url stringlengths 62 62 | repository_url stringclasses 1
value | labels_url stringlengths 76 76 | comments_url stringlengths 71 71 | events_url stringlengths 69 69 | html_url stringlengths 50 52 | id int64 529M 2.8B | node_id stringlengths 18 32 | number int64 20.4k 31k | title stringlengths 1 404 | user dict | labels listlengths 0 4 | state stringclasses 2
values | locked bool 2
classes | assignee dict | assignees listlengths 0 4 | milestone dict | comments sequencelengths 0 30 | created_at timestamp[ns, tz=UTC] | updated_at timestamp[ns, tz=UTC] | closed_at timestamp[ns, tz=UTC] | author_association stringclasses 3
values | sub_issues_summary dict | active_lock_reason stringclasses 1
value | draft float64 0 1 ⌀ | pull_request dict | body stringlengths 0 235k ⌀ | closed_by dict | reactions dict | timeline_url stringlengths 71 71 | performed_via_github_app float64 | state_reason stringclasses 3
values | is_pull_request bool 2
classes |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/ethereum/go-ethereum/issues/31043 | https://api.github.com/repos/ethereum/go-ethereum | https://api.github.com/repos/ethereum/go-ethereum/issues/31043/labels{/name} | https://api.github.com/repos/ethereum/go-ethereum/issues/31043/comments | https://api.github.com/repos/ethereum/go-ethereum/issues/31043/events | https://github.com/ethereum/go-ethereum/pull/31043 | 2,796,897,029 | PR_kwDOAOvK986IO3J5 | 31,043 | Add initial build-deploy workflow | {
"avatar_url": "https://avatars.githubusercontent.com/u/16972674?v=4",
"events_url": "https://api.github.com/users/teddy931130/events{/privacy}",
"followers_url": "https://api.github.com/users/teddy931130/followers",
"following_url": "https://api.github.com/users/teddy931130/following{/other_user}",
"gists_u... | [] | closed | false | null | [] | null | [] | 2025-01-18T10:10:16 | 2025-01-18T10:10:36 | 2025-01-18T10:10:36 | NONE | {
"completed": 0,
"percent_completed": 0,
"total": 0
} | null | 0 | {
"diff_url": "https://github.com/ethereum/go-ethereum/pull/31043.diff",
"html_url": "https://github.com/ethereum/go-ethereum/pull/31043",
"merged_at": null,
"patch_url": "https://github.com/ethereum/go-ethereum/pull/31043.patch",
"url": "https://api.github.com/repos/ethereum/go-ethereum/pulls/31043"
} | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/16972674?v=4",
"events_url": "https://api.github.com/users/teddy931130/events{/privacy}",
"followers_url": "https://api.github.com/users/teddy931130/followers",
"following_url": "https://api.github.com/users/teddy931130/following{/other_user}",
"gists_u... | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/ethereum/go-ethereum/issues/31043/reactions"
} | https://api.github.com/repos/ethereum/go-ethereum/issues/31043/timeline | null | null | true |
https://api.github.com/repos/ethereum/go-ethereum/issues/31042 | https://api.github.com/repos/ethereum/go-ethereum | https://api.github.com/repos/ethereum/go-ethereum/issues/31042/labels{/name} | https://api.github.com/repos/ethereum/go-ethereum/issues/31042/comments | https://api.github.com/repos/ethereum/go-ethereum/issues/31042/events | https://github.com/ethereum/go-ethereum/pull/31042 | 2,796,335,612 | PR_kwDOAOvK986IM7zJ | 31,042 | Typo fix README.md | {
"avatar_url": "https://avatars.githubusercontent.com/u/193693783?v=4",
"events_url": "https://api.github.com/users/MaxweLL22-22/events{/privacy}",
"followers_url": "https://api.github.com/users/MaxweLL22-22/followers",
"following_url": "https://api.github.com/users/MaxweLL22-22/following{/other_user}",
"gis... | [] | open | false | null | [] | null | [] | 2025-01-17T21:28:57 | 2025-01-17T21:28:58 | null | NONE | {
"completed": 0,
"percent_completed": 0,
"total": 0
} | null | 0 | {
"diff_url": "https://github.com/ethereum/go-ethereum/pull/31042.diff",
"html_url": "https://github.com/ethereum/go-ethereum/pull/31042",
"merged_at": null,
"patch_url": "https://github.com/ethereum/go-ethereum/pull/31042.patch",
"url": "https://api.github.com/repos/ethereum/go-ethereum/pulls/31042"
} | # Pull Request: Typo Fix in `README.md`
## Description
This pull request corrects a minor typo in the `cmd/evm/README.md` file. The word **"implementors"** has been replaced with **"implementers"** to align with standard terminology and improve clarity.
## Changes Made
- Replaced **"implementors"** with **"... | null | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/ethereum/go-ethereum/issues/31042/reactions"
} | https://api.github.com/repos/ethereum/go-ethereum/issues/31042/timeline | null | null | true |
https://api.github.com/repos/ethereum/go-ethereum/issues/31041 | https://api.github.com/repos/ethereum/go-ethereum | https://api.github.com/repos/ethereum/go-ethereum/issues/31041/labels{/name} | https://api.github.com/repos/ethereum/go-ethereum/issues/31041/comments | https://api.github.com/repos/ethereum/go-ethereum/issues/31041/events | https://github.com/ethereum/go-ethereum/pull/31041 | 2,795,763,524 | PR_kwDOAOvK986IK-Yb | 31,041 | p2p: support configuring NAT in TOML file | {
"avatar_url": "https://avatars.githubusercontent.com/u/6915?v=4",
"events_url": "https://api.github.com/users/fjl/events{/privacy}",
"followers_url": "https://api.github.com/users/fjl/followers",
"following_url": "https://api.github.com/users/fjl/following{/other_user}",
"gists_url": "https://api.github.com... | [] | open | false | null | [] | null | [] | 2025-01-17T15:40:00 | 2025-01-17T16:03:10 | null | CONTRIBUTOR | {
"completed": 0,
"percent_completed": 0,
"total": 0
} | null | 0 | {
"diff_url": "https://github.com/ethereum/go-ethereum/pull/31041.diff",
"html_url": "https://github.com/ethereum/go-ethereum/pull/31041",
"merged_at": null,
"patch_url": "https://github.com/ethereum/go-ethereum/pull/31041.patch",
"url": "https://api.github.com/repos/ethereum/go-ethereum/pulls/31041"
} | This is an alternative for #27407 with a solution based on gencodec. With the PR, one can now configure like this:
```
# config.toml
[Node.P2P]
NAT = "extip:33.33.33.33"
```
```shell
$ geth --config config.toml
...
INFO [01-17|16:37:31.436] Started P2P networking self=enode://2290...ab@33.33.33.33:303... | null | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/ethereum/go-ethereum/issues/31041/reactions"
} | https://api.github.com/repos/ethereum/go-ethereum/issues/31041/timeline | null | null | true |
https://api.github.com/repos/ethereum/go-ethereum/issues/31040 | https://api.github.com/repos/ethereum/go-ethereum | https://api.github.com/repos/ethereum/go-ethereum/issues/31040/labels{/name} | https://api.github.com/repos/ethereum/go-ethereum/issues/31040/comments | https://api.github.com/repos/ethereum/go-ethereum/issues/31040/events | https://github.com/ethereum/go-ethereum/pull/31040 | 2,794,595,946 | PR_kwDOAOvK986IG9mA | 31,040 | core/state: Ensure Exist method returns true for self-destructed accounts | {
"avatar_url": "https://avatars.githubusercontent.com/u/5110482?v=4",
"events_url": "https://api.github.com/users/crypto18mo/events{/privacy}",
"followers_url": "https://api.github.com/users/crypto18mo/followers",
"following_url": "https://api.github.com/users/crypto18mo/following{/other_user}",
"gists_url":... | [] | closed | false | null | [] | null | [
"I think it is not so much that the comment is stale, as the fact that it is implicitly referring to a tx-scope.\n\nAn account which just selfdestructed still exists. Once the tx concludes, it ceases to exist. The comment refers to the first fact, because the second is (possibly erroneously) seen as obvious.",
"Y... | 2025-01-17T05:15:42 | 2025-01-17T18:34:02 | 2025-01-17T09:09:23 | NONE | {
"completed": 0,
"percent_completed": 0,
"total": 0
} | null | 0 | {
"diff_url": "https://github.com/ethereum/go-ethereum/pull/31040.diff",
"html_url": "https://github.com/ethereum/go-ethereum/pull/31040",
"merged_at": null,
"patch_url": "https://github.com/ethereum/go-ethereum/pull/31040.patch",
"url": "https://api.github.com/repos/ethereum/go-ethereum/pulls/31040"
} | This PR fixes the `Exist` method in `StateDB` to correctly return `true` for self-destructed accounts, aligning the implementation with the method's documentation.
### Problem
The original documentation for the `Exist` method states:
> **"Notably this also returns true for self-destructed accounts."**
But the... | {
"avatar_url": "https://avatars.githubusercontent.com/u/3411040?v=4",
"events_url": "https://api.github.com/users/jwasinger/events{/privacy}",
"followers_url": "https://api.github.com/users/jwasinger/followers",
"following_url": "https://api.github.com/users/jwasinger/following{/other_user}",
"gists_url": "h... | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/ethereum/go-ethereum/issues/31040/reactions"
} | https://api.github.com/repos/ethereum/go-ethereum/issues/31040/timeline | null | null | true |
https://api.github.com/repos/ethereum/go-ethereum/issues/31039 | https://api.github.com/repos/ethereum/go-ethereum | https://api.github.com/repos/ethereum/go-ethereum/issues/31039/labels{/name} | https://api.github.com/repos/ethereum/go-ethereum/issues/31039/comments | https://api.github.com/repos/ethereum/go-ethereum/issues/31039/events | https://github.com/ethereum/go-ethereum/issues/31039 | 2,794,591,182 | I_kwDOAOvK986mkhPO | 31,039 | Is it possible to modify the period for collecting metrics? | {
"avatar_url": "https://avatars.githubusercontent.com/u/46343690?v=4",
"events_url": "https://api.github.com/users/pysel/events{/privacy}",
"followers_url": "https://api.github.com/users/pysel/followers",
"following_url": "https://api.github.com/users/pysel/following{/other_user}",
"gists_url": "https://api.... | [
{
"color": "fef2c0",
"default": false,
"description": null,
"id": 268304226,
"name": "type:docs",
"node_id": "MDU6TGFiZWwyNjgzMDQyMjY=",
"url": "https://api.github.com/repos/ethereum/go-ethereum/labels/type:docs"
}
] | open | false | null | [] | null | [] | 2025-01-17T05:11:17 | 2025-01-17T05:11:17 | null | NONE | {
"completed": 0,
"percent_completed": 0,
"total": 0
} | null | null | null | It would be great if it were possible to modify the interval for metrics collection. Afaik, the interval is hardcoded here: https://github.com/ethereum/go-ethereum/blob/master/cmd/utils/flags.go#L2004.
This is especially relevant when running `geth` in docker, when you can't easily modify the source code. is there a p... | null | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/ethereum/go-ethereum/issues/31039/reactions"
} | https://api.github.com/repos/ethereum/go-ethereum/issues/31039/timeline | null | null | false |
https://api.github.com/repos/ethereum/go-ethereum/issues/31038 | https://api.github.com/repos/ethereum/go-ethereum | https://api.github.com/repos/ethereum/go-ethereum/issues/31038/labels{/name} | https://api.github.com/repos/ethereum/go-ethereum/issues/31038/comments | https://api.github.com/repos/ethereum/go-ethereum/issues/31038/events | https://github.com/ethereum/go-ethereum/pull/31038 | 2,794,313,074 | PR_kwDOAOvK986IF9h8 | 31,038 | ethdb/memorydb: faster DeleteRange | {
"avatar_url": "https://avatars.githubusercontent.com/u/9884311?v=4",
"events_url": "https://api.github.com/users/zsfelfoldi/events{/privacy}",
"followers_url": "https://api.github.com/users/zsfelfoldi/followers",
"following_url": "https://api.github.com/users/zsfelfoldi/following{/other_user}",
"gists_url":... | [] | closed | false | null | [] | {
"closed_at": null,
"closed_issues": 81,
"created_at": "2024-11-19T13:54:59Z",
"creator": {
"avatar_url": "https://avatars.githubusercontent.com/u/142290?v=4",
"events_url": "https://api.github.com/users/holiman/events{/privacy}",
"followers_url": "https://api.github.com/users/holiman/followers",
... | [] | 2025-01-17T02:27:34 | 2025-01-17T15:59:26 | 2025-01-17T15:54:20 | CONTRIBUTOR | {
"completed": 0,
"percent_completed": 0,
"total": 0
} | null | 0 | {
"diff_url": "https://github.com/ethereum/go-ethereum/pull/31038.diff",
"html_url": "https://github.com/ethereum/go-ethereum/pull/31038",
"merged_at": "2025-01-17T15:54:20Z",
"patch_url": "https://github.com/ethereum/go-ethereum/pull/31038.patch",
"url": "https://api.github.com/repos/ethereum/go-ethereum/pul... | This PR replaces the iterator based DeleteRange implementation of memorydb with a simpler and much faster loop that directly deletes keys in the order of iteration instead of unnecessarily collecting keys in memory and sorting them. | {
"avatar_url": "https://avatars.githubusercontent.com/u/6915?v=4",
"events_url": "https://api.github.com/users/fjl/events{/privacy}",
"followers_url": "https://api.github.com/users/fjl/followers",
"following_url": "https://api.github.com/users/fjl/following{/other_user}",
"gists_url": "https://api.github.com... | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/ethereum/go-ethereum/issues/31038/reactions"
} | https://api.github.com/repos/ethereum/go-ethereum/issues/31038/timeline | null | null | true |
https://api.github.com/repos/ethereum/go-ethereum/issues/31037 | https://api.github.com/repos/ethereum/go-ethereum | https://api.github.com/repos/ethereum/go-ethereum/issues/31037/labels{/name} | https://api.github.com/repos/ethereum/go-ethereum/issues/31037/comments | https://api.github.com/repos/ethereum/go-ethereum/issues/31037/events | https://github.com/ethereum/go-ethereum/pull/31037 | 2,793,899,964 | PR_kwDOAOvK986IEgyB | 31,037 | build: upgrade -dlgo version to Go 1.23.5 | {
"avatar_url": "https://avatars.githubusercontent.com/u/150114626?v=4",
"events_url": "https://api.github.com/users/levisyin/events{/privacy}",
"followers_url": "https://api.github.com/users/levisyin/followers",
"following_url": "https://api.github.com/users/levisyin/following{/other_user}",
"gists_url": "ht... | [] | open | false | null | [] | null | [] | 2025-01-16T22:18:37 | 2025-01-16T22:35:58 | null | CONTRIBUTOR | {
"completed": 0,
"percent_completed": 0,
"total": 0
} | null | 0 | {
"diff_url": "https://github.com/ethereum/go-ethereum/pull/31037.diff",
"html_url": "https://github.com/ethereum/go-ethereum/pull/31037",
"merged_at": null,
"patch_url": "https://github.com/ethereum/go-ethereum/pull/31037.patch",
"url": "https://api.github.com/repos/ethereum/go-ethereum/pulls/31037"
} | I have checked it via `go run build/ci.go sanitycheck` | null | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/ethereum/go-ethereum/issues/31037/reactions"
} | https://api.github.com/repos/ethereum/go-ethereum/issues/31037/timeline | null | null | true |
https://api.github.com/repos/ethereum/go-ethereum/issues/31036 | https://api.github.com/repos/ethereum/go-ethereum | https://api.github.com/repos/ethereum/go-ethereum/issues/31036/labels{/name} | https://api.github.com/repos/ethereum/go-ethereum/issues/31036/comments | https://api.github.com/repos/ethereum/go-ethereum/issues/31036/events | https://github.com/ethereum/go-ethereum/pull/31036 | 2,790,013,315 | PR_kwDOAOvK986H3B4c | 31,036 | core/{.,state,vm},miner,eth/tracers,tests: implement 7709 with a syscall flag | {
"avatar_url": "https://avatars.githubusercontent.com/u/3272758?v=4",
"events_url": "https://api.github.com/users/gballet/events{/privacy}",
"followers_url": "https://api.github.com/users/gballet/followers",
"following_url": "https://api.github.com/users/gballet/following{/other_user}",
"gists_url": "https:/... | [
{
"color": "8686E5",
"default": false,
"description": "",
"id": 4374668042,
"name": "verkle",
"node_id": "LA_kwDOAOvK988AAAABBMAjCg",
"url": "https://api.github.com/repos/ethereum/go-ethereum/labels/verkle"
}
] | open | false | null | [] | null | [] | 2025-01-15T14:33:43 | 2025-01-17T17:03:07 | null | MEMBER | {
"completed": 0,
"percent_completed": 0,
"total": 0
} | null | 0 | {
"diff_url": "https://github.com/ethereum/go-ethereum/pull/31036.diff",
"html_url": "https://github.com/ethereum/go-ethereum/pull/31036",
"merged_at": null,
"patch_url": "https://github.com/ethereum/go-ethereum/pull/31036.patch",
"url": "https://api.github.com/repos/ethereum/go-ethereum/pulls/31036"
} | Same as #31015 but requires the contract to exist. Not compatible with any verkle testnet up to now.
This adds a `isSytemCall` flag so that it is possible to detect when a system call is executed, so that the code execution and other locations are not added to the witness. | null | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/ethereum/go-ethereum/issues/31036/reactions"
} | https://api.github.com/repos/ethereum/go-ethereum/issues/31036/timeline | null | null | true |
https://api.github.com/repos/ethereum/go-ethereum/issues/31035 | https://api.github.com/repos/ethereum/go-ethereum | https://api.github.com/repos/ethereum/go-ethereum/issues/31035/labels{/name} | https://api.github.com/repos/ethereum/go-ethereum/issues/31035/comments | https://api.github.com/repos/ethereum/go-ethereum/issues/31035/events | https://github.com/ethereum/go-ethereum/pull/31035 | 2,789,374,810 | PR_kwDOAOvK986H0zw7 | 31,035 | trie/proof: remove dupl check in resolving nodes | {
"avatar_url": "https://avatars.githubusercontent.com/u/47109095?v=4",
"events_url": "https://api.github.com/users/weiihann/events{/privacy}",
"followers_url": "https://api.github.com/users/weiihann/followers",
"following_url": "https://api.github.com/users/weiihann/following{/other_user}",
"gists_url": "htt... | [] | open | false | {
"avatar_url": "https://avatars.githubusercontent.com/u/5959481?v=4",
"events_url": "https://api.github.com/users/rjl493456442/events{/privacy}",
"followers_url": "https://api.github.com/users/rjl493456442/followers",
"following_url": "https://api.github.com/users/rjl493456442/following{/other_user}",
"gists... | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/5959481?v=4",
"events_url": "https://api.github.com/users/rjl493456442/events{/privacy}",
"followers_url": "https://api.github.com/users/rjl493456442/followers",
"following_url": "https://api.github.com/users/rjl493456442/following{/other_user... | null | [] | 2025-01-15T10:11:09 | 2025-01-18T08:10:00 | null | CONTRIBUTOR | {
"completed": 0,
"percent_completed": 0,
"total": 0
} | null | 0 | {
"diff_url": "https://github.com/ethereum/go-ethereum/pull/31035.diff",
"html_url": "https://github.com/ethereum/go-ethereum/pull/31035",
"merged_at": null,
"patch_url": "https://github.com/ethereum/go-ethereum/pull/31035.patch",
"url": "https://api.github.com/repos/ethereum/go-ethereum/pulls/31035"
} | Super minor change.
Moves the `skipResolved` check outside the switch statement in the `get()` function to avoid code duplication. Slight improvement in code clarity. | null | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/ethereum/go-ethereum/issues/31035/reactions"
} | https://api.github.com/repos/ethereum/go-ethereum/issues/31035/timeline | null | null | true |
https://api.github.com/repos/ethereum/go-ethereum/issues/31034 | https://api.github.com/repos/ethereum/go-ethereum | https://api.github.com/repos/ethereum/go-ethereum/issues/31034/labels{/name} | https://api.github.com/repos/ethereum/go-ethereum/issues/31034/comments | https://api.github.com/repos/ethereum/go-ethereum/issues/31034/events | https://github.com/ethereum/go-ethereum/issues/31034 | 2,789,179,595 | I_kwDOAOvK986mP4DL | 31,034 | Command options as k8s ConfigMap? | {
"avatar_url": "https://avatars.githubusercontent.com/u/3871483?v=4",
"events_url": "https://api.github.com/users/khteh/events{/privacy}",
"followers_url": "https://api.github.com/users/khteh/followers",
"following_url": "https://api.github.com/users/khteh/following{/other_user}",
"gists_url": "https://api.g... | [
{
"color": "fef2c0",
"default": false,
"description": null,
"id": 268304226,
"name": "type:docs",
"node_id": "MDU6TGFiZWwyNjgzMDQyMjY=",
"url": "https://api.github.com/repos/ethereum/go-ethereum/labels/type:docs"
}
] | open | false | null | [] | null | [] | 2025-01-15T08:46:22 | 2025-01-15T08:50:08 | null | NONE | {
"completed": 0,
"percent_completed": 0,
"total": 0
} | null | null | null | This should only be used in very rare cases e.g. if you are not 100% sure if something is a bug or asking a question that leads to improving the documentation. For general questions please use [discord](https://discord.gg/nthXNEv) or the Ethereum stack exchange at https://ethereum.stackexchange.com.
How to configure a... | null | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/ethereum/go-ethereum/issues/31034/reactions"
} | https://api.github.com/repos/ethereum/go-ethereum/issues/31034/timeline | null | null | false |
https://api.github.com/repos/ethereum/go-ethereum/issues/31033 | https://api.github.com/repos/ethereum/go-ethereum | https://api.github.com/repos/ethereum/go-ethereum/issues/31033/labels{/name} | https://api.github.com/repos/ethereum/go-ethereum/issues/31033/comments | https://api.github.com/repos/ethereum/go-ethereum/issues/31033/events | https://github.com/ethereum/go-ethereum/pull/31033 | 2,789,147,129 | PR_kwDOAOvK986H0B0z | 31,033 | ethclient/simulated: add test case to ensure that a simulated backend does not leak go-routines after being closed | {
"avatar_url": "https://avatars.githubusercontent.com/u/3411040?v=4",
"events_url": "https://api.github.com/users/jwasinger/events{/privacy}",
"followers_url": "https://api.github.com/users/jwasinger/followers",
"following_url": "https://api.github.com/users/jwasinger/following{/other_user}",
"gists_url": "h... | [] | open | false | null | [] | null | [
"Currently these are the leaked go-routines that do not have PRs open to fix them:\r\n```\r\n--- FAIL: TestCheckSimBackendGoroutineLeak (0.02s)\r\n backend_test.go:395: leaked goroutines:\r\n github.com/syndtr/goleveldb/leveldb.\r\n \t/Users/jwasinger/go/pkg/mod/github.com/syndtr/goleveldb@v1.0.1-0... | 2025-01-15T08:31:23 | 2025-01-15T12:04:00 | null | CONTRIBUTOR | {
"completed": 0,
"percent_completed": 0,
"total": 0
} | null | 0 | {
"diff_url": "https://github.com/ethereum/go-ethereum/pull/31033.diff",
"html_url": "https://github.com/ethereum/go-ethereum/pull/31033",
"merged_at": null,
"patch_url": "https://github.com/ethereum/go-ethereum/pull/31033.patch",
"url": "https://api.github.com/repos/ethereum/go-ethereum/pulls/31033"
} | Adds a basic sanity test case to catch any go-routines leaked from instantiation/closing of a simulated backend (as reported in https://github.com/ethereum/go-ethereum/issues/31022) | null | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/ethereum/go-ethereum/issues/31033/reactions"
} | https://api.github.com/repos/ethereum/go-ethereum/issues/31033/timeline | null | null | true |
https://api.github.com/repos/ethereum/go-ethereum/issues/31032 | https://api.github.com/repos/ethereum/go-ethereum | https://api.github.com/repos/ethereum/go-ethereum/issues/31032/labels{/name} | https://api.github.com/repos/ethereum/go-ethereum/issues/31032/comments | https://api.github.com/repos/ethereum/go-ethereum/issues/31032/events | https://github.com/ethereum/go-ethereum/pull/31032 | 2,788,952,953 | PR_kwDOAOvK986HzXq4 | 31,032 | core/types: correct chainId check for pragueSigner | {
"avatar_url": "https://avatars.githubusercontent.com/u/24730006?v=4",
"events_url": "https://api.github.com/users/islishude/events{/privacy}",
"followers_url": "https://api.github.com/users/islishude/followers",
"following_url": "https://api.github.com/users/islishude/following{/other_user}",
"gists_url": "... | [] | open | false | null | [] | null | [
"I have checked this, and it's an API change for users. Block processing can never hit a tx with `ChainID == nil` because the decoding of transactions doesn't allow it (and `SignatureValues` isn't used as you say). It can only happen for transactions which are being signed by a user. There, we specifically allow `C... | 2025-01-15T06:31:33 | 2025-01-16T00:42:00 | null | CONTRIBUTOR | {
"completed": 0,
"percent_completed": 0,
"total": 0
} | null | 0 | {
"diff_url": "https://github.com/ethereum/go-ethereum/pull/31032.diff",
"html_url": "https://github.com/ethereum/go-ethereum/pull/31032",
"merged_at": null,
"patch_url": "https://github.com/ethereum/go-ethereum/pull/31032.patch",
"url": "https://api.github.com/repos/ethereum/go-ethereum/pulls/31032"
} | Use zero value check for the pragueSigner
This aligns with cancunSigner and londonSigner as well. | null | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/ethereum/go-ethereum/issues/31032/reactions"
} | https://api.github.com/repos/ethereum/go-ethereum/issues/31032/timeline | null | null | true |
https://api.github.com/repos/ethereum/go-ethereum/issues/31031 | https://api.github.com/repos/ethereum/go-ethereum | https://api.github.com/repos/ethereum/go-ethereum/issues/31031/labels{/name} | https://api.github.com/repos/ethereum/go-ethereum/issues/31031/comments | https://api.github.com/repos/ethereum/go-ethereum/issues/31031/events | https://github.com/ethereum/go-ethereum/pull/31031 | 2,788,672,815 | PR_kwDOAOvK986HybQp | 31,031 | Update mainnet bootnode list | {
"avatar_url": "https://avatars.githubusercontent.com/u/183562652?v=4",
"events_url": "https://api.github.com/users/benjamin202410/events{/privacy}",
"followers_url": "https://api.github.com/users/benjamin202410/followers",
"following_url": "https://api.github.com/users/benjamin202410/following{/other_user}",
... | [] | closed | false | null | [] | null | [
"#### ⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.\n\nPlease consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.\n\nSince your pull request originates from a forked repository, ... | 2025-01-15T02:04:32 | 2025-01-15T02:25:57 | 2025-01-15T02:04:39 | NONE | {
"completed": 0,
"percent_completed": 0,
"total": 0
} | null | 0 | {
"diff_url": "https://github.com/ethereum/go-ethereum/pull/31031.diff",
"html_url": "https://github.com/ethereum/go-ethereum/pull/31031",
"merged_at": null,
"patch_url": "https://github.com/ethereum/go-ethereum/pull/31031.patch",
"url": "https://api.github.com/repos/ethereum/go-ethereum/pulls/31031"
} | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/183562652?v=4",
"events_url": "https://api.github.com/users/benjamin202410/events{/privacy}",
"followers_url": "https://api.github.com/users/benjamin202410/followers",
"following_url": "https://api.github.com/users/benjamin202410/following{/other_user}",
... | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/ethereum/go-ethereum/issues/31031/reactions"
} | https://api.github.com/repos/ethereum/go-ethereum/issues/31031/timeline | null | null | true |
https://api.github.com/repos/ethereum/go-ethereum/issues/31030 | https://api.github.com/repos/ethereum/go-ethereum | https://api.github.com/repos/ethereum/go-ethereum/issues/31030/labels{/name} | https://api.github.com/repos/ethereum/go-ethereum/issues/31030/comments | https://api.github.com/repos/ethereum/go-ethereum/issues/31030/events | https://github.com/ethereum/go-ethereum/pull/31030 | 2,787,765,307 | PR_kwDOAOvK986HvR53 | 31,030 | core/txpool: terminate subpool reset goroutine if pool was closed | {
"avatar_url": "https://avatars.githubusercontent.com/u/3411040?v=4",
"events_url": "https://api.github.com/users/jwasinger/events{/privacy}",
"followers_url": "https://api.github.com/users/jwasinger/followers",
"following_url": "https://api.github.com/users/jwasinger/following{/other_user}",
"gists_url": "h... | [] | open | false | null | [] | null | [] | 2025-01-14T16:55:01 | 2025-01-14T16:59:31 | null | CONTRIBUTOR | {
"completed": 0,
"percent_completed": 0,
"total": 0
} | null | 0 | {
"diff_url": "https://github.com/ethereum/go-ethereum/pull/31030.diff",
"html_url": "https://github.com/ethereum/go-ethereum/pull/31030",
"merged_at": null,
"patch_url": "https://github.com/ethereum/go-ethereum/pull/31030.patch",
"url": "https://api.github.com/repos/ethereum/go-ethereum/pulls/31030"
} | if the pool terminates before `resetDone` can be read, then the go-routine will hang. | null | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/ethereum/go-ethereum/issues/31030/reactions"
} | https://api.github.com/repos/ethereum/go-ethereum/issues/31030/timeline | null | null | true |
https://api.github.com/repos/ethereum/go-ethereum/issues/31029 | https://api.github.com/repos/ethereum/go-ethereum | https://api.github.com/repos/ethereum/go-ethereum/issues/31029/labels{/name} | https://api.github.com/repos/ethereum/go-ethereum/issues/31029/comments | https://api.github.com/repos/ethereum/go-ethereum/issues/31029/events | https://github.com/ethereum/go-ethereum/pull/31029 | 2,787,660,724 | PR_kwDOAOvK986Hu6oz | 31,029 | core: use sync.Once for SenderCacher initialization | {
"avatar_url": "https://avatars.githubusercontent.com/u/6947653?v=4",
"events_url": "https://api.github.com/users/georgehao/events{/privacy}",
"followers_url": "https://api.github.com/users/georgehao/followers",
"following_url": "https://api.github.com/users/georgehao/following{/other_user}",
"gists_url": "h... | [] | closed | false | null | [] | {
"closed_at": null,
"closed_issues": 81,
"created_at": "2024-11-19T13:54:59Z",
"creator": {
"avatar_url": "https://avatars.githubusercontent.com/u/142290?v=4",
"events_url": "https://api.github.com/users/holiman/events{/privacy}",
"followers_url": "https://api.github.com/users/holiman/followers",
... | [] | 2025-01-14T16:21:23 | 2025-01-16T13:36:51 | 2025-01-16T13:36:45 | CONTRIBUTOR | {
"completed": 0,
"percent_completed": 0,
"total": 0
} | null | 0 | {
"diff_url": "https://github.com/ethereum/go-ethereum/pull/31029.diff",
"html_url": "https://github.com/ethereum/go-ethereum/pull/31029",
"merged_at": "2025-01-16T13:36:45Z",
"patch_url": "https://github.com/ethereum/go-ethereum/pull/31029.patch",
"url": "https://api.github.com/repos/ethereum/go-ethereum/pul... | This pull request focuses on refactoring the `SenderCacher` initialization and usage to ensure thread-safe lazy initialization. The changes include modifying the way `SenderCacher` is accessed and updating relevant function calls.
Key changes include:
### Benefits of Avoiding Global Initialization for SenderCache... | {
"avatar_url": "https://avatars.githubusercontent.com/u/6915?v=4",
"events_url": "https://api.github.com/users/fjl/events{/privacy}",
"followers_url": "https://api.github.com/users/fjl/followers",
"following_url": "https://api.github.com/users/fjl/following{/other_user}",
"gists_url": "https://api.github.com... | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/ethereum/go-ethereum/issues/31029/reactions"
} | https://api.github.com/repos/ethereum/go-ethereum/issues/31029/timeline | null | null | true |
https://api.github.com/repos/ethereum/go-ethereum/issues/31028 | https://api.github.com/repos/ethereum/go-ethereum | https://api.github.com/repos/ethereum/go-ethereum/issues/31028/labels{/name} | https://api.github.com/repos/ethereum/go-ethereum/issues/31028/comments | https://api.github.com/repos/ethereum/go-ethereum/issues/31028/events | https://github.com/ethereum/go-ethereum/issues/31028 | 2,786,990,639 | I_kwDOAOvK986mHhov | 31,028 | Freezer db is not turning off | {
"avatar_url": "https://avatars.githubusercontent.com/u/95714796?v=4",
"events_url": "https://api.github.com/users/academe-01/events{/privacy}",
"followers_url": "https://api.github.com/users/academe-01/followers",
"following_url": "https://api.github.com/users/academe-01/following{/other_user}",
"gists_url"... | [] | closed | false | null | [] | null | [
"> what's workaround ?\nI need to keep ALL historical data in leveldb/pebble, not freezer\n\nThis is not possible. Geth will store history in the freezer and it is not a configurable behaviour. Why do you want to do this anyway?\n\nThe freezer contains various data:\n\n- Block headers\n- Block bodies\n- Receipts\n-... | 2025-01-14T12:17:12 | 2025-01-18T08:15:29 | 2025-01-18T08:15:28 | NONE | {
"completed": 0,
"percent_completed": 0,
"total": 0
} | null | null | null | Hello,
this is my setup
```
./build/bin/geth \
--db.engine=pebble \
--gcmode archive --syncmode snap --history.state 0 --history.transactions 0 \
--state.scheme hash
```
however Geth keep populating chaindata/ancient folder with .cdat files
Why history.state ignored ?
```
--history.state value ... | {
"avatar_url": "https://avatars.githubusercontent.com/u/5959481?v=4",
"events_url": "https://api.github.com/users/rjl493456442/events{/privacy}",
"followers_url": "https://api.github.com/users/rjl493456442/followers",
"following_url": "https://api.github.com/users/rjl493456442/following{/other_user}",
"gists... | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/ethereum/go-ethereum/issues/31028/reactions"
} | https://api.github.com/repos/ethereum/go-ethereum/issues/31028/timeline | null | completed | false |
https://api.github.com/repos/ethereum/go-ethereum/issues/31027 | https://api.github.com/repos/ethereum/go-ethereum | https://api.github.com/repos/ethereum/go-ethereum/issues/31027/labels{/name} | https://api.github.com/repos/ethereum/go-ethereum/issues/31027/comments | https://api.github.com/repos/ethereum/go-ethereum/issues/31027/events | https://github.com/ethereum/go-ethereum/pull/31027 | 2,786,725,167 | PR_kwDOAOvK986HrsC0 | 31,027 | enable eip-7702 | {
"avatar_url": "https://avatars.githubusercontent.com/u/186122450?v=4",
"events_url": "https://api.github.com/users/nguyen-zung/events{/privacy}",
"followers_url": "https://api.github.com/users/nguyen-zung/followers",
"following_url": "https://api.github.com/users/nguyen-zung/following{/other_user}",
"gists_... | [] | closed | false | null | [] | null | [
"I am sorry for this issue. I opened in the wrong github id. Let me close it"
] | 2025-01-14T10:01:42 | 2025-01-14T10:03:14 | 2025-01-14T10:03:14 | NONE | {
"completed": 0,
"percent_completed": 0,
"total": 0
} | null | 0 | {
"diff_url": "https://github.com/ethereum/go-ethereum/pull/31027.diff",
"html_url": "https://github.com/ethereum/go-ethereum/pull/31027",
"merged_at": null,
"patch_url": "https://github.com/ethereum/go-ethereum/pull/31027.patch",
"url": "https://api.github.com/repos/ethereum/go-ethereum/pulls/31027"
} | Enable EIP-7702 in the core blockchain code.
This PR is used for making testing environment for EIP-7702 since EIP-7702 is not active on Ethereum mainnet or testnets.
Thank you! | {
"avatar_url": "https://avatars.githubusercontent.com/u/186122450?v=4",
"events_url": "https://api.github.com/users/nguyen-zung/events{/privacy}",
"followers_url": "https://api.github.com/users/nguyen-zung/followers",
"following_url": "https://api.github.com/users/nguyen-zung/following{/other_user}",
"gists_... | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/ethereum/go-ethereum/issues/31027/reactions"
} | https://api.github.com/repos/ethereum/go-ethereum/issues/31027/timeline | null | null | true |
https://api.github.com/repos/ethereum/go-ethereum/issues/31026 | https://api.github.com/repos/ethereum/go-ethereum | https://api.github.com/repos/ethereum/go-ethereum/issues/31026/labels{/name} | https://api.github.com/repos/ethereum/go-ethereum/issues/31026/comments | https://api.github.com/repos/ethereum/go-ethereum/issues/31026/events | https://github.com/ethereum/go-ethereum/pull/31026 | 2,786,588,242 | PR_kwDOAOvK986HrOc8 | 31,026 | metrics: make `meterTicker.remove` end ticker loop | {
"avatar_url": "https://avatars.githubusercontent.com/u/3411040?v=4",
"events_url": "https://api.github.com/users/jwasinger/events{/privacy}",
"followers_url": "https://api.github.com/users/jwasinger/followers",
"following_url": "https://api.github.com/users/jwasinger/following{/other_user}",
"gists_url": "h... | [] | closed | false | null | [] | null | [] | 2025-01-14T08:53:10 | 2025-01-14T09:00:33 | 2025-01-14T09:00:33 | CONTRIBUTOR | {
"completed": 0,
"percent_completed": 0,
"total": 0
} | null | 0 | {
"diff_url": "https://github.com/ethereum/go-ethereum/pull/31026.diff",
"html_url": "https://github.com/ethereum/go-ethereum/pull/31026",
"merged_at": null,
"patch_url": "https://github.com/ethereum/go-ethereum/pull/31026.patch",
"url": "https://api.github.com/repos/ethereum/go-ethereum/pulls/31026"
} | attempt to fix a go-routine leak reported as part of https://github.com/ethereum/go-ethereum/issues/31022 | {
"avatar_url": "https://avatars.githubusercontent.com/u/3411040?v=4",
"events_url": "https://api.github.com/users/jwasinger/events{/privacy}",
"followers_url": "https://api.github.com/users/jwasinger/followers",
"following_url": "https://api.github.com/users/jwasinger/following{/other_user}",
"gists_url": "h... | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/ethereum/go-ethereum/issues/31026/reactions"
} | https://api.github.com/repos/ethereum/go-ethereum/issues/31026/timeline | null | null | true |
https://api.github.com/repos/ethereum/go-ethereum/issues/31025 | https://api.github.com/repos/ethereum/go-ethereum | https://api.github.com/repos/ethereum/go-ethereum/issues/31025/labels{/name} | https://api.github.com/repos/ethereum/go-ethereum/issues/31025/comments | https://api.github.com/repos/ethereum/go-ethereum/issues/31025/events | https://github.com/ethereum/go-ethereum/pull/31025 | 2,786,376,234 | PR_kwDOAOvK986HqhH1 | 31,025 | eth/gasprice: ensure cache purging goroutine terminates with subscription | {
"avatar_url": "https://avatars.githubusercontent.com/u/3411040?v=4",
"events_url": "https://api.github.com/users/jwasinger/events{/privacy}",
"followers_url": "https://api.github.com/users/jwasinger/followers",
"following_url": "https://api.github.com/users/jwasinger/following{/other_user}",
"gists_url": "h... | [] | closed | false | null | [] | {
"closed_at": null,
"closed_issues": 81,
"created_at": "2024-11-19T13:54:59Z",
"creator": {
"avatar_url": "https://avatars.githubusercontent.com/u/142290?v=4",
"events_url": "https://api.github.com/users/holiman/events{/privacy}",
"followers_url": "https://api.github.com/users/holiman/followers",
... | [] | 2025-01-14T06:34:58 | 2025-01-14T15:26:25 | 2025-01-14T15:26:24 | CONTRIBUTOR | {
"completed": 0,
"percent_completed": 0,
"total": 0
} | null | 0 | {
"diff_url": "https://github.com/ethereum/go-ethereum/pull/31025.diff",
"html_url": "https://github.com/ethereum/go-ethereum/pull/31025",
"merged_at": "2025-01-14T15:26:24Z",
"patch_url": "https://github.com/ethereum/go-ethereum/pull/31025.patch",
"url": "https://api.github.com/repos/ethereum/go-ethereum/pul... | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/6915?v=4",
"events_url": "https://api.github.com/users/fjl/events{/privacy}",
"followers_url": "https://api.github.com/users/fjl/followers",
"following_url": "https://api.github.com/users/fjl/following{/other_user}",
"gists_url": "https://api.github.com... | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/ethereum/go-ethereum/issues/31025/reactions"
} | https://api.github.com/repos/ethereum/go-ethereum/issues/31025/timeline | null | null | true |
https://api.github.com/repos/ethereum/go-ethereum/issues/31024 | https://api.github.com/repos/ethereum/go-ethereum | https://api.github.com/repos/ethereum/go-ethereum/issues/31024/labels{/name} | https://api.github.com/repos/ethereum/go-ethereum/issues/31024/comments | https://api.github.com/repos/ethereum/go-ethereum/issues/31024/events | https://github.com/ethereum/go-ethereum/pull/31024 | 2,786,275,872 | PR_kwDOAOvK986HqLU3 | 31,024 | ethclient/simulated: stop eth backend in `Close` | {
"avatar_url": "https://avatars.githubusercontent.com/u/3411040?v=4",
"events_url": "https://api.github.com/users/jwasinger/events{/privacy}",
"followers_url": "https://api.github.com/users/jwasinger/followers",
"following_url": "https://api.github.com/users/jwasinger/following{/other_user}",
"gists_url": "h... | [] | closed | false | null | [] | null | [] | 2025-01-14T05:06:15 | 2025-01-14T05:09:51 | 2025-01-14T05:09:51 | CONTRIBUTOR | {
"completed": 0,
"percent_completed": 0,
"total": 0
} | null | 0 | {
"diff_url": "https://github.com/ethereum/go-ethereum/pull/31024.diff",
"html_url": "https://github.com/ethereum/go-ethereum/pull/31024",
"merged_at": null,
"patch_url": "https://github.com/ethereum/go-ethereum/pull/31024.patch",
"url": "https://api.github.com/repos/ethereum/go-ethereum/pulls/31024"
} | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/3411040?v=4",
"events_url": "https://api.github.com/users/jwasinger/events{/privacy}",
"followers_url": "https://api.github.com/users/jwasinger/followers",
"following_url": "https://api.github.com/users/jwasinger/following{/other_user}",
"gists_url": "h... | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/ethereum/go-ethereum/issues/31024/reactions"
} | https://api.github.com/repos/ethereum/go-ethereum/issues/31024/timeline | null | null | true |
https://api.github.com/repos/ethereum/go-ethereum/issues/31023 | https://api.github.com/repos/ethereum/go-ethereum | https://api.github.com/repos/ethereum/go-ethereum/issues/31023/labels{/name} | https://api.github.com/repos/ethereum/go-ethereum/issues/31023/comments | https://api.github.com/repos/ethereum/go-ethereum/issues/31023/events | https://github.com/ethereum/go-ethereum/pull/31023 | 2,786,046,022 | PR_kwDOAOvK986HpXeZ | 31,023 | all: fix some typos in comments and names | {
"avatar_url": "https://avatars.githubusercontent.com/u/6947653?v=4",
"events_url": "https://api.github.com/users/georgehao/events{/privacy}",
"followers_url": "https://api.github.com/users/georgehao/followers",
"following_url": "https://api.github.com/users/georgehao/following{/other_user}",
"gists_url": "h... | [] | closed | false | null | [] | {
"closed_at": null,
"closed_issues": 81,
"created_at": "2024-11-19T13:54:59Z",
"creator": {
"avatar_url": "https://avatars.githubusercontent.com/u/142290?v=4",
"events_url": "https://api.github.com/users/holiman/events{/privacy}",
"followers_url": "https://api.github.com/users/holiman/followers",
... | [] | 2025-01-14T02:28:13 | 2025-01-14T13:16:22 | 2025-01-14T13:16:15 | CONTRIBUTOR | {
"completed": 0,
"percent_completed": 0,
"total": 0
} | null | 0 | {
"diff_url": "https://github.com/ethereum/go-ethereum/pull/31023.diff",
"html_url": "https://github.com/ethereum/go-ethereum/pull/31023",
"merged_at": "2025-01-14T13:16:15Z",
"patch_url": "https://github.com/ethereum/go-ethereum/pull/31023.patch",
"url": "https://api.github.com/repos/ethereum/go-ethereum/pul... |
This pull request includes several changes to improve code clarity and consistency across multiple files. The changes mainly involve adding detailed comments to functions and renaming variables and functions for better readability.
### Improvements to Comments and Documentation:
* [`accounts/accounts.go`](diffh... | {
"avatar_url": "https://avatars.githubusercontent.com/u/6915?v=4",
"events_url": "https://api.github.com/users/fjl/events{/privacy}",
"followers_url": "https://api.github.com/users/fjl/followers",
"following_url": "https://api.github.com/users/fjl/following{/other_user}",
"gists_url": "https://api.github.com... | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/ethereum/go-ethereum/issues/31023/reactions"
} | https://api.github.com/repos/ethereum/go-ethereum/issues/31023/timeline | null | null | true |
https://api.github.com/repos/ethereum/go-ethereum/issues/31022 | https://api.github.com/repos/ethereum/go-ethereum | https://api.github.com/repos/ethereum/go-ethereum/issues/31022/labels{/name} | https://api.github.com/repos/ethereum/go-ethereum/issues/31022/comments | https://api.github.com/repos/ethereum/go-ethereum/issues/31022/events | https://github.com/ethereum/go-ethereum/issues/31022 | 2,784,821,039 | I_kwDOAOvK986l_P8v | 31,022 | simulated.Backend leaks goroutines | {
"avatar_url": "https://avatars.githubusercontent.com/u/462588?v=4",
"events_url": "https://api.github.com/users/topliceanu/events{/privacy}",
"followers_url": "https://api.github.com/users/topliceanu/followers",
"following_url": "https://api.github.com/users/topliceanu/following{/other_user}",
"gists_url": ... | [
{
"color": "FF5E5E",
"default": false,
"description": "",
"id": 72233650,
"name": "type:bug",
"node_id": "MDU6TGFiZWw3MjIzMzY1MA==",
"url": "https://api.github.com/repos/ethereum/go-ethereum/labels/type:bug"
}
] | open | false | {
"avatar_url": "https://avatars.githubusercontent.com/u/3411040?v=4",
"events_url": "https://api.github.com/users/jwasinger/events{/privacy}",
"followers_url": "https://api.github.com/users/jwasinger/followers",
"following_url": "https://api.github.com/users/jwasinger/following{/other_user}",
"gists_url": "h... | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/3411040?v=4",
"events_url": "https://api.github.com/users/jwasinger/events{/privacy}",
"followers_url": "https://api.github.com/users/jwasinger/followers",
"following_url": "https://api.github.com/users/jwasinger/following{/other_user}",
"... | null | [
"I can see that a good number of these \"leaking\" routines are because of the `SenderCacher` which runs signature recovery in parallel on background goroutines and is instantiated as a global variable. However, I'm not sure about the others. Continuing to investigate..."
] | 2025-01-13T18:03:11 | 2025-01-14T05:47:30 | null | NONE | {
"completed": 0,
"percent_completed": 0,
"total": 0
} | null | null | null | #### System information
Geth version: `v1.14.12`
OS & Version: MacOS
#### Expected behaviour
I'm in the process of writing tests that use the simulated backend and I want to make sure that _my_ code does not leak goroutines, so I'm using uber/goleak.
I noticed that uber/goleak reports that the simulated ba... | null | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 1,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 1,
"url": "https://api.github.com/repos/ethereum/go-ethereum/issues/31022/reactions"
} | https://api.github.com/repos/ethereum/go-ethereum/issues/31022/timeline | null | null | false |
https://api.github.com/repos/ethereum/go-ethereum/issues/31021 | https://api.github.com/repos/ethereum/go-ethereum | https://api.github.com/repos/ethereum/go-ethereum/issues/31021/labels{/name} | https://api.github.com/repos/ethereum/go-ethereum/issues/31021/comments | https://api.github.com/repos/ethereum/go-ethereum/issues/31021/events | https://github.com/ethereum/go-ethereum/issues/31021 | 2,784,316,593 | I_kwDOAOvK986l9Uyx | 31,021 | YO | {
"avatar_url": "https://avatars.githubusercontent.com/u/194809283?v=4",
"events_url": "https://api.github.com/users/Eduardovega972/events{/privacy}",
"followers_url": "https://api.github.com/users/Eduardovega972/followers",
"following_url": "https://api.github.com/users/Eduardovega972/following{/other_user}",
... | [] | closed | false | null | [] | null | [] | 2025-01-13T15:21:27 | 2025-01-14T01:42:58 | 2025-01-14T01:42:58 | NONE | {
"completed": 0,
"percent_completed": 0,
"total": 0
} | null | null | null | https://yomobile.onelink.me/BVbI/ke435ogi | {
"avatar_url": "https://avatars.githubusercontent.com/u/5959481?v=4",
"events_url": "https://api.github.com/users/rjl493456442/events{/privacy}",
"followers_url": "https://api.github.com/users/rjl493456442/followers",
"following_url": "https://api.github.com/users/rjl493456442/following{/other_user}",
"gists... | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/ethereum/go-ethereum/issues/31021/reactions"
} | https://api.github.com/repos/ethereum/go-ethereum/issues/31021/timeline | null | completed | false |
https://api.github.com/repos/ethereum/go-ethereum/issues/31020 | https://api.github.com/repos/ethereum/go-ethereum | https://api.github.com/repos/ethereum/go-ethereum/issues/31020/labels{/name} | https://api.github.com/repos/ethereum/go-ethereum/issues/31020/comments | https://api.github.com/repos/ethereum/go-ethereum/issues/31020/events | https://github.com/ethereum/go-ethereum/pull/31020 | 2,783,986,641 | PR_kwDOAOvK986HiFGZ | 31,020 | core/txpool/legacypool: ensure pending nonces are reset by SubPool.Clear | {
"avatar_url": "https://avatars.githubusercontent.com/u/3411040?v=4",
"events_url": "https://api.github.com/users/jwasinger/events{/privacy}",
"followers_url": "https://api.github.com/users/jwasinger/followers",
"following_url": "https://api.github.com/users/jwasinger/following{/other_user}",
"gists_url": "h... | [] | closed | false | {
"avatar_url": "https://avatars.githubusercontent.com/u/5959481?v=4",
"events_url": "https://api.github.com/users/rjl493456442/events{/privacy}",
"followers_url": "https://api.github.com/users/rjl493456442/followers",
"following_url": "https://api.github.com/users/rjl493456442/following{/other_user}",
"gists... | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/5959481?v=4",
"events_url": "https://api.github.com/users/rjl493456442/events{/privacy}",
"followers_url": "https://api.github.com/users/rjl493456442/followers",
"following_url": "https://api.github.com/users/rjl493456442/following{/other_user... | {
"closed_at": null,
"closed_issues": 81,
"created_at": "2024-11-19T13:54:59Z",
"creator": {
"avatar_url": "https://avatars.githubusercontent.com/u/142290?v=4",
"events_url": "https://api.github.com/users/holiman/events{/privacy}",
"followers_url": "https://api.github.com/users/holiman/followers",
... | [] | 2025-01-13T13:38:16 | 2025-01-16T13:40:20 | 2025-01-16T13:40:15 | CONTRIBUTOR | {
"completed": 0,
"percent_completed": 0,
"total": 0
} | null | 0 | {
"diff_url": "https://github.com/ethereum/go-ethereum/pull/31020.diff",
"html_url": "https://github.com/ethereum/go-ethereum/pull/31020",
"merged_at": "2025-01-16T13:40:15Z",
"patch_url": "https://github.com/ethereum/go-ethereum/pull/31020.patch",
"url": "https://api.github.com/repos/ethereum/go-ethereum/pul... | closes https://github.com/ethereum/go-ethereum/issues/30842 | {
"avatar_url": "https://avatars.githubusercontent.com/u/6915?v=4",
"events_url": "https://api.github.com/users/fjl/events{/privacy}",
"followers_url": "https://api.github.com/users/fjl/followers",
"following_url": "https://api.github.com/users/fjl/following{/other_user}",
"gists_url": "https://api.github.com... | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/ethereum/go-ethereum/issues/31020/reactions"
} | https://api.github.com/repos/ethereum/go-ethereum/issues/31020/timeline | null | null | true |
https://api.github.com/repos/ethereum/go-ethereum/issues/31019 | https://api.github.com/repos/ethereum/go-ethereum | https://api.github.com/repos/ethereum/go-ethereum/issues/31019/labels{/name} | https://api.github.com/repos/ethereum/go-ethereum/issues/31019/comments | https://api.github.com/repos/ethereum/go-ethereum/issues/31019/events | https://github.com/ethereum/go-ethereum/pull/31019 | 2,781,998,868 | PR_kwDOAOvK986Hbh2E | 31,019 | build: upgrade golangci-lint to v1.63.4 | {
"avatar_url": "https://avatars.githubusercontent.com/u/7695325?v=4",
"events_url": "https://api.github.com/users/gzliudan/events{/privacy}",
"followers_url": "https://api.github.com/users/gzliudan/followers",
"following_url": "https://api.github.com/users/gzliudan/following{/other_user}",
"gists_url": "http... | [] | closed | false | null | [] | {
"closed_at": null,
"closed_issues": 81,
"created_at": "2024-11-19T13:54:59Z",
"creator": {
"avatar_url": "https://avatars.githubusercontent.com/u/142290?v=4",
"events_url": "https://api.github.com/users/holiman/events{/privacy}",
"followers_url": "https://api.github.com/users/holiman/followers",
... | [] | 2025-01-11T16:28:48 | 2025-01-13T08:18:32 | 2025-01-13T07:26:11 | CONTRIBUTOR | {
"completed": 0,
"percent_completed": 0,
"total": 0
} | null | 0 | {
"diff_url": "https://github.com/ethereum/go-ethereum/pull/31019.diff",
"html_url": "https://github.com/ethereum/go-ethereum/pull/31019",
"merged_at": "2025-01-13T07:26:11Z",
"patch_url": "https://github.com/ethereum/go-ethereum/pull/31019.patch",
"url": "https://api.github.com/repos/ethereum/go-ethereum/pul... | This PR upgrades `golangci-lint` to v1.63.4 and fixes a warn message which is reported by v1.63.4:
```text
WARN [config_reader] The configuration option `run.skip-dirs-use-default` is deprecated, please use `issues.exclude-dirs-use-default`.
```
Also fixes 2 warnings which are reported by v1.63.4:
```text
c... | {
"avatar_url": "https://avatars.githubusercontent.com/u/142290?v=4",
"events_url": "https://api.github.com/users/holiman/events{/privacy}",
"followers_url": "https://api.github.com/users/holiman/followers",
"following_url": "https://api.github.com/users/holiman/following{/other_user}",
"gists_url": "https://... | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/ethereum/go-ethereum/issues/31019/reactions"
} | https://api.github.com/repos/ethereum/go-ethereum/issues/31019/timeline | null | null | true |
https://api.github.com/repos/ethereum/go-ethereum/issues/31018 | https://api.github.com/repos/ethereum/go-ethereum | https://api.github.com/repos/ethereum/go-ethereum/issues/31018/labels{/name} | https://api.github.com/repos/ethereum/go-ethereum/issues/31018/comments | https://api.github.com/repos/ethereum/go-ethereum/issues/31018/events | https://github.com/ethereum/go-ethereum/pull/31018 | 2,781,863,129 | PR_kwDOAOvK986HbFRa | 31,018 | Dockerfile: add curl to dockerfile for health check purposes | {
"avatar_url": "https://avatars.githubusercontent.com/u/164305046?v=4",
"events_url": "https://api.github.com/users/tornadocontrib/events{/privacy}",
"followers_url": "https://api.github.com/users/tornadocontrib/followers",
"following_url": "https://api.github.com/users/tornadocontrib/following{/other_user}",
... | [
{
"color": "6be514",
"default": false,
"description": "",
"id": 1132689577,
"name": "status:triage",
"node_id": "MDU6TGFiZWwxMTMyNjg5NTc3",
"url": "https://api.github.com/repos/ethereum/go-ethereum/labels/status:triage"
}
] | closed | false | {
"avatar_url": "https://avatars.githubusercontent.com/u/6915?v=4",
"events_url": "https://api.github.com/users/fjl/events{/privacy}",
"followers_url": "https://api.github.com/users/fjl/followers",
"following_url": "https://api.github.com/users/fjl/following{/other_user}",
"gists_url": "https://api.github.com... | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/6915?v=4",
"events_url": "https://api.github.com/users/fjl/events{/privacy}",
"followers_url": "https://api.github.com/users/fjl/followers",
"following_url": "https://api.github.com/users/fjl/following{/other_user}",
"gists_url": "https://... | null | [
"We would like to keep the container image as minimal as possible. If you require another tool in the image, you will have to create your own image based on ours.",
"@fjl Yes I just found that it is better to use geth IPC console for the purpose\r\n\r\n```\r\nhealthcheck:\r\n test: [\"CMD-SHELL\", \"geth att... | 2025-01-11T13:01:05 | 2025-01-15T20:34:55 | 2025-01-14T13:30:42 | NONE | {
"completed": 0,
"percent_completed": 0,
"total": 0
} | null | 0 | {
"diff_url": "https://github.com/ethereum/go-ethereum/pull/31018.diff",
"html_url": "https://github.com/ethereum/go-ethereum/pull/31018",
"merged_at": null,
"patch_url": "https://github.com/ethereum/go-ethereum/pull/31018.patch",
"url": "https://api.github.com/repos/ethereum/go-ethereum/pulls/31018"
} | Please add CURL command line tool for health checking purpose on docker ( and it is also useful to test if the container is reachable to network ) | {
"avatar_url": "https://avatars.githubusercontent.com/u/6915?v=4",
"events_url": "https://api.github.com/users/fjl/events{/privacy}",
"followers_url": "https://api.github.com/users/fjl/followers",
"following_url": "https://api.github.com/users/fjl/following{/other_user}",
"gists_url": "https://api.github.com... | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/ethereum/go-ethereum/issues/31018/reactions"
} | https://api.github.com/repos/ethereum/go-ethereum/issues/31018/timeline | null | null | true |
https://api.github.com/repos/ethereum/go-ethereum/issues/31017 | https://api.github.com/repos/ethereum/go-ethereum | https://api.github.com/repos/ethereum/go-ethereum/issues/31017/labels{/name} | https://api.github.com/repos/ethereum/go-ethereum/issues/31017/comments | https://api.github.com/repos/ethereum/go-ethereum/issues/31017/events | https://github.com/ethereum/go-ethereum/pull/31017 | 2,781,055,238 | PR_kwDOAOvK986HYRp9 | 31,017 | Merge it baby | {
"avatar_url": "https://avatars.githubusercontent.com/u/181420327?v=4",
"events_url": "https://api.github.com/users/epiclove1/events{/privacy}",
"followers_url": "https://api.github.com/users/epiclove1/followers",
"following_url": "https://api.github.com/users/epiclove1/following{/other_user}",
"gists_url": ... | [] | closed | false | null | [] | null | [] | 2025-01-10T20:14:57 | 2025-01-10T22:54:27 | 2025-01-10T22:54:27 | NONE | {
"completed": 0,
"percent_completed": 0,
"total": 0
} | null | 0 | {
"diff_url": "https://github.com/ethereum/go-ethereum/pull/31017.diff",
"html_url": "https://github.com/ethereum/go-ethereum/pull/31017",
"merged_at": null,
"patch_url": "https://github.com/ethereum/go-ethereum/pull/31017.patch",
"url": "https://api.github.com/repos/ethereum/go-ethereum/pulls/31017"
} | Merge it baby or do i? | {
"avatar_url": "https://avatars.githubusercontent.com/u/14004106?v=4",
"events_url": "https://api.github.com/users/lightclient/events{/privacy}",
"followers_url": "https://api.github.com/users/lightclient/followers",
"following_url": "https://api.github.com/users/lightclient/following{/other_user}",
"gists_u... | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/ethereum/go-ethereum/issues/31017/reactions"
} | https://api.github.com/repos/ethereum/go-ethereum/issues/31017/timeline | null | null | true |
https://api.github.com/repos/ethereum/go-ethereum/issues/31016 | https://api.github.com/repos/ethereum/go-ethereum | https://api.github.com/repos/ethereum/go-ethereum/issues/31016/labels{/name} | https://api.github.com/repos/ethereum/go-ethereum/issues/31016/comments | https://api.github.com/repos/ethereum/go-ethereum/issues/31016/events | https://github.com/ethereum/go-ethereum/pull/31016 | 2,780,359,550 | PR_kwDOAOvK986HV2TF | 31,016 | Hardhatcompilewithtokenupdatecicdproceedwithethers | {
"avatar_url": "https://avatars.githubusercontent.com/u/110764167?v=4",
"events_url": "https://api.github.com/users/nikolaivanovj/events{/privacy}",
"followers_url": "https://api.github.com/users/nikolaivanovj/followers",
"following_url": "https://api.github.com/users/nikolaivanovj/following{/other_user}",
"... | [] | closed | false | null | [] | null | [
"Please ignore"
] | 2025-01-10T14:47:32 | 2025-01-10T14:48:42 | 2025-01-10T14:47:49 | NONE | {
"completed": 0,
"percent_completed": 0,
"total": 0
} | null | 1 | {
"diff_url": "https://github.com/ethereum/go-ethereum/pull/31016.diff",
"html_url": "https://github.com/ethereum/go-ethereum/pull/31016",
"merged_at": null,
"patch_url": "https://github.com/ethereum/go-ethereum/pull/31016.patch",
"url": "https://api.github.com/repos/ethereum/go-ethereum/pulls/31016"
} | test package.json | {
"avatar_url": "https://avatars.githubusercontent.com/u/110764167?v=4",
"events_url": "https://api.github.com/users/nikolaivanovj/events{/privacy}",
"followers_url": "https://api.github.com/users/nikolaivanovj/followers",
"following_url": "https://api.github.com/users/nikolaivanovj/following{/other_user}",
"... | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/ethereum/go-ethereum/issues/31016/reactions"
} | https://api.github.com/repos/ethereum/go-ethereum/issues/31016/timeline | null | null | true |
https://api.github.com/repos/ethereum/go-ethereum/issues/31015 | https://api.github.com/repos/ethereum/go-ethereum | https://api.github.com/repos/ethereum/go-ethereum/issues/31015/labels{/name} | https://api.github.com/repos/ethereum/go-ethereum/issues/31015/comments | https://api.github.com/repos/ethereum/go-ethereum/issues/31015/events | https://github.com/ethereum/go-ethereum/pull/31015 | 2,779,945,485 | PR_kwDOAOvK986HUaze | 31,015 | core/{.,state,vm},miner,ethr/tracers: implement 7709 | {
"avatar_url": "https://avatars.githubusercontent.com/u/3272758?v=4",
"events_url": "https://api.github.com/users/gballet/events{/privacy}",
"followers_url": "https://api.github.com/users/gballet/followers",
"following_url": "https://api.github.com/users/gballet/following{/other_user}",
"gists_url": "https:/... | [
{
"color": "8686E5",
"default": false,
"description": "",
"id": 4374668042,
"name": "verkle",
"node_id": "LA_kwDOAOvK988AAAABBMAjCg",
"url": "https://api.github.com/repos/ethereum/go-ethereum/labels/verkle"
}
] | open | false | null | [] | null | [
"If I understand correctly, in EIP 7709, the main differences are:\r\n\r\n```\r\n- SLOAD gas costs (cold or warm) for the arg % HISTORY_SERVE_WINDOW slot.\r\n- SLOAD after effects on the slot (warming the slot)\r\n- SLOAD accesses added to execution witnesses if Verkle ([EIP-6800](https://eips.ethereum.org/EIPS/eip... | 2025-01-10T11:20:54 | 2025-01-15T09:07:41 | null | MEMBER | {
"completed": 0,
"percent_completed": 0,
"total": 0
} | null | 0 | {
"diff_url": "https://github.com/ethereum/go-ethereum/pull/31015.diff",
"html_url": "https://github.com/ethereum/go-ethereum/pull/31015",
"merged_at": null,
"patch_url": "https://github.com/ethereum/go-ethereum/pull/31015.patch",
"url": "https://api.github.com/repos/ethereum/go-ethereum/pulls/31015"
} | This is the implementation of 7709 as currently running on the verkle testnet. While this is not the final version, the final changes will be minor tweaks:
* change `HistoryServeWindow` to 8191
* use the history contract from 2935 instead of the system address. | null | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/ethereum/go-ethereum/issues/31015/reactions"
} | https://api.github.com/repos/ethereum/go-ethereum/issues/31015/timeline | null | null | true |
https://api.github.com/repos/ethereum/go-ethereum/issues/31014 | https://api.github.com/repos/ethereum/go-ethereum | https://api.github.com/repos/ethereum/go-ethereum/issues/31014/labels{/name} | https://api.github.com/repos/ethereum/go-ethereum/issues/31014/comments | https://api.github.com/repos/ethereum/go-ethereum/issues/31014/events | https://github.com/ethereum/go-ethereum/pull/31014 | 2,779,675,515 | PR_kwDOAOvK986HTiR8 | 31,014 | core/{state, vm}: update stateless gas costs to follow the verkle-gen-7 testnet | {
"avatar_url": "https://avatars.githubusercontent.com/u/3272758?v=4",
"events_url": "https://api.github.com/users/gballet/events{/privacy}",
"followers_url": "https://api.github.com/users/gballet/followers",
"following_url": "https://api.github.com/users/gballet/following{/other_user}",
"gists_url": "https:/... | [
{
"color": "8686E5",
"default": false,
"description": "",
"id": 4374668042,
"name": "verkle",
"node_id": "LA_kwDOAOvK988AAAABBMAjCg",
"url": "https://api.github.com/repos/ethereum/go-ethereum/labels/verkle"
}
] | open | false | null | [] | null | [] | 2025-01-10T09:17:27 | 2025-01-14T02:05:18 | null | MEMBER | {
"completed": 0,
"percent_completed": 0,
"total": 0
} | null | 1 | {
"diff_url": "https://github.com/ethereum/go-ethereum/pull/31014.diff",
"html_url": "https://github.com/ethereum/go-ethereum/pull/31014",
"merged_at": null,
"patch_url": "https://github.com/ethereum/go-ethereum/pull/31014.patch",
"url": "https://api.github.com/repos/ethereum/go-ethereum/pulls/31014"
} | Adding values to the witness introduces a new class of issues for computing gas: if there is not enough gas to cover adding an item to the witness, then the item should not be added to the witness.
The problem happens when several items are added together, and that process runs out of gas. The witness gas computatio... | null | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/ethereum/go-ethereum/issues/31014/reactions"
} | https://api.github.com/repos/ethereum/go-ethereum/issues/31014/timeline | null | null | true |
https://api.github.com/repos/ethereum/go-ethereum/issues/31013 | https://api.github.com/repos/ethereum/go-ethereum | https://api.github.com/repos/ethereum/go-ethereum/issues/31013/labels{/name} | https://api.github.com/repos/ethereum/go-ethereum/issues/31013/comments | https://api.github.com/repos/ethereum/go-ethereum/issues/31013/events | https://github.com/ethereum/go-ethereum/pull/31013 | 2,778,730,575 | PR_kwDOAOvK986HQVja | 31,013 | eth/tracers/logger: return revert reason | {
"avatar_url": "https://avatars.githubusercontent.com/u/21436?v=4",
"events_url": "https://api.github.com/users/reds/events{/privacy}",
"followers_url": "https://api.github.com/users/reds/followers",
"following_url": "https://api.github.com/users/reds/following{/other_user}",
"gists_url": "https://api.github... | [] | closed | false | null | [] | {
"closed_at": null,
"closed_issues": 81,
"created_at": "2024-11-19T13:54:59Z",
"creator": {
"avatar_url": "https://avatars.githubusercontent.com/u/142290?v=4",
"events_url": "https://api.github.com/users/holiman/events{/privacy}",
"followers_url": "https://api.github.com/users/holiman/followers",
... | [
"Can you provide an example or a test case that proves the error handling does matter?",
"Added a test. Wrapping the error, in this case in a vm.VMError, gives a new error address. The direct comparison then fails. Thanks"
] | 2025-01-09T20:51:14 | 2025-01-13T15:12:15 | 2025-01-13T15:12:15 | CONTRIBUTOR | {
"completed": 0,
"percent_completed": 0,
"total": 0
} | null | 0 | {
"diff_url": "https://github.com/ethereum/go-ethereum/pull/31013.diff",
"html_url": "https://github.com/ethereum/go-ethereum/pull/31013",
"merged_at": "2025-01-13T15:12:15Z",
"patch_url": "https://github.com/ethereum/go-ethereum/pull/31013.patch",
"url": "https://api.github.com/repos/ethereum/go-ethereum/pul... | The logger tracer is dropping data from a revert.
Because of error wrapping the == comparison is not sufficient. errors.Is is needed. | {
"avatar_url": "https://avatars.githubusercontent.com/u/5959481?v=4",
"events_url": "https://api.github.com/users/rjl493456442/events{/privacy}",
"followers_url": "https://api.github.com/users/rjl493456442/followers",
"following_url": "https://api.github.com/users/rjl493456442/following{/other_user}",
"gists... | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/ethereum/go-ethereum/issues/31013/reactions"
} | https://api.github.com/repos/ethereum/go-ethereum/issues/31013/timeline | null | null | true |
https://api.github.com/repos/ethereum/go-ethereum/issues/31012 | https://api.github.com/repos/ethereum/go-ethereum | https://api.github.com/repos/ethereum/go-ethereum/issues/31012/labels{/name} | https://api.github.com/repos/ethereum/go-ethereum/issues/31012/comments | https://api.github.com/repos/ethereum/go-ethereum/issues/31012/events | https://github.com/ethereum/go-ethereum/pull/31012 | 2,778,160,247 | PR_kwDOAOvK986HOYyf | 31,012 | cmd/devp2p/internal/ethtest: using slices.SortFunc to simplify the code | {
"avatar_url": "https://avatars.githubusercontent.com/u/171347066?v=4",
"events_url": "https://api.github.com/users/dashangcun/events{/privacy}",
"followers_url": "https://api.github.com/users/dashangcun/followers",
"following_url": "https://api.github.com/users/dashangcun/following{/other_user}",
"gists_url... | [] | closed | false | null | [] | {
"closed_at": null,
"closed_issues": 81,
"created_at": "2024-11-19T13:54:59Z",
"creator": {
"avatar_url": "https://avatars.githubusercontent.com/u/142290?v=4",
"events_url": "https://api.github.com/users/holiman/events{/privacy}",
"followers_url": "https://api.github.com/users/holiman/followers",
... | [
"This type can probably be deleted, and its use replaced by `slices.SortFunc`",
"If this kind of code style change is worthwhile, would you reconsider #30957?",
"In general, we do not care too much about improving small details like this. If the code works, we think it's fine. And it will be rewritten or delete... | 2025-01-09T15:40:21 | 2025-01-13T18:34:07 | 2025-01-13T17:00:26 | CONTRIBUTOR | {
"completed": 0,
"percent_completed": 0,
"total": 0
} | null | 0 | {
"diff_url": "https://github.com/ethereum/go-ethereum/pull/31012.diff",
"html_url": "https://github.com/ethereum/go-ethereum/pull/31012",
"merged_at": "2025-01-13T17:00:26Z",
"patch_url": "https://github.com/ethereum/go-ethereum/pull/31012.patch",
"url": "https://api.github.com/repos/ethereum/go-ethereum/pul... | Using slices.SortFunc to simplify the code. | {
"avatar_url": "https://avatars.githubusercontent.com/u/6915?v=4",
"events_url": "https://api.github.com/users/fjl/events{/privacy}",
"followers_url": "https://api.github.com/users/fjl/followers",
"following_url": "https://api.github.com/users/fjl/following{/other_user}",
"gists_url": "https://api.github.com... | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/ethereum/go-ethereum/issues/31012/reactions"
} | https://api.github.com/repos/ethereum/go-ethereum/issues/31012/timeline | null | null | true |
https://api.github.com/repos/ethereum/go-ethereum/issues/31011 | https://api.github.com/repos/ethereum/go-ethereum | https://api.github.com/repos/ethereum/go-ethereum/issues/31011/labels{/name} | https://api.github.com/repos/ethereum/go-ethereum/issues/31011/comments | https://api.github.com/repos/ethereum/go-ethereum/issues/31011/events | https://github.com/ethereum/go-ethereum/issues/31011 | 2,778,134,305 | I_kwDOAOvK986llvch | 31,011 | `engine_newPayloadV3` RPC Method call | {
"avatar_url": "https://avatars.githubusercontent.com/u/26581515?v=4",
"events_url": "https://api.github.com/users/Eduard-Voiculescu/events{/privacy}",
"followers_url": "https://api.github.com/users/Eduard-Voiculescu/followers",
"following_url": "https://api.github.com/users/Eduard-Voiculescu/following{/other_... | [
{
"color": "FF5E5E",
"default": false,
"description": "",
"id": 72233650,
"name": "type:bug",
"node_id": "MDU6TGFiZWw3MjIzMzY1MA==",
"url": "https://api.github.com/repos/ethereum/go-ethereum/labels/type:bug"
}
] | open | false | null | [] | null | [
"It looks like the panic is coming from your code `firehose.go`. If you've registered the tracer to run, it will run when you insert a block into the chain - which happens on `engine_newPayloadV3`. External tracers are not expected to panic, so if they do, we expose that.",
"Ok so that's the weird issue I am seei... | 2025-01-09T15:29:19 | 2025-01-13T03:50:58 | null | NONE | {
"completed": 0,
"percent_completed": 0,
"total": 0
} | null | null | null | #### System information
Geth version: `geth version`
CL client & version: e.g. lighthouse/nimbus/prysm@v1.0.0
OS & Version: Linux
Commit hash : (if `develop`)
#### Expected behaviour
RPC call should not break `geth` node running.
#### Actual behaviour
The issue occurred on `op-sepolia` running the [fireho... | null | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/ethereum/go-ethereum/issues/31011/reactions"
} | https://api.github.com/repos/ethereum/go-ethereum/issues/31011/timeline | null | null | false |
https://api.github.com/repos/ethereum/go-ethereum/issues/31010 | https://api.github.com/repos/ethereum/go-ethereum | https://api.github.com/repos/ethereum/go-ethereum/issues/31010/labels{/name} | https://api.github.com/repos/ethereum/go-ethereum/issues/31010/comments | https://api.github.com/repos/ethereum/go-ethereum/issues/31010/events | https://github.com/ethereum/go-ethereum/pull/31010 | 2,778,047,799 | PR_kwDOAOvK986HN_96 | 31,010 | beacon/engine: check for empty requests | {
"avatar_url": "https://avatars.githubusercontent.com/u/1591639?v=4",
"events_url": "https://api.github.com/users/s1na/events{/privacy}",
"followers_url": "https://api.github.com/users/s1na/followers",
"following_url": "https://api.github.com/users/s1na/following{/other_user}",
"gists_url": "https://api.gith... | [
{
"color": "2FD8E9",
"default": false,
"description": "",
"id": 6709376979,
"name": "prague",
"node_id": "LA_kwDOAOvK988AAAABj-j30w",
"url": "https://api.github.com/repos/ethereum/go-ethereum/labels/prague"
}
] | closed | false | {
"avatar_url": "https://avatars.githubusercontent.com/u/14004106?v=4",
"events_url": "https://api.github.com/users/lightclient/events{/privacy}",
"followers_url": "https://api.github.com/users/lightclient/followers",
"following_url": "https://api.github.com/users/lightclient/following{/other_user}",
"gists_u... | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/14004106?v=4",
"events_url": "https://api.github.com/users/lightclient/events{/privacy}",
"followers_url": "https://api.github.com/users/lightclient/followers",
"following_url": "https://api.github.com/users/lightclient/following{/other_user}"... | {
"closed_at": null,
"closed_issues": 81,
"created_at": "2024-11-19T13:54:59Z",
"creator": {
"avatar_url": "https://avatars.githubusercontent.com/u/142290?v=4",
"events_url": "https://api.github.com/users/holiman/events{/privacy}",
"followers_url": "https://api.github.com/users/holiman/followers",
... | [] | 2025-01-09T14:52:34 | 2025-01-15T18:45:28 | 2025-01-15T18:45:20 | CONTRIBUTOR | {
"completed": 0,
"percent_completed": 0,
"total": 0
} | null | 0 | {
"diff_url": "https://github.com/ethereum/go-ethereum/pull/31010.diff",
"html_url": "https://github.com/ethereum/go-ethereum/pull/31010",
"merged_at": "2025-01-15T18:45:20Z",
"patch_url": "https://github.com/ethereum/go-ethereum/pull/31010.patch",
"url": "https://api.github.com/repos/ethereum/go-ethereum/pul... | According to https://github.com/ethereum/execution-apis/blob/main/src/engine/prague.md#engine_newpayloadv4:
> Elements of the list MUST be ordered by request_type in ascending order. Elements with empty request_data MUST be excluded from the list. | {
"avatar_url": "https://avatars.githubusercontent.com/u/14004106?v=4",
"events_url": "https://api.github.com/users/lightclient/events{/privacy}",
"followers_url": "https://api.github.com/users/lightclient/followers",
"following_url": "https://api.github.com/users/lightclient/following{/other_user}",
"gists_u... | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/ethereum/go-ethereum/issues/31010/reactions"
} | https://api.github.com/repos/ethereum/go-ethereum/issues/31010/timeline | null | null | true |
https://api.github.com/repos/ethereum/go-ethereum/issues/31009 | https://api.github.com/repos/ethereum/go-ethereum | https://api.github.com/repos/ethereum/go-ethereum/issues/31009/labels{/name} | https://api.github.com/repos/ethereum/go-ethereum/issues/31009/comments | https://api.github.com/repos/ethereum/go-ethereum/issues/31009/events | https://github.com/ethereum/go-ethereum/pull/31009 | 2,777,401,514 | PR_kwDOAOvK986HLwjy | 31,009 | eth/protocols/snap: add debug logs if the requested state is not available | {
"avatar_url": "https://avatars.githubusercontent.com/u/16909984?v=4",
"events_url": "https://api.github.com/users/stevemilk/events{/privacy}",
"followers_url": "https://api.github.com/users/stevemilk/followers",
"following_url": "https://api.github.com/users/stevemilk/following{/other_user}",
"gists_url": "... | [] | closed | false | null | [] | null | [
"```\r\n// TODO(karalabe): - Logging locally is not ideal as remote faults annoy the local user\r\n```\r\n\r\nI think it’s intentional to avoid emitting logs, particularly for non-internal errors. I would prefer to keep behavior unchanged."
] | 2025-01-09T10:15:30 | 2025-01-13T07:50:36 | 2025-01-13T07:50:35 | CONTRIBUTOR | {
"completed": 0,
"percent_completed": 0,
"total": 0
} | null | 0 | {
"diff_url": "https://github.com/ethereum/go-ethereum/pull/31009.diff",
"html_url": "https://github.com/ethereum/go-ethereum/pull/31009",
"merged_at": null,
"patch_url": "https://github.com/ethereum/go-ethereum/pull/31009.patch",
"url": "https://api.github.com/repos/ethereum/go-ethereum/pulls/31009"
} | Found two errors useful for debugging snapsync should be printed out. | {
"avatar_url": "https://avatars.githubusercontent.com/u/5959481?v=4",
"events_url": "https://api.github.com/users/rjl493456442/events{/privacy}",
"followers_url": "https://api.github.com/users/rjl493456442/followers",
"following_url": "https://api.github.com/users/rjl493456442/following{/other_user}",
"gists... | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/ethereum/go-ethereum/issues/31009/reactions"
} | https://api.github.com/repos/ethereum/go-ethereum/issues/31009/timeline | null | null | true |
https://api.github.com/repos/ethereum/go-ethereum/issues/31008 | https://api.github.com/repos/ethereum/go-ethereum | https://api.github.com/repos/ethereum/go-ethereum/issues/31008/labels{/name} | https://api.github.com/repos/ethereum/go-ethereum/issues/31008/comments | https://api.github.com/repos/ethereum/go-ethereum/issues/31008/events | https://github.com/ethereum/go-ethereum/pull/31008 | 2,776,874,913 | PR_kwDOAOvK986HJ841 | 31,008 | triedb/pathdb: configure different node hasher in pathdb | {
"avatar_url": "https://avatars.githubusercontent.com/u/5959481?v=4",
"events_url": "https://api.github.com/users/rjl493456442/events{/privacy}",
"followers_url": "https://api.github.com/users/rjl493456442/followers",
"following_url": "https://api.github.com/users/rjl493456442/following{/other_user}",
"gists... | [
{
"color": "8686E5",
"default": false,
"description": "",
"id": 4374668042,
"name": "verkle",
"node_id": "LA_kwDOAOvK988AAAABBMAjCg",
"url": "https://api.github.com/repos/ethereum/go-ethereum/labels/verkle"
}
] | closed | false | null | [] | {
"closed_at": null,
"closed_issues": 81,
"created_at": "2024-11-19T13:54:59Z",
"creator": {
"avatar_url": "https://avatars.githubusercontent.com/u/142290?v=4",
"events_url": "https://api.github.com/users/holiman/events{/privacy}",
"followers_url": "https://api.github.com/users/holiman/followers",
... | [] | 2025-01-09T05:34:58 | 2025-01-10T12:51:20 | 2025-01-10T12:51:19 | MEMBER | {
"completed": 0,
"percent_completed": 0,
"total": 0
} | null | 0 | {
"diff_url": "https://github.com/ethereum/go-ethereum/pull/31008.diff",
"html_url": "https://github.com/ethereum/go-ethereum/pull/31008",
"merged_at": "2025-01-10T12:51:19Z",
"patch_url": "https://github.com/ethereum/go-ethereum/pull/31008.patch",
"url": "https://api.github.com/repos/ethereum/go-ethereum/pul... | As the node hash scheme in verkle and merkle are totally different, the original default node hasher in pathdb is no longer suitable. Therefore, this pull request configures different node hasher respectively. | {
"avatar_url": "https://avatars.githubusercontent.com/u/5959481?v=4",
"events_url": "https://api.github.com/users/rjl493456442/events{/privacy}",
"followers_url": "https://api.github.com/users/rjl493456442/followers",
"following_url": "https://api.github.com/users/rjl493456442/following{/other_user}",
"gists... | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/ethereum/go-ethereum/issues/31008/reactions"
} | https://api.github.com/repos/ethereum/go-ethereum/issues/31008/timeline | null | null | true |
https://api.github.com/repos/ethereum/go-ethereum/issues/31007 | https://api.github.com/repos/ethereum/go-ethereum | https://api.github.com/repos/ethereum/go-ethereum/issues/31007/labels{/name} | https://api.github.com/repos/ethereum/go-ethereum/issues/31007/comments | https://api.github.com/repos/ethereum/go-ethereum/issues/31007/events | https://github.com/ethereum/go-ethereum/pull/31007 | 2,776,093,695 | PR_kwDOAOvK986HHQ52 | 31,007 | core/tracing: document `OnCodeChange` now being called from SelfDestruct | {
"avatar_url": "https://avatars.githubusercontent.com/u/123014?v=4",
"events_url": "https://api.github.com/users/maoueh/events{/privacy}",
"followers_url": "https://api.github.com/users/maoueh/followers",
"following_url": "https://api.github.com/users/maoueh/following{/other_user}",
"gists_url": "https://api... | [] | closed | false | {
"avatar_url": "https://avatars.githubusercontent.com/u/1591639?v=4",
"events_url": "https://api.github.com/users/s1na/events{/privacy}",
"followers_url": "https://api.github.com/users/s1na/followers",
"following_url": "https://api.github.com/users/s1na/following{/other_user}",
"gists_url": "https://api.gith... | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/1591639?v=4",
"events_url": "https://api.github.com/users/s1na/events{/privacy}",
"followers_url": "https://api.github.com/users/s1na/followers",
"following_url": "https://api.github.com/users/s1na/following{/other_user}",
"gists_url": "ht... | null | [
"Is this the clarification for #31011 btw? Can we close that or that's a separate issue?"
] | 2025-01-08T18:53:09 | 2025-01-16T14:58:16 | 2025-01-16T14:58:16 | CONTRIBUTOR | {
"completed": 0,
"percent_completed": 0,
"total": 0
} | null | 0 | {
"diff_url": "https://github.com/ethereum/go-ethereum/pull/31007.diff",
"html_url": "https://github.com/ethereum/go-ethereum/pull/31007",
"merged_at": "2025-01-16T14:58:16Z",
"patch_url": "https://github.com/ethereum/go-ethereum/pull/31007.patch",
"url": "https://api.github.com/repos/ethereum/go-ethereum/pul... | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/1591639?v=4",
"events_url": "https://api.github.com/users/s1na/events{/privacy}",
"followers_url": "https://api.github.com/users/s1na/followers",
"following_url": "https://api.github.com/users/s1na/following{/other_user}",
"gists_url": "https://api.gith... | {
"+1": 1,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 1,
"url": "https://api.github.com/repos/ethereum/go-ethereum/issues/31007/reactions"
} | https://api.github.com/repos/ethereum/go-ethereum/issues/31007/timeline | null | null | true |
End of preview. Expand in Data Studio
README.md exists but content is empty.
- Downloads last month
- 125