diff stringlengths 54 42.9k | msg stringlengths 10 207 | vccs_msg stringlengths 0 1.62k | type stringclasses 5
values |
|---|---|---|---|
--- lib/Plugins/CCpp.cpp
+++ lib/Plugins/CCpp.cpp
void CAnalyzerCCpp::GetIndependentBuldIdPC(const std::string& pBuildIdPC, std::string& pIndependentBuildIdPC)
while (ii < pBuildIdPC.length())
std::string line = "";
int jj = 0;
line += pBuildIdPC[ii];
- while (!isspace(line[jj]) ... | fixed local UUID | tabs are replaced by space
new crash types
added killing of debuginfo-install if CCpp is unloaded
Create new Utils library (it uses old DebugDump and adds more functionality)
Fixed looking for database and application plugin
tabs are replaced by spaces
added "editable" item
added new interface frof settings
reflect new... | TYPE0 |
--- src/hooks/abrt-hook-ccpp.c
+++ src/hooks/abrt-hook-ccpp.c
int main(int argc, char** argv)
if (dd)
dd_save_text(dd, FILENAME_ENVIRON, environ ? : "");
+ char *fips_enabled = xmalloc_fopen_fgetline_fclose("/proc/sys/crypto/fips_enabled");
+ if (fips_enabled)
+ {
+ if (s... | abrt-hook-ccpp: save /proc/sys/crypto/fips_enabled value if it isn't "0". Closes rhbz | abrtd: limit the number of frames in backtrace to 3000
abrt-server, abrt-dbus: trivial simplifications and tweaks
wire up SSLVerify in RHTSupport.conf to actually have the desired effect
daemon: log DBus calls with -v; log file creation only with -vvv
CCpp plugin: add forgotten closedir()
abrt-gui: correct "update" sig... | TYPE0 |
--- src/hooks/abrt-hook-ccpp.c
+++ src/hooks/abrt-hook-ccpp.c
@@ -795,6 +795,8 @@ int main(int argc, char** argv)
+/* Because of #1211835 and #1126850 */
+#if 0
@@ -827,6 +829,7 @@ int main(int argc, char** argv)
+#endif
| ccpp: stop reading hs_error.log from /tmp | lib: add functions validating dump dir
testsuite: always install libreport-plugin-mantisbt package
vmcore: catch IOErrors and OSErrors
testsuite: ureport does not fail on rhsm errors
rhbz: a more reliable C/C++ analysis event
testsuite: move dumpdir location from /tmp/XXXXX to /var/spool/XXXXX
abrtd: don't mark problem... | TYPE0 |
--- src/Hooks/abrt-hook-ccpp.cpp
+++ src/Hooks/abrt-hook-ccpp.cpp
static char* get_executable(pid_t pid)
sprintf(buf, "/proc/%lu/exe", (long)pid);
- return malloc_readlink(buf);
+ char *executable = malloc_readlink(buf);
+ /* find and cut off " (deleted)" from the path */
+ char *deleted = executabl... | remove "(deleted)" from executable path rhbz | Allow only one instance of GUI
GUI: fixed crash when abrt-gui is run without X server rhbz
CCpp: give up settings limits on the first failure
CCpp: Made it more verbose
Utils: small fix
blacklisted nspluginwrapper, because it causes too many useless reports
GUI: added popup menu, fixed behaviour when run with root priv... | TYPE0 |
--- src/hooks/abrt-hook-ccpp.c
+++ src/hooks/abrt-hook-ccpp.c
@@ -116,6 +116,8 @@ static off_t copyfd_sparse(int src_fd, int dst_fd1, int dst_fd2, off_t size2)
+//TODO: truncate to 0 or even delete the second file
+//(currently we delete the file later)
| abrt-hook-ccpp: added a TODO comment. No code changes | abrt-action-install-debuginfo: handle exception in result = downloader.download(missing). Closes bz
added abrt-action-generate-backtrace manpage
wizard: fix navigation but when "go to reporting step" leads to empty page
move abrt-action-FOO from /usr/libexec to /usr/bin
Add a warning comment that options and their enum... | TYPE0 |
--- src/hooks/abrt-hook-ccpp.c
+++ src/hooks/abrt-hook-ccpp.c
int main(int argc, char** argv)
g_user_core_flags = O_EXCL;
if (g_settings_debug_level == 0)
if (snprintf(path, sizeof(path), "%s/%s-coredump", g_settings_dump_location, last_slash) >= sizeof(path))
error_msg_and_die("... | ccpp: save abrt core files only to new files | dbus: keep the polkit authorization for all clients
testsuite: test journald-integration harder
abrtd: update last occurrence dump dir file
spec: added the versioned abrt-libs requires to silence rpmdiff
testsuite: logs must not include System logs
fix problem occurrence counter updating algorithm
testsuite: abrt-cli p... | TYPE1 |
--- src/hooks/abrt-hook-ccpp.c
+++ src/hooks/abrt-hook-ccpp.c
int main(int argc, char** argv)
g_settings_dump_location, iso_date_string(NULL), (long)pid);
dd = dd_create(path, fsuid, DEFAULT_DUMP_DIR_MODE);
if (dd)
char *rootdir = get_rootdir(pid);
- dd_create_basic_files(dd, fsuid, ... | ccpp: do not read data from root directories | testsuite: rhel6: fulfil expectations on contents of reported_to in cli-sanity
testsuite: add tests for abrt-cli list "not-reported" option
Show a confirmation notify bubble for reported problems in ShortenedReporting mode
vmcore: catch IOErrors and OSErrors
abrt_event: fix post-create reporter-uploader examples
allow ... | TYPE0 |
--- src/Daemon/Daemon.cpp
+++ src/Daemon/Daemon.cpp
int main(int argc, char** argv)
if (inotify_fd == -1)
+ close_on_exec_on(inotify_fd);
if (inotify_add_watch(inotify_fd, DEBUG_DUMPS_DIR, IN_CREATE | IN_MOVED_TO) == -1)
| trivial: close inotify_fd on exec | disable compilation of the rest of socket code
src/Hooks/CCpp.cpp: do save abrtd's own coredumps, but carefully...
abrt-debuginfo-install: use --enablerepo=*-debug*
implement abrtd -t TIMEOUT_IN_SEC
fix small bug in plugin loading code
Report GUI: made more fields copyable - closed rhbz; tweaked wording
trailing whites... | TYPE0 |
--- src/applet/applet.c
+++ src/applet/applet.c
static problem_info_t *problem_info_new(const char *dir)
- problem_info_t *pi = xzalloc(sizeof(*pi));
+ problem_info_t *pi = g_new0(problem_info_t, 1);
pi->problem_data = problem_data_new();
problem_info_set_dir(pi, dir);
return pi;
static void problem... | applet: Use g_new0() instead of xzalloc() | applet: Remove status icon
applet: Use G_SOURCE_REMOVE in timeout callback
applet: Use symbolic icon instead of abrt's in notifications
spec: Bump required glib2 version
build: Launch configure after autogen.sh
applet: Use g_bus_own_name() for single-instance
applet: Fix typo in "cuurent"
applet: Remove pointless custo... | TYPE0 |
--- src/plugins/abrt-action-analyze-oops.c
+++ src/plugins/abrt-action-analyze-oops.c
static void hash_oops_str(char hash_str[SHA1_RESULT_LEN*2 + 1], char *oops_buf, const char *oops_ptr)
char *line = xstrndup(call_trace, end_line - call_trace);
char *p = skip_whitespace(line);
- /* ... | rhbz - abrt hashing on kernel backtraces needs improving | KerneloopsScanner.cpp: make a room for NULL byte
add example of tainted kernel module
throw when some members are missing in xmlrpc response
mv .gitignore from /doc to /doc/abrt-plugins
do not send all errors from xmlto to /dev/null
add OPT_GROUP option
backport xmalloc_fgets and xmalloc_fgetline
add 16k cap for commen... | TYPE0 |
--- lib/plugins/FileTransfer.cpp
+++ lib/plugins/FileTransfer.cpp
void CFileTransfer::Run(const char *pActionDir, const char *pArgs, int force)
if (strcmp(pArgs, "store") == 0)
+ if (!dirlist)
+ {
+ throw CABRTException(EXCEP_PLUGIN, "Can't open "FILETRANSFER_DIRLIST);
+ }
... | FileTransfer.cpp: add forgotten open error test | remove one redundant check | TYPE0 |
--- lib/Plugins/CCpp.cpp
+++ lib/Plugins/CCpp.cpp
void CAnalyzerCCpp::InstallDebugInfos(const std::string& pPackage)
pipe(pipein); /* error check? */
close(pipein[1]); close(pipeout[1]);
close(pipein[0]);
close(pipein[1]);
if (strstr(buff, "Total download size") != NULL)
- ... | two trivial fixlets in lib/Plugins/CCpp.cpp | style fix by popular (Zdenek's) demand
fixing whitespace damage, no code changes
rework unsafe handling of SIGINT/SIGTERM
CCpp.cpp: fix handling of pipes when we fork children
prevent leaking buf in some cases
Fix build system for the case where configure was run with non-default prefix
Be more paranoid about /proc/...... | TYPE0 |
--- src/plugins/abrt-action-install-debuginfo-to-abrt-cache.c
+++ src/plugins/abrt-action-install-debuginfo-to-abrt-cache.c
int main(int argc, char **argv)
if (u != getuid())
+ /* Use safe umask */
+ umask(0022);
| a-a-i-d-t-a-cache: sanitize umask | console-notifications: add timeout
testsuite: add selinux-policy to DontMatchComponents list in bugzilla.conf
set sending-sensitive-data option to 'yes' for analyze_RetraceServer event
spec: abrt-python is no longer noarch
gdb: disable loading of auto-loaded files
doc: add documentation for GetProblemData
spec: fix abr... | TYPE0 |
--- src/gui-gtk/abrt-gtk.c
+++ src/gui-gtk/abrt-gtk.c
GtkWidget *create_main_window(void)
- GtkWidget *btn_online_help = gtk_button_new_with_mnemonic(_("_Online Help"));
+ GtkWidget *btn_online_help = gtk_button_new_with_mnemonic(_("Online _Help"));
gtk_box_pack_end(GTK_BOX(hbox_help_close), btn_online_help... | abrt-gui: change the help accelerator to alt-H | GUI: center all dialogs on parent
minor cleanup after removing the old backtrace parser
made some more strings translatable rhbz
GUI: minor fix in plugin settings UI
GUI: fixed exception in plugin settings dialog rhbz
GUI: make the "install debuginfo" hint selectable rhbz
GUI: nicer after report message
async dbus meth... | TYPE1 |
--- src/hooks/abrt-hook-ccpp.c
+++ src/hooks/abrt-hook-ccpp.c
static bool dump_fd_info(const char *dest_filename, char *source_filename, int source_base_ofs, uid_t uid, gid_t gid)
- FILE *fp = fopen(dest_filename, "w");
+ FILE *fp = fopen(dest_filename, "wx");
if (!fp)
perror_msg("Can't change '%s' ... | ccpp: open file for dump_fd_info with O_EXCL | abrt-handle-event: don't use already freed memory
auto-reporting: add options to specify auth type
synchronize default dump dir mode with libreport
configu UI: use glade file extension instead of ui
testsuite: dbus-NewProblem: replace direct path /usr/bin/true by $(which true)
python: load the configuration from correc... | TYPE0 |
--- src/dbus/abrt-dbus.c
+++ src/dbus/abrt-dbus.c
static void handle_method_call(GDBusConnection *connection,
caller_uid = get_caller_uid(connection, invocation, caller);
if (g_strcmp0(method_name, "SetElement") == 0)
g_variant_get(parameters, "(&s&s&s)", &problem_id, &element, &value);
- if (el... | dbus: report invalid element names | autogen: move configure to the default case
plugins: add abrt-action-generate-machine-id
testsuite: test processing of vmcore-dmesg.txt
init: set Type of abrtd.service to dbus
gettext: fix the initialization in python scripts
provide tmpfiles.d configuration
testsuite: move dumpdir location from /tmp/XXXXX to /var/spoo... | TYPE0 |
--- src/daemon/Daemon.cpp
+++ src/daemon/Daemon.cpp
static gboolean server_socket_cb(GIOChannel *source, GIOCondition condition, gpointer ptr_unused)
if (socket == -1)
if (pid < 0)
- close(socket);
+ close(socket);
| perror has to be used immediately after failed syscall | dump_dir: dd_close was freeing unallocated pointer! fix that
plug a memory leak in trim_debug_dumps()
fixing two instances of dd->gid which I forgot to convert
concat_path_file: make it a C function, not C++
preparatory patch for dirsize.cpp -> dirsize.c conversion
abrt.spec: make /abrtd more "greppable"
abrtlib.h: inc... | TYPE1 |
--- src/plugins/rhbz.c
+++ src/plugins/rhbz.c
struct bug_info *rhbz_bug_info(struct abrt_xmlrpc *ax, int bug_id)
bz->bi_platform = rhbz_bug_read_item("platform", bug_item,
- ret = (int*)rhbz_bug_read_item("dup_id", bug_item,
+ ret = (int*)rhbz_bug_read_item("dupe_of", bug_item,
... | rhbz: get id of duplicate from correct field | report-gtk: update excluded elements check boxes before emergency analysis event
trac: don't use localizable error messages for a detection of the known errors
use gtk_show_uri() instead of own launcher
run_event: default callbacks for logging and errors
trac: remove forgotten text from report-gtk usage string
trakc : ... | TYPE0 |
--- src/lib/strbuf.c
+++ src/lib/strbuf.c
char *strtrimch(char *str, int ch)
if (!str)
char *tmp = str;
while (*tmp == ch)
++tmp;
- memmove(str, tmp, strlen(str));
+ memmove(str, tmp, strlen(tmp));
int i = strlen(str);
| strbuf::strtrimch() : memmove() reads bytes out of borders | track : fixed memory leak in event_xml_parse.c:text()
trakc : use macro with ISO date sample instead of literal to compute required size of arrays used as buffers in snprintf() function call
trakc : use macro with ISO date sample instead of literal to compute required size of arrays used as buffers in snprintf() functi... | TYPE0 |
--- src/lib/user_settings.c
+++ src/lib/user_settings.c
void set_user_setting(const char *name, const char *value)
+ if (!user_settings)
+ return;
g_hash_table_replace(user_settings, xstrdup(name), xstrdup(value));
else
}
{
+ if (!user_settings)
+ return NULL;
return g_hash_table... | allow get/set on uninitialized user settings | add report result formatting and parsing
make reporters use unified report result formatting (trac)
include spaces inside values parsed from config (trac)
report_problem_in_dir: fix report-cli options
wizard: align close button to left (bz)
report-cli: clarify -r description
wizard: disable only button box when event i... | TYPE0 |
--- src/gui-wizard-gtk/wizard.c
+++ src/gui-wizard-gtk/wizard.c
static void save_text_if_changed(const char *name, const char *new_value)
if (strcmp(new_value, old_value) != 0)
- problem_data_reload_from_dump_dir();
- update_gui_state_from_problem_data(/* don't update selected event */ 0);
static vo... | wizard: fix save users changes after reviewing dump dir files | testsuite: change test for make_description
ureport: add functionality to use consumer certificate
spec: update spec file to work with last commit
spec: update the spec file to work with the last commit
reporter-mantisbt: adds man pages for reporter-mantisbt
testsuite: fix problem_data_load_from_dump_dir test
spec: upd... | TYPE2 |
--- src/plugins/rhbz.c
+++ src/plugins/rhbz.c
xmlrpc_value *rhbz_get_member(const char *member, xmlrpc_value *xml)
xmlrpc_value *value = NULL;
xmlrpc_struct_find_value(&env, xml, member, &value);
+ if (!value)
+ error_msg_and_die("fatal: There is no member named '%s'", member);
return value;
| rhbz: die if missing mandatory member | xmlrpc: rising XMLRPC_XML_SIZE_LIMIT_DEFAULT up to 4 times
compare problem data by content of file (FILENAME_*)
fix configure on rhel6
build: add inclusion to testsuite to see abrt_curl.h
fix bt reuploading
make-descr: don't include superfluous FILENAME_REASON in comment; it's in summary
rhbz - bz 4.2 doesn't have 'bug... | TYPE0 |
--- src/include/ureport.h
+++ src/include/ureport.h
@@ -233,7 +233,7 @@ ureport_json_attachment_new(const char *bthash, const char *type, const char *da
- * @return False in case of any error; otherwise True
+ * @return True in case of any error; otherwise False
@@ -247,7 +247,7 @@ ureport_attach_string(const char *bth... | ureport: wrong description of two functions in ureport.h | testsuite: change test for make_description
testsuite: change test for make_description
workflow: add new workflows
testsuite: changed atlocal.in to work with last commit
make_desc: add reason to the list
testsuite: changed atlocal.in to work with last commit
lib: add function index_of_string_in_list
doc: updated manpa... | TYPE0 |
--- src/cli/cli-report.c
+++ src/cli/cli-report.c
static problem_data_t *load_problem_data_if_not_yet(problem_data_t *problem_data, const char *dump_dir_name)
if (!dd)
- problem_data_free(problem_data);
| cli: remove superfluous problem_data_free() call | fix typo in function name, remove unnecessary forward declaratioins
bz reporter: include ROOTDIR, OS_RELEASE_IN_ROOTDIR, EXECUTABLE elements
Make get_dirsize_find_largest_dir less talkative.
reporter-bz: do not needlessly open dd if -f; assorted small fixes
reporter-bz: require bz version match when searching for dups.... | TYPE0 |
--- src/include/workflow.h
+++ src/include/workflow.h
@@ -38,8 +38,19 @@ void free_workflow(workflow_t *w);
+
+/* Get a list of executed events configuration.
+ *
+ * @return A list of event_config_t *. Do not free the list.
+ */
+
+/* Get a list of the event names to execute.
+ *
+ * @return A list of char *. Free the... | workflows: add comments to ambiguous functions | translations: update zanata configuration
lib: parse list delimited by any character
spec: install ureport.h
track : report-gt - missing files delimited by commas
expand events from a chain and process expanded events separately
ureport: support HTTP Basic authentication
lib: add alternative dd functions accepting fds
... | TYPE1 |
--- src/plugins/reporter-mailx.c
+++ src/plugins/reporter-mailx.c
static void create_and_send_email(
+ /* Prevent mailx from creating dead.letter if sending fails. The file is
+ * useless in our case and if the reporter is called from abrtd, SELinux
+ * complains a lot about mailx touching ABRT data.
+ ... | mailx: stop creating dead.letter on mailx failures | track : report-gt - missing files delimited by commas
update the list of ignored words
mailx: print only one log message in notify_only mode
testsuite: complex testing of xml locales
wizard: extended the manual pages
testsuite: add test for strremovech(str, ch)
update CWD after stealing of a dump directory
plugins: por... | TYPE0 |
--- src/lib/create_dump_dir.c
+++ src/lib/create_dump_dir.c
LibreportError save_dump_dir_from_problem_data(problem_data_t *problem_data, char **problem_id, const char *base_dir_name)
if (dd_rename(dd, new_path) != 0)
- free(new_path);
+ free(new_path);
+ dd_close(dd);
+ free(new_path);
| add missing dd_close() to save_dump_dir_from_problem_data() | report_problem_in_dir() never uses report-only option (always perform analysis)
trac : fixed memory leak in is_comment_dup() function
rhbz : bugzillas are created according to rh bugzilla default template
track : add 'reporter' and 'related_packages' fields to ureports
track : fixed memory leak in find_best_bt_rating_i... | TYPE1 |
--- src/lib/json.c
+++ src/lib/json.c
static bool ureport_add_type(struct json_object *ur, problem_data_t *pd)
else if (strcmp(pd_item, "Python") == 0)
- else if (strcmp(pd_item, "Kerneloops") == 0)
+ else if (strcmp(pd_item, "Kerneloops") == 0 || strcmp(pd_item, "vmcore") == 0)
ureport_add_str(ur, ... | ureport: add conversion from abrt vmcore type to ureport KERNELOOPS type | strbuf::strtrimch() : memmove() reads bytes out of borders
bugzilla: make rhbz_new_bug() more legible
report-gtk: destroy global text cache only once
clear warnings after switching to a next page
uReport: detect missing type field at client side
dd: convert time at lock time
rhbz: show the description file in bugzilla ... | TYPE1 |
--- src/gui-wizard-gtk/wizard.c
+++ src/gui-wizard-gtk/wizard.c
@@ -751,7 +751,7 @@ static void tv_details_row_activated(
-#if (GTK_MAJOR_VERSION == 3 && GTK_MINOR_VERSION < 8)
+#if ((GTK_MAJOR_VERSION == 3 && GTK_MINOR_VERSION < 7) || (GTK_MAJOR_VERSION == 3 && GTK_MINOR_VERSION == 7 && GTK_MICRO_VERSION < 8))
| report-gtk: gtk_scrolled_window_add_with_viewport has been deprecated since gtk-3.7.8 | wizard : fixed problem with automatic changing of pages (call on_page_prepare directly)
create a copy of inserted keys in loaded files hash table
report-gtk: don't log THANKYOU message
rhbz: show a link to a page describing the ABRT configuration
report-cli: add event name prefix before question
trac: report-gtk: intro... | TYPE0 |
--- source/components/executer/exmisc.c
+++ source/components/executer/exmisc.c
@@ -2,7 +2,7 @@
- * $Revision: 1.127 $
+ * $Revision: 1.129 $
@@ -10,7 +10,7 @@
- * Some or all of this work - Copyright (c) 1999 - 2004, Intel Corp.
+ * Some or all of this work - Copyright (c) 1999 - 2005, Intel ... | Allow RefOf on the Debug object | fix PM1_CONTROL to pass register bits, so RegWrite can do special-case
Added -a and -c compiler output options
Add VAR_PACKAGE to case
Renamed Osd interfaces, renamed header files
Additional mutex and locking for GPE data structures
Support for method owner IDs
Added MCW comment for passing the Object into the Handler ... | TYPE0 |
--- source/common/adisasm.c
+++ source/common/adisasm.c
- * $Revision: 1.67 $
+ * $Revision: 1.68 $
ACPI_STATUS
+ char *FacsSuffix = "";
if (NewTable)
AcpiGbl_FADT = (void *) NewTable;
+ FacsSuffix = &AcpiGbl_FADT->OemTableId;
AC... | Special handling for FACS table "name" | date 2005.06.17.19.38.00; author rmoore1; state Exp;
date 2002.05.17.20.35.00; author rmoore1; state Exp;
Added 2003 copyright to the legal header
date 2002.12.13.22.38.00; author rmoore1; state Exp;
date 2001.12.12.00.13.00; author rmoore1; state Exp;
date 2000.03.28.18.35.00; author rmos... | TYPE0 |
--- source/components/namespace/nsxfname.c
+++ source/components/namespace/nsxfname.c
ACPI_STATUS
ACPI_HANDLE Parent,
- ACPI_HANDLE Scope = NULL;
+ NAME_TABLE_ENTRY *Scope = NULL;
if (Parent)
- Scope = Parent->Scope;
+ Scope = ((NAME_TABLE_ENTRY*) Parent)... | Fixed bug in AcpiGetHandle(): searching for a relative path always | automated code cleanup
Update and restructuring of field access code
Fix for 16-bit generation
Call to debugger for statistics gathering
global fix: declare functions not in headers as static
added unsigned integer to string function
update for new database structure
xface changes; cleanup
Code cleanup, added proc head... | TYPE0 |
--- source/components/events/evregion.c
+++ source/components/events/evregion.c
@@ -1,7 +1,7 @@
- * $Revision: 1.79 $
+ * $Revision: 1.80 $
@@ -148,7 +148,7 @@ AcpiEvInstallDefaultAddressSpaceHandlers (
- /*
+ /*
| Ran acpisrc source cleanup | date 2002.08.07.20.50.00; author rmoore1; state Exp;
Add ProcessorObj keyword
Update to use new debug macro that automatically inserts the procedure
Prefixed all #defines in acconfig.h with ACPI_
Removed extraneous (dead) functions
date 2000.08.31.22.20.00; author rmoore1; state Exp;
Misc compiler bug fixes... | TYPE0 |
--- source/compiler/aslmain.c
+++ source/compiler/aslmain.c
static void
+ printf (" -va Disable all errors and warnings (summary only)\n");
static int
Gbl_Acpi2 = TRUE;
BadCommandLine = TRUE;
Gbl_DebugFlag = TRUE;
Gbl_ParseOnlyFlag = TRUE;
BadCommandLine =... | iASL: Add option to display summary only. | Update comments in module header.
New: ACPICA documentation
New: Public GPE group enable/disable interfaces.
Fix possible memory leak in Unload() operator.
Update windows project files for new source files.
iASL: named objects within loop, part two.
Restructure bit register access functions.
iASL: Additional changes fo... | TYPE1 |
--- source/components/utilities/utalloc.c
+++ source/components/utilities/utalloc.c
void
MEMSET ((void *) ObjDesc, 0, sizeof (ACPI_OBJECT_INTERNAL));
- ObjDesc->Common.DataType = DESC_TYPE_ACPI_OBJ;
- ObjDesc->Common.Size = sizeof (ACPI_OBJECT_INTERNAL);
- ObjDesc->Common.Flags = AO_STATIC_ALLOCATION;
+... | Init static object reference count | Changed to generic 64-bit friendly data types
Fixed AmlDumpObjectDescriptor to only check DebugLevel and TraceLevel
Changed -o to affect all output files
Rename the opcode execution functions
Run _INI on ThermalZones
First definition and deployment of spin lock interfaces
new GCC doesn't like functions without args
Fix... | TYPE0 |
--- source/include/acpixf.h
+++ source/include/acpixf.h
@@ -270,7 +270,6 @@ INT32
-
| Modified various APIs to match our intent. | New procedure, LocalDeleteObject. Was DeleteObject in the interpreter
Converted all code to use the new (X) fields of the FADT.
date 2002.08.29.22.36.00; author agrover; state Exp;
Moved NsAllocateNte to nsalloc.c
Moved Method Stack constants to config.h from global.h
Support for new parser
New interface to init... | TYPE1 |
--- source/components/events/evgpe.c
+++ source/components/events/evgpe.c
- * $Revision: 1.32 $
+ * $Revision: 1.34 $
UINT32
- * Some or all of this work - Copyright (c) 1999 - 2003, Intel Corp.
+ * Some or all of this work - Copyright (c) 1999 - 2004, Intel Corp.
ACPI_GPE_XRUPT_INFO ... | Check for the case where there are no GPEs | Restructured package copy code
Support for FieldAttribute byte, merged Access/Lock/Update bits back
Some Lint changes; 16-bit changes
New ACPI_DEBUG_PRINT macro deployed. Much smaller implementation.
Another pass through the source to prefix all local types with "ACPI_"
Moved all Debugger globals to acglobal.h
Fix fo... | TYPE4 |
--- source/components/hardware/hwsleep.c
+++ source/components/hardware/hwsleep.c
- * $Revision: 1.14 $
+ * $Revision: 1.15 $
ACPI_STATUS
if (!ACPI_SUCCESS (Status))
PM1AControl = (UINT16) AcpiHwRegisterRead(ACPI_MTX_LOCK, PM1_CONTROL);
DEBUG_PRINT(ACPI_OK, ("Entering S%d\n", Sle... | don't try secondary PM_EN write if doing S1 | Added pointer/integer conversion macros to cleanup IA64 generation
Does not call localCleanup from Disable.
Added support/handlers for ACPI 2.0 opregions - CMOS, PCI_BAR
Removed _HID check for button devices. This is the responsibility of
Opcode class/type cleanup. Restructuring of math and logic AML
date 99.04.13... | TYPE0 |
--- source/components/parser/psparse.c
+++ source/components/parser/psparse.c
@@ -1,7 +1,7 @@
- * $Revision: 1.75 $
+ * $Revision: 1.76 $
@@ -1439,7 +1439,6 @@ AcpiPsParseAml (
-
| Code cleanup (acpisrc -c) | Opcode class/type cleanup. Restructuring of math and logic AML
Fixed include pathnames
date 2001.01.21.04.35.00; author psdiefen; state Exp;
Fixed exit macros
Automated code cleanup
Full implementation of RemoveGpeBlock
Renamed name verify routines
Splitting off dispatch code
Update and restructuring of f... | TYPE0 |
--- source/compiler/aslglobal.h
+++ source/compiler/aslglobal.h
- * $Revision: 1.15 $
+ * $Revision: 1.17 $
+ EXTERN UINT32 INIT_GLOBAL (Gbl_TempCount, 0);
+ EXTERN ASL_PARSE_NODE *Gbl_FirstLevelInsertionNode;
+ EXTERN ASL_EVENT_INFO AslGbl_Events[20];
| Support for Switch/Case added | Removed debug printf
Moved support for ElseIf from transform.c to the parser.
date 2000.09.28.20.54.00; author rmoore1; state Exp;
Update for static functions, cleanup
Error handling changes
Handle Return and Return() as Return(Zero)
Support for FieldAttribute byte, merged Access/Lock/Update bits back
date 200... | TYPE0 |
--- source/components/dispatcher/dswload2.c
+++ source/components/dispatcher/dswload2.c
@@ -308,7 +308,7 @@ AcpiDsLoad2BeginOp (
- "for Scope operator, changed to type ANY\n",
+ "for Scope operator, changed to type ANY",
--- source/components/dispatcher/dsobject.c
+++ source/components/dis... | Remove some extraneous newlines in ACPI_ERROR type calls.. | iASL: For -f option (force), allow non-ASCII characters in input.
Limit maximum time for Sleep() operator.
Update math module; no functional change.
Add semaphores to Linux/Unix application OSL.
Windows binaries: Update for version 20100806.
Disassembler: Add option to disable Buffer->ResourceTemplate disassembly.
Clea... | TYPE0 |
--- source/tools/acpiexec/aeexec.c
+++ source/tools/acpiexec/aeexec.c
- * $Revision: 1.107 $
+ * $Revision: 1.108 $
void
Status = AcpiAcquireGlobalLock (0xFFFF, &LockHandle);
+ Status = AcpiAcquireGlobalLock (0x5, &LockHandle); /* Should fail */
if (ACPI_FAILURE (Status))
| ACPICA: test timeout on global lock interface | Renamed checksum procedure
Fix for correct size of _CID struct
Additional restructuring and cleanup of namespace evaluation functions
Removed optional buffer validation; cleanup
Fix to allow embedded method declarations, BZ 5361
support for c99 uintptr_t
Fix various formatting issues
ASCII check now skips comments; no ... | TYPE0 |
--- source/components/namespace/nsnames.c
+++ source/components/namespace/nsnames.c
- * $Revision: 1.77 $
+ * $Revision: 1.78 $
ACPI_SIZE
NextNode = Node;
- while (NextNode != AcpiGbl_RootNode)
+ while (NextNode && (NextNode != AcpiGbl_RootNode))
Size += PATH_SEGMENT_LENG... | Fix for RefOf/DeRefOf issue. RefOf now returns an object of type | Renamed some of the basic data types to ACPI*
Source conversion tool
Changed all memory allocations to use Cm functions.
Better debug output for objects
Maximum FieldBitLength increased from 16 bits to 32.
Global variables prefixed with "AcpiGbl_"
Added method params to interface to InitAmlWalk
Comments from 07/18/00 c... | TYPE2 |
--- source/components/executer/exdump.c
+++ source/components/executer/exdump.c
@@ -358,6 +358,11 @@ AmlDumpOperand (
+ case AML_NAMEPATH_OP:
+ DEBUG_PRINT_RAW (ACPI_INFO, ("Lvalue.Nte->Name %x\n",
+ EntryDesc->Lvalue.Nte->Name));
+ break;
+
| Added AML_NAMEPATH_OP to AmlDumpOperand case statement. | Fixed a comment
date 2000.03.30.16.22.00; author psdiefen; state Exp;
Space IDs are output as strings now.
Fix for OFFSET and a new error message
Optimized the ACPI_OPERAND_OBJECT size
date 2000.11.02.23.17.00; author rmoore1; state Exp;
Source line printed for all errors. More options. added compi... | TYPE1 |
--- source/components/events/evxfregn.c
+++ source/components/events/evxfregn.c
@@ -139,6 +139,12 @@
+ * NOTE: This function should only be called after AcpiEnableSubsystem has
+ * been called. This is because any _REG methods associated with the Space ID
+ * are executed here, and these methods can only be safely exec... | Comment update; no functional change. | Debugger: fix possible hang when evaluating non-methods.
ACPI 4.0: iASL/Disassembler - IPMI keyword support.
Allow multiple backslash prefix in namepaths.
Fix reference count issue in NsRepairObject.
Update version to 20090320.
Delete obsolete 16-bit files.
iASL: Add typechecking for Return() values for predefined name... | TYPE0 |
--- source/include/platform/acwin.h
+++ source/include/platform/acwin.h
* $Revision: 1.27 $
- * $Revision: 1.27 $
+ * $Revision: 1.28 $
/*
+ /*! [End] no source code translation !*/
| ACPICA: Fix for Linux source translation | Replace OsQueueForExecution with OsExecute
Fixed error with resource type for QwordSpace
Support for disassembler external generation
Moved definition of ACPI_UINTPTR to actypes
Add check for type==DEVICE, restructure external interfaces to use common parameter validation. BZ 358
Prevent fault if output file could not ... | TYPE2 |
--- source/compiler/asllisting.c
+++ source/compiler/asllisting.c
- * $Revision: 1.24 $
+ * $Revision: 1.25 $
void
switch (Node->ParseOpcode)
OpInfo = AcpiPsGetOpcodeInfo (Node->AmlOpcode);
- OpClass = ACPI_GET_OP_CLASS (OpInfo);
+ OpClass = OpInfo->Class;
| Split opcode flags into separate class/type/flags fields | Set buffer children to point back to parent
date 2002.08.22.21.46.00; author rmoore1; state Exp;
update for new files, defines
date 2000.04.19.22.35.00; author rmoore1; state Exp;
Source line printed for all errors. More options. added compile time
empty #ifdef - buh-bye
Error handling, reduction of confl... | TYPE0 |
--- source/components/executer/exstore.c
+++ source/components/executer/exstore.c
@@ -206,12 +206,13 @@ AmlExecute (
-
+/*
+*/
| Fixes for ESG. | Phase 2 legal header.
Support for ACPI 2.0 SMBUS changes
Updates to integrate into MS VC++
New "Sleep" command to simulate sleep
Only delete field desc if it doesn't get stored.
Added another \n
Do not print dots ifndef ACPI_DEBUG_OUTPUT
Update for changed data structures (removed 8/16/32 overlay for
Install default ad... | TYPE0 |
--- source/components/executer/exfldio.c
+++ source/components/executer/exfldio.c
static ACPI_STATUS
ACPI_INTEGER *Value,
if (!Value)
Value = &LocalValue;
*Value = 0;
switch (ACPI_GET_OBJECT_TYPE (ObjDesc))
ACPI_DEBUG_PRINT ((ACPI_DB_BFIELD,
- ACPI_DEBUG_PR... | Update debug output for IndexField I/O. | Test suite: remove obsolete exception codes.
Update version to 20080514
Update logfile for version 20080609.
Removed unused include files from source files.
Debugger: fix possible hang when evaluating non-methods.
Add a mechanism to escape infinite AML While() loops.
Debugger: update tables command for unloaded tables.... | TYPE0 |
--- source/components/debugger/dbstats.c
+++ source/components/debugger/dbstats.c
* $Revision: 1.89 $
- * $Revision: 1.89 $
+ * $Revision: 1.90 $
+ AcpiOsPrintf ("AcpiObject %3d\n", sizeof (ACPI_OBJECT));
| Added additional object to SIZES command. | Changes required for update to Package contruction in interpreter.
Fixes for load() operator.
Fix for case where there is no incoming filename (iasl -g)
Remove global lock handler on AcpiTerminate.
ACPICA: IsResourceTemplate now returns ACPI_STATUS to differentiate the failure modes.
New interface added
Updated error m... | TYPE1 |
--- source/tools/acpiexec/aehandlers.c
+++ source/tools/acpiexec/aehandlers.c
ACPI_STATUS
Status = AcpiInstallNotifyHandler (ACPI_ROOT_OBJECT, ACPI_DEVICE_NOTIFY,
Status = AcpiGetHandle (NULL, "\\_SB", &Handle);
if (ACPI_SUCCESS (Status))
AE_CHECK_OK (AcpiAttachData, Status);
Status = AcpiDe... | AcpiExec: Add support to test attach/delete root node objects. | Tests: Update all copyrights to 2012.
Fix possible buffer overflow during a field unit read operation.
AcpiHelp: Add missing table terminator.
ACPI 5.0/TableCompiler: Support for new table info opcode.
Linux scripts: Make AcpiSrc utility compile optional.
AcpiXtract: Handle "empty" lines containing one or more spaces.
... | TYPE1 |
--- source/compiler/aslcodegen.c
+++ source/compiler/aslcodegen.c
- * $Revision: 1.60 $
+ * $Revision: 1.61 $
static void
ACPI_PARSE_OBJECT *Op)
if (Op->Asl.ParseOpcode == PARSEOP_DEFAULT_ARG)
Aml.Opcode = Op->Asl.AmlOpcode;
CgLocalWriteAmlData (Op, &Aml.OpcodeB... | Fix fault if package length too long to be encoded (BZ 432) | Moved common utility functions to utility directory
New struct name
Fixed some potential casting issues - use standard macros
Zeroth error message must be reserved/notused
Add support for DataTableRegion operator, was missing from named opcodes list. Cause "opcode not handled" error message in disassembly
Add additiona... | TYPE1 |
--- source/include/platform/acenv.h
+++ source/include/platform/acenv.h
@@ -224,8 +224,8 @@ typedef char *va_list;
-#define STRSTR(s1,s2) __strstr((char *) (s1), (char *) (s2))
-#define STRUPR(s) _strupr((char *) (s))
+#define STRSTR(s1,s2) _strstr((char *) (s1), (char *) (s2))
+#defin... | Changed _strupr to __strupr (two __) unable to link on WDM because | date 2002.04.16.20.54.00; author rmoore1; state Exp;
Another pass at removal of ACPI_HANDLE from low-level CA code
Removed KDT error string tables -- too hard to maintain!
Cleanup of method arg/local interfaces
Prefixed all macros with "ACPI_" to prevent collisions with local OS
Removed extraneous parameter, fixe... | TYPE1 |
--- source/components/executer/exmisc.c
+++ source/components/executer/exmisc.c
- * $Revision: 1.84 $
+ * $Revision: 1.85 $
ACPI_STATUS
ACPI_OPERAND_OBJECT **Operand = &WalkState->Operands[0];
if ((Op1Desc->Integer.Value > MAX_MATCH_OPERATOR) ||
(Op2Desc->Integer.... | Added NATIVE_UINT for switch statements, prevents switch on a 64-bit | Third pass to include lint changes/comments/cleanup.
Support for bit offset <--> byteoffset conversions
Pass ISR flag to internal interfaces
Ensured the source files are under VSS
Removed obsolete function
Lint fix for debug statement
fix length in converted string. Update string create interface
Removed ACPI_READ_ADR... | TYPE0 |
--- source/components/events/evgpe.c
+++ source/components/events/evgpe.c
UINT32
for (i = 0; i < GpeBlock->RegisterCount; i++)
GpeRegisterInfo = &GpeBlock->RegisterInfo[i];
+ /*
+ * Optimization: If there are no GPEs enabled within this
+ * register, we can safe... | GPE detect optimization - ignore unused GPE registers. | Tests: Add -cr iASL option to ASLTS makefile.
GetExternalPathname is no longer debug-only.
Increase max sempahores for windows OSL.
Conditionally compile AcpiSetFirmwareWakingVector64.
AcpiSrc: Add option to simply inject dual-license header.
Documents: Update for Data Table Compiler.
Update .gitignore file.
Fix PCI co... | TYPE0 |
--- source/components/events/evevent.c
+++ source/components/events/evevent.c
@@ -2,7 +2,7 @@
- * $Revision: 1.52 $
+ * $Revision: 1.53 $
@@ -124,7 +124,6 @@
-
| Cleanup - extraneous spaces and tab removal | Support for recursive method typing
date 2001.01.09.23.34.00; author rmoore1; state Exp;
Removed NATIVE_UINT from internal structures and some procedures.
Purged all references to Constants contained in reference objects.
Changed minimimum length from 6 to 5 for namepath optimization
Some Lint changes; 16-bit cha... | TYPE0 |
--- source/include/actypes.h
+++ source/include/actypes.h
@@ -1,7 +1,7 @@
- * $Revision: 1.134 $
+ * $Revision: 1.135 $
@@ -355,7 +355,7 @@ typedef UINT8 OBJECT_TYPE_INTERNAL;
- * Also, values exceeding the largest official ACPI ObjectType must not overlap with
+ * Also, values ex... | Ran acpisrc source cleanup | Support for hex/octal/misc escape sequences. Error on invalid escape.
Bug fixes from Novell
Overhaul of the NATIVE* types. renamed to ACPI_NATIVE*, eliminated
Checks if object is already on list before adding.
date 2001.02.14.23.56.00; author agrover; state Exp;
Major header file consolidation
Generation for Wi... | TYPE0 |
--- source/components/executer/exutils.c
+++ source/components/executer/exutils.c
@@ -2,7 +2,7 @@
- * $Revision: 1.116 $
+ * $Revision: 1.117 $
@@ -454,7 +454,7 @@ AcpiExEisaIdToString (
- * DESCRIPTOIN: Convert a number to string representation. Assumes string
+ * DESCRIPTION: Convert a numbe... | typo in comment | Automated code cleanup
Renamed some AML opcodes to indicate that they are internal ops only
date 2001.12.12.23.38.00; author rmoore1; state Exp;
Fixed token list
Bug Fixes for Linux version of compiler
date 2005.06.21.22.36.00; author rmoore1; state Exp;
Eliminated construction of full parse tree for main t... | TYPE0 |
--- source/components/namespace/nsdump.c
+++ source/components/namespace/nsdump.c
@@ -287,6 +287,13 @@ AcpiNsDumpOneObject (
+ if (!ThisNode)
+ {
+ ACPI_DEBUG_PRINT ((ACPI_DB_INFO, "Invalid object handle %p\n",
+ ObjHandle));
+ return (AE_OK);
+ }
+
| Add error check to debug object dump routine. | iASL: Fix to allow aliases within ASL namepaths.
acpisrc: Improve comment counting mechanism.
iASL: Additional changes for external methods.
Add OS/2 header file support.
Update lint batchfile to process entire ACPICA tree.
Move some additional symbols to public headers.
Test suite: remove obsolete exception codes.
Fix... | TYPE1 |
--- source/compiler/aslopcodes.c
+++ source/compiler/aslopcodes.c
- * $Revision: 1.68 $
+ * $Revision: 1.69 $
UINT32
ACPI_PARSE_OBJECT *Op)
if (AcpiGbl_IntegerByteWidth == 4)
if (AcpiGbl_IntegerByteWidth == 8)
if (Op->Asl.Value.Integer <= ACPI_UINT32_MAX... | warning and truncation for large integers in 32-bit tables | date 2000.11.10.21.10.00; author rmoore1; state Exp;
Update for new interfaces
Removed obsolete define and TBD
table fix, port to new core interfaces
change all functions of type ASL_WALK_CALLBACK to return ACPI_STATUS
date 2002.04.17.20.35.00; author rmoore1; state Exp;
date 2000.09.14.23.08.00; auth... | TYPE0 |
--- source/components/namespace/nsaccess.c
+++ source/components/namespace/nsaccess.c
@@ -188,8 +188,8 @@ AcpiNsRootInitialize (
- Status = AcpiNsLookup (NULL, (char *) InitVal->Name, InitVal->Type,
- ACPI_IMODE_LOAD_PASS2, ACPI_NS_NO_UPSEARCH,
+ Status = AcpiNsLookup (NULL, ACPI_CAST_PTR (char... | Fix deconstification warnings (-Wcast-qual) with AcpiNsRootInitialize(). | Reduce code duplication.
Work around an ancient GCC bug.
Use "uname -p" instead of "uname -m" to detect 64-bit processors on FreeBSD.
Fix deconstification warnings (-Wcast-qual) with function traces.
Move few platform-specific definitions from FreeBSD header files to acfreebsd.h.
Work around a Berkeley Yacc (byacc) bug... | TYPE2 |
--- source/components/debugger/dbdisply.c
+++ source/components/debugger/dbdisply.c
* $Revision: 1.81 $
- * $Revision: 1.81 $
+ * $Revision: 1.82 $
for (i = 0; i < NumArgs; i++)
- for (i = 0; i < NumArgs; i++)
+ for (i = 0; i < MTH_NUM_ARGS; i++)
| Display all Args - they can be used as locals | major overhaul of ACPI_TYPE and the use of internal types. Most were
Added option to override the table header Revision field
Support for creation of user (return) buffers
Update function headers
New error message
Fixes for SSDT disassembly
date 2000.10.25.14.07.00; author rmoore1; state Exp;
hwtimer - enable ex... | TYPE0 |
--- source/components/resources/rsutils.c
+++ source/components/resources/rsutils.c
- * $Revision: 1.22 $
+ * $Revision: 1.23 $
ACPI_STATUS
Status = AcpiRsCreateByteStream (InBuffer->Pointer, ByteStream,
Params[0]->Buffer.Pointer = ByteStream;
- ACPI_MEM_FREE (ByteStream);
| double deleting ByteStream - remove non-refcounted version | Don't abort on GPE overlap, just ignore the GPE1 block.
Use FindTable interface
Changed names of the major objects for clarity
Reference count fix.
Parse errors appear in listing file
Initial support for multiple object attachments and related interfaces
Pass walk state to the interpreter
Check for zero-length buffer
d... | TYPE0 |
--- source/components/executer/excreate.c
+++ source/components/executer/excreate.c
ACPI_STATUS
if (!FieldDesc)
FieldDesc->FieldUnit.Access = (UINT8) ACCESS_AnyAcc;
FieldDesc->FieldUnit.LockRule = (UINT8) GLOCK_NeverLock;
FieldDesc->FieldUnit.UpdateRule = (UINT8) UPDATE_Prese... | Added alignment and math macros | Added error checking after all mutex acquires and most mutex releases.
Restructured the name table data structure
Added ACPI_INTEGER data type
New GetHandle interface
Code cleanup (acpisrc -c)
Support for CondRefOf, better error unwinding
Restructured object store code, initial implementation of target
Added Function t... | TYPE0 |
--- tests/aapits/athardware.c
+++ tests/aapits/athardware.c
ACPI_STATUS
ACPI_PHYSICAL_ADDRESS PhysicalAddress =
if (ACPI_FAILURE(Status))
- Status = AcpiSetFirmwareWakingVector ((UINT32) PhysicalAddress);
+ Status = AcpiSetFirmwareWakingVector ((UINT32) PhysicalAddress, 0);
if (ACPI_FAILURE(Status... | aapts: Update for ACPICA interface change. | Fix several rare error messages.
Cleanup global variable that is used only by OSL code.
Update for non-configured ACPI_IS_DEBUG_ENABLED macro.
ASLTS: add test for overlapping opregions.
AcpiExec: Add check for correct context arg in region handler.
Add support for OS X in the Unix OSL.
Add more methods eligible for NUL... | TYPE0 |
--- source/tools/acpidump/apdump.c
+++ source/tools/acpidump/apdump.c
BOOLEAN
ACPI_TABLE_HEADER *Table)
if (!AcpiUtValidAcpiName (Table->Signature))
- if (Table->Length <= sizeof (ACPI_TABLE_HEADER))
+ if (Table->Length < sizeof (ACPI_TABLE_HEADER))
fprintf (stderr, "Table ... | AcpiDump: Allow tables that contain only an ACPI table header. | Add OS/2 header file support.
Update windows project files for new source files.
Update Linux-specific script files.
Load operator: re-instate most restrictions on incoming table signature.
Windows compatibility fix: same buffer/string store.
Unix makefiles: Update compiler options.
iASL: Fix namepath optimization prob... | TYPE0 |
--- source/compiler/aslcompile.c
+++ source/compiler/aslcompile.c
@@ -2,7 +2,7 @@
- * $Revision: 1.77 $
+ * $Revision: 1.78 $
@@ -684,7 +684,6 @@ CmCleanupAndExit (void)
-
| Exit with non-zero on error | date 2000.11.06.17.36.00; author rmoore1; state Exp;
date 2000.11.07.21.09.00; author rmoore1; state Exp;
Support for new AML debugger component
date 2000.03.22.15.41.00; author rmoore1; state Exp;
date 2002.06.28.05.15.00; author psdiefen; state Exp;
date 2000.06.13.18.23.00; autho... | TYPE0 |
--- source/components/hardware/hwregs.c
+++ source/components/hardware/hwregs.c
ACPI_STATUS
LockFlags = AcpiOsAcquireLock (AcpiGbl_HardwareLock);
if (ACPI_FAILURE (Status))
- goto UnlockAndExit;
+ AcpiOsReleaseLock (AcpiGbl_HardwareLock, LockFlags);
}
- UnlockAndExit:
- AcpiOsReleaseLock (Ac... | Hardware: Fix possible recursive locking in hwregs.c | TYPE2 | |
--- source/compiler/asltransform.c
+++ source/compiler/asltransform.c
@@ -2,7 +2,7 @@
- * $Revision: 1.27 $
+ * $Revision: 1.28 $
@@ -540,7 +540,10 @@ TrDoSwitch (
- * Change CaseOp() to: If (PredicateValue == CaseValue) {...}
+ * Change CaseOp() to: If (LEqua... | update a comment | date 99.05.17.23.13.00; author rmosgrov; state Exp;
date 2000.10.10.22.45.00; author rmoore1; state Exp;
Check parent for NAMED opcode
date 2000.06.19.22.50.00; author rmoore1; state Exp;
date 2002.04.16.20.54.00; author rmoore1; state Exp;
date 2002.04.26.16.29.00; author rmoore1... | TYPE0 |
--- source/components/namespace/nsload.c
+++ source/components/namespace/nsload.c
- * $Revision: 1.49 $
+ * $Revision: 1.51 $
ACPI_STATUS
- * Some or all of this work - Copyright (c) 1999, 2000, 2001, Intel Corp.
+ * Some or all of this work - Copyright (c) 1999 - 2002, Intel Corp.
ACP... | Added support for FADT, FACS in AcpiInstallTable. | Improved error messages
date 2000.08.29.19.56.00; author rmoore1; state Exp;
Removed the TBD that set the Handler context to the region object.
More scope override
added disasm include
date 99.08.10.16.17.00; author rmoore1; state Exp;
New init xfaces; JIT CreateField evaluation.
Changes to work interchan... | TYPE0 |
--- source/components/events/evgpeblk.c
+++ source/components/events/evgpeblk.c
ACPI_STATUS
ACPI_NAMESPACE_NODE *GpeDevice,
if (!GpeBlock)
WalkInfo.GpeBlock = GpeBlock;
GpeEnabledCount = 0;
if (GpeDevice == AcpiGbl_FadtGpeDevice)
GpeDevice = NULL;
for (j = 0; j < ACPI_GPE_REG... | Ensure GPEs are not enabled twice. | Move check for valid Thread ID structure.
Update FADT flag definitions.
Update version to 20100331.
Test suite: remove obsolete exception codes.
Linux OSL: cleanup/update/merge, add ACPI_THREAD_ID.
Remove unused ACPI register bit definition.
Fix for table load regression.
Update windows project files (add new aapits pr... | TYPE0 |
--- source/compiler/aslwalks.c
+++ source/compiler/aslwalks.c
ACPI_STATUS
ACPI_PARSE_OBJECT *Op,
ThisOpBtype = AnGetBtype (Op->Asl.Child);
if ((Op->Asl.Child->Asl.ParseOpcode == PARSEOP_METHODCALL) &&
- * Check for a recursive method call first.
+ * Ch... | iASL: Fix a possible fault in a Return statement | Eliminate extra call to NsGetParentNode.
ACPI 6.0: Add changes for MADT table.
Invalidate DdbHandle after table unload.
Module-level code: enable _REG execution in same scope.
Divergence script: Auto-select 32/64 versions of AcpiSrc utility.
Fix a couple issues with the local printf module.
AcpiXtract: Fix to handle em... | TYPE2 |
--- source/components/parser/psparse.c
+++ source/components/parser/psparse.c
ACPI_STATUS
if (PsHasCompletedScope (ParserState))
PsPopScope (ParserState, &Op, &Args);
if (!Op)
Opcode = PsPeekOpcode (ParserState);
PsGetNextArg (ParserState, *Args, &ArgCount);
... | Fix to support method references without mistaking them for method | Converted all code to use the new (X) fields of the FADT.
Alias creation not done here, done in load module
clean up interrupt handling and fixed event dispatch stuff
Update function headers
date 2001.10.09.23.12.00; author rmoore1; state Exp;
date 2001.01.09.23.34.00; author rmoore1; state Exp;
Restructure... | TYPE1 |
--- source/components/events/evregion.c
+++ source/components/events/evregion.c
- * $Revision: 1.120 $
+ * $Revision: 1.121 $
ACPI_STATUS
if ((Node->Type != ACPI_TYPE_DEVICE) &&
if (!ObjDesc)
- if (IS_THIS_OBJECT_TYPE (ObjDesc, ACPI_TYPE_DEVICE))
+ if (ObjDesc->Common.Type ==... | Macro rename and cleanup | ValidateBufferSize is now InitializeBuffer. Also, clears the caller
date 2000.05.11.22.31.00; author rmoore1; state Exp;
date 2004.05.25.19.59.00; author rmoore1; state Exp;
major overhaul of ACPI_TYPE and the use of internal types. Most were
Rename for clarity
Only set RootNode if the parse tree is compl... | TYPE0 |
--- source/include/acglobal.h
+++ source/include/acglobal.h
@@ -1,7 +1,7 @@
- * $Revision: 1.153 $
+ * $Revision: 1.154 $
@@ -132,7 +132,7 @@
-/*
+/*
| automated code cleanup | one more tweak
Another pass through the source to prefix all local types with "ACPI_"
increased cache depths
Major update for new disassembler (produces compilable ASL).
Fixed exit macros
New init xfaces; JIT CreateField evaluation.
New names for I/O and PCI OSD interfaces
Changed AE_EXIST to AE_ALREADY_EXISTS (more in... | TYPE0 |
--- source/include/amlresrc.h
+++ source/include/amlresrc.h
@@ -2,7 +2,7 @@
- * $Revision: 1.25 $
+ * $Revision: 1.26 $
@@ -123,6 +123,7 @@
+#define ASL_RESNAME_ACCESSSIZE "_ASZ"
@@ -381,7 +382,7 @@ typedef struct asl_general_register_desc
- UINT8 Rese... | Support for ACPI 3.0 Register macro, new parameter | Fixed a comment; cleanup
Removed concept of a "static" acpi internal object. This mechanism
16-bit warning removal
Standalone disassembler now uses namespace mgr for symbol table
Externalized 3 hardware interfaces
date 2005.06.21.22.35.00; author rmoore1; state Exp;
Added a debug statement
Externalized 3 hardwar... | TYPE0 |
--- source/tools/acpisrc/astable.c
+++ source/tools/acpisrc/astable.c
- * $Revision: 1.18 $
+ * $Revision: 1.19 $
{"INT8", "s8", REPLACE_WHOLE_WORD},
- " * Copyright (C) 2000 - 2007, R. Byron Moore\n"
+ " * Copyright (C) 2000 - 2008, Intel Corp.... | 2008 Copyright support added. | Fix for hang in ElseIf construct.
Removed extraneous code.
Fix to allow embedded method declarations, BZ 5361
Update version to 20070126
Added OEM table msg; misc cleanup
Fix various formatting issues
Increase number of _OSI strings
Removed extraneous(obsolete) global mutexes, renamed mutex defines
Fixes for load() ope... | TYPE0 |
--- source/components/executer/exutils.c
+++ source/components/executer/exutils.c
- * $Revision: 1.107 $
+ * $Revision: 1.109 $
UINT32
- * Some or all of this work - Copyright (c) 1999 - 2002, Intel Corp.
+ * Some or all of this work - Copyright (c) 1999 - 2003, Intel Corp.
ACPI_INTEGE... | fix DigitsNeeded for 0 (Takayoshi Kochi) | Fixed Divide - return value was broken until now.
check some return codes
Must set the node type when a new object is stored.
Simplified opcode checking for CreateXXXField; cleanup
Better error handling
Moved prototypes for "static" functions from headers into the defining
Cleanup via acpisrc -c
verify bits get set wh... | TYPE2 |
--- source/components/utilities/utalloc.c
+++ source/components/utilities/utalloc.c
@@ -121,8 +121,9 @@
-#define _THIS_MODULE "cmalloc.c"
+ MODULE_NAME ("cmalloc");
+
| Macro support to eliminate excessive debug string duplication | date 2000.11.06.21.00.00; author rmoore1; state Exp;
Renamed a macro
Prefixed C library macros (MEMSET, etc.) with "ACPI_".
Updated for missing text
date 2000.10.10.22.45.00; author rmoore1; state Exp;
Eliminated "Name Tables" and replaced with "Named Objects"
date 2000.11.14.23.40.00; author rmoore1;... | TYPE1 |
--- source/compiler/aslopcodes.c
+++ source/compiler/aslopcodes.c
static void
- ACPI_PLD_INFO PldInfo = {0};
+ ACPI_PLD_INFO PldInfo;
if (!Buffer)
+ ACPI_MEMSET (&PldInfo, 0, sizeof (ACPI_PLD_INFO));
PldInfo.Revision = (UINT8) Node->Asl.Child->Asl.Value.Integer;
... | iASL: Update for ToPLD macro. | Prevent possible allocation overrun during object copy.
iASL: Fix NULLs emitted in listing files.
Tests: Update/cleanup documentation.
Tests: Update apitest for OsPhysicalTableOverride.
Tests: Update ASLTS makefiles.
ACPI 5.0: Support for new FixedDMA descriptor.
Conditionally define a local variable that is used for d... | TYPE0 |
--- source/components/executer/exsystem.c
+++ source/components/executer/exsystem.c
ACPI_STATUS
- ACPI_STATUS Status;
+ ACPI_STATUS Status = AE_OK;
Status = AE_OK;
return (Status);
| Initialized Status, line 386. | date 99.02.16.17.56.00; author rmosgrov; state Exp;
date 2001.03.21.00.50.00; author agrover; state Exp;
Renamed "OpCode" to "Opcode"
Removed object and method stacks for the new parser
date 2001.01.09.23.34.00; author rmoore1; state Exp;
Buffer length fix, detabbed
Prefixed component IDs wit... | TYPE0 |
--- source/components/parser/psparse.c
+++ source/components/parser/psparse.c
- * $Revision: 1.124 $
+ * $Revision: 1.125 $
ACPI_STATUS
ACPI_FUNCTION_TRACE_PTR ("PsParseLoop", WalkState);
ParserState = &WalkState->ParserState;
WalkState->ArgTypes = 0;
if (AcpiPsHasComplet... | Fourth pass to include lint changes/comments/cleanup (64-bit) | Removed duplicitous local var inits
Major changes to produce .ASM and .C source/listing files
Renamed "OpCode" to "Opcode"
Changed names of the major objects for clarity
Header cleanup; Split debug switch into component_id and level
check to see if init succeeded
ifdef out AcpiDsDumpMethodInfo if not ACPI_DEBUG_OUTPUT... | TYPE1 |
--- source/components/namespace/nsaccess.c
+++ source/components/namespace/nsaccess.c
- * $Revision: 1.163 $
+ * $Revision: 1.164 $
ACPI_STATUS
+ ObjDesc->Mutex.Node = NewNode;
ACPI_OBJECT_TYPE Type,
+ UINT32 NumCarats;
if (*Path == (UI... | Init Mutex Node. Set proper type for single-nameseg case | Deployed new procedure to extract NS Node name and validate the node.
Changed a param
Optimized the ACPI_OPERAND_OBJECT size
update error message
Register ID fix
Removed WhyBuf mechanism, it was causing faults
Ran acpisrc source cleanup
date 2000.10.25.14.07.00; author rmoore1; state Exp;
Single Thread debugger s... | TYPE0 |
--- src/lib/Libifl/trq_auth.c
+++ src/lib/Libifl/trq_auth.c
@@ -998,6 +998,9 @@ int authorize_socket(
+ if (server_name != NULL)
+ free(server_name);
+
| TRQ-3017 Leak in trqauthd | TRQ-2660 - TORQUE not cleanup up jobs correctly after a qrerun
TRQ-2670 Server keeping jobs on node after job has been requeued
added TODO comment for NVIDIA GPU detection and allocation.
TRQ-2660 TORQUE is not cleaning up jobs correctly after a qrerun
TRQ-2464 and TRQ-2463. Valgrind invalid Read
TRQ-2647 NVIDIA gpu st... | TYPE3 |
--- src/lib/Libutils/numa_chip.cpp
+++ src/lib/Libutils/numa_chip.cpp
if (lprocs_per_task == 1)
+ if (lprocs_per_task == 0)
{
+ {
step = (processing_units_per_task/2) + 1;
+ step = 0;
step_remainder = 0;
+ step_remainder = processing_units_per_task;
}
+ place_count = 0;
else
... | Made it so cores or threads can be allocated on | more unit tests fixed
AC-7791 - Made some fixes for conditional compiles with
AC-8004 Removed requirement for hwloc 1.7.2 when compiling
TRQ-3014 Unable to submit from acl_hosts login nodes -- Georgia Tech 21588
TRQ-3220 Torque auto_node_np does not override internal proc count of node
fixed receive_mom_communication ... | TYPE0 |
--- src/resmom/requests.c
+++ src/resmom/requests.c
int req_stat_job(
snprintf(name, sizeof(name), "%s", preq->rq_ind.rq_status.rq_id);
- name[(PBS_MAXSVRJOBID > PBS_MAXDEST ? PBS_MAXSVRJOBID:PBS_MAXDEST)] = '\0';
+ name[sizeof(name) - 1] = '\0';
if ((name[0] == '\0') || (name[0] == '@'))
pjob = mom_find_jo... | Improved a line of code checked in earlier. | Improved a line of code checked in earlier.
Fix for TRQ-1838 - pbs_server is hung - deadlock.
TRQ-1325: Enable --with-debugging by default. To disable debug, use --with-debug=no.
Fix for TRQ-1786 - Server crash.
Fix for TRQ-1736 - pbs server coredumping.
Fixed compiling errors.
Fixed compilation & linkage problems with... | TYPE0 |
--- src/cmds/qstat.c
+++ src/cmds/qstat.c
void display_statjob(
if (p->name != NULL)
c = p->name;
while ((*c != '.') && (*c != '\0'))
c++;
if (*c == '.')
c++;
while((*c != '.') && (*c != '\0'))
c++;
if (*c == '.')
c++;... | Avoid reading/writing past the end of a buffer with display_job_server_suffix=false | Check the return value of close() to prevent data loss
Protect against multiple definitions of typedef pbs_net_t
Reduce the frequency in which the main loop runs
Have pbs_mom wait longer for ALPS reservations to clear
Fix a missing variable definition
Reduce unnecessary node state change logging
Don't add MIC COI inclu... | TYPE0 |
--- src/lib/Libifl/test/pbsD_connect/scaffolding.c
+++ src/lib/Libifl/test/pbsD_connect/scaffolding.c
@@ -144,3 +144,8 @@ char *pbse_to_txt(int err)
+
+int pbs_getaddrinfo(const char *hostname, struct addrinfo *in, struct addrinfo **out)
+ {
+ return(0);
+ }
| Fix an issue with a unit test. | Fix a bug in the race condition mom hierarchy fix.
Update gitignore again.
Fix a few more coverity issues.
TRQ-1826. The mpp* attributes weren't being passed down to the mom daemons, making it so that mppdepth wasn't set correctly for the ALPS reservation.
Fix another compile error. I don't know why I can't reproduce t... | TYPE2 |
--- src/server/test/mom_hierarchy_handler/scaffolding.c
+++ src/server/test/mom_hierarchy_handler/scaffolding.c
@@ -6,6 +6,7 @@
+#include "id_map.hpp"
@@ -13,6 +14,8 @@ threadpool_t *async_pool = NULL;
+threadpool_t *task_pool;
+id_map node_mapper;
@@ -294,6 +297,13 @@ int tcp_con... | Fix a unit test issue. | Restore temporarily setting the pbs_tcp_timeout to 0 when re-running do_tcp(). This is called repeatedly each time a tcp_connection is received.
Add two changes supplied by Martin Siegert. One fixes a problem of cpuset knowledge not being adequately recorded for sister nodes, another fixes an issue with whitespace in r... | TYPE2 |
--- src/server/test/pbsd_main/scaffolding.c
+++ src/server/test/pbsd_main/scaffolding.c
- void acct_close(void)
+ void acct_close(bool)
fprintf(stderr, "The call to acct_close needs to be mocked!!\n");
exit(1);
| Fixed unit test for pbsd_main. | TYPE0 | |
--- src/resmom/requests.c
+++ src/resmom/requests.c
void req_cpyfile(
- char localname_alt[MAXPATHLEN + 1];
pjob = mom_find_job(preq->rq_ind.rq_cpyfile.rq_jobid);
if (rc > 0)
pair != NULL;
if (pair->fp_flag == STDJOBFILE)
snprintf(localname, sizeof(localname), "%s/%s", spool_dir.c_... | TRQ-3575. Fix two Coverity errors related to the check-in. | Fix one more scaffolding issues.
Fix a problem in my TRQ-1943 fix. Make sure that sisters_contacted isn't null before attempting to derefence it.
fix some more unit test issues.
TRQ-3601. One more scaffolding correction.
Fix the travis-ci job to run the actual unit tests.
Fix an error when reserving mics for jobs.
TRQ-... | TYPE1 |
--- src/test/array_func/test_uut.c
+++ src/test/array_func/test_uut.c
job_array *get_job_array(
job_array *pa = (job_array *)calloc(1, sizeof(job_array));
+ return(pa);
Suite *array_func_suite(void)
tcase_add_test(tc_core, update_array_values_test);
+ tcase_add_test(tc_core, update_slot_values_test);
suite_ad... | Fix unit test. | TRQ-3197 - Support for RedHat7 SLES 12
Update version to 6.0.0.
Fix broken unit test.
TRQ-3330 - update script to remove destination before moving
TRQ-3226 - backport changes from 5.0-dev
Fix unit test build problems.
TRQ-2782 Divide job and array files into subdirectories
Fix coredump issue in nightly regressions.
TRQ... | TYPE2 |
--- src/server/test/node_manager/scaffolding.c
+++ src/server/test/node_manager/scaffolding.c
@@ -526,7 +526,6 @@ int decode_resc(
-id_map::~id_map(){}
--- src/server/test/node_func/scaffolding.c
+++ src/server/test/node_func/scaffolding.c
@@ -292,7 +292,6 @@ struct pbsnode *create_alps_subnode(struct pbsnode *parent, ... | Fixed unit tests. | Added a readme and license file.
TRQ-1426 Cleaned up and more thoroughly checked the routine against QA's improved test.
Fixed unit test.
fixed some runtime errors.
Fixed some coverity bugs.
TRQ-1426 Cleaned up and more thoroughly checked the routine against QA's improved test.
Fixed the version number.
trq-2227 trq-22... | TYPE0 |
--- src/server/job_func.c
+++ src/server/job_func.c
job *job_clone(
if (pnewjob == NULL)
oldid,taskid,hostname);
+ free(oldid);
| removed memory leak in job_clone() | added log rolling support into Liblog, added log_file_max_size and log_file_roll_depth attributes (set from qmgr) to control log rolling for pbs_server
added log_roll bug fix info to changelog
cleaned up a couple spots in darwin/mom_mach.c
removed a couple of double semicolons ;;
may now specify umask to use when crea... | TYPE3 |
--- src/test/momctl/test_uut.c
+++ src/test/momctl/test_uut.c
@@ -3,6 +3,7 @@
+#include "momctl.h"
| Added header to momctl unit test to resolve do_mom | TRQ-2993 Preemption broken when setting kill_delay option -- University of Washington 21353
TRQ-2434 Stray jobs on nodes. second fix
TRQ-2993 Preemption broken when setting kill_delay option -- University of Washington 21353
TRQ-3142 Increase maximum time for $prologalarm
TRQ-3142 Increase maximum time for $prologala... | TYPE1 |
--- src/test/process_mom_update/scaffolding.c
+++ src/test/process_mom_update/scaffolding.c
@@ -341,6 +341,11 @@ id_map::id_map(){}
+bool task_hosts_match(const char *one, const char *two)
+ {
+ return(true);
+ }
+
--- src/test/mom_mach/scaffolding.c
+++ src/test/mom_mach/scaffolding.c
@@ -290,6 +290,11 @@ void capt... | Fix two more unit test issues. | TRQ-3044. Revise the fix to set a locking hierarchy.
TRQ-2572. Make the --version outputs all follow the same format.
TRQ-1802. Make the job environment variable $PBS_NUM_NODES accurate on multi-req jobs as well as signle req jobs.
Fix a compile error when not enabling cgroups.
Fix a compile error when enabling cpusets... | TYPE2 |
--- src/resmom/mom_comm.c
+++ src/resmom/mom_comm.c
int handle_im_kill_job_radix_response(
job *pjob,
nodeid = disrsi(chan, &ret);
if (ret != DIS_SUCCESS)
np = &pjob->ji_sisters[nodeid+1]; /* yes this is klugey but the sisters are off by one on the index */
- if (pjob->ji_resources != NULL)... | TRQ-2924: Core dump fix | TYPE2 | |
--- src/resmom/start_exec.c
+++ src/resmom/start_exec.c
@@ -4147,7 +4147,7 @@ int TMomFinalizeChild(
- arg[aindex] = calloc(1,
+ arg[aindex] = (char *)calloc(1,
| Fix a g++ error with --enable-shell-use-argv | Fix deadlocks because we thought the default of the mutex_mgr constructor defaulted the locked value to true.
Fix a race condition between the time when the mom reports itself down (on a normal shutdown) and when its update reaches the server if using a mom hierarchy.
TRQ-1582. Fix a case where the routing queue retry ... | TYPE2 |
--- src/lib/Libattr/attr_fn_attr_req_info.c
+++ src/lib/Libattr/attr_fn_attr_req_info.c
int encode_attr_req_info(
const char *atname,
if ((attr == NULL) ||
(attr->at_val.at_ptr == NULL))
+ if (atname == NULL)
+ return(PBSE_BAD_PARAMETER);
std::vector<std::string> values;
attr_req_info ... | AC-8469 - fixed unit test to handle case where atname | TRQ-2632 pbsdsh requires FQDN even if other elements don't
TRQ-3026 Delays with preemption
Fixed unit test for mom_job_func
TRQ-3097 Failed qsub submissions count against max_user_queuable
Added code to be able to add NVIDIA GPU devices
TRQ-2434 Stray jobs on nodes. second fix
TRQ-2665 qrerun causing mom node to leav... | TYPE1 |
--- src/resmom/mom_main.c
+++ src/resmom/mom_main.c
+ #define TCP_READ_PROTO_TIMEOUT 2
int tcp_read_proto_version(
- pbs_tcp_timeout = 0;
+ pbs_tcp_timeout = TCP_READ_PROTO_TIMEOUT;
| Changed the pbs_tcp_timeout value when reading the protocol | Commiting updated headers
Added changes for C++ compatibility
comitting updated headers
Changed the pbs_tcp_timeout value when reading the protocol
fixed type cast problem
rpp was removed in the previous commit but includes for rpp.h were
Added (char *) to macro definition for GET_NEXT and GET_PRIOR
commiting changes f... | TYPE0 |
End of preview. Expand in Data Studio
README.md exists but content is empty.
- Downloads last month
- 9