Restore orphaned moe_fp32 solutions (reference-scalar + ggml baseline)

#2
by awu12 - opened
CMU l3 org

Problem

The two moe_fp32 definitions (moe_fp32_e60_k4_d2048_ff1408, moe_fp32_e64_k8_d2048_ff1024) were orphaned after the bf16 migration: the definitions exist but had no solutions (no reference-scalar, no baseline-llamacpp-arm), so they evaluate to NO_REFERENCE and cannot run.

Fix

Restore both solutions by adapting the matching moe_bf16 ones (identical SwiGLU-MoE logic, only the input dtype differs):

  • reference-scalar: uint16_t(bf16)-> float inputs; drop bf16_to_f32 widening (read fp32 directly).
  • ggml baseline: GGML_TYPE_BF16 -> GGML_TYPE_F32.

Verification

  • reference-scalar: compiled (clang -O2 -std=c++14), run via ctypes, output matches Definition.reference (max_rel_err = 1.9e-6).
  • ggml baseline: compiles against ggml on Graviton4 (clang-18, ggml headers) for both defs.

Note

Restores fp32 MoE parallel to gemm_fp32. If the bf16 migration intended to deprecate fp32 MoE instead, the alternative is to delete the two definitions β€” happy to flip. Does not touch any other def/solution/workload.

Ready to merge
This branch is ready to get merged automatically.

Sign up or log in to comment