codeLink string | commit_id string | commit_message string | func_after string | func_before string | lang string | project string | vul int64 |
|---|---|---|---|---|---|---|---|
https://github.com/chromium/chromium/commit/610f904d8215075c4681be4eb413f4348860bf9f | 610f904d8215075c4681be4eb413f4348860bf9f | Retrieve per host storage usage from QuotaManager.
R=kinuko@chromium.org
BUG=none
TEST=QuotaManagerTest.GetUsage
Review URL: http://codereview.chromium.org/8079004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103921 0039d316-1c4b-4281-b951-d872f2087c98 | void UsageTracker::DidGetClientGlobalUsage(StorageType type,
int64 usage,
int64 unlimited_usage) {
DCHECK_EQ(type, type_);
global_usage_.usage += usage;
global_usage_.unlimited_usage += unlimited_usage;
if (--global_usage_.pen... | void UsageTracker::DidGetClientGlobalUsage(StorageType type,
int64 usage,
int64 unlimited_usage) {
DCHECK_EQ(type, type_);
global_usage_.usage += usage;
global_usage_.unlimited_usage += unlimited_usage;
if (--global_usage_.pen... | C | Chrome | 0 |
https://github.com/chromium/chromium/commit/957973753ec4159003ff7930d946b7e89c7e09f3 | 957973753ec4159003ff7930d946b7e89c7e09f3 | Make NotifyHeadersComplete the last call in the function.
BUG=82903
Review URL: http://codereview.chromium.org/7038017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85719 0039d316-1c4b-4281-b951-d872f2087c98 | void BlobURLRequestJob::DidRead(int result) {
if (result < 0) {
NotifyFailure(net::ERR_FAILED);
return;
}
SetStatus(net::URLRequestStatus()); // Clear the IO_PENDING status
AdvanceBytesRead(result);
if (!read_buf_remaining_bytes_) {
int bytes_read = ReadCompleted();
NotifyReadComplete(bytes... | void BlobURLRequestJob::DidRead(int result) {
if (result < 0) {
NotifyFailure(net::ERR_FAILED);
return;
}
SetStatus(net::URLRequestStatus()); // Clear the IO_PENDING status
AdvanceBytesRead(result);
if (!read_buf_remaining_bytes_) {
int bytes_read = ReadCompleted();
NotifyReadComplete(bytes... | C | Chrome | 0 |
https://github.com/chromium/chromium/commit/27c68f543e5eba779902447445dfb05ec3f5bf75 | 27c68f543e5eba779902447445dfb05ec3f5bf75 | Revert of Add accelerated VP9 decode infrastructure and an implementation for VA-API. (patchset #7 id:260001 of https://codereview.chromium.org/1318863003/ )
Reason for revert:
I think this patch broke compile step for Chromium Linux ChromeOS MSan Builder.
First failing build:
http://build.chromium.org/p/chromium.mem... | Vp9Parser::~Vp9Parser() {}
| Vp9Parser::~Vp9Parser() {}
| C | Chrome | 0 |
https://github.com/chromium/chromium/commit/2fb4f2c9c461551d43fdfa28ef4c960da81a47dd | 2fb4f2c9c461551d43fdfa28ef4c960da81a47dd | Gate support for certain EOTFs/primaries/matrices on color management / hdr flags
Creates a new class VideoColorSpace specifically for encoding color spaces
according to ISO/IEC 23001-8.
Plumb this color space through from parsing to validation.
BUG=687627
Review-Url: https://codereview.chromium.org/2742113002
Cr-C... | VideoCodec StringToVideoCodec(const std::string& codec_id) {
std::vector<std::string> elem = base::SplitString(
codec_id, ".", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
if (elem.empty())
return kUnknownVideoCodec;
VideoCodecProfile profile = VIDEO_CODEC_PROFILE_UNKNOWN;
uint8_t level = 0;
Vi... | VideoCodec StringToVideoCodec(const std::string& codec_id) {
std::vector<std::string> elem = base::SplitString(
codec_id, ".", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
if (elem.empty())
return kUnknownVideoCodec;
VideoCodecProfile profile = VIDEO_CODEC_PROFILE_UNKNOWN;
uint8_t level = 0;
gf... | C | Chrome | 1 |
https://github.com/chromium/chromium/commit/df831400bcb63db4259b5858281b1727ba972a2a | df831400bcb63db4259b5858281b1727ba972a2a | WebKit2: Support window bounce when panning.
https://bugs.webkit.org/show_bug.cgi?id=58065
<rdar://problem/9244367>
Reviewed by Adam Roben.
Make gestureDidScroll synchronous, as once we scroll, we need to know
whether or not we are at the beginning or end of the scrollable document.
If we are at eith... | void WebPageProxy::didChooseFilesForOpenPanel(const Vector<String>& fileURLs)
{
if (!isValid())
return;
#if ENABLE(WEB_PROCESS_SANDBOX)
for (size_t i = 0; i < fileURLs.size(); ++i) {
SandboxExtension::Handle sandboxExtensionHandle;
SandboxExtension::createHandle(fileURLs[i], SandboxExte... | void WebPageProxy::didChooseFilesForOpenPanel(const Vector<String>& fileURLs)
{
if (!isValid())
return;
#if ENABLE(WEB_PROCESS_SANDBOX)
for (size_t i = 0; i < fileURLs.size(); ++i) {
SandboxExtension::Handle sandboxExtensionHandle;
SandboxExtension::createHandle(fileURLs[i], SandboxExte... | C | Chrome | 0 |
https://github.com/chromium/chromium/commit/6834289784ed45b5524de0fb7ef43ae283b0d6d3 | 6834289784ed45b5524de0fb7ef43ae283b0d6d3 | Output silence if the MediaElementAudioSourceNode has a different origin
See http://webaudio.github.io/web-audio-api/#security-with-mediaelementaudiosourcenode-and-cross-origin-resources
Two new tests added for the same origin and a cross origin source.
BUG=313939
Review URL: https://codereview.chromium.org/5204330... | void AudioContext::derefUnfinishedSourceNodes()
{
ASSERT(isMainThread());
for (unsigned i = 0; i < m_referencedNodes.size(); ++i)
m_referencedNodes.at(i)->breakConnection();
m_referencedNodes.clear();
}
| void AudioContext::derefUnfinishedSourceNodes()
{
ASSERT(isMainThread());
for (unsigned i = 0; i < m_referencedNodes.size(); ++i)
m_referencedNodes.at(i)->breakConnection();
m_referencedNodes.clear();
}
| C | Chrome | 0 |
https://github.com/chromium/chromium/commit/aac449e7154720b895ff1e7f3497c2ce95ae1a5a | aac449e7154720b895ff1e7f3497c2ce95ae1a5a | POSIX: make sure that we never pass directory descriptors into the sandbox.
BUG=43304
http://codereview.chromium.org/2733011/show
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49446 0039d316-1c4b-4281-b951-d872f2087c98 | void Channel::ChannelImpl::OnFileCanWriteWithoutBlocking(int fd) {
if (!ProcessOutgoingMessages()) {
Close();
listener_->OnChannelError();
}
}
| void Channel::ChannelImpl::OnFileCanWriteWithoutBlocking(int fd) {
if (!ProcessOutgoingMessages()) {
Close();
listener_->OnChannelError();
}
}
| C | Chrome | 0 |
https://github.com/chromium/chromium/commit/a03d4448faf2c40f4ef444a88cb9aace5b98e8c4 | a03d4448faf2c40f4ef444a88cb9aace5b98e8c4 | Introduce background.scripts feature for extension manifests.
This optimizes for the common use case where background pages
just include a reference to one or more script files and no
additional HTML.
BUG=107791
Review URL: http://codereview.chromium.org/9150008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@... | void TestingAutomationProvider::ClickAppModalDialogButton(int button,
bool* success) {
*success = false;
NativeAppModalDialog* native_dialog =
AppModalDialogQueue::GetInstance()->active_dialog()->native_dialog();
if (native_dialog &&
(native_d... | void TestingAutomationProvider::ClickAppModalDialogButton(int button,
bool* success) {
*success = false;
NativeAppModalDialog* native_dialog =
AppModalDialogQueue::GetInstance()->active_dialog()->native_dialog();
if (native_dialog &&
(native_d... | C | Chrome | 0 |
https://github.com/chromium/chromium/commit/8a50f99c25fb70ff43aaa82b6f9569db383f0ca8 | 8a50f99c25fb70ff43aaa82b6f9569db383f0ca8 | [Sync] Rework unit tests for ChromeInvalidationClient
In particular, add unit tests that would have caught bug 139424.
Dep-inject InvalidationClient into ChromeInvalidationClient.
Use the function name 'UpdateRegisteredIds' consistently.
Replace some mocks with fakes.
BUG=139424
Review URL: https://chromiumcoder... | ChromeInvalidationClientTest()
: kBookmarksId_(kChromeSyncSourceId, "BOOKMARK"),
kPreferencesId_(kChromeSyncSourceId, "PREFERENCE"),
kExtensionsId_(kChromeSyncSourceId, "EXTENSION"),
| ChromeInvalidationClientTest()
: fake_push_client_(new notifier::FakePushClient()),
client_(scoped_ptr<notifier::PushClient>(fake_push_client_)),
kBookmarksId_(kChromeSyncSourceId, "BOOKMARK"),
kPreferencesId_(kChromeSyncSourceId, "PREFERENCE"),
kExtensionsId_(kChromeSyncSourc... | C | Chrome | 1 |
https://github.com/chromium/chromium/commit/364fb6e517fc4fbc8196a4afba4f77b3d5300c3e | 364fb6e517fc4fbc8196a4afba4f77b3d5300c3e | Add InputMethodObserver support into InputMethodBase
This is a preparation CL to fix issue 164964.
Following observer callbacks are defined but not yet
supported by ui::InputMethodBase and its sub classes.
- InputMethodObserver::OnCaretBoundsChanged
- InputMethodObserver::OnInputLocaleChanged
This CL makes these cal... | void InputMethodBase::SetDelegate(internal::InputMethodDelegate* delegate) {
delegate_ = delegate;
}
| void InputMethodBase::SetDelegate(internal::InputMethodDelegate* delegate) {
delegate_ = delegate;
}
| C | Chrome | 0 |
https://github.com/chromium/chromium/commit/820957a3386e960334be3b93b48636e749d38ea3 | 820957a3386e960334be3b93b48636e749d38ea3 | Make WebContentsDelegate::OpenColorChooser return NULL on failure
Changing WebContentsDelegate::OpenColorChooser to return NULL on failure so we don't put the same ColorChooser into two scoped_ptrs(WebContentsImpl::color_chooser_)
BUG=331790
Review URL: https://codereview.chromium.org/128053002
git-svn-id: svn://sv... | int WebContentsImpl::CreateSwappedOutRenderView(
SiteInstance* instance) {
return GetRenderManager()->CreateRenderFrame(instance, MSG_ROUTING_NONE,
true, true);
}
| int WebContentsImpl::CreateSwappedOutRenderView(
SiteInstance* instance) {
return GetRenderManager()->CreateRenderFrame(instance, MSG_ROUTING_NONE,
true, true);
}
| C | Chrome | 0 |
https://github.com/chromium/chromium/commit/74c1ec481b33194dc7a428f2d58fc89640b313ae | 74c1ec481b33194dc7a428f2d58fc89640b313ae | Fix glGetFramebufferAttachmentParameteriv so it returns
current names for buffers.
TEST=unit_tests and conformance tests
BUG=none
Review URL: http://codereview.chromium.org/3135003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55831 0039d316-1c4b-4281-b951-d872f2087c98 | GLES2DecoderImpl::GLES2DecoderImpl(ContextGroup* group)
: GLES2Decoder(group),
error_bits_(0),
util_(0), // TODO(gman): Set to actual num compress texture formats.
pack_alignment_(4),
unpack_alignment_(4),
attrib_0_buffer_id_(0),
attrib_0_size_(0),
active_texture_unit_(0),... | GLES2DecoderImpl::GLES2DecoderImpl(ContextGroup* group)
: GLES2Decoder(group),
error_bits_(0),
util_(0), // TODO(gman): Set to actual num compress texture formats.
pack_alignment_(4),
unpack_alignment_(4),
attrib_0_buffer_id_(0),
attrib_0_size_(0),
active_texture_unit_(0),... | C | Chrome | 0 |
https://github.com/chromium/chromium/commit/a3987c8b93d3abbba6ea4e438493bf996fff66b7 | a3987c8b93d3abbba6ea4e438493bf996fff66b7 | Make Surface creation lazy for OffscreenCanvasFrameReceiverImpl
This CL shifts the SurfaceFactory pointer and SurfaceFactoryClient implementation
from OffscreenCanvasSurfaceImpl to OffscreenCanvasFrameReceiverImpl to
facilitate resource handling after compositor frame is submitted. As a result,
surface on browser is ... | void CanvasSurfaceLayerBridgeClientImpl::asyncSatisfy(const cc::SurfaceSequence& sequence)
{
m_service->Satisfy(sequence);
}
| void CanvasSurfaceLayerBridgeClientImpl::asyncSatisfy(const cc::SurfaceSequence& sequence)
{
m_service->Satisfy(sequence);
}
| C | Chrome | 0 |
https://github.com/chromium/chromium/commit/a3e2afaedd8190398ae45ccef34fcdee00fb19aa | a3e2afaedd8190398ae45ccef34fcdee00fb19aa | Fixed crash related to cellular network payment plan retreival.
BUG=chromium-os:8864
TEST=none
Review URL: http://codereview.chromium.org/4690002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65405 0039d316-1c4b-4281-b951-d872f2087c98 | virtual bool GetWifiAccessPoints(WifiAccessPointVector* result) {
if (!EnsureCrosLoaded())
return false;
DeviceNetworkList* network_list = GetDeviceNetworkList();
if (network_list == NULL)
return false;
result->clear();
result->reserve(network_list->network_size);
const base::Time ... | virtual bool GetWifiAccessPoints(WifiAccessPointVector* result) {
if (!EnsureCrosLoaded())
return false;
DeviceNetworkList* network_list = GetDeviceNetworkList();
if (network_list == NULL)
return false;
result->clear();
result->reserve(network_list->network_size);
const base::Time ... | C | Chrome | 0 |
https://github.com/chromium/chromium/commit/c4363d1ca65494cb7b271625e1ff6541a9f593c9 | c4363d1ca65494cb7b271625e1ff6541a9f593c9 | ozone: evdev: Add a couple more trace events
Add trace event inside each read notification for evdev.
BUG=none
TEST=chrome://tracing in link_freon
Review URL: https://codereview.chromium.org/1110693003
Cr-Commit-Position: refs/heads/master@{#327110} | bool EventConverterEvdevImpl::HasCapsLockLed() const {
return has_caps_lock_led_;
}
| bool EventConverterEvdevImpl::HasCapsLockLed() const {
return has_caps_lock_led_;
}
| C | Chrome | 0 |
https://github.com/chromium/chromium/commit/2953a669ec0a32a25c6250d34bf895ec0eb63d27 | 2953a669ec0a32a25c6250d34bf895ec0eb63d27 | Avoid an overflow in harfbuzz-myanmar.c
Adds a guard to prevent invalid assignment.
BUG=108006
TEST=manually with ASAN.
Review URL: http://codereview.chromium.org/8997001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115859 0039d316-1c4b-4281-b951-d872f2087c98 | HB_Bool HB_MyanmarShape(HB_ShaperItem *item)
{
HB_Bool openType = FALSE;
unsigned short *logClusters = item->log_clusters;
HB_ShaperItem syllable = *item;
int first_glyph = 0;
int sstart = item->item.pos;
int end = sstart + item->item.length;
int i = 0;
assert(item->item.script == HB_... | HB_Bool HB_MyanmarShape(HB_ShaperItem *item)
{
HB_Bool openType = FALSE;
unsigned short *logClusters = item->log_clusters;
HB_ShaperItem syllable = *item;
int first_glyph = 0;
int sstart = item->item.pos;
int end = sstart + item->item.length;
int i = 0;
assert(item->item.script == HB_... | C | Chrome | 0 |
https://github.com/chromium/chromium/commit/961d0cda4cfc3bcf04aa48ccc32772d63af12d9b | 961d0cda4cfc3bcf04aa48ccc32772d63af12d9b | Extract generation logic from the accessory controller into a separate one
This change adds a controller that is responsible for mediating
communication between ChromePasswordManagerClient and
PasswordAccessoryController for password generation. It is also
responsible for managing the modal dialog used to present the ... | void ChromePasswordManagerClient::PasswordFormsParsed(
const std::vector<autofill::PasswordForm>& forms) {
if (!password_manager::bad_message::CheckChildProcessSecurityPolicy(
password_manager_driver_bindings_.GetCurrentTargetFrame(), forms,
BadMessageReason::CPMD_BAD_ORIGIN_FORMS_PARSED))
... | void ChromePasswordManagerClient::PasswordFormsParsed(
const std::vector<autofill::PasswordForm>& forms) {
if (!password_manager::bad_message::CheckChildProcessSecurityPolicy(
password_manager_driver_bindings_.GetCurrentTargetFrame(), forms,
BadMessageReason::CPMD_BAD_ORIGIN_FORMS_PARSED))
... | C | Chrome | 0 |
https://github.com/chromium/chromium/commit/3eb1f512d8646db3a70aaef108a8f5ad8b3f013d | 3eb1f512d8646db3a70aaef108a8f5ad8b3f013d | 2010-06-18 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
noAccess url schemes block access to inline stylesheets
https://bugs.webkit.org/show_bug.cgi?id=32309
Test that data URLs can access their inline style sheets.
* http/tests/security/data-url-inline.css-expec... | CSSRule *CSSStyleSheet::ownerRule() const
{
return (parent() && parent()->isRule()) ? static_cast<CSSRule*>(parent()) : 0;
}
| CSSRule *CSSStyleSheet::ownerRule() const
{
return (parent() && parent()->isRule()) ? static_cast<CSSRule*>(parent()) : 0;
}
| C | Chrome | 0 |
https://github.com/chromium/chromium/commit/b9e2ecab97a8a7f3cce06951ab92a3eaef559206 | b9e2ecab97a8a7f3cce06951ab92a3eaef559206 | Do not discount a MANUAL_SUBFRAME load just because it involved
some redirects.
R=brettw
BUG=21353
TEST=none
Review URL: http://codereview.chromium.org/246073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27887 0039d316-1c4b-4281-b951-d872f2087c98 | bool NavigationController::IsURLInPageNavigation(const GURL& url) const {
NavigationEntry* last_committed = GetLastCommittedEntry();
if (!last_committed)
return false;
return AreURLsInPageNavigation(last_committed->url(), url);
}
| bool NavigationController::IsURLInPageNavigation(const GURL& url) const {
NavigationEntry* last_committed = GetLastCommittedEntry();
if (!last_committed)
return false;
return AreURLsInPageNavigation(last_committed->url(), url);
}
| C | Chrome | 0 |
https://github.com/chromium/chromium/commit/ea3d1d84be3d6f97bf50e76511c9e26af6895533 | ea3d1d84be3d6f97bf50e76511c9e26af6895533 | Fix passing pointers between processes.
BUG=31880
Review URL: http://codereview.chromium.org/558036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37555 0039d316-1c4b-4281-b951-d872f2087c98 | void WebPluginDelegateStub::CreateSharedBuffer(
size_t size,
base::SharedMemory* shared_buf,
base::SharedMemoryHandle* remote_handle) {
if (!shared_buf->Create(std::wstring(), false, false, size)) {
NOTREACHED();
return;
}
if (!shared_buf->Map(size)) {
NOTREACHED();
shared_buf->Close()... | void WebPluginDelegateStub::CreateSharedBuffer(
size_t size,
base::SharedMemory* shared_buf,
base::SharedMemoryHandle* remote_handle) {
if (!shared_buf->Create(std::wstring(), false, false, size)) {
NOTREACHED();
return;
}
if (!shared_buf->Map(size)) {
NOTREACHED();
shared_buf->Close()... | C | Chrome | 0 |
https://github.com/chromium/chromium/commit/a5333583f14284a411abac2fef7caed889a8bba3 | a5333583f14284a411abac2fef7caed889a8bba3 | Wire InstallFinished and add some InstallEvent.waitUntil tests
BUG=285976
TEST=content_browsertests:ServiceWorkerVersionBrowserTest.Install*
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250804
Review URL: https://codereview.chromium.org/153553008
git-svn-id: svn://svn.chromium.org/chrome/trun... | void EmbeddedWorkerContextClient::workerContextDestroyed() {
script_context_.reset();
main_thread_proxy_->PostTask(
FROM_HERE,
base::Bind(&CallWorkerContextDestroyedOnMainThread,
embedded_worker_id_));
}
| void EmbeddedWorkerContextClient::workerContextDestroyed() {
script_context_.reset();
main_thread_proxy_->PostTask(
FROM_HERE,
base::Bind(&CallWorkerContextDestroyedOnMainThread,
embedded_worker_id_));
}
| C | Chrome | 0 |
https://github.com/chromium/chromium/commit/3b7ff00418c0e7593d42e5648ba39397e23fe2f9 | 3b7ff00418c0e7593d42e5648ba39397e23fe2f9 | sync: ensure sync init path doesn't block on CheckTime
The call to RequestEarlyExit (which calls Abort) only happens if the SyncBackendHost has received the initialization callback from the SyncManager. But during init, the SyncManager could make a call to CheckTime, meaning that call would never be aborted. This pa... | bool SyncManager::SyncInternal::UpdateCryptographerFromNigori() {
DCHECK(initialized_);
syncable::ScopedDirLookup lookup(dir_manager(), username_for_share());
if (!lookup.good()) {
NOTREACHED() << "BootstrapEncryption: lookup not good so bailing out";
return false;
}
if (!lookup->initial_sync_ended_fo... | bool SyncManager::SyncInternal::UpdateCryptographerFromNigori() {
DCHECK(initialized_);
syncable::ScopedDirLookup lookup(dir_manager(), username_for_share());
if (!lookup.good()) {
NOTREACHED() << "BootstrapEncryption: lookup not good so bailing out";
return false;
}
if (!lookup->initial_sync_ended_fo... | C | Chrome | 0 |
https://github.com/chromium/chromium/commit/f2f703241635fa96fa630b83afcc9a330cc21b7e | f2f703241635fa96fa630b83afcc9a330cc21b7e | CrOS Shelf: Get rid of 'split view' mode for shelf background
In the new UI, "maximized" and "split view" are treated the same in
specs, so there is no more need for a separate "split view" mode. This
folds it into the "maximized" mode.
Note that the only thing that _seems_ different in
shelf_background_animator is S... | bool ShelfLayoutManager::CanStartFullscreenAppListDrag(
float scroll_y_hint) const {
if (!shelf_->IsHorizontalAlignment())
return false;
if (!IsVisible())
return false;
if (shelf_widget_->IsShowingOverflowBubble())
return false;
if (is_app_list_visible_)
return false;
if (scroll_y_hint... | bool ShelfLayoutManager::CanStartFullscreenAppListDrag(
float scroll_y_hint) const {
if (!shelf_->IsHorizontalAlignment())
return false;
if (!IsVisible())
return false;
if (shelf_widget_->IsShowingOverflowBubble())
return false;
if (is_app_list_visible_)
return false;
if (scroll_y_hint... | C | Chrome | 0 |
https://github.com/chromium/chromium/commit/ea994548ed483e234a6fadd0cbdfa10d58b75cef | ea994548ed483e234a6fadd0cbdfa10d58b75cef | Fix integer overflow in software compositor
Ensure that the size mapped from the renderer
process for the software frame is not less than
expected due to integer overflow.
BUG=348332
Review URL: https://codereview.chromium.org/196283018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257417 0039d316-1c4b-4281-b... | bool SoftwareFrameManager::SwapToNewFrame(
uint32 output_surface_id,
const cc::SoftwareFrameData* frame_data,
float frame_device_scale_factor,
base::ProcessHandle process_handle) {
#ifdef OS_WIN
scoped_ptr<base::SharedMemory> shared_memory(
new base::SharedMemory(frame_data->handle, true,
... | bool SoftwareFrameManager::SwapToNewFrame(
uint32 output_surface_id,
const cc::SoftwareFrameData* frame_data,
float frame_device_scale_factor,
base::ProcessHandle process_handle) {
#ifdef OS_WIN
scoped_ptr<base::SharedMemory> shared_memory(
new base::SharedMemory(frame_data->handle, true,
... | C | Chrome | 1 |
https://github.com/chromium/chromium/commit/e93dc535728da259ec16d1c3cc393f80b25f64ae | e93dc535728da259ec16d1c3cc393f80b25f64ae | Add a unit test that filenames aren't unintentionally converted to URLs.
Also fixes two issues in OSExchangeDataProviderWin:
- It used a disjoint set of clipboard formats when handling
GetUrl(..., true /* filename conversion */) vs GetFilenames(...), so the
actual returned results would vary depending on which one... | void OSExchangeDataProviderWin::SetFileContents(
const base::FilePath& filename,
const std::string& file_contents) {
STGMEDIUM* storage = GetStorageForFileDescriptor(filename);
data_->contents_.push_back(new DataObjectImpl::StoredDataInfo(
Clipboard::GetFileDescriptorFormatType().ToFormatEtc(), storag... | void OSExchangeDataProviderWin::SetFileContents(
const base::FilePath& filename,
const std::string& file_contents) {
STGMEDIUM* storage = GetStorageForFileDescriptor(filename);
data_->contents_.push_back(new DataObjectImpl::StoredDataInfo(
Clipboard::GetFileDescriptorFormatType().ToFormatEtc(), storag... | C | Chrome | 0 |
https://github.com/chromium/chromium/commit/364fb6e517fc4fbc8196a4afba4f77b3d5300c3e | 364fb6e517fc4fbc8196a4afba4f77b3d5300c3e | Add InputMethodObserver support into InputMethodBase
This is a preparation CL to fix issue 164964.
Following observer callbacks are defined but not yet
supported by ui::InputMethodBase and its sub classes.
- InputMethodObserver::OnCaretBoundsChanged
- InputMethodObserver::OnInputLocaleChanged
This CL makes these cal... | chromeos::IBusEngineHandlerInterface* GetEngine() {
return chromeos::IBusBridge::Get()->GetEngineHandler();
}
| chromeos::IBusEngineHandlerInterface* GetEngine() {
return chromeos::IBusBridge::Get()->GetEngineHandler();
}
| C | Chrome | 0 |
https://github.com/chromium/chromium/commit/ee8d6fd30b022ac2c87b7a190c954e7bb3c9b21e | ee8d6fd30b022ac2c87b7a190c954e7bb3c9b21e | Clean up calls like "gfx::Rect(0, 0, size().width(), size().height()".
The caller can use the much shorter "gfx::Rect(size())", since gfx::Rect
has a constructor that just takes a Size.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2204001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48283 00... | void SetupLayoutForMatch(PangoLayout* layout,
const std::wstring& text,
AutocompleteMatch::ACMatchClassifications classifications,
const GdkColor* base_color,
const GdkColor* url_color,
const std::string& prefix_text) {
size_t additional_offset = prefix_text.size(); // Length in utf-8 bytes.
s... | void SetupLayoutForMatch(PangoLayout* layout,
const std::wstring& text,
AutocompleteMatch::ACMatchClassifications classifications,
const GdkColor* base_color,
const GdkColor* url_color,
const std::string& prefix_text) {
size_t additional_offset = prefix_text.size(); // Length in utf-8 bytes.
s... | C | Chrome | 0 |
https://github.com/chromium/chromium/commit/f2f703241635fa96fa630b83afcc9a330cc21b7e | f2f703241635fa96fa630b83afcc9a330cc21b7e | CrOS Shelf: Get rid of 'split view' mode for shelf background
In the new UI, "maximized" and "split view" are treated the same in
specs, so there is no more need for a separate "split view" mode. This
folds it into the "maximized" mode.
Note that the only thing that _seems_ different in
shelf_background_animator is S... | void ShelfBackgroundAnimator::AddObserver(
ShelfBackgroundAnimatorObserver* observer) {
observers_.AddObserver(observer);
NotifyObserver(observer);
}
| void ShelfBackgroundAnimator::AddObserver(
ShelfBackgroundAnimatorObserver* observer) {
observers_.AddObserver(observer);
NotifyObserver(observer);
}
| C | Chrome | 0 |
https://github.com/chromium/chromium/commit/a46bcef82b29d30836a0f26226e3d4aca4fa9612 | a46bcef82b29d30836a0f26226e3d4aca4fa9612 | Access ChromotingHost::clients_ only on network thread.
Previously ChromotingHost was doing some work on the main thread and
some on the network thread. |clients_| and some other members were
accessed without lock on both of these threads. Moved most of the
ChromotingHost activity to the network thread to avoid possib... | void ConnectionToClient::Disconnect() {
DCHECK(message_loop_->BelongsToCurrentThread());
CloseChannels();
DCHECK(session_.get());
Session* session = session_.release();
// It may not be safe to delete |session_| here becase this method
// may be invoked in resonse to a libjingle event and libjingle's... | void ConnectionToClient::Disconnect() {
if (!message_loop_->BelongsToCurrentThread()) {
message_loop_->PostTask(
FROM_HERE, base::Bind(&ConnectionToClient::Disconnect, this));
return;
}
CloseChannels();
if (session_.get())
session_.reset();
}
| C | Chrome | 1 |
https://github.com/chromium/chromium/commit/690d0a9175790c4bd3abd066932bc08203c164ca | 690d0a9175790c4bd3abd066932bc08203c164ca | Avoid excessive nesting / recursion in browser URL handling.
BUG=31517
TEST=ChildProcessSecurityPolicyTest
Review URL: http://codereview.chromium.org/525038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35585 0039d316-1c4b-4281-b951-d872f2087c98 | void ChildProcessSecurityPolicy::GrantReadRawCookies(int renderer_id) {
AutoLock lock(lock_);
SecurityStateMap::iterator state = security_state_.find(renderer_id);
if (state == security_state_.end())
return;
state->second->GrantReadRawCookies();
}
| void ChildProcessSecurityPolicy::GrantReadRawCookies(int renderer_id) {
AutoLock lock(lock_);
SecurityStateMap::iterator state = security_state_.find(renderer_id);
if (state == security_state_.end())
return;
state->second->GrantReadRawCookies();
}
| C | Chrome | 0 |
https://github.com/chromium/chromium/commit/8353baf8d1504dbdd4ad7584ff2466de657521cd | 8353baf8d1504dbdd4ad7584ff2466de657521cd | Remove WebFrame::canHaveSecureChild
To simplify the public API, ServiceWorkerNetworkProvider can do the
parent walk itself.
Follow-up to https://crrev.com/ad1850962644e19.
BUG=607543
Review-Url: https://codereview.chromium.org/2082493002
Cr-Commit-Position: refs/heads/master@{#400896} | WebFrame::WebFrame(WebTreeScopeType scope)
: m_scope(scope)
, m_parent(0)
, m_previousSibling(0)
, m_nextSibling(0)
, m_firstChild(0)
, m_lastChild(0)
, m_opener(0)
, m_openedFrameTracker(new OpenedFrameTracker)
{
}
| WebFrame::WebFrame(WebTreeScopeType scope)
: m_scope(scope)
, m_parent(0)
, m_previousSibling(0)
, m_nextSibling(0)
, m_firstChild(0)
, m_lastChild(0)
, m_opener(0)
, m_openedFrameTracker(new OpenedFrameTracker)
{
}
| C | Chrome | 0 |
https://github.com/chromium/chromium/commit/1a113d35a19c0ed6500fb5c0acdc35730617fb3f | 1a113d35a19c0ed6500fb5c0acdc35730617fb3f | Gracefully deal with clearing content settings for unregistered extensions.
BUG=128652
Review URL: https://chromiumcodereview.appspot.com/10907093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155341 0039d316-1c4b-4281-b951-d872f2087c98 | void ContentSettingsStore::ClearContentSettingsForExtension(
const std::string& ext_id,
ExtensionPrefsScope scope) {
bool notify = false;
{
base::AutoLock lock(lock_);
OriginIdentifierValueMap* map = GetValueMap(ext_id, scope);
// Fail gracefully in Release builds.
NOTREACHED();
... | void ContentSettingsStore::ClearContentSettingsForExtension(
const std::string& ext_id,
ExtensionPrefsScope scope) {
bool notify = false;
{
base::AutoLock lock(lock_);
OriginIdentifierValueMap* map = GetValueMap(ext_id, scope);
char ext_id_buffer[33];
base::strlcpy(ext_id_buffer, ext_... | C | Chrome | 1 |
https://github.com/chromium/chromium/commit/1161a49d663dd395bd639549c2dfe7324f847938 | 1161a49d663dd395bd639549c2dfe7324f847938 | Don't populate URL data in WebDropData when dragging files.
This is considered a potential security issue as well, since it leaks
filesystem paths.
BUG=332579
Review URL: https://codereview.chromium.org/135633002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244538 0039d316-1c4b-4281-b951-d872f2087c98 | bool HomeButton::CanDrop(const OSExchangeData& data) {
return data.HasURL();
}
| bool HomeButton::CanDrop(const OSExchangeData& data) {
return data.HasURL();
}
| C | Chrome | 0 |
https://github.com/chromium/chromium/commit/7f9cb4b09dee69d7ea5391650b6f68a39e3c5874 | 7f9cb4b09dee69d7ea5391650b6f68a39e3c5874 | DevTools: enable two sanity tests (fixed upstream)
BUG=53406
Review URL: http://codereview.chromium.org/3305023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59081 0039d316-1c4b-4281-b951-d872f2087c98 | void CloseDevToolsWindow() {
DevToolsManager* devtools_manager = DevToolsManager::GetInstance();
Browser* browser = window_->browser();
devtools_manager->UnregisterDevToolsClientHostFor(inspected_rvh_);
if (browser)
BrowserClosedObserver close_observer(browser);
}
| void CloseDevToolsWindow() {
DevToolsManager* devtools_manager = DevToolsManager::GetInstance();
Browser* browser = window_->browser();
devtools_manager->UnregisterDevToolsClientHostFor(inspected_rvh_);
if (browser)
BrowserClosedObserver close_observer(browser);
}
| C | Chrome | 0 |
https://github.com/chromium/chromium/commit/27c68f543e5eba779902447445dfb05ec3f5bf75 | 27c68f543e5eba779902447445dfb05ec3f5bf75 | Revert of Add accelerated VP9 decode infrastructure and an implementation for VA-API. (patchset #7 id:260001 of https://codereview.chromium.org/1318863003/ )
Reason for revert:
I think this patch broke compile step for Chromium Linux ChromeOS MSan Builder.
First failing build:
http://build.chromium.org/p/chromium.mem... | void VaapiVideoDecodeAccelerator::InitiateSurfaceSetChange(size_t num_pics,
gfx::Size size) {
DCHECK_EQ(message_loop_, base::MessageLoop::current());
DCHECK(!awaiting_va_surfaces_recycle_);
DVLOG(1) << "Initiating surface set change";
awaiting_va_surfa... | void VaapiVideoDecodeAccelerator::InitiateSurfaceSetChange(size_t num_pics,
gfx::Size size) {
DCHECK_EQ(message_loop_, base::MessageLoop::current());
DCHECK(!awaiting_va_surfaces_recycle_);
DVLOG(1) << "Initiating surface set change";
awaiting_va_surfa... | C | Chrome | 0 |
https://github.com/chromium/chromium/commit/dde871628c04863cf5992cb17e3e40f2ba576279 | dde871628c04863cf5992cb17e3e40f2ba576279 | Add a setDebugDirtyRegion() feature to the client.
Calling remoting.clientSession.setDebugDirtyRegion(true) enables
rendering of each frame's dirty region with an purple, translucent
overlay.
Currently the dirty region is re-rendered immediately for each frame,
with no linger nor fade-out behaviour.
BUG=427659
Revi... | void ChromotingInstance::DidChangeFocus(bool has_focus) {
DCHECK(plugin_task_runner_->BelongsToCurrentThread());
if (!IsConnected())
return;
input_handler_.DidChangeFocus(has_focus);
if (mouse_locker_)
mouse_locker_->DidChangeFocus(has_focus);
}
| void ChromotingInstance::DidChangeFocus(bool has_focus) {
DCHECK(plugin_task_runner_->BelongsToCurrentThread());
if (!IsConnected())
return;
input_handler_.DidChangeFocus(has_focus);
if (mouse_locker_)
mouse_locker_->DidChangeFocus(has_focus);
}
| C | Chrome | 0 |
https://github.com/chromium/chromium/commit/1161a49d663dd395bd639549c2dfe7324f847938 | 1161a49d663dd395bd639549c2dfe7324f847938 | Don't populate URL data in WebDropData when dragging files.
This is considered a potential security issue as well, since it leaks
filesystem paths.
BUG=332579
Review URL: https://codereview.chromium.org/135633002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244538 0039d316-1c4b-4281-b951-d872f2087c98 | const gfx::Vector2d& OSExchangeDataProviderAuraX11::GetDragImageOffset() const {
return drag_image_offset_;
}
| const gfx::Vector2d& OSExchangeDataProviderAuraX11::GetDragImageOffset() const {
return drag_image_offset_;
}
| C | Chrome | 0 |
https://github.com/chromium/chromium/commit/74c1ec481b33194dc7a428f2d58fc89640b313ae | 74c1ec481b33194dc7a428f2d58fc89640b313ae | Fix glGetFramebufferAttachmentParameteriv so it returns
current names for buffers.
TEST=unit_tests and conformance tests
BUG=none
Review URL: http://codereview.chromium.org/3135003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55831 0039d316-1c4b-4281-b951-d872f2087c98 | void GLES2DecoderImpl::DoBindTexture(GLenum target, GLuint client_id) {
TextureManager::TextureInfo* info = NULL;
GLuint service_id = 0;
if (client_id != 0) {
info = GetTextureInfo(client_id);
if (!info) {
glGenTextures(1, &service_id);
CreateTextureInfo(client_id, service_id);
info = Ge... | void GLES2DecoderImpl::DoBindTexture(GLenum target, GLuint client_id) {
TextureManager::TextureInfo* info = NULL;
GLuint service_id = 0;
if (client_id != 0) {
info = GetTextureInfo(client_id);
if (!info) {
glGenTextures(1, &service_id);
CreateTextureInfo(client_id, service_id);
info = Ge... | C | Chrome | 0 |
https://github.com/chromium/chromium/commit/2bcaf4649c1d495072967ea454e8c16dce044705 | 2bcaf4649c1d495072967ea454e8c16dce044705 | Don't interpret embeded NULLs in a response header line as a line terminator.
BUG=95992
Review URL: http://codereview.chromium.org/7796025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100863 0039d316-1c4b-4281-b951-d872f2087c98 | void HttpUtil::ParseContentType(const string& content_type_str,
string* mime_type, string* charset,
bool *had_charset) {
size_t type_val = content_type_str.find_first_not_of(HTTP_LWS);
type_val = std::min(type_val, content_type_str.length());
size_t ... | void HttpUtil::ParseContentType(const string& content_type_str,
string* mime_type, string* charset,
bool *had_charset) {
size_t type_val = content_type_str.find_first_not_of(HTTP_LWS);
type_val = std::min(type_val, content_type_str.length());
size_t ... | C | Chrome | 0 |
https://github.com/chromium/chromium/commit/5c9d37f8055700c36b4c9006b0d4d81f4f961a06 | 5c9d37f8055700c36b4c9006b0d4d81f4f961a06 | 2010-07-26 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Darin Fisher.
Move DocumentLoadTiming struct to a new file
https://bugs.webkit.org/show_bug.cgi?id=42917
Also makes DocumentLoadTiming Noncopyable.
No new tests because no new functionality.
* GNUmakefile.... | void FrameLoader::loadWithDocumentLoader(DocumentLoader* loader, FrameLoadType type, PassRefPtr<FormState> prpFormState)
{
ASSERT(m_client->hasWebView());
ASSERT(m_frame->view());
if (m_pageDismissalEventBeingDispatched)
return;
policyChecker()->setLoadType(type);
RefPtr<FormState> formS... | void FrameLoader::loadWithDocumentLoader(DocumentLoader* loader, FrameLoadType type, PassRefPtr<FormState> prpFormState)
{
ASSERT(m_client->hasWebView());
ASSERT(m_frame->view());
if (m_pageDismissalEventBeingDispatched)
return;
policyChecker()->setLoadType(type);
RefPtr<FormState> formS... | C | Chrome | 0 |
https://github.com/chromium/chromium/commit/6c5d779aaf0dec9628da8a20751e95fd09554b14 | 6c5d779aaf0dec9628da8a20751e95fd09554b14 | Move the cancellation of blocked requests code from ResourceDispatcherHost::~ResourceDispatcherHost() to ResourceDispatcherHost::OnShutdown().
This causes the requests to be cancelled on the IO thread rather than the UI thread, which is important since cancellation may delete the URLRequest (and URLRequests should not... | void ResourceDispatcherHost::AddObserver(Observer* obs) {
observer_list_.AddObserver(obs);
}
| void ResourceDispatcherHost::AddObserver(Observer* obs) {
observer_list_.AddObserver(obs);
}
| C | Chrome | 0 |
https://github.com/chromium/chromium/commit/511d0a0a31a54e0cc0f15cb1b977dc9f9b20f0d3 | 511d0a0a31a54e0cc0f15cb1b977dc9f9b20f0d3 | Implement new websocket handshake based on draft-hixie-thewebsocketprotocol-76
BUG=none
TEST=net_unittests passes
Review URL: http://codereview.chromium.org/1108002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42736 0039d316-1c4b-4281-b951-d872f2087c98 | void WebSocket::SkipReadBuffer(int len) {
if (len == 0)
return;
DCHECK_GT(len, 0);
read_consumed_len_ += len;
int remaining = current_read_buf_->offset() - read_consumed_len_;
DCHECK_GE(remaining, 0);
if (remaining < read_consumed_len_ &&
current_read_buf_->RemainingCapacity() < read_consumed_len_... | void WebSocket::SkipReadBuffer(int len) {
if (len == 0)
return;
DCHECK_GT(len, 0);
read_consumed_len_ += len;
int remaining = current_read_buf_->offset() - read_consumed_len_;
DCHECK_GE(remaining, 0);
if (remaining < read_consumed_len_ &&
current_read_buf_->RemainingCapacity() < read_consumed_len_... | C | Chrome | 0 |
https://github.com/chromium/chromium/commit/9d02cda7a634fbd6e53d98091f618057f0174387 | 9d02cda7a634fbd6e53d98091f618057f0174387 | Coverity: Fixing pass by value.
CID=101462, 101458, 101437, 101471, 101467
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/9006023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115257 0039d316-1c4b-4281-b951-d872f2087c98 | void FreeCopyOfAddrinfo(struct addrinfo* info) {
DCHECK(info);
if (info->ai_canonname)
free(info->ai_canonname); // Allocated by strdup.
if (info->ai_addr)
delete [] reinterpret_cast<char*>(info->ai_addr);
struct addrinfo* next = info->ai_next;
delete info;
if (next)
FreeCopyOfAddrinfo(next... | void FreeCopyOfAddrinfo(struct addrinfo* info) {
DCHECK(info);
if (info->ai_canonname)
free(info->ai_canonname); // Allocated by strdup.
if (info->ai_addr)
delete [] reinterpret_cast<char*>(info->ai_addr);
struct addrinfo* next = info->ai_next;
delete info;
if (next)
FreeCopyOfAddrinfo(next... | C | Chrome | 0 |
https://github.com/chromium/chromium/commit/283fb25624bf253d120708152e23cf9143519198 | 283fb25624bf253d120708152e23cf9143519198 | Coverity; Fixing pass by value bugs.
CID=101466, 101464, 101494, 101495, 101496, 101497
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/8956046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115399 0039d316-1c4b-4281-b951-d872f2087c98 | InfoBarDelegate* ExtensionInstallUI::GetNewThemeInstalledInfoBarDelegate(
TabContentsWrapper* tab_contents,
const Extension* new_theme,
const std::string& previous_theme_id,
bool previous_using_native_theme) {
Profile* profile = tab_contents->profile();
return new ThemeInstalledInfoBarDelegate(
... | InfoBarDelegate* ExtensionInstallUI::GetNewThemeInstalledInfoBarDelegate(
TabContentsWrapper* tab_contents,
const Extension* new_theme,
const std::string& previous_theme_id,
bool previous_using_native_theme) {
Profile* profile = tab_contents->profile();
return new ThemeInstalledInfoBarDelegate(
... | C | Chrome | 0 |
https://github.com/chromium/chromium/commit/b9e2ecab97a8a7f3cce06951ab92a3eaef559206 | b9e2ecab97a8a7f3cce06951ab92a3eaef559206 | Do not discount a MANUAL_SUBFRAME load just because it involved
some redirects.
R=brettw
BUG=21353
TEST=none
Review URL: http://codereview.chromium.org/246073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27887 0039d316-1c4b-4281-b951-d872f2087c98 | bool WebFrameLoaderClient::canHandleRequest(const ResourceRequest&) const {
return true;
}
| bool WebFrameLoaderClient::canHandleRequest(const ResourceRequest&) const {
return true;
}
| C | Chrome | 0 |
https://github.com/chromium/chromium/commit/21d4d15a81b030f522fef29a0429f08a70220f68 | 21d4d15a81b030f522fef29a0429f08a70220f68 | Moved guest_view_registry to GuestViewManager and made it an instance map
This change allows for the change towards moving GuestViewManager to components
and implementing an extensions specific GuestViewManager that installs extensions-specific
guest types.
BUG=444869
Review URL: https://codereview.chromium.org/1096... | void GuestViewBase::SetUpSizing(const base::DictionaryValue& params) {
bool auto_size_enabled = auto_size_enabled_;
params.GetBoolean(guestview::kAttributeAutoSize, &auto_size_enabled);
int max_height = max_auto_size_.height();
int max_width = max_auto_size_.width();
params.GetInteger(guestview::kAttributeMa... | void GuestViewBase::SetUpSizing(const base::DictionaryValue& params) {
bool auto_size_enabled = auto_size_enabled_;
params.GetBoolean(guestview::kAttributeAutoSize, &auto_size_enabled);
int max_height = max_auto_size_.height();
int max_width = max_auto_size_.width();
params.GetInteger(guestview::kAttributeMa... | C | Chrome | 0 |
https://github.com/chromium/chromium/commit/aa0e1ed74972a619072341b6409dc5cacd2418aa | aa0e1ed74972a619072341b6409dc5cacd2418aa | [BlackBerry] willComposite() and didComposite() are now in InspectorController
https://bugs.webkit.org/show_bug.cgi?id=110343
Patch by Alberto Garcia <albgarcia@rim.com> on 2013-02-21
Reviewed by Carlos Garcia Campos.
This was changed in r142879.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::willComposite)... | void WebPagePrivate::exitFullscreenForNode(Node* node)
{
#if ENABLE(VIDEO)
if (m_fullscreenNode.get()) {
m_client->fullscreenStop();
m_fullscreenNode = 0;
}
if (!node || !node->hasTagName(HTMLNames::videoTag))
return;
MediaPlayer* player = static_cast<HTMLMediaElement*>(node)->... | void WebPagePrivate::exitFullscreenForNode(Node* node)
{
#if ENABLE(VIDEO)
if (m_fullscreenNode.get()) {
m_client->fullscreenStop();
m_fullscreenNode = 0;
}
if (!node || !node->hasTagName(HTMLNames::videoTag))
return;
MediaPlayer* player = static_cast<HTMLMediaElement*>(node)->... | C | Chrome | 0 |
https://github.com/chromium/chromium/commit/3a353ebdb7753a3fbeb401c4c0e0f3358ccbb90b | 3a353ebdb7753a3fbeb401c4c0e0f3358ccbb90b | Support pausing media when a context is frozen.
Media is resumed when the context is unpaused. This feature will be used
for bfcache and pausing iframes feature policy.
BUG=907125
Change-Id: Ic3925ea1a4544242b7bf0b9ad8c9cb9f63976bbd
Reviewed-on: https://chromium-review.googlesource.com/c/1410126
Commit-Queue: Dave T... | void HTMLMediaElement::SetShouldDelayLoadEvent(bool should_delay) {
if (should_delay_load_event_ == should_delay)
return;
BLINK_MEDIA_LOG << "setShouldDelayLoadEvent(" << (void*)this << ", "
<< BoolString(should_delay) << ")";
should_delay_load_event_ = should_delay;
if (should_delay)
... | void HTMLMediaElement::SetShouldDelayLoadEvent(bool should_delay) {
if (should_delay_load_event_ == should_delay)
return;
BLINK_MEDIA_LOG << "setShouldDelayLoadEvent(" << (void*)this << ", "
<< BoolString(should_delay) << ")";
should_delay_load_event_ = should_delay;
if (should_delay)
... | C | Chrome | 0 |
https://github.com/chromium/chromium/commit/fc790462b4f248712bbc8c3734664dd6b05f80f2 | fc790462b4f248712bbc8c3734664dd6b05f80f2 | Set the job name for the print job on the Mac.
BUG=http://crbug.com/29188
TEST=as in bug
Review URL: http://codereview.chromium.org/1997016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47056 0039d316-1c4b-4281-b951-d872f2087c98 | explicit WriteClipboardTask(Clipboard::ObjectMap* objects)
: objects_(objects) {}
| explicit WriteClipboardTask(Clipboard::ObjectMap* objects)
: objects_(objects) {}
| C | Chrome | 0 |
https://github.com/chromium/chromium/commit/b9866ebc631655c593a2ac60a3c7cf7d217ccf5d | b9866ebc631655c593a2ac60a3c7cf7d217ccf5d | Use the lock when accessing the buffer object.
BUG=69195
TEST=play Z-Type for hours :)
Review URL: http://codereview.chromium.org/6157007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71211 0039d316-1c4b-4281-b951-d872f2087c98 | scoped_refptr<AudioOutputController> AudioOutputController::CreateLowLatency(
EventHandler* event_handler,
AudioParameters params,
SyncReader* sync_reader) {
DCHECK(sync_reader);
if (!CheckParameters(params))
return NULL;
if (!AudioManager::GetAudioManager())
return NULL;
scoped_refptr<A... | scoped_refptr<AudioOutputController> AudioOutputController::CreateLowLatency(
EventHandler* event_handler,
AudioParameters params,
SyncReader* sync_reader) {
DCHECK(sync_reader);
if (!CheckParameters(params))
return NULL;
if (!AudioManager::GetAudioManager())
return NULL;
scoped_refptr<A... | C | Chrome | 0 |
https://github.com/chromium/chromium/commit/fc790462b4f248712bbc8c3734664dd6b05f80f2 | fc790462b4f248712bbc8c3734664dd6b05f80f2 | Set the job name for the print job on the Mac.
BUG=http://crbug.com/29188
TEST=as in bug
Review URL: http://codereview.chromium.org/1997016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47056 0039d316-1c4b-4281-b951-d872f2087c98 | void ResourceMessageFilter::OnOpenChannelToPlugin(const GURL& url,
const std::string& mime_type,
const std::wstring& locale,
IPC::Message* reply_msg) {
plugin_service_-... | void ResourceMessageFilter::OnOpenChannelToPlugin(const GURL& url,
const std::string& mime_type,
const std::wstring& locale,
IPC::Message* reply_msg) {
plugin_service_-... | C | Chrome | 0 |
https://github.com/chromium/chromium/commit/961d0cda4cfc3bcf04aa48ccc32772d63af12d9b | 961d0cda4cfc3bcf04aa48ccc32772d63af12d9b | Extract generation logic from the accessory controller into a separate one
This change adds a controller that is responsible for mediating
communication between ChromePasswordManagerClient and
PasswordAccessoryController for password generation. It is also
responsible for managing the modal dialog used to present the ... | void ChromePasswordManagerClient::LogPasswordReuseDetectedEvent() {
safe_browsing::PasswordProtectionService* pps =
GetPasswordProtectionService();
if (pps) {
pps->MaybeLogPasswordReuseDetectedEvent(web_contents());
}
}
| void ChromePasswordManagerClient::LogPasswordReuseDetectedEvent() {
safe_browsing::PasswordProtectionService* pps =
GetPasswordProtectionService();
if (pps) {
pps->MaybeLogPasswordReuseDetectedEvent(web_contents());
}
}
| C | Chrome | 0 |
https://github.com/chromium/chromium/commit/610f904d8215075c4681be4eb413f4348860bf9f | 610f904d8215075c4681be4eb413f4348860bf9f | Retrieve per host storage usage from QuotaManager.
R=kinuko@chromium.org
BUG=none
TEST=QuotaManagerTest.GetUsage
Review URL: http://codereview.chromium.org/8079004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103921 0039d316-1c4b-4281-b951-d872f2087c98 | bool db_disabled() const { return db_disabled_; }
| bool db_disabled() const { return db_disabled_; }
| C | Chrome | 0 |
https://github.com/chromium/chromium/commit/7cb8e1ae121cf6b14aa0a59cc708de630c0ef965 | 7cb8e1ae121cf6b14aa0a59cc708de630c0ef965 | Move variations prefs into the variations component
These prefs are used by variations code that is targeted for componentization.
BUG=382865
TBR=thakis
Review URL: https://codereview.chromium.org/1265423003
Cr-Commit-Position: refs/heads/master@{#343661} | void MasterPreferences::InitializeFromCommandLine(
const base::CommandLine& cmd_line) {
#if defined(OS_WIN)
if (cmd_line.HasSwitch(installer::switches::kInstallerData)) {
base::FilePath prefs_path(cmd_line.GetSwitchValuePath(
installer::switches::kInstallerData));
InitializeFromFilePath(prefs_path... | void MasterPreferences::InitializeFromCommandLine(
const base::CommandLine& cmd_line) {
#if defined(OS_WIN)
if (cmd_line.HasSwitch(installer::switches::kInstallerData)) {
base::FilePath prefs_path(cmd_line.GetSwitchValuePath(
installer::switches::kInstallerData));
InitializeFromFilePath(prefs_path... | C | Chrome | 0 |
https://github.com/chromium/chromium/commit/3b7ff00418c0e7593d42e5648ba39397e23fe2f9 | 3b7ff00418c0e7593d42e5648ba39397e23fe2f9 | sync: ensure sync init path doesn't block on CheckTime
The call to RequestEarlyExit (which calls Abort) only happens if the SyncBackendHost has received the initialization callback from the SyncManager. But during init, the SyncManager could make a call to CheckTime, meaning that call would never be aborted. This pa... | void SyncBackendHost::Core::SaveChanges() {
sync_manager_->SaveChanges();
}
| void SyncBackendHost::Core::SaveChanges() {
sync_manager_->SaveChanges();
}
| C | Chrome | 0 |
https://github.com/chromium/chromium/commit/1da0daecc540238cb473f0d6322da51d3a544244 | 1da0daecc540238cb473f0d6322da51d3a544244 | Change VideoDecoder::ReadCB to take const scoped_refptr<VideoFrame>&.
BUG=none
TEST=media_unittests, media layout tests.
Review URL: https://chromiumcodereview.appspot.com/10559074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143192 0039d316-1c4b-4281-b951-d872f2087c98 | void VideoRendererBase::Initialize(const scoped_refptr<VideoDecoder>& decoder,
const PipelineStatusCB& status_cb,
const StatisticsCB& statistics_cb,
const TimeCB& time_cb) {
base::AutoLock auto_lock(lock_);
DCHE... | void VideoRendererBase::Initialize(const scoped_refptr<VideoDecoder>& decoder,
const PipelineStatusCB& status_cb,
const StatisticsCB& statistics_cb,
const TimeCB& time_cb) {
base::AutoLock auto_lock(lock_);
DCHE... | C | Chrome | 0 |
https://github.com/chromium/chromium/commit/5c9d37f8055700c36b4c9006b0d4d81f4f961a06 | 5c9d37f8055700c36b4c9006b0d4d81f4f961a06 | 2010-07-26 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Darin Fisher.
Move DocumentLoadTiming struct to a new file
https://bugs.webkit.org/show_bug.cgi?id=42917
Also makes DocumentLoadTiming Noncopyable.
No new tests because no new functionality.
* GNUmakefile.... | void MainResourceLoader::addData(const char* data, int length, bool allAtOnce)
{
ResourceLoader::addData(data, length, allAtOnce);
frameLoader()->receivedData(data, length);
}
| void MainResourceLoader::addData(const char* data, int length, bool allAtOnce)
{
ResourceLoader::addData(data, length, allAtOnce);
frameLoader()->receivedData(data, length);
}
| C | Chrome | 0 |
https://github.com/chromium/chromium/commit/df831400bcb63db4259b5858281b1727ba972a2a | df831400bcb63db4259b5858281b1727ba972a2a | WebKit2: Support window bounce when panning.
https://bugs.webkit.org/show_bug.cgi?id=58065
<rdar://problem/9244367>
Reviewed by Adam Roben.
Make gestureDidScroll synchronous, as once we scroll, we need to know
whether or not we are at the beginning or end of the scrollable document.
If we are at eith... | void WebView::exitAcceleratedCompositingMode()
{
ASSERT(useNewDrawingArea());
ASSERT_NOT_REACHED();
}
| void WebView::exitAcceleratedCompositingMode()
{
ASSERT(useNewDrawingArea());
ASSERT_NOT_REACHED();
}
| C | Chrome | 0 |
https://github.com/chromium/chromium/commit/ee8d6fd30b022ac2c87b7a190c954e7bb3c9b21e | ee8d6fd30b022ac2c87b7a190c954e7bb3c9b21e | Clean up calls like "gfx::Rect(0, 0, size().width(), size().height()".
The caller can use the much shorter "gfx::Rect(size())", since gfx::Rect
has a constructor that just takes a Size.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2204001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48283 00... | void AutomationProvider::GetWindowTitle(int handle, string16* text) {
gfx::NativeWindow window = window_tracker_->GetResource(handle);
const gchar* title = gtk_window_get_title(window);
text->assign(UTF8ToUTF16(title));
}
| void AutomationProvider::GetWindowTitle(int handle, string16* text) {
gfx::NativeWindow window = window_tracker_->GetResource(handle);
const gchar* title = gtk_window_get_title(window);
text->assign(UTF8ToUTF16(title));
}
| C | Chrome | 0 |
https://github.com/chromium/chromium/commit/5c9d37f8055700c36b4c9006b0d4d81f4f961a06 | 5c9d37f8055700c36b4c9006b0d4d81f4f961a06 | 2010-07-26 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Darin Fisher.
Move DocumentLoadTiming struct to a new file
https://bugs.webkit.org/show_bug.cgi?id=42917
Also makes DocumentLoadTiming Noncopyable.
No new tests because no new functionality.
* GNUmakefile.... | static double getPossiblySkewedTimeInKnownRange(double skewedTime, double lowerBound, double upperBound)
{
#if PLATFORM(CHROMIUM)
if (skewedTime <= lowerBound)
return lowerBound;
if (skewedTime >= upperBound)
return upperBound;
#else
ASSERT_UNUSED(lowerBound, skewedTime >= lowerBound);
... | static double getPossiblySkewedTimeInKnownRange(double skewedTime, double lowerBound, double upperBound)
{
#if PLATFORM(CHROMIUM)
if (skewedTime <= lowerBound)
return lowerBound;
if (skewedTime >= upperBound)
return upperBound;
#else
ASSERT_UNUSED(lowerBound, skewedTime >= lowerBound);
... | C | Chrome | 0 |
https://github.com/chromium/chromium/commit/6a13a6c2fbae0b3269743e6a141fdfe0d9ec9793 | 6a13a6c2fbae0b3269743e6a141fdfe0d9ec9793 | Don't delete the current NavigationEntry when leaving an interstitial page.
BUG=107182
TEST=See bug
Review URL: http://codereview.chromium.org/8976014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115189 0039d316-1c4b-4281-b951-d872f2087c98 | ~TestSafeBrowsingBlockingPage() {
if (wait_for_delete_) {
MessageLoopForUI::current()->Quit();
}
}
| ~TestSafeBrowsingBlockingPage() {
if (wait_for_delete_) {
MessageLoopForUI::current()->Quit();
}
}
| C | Chrome | 0 |
https://github.com/chromium/chromium/commit/9d02cda7a634fbd6e53d98091f618057f0174387 | 9d02cda7a634fbd6e53d98091f618057f0174387 | Coverity: Fixing pass by value.
CID=101462, 101458, 101437, 101471, 101467
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/9006023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115257 0039d316-1c4b-4281-b951-d872f2087c98 | bool ExtensionPrefs::IsBlacklistBitSet(DictionaryValue* ext) {
return ReadBooleanFromPref(ext, kPrefBlacklist);
}
| bool ExtensionPrefs::IsBlacklistBitSet(DictionaryValue* ext) {
return ReadBooleanFromPref(ext, kPrefBlacklist);
}
| C | Chrome | 0 |
https://github.com/chromium/chromium/commit/dc3857aac17be72c96f28d860d875235b3be349a | dc3857aac17be72c96f28d860d875235b3be349a | Unreviewed, rolling out r142736.
http://trac.webkit.org/changeset/142736
https://bugs.webkit.org/show_bug.cgi?id=109716
Broke ABI, nightly builds crash on launch (Requested by ap on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-13
Source/WebKit2:
* Shared/APIClientTraits.cpp:
(WebKit):
* S... | static void didCommitLoadForFrame(WKPageRef page, WKFrameRef frame, WKTypeRef userData, const void* clientInfo)
{
if (!WKFrameIsMainFrame(frame))
return;
webkitWebViewLoadChanged(WEBKIT_WEB_VIEW(clientInfo), WEBKIT_LOAD_COMMITTED);
}
| static void didCommitLoadForFrame(WKPageRef page, WKFrameRef frame, WKTypeRef userData, const void* clientInfo)
{
if (!WKFrameIsMainFrame(frame))
return;
webkitWebViewLoadChanged(WEBKIT_WEB_VIEW(clientInfo), WEBKIT_LOAD_COMMITTED);
}
| C | Chrome | 0 |
https://github.com/chromium/chromium/commit/a44b00c88bc5ea35b5b150217c5fd6e4ce168e58 | a44b00c88bc5ea35b5b150217c5fd6e4ce168e58 | Apply behaviour change fix from upstream for previous XPath change.
BUG=58731
TEST=NONE
Review URL: http://codereview.chromium.org/4027006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63572 0039d316-1c4b-4281-b951-d872f2087c98 | xmlXPathNodeSetCreate(xmlNodePtr val) {
xmlNodeSetPtr ret;
ret = (xmlNodeSetPtr) xmlMalloc(sizeof(xmlNodeSet));
if (ret == NULL) {
xmlXPathErrMemory(NULL, "creating nodeset\n");
return(NULL);
}
memset(ret, 0 , (size_t) sizeof(xmlNodeSet));
if (val != NULL) {
ret->nodeTab = (xml... | xmlXPathNodeSetCreate(xmlNodePtr val) {
xmlNodeSetPtr ret;
ret = (xmlNodeSetPtr) xmlMalloc(sizeof(xmlNodeSet));
if (ret == NULL) {
xmlXPathErrMemory(NULL, "creating nodeset\n");
return(NULL);
}
memset(ret, 0 , (size_t) sizeof(xmlNodeSet));
if (val != NULL) {
ret->nodeTab = (xml... | C | Chrome | 0 |
https://github.com/chromium/chromium/commit/1161a49d663dd395bd639549c2dfe7324f847938 | 1161a49d663dd395bd639549c2dfe7324f847938 | Don't populate URL data in WebDropData when dragging files.
This is considered a potential security issue as well, since it leaks
filesystem paths.
BUG=332579
Review URL: https://codereview.chromium.org/135633002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244538 0039d316-1c4b-4281-b951-d872f2087c98 | void OmniboxViewViews::Init() {
SetController(this);
SetTextInputType(DetermineTextInputType());
SetBackgroundColor(location_bar_view_->GetColor(
ToolbarModel::NONE, LocationBarView::BACKGROUND));
if (popup_window_mode_)
SetReadOnly(true);
if (chrome::ShouldDisplayOriginChip())
set_placeholder... | void OmniboxViewViews::Init() {
SetController(this);
SetTextInputType(DetermineTextInputType());
SetBackgroundColor(location_bar_view_->GetColor(
ToolbarModel::NONE, LocationBarView::BACKGROUND));
if (popup_window_mode_)
SetReadOnly(true);
if (chrome::ShouldDisplayOriginChip())
set_placeholder... | C | Chrome | 0 |
https://github.com/chromium/chromium/commit/a46bcef82b29d30836a0f26226e3d4aca4fa9612 | a46bcef82b29d30836a0f26226e3d4aca4fa9612 | Access ChromotingHost::clients_ only on network thread.
Previously ChromotingHost was doing some work on the main thread and
some on the network thread. |clients_| and some other members were
accessed without lock on both of these threads. Moved most of the
ChromotingHost activity to the network thread to avoid possib... | void HostNPScriptObject::SetException(const std::string& exception_string) {
CHECK_EQ(base::PlatformThread::CurrentId(), np_thread_id_);
g_npnetscape_funcs->setexception(parent_, exception_string.c_str());
LOG(INFO) << exception_string;
}
| void HostNPScriptObject::SetException(const std::string& exception_string) {
CHECK_EQ(base::PlatformThread::CurrentId(), np_thread_id_);
g_npnetscape_funcs->setexception(parent_, exception_string.c_str());
LOG(INFO) << exception_string;
}
| C | Chrome | 0 |
https://github.com/chromium/chromium/commit/3a353ebdb7753a3fbeb401c4c0e0f3358ccbb90b | 3a353ebdb7753a3fbeb401c4c0e0f3358ccbb90b | Support pausing media when a context is frozen.
Media is resumed when the context is unpaused. This feature will be used
for bfcache and pausing iframes feature policy.
BUG=907125
Change-Id: Ic3925ea1a4544242b7bf0b9ad8c9cb9f63976bbd
Reviewed-on: https://chromium-review.googlesource.com/c/1410126
Commit-Queue: Dave T... | void HTMLMediaElement::load() {
BLINK_MEDIA_LOG << "load(" << (void*)this << ")";
autoplay_policy_->TryUnlockingUserGesture();
ignore_preload_none_ = true;
InvokeLoadAlgorithm();
}
| void HTMLMediaElement::load() {
BLINK_MEDIA_LOG << "load(" << (void*)this << ")";
autoplay_policy_->TryUnlockingUserGesture();
ignore_preload_none_ = true;
InvokeLoadAlgorithm();
}
| C | Chrome | 0 |
https://github.com/chromium/chromium/commit/8353baf8d1504dbdd4ad7584ff2466de657521cd | 8353baf8d1504dbdd4ad7584ff2466de657521cd | Remove WebFrame::canHaveSecureChild
To simplify the public API, ServiceWorkerNetworkProvider can do the
parent walk itself.
Follow-up to https://crrev.com/ad1850962644e19.
BUG=607543
Review-Url: https://codereview.chromium.org/2082493002
Cr-Commit-Position: refs/heads/master@{#400896} | void Document::didLoadAllImports()
{
if (!haveScriptBlockingStylesheetsLoaded())
return;
if (!importLoader())
styleResolverMayHaveChanged();
didLoadAllScriptBlockingResources();
}
| void Document::didLoadAllImports()
{
if (!haveScriptBlockingStylesheetsLoaded())
return;
if (!importLoader())
styleResolverMayHaveChanged();
didLoadAllScriptBlockingResources();
}
| C | Chrome | 0 |
https://github.com/chromium/chromium/commit/9ad7483d8e7c20e9f1a5a08d00150fb51899f14c | 9ad7483d8e7c20e9f1a5a08d00150fb51899f14c | Shutdown Timebomb - In canary, get a callstack if it takes longer than
10 minutes. In Dev, get callstack if it takes longer than 20 minutes.
In Beta (50 minutes) and Stable (100 minutes) it is same as before.
BUG=519321
R=asvitkine@chromium.org
Review URL: https://codereview.chromium.org/1409333005
Cr-Commit-Positio... | void ThreadWatcherList::GetStatusOfThreads(uint32* responding_thread_count,
uint32* unresponding_thread_count) {
DCHECK(WatchDogThread::CurrentlyOnWatchDogThread());
*responding_thread_count = 0;
*unresponding_thread_count = 0;
if (!g_thread_watcher_list_)
return;
... | void ThreadWatcherList::GetStatusOfThreads(uint32* responding_thread_count,
uint32* unresponding_thread_count) {
DCHECK(WatchDogThread::CurrentlyOnWatchDogThread());
*responding_thread_count = 0;
*unresponding_thread_count = 0;
if (!g_thread_watcher_list_)
return;
... | C | Chrome | 0 |
https://github.com/chromium/chromium/commit/9d02cda7a634fbd6e53d98091f618057f0174387 | 9d02cda7a634fbd6e53d98091f618057f0174387 | Coverity: Fixing pass by value.
CID=101462, 101458, 101437, 101471, 101467
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/9006023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115257 0039d316-1c4b-4281-b951-d872f2087c98 | void ExtensionPrefs::MigratePermissions(const ExtensionIdSet& extension_ids) {
ExtensionPermissionsInfo* info = ExtensionPermissionsInfo::GetInstance();
for (ExtensionIdSet::const_iterator ext_id = extension_ids.begin();
ext_id != extension_ids.end(); ++ext_id) {
bool full_access;
const DictionaryVa... | void ExtensionPrefs::MigratePermissions(const ExtensionIdSet& extension_ids) {
ExtensionPermissionsInfo* info = ExtensionPermissionsInfo::GetInstance();
for (ExtensionIdSet::const_iterator ext_id = extension_ids.begin();
ext_id != extension_ids.end(); ++ext_id) {
bool full_access;
const DictionaryVa... | C | Chrome | 0 |
https://github.com/chromium/chromium/commit/ee8d6fd30b022ac2c87b7a190c954e7bb3c9b21e | ee8d6fd30b022ac2c87b7a190c954e7bb3c9b21e | Clean up calls like "gfx::Rect(0, 0, size().width(), size().height()".
The caller can use the much shorter "gfx::Rect(size())", since gfx::Rect
has a constructor that just takes a Size.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2204001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48283 00... | WindowDragResponseTask(AutomationProvider* provider,
IPC::Message* reply_message)
: provider_(provider),
reply_message_(reply_message) {
DCHECK(provider_);
DCHECK(reply_message_);
}
| WindowDragResponseTask(AutomationProvider* provider,
IPC::Message* reply_message)
: provider_(provider),
reply_message_(reply_message) {
DCHECK(provider_);
DCHECK(reply_message_);
}
| C | Chrome | 0 |
https://github.com/chromium/chromium/commit/99844692ee805d18d5ee7fd9c62f14d2dffa2e06 | 99844692ee805d18d5ee7fd9c62f14d2dffa2e06 | Removing unnecessary DCHECK from SafeBrowsing interstitial.
BUG=30079
TEST=None.
Review URL: http://codereview.chromium.org/1131003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42049 0039d316-1c4b-4281-b951-d872f2087c98 | void InterstitialPage::InterstitialPageRVHViewDelegate::OnFindReply(
int request_id, int number_of_matches, const gfx::Rect& selection_rect,
int active_match_ordinal, bool final_update) {
}
| void InterstitialPage::InterstitialPageRVHViewDelegate::OnFindReply(
int request_id, int number_of_matches, const gfx::Rect& selection_rect,
int active_match_ordinal, bool final_update) {
}
| C | Chrome | 0 |
https://github.com/chromium/chromium/commit/5041f984669fe3a989a84c348eb838c8f7233f6b | 5041f984669fe3a989a84c348eb838c8f7233f6b | AutoFill: Release the cached frame when we receive the frameDestroyed() message
from WebKit.
BUG=48857
TEST=none
Review URL: http://codereview.chromium.org/3173005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55789 0039d316-1c4b-4281-b951-d872f2087c98 | void RenderView::OnSetFocus(bool enable) {
RenderWidget::OnSetFocus(enable);
if (webview() && webview()->isActive()) {
std::set<WebPluginDelegateProxy*>::iterator plugin_it;
for (plugin_it = plugin_delegates_.begin();
plugin_it != plugin_delegates_.end(); ++plugin_it) {
if (enable)
(... | void RenderView::OnSetFocus(bool enable) {
RenderWidget::OnSetFocus(enable);
if (webview() && webview()->isActive()) {
std::set<WebPluginDelegateProxy*>::iterator plugin_it;
for (plugin_it = plugin_delegates_.begin();
plugin_it != plugin_delegates_.end(); ++plugin_it) {
if (enable)
(... | C | Chrome | 0 |
https://github.com/chromium/chromium/commit/4fdb2b3ebb31e39852fb1bc20fcdf3b5e4de382e | 4fdb2b3ebb31e39852fb1bc20fcdf3b5e4de382e | ur_ls -> urls in ResourceFetcher
Blink Reformat miss? fix
BUG=675877
Review-Url: https://codereview.chromium.org/2809103002
Cr-Commit-Position: refs/heads/master@{#463599} | void ResourceFetcher::ClearPreloads(ClearPreloadsPolicy policy) {
if (!preloads_)
return;
LogPreloadStats(policy);
for (const auto& resource : *preloads_) {
if (policy == kClearAllPreloads || !resource->IsLinkPreload()) {
resource->DecreasePreloadCount();
if (resource->GetPreloadResult() ==... | void ResourceFetcher::ClearPreloads(ClearPreloadsPolicy policy) {
if (!preloads_)
return;
LogPreloadStats(policy);
for (const auto& resource : *preloads_) {
if (policy == kClearAllPreloads || !resource->IsLinkPreload()) {
resource->DecreasePreloadCount();
if (resource->GetPreloadResult() ==... | C | Chrome | 0 |
https://github.com/chromium/chromium/commit/19190765882e272a6a2162c89acdb29110f7e3cf | 19190765882e272a6a2162c89acdb29110f7e3cf | Revert 102184 - [Sync] use base::Time in sync
Make EntryKernel/Entry/BaseNode use base::Time instead of int64s.
Add sync/util/time.h, with utility functions to manage the sync proto
time format.
Store times on disk in proto format instead of the local system.
This requires a database version bump (to 77).
Update Se... | VerifyResult SyncerUtil::VerifyNewEntry(
const SyncEntity& update,
syncable::Entry* target,
const bool deleted) {
if (target->good()) {
return VERIFY_UNDECIDED;
}
if (deleted) {
return VERIFY_SKIP;
}
return VERIFY_SUCCESS;
}
| VerifyResult SyncerUtil::VerifyNewEntry(
const SyncEntity& update,
syncable::Entry* target,
const bool deleted) {
if (target->good()) {
return VERIFY_UNDECIDED;
}
if (deleted) {
return VERIFY_SKIP;
}
return VERIFY_SUCCESS;
}
| C | Chrome | 0 |
https://github.com/chromium/chromium/commit/690d0a9175790c4bd3abd066932bc08203c164ca | 690d0a9175790c4bd3abd066932bc08203c164ca | Avoid excessive nesting / recursion in browser URL handling.
BUG=31517
TEST=ChildProcessSecurityPolicyTest
Review URL: http://codereview.chromium.org/525038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35585 0039d316-1c4b-4281-b951-d872f2087c98 | bool ChildProcessSecurityPolicy::IsPseudoScheme(const std::string& scheme) {
AutoLock lock(lock_);
return (pseudo_schemes_.find(scheme) != pseudo_schemes_.end());
}
| bool ChildProcessSecurityPolicy::IsPseudoScheme(const std::string& scheme) {
AutoLock lock(lock_);
return (pseudo_schemes_.find(scheme) != pseudo_schemes_.end());
}
| C | Chrome | 0 |
https://github.com/chromium/chromium/commit/a0af50481db56aa780942e8595a20c36b2c34f5c | a0af50481db56aa780942e8595a20c36b2c34f5c | Build fix following bug #30696.
Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-22
Reviewed by NOBODY (build fix).
* WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::windowObjectCleared):
* webkit/webkitwebframe.cpp:
(webkit_web_frame_get_global_context):
git-svn-id: svn://svn.chr... | void FrameLoaderClient::dispatchWillPerformClientRedirect(const KURL&, double, double)
{
notImplemented();
}
| void FrameLoaderClient::dispatchWillPerformClientRedirect(const KURL&, double, double)
{
notImplemented();
}
| C | Chrome | 0 |
https://github.com/chromium/chromium/commit/181c7400b2bf50ba02ac77149749fb419b4d4797 | 181c7400b2bf50ba02ac77149749fb419b4d4797 | gpu: Use GetUniformSetup computed result size.
R=piman@chromium.org
BUG=468936
Review URL: https://codereview.chromium.org/1016193003
Cr-Commit-Position: refs/heads/master@{#321489} | error::Error GLES2DecoderImpl::DoCommandsImpl(unsigned int num_commands,
const void* buffer,
int num_entries,
int* entries_processed) {
commands_to_process_ = num_commands;
error... | error::Error GLES2DecoderImpl::DoCommandsImpl(unsigned int num_commands,
const void* buffer,
int num_entries,
int* entries_processed) {
commands_to_process_ = num_commands;
error... | C | Chrome | 0 |
https://github.com/chromium/chromium/commit/fc790462b4f248712bbc8c3734664dd6b05f80f2 | fc790462b4f248712bbc8c3734664dd6b05f80f2 | Set the job name for the print job on the Mac.
BUG=http://crbug.com/29188
TEST=as in bug
Review URL: http://codereview.chromium.org/1997016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47056 0039d316-1c4b-4281-b951-d872f2087c98 | void ResourceMessageFilter::OnCreateWorker(
const ViewHostMsg_CreateWorker_Params& params, int* route_id) {
*route_id = params.route_id != MSG_ROUTING_NONE ?
params.route_id : render_widget_helper_->GetNextRoutingID();
WorkerService::GetInstance()->CreateWorker(
params.url, params.is_shared, off_the... | void ResourceMessageFilter::OnCreateWorker(
const ViewHostMsg_CreateWorker_Params& params, int* route_id) {
*route_id = params.route_id != MSG_ROUTING_NONE ?
params.route_id : render_widget_helper_->GetNextRoutingID();
WorkerService::GetInstance()->CreateWorker(
params.url, params.is_shared, off_the... | C | Chrome | 0 |
https://github.com/chromium/chromium/commit/87c15175997b0103166020d79fe9048dcf4025f4 | 87c15175997b0103166020d79fe9048dcf4025f4 | Add support for horizontal mouse wheel messages in Windows Desktop Aura.
This is simply a matter of recognizing the WM_MOUSEHWHEEL message as a valid mouse wheel message.
Tested this on web pages with horizontal scrollbars and it works well.
BUG=332797
R=sky@chromium.org, sky
Review URL: https://codereview.chromium.... | bool IsKeyEvent(const base::NativeEvent& native_event) {
return native_event.message == WM_KEYDOWN ||
native_event.message == WM_SYSKEYDOWN ||
native_event.message == WM_CHAR ||
native_event.message == WM_KEYUP ||
native_event.message == WM_SYSKEYUP;
}
| bool IsKeyEvent(const base::NativeEvent& native_event) {
return native_event.message == WM_KEYDOWN ||
native_event.message == WM_SYSKEYDOWN ||
native_event.message == WM_CHAR ||
native_event.message == WM_KEYUP ||
native_event.message == WM_SYSKEYUP;
}
| C | Chrome | 0 |
https://github.com/chromium/chromium/commit/d4cd2b2c0953ad7e9fa988c234eb9361be80fe81 | d4cd2b2c0953ad7e9fa988c234eb9361be80fe81 | DevTools: 'Overrides' UI overlay obstructs page and element inspector
BUG=302862
R=vsevik@chromium.org
Review URL: https://codereview.chromium.org/40233006
git-svn-id: svn://svn.chromium.org/blink/trunk@160559 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | void InspectorPageAgent::didScroll()
{
if (m_enabled)
m_overlay->update();
}
| void InspectorPageAgent::didScroll()
{
if (m_enabled)
m_overlay->update();
}
| C | Chrome | 0 |
https://github.com/chromium/chromium/commit/ec14f31eca3a51f665432973552ee575635132b3 | ec14f31eca3a51f665432973552ee575635132b3 | [EFL] Change the behavior of ewk_view_scale_set.
https://bugs.webkit.org/show_bug.cgi?id=70078
Reviewed by Eric Seidel.
Remove center point basis zoom alignment from ewk_view_scale_set to call
Page::setPageScaleFactor without any adjustment.
* ewk/ewk_view.cpp:
(ewk_view_scale_set):
* ewk/ewk_view.h:
git-svn-id: s... | static Eina_Bool _ewk_view_smart_enable_render(Ewk_View_Smart_Data* smartData)
{
WRN("not supported by engine. smartData=%p", smartData);
return false;
}
| static Eina_Bool _ewk_view_smart_enable_render(Ewk_View_Smart_Data* smartData)
{
WRN("not supported by engine. smartData=%p", smartData);
return false;
}
| C | Chrome | 0 |
https://github.com/chromium/chromium/commit/b051cdb6465736e7233cd22b807e255554378206 | b051cdb6465736e7233cd22b807e255554378206 | OpenSSL: don't allow the server certificate to change during renegotiation.
This mirrors r229611, but for OpenSSL.
BUG=306959
Review URL: https://codereview.chromium.org/177143004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254022 0039d316-1c4b-4281-b951-d872f2087c98 | int SSLClientSocketOpenSSL::GetTLSUniqueChannelBinding(std::string* out) {
return ERR_NOT_IMPLEMENTED;
}
| int SSLClientSocketOpenSSL::GetTLSUniqueChannelBinding(std::string* out) {
return ERR_NOT_IMPLEMENTED;
}
| C | Chrome | 0 |
https://github.com/chromium/chromium/commit/27c68f543e5eba779902447445dfb05ec3f5bf75 | 27c68f543e5eba779902447445dfb05ec3f5bf75 | Revert of Add accelerated VP9 decode infrastructure and an implementation for VA-API. (patchset #7 id:260001 of https://codereview.chromium.org/1318863003/ )
Reason for revert:
I think this patch broke compile step for Chromium Linux ChromeOS MSan Builder.
First failing build:
http://build.chromium.org/p/chromium.mem... | bool VaapiVideoDecodeAccelerator::VaapiVP9Accelerator::OutputPicture(
| bool VaapiVideoDecodeAccelerator::VaapiVP9Accelerator::OutputPicture(
const scoped_refptr<VP9Picture>& pic) {
scoped_refptr<VaapiDecodeSurface> dec_surface =
VP9PictureToVaapiDecodeSurface(pic);
vaapi_dec_->SurfaceReady(dec_surface);
return true;
}
| C | Chrome | 1 |
https://github.com/chromium/chromium/commit/9d02cda7a634fbd6e53d98091f618057f0174387 | 9d02cda7a634fbd6e53d98091f618057f0174387 | Coverity: Fixing pass by value.
CID=101462, 101458, 101437, 101471, 101467
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/9006023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115257 0039d316-1c4b-4281-b951-d872f2087c98 | void AdjustComponents(int delta, url_parse::Parsed* parsed) {
AdjustComponent(delta, &(parsed->username));
AdjustComponent(delta, &(parsed->password));
AdjustComponent(delta, &(parsed->host));
AdjustComponent(delta, &(parsed->port));
AdjustComponent(delta, &(parsed->path));
AdjustComponent(delta, &(parsed->... | void AdjustComponents(int delta, url_parse::Parsed* parsed) {
AdjustComponent(delta, &(parsed->username));
AdjustComponent(delta, &(parsed->password));
AdjustComponent(delta, &(parsed->host));
AdjustComponent(delta, &(parsed->port));
AdjustComponent(delta, &(parsed->path));
AdjustComponent(delta, &(parsed->... | C | Chrome | 0 |
https://github.com/chromium/chromium/commit/f1a142d29ad1dfaecd3b609051b476440289ec72 | f1a142d29ad1dfaecd3b609051b476440289ec72 | Fix print media page size by using the value we compute.
BUG=82472
TEST=NONE (in bug)
Review URL: http://codereview.chromium.org/8344016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106160 0039d316-1c4b-4281-b951-d872f2087c98 | int PrintWebViewHelper::PrintPreviewContext::GetNextPageNumber() {
DCHECK_EQ(RENDERING, state_);
if (IsFinalPageRendered())
return -1;
return pages_to_render_[current_page_index_++];
}
| int PrintWebViewHelper::PrintPreviewContext::GetNextPageNumber() {
DCHECK_EQ(RENDERING, state_);
if (IsFinalPageRendered())
return -1;
return pages_to_render_[current_page_index_++];
}
| C | Chrome | 0 |
https://github.com/chromium/chromium/commit/dc3857aac17be72c96f28d860d875235b3be349a | dc3857aac17be72c96f28d860d875235b3be349a | Unreviewed, rolling out r142736.
http://trac.webkit.org/changeset/142736
https://bugs.webkit.org/show_bug.cgi?id=109716
Broke ABI, nightly builds crash on launch (Requested by ap on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-13
Source/WebKit2:
* Shared/APIClientTraits.cpp:
(WebKit):
* S... | bool InjectedBundlePage::shouldDeleteRange(WKBundlePageRef page, WKBundleRangeHandleRef range, const void* clientInfo)
{
return static_cast<InjectedBundlePage*>(const_cast<void*>(clientInfo))->shouldDeleteRange(range);
}
| bool InjectedBundlePage::shouldDeleteRange(WKBundlePageRef page, WKBundleRangeHandleRef range, const void* clientInfo)
{
return static_cast<InjectedBundlePage*>(const_cast<void*>(clientInfo))->shouldDeleteRange(range);
}
| C | Chrome | 0 |
https://github.com/chromium/chromium/commit/3290c948762c47292fb388de8318859ee22b6688 | 3290c948762c47292fb388de8318859ee22b6688 | GTK: Fix a couple minor popup window icon menu bugs.
BUG=26265,26268
Review URL: http://codereview.chromium.org/360023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31009 0039d316-1c4b-4281-b951-d872f2087c98 | void BrowserTitlebar::Init() {
GtkWidget* container_hbox = gtk_hbox_new(FALSE, 0);
container_ = gtk_event_box_new();
gtk_widget_set_name(container_, "chrome-browser-titlebar");
gtk_event_box_set_visible_window(GTK_EVENT_BOX(container_), FALSE);
gtk_container_add(GTK_CONTAINER(container_), container_hbox);
... | void BrowserTitlebar::Init() {
GtkWidget* container_hbox = gtk_hbox_new(FALSE, 0);
container_ = gtk_event_box_new();
gtk_widget_set_name(container_, "chrome-browser-titlebar");
gtk_event_box_set_visible_window(GTK_EVENT_BOX(container_), FALSE);
gtk_container_add(GTK_CONTAINER(container_), container_hbox);
... | C | Chrome | 0 |
https://github.com/chromium/chromium/commit/59f5e0204cbc0e524b2687fb1beddda82047d16d | 59f5e0204cbc0e524b2687fb1beddda82047d16d | AutoFill: Record whether the user initiated the form submission and don't save form data if the form was not user-submitted.
BUG=48225
TEST=none
Review URL: http://codereview.chromium.org/2842062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53350 0039d316-1c4b-4281-b951-d872f2087c98 | void AutoFillManager::FormsSeen(const std::vector<FormData>& forms) {
if (!IsAutoFillEnabled())
return;
if (personal_data_->profiles().empty() &&
personal_data_->credit_cards().empty())
return;
ParseForms(forms);
}
| void AutoFillManager::FormsSeen(const std::vector<FormData>& forms) {
if (!IsAutoFillEnabled())
return;
if (personal_data_->profiles().empty() &&
personal_data_->credit_cards().empty())
return;
ParseForms(forms);
}
| C | Chrome | 0 |
https://github.com/chromium/chromium/commit/3a353ebdb7753a3fbeb401c4c0e0f3358ccbb90b | 3a353ebdb7753a3fbeb401c4c0e0f3358ccbb90b | Support pausing media when a context is frozen.
Media is resumed when the context is unpaused. This feature will be used
for bfcache and pausing iframes feature policy.
BUG=907125
Change-Id: Ic3925ea1a4544242b7bf0b9ad8c9cb9f63976bbd
Reviewed-on: https://chromium-review.googlesource.com/c/1410126
Commit-Queue: Dave T... | void HTMLMediaElement::RemotePlaybackStarted() {
if (RemotePlaybackClient())
RemotePlaybackClient()->StateChanged(WebRemotePlaybackState::kConnected);
}
| void HTMLMediaElement::RemotePlaybackStarted() {
if (RemotePlaybackClient())
RemotePlaybackClient()->StateChanged(WebRemotePlaybackState::kConnected);
}
| C | Chrome | 0 |
https://github.com/chromium/chromium/commit/3eb1f512d8646db3a70aaef108a8f5ad8b3f013d | 3eb1f512d8646db3a70aaef108a8f5ad8b3f013d | 2010-06-18 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
noAccess url schemes block access to inline stylesheets
https://bugs.webkit.org/show_bug.cgi?id=32309
Test that data URLs can access their inline style sheets.
* http/tests/security/data-url-inline.css-expec... | void CSSStyleSheet::checkLoaded()
{
if (isLoading())
return;
if (parent())
parent()->checkLoaded();
RefPtr<CSSStyleSheet> protector(this);
m_loadCompleted = ownerNode() ? ownerNode()->sheetLoaded() : true;
}
| void CSSStyleSheet::checkLoaded()
{
if (isLoading())
return;
if (parent())
parent()->checkLoaded();
RefPtr<CSSStyleSheet> protector(this);
m_loadCompleted = ownerNode() ? ownerNode()->sheetLoaded() : true;
}
| C | Chrome | 0 |
https://github.com/chromium/chromium/commit/bfa69d49b17f33635c79f79819b90a8d2089c4b3 | bfa69d49b17f33635c79f79819b90a8d2089c4b3 | Change notification cmd line enabling to use the new RuntimeEnabledFeatures code.
BUG=25318
TEST=none
Review URL: http://codereview.chromium.org/339093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30660 0039d316-1c4b-4281-b951-d872f2087c98 | void RenderThread::OnSetExtensionFunctionNames(
const std::vector<std::string>& names) {
ExtensionProcessBindings::SetFunctionNames(names);
}
| void RenderThread::OnSetExtensionFunctionNames(
const std::vector<std::string>& names) {
ExtensionProcessBindings::SetFunctionNames(names);
}
| C | Chrome | 0 |
https://github.com/chromium/chromium/commit/f85716d839636e0814d3309ce1d8f8a2cd1fb9a8 | f85716d839636e0814d3309ce1d8f8a2cd1fb9a8 | [LayoutNG] Take overflow into account when column-balancing.
I didn't check why one test started to pass (it's not a very interesting
test for overflow).
Bug: 829028
Change-Id: I2c2d5fe3ea8c6a87f00df47f81d4158936d8a1bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742162
Reviewed-by: Ian Kil... | String DumpFragmentTree(const NGPhysicalBoxFragment* fragment) {
NGPhysicalFragment::DumpFlags flags =
NGPhysicalFragment::DumpHeaderText | NGPhysicalFragment::DumpSubtree |
NGPhysicalFragment::DumpIndentation | NGPhysicalFragment::DumpOffset |
NGPhysicalFragment::DumpSize;
return fra... | String DumpFragmentTree(const NGPhysicalBoxFragment* fragment) {
NGPhysicalFragment::DumpFlags flags =
NGPhysicalFragment::DumpHeaderText | NGPhysicalFragment::DumpSubtree |
NGPhysicalFragment::DumpIndentation | NGPhysicalFragment::DumpOffset |
NGPhysicalFragment::DumpSize;
return fra... | C | Chrome | 0 |
https://github.com/chromium/chromium/commit/75f1a0ebf09d110642f19dd4e389004e949a7828 | 75f1a0ebf09d110642f19dd4e389004e949a7828 | Web Animations: Temporary fix for performance regression in transition tests
This patch adds a flag to Player::setStartTime to permit it to only call
update() instead of serviceAnimations() (as per previous behaviour). We
intend to in the near future replace the serviceAnimations calls with a
deferred timing update sy... | PassRefPtr<Player> Player::create(DocumentTimeline& timeline, TimedItem* content)
{
return adoptRef(new Player(timeline, content));
}
| PassRefPtr<Player> Player::create(DocumentTimeline& timeline, TimedItem* content)
{
return adoptRef(new Player(timeline, content));
}
| C | Chrome | 0 |
https://github.com/chromium/chromium/commit/df831400bcb63db4259b5858281b1727ba972a2a | df831400bcb63db4259b5858281b1727ba972a2a | WebKit2: Support window bounce when panning.
https://bugs.webkit.org/show_bug.cgi?id=58065
<rdar://problem/9244367>
Reviewed by Adam Roben.
Make gestureDidScroll synchronous, as once we scroll, we need to know
whether or not we are at the beginning or end of the scrollable document.
If we are at eith... | IntSize WebPageProxy::viewSize() const
{
return m_pageClient->viewSize();
}
| IntSize WebPageProxy::viewSize() const
{
return m_pageClient->viewSize();
}
| C | Chrome | 0 |
https://github.com/chromium/chromium/commit/a0af50481db56aa780942e8595a20c36b2c34f5c | a0af50481db56aa780942e8595a20c36b2c34f5c | Build fix following bug #30696.
Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-22
Reviewed by NOBODY (build fix).
* WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::windowObjectCleared):
* webkit/webkitwebframe.cpp:
(webkit_web_frame_get_global_context):
git-svn-id: svn://svn.chr... | bool FrameLoaderClient::shouldGoToHistoryItem(HistoryItem* item) const
{
return item != 0;
}
| bool FrameLoaderClient::shouldGoToHistoryItem(HistoryItem* item) const
{
return item != 0;
}
| C | Chrome | 0 |
https://github.com/chromium/chromium/commit/8c3278613079f1c6d858f2b2deb95d8b95dd1789 | 8c3278613079f1c6d858f2b2deb95d8b95dd1789 | Enable ManifestTest.AppLaunchContainer as it should be passing now.
BUG=47230
TEST=test passes
TBR=robertshield
Review URL: http://codereview.chromium.org/2844016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50553 0039d316-1c4b-4281-b951-d872f2087c98 | Extension* LoadAndExpectSuccess(const std::string& name) {
std::string error;
Extension* extension = LoadExtension(name, &error);
EXPECT_TRUE(extension);
EXPECT_EQ("", error);
return extension;
}
| Extension* LoadAndExpectSuccess(const std::string& name) {
std::string error;
Extension* extension = LoadExtension(name, &error);
EXPECT_TRUE(extension);
EXPECT_EQ("", error);
return extension;
}
| C | Chrome | 0 |
https://github.com/chromium/chromium/commit/d1a59e4e845a01d7d7b80ef184b672752a9eae4d | d1a59e4e845a01d7d7b80ef184b672752a9eae4d | Fixing cross-process postMessage replies on more than two iterations.
When two frames are replying to each other using event.source across processes,
after the first two replies, things break down. The root cause is that in
RenderViewImpl::GetFrameByMappedID, the lookup was incorrect. It is now
properly searching fo... | void RenderViewImpl::dispatchIntent(
WebFrame* frame, const WebIntentRequest& intentRequest) {
webkit_glue::WebIntentData intent_data(intentRequest.intent());
WebKit::WebMessagePortChannelArray* channels =
intentRequest.intent().messagePortChannelsRelease();
if (channels) {
for (size_t i = 0; i < c... | void RenderViewImpl::dispatchIntent(
WebFrame* frame, const WebIntentRequest& intentRequest) {
webkit_glue::WebIntentData intent_data(intentRequest.intent());
WebKit::WebMessagePortChannelArray* channels =
intentRequest.intent().messagePortChannelsRelease();
if (channels) {
for (size_t i = 0; i < c... | C | Chrome | 0 |
https://github.com/chromium/chromium/commit/bfa69d49b17f33635c79f79819b90a8d2089c4b3 | bfa69d49b17f33635c79f79819b90a8d2089c4b3 | Change notification cmd line enabling to use the new RuntimeEnabledFeatures code.
BUG=25318
TEST=none
Review URL: http://codereview.chromium.org/339093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30660 0039d316-1c4b-4281-b951-d872f2087c98 | void BrowserRenderProcessHost::SendUserScriptsUpdate(
base::SharedMemory *shared_memory) {
base::SharedMemoryHandle handle_for_process;
if (!shared_memory->ShareToProcess(GetRendererProcessHandle(),
&handle_for_process)) {
return;
}
if (base::SharedMemory::IsHandleV... | void BrowserRenderProcessHost::SendUserScriptsUpdate(
base::SharedMemory *shared_memory) {
base::SharedMemoryHandle handle_for_process;
if (!shared_memory->ShareToProcess(GetRendererProcessHandle(),
&handle_for_process)) {
return;
}
if (base::SharedMemory::IsHandleV... | C | Chrome | 0 |
https://github.com/chromium/chromium/commit/de485eb849be99305925de2257da3b85325df2fd | de485eb849be99305925de2257da3b85325df2fd | Disable ash configuring display when running mash.
When running ash inside of mash_shell on a device, DisplayConfigurator
will request a NativeDisplayDelegate from Ozone. Ozone is initialized
only in the mus process, not in the ash process, so ash crashes at this
point.
Add accessor for configure_display_ to avoid cr... | std::vector<aura::Window*> Shell::GetContainersFromAllRootWindows(
int container_id,
aura::Window* priority_root) {
std::vector<aura::Window*> containers;
aura::Window::Windows root_windows = GetAllRootWindows();
for (aura::Window::Windows::const_iterator it = root_windows.begin();
it != root_windo... | std::vector<aura::Window*> Shell::GetContainersFromAllRootWindows(
int container_id,
aura::Window* priority_root) {
std::vector<aura::Window*> containers;
aura::Window::Windows root_windows = GetAllRootWindows();
for (aura::Window::Windows::const_iterator it = root_windows.begin();
it != root_windo... | C | Chrome | 0 |
End of preview. Expand in Data Studio
README.md exists but content is empty.
- Downloads last month
- 12