Remove dataset script

#6
by lhoestq HF staff - opened

This should fix the viewer

Hi @lhoestq , thank you so much for the fix!

May I ask how can I keep the dataset script while still ensuring the viewer works? Because as far as I can see, this Wikipedia dataset also uses the dataset script but the viewer still works. My dataset script is written based on its dataset script, which has your fix for this issue.

P/S: Sory, I didn't see your comment in another chat.

We handle authentication by extending calls to open to use the user's token when needed. But we don't do that for HfFileSystem that was not meant to be used in dataset script 😬
Though we should probably try to support it given that it's helpful to glob files.

Datasets like Wikipedia work because they don't use the HfFileSystem.
When you need to list files, a workaround is hardcoding the list of files in the dataset script instead of using the HfFileSystem to glob them.

nguyenhuuthuat09 changed pull request status to closed

Sign up or log in to comment