Await playback of samples before allowing to vote

#44
by Pendrokar - opened

"To avoid a bias to hearing the bias of just their favored TTS, I suggest making the vote buttons non-interactive until the playback of both samples is finished." - #43

Had created #43 beforehand because I misunderstood HF saying that discussions and pull requests are nearly the same thing. So I thought a commit to #43 would make it into a pull request.

A way to fix #43

Implemented in cloned Arena Space:
๐Ÿค—https://huggingface.co/spaces/Pendrokar/TTS-Spaces-Arena

Pendrokar changed pull request status to open
TTS AGI org

LGTM! If @mrfakename is okay with this then good to merge for me. Thanks @Pendrokar for the PR.

TTS AGI org

lgtm

mrfakename changed pull request status to merged

Seems there are two issues:

Revert the PR for now @mrfakename . I have some rebasing to do. HF Space dev is cumbersome when I seemingly cannot tell a HF Space to use a different Git Branch and I can only really test it on PR #30 as that supports HF spaces. ๐Ÿ˜•

If only if I could tell my cloned HF Space to use a different Git branch rather than main. ๐Ÿค”

Sign up or log in to comment