Hugging Face's logo

Spaces:
SpacesExamples
/
ComfyUI
Paused

App Files Community
9

Correct the expansion of $USE_PERSISTENT_DATA in CMD

#4
by deleted - opened
base: refs/heads/main
←
from: refs/pr/4
Discussion Files changed
+1
-1
deleted

Parameter expansion is not performed in the CMD variant with an array of args.

(Maybe should it be additionaly prepended with exec?)

Correct the expansion of $USE_PERSISTENT_DATA in CMDd11c54d9
radames changed pull request status to merged
radames
 Spaces Examples org

thank you @zq50

deleted

I noticed that you reverted the change. Trying to figure out what went wrong, I saw that a duplicated space inherits USE_PERSISTENT_DATA=false set in settings.
Since I didn't modify the condition in the param expansion and "false" is a non-empty string, in this case, "false" means True.
If that's the issue, you need to either change the variable's value to an empty string or use a more complex condition test which checks if the string value equals "true".

radames
 Spaces Examples org

sorry @zq50 after I add your commit, the Space was unable to save data on /data, so I reverted, have to look into that. The idea is to offer folks ability to use our persistent data storage

Sign up or log in to comment