quick_fix_to_subdomain_scrapper

tdagent/tools/get_domain_information.py

@@ -77,11 +77,12 @@ def get_geolocation(ip: str) -> dict[str, Any] | str:
     except Exception as e:  # noqa: BLE001
         return str(e)
 
+
 def _request_dns_record(  # noqa: D417
     domain: str,
     record_type: str,
     timeout: float = 0.5,
-    ) -> list[str]:
+) -> list[str]:
     """Utility to build dns resolve requests that do not use port 53.
 
     Args:
@@ -180,6 +181,7 @@ def enumerate_dns(domain_name: str) -> dict[str, Any] | None:
             enumeration[record_type] = [str(e)]
     return enumeration if enumeration else None
 
+
 def resolve_subdomain_ipv4(domain: str) -> str | None:
     """Resolve the IPv4 address of a domain.
 
@@ -192,11 +194,15 @@ def resolve_subdomain_ipv4(domain: str) -> str | None:
             is returned.
     """
     try:
-        _request_dns_record(domain, "A", timeout=0.6)
-        return domain  # noqa: TRY300
+        ipv4 = _request_dns_record(domain, "A", timeout=0.6)
+        if ipv4:
+            return domain
+        msg = "Cannot resolve it: it is likely non-existing"
+        raise Exception(msg)  # noqa: TRY002, TRY301
     except Exception:  # noqa: BLE001
         return None
 
+
 @cachetools.cached(
     cache=cachetools.TTLCache(maxsize=_CACHE_MAX_SIZE, ttl=_CACHE_TTL_SECONDS),
 )