code_revision problem with ST
I'd like to use the code_revision parameter. However, not for the custom ST module, but for the underlying model implementation of jina-embeddings-v3.
Unfortunately, it gets removed
https://github.com/UKPLab/sentence-transformers/blob/07fac06d7af8d92791d9386cce9bf970d3d7dbd3/sentence_transformers/SentenceTransformer.py#L1554
before it can be used
https://huggingface.co/jinaai/jina-embeddings-v3/blob/9c9e6d940f6eeb1265a05b22d0863ab07b0bc8fa/custom_st.py#L82
I guess one hacky way to fix this is by passing the revision ID using a different name and then renaming it back to code_revision before it's used.
@tomaarsen
, any thoughts on this? Or maybe it's ok to keep code_revision in model_kwargs?
I'm closing the issue because we don't really need to use the code_revision argument anymore