readme: add onnx mean pool function
#82
by
knysfh
- opened
No description provided.
knysfh
changed pull request title from
Add onnx mean pool function
to readme: add onnx mean pool function
Hi @knysfh , thanks for the PR!
I have one minor comment: let's mention that we're also doing normalization as a short comment and maybe combine the two lines (243-244) into one for simplicity
@jupyterjazz I have reduced the number of lines in the normalization function
Cool, thanks.
Can you also replace # Apply mean pooling to 'outputs' to get a single representation of each text with # Apply mean pooling and normalization to the model outputs and let's merge it
Alright, I have modified the comments
Great, thanks for the contribution
jupyterjazz
changed pull request status to
merged