FacebookAI

/

xlm-roberta-large

like 271

LGTM - thanks!

@LysandreJik @julien-c good to merge?

Good for me!

I see multilingual two times in the file. Other than that this is awesome!

good for me too except for @osanseviero 's catch!

Arf, my bad, I missed my copy/paste from the xlm-roberta-base model 🙃
In the current state what is better to do?

• close this PR and reopen another one without the double "- multilingual"?
• merge this PR and open one right after that corrects the double "- multilingual"?

(or even better, the ability to edit a PR will be available at the same time as the ability to add images https://twitter.com/julien_c/status/1533764195954700291?cxt=HHwWhsC90Z6ag8kqAAAA? 👀)

if you use git command line there's an advanced workflow you can follow to push on the present "PR branch": see https://huggingface.co/docs/hub/repositories-pull-requests-discussions#how-do-i-manage-pull-requests-locally

If it's too complex, either of your solutions work too (I'd favor the second one)

The fact that no repo is forked confuses me, I don't understand where I need to indicate cd the_repo to then be able to run the column lines you point to in order to retrieve the file, modify it and then push it.

@lbourdois can you try:

git clone https://huggingface.co/xlm-roberta-large
cd xlm-roberta-large
git fetch origin refs/pr/4:pr/4
git checkout pr/4
# Do your changes
git add .
git commit -m "Add your change"
git push origin pr/4:refs/pr/4

?

Ahhhh I had to clone the URL🙃 It's much clearer now, thanks @julien-c

I followed what you said, everything looks good (I get back my PR in local with the two multilingual tags, I delete one, I commit) until the push.

It says "Everything up-to-date" but I don't see anything updated on the website.
I'm not the most skilled git person, but this seems to be a mess in the branches.

maybe @sbrandeis has an idea for this one^

@julien-c
I was able to remove the duplicate multilingual tag through the web interface. So I think we're good now.
Concerning the local modification via the console which did not work, it remains a mystery to me.

thanks @lbourdois , merging now!