Update app.py

app.py

@@ -145,31 +145,44 @@ def get_video_metadata(temp_video_path: str) -> dict:
         return {"duration": 0, "has_duration": False}
 
 def repair_video(temp_video_path: str) -> str:
-    """Repair the video only if metadata is invalid"""
+    """Repair the video only if metadata is invalid or video is not playable"""
+    cap = cv2.VideoCapture(temp_video_path)
     metadata = get_video_metadata(temp_video_path)
-    if metadata["has_duration"]:
-        logger.info("Video metadata is valid, skipping repair")
+    if cap.isOpened() and metadata["has_duration"]:
+        cap.release()
+        logger.info("Video is playable and has valid metadata, skipping repair")
         return temp_video_path
+    cap.release()
 
     try:
         repaired_video_path = tempfile.NamedTemporaryFile(delete=False, suffix=".webm").name
-        repair_command = f"ffmpeg -i {temp_video_path} -c:v libvpx -c:a libopus -y {repaired_video_path}"
-        logger.info(f"Attempting to repair video: {repair_command}")
+        repair_command = [
+            'ffmpeg',
+            '-i', temp_video_path,
+            '-c:v', 'libvpx',
+            '-c:a', 'libopus',
+            '-y', repaired_video_path
+        ]
+        logger.info(f"Attempting to repair video with command: {' '.join(repair_command)}")
         result = subprocess.run(
             repair_command,
-            shell=True,
             capture_output=True,
             text=True,
             check=True
         )
         logger.info(f"Video repair output: {result.stdout}")
-        logger.info(f"Video repair stderr: {result.stderr}")
-        logger.info(f"Video repaired and saved to: {repaired_video_path}")
-        return repaired_video_path
+        new_metadata = get_video_metadata(repaired_video_path)
+        if new_metadata["has_duration"]:
+            logger.info(f"Video repaired successfully, saved to: {repaired_video_path}")
+            os.unlink(temp_video_path)
+            return repaired_video_path
+        else:
+            logger.warning("Repair failed to fix metadata, using original video")
+            os.unlink(repaired_video_path)
+            return temp_video_path
     except subprocess.CalledProcessError as e:
-        logger.error(f"Failed to repair video: {e}")
-        logger.error(f"Repair stdout: {e.stdout}")
-        logger.error(f"Repair stderr: {e.stderr}")
+        logger.error(f"Failed to repair video: {e.stderr}")
+        os.unlink(repaired_video_path) if os.path.exists(repaired_video_path) else None
         return temp_video_path
     except Exception as e:
         logger.error(f"Unexpected error during video repair: {e}")