Nan is not captured properly

#315
by sieu-n - opened
No description provided.
sieu-n changed pull request title from Update src/display_models/read_results.py to Nan is not captured properly

While reading the data from open-llm-leaderboard/results using this code for analysis, I noticed that the values are float("nan") instead of None, and the condition doesn't capture them. Probably nothing serious in terms of the leaderboard though :)

edit: small typo fixes

A slight change I believe would be that about 40 out of the 2000 models will have the partial average score, computed as the sum of successful metrics / 4, which is nan in the current code because the condition fails to catch and exclude it.

Open LLM Leaderboard org

Hi ! Thank you for this PR ! Do you have an example of a model where this change does catch a nan ?

Open LLM Leaderboard org

Closing for inactivity, feel free to reopen if needed!

clefourrier changed pull request status to closed

Sign up or log in to comment