Spaces:

Gradio-Blocks

/

pokemon-move-generator-app

like 14

Runtime error

Before, the Parameters column of the Generation History table was not displaying correctly.

My suggestion is to dump the parameters into a JSON string and use that as the value in the table.

Hi macklon, thanks for opening an issue for my space! I was having trouble figuring out how to correctly display the history, so I'll look at your suggestion and likely implement it. By the way, did you have a suggestion for fixing the issue with move descriptions being too long for the history table? Occasionally, that will force the table to display one really long line, which makes the parameter columns un-viewable.

Thanks again, and hope you enjoyed the app!

Your app is awesome, such a cool idea :D

As for the super long descriptions, I think we might need to ask the gradio team to provide an option for this - this StackOverflow thread outlines a couple of CSS properties that can be used to wrap the long descriptions in the table. I tried it with console devtools and the following change worked:

<span tabindex="-1" role="button" class="p-2 outline-none border-0 flex-1" style="white-space:pre-line">This move is called ....</span>

I just fixed this I think, but I believe I incorrectly added your changes and had to add them manually on my end. Sorry! New to this haha. Should be fixed now, and thanks again for contributing!

yes its fixed! I'm now able to track how changing the parameters affects my experiments
BTW this was my first PR so I'm also new to this :)

Haha, awesome, glad to hear the fix worked, and nice to meet a fellow learner :)