ReviewComments stringlengths 1 2.35k | OriginalCode stringlengths 28 487 | ReviewedCode stringlengths 14 463 |
|---|---|---|
METHOD_1 METHOD_2 METHOD_2 alias METHOD_1 hmmm created infinite loop ? METHOD_1 - > METHOD_2 - > METHOD_1 ? entire logic incorrect line : TYPE_2 cloned = ( TYPE_2 ) super METHOD_1 ( ) ; cloned VAR_1 ( ) ; return cloned ; | public Object METHOD_1 ( ) throws TYPE_1 { super . METHOD_1 ( ) ; TYPE_2 ctx = new TYPE_2 ( ) ; ctx . VAR_1 ( this ) ; <START> return this . METHOD_2 ( ) ; <END> } | public Object METHOD_1 ( ) { return new TYPE_2 ( this ) ; } |
drop lines | @Override public Response execute ( TYPE_1 request ) throws IOException { TYPE_2 VAR_1 = METHOD_1 ( request ) ; TYPE_3 VAR_2 = execute ( client , VAR_1 ) ; String url = request . VAR_3 ( ) ; <START> if ( this . VAR_4 != null && this . VAR_4 . VAR_5 != null ) { <END> url = this . VAR_4 . VAR_5 . toString ( ) ; } return ... | @Override public Response execute ( TYPE_1 request ) throws IOException { TYPE_2 VAR_1 = METHOD_1 ( request ) ; TYPE_3 VAR_2 = execute ( client , VAR_1 ) ; String url = request . VAR_3 ( ) ; if ( VAR_4 != null && VAR_4 . VAR_5 != null ) { url = VAR_4 . VAR_5 . toString ( ) ; } return METHOD_2 ( url , VAR_2 ) ; } |
I thought wanted practice adrian | public TYPE_1 METHOD_1 ( ) { <START> VAR_1 . METHOD_1 ( ) . METHOD_2 ( true ) ; <END> return VAR_1 . METHOD_1 ( ) ; } | public TYPE_1 METHOD_1 ( ) { return VAR_1 . METHOD_1 ( ) ; } |
I return trait set avoid modifying trait a table | static TYPE_1 METHOD_1 ( TYPE_2 node ) { <START> if ( node instanceof TYPE_3 ) { <END> return node . VAR_1 ( ) . METHOD_1 ( ) ; } return node . VAR_2 ( ) . METHOD_2 ( TYPE_4 . VAR_4 ) ; } | static TYPE_1 METHOD_1 ( TYPE_2 node ) { return node . VAR_2 ( ) . METHOD_2 ( TYPE_4 . VAR_4 ) ; } |
I don t manipulate correlation id I add input validator validating correlation id length | public void METHOD_1 ( String VAR_1 ) { if ( VAR_1 == null ) { this . VAR_1 = Guid . TYPE_1 ( ) . toString ( ) ; } else if ( VAR_1 . length ( ) <= 100 ) { this . VAR_1 = VAR_1 ; } else { this . VAR_1 = VAR_1 . substring ( 0 , 100 ) ; } <START> } <END> | public void METHOD_1 ( String VAR_1 ) { this . VAR_1 = VAR_1 ; } |
don t assert success cli exits 0 | public void METHOD_1 ( ) throws IOException , InterruptedException { try ( TYPE_1 file = new TYPE_1 ( ) ) { TYPE_2 . write ( STRING_1 , file . file ( ) , VAR_1 ) ; METHOD_2 ( STRING_2 , file . file ( ) . METHOD_3 ( ) ) ; assertThat ( METHOD_4 ( VAR_2 . METHOD_5 ( ) ) ) . METHOD_6 ( VAR_3 ) ; VAR_2 . METHOD_7 ( ) ; } <S... | public void METHOD_1 ( ) throws Exception { try ( TYPE_1 file = new TYPE_1 ( ) ) { TYPE_2 . write ( STRING_1 , file . file ( ) , VAR_1 ) ; METHOD_2 ( STRING_2 , file . file ( ) . METHOD_3 ( ) ) ; assertThat ( METHOD_4 ( VAR_2 . METHOD_5 ( ) ) ) . METHOD_6 ( VAR_3 ) ; VAR_2 . METHOD_7 ( ) ; } } |
/ Optional < Class < TYPE_1 > > | <START> static < TYPE_1 extends TYPE_2 < TYPE_1 > > Optional < Class < ? > > METHOD_1 ( Type type ) { <END> return Optional . of ( type ) . map ( TYPE_3 : : METHOD_2 ) . filter ( Class : : METHOD_3 ) . map ( c - > ( Class < TYPE_1 > ) c ) ; } | static < TYPE_1 extends TYPE_2 < TYPE_1 > > Optional < Class < TYPE_1 > > METHOD_1 ( Type type ) { return Optional . of ( type ) . map ( TYPE_3 : : METHOD_2 ) . filter ( Class : : METHOD_3 ) . map ( c - > ( Class < TYPE_1 > ) c ) ; } |
I don t random separator logic | private String METHOD_1 ( ) { ImmutableList < String > VAR_1 = VAR_2 . METHOD_2 ( ) ; return TYPE_1 . METHOD_3 ( TYPE_2 . of ( STRING_1 , VAR_1 . METHOD_4 ( 0 , Math . VAR_3 ( VAR_1 . size ( ) , VAR_4 ) ) , STRING_2 , ImmutableList . VAR_5 ( VAR_1 ) , <START> STRING_3 , TYPE_3 . METHOD_5 ( ) . METHOD_6 ( ) > FLOAT_1 ? ... | private String METHOD_1 ( ) { ImmutableList < String > VAR_1 = VAR_2 . METHOD_2 ( ) ; return TYPE_1 . METHOD_3 ( TYPE_2 . of ( STRING_1 , VAR_1 . METHOD_4 ( 0 , Math . VAR_3 ( VAR_1 . size ( ) , VAR_4 ) ) , STRING_2 , ImmutableList . VAR_5 ( VAR_1 ) ) ) ; } |
shouldn t TYPE_1 getInstance ( ) instead ? s a - op | private long METHOD_1 ( long VAR_1 ) { TYPE_1 VAR_2 = <START> new TYPE_2 ( ) ; <END> VAR_2 . METHOD_2 ( VAR_1 ) ; VAR_2 . set ( TYPE_1 . VAR_3 , 0 ) ; VAR_2 . set ( TYPE_1 . VAR_4 , 0 ) ; VAR_2 . add ( TYPE_1 . VAR_5 , 1 ) ; return VAR_2 . METHOD_3 ( ) ; } | private long METHOD_1 ( long VAR_1 ) { TYPE_1 VAR_2 = TYPE_1 . getInstance ( ) ; VAR_2 . METHOD_2 ( VAR_1 ) ; VAR_2 . set ( TYPE_1 . VAR_3 , 0 ) ; VAR_2 . set ( TYPE_1 . VAR_4 , 0 ) ; VAR_2 . add ( TYPE_1 . VAR_5 , 1 ) ; return VAR_2 . METHOD_3 ( ) ; } |
redundant assertion | public void METHOD_1 ( ) throws TYPE_1 { TYPE_2 VAR_1 = db . VAR_2 ( ) ; VAR_1 . METHOD_2 ( STRING_1 ) . execute ( ) ; try { VAR_1 . METHOD_3 ( STRING_2 ) . METHOD_4 ( TYPE_3 . class ) . METHOD_5 ( ) ; METHOD_6 ( STRING_3 ) ; } catch ( IllegalArgumentException e ) { <START> assertThat ( e ) . METHOD_7 ( ) ; <END> } } | public void METHOD_1 ( ) throws TYPE_1 { TYPE_2 VAR_1 = db . VAR_2 ( ) ; VAR_1 . METHOD_2 ( STRING_1 ) . execute ( ) ; VAR_1 . METHOD_3 ( STRING_2 ) . METHOD_4 ( TYPE_3 . class ) . METHOD_5 ( ) ; } |
change modifies semantic meaning | <START> private static void METHOD_1 ( final TYPE_1 key , final boolean value ) { <END> final TYPE_2 < TYPE_1 , Boolean > cache = TYPE_4 . TYPE_5 . get ( ) ; if ( cache != null ) { cache . put ( key , value ) ; TYPE_4 . TYPE_5 . set ( cache ) ; } } | private void METHOD_1 ( final TYPE_1 key , final boolean value ) { final TYPE_2 < TYPE_1 , Boolean > cache = TYPE_4 . TYPE_5 . get ( ) ; if ( cache != null ) { cache . put ( key , value ) ; TYPE_4 . TYPE_5 . set ( cache ) ; } } |
don t need a super METHOD_1 ( ) call | public void METHOD_1 ( ) throws Exception { <START> VAR_1 = METHOD_2 ( ) . METHOD_3 ( ) ; <END> } | public void METHOD_1 ( ) throws Exception { super . METHOD_1 ( ) ; VAR_1 = METHOD_2 ( ) . METHOD_3 ( ) ; } |
IOException thrown method | <START> private void METHOD_1 ( ) throws IOException { <END> for ( Map . Entry < String , TYPE_1 > entry : VAR_1 . entrySet ( ) ) { String VAR_2 = entry . getKey ( ) ; TYPE_1 VAR_3 = entry . getValue ( ) ; if ( ! VAR_3 . METHOD_2 ( ) . contains ( VAR_4 ) ) { info ( STRING_1 , VAR_4 , VAR_2 ) ; VAR_3 . METHOD_3 ( VAR_4 ... | private void METHOD_1 ( ) { for ( Map . Entry < String , TYPE_1 > entry : VAR_1 . entrySet ( ) ) { String VAR_2 = entry . getKey ( ) ; TYPE_1 VAR_3 = entry . getValue ( ) ; if ( ! VAR_3 . METHOD_2 ( ) . contains ( VAR_4 ) ) { info ( STRING_1 , VAR_4 , VAR_2 ) ; VAR_3 . METHOD_3 ( VAR_4 ) ; VAR_3 . METHOD_4 ( VAR_4 , TY... |
reason assigning VAR_1 rest cases instead returning | private int METHOD_1 ( TYPE_1 result ) { int VAR_1 ; switch ( result ) { case VAR_2 : VAR_1 = R . VAR_3 . VAR_4 ; break ; case VAR_5 : VAR_1 = R . VAR_3 . VAR_6 ; break ; case VAR_7 : VAR_1 = R . VAR_3 . VAR_8 ; break ; default : <START> return R . VAR_3 . VAR_9 ; <END> } return context . VAR_10 ( ) . METHOD_2 ( VAR_1 ... | private int METHOD_1 ( TYPE_1 result ) { int VAR_1 ; switch ( result ) { case VAR_2 : VAR_1 = R . VAR_3 . VAR_4 ; break ; case VAR_5 : VAR_1 = R . VAR_3 . VAR_6 ; break ; case VAR_7 : VAR_1 = R . VAR_3 . VAR_8 ; break ; default : VAR_1 = R . VAR_3 . VAR_9 ; break ; } return context . VAR_10 ( ) . METHOD_2 ( VAR_1 ) ; } |
compile error | public TYPE_1 METHOD_1 ( ) { <START> return super . VAR_1 ; <END> } | public TYPE_1 METHOD_1 ( ) { return super . METHOD_1 ( ) ; } |
I protected | <START> public static <END> TYPE_1 create ( long start , long VAR_1 , int VAR_2 , String value , ANNOTATION_1 TYPE_2 parent ) { if ( start > VAR_1 ) { throw new IllegalArgumentException ( Messages . TYPE_3 + CHAR_1 + start + CHAR_2 + VAR_1 + CHAR_3 ) ; } return new TYPE_1 ( start , VAR_1 , value , VAR_2 , parent ) ; } | protected static TYPE_1 create ( long start , long VAR_1 , int VAR_2 , String value , ANNOTATION_1 TYPE_2 parent ) { if ( start > VAR_1 ) { throw new IllegalArgumentException ( Messages . TYPE_3 + CHAR_1 + start + CHAR_2 + VAR_1 + CHAR_3 ) ; } return new TYPE_1 ( start , VAR_1 , value , VAR_2 , parent ) ; } |
done internally TYPE_4 ? other | private TYPE_1 < Throwable , Throwable > METHOD_1 ( TYPE_2 event ) { return VAR_1 - > { Throwable VAR_2 = METHOD_2 ( VAR_1 ) ; TYPE_2 VAR_3 = event ; if ( VAR_1 instanceof TYPE_3 ) { VAR_3 = ( ( TYPE_3 ) VAR_1 ) . METHOD_3 ( ) ; } return new TYPE_3 ( VAR_3 , new TYPE_4 ( METHOD_4 ( VAR_4 , VAR_2 . getMessage ( ) ) , <S... | private TYPE_1 < Throwable , Throwable > METHOD_1 ( TYPE_2 event ) { return VAR_1 - > { Throwable VAR_2 = METHOD_2 ( VAR_1 ) ; TYPE_2 VAR_3 = event ; if ( VAR_1 instanceof TYPE_3 ) { VAR_3 = ( ( TYPE_3 ) VAR_1 ) . METHOD_3 ( ) ; } return new TYPE_3 ( VAR_3 , new TYPE_4 ( METHOD_4 ( VAR_4 , VAR_2 . getMessage ( ) ) , VA... |
please move line METHOD_2 block javaif ( METHOD_2 ( ) ) { TYPE_4 METHOD_6 ( ) ; _CODE_ don t change behavior kind discuss put | private void METHOD_1 ( final TYPE_1 context ) { if ( METHOD_2 ( ) ) { if ( ! ( context instanceof TYPE_2 ) ) { context . VAR_1 ( ) ; } else { TYPE_3 . METHOD_3 ( this ) . METHOD_4 ( ) . METHOD_5 ( VAR_2 , false ) . commit ( ) ; } } <START> TYPE_4 . METHOD_6 ( ) ; <END> } | private void METHOD_1 ( final TYPE_1 context ) { if ( METHOD_2 ( ) ) { TYPE_4 . METHOD_6 ( ) ; if ( ! ( context instanceof TYPE_2 ) ) { context . VAR_1 ( ) ; } else { TYPE_3 . METHOD_3 ( this ) . METHOD_4 ( ) . METHOD_5 ( VAR_2 , false ) . commit ( ) ; } } } |
loooooong line | <START> public boolean METHOD_1 ( String VAR_1 , String VAR_2 , String VAR_3 , String VAR_4 , String VAR_5 , String VAR_6 ) { <END> return TYPE_1 . METHOD_2 ( VAR_1 . toString ( ) , VAR_2 . toString ( ) , VAR_3 . toString ( ) , VAR_4 . toString ( ) , VAR_5 . toString ( ) , VAR_6 . toString ( ) ) ; } | public boolean METHOD_1 ( String VAR_1 , String VAR_2 , String VAR_3 , String VAR_4 , String VAR_5 , String VAR_6 ) { return TYPE_1 . METHOD_2 ( VAR_1 , VAR_2 , VAR_3 , VAR_4 , VAR_5 , VAR_6 ) ; } |
index field read a local variable loop | public Integer METHOD_1 ( Integer VAR_1 , TYPE_1 < ? super T > VAR_2 ) { int i = VAR_1 ; <START> while ( i < index . get ( ) ) { <END> METHOD_2 ( VAR_2 , i ) ; i ++ ; } return i ; } | public Integer METHOD_1 ( Integer VAR_1 , TYPE_1 < ? super T > VAR_2 ) { int i = VAR_1 ; while ( i < get ( ) ) { METHOD_2 ( VAR_2 , i ) ; i ++ ; } return i ; } |
suggestionreturn getInstance ( ) ; | public String METHOD_1 ( ) { <START> return VAR_1 + STRING_1 + VAR_2 + STRING_2 ; <END> } | public String METHOD_1 ( ) { return getInstance ( ) ; } |
fill more methods bodies copying ideas pull request classes i pointed ticket description | <START> public TYPE_1 METHOD_1 ( TYPE_1 VAR_1 ) throws TYPE_2 { <END> return null ; } | public TYPE_1 METHOD_1 ( TYPE_1 VAR_1 ) throws TYPE_2 { throw new TYPE_2 ( ) ; } |
* Arrays VAR_5 ( ) returns a negative necessarily - 1 original code line 453 fail d check other callers * IIRC operation called * * frequently I absolutely want avoid allocating a dummy object ; ll put additional pressure GC | protected int METHOD_1 ( String VAR_1 ) { TYPE_1 [ ] VAR_2 = this . VAR_3 ; TYPE_2 VAR_4 = new TYPE_2 ( VAR_1 ) ; <START> return Arrays . VAR_5 ( VAR_2 , VAR_4 , ( VAR_6 , VAR_7 ) - > VAR_6 . name . METHOD_2 ( VAR_7 . name ) ) ; <END> } | protected int METHOD_1 ( String VAR_1 ) { TYPE_1 [ ] VAR_2 = this . VAR_3 ; if ( VAR_2 . length == 0 ) { return - 1 ; } else if ( VAR_2 . length == 1 ) { return VAR_2 [ 0 ] . name . equals ( VAR_1 ) ? 0 : - 1 ; } TYPE_2 VAR_4 = new TYPE_2 ( VAR_1 ) ; return Arrays . VAR_5 ( VAR_2 , VAR_4 , ( VAR_6 , VAR_7 ) - > VAR_6 .... |
need wait METHOD_4 | public void METHOD_1 ( ) { METHOD_2 ( ) ; METHOD_3 ( STRING_1 ) . METHOD_4 ( INT_1 ) ; <START> METHOD_5 ( ) ; <END> Assert . assertTrue ( METHOD_3 ( STRING_2 ) . exists ( ) ) ; } | public void METHOD_1 ( ) { METHOD_2 ( ) ; METHOD_5 ( ) ; METHOD_3 ( STRING_1 ) . METHOD_4 ( INT_1 ) ; METHOD_5 ( ) ; Assert . assertTrue ( METHOD_3 ( STRING_2 ) . exists ( ) ) ; } |
SDK t initialized internet VAR_4 don t need check | @Override public void METHOD_1 ( Context context , TYPE_1 VAR_1 , TYPE_2 VAR_2 ) throws IllegalStateException { <START> if ( ! METHOD_2 ( context , TYPE_4 . VAR_4 . VAR_5 ) ) { <END> throw new IllegalStateException ( STRING_1 ) ; } TYPE_3 . METHOD_3 ( context , VAR_1 . getString ( STRING_2 ) ) ; } | @Override public void METHOD_1 ( Context context , TYPE_1 VAR_1 , TYPE_2 VAR_2 ) throws IllegalStateException { TYPE_3 . METHOD_3 ( context , VAR_1 . getString ( STRING_2 ) ) ; } |
nitpick : complaining unnecessary VAR_3 variable 😿 | public View METHOD_1 ( ANNOTATION_1 TYPE_1 VAR_1 , TYPE_2 container , TYPE_3 VAR_2 ) { <START> TYPE_2 VAR_3 = METHOD_2 ( VAR_1 , container , VAR_2 ) ; return VAR_3 ; <END> } | public View METHOD_1 ( ANNOTATION_1 TYPE_1 VAR_1 , TYPE_2 container , TYPE_3 VAR_2 ) { return METHOD_2 ( VAR_1 , container , VAR_2 ) ; } |
formatting ( TYPE_2 VAR_1 ) ( TYPE_2 VAR_1 ) | <START> public static Set < TYPE_1 > METHOD_1 ( TYPE_2 ... VAR_1 ) { <END> Set < TYPE_1 > result = new HashSet < > ( ) ; for ( TYPE_2 VAR_2 : VAR_1 ) { result . addAll ( VAR_2 . METHOD_2 ( ) ) ; } return result ; } | public static Set < TYPE_1 > METHOD_1 ( TYPE_2 ... VAR_1 ) { return METHOD_1 ( Arrays . asList ( VAR_1 ) ) ; } |
return a host UEFI capability satisfies return cond | private Long METHOD_1 ( List < Long > VAR_1 , String VAR_2 ) { int VAR_3 = 0 ; for ( Long host : VAR_1 ) { Map < String , String > VAR_4 = VAR_5 . METHOD_2 ( host ) ; if ( VAR_4 . containsKey ( TYPE_1 . VAR_7 ) ) { if ( VAR_4 . get ( TYPE_1 . VAR_7 ) . equalsIgnoreCase ( STRING_1 ) ) { <START> VAR_3 ++ ; <END> } } } re... | private Long METHOD_1 ( List < Long > VAR_1 , String VAR_2 ) { for ( Long host : VAR_1 ) { Map < String , String > VAR_4 = VAR_5 . METHOD_2 ( host ) ; if ( VAR_4 . containsKey ( TYPE_1 . VAR_7 ) ) { if ( VAR_4 . get ( TYPE_1 . VAR_7 ) . equalsIgnoreCase ( STRING_1 ) ) { return new Long ( 1 ) ; } } } return new Long ( 0... |
another access modification don t need ( _CODE_ ( ) ? ) | <START> void METHOD_1 ( TYPE_1 VAR_1 ) { <END> this . VAR_2 = VAR_1 ; } | public void METHOD_1 ( TYPE_1 VAR_1 ) { this . VAR_2 = VAR_1 ; } |
I suggest check count 0 return null ( aggregate constraint simply match ) case | public Double METHOD_1 ( TYPE_1 < Double > result ) { <START> return ( result . value ) / result . count ; <END> } | public Double METHOD_1 ( TYPE_1 < Double > result ) { return ( result . count == 0 ) ? null : ( ( double ) result . value ) / result . count ; } |
assert keyword ? functional ? suggest remove switch assertNotNull ( ) | public static void METHOD_1 ( ) throws IOException { TYPE_1 VAR_1 = TYPE_2 . class . METHOD_2 ( ) ; <START> assert VAR_1 <END> != null ; File VAR_2 = new File ( VAR_3 . METHOD_3 ( ) , STRING_1 ) ; try ( TYPE_3 in = VAR_1 . METHOD_4 ( STRING_1 ) ; TYPE_4 out = new TYPE_5 ( VAR_2 ) ) { TYPE_6 . METHOD_5 ( in , out ) ; } ... | public static void METHOD_1 ( ) throws IOException { TYPE_1 VAR_1 = TYPE_2 . class . METHOD_2 ( ) ; assertNotNull ( VAR_1 ) ; File VAR_2 = new File ( VAR_3 . METHOD_3 ( ) , STRING_1 ) ; try ( TYPE_3 in = VAR_1 . METHOD_4 ( STRING_1 ) ; TYPE_4 out = new TYPE_5 ( VAR_2 ) ) { TYPE_6 . METHOD_5 ( in , out ) ; } VAR_4 = new... |
I 1st check needed method doesn t TYPE_4 observer called | private boolean METHOD_1 ( TYPE_1 [ ] parameters , TYPE_2 VAR_1 , TYPE_3 method ) { <START> if ( method . VAR_2 ( TYPE_4 . class ) && method . VAR_3 ( ) . METHOD_2 ( TYPE_4 . class ) . METHOD_3 ( ) ) { <END> return true ; } for ( TYPE_1 VAR_4 : parameters ) { if ( VAR_1 . get ( VAR_4 . getName ( ) ) != null ) return fa... | private boolean METHOD_1 ( TYPE_1 [ ] parameters , TYPE_2 VAR_1 , TYPE_3 method ) { if ( method . VAR_3 ( ) . METHOD_2 ( TYPE_4 . class ) . METHOD_3 ( ) ) { return true ; } for ( TYPE_1 VAR_4 : parameters ) { if ( VAR_1 . get ( VAR_4 . getName ( ) ) != null ) return false ; } return true ; } |
check VAR_3 null | public String getValue ( TYPE_1 task ) { TYPE_2 VAR_1 = TYPE_3 . METHOD_1 ( task . VAR_2 ( ) ) ; TYPE_4 VAR_3 = TYPE_5 . METHOD_2 ( task ) ; <START> TYPE_6 url = VAR_1 . METHOD_3 ( VAR_3 , task ) ; <END> if ( url == null ) { return task . VAR_4 ( ) ; } return url . toString ( ) ; } | public String getValue ( TYPE_1 task ) { TYPE_2 VAR_1 = TYPE_3 . METHOD_1 ( task . VAR_2 ( ) ) ; TYPE_4 VAR_3 = TYPE_5 . METHOD_2 ( task ) ; if ( VAR_3 != null ) { TYPE_6 url = VAR_1 . METHOD_3 ( VAR_3 , task ) ; if ( url != null ) { return url . toString ( ) ; } } return task . VAR_4 ( ) ; } |
call methods | protected void METHOD_1 ( ) { <START> this . VAR_1 = TYPE_1 . METHOD_2 ( this . METHOD_3 ( ) ) ; <END> if ( this . VAR_2 == null ) { this . VAR_2 = new TYPE_2 ( this . VAR_3 , this . VAR_4 ) ; } this . VAR_5 = true ; } | protected void METHOD_1 ( ) { this . VAR_1 = TYPE_1 . METHOD_2 ( METHOD_3 ( ) ) ; if ( this . VAR_2 == null ) { this . VAR_2 = new TYPE_2 ( this . VAR_3 , this . VAR_4 ) ; } this . VAR_5 = true ; } |
missing a close bracket ( ) ) ; | public String read ( String key ) { String data = VAR_1 . read ( key ) ; <START> return ( data == null ) ? null : VAR_2 ( VAR_3 . VAR_4 ( VAR_5 , VAR_6 ( data ) ) ; <END> } | public String read ( String key ) { String data = VAR_1 . read ( key ) ; return ( data == null ) ? null : VAR_2 ( VAR_3 . VAR_4 ( VAR_5 , VAR_6 ( data ) ) ) ; } |
please break line | protected void METHOD_1 ( ) { try { TYPE_1 VAR_1 = <START> METHOD_2 ( ) . METHOD_3 ( getParameters ( ) . METHOD_4 ( ) , TYPE_2 . METHOD_5 ( getParameters ( ) . METHOD_6 ( ) ) ) ; <END> METHOD_7 ( VAR_1 . METHOD_8 ( ) ) ; } catch ( IOException e ) { log . error ( STRING_1 , e ) ; return ; } } | protected void METHOD_1 ( ) { TYPE_1 VAR_1 = METHOD_2 ( ) . METHOD_3 ( getParameters ( ) . METHOD_4 ( ) , getParameters ( ) . METHOD_6 ( ) ) ; METHOD_7 ( VAR_1 . METHOD_8 ( ) ) ; } |
cached TYPE_2 ( ) cache 0 - 127 : ) | public TYPE_1 METHOD_1 ( ) { final TYPE_1 row = VAR_1 . METHOD_1 ( ) ; if ( row . size ( ) == 1 ) { if ( VAR_2 == 0 ) { return row ; } else { return new TYPE_2 ( row . get ( 0 ) + VAR_2 ) ; } } else { <START> return new TYPE_2 ( 0 ) ; <END> } } | public TYPE_1 METHOD_1 ( ) { final TYPE_1 row = VAR_1 . METHOD_1 ( ) ; if ( row . size ( ) == 1 ) { if ( VAR_2 == 0 ) { return row ; } else { return TYPE_2 . of ( row . get ( 0 ) + VAR_2 ) ; } } else { return TYPE_2 . of ( 0 ) ; } } |
debugging debug logs instead | public void METHOD_1 ( TYPE_1 ctx ) throws Exception { super . METHOD_1 ( ctx ) ; LOG . info ( STRING_1 , ctx ) ; <START> } <END> | public void METHOD_1 ( TYPE_1 ctx ) throws Exception { super . METHOD_1 ( ctx ) ; LOG . debug ( STRING_1 , ctx ) ; } |
shouldn t line 134 ? replacing getClass ( ) check instead obj = = null check ? user object ? I return false null return false compare TYPE_1 _CODE_ wanted comparable user object continue params comparison compare user candidate _CODE_ I implementation equivalent TYPE_1 user objects | public boolean equals ( Object obj ) { if ( this == obj ) { return true ; } <START> if ( ! ( obj instanceof TYPE_1 ) ) { <END> return false ; } if ( ! getClass ( ) . equals ( obj . getClass ( ) ) ) { return false ; } TYPE_1 VAR_1 = ( TYPE_1 ) obj ; return getId ( ) == VAR_1 . getId ( ) ; } | public boolean equals ( Object obj ) { if ( this == obj ) { return true ; } if ( obj == null ) { return false ; } if ( ! ( obj instanceof TYPE_1 ) ) { return false ; } TYPE_1 VAR_1 = ( TYPE_1 ) obj ; return getId ( ) == VAR_1 . getId ( ) ; } |
style - : return Collections VAR_4 avoid assignment VAR_1 | public List < TYPE_1 > METHOD_1 ( final TYPE_4 . TYPE_5 id ) { List < TYPE_1 > VAR_1 = new ArrayList < TYPE_1 > ( ) ; VAR_1 . addAll ( METHOD_2 ( id ) ) ; VAR_1 . addAll ( METHOD_3 ( id ) ) ; Collections . VAR_2 ( VAR_1 , TYPE_1 . VAR_3 ) ; <START> VAR_1 = Collections . VAR_4 ( TYPE_3 . METHOD_4 ( VAR_1 ) ) ; <END> ret... | public List < TYPE_1 > METHOD_1 ( final TYPE_4 . TYPE_5 id ) { List < TYPE_1 > VAR_1 = new ArrayList < TYPE_1 > ( ) ; VAR_1 . addAll ( METHOD_2 ( id ) ) ; VAR_1 . addAll ( METHOD_3 ( id ) ) ; Collections . VAR_2 ( VAR_1 , TYPE_1 . VAR_3 ) ; return Collections . VAR_4 ( TYPE_3 . METHOD_4 ( VAR_1 ) ) ; } |
needed | public void METHOD_1 ( final String VAR_1 , final String value ) { VAR_2 . METHOD_2 ( VAR_1 , ( key , values ) - > { values . forEach ( i - > { <START> if ( ( i . getValue ( ) . equals ( value ) ) && i . VAR_3 ( ) == false ) { <END> i . VAR_4 ( true ) ; } } ) ; return values ; } ) ; } | public void METHOD_1 ( final String VAR_1 , final String value ) { VAR_2 . METHOD_2 ( VAR_1 , ( key , values ) - > { values . forEach ( i - > { if ( i . getValue ( ) . equals ( value ) && i . VAR_3 ( ) == false ) { i . VAR_4 ( true ) ; } } ) ; return values ; } ) ; } |
instead remove synchronized setter variable volatile | <START> public synchronized TYPE_1 < TYPE_2 > METHOD_1 ( ) { <END> return VAR_1 ; } | public TYPE_1 < TYPE_2 > METHOD_1 ( ) { return VAR_1 ; } |
int type null want Integer type null other places comparing 0 a wrong written condition | public void METHOD_1 ( int id ) { try { <START> if ( ! TYPE_1 . equals ( id , null ) ) { <END> METHOD_2 ( this . VAR_1 . METHOD_3 ( ) . METHOD_4 ( id ) ) ; } } catch ( TYPE_2 e ) { TYPE_3 . METHOD_5 ( STRING_1 + id + STRING_2 , e . getMessage ( ) ) ; } } | public void METHOD_1 ( int id ) { try { METHOD_2 ( this . VAR_1 . METHOD_3 ( ) . METHOD_4 ( id ) ) ; } catch ( TYPE_2 e ) { TYPE_3 . METHOD_5 ( STRING_1 + id + STRING_2 , e . getMessage ( ) ) ; } } |
a bit surprising TYPE_1 TYPE_2 | private void METHOD_1 ( <START> String VAR_1 , TYPE_1 VAR_2 , TYPE_2 VAR_3 ) { <END> try ( TYPE_1 VAR_4 = VAR_3 . METHOD_2 ( ) ) { String VAR_5 = VAR_3 . METHOD_3 ( ) ; LOG . debug ( STRING_1 , VAR_5 ) ; VAR_6 . METHOD_4 ( VAR_1 , VAR_1 , VAR_2 , VAR_5 , VAR_4 ) ; } catch ( IOException e ) { LOG . error ( STRING_2 , e ... | private void METHOD_1 ( String VAR_1 , TYPE_1 VAR_2 , TYPE_2 VAR_3 ) { try ( TYPE_1 VAR_4 = VAR_3 . METHOD_2 ( ) ) { String VAR_5 = VAR_3 . METHOD_3 ( ) ; LOG . debug ( STRING_1 , VAR_5 ) ; VAR_6 . METHOD_4 ( VAR_1 , VAR_1 , VAR_2 , VAR_5 , VAR_4 ) ; } catch ( Exception e ) { LOG . error ( STRING_2 , e ) ; } } |
please a logging framework instead System messages preferably slf4j | public void METHOD_1 ( ) throws TYPE_1 { synchronized ( TYPE_2 . class ) { if ( VAR_1 == null ) { VAR_2 = TYPE_3 . get ( METHOD_2 ( ) . getProperty ( VAR_3 ) ) ; <START> System . out . println ( STRING_1 + VAR_2 ) ; <END> try { VAR_1 = METHOD_3 ( ) ; } catch ( final IOException | TYPE_4 e ) { throw new TYPE_1 ( e ) ; }... | public void METHOD_1 ( ) throws TYPE_1 { synchronized ( TYPE_2 . class ) { if ( VAR_1 == null ) { VAR_2 = TYPE_3 . get ( METHOD_2 ( ) . getProperty ( VAR_3 ) ) ; LOGGER . info ( STRING_1 + VAR_2 ) ; try { VAR_1 = METHOD_3 ( ) ; } catch ( final IOException | TYPE_4 e ) { throw new TYPE_1 ( e ) ; } } VAR_4 ++ ; } } |
don t need impala hdi35 s cloudera | protected void METHOD_1 ( TYPE_1 configuration ) throws TYPE_2 { <START> String VAR_1 = <END> configuration . getProperty ( STRING_1 , STRING_2 ) ; TYPE_3 . put ( STRING_3 , VAR_1 ) ; } | protected void METHOD_1 ( TYPE_1 configuration ) throws TYPE_2 { } |
static | <START> void METHOD_1 ( TYPE_1 VAR_1 , int VAR_2 ) <END> throws IOException { TYPE_2 VAR_3 = ( TYPE_2 ) VAR_1 . METHOD_2 ( ) ; VAR_3 . METHOD_3 ( TYPE_1 . VAR_4 , null ) ; TYPE_3 VAR_5 = new TYPE_3 ( ) ; for ( int i = 0 ; i < VAR_2 ; i ++ ) { METHOD_4 ( VAR_1 , 10 ) ; VAR_3 . METHOD_3 ( TYPE_1 . VAR_4 , null ) ; } METH... | void METHOD_1 ( TYPE_1 VAR_1 , int VAR_2 ) throws IOException { TYPE_2 VAR_3 = ( TYPE_2 ) VAR_1 . METHOD_2 ( ) ; VAR_3 . METHOD_3 ( TYPE_1 . VAR_4 , null ) ; for ( int i = 0 ; i < VAR_2 ; i ++ ) { METHOD_4 ( VAR_1 , 10 ) ; VAR_3 . METHOD_3 ( TYPE_1 . VAR_4 , null ) ; } METHOD_4 ( VAR_1 , 10 ) ; } |
kill entire compat package - please don t add new dependencies common - lang s StringUtils isEmpty ( VAR_1 ) | public static ArrayList < Guid > METHOD_1 ( String VAR_1 ) { <START> if ( TYPE_1 . METHOD_2 ( VAR_1 ) ) { <END> return new ArrayList < Guid > ( ) ; } return METHOD_3 ( Arrays . asList ( VAR_1 . split ( VAR_2 ) ) ) ; } | public static ArrayList < Guid > METHOD_1 ( String VAR_1 ) { if ( StringUtils . isEmpty ( VAR_1 ) ) { return new ArrayList < Guid > ( ) ; } return METHOD_3 ( Arrays . asList ( VAR_1 . split ( VAR_2 ) ) ) ; } |
need _CODE_ VAR_4 | public TYPE_1 ( Context context ) { VAR_2 = context ; <START> VAR_3 = STRING_1 ; <END> VAR_4 = TYPE_2 . VAR_6 ; VAR_7 . put ( VAR_3 , VAR_4 ) ; } | public TYPE_1 ( Context context ) { VAR_2 = context ; String VAR_3 = STRING_1 ; int VAR_4 = TYPE_2 . VAR_6 ; VAR_7 . put ( VAR_3 , VAR_4 ) ; } |
need intermediate VAR_2 variable | public static TYPE_1 METHOD_1 ( Object input , String content ) throws IOException { TYPE_1 VAR_1 = new TYPE_1 ( ) ; VAR_1 . METHOD_2 ( content ) ; if ( input instanceof TYPE_2 ) { TYPE_2 VAR_2 = ( TYPE_2 ) input ; <START> VAR_1 . METHOD_3 ( VAR_2 ) ; <END> } else if ( input instanceof TYPE_3 ) { VAR_1 . METHOD_4 ( ( T... | public static TYPE_1 METHOD_1 ( Object input , String content ) throws IOException { TYPE_1 VAR_1 = new TYPE_1 ( ) ; VAR_1 . METHOD_2 ( content ) ; if ( input instanceof TYPE_2 ) { VAR_1 . METHOD_3 ( ( TYPE_2 ) input ) ; } else if ( input instanceof TYPE_3 ) { VAR_1 . METHOD_4 ( ( TYPE_3 ) input ) ; } else { throw new ... |
return VAR_2 ( VAR_1 ) rest | private TYPE_1 < String , TYPE_2 > METHOD_1 ( List < TYPE_3 > VAR_1 ) { TYPE_1 < String , TYPE_2 > VAR_2 ; try { <START> VAR_2 = METHOD_2 ( VAR_1 ) ; <END> } catch ( TYPE_4 e ) { throw TYPE_5 . METHOD_3 ( e ) ; } return VAR_2 ; } | private TYPE_1 < String , TYPE_2 > METHOD_1 ( List < TYPE_3 > VAR_1 ) { TYPE_1 < String , TYPE_2 > VAR_2 ; try { return METHOD_2 ( VAR_1 ) ; } catch ( TYPE_4 e ) { throw TYPE_5 . METHOD_3 ( e ) ; } } |
nice a METHOD_1 method category change : return METHOD_2 ( VAR_1 ) METHOD_1 ( ) | public static boolean METHOD_1 ( int VAR_1 ) { <START> switch ( METHOD_2 ( VAR_1 ) ) { <END> case VAR_2 : case VAR_3 : return true ; default : return false ; } } | public static boolean METHOD_1 ( int VAR_1 ) { return METHOD_2 ( VAR_1 ) . METHOD_1 ( ) ; } |
unwanted final | public List < String > METHOD_1 ( ) { if ( METHOD_2 ( ) ) { METHOD_3 ( ) ; <START> for ( final String VAR_1 : VAR_2 . METHOD_1 ( ) ) { <END> super . METHOD_4 ( VAR_1 ) ; } } return super . METHOD_1 ( ) ; } | public List < String > METHOD_1 ( ) { if ( METHOD_2 ( ) ) { METHOD_3 ( ) ; for ( String VAR_1 : VAR_2 . METHOD_1 ( ) ) { super . METHOD_4 ( VAR_1 ) ; } } return super . METHOD_1 ( ) ; } |
cut && | private boolean METHOD_1 ( TYPE_1 event ) { String VAR_1 = event . getType ( ) . getName ( ) ; String VAR_2 = VAR_3 ; if ( VAR_1 . equals ( VAR_2 ) ) { return true ; } <START> if ( ( VAR_2 . METHOD_2 ( TYPE_2 . VAR_5 ) && VAR_1 . startsWith ( VAR_2 . METHOD_3 ( TYPE_2 . VAR_5 , TYPE_2 . VAR_6 ) ) ) ) { <END> return tru... | private boolean METHOD_1 ( TYPE_1 event ) { String VAR_1 = event . getType ( ) . getName ( ) ; if ( VAR_1 . equals ( VAR_3 ) ) { return true ; } if ( ( VAR_3 . METHOD_2 ( TYPE_2 . VAR_5 ) && VAR_1 . startsWith ( VAR_3 . METHOD_3 ( TYPE_2 . VAR_5 , TYPE_2 . VAR_6 ) ) ) ) { return true ; } return false ; } |
derive prefs _CODE_ ( ) require client pass a default protocol I I prefer avoid complicating nice simple model type | ANNOTATION_1 public String server ( ) { if ( server . startsWith ( STRING_1 ) ) { server = <START> STRING_2 + <END> server ; } return server ; } | ANNOTATION_1 public String server ( ) { return server ; } |
I view view stupid VAR_1 variable VAR_10 component VAR_1 functionality tested unit test | public void METHOD_1 ( TYPE_1 VAR_1 ) { this . VAR_1 = VAR_1 ; if ( ! VAR_1 . METHOD_2 ( ) ) { VAR_2 . METHOD_3 ( true ) ; } else { VAR_2 . METHOD_4 ( VAR_3 . format ( TYPE_3 . TYPE_4 , VAR_6 . METHOD_5 ( ) ) ) ; } VAR_7 . METHOD_4 ( VAR_6 . METHOD_6 ( ) ) ; VAR_8 . METHOD_7 ( STRING_1 , VAR_3 . METHOD_8 ( TYPE_3 . TYP... | public void METHOD_1 ( TYPE_1 VAR_1 ) { this . VAR_1 = VAR_1 ; VAR_2 . METHOD_4 ( VAR_3 . format ( TYPE_3 . TYPE_4 , VAR_6 . METHOD_5 ( ) ) ) ; VAR_7 . METHOD_4 ( VAR_6 . METHOD_6 ( ) ) ; VAR_8 . METHOD_7 ( STRING_1 , VAR_3 . METHOD_8 ( TYPE_3 . TYPE_2 ) ) ; } |
equals ( ) instead METHOD_3 | private TYPE_1 METHOD_1 ( List < TYPE_1 > VAR_1 , List < TYPE_1 > VAR_2 , String VAR_3 ) { for ( TYPE_1 VAR_4 : VAR_2 ) { <START> if ( StringUtils . VAR_5 ( VAR_4 . METHOD_2 ( ) ) && StringUtils . VAR_5 ( VAR_3 ) && VAR_4 . METHOD_2 ( ) . METHOD_3 ( VAR_3 ) == 0 ) { <END> VAR_1 . add ( VAR_4 ) ; VAR_2 . remove ( VAR_4 ... | private TYPE_1 METHOD_1 ( List < TYPE_1 > VAR_1 , List < TYPE_1 > VAR_2 , String VAR_3 ) { for ( TYPE_1 VAR_4 : VAR_2 ) { if ( StringUtils . VAR_5 ( VAR_4 . METHOD_2 ( ) ) && StringUtils . VAR_5 ( VAR_3 ) && VAR_4 . METHOD_2 ( ) . equals ( VAR_3 ) ) { VAR_1 . add ( 0 , VAR_4 ) ; VAR_2 . remove ( VAR_4 ) ; return VAR_4 ... |
pls replace withstrings ! = null && VAR_1 isEmpty ( ) | public static ArrayList < Guid > METHOD_1 ( List < String > VAR_1 ) { ArrayList < Guid > VAR_2 = new ArrayList < Guid > ( ) ; <START> if ( TYPE_1 . isEmpty ( VAR_1 ) ) { <END> for ( String VAR_3 : VAR_1 ) { VAR_2 . add ( Guid . VAR_4 ( VAR_3 ) ) ; } } return VAR_2 ; } | public static ArrayList < Guid > METHOD_1 ( List < String > VAR_1 ) { ArrayList < Guid > VAR_2 = new ArrayList < Guid > ( ) ; if ( VAR_1 != null && ! VAR_1 . isEmpty ( ) ) { for ( String VAR_3 : VAR_1 ) { VAR_2 . add ( Guid . VAR_4 ( VAR_3 ) ) ; } } return VAR_2 ; } |
iterator assertion e g : assertThat ( Arrays asList ( VAR_1 ) iterator ( ) ) hasNext ( ) ; | public void METHOD_1 ( ) { <START> assertThat ( Arrays . asList ( VAR_1 ) . iterator ( ) ) . METHOD_2 ( ) . contains ( VAR_1 [ 0 ] ) ; <END> } | public void METHOD_1 ( ) { assertThat ( Arrays . asList ( VAR_1 ) . iterator ( ) ) . hasNext ( ) ; } |
I dont / catch necessary log message don t move message _CODE_ | public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) throws Exception { TYPE_1 VAR_2 ; try { VAR_2 = VAR_1 . METHOD_2 ( VAR_3 ) ; } catch ( Exception e ) { log . error ( STRING_1 + VAR_1 . METHOD_3 ( ) , e ) ; <START> throw e ; <END> } return VAR_2 ; } | public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) throws Exception { return VAR_1 . METHOD_2 ( VAR_3 ) ; } |
result call unused I don t | public TYPE_1 < TYPE_2 < ? > > METHOD_1 ( TYPE_3 query ) { <START> query . VAR_1 ( METHOD_2 ( query ) ) ; <END> return VAR_2 . METHOD_1 ( query ) ; } | public TYPE_1 < TYPE_2 < ? > > METHOD_1 ( TYPE_3 query ) { return VAR_2 . METHOD_1 ( query ) ; } |
isn t a debug statement more info trace | private static void METHOD_1 ( TYPE_1 VAR_1 , String VAR_2 ) throws TYPE_2 { if ( TYPE_3 . METHOD_2 ( VAR_2 ) ) { if ( VAR_1 . METHOD_3 ( ) == null ) { <START> LOG . debug ( STRING_1 ) ; <END> throw new TYPE_2 ( TYPE_4 . VAR_4 , STRING_2 ) ; } if ( ! VAR_1 . METHOD_4 ( ) ) { LOG . debug ( STRING_3 ) ; throw new TYPE_2 ... | private static void METHOD_1 ( TYPE_1 VAR_1 , String VAR_2 ) throws TYPE_2 { if ( TYPE_3 . METHOD_2 ( VAR_2 ) ) { if ( VAR_1 . METHOD_3 ( ) == null ) { LOG . info ( STRING_1 ) ; throw new TYPE_2 ( TYPE_4 . VAR_4 , STRING_2 ) ; } if ( ! VAR_1 . METHOD_4 ( ) ) { LOG . info ( STRING_3 ) ; throw new TYPE_2 ( TYPE_4 . VAR_4... |
remove String format | public void METHOD_1 ( ) throws Exception { <START> METHOD_2 ( String . format ( STRING_1 , VAR_1 , <END> TYPE_1 . VAR_3 ) ) ; METHOD_3 ( ) . METHOD_4 ( STRING_2 , VAR_1 ) . METHOD_5 ( ) . METHOD_6 ( STRING_3 ) . METHOD_7 ( STRING_4 ) . build ( ) . run ( ) ; } | public void METHOD_1 ( ) throws Exception { METHOD_2 ( STRING_1 , VAR_1 , TYPE_1 . VAR_3 ) ; METHOD_3 ( ) . METHOD_4 ( STRING_2 , VAR_1 ) . METHOD_5 ( ) . METHOD_6 ( STRING_3 ) . METHOD_7 ( STRING_4 ) . build ( ) . run ( ) ; } |
remove | public void METHOD_1 ( ) throws Exception { <START> this . VAR_1 = null ; <END> this . VAR_2 . clear ( ) ; this . VAR_3 . clear ( ) ; } | public void METHOD_1 ( ) throws Exception { VAR_1 = null ; VAR_2 . clear ( ) ; VAR_3 . clear ( ) ; } |
I d formatting / mark controllers put VAR_3 model attribute _CODE_ jsp | private String METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 model , TYPE_3 request ) { TYPE_4 VAR_2 = METHOD_2 ( VAR_1 , model , request ) ; String VAR_3 = METHOD_3 ( request ) ; model . VAR_4 ( STRING_1 , STRING_2 ) ; <START> model . VAR_4 ( STRING_3 , STRING_4 <END> + VAR_3 + STRING_5 ) ; return STRING_2 ; } | private String METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 model , TYPE_3 request ) { TYPE_4 VAR_2 = METHOD_2 ( VAR_1 , model , request ) ; String VAR_3 = METHOD_3 ( request ) ; model . VAR_4 ( STRING_1 , STRING_2 ) ; model . VAR_4 ( STRING_3 , VAR_3 ) ; return STRING_2 ; } |
I prefer leave package - private avoid a synthetic accessor | <START> private TYPE_2 ( ANNOTATION_1 Set < TYPE_1 > VAR_2 , int VAR_3 , <END> ANNOTATION_1 Set < TYPE_1 > VAR_4 , long VAR_5 , ANNOTATION_1 Set < String > VAR_6 ) { super ( VAR_2 , VAR_3 , VAR_4 , VAR_5 , VAR_6 ) ; } | TYPE_2 ( ANNOTATION_1 Set < TYPE_1 > VAR_2 , int VAR_3 , ANNOTATION_1 Set < TYPE_1 > VAR_4 , long VAR_5 , ANNOTATION_1 Set < String > VAR_6 ) { super ( VAR_2 , VAR_3 , VAR_4 , VAR_5 , VAR_6 ) ; } |
I d inline variable : return new TYPE_1 ( TYPE_3 METHOD_1 ( input ) ) ; | public static TYPE_1 METHOD_1 ( TYPE_2 input ) { <START> TYPE_3 VAR_1 = TYPE_3 . METHOD_1 ( input ) ; <END> return new TYPE_1 ( VAR_1 ) ; } | public static TYPE_1 METHOD_1 ( TYPE_2 input ) { return new TYPE_1 ( TYPE_3 . METHOD_1 ( input ) ) ; } |
isn t anti - pattern move a deprecated method general | private void METHOD_1 ( File VAR_1 ) { if ( VAR_1 != null ) { try { TYPE_1 . METHOD_2 ( VAR_1 ) ; } catch ( IOException e ) { <START> TYPE_2 . METHOD_3 ( e ) ; <END> } } } | private void METHOD_1 ( File VAR_1 ) { if ( VAR_1 != null ) { try { TYPE_1 . METHOD_2 ( VAR_1 ) ; } catch ( IOException e ) { throw new RuntimeException ( e ) ; } } } |
delete line call super METHOD_1 ( VAR_2 ) ; required assertion | public TYPE_1 METHOD_1 ( String VAR_1 , Object ... args ) { String VAR_2 = String . format ( VAR_1 , args ) ; <START> this . VAR_3 . METHOD_2 ( info , VAR_4 , VAR_2 ) ; <END> return super . METHOD_1 ( VAR_2 ) ; } | public TYPE_1 METHOD_1 ( String VAR_1 , Object ... args ) { String VAR_2 = String . format ( VAR_1 , args ) ; return super . METHOD_1 ( VAR_2 ) ; } |
inlined i | public String METHOD_1 ( ) { if ( STRING_1 . equals ( METHOD_2 ( ) . METHOD_3 ( ) ) ) { return METHOD_2 ( ) . METHOD_1 ( ) ; } <START> Optional < String > VAR_1 = Optional . of ( METHOD_2 ( ) . METHOD_4 ( STRING_2 ) ) ; <END> return VAR_1 . METHOD_5 ( "" ) ; } | public String METHOD_1 ( ) { if ( STRING_1 . equals ( METHOD_2 ( ) . METHOD_3 ( ) ) ) { return METHOD_2 ( ) . METHOD_1 ( ) ; } return Optional . of ( METHOD_2 ( ) . METHOD_4 ( STRING_2 ) ) . METHOD_5 ( "" ) ; } |
shouldn t need cast double | public double METHOD_1 ( ) { <START> return ( double ) VAR_1 . METHOD_2 ( ) ; <END> } | public double METHOD_1 ( ) { return VAR_1 . METHOD_2 ( ) ; } |
please synchronize | <START> public void METHOD_1 ( TYPE_1 VAR_1 , float VAR_2 ) { <END> VAR_1 . METHOD_2 ( VAR_3 ) ; if ( VAR_4 == FLOAT_1 ) { super . METHOD_3 ( false ) ; } else { super . METHOD_3 ( true ) ; } if ( VAR_5 instanceof TYPE_2 ) { VAR_5 . METHOD_1 ( VAR_1 , VAR_4 ) ; } if ( METHOD_4 ( ) && this . METHOD_5 ( ) != null ) { supe... | public synchronized void METHOD_1 ( TYPE_1 VAR_1 , float VAR_2 ) { VAR_1 . METHOD_2 ( VAR_3 ) ; if ( VAR_4 == FLOAT_1 ) { super . METHOD_3 ( false ) ; } else { super . METHOD_3 ( true ) ; } if ( VAR_5 instanceof TYPE_2 ) { VAR_5 . METHOD_1 ( VAR_1 , VAR_4 ) ; } if ( METHOD_4 ( ) && this . METHOD_5 ( ) != null ) { super... |
isn t redundant TYPE_2 METHOD_2 ( ) knowing _CODE_ _CODE_ _CODE_ | protected boolean METHOD_1 ( TYPE_1 TYPE_2 ) { if ( TYPE_2 . METHOD_2 ( ) || TYPE_2 . METHOD_3 ( VAR_1 ) ) { return true ; } TYPE_3 VAR_2 = TYPE_4 . METHOD_4 ( TYPE_3 . class ) ; List < String > VAR_3 = VAR_2 . METHOD_5 ( ) ; <START> return VAR_3 . stream ( ) . METHOD_6 ( TYPE_2 : : METHOD_3 ) ; <END> } | protected boolean METHOD_1 ( TYPE_1 TYPE_2 ) { return TYPE_2 . METHOD_2 ( ) || TYPE_2 . METHOD_3 ( VAR_1 ) ; } |
minor : required | void METHOD_1 ( ) { <START> this . VAR_1 = true ; <END> this . VAR_2 = true ; } | void METHOD_1 ( ) { VAR_1 = true ; VAR_2 = true ; } |
work controlled models | public void METHOD_1 ( TYPE_1 VAR_1 ) { <START> METHOD_2 ( ) . METHOD_3 ( ) . add ( VAR_1 ) ; <END> } | public void METHOD_1 ( TYPE_1 VAR_1 ) { if ( METHOD_2 ( ) != null ) { METHOD_2 ( ) . METHOD_3 ( ) . add ( VAR_1 ) ; } } |
done | public < T > TYPE_1 add ( TYPE_2 type , T VAR_1 , T VAR_2 , boolean VAR_3 ) { String VAR_4 = VAR_1 != null ? VAR_1 . toString ( ) : STRING_1 ; <START> String VAR_5 = VAR_2 != null ? VAR_2 . toString ( ) : STRING_1 ; <END> VAR_6 . add ( new TYPE_3 ( type , VAR_4 , VAR_5 , VAR_3 ) ) ; return this ; } | public < T > TYPE_1 add ( TYPE_2 type , T VAR_1 , T VAR_2 , boolean VAR_3 ) { String VAR_4 = VAR_1 == null ? null : VAR_1 . toString ( ) ; String VAR_5 = VAR_2 == null ? null : VAR_2 . toString ( ) ; VAR_6 . add ( new TYPE_3 ( type , VAR_4 , VAR_5 , VAR_3 ) ) ; return this ; } |
case table null string formed incorrectly - table = appended table ! = null | public String toString ( ) { StringBuilder sb = new StringBuilder ( STRING_1 ) ; <START> if ( table != null ) { <END> sb . append ( table . getPath ( ) ) ; } if ( reader != null ) { sb . append ( STRING_2 ) . append ( TYPE_1 . METHOD_1 ( reader . getId ( ) ) ) ; } sb . append ( STRING_3 ) . append ( reader ) . append (... | public String toString ( ) { StringBuilder sb = new StringBuilder ( STRING_1 ) . append ( table != null ? table . getPath ( ) : null ) ; if ( reader != null ) { sb . append ( STRING_2 ) . append ( TYPE_1 . METHOD_1 ( reader . getId ( ) ) ) ; } sb . append ( STRING_3 ) . append ( reader ) . append ( CHAR_1 ) ; return sb... |
import VAR_4 VAR_6 VAR_8 | private static TYPE_1 METHOD_1 ( String VAR_1 , String VAR_2 ) { <START> TYPE_1 . Builder builder = TYPE_1 . METHOD_2 ( new TYPE_2 ( Type . TYPE_4 . VAR_4 , TYPE_2 . TYPE_5 . VAR_6 , STRING_1 , TYPE_3 . VAR_8 ) ) ; <END> builder . VAR_9 ( VAR_1 . METHOD_3 ( ) ) . METHOD_4 ( VAR_2 . METHOD_3 ( ) ) . METHOD_5 ( 0 ) ; ret... | private static TYPE_1 METHOD_1 ( String VAR_1 , String VAR_2 ) { TYPE_1 . Builder builder = TYPE_1 . METHOD_2 ( new TYPE_2 ( VAR_4 , VAR_6 , STRING_1 , VAR_8 ) ) ; builder . VAR_9 ( VAR_1 . METHOD_3 ( ) ) . METHOD_4 ( VAR_2 . METHOD_3 ( ) ) . METHOD_5 ( 0 ) ; return builder . build ( ) ; } |
belong _CODE_ ? other _CODE_ more a POJO type class methods pulled internal helper class | <START> private static TYPE_1 METHOD_1 ( TYPE_2 VAR_1 , ANNOTATION_1 String VAR_2 ) { <END> try { if ( TYPE_3 . METHOD_2 ( VAR_2 ) ) { VAR_2 = TYPE_1 . METHOD_3 ( VAR_1 ) ; } return new TYPE_1 ( VAR_2 ) ; } catch ( Exception e ) { logger . error ( STRING_1 , VAR_2 , e ) ; throw e ; } } | private static String METHOD_1 ( TYPE_2 VAR_1 , ANNOTATION_1 String VAR_2 ) { try { if ( TYPE_3 . METHOD_2 ( VAR_2 ) ) { VAR_2 = TYPE_1 . METHOD_3 ( VAR_1 ) ; } return VAR_2 ; } catch ( Exception e ) { logger . error ( STRING_1 , VAR_2 , e ) ; throw e ; } } |
code : channel close ( ) ; | public void METHOD_1 ( TYPE_1 channel ) throws IOException { <START> this . channel = channel ; <END> } | public void METHOD_1 ( TYPE_1 channel ) throws IOException { this . channel . close ( ) ; this . channel = channel ; } |
close calling super METHOD_1 | public void METHOD_1 ( TYPE_1 context ) throws InterruptedException { <START> super . METHOD_1 ( context ) ; <END> VAR_1 . values ( ) . forEach ( TYPE_2 : : close ) ; } | public void METHOD_1 ( TYPE_1 context ) throws InterruptedException { VAR_1 . values ( ) . forEach ( TYPE_2 : : close ) ; super . METHOD_1 ( context ) ; } |
list exceptions bring test ? t replace throws Exception | void METHOD_1 ( ) <START> throws TYPE_1 , TYPE_2 , TYPE_3 , TYPE_4 , TYPE_5 , TYPE_6 , <END> TYPE_7 { byte [ ] VAR_1 = STRING_1 . METHOD_2 ( STRING_2 ) ; VAR_2 . METHOD_3 ( VAR_1 ) ; TYPE_8 VAR_3 = new TYPE_8 ( VAR_1 ) ; } | void METHOD_1 ( ) throws Exception { byte [ ] VAR_1 = STRING_1 . METHOD_2 ( STRING_2 ) ; VAR_2 . METHOD_3 ( VAR_1 ) ; TYPE_8 VAR_3 = new TYPE_8 ( VAR_1 ) ; } |
I m pretty removing change line fix test failure problem I don t a subdeployment attachment case a subdeployment a management VAR_1 getName ( ) A user t assign a management a subdeployment s internal part top level deployment independently added server config | private static TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { if ( VAR_1 . METHOD_2 ( ) == null ) { return TYPE_1 . METHOD_3 ( VAR_2 , VAR_1 . METHOD_4 ( TYPE_3 . VAR_4 ) ) ; } else { <START> return METHOD_1 ( VAR_1 . METHOD_2 ( ) ) . append ( VAR_5 , VAR_1 . METHOD_4 ( TYPE_3 . VAR_4 ) ) ; <END> } } | private static TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { if ( VAR_1 . METHOD_2 ( ) == null ) { return TYPE_1 . METHOD_3 ( VAR_2 , VAR_1 . METHOD_4 ( TYPE_3 . VAR_4 ) ) ; } else { return METHOD_1 ( VAR_1 . METHOD_2 ( ) ) . append ( VAR_5 , VAR_1 . getName ( ) ) ; } } |
more meaningless access changes | <START> void METHOD_1 ( String id , TYPE_2 . TYPE_3 VAR_1 ) { <END> VAR_2 . put ( id , VAR_1 ) ; } | public void METHOD_1 ( String id , TYPE_2 . TYPE_3 VAR_1 ) { VAR_2 . put ( id , VAR_1 ) ; } |
I call METHOD_1 mode ( METHOD_1 a - op wasn t started ) implement other modes don t update piece code | public void METHOD_1 ( ) { if ( VAR_1 . METHOD_2 ( true , false ) ) { METHOD_3 ( ) ; VAR_2 . METHOD_1 ( ) ; } <START> if ( config . VAR_3 ( ) == TYPE_1 . VAR_5 ) { <END> VAR_6 . METHOD_1 ( ) ; } } | public void METHOD_1 ( ) { if ( VAR_1 . METHOD_2 ( true , false ) ) { METHOD_3 ( ) ; VAR_2 . METHOD_1 ( ) ; } VAR_6 . METHOD_1 ( ) ; } |
call update update apply change ignore | public static synchronized void METHOD_1 ( int VAR_1 ) { if ( VAR_2 == null ) { VAR_2 = new TYPE_1 ( VAR_1 ) ; } else if ( VAR_2 . METHOD_2 ( ) != VAR_1 ) { <START> VAR_2 . METHOD_3 ( VAR_1 ) ; <END> } } | public static synchronized void METHOD_1 ( int VAR_1 ) { if ( VAR_2 == null ) { VAR_2 = new TYPE_1 ( VAR_1 ) ; } else { VAR_2 . METHOD_3 ( VAR_1 ) ; } } |
t return | public String toString ( ) { <START> return String . valueOf ( value ) ; <END> } | public String toString ( ) { return value ; } |
change log | public List < TYPE_1 > METHOD_1 ( ) { try { return Context . VAR_1 ( ) . METHOD_2 ( "" ) ; } catch ( Exception e ) { <START> logger . error ( STRING_1 , e ) ; <END> } return Collections . VAR_2 ( ) ; } | public List < TYPE_1 > METHOD_1 ( ) { try { return Context . VAR_1 ( ) . METHOD_2 ( "" ) ; } catch ( Exception e ) { log . error ( STRING_1 , e ) ; } return Collections . VAR_2 ( ) ; } |
_CODE_ certificate class sending / information View | public String METHOD_1 ( ) { <START> VAR_1 = StringUtils . isEmpty ( VAR_2 . METHOD_2 ( ) . getName ( ) ) ? VAR_3 <END> : VAR_2 . METHOD_2 ( ) . getName ( ) ; return VAR_1 ; } | public String METHOD_1 ( ) { return VAR_1 ; } |
I able constructor ? need chain constructors | <START> TYPE_4 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 , int VAR_4 , <END> TYPE_3 VAR_5 , int VAR_6 ) { super ( VAR_2 , VAR_3 , VAR_4 , VAR_5 , VAR_6 ) ; this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; this . VAR_4 = VAR_4 ; this . VAR_5 = VAR_5 ; } | TYPE_4 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 , int VAR_4 , TYPE_3 VAR_5 , int VAR_6 ) { super ( VAR_2 , VAR_3 , VAR_4 , VAR_5 , VAR_6 ) ; } |
handled item VAR_2 ( ) | public String METHOD_1 ( final Object element ) { TYPE_1 item = ( TYPE_1 ) element ; <START> String VAR_1 = item . VAR_2 ( ) ; if ( VAR_1 == null || VAR_1 . trim ( ) . length ( ) == 0 ) { VAR_1 = item . VAR_3 ( ) . getName ( ) ; } <END> return VAR_1 ; } | public String METHOD_1 ( final Object element ) { TYPE_1 item = ( TYPE_1 ) element ; return item . VAR_2 ( ) ; } |
please recheck condition VAR_1 = true log ( failed ) block wrong | public boolean METHOD_1 ( ) { final boolean [ ] VAR_1 = { false } ; TYPE_1 . METHOD_2 ( new TYPE_2 ( ) { @Override public void run ( ) { if ( ! VAR_2 . METHOD_3 ( file . VAR_3 ( ) , false ) ) { TYPE_3 . VAR_5 . debug ( STRING_1 , STRING_2 + file ) ; <START> VAR_1 [ 0 ] = true ; <END> } } } ) ; return VAR_1 [ 0 ] ; } | public boolean METHOD_1 ( ) { final boolean [ ] VAR_1 = { false } ; TYPE_1 . METHOD_2 ( new TYPE_2 ( ) { @Override public void run ( ) { if ( VAR_2 . METHOD_3 ( file . VAR_3 ( ) , false ) ) { VAR_1 [ 0 ] = true ; } else { TYPE_3 . VAR_5 . debug ( STRING_1 , STRING_2 + file ) ; } } } ) ; return VAR_1 [ 0 ] ; } |
isn t necessary new TYPE_1 ( file ) create file doesn t exist | private void METHOD_1 ( File VAR_1 , String name , String content ) throws IOException { File file = new File ( VAR_1 , name ) ; <START> file . VAR_2 ( ) ; <END> TYPE_1 VAR_3 = null ; try { VAR_3 = new TYPE_1 ( file ) ; VAR_3 . write ( content . VAR_4 ( STRING_1 ) ) ; } finally { if ( VAR_3 != null ) VAR_3 . close ( ) ... | private void METHOD_1 ( File VAR_1 , String name , String content ) throws IOException { File file = new File ( VAR_1 , name ) ; TYPE_1 VAR_3 = new TYPE_1 ( file ) ; try { VAR_3 . write ( content . VAR_4 ( STRING_1 ) ) ; } finally { VAR_3 . close ( ) ; } } |
VAR_9 grouping node defined nt : unstructured cnd arg ( tko : servers type ) throws exception create attempted changing arg null create issue | public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) throws TYPE_3 { TYPE_4 . METHOD_2 ( VAR_1 , STRING_1 ) ; TYPE_4 . METHOD_3 ( ( VAR_1 . METHOD_4 ( ) == org . VAR_2 . VAR_3 . VAR_4 . TYPE_5 . TYPE_2 . TYPE_6 . VAR_8 ) , STRING_2 ) ; METHOD_5 ( VAR_1 ) ; <START> return create ( VAR_1 , VAR_9 , TYPE_7 . VAR_11 ) ; <END> } | public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) throws TYPE_3 { TYPE_4 . METHOD_2 ( VAR_1 , STRING_1 ) ; TYPE_4 . METHOD_3 ( ( VAR_1 . METHOD_4 ( ) == org . VAR_2 . VAR_3 . VAR_4 . TYPE_5 . TYPE_2 . TYPE_6 . VAR_8 ) , STRING_2 ) ; METHOD_5 ( VAR_1 ) ; return create ( VAR_1 , VAR_9 , null ) ; } |
longer ! rip field | public TYPE_5 ( TYPE_1 < T > VAR_2 , TYPE_2 < T > filter , List < TYPE_3 < T > > VAR_3 ) { this . VAR_2 = VAR_2 ; this . filter = filter ; this . VAR_3 = VAR_3 ; <START> this . VAR_4 = TYPE_4 . create ( ) ; <END> } | public TYPE_5 ( TYPE_1 < T > VAR_2 , TYPE_2 < T > filter , List < TYPE_3 < T > > VAR_3 ) { this . VAR_2 = VAR_2 ; this . filter = filter ; this . VAR_3 = VAR_3 ; } |
condition : ( ! METHOD_1 ( ) ) | public TYPE_1 add ( int VAR_1 , int VAR_2 , int VAR_3 , int VAR_4 , String offset , TYPE_2 VAR_5 ) { if ( METHOD_1 ( ) ) { <START> VAR_4 = 0 ; <END> } return add ( VAR_5 , VAR_1 , VAR_2 , VAR_3 , VAR_4 , offset , INT_1 , 1 , 1 ) ; } | public TYPE_1 add ( int VAR_1 , int VAR_2 , int VAR_3 , int VAR_4 , String offset , TYPE_2 VAR_5 ) { if ( ! METHOD_1 ( ) ) { VAR_4 = 0 ; } return add ( VAR_5 , VAR_1 , VAR_2 , VAR_3 , VAR_4 , offset , INT_1 , 1 , 1 ) ; } |
mentioned removing need VAR_2 parameter checking type default ? please | public void METHOD_1 ( ) { <START> VAR_1 = new TYPE_1 < > ( Integer . VAR_2 , VAR_3 , <END> INT_1 , new TYPE_2 < > ( 0 , 100 , false , false ) ) ; VAR_4 = - 1 ; VAR_1 . METHOD_2 ( VAR_5 - > VAR_4 = ( int ) VAR_5 . METHOD_3 ( ) ) ; } | public void METHOD_1 ( ) { VAR_1 = new TYPE_1 < > ( VAR_3 , INT_1 , new TYPE_2 < > ( 0 , 100 , false , false ) ) ; VAR_4 = - 1 ; VAR_1 . METHOD_2 ( VAR_5 - > VAR_4 = ( int ) VAR_5 . METHOD_3 ( ) ) ; } |
instead METHOD_1 ( TYPE_1 METHOD_1 ( Context ( enriched others future simply a _CODE_ pass METHOD_1 _CODE_ | <START> private void METHOD_1 ( TYPE_1 VAR_1 ) { <END> if ( VAR_1 . METHOD_2 ( ) . contains ( STRING_1 ) ) return ; METHOD_3 ( ) ; METHOD_4 ( VAR_1 . METHOD_5 ( ) ) ; METHOD_4 ( VAR_1 . METHOD_6 ( ) ) ; METHOD_4 ( VAR_1 . METHOD_7 ( ) ) ; METHOD_1 ( VAR_1 . METHOD_5 ( ) ) ; METHOD_1 ( VAR_1 . METHOD_6 ( ) ) ; METHOD_1 ... | private void METHOD_1 ( TYPE_1 VAR_1 ) { METHOD_3 ( ) ; METHOD_4 ( VAR_1 . METHOD_5 ( ) ) ; METHOD_1 ( VAR_1 . METHOD_5 ( ) , true ) ; METHOD_1 ( VAR_1 . METHOD_6 ( ) , false ) ; METHOD_1 ( VAR_1 . METHOD_7 ( ) , false ) ; } |
_CODE_ ( ) overridden toString ( ) | public void METHOD_1 ( TYPE_1 VAR_1 , Class < ? > type , Type VAR_2 , TYPE_2 [ ] VAR_3 , TYPE_3 VAR_4 , TYPE_4 < String , Object > VAR_5 , TYPE_5 VAR_6 ) throws IOException , TYPE_6 { <START> VAR_6 . write ( VAR_1 . toString ( ) . METHOD_2 ( ) ) ; <END> } | public void METHOD_1 ( TYPE_1 VAR_1 , Class < ? > type , Type VAR_2 , TYPE_2 [ ] VAR_3 , TYPE_3 VAR_4 , TYPE_4 < String , Object > VAR_5 , TYPE_5 VAR_6 ) throws IOException , TYPE_6 { VAR_6 . write ( VAR_1 . name ( ) . METHOD_2 ( ) ) ; } |
I d move super METHOD_1 ( ) safety _CODE_ line | public void METHOD_1 ( TYPE_1 context ) throws Exception { METHOD_2 ( ) ; VAR_1 = null ; super . METHOD_1 ( context ) ; VAR_2 = null ; <START> if ( VAR_3 != null ) { <END> TYPE_2 . METHOD_3 ( ) . METHOD_4 ( VAR_3 , TYPE_3 . class ) ; } } | public void METHOD_1 ( TYPE_1 context ) throws Exception { METHOD_2 ( ) ; VAR_1 = null ; if ( VAR_3 != null ) { TYPE_2 . METHOD_3 ( ) . METHOD_4 ( VAR_3 , TYPE_3 . class ) ; } super . METHOD_1 ( context ) ; VAR_2 = null ; } |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.