ReviewComments stringlengths 1 2.35k | OriginalCode stringlengths 28 487 | ReviewedCode stringlengths 14 463 |
|---|---|---|
String isEmpty ( ) avaible JDK 1 6 please useif ( VAR_1 = = null || VAR_1 length ( ) = = 0 ) return ; compilable JDK 1 5 | protected static String METHOD_1 ( String VAR_1 ) { <START> if ( VAR_1 == null || VAR_1 . isEmpty ( ) ) return "" ; <END> while ( VAR_1 . METHOD_2 ( VAR_2 ) . length > INT_1 ) { VAR_1 = VAR_1 . substring ( 0 , VAR_1 . length ( ) - 1 ) ; } return VAR_1 ; } | protected static String METHOD_1 ( String VAR_1 ) { if ( VAR_1 == null || VAR_1 . length ( ) == 0 ) return "" ; while ( VAR_1 . METHOD_2 ( VAR_2 ) . length > INT_1 ) { VAR_1 = VAR_1 . substring ( 0 , VAR_1 . length ( ) - 1 ) ; } return VAR_1 ; } |
\s include zero - width - joiner stuff ? languages fun : D | public TYPE_1 ( final String VAR_2 , final String text ) { this . VAR_2 = VAR_2 ; <START> this . text = text . VAR_3 ( STRING_1 , STRING_2 ) ; <END> } | public TYPE_1 ( final String VAR_2 , final String text ) { this . VAR_2 = VAR_2 ; this . text = text ; } |
log - throw other surprise exceptions | public void METHOD_1 ( Throwable VAR_1 ) { if ( VAR_1 instanceof IOException ) { Utils . VAR_2 ( VAR_3 , VAR_4 ) ; <START> } <END> } | public void METHOD_1 ( Throwable VAR_1 ) { Utils . VAR_2 ( VAR_3 , VAR_4 ) ; } |
collapse new constructor function ( VAR_2 text null VAR_3 ) ; | <START> public TYPE_2 ( final String VAR_2 , final String text , final TYPE_1 VAR_3 ) { <END> this . VAR_2 = VAR_2 ; this . text = text ; this . VAR_4 = null ; this . VAR_3 = VAR_3 ; } | public TYPE_2 ( final String VAR_2 , final String text , final TYPE_1 VAR_3 ) { this ( VAR_2 , text , null , VAR_3 ) ; } |
need a toast bookmarking page ? s expensive operation especially | public void METHOD_1 ( ) { new TYPE_1 ( METHOD_2 ( ) , VAR_1 ) { @Override public void METHOD_3 ( ) { <START> TYPE_2 . METHOD_4 ( METHOD_2 ( ) , R . string . VAR_2 , TYPE_2 . VAR_3 ) . METHOD_5 ( ) ; <END> } @Override public void METHOD_6 ( TYPE_3 result ) { TYPE_2 . METHOD_4 ( METHOD_2 ( ) , R . string . VAR_4 , TYPE_2 . VAR_3 ) . METHOD_5 ( ) ; } } . execute ( ) ; } | public void METHOD_1 ( ) { new TYPE_1 ( METHOD_2 ( ) , VAR_1 ) { @Override public void METHOD_6 ( TYPE_3 result ) { TYPE_2 . METHOD_4 ( METHOD_2 ( ) , R . string . VAR_4 , TYPE_2 . VAR_3 ) . METHOD_5 ( ) ; } } . execute ( ) ; } |
enclose ( other conditional ) bodies curly braces | public void METHOD_1 ( boolean VAR_1 ) { if ( ! VAR_1 ) <START> VAR_2 . METHOD_2 ( ) ; <END> VAR_2 . METHOD_3 ( VAR_1 ) ; } | public void METHOD_1 ( boolean VAR_1 ) { if ( ! VAR_1 ) { VAR_2 . METHOD_2 ( ) ; } VAR_2 . METHOD_3 ( VAR_1 ) ; } |
read ? saving | public void METHOD_1 ( TYPE_1 VAR_1 ) { super . METHOD_1 ( VAR_1 ) ; VAR_1 . METHOD_2 ( STRING_1 , VAR_2 . METHOD_3 ( ) . toString ( ) ) ; <START> VAR_1 . METHOD_2 ( STRING_2 , VAR_2 . METHOD_3 ( ) . toString ( ) ) ; <END> } | public void METHOD_1 ( TYPE_1 VAR_1 ) { super . METHOD_1 ( VAR_1 ) ; VAR_1 . METHOD_2 ( STRING_1 , VAR_2 . METHOD_3 ( ) . toString ( ) ) ; } |
I drop calculation Math VAR_4 ( ) call | public void METHOD_1 ( TYPE_1 event ) { if ( VAR_1 != null && VAR_1 . METHOD_2 ( ) != null ) { VAR_2 . METHOD_3 ( true ) ; VAR_1 . METHOD_4 ( ) ; TYPE_2 VAR_3 = new TYPE_2 ( TYPE_3 . METHOD_5 ( ) ) ; VAR_3 . METHOD_6 ( new TYPE_4 ( ) { @Override public void run ( ) { VAR_2 . METHOD_3 ( false ) ; } <START> } , ( long ) Math . VAR_4 ( FLOAT_1 * TYPE_5 . VAR_6 ) ) ; <END> } } | public void METHOD_1 ( TYPE_1 event ) { if ( VAR_1 != null && VAR_1 . METHOD_2 ( ) != null ) { VAR_2 . METHOD_3 ( true ) ; VAR_1 . METHOD_4 ( ) ; TYPE_2 VAR_3 = new TYPE_2 ( TYPE_3 . METHOD_5 ( ) ) ; VAR_3 . METHOD_6 ( new TYPE_4 ( ) { @Override public void run ( ) { VAR_2 . METHOD_3 ( false ) ; } } , ( long ) ( FLOAT_1 * TYPE_5 . VAR_6 ) ) ; } } |
block line 187 191 simplified toreturn VAR_4 ! = null && VAR_4 && cache VAR_3 ; | private boolean METHOD_1 ( ) { if ( cache . VAR_1 != context . VAR_2 . METHOD_2 ( ) ) { cache . VAR_3 = false ; cache . VAR_1 = context . VAR_2 . METHOD_2 ( ) ; } Boolean VAR_4 = ( Boolean ) METHOD_3 ( STRING_1 ) ; if ( VAR_4 == null ? false : VAR_4 && cache . VAR_3 ) { return true ; } <START> return false ; <END> } | private boolean METHOD_1 ( ) { if ( cache . VAR_1 != context . VAR_2 . METHOD_2 ( ) ) { cache . VAR_3 = false ; cache . VAR_1 = context . VAR_2 . METHOD_2 ( ) ; } Boolean VAR_4 = ( Boolean ) METHOD_3 ( STRING_1 ) ; return VAR_4 == null ? false : VAR_4 && cache . VAR_3 ; } |
A defensive copy list safer IMO | private TYPE_2 ( List < String > VAR_2 , TYPE_1 VAR_3 ) { this . VAR_4 = VAR_2 ; <START> this . VAR_2 = VAR_2 ; <END> this . VAR_3 = VAR_3 ; } | private TYPE_2 ( List < String > VAR_2 , TYPE_1 VAR_3 ) { this . VAR_4 = VAR_2 ; this . VAR_2 = new ArrayList < String > ( ) ; this . VAR_2 . addAll ( VAR_2 ) ; this . VAR_3 = VAR_3 ; } |
instead VAR_2 output data ll parameters event line nicely formatted | public Integer METHOD_1 ( ) throws Throwable { String VAR_1 = TYPE_1 . getInstance ( ) . METHOD_2 ( ) < 2 ? TYPE_2 : TYPE_2 . METHOD_3 ( STRING_1 , STRING_2 ) ; String VAR_2 = TYPE_3 . parse ( VAR_1 ) . METHOD_4 ( ) . query ( data . toString ( ) ) . build ( ) . toString ( ) ; <START> Log . d ( TYPE_5 . VAR_4 , STRING_3 + VAR_2 ) ; <END> return TYPE_4 . get ( VAR_2 ) . METHOD_5 ( STRING_4 , VAR_5 ) . METHOD_6 ( ) ; } | public Integer METHOD_1 ( ) throws Throwable { String VAR_1 = TYPE_1 . getInstance ( ) . METHOD_2 ( ) < 2 ? TYPE_2 : TYPE_2 . METHOD_3 ( STRING_1 , STRING_2 ) ; String VAR_2 = TYPE_3 . parse ( VAR_1 ) . METHOD_4 ( ) . query ( data . toString ( ) ) . build ( ) . toString ( ) ; return TYPE_4 . get ( VAR_2 ) . METHOD_5 ( STRING_4 , VAR_5 ) . METHOD_6 ( ) ; } |
log rethrow exception correct | public Object METHOD_1 ( TYPE_1 [ ] VAR_1 ) throws TYPE_2 { result . clear ( ) ; try { if ( VAR_1 . length == 1 && VAR_2 != null && VAR_1 [ 0 ] != null ) { String VAR_3 = ( ( TYPE_3 ) VAR_2 ) . METHOD_2 ( VAR_1 [ 0 ] . get ( ) ) ; result . set ( VAR_4 . METHOD_3 ( VAR_3 ) ) ; } <START> } catch ( Exception ex ) { <END> LOG . error ( ex ) ; } return result ; } | public Object METHOD_1 ( TYPE_1 [ ] VAR_1 ) throws TYPE_2 { result . clear ( ) ; if ( VAR_1 . length == 1 && VAR_2 != null && VAR_1 [ 0 ] != null ) { String VAR_3 = ( ( TYPE_3 ) VAR_2 ) . METHOD_2 ( VAR_1 [ 0 ] . get ( ) ) ; result . set ( VAR_4 . METHOD_3 ( VAR_3 ) ) ; } return result ; } |
s exceptions bubble a nice stack trace aids debugging | public void METHOD_1 ( ) throws TYPE_1 , TYPE_2 { TYPE_3 VAR_1 = TYPE_7 . VAR_3 ; TYPE_3 [ ] VAR_4 = new TYPE_3 [ ] { VAR_1 } ; TYPE_4 VAR_5 = new TYPE_4 ( TYPE_5 . class . METHOD_2 ( VAR_6 ) . METHOD_3 ( ) ) ; try { VAR_5 . METHOD_4 ( VAR_4 ) ; <START> METHOD_5 ( STRING_1 ) ; <END> } catch ( TYPE_6 VAR_7 ) { } } | public void METHOD_1 ( ) throws TYPE_2 { TYPE_3 VAR_1 = TYPE_7 . VAR_3 ; TYPE_3 [ ] VAR_4 = new TYPE_3 [ ] { VAR_1 } ; TYPE_4 VAR_5 = new TYPE_4 ( ) ; VAR_5 . METHOD_4 ( VAR_4 ) ; } |
s exceptions bubble a stack trace aids debugging | public void METHOD_1 ( ) throws TYPE_1 , TYPE_2 { TYPE_3 VAR_1 = TYPE_7 . VAR_3 ; TYPE_3 VAR_4 = TYPE_7 . VAR_3 ; TYPE_3 [ ] VAR_5 = new TYPE_3 [ ] { VAR_1 , VAR_4 } ; TYPE_4 VAR_6 = new TYPE_4 ( TYPE_5 . class . METHOD_2 ( VAR_7 ) . METHOD_3 ( ) ) ; try { <START> VAR_6 . METHOD_4 ( VAR_5 ) ; <END> METHOD_5 ( STRING_1 ) ; } catch ( TYPE_6 VAR_8 ) { } } | public void METHOD_1 ( ) throws TYPE_2 { TYPE_3 VAR_1 = TYPE_7 . VAR_3 ; TYPE_3 VAR_4 = TYPE_7 . VAR_3 ; TYPE_3 [ ] VAR_5 = new TYPE_3 [ ] { VAR_1 , VAR_4 } ; TYPE_4 VAR_6 = new TYPE_4 ( ) ; VAR_6 . METHOD_4 ( VAR_5 ) ; } |
works I m difference doc imply return true : returns true search launched false activity respond ( ) | public boolean METHOD_1 ( ) { METHOD_2 ( ) ; VAR_1 . METHOD_3 ( ) ; <START> return false ; <END> } | public boolean METHOD_1 ( ) { METHOD_2 ( ) ; VAR_1 . METHOD_3 ( ) ; return true ; } |
check size ( ) > 0 crashes results press keyboard | public TYPE_1 METHOD_1 ( ) { <START> if ( VAR_1 != null ) { <END> return VAR_1 . get ( 0 ) ; } else { return null ; } } | public TYPE_1 METHOD_1 ( ) { if ( VAR_1 != null && ! VAR_1 . isEmpty ( ) ) { return VAR_1 . get ( 0 ) ; } else { return null ; } } |
String instead TYPE_1 ? hive magic method simpler | <START> public TYPE_1 METHOD_1 ( String VAR_1 , String VAR_2 ) { <END> assert VAR_3 != null : STRING_1 ; return new TYPE_1 ( VAR_3 . METHOD_2 ( VAR_1 , VAR_2 ) ) ; } | public String METHOD_1 ( String VAR_1 , String VAR_2 ) { assert VAR_3 != null : STRING_1 ; return VAR_3 . METHOD_2 ( VAR_1 , VAR_2 ) ; } |
done | <START> public void METHOD_1 ( ) throws TYPE_1 , IOException { <END> TYPE_2 VAR_1 = TYPE_4 . VAR_3 ; TYPE_2 VAR_4 = TYPE_4 . VAR_3 ; TYPE_2 [ ] VAR_5 = new TYPE_2 [ ] { VAR_1 , VAR_4 } ; TYPE_3 VAR_6 = new TYPE_3 ( ) ; VAR_6 . METHOD_2 ( VAR_5 ) ; } | public void METHOD_1 ( ) throws TYPE_1 { TYPE_2 VAR_1 = TYPE_4 . VAR_3 ; TYPE_2 VAR_4 = TYPE_4 . VAR_3 ; TYPE_2 [ ] VAR_5 = new TYPE_2 [ ] { VAR_1 , VAR_4 } ; TYPE_3 VAR_6 = new TYPE_3 ( ) ; VAR_6 . METHOD_2 ( VAR_5 ) ; } |
done | <START> public void METHOD_1 ( ) throws TYPE_1 , IOException { <END> TYPE_2 VAR_1 = TYPE_4 . VAR_3 ; TYPE_2 [ ] VAR_4 = new TYPE_2 [ ] { VAR_1 } ; TYPE_3 VAR_5 = new TYPE_3 ( ) ; VAR_5 . METHOD_2 ( VAR_4 ) ; } | public void METHOD_1 ( ) throws TYPE_1 { TYPE_2 VAR_1 = TYPE_4 . VAR_3 ; TYPE_2 [ ] VAR_4 = new TYPE_2 [ ] { VAR_1 } ; TYPE_3 VAR_5 = new TYPE_3 ( ) ; VAR_5 . METHOD_2 ( VAR_4 ) ; } |
yeah meh removing close ( ) | public void METHOD_1 ( ) throws TYPE_1 , IOException { TYPE_2 VAR_1 = TYPE_4 . VAR_3 ; TYPE_2 VAR_4 = TYPE_4 . VAR_3 ; TYPE_2 [ ] VAR_5 = new TYPE_2 [ ] { VAR_1 , VAR_4 } ; TYPE_3 VAR_6 = new TYPE_3 ( ) ; VAR_6 . METHOD_2 ( VAR_5 ) ; <START> VAR_6 . close ( ) ; <END> } | public void METHOD_1 ( ) throws TYPE_1 , IOException { TYPE_2 VAR_1 = TYPE_4 . VAR_3 ; TYPE_2 VAR_4 = TYPE_4 . VAR_3 ; TYPE_2 [ ] VAR_5 = new TYPE_2 [ ] { VAR_1 , VAR_4 } ; TYPE_3 VAR_6 = new TYPE_3 ( ) ; VAR_6 . METHOD_2 ( VAR_5 ) ; } |
page METHOD_4 ( ) | private void METHOD_1 ( final TYPE_1 VAR_1 ) { <START> if ( VAR_2 . METHOD_2 ( ) . METHOD_3 ( ) . METHOD_4 ( ) ) { <END> new TYPE_2 ( VAR_3 ) { @Override public void METHOD_5 ( TYPE_3 VAR_4 ) { METHOD_6 ( VAR_1 , VAR_4 ) ; } @Override public void METHOD_7 ( Throwable VAR_5 ) { Log . VAR_6 ( TAG , STRING_1 , VAR_5 ) ; METHOD_8 ( ) ; } } . execute ( ) ; } else { METHOD_6 ( VAR_1 , VAR_7 ) ; } } | private void METHOD_1 ( final TYPE_1 VAR_1 ) { if ( VAR_2 . METHOD_2 ( ) . METHOD_4 ( ) ) { new TYPE_2 ( VAR_3 ) { @Override public void METHOD_5 ( TYPE_3 VAR_4 ) { METHOD_6 ( VAR_1 , VAR_4 ) ; } @Override public void METHOD_7 ( Throwable VAR_5 ) { Log . VAR_6 ( TAG , STRING_1 , VAR_5 ) ; METHOD_8 ( ) ; } } . execute ( ) ; } else { METHOD_6 ( VAR_1 , VAR_7 ) ; } } |
private | <START> public TYPE_5 . TYPE_6 . TYPE_9 METHOD_1 ( ) { <END> TYPE_2 client = context . VAR_2 ( ) . METHOD_2 ( TYPE_7 . TYPE_8 . METHOD_3 ( ) ) ; try { return client . query ( TYPE_7 . TYPE_8 . METHOD_3 ( ) , null , STRING_1 , new String [ ] { Integer . toString ( TYPE_7 . VAR_4 ) , Integer . toString ( TYPE_7 . VAR_5 ) } , STRING_2 ) ; } catch ( TYPE_4 e ) { throw new RuntimeException ( e ) ; } } | private TYPE_5 . TYPE_6 . TYPE_9 METHOD_1 ( ) { TYPE_2 client = context . VAR_2 ( ) . METHOD_2 ( TYPE_7 . TYPE_8 . METHOD_3 ( ) ) ; try { return client . query ( TYPE_7 . TYPE_8 . METHOD_3 ( ) , null , STRING_1 , new String [ ] { Integer . toString ( TYPE_7 . VAR_4 ) , Integer . toString ( TYPE_7 . VAR_5 ) } , STRING_2 ) ; } catch ( TYPE_4 e ) { throw new RuntimeException ( e ) ; } } |
METHOD_3 ( ) doesn t need done s done automatically TYPE_1 _CODE_ ( ) instead modify _CODE_ : 132 _CODE_ instead _CODE_ | public TYPE_1 METHOD_1 ( String VAR_1 ) { <START> return new TYPE_1 ( VAR_1 . METHOD_2 ( STRING_1 , "" ) . METHOD_3 ( STRING_2 , STRING_3 ) , this ) ; <END> } | public TYPE_1 METHOD_1 ( String VAR_1 ) { return new TYPE_1 ( VAR_1 . METHOD_2 ( STRING_1 , "" ) , this ) ; } |
generally agree + good find method return false handled ( android view TYPE_1 ) | public boolean METHOD_1 ( TYPE_1 event ) { try { return super . METHOD_1 ( event ) ; } catch ( RuntimeException e ) { <START> return true ; <END> } } | public boolean METHOD_1 ( TYPE_1 event ) { try { return super . METHOD_1 ( event ) ; } catch ( RuntimeException e ) { return false ; } } |
simply return VAR_3 else case worry contents info ? prevent more crashes | public int getType ( ) { if ( VAR_1 . startsWith ( STRING_1 ) ) { return VAR_2 ; } else if ( VAR_1 . startsWith ( STRING_2 ) ) { return VAR_3 ; } else if ( info . startsWith ( STRING_3 ) ) { return VAR_3 ; } else { <START> throw new RuntimeException ( STRING_4 ) ; <END> } } | public int getType ( ) { if ( VAR_1 . startsWith ( STRING_1 ) ) { return VAR_2 ; } else if ( VAR_1 . startsWith ( STRING_2 ) ) { return VAR_3 ; } else if ( info . startsWith ( STRING_3 ) ) { return VAR_3 ; } else { return VAR_3 ; } } |
I prefer move catch block METHOD_1 implementation called another place | protected void run ( Date VAR_1 ) { try { TYPE_1 . METHOD_1 ( METHOD_2 ( ) ) ; <START> } catch ( Exception e ) { <END> Log . d ( STRING_1 , STRING_2 , e ) ; } } | protected void run ( Date VAR_1 ) { TYPE_1 . METHOD_1 ( METHOD_2 ( ) ) ; } |
inline VAR_1 | private void METHOD_1 ( ) { boolean VAR_1 = TYPE_1 . METHOD_2 ( VAR_2 ) ; TYPE_2 VAR_3 = ( TYPE_2 ) VAR_4 . METHOD_3 ( R . id . VAR_5 ) ; <START> if ( ! VAR_1 ) { <END> VAR_3 . setText ( R . string . VAR_6 ) ; } else { VAR_3 . setText ( R . string . VAR_7 ) ; } METHOD_4 ( ) ; TYPE_3 . METHOD_5 ( VAR_4 ) ; } | private void METHOD_1 ( ) { TYPE_2 VAR_3 = ( TYPE_2 ) VAR_4 . METHOD_3 ( R . id . VAR_5 ) ; if ( ! TYPE_1 . METHOD_2 ( VAR_2 ) ) { VAR_3 . setText ( R . string . VAR_6 ) ; } else { VAR_3 . setText ( R . string . VAR_7 ) ; } METHOD_4 ( ) ; TYPE_3 . METHOD_5 ( VAR_4 ) ; } |
inline variable VAR_5 | public static boolean METHOD_1 ( Context ctx ) { TYPE_1 VAR_1 = ( TYPE_1 ) ctx . VAR_2 ( Context . VAR_3 ) ; TYPE_2 VAR_4 = VAR_1 . METHOD_2 ( ) ; boolean VAR_5 = VAR_4 != null && VAR_4 . METHOD_3 ( ) ; <START> return VAR_5 ; <END> } | public static boolean METHOD_1 ( Context ctx ) { TYPE_1 VAR_1 = ( TYPE_1 ) ctx . VAR_2 ( Context . VAR_3 ) ; TYPE_2 VAR_4 = VAR_1 . METHOD_2 ( ) ; return VAR_4 != null && VAR_4 . METHOD_3 ( ) ; } |
_CODE_ networking _CODE_ instead | public void METHOD_1 ( Throwable VAR_1 ) { if ( Utils . VAR_2 ( VAR_1 , TYPE_1 . class ) && TYPE_2 . getInstance ( ) . METHOD_2 ( ) < 2 ) { TYPE_2 . getInstance ( ) . METHOD_3 ( true ) ; <START> TYPE_3 . METHOD_4 ( ) ; <END> METHOD_5 ( ) ; return ; } throw new RuntimeException ( VAR_1 ) ; } | public void METHOD_1 ( Throwable VAR_1 ) { } |
TYPE_6 ? VAR_2 length ( ) | protected TYPE_1 METHOD_1 ( TYPE_2 uri ) { if ( VAR_1 == null ) { return null ; } for ( String VAR_2 : VAR_3 ) { if ( uri . VAR_4 ( ) . startsWith ( VAR_2 ) ) { TYPE_3 VAR_5 = next . VAR_6 ( uri . VAR_4 ( ) . substring ( <START> TYPE_5 . TYPE_6 . length ( ) ) ) ; <END> if ( VAR_5 == null ) { return null ; } return new TYPE_1 ( VAR_5 , VAR_1 ) ; } } return next . VAR_6 ( uri ) ; } | protected TYPE_1 METHOD_1 ( TYPE_2 uri ) { if ( VAR_1 == null ) { return null ; } for ( String VAR_2 : VAR_3 ) { if ( uri . VAR_4 ( ) . startsWith ( VAR_2 ) ) { TYPE_3 VAR_5 = next . VAR_6 ( uri . VAR_4 ( ) . substring ( VAR_2 . length ( ) ) ) ; if ( VAR_5 == null ) { return null ; } return new TYPE_1 ( VAR_5 , VAR_1 ) ; } } return next . VAR_6 ( uri ) ; } |
I don t short names aren t necessary full titles ? I m a need capitalizing unknown internal external fine ja ? s talk return a string _CODE_ enum declare some constants TYPE_3 eh | public String METHOD_1 ( String url ) throws TYPE_1 { TYPE_2 VAR_1 = TYPE_3 . METHOD_2 ( url ) ; switch ( VAR_1 ) { <START> case VAR_2 : return STRING_1 ; <END> case VAR_3 : return STRING_2 ; case VAR_4 : return STRING_3 ; } return STRING_1 ; } | public String METHOD_1 ( String url ) throws TYPE_1 { return TYPE_3 . getInstance ( ) . METHOD_2 ( url ) ; } |
reverse order equals ( ) | private static boolean METHOD_1 ( ) { <START> return TYPE_1 . METHOD_2 ( ) . equals ( TYPE_1 . TYPE_3 ) ; <END> } | private static boolean METHOD_1 ( ) { return TYPE_1 . TYPE_3 . equals ( TYPE_1 . METHOD_2 ( ) ) ; } |
super minor conditional needed properties null - null | public TYPE_1 METHOD_1 ( ) { if ( METHOD_2 ( ) ) { <START> return properties ; <END> } else { return null ; } } | public TYPE_1 METHOD_1 ( ) { return properties ; } |
I m a TYPE_1 expert I want write unconditionally don t I constructor byte offsets wrong other values | public void METHOD_1 ( TYPE_1 VAR_1 , int VAR_2 ) { VAR_1 . METHOD_2 ( VAR_3 ) ; VAR_1 . METHOD_2 ( text ) ; VAR_1 . METHOD_2 ( VAR_4 ) ; VAR_1 . METHOD_3 ( VAR_5 , VAR_2 ) ; <START> if ( METHOD_4 ( ) ) { <END> VAR_1 . METHOD_3 ( properties , VAR_2 ) ; } VAR_1 . METHOD_2 ( VAR_6 ) ; VAR_1 . METHOD_2 ( description ) ; } | public void METHOD_1 ( TYPE_1 VAR_1 , int VAR_2 ) { VAR_1 . METHOD_2 ( VAR_3 ) ; VAR_1 . METHOD_2 ( text ) ; VAR_1 . METHOD_2 ( VAR_4 ) ; VAR_1 . METHOD_3 ( VAR_5 , VAR_2 ) ; VAR_1 . METHOD_3 ( properties , VAR_2 ) ; VAR_1 . METHOD_2 ( VAR_6 ) ; VAR_1 . METHOD_2 ( description ) ; } |
add properties | public void METHOD_1 ( TYPE_1 VAR_1 , int VAR_2 ) { VAR_1 . METHOD_2 ( VAR_3 ) ; VAR_1 . METHOD_2 ( text ) ; VAR_1 . METHOD_2 ( VAR_4 ) ; VAR_1 . METHOD_3 ( VAR_5 , VAR_2 ) ; <START> VAR_1 . METHOD_2 ( VAR_6 ) ; <END> VAR_1 . METHOD_2 ( description ) ; } | public void METHOD_1 ( TYPE_1 VAR_1 , int VAR_2 ) { VAR_1 . METHOD_2 ( VAR_3 ) ; VAR_1 . METHOD_2 ( text ) ; VAR_1 . METHOD_2 ( VAR_4 ) ; VAR_1 . METHOD_3 ( properties , VAR_2 ) ; VAR_1 . METHOD_3 ( VAR_5 , VAR_2 ) ; VAR_1 . METHOD_2 ( VAR_6 ) ; VAR_1 . METHOD_2 ( description ) ; } |
I unsurprising behavior client returning false / null | public boolean METHOD_1 ( ) { if ( METHOD_2 ( ) ) { return properties . VAR_1 ( ) ; } else { throw new TYPE_1 ( STRING_1 ) ; } <START> } <END> | public boolean METHOD_1 ( ) { if ( METHOD_2 ( ) ) { return properties . VAR_1 ( ) ; } else { return false ; } } |
minor : elses unnecessary | public int METHOD_1 ( ) { if ( METHOD_2 ( ) ) { return R . VAR_1 . VAR_2 ; } else if ( METHOD_3 ( ) ) { return R . VAR_1 . VAR_3 ; <START> } else { <END> return R . VAR_1 . VAR_4 ; } } | public int METHOD_1 ( ) { if ( METHOD_2 ( ) ) { return R . VAR_1 . VAR_2 ; } if ( METHOD_3 ( ) ) { return R . VAR_1 . VAR_3 ; } return R . VAR_1 . VAR_4 ; } |
I don t * methods return null field isn t present ll throw exception s implementation VAR_3 ( ) ( reported android studio ) : public _CODE_ VAR_3 ( String ) throws TYPE_4 { Object object = ( ) ; ( object instanceof _CODE_ ) { return ( _CODE_ ) object ; } else { throw JSON _CODE_ ( object _CODE_ ) ; } } | public TYPE_1 METHOD_1 ( int VAR_1 , TYPE_2 VAR_2 , TYPE_3 result ) { try { <START> if ( result . VAR_3 ( STRING_1 ) != null ) { <END> TYPE_3 VAR_4 = ( TYPE_3 ) result . VAR_3 ( STRING_1 ) . get ( 0 ) ; TYPE_1 VAR_5 = METHOD_2 ( VAR_4 . METHOD_3 ( STRING_2 ) ) ; return VAR_5 ; } return null ; } catch ( TYPE_4 e ) { Log . VAR_6 ( TAG , e ) ; return null ; } } | public TYPE_1 METHOD_1 ( int VAR_1 , TYPE_2 VAR_2 , TYPE_3 result ) { TYPE_1 VAR_5 = new TYPE_1 ( "" , "" , "" ) ; try { TYPE_3 VAR_4 = ( TYPE_3 ) result . VAR_3 ( STRING_1 ) . get ( 0 ) ; METHOD_2 ( VAR_5 , VAR_4 . METHOD_3 ( STRING_2 ) ) ; } catch ( TYPE_4 e ) { Log . VAR_6 ( TAG , e ) ; } return VAR_5 ; } |
IMHO : s need send exception I return false previous patch caller aware contract : a _CODE_ returns _CODE_ = = true stop | public boolean METHOD_1 ( ) { <START> return true ; <END> } | public boolean METHOD_1 ( ) { return false ; } |
pass info message param super need a copy subclass | public TYPE_1 ( String VAR_2 , String info ) { <START> super ( info ) ; <END> this . VAR_2 = VAR_2 ; this . info = info ; } | public TYPE_1 ( String VAR_2 , String info ) { super ( ) ; this . VAR_2 = VAR_2 ; this . info = info ; } |
minor : introducing a method exit point extra line I recommend inverting logic moving VAR_3 invocation | public void METHOD_1 ( TYPE_1 VAR_1 ) { <START> if ( model . VAR_2 ( ) == null ) { <END> return ; } VAR_3 . METHOD_2 ( VAR_1 ) ; } | public void METHOD_1 ( TYPE_1 VAR_1 ) { if ( model . VAR_2 ( ) != null ) { VAR_3 . METHOD_2 ( VAR_1 ) ; } } |
I spotted earlier conditionals collapse : TYPE_2 VAR_3 = TYPE_3 METHOD_3 ( METHOD_4 ( ) VAR_1 ? R VAR_3 VAR_4 : R VAR_3 fade_out_to ) ; VAR_5 METHOD_5 ( VAR_3 ) ; VAR_2 = VAR_1 ; | private void METHOD_1 ( boolean VAR_1 ) { if ( ! TYPE_1 . METHOD_2 ( ) || VAR_1 == VAR_2 ) { return ; } <START> if ( VAR_1 ) { <END> TYPE_2 VAR_3 = TYPE_3 . METHOD_3 ( METHOD_4 ( ) , R . VAR_3 . VAR_4 ) ; VAR_5 . METHOD_5 ( VAR_3 ) ; VAR_2 = true ; } else { TYPE_2 VAR_3 = TYPE_3 . METHOD_3 ( METHOD_4 ( ) , R . VAR_3 . VAR_6 ) ; VAR_5 . METHOD_5 ( VAR_3 ) ; VAR_2 = false ; } } | private void METHOD_1 ( boolean VAR_1 ) { if ( ! TYPE_1 . METHOD_2 ( ) || VAR_1 == VAR_2 ) { return ; } TYPE_2 VAR_3 = TYPE_3 . METHOD_3 ( METHOD_4 ( ) , VAR_1 ? R . VAR_3 . VAR_4 : R . VAR_3 . VAR_6 ) ; VAR_5 . METHOD_5 ( VAR_3 ) ; VAR_2 = VAR_1 ; } |
( ! TYPE_1 METHOD_2 || VAR_1 = = _CODE_ ) | private void METHOD_1 ( boolean VAR_1 ) { <START> if ( ! TYPE_1 . METHOD_2 ( ) ) { <END> return ; } if ( VAR_1 && ! VAR_2 ) { TYPE_2 VAR_3 = TYPE_3 . METHOD_3 ( METHOD_4 ( ) , R . VAR_3 . VAR_4 ) ; VAR_5 . METHOD_5 ( VAR_3 ) ; VAR_2 = true ; } else if ( ! VAR_1 && VAR_2 ) { TYPE_2 VAR_3 = TYPE_3 . METHOD_3 ( METHOD_4 ( ) , R . VAR_3 . VAR_6 ) ; VAR_5 . METHOD_5 ( VAR_3 ) ; VAR_2 = false ; } } | private void METHOD_1 ( boolean VAR_1 ) { if ( ! TYPE_1 . METHOD_2 ( ) || VAR_1 == VAR_2 ) { return ; } if ( VAR_1 ) { TYPE_2 VAR_3 = TYPE_3 . METHOD_3 ( METHOD_4 ( ) , R . VAR_3 . VAR_4 ) ; VAR_5 . METHOD_5 ( VAR_3 ) ; VAR_2 = true ; } else { TYPE_2 VAR_3 = TYPE_3 . METHOD_3 ( METHOD_4 ( ) , R . VAR_3 . VAR_6 ) ; VAR_5 . METHOD_5 ( VAR_3 ) ; VAR_2 = false ; } } |
s advantage adding _CODE_ instance variable | public void METHOD_1 ( TYPE_1 VAR_1 ) { super . METHOD_1 ( VAR_1 ) ; VAR_2 = ( TYPE_2 ) METHOD_2 ( ) . METHOD_3 ( ) ; model = new TYPE_3 ( ) ; if ( TYPE_4 . METHOD_4 ( ) ) { VAR_3 = new TYPE_5 ( ) ; } else { VAR_3 = new TYPE_6 ( ) ; } <START> VAR_4 = new TYPE_7 ( METHOD_2 ( ) ) ; <END> } | public void METHOD_1 ( TYPE_1 VAR_1 ) { super . METHOD_1 ( VAR_1 ) ; VAR_2 = ( TYPE_2 ) METHOD_2 ( ) . METHOD_3 ( ) ; model = new TYPE_3 ( ) ; if ( TYPE_4 . METHOD_4 ( ) ) { VAR_3 = new TYPE_5 ( ) ; } else { VAR_3 = new TYPE_6 ( ) ; } } |
I write - args super constructors implied I figure read obvious php developers else | public TYPE_2 ( boolean VAR_2 , TYPE_1 VAR_3 , int VAR_4 ) { <START> super ( ) ; <END> this . VAR_2 = VAR_2 ; this . VAR_4 = VAR_4 ; this . VAR_3 = VAR_3 ; } | public TYPE_2 ( boolean VAR_2 , TYPE_1 VAR_3 , int VAR_4 ) { this . VAR_2 = VAR_2 ; this . VAR_4 = VAR_4 ; this . VAR_3 = VAR_3 ; } |
I want logical double ampersands ! VAR_1 isEmpty && ! VAR_2 isEmpty && ! VAR_3 isEmpty ( ) instead | public boolean METHOD_1 ( ) { <START> return ! ( VAR_1 . equals ( "" ) && VAR_2 . equals ( "" ) & VAR_3 . equals ( "" ) ) ; <END> } | public boolean METHOD_1 ( ) { return ! VAR_1 . isEmpty ( ) && ! VAR_2 . isEmpty ( ) && ! VAR_3 . isEmpty ( ) ; } |
remove callbacks case prevent accidental double posting | private void METHOD_1 ( boolean VAR_1 ) { if ( VAR_1 ) { VAR_2 . METHOD_2 ( VAR_3 ) ; VAR_2 . METHOD_3 ( ) ; <START> } else { <END> VAR_2 . METHOD_4 ( VAR_3 , VAR_4 ) ; } } | private void METHOD_1 ( boolean VAR_1 ) { VAR_2 . METHOD_2 ( VAR_3 ) ; if ( VAR_1 ) { VAR_2 . METHOD_3 ( ) ; } else { VAR_2 . METHOD_4 ( VAR_3 , VAR_4 ) ; } } |
nice corner case handling block review : VAR_3 add ( Math min ( 0 VAR_3 size ( ) - 1 ) VAR_2 ) instead a conditional | private void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 entry ) { TYPE_3 VAR_2 = new TYPE_3 ( ) ; <START> if ( VAR_3 . size ( ) > 0 ) { <END> VAR_3 . add ( VAR_3 . size ( ) - 1 , VAR_2 ) ; } else { VAR_3 . add ( VAR_2 ) ; } VAR_2 . METHOD_2 ( ) . add ( new TYPE_4 ( VAR_1 , entry ) ) ; VAR_4 . METHOD_3 ( ) ; } | private void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 entry ) { TYPE_3 VAR_2 = new TYPE_3 ( ) ; VAR_3 . add ( Math . max ( 0 , VAR_3 . size ( ) - 1 ) , VAR_2 ) ; VAR_2 . METHOD_2 ( ) . add ( new TYPE_4 ( VAR_1 , entry ) ) ; VAR_4 . METHOD_3 ( ) ; } |
calling _CODE_ ( ) instead ? remove cast VAR_6 division | public int METHOD_1 ( ) { TYPE_1 res = VAR_1 . METHOD_2 ( ) ; <START> return ( int ) ( res . VAR_2 ( R . VAR_3 . VAR_4 ) <END> / res . VAR_5 ( ) . VAR_6 ) ; } | private int METHOD_1 ( ) { TYPE_1 res = VAR_1 . METHOD_2 ( ) ; return ( int ) ( res . VAR_2 ( R . VAR_3 . VAR_4 ) / res . VAR_5 ( ) . VAR_6 ) ; } |
call super | <START> public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { <END> TYPE_1 VAR_2 = super . METHOD_1 ( VAR_1 ) ; VAR_2 . METHOD_2 ( ) . METHOD_3 ( new TYPE_3 ( TYPE_4 . VAR_4 ) ) ; return VAR_2 ; } | public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { super . METHOD_1 ( VAR_1 ) ; TYPE_1 VAR_2 = super . METHOD_1 ( VAR_1 ) ; VAR_2 . METHOD_2 ( ) . METHOD_3 ( new TYPE_3 ( TYPE_4 . VAR_4 ) ) ; return VAR_2 ; } |
want add a null check METHOD_3 ( ) clients _CODE_ idea fragment lifecycles | private void METHOD_1 ( ) { if ( METHOD_2 ( ) != null ) { <START> METHOD_3 ( ) . METHOD_4 ( ) . METHOD_5 ( VAR_1 , null , VAR_2 ) ; <END> } } | private void METHOD_1 ( ) { if ( METHOD_3 ( ) != null && METHOD_2 ( ) != null ) { METHOD_3 ( ) . METHOD_4 ( ) . METHOD_5 ( VAR_1 , null , VAR_2 ) ; } } |
safer pass application context constructor I m guaranteed fragment added callback | public TYPE_1 < TYPE_2 > METHOD_1 ( int i , TYPE_3 VAR_1 ) { TYPE_4 VAR_2 = new TYPE_4 ( VAR_3 . METHOD_2 ( ) , null ) ; String VAR_4 = TYPE_4 . TYPE_8 . METHOD_3 ( VAR_2 , TYPE_4 . TYPE_8 . VAR_5 ) ; String [ ] VAR_6 = TYPE_4 . TYPE_8 . METHOD_4 ( VAR_2 ) ; return new TYPE_6 ( <START> VAR_3 . METHOD_5 ( ) , <END> TYPE_7 . parse ( TYPE_4 . TYPE_8 . METHOD_6 ( ) . toString ( ) ) , null , VAR_4 , VAR_6 , null ) ; } | public TYPE_1 < TYPE_2 > METHOD_1 ( int i , TYPE_3 VAR_1 ) { TYPE_4 VAR_2 = new TYPE_4 ( VAR_3 . METHOD_2 ( ) , null ) ; String VAR_4 = TYPE_4 . TYPE_8 . METHOD_3 ( VAR_2 , TYPE_4 . TYPE_8 . VAR_5 ) ; String [ ] VAR_6 = TYPE_4 . TYPE_8 . METHOD_4 ( VAR_2 ) ; return new TYPE_6 ( context , TYPE_7 . parse ( TYPE_4 . TYPE_8 . METHOD_6 ( ) . toString ( ) ) , null , VAR_4 , VAR_6 , null ) ; } |
isn t content provider s responsibility call methods a reference database ? I m vague area codebase I want avoid unnecessary dependencies TYPE_2 | public void METHOD_1 ( TYPE_1 VAR_1 ) { METHOD_1 ( <START> TYPE_2 . getInstance ( ) . METHOD_2 ( ) . METHOD_3 ( ) , <END> VAR_1 , METHOD_4 ( ) , METHOD_5 ( ) , METHOD_6 ( VAR_1 ) ) ; } | public void METHOD_1 ( TYPE_1 VAR_1 ) { super . METHOD_1 ( TYPE_2 . getInstance ( ) . METHOD_2 ( ) . METHOD_3 ( ) , VAR_1 , METHOD_4 ( ) , METHOD_5 ( ) , METHOD_6 ( VAR_1 ) ) ; } |
call function instead | public static void METHOD_1 ( TYPE_1 VAR_1 , int VAR_2 , int VAR_3 ) { <START> METHOD_1 ( METHOD_2 ( VAR_1 ) , VAR_1 . getString ( VAR_2 ) , VAR_3 ) ; <END> } | public static void METHOD_1 ( TYPE_1 VAR_1 , int VAR_2 , int VAR_3 ) { METHOD_1 ( VAR_1 , VAR_1 . getString ( VAR_2 ) , VAR_3 ) ; } |
feedback function leverage METHOD_1 ( TYPE_1 int int ) instead repeating METHOD_2 ( ) getString ( ) | <START> public static void METHOD_1 ( TYPE_1 VAR_1 , int VAR_2 ) { <END> METHOD_1 ( METHOD_2 ( VAR_1 ) , VAR_1 . getString ( VAR_2 ) , TYPE_2 . VAR_4 ) ; } | public static void METHOD_1 ( TYPE_1 VAR_1 , int VAR_2 ) { METHOD_1 ( VAR_1 , VAR_1 . getString ( VAR_2 ) , TYPE_2 . VAR_4 ) ; } |
more state = > more branches = > more bugs a strong reason default lazy initialization ? a stateless final nonnull initialize declaration want skip member variable altogether [ 0 ] switch joda time [ 1 ] [ 0 ] | <START> public TYPE_1 METHOD_1 ( ) { <END> if ( VAR_1 == null ) { VAR_1 = new TYPE_1 ( STRING_1 , TYPE_3 . VAR_3 ) ; VAR_1 . METHOD_2 ( TYPE_2 . METHOD_3 ( STRING_2 ) ) ; } return VAR_1 ; } | public TYPE_1 METHOD_1 ( ) { TYPE_1 VAR_1 = new TYPE_1 ( STRING_1 , TYPE_3 . VAR_3 ) ; VAR_1 . METHOD_2 ( TYPE_2 . METHOD_3 ( STRING_2 ) ) ; return VAR_1 ; } |
need _CODE_ _CODE_ enough | public void METHOD_1 ( ANNOTATION_1 TYPE_1 VAR_1 ) { super . METHOD_1 ( VAR_1 ) ; <START> TYPE_2 . getInstance ( ) . METHOD_2 ( this ) ; <END> TYPE_3 . METHOD_3 ( this ) ; METHOD_4 ( TYPE_2 . getInstance ( ) . METHOD_5 ( ) . METHOD_6 ( ) ) ; METHOD_7 ( ) ; if ( METHOD_8 ( ) != null ) { METHOD_8 ( ) . METHOD_9 ( true ) ; } METHOD_10 ( this ) ; } | public void METHOD_1 ( ANNOTATION_1 TYPE_1 VAR_1 ) { super . METHOD_1 ( VAR_1 ) ; TYPE_3 . METHOD_3 ( this ) ; METHOD_4 ( TYPE_2 . getInstance ( ) . METHOD_5 ( ) . METHOD_6 ( ) ) ; METHOD_7 ( ) ; if ( METHOD_8 ( ) != null ) { METHOD_8 ( ) . METHOD_9 ( true ) ; } METHOD_10 ( this ) ; } |
remove version variable s equal constant | public TYPE_2 ( TYPE_1 VAR_2 ) { super ( VAR_2 , VAR_3 , VAR_4 , VAR_2 . METHOD_1 ( ) ? TYPE_3 . VAR_6 : TYPE_3 . VAR_7 ) ; <START> version = VAR_8 ; <END> } | public TYPE_2 ( TYPE_1 VAR_2 ) { super ( VAR_2 , VAR_3 , VAR_4 , VAR_2 . METHOD_1 ( ) ? TYPE_3 . VAR_6 : TYPE_3 . VAR_7 ) ; } |
shouldn t return true ? I thought force meant unconditionally _CODE_ | public static boolean METHOD_1 ( ) { if ( TYPE_1 . METHOD_2 ( ) ) { <START> return TYPE_1 . METHOD_3 ( ) ; <END> } boolean VAR_1 = METHOD_4 ( ) ; TYPE_1 . METHOD_5 ( VAR_1 ) ; return VAR_1 ; } | public boolean METHOD_1 ( ) { return TYPE_1 . METHOD_3 ( ) ; } |
move METHOD_5 ( ) check top function ? I recall prevent a crash ( reproduced ) I d err side caution | public void METHOD_1 ( TYPE_1 < TYPE_2 > VAR_1 , TYPE_2 VAR_2 ) { VAR_3 . METHOD_2 ( VAR_2 ) ; boolean VAR_4 = VAR_5 . METHOD_3 ( ) > 0 ; VAR_6 . METHOD_4 ( VAR_4 ? View . VAR_7 : View . VAR_8 ) ; <START> if ( ! METHOD_5 ( ) ) { <END> return ; } METHOD_6 ( ) . METHOD_7 ( ) ; } | public void METHOD_1 ( TYPE_1 < TYPE_2 > VAR_1 , TYPE_2 VAR_2 ) { if ( ! METHOD_5 ( ) ) { return ; } VAR_3 . METHOD_2 ( VAR_2 ) ; boolean VAR_4 = VAR_5 . METHOD_3 ( ) > 0 ; VAR_6 . METHOD_4 ( VAR_4 ? View . VAR_7 : View . VAR_8 ) ; METHOD_6 ( ) . METHOD_7 ( ) ; } |
intentional | public void METHOD_1 ( ) { VAR_1 = false ; METHOD_2 ( ) . METHOD_3 ( ) ; <START> METHOD_2 ( ) . METHOD_3 ( ) ; <END> ( ( TYPE_1 ) METHOD_2 ( ) ) . METHOD_4 ( ) . METHOD_5 ( false ) ; METHOD_6 ( false ) ; ( ( TYPE_1 ) METHOD_2 ( ) ) . METHOD_7 ( ) . METHOD_8 ( true ) ; VAR_2 . METHOD_9 ( View . VAR_3 ) ; METHOD_10 ( METHOD_2 ( ) ) ; METHOD_11 ( VAR_4 ) ; } | public void METHOD_1 ( ) { VAR_1 = false ; METHOD_2 ( ) . METHOD_3 ( ) ; ( ( TYPE_1 ) METHOD_2 ( ) ) . METHOD_4 ( ) . METHOD_5 ( false ) ; METHOD_6 ( false ) ; ( ( TYPE_1 ) METHOD_2 ( ) ) . METHOD_7 ( ) . METHOD_8 ( true ) ; VAR_2 . METHOD_9 ( View . VAR_3 ) ; METHOD_10 ( METHOD_2 ( ) ) ; METHOD_11 ( VAR_4 ) ; } |
! result isEmpty ( ) instead | public void METHOD_1 ( Map < TYPE_1 , TYPE_2 > result ) { if ( ! METHOD_2 ( ) ) { return ; } <START> if ( result . size ( ) > 0 ) { <END> VAR_1 . METHOD_3 ( View . VAR_2 ) ; VAR_3 = ( TYPE_2 ) result . values ( ) . METHOD_4 ( ) [ 0 ] ; METHOD_5 ( ) ; } else { METHOD_6 ( ) ; } } | public void METHOD_1 ( Map < TYPE_1 , TYPE_2 > result ) { if ( ! METHOD_2 ( ) ) { return ; } if ( ! result . isEmpty ( ) ) { VAR_1 . METHOD_3 ( View . VAR_2 ) ; VAR_3 = ( TYPE_2 ) result . values ( ) . METHOD_4 ( ) [ 0 ] ; METHOD_5 ( ) ; } else { METHOD_6 ( ) ; } } |
call super _CODE_ ( ) call ( ) | public void METHOD_1 ( TYPE_1 . view . TYPE_2 VAR_2 ) { METHOD_2 ( ) ; VAR_3 . METHOD_3 ( false ) ; <START> super . METHOD_1 ( VAR_2 ) ; <END> } | public void METHOD_1 ( TYPE_1 . view . TYPE_2 VAR_2 ) { super . METHOD_1 ( VAR_2 ) ; METHOD_2 ( ) ; VAR_3 . METHOD_3 ( false ) ; } |
I don t needed method checks return VAR_1 METHOD_1 ( ) throws failure client doesn t need assert returning method success | <START> public boolean METHOD_1 ( ) throws InterruptedException { <END> if ( ! VAR_1 . METHOD_1 ( TYPE_1 . VAR_3 , TYPE_1 . VAR_4 ) ) { throw new InterruptedException ( STRING_1 ) ; } return VAR_1 . METHOD_1 ( TYPE_1 . VAR_3 , TYPE_1 . VAR_4 ) ; } | public void METHOD_1 ( ) throws InterruptedException { if ( ! VAR_1 . METHOD_1 ( TYPE_1 . VAR_3 , TYPE_1 . VAR_4 ) ) { throw new InterruptedException ( STRING_1 ) ; } } |
need a rebase patch removing a / b test ( vice versa ) | public void METHOD_1 ( TYPE_1 VAR_1 , int VAR_2 , ANNOTATION_1 TYPE_2 location ) { if ( METHOD_2 ( ) . METHOD_3 ( VAR_3 ) == null ) { TYPE_3 VAR_4 = VAR_5 . METHOD_4 ( ) <START> ? TYPE_4 . METHOD_5 ( VAR_1 , VAR_2 ) <END> : TYPE_5 . METHOD_5 ( VAR_1 , VAR_2 , location ) ; VAR_4 . METHOD_6 ( METHOD_2 ( ) , VAR_3 ) ; } } | public void METHOD_1 ( TYPE_1 VAR_1 , int VAR_2 , ANNOTATION_1 TYPE_2 location ) { if ( METHOD_2 ( ) . METHOD_3 ( VAR_3 ) == null ) { TYPE_3 VAR_4 = TYPE_5 . METHOD_5 ( VAR_1 , VAR_2 , location ) ; VAR_4 . METHOD_6 ( METHOD_2 ( ) , VAR_3 ) ; } } |
arguments length checked I need | public Object METHOD_1 ( TYPE_1 [ ] VAR_1 ) throws TYPE_2 { result . clear ( ) ; if ( VAR_1 . length == 1 && VAR_2 != null && VAR_1 [ 0 ] != null ) { <START> String VAR_3 = ( ( TYPE_3 ) VAR_2 ) . METHOD_2 ( VAR_1 [ 0 ] . get ( ) ) ; <END> result . set ( TYPE_4 . METHOD_3 ( VAR_3 ) ) ; } return result ; } | public Object METHOD_1 ( TYPE_1 [ ] VAR_1 ) throws TYPE_2 { result . clear ( ) ; if ( VAR_1 . length == 1 && VAR_1 [ 0 ] != null ) { String VAR_3 = VAR_2 . METHOD_2 ( VAR_1 [ 0 ] . get ( ) ) ; result . set ( TYPE_4 . METHOD_3 ( VAR_3 ) ) ; } return result ; } |
code suspect accessing methods main thread ? tolerable omit synchronization initialize app _CODE_ ( ) | <START> public synchronized TYPE_1 METHOD_1 ( ) { <END> if ( VAR_1 == null ) { VAR_1 = new TYPE_1 ( this ) ; } return VAR_1 ; } | public TYPE_1 METHOD_1 ( ) { return VAR_1 ; } |
line combined previous line | private TYPE_4 . TYPE_5 METHOD_1 ( TYPE_2 VAR_1 ) { TYPE_4 . TYPE_5 VAR_2 ; <START> VAR_2 = TYPE_3 . METHOD_2 ( VAR_1 ) <END> . create ( TYPE_4 . TYPE_5 . class ) ; return VAR_2 ; } | private TYPE_4 . TYPE_5 METHOD_1 ( TYPE_2 VAR_1 ) { TYPE_4 . TYPE_5 VAR_2 = TYPE_3 . METHOD_2 ( VAR_1 ) . create ( TYPE_4 . TYPE_5 . class ) ; return VAR_2 ; } |
line combined previous line | private TYPE_6 . TYPE_7 METHOD_1 ( TYPE_2 VAR_1 ) { TYPE_6 . TYPE_7 VAR_2 ; <START> VAR_2 = TYPE_3 . METHOD_2 ( VAR_1 , <END> String . format ( TYPE_8 . VAR_4 , TYPE_4 . METHOD_3 ( ) , TYPE_5 . getInstance ( ) . METHOD_4 ( ) , VAR_1 . METHOD_5 ( ) ) ) . create ( TYPE_6 . TYPE_7 . class ) ; return VAR_2 ; } | private TYPE_6 . TYPE_7 METHOD_1 ( TYPE_2 VAR_1 ) { TYPE_6 . TYPE_7 VAR_2 = TYPE_3 . METHOD_2 ( VAR_1 , String . format ( TYPE_8 . VAR_4 , TYPE_4 . METHOD_3 ( ) , TYPE_5 . getInstance ( ) . METHOD_4 ( ) , VAR_1 . METHOD_5 ( ) ) ) . create ( TYPE_6 . TYPE_7 . class ) ; return VAR_2 ; } |
s reasoning ? highlight tooltip shown time ( 1 - minute intervals ) | public static boolean METHOD_1 ( ) { <START> return ! METHOD_2 ( R . string . VAR_1 , false ) ; <END> } | public static boolean METHOD_1 ( ) { return METHOD_2 ( R . string . VAR_1 , true ) ; } |
hang patch curiosity lazy init _CODE_ ? operation expected slow | public static float METHOD_1 ( ) { if ( VAR_1 == null ) { <START> VAR_1 = METHOD_2 ( ) . VAR_2 ; <END> } return VAR_1 ; } | public static float METHOD_1 ( ) { return METHOD_2 ( ) . VAR_2 ; } |
consider reverting s longer a WIP patch | public TYPE_1 METHOD_1 ( ) { <START> return METHOD_2 ( new TYPE_2 ( STRING_1 ) ) ; <END> } | public TYPE_1 METHOD_1 ( ) { return new TYPE_1 ( STRING_1 , false ) ; } |
I parameter meant flags passed VAR_1 METHOD_2 calls | <START> public void METHOD_1 ( TYPE_1 VAR_1 , int i ) { <END> VAR_1 . METHOD_2 ( VAR_2 , 0 ) ; VAR_1 . METHOD_2 ( VAR_3 , 0 ) ; } | public void METHOD_1 ( TYPE_1 VAR_1 , int i ) { VAR_1 . METHOD_2 ( VAR_2 , i ) ; VAR_1 . METHOD_2 ( VAR_3 , i ) ; } |
TYPE_2 e ( VAR_1 ) | public void METHOD_1 ( ) { new TYPE_1 ( ) { @Override public void METHOD_2 ( Throwable VAR_1 ) { <START> TYPE_2 . e ( STRING_1 + VAR_1 . getMessage ( ) ) ; <END> } @Override public void METHOD_3 ( TYPE_3 result ) { if ( result . VAR_2 ( ) ) { TYPE_2 . i ( STRING_2 ) ; VAR_3 . METHOD_4 ( new TYPE_4 ( result . VAR_4 ( ) ) , true ) ; } else { TYPE_2 . i ( STRING_3 ) ; METHOD_5 ( ) ; } } } . execute ( ) ; } | public void METHOD_1 ( ) { new TYPE_1 ( ) { @Override public void METHOD_2 ( Throwable VAR_1 ) { TYPE_2 . e ( VAR_1 ) ; } @Override public void METHOD_3 ( TYPE_3 result ) { if ( result . VAR_2 ( ) ) { TYPE_2 . i ( STRING_2 ) ; VAR_3 . METHOD_4 ( new TYPE_4 ( result . VAR_4 ( ) ) , true ) ; } else { TYPE_2 . i ( STRING_3 ) ; METHOD_5 ( ) ; } } } . execute ( ) ; } |
great ! worth a TYPE_1 METHOD_3 ( ) variable arity overload | private void METHOD_1 ( ) { METHOD_2 ( ) ; bind ( ) ; <START> TYPE_1 . METHOD_3 ( VAR_1 ) ; <END> TYPE_1 . METHOD_3 ( VAR_2 ) ; TYPE_1 . METHOD_3 ( VAR_3 ) ; } | private void METHOD_1 ( ) { METHOD_2 ( ) ; bind ( ) ; TYPE_1 . METHOD_3 ( VAR_1 , VAR_2 , VAR_3 ) ; } |
I unconditionally set VAR_1 ( conditionals hazardous ) note : information preserved database lost app restart | public void METHOD_1 ( boolean VAR_1 ) { if ( VAR_2 . isEmpty ( ) ) { <START> VAR_3 = VAR_1 ; <END> return ; } for ( TYPE_1 page : VAR_2 ) { page . VAR_4 ( VAR_1 ) ; TYPE_2 . instance ( ) . METHOD_2 ( page ) ; } } | public void METHOD_1 ( boolean VAR_1 ) { VAR_3 = VAR_1 ; for ( TYPE_1 page : VAR_2 ) { page . VAR_4 ( VAR_1 ) ; } } |
isEmpty ( ) | public boolean METHOD_1 ( ) { <START> if ( VAR_1 . size ( ) == 0 ) { <END> return VAR_2 ; } for ( TYPE_1 page : VAR_1 ) { if ( ! page . VAR_3 ( ) ) { return false ; } } return true ; } | public boolean METHOD_1 ( ) { if ( VAR_1 . isEmpty ( ) ) { return VAR_2 ; } for ( TYPE_1 page : VAR_1 ) { if ( ! page . VAR_3 ( ) ) { return false ; } } return true ; } |
VAR_2 derived page title considered calling new constructor ( row _CODE_ ( row title ) | public TYPE_2 ( ANNOTATION_1 TYPE_1 row ) { super ( row . key ( ) , row ) ; <START> VAR_2 = null ; <END> } | public TYPE_2 ( ANNOTATION_1 TYPE_1 row ) { super ( row . key ( ) , row , null ) ; } |
I wrote wrong earlier I want iterator remove ( ) avoid a _CODE_ | public < T extends TYPE_1 > void METHOD_1 ( Class < T > type , List < TYPE_1 > VAR_1 ) { Iterator < TYPE_1 > iterator = VAR_1 . iterator ( ) ; while ( iterator . hasNext ( ) ) { TYPE_1 VAR_2 = iterator . next ( ) ; if ( type . VAR_3 ( VAR_2 ) ) { <START> VAR_1 . remove ( VAR_2 ) ; <END> } } } | public < T extends TYPE_1 > void METHOD_1 ( Class < T > type , List < TYPE_1 > VAR_1 ) { Iterator < TYPE_1 > iterator = VAR_1 . iterator ( ) ; while ( iterator . hasNext ( ) ) { TYPE_1 VAR_2 = iterator . next ( ) ; if ( type . VAR_3 ( VAR_2 ) ) { iterator . remove ( ) ; } } } |
a nice test ! s safe clients cache return results immediately | public void request ( ANNOTATION_1 Context context , int VAR_1 , final TYPE_3 . TYPE_4 VAR_2 ) { <START> VAR_2 . METHOD_1 ( this , new TYPE_2 ( ) ) ; <END> } | public void request ( ANNOTATION_1 Context context , int VAR_1 , final TYPE_3 . TYPE_4 VAR_2 ) { VAR_2 . METHOD_1 ( new TYPE_2 ( ) ) ; } |
replacements unconditionally ? I m worried pages cached service other enabled | public TYPE_1 METHOD_1 ( String VAR_1 ) { <START> return new TYPE_1 ( TYPE_3 . TYPE_4 . METHOD_2 ( ) <END> ? VAR_1 . METHOD_3 ( STRING_1 , "" ) : VAR_1 . METHOD_3 ( STRING_2 , "" ) , this ) ; } | public TYPE_1 METHOD_1 ( String VAR_1 ) { return new TYPE_1 ( VAR_1 . METHOD_3 ( STRING_1 , "" ) . METHOD_3 ( STRING_2 , "" ) , this ) ; } |
wouldn t calling base method _CODE_ setText ( ) bypassing overridden method _CODE_ ? ( appears testing ) | ANNOTATION_1 public TYPE_1 METHOD_1 ( ANNOTATION_2 TYPE_2 VAR_1 ) { <START> VAR_2 . setText ( VAR_1 ) ; <END> return this ; } | ANNOTATION_1 public TYPE_1 METHOD_1 ( ANNOTATION_2 TYPE_2 VAR_1 ) { VAR_2 . setText ( ( String ) VAR_1 ) ; return this ; } |
good check METHOD_8 ( ) doesn t return null method appears complete asynchronously | public void METHOD_1 ( ) { METHOD_2 ( ) ; VAR_1 . METHOD_3 ( true ) ; VAR_2 . METHOD_4 ( model . VAR_3 ( ) ) ; METHOD_5 ( ) ; METHOD_6 ( ) ; METHOD_7 ( ) ; <START> if ( METHOD_8 ( ) . METHOD_9 ( ) != null ) { <END> METHOD_8 ( ) . METHOD_9 ( ) . METHOD_10 ( ) ; } } | public void METHOD_1 ( ) { METHOD_2 ( ) ; VAR_1 . METHOD_3 ( true ) ; VAR_2 . METHOD_4 ( model . VAR_3 ( ) ) ; METHOD_5 ( ) ; METHOD_6 ( ) ; METHOD_7 ( ) ; if ( METHOD_8 ( ) != null && METHOD_8 ( ) . METHOD_9 ( ) != null ) { METHOD_8 ( ) . METHOD_9 ( ) . METHOD_10 ( ) ; } } |
METHOD_9 ( ) ! = null | public void METHOD_1 ( ) { METHOD_2 ( ) ; VAR_1 . METHOD_3 ( true ) ; VAR_2 . METHOD_4 ( model . VAR_3 ( ) ) ; METHOD_5 ( ) ; METHOD_6 ( ) ; METHOD_7 ( ) ; if <START> ( METHOD_8 ( ) <END> != null && METHOD_9 ( ) != null ) { METHOD_9 ( ) . METHOD_10 ( ) ; } } | public void METHOD_1 ( ) { METHOD_2 ( ) ; VAR_1 . METHOD_3 ( true ) ; VAR_2 . METHOD_4 ( model . VAR_3 ( ) ) ; METHOD_5 ( ) ; METHOD_6 ( ) ; METHOD_7 ( ) ; if ( METHOD_9 ( ) != null ) { METHOD_9 ( ) . METHOD_10 ( ) ; } } |
code method misleading s implies | <START> public static boolean METHOD_1 ( ) { <END> List < TYPE_1 > VAR_1 = METHOD_2 ( ) ; return ! VAR_1 . isEmpty ( ) && ! VAR_1 . get ( 0 ) . METHOD_3 ( ) . isEmpty ( ) ; } | public static boolean METHOD_1 ( ) { List < TYPE_1 > VAR_1 = METHOD_2 ( ) ; return VAR_1 . isEmpty ( ) || ( VAR_1 . size ( ) == 1 && VAR_1 . get ( 0 ) . METHOD_3 ( ) . isEmpty ( ) ) ; } |
missed earlier call super _CODE_ | public void <START> METHOD_1 ( TYPE_1 <END> VAR_1 , TYPE_2 VAR_2 ) { VAR_2 . METHOD_2 ( R . VAR_1 . VAR_3 , VAR_1 ) ; VAR_4 . METHOD_3 ( new TYPE_3 ( ) { @Override public void run ( ) { METHOD_4 ( ) ; } } ) ; } | public void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) { super . METHOD_1 ( VAR_1 , VAR_2 ) ; VAR_2 . METHOD_2 ( R . VAR_1 . VAR_3 , VAR_1 ) ; VAR_4 . METHOD_3 ( new TYPE_3 ( ) { @Override public void run ( ) { METHOD_4 ( ) ; } } ) ; } |
fragment shouldn t force host internals changing dependency a toolbar clear VAR_1 pattern exposing toolbar allows fragment change s defer consider pushing METHOD_1 ( ) host allow hide / show toolbar | public void METHOD_1 ( ) { TYPE_1 VAR_1 = METHOD_2 ( ) ; if ( VAR_1 != null ) { <START> VAR_1 . METHOD_3 ( ) . METHOD_4 ( View . VAR_2 ) ; <END> } } | public void METHOD_1 ( ) { TYPE_1 VAR_1 = METHOD_2 ( ) ; if ( VAR_1 != null ) { VAR_1 . METHOD_1 ( ) ; } } |
clear previously set listeners | public void METHOD_1 ( ANNOTATION_1 TYPE_1 VAR_1 ) { <START> VAR_2 = <END> VAR_1 ; if ( VAR_2 != null ) { VAR_2 . METHOD_2 ( this ) ; VAR_2 . METHOD_3 ( this ) ; VAR_2 . METHOD_4 ( this ) ; VAR_2 . METHOD_5 ( this ) ; } } | public void METHOD_1 ( ANNOTATION_1 TYPE_1 VAR_1 ) { this . VAR_1 = VAR_1 ; if ( VAR_1 != null ) { VAR_1 . METHOD_2 ( this ) ; VAR_1 . METHOD_3 ( this ) ; VAR_1 . METHOD_4 ( this ) ; VAR_1 . METHOD_5 ( this ) ; } } |
throw new IOException ( e ) | private static TYPE_1 METHOD_1 ( String VAR_1 ) throws IOException { try { Class . VAR_2 ( STRING_1 ) . METHOD_2 ( ) ; TYPE_2 VAR_3 = TYPE_3 . METHOD_3 ( STRING_2 + VAR_1 ) ; return new TYPE_1 ( VAR_3 ) ; } catch ( Exception e ) { <START> throw ( IOException ) new IOException ( e . getMessage ( ) ) . METHOD_4 ( e ) ; <END> } } | private static TYPE_1 METHOD_1 ( String VAR_1 ) throws IOException { try { Class . VAR_2 ( STRING_1 ) . METHOD_2 ( ) ; TYPE_2 VAR_3 = TYPE_3 . METHOD_3 ( STRING_2 + VAR_1 ) ; return new TYPE_1 ( VAR_3 ) ; } catch ( Exception e ) { throw new IOException ( e ) ; } } |
throw new IOException ( e ) | private static TYPE_1 METHOD_1 ( String VAR_1 ) throws IOException { try { Class . VAR_2 ( STRING_1 ) . METHOD_2 ( ) ; TYPE_2 VAR_3 = TYPE_3 . METHOD_3 ( STRING_2 + VAR_1 ) ; return new TYPE_1 ( VAR_3 ) ; } catch ( Exception e ) { <START> throw new IOException ( e . toString ( ) ) ; <END> } } | private static TYPE_1 METHOD_1 ( String VAR_1 ) throws IOException { try { Class . VAR_2 ( STRING_1 ) . METHOD_2 ( ) ; TYPE_2 VAR_3 = TYPE_3 . METHOD_3 ( STRING_2 + VAR_1 ) ; return new TYPE_1 ( VAR_3 ) ; } catch ( Exception e ) { throw new IOException ( e ) ; } } |
reason package protected ? protected means subclasses override method doesn t supported class | <START> ANNOTATION_1 ( R . id . VAR_1 ) protected void METHOD_1 ( View v ) { <END> if ( VAR_2 != null ) { VAR_2 . METHOD_1 ( ) ; } } | ANNOTATION_1 ( R . id . VAR_1 ) void METHOD_1 ( View v ) { if ( VAR_2 != null ) { VAR_2 . METHOD_1 ( ) ; } } |
feel free ignore : I handle null case feels special nonempty case generic : ( VAR_4 isEmpty ( ) ) { return null } METHOD_3 ( VAR_4 true ) ; return new TYPE_5 < > ( VAR_1 METHOD_4 ( TYPE_6 class ) VAR_1 METHOD_5 ( VAR_2 ) VAR_4 ) ; | public final < T > TYPE_1 < T > create ( ANNOTATION_1 TYPE_2 VAR_1 , ANNOTATION_1 TYPE_3 < T > VAR_2 ) { Class < ? > VAR_3 = VAR_2 . METHOD_1 ( ) ; Set < TYPE_4 > VAR_4 = METHOD_2 ( VAR_3 ) ; if ( ! VAR_4 . isEmpty ( ) ) { METHOD_3 ( VAR_4 , true ) ; return new TYPE_5 < > ( VAR_1 . METHOD_4 ( TYPE_6 . class ) , VAR_1 . METHOD_5 ( this , VAR_2 ) , VAR_4 ) ; } <START> return null ; <END> } | public final < T > TYPE_1 < T > create ( ANNOTATION_1 TYPE_2 VAR_1 , ANNOTATION_1 TYPE_3 < T > VAR_2 ) { Class < ? > VAR_3 = VAR_2 . METHOD_1 ( ) ; Set < TYPE_4 > VAR_4 = METHOD_2 ( VAR_3 ) ; if ( VAR_4 . isEmpty ( ) ) { return null ; } METHOD_3 ( VAR_4 , true ) ; return new TYPE_5 < > ( VAR_1 . METHOD_5 ( this , VAR_2 ) , VAR_4 ) ; } |
VAR_4 read ( ) ? I m means VAR_2 TYPE_2 class current implementation write need updated VAR_2 write | @Override ANNOTATION_1 public T read ( TYPE_1 in ) throws IOException { <START> TYPE_2 VAR_1 = VAR_2 . read ( in ) ; T VAR_3 = VAR_4 . METHOD_1 ( VAR_1 ) ; <END> return METHOD_2 ( VAR_3 , VAR_5 ) ? VAR_3 : null ; } | @Override ANNOTATION_1 public T read ( TYPE_1 in ) throws IOException { T VAR_3 = VAR_4 . read ( in ) ; return METHOD_2 ( VAR_3 , VAR_5 ) ? VAR_3 : null ; } |
set a reference copy null | public void METHOD_1 ( ANNOTATION_1 TYPE_1 < ? > call ) { if ( call == null ) { return ; } call . VAR_1 ( ) ; <START> call = null ; <END> } | public void METHOD_1 ( ANNOTATION_1 TYPE_1 < ? > call ) { if ( call == null ) { return ; } call . VAR_1 ( ) ; } |
type adapter needs support write | private void METHOD_1 ( TYPE_1 VAR_1 ) { VAR_1 . METHOD_2 ( STRING_1 , VAR_2 ) ; <START> VAR_1 . METHOD_3 ( STRING_2 , TYPE_2 . METHOD_4 ( VAR_3 ) ) ; <END> VAR_1 . METHOD_2 ( STRING_3 , METHOD_5 ( ) ) ; VAR_1 . METHOD_3 ( VAR_4 , VAR_5 . METHOD_6 ( ) ) ; } | private void METHOD_1 ( TYPE_1 VAR_1 ) { VAR_1 . METHOD_2 ( STRING_3 , METHOD_5 ( ) ) ; VAR_1 . METHOD_3 ( VAR_4 , VAR_5 . METHOD_6 ( ) ) ; } |
typing permissive I supposed a location provider GPS network | private TYPE_1 METHOD_1 ( ANNOTATION_1 String VAR_1 , double VAR_2 , double VAR_3 ) { TYPE_2 location = new <START> TYPE_2 ( VAR_1 ) ; <END> location . VAR_4 ( VAR_2 ) ; location . VAR_5 ( VAR_3 ) ; return new TYPE_1 ( location ) ; } | private TYPE_1 METHOD_1 ( ANNOTATION_1 String VAR_1 , double VAR_2 , double VAR_3 ) { TYPE_2 location = new TYPE_2 ( "" ) ; location . VAR_4 ( VAR_2 ) ; location . VAR_5 ( VAR_3 ) ; return new TYPE_1 ( VAR_1 , location ) ; } |
METHOD_7 ( ) METHOD_5 want invoked METHOD_7 argument | private void METHOD_1 ( ANNOTATION_1 TYPE_1 < TYPE_2 > call , ANNOTATION_1 TYPE_3 VAR_1 ) { METHOD_2 ( VAR_1 ) . METHOD_3 ( METHOD_4 ( call ) ) ; METHOD_2 ( VAR_1 , <START> METHOD_5 ( ) ) . METHOD_6 ( METHOD_4 ( call ) , <END> METHOD_7 ( Throwable . VAR_2 ) ) ; } | private void METHOD_1 ( ANNOTATION_1 TYPE_1 < TYPE_2 > call , ANNOTATION_1 TYPE_3 VAR_1 ) { METHOD_2 ( VAR_1 ) . METHOD_3 ( METHOD_4 ( call ) ) ; METHOD_2 ( VAR_1 , METHOD_5 ( ) ) . METHOD_6 ( METHOD_7 ( TYPE_1 . VAR_2 ) , METHOD_7 ( Throwable . VAR_2 ) ) ; } |
I return else case METHOD_3 | public void METHOD_1 ( ANNOTATION_1 TYPE_1 < TYPE_2 > call , ANNOTATION_1 Response < TYPE_2 > response ) { if ( response . VAR_1 ( ) ) { if ( response . VAR_2 ( ) == null ) { <START> VAR_3 . METHOD_2 ( call , new TYPE_3 ( STRING_1 ) ) ; <END> } VAR_3 . METHOD_3 ( call , response . VAR_2 ( ) ) ; } else { VAR_3 . METHOD_2 ( call , TYPE_4 . METHOD_4 ( response , VAR_4 . METHOD_5 ( ) ) ) ; } } | public void METHOD_1 ( ANNOTATION_1 TYPE_1 < TYPE_2 > call , ANNOTATION_1 Response < TYPE_2 > response ) { if ( response . VAR_1 ( ) ) { if ( response . VAR_2 ( ) == null ) { VAR_3 . METHOD_2 ( call , new TYPE_3 ( STRING_1 ) ) ; return ; } VAR_3 . METHOD_3 ( call , response . VAR_2 ( ) ) ; } else { VAR_3 . METHOD_2 ( call , TYPE_4 . METHOD_4 ( response , VAR_4 . METHOD_5 ( ) ) ) ; } } |
s a billion TYPE_3 methods I TYPE_3 ( context ) circumstance | public View METHOD_1 ( Context context , TYPE_1 VAR_1 , TYPE_2 parent ) { <START> return ( ( TYPE_3 ) context . VAR_2 ( Context . VAR_3 ) ) <END> . METHOD_2 ( VAR_4 . R . VAR_5 . VAR_6 , parent , false ) ; } | public View METHOD_1 ( Context context , TYPE_1 VAR_1 , TYPE_2 parent ) { return TYPE_3 . from ( context ) . METHOD_2 ( VAR_4 . R . VAR_5 . VAR_6 , parent , false ) ; } |
fragment obtain host calling _CODE_ _CODE_ ( ) I activity ratained a fragment instance ll a memory leak | @Override protected TYPE_1 METHOD_1 ( ) { TYPE_1 VAR_1 = TYPE_1 . METHOD_2 ( ) ; <START> VAR_1 . METHOD_3 ( this ) ; <END> return VAR_1 ; } | @Override protected TYPE_1 METHOD_1 ( ) { return TYPE_1 . METHOD_2 ( ) ; } |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.