ReviewComments
stringlengths
1
2.35k
OriginalCode
stringlengths
28
487
ReviewedCode
stringlengths
14
463
calling METHOD_3 I forgot add screenshots patch
ANNOTATION_1 public void METHOD_1 ( ANNOTATION_2 ( VAR_1 = { VAR_2 , VAR_3 } ) int VAR_4 , ANNOTATION_3 TYPE_1 VAR_5 ) { METHOD_2 ( VAR_4 , TYPE_3 . VAR_7 , VAR_5 , TYPE_4 . VAR_9 ) ; VAR_10 = new TYPE_2 ( ctx ( ) ) ; <START> METHOD_3 ( VAR_10 ) ; <END> }
ANNOTATION_1 public void METHOD_1 ( ANNOTATION_2 ( VAR_1 = { VAR_2 , VAR_3 } ) int VAR_4 , ANNOTATION_3 TYPE_1 VAR_5 ) { METHOD_2 ( VAR_4 , TYPE_3 . VAR_7 , VAR_5 , TYPE_4 . VAR_9 ) ; METHOD_3 ( VAR_10 ) ; }
I guess consistent codebase method annotations line method signature line ( s ) s pick other stick a - class basis
ANNOTATION_1 <START> @Override public <END> TYPE_1 type ( ) { return TYPE_1 . VAR_1 ; }
public TYPE_1 type ( ) { return TYPE_1 . VAR_1 ; }
context
public TYPE_2 ( Context context ) { super ( context ) ; <START> METHOD_1 ( METHOD_2 ( ) , R . VAR_2 . VAR_3 , <END> this ) ; TYPE_1 . bind ( this ) ; }
public TYPE_2 ( Context context ) { super ( context ) ; METHOD_1 ( context , R . VAR_2 . VAR_3 , this ) ; TYPE_1 . bind ( this ) ; }
unnecessary else : ]
private String METHOD_1 ( ) { if ( METHOD_2 ( ) . METHOD_3 ( VAR_1 ) ) { return TYPE_1 . METHOD_4 ( METHOD_5 ( ) , new TYPE_2 ( VAR_2 ) . METHOD_6 ( ) ) ; } <START> else <END> if ( VAR_3 != null ) { return VAR_3 . METHOD_7 ( ) ; } return null ; }
private String METHOD_1 ( ) { return METHOD_2 ( ) . METHOD_3 ( VAR_1 ) ? TYPE_1 . METHOD_4 ( METHOD_5 ( ) , VAR_2 ) : null ; }
i ? 0 previously s existing bug set purpose
protected void METHOD_1 ( TYPE_1 [ ] VAR_1 , int i , TYPE_2 type ) throws TYPE_3 { TYPE_2 VAR_2 = ( ( TYPE_4 ) VAR_1 [ i ] ) . METHOD_2 ( ) ; if ( VAR_2 != type ) { throw new <START> TYPE_3 ( 0 , <END> STRING_1 + type . getClass ( ) . METHOD_3 ( ) + STRING_2 + METHOD_4 ( ) + STRING_3 + VAR_1 [ i ] . METHOD_5 ( ) + STRING_4 ) ; } }
protected void METHOD_1 ( TYPE_1 [ ] VAR_1 , int i , TYPE_2 type ) throws TYPE_3 { METHOD_1 ( VAR_1 [ i ] , i , type ) ; }
doesn t ANNOTATION_1 _CODE_ requires method public _CODE_ requires package privacy
<START> ANNOTATION_1 <END> public void METHOD_1 ( ANNOTATION_2 String VAR_1 , int id ) { VAR_2 . put ( VAR_1 , id ) ; }
public void METHOD_1 ( ANNOTATION_2 String VAR_1 , int id ) { VAR_2 . put ( VAR_1 , id ) ; }
flip conditional = = instead negated logic
public int METHOD_1 ( ANNOTATION_1 String VAR_1 ) { Integer id = VAR_2 . get ( VAR_1 ) ; return <START> id != null ? id : 0 ; <END> }
public int METHOD_1 ( ANNOTATION_1 String VAR_1 ) { Integer id = VAR_2 . get ( VAR_1 ) ; return id == null ? 0 : id ; }
return a Map instead a HashMap implementation
public static <START> HashMap < String , <END> Integer > METHOD_1 ( ) { TYPE_1 < HashMap < String , Integer > > type = new TYPE_1 < HashMap < String , Integer > > ( ) { } ; return TYPE_2 . METHOD_2 ( type , getString ( R . string . VAR_1 , STRING_1 ) ) ; }
public static Map < String , Integer > METHOD_1 ( ) { TYPE_1 < HashMap < String , Integer > > type = new TYPE_1 < HashMap < String , Integer > > ( ) { } ; return TYPE_2 . METHOD_2 ( type , getString ( R . string . VAR_1 , STRING_1 ) ) ; }
I m I missed earlier null check VAR_2 int overload method suggests a similar null check necessary consider checking return METHOD_2 ( ) case s present adapter
public void METHOD_1 ( ANNOTATION_1 TYPE_1 VAR_1 ) { <START> METHOD_1 ( VAR_2 . METHOD_2 ( VAR_1 ) ) ; <END> }
public void METHOD_1 ( ANNOTATION_1 TYPE_1 VAR_1 ) { if ( VAR_2 != null && VAR_2 . METHOD_2 ( VAR_1 ) > - 1 ) { METHOD_1 ( VAR_2 . METHOD_2 ( VAR_1 ) ) ; } }
I flagged a potential NPE android studio sense happen I recommend adding a VAR_3 ! = null conditional suppressing warning throwing IllegalStateException null show author considering case true warnings flagged android studio
public void METHOD_1 ( TYPE_3 . TYPE_4 VAR_1 , int VAR_2 ) { if ( VAR_1 instanceof TYPE_2 ) { ( ( TYPE_2 ) <START> VAR_1 ) . METHOD_2 ( VAR_3 . METHOD_3 ( ) . get ( VAR_2 ) ) ; <END> } }
public void METHOD_1 ( TYPE_3 . TYPE_4 VAR_1 , int VAR_2 ) { if ( VAR_3 != null && VAR_1 instanceof TYPE_2 ) { ( ( TYPE_2 ) VAR_1 ) . METHOD_2 ( VAR_3 . METHOD_3 ( ) . get ( VAR_2 ) ) ; } }
needless else : ]
private TYPE_1 METHOD_1 ( ANNOTATION_1 Context context , ANNOTATION_2 Throwable VAR_1 ) { if ( VAR_1 != null && ! METHOD_2 ( context , VAR_1 ) ) { if ( context instanceof TYPE_2 ) { return TYPE_1 . VAR_2 ; } <START> else { <END> return TYPE_1 . VAR_3 ; } } return TYPE_1 . VAR_4 ; }
private TYPE_1 METHOD_1 ( ANNOTATION_1 Context context , ANNOTATION_2 Throwable VAR_1 ) { if ( VAR_1 != null && ! METHOD_2 ( context , VAR_1 ) ) { if ( context instanceof TYPE_2 ) { return TYPE_1 . VAR_2 ; } return TYPE_1 . VAR_3 ; } return TYPE_1 . VAR_4 ; }
dates - move immutable
public TYPE_2 ( TYPE_1 VAR_2 , Date VAR_3 , int VAR_4 , Map < Long , Boolean > VAR_5 , int VAR_6 ) { this . VAR_2 = VAR_2 ; <START> this . VAR_3 = VAR_3 != null ? new Date ( VAR_3 . METHOD_1 ( ) ) : null ; <END> this . VAR_4 = VAR_4 ; this . VAR_5 = VAR_5 ; this . VAR_6 = VAR_6 ; }
public TYPE_2 ( TYPE_1 VAR_2 , Date VAR_3 , int VAR_4 , Map < Long , Boolean > VAR_5 , int VAR_6 ) { this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; this . VAR_4 = VAR_4 ; this . VAR_5 = VAR_5 ; this . VAR_6 = VAR_6 ; }
FWIW I observe ( notified respond ) changes airplane mode connectivity state ( basically system status bar connectivity icon ) track network successes failures existing interceptor _CODE_ switching rebroadcast OFFLINE / ONLINE events event bus global network health want avoid mingling responsibilities intercepting requests
@Override protected void METHOD_1 ( int VAR_1 ) { if ( VAR_1 == 0 ) { METHOD_2 ( new TYPE_1 ( ) ) ; METHOD_2 ( new TYPE_2 ( ) ) ; } METHOD_2 ( new TYPE_3 ( ) ) ; METHOD_2 ( new TYPE_4 ( ) ) ; if ( VAR_1 == 0 ) { METHOD_2 ( new TYPE_5 ( ) ) ; } METHOD_2 ( new TYPE_6 ( ) ) ; if ( VAR_1 == 0 ) { METHOD_2 ( new TYPE_7 ( ) ) ; } <START> METHOD_2 ( new TYPE_8 ( ) ) ; <END> }
protected void METHOD_1 ( int VAR_1 ) { if ( VAR_1 == 0 ) { METHOD_2 ( new TYPE_1 ( ) ) ; METHOD_2 ( new TYPE_2 ( ) ) ; } METHOD_2 ( new TYPE_3 ( ) ) ; METHOD_2 ( new TYPE_4 ( ) ) ; if ( VAR_1 == 0 ) { METHOD_2 ( new TYPE_5 ( ) ) ; } METHOD_2 ( new TYPE_6 ( ) ) ; if ( VAR_1 == 0 ) { METHOD_2 ( new TYPE_7 ( ) ) ; } }
good cover usage feed
@Override public void error ( ANNOTATION_1 Throwable VAR_1 ) { <START> if ( VAR_1 instanceof TYPE_3 . TYPE_4 ) { METHOD_1 ( new TYPE_2 ( ) ) ; } <END> METHOD_2 ( VAR_2 ) ; }
@Override public void error ( ANNOTATION_1 Throwable VAR_1 ) { METHOD_2 ( VAR_2 ) ; }
client a single VAR_2 shared image s skip converting a List pass TYPE_5 straight call METHOD_1 request ( VAR_2 toString ( ) ) _CODE_ join ( TYPE_5 class overrides toString ( ) return namespace - prefixed VAR_2 string )
public TYPE_1 < TYPE_2 < TYPE_3 > > request ( ANNOTATION_1 TYPE_4 VAR_1 , ANNOTATION_1 TYPE_5 VAR_2 , ANNOTATION_1 TYPE_6 VAR_3 ) { <START> List < TYPE_5 > VAR_4 = new ArrayList < > ( ) ; VAR_4 . add ( VAR_2 ) ; <END> return request ( VAR_1 , VAR_5 . METHOD_1 ( VAR_1 ) , VAR_4 , VAR_3 ) ; }
public TYPE_1 < TYPE_2 < TYPE_3 > > request ( ANNOTATION_1 TYPE_4 VAR_1 , ANNOTATION_1 TYPE_5 VAR_2 , ANNOTATION_1 TYPE_6 VAR_3 ) { return request ( VAR_1 , VAR_5 . METHOD_1 ( VAR_1 ) , VAR_2 , VAR_3 ) ; }
return null VAR_5 : )
public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 , String VAR_2 , TYPE_3 format ) { TYPE_1 VAR_3 = null ; try { VAR_3 = TYPE_4 . parse ( VAR_1 , VAR_2 , format ) ; } catch ( IOException VAR_4 ) { log . error ( STRING_1 , VAR_4 . getMessage ( ) ) ; System . VAR_5 ( 1 ) ; } catch ( TYPE_5 VAR_6 ) { log . error ( STRING_2 , VAR_6 . getMessage ( ) ) ; System . VAR_5 ( 1 ) ; <START> return null ; <END> } return VAR_3 ; }
public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 , String VAR_2 , TYPE_3 format ) throws IOException , TYPE_5 { return TYPE_4 . parse ( VAR_1 , VAR_2 , format ) ; }
I a bit cleaner calling super METHOD_1 ( ) exposing METHOD_3 ( ) proceed METHOD_5 VAR_2 ( remove default inflating VAR_2 super ( ) ) create abstract method asks resource - id VAR_2 METHOD_5
@Override public boolean METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) { VAR_3 = VAR_1 ; <START> VAR_1 . METHOD_2 ( METHOD_3 ( ) ) ; <END> VAR_1 . METHOD_4 ( ) . METHOD_5 ( R . VAR_2 . VAR_4 , VAR_2 ) ; return true ; }
@Override public boolean METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) { super . METHOD_1 ( VAR_1 , VAR_2 ) ; VAR_1 . METHOD_4 ( ) . METHOD_5 ( R . VAR_2 . VAR_4 , VAR_2 ) ; VAR_3 = VAR_1 ; return true ; }
close ( ) a finally block - - resource
public void METHOD_1 ( ) throws Exception { TYPE_1 VAR_1 = METHOD_2 ( VAR_2 ) ; VAR_3 . METHOD_3 ( VAR_1 , VAR_4 , VAR_5 ) ; <START> VAR_1 . close ( ) ; <END> }
public void METHOD_1 ( ) throws Exception { try ( TYPE_1 VAR_1 = METHOD_2 ( VAR_2 ) ) { VAR_3 . METHOD_3 ( VAR_1 , VAR_4 , VAR_5 ) ; } }
needs a line break consistency
<START> @Override public <END> void METHOD_1 ( ) { VAR_1 . METHOD_2 ( null ) ; VAR_2 . METHOD_3 ( ) ; VAR_2 = null ; super . METHOD_1 ( ) ; }
public void METHOD_1 ( ) { VAR_1 . METHOD_2 ( null ) ; VAR_2 . METHOD_3 ( ) ; VAR_2 = null ; super . METHOD_1 ( ) ; }
call super ( ) implicit required
public TYPE_2 ( TYPE_1 VAR_2 ) { <START> super ( ) ; <END> this . VAR_2 = VAR_2 ; }
public TYPE_2 ( TYPE_1 VAR_2 ) { this . VAR_2 = VAR_2 ; }
nitpick : I d throw IllegalArgumentException note _CODE_ catched toplevel parse function ( _CODE_ ) token location added
static < TYPE_1 extends TYPE_2 , TYPE_3 extends TYPE_4 < TYPE_1 > > TYPE_1 METHOD_1 ( TYPE_5 < TYPE_3 , TYPE_6 > VAR_1 , TYPE_7 parser , TYPE_6 VAR_2 ) throws IOException { TYPE_3 state = VAR_1 . parse ( parser , VAR_2 ) ; String error = <START> state . VAR_3 ( ) ; <END> if ( error != null ) { throw new TYPE_8 ( parser . VAR_4 ( ) , error ) ; } return state . VAR_5 ( ) ; }
static < TYPE_1 extends TYPE_2 , TYPE_3 extends TYPE_4 < TYPE_1 > > TYPE_1 METHOD_1 ( TYPE_5 < TYPE_3 , TYPE_6 > VAR_1 , TYPE_7 parser , TYPE_6 VAR_2 ) throws IOException { TYPE_3 state = VAR_1 . parse ( parser , VAR_2 ) ; state . VAR_3 ( ) ; return state . VAR_5 ( ) ; }
VAR_2 histogram isn t threadsafe synchronization needed
double <START> METHOD_1 ( double <END> VAR_1 ) { return VAR_2 . METHOD_2 ( VAR_1 ) / TYPE_1 . VAR_4 ; }
synchronized double METHOD_1 ( double VAR_1 ) { return VAR_2 . METHOD_2 ( VAR_1 ) / TYPE_1 . VAR_4 ; }
assert size > 0 rotate fail size 0
TYPE_5 ( int size ) { VAR_2 = new TYPE_1 ( TYPE_2 . METHOD_1 ( ) , TYPE_3 . METHOD_1 ( ) , VAR_3 ) ; list = new ArrayList < > ( ) ; VAR_4 = new TYPE_4 ( TYPE_2 . METHOD_1 ( ) , TYPE_3 . METHOD_1 ( ) , VAR_3 ) ; <START> this . size = size ; <END> }
TYPE_5 ( int size ) { VAR_2 = new TYPE_1 ( TYPE_2 . METHOD_1 ( ) , TYPE_3 . METHOD_1 ( ) , VAR_3 ) ; list = new ArrayList < > ( ) ; VAR_4 = new TYPE_4 ( TYPE_2 . METHOD_1 ( ) , TYPE_3 . METHOD_1 ( ) , VAR_3 ) ; assert size > 0 ; this . size = size ; }
a big fan VAR_2 property VAR_3 similar weird technical differs
public TYPE_1 ( String host ) { VAR_2 = STRING_1 + host ; <START> String VAR_3 = STRING_2 + host ; <END> VAR_4 = VAR_2 + STRING_3 ; VAR_5 = VAR_3 + STRING_3 ; entity = VAR_2 + STRING_4 ; VAR_6 = entity + STRING_5 ; value = VAR_2 + STRING_6 ; VAR_7 = VAR_2 + STRING_7 ; VAR_8 = VAR_2 + STRING_8 ; }
public TYPE_1 ( String host ) { VAR_2 = STRING_1 + host ; VAR_3 = STRING_2 + host ; VAR_4 = VAR_2 + STRING_3 ; VAR_5 = VAR_3 + STRING_3 ; entity = VAR_2 + STRING_4 ; VAR_6 = entity + STRING_5 ; value = VAR_2 + STRING_6 ; VAR_7 = VAR_2 + STRING_7 ; VAR_8 = VAR_2 + STRING_8 ; }
static import
public TYPE_4 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 ) { this . VAR_2 = <START> TYPE_3 . METHOD_1 ( VAR_2 ) ; <END> this . VAR_3 = TYPE_3 . METHOD_1 ( VAR_3 ) ; }
public TYPE_4 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 ) { this . VAR_2 = METHOD_1 ( VAR_2 ) ; this . VAR_3 = METHOD_1 ( VAR_3 ) ; }
A couple notes : - METHOD_3 ( ) returns actual getInstance ( ) call - METHOD_1 ( ) counter - intuitive s realm possibility a user press button leave app ( e g pressing home button ) _CODE_ ( )
public void METHOD_1 ( ) { if ( METHOD_2 ( ) . METHOD_1 ( ) ) { return ; } <START> TYPE_1 . getInstance ( ) . METHOD_3 ( ) . METHOD_4 ( TYPE_2 . METHOD_5 ( TYPE_3 . VAR_2 ) ) ; <END> METHOD_6 ( ) ; }
public void METHOD_1 ( ) { if ( METHOD_2 ( ) . METHOD_1 ( ) ) { return ; } METHOD_6 ( ) ; }
bus events need anymore ? ( idea send events individual cards avoid rebuild view hierarchy _CODE_ )
public void METHOD_1 ( boolean VAR_1 ) { super . METHOD_1 ( VAR_1 ) ; if ( ! METHOD_2 ( ) ) { return ; } if ( VAR_1 ) { VAR_2 . METHOD_3 ( ) ; <START> VAR_3 . METHOD_4 ( ) ; <END> } else { VAR_2 . METHOD_5 ( ) ; } }
public void METHOD_1 ( boolean VAR_1 ) { super . METHOD_1 ( VAR_1 ) ; if ( ! METHOD_2 ( ) ) { return ; } if ( VAR_1 ) { VAR_2 . METHOD_3 ( ) ; } else { VAR_2 . METHOD_5 ( ) ; } }
METHOD_1 ( ) return type TYPE_6 TYPE_7 TYPE_9 < ? extends TYPE_7 TYPE_8 > ( minor simplification )
public static <START> TYPE_7 . TYPE_9 < ? extends TYPE_7 . TYPE_8 > METHOD_1 ( <END> String VAR_1 , Collection < String > VAR_2 , TYPE_3 VAR_3 , int VAR_4 , Date VAR_5 ) { Map < String , Class < ? extends TYPE_4 > > VAR_6 = METHOD_2 ( VAR_2 ) ; TYPE_5 < String > VAR_7 = TYPE_5 . METHOD_3 ( VAR_6 . keySet ( ) ) ; return new TYPE_6 ( METHOD_4 ( VAR_1 , VAR_6 , VAR_4 ) , VAR_3 , VAR_5 , VAR_4 , VAR_7 ) ; }
public static TYPE_6 METHOD_1 ( String VAR_1 , Collection < String > VAR_2 , TYPE_3 VAR_3 , int VAR_4 , Date VAR_5 ) { Map < String , Class < ? extends TYPE_4 > > VAR_6 = METHOD_2 ( VAR_2 ) ; TYPE_5 < String > VAR_7 = TYPE_5 . METHOD_3 ( VAR_6 . keySet ( ) ) ; return new TYPE_6 ( METHOD_4 ( VAR_1 , VAR_6 , VAR_4 ) , VAR_3 , VAR_5 , VAR_4 , VAR_7 ) ; }
ideally call super ( ) cases put _CODE_ ( ) call init ( ) method called constructors
public TYPE_2 ( Context ctx , TYPE_1 VAR_2 ) { <START> this ( ctx , <END> VAR_2 , 0 ) ; }
public TYPE_2 ( Context ctx , TYPE_1 VAR_2 ) { super ( ctx , VAR_2 ) ; }
need METHOD_2 TYPE_1 ? a simple DTO
private TYPE_1 METHOD_1 ( String name , int id ) { TYPE_1 VAR_1 = <START> METHOD_2 ( TYPE_1 . class ) ; <END> when ( VAR_1 . METHOD_3 ( ) ) . METHOD_4 ( id ) ; when ( VAR_1 . METHOD_5 ( ) ) . METHOD_4 ( name ) ; return VAR_1 ; }
private TYPE_1 METHOD_1 ( String name , int id ) { return new TYPE_1 ( name , id , null , null , null ) ; }
ImmutableList VAR_6 ( ) a bit redundant static import
public void METHOD_1 ( ) { VAR_1 = VAR_2 . stream ( ) . METHOD_2 ( ( String VAR_3 ) - > VAR_4 . METHOD_3 ( VAR_3 ) . stream ( ) ) . map ( p - > new TYPE_1 ( p . VAR_3 ( ) , p . VAR_5 ( ) ) ) <START> . collect ( ImmutableList . VAR_6 ( ) ) ; <END> }
private ImmutableList < TYPE_1 > METHOD_1 ( ) { return VAR_2 . stream ( ) . METHOD_2 ( ( String VAR_3 ) - > VAR_4 . METHOD_3 ( VAR_3 ) . stream ( ) ) . map ( p - > new TYPE_1 ( p . VAR_3 ( ) , p . VAR_5 ( ) ) ) . collect ( ImmutableList . VAR_6 ( ) ) ; }
want import static static methods
private int METHOD_1 ( char [ ] s , int VAR_1 ) { if ( VAR_1 > 5 && <START> TYPE_1 . startsWith ( s , <END> VAR_1 , STRING_1 ) ) return TYPE_1 . METHOD_2 ( s , 0 , VAR_1 , 3 ) ; return VAR_1 ; }
private int METHOD_1 ( char [ ] s , int VAR_1 ) { if ( VAR_1 > 5 && startsWith ( s , VAR_1 , STRING_1 ) ) { return METHOD_2 ( s , 0 , VAR_1 , 3 ) ; } return VAR_1 ; }
line need additional logic unsupporting languages I ve updated patch fix please rebase patch thanks
public void METHOD_1 ( ANNOTATION_1 TYPE_1 VAR_1 , int position ) { String VAR_2 = TYPE_2 . getInstance ( ) . METHOD_2 ( VAR_3 . get ( position ) ) ; <START> VAR_1 . VAR_2 . setText ( String . format ( METHOD_3 ( ) . getString ( R . string . VAR_4 ) , String . valueOf ( position + 1 ) , VAR_2 == null ? VAR_3 . get ( position ) : VAR_2 ) ) ; <END> }
public void METHOD_1 ( ANNOTATION_1 TYPE_1 VAR_1 , int position ) { String VAR_2 = TYPE_2 . getInstance ( ) . METHOD_2 ( VAR_3 . get ( position ) ) ; VAR_1 . VAR_2 . setText ( String . format ( METHOD_3 ( ) . getString ( R . string . VAR_4 ) , String . valueOf ( position + 1 ) , VAR_2 ) ) ; }
reason local METHOD_5 ( ) function
public void METHOD_1 ( int VAR_1 , int VAR_2 , TYPE_1 data ) { super . METHOD_1 ( VAR_1 , VAR_2 , data ) ; if ( VAR_1 == VAR_3 ) { if ( VAR_2 == TYPE_2 . VAR_5 ) { int position = data . VAR_6 ( VAR_7 , 0 ) ; METHOD_2 ( position ) ; if ( VAR_8 . METHOD_3 ( ) . METHOD_4 ( ) . size ( ) == 1 ) { <START> VAR_9 . METHOD_5 ( query , <END> query != null && query . length ( ) > 1 ) ; } } } }
public void METHOD_1 ( int VAR_1 , int VAR_2 , TYPE_1 data ) { super . METHOD_1 ( VAR_1 , VAR_2 , data ) ; if ( VAR_1 == VAR_3 ) { if ( VAR_2 == TYPE_2 . VAR_5 ) { int position = data . VAR_6 ( VAR_7 , 0 ) ; METHOD_2 ( position ) ; if ( VAR_8 . METHOD_3 ( ) . METHOD_4 ( ) . size ( ) == 1 ) { METHOD_5 ( query , query != null && query . length ( ) > 1 ) ; } } } }
depend TYPE_1 ? moved constructor _CODE_ unmodifiable
public void METHOD_1 ( final TYPE_1 VAR_1 ) { <START> METHOD_2 ( VAR_2 ) ; <END> super . METHOD_1 ( VAR_1 ) ; METHOD_3 ( ) ; }
public void METHOD_1 ( final TYPE_1 VAR_1 ) { super . METHOD_1 ( VAR_1 ) ; METHOD_3 ( ) ; }
tag relate action
public void METHOD_1 ( ANNOTATION_1 TYPE_1 container , int position , ANNOTATION_1 Object object ) { View view = ( ( View ) object ) ; container . VAR_1 ( view ) ; <START> view . VAR_2 ( - 1 ) ; <END> }
public void METHOD_1 ( ANNOTATION_1 TYPE_1 container , int position , ANNOTATION_1 Object object ) { View view = ( ( View ) object ) ; container . VAR_1 ( view ) ; }
I d store TYPE_4 factory instance a signature : VAR_5 = VAR_3 METHOD_1 ( source VAR_5 ) ; reused bitset stored place
public TYPE_1 build ( String source , TYPE_2 VAR_1 , TYPE_2 VAR_2 ) { if ( VAR_3 == null ) { return new TYPE_1 . TYPE_6 ( VAR_4 , source , VAR_1 , VAR_2 ) ; } else { <START> TYPE_4 VAR_5 = <END> VAR_3 . METHOD_1 ( source ) ; return new TYPE_1 . TYPE_7 ( VAR_4 , VAR_5 , source , VAR_1 , VAR_2 ) ; } }
public TYPE_1 build ( String source , TYPE_2 VAR_1 , TYPE_2 VAR_2 ) { if ( VAR_3 == null ) { return new TYPE_1 . TYPE_6 ( VAR_4 , source , VAR_1 , VAR_2 ) ; } else { VAR_5 = VAR_3 . run ( source , VAR_5 ) ; return new TYPE_1 . TYPE_7 ( VAR_4 , VAR_5 , source , VAR_1 , VAR_2 ) ; } }
guarantees VAR_2 empty ? empty skip ( calling ( input VAR_1 ( ) ) instead ( input VAR_1 ( ) )
public final boolean METHOD_1 ( ) throws IOException { if ( input . VAR_1 ( ) ) { String VAR_2 = TYPE_1 . METHOD_2 ( VAR_3 . toString ( ) ) ; if ( VAR_2 != null ) <START> VAR_3 . METHOD_3 ( ) . append ( VAR_2 ) ; <END> return true ; } else { return false ; } }
public final boolean METHOD_1 ( ) throws IOException { if ( input . VAR_1 ( ) ) { String VAR_2 = TYPE_1 . METHOD_2 ( VAR_3 . toString ( ) ) ; if ( VAR_2 != null ) { VAR_3 . METHOD_3 ( ) . append ( VAR_2 ) ; } return true ; } else { return false ; } }
a reason post ( ) ing instead executing
public void METHOD_1 ( int VAR_1 ) { <START> new TYPE_1 ( ) . METHOD_2 ( ( ) - > { <END> VAR_2 . METHOD_3 ( VAR_1 ) ; if ( VAR_1 == VAR_3 ) { new TYPE_1 ( ) . METHOD_2 ( ( ) - > { METHOD_4 ( VAR_4 ) ; VAR_2 . METHOD_3 ( VAR_5 ) ; } , VAR_6 ) ; } } , VAR_7 ) ; }
public void METHOD_1 ( int VAR_1 ) { VAR_2 . METHOD_3 ( VAR_1 ) ; }
I reason METHOD_1 a string making a _CODE_ simpler ? ! : )
public TYPE_1 < String > METHOD_1 ( TYPE_2 message ) { long VAR_1 = 0 ; String VAR_2 ; try { <START> VAR_2 = new String ( message . VAR_3 ( ) , STRING_1 ) ; <END> } catch ( TYPE_3 e ) { log . error ( STRING_2 , e ) ; VAR_2 = new String ( message . VAR_3 ( ) ) ; } return new TYPE_1 < String > ( VAR_2 , System . currentTimeMillis ( ) ) ; }
public TYPE_1 < String > METHOD_1 ( TYPE_2 message ) { String VAR_2 ; try { VAR_2 = new String ( message . VAR_3 ( ) , STRING_1 ) ; } catch ( TYPE_3 e ) { log . error ( STRING_2 , e ) ; VAR_2 = new String ( message . VAR_3 ( ) ) ; } return new TYPE_1 < String > ( VAR_2 , System . currentTimeMillis ( ) ) ; }
I don t warning system - defined prefixes s essentially informing user t change override schema : ( I crazy s leave possibility ) s point warning overwriting ignore setting
public static void METHOD_1 ( Map < String , String > VAR_1 , String VAR_2 , String uri ) { if ( ! VAR_1 . containsKey ( VAR_2 ) ) { VAR_1 . put ( VAR_2 , uri ) ; } else { final String VAR_3 = VAR_1 . get ( VAR_2 ) ; if ( ! VAR_3 . equals ( uri ) ) { <START> log . warn ( STRING_1 , <END> VAR_2 , VAR_3 , uri ) ; } } }
public static void METHOD_1 ( Map < String , String > VAR_1 , String VAR_2 , String uri ) { if ( ! VAR_1 . containsKey ( VAR_2 ) ) { VAR_1 . put ( VAR_2 , uri ) ; } }
specific logic component need depend TYPE_1 METHOD_3 ( )
public void METHOD_1 ( ) { VAR_1 . METHOD_2 ( ( TYPE_1 . METHOD_3 ( ) <START> && TYPE_1 . METHOD_4 ( ) >= VAR_2 ) ? <END> VAR_3 : VAR_4 ) ; }
public void METHOD_1 ( ) { VAR_1 . METHOD_2 ( TYPE_1 . METHOD_3 ( ) ? VAR_3 : VAR_4 ) ; }
_CODE_ _CODE_ map ( empty string ) STRING_5 ( double quote ) original JSON _CODE_ = > quotes mapping _CODE_ = > ( map ) part mapping
TYPE_2 ( ) { TYPE_1 . Builder builder = new TYPE_1 . Builder ( ) ; builder . add ( STRING_1 , STRING_2 ) ; builder . add ( STRING_3 , STRING_2 ) ; <START> builder . add ( STRING_4 , STRING_5 ) ; builder . add ( STRING_6 , STRING_5 ) ; <END> VAR_2 = builder . build ( ) ; }
TYPE_2 ( ) { TYPE_1 . Builder builder = new TYPE_1 . Builder ( ) ; builder . add ( STRING_1 , STRING_2 ) ; builder . add ( STRING_3 , STRING_2 ) ; builder . add ( STRING_4 , "" ) ; builder . add ( STRING_6 , "" ) ; VAR_2 = builder . build ( ) ; }
need size VAR_4 output ? s logging
private void METHOD_1 ( TYPE_1 out ) throws IOException { TYPE_2 VAR_1 = new TYPE_2 ( ) ; try ( TYPE_3 VAR_2 = new TYPE_3 ( VAR_1 ) ) { VAR_3 . METHOD_2 ( VAR_2 ) ; } byte [ ] VAR_4 = VAR_1 . METHOD_3 ( ) ; <START> out . VAR_5 ( VAR_4 . length ) ; <END> out . write ( VAR_4 ) ; }
private void METHOD_1 ( TYPE_1 out ) throws IOException { VAR_3 . METHOD_2 ( new TYPE_3 ( out ) ) ; }
static import
static Iterator < TYPE_1 > METHOD_1 ( Iterator < String > iterator ) throws IOException { TYPE_2 VAR_1 = new TYPE_3 ( TYPE_4 . METHOD_2 ( ) ) ; while ( iterator . hasNext ( ) ) { VAR_1 . add ( new TYPE_5 ( iterator . next ( ) ) ) ; } TYPE_6 < Object > VAR_2 = METHOD_3 ( VAR_1 ) ; return VAR_2 == null ? TYPE_7 . METHOD_4 ( ) : <START> Collections . VAR_3 ( new <END> TYPE_1 ( VAR_2 ) ) . iterator ( ) ; }
public static Iterator < TYPE_1 > METHOD_1 ( Iterator < String > iterator ) throws IOException { TYPE_2 VAR_1 = new TYPE_3 ( TYPE_4 . METHOD_2 ( ) ) ; while ( iterator . hasNext ( ) ) { VAR_1 . add ( new TYPE_5 ( iterator . next ( ) ) ) ; } TYPE_6 < Object > VAR_2 = METHOD_3 ( VAR_1 ) ; return VAR_2 == null ? TYPE_7 . METHOD_4 ( ) : Collections . VAR_3 ( new TYPE_1 ( VAR_2 ) ) . iterator ( ) ; }
done
public <START> static String <END> METHOD_1 ( int count ) { return TYPE_1 . METHOD_2 ( count ) ; }
public String METHOD_1 ( int count ) { return TYPE_1 . METHOD_2 ( count ) ; }
a imbricated s ( minor enough feel free ignore ) : private TYPE_1 METHOD_1 ( TYPE_1 item TYPE_1 VAR_1 String VAR_2 ) { ( VAR_1 ! = null ) return VAR_1 ; ( VAR_2 equals ( item VAR_3 ( ) ) ) { return item ; } return null ; }
private TYPE_1 <START> METHOD_1 ( TYPE_1 <END> item , TYPE_1 VAR_1 , String VAR_2 ) { if ( VAR_1 == null ) { if ( VAR_2 . equals ( item . VAR_3 ( ) ) ) { return item ; } return null ; } else { return VAR_1 ; } }
private TYPE_1 METHOD_1 ( TYPE_1 item , TYPE_1 VAR_1 , String VAR_2 ) { if ( VAR_1 != null ) { return VAR_1 ; } if ( VAR_2 . equals ( item . VAR_3 ( ) ) ) { return item ; } return null ; }
adding classes semantics s inspecting event some trim ( ) startsWith ( { )
public TYPE_1 METHOD_1 ( String VAR_1 ) { <START> TYPE_1 event = this . VAR_2 . parse ( VAR_1 , false ) ; <END> return this . METHOD_1 ( event ) ; }
public TYPE_1 METHOD_1 ( String VAR_1 ) { TYPE_1 event = this . VAR_2 . parse ( VAR_1 ) ; return this . METHOD_1 ( event ) ; }
wouldn t TYPE_4 file exists
public static TYPE_1 METHOD_1 ( final String VAR_1 ) throws IOException { final File VAR_2 = new File ( VAR_1 ) ; <START> if ( ! VAR_2 . exists ( ) ) { <END> throw new TYPE_2 ( VAR_2 . toString ( ) ) ; } final TYPE_1 properties = new TYPE_1 ( ) ; final TYPE_3 is = new TYPE_4 ( VAR_2 ) ; try { properties . VAR_3 ( is ) ; } finally { if ( is != null ) { is . close ( ) ; } } return properties ; }
private static TYPE_1 METHOD_1 ( final String VAR_1 ) throws IOException { final File VAR_2 = new File ( VAR_1 ) ; if ( ! VAR_2 . exists ( ) ) { throw new TYPE_2 ( VAR_2 . toString ( ) ) ; } final TYPE_1 properties = new TYPE_1 ( ) ; try ( TYPE_3 is = new TYPE_4 ( VAR_2 ) ) { properties . VAR_3 ( is ) ; } return properties ; }
need VAR_3 fair ? understanding a kafka VAR_3 transport VAR_3 isn t maintaining full order ( multiple partitions )
public TYPE_2 ( int VAR_2 ) { this . VAR_3 = new TYPE_1 < > ( VAR_2 , <START> true ) ; <END> }
TYPE_2 ( int VAR_2 ) { this . VAR_3 = new TYPE_1 < > ( VAR_2 ) ; }
configuration injected read system properties constructor
TYPE_3 ( TYPE_1 VAR_2 ) { this . VAR_2 = VAR_2 ; String VAR_3 = <START> System . getProperty ( STRING_1 ) ; <END> VAR_4 = Boolean . VAR_5 . toString ( ) . equals ( VAR_3 ) ; id = TYPE_2 . METHOD_1 ( ) . toString ( ) . METHOD_2 ( STRING_2 , "" ) ; }
TYPE_3 ( TYPE_1 VAR_2 ) { this ( VAR_2 , false ) ; }
hide bugs ? sense throw exception simply remove check ? 0x0 a valid code point return a bit ambiguous I d favor accessing array JVM throw error
private int METHOD_1 ( final int VAR_1 ) { <START> if ( VAR_1 < 0 || VAR_1 >= text . length ) { <END> return 0 ; } return text [ VAR_1 ] ; }
private int METHOD_1 ( final int VAR_1 ) { if ( VAR_1 < 0 ) { return - 1 ; } return text [ VAR_1 ] ; }
public
void <START> METHOD_1 ( StringBuilder <END> VAR_1 ) { METHOD_2 ( VAR_1 , VAR_2 ) ; }
public void METHOD_1 ( StringBuilder VAR_1 ) { METHOD_2 ( VAR_1 , VAR_2 ) ; }
s method ? public
<START> public void METHOD_1 ( boolean VAR_1 ) { <END> super . METHOD_2 ( VAR_1 ) ; }
protected void METHOD_1 ( boolean VAR_1 ) { super . METHOD_2 ( VAR_1 ) ; }
validation step api throws exception necessary
<START> public synchronized boolean METHOD_1 ( final long VAR_1 ) { <END> this . VAR_2 . METHOD_2 ( ( int ) ( INT_1 < < INT_2 | VAR_1 ) ) ; TYPE_1 VAR_3 = this . METHOD_3 ( VAR_1 ) ; boolean VAR_4 = VAR_3 . METHOD_4 ( ) ; if ( VAR_4 ) { VAR_3 . METHOD_5 ( ) ; } return VAR_4 ; }
public synchronized void METHOD_1 ( final long VAR_1 ) { this . VAR_2 . METHOD_2 ( ( int ) ( INT_1 < < INT_2 | VAR_1 ) ) ; TYPE_1 VAR_3 = this . METHOD_3 ( VAR_1 ) ; VAR_3 . METHOD_4 ( ) ; VAR_3 . METHOD_5 ( ) ; }
please getters final
<START> public double METHOD_1 ( ) { <END> return VAR_1 ; }
public final double METHOD_1 ( ) { return VAR_1 ; }
throw please
public int METHOD_1 ( String VAR_1 ) { VAR_2 = VAR_3 . METHOD_2 ( STRING_1 + VAR_1 + STRING_2 ) ; if ( VAR_2 == null ) return - 1 ; else { try { while ( VAR_2 . next ( ) ) { return VAR_2 . getInt ( STRING_3 ) ; } } catch ( TYPE_1 e ) { <START> new IllegalStateException ( STRING_4 + e ) ; <END> } } return - 1 ; }
public int METHOD_1 ( String VAR_1 ) { VAR_2 = VAR_3 . METHOD_2 ( STRING_1 + VAR_1 + STRING_2 ) ; if ( VAR_2 == null ) return - 1 ; else { try { while ( VAR_2 . next ( ) ) { return VAR_2 . getInt ( STRING_3 ) ; } } catch ( TYPE_1 e ) { throw new IllegalStateException ( STRING_4 + e ) ; } } return - 1 ; }
thrown others
public List < Thread > METHOD_1 ( ) { try { METHOD_2 ( ) ; } catch ( TYPE_1 e ) { <START> new IllegalStateException ( STRING_1 + e ) ; <END> } return VAR_1 ; }
public List < Thread > METHOD_1 ( ) { try { METHOD_2 ( ) ; } catch ( TYPE_1 e ) { throw new IllegalStateException ( STRING_1 + e ) ; } return VAR_1 ; }
avoid
public void METHOD_1 ( double VAR_1 ) { <START> this . VAR_2 = <END> VAR_1 ; }
public void METHOD_1 ( double VAR_1 ) { VAR_2 = VAR_1 ; }
set xml
public void METHOD_1 ( TYPE_1 VAR_1 ) { super . METHOD_1 ( VAR_1 ) ; VAR_2 = METHOD_2 ( ) . METHOD_3 ( ) ; VAR_3 = new TYPE_2 ( METHOD_2 ( ) ) ; VAR_3 . METHOD_4 ( ) ; VAR_3 . METHOD_5 ( ) ; VAR_4 = new TYPE_3 ( VAR_2 , ( ( TYPE_4 ) METHOD_2 ( ) ) . METHOD_6 ( ) ) ; METHOD_7 ( VAR_4 ) ; METHOD_8 ( ) . METHOD_9 ( 0 , null , this ) ; <START> METHOD_10 ( ) . METHOD_11 ( TYPE_5 . VAR_6 ) ; <END> }
public void METHOD_1 ( TYPE_1 VAR_1 ) { super . METHOD_1 ( VAR_1 ) ; VAR_2 = METHOD_2 ( ) . METHOD_3 ( ) ; VAR_3 = new TYPE_2 ( METHOD_2 ( ) ) ; VAR_3 . METHOD_4 ( ) ; VAR_3 . METHOD_5 ( ) ; VAR_4 = new TYPE_3 ( VAR_2 , ( ( TYPE_4 ) METHOD_2 ( ) ) . METHOD_6 ( ) ) ; METHOD_7 ( VAR_4 ) ; METHOD_8 ( ) . METHOD_9 ( 0 , null , this ) ; }
final
<START> public TYPE_1 METHOD_1 ( String VAR_1 , String [ ] VAR_2 ) { <END> String VAR_3 = STRING_1 ; String [ ] VAR_4 = new String [ ] { VAR_1 } ; return query ( VAR_3 , VAR_4 , VAR_2 ) ; }
public final TYPE_1 METHOD_1 ( String VAR_1 , String [ ] VAR_2 ) { String VAR_3 = STRING_1 ; String [ ] VAR_4 = new String [ ] { VAR_1 } ; return query ( VAR_3 , VAR_4 , VAR_2 ) ; }
final
<START> public TYPE_1 METHOD_1 ( String query , String [ ] VAR_1 ) { <END> String VAR_2 = VAR_3 + STRING_1 ; String [ ] VAR_4 = new String [ ] { STRING_2 + query + STRING_2 } ; return query ( VAR_2 , VAR_4 , VAR_1 ) ; }
public final TYPE_1 METHOD_1 ( String query , String [ ] VAR_1 ) { String VAR_2 = VAR_3 + STRING_1 ; String [ ] VAR_4 = new String [ ] { STRING_2 + query + STRING_2 } ; return query ( VAR_2 , VAR_4 , VAR_1 ) ; }
const LOG
public void METHOD_1 ( TYPE_1 VAR_1 , View view , int position , long id ) { <START> Log . i ( STRING_1 , <END> STRING_2 ) ; super . METHOD_1 ( VAR_1 , view , position , id ) ; TYPE_2 item = ( TYPE_2 ) METHOD_2 ( ) . METHOD_3 ( position ) ; VAR_2 . METHOD_4 ( item ) ; VAR_3 . METHOD_5 ( TYPE_4 . TYPE_3 . VAR_6 ) ; }
public void METHOD_1 ( TYPE_1 VAR_1 , View view , int position , long id ) { super . METHOD_1 ( VAR_1 , view , position , id ) ; TYPE_2 item = ( TYPE_2 ) METHOD_2 ( ) . METHOD_3 ( position ) ; VAR_2 . METHOD_4 ( item ) ; VAR_3 . METHOD_5 ( TYPE_4 . TYPE_3 . VAR_6 ) ; }
isn t needed method returns false default
protected boolean METHOD_1 ( String token , TYPE_1 VAR_1 ) { try { TYPE_2 response = client . VAR_2 ( token , VAR_1 . METHOD_2 ( ) ) ; if ( response . getStatus ( ) == INT_1 ) { return true ; } } catch ( Exception e ) { LOG . warn ( String . format ( STRING_1 , VAR_1 . METHOD_2 ( ) ) ) ; <START> return false ; <END> } return false ; }
protected boolean METHOD_1 ( String token , TYPE_1 VAR_1 ) { try { TYPE_2 response = client . VAR_2 ( token , VAR_1 . METHOD_2 ( ) ) ; if ( response . getStatus ( ) == INT_1 ) { return true ; } } catch ( Exception e ) { LOG . warn ( String . format ( STRING_1 , VAR_1 . METHOD_2 ( ) ) ) ; } return false ; }
TYPE_2 TYPE_1
public boolean METHOD_1 ( ) { <START> VAR_1 = new TYPE_1 ( METHOD_2 ( ) , TYPE_2 . getInstance ( ) ) ; <END> return true ; }
public boolean METHOD_1 ( ) { VAR_1 = new TYPE_1 ( METHOD_2 ( ) ) ; return true ; }
return int
<START> public void METHOD_1 ( ByteBuffer VAR_1 ) { <END> VAR_1 . put ( data , 0 , METHOD_2 ( ) ) ; }
public int METHOD_1 ( ByteBuffer VAR_1 ) { int length = METHOD_2 ( ) ; VAR_1 . put ( data , 0 , length ) ; return length ; }
wrong tabbing function
private void METHOD_1 ( ) { view . VAR_1 ( new TYPE_1 ( ) { @Override public void METHOD_2 ( TYPE_2 e ) { int index = TYPE_3 . getInstance ( ) . METHOD_3 ( view ) ; TYPE_3 . getInstance ( ) . remove ( index ) ; view . VAR_2 ( ) ; view . VAR_3 ( ) ; TYPE_3 . getInstance ( ) . METHOD_4 ( 0 ) ; } <START> } ) ; <END> }
private void METHOD_1 ( ) { view . VAR_1 ( new TYPE_1 ( ) { @Override public void METHOD_2 ( TYPE_2 e ) { final int index = TYPE_3 . getInstance ( ) . METHOD_3 ( view ) ; TYPE_3 . getInstance ( ) . remove ( index ) ; view . VAR_2 ( ) ; view . VAR_3 ( ) ; TYPE_3 . getInstance ( ) . METHOD_4 ( 0 ) ; } } ) ; }
check p null
public void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) throws TYPE_3 , TYPE_4 { TYPE_5 b = METHOD_2 ( VAR_1 ) ; if ( b == null || b . VAR_3 ( ) == null ) { return ; } for ( TYPE_1 VAR_4 : b . VAR_3 ( ) ) { TYPE_6 p = ( TYPE_6 ) METHOD_3 ( VAR_4 ) ; <START> if ( p . VAR_5 ( ) . equals ( VAR_2 ) ) { <END> METHOD_1 ( p ) ; return ; } } }
public void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) throws TYPE_3 , TYPE_4 { TYPE_5 b = METHOD_2 ( VAR_1 ) ; if ( b == null ) { return ; } for ( TYPE_1 VAR_4 : b . VAR_3 ( ) ) { TYPE_6 p = ( TYPE_6 ) METHOD_3 ( VAR_4 ) ; if ( p . VAR_5 ( ) . equals ( VAR_2 ) ) { METHOD_1 ( p ) ; return ; } } }
I guess won t affect compatibility previous deployments ( reading / writing ZK ) nice confirm
public TYPE_4 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 , String VAR_4 ) { super ( VAR_2 , <START> TYPE_3 . VAR_6 ) ; <END> this . VAR_3 = VAR_3 ; this . VAR_4 = VAR_4 ; }
public TYPE_4 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 , String VAR_4 ) { super ( VAR_2 , null ) ; this . VAR_3 = VAR_3 ; this . VAR_4 = VAR_4 ; }
wouldn t override METHOD_1 TYPE_5 class adding initialization code needed
public void METHOD_1 ( TYPE_1 VAR_1 ) { VAR_2 = TYPE_2 . METHOD_2 ( VAR_1 , TYPE_3 . class ) ; TYPE_6 . TYPE_7 VAR_3 = ( TYPE_6 . TYPE_7 ) VAR_1 ; if ( VAR_3 . getType ( ) == TYPE_6 . TYPE_7 . Type . VAR_4 && VAR_3 . METHOD_3 ( ) ) { <START> TYPE_5 VAR_5 = ( TYPE_5 ) this ; VAR_5 . METHOD_4 ( ) ; <END> } METHOD_5 ( VAR_3 ) ; }
public void METHOD_1 ( TYPE_1 VAR_1 ) { VAR_2 = TYPE_2 . METHOD_2 ( VAR_1 , TYPE_3 . class ) ; METHOD_5 ( ( TYPE_6 . TYPE_7 ) VAR_1 ) ; }
needed
public void METHOD_1 ( ) { throw new TYPE_2 . TYPE_3 ( STRING_1 + STRING_2 + <START> this . getClass ( ) <END> + STRING_3 + STRING_4 ) ; }
public void METHOD_1 ( ) { throw new TYPE_2 . TYPE_3 ( STRING_1 + STRING_2 + getClass ( ) + STRING_3 + STRING_4 ) ; }
i e assertEquals
public void METHOD_1 ( ) { TYPE_1 VAR_1 = new TYPE_1 ( ) ; TYPE_2 VAR_2 = VAR_1 . METHOD_2 ( TYPE_2 . class ) ; assertTrue ( VAR_1 . METHOD_3 ( VAR_2 ) ) ; TYPE_1 VAR_3 = TYPE_3 . METHOD_4 ( VAR_2 , TYPE_1 . class ) ; <START> assertTrue ( VAR_1 . equals ( VAR_3 ) ) ; <END> }
public void METHOD_1 ( ) { TYPE_1 VAR_1 = new TYPE_1 ( ) ; TYPE_2 VAR_2 = VAR_1 . METHOD_2 ( TYPE_2 . class ) ; assertTrue ( VAR_1 . METHOD_3 ( VAR_2 ) ) ; TYPE_1 VAR_3 = TYPE_3 . METHOD_4 ( VAR_2 , TYPE_1 . class ) ; assertEquals ( VAR_1 , VAR_3 ) ; }
zamiast tego czysciej bedzie jak zrobiszthis ( STRING_1 ) ;
public TYPE_1 ( ) { <START> url = STRING_1 ; <END> }
public TYPE_1 ( ) { this ( STRING_1 ) ; }
czy tworzenie nowej instancji zoomstyleparser a za kazdym razem ma sens ? moze lepiej przechowywac jako pole
public void METHOD_1 ( int VAR_1 ) { String VAR_2 = TYPE_1 . METHOD_2 ( context , VAR_1 ) ; <START> TYPE_2 VAR_3 = new TYPE_3 ( ) ; <END> VAR_4 = VAR_3 . METHOD_3 ( VAR_2 ) ; }
public void METHOD_1 ( int VAR_1 ) { String VAR_2 = TYPE_1 . METHOD_2 ( context , VAR_1 ) ; VAR_4 = VAR_3 . METHOD_3 ( VAR_2 ) ; }
nie pomyli ? e ? tu przypadkiem kierunków znaków ? ! teraz jest chyba ? e je ? li wykracza poza VAR_1 : D
public void METHOD_1 ( float x , float y ) { <START> if ( VAR_1 . x < x && VAR_1 . y < y ) { <END> offset . x = x ; offset . y = y ; } }
public void METHOD_1 ( float x , float y ) { if ( x < VAR_1 . x && y < VAR_1 . y ) { offset . x = x ; offset . y = y ; } }
I need super ( ) file
public TYPE_2 ( TYPE_1 VAR_2 ) { <START> super ( ) ; <END> this . VAR_2 = VAR_2 ; VAR_3 = new HashMap < String , List < Double > > ( ) ; }
public TYPE_2 ( TYPE_1 VAR_2 ) { this . VAR_2 = VAR_2 ; VAR_3 = new HashMap < String , List < Double > > ( ) ; }
loop position VAR_1 parameters null
public static TYPE_1 METHOD_1 ( ArrayList < TYPE_1 > position , String VAR_1 ) { <START> for ( TYPE_1 VAR_2 : position ) { <END> if ( VAR_2 . METHOD_2 ( ) . equals ( VAR_1 ) ) { position . remove ( VAR_2 ) ; return VAR_2 ; } } return null ; }
public static TYPE_1 METHOD_1 ( ArrayList < TYPE_1 > position , String VAR_1 ) { if ( position != null && VAR_1 != null ) { for ( TYPE_1 VAR_2 : position ) { if ( VAR_2 . METHOD_2 ( ) . equals ( VAR_1 ) ) { position . remove ( VAR_2 ) ; return VAR_2 ; } } } return null ; }
unsafe addition integer overflow long instead integer
public static int METHOD_1 ( ArrayList < TYPE_1 > position , String VAR_1 ) { int VAR_2 = 0 ; for ( TYPE_1 VAR_3 : position ) { if ( VAR_3 . METHOD_2 ( ) . equals ( VAR_1 ) ) { <START> VAR_2 += VAR_3 . METHOD_3 ( ) ; <END> } } return VAR_2 ; }
public static int METHOD_1 ( ArrayList < TYPE_1 > position , String VAR_1 ) { long VAR_2 = 0 ; for ( TYPE_1 VAR_3 : position ) { if ( VAR_3 . METHOD_2 ( ) . equals ( VAR_1 ) ) { VAR_2 += VAR_3 . METHOD_3 ( ) ; } } return VAR_2 ; }
redundant variable -
public TYPE_4 ( String name ) { <START> this . VAR_2 = name ; <END> VAR_3 = new HashMap < String , TYPE_1 > ( ) ; VAR_4 = new TYPE_2 ( this ) ; VAR_5 = new TYPE_3 ( this ) ; }
public TYPE_4 ( String name ) { this . name = name ; VAR_3 = new HashMap < String , TYPE_1 > ( ) ; VAR_4 = new TYPE_2 ( this ) ; VAR_5 = new TYPE_3 ( this ) ; }
don t need super
public TYPE_2 ( String name , double VAR_2 ) { <START> super ( ) ; <END> this . name = name ; this . VAR_2 = VAR_2 ; this . VAR_3 = new ArrayList < TYPE_1 > ( ) ; this . VAR_4 = new ArrayList < TYPE_1 > ( ) ; }
public TYPE_2 ( String name , double VAR_2 ) { this . name = name ; this . VAR_2 = VAR_2 ; this . VAR_3 = new ArrayList < TYPE_1 > ( ) ; this . VAR_4 = new ArrayList < TYPE_1 > ( ) ; }
don t need super
public TYPE_2 ( TYPE_1 m ) { <START> super ( ) ; <END> this . VAR_2 = m ; VAR_3 = new HashMap < String , List < Double > > ( ) ; }
public TYPE_2 ( TYPE_1 m ) { this . VAR_2 = m ; VAR_3 = new HashMap < String , List < Double > > ( ) ; }
unnecessary call super ( )
public TYPE_2 ( String VAR_2 , double VAR_3 ) { <START> super ( ) ; <END> this . name = name ; this . VAR_3 = VAR_3 ; this . position = new ArrayList < TYPE_1 > ( ) ; this . VAR_4 = new ArrayList < TYPE_1 > ( ) ; }
public TYPE_2 ( String VAR_2 , double VAR_3 ) { this . name = name ; this . VAR_3 = VAR_3 ; this . position = new ArrayList < TYPE_1 > ( ) ; this . VAR_4 = new ArrayList < TYPE_1 > ( ) ; }
a lot conditionals readable
public static boolean METHOD_1 ( ArrayList < TYPE_1 > VAR_1 , TYPE_1 VAR_2 ) { for ( TYPE_1 VAR_3 : VAR_1 ) { if <START> ( ( ( VAR_3 instanceof TYPE_2 ) && ( VAR_2 instanceof TYPE_2 ) ) || ( ( VAR_3 instanceof TYPE_3 ) && ( VAR_2 instanceof TYPE_3 ) ) ) { <END> if ( VAR_3 . METHOD_2 ( ) . equals ( VAR_2 . METHOD_2 ( ) ) ) { return true ; } } } return false ; }
public static boolean METHOD_1 ( ArrayList < TYPE_1 > VAR_1 , TYPE_1 VAR_2 ) { for ( TYPE_1 VAR_3 : VAR_1 ) { if ( ( VAR_3 instanceof TYPE_2 ) && ( VAR_2 instanceof TYPE_2 ) ) { if ( ( VAR_3 instanceof TYPE_3 ) && ( VAR_2 instanceof TYPE_3 ) ) { if ( VAR_3 . METHOD_2 ( ) . equals ( VAR_2 . METHOD_2 ( ) ) ) { return true ; } } } } return false ; }
unnecessary call super
public TYPE_3 ( String name , double VAR_2 ) { <START> super ( ) ; <END> this . name = name ; this . VAR_2 = VAR_2 ; this . position = new ArrayList < TYPE_1 > ( ) ; this . VAR_3 = new ArrayList < TYPE_2 > ( ) ; }
public TYPE_3 ( String name , double VAR_2 ) { this . name = name ; this . VAR_2 = VAR_2 ; this . position = new ArrayList < TYPE_1 > ( ) ; this . VAR_3 = new ArrayList < TYPE_2 > ( ) ; }
aren t calling super class add super ( params )
public <START> TYPE_2 ( String <END> VAR_2 , int VAR_3 , double VAR_4 , TYPE_1 VAR_5 ) { VAR_6 = VAR_2 ; size = VAR_3 ; VAR_7 = VAR_4 ; VAR_8 = VAR_5 ; }
public TYPE_2 ( String VAR_2 , int VAR_3 , double VAR_4 , TYPE_1 VAR_5 ) { super ( ) ; VAR_6 = VAR_2 ; size = VAR_3 ; VAR_7 = VAR_4 ; VAR_8 = VAR_5 ; }
method changed private
<START> public void <END> METHOD_1 ( HashMap < String , ArrayList < TYPE_1 > > VAR_1 ) { this . VAR_1 = VAR_1 ; }
private void METHOD_1 ( HashMap < String , ArrayList < TYPE_1 > > VAR_1 ) { this . VAR_1 = VAR_1 ; }
changed : VAR_2 = m ;
public TYPE_2 ( TYPE_1 m ) { super ( ) ; <START> this . m = VAR_2 ; <END> VAR_3 = new HashMap < String , List < Double > > ( ) ; }
public TYPE_2 ( TYPE_1 m ) { super ( ) ; this . VAR_2 = m ; VAR_3 = new HashMap < String , List < Double > > ( ) ; }
NPE risk
public boolean equals ( Object obj ) { if ( null == obj || ! ( obj instanceof TYPE_1 ) ) return false ; TYPE_1 o = ( TYPE_1 ) obj ; return <START> VAR_1 . equals ( o . VAR_1 ) <END> && VAR_2 . equals ( o . VAR_2 ) ; }
public boolean equals ( Object obj ) { if ( null == obj || ! ( obj instanceof TYPE_1 ) ) return false ; TYPE_1 o = ( TYPE_1 ) obj ; return null != VAR_1 && null != VAR_2 && VAR_1 . equals ( o . VAR_1 ) && VAR_2 . equals ( o . VAR_2 ) ; }
zawsze robi ? em / widzia ? em tak zrobione : int id = getId ( ) ; ( id = = R id VAR_1 )
public void METHOD_1 ( View v ) { <START> if ( VAR_1 == v ) { <END> } else if ( VAR_2 == v ) { } else if ( VAR_3 == v ) { } else if ( VAR_4 == v ) { } }
public void METHOD_1 ( View v ) { int id = v . getId ( ) ; if ( id == R . id . VAR_1 ) { } else if ( id == R . id . VAR_2 ) { } else if ( id == R . id . VAR_3 ) { } else if ( id == R . id . VAR_4 ) { } }
optional : add uri a parameter turn intoreturn TYPE_7 METHOD_3 ( VAR_5 METHOD_5 ( ) ) other usages
public TYPE_1 get ( ANNOTATION_1 ( STRING_1 ) TYPE_2 id ) throws TYPE_3 , TYPE_4 { if ( ! VAR_1 . METHOD_1 ( context , TYPE_8 . VAR_3 , id ) ) { throw new TYPE_5 ( STRING_2 ) ; } org . VAR_4 . cluster . data . TYPE_1 VAR_5 = VAR_6 . METHOD_2 ( id ) ; if ( VAR_5 == null ) { throw new TYPE_6 ( STRING_3 ) ; } TYPE_1 VAR_7 = <START> TYPE_7 . METHOD_3 ( VAR_5 ) ; <END> VAR_7 . METHOD_4 ( METHOD_5 ( ) ) ; return VAR_7 ; }
public TYPE_1 get ( ANNOTATION_1 ( STRING_1 ) TYPE_2 id ) throws TYPE_3 , TYPE_4 { if ( ! VAR_1 . METHOD_1 ( context , TYPE_8 . VAR_3 , id ) ) { throw new TYPE_5 ( STRING_2 ) ; } org . VAR_4 . cluster . data . TYPE_1 VAR_5 = VAR_6 . METHOD_2 ( id ) ; if ( VAR_5 == null ) { throw new TYPE_6 ( STRING_3 ) ; } return TYPE_7 . METHOD_3 ( VAR_5 , METHOD_5 ( ) ) ; }
good call whoops want check new VAR_1 object null possibly set true case null : )
public void METHOD_1 ( TYPE_1 VAR_1 ) { this . VAR_1 = VAR_1 ; <START> VAR_2 = false ; <END> }
public void METHOD_1 ( TYPE_1 VAR_1 ) { this . VAR_1 = VAR_1 ; if ( VAR_1 == null ) { VAR_2 = true ; } else { VAR_2 = false ; } }
revert useful tests running v2 gate : D
public static TYPE_1 . Builder METHOD_1 ( ) { if <START> ( ! METHOD_2 ( ) ) <END> { return METHOD_3 ( ) ; } else { return METHOD_4 ( ) ; } }
public static TYPE_1 . Builder METHOD_1 ( ) { if ( METHOD_2 ( ) ) { return METHOD_3 ( ) ; } else { return METHOD_4 ( ) ; } }
scala type java code
public TYPE_3 ( TYPE_1 VAR_2 , TYPE_2 action , boolean VAR_3 ) { super ( VAR_2 , action ) ; this . VAR_3 = VAR_3 ; <START> if ( ! action . equals ( TYPE_2 . VAR_4 ) && <END> ! action . equals ( TYPE_2 . VAR_5 ) && ! action . equals ( TYPE_2 . VAR_6 ) ) { throw new IllegalArgumentException ( STRING_1 + STRING_2 ) ; } }
public TYPE_3 ( TYPE_1 VAR_2 , TYPE_2 action , boolean VAR_3 ) { super ( VAR_2 , action ) ; this . VAR_3 = VAR_3 ; if ( ! action . equals ( TYPE_2 . VAR_4 ) && ! action . equals ( TYPE_2 . VAR_5 ) && ! action . equals ( TYPE_2 . VAR_6 ) ) throw new IllegalArgumentException ( STRING_1 + STRING_2 ) ; }
trailing curly brace missing && action ! = TYPE_2 VAR_6 && action ! = TYPE_2 VAR_7 ) {
public TYPE_4 ( TYPE_1 VAR_2 , TYPE_2 action , TYPE_3 VAR_3 ) { super ( VAR_2 , action , VAR_3 ) ; if ( action != TYPE_2 . VAR_4 && action != TYPE_2 . VAR_5 <START> && action <END> != TYPE_2 . VAR_6 && action != TYPE_2 . VAR_7 ) throw new IllegalArgumentException ( STRING_1 + STRING_2 ) ; }
public TYPE_4 ( TYPE_1 VAR_2 , TYPE_2 action , TYPE_3 VAR_3 ) { super ( VAR_2 , action , VAR_3 ) ; if ( action != TYPE_2 . VAR_4 && action != TYPE_2 . VAR_5 && action != TYPE_2 . VAR_6 && action != TYPE_2 . VAR_7 ) { throw new IllegalArgumentException ( STRING_1 + STRING_2 ) ; } }
return System getProperty ( STRING_1 ) ! = null ;
public static boolean METHOD_1 ( ) { return <START> Boolean . VAR_1 ( System . VAR_2 ( STRING_1 ) ) ; <END> }
public static boolean METHOD_1 ( ) { return System . getProperty ( STRING_1 ) != null ; }
running v1 tests anymore v2 option
public void METHOD_1 ( ) throws Exception { super . METHOD_1 ( ) ; VAR_1 = METHOD_2 ( ) ; <START> TYPE_2 = TYPE_1 . METHOD_3 ( ) ? STRING_1 : STRING_2 ; TYPE_3 = TYPE_1 . METHOD_3 ( ) ? STRING_3 : STRING_4 ; <END> }
public void METHOD_1 ( ) throws Exception { super . METHOD_1 ( ) ; VAR_1 = METHOD_2 ( ) ; }
accept redirect I don t TYPE_5 needed TYPE_2 needed case want pop / push a vlan redirecting
public void METHOD_1 ( TYPE_1 VAR_1 ) { super . METHOD_1 ( VAR_1 ) ; switch ( action ) { <START> case VAR_2 : VAR_3 = TYPE_3 . TYPE_2 ; break ; case VAR_6 : VAR_3 = TYPE_3 . TYPE_5 ; break ; case VAR_8 : VAR_3 = TYPE_3 . TYPE_4 ; break ; <END> default : throw new IllegalArgumentException ( STRING_1 ) ; } }
public void METHOD_1 ( TYPE_1 VAR_1 ) { super . METHOD_1 ( VAR_1 ) ; switch ( action ) { case VAR_2 : VAR_3 = TYPE_3 . TYPE_2 ; break ; case VAR_8 : VAR_3 = TYPE_3 . TYPE_4 ; break ; default : throw new IllegalArgumentException ( STRING_1 ) ; } }
infinite loop ! buf VAR_3 needed
public static void METHOD_1 ( ByteBuffer buf , TYPE_1 VAR_1 ) { int start = buf . position ( ) ; int VAR_2 = buf . VAR_3 ( ) ; <START> while ( buf . VAR_4 ( ) > VAR_5 ) { <END> short VAR_6 = buf . VAR_7 ( ) ; short VAR_8 = METHOD_2 ( buf . VAR_7 ( ) ) ; buf . VAR_3 ( VAR_2 ) ; VAR_1 . METHOD_3 ( buf , VAR_8 ) ; buf . position ( start ) ; } }
public static void METHOD_1 ( ByteBuffer buf , TYPE_1 VAR_1 ) { int start = buf . position ( ) ; if ( buf . VAR_4 ( ) > VAR_5 ) { short VAR_6 = buf . VAR_7 ( ) ; short VAR_8 = METHOD_2 ( buf . VAR_7 ( ) ) ; VAR_1 . METHOD_3 ( buf , VAR_8 ) ; buf . position ( start ) ; } }
I needed METHOD_2 check
public TYPE_1 METHOD_1 ( ) { <START> if ( VAR_1 == null ) { return null ; } <END> return METHOD_2 ( VAR_2 , VAR_1 ) ; }
public TYPE_1 METHOD_1 ( ) { return METHOD_2 ( VAR_2 , VAR_1 ) ; }
shouldn t thrown
public static String METHOD_1 ( String VAR_1 ) { if ( VAR_1 == null ) return null ; try { return VAR_1 . METHOD_2 ( CHAR_1 , CHAR_2 ) . METHOD_3 ( ) ; <START> } catch ( IllegalArgumentException ex ) { <END> return null ; } }
public static String METHOD_1 ( String VAR_1 ) { if ( VAR_1 == null ) { return null ; } return VAR_1 . METHOD_2 ( CHAR_1 , CHAR_2 ) . METHOD_3 ( ) ; }