ReviewComments stringlengths 1 2.35k | OriginalCode stringlengths 28 487 | ReviewedCode stringlengths 14 463 |
|---|---|---|
add VAR_1 | public void METHOD_1 ( ) throws Exception { TYPE_1 VAR_1 = VAR_2 . METHOD_2 ( VAR_3 ) ; TYPE_2 VAR_4 = <START> new TYPE_2 . Builder ( ) . METHOD_3 ( VAR_1 ) <END> . METHOD_4 ( TYPE_4 . VAR_6 ) . build ( ) ; List < TYPE_3 > VAR_7 = VAR_8 . METHOD_5 ( VAR_4 ) ; assertThat ( VAR_7 . size ( ) , is ( 2 ) ) ; for ( TYPE_3 VA... | public void METHOD_1 ( ) throws Exception { TYPE_2 VAR_4 = new TYPE_2 . Builder ( ) . METHOD_4 ( TYPE_4 . VAR_6 ) . build ( ) ; List < TYPE_3 > VAR_7 = VAR_8 . METHOD_5 ( VAR_4 ) ; assertThat ( VAR_7 . size ( ) , is ( 5 ) ) ; for ( TYPE_3 VAR_9 : VAR_7 ) { assertThat ( VAR_9 . METHOD_6 ( ) , is ( TYPE_4 . VAR_6 ) ) ; }... |
format able deal enum s fine need call ( ) | static TYPE_1 METHOD_1 ( TYPE_2 request , Response VAR_1 , IOException VAR_2 ) { return new TYPE_1 ( <START> format ( STRING_1 , VAR_2 . getMessage ( ) , request . VAR_3 ( ) . name ( ) , request . url ( ) ) , <END> VAR_2 ) ; } | static TYPE_1 METHOD_1 ( TYPE_2 request , Response VAR_1 , IOException VAR_2 ) { return new TYPE_1 ( format ( STRING_1 , VAR_2 . getMessage ( ) , request . VAR_3 ( ) , request . url ( ) ) , VAR_2 ) ; } |
merge lines METHOD_1 return argument | protected TYPE_3 ( TYPE_1 buf ) { TYPE_2 . METHOD_1 ( buf , STRING_1 ) ; <START> this . buf = buf ; <END> } | protected TYPE_3 ( TYPE_1 buf ) { this . buf = TYPE_2 . METHOD_1 ( buf , STRING_1 ) ; } |
check VAR_1 ( 0 ) exists | public boolean METHOD_1 ( ) { <START> return VAR_1 . size ( ) == VAR_1 . get ( 0 ) . METHOD_2 ( ) . METHOD_3 ( ) ; <END> } | public boolean METHOD_1 ( ) { return ! isEmpty ( ) && VAR_1 . size ( ) == VAR_1 . get ( 0 ) . METHOD_2 ( ) . METHOD_3 ( ) ; } |
private | <START> public String <END> METHOD_1 ( ) { return "" + state + VAR_1 ; } | public String METHOD_1 ( ) { return state + VAR_1 ; } |
couldn t Arrays asList ( METHOD_3 ) METHOD_2 ( VAR_1 ) instead importing a new library | public int METHOD_1 ( String VAR_1 ) { <START> int index = TYPE_1 . METHOD_2 ( METHOD_3 ( ) , VAR_1 ) ; <END> if ( index == TYPE_1 . VAR_2 ) { return METHOD_1 ( VAR_3 ) ; } return index ; } | public int METHOD_1 ( String VAR_1 ) { int index = METHOD_3 ( ) . METHOD_2 ( VAR_1 ) ; if ( index == - 1 ) { return METHOD_1 ( VAR_3 ) ; } return index ; } |
I prefer junit assertion functions | public void METHOD_1 ( ) { final double [ ] [ ] VAR_1 = { { FLOAT_1 , FLOAT_2 } , { FLOAT_3 , FLOAT_4 } , { FLOAT_5 , FLOAT_6 } , { FLOAT_7 , FLOAT_8 } } ; double [ ] VAR_2 = { FLOAT_9 , FLOAT_10 } ; double [ ] VAR_3 = { FLOAT_11 , FLOAT_12 } ; <START> assert ( TYPE_1 . contains ( VAR_1 , VAR_2 ) ) ; <END> assert ( ! T... | public void METHOD_1 ( ) { final double [ ] [ ] VAR_1 = { { FLOAT_2 , FLOAT_1 } , { FLOAT_4 , FLOAT_3 } , { FLOAT_6 , FLOAT_5 } , { FLOAT_8 , FLOAT_7 } } ; double [ ] VAR_2 = { FLOAT_10 , FLOAT_9 } ; double [ ] VAR_3 = { FLOAT_12 , FLOAT_11 } ; assert ( TYPE_1 . contains ( VAR_1 , VAR_2 ) ) ; assert ( ! TYPE_1 . contai... |
called concurrently rite ? need current status _CODE_ | public void METHOD_1 ( ) { try { VAR_1 . METHOD_2 ( this ) ; <START> VAR_2 . METHOD_3 ( TYPE_3 . TYPE_2 . VAR_5 , client . VAR_6 ( ) ) ; <END> } catch ( TYPE_1 e ) { LOG . error ( STRING_1 , e ) ; } } | public void METHOD_1 ( ) { try { VAR_1 . METHOD_2 ( this ) ; VAR_2 = client . VAR_6 ( ) ; } catch ( TYPE_1 e ) { LOG . error ( STRING_1 , e ) ; } } |
shouldn t appended VAR_1 | public static void METHOD_1 ( StringBuilder buffer , int position ) { StringBuilder VAR_1 = new StringBuilder ( INT_1 ) ; VAR_1 . append ( STRING_1 ) ; buffer . append ( STRING_2 ) ; METHOD_2 ( VAR_1 , VAR_2 , VAR_3 ) ; <START> buffer . append ( STRING_3 ) ; <END> buffer . VAR_4 ( position , VAR_1 . toString ( ) ) ; } | public static void METHOD_1 ( StringBuilder buffer , int position ) { StringBuilder VAR_1 = new StringBuilder ( INT_1 ) ; VAR_1 . append ( STRING_1 ) ; VAR_1 . append ( STRING_2 ) ; METHOD_2 ( VAR_1 , VAR_2 , VAR_3 ) ; VAR_1 . append ( STRING_3 ) ; buffer . VAR_4 ( position , VAR_1 . toString ( ) ) ; } |
final | private void METHOD_1 ( final List < TYPE_1 > VAR_1 ) throws TYPE_2 , TYPE_3 { TYPE_1 VAR_2 = METHOD_2 ( VAR_1 ) ; final TYPE_4 VAR_3 = new TYPE_4 ( VAR_2 , null ) ; <START> TYPE_5 VAR_4 = new TYPE_5 ( Collections . VAR_5 ( VAR_3 ) ) ; <END> VAR_4 . METHOD_3 ( false ) ; final TYPE_6 VAR_6 = TYPE_7 . getInstance ( STRIN... | private void METHOD_1 ( final List < TYPE_1 > VAR_1 ) throws TYPE_2 , TYPE_3 { final TYPE_1 VAR_2 = METHOD_2 ( VAR_1 ) ; final TYPE_4 VAR_3 = new TYPE_4 ( VAR_2 , null ) ; final TYPE_5 VAR_4 = new TYPE_5 ( Collections . VAR_5 ( VAR_3 ) ) ; VAR_4 . METHOD_3 ( false ) ; final TYPE_6 VAR_6 = TYPE_7 . getInstance ( STRING_... |
change regression _CODE_ _CODE_ _CODE_ java TYPE_3 added deployment _CODE_ _CODE_ fails | public Set < Class < ? > > METHOD_1 ( ) { final Set < Class < ? > > VAR_1 = new HashSet < > ( ) ; VAR_1 . add ( TYPE_1 . class ) ; VAR_1 . add ( TYPE_2 . class ) ; <START> VAR_1 . add ( TYPE_3 . class ) ; <END> VAR_1 . add ( TYPE_4 . class ) ; return VAR_1 ; } | public Set < Class < ? > > METHOD_1 ( ) { final Set < Class < ? > > VAR_1 = new HashSet < > ( ) ; VAR_1 . add ( TYPE_1 . class ) ; VAR_1 . add ( TYPE_2 . class ) ; return VAR_1 ; } |
subclasses method _protected_ code replaced a call method subclasses | <START> private void METHOD_1 ( final String message ) throws TYPE_1 { try { METHOD_2 ( ) ; } catch ( final Exception e ) { throw new TYPE_1 ( message , e ) ; } } <END> | protected void METHOD_1 ( final String message ) throws TYPE_1 { try { METHOD_2 ( ) ; } catch ( final Exception e ) { throw new TYPE_1 ( message , e ) ; } } |
minor : pass time column selector field selector consistent buffered aggregator | public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { return new TYPE_3 ( name , VAR_1 . METHOD_2 ( VAR_2 ) , <START> VAR_1 . METHOD_2 ( TYPE_4 . VAR_4 ) <END> ) ; } | public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { return new TYPE_3 ( name , VAR_1 . METHOD_2 ( TYPE_4 . VAR_4 ) , VAR_1 . METHOD_2 ( VAR_2 ) ) ; } |
won t base class a _CODE_ ( ) method caller implementprotected final void METHOD_1 ( ) { ( _CODE_ ( ) ) { _CODE_ ( ) ) ; } } | protected void METHOD_1 ( ) { <START> super . METHOD_1 ( ) ; <END> if ( METHOD_2 ( METHOD_3 ( ) . message ) ) { return ; } TYPE_1 VAR_1 = new TYPE_1 ( vds . getId ( ) ) ; VAR_1 . METHOD_4 ( vds ) ; VAR_1 . METHOD_5 ( STRING_1 , METHOD_3 ( ) . message ) ; VAR_2 . log ( VAR_1 , TYPE_2 . VAR_4 ) ; } | protected void METHOD_1 ( ) { if ( METHOD_2 ( METHOD_3 ( ) . message ) ) { return ; } TYPE_1 VAR_1 = new TYPE_1 ( vds . getId ( ) ) ; VAR_1 . METHOD_4 ( vds ) ; VAR_1 . METHOD_5 ( STRING_1 , METHOD_3 ( ) . message ) ; VAR_2 . log ( VAR_1 , TYPE_2 . VAR_4 ) ; } |
protected package | <START> protected String METHOD_1 ( TYPE_1 VAR_1 ) { <END> String VAR_2 = STRING_1 + ( int ) ( VAR_1 . VAR_3 * INT_1 ) + STRING_2 + ( int ) ( VAR_1 . VAR_4 * INT_1 ) + STRING_2 + ( int ) ( VAR_1 . VAR_5 * INT_1 ) + STRING_2 + ( int ) ( VAR_1 . VAR_6 * INT_1 ) + STRING_3 ; return VAR_2 ; } | String METHOD_1 ( TYPE_1 VAR_1 ) { String VAR_2 = STRING_1 + ( int ) ( VAR_1 . VAR_3 * INT_1 ) + STRING_2 + ( int ) ( VAR_1 . VAR_4 * INT_1 ) + STRING_2 + ( int ) ( VAR_1 . VAR_5 * INT_1 ) + STRING_2 + ( int ) ( VAR_1 . VAR_6 * INT_1 ) + STRING_3 ; return VAR_2 ; } |
style : missing braces style guide changed a braces single line blocks | public TYPE_1 METHOD_1 ( File f , TYPE_3 . TYPE_4 VAR_1 ) { <START> if ( VAR_1 . METHOD_2 ( ) ) <END> return TYPE_1 . VAR_2 ; else if ( VAR_1 . METHOD_3 ( ) ) { if ( new File ( f , Constants . VAR_3 ) . exists ( ) ) return TYPE_1 . VAR_4 ; else return TYPE_1 . VAR_5 ; } else if ( VAR_1 . METHOD_4 ( ) ) return TYPE_1 . ... | public TYPE_1 METHOD_1 ( File f , TYPE_3 . TYPE_4 VAR_1 ) { if ( VAR_1 . METHOD_2 ( ) ) { return TYPE_1 . VAR_2 ; } else if ( VAR_1 . METHOD_3 ( ) ) { if ( new File ( f , Constants . VAR_3 ) . exists ( ) ) { return TYPE_1 . VAR_4 ; } else { return TYPE_1 . VAR_5 ; } } else if ( VAR_1 . METHOD_4 ( ) ) { return TYPE_1 . ... |
move constructor ? a defensive copy front - load work instead | public Map < String , Set < TYPE_1 > > METHOD_1 ( ) { <START> return TYPE_2 . METHOD_2 ( VAR_1 . METHOD_3 ( ) , TYPE_3 : : METHOD_4 ) ; <END> } | public Map < String , Set < TYPE_1 > > METHOD_1 ( ) { return VAR_1 ; } |
throws required | <START> public void METHOD_1 ( TYPE_1 location , TYPE_2 VAR_1 ) throws TYPE_3 { <END> METHOD_2 ( location , VAR_1 , TYPE_4 . VAR_3 ) ; } | public void METHOD_1 ( TYPE_1 location , TYPE_2 VAR_1 ) { METHOD_2 ( location , VAR_1 , TYPE_4 . VAR_3 ) ; } |
cuellar reason set 1 line number 133 ? I d prefer String [ 0 ] add some safety _CODE_ ( ) check array length ( 0 set _CODE_ ) _CODE_ needs a smarter I d suggest API call _CODE_ wipe _CODE_ stuff incoming _CODE_ | public TYPE_5 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 , TYPE_3 VAR_4 , TYPE_4 VAR_5 ) { this . VAR_3 = VAR_3 ; this . VAR_2 = VAR_2 ; this . VAR_4 = VAR_4 ; this . VAR_5 = VAR_5 ; <START> this . VAR_6 = new String [ 1 ] ; <END> } | public TYPE_5 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 , TYPE_3 VAR_4 , TYPE_4 VAR_5 ) { this . VAR_3 = VAR_3 ; this . VAR_2 = VAR_2 ; this . VAR_4 = VAR_4 ; this . VAR_5 = VAR_5 ; this . VAR_6 = new String [ 0 ] ; } |
default access ( modifier ) suffices | public static int METHOD_1 ( ) { return TYPE_1 . METHOD_2 ( ) ; <START> } <END> | static int METHOD_1 ( ) { return TYPE_1 . METHOD_2 ( ) ; } |
eliminate extraneous | private void METHOD_1 ( String VAR_1 ) { try { if ( VAR_1 == null ) { <START> this . VAR_2 = TYPE_1 . METHOD_2 ( ) ; <END> } else { this . VAR_2 = TYPE_1 . METHOD_3 ( VAR_1 ) ; } logger . debug ( STRING_1 , this . VAR_3 , VAR_1 ) ; } catch ( TYPE_2 e ) { logger . error ( STRING_2 , this . VAR_3 , VAR_1 ) ; } } | private void METHOD_1 ( String VAR_1 ) { try { if ( VAR_1 == null ) { VAR_2 = TYPE_1 . METHOD_2 ( ) ; } else { VAR_2 = TYPE_1 . METHOD_3 ( VAR_1 ) ; } logger . debug ( STRING_1 , VAR_3 , VAR_1 ) ; } catch ( TYPE_2 e ) { logger . warn ( STRING_2 , VAR_3 , VAR_1 ) ; VAR_2 = TYPE_1 . METHOD_2 ( ) ; } } |
VAR_2 need change : suggestionif ( ! isEmpty ( VAR_1 ) || VAR_2 ! = null ) { user selects expression type leaves expression blank _expression component_ wont loaded | void METHOD_1 ( final String type , final String VAR_1 , final TYPE_1 VAR_2 ) { METHOD_2 ( ) . METHOD_3 ( type ) ; <START> if ( ! isEmpty ( VAR_1 ) ) { <END> METHOD_2 ( ) . METHOD_4 ( VAR_2 ) ; } else { METHOD_2 ( ) . METHOD_5 ( ) ; } } | void METHOD_1 ( final String type , final String VAR_1 , final TYPE_1 VAR_2 ) { METHOD_2 ( ) . METHOD_3 ( type ) ; if ( ! isEmpty ( VAR_1 ) || VAR_2 != null ) { METHOD_2 ( ) . METHOD_4 ( VAR_2 ) ; } else { METHOD_2 ( ) . METHOD_5 ( ) ; } } |
I databases method properly constructed ? eclipse returns method return a result type boolean I add return _CODE_ false | <START> public boolean METHOD_1 ( ) { <END> } | public boolean METHOD_1 ( ) { return true ; } |
return STRING_1 | public String METHOD_1 ( ) { <START> return Context . VAR_1 ( ) . getMessage ( STRING_1 ) ; <END> } | public String METHOD_1 ( ) { return STRING_1 ; } |
unnecessary null check path ; trivial ; ignoring | public static String METHOD_1 ( Object context , String path ) { TYPE_1 . METHOD_2 ( path , STRING_1 ) ; <START> if ( path == null || path . startsWith ( STRING_2 ) || TYPE_2 . METHOD_3 ( path ) ) return path ; <END> TYPE_1 . METHOD_2 ( context , STRING_3 ) ; return METHOD_4 ( context ) + path ; } | public static String METHOD_1 ( Object context , String path ) { TYPE_1 . METHOD_2 ( path , STRING_1 ) ; if ( path . startsWith ( STRING_2 ) || TYPE_2 . METHOD_3 ( path ) ) return path ; TYPE_1 . METHOD_2 ( context , STRING_3 ) ; return METHOD_4 ( context ) + path ; } |
removed | private void METHOD_1 ( TYPE_1 VAR_1 ) { <START> TYPE_2 VAR_2 = VAR_3 . METHOD_2 ( ) ; <END> TYPE_3 cmd = VAR_4 . METHOD_3 ( VAR_5 , VAR_1 ) ; try { VAR_3 . METHOD_4 ( source , cmd , TYPE_4 . NONE ) ; } catch ( Exception e ) { log . VAR_7 ( STRING_1 , source , VAR_1 ) ; } } | private void METHOD_1 ( TYPE_1 VAR_1 ) { TYPE_3 cmd = VAR_4 . METHOD_3 ( VAR_5 , VAR_1 ) ; try { VAR_3 . METHOD_4 ( source , cmd , TYPE_4 . NONE ) ; } catch ( Exception e ) { log . VAR_7 ( STRING_1 , source , VAR_1 ) ; } } |
expensive call eviction attempt want eviction loop fast dependencies external services | public void METHOD_1 ( ) { <START> VAR_1 . METHOD_2 ( ) ; <END> METHOD_3 ( ) ; } | public void METHOD_1 ( ) { METHOD_3 ( ) ; } |
intentionally a bitwise | private final void METHOD_1 ( ) { int VAR_1 = VAR_2 . METHOD_2 ( ) ; if ( VAR_1 == 0 ) { <START> if ( ! VAR_3 . METHOD_3 ( ) & VAR_4 ) <END> { VAR_5 . METHOD_4 ( ) . VAR_6 . VAR_7 . METHOD_5 ( ) ; } else { VAR_5 . METHOD_4 ( ) . VAR_6 . VAR_8 . METHOD_6 ( System . VAR_9 ( ) - VAR_10 ) ; } } } | private final void METHOD_1 ( ) { int VAR_1 = VAR_2 . METHOD_2 ( ) ; if ( VAR_1 == 0 ) { if ( ! VAR_3 . METHOD_3 ( ) && VAR_4 ) { VAR_5 . METHOD_4 ( ) . VAR_6 . VAR_7 . METHOD_5 ( ) ; } else { VAR_5 . METHOD_4 ( ) . VAR_6 . VAR_8 . METHOD_6 ( System . VAR_9 ( ) - VAR_10 ) ; } } } |
parameterized constructor call instead addAll ( ) | public List < TYPE_1 > METHOD_1 ( TYPE_2 sess , List < TYPE_3 > VAR_1 , TYPE_4 resource , TYPE_5 group , boolean VAR_2 ) throws TYPE_6 { this . METHOD_2 ( sess , group , resource ) ; List < TYPE_1 > VAR_3 = new ArrayList < > ( ) ; <START> VAR_3 . addAll ( METHOD_3 ( ) . METHOD_1 ( sess , VAR_1 , resource , group ) ) ; ... | public List < TYPE_1 > METHOD_1 ( TYPE_2 sess , List < TYPE_3 > VAR_1 , TYPE_4 resource , TYPE_5 group , boolean VAR_2 ) throws TYPE_6 { this . METHOD_2 ( sess , group , resource ) ; List < TYPE_1 > VAR_3 = METHOD_3 ( ) . METHOD_1 ( sess , VAR_1 , resource , group ) ; if ( VAR_2 ) { VAR_3 . addAll ( METHOD_3 ( ) . METH... |
open expression user specification test default _CODE_ | private boolean METHOD_1 ( TYPE_1 < ? > message ) { <START> if ( message . VAR_1 ( ) . containsKey ( TYPE_2 . VAR_3 ) ) { <END> return this . VAR_4 . getValue ( this . VAR_5 , message , Boolean . VAR_6 ) ; } return false ; } | private boolean METHOD_1 ( TYPE_1 < ? > message ) { Boolean value = this . VAR_4 . getValue ( this . VAR_5 , message , Boolean . VAR_6 ) ; return value != null ? value : false ; } |
rid variable | public void METHOD_1 ( ) { <START> int VAR_1 = 1 ; <END> TYPE_1 VAR_2 = VAR_3 . METHOD_2 ( VAR_1 ) ; assertEquals ( STRING_1 , VAR_2 . METHOD_3 ( ) ) ; } | public void METHOD_1 ( ) { TYPE_1 VAR_2 = VAR_3 . METHOD_2 ( 1 ) ; assertEquals ( STRING_1 , VAR_2 . METHOD_3 ( ) ) ; } |
split lines | public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { METHOD_2 ( ! VAR_2 , STRING_1 ) ; TYPE_3 VAR_3 = VAR_1 . METHOD_3 ( VAR_4 , VAR_5 , TYPE_4 . class . METHOD_4 ( ) ) ; <START> return new TYPE_5 ( VAR_3 , METHOD_5 ( ) , VAR_6 , VAR_7 , VAR_8 , VAR_9 . METHOD_6 ( ) , VAR_10 ) ; <END> } | public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { METHOD_2 ( ! VAR_2 , STRING_1 ) ; TYPE_3 VAR_3 = VAR_1 . METHOD_3 ( VAR_4 , VAR_5 , TYPE_5 . class . METHOD_4 ( ) ) ; return new TYPE_5 ( VAR_3 , METHOD_5 ( ) , VAR_6 , VAR_7 , VAR_8 , VAR_9 ) ; } |
evtl geht auch clear ( ) dann braucht man gar keinen parameter | private TYPE_1 METHOD_1 ( final TYPE_2 job , TYPE_1 VAR_1 , String VAR_2 ) { <START> if ( VAR_1 != null ) { <END> job . VAR_3 ( ) . remove ( VAR_1 ) ; } TYPE_1 VAR_4 = new TYPE_1 ( ) ; VAR_4 . METHOD_2 ( Collections . VAR_5 ( new TYPE_3 ( VAR_2 , new TYPE_4 ( ) ) ) ) ; job . VAR_3 ( ) . add ( VAR_4 ) ; return VAR_4 ; } | private TYPE_1 METHOD_1 ( final TYPE_2 job , TYPE_1 VAR_1 , String VAR_2 ) { if ( VAR_1 != null ) { job . VAR_3 ( ) . remove ( VAR_1 ) ; } return METHOD_1 ( job , VAR_2 ) ; } |
more PHD students PHD students switching order || improve performance | public boolean METHOD_1 ( TYPE_1 user ) { if ( user == null || user . VAR_1 ( ) == null ) { return false ; } <START> return new TYPE_2 ( ) . METHOD_1 ( user ) || ( user . VAR_1 ( ) . METHOD_2 ( ) != null && user . VAR_1 ( ) <END> . METHOD_2 ( ) . METHOD_3 ( ) ) ; } | public boolean METHOD_1 ( TYPE_1 user ) { if ( user == null || user . VAR_1 ( ) == null ) { return false ; } return ( user . VAR_1 ( ) . METHOD_2 ( ) != null && user . VAR_1 ( ) . METHOD_2 ( ) . METHOD_3 ( ) ) || new TYPE_2 ( ) . METHOD_1 ( user ) ; } |
rename METHOD_3 METHOD_1 | public TYPE_1 < ? > METHOD_1 ( ) { if ( METHOD_2 ( ) ) { return VAR_1 ; } <START> return VAR_2 . METHOD_3 ( ) ; <END> } | public TYPE_1 < ? > METHOD_1 ( ) { if ( METHOD_2 ( ) ) { return VAR_1 ; } return VAR_2 . METHOD_1 ( ) ; } |
s relation change WFLY - 19339 | public Map < String , TYPE_1 > METHOD_1 ( ) { <START> return Collections . VAR_1 ( VAR_2 ) ; <END> } | public Map < String , TYPE_1 > METHOD_1 ( ) { return VAR_2 ; } |
rename entry | public void METHOD_1 ( TYPE_1 [ ] VAR_1 ) { model . VAR_2 ( ) ; TYPE_1 entry ; for ( TYPE_1 <START> VAR_3 : <END> VAR_1 ) { entry = VAR_3 ; switch ( entry . VAR_4 ( ) ) { case TYPE_1 . VAR_5 : model . VAR_6 ( TYPE_2 . VAR_8 , entry ) ; break ; default : model . VAR_6 ( TYPE_2 . VAR_9 , entry ) ; break ; } } METHOD_2 ( ... | public void METHOD_1 ( TYPE_1 [ ] VAR_1 ) { model . VAR_2 ( ) ; for ( TYPE_1 entry : VAR_1 ) { switch ( entry . VAR_4 ( ) ) { case TYPE_1 . VAR_5 : model . VAR_6 ( TYPE_2 . VAR_8 , entry ) ; break ; default : model . VAR_6 ( TYPE_2 . VAR_9 , entry ) ; break ; } } METHOD_2 ( ) ; } |
a new code mved consider java7 - - resources statement : ( TYPE_1 VAR_2 = new TYPE_1 ( VAR_1 ) ) { return VAR_2 METHOD_2 ( ) METHOD_3 ( ) getValue ( STRING_1 ) ; } | public static String METHOD_1 ( File VAR_1 ) throws IOException { <START> TYPE_1 VAR_2 = new TYPE_1 ( VAR_1 ) ; try { return VAR_2 . METHOD_2 ( ) . METHOD_3 ( ) . getValue ( STRING_1 ) ; } finally { VAR_2 . close ( ) ; } <END> } | public static String METHOD_1 ( File VAR_1 ) throws IOException { try ( TYPE_1 VAR_2 = new TYPE_1 ( VAR_1 ) ) { return VAR_2 . METHOD_2 ( ) . METHOD_3 ( ) . getValue ( STRING_1 ) ; } } |
primitive boolean compared null | protected String METHOD_1 ( String name ) { boolean VAR_1 = VAR_2 != null && VAR_2 . METHOD_2 ( ) . METHOD_3 ( ) . METHOD_4 ( ) ; <START> if ( VAR_1 != null && VAR_1 ) { <END> return VAR_3 + STRING_1 + ( name != null ? name : VAR_4 ) ; } else { return name != null ? name : VAR_4 ; } } | protected String METHOD_1 ( String name ) { boolean VAR_1 = VAR_2 != null && VAR_2 . METHOD_2 ( ) . METHOD_3 ( ) . METHOD_4 ( ) ; if ( VAR_1 ) { return VAR_3 + STRING_1 + ( name != null ? name : VAR_4 ) ; } else { return name != null ? name : VAR_4 ; } } |
s element checked viewer map other code wrong e g _CODE_ ( ) s return false | public boolean METHOD_1 ( Object element ) { if ( VAR_1 . containsKey ( element ) ) { return VAR_1 . get ( element ) ; } <START> return VAR_2 . METHOD_1 ( element ) ; <END> } | public boolean METHOD_1 ( Object element ) { return VAR_1 . contains ( element ) ; } |
swallow typo - case issue a warning ? delete VAR_1 method doesn t matter a mail doesn t exist fine rellies command change spelled VAR_1 wrong fail i | <START> private void METHOD_1 ( String VAR_1 ) throws TYPE_1 , TYPE_2 { List < TYPE_3 > VAR_2 = VAR_3 . apply ( VAR_4 ) ; for ( TYPE_3 e : VAR_2 ) { if ( e . VAR_1 . equals ( VAR_1 ) ) { VAR_5 . apply ( new TYPE_5 . TYPE_6 ( user , VAR_1 ) , null ) ; } } } <END> | private void METHOD_1 ( String VAR_1 ) throws TYPE_1 , TYPE_2 { VAR_5 . apply ( new TYPE_5 . TYPE_6 ( user , VAR_1 ) , null ) ; } |
brackets single statements cleanup file done a separate commit mix unrelated changes | private void METHOD_1 ( TYPE_1 [ ] VAR_1 ) { <START> for ( TYPE_1 job : VAR_1 ) { <END> job . VAR_2 ( ) ; } } | private void METHOD_1 ( TYPE_1 [ ] VAR_1 ) { for ( TYPE_1 job : VAR_1 ) job . VAR_2 ( ) ; } |
please swap order private static [ google code style guide ] ( ) | <START> static private long METHOD_1 ( String VAR_1 ) { <END> if ( VAR_1 . contains ( STRING_1 ) ) { float value = TYPE_1 . METHOD_2 ( VAR_1 ) ; float VAR_2 = value % 1 ; return TYPE_2 . METHOD_1 ( ( long ) value ) + ( long ) ( VAR_2 * INT_1 ) ; } else { return TYPE_2 . METHOD_1 ( Long . VAR_3 ( VAR_1 ) ) ; } } | private static long METHOD_1 ( String VAR_1 ) { if ( VAR_1 . contains ( STRING_1 ) ) { float value = TYPE_1 . METHOD_2 ( VAR_1 ) ; float VAR_2 = value % 1 ; return TYPE_2 . METHOD_1 ( ( long ) value ) + ( long ) ( VAR_2 * INT_1 ) ; } else { return TYPE_2 . METHOD_1 ( Long . VAR_3 ( VAR_1 ) ) ; } } |
pre - mature optimization I worry data structure option view list a revolving buffer essentially maintain index oldest valid item replace increment add start search wrapping | public synchronized void METHOD_1 ( List < TYPE_1 > VAR_1 ) { for ( TYPE_1 request : VAR_1 ) { if ( VAR_2 . size ( ) >= VAR_3 ) { <START> VAR_2 . remove ( 0 ) ; <END> } VAR_2 . add ( new TYPE_2 ( request , METHOD_2 ( ) . METHOD_3 ( ) ) ) ; } VAR_4 . execute ( VAR_5 ) ; } | public synchronized void METHOD_1 ( List < TYPE_1 > VAR_1 ) { for ( TYPE_1 request : VAR_1 ) { VAR_2 . add ( new TYPE_2 ( request , METHOD_2 ( ) . METHOD_3 ( ) ) ) ; } VAR_4 . execute ( VAR_5 ) ; } |
catch Throwable ? methods shouldn t throw VAR_1 false s easy a hang exception type changed | static boolean METHOD_1 ( TYPE_1 parser , boolean VAR_1 ) throws IOException { try { TYPE_2 VAR_2 = parser . VAR_2 ( ) ; if ( VAR_2 == null ) VAR_2 = parser . VAR_3 ( ) ; if ( VAR_2 == TYPE_2 . VAR_4 ) return true ; if ( VAR_1 ) { throw new IllegalArgumentException ( STRING_1 + VAR_2 ) ; } return false ; <START> } catc... | static boolean METHOD_1 ( TYPE_1 parser , boolean VAR_1 ) throws IOException { try { TYPE_2 VAR_2 = parser . VAR_2 ( ) ; if ( VAR_2 == null ) VAR_2 = parser . VAR_3 ( ) ; if ( VAR_2 == TYPE_2 . VAR_4 ) return true ; if ( VAR_1 ) { throw new IllegalArgumentException ( STRING_1 + VAR_2 ) ; } return false ; } catch ( Thro... |
rid injection moving initialization VAR_3 c tor _CODE_ ( ) method VAR_2 a member _CODE_ ( ) referring initialized TYPE_3 obtain _CODE_ host | public TYPE_4 ( TYPE_1 parameters , boolean VAR_2 ) { super ( parameters ) ; if ( ! VAR_2 ) { <START> VAR_3 = TYPE_2 . get ( TYPE_3 . class ) . METHOD_1 ( parameters . VAR_4 ( ) ) ; <END> } } | public TYPE_4 ( TYPE_1 parameters , boolean VAR_2 ) { super ( parameters ) ; this . VAR_2 = VAR_2 ; } |
needed | public TYPE_2 ( TYPE_1 VAR_2 , TYPE_1 VAR_3 ) { super ( VAR_2 , VAR_3 ) ; <START> VAR_2 . METHOD_1 ( ) . get ( STRING_1 ) . METHOD_2 ( ) ; <END> } | public TYPE_2 ( TYPE_1 VAR_2 , TYPE_1 VAR_3 ) { super ( VAR_2 , VAR_3 ) ; } |
annotate interface methods don t need repeat ( setting inherit annotations ) | <START> public List < ANNOTATION_1 Integer > METHOD_1 ( int VAR_1 , boolean VAR_2 ) <END> throws TYPE_1 { return METHOD_2 ( ) . METHOD_1 ( VAR_1 , VAR_2 ) ; } | public List < Integer > METHOD_1 ( int VAR_1 , boolean VAR_2 ) throws TYPE_1 { return METHOD_2 ( ) . METHOD_1 ( VAR_1 , VAR_2 ) ; } |
VAR_1 | private String METHOD_1 ( ) throws Exception { if <START> ( VAR_1 != <END> null ) { return VAR_1 ; } long VAR_2 = System . currentTimeMillis ( ) ; VAR_1 = VAR_3 . execute ( VAR_4 , VAR_5 ) ; long VAR_6 = System . currentTimeMillis ( ) ; System . out . println ( STRING_1 + ( VAR_6 - VAR_2 ) ) ; return VAR_1 ; } | private String METHOD_1 ( ) throws Exception { if ( this . VAR_1 != null ) { return this . VAR_1 ; } this . VAR_1 = VAR_3 . execute ( VAR_4 , VAR_5 ) ; return this . VAR_1 ; } |
lets remove / catch / log / rethrow | public static String METHOD_1 ( Map conf ) throws IOException { String VAR_1 = METHOD_2 ( conf ) + VAR_2 + STRING_1 ; try { TYPE_1 . METHOD_3 ( new File ( VAR_1 ) ) ; } catch ( IOException e ) { LOG . error ( STRING_2 + VAR_1 , e ) ; <START> throw e ; <END> } return VAR_1 ; } | public static String METHOD_1 ( Map conf ) throws IOException { String VAR_1 = METHOD_2 ( conf ) + VAR_2 + STRING_1 ; TYPE_1 . METHOD_3 ( new File ( VAR_1 ) ) ; return VAR_1 ; } |
public | <START> public TYPE_2 ( String VAR_2 , long VAR_3 , String VAR_4 ) { <END> this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; this . VAR_4 = VAR_4 ; VAR_5 = METHOD_1 ( TYPE_1 . class ) ; when ( VAR_5 . toString ( ) ) . METHOD_2 ( VAR_2 ) ; } | TYPE_2 ( String VAR_2 , long VAR_3 , String VAR_4 ) { this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; this . VAR_4 = VAR_4 ; VAR_5 = METHOD_1 ( TYPE_1 . class ) ; when ( VAR_5 . toString ( ) ) . METHOD_2 ( VAR_2 ) ; } |
Log error level ? I don t put stack trace result crashing system more issue warn | public static void METHOD_1 ( String [ ] args ) { LOG . info ( STRING_1 ) ; try { TYPE_1 . METHOD_2 ( ) ; LOG . info ( STRING_2 ) ; } catch ( IllegalStateException e ) { <START> LOG . warn ( STRING_3 , e . getMessage ( ) ) ; <END> System . VAR_1 ( - 1 ) ; } System . VAR_1 ( 0 ) ; } | public static void METHOD_1 ( String [ ] args ) { LOG . info ( STRING_1 ) ; try { TYPE_1 . METHOD_2 ( ) ; LOG . info ( STRING_2 ) ; } catch ( IllegalStateException e ) { LOG . error ( STRING_3 , e . getMessage ( ) ) ; System . VAR_1 ( - 1 ) ; } System . VAR_1 ( 0 ) ; } |
static | <START> private boolean METHOD_1 ( TYPE_1 filter , TYPE_2 [ ] VAR_1 ) <END> { return Arrays . stream ( filter . VAR_2 ( ) ) . METHOD_2 ( channel - > VAR_1 [ channel ] != null ) ; } | private static boolean METHOD_1 ( TYPE_1 filter , TYPE_2 [ ] VAR_1 ) { return Arrays . stream ( filter . VAR_2 ( ) ) . METHOD_2 ( channel - > VAR_1 [ channel ] != null ) ; } |
static import METHOD_3 | public void METHOD_1 ( ) { <START> METHOD_2 ( TYPE_1 . METHOD_3 ( TYPE_2 . class ) <END> . METHOD_4 ( null ) ) ; } | public void METHOD_1 ( ) { METHOD_2 ( METHOD_3 ( TYPE_2 . class ) . METHOD_4 ( null ) ) ; } |
s break line please | public int METHOD_1 ( ) { <START> return TYPE_1 . METHOD_2 ( VAR_1 , VAR_2 , VAR_3 , VAR_4 , VAR_5 , VAR_6 , VAR_7 ) ; <END> } | public int METHOD_1 ( ) { return TYPE_1 . METHOD_2 ( VAR_1 , VAR_2 , VAR_5 , VAR_6 , VAR_7 ) ; } |
return VAR_1 METHOD_2 ( TYPE_2 class ) || VAR_1 METHOD_2 ( TYPE_3 class ) | public boolean METHOD_1 ( Class < ? extends TYPE_1 > VAR_1 ) { <START> if ( VAR_1 . METHOD_2 ( TYPE_2 . class ) || VAR_1 . METHOD_2 ( TYPE_3 . class ) ) { <END> return true ; } else { return false ; } } | public boolean METHOD_1 ( Class < ? extends TYPE_1 > VAR_1 ) { return VAR_1 . METHOD_2 ( TYPE_2 . class ) || VAR_1 . METHOD_2 ( TYPE_3 . class ) ; } |
fluent interface | public void METHOD_1 ( String VAR_1 , String VAR_2 ) { TYPE_1 VAR_3 = new TYPE_1 ( VAR_4 ) ; VAR_3 . METHOD_2 ( VAR_5 . METHOD_3 ( VAR_1 ) ) ; TYPE_2 VAR_6 = VAR_3 . METHOD_4 ( ) ; VAR_6 . METHOD_5 ( config . VAR_7 ( ) ) ; <START> VAR_6 . METHOD_6 ( ) ; <END> TYPE_3 . METHOD_7 ( VAR_5 . METHOD_3 ( VAR_2 ) , VAR_4 . MET... | public void METHOD_1 ( String VAR_1 , String VAR_2 ) { TYPE_1 VAR_3 = new TYPE_1 ( VAR_4 ) ; VAR_3 . METHOD_2 ( VAR_5 . METHOD_3 ( VAR_1 ) ) ; VAR_3 . METHOD_4 ( ) . METHOD_6 ( ) ; TYPE_3 . METHOD_7 ( VAR_5 . METHOD_3 ( VAR_2 ) , VAR_4 . METHOD_8 ( ) ) ; } |
s issue argument ( VAR_1 ) IllegalStateException more sense | public void execute ( TYPE_1 VAR_1 ) throws IOException { <START> if ( ! METHOD_1 ( ) ) throw new IllegalArgumentException ( STRING_1 ) ; <END> TYPE_2 VAR_2 = VAR_3 . METHOD_2 ( ) ; VAR_2 . METHOD_3 ( ( double ) VAR_4 . METHOD_2 ( ) ) ; VAR_1 . METHOD_4 ( VAR_2 ) ; } | public void execute ( TYPE_1 VAR_1 ) throws IOException { if ( ! METHOD_1 ( ) ) throw new IllegalStateException ( STRING_1 ) ; TYPE_2 VAR_2 = VAR_3 . METHOD_2 ( ) ; VAR_2 . METHOD_3 ( ( double ) VAR_4 . METHOD_2 ( ) ) ; VAR_1 . METHOD_4 ( VAR_2 ) ; } |
please remove System println | public void METHOD_1 ( ) { VAR_1 . METHOD_2 ( TYPE_2 . VAR_3 ) ; assertThat ( TYPE_1 . METHOD_3 ( new File ( STRING_1 ) ) ) . METHOD_4 ( ) ; assertThat ( VAR_1 . METHOD_5 ( TYPE_2 . VAR_4 ) ) . contains ( STRING_2 ) ; <START> System . out . println ( VAR_1 . METHOD_5 ( TYPE_2 . VAR_3 ) ) ; <END> assertThat ( VAR_1 . ME... | public void METHOD_1 ( ) { VAR_1 . METHOD_2 ( TYPE_2 . VAR_3 ) ; assertThat ( TYPE_1 . METHOD_3 ( new File ( STRING_1 ) ) ) . METHOD_4 ( ) ; assertThat ( VAR_1 . METHOD_5 ( TYPE_2 . VAR_4 ) ) . contains ( STRING_2 ) ; assertThat ( VAR_1 . METHOD_5 ( TYPE_2 . VAR_3 ) ) . METHOD_6 ( 1 ) . METHOD_7 ( s - > s . startsWith ... |
remove log warn cover log trace | boolean METHOD_1 ( ) { try { return TYPE_1 . getInstance ( ) . METHOD_2 ( TYPE_3 . VAR_2 , TYPE_3 . VAR_3 ) ; } catch ( final TYPE_2 ex ) { <START> LOG . warn ( ex . VAR_4 ( ) ) ; <END> LOG . trace ( STRING_1 , ex . VAR_4 ( ) , ex ) ; } return false ; } | boolean METHOD_1 ( ) { try { return TYPE_1 . getInstance ( ) . METHOD_2 ( TYPE_3 . VAR_2 , TYPE_3 . VAR_3 ) ; } catch ( final TYPE_2 ex ) { LOG . trace ( STRING_1 , ex . VAR_4 ( ) , ex ) ; } return false ; } |
shouldn t users automatically friend STRING_1 signup | public void METHOD_1 ( ) throws Exception { TYPE_1 VAR_1 = TYPE_2 . METHOD_2 ( STRING_1 , STRING_2 , VAR_2 , VAR_3 ) ; TYPE_1 VAR_4 = TYPE_2 . METHOD_2 ( STRING_3 , STRING_3 , VAR_2 , VAR_3 ) ; <START> VAR_4 . METHOD_3 ( VAR_1 . VAR_5 , TYPE_3 . METHOD_4 ( ) ) . get ( ) ; <END> List < TYPE_4 > VAR_6 = VAR_1 . METHOD_5 ... | public void METHOD_1 ( ) throws Exception { TYPE_1 VAR_1 = TYPE_2 . METHOD_2 ( STRING_1 , STRING_2 , VAR_2 , VAR_3 ) ; TYPE_1 VAR_4 = TYPE_2 . METHOD_2 ( STRING_3 , STRING_3 , VAR_2 , VAR_3 ) ; List < TYPE_4 > VAR_6 = VAR_1 . METHOD_5 ( ) . get ( ) ; assertTrue ( STRING_4 , VAR_6 . size ( ) > 0 ) ; } |
тут ты ловишь и то что вылетит из VAR_1 METHOD_1 ( ) надо более узкий - только на METHOD_4 ( ) и METHOD_5 ( ) | public void METHOD_1 ( TYPE_1 request , TYPE_2 response , TYPE_3 VAR_1 ) throws IOException , TYPE_4 { METHOD_2 ( VAR_2 , STRING_1 ) ; try { VAR_2 . METHOD_3 ( METHOD_4 ( request ) , METHOD_5 ( request ) ) ; VAR_1 . METHOD_1 ( request , response ) ; <START> } catch ( IllegalArgumentException e ) { <END> ( ( TYPE_5 ) re... | public void METHOD_1 ( TYPE_1 request , TYPE_2 response , TYPE_3 VAR_1 ) throws IOException , TYPE_4 { METHOD_2 ( VAR_2 , STRING_1 ) ; try { try { VAR_2 . METHOD_3 ( METHOD_4 ( request ) , METHOD_5 ( request ) ) ; } catch ( IllegalArgumentException e ) { ( ( TYPE_5 ) response ) . METHOD_6 ( TYPE_5 . VAR_3 ) ; return ; ... |
throw new TYPE_5 ( e ) ; orgin exception TYPE_5 | public TYPE_1 getPath ( ) { try { return new TYPE_2 ( ) . METHOD_1 ( this , METHOD_2 ( TYPE_6 . TYPE_7 . class ) ) ; } catch ( TYPE_4 e ) { <START> throw new TYPE_5 ( ) ; <END> } } | public TYPE_1 getPath ( ) { try { return new TYPE_2 ( ) . METHOD_1 ( this , METHOD_2 ( TYPE_6 . TYPE_7 . class ) ) ; } catch ( TYPE_4 e ) { throw new TYPE_5 ( e ) ; } } |
I delegate overloaded method : public void METHOD_1 ( final TYPE_1 input final TYPE_2 output final String ) throws IOException { output write ( METHOD_1 ( input ) ) ; } | public void METHOD_1 ( final TYPE_1 input , final TYPE_2 output , final String name ) throws IOException { <START> final byte [ ] VAR_1 ; <END> try { VAR_1 = TYPE_3 . METHOD_2 ( input ) ; } catch ( final IOException e ) { throw METHOD_3 ( name , e ) ; } output . write ( METHOD_1 ( VAR_1 , name ) ) ; } | public void METHOD_1 ( final TYPE_1 input , final TYPE_2 output , final String name ) throws IOException { output . write ( METHOD_1 ( input , name ) ) ; } |
drop println : - ) | public TYPE_2 . TYPE_3 METHOD_1 ( ) { <START> System . out . println ( STRING_1 ) ; <END> return VAR_1 ; } | public TYPE_2 . TYPE_3 METHOD_1 ( ) { return VAR_1 ; } |
fail _CODE_ test fails leave assertions tests METHOD_1 methods | protected void METHOD_1 ( ) { boolean VAR_1 = METHOD_2 ( ) . METHOD_3 ( VAR_2 ) ; <START> assertTrue ( VAR_1 ) ; <END> } | protected void METHOD_1 ( ) { METHOD_2 ( ) . METHOD_3 ( VAR_2 ) ; } |
need empty message _CODE_ ( node ( STRING_2 ) ( STRING_3 ) ) ; | public void METHOD_1 ( ) throws Exception { TYPE_1 node = METHOD_2 ( TYPE_2 . VAR_2 , STRING_1 ) ; <START> METHOD_3 ( "" , node . get ( STRING_2 ) . get ( STRING_3 ) ) ; <END> } | public void METHOD_1 ( ) throws Exception { TYPE_1 node = METHOD_2 ( TYPE_2 . VAR_2 , STRING_1 ) ; METHOD_3 ( node . get ( STRING_2 ) . get ( STRING_3 ) ) ; } |
need VAR_2 code ? _CODE_ execute thread safe isn t | protected void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 resource , TYPE_3 monitor ) { <START> VAR_2 . METHOD_2 ( ) ; <END> try { VAR_3 . execute ( new TYPE_4 ( VAR_1 , resource , monitor ) ) ; } finally { VAR_2 . METHOD_3 ( ) ; } } | protected void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 resource , TYPE_3 monitor ) { VAR_3 . execute ( new TYPE_4 ( VAR_1 , resource , monitor ) ) ; } |
unrelated change snuck bitching reviewing harder big refactorings | private void METHOD_1 ( ) throws TYPE_1 { int VAR_1 = 0 ; for ( TYPE_2 VAR_2 : VAR_3 ) { VAR_1 += VAR_2 . METHOD_2 ( ) ; } <START> if ( VAR_1 > VAR_4 ) { <END> throw new TYPE_1 ( STRING_1 ) ; } } | private void METHOD_1 ( ) throws TYPE_1 { int VAR_1 = 0 ; for ( TYPE_2 VAR_2 : VAR_3 ) { VAR_1 += VAR_2 . METHOD_2 ( ) ; } if ( VAR_1 > VAR_4 ) throw new TYPE_1 ( STRING_1 ) ; } |
VAR_3 API ( List VAR_1 ) private | <START> public static TYPE_1 METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 < TYPE_1 > VAR_2 ) <END> { List < TYPE_1 > VAR_3 = METHOD_2 ( VAR_1 ) . stream ( ) . filter ( VAR_2 ) . collect ( METHOD_3 ( ) ) ; return METHOD_4 ( VAR_3 ) ; } | private static TYPE_1 METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 < TYPE_1 > VAR_2 ) { List < TYPE_1 > VAR_3 = METHOD_2 ( VAR_1 ) . stream ( ) . filter ( VAR_2 ) . collect ( METHOD_3 ( ) ) ; return METHOD_4 ( VAR_3 ) ; } |
NPE : VAR_3 null super called I don t line necessary | public void METHOD_1 ( TYPE_1 parent ) { String name = METHOD_2 ( ) . METHOD_3 ( ) ; if ( name != null ) { name = TYPE_2 . METHOD_4 ( name ) ; } if ( name != null ) { VAR_1 . METHOD_5 ( name ) ; } VAR_2 = new TYPE_3 ( name ) ; <START> TYPE_4 VAR_3 = METHOD_6 ( ) ; <END> VAR_3 . METHOD_7 ( ) . METHOD_8 ( VAR_3 . METHOD_... | public void METHOD_1 ( TYPE_1 parent ) { String name = METHOD_2 ( ) . METHOD_3 ( ) ; if ( name != null ) { name = TYPE_2 . METHOD_4 ( name ) ; } if ( name != null ) { VAR_1 . METHOD_5 ( name ) ; } VAR_2 = new TYPE_3 ( name ) ; super . METHOD_1 ( parent ) ; TYPE_4 VAR_3 = METHOD_6 ( ) ; VAR_3 . METHOD_7 ( ) . METHOD_8 (... |
s change signature add a separate method | <START> public TYPE_1 METHOD_1 ( ) { <END> return VAR_1 ; } | public String METHOD_1 ( ) { return VAR_1 . toString ( ) ; } |
please s unnecessary write factory | public TYPE_1 METHOD_1 ( int i ) { <START> return METHOD_1 ( i , this . factory ) ; <END> } | public TYPE_1 METHOD_1 ( int i ) { return METHOD_1 ( i , factory ) ; } |
I presume want line gitattributes ? I need a single METHOD_3 lines : METHOD_3 ( STRING_8 [ [ ] ] bar\n + STRING_10 + ) ; | public void METHOD_1 ( ) throws Exception { METHOD_2 ( STRING_1 , STRING_2 , STRING_3 , STRING_4 , STRING_5 , STRING_6 , STRING_7 ) ; METHOD_3 ( STRING_8 , STRING_9 ) ; METHOD_3 ( STRING_8 , STRING_10 ) ; METHOD_3 ( STRING_8 , STRING_11 ) ; <START> METHOD_3 ( STRING_8 , STRING_12 ) ; <END> METHOD_4 ( ) ; } | public void METHOD_1 ( ) throws Exception { METHOD_2 ( STRING_1 , STRING_2 , STRING_3 , STRING_4 , STRING_5 , STRING_6 , STRING_7 ) ; METHOD_3 ( STRING_8 , STRING_9 + STRING_10 + STRING_11 + STRING_12 ) ; METHOD_4 ( ) ; } |
pass null parameter need mocking case | public void METHOD_1 ( ) { METHOD_2 ( VAR_1 . VAR_2 ) ; TYPE_1 VAR_3 = METHOD_3 ( TYPE_1 . class ) ; TYPE_2 VAR_4 = METHOD_3 ( TYPE_2 . class ) ; TYPE_3 VAR_5 = METHOD_3 ( TYPE_3 . class ) ; <START> VAR_1 . METHOD_4 ( VAR_3 , VAR_4 , VAR_5 ) ; <END> METHOD_2 ( VAR_1 . VAR_2 ) ; VAR_1 . METHOD_5 ( ) ; assertTrue ( VAR_1... | public void METHOD_1 ( ) { METHOD_2 ( VAR_1 . VAR_2 ) ; VAR_1 . METHOD_4 ( null , null , null ) ; METHOD_2 ( VAR_1 . VAR_2 ) ; VAR_1 . METHOD_5 ( ) ; assertTrue ( VAR_1 . VAR_2 ) ; } |
INT_1 | private static String METHOD_1 ( TYPE_1 VAR_1 , String VAR_2 ) { if ( VAR_1 . METHOD_2 ( ) . METHOD_3 ( ) ) { <START> StringBuilder VAR_3 = new StringBuilder ( VAR_2 . length ( ) + INT_1 ) ; <END> VAR_3 . append ( STRING_1 ) ; if ( ! VAR_2 . isEmpty ( ) && ! VAR_2 . startsWith ( STRING_2 ) ) { VAR_3 . append ( CHAR_1 )... | private static String METHOD_1 ( TYPE_1 VAR_1 , String VAR_2 ) { if ( VAR_1 . METHOD_2 ( ) . METHOD_3 ( ) ) { StringBuilder VAR_3 = new StringBuilder ( VAR_2 . length ( ) + 3 ) ; VAR_3 . append ( STRING_1 ) ; if ( ! VAR_2 . isEmpty ( ) && ! VAR_2 . startsWith ( STRING_2 ) ) { VAR_3 . append ( CHAR_1 ) ; } VAR_3 . appen... |
minor : don t need call METHOD_2 ( ) s a class member | public TYPE_1 METHOD_1 ( ) { TYPE_1 VAR_1 = new TYPE_1 ( ) ; <START> TYPE_2 VAR_2 = METHOD_2 ( ) ; <END> VAR_1 . put ( VAR_3 , VAR_2 . METHOD_3 ( ) + STRING_1 + VAR_2 . METHOD_4 ( ) ) ; VAR_1 . put ( VAR_4 , METHOD_5 ( ) . METHOD_6 ( ) ) ; VAR_1 . put ( VAR_5 , METHOD_7 ( ) ) ; VAR_1 . put ( VAR_6 , METHOD_8 ( ) ) ; re... | public TYPE_1 METHOD_1 ( ) { TYPE_1 VAR_1 = new TYPE_1 ( ) ; VAR_1 . put ( VAR_3 , VAR_2 . METHOD_3 ( ) + STRING_1 + VAR_2 . METHOD_4 ( ) ) ; VAR_1 . put ( VAR_4 , METHOD_5 ( ) . METHOD_6 ( ) ) ; VAR_1 . put ( VAR_5 , METHOD_7 ( ) ) ; VAR_1 . put ( VAR_6 , METHOD_8 ( ) ) ; return VAR_1 ; } |
doesn t work java 6 enhancements want * add * permissions file wan t remove | protected String METHOD_1 ( String value ) throws IOException { File VAR_1 = File . VAR_2 ( STRING_1 , STRING_2 ) ; String VAR_3 = VAR_1 . METHOD_2 ( ) ; VAR_1 . METHOD_3 ( true , true ) ; VAR_1 . METHOD_4 ( true , true ) ; <START> VAR_1 . METHOD_5 ( false ) ; <END> TYPE_1 out = new TYPE_1 ( new TYPE_2 ( VAR_1 ) ) ; ou... | protected String METHOD_1 ( String value ) throws IOException { File VAR_1 = File . VAR_2 ( STRING_1 , STRING_2 ) ; String VAR_3 = VAR_1 . METHOD_2 ( ) ; VAR_1 . METHOD_3 ( true , true ) ; VAR_1 . METHOD_4 ( true , true ) ; TYPE_1 out = new TYPE_1 ( new TYPE_2 ( VAR_1 ) ) ; out . write ( value ) ; out . close ( ) ; ret... |
avoid repeating 1 places | public void METHOD_1 ( ) throws Exception { <START> TYPE_1 VAR_1 = VAR_2 . METHOD_2 ( 1 ) ; <END> Assert . VAR_3 ( VAR_2 . METHOD_2 ( 1 ) . METHOD_3 ( ) ) ; VAR_2 . METHOD_4 ( VAR_1 , STRING_1 ) ; Assert . assertTrue ( VAR_2 . METHOD_2 ( 1 ) . METHOD_3 ( ) ) ; } | public void METHOD_1 ( ) throws Exception { TYPE_1 VAR_1 = VAR_2 . METHOD_2 ( 2 ) ; Assert . VAR_3 ( VAR_2 . METHOD_2 ( 2 ) . METHOD_3 ( ) ) ; VAR_2 . METHOD_4 ( VAR_1 , STRING_1 ) ; Assert . assertTrue ( VAR_2 . METHOD_2 ( 2 ) . METHOD_3 ( ) ) ; } |
remove ? OPENNLP - 922 changes style equals _CODE_ implementations | public boolean equals ( Object obj ) { if ( obj == null ) { return false ; } if ( getClass ( ) != obj . getClass ( ) ) { return false ; } final TYPE_1 < T > VAR_1 = ( TYPE_1 < T > ) obj ; <START> return TYPE_2 . equals ( this . VAR_2 , VAR_1 . VAR_2 ) && <END> this . VAR_3 == VAR_1 . VAR_3 && TYPE_2 . equals ( this . V... | public boolean equals ( Object obj ) { if ( obj == null ) { return false ; } if ( getClass ( ) != obj . getClass ( ) ) { return false ; } final TYPE_1 < T > VAR_1 = ( TYPE_1 < T > ) obj ; if ( ! TYPE_2 . equals ( this . VAR_2 , VAR_1 . VAR_2 ) ) { return false ; } return this . VAR_3 == VAR_1 . VAR_3 && TYPE_2 . equals... |
VAR_7 METHOD_5 ( ) returns TYPE_1 instanceof TYPE_1 a _CODE_ equals null I rid statements return VAR_7 METHOD_5 ( VAR_8 ) add a _CODE_ _CODE_ | private TYPE_1 METHOD_1 ( TYPE_2 session , TYPE_1 VAR_1 , TYPE_3 VAR_2 ) { Map < TYPE_4 < TYPE_1 > , Type > VAR_3 = METHOD_2 ( session , VAR_1 , VAR_2 ) ; TYPE_5 VAR_4 = TYPE_5 . METHOD_3 ( VAR_1 , metadata , session , VAR_3 ) ; Object value = VAR_4 . METHOD_4 ( TYPE_6 . VAR_6 ) ; <START> if ( value instanceof TYPE_1 )... | private TYPE_1 METHOD_1 ( TYPE_2 session , TYPE_1 VAR_1 , TYPE_3 VAR_2 ) { Map < TYPE_4 < TYPE_1 > , Type > VAR_3 = METHOD_2 ( session , VAR_1 , VAR_2 ) ; TYPE_5 VAR_4 = TYPE_5 . METHOD_3 ( VAR_1 , metadata , session , VAR_3 ) ; Object value = VAR_4 . METHOD_4 ( TYPE_6 . VAR_6 ) ; if ( value == null ) { value = false ;... |
incorrect case logger VAR_2 null a NPE | public boolean METHOD_1 ( String VAR_1 , Object data ) { TYPE_1 event = METHOD_2 ( VAR_1 , data ) ; TYPE_2 VAR_2 = TYPE_3 . METHOD_3 ( ) . METHOD_4 ( ) ; if ( VAR_2 == null && logger != null ) { logger . error ( TYPE_4 . bind ( TYPE_5 . VAR_4 , event . toString ( ) ) ) ; <START> return false ; <END> } VAR_2 . METHOD_5 ... | public boolean METHOD_1 ( String VAR_1 , Object data ) { TYPE_1 event = METHOD_2 ( VAR_1 , data ) ; TYPE_2 VAR_2 = TYPE_3 . METHOD_3 ( ) . METHOD_4 ( ) ; if ( VAR_2 == null ) { if ( logger != null ) { logger . error ( TYPE_4 . bind ( TYPE_5 . VAR_4 , event . toString ( ) ) ) ; } return false ; } VAR_2 . METHOD_5 ( even... |
expected ( 1 ) parameter assertEquals | public void METHOD_1 ( ) { final TYPE_1 VAR_1 = new TYPE_1 ( ) ; VAR_1 . METHOD_2 ( ) . METHOD_3 ( true ) ; VAR_1 . METHOD_4 ( STRING_1 ) ; VAR_1 . METHOD_5 ( ) ; assertEquals ( STRING_2 , VAR_1 . METHOD_6 ( ) . METHOD_7 ( new TYPE_2 < TYPE_3 > ( ) { @Override public boolean METHOD_8 ( final TYPE_3 element ) { return e... | public void METHOD_1 ( ) { final TYPE_1 VAR_1 = new TYPE_1 ( ) ; VAR_1 . METHOD_2 ( ) . METHOD_3 ( true ) ; VAR_1 . METHOD_4 ( STRING_1 ) ; VAR_1 . METHOD_5 ( ) ; assertEquals ( STRING_2 , 1 , VAR_1 . METHOD_6 ( ) . METHOD_7 ( new TYPE_2 < TYPE_3 > ( ) { @Override public boolean METHOD_8 ( final TYPE_3 element ) { retu... |
! [ redundantarraycreation ] ( ) | public TYPE_1 METHOD_1 ( ) { TYPE_1 VAR_1 = new TYPE_1 ( ) ; <START> VAR_1 . METHOD_2 ( Arrays . asList ( new TYPE_2 [ ] { METHOD_3 ( ) , METHOD_4 ( ) } ) ) ; <END> VAR_1 . METHOD_5 ( METHOD_6 ( ) ) ; return VAR_1 ; } | public TYPE_1 METHOD_1 ( ) { TYPE_1 VAR_1 = new TYPE_1 ( ) ; VAR_1 . METHOD_2 ( Arrays . asList ( METHOD_3 ( ) , METHOD_4 ( ) ) ) ; VAR_1 . METHOD_5 ( METHOD_6 ( ) ) ; return VAR_1 ; } |
package protected | <START> protected List < TYPE_1 > METHOD_1 ( TYPE_2 . Type type , List < TYPE_1 . TYPE_4 > VAR_1 ) { <END> TYPE_1 VAR_2 = new TYPE_1 ( VAR_3 , type , VAR_4 , VAR_1 ) ; List < TYPE_1 > VAR_5 = new ArrayList < TYPE_1 > ( 1 ) ; VAR_5 . add ( VAR_2 ) ; return VAR_5 ; } | List < TYPE_1 > METHOD_1 ( TYPE_2 . Type type , List < TYPE_1 . TYPE_4 > VAR_1 ) { TYPE_1 VAR_2 = new TYPE_1 ( VAR_3 , type , VAR_4 , VAR_1 ) ; List < TYPE_1 > VAR_5 = new ArrayList < TYPE_1 > ( 1 ) ; VAR_5 . add ( VAR_2 ) ; return VAR_5 ; } |
static | <START> private TYPE_1 METHOD_1 ( ) { <END> TYPE_1 VAR_1 = new TYPE_1 ( ) ; VAR_1 . METHOD_2 ( STRING_1 ) ; VAR_1 . METHOD_3 ( TYPE_2 . VAR_3 ) ; VAR_1 . METHOD_4 ( new Guid ( ) ) ; VAR_1 . METHOD_5 ( STRING_2 ) ; VAR_1 . METHOD_6 ( INT_1 ) ; return VAR_1 ; } | private static TYPE_1 METHOD_1 ( ) { TYPE_1 VAR_1 = new TYPE_1 ( ) ; VAR_1 . METHOD_2 ( STRING_1 ) ; VAR_1 . METHOD_3 ( TYPE_2 . VAR_3 ) ; VAR_1 . METHOD_4 ( new Guid ( ) ) ; VAR_1 . METHOD_5 ( STRING_2 ) ; VAR_1 . METHOD_6 ( INT_1 ) ; return VAR_1 ; } |
handle VAR_6 ? decltype ( auto ) METHOD_2 ( ) null | private static TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { TYPE_3 VAR_2 = VAR_1 . METHOD_2 ( ) ; if ( VAR_2 == null ) { return null ; } int VAR_3 = VAR_1 . getType ( ) ; <START> if ( VAR_3 == TYPE_4 . VAR_5 || VAR_3 == TYPE_4 . VAR_6 ) { <END> return METHOD_1 ( VAR_2 ) ; } return VAR_2 . METHOD_3 ( ) ; } | private static TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { TYPE_3 VAR_2 = VAR_1 . METHOD_2 ( ) ; if ( VAR_2 == null ) { return null ; } int VAR_3 = VAR_1 . getType ( ) ; if ( VAR_3 == TYPE_4 . VAR_5 ) { return METHOD_1 ( VAR_2 ) ; } return VAR_2 . METHOD_3 ( ) ; } |
I underscore a dash | public TYPE_1 METHOD_1 ( ) { <START> if ( VAR_1 . get ( STRING_1 ) != null ) { <END> return ( TYPE_1 ) VAR_1 . get ( STRING_2 ) ; } else { return 2 ; } } | public TYPE_1 METHOD_1 ( ) { if ( VAR_1 . get ( STRING_2 ) != null ) { return ( TYPE_1 ) VAR_1 . get ( STRING_2 ) ; } else { return 2 ; } } |
change INFO level | public void start ( ) { if ( VAR_1 . METHOD_1 ( false , true ) ) { METHOD_2 ( ) ; VAR_2 = Utils . VAR_3 ( 1 , false ) ; VAR_2 . METHOD_3 ( new TYPE_1 ( ) , 0 , config . VAR_4 , TimeUnit . VAR_5 ) ; <START> logger . trace ( STRING_1 ) ; <END> } } | public void start ( ) { if ( VAR_1 . METHOD_1 ( false , true ) ) { METHOD_2 ( ) ; VAR_2 = Utils . VAR_3 ( 1 , false ) ; VAR_2 . METHOD_3 ( new TYPE_1 ( ) , 0 , config . VAR_4 , TimeUnit . VAR_5 ) ; logger . info ( STRING_1 ) ; } } |
point reason wouldn t throw exception return error client | public String METHOD_1 ( ANNOTATION_1 ( STRING_1 ) final String id , final TYPE_1 request ) { String VAR_1 ; try { VAR_1 = TYPE_2 . METHOD_2 ( id , STRING_2 ) ; } catch ( TYPE_3 e ) { log . warn ( STRING_3 , id , e ) ; <START> VAR_1 = id ; <END> } final String path = STRING_4 + VAR_1 + STRING_5 + TYPE_4 . METHOD_3 ( re... | public String METHOD_1 ( ANNOTATION_1 ( STRING_1 ) final String id , final TYPE_1 request ) throws TYPE_3 { final String VAR_1 = TYPE_2 . METHOD_2 ( id , STRING_2 ) ; final String path = STRING_4 + VAR_1 + STRING_5 + TYPE_4 . METHOD_3 ( request ) ; return STRING_6 + path ; } |
a - integer ? a set host ? more accurate save qos parameters _CODE_ doubles saving integer bits displaying user mb I don t understand benefit sending / receiving bits doubles api vdsm | private Integer METHOD_1 ( Map < String , Object > entry , String VAR_1 , int VAR_2 ) { Map < String , Double > parameters = ( Map < String , Double > ) entry . get ( VAR_1 ) ; if ( parameters == null ) { return null ; } Double VAR_3 = parameters . get ( TYPE_1 . VAR_5 ) ; <START> return ( VAR_3 == null ) ? null : ( in... | private Integer METHOD_1 ( Map < String , Object > entry , String VAR_1 , int VAR_2 ) { Map < String , Integer > parameters = ( Map < String , Integer > ) entry . get ( VAR_1 ) ; if ( parameters == null ) { return null ; } Integer VAR_3 = parameters . get ( TYPE_1 . VAR_5 ) ; return ( VAR_3 == null ) ? null : ( VAR_3 /... |
else block replaced listener VAR_3 ( ) ; | public TYPE_1 < TYPE_2 > METHOD_1 ( final TYPE_3 < TYPE_2 > listener ) { VAR_1 . METHOD_2 ( ( value , VAR_2 ) - > { <START> if ( VAR_2 == null ) { <END> listener . VAR_3 ( this ) ; } else { listener . VAR_3 ( this ) ; } } ) ; return this ; } | public TYPE_1 < TYPE_2 > METHOD_1 ( final TYPE_3 < TYPE_2 > listener ) { VAR_1 . METHOD_2 ( ( value , VAR_2 ) - > { listener . VAR_3 ( this ) ; } ) ; return this ; } |
throw error | public TYPE_1 < T > METHOD_1 ( TYPE_2 VAR_1 , TYPE_3 VAR_2 , List < TYPE_1 < T > > VAR_3 ) { if ( ! METHOD_2 ( VAR_1 ) ) { return METHOD_3 ( VAR_2 ) ; } try { return new TYPE_1 < > ( Optional . of ( ( T ) VAR_4 . get ( VAR_1 ) . METHOD_4 ( VAR_3 ) ) , VAR_2 , VAR_3 ) ; } <START> catch ( Throwable t ) { <END> return MET... | public TYPE_1 < T > METHOD_1 ( TYPE_2 VAR_1 , TYPE_3 VAR_2 , List < TYPE_1 < T > > VAR_3 ) throws Throwable { if ( ! VAR_4 . containsKey ( VAR_1 ) ) { return new TYPE_1 < > ( Optional . empty ( ) , VAR_2 , VAR_3 ) ; } return new TYPE_1 < > ( Optional . of ( ( T ) VAR_4 . get ( VAR_1 ) . METHOD_4 ( VAR_3 ) ) , VAR_2 , V... |
true rid variable | public void METHOD_1 ( ) { Guid VAR_1 = METHOD_2 ( ) ; if ( VAR_1 == null ) { METHOD_1 ( false , false , null ) ; } else { TYPE_1 . getInstance ( ) . METHOD_3 ( new TYPE_2 < > ( cluster - > { if ( cluster != null ) { <START> METHOD_1 ( true , cluster . VAR_2 ( ) , VAR_1 ) ; <END> } } ) , VAR_1 ) ; } } | public void METHOD_1 ( ) { Guid VAR_1 = METHOD_2 ( ) ; if ( VAR_1 == null ) { METHOD_1 ( false , null ) ; } else { TYPE_1 . getInstance ( ) . METHOD_3 ( new TYPE_2 < > ( cluster - > { if ( cluster != null ) { METHOD_1 ( cluster . VAR_2 ( ) , VAR_1 ) ; } } ) , VAR_1 ) ; } } |
METHOD_1 ( VAR_2 | public TYPE_3 ( final String name , final TYPE_1 VAR_2 ) { METHOD_1 ( name , STRING_1 ) ; <START> METHOD_1 ( name , STRING_2 ) ; <END> this . VAR_3 = new TYPE_2 ( name , VAR_2 ) ; } | public TYPE_3 ( final String name , final TYPE_1 VAR_2 ) { METHOD_1 ( name , STRING_1 ) ; METHOD_1 ( VAR_2 , STRING_2 ) ; this . VAR_3 = new TYPE_2 ( name , VAR_2 ) ; } |
add a null check selected VAR_1 installed yielding a null menu item | private void METHOD_1 ( TYPE_1 request ) { TYPE_2 VAR_1 = TYPE_3 . METHOD_2 ( METHOD_3 ( ) ) ; TYPE_4 VAR_2 = TYPE_4 . METHOD_4 ( VAR_1 . METHOD_5 ( ) , VAR_1 . getKey ( ) ) ; <START> if ( ! VAR_2 . METHOD_6 ( ) ) { <END> throw TYPE_5 . METHOD_7 ( ) ; } TYPE_6 . METHOD_8 ( request , VAR_2 ) ; } | private void METHOD_1 ( TYPE_1 request ) { TYPE_2 VAR_1 = TYPE_3 . METHOD_2 ( METHOD_3 ( ) ) ; TYPE_4 VAR_2 = TYPE_4 . METHOD_4 ( VAR_1 . METHOD_5 ( ) , VAR_1 . getKey ( ) ) ; if ( VAR_2 == null || ! VAR_2 . METHOD_6 ( ) ) { throw TYPE_5 . METHOD_7 ( ) ; } TYPE_6 . METHOD_8 ( request , VAR_2 ) ; } |
String valueOf | private void METHOD_1 ( TYPE_1 VAR_1 , String url , long VAR_2 ) { TYPE_2 VAR_3 = VAR_4 . VAR_3 ; TYPE_3 . Log log = VAR_4 . log ; if ( VAR_3 . log ( ) ) { log . log ( String . format ( STRING_1 , VAR_1 . VAR_5 , url , VAR_2 ) ) ; if ( VAR_3 . METHOD_2 ( ) >= TYPE_2 . TYPE_5 . METHOD_2 ( ) ) { <START> log . log ( VAR_1... | private void METHOD_1 ( TYPE_1 VAR_1 , String url , long VAR_2 ) { TYPE_2 VAR_3 = VAR_4 . VAR_3 ; TYPE_3 . Log log = VAR_4 . log ; if ( VAR_3 . log ( ) ) { log . log ( String . format ( STRING_1 , VAR_1 . VAR_5 , url , VAR_2 ) ) ; if ( VAR_3 . METHOD_2 ( ) >= TYPE_2 . TYPE_5 . METHOD_2 ( ) ) { log . log ( String . valu... |
context | public void METHOD_1 ( final TYPE_1 context ) { if ( context . VAR_1 ( ) ) { return ; } TYPE_2 . METHOD_2 ( ) . METHOD_3 ( new TYPE_3 ( ) { @Override public void run ( ) { <START> synchronized ( context . VAR_2 ( ) ) { <END> if ( ! context . VAR_1 ( ) ) { context . VAR_3 ( ) ; context . VAR_4 ( ) . METHOD_4 ( ) ; conte... | public void METHOD_1 ( final TYPE_1 context ) { if ( context . VAR_1 ( ) ) { return ; } TYPE_2 . METHOD_2 ( ) . METHOD_3 ( new TYPE_3 ( ) { @Override public void run ( ) { synchronized ( context ) { if ( ! context . VAR_1 ( ) ) { context . VAR_3 ( ) ; context . VAR_4 ( ) . METHOD_4 ( ) ; context . VAR_5 ( ) ; } } } } )... |
reads a bit strange fall METHOD_3 request doesn t need coordinator clearer a slight restructure : _CODE_ METHOD_4 ( VAR_1 ) ; ( VAR_1 METHOD_2 ( ) ) { VAR_5 METHOD_3 ( VAR_1 ) ; } else { / / - coordinator requests VAR_2 prevent a tight loop node availabletime VAR_2 ( VAR_3 ) ; metadata VAR_4 ( ) ; } | private void METHOD_1 ( TYPE_2 . TYPE_3 VAR_1 ) { if ( ! VAR_1 . METHOD_2 ( ) ) { time . VAR_2 ( VAR_3 ) ; metadata . VAR_4 ( ) ; } <START> VAR_5 . METHOD_3 ( VAR_1 ) ; <END> VAR_5 . METHOD_4 ( VAR_1 ) ; } | private void METHOD_1 ( TYPE_2 . TYPE_3 VAR_1 ) { if ( VAR_1 . METHOD_2 ( ) ) { VAR_5 . METHOD_3 ( VAR_1 ) ; } else { time . VAR_2 ( VAR_3 ) ; metadata . VAR_4 ( ) ; } VAR_5 . METHOD_4 ( VAR_1 ) ; } |
( spelling ) I guess a reason t _CODE_ oppossed METHOD_5 ? semantics | public void METHOD_1 ( ) throws Exception { TYPE_1 client = new TYPE_1 ( VAR_1 . location ( ) ) ; assertNotNull ( client . VAR_2 ( ) ) ; METHOD_2 ( client . VAR_2 ( ) . METHOD_3 ( ) ) ; TYPE_2 version = client . VAR_3 ( new TYPE_3 ( ) ) ; assertTrue ( STRING_1 + VAR_1 . METHOD_4 ( ) + STRING_2 + version . toString ( ) ... | public void METHOD_1 ( ) throws Exception { TYPE_1 client = new TYPE_1 ( VAR_1 . location ( ) ) ; assertNotNull ( client . VAR_2 ( ) ) ; METHOD_2 ( client . VAR_2 ( ) . METHOD_3 ( ) ) ; TYPE_2 version = client . VAR_3 ( new TYPE_3 ( ) ) ; assertEquals ( STRING_1 + VAR_1 . METHOD_4 ( ) + STRING_2 + version . toString ( ... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.