ReviewComments stringlengths 1 2.35k | OriginalCode stringlengths 28 487 | ReviewedCode stringlengths 14 463 |
|---|---|---|
exception constructors - static classes setters key word isn t needed | private String METHOD_1 ( ) { <START> return String . VAR_1 ( STRING_1 , this . VAR_2 ) ; <END> } | private String METHOD_1 ( ) { return String . VAR_1 ( STRING_1 , VAR_2 ) ; } |
suggestion | public void METHOD_1 ( ) { TYPE_1 VAR_1 = new TYPE_1 ( STRING_1 ) ; TYPE_2 VAR_2 = new TYPE_2 ( METHOD_2 ( ) , VAR_3 , VAR_1 ) ; TYPE_3 VAR_4 = TYPE_4 . METHOD_3 ( TYPE_3 . class ) ; VAR_2 . METHOD_4 ( VAR_4 ) ; <START> VAR_2 . METHOD_5 ( VAR_5 ) ; <END> METHOD_6 ( VAR_4 ) . METHOD_7 ( true ) ; } | public void METHOD_1 ( ) { TYPE_1 VAR_1 = new TYPE_1 ( STRING_1 ) ; TYPE_2 VAR_2 = new TYPE_2 ( METHOD_2 ( ) , VAR_3 , VAR_1 ) ; TYPE_3 VAR_4 = TYPE_4 . METHOD_3 ( TYPE_3 . class ) ; VAR_2 . METHOD_4 ( VAR_4 ) ; METHOD_6 ( VAR_4 ) . METHOD_7 ( true ) ; } |
[ _CODE_ ] ( ) I VAR_5 treated VAR_2 return a zero exit status | public byte METHOD_1 ( boolean VAR_1 ) { byte result = INT_1 ; <START> if ( ! VAR_2 . isEmpty ( ) || ( VAR_1 && ( ! VAR_3 . isEmpty ( ) || ! VAR_4 . isEmpty ( ) || ! VAR_5 . isEmpty ( ) ) ) ) { <END> result |= VAR_6 ; } return result ; } | public byte METHOD_1 ( boolean VAR_1 ) { byte result = INT_1 ; if ( ! VAR_2 . isEmpty ( ) || ! VAR_5 . isEmpty ( ) || ( VAR_1 && ( ! VAR_3 . isEmpty ( ) || ! VAR_4 . isEmpty ( ) ) ) ) { result |= VAR_6 ; } return result ; } |
a matter taste I : ( VAR_2 = = null ) { VAR_3 put ( VAR_1 METHOD_2 ( ) VAR_1 ) ; } else ( ! METHOD_3 ( VAR_2 VAR_1 ) ) { throw new TYPE_2 ( VAR_2 VAR_1 ) ; } a method named METHOD_1 ( VAR_2 = = null || METHOD_3 ( VAR_2 VAR_1 ) ) triggered a add VAR_1 cases put overwrites VAR_2 step definition new | public void METHOD_1 ( TYPE_1 VAR_1 ) { TYPE_1 VAR_2 = VAR_3 . get ( VAR_1 . METHOD_2 ( ) ) ; <START> if ( VAR_2 == null || METHOD_3 ( VAR_2 , VAR_1 ) ) { <END> VAR_3 . put ( VAR_1 . METHOD_2 ( ) , VAR_1 ) ; } else { throw new TYPE_2 ( VAR_2 , VAR_1 ) ; } } | public void METHOD_1 ( TYPE_1 VAR_1 ) { TYPE_1 VAR_2 = VAR_3 . get ( VAR_1 . METHOD_2 ( ) ) ; if ( VAR_2 == null ) { VAR_3 . put ( VAR_1 . METHOD_2 ( ) , VAR_1 ) ; } else if ( ! METHOD_3 ( VAR_2 , VAR_1 ) ) { throw new TYPE_2 ( VAR_2 , VAR_1 ) ; } } |
don t ask remove METHOD_2 ( ) add a TYPE_4 METHOD_1 ( ) method instead | private void METHOD_1 ( TYPE_2 . TYPE_3 . TYPE_4 VAR_2 ) { <START> VAR_2 . METHOD_2 ( ) . METHOD_1 ( out ) ; <END> } | private void METHOD_1 ( TYPE_2 . TYPE_3 . TYPE_4 VAR_2 ) { VAR_2 . METHOD_1 ( out ) ; } |
keft | public void VAR_1 ( ) { TYPE_4 VAR_3 = new TYPE_4 ( TYPE_3 < TYPE_1 > VAR_6 ( ) , STRING_1 , STRING_2 , 0 , null , null ) ; String VAR_7 = new TYPE_2 ( new TYPE_5 ( ) ) . VAR_10 ( VAR_3 ) ; String VAR_11 = "" + STRING_3 + <START> < < < < < < < VAR_12 <END> STRING_4 ; assertEquals ( VAR_11 , VAR_7 ) ; } | public void VAR_1 ( ) { TYPE_4 VAR_3 = new TYPE_4 ( TYPE_3 < TYPE_1 > VAR_6 ( ) , STRING_1 , STRING_2 , 0 , null , null ) ; String VAR_7 = new TYPE_2 ( new TYPE_5 ( ) ) . VAR_10 ( VAR_3 ) ; String VAR_11 = "" + STRING_3 + STRING_4 ; assertEquals ( VAR_11 , VAR_7 ) ; } |
turn a positive check / guard clause sojavaif ( VAR_1 isEmpty ( ) ) { return false ; } removes level nesting easier read reader s immediately VAR_1 empty return | private final boolean METHOD_1 ( TYPE_1 VAR_1 ) { boolean result = false ; <START> if ( ! VAR_1 . isEmpty ( ) ) { <END> TYPE_2 VAR_2 = VAR_1 . get ( 0 ) ; try { new TYPE_3 ( TYPE_5 . VAR_4 ) . parse ( VAR_2 . METHOD_2 ( STRING_1 ) ) ; } catch ( TYPE_4 ex ) { result = true ; } } return result ; } | private final boolean METHOD_1 ( TYPE_1 VAR_1 ) { boolean result = false ; if ( VAR_1 . isEmpty ( ) ) { return result ; } TYPE_2 VAR_2 = VAR_1 . get ( 0 ) ; try { new TYPE_3 ( TYPE_5 . VAR_4 ) . parse ( VAR_2 . METHOD_2 ( STRING_1 ) ) ; } catch ( TYPE_4 ex ) { result = true ; } return result ; } |
move boilerplate _CODE_ request ; TYPE_2 VAR_5 ; class fields andjavarequest = new TYPE_1 ( ) ; VAR_5 METHOD_2 ( request ) ; _CODE_ method tests cleaner diferences request VAR_1 ( ) | public void METHOD_1 ( ) throws Exception { TYPE_1 request = new TYPE_1 ( ) ; request . VAR_1 ( TYPE_6 . VAR_3 , VAR_4 ) ; TYPE_2 VAR_5 = new TYPE_2 ( ) ; <START> VAR_5 . METHOD_2 ( request ) ; <END> when ( VAR_6 . METHOD_3 ( METHOD_4 ( TYPE_3 . class ) ) ) . METHOD_5 ( VAR_7 ) ; TYPE_4 VAR_8 = VAR_9 . METHOD_6 ( VAR_5... | public void METHOD_1 ( ) throws Exception { request . VAR_1 ( TYPE_6 . VAR_3 , VAR_4 ) ; when ( VAR_6 . METHOD_3 ( METHOD_4 ( TYPE_3 . class ) ) ) . METHOD_5 ( VAR_7 ) ; TYPE_4 VAR_8 = VAR_9 . METHOD_6 ( VAR_5 ) ; assertThat ( VAR_8 , is ( METHOD_7 ( TYPE_5 . class ) ) ) ; } |
done _CODE_ | public void METHOD_1 ( ) throws Exception { request . VAR_1 ( TYPE_3 . VAR_3 , VAR_4 ) ; <START> VAR_5 . METHOD_2 ( request ) ; <END> TYPE_1 VAR_6 = VAR_7 . METHOD_3 ( VAR_5 ) ; assertThat ( VAR_6 , is ( METHOD_4 ( TYPE_2 . class ) ) ) ; } | public void METHOD_1 ( ) throws Exception { request . VAR_1 ( TYPE_3 . VAR_3 , VAR_4 ) ; TYPE_1 VAR_6 = VAR_7 . METHOD_3 ( VAR_5 ) ; assertThat ( VAR_6 , is ( METHOD_4 ( TYPE_2 . class ) ) ) ; } |
assertThat ( ( ) ) | public void METHOD_1 ( ) throws Exception { String VAR_1 = STRING_1 ; VAR_2 = new TYPE_1 . Builder ( ) . METHOD_2 ( VAR_1 ) . build ( ) ; <START> assertTrue ( VAR_2 . METHOD_3 ( ) <END> . equals ( VAR_1 ) ) ; METHOD_4 ( VAR_2 . METHOD_5 ( ) ) ; METHOD_6 ( VAR_2 . METHOD_7 ( ) ) ; METHOD_4 ( VAR_2 . METHOD_8 ( ) ) ; MET... | public void METHOD_1 ( ) throws Exception { String VAR_1 = STRING_1 ; VAR_2 = new TYPE_1 . Builder ( ) . METHOD_2 ( VAR_1 ) . build ( ) ; assertThat ( VAR_2 . METHOD_3 ( ) , is ( VAR_1 ) ) ; METHOD_4 ( VAR_2 . METHOD_5 ( ) ) ; METHOD_6 ( VAR_2 . METHOD_7 ( ) ) ; METHOD_4 ( VAR_2 . METHOD_8 ( ) ) ; METHOD_4 ( VAR_2 . ME... |
loop ? size 1 | public void METHOD_1 ( ) throws Exception { TYPE_1 VAR_1 = new TYPE_1 . Builder ( ) . METHOD_2 ( VAR_2 ) . build ( ) ; List < TYPE_2 > VAR_3 = VAR_4 . METHOD_3 ( VAR_1 ) ; assertThat ( VAR_3 . size ( ) , is ( 1 ) ) ; <START> for ( TYPE_2 VAR_5 : VAR_3 ) { <END> assertThat ( VAR_5 . METHOD_4 ( ) , is ( VAR_2 ) ) ; } } | public void METHOD_1 ( ) throws Exception { TYPE_1 VAR_1 = new TYPE_1 . Builder ( ) . METHOD_2 ( VAR_2 ) . build ( ) ; List < TYPE_2 > VAR_3 = VAR_4 . METHOD_3 ( VAR_1 ) ; assertThat ( VAR_3 . size ( ) , is ( 1 ) ) ; assertThat ( VAR_3 . get ( 0 ) . METHOD_4 ( ) , is ( VAR_2 ) ) ; } |
assertThat ( ( ) ) | public void METHOD_1 ( ) throws Exception { TYPE_1 format = new TYPE_2 ( STRING_1 ) ; Date VAR_1 = format . parse ( STRING_2 ) ; VAR_2 = new TYPE_3 . Builder ( ) . METHOD_2 ( VAR_1 ) . build ( ) ; <START> assertTrue ( VAR_2 . METHOD_3 ( ) <END> . equals ( VAR_1 ) ) ; METHOD_4 ( VAR_2 . METHOD_5 ( ) ) ; METHOD_6 ( VAR_2... | public void METHOD_1 ( ) throws Exception { TYPE_1 format = new TYPE_2 ( STRING_1 ) ; Date VAR_1 = format . parse ( STRING_2 ) ; VAR_2 = new TYPE_3 . Builder ( ) . METHOD_2 ( VAR_1 ) . build ( ) ; assertThat ( VAR_2 . METHOD_3 ( ) , is ( VAR_1 ) ) ; METHOD_4 ( VAR_2 . METHOD_5 ( ) ) ; METHOD_6 ( VAR_2 . METHOD_7 ( ) ) ... |
_CODE_ _CODE_ order object | private void METHOD_1 ( TYPE_1 description ) { description . VAR_1 ( STRING_1 ) ; description . VAR_1 ( STRING_2 , TYPE_2 . VAR_3 ) ; description . VAR_1 ( STRING_3 ) ; description . VAR_1 ( STRING_4 ) ; description . VAR_1 ( STRING_5 ) ; <START> description . VAR_1 ( STRING_6 , TYPE_2 . VAR_3 ) ; <END> description . V... | private void METHOD_1 ( TYPE_1 description ) { description . VAR_1 ( STRING_1 ) ; description . VAR_1 ( STRING_2 , TYPE_2 . VAR_3 ) ; description . VAR_1 ( STRING_3 ) ; description . VAR_1 ( STRING_6 , TYPE_2 . VAR_3 ) ; description . VAR_1 ( STRING_4 ) ; description . VAR_1 ( STRING_5 ) ; description . VAR_1 ( STRING_... |
remove assertion title identifier | public void METHOD_1 ( ) throws Exception { TYPE_1 VAR_1 = VAR_2 . METHOD_2 ( STRING_1 ) ; assertNotNull ( VAR_1 ) ; assertThat ( VAR_1 . METHOD_3 ( ) , is ( STRING_1 ) ) ; <START> assertThat ( VAR_1 . METHOD_4 ( ) , is ( STRING_2 ) ) ; <END> } | public void METHOD_1 ( ) throws Exception { TYPE_1 VAR_1 = VAR_2 . METHOD_2 ( STRING_1 ) ; assertNotNull ( VAR_1 ) ; assertThat ( VAR_1 . METHOD_3 ( ) , is ( STRING_1 ) ) ; } |
return a java File ? ensure exists VAR_3 writable return java file user method doesnt deal some | <START> public String METHOD_1 ( ) { <END> Path VAR_1 = TYPE_1 . get ( METHOD_2 ( TYPE_3 . VAR_3 , true ) ) ; if ( ! VAR_1 . METHOD_3 ( ) ) { VAR_1 = TYPE_1 . get ( TYPE_2 . METHOD_4 ( ) , VAR_1 . toString ( ) ) ; } if ( ! VAR_1 . METHOD_5 ( ) . exists ( ) ) { VAR_1 . METHOD_5 ( ) . METHOD_6 ( ) ; } return VAR_1 . toSt... | public File METHOD_1 ( ) { Path VAR_1 = TYPE_1 . get ( METHOD_2 ( TYPE_3 . VAR_3 , true ) ) ; if ( ! VAR_1 . METHOD_3 ( ) ) { VAR_1 = TYPE_1 . get ( TYPE_2 . METHOD_4 ( ) , VAR_1 . toString ( ) ) ; } if ( ! VAR_1 . METHOD_5 ( ) . exists ( ) ) { VAR_1 . METHOD_5 ( ) . METHOD_6 ( ) ; } return VAR_1 . METHOD_5 ( ) ; } |
final | public List < TYPE_1 > METHOD_1 ( List < TYPE_2 > VAR_1 ) { final TYPE_3 VAR_2 = METHOD_2 ( ) ; METHOD_3 ( VAR_2 , VAR_1 ) ; <START> List < TYPE_1 > result = ( List < TYPE_1 > ) VAR_2 . list ( ) ; <END> return result == null ? new ArrayList < TYPE_1 > ( ) : result ; } | public List < TYPE_1 > METHOD_1 ( List < TYPE_2 > VAR_1 ) { final TYPE_3 VAR_2 = METHOD_2 ( ) ; METHOD_3 ( VAR_2 , VAR_1 ) ; final List < TYPE_1 > result = ( List < TYPE_1 > ) VAR_2 . list ( ) ; return result == null ? new ArrayList < TYPE_1 > ( ) : result ; } |
inline null | public void METHOD_1 ( ) throws Exception { TYPE_1 VAR_1 = TYPE_1 . instance ( ) . METHOD_2 ( VAR_2 . METHOD_3 ( ) ) . METHOD_4 ( VAR_3 ) ; <START> TYPE_2 VAR_4 = null ; <END> VAR_5 . METHOD_5 ( IllegalArgumentException . VAR_6 ) ; VAR_5 . METHOD_6 ( STRING_1 ) ; VAR_7 . METHOD_7 ( VAR_4 , VAR_1 ) ; } | public void METHOD_1 ( ) throws Exception { TYPE_1 VAR_1 = TYPE_1 . instance ( ) . METHOD_2 ( VAR_2 . METHOD_3 ( ) ) . METHOD_4 ( VAR_3 ) ; VAR_5 . METHOD_5 ( IllegalArgumentException . VAR_6 ) ; VAR_5 . METHOD_6 ( STRING_1 ) ; VAR_7 . METHOD_7 ( null , VAR_1 ) ; } |
inline null | public void METHOD_1 ( ) throws Exception { TYPE_1 VAR_1 = null ; TYPE_2 VAR_2 = VAR_3 . METHOD_2 ( VAR_4 ) ; VAR_5 . METHOD_3 ( IllegalArgumentException . VAR_6 ) ; VAR_5 . METHOD_4 ( STRING_1 ) ; <START> VAR_7 . METHOD_5 ( VAR_2 , VAR_1 ) ; <END> } | public void METHOD_1 ( ) throws Exception { TYPE_2 VAR_2 = VAR_3 . METHOD_2 ( VAR_4 ) ; VAR_5 . METHOD_3 ( IllegalArgumentException . VAR_6 ) ; VAR_5 . METHOD_4 ( STRING_1 ) ; VAR_7 . METHOD_5 ( VAR_2 , null ) ; } |
shouldnt hardcoding URL | public String METHOD_1 ( TYPE_1 VAR_1 ) { if ( VAR_1 == null ) throw new IllegalArgumentException ( STRING_1 ) ; else if ( VAR_1 . METHOD_2 ( ) == null ) throw new IllegalArgumentException ( STRING_2 ) ; else { if ( this . VAR_2 == null ) <START> return STRING_3 + STRING_4 + VAR_1 . METHOD_2 ( ) ; <END> else return thi... | public String METHOD_1 ( TYPE_1 VAR_1 ) { if ( VAR_1 == null ) throw new IllegalArgumentException ( STRING_1 ) ; else if ( VAR_1 . METHOD_2 ( ) == null ) throw new IllegalArgumentException ( STRING_2 ) ; return VAR_2 . METHOD_1 ( ) + STRING_4 + VAR_1 . METHOD_2 ( ) ; } |
need throws Exception | <START> TYPE_1 METHOD_1 ( ) throws Exception { <END> TYPE_1 VAR_1 = new TYPE_1 ( ) ; VAR_1 . METHOD_2 ( 1 ) ; VAR_1 . METHOD_3 ( STRING_1 ) ; return VAR_1 ; } | TYPE_1 METHOD_1 ( ) { TYPE_1 VAR_1 = new TYPE_1 ( ) ; VAR_1 . METHOD_2 ( 1 ) ; VAR_1 . METHOD_3 ( STRING_1 ) ; return VAR_1 ; } |
catch block redundant exceptions caught logged METHOD_2 method | public void METHOD_1 ( ) { <START> try { <END> METHOD_2 ( ) ; } catch ( Exception e ) { } METHOD_3 ( ) ; } | public void METHOD_1 ( ) { METHOD_2 ( ) ; METHOD_3 ( ) ; } |
method synchronized | <START> public void METHOD_1 ( boolean VAR_1 ) { <END> VAR_2 = VAR_1 ; } | public synchronized void METHOD_1 ( boolean VAR_1 ) { VAR_2 = VAR_1 ; } |
lowercase boolean - primitive type | public void METHOD_1 ( TYPE_1 VAR_1 ) { super . METHOD_1 ( VAR_1 ) ; <START> Boolean VAR_2 = TYPE_2 . getInstance ( ) . METHOD_2 ( METHOD_3 ( ) ) ; <END> METHOD_4 ( true ) ; METHOD_5 ( TYPE_5 . VAR_4 , ( VAR_2 ? R . VAR_5 . TYPE_4 : R . VAR_5 . TYPE_3 ) ) ; } | public void METHOD_1 ( TYPE_1 VAR_1 ) { super . METHOD_1 ( VAR_1 ) ; boolean VAR_2 = TYPE_2 . getInstance ( ) . METHOD_2 ( METHOD_3 ( ) ) ; METHOD_4 ( true ) ; METHOD_5 ( TYPE_5 . VAR_4 , ( VAR_2 ? R . VAR_5 . TYPE_4 : R . VAR_5 . TYPE_3 ) ) ; } |
< table data - meta = generated_by_salesforcesdk > < tbody > < tr > < td > : warning : < / td > < td width = 100% data - sticky = false > < span < code > apply ( ) < / code > instead ; < code > commit < / code > writes data persistent storage immediately < code > apply < / code > handle background < / td > < / tr > < /... | public void METHOD_1 ( TYPE_1 VAR_1 , int VAR_2 , int VAR_3 ) { if ( VAR_1 == null ) { return ; } final Context context = TYPE_2 . getInstance ( ) . METHOD_2 ( ) ; final TYPE_3 VAR_4 = context . VAR_5 ( VAR_6 + VAR_1 . METHOD_3 ( ) , Context . VAR_7 ) ; final TYPE_4 e = VAR_4 . METHOD_4 ( ) ; e . VAR_8 ( VAR_9 , VAR_2 ... | public void METHOD_1 ( TYPE_1 VAR_1 , int VAR_2 , int VAR_3 ) { METHOD_1 ( VAR_1 , VAR_2 , VAR_3 , true ) ; } |
remove synchronized keyword method move method | <START> public static synchronized String METHOD_1 ( String name ) { <END> return METHOD_1 ( name , INT_1 ) ; } | public static String METHOD_1 ( String name ) { return METHOD_1 ( name , INT_1 ) ; } |
don t need a super METHOD_1 ( ) call | public void METHOD_1 ( ) throws Exception { <START> VAR_1 = null ; <END> } | public void METHOD_1 ( ) throws Exception { VAR_1 = null ; super . METHOD_1 ( ) ; } |
minor : change log line url correctly reflect URL loaded | private void METHOD_1 ( boolean VAR_1 ) { assert ! VAR_2 . METHOD_2 ( ) ; String VAR_3 = VAR_2 . METHOD_3 ( ) ; String url = VAR_3 ; if ( VAR_1 ) { url = METHOD_4 ( url , false ) ; } <START> TYPE_1 . i ( TAG , STRING_1 + VAR_3 ) ; <END> METHOD_5 ( url ) ; VAR_4 = true ; } | private void METHOD_1 ( boolean VAR_1 ) { assert ! VAR_2 . METHOD_2 ( ) ; String VAR_3 = VAR_2 . METHOD_3 ( ) ; String url = VAR_3 ; if ( VAR_1 ) { url = METHOD_4 ( url , false ) ; } TYPE_1 . i ( TAG , STRING_1 + url ) ; METHOD_5 ( url ) ; VAR_4 = true ; } |
app compiled smartstore / smartsync TYPE_1 instead set flag _CODE_ java getInstance | <START> public static TYPE_1 getInstance ( ) { <END> if ( VAR_1 != null ) { TYPE_2 . getInstance ( ) . METHOD_1 ( VAR_2 ) ; return ( TYPE_1 ) VAR_1 ; } else { throw new RuntimeException ( STRING_1 ) ; } } | public static TYPE_1 getInstance ( ) { if ( VAR_1 != null ) { return ( TYPE_1 ) VAR_1 ; } else { throw new RuntimeException ( STRING_1 ) ; } } |
a METHOD_1 method TYPE_4 _CODE_ | private void METHOD_1 ( TYPE_1 args , TYPE_2 VAR_1 ) throws TYPE_3 { <START> List < String > VAR_2 = TYPE_4 . getInstance ( ) . METHOD_2 ( ) ; <END> for ( String VAR_3 : VAR_2 ) { TYPE_4 . getInstance ( ) . METHOD_3 ( VAR_3 ) ; } TYPE_5 VAR_4 = new TYPE_5 ( TYPE_5 . Status . VAR_5 , true ) ; VAR_1 . METHOD_4 ( VAR_4 ) ... | private void METHOD_1 ( TYPE_1 args , TYPE_2 VAR_1 ) throws TYPE_3 { TYPE_4 . getInstance ( ) . METHOD_1 ( ) ; TYPE_5 VAR_4 = new TYPE_5 ( TYPE_5 . Status . VAR_5 , true ) ; VAR_1 . METHOD_4 ( VAR_4 ) ; } |
call method _CODE_ ( ) instead | <START> public List < String > METHOD_1 ( ) throws TYPE_1 { <END> TYPE_2 VAR_1 = METHOD_2 ( ) . METHOD_3 ( ) ; String VAR_2 = VAR_1 != null ? VAR_1 . METHOD_4 ( ) : null ; List < String > VAR_3 = TYPE_3 . METHOD_5 ( context , METHOD_2 ( ) . METHOD_3 ( ) , VAR_2 ) ; return VAR_3 ; } | public List < String > METHOD_1 ( ) { TYPE_2 VAR_1 = METHOD_2 ( ) . METHOD_3 ( ) ; String VAR_2 = VAR_1 != null ? VAR_1 . METHOD_4 ( ) : null ; List < String > VAR_3 = TYPE_3 . METHOD_5 ( context , METHOD_2 ( ) . METHOD_3 ( ) , VAR_2 ) ; return VAR_3 ; } |
static | <START> public boolean METHOD_1 ( Context context ) { <END> try { METHOD_2 ( context ) ; } catch ( TYPE_1 VAR_1 ) { return METHOD_3 ( context , VAR_2 , METHOD_4 ( ) ) ; } catch ( Exception ex ) { Log . e ( TAG , STRING_1 , ex ) ; return false ; } return true ; } | public static boolean METHOD_1 ( Context context ) { try { METHOD_2 ( context ) ; } catch ( TYPE_1 VAR_1 ) { return METHOD_3 ( context , VAR_2 , METHOD_4 ( ) ) ; } catch ( Exception ex ) { Log . e ( TAG , STRING_1 , ex ) ; return false ; } return true ; } |
static | <START> public void METHOD_1 ( Context context ) throws TYPE_1 { <END> TYPE_2 . METHOD_1 ( context ) ; } | public static void METHOD_1 ( Context context ) throws TYPE_1 { TYPE_2 . METHOD_1 ( context ) ; } |
static | <START> public boolean METHOD_1 ( File file ) { <END> return file . VAR_1 ( ) ; } | public static boolean METHOD_1 ( File file ) { return file . VAR_1 ( ) ; } |
static | <START> public String [ ] METHOD_1 ( ) { <END> if ( TYPE_1 . VAR_2 . VAR_3 >= TYPE_1 . VAR_4 . VAR_5 && TYPE_1 . VAR_6 . length > 0 ) { return TYPE_1 . VAR_6 ; } else { return new String [ ] { TYPE_1 . VAR_7 , TYPE_1 . VAR_8 } ; } } | public static String [ ] METHOD_1 ( ) { if ( TYPE_1 . VAR_2 . VAR_3 >= TYPE_1 . VAR_4 . VAR_5 && TYPE_1 . VAR_6 . length > 0 ) { return TYPE_1 . VAR_6 ; } else { return new String [ ] { TYPE_1 . VAR_7 , TYPE_1 . VAR_8 } ; } } |
static call s need instantiate util class time | protected void METHOD_1 ( Context context ) { <START> new TYPE_1 ( ) . METHOD_2 ( context ) ; <END> } | protected void METHOD_1 ( Context context ) { TYPE_1 . METHOD_2 ( context ) ; } |
remove throws Exception catching triggering METHOD_3 | <START> protected TYPE_1 METHOD_1 ( TYPE_2 options ) throws Exception { <END> try { return TYPE_3 . METHOD_2 ( TYPE_5 . VAR_2 , new TYPE_4 ( options . VAR_3 ) , options . VAR_4 ) ; } catch ( Exception e ) { METHOD_3 ( STRING_1 , e . VAR_5 ( ) ) ; VAR_6 . METHOD_4 ( ) ; } return null ; } | protected TYPE_1 METHOD_1 ( TYPE_2 options ) { try { return TYPE_3 . METHOD_2 ( TYPE_5 . VAR_2 , new TYPE_4 ( options . VAR_3 ) , options . VAR_4 ) ; } catch ( Exception e ) { METHOD_3 ( STRING_1 , e . VAR_5 ( ) ) ; VAR_6 . METHOD_4 ( ) ; } return null ; } |
I don t muck part | public TYPE_1 METHOD_1 ( ) { <START> VAR_1 . METHOD_2 ( VAR_2 , VAR_3 ) ; <END> return VAR_1 ; } | public TYPE_1 METHOD_1 ( ) { return VAR_1 ; } |
return | public static TYPE_1 METHOD_1 ( TYPE_2 VAR_1 , TYPE_3 VAR_2 , String VAR_3 ) throws IOException , TYPE_4 , TYPE_5 { TYPE_6 . Builder VAR_4 = new TYPE_6 . Builder ( ) . add ( VAR_5 , VAR_6 ) . add ( VAR_7 , VAR_3 ) ; TYPE_1 VAR_8 = METHOD_2 ( VAR_1 , VAR_2 , VAR_4 ) ; <START> return VAR_8 ; <END> } | public static TYPE_1 METHOD_1 ( TYPE_2 VAR_1 , TYPE_3 VAR_2 , String VAR_3 ) throws IOException , TYPE_4 , TYPE_5 { TYPE_6 . Builder VAR_4 = new TYPE_6 . Builder ( ) . add ( VAR_5 , VAR_6 ) . add ( VAR_7 , VAR_3 ) ; return METHOD_2 ( VAR_1 , VAR_2 , VAR_4 ) ; } |
I don t enforce java 7 a minimum java 6 syntax | public void METHOD_1 ( ) throws Exception { final TYPE_1 response = METHOD_2 ( ) ; <START> try ( TYPE_2 in = response . VAR_1 ( ) ) { <END> METHOD_3 ( in ) ; } catch ( IOException e ) { METHOD_4 ( STRING_1 ) ; } catch ( TYPE_3 e ) { METHOD_4 ( STRING_2 ) ; } finally { response . VAR_2 ( ) ; } } | public void METHOD_1 ( ) throws Exception { final TYPE_1 response = METHOD_2 ( ) ; try { TYPE_2 in = response . VAR_1 ( ) ; METHOD_3 ( in ) ; } catch ( IOException e ) { METHOD_4 ( STRING_1 ) ; } catch ( TYPE_3 e ) { METHOD_4 ( STRING_2 ) ; } finally { response . VAR_2 ( ) ; } } |
missing semi - colon compilation error ? ; - ) | public void VAR_1 ( ) throws Exception { final TYPE_1 response = VAR_3 ( ) ; try { <START> TYPE_2 in = response . VAR_5 ( ) <END> VAR_6 ( in ) ; } catch ( IOException e ) { VAR_7 ( STRING_1 ) ; } final TYPE_1 VAR_8 = VAR_3 ( ) ; assertNotNull ( VAR_8 ) ; } | public void VAR_1 ( ) throws Exception { final TYPE_1 response = VAR_3 ( ) ; try { TYPE_2 in = response . VAR_5 ( ) ; VAR_6 ( in ) ; } catch ( IOException e ) { VAR_7 ( STRING_1 ) ; } final TYPE_1 VAR_8 = VAR_3 ( ) ; assertNotNull ( VAR_8 ) ; } |
don t need METHOD_3 ( ) a null check | public TYPE_1 METHOD_1 ( ) { final TYPE_2 VAR_1 = METHOD_2 ( ) ; <START> return VAR_1 == null ? null : METHOD_3 ( VAR_1 ) ; <END> } | public TYPE_1 METHOD_1 ( ) { return METHOD_3 ( METHOD_2 ( ) ) ; } |
log exception : Log e ( STRING_1 STRING_2 e ) ; | public String toString ( ) { try { return METHOD_1 ( ) ; } catch ( Exception e ) { <START> Log . e ( STRING_1 , STRING_2 ) ; <END> return ( ( response == null ) ? "" : response . toString ( ) ) ; } } | public String toString ( ) { try { return METHOD_1 ( ) ; } catch ( Exception e ) { Log . e ( STRING_1 , STRING_2 , e ) ; return ( ( response == null ) ? "" : response . toString ( ) ) ; } } |
want move call _CODE_ ( ) reason fast user switching account switch occurs activity ll stuck a handle _CODE_ ( variable VAR_4 won t updated ) | protected void METHOD_1 ( TYPE_1 VAR_1 ) { super . METHOD_1 ( VAR_1 ) ; METHOD_2 ( R . VAR_2 . VAR_3 ) ; <START> VAR_4 = TYPE_2 . getInstance ( ) <END> . METHOD_3 ( ) ; VAR_5 = ( TYPE_3 ) METHOD_4 ( R . id . VAR_6 ) ; VAR_7 = ( TYPE_4 ) METHOD_4 ( R . id . VAR_8 ) ; VAR_9 = ( TYPE_4 ) METHOD_4 ( R . id . VAR_10 ) ; VAR... | protected void METHOD_1 ( TYPE_1 VAR_1 ) { super . METHOD_1 ( VAR_1 ) ; METHOD_2 ( R . VAR_2 . VAR_3 ) ; VAR_5 = ( TYPE_3 ) METHOD_4 ( R . id . VAR_6 ) ; VAR_7 = ( TYPE_4 ) METHOD_4 ( R . id . VAR_8 ) ; VAR_9 = ( TYPE_4 ) METHOD_4 ( R . id . VAR_10 ) ; VAR_11 = ( TYPE_5 ) METHOD_4 ( R . id . VAR_12 ) ; } |
reason instanceof check add METHOD_1 | public TYPE_1 METHOD_1 ( TYPE_1 VAR_1 ) { <START> return new TYPE_2 ( this . val - ( ( TYPE_2 ) VAR_1 ) . val ) ; <END> } | public TYPE_1 METHOD_1 ( TYPE_1 VAR_1 ) { if ( ! ( VAR_1 instanceof TYPE_2 ) ) { throw new RuntimeException ( ) ; } return new TYPE_2 ( this . val - ( ( TYPE_2 ) VAR_1 ) . val ) ; } |
a hard time return METHOD_4 ( VAR_1 METHOD_2 ( VAR_1 METHOD_3 ( ) - 1 ) ? I m dense I t understand reason _CODE_ / _CODE_ / METHOD_5 code | public static TYPE_1 METHOD_1 ( TYPE_1 VAR_1 ) { TYPE_1 VAR_2 = VAR_1 . METHOD_2 ( VAR_1 . METHOD_3 ( ) - 1 ) ; return METHOD_4 ( VAR_1 ) . METHOD_5 ( VAR_2 . METHOD_6 ( ) ) . METHOD_7 ( VAR_2 . METHOD_8 ( ) ) <START> . METHOD_9 ( VAR_2 . METHOD_10 ( ) ) ; <END> } | public static TYPE_1 METHOD_1 ( TYPE_1 VAR_1 ) { return METHOD_4 ( VAR_1 . METHOD_2 ( VAR_1 . METHOD_3 ( ) - 1 ) ) ; } |
pass enum work | public static void METHOD_1 ( Context ctx , TYPE_1 request ) { TYPE_2 i = TYPE_3 . METHOD_2 ( ctx , TYPE_4 . class ) ; i . VAR_1 ( TYPE_4 . VAR_2 , request . VAR_3 ( ) ) ; <START> i . VAR_1 ( TYPE_4 . VAR_4 , request . VAR_5 ( ) . toString ( ) ) ; <END> ctx . VAR_6 ( i ) ; TYPE_3 . METHOD_3 ( ( TYPE_5 ) ctx ) ; } | public static void METHOD_1 ( Context ctx , TYPE_1 request ) { TYPE_2 i = TYPE_3 . METHOD_2 ( ctx , TYPE_4 . class ) ; i . VAR_1 ( TYPE_4 . VAR_2 , request . VAR_3 ( ) ) ; i . VAR_1 ( TYPE_4 . VAR_4 , request . VAR_5 ( ) ) ; ctx . VAR_6 ( i ) ; TYPE_3 . METHOD_3 ( ( TYPE_5 ) ctx ) ; } |
change _CODE_ ( STRING_1 ) rid casting stuff | public TYPE_1 METHOD_1 ( ) { <START> return ( TYPE_1 ) METHOD_2 ( ) . get ( STRING_1 ) ; <END> } | public TYPE_1 METHOD_1 ( ) { return METHOD_2 ( ) . METHOD_1 ( ) ; } |
extra file | public static TYPE_1 METHOD_1 ( String VAR_1 ) { TYPE_1 f = new TYPE_1 ( ) ; TYPE_2 args = new TYPE_2 ( ) ; <START> args . VAR_2 ( Constants . VAR_3 , VAR_1 ) ; <END> f . VAR_4 ( args ) ; return f ; } | public static TYPE_1 METHOD_1 ( String VAR_1 ) { TYPE_1 f = new TYPE_1 ( ) ; TYPE_2 args = new TYPE_2 ( ) ; args . VAR_2 ( VAR_3 , VAR_1 ) ; f . VAR_4 ( args ) ; return f ; } |
_CODE_ put 3 load methods proximity other | <START> public void METHOD_1 ( boolean VAR_1 ) { <END> TYPE_1 VAR_2 = VAR_3 - > { VAR_4 = ( TYPE_2 ) VAR_3 ; METHOD_2 ( ) ; METHOD_3 ( ) ; if ( VAR_5 >= VAR_6 && VAR_5 <= VAR_7 ) { METHOD_4 ( ) . METHOD_5 ( VAR_5 ) ; VAR_5 = - 1 ; } METHOD_6 ( true ) ; METHOD_7 ( ) ; } ; TYPE_3 . METHOD_1 ( this , VAR_8 , VAR_9 , VAR_1... | private void METHOD_1 ( boolean VAR_1 ) { TYPE_1 < TYPE_2 > VAR_2 = VAR_3 - > { VAR_4 = VAR_3 ; METHOD_2 ( ) ; METHOD_3 ( ) ; if ( VAR_5 >= VAR_6 && VAR_5 <= VAR_7 ) { METHOD_4 ( ) . METHOD_5 ( VAR_5 ) ; VAR_5 = - 1 ; } METHOD_6 ( true ) ; METHOD_7 ( ) ; } ; TYPE_3 . METHOD_1 ( this , VAR_8 , VAR_9 , VAR_1 ) . METHOD_8... |
private | <START> public void METHOD_1 ( ) { <END> METHOD_2 ( false ) ; Log . d ( STRING_1 , STRING_2 ) ; METHOD_3 ( true ) ; METHOD_4 ( true ) ; } | private void METHOD_1 ( ) { METHOD_2 ( false ) ; METHOD_3 ( true ) ; METHOD_4 ( true ) ; } |
change isn t needed | public static TYPE_1 METHOD_1 ( ) { TYPE_1 VAR_1 = new TYPE_1 ( ) ; TYPE_2 args = new TYPE_2 ( ) ; VAR_1 . METHOD_2 ( args ) ; <START> return VAR_1 ; <END> } | public static TYPE_1 METHOD_1 ( ) { return new TYPE_1 ( ) ; } |
oops | protected void METHOD_1 ( TYPE_1 VAR_1 ) { super . METHOD_1 ( VAR_1 ) ; VAR_2 = VAR_1 . getString ( STRING_1 ) ; VAR_3 = VAR_1 . getString ( STRING_2 ) ; VAR_4 = VAR_1 . getInt ( STRING_3 ) ; VAR_5 = VAR_1 . METHOD_2 ( STRING_4 , - 1 ) ; VAR_6 = VAR_1 . getInt ( STRING_5 , - 1 ) ; VAR_1 . remove ( STRING_4 ) ; <START> ... | protected void METHOD_1 ( TYPE_1 VAR_1 ) { super . METHOD_1 ( VAR_1 ) ; VAR_2 = VAR_1 . getString ( STRING_1 ) ; VAR_3 = VAR_1 . getString ( STRING_2 ) ; VAR_4 = VAR_1 . getInt ( STRING_3 ) ; VAR_5 = VAR_1 . METHOD_2 ( STRING_4 , - 1 ) ; VAR_6 = VAR_1 . getInt ( STRING_5 , - 1 ) ; VAR_1 . remove ( STRING_4 ) ; VAR_1 . ... |
( position = = 0 ) expresses | protected TYPE_1 METHOD_1 ( int position ) { final TYPE_2 f = TYPE_2 . METHOD_2 ( VAR_1 , VAR_2 , position == 1 ) ; <START> if ( position != 1 ) { <END> VAR_3 = f ; } return f ; } | protected TYPE_1 METHOD_1 ( int position ) { final TYPE_2 f = TYPE_2 . METHOD_2 ( VAR_1 , VAR_2 , position == 1 ) ; if ( position == 0 ) { VAR_3 = f ; } return f ; } |
( ! hasNext ( ) ) | int read ( ) { <START> if ( this . hasNext ( ) == false ) { <END> throw new IllegalStateException ( STRING_1 ) ; } int value = this . VAR_1 [ VAR_2 ] ; this . VAR_2 ++ ; return value ; } | int read ( ) { if ( ! this . hasNext ( ) ) { throw new IllegalStateException ( STRING_1 ) ; } int value = this . VAR_1 [ VAR_2 ] ; this . VAR_2 ++ ; return value ; } |
I modified test ensure METHOD_3 symmetrical test failed NPE : void METHOD_1 ( ) { _CODE_ ( STRING_1 STRING_2 true ) ; } private void _CODE_ ( String wkt String _CODE_ boolean METHOD_3 ) { assertEquals ( TYPE_1 METHOD_2 ( wkt ) METHOD_3 ( TYPE_1 METHOD_2 ( _CODE_ ) ) METHOD_3 ) ; assertEquals ( TYPE_1 METHOD_2 ( _CODE_ ... | <START> public void METHOD_1 ( ) { <END> TYPE_1 VAR_1 = TYPE_1 . METHOD_2 ( STRING_1 ) ; assertTrue ( VAR_1 . METHOD_3 ( TYPE_1 . METHOD_2 ( STRING_2 ) ) ) ; } | public void METHOD_1 ( ) { TYPE_1 VAR_1 = TYPE_1 . METHOD_2 ( STRING_1 ) ; assertTrue ( VAR_1 . METHOD_3 ( TYPE_1 . METHOD_2 ( STRING_2 ) ) ) ; VAR_1 = TYPE_1 . METHOD_2 ( STRING_2 ) ; assertTrue ( VAR_1 . METHOD_3 ( TYPE_1 . METHOD_2 ( STRING_1 ) ) ) ; } |
es este 1 | public TYPE_2 ( String VAR_2 , boolean VAR_3 ) { <START> this ( VAR_2 , 1 , VAR_3 , TYPE_1 . getInstance ( ) . METHOD_1 ( VAR_2 ) ) ; <END> } | public TYPE_2 ( String VAR_2 , boolean VAR_3 ) { this ( VAR_2 , - 1 , VAR_3 , TYPE_1 . getInstance ( ) . METHOD_1 ( VAR_2 ) ) ; } |
setting alias temp directory important optional argument ? overwrite alias needed ( i e improve performance ) instances cached | public void METHOD_1 ( ) { String VAR_1 = TYPE_1 . getInstance ( ) . getString ( STRING_1 , null ) ; <START> VAR_2 = TYPE_2 . METHOD_2 ( STRING_2 , VAR_1 ) ; <END> } | public void METHOD_1 ( ) { VAR_2 = TYPE_2 . METHOD_2 ( ) ; } |
bloc code repeated times centralized a single method | public TYPE_1 METHOD_1 ( ) { <START> if ( VAR_1 != null && VAR_1 . METHOD_2 ( ) ) { <END> METHOD_3 ( ) ; } return VAR_2 . METHOD_1 ( ) ; } | public TYPE_1 METHOD_1 ( ) { return VAR_2 . METHOD_1 ( ) ; } |
StringUtils _CODE_ ( ) | private TYPE_1 METHOD_1 ( TYPE_2 VAR_1 , TYPE_3 VAR_2 ) { Collection < TYPE_4 > VAR_3 = METHOD_2 ( null , null , VAR_2 . METHOD_3 ( ) , null , <START> ( VAR_2 . METHOD_3 ( ) != null ? TYPE_5 . METHOD_4 ( VAR_2 . METHOD_3 ( ) ) : "" ) , <END> null ) ; return METHOD_5 ( TYPE_1 . VAR_4 . VAR_5 , VAR_1 , VAR_3 ) ; } | private TYPE_1 METHOD_1 ( TYPE_2 VAR_1 , TYPE_3 VAR_2 ) { Collection < TYPE_4 > VAR_3 = METHOD_2 ( null , null , VAR_2 . METHOD_3 ( ) , null , ( VAR_2 . METHOD_3 ( ) != null ? TYPE_5 . METHOD_4 ( VAR_2 . METHOD_3 ( ) ) : "" ) , null ) ; return METHOD_5 ( VAR_5 , VAR_1 , VAR_3 ) ; } |
I fear won t able add fail fast ( I proposal add more fail fasts : ) ) other fail fasts added PR fine | public TYPE_5 ( TYPE_1 VAR_2 , boolean VAR_3 , TYPE_2 < TYPE_3 > VAR_4 ) { super ( VAR_2 , VAR_3 ) ; if ( VAR_3 && ! ( VAR_4 instanceof TYPE_4 ) ) { throw new IllegalStateException ( STRING_1 + VAR_4 + STRING_2 + TYPE_4 . class . METHOD_1 ( ) + STRING_3 ) ; <START> } <END> this . VAR_4 = VAR_4 ; } | public TYPE_5 ( TYPE_1 VAR_2 , boolean VAR_3 , TYPE_2 < TYPE_3 > VAR_4 ) { super ( VAR_2 , VAR_3 ) ; this . VAR_4 = VAR_4 ; } |
need return statement | public static void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 outputStream ) throws IOException { if ( VAR_1 == null || outputStream == null ) { if ( outputStream != null ) { TYPE_3 . METHOD_2 ( outputStream ) ; } return ; } try { TYPE_3 . METHOD_3 ( VAR_1 , outputStream ) ; } finally { TYPE_3 . METHOD_2 ( outputStream ) ; <STAR... | public static void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 outputStream ) throws IOException { if ( VAR_1 == null || outputStream == null ) { if ( outputStream != null ) { TYPE_3 . METHOD_2 ( outputStream ) ; } return ; } try { TYPE_3 . METHOD_3 ( VAR_1 , outputStream ) ; } finally { TYPE_3 . METHOD_2 ( outputStream ) ; } } |
change Assert state ( session ! = null STRING_1 ) ; | protected void METHOD_1 ( ) throws Throwable { <START> if ( session == null ) { <END> throw new IllegalStateException ( STRING_1 ) ; } session . execute ( String . format ( STRING_2 + STRING_3 , VAR_1 ) ) ; session . execute ( String . format ( STRING_4 , VAR_1 ) ) ; } | protected void METHOD_1 ( ) throws Throwable { Assert . state ( session != null , STRING_1 ) ; session . execute ( String . format ( STRING_2 + STRING_3 , VAR_1 ) ) ; session . execute ( String . format ( STRING_4 , VAR_1 ) ) ; } |
needed statement handles DB care status changed instance | private void METHOD_1 ( ) { final TYPE_1 VAR_1 = METHOD_2 ( ) ; TYPE_2 . METHOD_3 ( ( ) - > { METHOD_4 ( ) . METHOD_5 ( VAR_1 . METHOD_6 ( ) ) ; <START> VAR_1 . METHOD_7 ( TYPE_4 . VAR_3 ) ; <END> TYPE_3 . METHOD_8 ( VAR_1 . METHOD_9 ( ) , TYPE_4 . VAR_3 ) ; METHOD_4 ( ) . METHOD_10 ( ) ; return null ; } ) ; } | private void METHOD_1 ( ) { final TYPE_1 VAR_1 = METHOD_2 ( ) ; TYPE_2 . METHOD_3 ( ( ) - > { METHOD_4 ( ) . METHOD_5 ( VAR_1 . METHOD_6 ( ) ) ; TYPE_3 . METHOD_8 ( VAR_1 . METHOD_9 ( ) , TYPE_4 . VAR_3 ) ; METHOD_4 ( ) . METHOD_10 ( ) ; return null ; } ) ; } |
s motivation swallowing exception a warning ? _CODE_ ( improved version want logging ) | public synchronized void close ( ) { try { TYPE_1 VAR_1 = TYPE_1 . create ( ) ; if ( VAR_2 != null ) { VAR_1 . METHOD_1 ( VAR_2 ) ; } VAR_1 . METHOD_1 ( VAR_3 ) ; VAR_1 . close ( ) ; } catch ( IOException e ) { <START> LOG . warn ( STRING_1 , e . getMessage ( ) ) ; <END> } VAR_4 = true ; } | public synchronized void close ( ) throws IOException { TYPE_1 VAR_1 = TYPE_1 . create ( ) ; if ( VAR_2 != null ) { VAR_1 . METHOD_1 ( VAR_2 ) ; } VAR_1 . METHOD_1 ( VAR_3 ) ; VAR_1 . close ( ) ; VAR_4 = true ; } |
logging client side ll need setup log level ? I move code _CODE_ deploy ( ) method work | public void METHOD_1 ( ) { <START> Logger logger = Logger . VAR_1 ( TYPE_1 . class . getName ( ) ) ; <END> Level VAR_2 = logger . VAR_3 ( ) ; logger . VAR_4 ( Level . VAR_5 ) ; new TYPE_2 ( ) . METHOD_2 ( ) ; logger . VAR_4 ( VAR_2 ) ; } | public void METHOD_1 ( ) { new TYPE_2 ( ) . METHOD_2 ( ) ; } |
empty line | public void METHOD_1 ( ) throws Exception { VAR_1 . METHOD_2 ( STRING_1 ) ; int VAR_2 = VAR_3 . METHOD_3 ( ) ; assertEquals ( STRING_2 , 2 , VAR_2 ) ; VAR_3 . METHOD_2 ( STRING_3 ) ; VAR_2 = VAR_3 . METHOD_3 ( ) ; assertEquals ( STRING_2 , 2 , VAR_2 ) ; VAR_3 . METHOD_2 ( STRING_4 ) ; VAR_2 = VAR_3 . METHOD_3 ( ) ; ass... | public void METHOD_1 ( ) throws Exception { VAR_1 . METHOD_2 ( STRING_1 ) ; int VAR_2 = VAR_3 . METHOD_3 ( ) ; assertEquals ( STRING_2 , 2 , VAR_2 ) ; VAR_3 . METHOD_2 ( STRING_3 ) ; VAR_2 = VAR_3 . METHOD_3 ( ) ; assertEquals ( STRING_2 , 2 , VAR_2 ) ; VAR_3 . METHOD_2 ( STRING_4 ) ; VAR_2 = VAR_3 . METHOD_3 ( ) ; } |
new HashMap < String Object > ( 0 ) Collections < String Object > _CODE_ ( ) immutable | public TYPE_2 ( TYPE_1 server ) { <START> this ( server , new HashMap < String , Object > ( ) ) ; <END> } | public TYPE_2 ( TYPE_1 server ) { this ( server , new HashMap < String , Object > ( 0 ) ) ; } |
need FQCN | public TYPE_1 < TYPE_2 > execute ( final TYPE_3 context ) { final TYPE_1 < TYPE_2 > results = METHOD_1 ( context ) ; if ( ! results . getType ( ) . equals ( TYPE_1 . Type . VAR_1 ) ) { <START> final org . VAR_2 . VAR_3 . VAR_4 . VAR_5 . VAR_6 . VAR_7 . TYPE_4 VAR_7 = METHOD_2 ( context ) ; <END> VAR_7 . METHOD_3 ( VAR_... | public TYPE_1 < TYPE_2 > execute ( final TYPE_3 context ) { final TYPE_1 < TYPE_2 > results = METHOD_1 ( context ) ; if ( ! results . getType ( ) . equals ( TYPE_1 . Type . VAR_1 ) ) { final TYPE_4 VAR_7 = METHOD_2 ( context ) ; VAR_7 . METHOD_3 ( VAR_9 ) ; METHOD_4 ( context ) . METHOD_3 ( VAR_9 ) ; } return results ;... |
return exception exits codethrow METHOD_1 ( column ( 0 ) ) ; | <START> private static void METHOD_1 ( TYPE_1 VAR_1 ) throws TYPE_2 { <END> throw new TYPE_2 ( VAR_1 , STRING_1 ) ; } | private static TYPE_2 METHOD_1 ( TYPE_1 VAR_1 ) { return new TYPE_2 ( VAR_1 , STRING_1 ) ; } |
move logic builder factories needed | public static < T > TYPE_1 < T > METHOD_1 ( TYPE_2 < T > message ) { Assert . VAR_1 ( message , STRING_1 ) ; if ( message instanceof TYPE_3 ) { logger . warn ( STRING_2 + STRING_3 ) ; <START> } <END> return new TYPE_1 < T > ( message ) ; } | public static < T > TYPE_1 < T > METHOD_1 ( TYPE_2 < T > message ) { Assert . VAR_1 ( message , STRING_1 ) ; return new TYPE_1 < T > ( message ) ; } |
implies expecting code review verified integers ( break silently ) I underlying implication data type getters Integer convert integer a string safely isn t true parsing some arbitrary string IMO thoughts | public TYPE_1 METHOD_1 ( Object element , int VAR_1 ) { TYPE_2 VAR_2 = ( TYPE_2 ) element ; switch ( VAR_1 ) { case 0 : return METHOD_2 ( ) ; case 1 : try { <START> return METHOD_3 ( Integer . parseInt ( VAR_2 . METHOD_4 ( ) ) ) ; <END> } catch ( Exception e ) { break ; } case 2 : try { return METHOD_5 ( Integer . pars... | public TYPE_1 METHOD_1 ( Object element , int VAR_1 ) { TYPE_2 VAR_2 = ( TYPE_2 ) element ; switch ( VAR_1 ) { case 0 : return METHOD_2 ( ) ; case 1 : return METHOD_3 ( VAR_2 . METHOD_4 ( ) ) ; case 2 : return METHOD_5 ( VAR_2 . METHOD_6 ( ) ) ; } return null ; } |
s add protected symmetric other fields accessed context scope | <START> TYPE_1 METHOD_1 ( ) { <END> return VAR_1 ; } | protected TYPE_1 METHOD_1 ( ) { return VAR_1 ; } |
logic _CODE_ : _CODE_ = _CODE_ = = null ? new ArrayList < TYPE_1 > ( ) : _CODE_ ; VAR_1 expected empty ArrayList case VAR_1 iterator ( ) ( ) fail _CODE_ | public static TYPE_1 METHOD_1 ( Collection < TYPE_1 > VAR_1 ) { <START> return VAR_1 . contains ( TYPE_1 . VAR_2 ) ? TYPE_1 . VAR_2 : VAR_1 . iterator ( ) . next ( ) ; <END> } | public static TYPE_1 METHOD_1 ( Collection < TYPE_1 > VAR_1 ) { if ( VAR_1 == null || VAR_1 . isEmpty ( ) ) { return null ; } else if ( VAR_1 . contains ( TYPE_1 . VAR_2 ) ) { return TYPE_1 . VAR_2 ; } else { return VAR_1 . iterator ( ) . next ( ) ; } } |
don t need wait tx completion responses removing local info removing local info expensive send command | public TYPE_1 < TYPE_2 > METHOD_1 ( Collection < TYPE_3 > VAR_1 , long VAR_2 ) { if ( VAR_3 != null ) { TYPE_4 VAR_4 = VAR_5 . METHOD_2 ( VAR_2 ) ; TYPE_1 < TYPE_2 > VAR_6 = METHOD_3 ( VAR_1 , VAR_4 ) ; <START> return VAR_6 . METHOD_4 ( ( ) - > METHOD_5 ( VAR_2 ) ) ; <END> } else { METHOD_5 ( VAR_2 ) ; return TYPE_5 . ... | public TYPE_1 < TYPE_2 > METHOD_1 ( Collection < TYPE_3 > VAR_1 , long VAR_2 ) { if ( VAR_3 != null ) { TYPE_4 VAR_4 = VAR_5 . METHOD_2 ( VAR_2 ) ; TYPE_1 < TYPE_2 > VAR_6 = METHOD_3 ( VAR_1 , VAR_4 ) ; METHOD_5 ( VAR_2 ) ; return VAR_6 ; } else { METHOD_5 ( VAR_2 ) ; return TYPE_5 . METHOD_6 ( ) ; } } |
extracted a private static final constant | public TYPE_1 apply ( List < TYPE_2 > args , TYPE_2 . TYPE_5 VAR_1 ) { if ( args . size ( ) >= 1 ) { throw new TYPE_4 ( STRING_1 , name ( ) ) ; } <START> return TYPE_1 . of ( Math . VAR_2 ) ; <END> } | public TYPE_1 apply ( List < TYPE_2 > args , TYPE_2 . TYPE_5 VAR_1 ) { if ( args . size ( ) >= 1 ) { throw new TYPE_4 ( STRING_1 , name ( ) ) ; } return TYPE_1 . of ( VAR_2 ) ; } |
rename entry | public static List < TYPE_1 > METHOD_1 ( TYPE_2 project ) throws TYPE_3 { ArrayList < TYPE_1 > VAR_1 = new ArrayList < > ( ) ; for ( TYPE_4 <START> VAR_2 : <END> project . VAR_3 ( ) ) { VAR_1 . add ( TYPE_1 . METHOD_2 ( VAR_2 , project ) ) ; } return VAR_1 ; } | public static List < TYPE_1 > METHOD_1 ( TYPE_2 project ) throws TYPE_3 { ArrayList < TYPE_1 > VAR_1 = new ArrayList < > ( ) ; for ( TYPE_4 entry : project . VAR_3 ( ) ) { VAR_1 . add ( TYPE_1 . METHOD_2 ( entry , project ) ) ; } return VAR_1 ; } |
hmm I suprised case I intellij 14 0 2 | public final List < TYPE_1 > METHOD_1 ( final TYPE_2 < TYPE_1 > VAR_1 , final List < TYPE_1 > VAR_2 ) { return this . METHOD_2 ( METHOD_3 ( TYPE_4 . VAR_4 . METHOD_4 ( ) , VAR_2 . METHOD_5 ( TYPE_3 < TYPE_1 , TYPE_1 , Boolean > METHOD_6 ( VAR_1 . METHOD_7 ( ) ) ) ) ) ; <START> } <END> | public final List < TYPE_1 > METHOD_1 ( final TYPE_2 < TYPE_1 > VAR_1 , final List < TYPE_1 > VAR_2 ) { return METHOD_2 ( METHOD_3 ( TYPE_4 . VAR_4 . METHOD_4 ( ) , VAR_2 . METHOD_5 ( METHOD_6 ( VAR_1 . METHOD_7 ( ) ) ) ) ) ; } |
a good set _CODE_ _CODE_ set result depends order some checking ( possibly logging ) required define a clear priority settings build method ensure | public Builder METHOD_1 ( TYPE_1 VAR_1 ) { this . VAR_1 = VAR_1 ; <START> this . VAR_2 = VAR_1 . METHOD_2 ( ) ; <END> return this ; } | public Builder METHOD_1 ( TYPE_1 VAR_1 ) { this . VAR_1 = VAR_1 ; return this ; } |
I don t calling super I d | public Integer METHOD_1 ( ) { TYPE_1 VAR_1 = METHOD_2 ( ) ; if ( TYPE_2 . METHOD_3 ( VAR_1 ) ) { return VAR_1 . METHOD_4 ( ) ; } <START> return super . METHOD_1 ( ) ; <END> } | public Integer METHOD_1 ( ) { TYPE_1 VAR_1 = METHOD_2 ( ) ; if ( TYPE_2 . METHOD_3 ( VAR_1 ) ) { return VAR_1 . METHOD_4 ( ) ; } return null ; } |
s remove METHOD_2 s critical checks & forget remove _CODE_ fixed | TYPE_4 ( TYPE_1 config , TYPE_2 < TYPE_3 > VAR_2 ) { METHOD_1 ( config , STRING_1 ) ; METHOD_1 ( VAR_2 , STRING_2 ) ; <START> METHOD_2 ( config . VAR_3 ( ) . METHOD_3 ( ) >= 10 , STRING_3 ) ; <END> METHOD_2 ( config . VAR_4 ( ) . METHOD_3 ( ) >= 10 , STRING_4 ) ; VAR_5 = METHOD_4 ( config , VAR_2 ) ; } | TYPE_4 ( TYPE_1 config , TYPE_2 < TYPE_3 > VAR_2 ) { METHOD_1 ( config , STRING_1 ) ; METHOD_1 ( VAR_2 , STRING_2 ) ; VAR_5 = METHOD_4 ( config , VAR_2 ) ; } |
VAR_2 null ? NPE thrown | public void METHOD_1 ( ) { <START> if ( VAR_1 ) { METHOD_2 ( ) ; } <END> VAR_2 = null ; VAR_3 = null ; VAR_4 = null ; VAR_5 = null ; VAR_6 = null ; METHOD_3 ( ) ; super . METHOD_1 ( ) ; } | public void METHOD_1 ( ) { METHOD_2 ( ) ; VAR_2 = null ; VAR_3 = null ; VAR_4 = null ; VAR_5 = null ; VAR_6 = null ; METHOD_3 ( ) ; super . METHOD_1 ( ) ; } |
minor : I m generally happy reassigning method parameters | public void METHOD_1 ( Throwable error ) { if ( error == null ) { throw new TYPE_1 ( STRING_1 ) ; } if ( error instanceof TYPE_2 ) { TYPE_3 e = new TYPE_3 ( error . getMessage ( ) ) ; e . VAR_1 ( error ) ; <START> error = e ; <END> } VAR_2 . add ( error ) ; } | public void METHOD_1 ( Throwable error ) { if ( error == null ) { throw new TYPE_1 ( STRING_1 ) ; } if ( error instanceof TYPE_2 ) { TYPE_3 e = new TYPE_3 ( error . getMessage ( ) ) ; e . VAR_1 ( error ) ; VAR_2 . add ( e ) ; } else { VAR_2 . add ( error ) ; } } |
shouldn t test synchronized _CODE_ java | protected void METHOD_1 ( ) { <START> if ( VAR_1 . isEmpty ( ) ) { <END> return ; } super . METHOD_1 ( ) ; } | protected void METHOD_1 ( ) { synchronized ( this ) { if ( VAR_1 . isEmpty ( ) ) { return ; } } super . METHOD_1 ( ) ; } |
I pre - existing variable capitalized Map map | public String get ( String key ) { <START> Map < String , String > Map = VAR_1 . get ( ) ; <END> if ( ( Map != null ) && ( key != null ) ) { return Map . get ( key ) ; } else { return null ; } } | public String get ( String key ) { Map < String , String > map = VAR_1 . get ( ) ; if ( ( map != null ) && ( key != null ) ) { return map . get ( key ) ; } else { return null ; } } |
bekhta a left - ? I e planning revert change discussion ? question some more places TYPE_2 METHOD_6 ( ) | public void METHOD_1 ( Class < ? > from , Class < ? > to ) { METHOD_2 ( ) ; boolean VAR_1 = false ; for ( TYPE_1 VAR_2 : VAR_3 ) { if ( VAR_2 . METHOD_3 ( ) . equals ( from ) && VAR_2 . METHOD_4 ( ) . equals ( to ) ) { VAR_1 = true ; break ; } } if ( ! VAR_1 ) { <START> METHOD_5 ( String . format ( TYPE_2 . METHOD_6 ( ... | public void METHOD_1 ( Class < ? > from , Class < ? > to ) { METHOD_2 ( ) ; boolean VAR_1 = false ; for ( TYPE_1 VAR_2 : VAR_3 ) { if ( VAR_2 . METHOD_3 ( ) . equals ( from ) && VAR_2 . METHOD_4 ( ) . equals ( to ) ) { VAR_1 = true ; break ; } } if ( ! VAR_1 ) { METHOD_5 ( String . format ( STRING_1 , VAR_3 , from , to... |
copy paste error | public synchronized void METHOD_1 ( long VAR_1 ) { VAR_2 . put ( Long . VAR_3 , VAR_4 , VAR_5 , VAR_1 ) ; <START> VAR_6 . METHOD_2 ( VAR_1 ) ; <END> } | public void METHOD_1 ( long VAR_1 ) { VAR_2 . put ( Long . VAR_3 , VAR_4 , VAR_5 , VAR_1 ) ; } |
FYI TimeUnit VAR_3 VAR_2 ( VAR_1 METHOD_3 ( ) ) | public void METHOD_1 ( TYPE_1 VAR_1 ) { try { <START> Thread . VAR_2 ( TimeUnit . VAR_3 . METHOD_2 ( VAR_1 . METHOD_3 ( ) ) ) ; <END> } catch ( InterruptedException e ) { } } | public void METHOD_1 ( TYPE_1 VAR_1 ) { try { TimeUnit . VAR_3 . METHOD_1 ( VAR_1 . METHOD_3 ( ) ) ; } catch ( InterruptedException e ) { } } |
I VAR_3 isn t check VAR_1 cast connection provided | public void METHOD_1 ( ) { <START> TYPE_1 VAR_1 = VAR_2 . METHOD_2 ( ) ; <END> if ( ! ( VAR_1 instanceof TYPE_2 ) ) { throw new IllegalStateException ( STRING_1 ) ; } TYPE_2 VAR_3 = ( TYPE_2 ) VAR_1 ; try { VAR_1 . METHOD_3 ( null ) ; } catch ( TYPE_3 VAR_4 ) { LOG . VAR_5 ( VAR_4 ) ; } } | public void METHOD_1 ( ) { TYPE_1 VAR_1 = VAR_2 . METHOD_2 ( ) ; if ( ! ( VAR_1 instanceof TYPE_2 ) ) { throw new IllegalStateException ( STRING_1 ) ; } try { VAR_1 . METHOD_3 ( null ) ; } catch ( TYPE_3 VAR_4 ) { LOG . VAR_5 ( VAR_4 ) ; } } |
Integer valueOf ( ) instead | public boolean METHOD_1 ( TYPE_1 VAR_1 ) { <START> return VAR_2 . contains ( new Integer ( VAR_1 . METHOD_2 ( ) ) ) ; <END> } | public boolean METHOD_1 ( TYPE_1 VAR_1 ) { return VAR_2 . contains ( Integer . valueOf ( VAR_1 . METHOD_2 ( ) ) ) ; } |
please brackets - line blocks | public TYPE_1 METHOD_1 ( ) { <START> if ( VAR_1 ) <END> return VAR_2 ; return super . METHOD_1 ( ) ; } | public TYPE_1 METHOD_1 ( ) { if ( VAR_1 ) { return VAR_2 ; } return super . METHOD_1 ( ) ; } |
swallowing exception ? isn t caller | public TYPE_1 METHOD_1 ( TYPE_2 < String , TYPE_3 > VAR_1 , String VAR_2 ) { logger . debug ( STRING_1 , VAR_2 ) ; try { TYPE_4 config = METHOD_2 ( VAR_1 ) ; if ( config != null ) { return METHOD_3 ( config , VAR_3 - > StringUtils . equals ( VAR_2 , VAR_3 . getString ( VAR_4 ) ) ) ; } } catch ( TYPE_5 e ) { <START> log... | public TYPE_1 METHOD_1 ( TYPE_2 < String , TYPE_3 > VAR_1 , String VAR_2 ) throws TYPE_5 , IOException { logger . debug ( STRING_1 , VAR_2 ) ; TYPE_4 config = METHOD_2 ( VAR_1 ) ; if ( config != null ) { return METHOD_3 ( config , VAR_3 - > StringUtils . equals ( VAR_2 , VAR_3 . getString ( VAR_4 ) ) ) ; } return null ... |
add a null check class initialized | public void METHOD_1 ( ) { <START> VAR_1 . METHOD_2 ( TYPE_1 . VAR_3 ) ; <END> } | public void METHOD_1 ( ) { if ( VAR_1 != null ) { VAR_1 . METHOD_2 ( TYPE_1 . VAR_3 ) ; } } |
setter called moved constructor | public TYPE_1 METHOD_1 ( final TYPE_2 args ) { TYPE_1 VAR_1 = new TYPE_1 ( null , null , VAR_2 , VAR_3 , VAR_4 , VAR_5 , VAR_6 , VAR_7 , VAR_8 ) ; <START> VAR_1 . METHOD_2 ( VAR_9 ) ; <END> return VAR_1 ; } | public TYPE_1 METHOD_1 ( final TYPE_2 args ) { return new TYPE_1 ( null , null , VAR_2 , VAR_3 , VAR_4 , VAR_5 , VAR_6 , VAR_7 , VAR_8 , VAR_9 ) ; } |
getName ( ) instead VAR_1 METHOD_1 ( ) | public String toString ( ) { <START> return STRING_1 + VAR_1 . METHOD_1 ( ) + STRING_2 ; <END> } | public String toString ( ) { return STRING_1 + getName ( ) + STRING_2 ; } |
public protected private | <START> TYPE_1 METHOD_1 ( TYPE_1 VAR_1 , List < TYPE_2 < T > > VAR_2 ) { <END> return METHOD_1 ( VAR_1 , VAR_2 , true ) ; } | private TYPE_1 METHOD_1 ( TYPE_1 VAR_1 , List < TYPE_2 < T > > VAR_2 ) { return METHOD_1 ( VAR_1 , VAR_2 , true ) ; } |
don t spam final keywords code part changeset | private static synchronized TYPE_1 session ( ) { final TYPE_2 properties = new TYPE_2 ( ) ; <START> final TYPE_3 conf = TYPE_4 . METHOD_1 ( ) ; <END> properties . put ( STRING_1 , conf . VAR_1 ( ) ) ; properties . put ( STRING_2 , conf . VAR_2 ( ) ) ; properties . put ( STRING_3 , conf . VAR_3 ( ) ) ; properties . put ... | private static synchronized TYPE_1 session ( ) { final TYPE_2 properties = new TYPE_2 ( ) ; TYPE_3 conf = TYPE_4 . METHOD_1 ( ) ; properties . put ( STRING_1 , conf . VAR_1 ( ) ) ; properties . put ( STRING_2 , conf . VAR_2 ( ) ) ; properties . put ( STRING_3 , conf . VAR_3 ( ) ) ; properties . put ( STRING_4 , conf . ... |
need mark VAR_1 final code needs JDK6 compatible | public void METHOD_1 ( ) throws Exception { TYPE_1 < String > VAR_1 = new TYPE_1 < String > ( 1 ) ; VAR_1 . add ( METHOD_2 ( TYPE_2 . class ) ) ; TYPE_3 t = new TYPE_3 ( ) { @Override public void METHOD_3 ( ) throws Throwable { <START> VAR_1 . add ( METHOD_2 ( TYPE_2 . class ) ) ; <END> } } ; t . start ( ) ; t . VAR_2 ... | public void METHOD_1 ( ) throws Exception { final TYPE_1 < String > VAR_1 = new TYPE_1 < String > ( 1 ) ; VAR_1 . add ( METHOD_2 ( TYPE_2 . VAR_4 ) ) ; TYPE_3 t = new TYPE_3 ( ) { @Override public void METHOD_3 ( ) throws Throwable { VAR_1 . add ( METHOD_2 ( TYPE_2 . VAR_4 ) ) ; } } ; t . start ( ) ; t . VAR_2 ( ) ; t ... |
trace experiment disposed UUID changed ( experiment longer children UUID computed empty string ) | public void METHOD_1 ( ANNOTATION_1 TYPE_1 VAR_1 ) { METHOD_2 ( ) ; super . METHOD_1 ( VAR_1 ) ; METHOD_3 ( null ) ; if ( VAR_1 != null ) { <START> VAR_2 . remove ( VAR_1 . METHOD_4 ( ) . METHOD_5 ( ) ) ; <END> } } | public void METHOD_1 ( ANNOTATION_1 TYPE_1 VAR_1 ) { METHOD_2 ( ) ; super . METHOD_1 ( VAR_1 ) ; METHOD_3 ( null ) ; if ( VAR_1 != null ) { VAR_2 . remove ( VAR_1 . METHOD_4 ( ) ) ; } } |
other option commands exposing information user I internally stick original VAR_1 / committer / tagger | private String METHOD_1 ( int line ) { TYPE_1 VAR_1 = <START> db . VAR_2 ( ) . map ( VAR_3 . METHOD_2 ( line ) ) ; <END> if ( VAR_1 == null ) return "" ; String name = VAR_4 ? VAR_1 . METHOD_3 ( ) : VAR_1 . getName ( ) ; return name != null ? name : "" ; } | private String METHOD_1 ( int line ) { TYPE_1 VAR_1 = VAR_3 . METHOD_2 ( line ) ; if ( VAR_1 == null ) return "" ; String name = VAR_4 ? VAR_1 . METHOD_3 ( ) : VAR_1 . getName ( ) ; return name != null ? name : "" ; } |
avoid multiple returns | <START> public void METHOD_1 ( ) { <END> View view = METHOD_2 ( ) ; if ( view == null ) { return ; } METHOD_3 ( ) . METHOD_4 ( view , this ) ; if ( VAR_1 == null ) { return ; } for ( TYPE_1 VAR_2 : VAR_1 . METHOD_5 ( ) ) { METHOD_3 ( ) . METHOD_4 ( VAR_2 , this ) ; } METHOD_3 ( ) . METHOD_4 ( VAR_1 , this ) ; VAR_1 = n... | public void METHOD_1 ( ) { View view = METHOD_2 ( ) ; if ( view != null ) { METHOD_3 ( ) . METHOD_4 ( view , this ) ; if ( VAR_1 != null ) { for ( TYPE_1 VAR_2 : VAR_1 . METHOD_5 ( ) ) { METHOD_3 ( ) . METHOD_4 ( VAR_2 , this ) ; } METHOD_3 ( ) . METHOD_4 ( VAR_1 , this ) ; VAR_1 = null ; } } } |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.