ReviewComments stringlengths 1 2.35k | OriginalCode stringlengths 28 487 | ReviewedCode stringlengths 14 463 |
|---|---|---|
please dont Optional VAR_2 ? isnt user some leftovers target removed dmn files project | protected TYPE_1 < List < String > > METHOD_1 ( TYPE_2 < List < TYPE_3 > > VAR_1 ) { return response - > { List < TYPE_3 > VAR_2 = response . stream ( ) . map ( this : : METHOD_2 ) <START> . filter ( this : : METHOD_3 ) <END> . METHOD_4 ( TYPE_4 . METHOD_5 ( TYPE_3 : : METHOD_6 , String . VAR_3 ) ) . collect ( Collecto... | protected TYPE_1 < List < String > > METHOD_1 ( TYPE_2 < List < TYPE_3 > > VAR_1 ) { return response - > { List < TYPE_3 > VAR_2 = response . stream ( ) . map ( this : : METHOD_2 ) . METHOD_4 ( TYPE_4 . METHOD_5 ( TYPE_3 : : METHOD_6 , String . VAR_3 ) ) . collect ( Collectors . VAR_4 ( ) ) ; VAR_1 . METHOD_7 ( VAR_2 )... |
uniform code approaches | protected void METHOD_1 ( ) { <START> VAR_1 . METHOD_2 ( ) . METHOD_3 ( TYPE_2 . TYPE_3 : : METHOD_4 ) ; VAR_1 . METHOD_5 ( ) . METHOD_3 ( TYPE_2 . TYPE_3 : : METHOD_4 ) ; VAR_1 . METHOD_6 ( ) . METHOD_3 ( TYPE_2 . TYPE_3 : : METHOD_4 ) ; VAR_2 . METHOD_7 ( ) ; <END> } | protected void METHOD_1 ( ) { VAR_1 . METHOD_1 ( ) ; } |
I remember a similar ( ? ) code else I wrong | <START> protected double METHOD_1 ( String VAR_1 ) { <END> TYPE_2 . TYPE_3 VAR_2 ; try { VAR_2 = TYPE_2 . TYPE_3 . valueOf ( VAR_1 ) ; } catch ( IllegalArgumentException e ) { VAR_2 = TYPE_2 . TYPE_3 . TYPE_6 ; } switch ( VAR_2 ) { case TYPE_5 : return INT_1 ; case TYPE_4 : return INT_2 ; default : return INT_3 ; } } | protected static double METHOD_1 ( String VAR_1 ) { TYPE_2 . TYPE_3 VAR_2 ; try { VAR_2 = TYPE_2 . TYPE_3 . valueOf ( VAR_1 ) ; } catch ( IllegalArgumentException e ) { VAR_2 = TYPE_2 . TYPE_3 . TYPE_6 ; } switch ( VAR_2 ) { case TYPE_5 : return INT_1 ; case TYPE_4 : return INT_2 ; default : return INT_3 ; } } |
shouldn t handle case single enum ? javaprivate boolean METHOD_1 ( ) { ( VAR_1 ! = null && VAR_1 METHOD_2 ( ) ! = null ) { ( VAR_1 METHOD_2 ( ) split ( STRING_1 ) length > 1 ) { return true ; } else { return VAR_1 METHOD_2 ( ) trim ( ) length ( ) > 0 ; } } else { return false ; } } | private boolean METHOD_1 ( ) { return VAR_1 != null && VAR_1 . METHOD_2 ( ) != null && <START> VAR_1 . METHOD_2 ( ) . split ( STRING_1 ) . length > 1 ; <END> } | private boolean METHOD_1 ( ) { return VAR_1 != null && VAR_1 . METHOD_2 ( ) != null && ! VAR_1 . METHOD_2 ( ) . trim ( ) . isEmpty ( ) ; } |
METHOD_3 private move VAR_5 variable METHOD_3 currently check METHOD_3 VAR_5 null | protected static TYPE_1 METHOD_1 ( TYPE_2 source ) { TYPE_1 VAR_1 = new TYPE_1 ( ) ; TYPE_3 VAR_2 = new TYPE_3 ( ) ; VAR_1 . METHOD_2 ( VAR_2 ) ; final List < TYPE_4 > VAR_3 = source . VAR_4 ( ) ; <START> List < TYPE_5 > VAR_5 = new ArrayList < > ( ) ; METHOD_3 ( VAR_5 , VAR_3 ) ; VAR_2 . METHOD_4 ( VAR_5 ) ; <END> ret... | protected static TYPE_1 METHOD_1 ( TYPE_2 source ) { TYPE_1 VAR_1 = new TYPE_1 ( ) ; TYPE_3 VAR_2 = new TYPE_3 ( ) ; VAR_1 . METHOD_2 ( VAR_2 ) ; final List < TYPE_4 > VAR_3 = source . VAR_4 ( ) ; List < TYPE_5 > VAR_5 = METHOD_3 ( VAR_3 ) ; VAR_2 . METHOD_4 ( VAR_5 ) ; return VAR_1 ; } |
variant a bit shorter readable ? javaif ( source ! = null && source VAR_3 ( ) ! = null ) { final TYPE_3 VAR_2 = source VAR_3 ( ) ; VAR_2 METHOD_2 ( ) forEach ( VAR_4 - > VAR_1 METHOD_3 ( METHOD_2 ( VAR_4 ) ) ) ; } | protected static TYPE_1 METHOD_1 ( TYPE_2 source ) { TYPE_1 VAR_1 = new TYPE_1 ( ) ; <START> if ( source != null ) { final TYPE_3 VAR_2 = source . VAR_3 ( ) ; if ( VAR_2 != null ) { VAR_2 . METHOD_2 ( ) . forEach ( VAR_4 - > VAR_1 . METHOD_3 ( METHOD_2 ( VAR_4 ) ) ) ; } } <END> return VAR_1 ; } | protected static TYPE_1 METHOD_1 ( TYPE_2 source ) { TYPE_1 VAR_1 = new TYPE_1 ( ) ; if ( source != null && source . VAR_3 ( ) != null ) { final TYPE_3 VAR_2 = source . VAR_3 ( ) ; VAR_2 . METHOD_2 ( ) . forEach ( VAR_4 - > VAR_1 . METHOD_3 ( METHOD_2 ( VAR_4 ) ) ) ; } return VAR_1 ; } |
t VAR_1 METHOD_2 ( Collections _CODE_ ( ) ) | public void METHOD_1 ( TYPE_1 < List < TYPE_2 > > VAR_1 ) { List < TYPE_2 > VAR_2 = new ArrayList < > ( ) ; <START> VAR_1 . METHOD_2 ( VAR_2 ) ; <END> } | public void METHOD_1 ( TYPE_1 < List < TYPE_2 > > VAR_1 ) { VAR_1 . METHOD_2 ( new ArrayList < > ( ) ) ; } |
I > 0 a list item 1 = work | private String METHOD_1 ( final String value ) { <START> if ( value != null && value . VAR_1 ( STRING_1 ) > 1 ) { <END> return value . substring ( 0 , value . VAR_1 ( STRING_1 ) ) ; } else { return value ; } } | private String METHOD_1 ( final String value ) { if ( value != null && value . VAR_1 ( STRING_1 ) > 0 ) { return value . substring ( 0 , value . VAR_1 ( STRING_1 ) ) ; } else { return value ; } } |
removed I | public void METHOD_1 ( ) { VAR_1 . METHOD_2 ( TYPE_1 . VAR_3 ) ; METHOD_3 ( VAR_1 , METHOD_4 ( 1 ) ) . METHOD_5 ( ) ; METHOD_3 ( VAR_1 , METHOD_4 ( 1 ) ) . METHOD_6 ( ) ; <START> METHOD_3 ( VAR_1 , METHOD_7 ( ) ) . METHOD_8 ( METHOD_9 ( true ) ) ; <END> } | public void METHOD_1 ( ) { VAR_1 . METHOD_2 ( TYPE_1 . VAR_3 ) ; METHOD_3 ( VAR_1 , METHOD_4 ( 1 ) ) . METHOD_5 ( ) ; METHOD_3 ( VAR_1 , METHOD_4 ( 1 ) ) . METHOD_6 ( ) ; } |
please enable run button background tab | public void METHOD_1 ( ) { METHOD_2 ( true ) ; <START> VAR_1 . METHOD_3 ( false ) ; <END> VAR_2 . METHOD_4 ( ) ; VAR_2 . METHOD_5 ( ) ; VAR_3 . METHOD_6 ( ) ; METHOD_7 ( TYPE_1 . VAR_5 ) ; } | public void METHOD_1 ( ) { METHOD_2 ( true ) ; VAR_2 . METHOD_4 ( ) ; VAR_2 . METHOD_5 ( ) ; VAR_3 . METHOD_6 ( ) ; METHOD_7 ( TYPE_1 . VAR_5 ) ; } |
final | protected void METHOD_1 ( ) { <START> String value = getValue ( ) ; <END> if ( ! value . startsWith ( VAR_1 ) ) { if ( value . startsWith ( VAR_2 ) ) { VAR_3 . METHOD_2 ( value . VAR_4 ( VAR_2 , VAR_1 ) ) ; } else if ( value . startsWith ( STRING_1 ) ) { VAR_3 . METHOD_2 ( value . VAR_4 ( STRING_1 , VAR_1 ) ) ; } else ... | protected void METHOD_1 ( ) { final String value = getValue ( ) ; if ( ! value . startsWith ( VAR_1 ) ) { if ( value . startsWith ( VAR_2 ) ) { VAR_3 . METHOD_2 ( value . VAR_4 ( VAR_2 , VAR_1 ) ) ; } else if ( value . startsWith ( STRING_1 ) ) { VAR_3 . METHOD_2 ( value . VAR_4 ( STRING_1 , VAR_1 ) ) ; } else { VAR_3 ... |
cast set _basedmntypeimpl_ type instead _dmntype_ | protected TYPE_1 METHOD_1 ( String VAR_1 , TYPE_2 type , TYPE_3 < String , TYPE_1 > VAR_2 , TYPE_1 . Type VAR_3 ) throws TYPE_4 { <START> return METHOD_2 ( ( TYPE_5 ) type ) ? METHOD_3 ( new HashMap < > ( ) , VAR_1 , type , VAR_2 , VAR_3 , new ArrayList < > ( ) ) : METHOD_4 ( new HashMap < > ( ) , VAR_1 , VAR_1 , type ... | protected TYPE_1 METHOD_1 ( String VAR_1 , TYPE_2 type , TYPE_3 < String , TYPE_1 > VAR_2 , TYPE_1 . Type VAR_3 ) throws TYPE_4 { return METHOD_2 ( type ) ? METHOD_3 ( new HashMap < > ( ) , VAR_1 , type , VAR_2 , VAR_3 , new ArrayList < > ( ) ) : METHOD_4 ( new HashMap < > ( ) , VAR_1 , VAR_1 , type . getName ( ) , typ... |
a small suggestion add a default new _CODE_ case add some new scenario type | public void METHOD_1 ( String VAR_1 ) { if ( VAR_2 != null ) { VAR_3 . METHOD_2 ( view . VAR_4 ( ) . METHOD_3 ( ) ) ; switch ( TYPE_1 . Type . valueOf ( VAR_1 ) ) { case VAR_6 : METHOD_4 ( ) ; break ; case VAR_7 : METHOD_5 ( ) ; <START> break ; <END> } VAR_2 . execute ( ) ; } } | public void METHOD_1 ( String VAR_1 ) { if ( VAR_2 != null ) { VAR_3 . METHOD_2 ( view . VAR_4 ( ) . METHOD_3 ( ) ) ; switch ( TYPE_1 . Type . valueOf ( VAR_1 ) ) { case VAR_6 : METHOD_4 ( ) ; break ; case VAR_7 : METHOD_5 ( ) ; break ; default : } VAR_2 . execute ( ) ; } } |
changed _public_ ? understand | <START> public void METHOD_1 ( final TYPE_1 < Path > VAR_1 ) { <END> final String VAR_2 = METHOD_2 ( VAR_1 ) ; METHOD_3 ( VAR_2 ) ; } | protected void METHOD_1 ( final TYPE_1 < Path > VAR_1 ) { final String VAR_2 = METHOD_2 ( VAR_1 ) ; METHOD_3 ( VAR_2 ) ; } |
cell | public void METHOD_1 ( ) { when ( VAR_1 . METHOD_2 ( ) ) . METHOD_3 ( Collections . VAR_2 ( ) ) ; <START> when ( VAR_1 . METHOD_4 ( ) ) . METHOD_3 ( TYPE_1 . create ( VAR_3 , VAR_4 ) ) ; <END> assertTrue ( VAR_5 . METHOD_5 ( VAR_6 ) ) ; } | public void METHOD_1 ( ) { when ( VAR_1 . METHOD_2 ( ) ) . METHOD_3 ( Collections . VAR_2 ( ) ) ; when ( VAR_1 . METHOD_4 ( ) ) . METHOD_3 ( Arrays . asList ( VAR_3 ) ) ; assertTrue ( VAR_5 . METHOD_5 ( VAR_6 ) ) ; } |
org drools core util StringUtils implementation | private boolean METHOD_1 ( final TYPE_1 VAR_1 ) { <START> return VAR_1 . METHOD_2 ( ) != null && ! VAR_1 . METHOD_2 ( ) . trim ( ) . isEmpty ( ) ; <END> } | private boolean METHOD_1 ( final TYPE_1 VAR_1 ) { return ! StringUtils . isEmpty ( VAR_1 . METHOD_2 ( ) ) ; } |
sake short codebase size ( ) = = 0 replaced isEmpty ( ) | protected boolean METHOD_1 ( TYPE_1 VAR_1 ) { return TYPE_2 . equals ( VAR_1 . METHOD_2 ( ) . getType ( ) ) || TYPE_3 . equals ( VAR_1 . METHOD_3 ( ) ) || <START> VAR_1 . METHOD_4 ( ) . size ( ) == 0 ; <END> } | public static boolean METHOD_1 ( TYPE_1 VAR_1 ) { return TYPE_2 . equals ( VAR_1 . METHOD_2 ( ) . getType ( ) ) || TYPE_3 . equals ( VAR_1 . METHOD_3 ( ) ) || VAR_1 . METHOD_4 ( ) . isEmpty ( ) ; } |
s removed METHOD_5 put current columns widht factmappings decided happen * * * * user saves scenario - rely status implementation manage | public void METHOD_1 ( int VAR_1 ) { METHOD_2 ( ) ; final TYPE_1 < ? > VAR_2 = METHOD_3 ( ) . get ( VAR_1 ) ; METHOD_1 ( VAR_2 ) ; VAR_3 . METHOD_4 ( VAR_1 ) ; <START> METHOD_5 ( ) ; <END> } | public void METHOD_1 ( int VAR_1 ) { METHOD_2 ( ) ; final TYPE_1 < ? > VAR_2 = METHOD_3 ( ) . get ( VAR_1 ) ; METHOD_1 ( VAR_2 ) ; VAR_3 . METHOD_4 ( VAR_1 ) ; } |
log necessary | public void METHOD_1 ( String VAR_1 ) { <START> TYPE_1 . log ( this . toString ( ) + STRING_1 + VAR_1 + STRING_2 ) ; <END> VAR_2 . METHOD_1 ( VAR_1 , METHOD_2 ( ) , METHOD_3 ( ) , context . getStatus ( ) . METHOD_4 ( ) ) ; } | public void METHOD_1 ( String VAR_1 ) { VAR_2 . METHOD_1 ( VAR_1 , METHOD_2 ( ) , METHOD_3 ( ) , context . getStatus ( ) . METHOD_4 ( ) ) ; } |
preventing move context VAR_2 ( ) METHOD_6 ( true ) ; METHOD_5 | public void METHOD_1 ( TYPE_1 event ) { context . getStatus ( ) . METHOD_2 ( String . valueOf ( new Date ( ) . METHOD_3 ( ) ) ) ; context . getStatus ( ) . METHOD_4 ( event . VAR_1 ( ) ) ; METHOD_5 ( context , new TYPE_2 ( ) ) ; <START> context . VAR_2 ( ) . METHOD_6 ( true ) ; <END> } | public void METHOD_1 ( TYPE_1 event ) { context . getStatus ( ) . METHOD_2 ( String . valueOf ( new Date ( ) . METHOD_3 ( ) ) ) ; context . getStatus ( ) . METHOD_4 ( event . VAR_1 ( ) ) ; METHOD_5 ( context , new TYPE_2 ( ) , true ) ; } |
want logging class asking log type resolved operator cell | public String getType ( final Optional < String > VAR_1 ) throws TYPE_1 { try { Logger . add ( STRING_1 ) ; if ( VAR_1 . isPresent ( ) ) { return VAR_2 . METHOD_1 ( ) ; } final String type = VAR_3 . getType ( VAR_2 , VAR_4 ) ; <START> Logger . add ( STRING_2 + type ) ; <END> return type ; } catch ( final Exception e ) ... | public String getType ( final Optional < String > VAR_1 ) throws TYPE_1 { try { if ( VAR_1 . isPresent ( ) ) { return VAR_2 . METHOD_1 ( ) ; } final String type = VAR_3 . getType ( VAR_2 , VAR_4 ) ; return type ; } catch ( final Exception e ) { throw new TYPE_1 ( STRING_3 + TYPE_2 . toString ( VAR_2 ) + STRING_4 + VAR_... |
util method * * delegation * * instead * * inheritance * * inheritance testeability | <START> protected TYPE_1 METHOD_1 ( Class VAR_1 ) { <END> String key = VAR_1 . METHOD_2 ( ) ; Map < String , String > VAR_2 = new HashMap < > ( ) ; String VAR_3 = VAR_1 . METHOD_3 ( ) ; VAR_2 . put ( STRING_1 , VAR_3 ) ; String VAR_4 = VAR_3 . substring ( 0 , VAR_3 . METHOD_4 ( STRING_2 ) ) ; return new TYPE_1 ( key , ... | protected static TYPE_1 METHOD_1 ( Class VAR_1 ) { String key = VAR_1 . METHOD_2 ( ) ; Map < String , String > VAR_2 = new HashMap < > ( ) ; String VAR_3 = VAR_1 . METHOD_3 ( ) ; VAR_2 . put ( STRING_1 , VAR_3 ) ; String VAR_4 = VAR_3 . substring ( 0 , VAR_3 . METHOD_4 ( STRING_2 ) ) ; return new TYPE_1 ( key , VAR_4 ,... |
defaults TYPE_1 set TYPE_1 constructor | public TYPE_1 build ( ) { List < TYPE_4 . TYPE_5 > VAR_1 = VAR_2 . build ( ) ; TYPE_3 VAR_3 = VAR_4 != null ? VAR_4 : new TYPE_3 ( ) ; TYPE_1 VAR_5 = new TYPE_1 ( VAR_1 , VAR_3 , VAR_6 , VAR_7 , VAR_8 , VAR_9 ) ; VAR_5 . METHOD_1 ( TYPE_4 . TYPE_6 . VAR_11 ) ; <START> VAR_5 . METHOD_2 ( VAR_6 ) ; <END> return VAR_5 ; } | public TYPE_1 build ( ) { List < TYPE_4 . TYPE_5 > VAR_1 = VAR_2 . build ( ) ; TYPE_3 VAR_3 = VAR_4 != null ? VAR_4 : new TYPE_3 ( ) ; return new TYPE_1 ( VAR_1 , VAR_3 , VAR_6 , VAR_7 , VAR_8 , VAR_9 ) ; } |
I prefer move methods simulation ( create methods change package private ) remove existing related _CODE_ scenario s remove header easy forget cleanup scenario s inconsistent data | <START> public void METHOD_1 ( TYPE_1 VAR_1 ) { <END> VAR_2 . remove ( VAR_1 ) ; } | void METHOD_1 ( TYPE_1 VAR_1 ) { VAR_2 . remove ( VAR_1 ) ; } |
worth resources : javatry ( final TYPE_2 VAR_1 = VAR_2 METHOD_2 ( path TYPE_4 VAR_4 ) ) { final String VAR_5 = TYPE_3 METHOD_3 ( VAR_1 null ) ; return METHOD_4 ( path VAR_5 ) ; } | public TYPE_1 METHOD_1 ( final Path path ) throws Exception { TYPE_2 VAR_1 = null ; try { VAR_1 = VAR_2 . METHOD_2 ( path , TYPE_4 . VAR_4 ) ; <START> final String VAR_5 = TYPE_3 . METHOD_3 ( VAR_1 , <END> null ) ; return METHOD_4 ( path , VAR_5 ) ; } finally { if ( VAR_1 != null ) { try { VAR_1 . close ( ) ; } catch (... | public TYPE_1 METHOD_1 ( final Path path ) throws Exception { try ( final TYPE_2 VAR_1 = VAR_2 . METHOD_2 ( path , TYPE_4 . VAR_4 ) ) { final String VAR_5 = TYPE_3 . METHOD_3 ( VAR_1 , null ) ; return METHOD_4 ( path , VAR_5 ) ; } } |
super ( VAR_5 ) provide view base set view class don t need cast actual view | public TYPE_6 ( final TYPE_1 < TYPE_2 > VAR_2 , final TYPE_3 type , final TYPE_4 VAR_3 , final TYPE_5 VAR_4 ) { super ( ) ; <START> this . VAR_5 = METHOD_1 ( ) ; <END> this . VAR_2 = VAR_2 ; this . type = type ; this . VAR_3 = VAR_3 ; this . VAR_4 = VAR_4 ; } | public TYPE_6 ( final TYPE_1 < TYPE_2 > VAR_2 , final TYPE_3 type , final TYPE_4 VAR_3 , final TYPE_5 VAR_4 ) { super ( ) ; this . view = METHOD_1 ( ) ; this . VAR_5 = view ; this . VAR_2 = VAR_2 ; this . type = type ; this . VAR_3 = VAR_3 ; this . VAR_4 = VAR_4 ; } |
correct method ! ? I ( code ) show a popup restore file current version other editors VAR_2 _CODE_ ( path ) ; save success callbacks want check XLS score card editor upload file editor similar problems I ll compile PR _see_ s ; case code review misguided | void METHOD_1 ( ) { view . VAR_1 ( VAR_2 . METHOD_2 ( ) ) ; <START> VAR_2 . METHOD_3 ( ) ; <END> VAR_3 = null ; } | void METHOD_1 ( ) { view . VAR_1 ( VAR_2 . METHOD_2 ( ) ) ; VAR_3 = null ; } |
I don t s easy : - ( IMO abuse _CODE_ tweaking s visual appearance class ( adding a _CODE_ ( boolean ) acceptable ) brings | public TYPE_4 ( ) { super ( ) ; setText ( TYPE_2 . TYPE_3 . METHOD_1 ( ) ) ; METHOD_2 ( TYPE_2 . TYPE_3 . METHOD_3 ( ) ) ; METHOD_4 ( ( VAR_2 ) - > { <START> VAR_3 . METHOD_5 ( ) . METHOD_6 ( ) . METHOD_7 ( STRING_1 , <END> STRING_2 ) ; VAR_3 . METHOD_8 ( ( VAR_4 ) - > VAR_5 . execute ( ) ) ; } ) ; } | public TYPE_4 ( ) { } |
want ideally package protected | <START> public TYPE_1 METHOD_1 ( String [ ] VAR_1 , <END> TYPE_2 VAR_2 ) { return new TYPE_1 ( VAR_1 , VAR_2 ) ; } | TYPE_1 METHOD_1 ( String [ ] VAR_1 , TYPE_2 VAR_2 ) { return new TYPE_1 ( VAR_1 , VAR_2 ) ; } |
Collections _CODE_ ( VAR_2 ) | public static void METHOD_1 ( final String VAR_1 , final Set < TYPE_1 > result , final int VAR_2 ) { METHOD_2 ( STRING_1 + VAR_1 , result . stream ( ) . filter ( VAR_3 - > METHOD_3 ( VAR_3 , VAR_1 ) && METHOD_4 ( VAR_3 , <START> new HashSet < Integer > ( ) { { <END> add ( VAR_2 ) ; } } ) ) . count ( ) > 0 ) ; } | public static void METHOD_1 ( final String VAR_1 , final Set < TYPE_1 > result , final int VAR_2 ) { METHOD_2 ( STRING_1 + VAR_1 , result . stream ( ) . filter ( VAR_3 - > METHOD_3 ( VAR_3 , VAR_1 ) ) . filter ( VAR_3 - > METHOD_4 ( VAR_3 , Arrays . asList ( VAR_2 ) ) ) . count ( ) > 0 ) ; } |
considered a strange implementation MVP ; P calling METHOD_1 ( ) calls METHOD_2 ( ) calls P call METHOD_2 some UI elements P call perform complete METHOD_2 call P call complete METHOD_2 ? I miss | public void METHOD_1 ( final TYPE_1 page ) { this . page = page ; clear ( ) ; <START> METHOD_2 ( ) ; <END> } | public void METHOD_1 ( final TYPE_1 page ) { this . page = page ; } |
a unwinding I code | private void METHOD_1 ( ) { final String VAR_1 = METHOD_2 ( TYPE_2 . TYPE_1 ) ; VAR_4 . clear ( ) ; VAR_4 . METHOD_3 ( STRING_1 + VAR_1 + STRING_2 , "" ) ; <START> page . VAR_5 ( VAR_6 - > VAR_4 . METHOD_3 ( VAR_6 ) ) ; <END> VAR_4 . METHOD_4 ( METHOD_5 ( METHOD_6 ( ) , VAR_4 ) ) ; } | public void METHOD_1 ( ) { final String VAR_1 = METHOD_2 ( TYPE_2 . TYPE_1 ) ; VAR_4 . clear ( ) ; VAR_4 . METHOD_3 ( STRING_1 + VAR_1 + STRING_2 , "" ) ; } |
GWT client side METHOD_1 tend trouble workaround | public int METHOD_1 ( ) { int result = VAR_1 != null ? VAR_1 . METHOD_1 ( ) : 0 ; result = INT_1 * result + ( VAR_2 != null ? VAR_2 . METHOD_1 ( ) : 0 ) ; result = INT_1 * result + ( VAR_3 != null ? VAR_3 . METHOD_1 ( ) : 0 ) ; result = INT_1 * result + ( VAR_4 != null ? VAR_4 . METHOD_1 ( ) : 0 ) ; <START> return resu... | public int METHOD_1 ( ) { int result = VAR_1 != null ? ~ ~ VAR_1 . METHOD_1 ( ) : 0 ; result = INT_1 * result + ( VAR_2 != null ? ~ ~ VAR_2 . METHOD_1 ( ) : 0 ) ; result = INT_1 * result + ( VAR_3 != null ? ~ ~ VAR_3 . METHOD_1 ( ) : 0 ) ; result = INT_1 * result + ( VAR_4 != null ? ~ ~ VAR_4 . METHOD_1 ( ) : 0 ) ; ret... |
I m scared stupid result = result VAR_2 implementations happy ll scratching head _if_ _CODE_ start rolling V&V crazy a | public int METHOD_1 ( ) { int result = VAR_1 . METHOD_1 ( ) ; <START> result = INT_1 * result + name . VAR_2 ( ) ; <END> return result ; } | public int METHOD_1 ( ) { int result = ~ ~ VAR_1 . METHOD_1 ( ) ; result = INT_1 * result + ~ ~ name . VAR_2 ( ) ; return ~ ~ result ; } |
I missed time d remove type logging ( I assume added debug tests ) | protected String [ ] METHOD_1 ( ) { <START> System . out . println ( STRING_1 ) ; <END> return VAR_1 ; } | protected String [ ] METHOD_1 ( ) { return VAR_1 ; } |
find analysis panel starts a bit loopy ( IIRC ) want check METHOD_1 implementations - result = result type construct I dig original email | public int METHOD_1 ( ) { <START> return INT_1 * VAR_1 . METHOD_1 ( ) + VAR_2 . METHOD_1 ( ) ; <END> } | public int METHOD_1 ( ) { final int result = INT_1 * VAR_1 . METHOD_1 ( ) + VAR_2 . METHOD_1 ( ) ; return ~ ~ result ; } |
parameters TYPE_1 constructor lambda expressions statement shorter | void METHOD_1 ( ) { VAR_1 . METHOD_2 ( new TYPE_1 ( VAR_2 , parent . VAR_3 ( ) . METHOD_3 ( ) , VAR_4 , new TYPE_1 . TYPE_4 ( ) { @Override public String METHOD_4 ( ) { return VAR_2 . METHOD_5 ( ) + STRING_1 + VAR_5 . METHOD_6 ( ) ; } } , new TYPE_3 ( ) { @Override public void run ( ) { } <START> } ) , <END> parent ) ;... | void METHOD_1 ( ) { VAR_1 . METHOD_2 ( new TYPE_1 ( VAR_2 , parent . VAR_3 ( ) . METHOD_3 ( ) , VAR_4 , ( ) - > VAR_2 . METHOD_5 ( ) + STRING_1 + VAR_5 . METHOD_6 ( ) , ( ) - > { } ) , parent ) ; } |
replace : return VAR_1 [ 0 ] METHOD_2 ( ) getName ( ) equals ( VAR_1 [ 0 ] METHOD_3 ( ) getName ( ) ) ( s need / else ) | private boolean METHOD_1 ( TYPE_1 [ ] VAR_1 ) { <START> if ( VAR_1 [ 0 ] . METHOD_2 ( ) . getName ( ) . equals ( VAR_1 [ 0 ] . METHOD_3 ( ) . getName ( ) ) ) { <END> return true ; } else { return false ; } } | private boolean METHOD_1 ( TYPE_1 [ ] VAR_1 ) { return VAR_1 [ 0 ] . METHOD_2 ( ) . getName ( ) . equals ( VAR_1 [ 0 ] . METHOD_3 ( ) . getName ( ) ) && VAR_1 . length == 1 ; } |
method equals ( ) instead = = | private int METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 < TYPE_1 > VAR_2 , int val ) { int VAR_3 ; <START> if ( VAR_2 == TYPE_3 . METHOD_2 ( ) ) { VAR_3 = TYPE_4 . METHOD_3 ( VAR_4 . METHOD_4 ( VAR_1 , val , true ) ) ; } else if ( VAR_2 == TYPE_3 . METHOD_5 ( ) ) { <END> VAR_3 = VAR_4 . METHOD_4 ( VAR_1 , val , true ) ; } else { ... | private int METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 < TYPE_1 > VAR_2 , int val ) { int VAR_3 ; if ( TYPE_3 . METHOD_2 ( ) . equals ( VAR_2 ) ) { VAR_3 = TYPE_4 . METHOD_3 ( VAR_4 . METHOD_4 ( VAR_1 , val , true ) ) ; } else if ( TYPE_3 . METHOD_5 ( ) . equals ( VAR_2 ) ) { VAR_3 = VAR_4 . METHOD_4 ( VAR_1 , val , true ) ; } e... |
remove VAR_2 attribute | public int METHOD_1 ( int VAR_1 ) { <START> if ( VAR_2 ) { <END> return TYPE_1 . METHOD_2 ( ) ; } return TYPE_1 . METHOD_3 ( ) ; } | public int METHOD_1 ( int VAR_1 ) { return TYPE_1 . METHOD_3 ( ) ; } |
I suggest : ( VAR_2 METHOD_3 ( i ) size ( ) = = 0 || VAR_2 METHOD_4 ( i ) size ( ) = = 0 ) { | private void METHOD_1 ( TYPE_1 VAR_1 ) { for ( int i = VAR_1 . METHOD_2 ( 0 ) ; i >= 0 ; i = VAR_1 . METHOD_2 ( i + 1 ) ) { <START> if ( VAR_2 . METHOD_3 ( i ) . size ( ) * VAR_2 . METHOD_4 ( i ) . size ( ) == 0 ) { <END> VAR_3 [ i ] = VAR_4 ; VAR_5 [ VAR_4 ++ ] = i ; VAR_1 . clear ( i ) ; } } } | private void METHOD_1 ( TYPE_1 VAR_1 ) { for ( int i = VAR_1 . METHOD_2 ( 0 ) ; i >= 0 ; i = VAR_1 . METHOD_2 ( i + 1 ) ) { if ( VAR_2 . METHOD_3 ( i ) . size ( ) == 0 || VAR_2 . METHOD_4 ( i ) . size ( ) == 0 ) { VAR_3 [ i ] = VAR_4 ; VAR_5 [ VAR_4 ++ ] = i ; VAR_1 . clear ( i ) ; } } } |
catch needed | public static void METHOD_1 ( ByteBuffer buffer ) { try { if ( buffer . VAR_1 ( ) ) { METHOD_2 ( ( TYPE_1 ) buffer ) ; } } <START> catch ( Exception e ) { <END> throw TYPE_2 . METHOD_3 ( e ) ; } } | public static void METHOD_1 ( ByteBuffer buffer ) { if ( buffer . VAR_1 ( ) ) { METHOD_2 ( ( TYPE_1 ) buffer ) ; } } |
Boolean boolean | <START> public static Boolean METHOD_1 ( String VAR_1 ) <END> { if ( TYPE_1 . METHOD_2 ( VAR_1 ) ) { return false ; } return VAR_1 . METHOD_3 ( VAR_2 ) ; } | public static boolean METHOD_1 ( String VAR_1 ) { if ( TYPE_1 . METHOD_2 ( VAR_1 ) ) { return false ; } return VAR_1 . METHOD_3 ( VAR_2 ) ; } |
logic zip | public static Boolean METHOD_1 ( String VAR_1 ) { if ( TYPE_1 . METHOD_2 ( VAR_1 ) ) { return false ; } <START> return VAR_1 . METHOD_3 ( TYPE_2 ) && VAR_1 . length ( ) > TYPE_2 . length ( ) ; <END> } | public static boolean METHOD_1 ( String VAR_1 ) { if ( TYPE_1 . METHOD_2 ( VAR_1 ) ) { return false ; } return VAR_1 . METHOD_3 ( TYPE_2 ) && VAR_1 . length ( ) > TYPE_2 . length ( ) ; } |
private _CODE_ public | <START> private void METHOD_1 ( Collection < File > VAR_1 ) <END> { if ( VAR_1 == null || VAR_1 . isEmpty ( ) ) { return ; } long size = INT_1 ; for ( File file : VAR_1 ) { size += file . length ( ) ; } this . VAR_1 . addAll ( VAR_1 ) ; this . size += size ; } | protected void METHOD_1 ( Collection < File > VAR_1 ) { if ( VAR_1 == null || VAR_1 . isEmpty ( ) ) { return ; } long size = INT_1 ; for ( File file : VAR_1 ) { size += file . length ( ) ; } this . VAR_1 . addAll ( VAR_1 ) ; this . size += size ; } |
resources | public static void METHOD_1 ( TYPE_1 is , File file ) throws IOException { TYPE_2 VAR_1 = null ; try { file . VAR_2 ( ) . METHOD_2 ( ) ; VAR_1 = new TYPE_3 ( new TYPE_4 ( file ) ) ; TYPE_5 . METHOD_3 ( is , VAR_1 ) ; } finally { TYPE_6 . close ( is ) ; <START> TYPE_6 . close ( VAR_1 ) ; <END> } } | public static void METHOD_1 ( TYPE_1 is , File file ) throws IOException { file . VAR_2 ( ) . METHOD_2 ( ) ; try ( TYPE_2 VAR_1 = new TYPE_3 ( new TYPE_4 ( file ) ) ) { TYPE_5 . METHOD_3 ( is , VAR_1 ) ; } finally { TYPE_6 . close ( is ) ; } } |
TYPE_1 a runtime exception don t need declare | <START> public void METHOD_1 ( String VAR_1 ) throws TYPE_1 <END> { try { METHOD_1 ( VAR_2 . split ( VAR_1 ) ) ; } catch ( Exception e ) { TYPE_2 . METHOD_2 ( e , TYPE_1 . class ) ; throw new TYPE_1 . Builder ( ) . METHOD_3 ( TYPE_1 . TYPE_3 . VAR_4 ) . METHOD_4 ( e . getMessage ( ) ) . build ( ) ; } } | public void METHOD_1 ( String VAR_1 ) { try { METHOD_1 ( VAR_2 . split ( VAR_1 ) ) ; } catch ( Exception e ) { TYPE_2 . METHOD_2 ( e , TYPE_1 . class ) ; throw new TYPE_1 . Builder ( ) . METHOD_3 ( TYPE_1 . TYPE_3 . VAR_4 ) . METHOD_4 ( e . getMessage ( ) ) . build ( ) ; } } |
want avoid returning optional collection return empty collection | <START> public Optional < Collection < TYPE_1 > > METHOD_1 ( TYPE_2 VAR_1 ) { <END> return VAR_2 . METHOD_1 ( VAR_1 ) ; } | public Collection < TYPE_1 > METHOD_1 ( TYPE_2 VAR_1 ) { return VAR_2 . METHOD_1 ( VAR_1 ) ; } |
_CODE_ instead ? list necessary instead set | public void METHOD_1 ( boolean VAR_1 ) { if ( this . VAR_1 != VAR_1 ) { logger . info ( STRING_1 , VAR_1 ) ; this . VAR_1 = VAR_1 ; List < TYPE_1 < TYPE_2 > > VAR_2 = new ArrayList < TYPE_1 < TYPE_2 > > ( ) ; <START> VAR_2 . add ( TYPE_1 . of ( VAR_3 , TYPE_3 . METHOD_2 ( ) ) ) ; <END> VAR_4 . METHOD_3 ( VAR_2 ) ; } } | public void METHOD_1 ( boolean VAR_1 ) { if ( this . VAR_1 != VAR_1 ) { logger . info ( STRING_1 , VAR_1 ) ; this . VAR_1 = VAR_1 ; List < TYPE_1 < TYPE_2 > > VAR_2 = ImmutableList . of ( TYPE_1 . of ( VAR_3 , TYPE_3 . METHOD_2 ( ) ) ) ; VAR_4 . METHOD_3 ( VAR_2 ) ; } } |
d a logger ignore exception propagate exception throwables propagate | public void METHOD_1 ( String id ) { try { METHOD_2 ( id ) ; VAR_1 . apply ( id ) ; } catch ( Exception e ) { <START> e . VAR_2 ( ) ; <END> } VAR_3 . METHOD_3 ( ) . METHOD_4 ( id ) ; String VAR_4 = VAR_5 . apply ( id ) ; VAR_6 . apply ( VAR_4 ) ; } | public void METHOD_1 ( String id ) { METHOD_2 ( id ) ; VAR_1 . apply ( id ) ; VAR_3 . METHOD_3 ( ) . METHOD_4 ( id ) ; String VAR_4 = VAR_5 . apply ( id ) ; VAR_6 . apply ( VAR_4 ) ; } |
[ curiosity ] expected beans registered VAR_2 set | public synchronized void METHOD_1 ( TYPE_1 VAR_1 , String name ) { <START> if ( VAR_2 != null ) { <END> TYPE_2 . METHOD_2 ( VAR_2 , VAR_1 , VAR_1 . getType ( ) , name ) ; } VAR_3 . put ( new TYPE_3 ( VAR_1 , name ) , VAR_1 ) ; } | public synchronized void METHOD_1 ( TYPE_1 VAR_1 , String name ) { if ( VAR_2 . isPresent ( ) ) { TYPE_2 . METHOD_2 ( VAR_2 . get ( ) , VAR_1 , VAR_1 . getType ( ) , name ) ; } VAR_3 . put ( new TYPE_3 ( VAR_1 , name ) , VAR_1 ) ; } |
slight perf cost resource bundles resolve languages calls METHOD_1 ( ) I m case done _CODE_ ( ) properly resolves label | public TYPE_1 METHOD_1 ( ) { if ( VAR_1 == null ) { String VAR_2 = context . VAR_3 ( ) . METHOD_2 ( ) ; if ( VAR_2 != null ) { <START> VAR_1 = METHOD_3 ( VAR_2 ) ; <END> } else if ( context . getId ( ) != null ) { Map < TYPE_2 , TYPE_5 . TYPE_6 > VAR_4 = VAR_5 . METHOD_4 ( context . getId ( ) ) ; VAR_1 = TYPE_4 . METHO... | public TYPE_1 METHOD_1 ( ) { if ( VAR_1 == null ) { String VAR_2 = context . VAR_3 ( ) . METHOD_2 ( ) ; if ( VAR_2 != null ) { VAR_1 = VAR_5 . METHOD_3 ( VAR_2 ) ; } else if ( context . getId ( ) != null ) { Map < TYPE_2 , TYPE_5 . TYPE_6 > VAR_4 = VAR_5 . METHOD_4 ( context . getId ( ) ) ; VAR_1 = TYPE_4 . METHOD_5 ( ... |
access modifier method visible package subclasses classes package want | <START> TYPE_1 METHOD_1 ( ) { <END> return props ; } | public TYPE_1 METHOD_1 ( ) { return props ; } |
definition class session based ( _CODE_ ) change synchronizing entire _CODE_ instance removing a domain user session ends blocking another user another session storing domain removing model I don t understand done level synchronization required I don t suspect s specifically multi - threaded testing methods synchronize... | <START> public synchronized void METHOD_1 ( final String VAR_1 ) { <END> VAR_2 . METHOD_1 ( VAR_1 ) ; METHOD_2 ( VAR_1 ) ; METHOD_3 ( VAR_1 ) ; } | public void METHOD_1 ( final String VAR_1 ) { VAR_2 . METHOD_1 ( VAR_1 ) ; METHOD_2 ( VAR_1 ) ; METHOD_3 ( VAR_1 ) ; } |
File object construct VAR_8 file : new File ( VAR_1 VAR_7 + etx ) ; | private void METHOD_1 ( String VAR_1 , boolean VAR_2 ) { String VAR_3 = VAR_4 ; if ( VAR_2 ) { VAR_3 = VAR_5 ; } String VAR_6 = VAR_1 + VAR_7 + VAR_3 ; <START> File VAR_8 = new File ( VAR_6 ) ; <END> try { if ( ! VAR_8 . METHOD_2 ( ) ) { logger . error ( Messages . getInstance ( ) . METHOD_3 ( STRING_1 ) ) ; } } catch ... | private void METHOD_1 ( String VAR_1 , boolean VAR_2 ) { String VAR_3 = VAR_4 ; if ( VAR_2 ) { VAR_3 = VAR_5 ; } File VAR_8 = new File ( VAR_1 , VAR_7 + VAR_3 ) ; try { if ( ! VAR_8 . METHOD_2 ( ) ) { logger . error ( Messages . getInstance ( ) . METHOD_3 ( STRING_1 ) ) ; } } catch ( IOException e ) { logger . error ( ... |
please remove unused b r | public boolean METHOD_1 ( TYPE_1 node ) { if ( METHOD_2 ( node , STRING_1 , STRING_2 , STRING_3 ) ) { final TYPE_2 b = this . ctx . VAR_1 ( ) ; <START> final TYPE_3 r = this . ctx . VAR_2 ( ) ; <END> node . VAR_3 ( new TYPE_4 ( this . ctx , node ) ) ; } return VAR_4 ; } | public boolean METHOD_1 ( TYPE_1 node ) { if ( METHOD_2 ( node , STRING_1 , STRING_2 , STRING_3 ) ) { node . VAR_3 ( new TYPE_4 ( this . ctx , node ) ) ; } return VAR_4 ; } |
please change TYPE_2 methods fields static imports | public boolean METHOD_1 ( TYPE_1 node ) { <START> if ( TYPE_2 . METHOD_2 ( node . VAR_1 ( ) , VAR_2 ) ) { <END> return VAR_3 ; } return VAR_4 ; } | public boolean METHOD_1 ( TYPE_1 node ) { if ( METHOD_2 ( node . VAR_1 ( ) , VAR_2 ) ) { return VAR_3 ; } return VAR_4 ; } |
apparently bad practice : * I worried a I _CODE_ i e a / finally block | public void METHOD_1 ( TYPE_1 db , long VAR_1 ) { TYPE_2 VAR_2 = db . query ( STRING_1 , new String [ ] { STRING_2 } , STRING_3 , new String [ ] { Long . toString ( VAR_1 ) } , null , null , null ) ; <START> VAR_2 . close ( ) ; <END> } | public void METHOD_1 ( TYPE_1 db , long VAR_1 ) { TYPE_2 VAR_2 = db . query ( STRING_1 , new String [ ] { STRING_2 } , STRING_3 , new String [ ] { Long . toString ( VAR_1 ) } , null , null , null ) ; if ( VAR_2 != null ) { VAR_2 . close ( ) ; } } |
I disagree changes VAR_3 section please revert highlight fact VAR_3 code missing check _CODE_ ( _CODE_ ) isEmpty ( ) | public String METHOD_1 ( ) { String VAR_1 = STRING_1 + TYPE_1 . this + TYPE_1 . VAR_3 + this ; <START> String VAR_4 = TYPE_1 . VAR_3 + STRING_1 + this ; <END> return VAR_1 + VAR_4 ; } | public String METHOD_1 ( ) { String VAR_1 = String . valueOf ( TYPE_1 . VAR_3 ) + TYPE_1 . VAR_3 + this ; String VAR_4 = String . valueOf ( TYPE_1 . VAR_3 ) + this ; return VAR_1 + VAR_4 ; } |
please change code match replaced I wanted exception thrown | public Boolean METHOD_1 ( boolean VAR_1 ) { class TYPE_1 { Boolean b ; } TYPE_1 VAR_2 = new TYPE_1 ( ) ; Boolean VAR_3 = Boolean . VAR_4 ; <START> return VAR_1 ? VAR_2 . b : VAR_3 ; <END> } | public Boolean METHOD_1 ( boolean VAR_1 ) { class TYPE_1 { Boolean b ; } TYPE_1 VAR_2 = new TYPE_1 ( ) ; return VAR_1 ? VAR_2 . b : Boolean . VAR_4 ; } |
please move METHOD_1 ( TYPE_1 ) METHOD_1 ( TYPE_2 ) helps reading code top ( clean code book uncle bob ) diff | public static boolean METHOD_1 ( TYPE_1 node , String VAR_1 , <START> String VAR_2 , String ... VAR_3 ) { <END> if ( node == null ) { return false ; } final TYPE_2 VAR_4 = node . VAR_5 ( ) ; return METHOD_1 ( VAR_4 , VAR_1 , VAR_2 , VAR_3 ) ; } | public static boolean METHOD_1 ( TYPE_1 node , String VAR_1 , String VAR_2 , String ... VAR_3 ) { return node != null && METHOD_1 ( node . VAR_5 ( ) , VAR_1 , VAR_2 , VAR_3 ) ; } |
VAR_3 created lazy | private void METHOD_1 ( TYPE_3 . TYPE_4 VAR_1 ) { if ( position != null && ! position . VAR_2 . equals ( VAR_1 ) ) { <START> TYPE_2 VAR_3 = new TYPE_2 ( position . offset , position . VAR_4 , VAR_1 ) ; <END> METHOD_2 ( TYPE_5 . VAR_6 , ( ) - > { this . position = VAR_3 ; this . VAR_7 = null ; } ) ; } } | private void METHOD_1 ( TYPE_3 . TYPE_4 VAR_1 ) { if ( position != null ) { TYPE_2 VAR_3 = new TYPE_2 ( position . offset , position . VAR_4 , VAR_1 ) ; METHOD_2 ( TYPE_5 . VAR_6 , ( ) - > { this . position = VAR_3 ; this . VAR_7 = null ; } ) ; } } |
return VAR_3 SUSPENDED | private Map < TYPE_1 , Long > METHOD_1 ( ) { <START> if ( state ( ) == TYPE_2 . VAR_2 ) { <END> return Collections . VAR_3 ( ) ; } final Map < TYPE_1 , Long > VAR_4 = new HashMap < > ( VAR_5 . METHOD_2 ( ) ) ; for ( final Map . Entry < TYPE_1 , Long > entry : VAR_6 . entrySet ( ) ) { VAR_4 . METHOD_3 ( entry . getKey (... | private Map < TYPE_1 , Long > METHOD_1 ( ) { final Map < TYPE_1 , Long > VAR_4 = new HashMap < > ( VAR_5 . METHOD_2 ( ) ) ; for ( final Map . Entry < TYPE_1 , Long > entry : VAR_6 . entrySet ( ) ) { VAR_4 . METHOD_3 ( entry . getKey ( ) , entry . getValue ( ) ) ; } return VAR_4 ; } |
a step wrap a TYPE_2 immediately unwrap | private Map < TYPE_1 , Long > METHOD_1 ( final Set < TYPE_1 > VAR_1 ) { final Map < TYPE_1 , Long > VAR_2 ; try { VAR_2 = METHOD_2 ( VAR_1 , VAR_3 ) ; } catch ( final TYPE_2 e ) { <START> if ( e . VAR_4 ( ) instanceof TYPE_3 ) { <END> return Collections . VAR_5 ( ) ; } else { throw e ; } } VAR_6 = time . VAR_7 ( ) ; re... | private Map < TYPE_1 , Long > METHOD_1 ( final Set < TYPE_1 > VAR_1 ) { final Map < TYPE_1 , Long > VAR_2 ; try { VAR_2 = METHOD_2 ( VAR_1 , VAR_3 ) ; } catch ( final TYPE_3 e ) { return Collections . VAR_5 ( ) ; } VAR_6 = time . VAR_7 ( ) ; return VAR_2 ; } |
pass MAX_VALUE avoid introducing test flakyness | public void METHOD_1 ( ) { final TYPE_1 VAR_1 = TYPE_2 . METHOD_2 ( TYPE_3 . class ) ; TYPE_2 . METHOD_3 ( VAR_1 . METHOD_4 ( TYPE_2 . METHOD_5 ( ) ) ) . METHOD_6 ( new RuntimeException ( ) ) ; METHOD_7 ( VAR_1 ) ; <START> METHOD_8 ( TYPE_4 . class , ( ) - > METHOD_9 ( METHOD_10 ( ) , VAR_1 , INT_1 ) ) ; <END> METHOD_1... | public void METHOD_1 ( ) { final TYPE_1 VAR_1 = TYPE_2 . METHOD_2 ( TYPE_3 . class ) ; TYPE_2 . METHOD_3 ( VAR_1 . METHOD_4 ( TYPE_2 . METHOD_5 ( ) ) ) . METHOD_6 ( new RuntimeException ( ) ) ; METHOD_7 ( VAR_1 ) ; METHOD_8 ( TYPE_4 . class , ( ) - > METHOD_9 ( METHOD_10 ( ) , VAR_1 ) ) ; METHOD_11 ( VAR_1 ) ; } |
trim ? suggestionthis VAR_6 = VAR_3 VAR_6 ( ) trim ( ) ; | TYPE_6 ( TYPE_1 < byte [ ] , byte [ ] > VAR_2 , TYPE_2 VAR_3 , TYPE_3 id , TYPE_4 VAR_4 ) { TYPE_5 . METHOD_1 ( VAR_2 ) ; TYPE_5 . METHOD_1 ( VAR_3 ) ; TYPE_5 . METHOD_1 ( id ) ; TYPE_5 . METHOD_1 ( VAR_4 ) ; this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; this . VAR_5 = id ; this . VAR_4 = VAR_4 ; <START> this . VAR_6 =... | TYPE_6 ( TYPE_1 < byte [ ] , byte [ ] > VAR_2 , TYPE_2 VAR_3 , TYPE_3 id , TYPE_4 VAR_4 ) { TYPE_5 . METHOD_1 ( VAR_2 ) ; TYPE_5 . METHOD_1 ( VAR_3 ) ; TYPE_5 . METHOD_1 ( id ) ; TYPE_5 . METHOD_1 ( VAR_4 ) ; this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; this . VAR_5 = id ; this . VAR_4 = VAR_4 ; this . VAR_6 = VAR_3 .... |
s protected suggestionprotected TYPE_6 ( TYPE_1 < byte [ ] byte [ ] > VAR_2 String VAR_3 | <START> public TYPE_6 ( TYPE_1 < byte [ ] , byte [ ] > VAR_2 , String VAR_3 , <END> int VAR_4 , TYPE_2 VAR_5 , Object key , TYPE_2 VAR_6 , Object value , long VAR_7 , Long VAR_8 , TYPE_3 VAR_9 , TYPE_4 < TYPE_5 > VAR_10 ) { super ( VAR_3 , VAR_4 , VAR_5 , key , VAR_6 , value , VAR_7 , VAR_8 , VAR_9 , VAR_10 ) ; this . ... | protected TYPE_6 ( TYPE_1 < byte [ ] , byte [ ] > VAR_2 , String VAR_3 , int VAR_4 , TYPE_2 VAR_5 , Object key , TYPE_2 VAR_6 , Object value , long VAR_7 , Long VAR_8 , TYPE_3 VAR_9 , TYPE_4 < TYPE_5 > VAR_10 ) { super ( VAR_3 , VAR_4 , VAR_5 , key , VAR_6 , value , VAR_7 , VAR_8 , VAR_9 , VAR_10 ) ; this . VAR_2 = VAR... |
initialization required | public void METHOD_1 ( ) { <START> TYPE_1 < ? > VAR_1 = null ; <END> while ( ( VAR_1 = VAR_2 . METHOD_2 ( ) ) != null ) { try { VAR_1 . get ( ) ; } catch ( InterruptedException | TYPE_2 e ) { log . error ( STRING_1 ) ; throw new TYPE_3 ( e ) ; } } } | public void METHOD_1 ( ) { TYPE_1 < ? > VAR_1 ; while ( ( VAR_1 = VAR_2 . METHOD_2 ( ) ) != null ) { try { VAR_1 . get ( ) ; } catch ( InterruptedException | TYPE_2 e ) { log . error ( STRING_1 ) ; throw new TYPE_3 ( e ) ; } } } |
I want check instead key ? suggestionreturn record ( ) = = null ; | public boolean METHOD_1 ( R record ) { <START> return record . key ( ) == null ; <END> } | public boolean METHOD_1 ( R record ) { return record . value ( ) == null ; } |
throw exception replace null empty string | public TYPE_2 ( String VAR_2 ) { <START> TYPE_1 . METHOD_1 ( VAR_2 ) ; <END> this . VAR_2 = VAR_2 ; } | public TYPE_2 ( String VAR_2 ) { this . VAR_2 = VAR_2 != null ? VAR_2 : "" ; } |
don t need check VAR_1 = = null condition check covers | public boolean equals ( Object VAR_1 ) { if ( this == VAR_1 ) { return true ; } <START> if ( VAR_1 == null || ! ( VAR_1 instanceof TYPE_1 ) ) { <END> return false ; } final TYPE_1 that = ( TYPE_1 ) VAR_1 ; return TYPE_2 . equals ( this . VAR_2 , that . VAR_2 ) ; } | public boolean equals ( Object VAR_1 ) { if ( this == VAR_1 ) { return true ; } if ( ! ( VAR_1 instanceof TYPE_1 ) ) { return false ; } final TYPE_1 that = ( TYPE_1 ) VAR_1 ; return TYPE_2 . equals ( this . VAR_2 , that . VAR_2 ) ; } |
check replicate a bit s happening _CODE_ pass validations | public TYPE_1 METHOD_1 ( int VAR_1 ) { <START> if ( VAR_1 == VAR_2 ) { <END> return METHOD_2 ( ) ; } this . VAR_1 = VAR_1 ; return this ; } | public TYPE_1 METHOD_1 ( int VAR_1 ) { this . VAR_1 = VAR_1 ; return this ; } |
question | public TYPE_1 METHOD_1 ( short VAR_1 ) { <START> if ( VAR_1 == VAR_2 ) { <END> return METHOD_2 ( ) ; } this . VAR_1 = VAR_1 ; return this ; } | public TYPE_1 METHOD_1 ( short VAR_1 ) { this . VAR_1 = VAR_1 ; return this ; } |
fail VAR_1 empty ? simplify ? interested VAR_4 state ? need check previous state | private void METHOD_1 ( final List < TYPE_1 < TYPE_3 . TYPE_4 , TYPE_3 . TYPE_4 > > VAR_1 ) throws Exception { METHOD_2 ( <START> ( ) - > VAR_1 . get ( VAR_1 . size ( ) - 1 ) . equals ( new TYPE_1 < > ( TYPE_4 . VAR_3 , TYPE_4 . VAR_4 ) ) , <END> VAR_5 , ( ) - > STRING_1 + VAR_1 ) ; } | private void METHOD_1 ( final List < TYPE_1 < TYPE_3 . TYPE_4 , TYPE_3 . TYPE_4 > > VAR_1 ) throws Exception { METHOD_2 ( ( ) - > ! VAR_1 . isEmpty ( ) && VAR_1 . get ( VAR_1 . size ( ) - 1 ) . value . equals ( TYPE_4 . VAR_4 ) , VAR_5 , ( ) - > STRING_1 + VAR_1 ) ; } |
line necessary ? isn t property logged INFO level worker starts TYPE_2 ( _CODE_ _CODE_ ) constructor | protected void METHOD_1 ( TYPE_1 context ) { String VAR_1 = config . getString ( TYPE_2 . VAR_2 ) ; <START> log . debug ( STRING_1 + VAR_1 ) ; <END> String [ ] VAR_3 = TYPE_3 . METHOD_2 ( VAR_1 ) ; Arrays . stream ( VAR_3 ) . forEach ( TYPE_2 : : METHOD_3 ) ; TYPE_4 VAR_4 = new TYPE_4 ( TYPE_5 . class ) ; VAR_4 . METHO... | protected void METHOD_1 ( TYPE_1 context ) { String VAR_1 = config . getString ( TYPE_2 . VAR_2 ) ; TYPE_4 VAR_4 = new TYPE_4 ( TYPE_5 . class ) ; VAR_4 . METHOD_4 ( STRING_2 , VAR_1 ) ; context . VAR_5 ( VAR_4 , STRING_3 , TYPE_6 . of ( TYPE_7 . VAR_7 ) ) ; } |
extra semi - colon | public TYPE_1 ( ) { <START> this . VAR_2 = Collections . VAR_3 ( ) ; ; <END> } | public TYPE_1 ( ) { this . VAR_2 = Collections . VAR_3 ( ) ; } |
suggestionreturn new HashMap < > ( VAR_2 ( VAR_4 TimeUnit VAR_5 ) ; ) ; | public Map < String , String > METHOD_1 ( String VAR_1 ) { TYPE_1 < Map < String , String > > VAR_2 = new TYPE_1 < > ( ) ; VAR_3 . METHOD_1 ( VAR_1 , VAR_2 ) ; try { <START> Map < String , String > result = VAR_2 . get ( VAR_4 , TimeUnit . VAR_5 ) ; return new HashMap < > ( result ) ; <END> } catch ( InterruptedExcepti... | public Map < String , String > METHOD_1 ( String VAR_1 ) { TYPE_1 < Map < String , String > > VAR_2 = new TYPE_1 < > ( ) ; VAR_3 . METHOD_1 ( VAR_1 , VAR_2 ) ; try { return new HashMap < > ( VAR_2 . get ( VAR_4 , TimeUnit . VAR_5 ) ) ; } catch ( InterruptedException | TYPE_2 | TYPE_3 e ) { throw new TYPE_4 ( String . f... |
bad suggestion inserted a typo I I start build suggestionreturn new HashMap < > ( VAR_4 ( VAR_6 TimeUnit VAR_7 ) ) ; | public Map < String , String > VAR_1 ( String VAR_2 ) { TYPE_2 < Map < String , String > > VAR_4 = new TYPE_2 < > ( ) ; VAR_5 . VAR_1 ( VAR_2 , VAR_4 ) ; try { <START> return new HashMap < > ( VAR_4 . get ( VAR_6 , TimeUnit . VAR_7 ) ; ) ; <END> } catch ( InterruptedException | TYPE_1 | TYPE_3 e ) { throw new TYPE_4 ( ... | public Map < String , String > VAR_1 ( String VAR_2 ) { TYPE_2 < Map < String , String > > VAR_4 = new TYPE_2 < > ( ) ; VAR_5 . VAR_1 ( VAR_2 , VAR_4 ) ; try { return new HashMap < > ( VAR_4 . get ( VAR_6 , TimeUnit . VAR_7 ) ) ; } catch ( InterruptedException | TYPE_1 | TYPE_3 e ) { throw new TYPE_4 ( String . format ... |
VAR_4 scoped class logs message want capture | public void METHOD_1 ( ) { props . VAR_1 ( TYPE_5 . VAR_3 , TYPE_1 . class . getName ( ) ) ; <START> final TYPE_2 VAR_4 = TYPE_2 . METHOD_2 ( ) ; <END> try { new TYPE_3 ( new TYPE_4 ( ) . build ( ) , props , VAR_5 , time ) ; } finally { TYPE_2 . METHOD_3 ( VAR_4 ) ; } assertThat ( VAR_4 . METHOD_4 ( ) , METHOD_5 ( STRI... | public void METHOD_1 ( ) { props . VAR_1 ( TYPE_5 . VAR_3 , TYPE_1 . class . getName ( ) ) ; try ( final TYPE_2 VAR_4 = TYPE_2 . METHOD_2 ( ) ) { new TYPE_3 ( new TYPE_4 ( ) . build ( ) , props , VAR_5 , time ) ; assertThat ( VAR_4 . METHOD_4 ( ) , METHOD_5 ( STRING_1 + VAR_6 + STRING_2 + STRING_3 + STRING_4 + STRING_5... |
prop : I add client contained set | void METHOD_1 ( final TYPE_1 client ) { if ( VAR_1 . contains ( client ) ) { VAR_2 . remove ( client ) ; } VAR_2 . METHOD_1 ( client ) ; <START> VAR_1 . add ( client ) ; <END> } | void METHOD_1 ( final TYPE_1 client ) { if ( VAR_1 . contains ( client ) ) { VAR_2 . remove ( client ) ; } else { VAR_1 . add ( client ) ; } VAR_2 . METHOD_1 ( client ) ; } |
s a nice blog : exception costs | public void close ( ) { <START> TYPE_1 e = new TYPE_1 ( STRING_1 ) ; for ( TYPE_2 VAR_1 : VAR_2 ) { try { VAR_1 . close ( ) ; } catch ( Throwable t ) { e . VAR_3 ( t ) ; } } if ( e . VAR_4 ( ) . length > 0 ) { throw e ; } <END> } | public void close ( ) { TYPE_1 e = null ; for ( TYPE_2 VAR_1 : VAR_2 ) { try { VAR_1 . close ( ) ; } catch ( Throwable t ) { e = e != null ? e : new TYPE_1 ( STRING_1 ) ; e . VAR_3 ( t ) ; } } if ( e != null ) { throw e ; } } |
exception | static void METHOD_1 ( final String message , final TYPE_1 < RuntimeException > VAR_1 ) { if ( VAR_1 != null && ! VAR_1 . isEmpty ( ) ) { final RuntimeException VAR_2 = VAR_1 . METHOD_2 ( ) ; <START> final RuntimeException VAR_3 = new RuntimeException ( message , VAR_2 ) ; <END> for ( final RuntimeException e : VAR_1 )... | static void METHOD_1 ( final String message , final TYPE_1 < RuntimeException > VAR_1 ) { if ( ! VAR_1 . isEmpty ( ) ) { final RuntimeException VAR_2 = VAR_1 . METHOD_2 ( ) ; final RuntimeException VAR_3 = new RuntimeException ( message , VAR_2 ) ; for ( final RuntimeException e : VAR_1 ) { VAR_3 . METHOD_3 ( e ) ; } t... |
final return empty list ? avoid null | static TYPE_1 < RuntimeException > METHOD_1 ( final TYPE_2 ... VAR_1 ) { <START> TYPE_1 < RuntimeException > VAR_2 = null ; <END> for ( final TYPE_2 action : VAR_1 ) { try { action . run ( ) ; } catch ( final RuntimeException exception ) { if ( VAR_2 == null ) { VAR_2 = new TYPE_1 < > ( ) ; } VAR_2 . add ( exception ) ... | static TYPE_1 < RuntimeException > METHOD_1 ( final TYPE_2 ... VAR_1 ) { final TYPE_1 < RuntimeException > VAR_2 = new TYPE_1 < > ( ) ; for ( final TYPE_2 action : VAR_1 ) { try { action . run ( ) ; } catch ( final RuntimeException exception ) { VAR_2 . add ( exception ) ; } } return VAR_2 ; } |
check ( isEmpty ( ) sense ) I avoid null | public void close ( ) { VAR_1 . METHOD_1 ( ) . METHOD_2 ( ) ; try { final TYPE_1 < RuntimeException > VAR_2 = METHOD_3 ( ( ) - > cache . VAR_3 ( VAR_4 ) , ( ) - > cache . close ( VAR_4 ) , METHOD_4 ( ) : : close ) ; <START> if ( VAR_2 != null && ! VAR_2 . isEmpty ( ) ) { <END> METHOD_5 ( STRING_1 + name ( ) , VAR_2 ) ;... | public void close ( ) { VAR_1 . METHOD_1 ( ) . METHOD_2 ( ) ; try { final TYPE_1 < RuntimeException > VAR_2 = METHOD_3 ( ( ) - > cache . VAR_3 ( VAR_4 ) , ( ) - > cache . close ( VAR_4 ) , METHOD_4 ( ) : : close ) ; if ( ! VAR_2 . isEmpty ( ) ) { METHOD_5 ( STRING_1 + name ( ) , VAR_2 ) ; } } finally { VAR_1 . METHOD_1... |
Q : consider stateful tasks METHOD_3 ( ) | private boolean METHOD_1 ( ) { if ( METHOD_2 ( ) ) { final int VAR_1 = <START> METHOD_3 ( VAR_2 . values ( ) , VAR_3 , TYPE_1 : : METHOD_4 ) ; <END> return VAR_1 <= VAR_4 . VAR_5 ; } else { return false ; } } | private boolean METHOD_1 ( ) { if ( METHOD_2 ( ) ) { final int VAR_1 = METHOD_3 ( VAR_2 . values ( ) , VAR_3 ) ; return VAR_1 <= VAR_4 . VAR_5 ; } else { return false ; } } |
passing VAR_3 potentially check a helper function : private boolean0 VAR_5 ( ) { VAR_3 = = VAR_6 || VAR_3 = = VAR_7 ; } | public TYPE_7 ( final TYPE_1 < byte [ ] , byte [ ] > VAR_2 , final TYPE_5 . TYPE_6 VAR_3 , final TYPE_3 VAR_4 ) { this . VAR_2 = TYPE_4 . METHOD_1 ( VAR_2 , STRING_1 ) ; this . VAR_3 = TYPE_4 . METHOD_1 ( VAR_3 , STRING_2 ) ; <START> this . VAR_5 = VAR_3 == VAR_6 || VAR_3 == VAR_7 ; <END> log = TYPE_4 . METHOD_1 ( VAR_... | public TYPE_7 ( final TYPE_1 < byte [ ] , byte [ ] > VAR_2 , final TYPE_5 . TYPE_6 VAR_3 , final TYPE_3 VAR_4 ) { this . VAR_2 = TYPE_4 . METHOD_1 ( VAR_2 , STRING_1 ) ; this . VAR_3 = TYPE_4 . METHOD_1 ( VAR_3 , STRING_2 ) ; log = TYPE_4 . METHOD_1 ( VAR_4 , STRING_3 ) . logger ( getClass ( ) ) ; VAR_8 = VAR_4 . METHO... |
move line 290 | public void METHOD_1 ( ) { if ( state != TYPE_1 . VAR_2 ) { log . debug ( STRING_1 , VAR_3 ) ; <START> METHOD_2 ( METHOD_3 ( ) ) ; <END> } state = TYPE_1 . VAR_2 ; } | public void METHOD_1 ( ) { if ( state != TYPE_1 . VAR_2 ) { log . debug ( STRING_1 , VAR_3 ) ; METHOD_2 ( METHOD_3 ( ) ) ; state = TYPE_1 . VAR_2 ; } } |
I feel internalize VAR_3 creation including null check : VAR_3 = TYPE_1 METHOD_1 ( VAR_2 ) ; | TYPE_3 ( final String VAR_2 ) { <START> VAR_3 = VAR_2 != null ? TYPE_1 . METHOD_1 ( VAR_2 ) : null ; <END> VAR_4 = new HashSet < > ( ) ; state = new TYPE_2 ( ) ; } | TYPE_3 ( final String VAR_2 ) { VAR_3 = TYPE_1 . METHOD_1 ( VAR_2 ) ; VAR_4 = new HashSet < > ( ) ; state = new TYPE_2 ( ) ; } |
utility methods static | <START> private Map < String , List < TYPE_1 > > METHOD_1 ( final List < TYPE_1 > VAR_1 , <END> final List < TYPE_1 > VAR_2 ) { return METHOD_2 ( METHOD_3 ( VAR_3 , VAR_1 ) , METHOD_3 ( VAR_4 , VAR_2 ) ) ; } | private static Map < String , List < TYPE_1 > > METHOD_1 ( final List < TYPE_1 > VAR_1 , final List < TYPE_1 > VAR_2 ) { return METHOD_2 ( METHOD_3 ( VAR_3 , VAR_1 ) , METHOD_3 ( VAR_4 , VAR_2 ) ) ; } |
ah missed time perform METHOD_2 ( ) lambda time perform included latency | public TYPE_1 < TYPE_2 > METHOD_1 ( final TYPE_3 key ) { try { <START> final byte [ ] VAR_1 = METHOD_2 ( ) . get ( METHOD_3 ( key ) ) ; return new TYPE_1 < TYPE_2 > ( VAR_1 , METHOD_4 ( ( ) - > METHOD_5 ( VAR_1 ) , time , VAR_2 ) ) ; <END> } catch ( final TYPE_4 e ) { final String message = String . format ( e . getMes... | public TYPE_1 < TYPE_2 > METHOD_1 ( final TYPE_3 key ) { try { return METHOD_4 ( ( ) - > { final byte [ ] VAR_1 = METHOD_2 ( ) . get ( METHOD_3 ( key ) ) ; return new TYPE_1 < TYPE_2 > ( VAR_1 , METHOD_5 ( VAR_1 ) ) ; } , time , VAR_2 ) ; } catch ( final TYPE_4 e ) { final String message = String . format ( e . getMess... |
mocked VAR_1 store shouldn t need a put | public void METHOD_1 ( ) { METHOD_2 ( VAR_1 . get ( VAR_2 ) ) . METHOD_3 ( VAR_3 ) ; VAR_1 . put ( METHOD_4 ( VAR_2 ) , METHOD_5 ( VAR_3 ) ) ; METHOD_6 ( ) ; METHOD_7 ( ) ; <START> VAR_4 . put ( key , VAR_5 ) ; <END> final TYPE_1 < String > VAR_6 = VAR_4 . METHOD_8 ( key ) ; assertEquals ( VAR_6 . value , VAR_5 ) ; ass... | public void METHOD_1 ( ) { METHOD_2 ( VAR_1 . get ( VAR_2 ) ) . METHOD_3 ( VAR_3 ) ; VAR_1 . put ( METHOD_4 ( VAR_2 ) , METHOD_5 ( VAR_3 ) ) ; METHOD_6 ( ) ; METHOD_7 ( ) ; final TYPE_1 < String > VAR_6 = VAR_4 . METHOD_8 ( key ) ; assertEquals ( VAR_6 . value , VAR_5 ) ; assertEquals ( VAR_6 . VAR_7 , VAR_3 ) ; } |
suggestion | public void METHOD_1 ( ) { <START> METHOD_2 ( ) ; <END> METHOD_3 ( ) ; VAR_1 . put ( key , VAR_2 ) ; final TYPE_1 < String > VAR_3 = new TYPE_1 < > ( TYPE_2 . String ( ) ) ; final byte [ ] VAR_4 = VAR_3 . METHOD_4 ( ) . METHOD_5 ( STRING_1 , VAR_2 ) ; final TYPE_3 < String > VAR_5 = TYPE_3 . METHOD_6 ( STRING_2 , INT_1... | public void METHOD_1 ( ) { METHOD_3 ( ) ; VAR_1 . put ( key , VAR_2 ) ; final TYPE_1 < String > VAR_3 = new TYPE_1 < > ( TYPE_2 . String ( ) ) ; final byte [ ] VAR_4 = VAR_3 . METHOD_4 ( ) . METHOD_5 ( STRING_1 , VAR_2 ) ; final TYPE_3 < String > VAR_5 = TYPE_3 . METHOD_6 ( STRING_2 , INT_1 ) ; METHOD_7 ( VAR_1 . METHO... |
prop : I VAR_1 toString ( ) testing VAR_1 toString ( ) method assumption folder a equal result VAR_1 toString ( ) 0_1 | public void METHOD_1 ( ) throws IOException { METHOD_2 ( VAR_1 ) ; METHOD_3 ( VAR_2 ) ; METHOD_4 ( <START> STRING_1 , <END> STRING_2 , STRING_3 ) ; METHOD_5 ( VAR_3 ) ; VAR_4 . METHOD_6 ( METHOD_7 ( STRING_4 ) ) ; METHOD_8 ( VAR_3 ) ; assertThat ( VAR_4 . METHOD_9 ( ) , is ( METHOD_7 ( VAR_1 ) ) ) ; } | public void METHOD_1 ( ) throws IOException { METHOD_2 ( VAR_1 ) ; METHOD_3 ( VAR_2 ) ; METHOD_4 ( VAR_1 . toString ( ) , VAR_2 . toString ( ) , STRING_3 ) ; METHOD_5 ( VAR_3 ) ; VAR_4 . METHOD_6 ( METHOD_7 ( STRING_4 ) ) ; METHOD_8 ( VAR_3 ) ; assertThat ( VAR_4 . METHOD_9 ( ) , is ( METHOD_7 ( VAR_1 ) ) ) ; } |
prop : remove line need METHOD_7 ( ) need some expectation settings a call returns void e g METHOD_7 ( ) times ( 3 ) | private static void METHOD_1 ( final TYPE_1 < byte [ ] , byte [ ] > VAR_1 ) { final Set < TYPE_2 > VAR_2 = METHOD_2 ( new TYPE_2 ( STRING_1 , 0 ) ) ; METHOD_3 ( VAR_1 . METHOD_4 ( ) ) . METHOD_5 ( VAR_2 ) ; VAR_1 . METHOD_6 ( VAR_2 ) ; <START> METHOD_7 ( ) ; <END> } | private static void METHOD_1 ( final TYPE_1 < byte [ ] , byte [ ] > VAR_1 ) { final Set < TYPE_2 > VAR_2 = METHOD_2 ( new TYPE_2 ( STRING_1 , 0 ) ) ; METHOD_3 ( VAR_1 . METHOD_4 ( ) ) . METHOD_5 ( VAR_2 ) ; VAR_1 . METHOD_6 ( VAR_2 ) ; } |
write state = METHOD_1 ( state ) ; | public TYPE_3 ( String VAR_2 , boolean VAR_3 , Optional < TYPE_1 > state ) { TYPE_2 . METHOD_1 ( state ) ; this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; <START> this . state = state ; <END> } | public TYPE_3 ( String VAR_2 , boolean VAR_3 , Optional < TYPE_1 > state ) { this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; this . state = TYPE_2 . METHOD_1 ( state ) ; } |
introduced PR : thinking I realized VAR_2 state need rely VAR_5 METHOD_2 fact METHOD_2 VAR_2 | public void METHOD_1 ( ) { switch ( state ( ) ) { case VAR_1 : case VAR_2 : <START> VAR_3 = false ; <END> VAR_4 = false ; if ( VAR_5 ) { VAR_6 . METHOD_2 ( METHOD_3 ( ) ) ; } log . info ( STRING_1 ) ; break ; default : throw new IllegalStateException ( STRING_2 + state ( ) + STRING_3 + id ) ; } } | public void METHOD_1 ( ) { switch ( state ( ) ) { case VAR_1 : VAR_3 = false ; VAR_4 = false ; if ( VAR_5 ) { VAR_6 . METHOD_2 ( METHOD_3 ( ) ) ; } log . info ( STRING_1 ) ; break ; case VAR_2 : VAR_3 = false ; VAR_4 = false ; VAR_6 . METHOD_2 ( METHOD_3 ( ) ) ; log . info ( STRING_1 ) ; break ; default : throw new Ill... |
req : please need method suggestionreturn config getProperty ( TYPE_2 VAR_2 VAR_3 ) ; | private static String METHOD_1 ( final TYPE_1 config ) { <START> if ( config . containsKey ( TYPE_2 . VAR_2 ) ) { return config . getProperty ( TYPE_2 . VAR_2 ) ; } return VAR_3 ; <END> } | private static String METHOD_1 ( final TYPE_1 config ) { return config . getProperty ( TYPE_2 . VAR_2 , VAR_3 ) ; } |
hmm want capture exceptions TYPE_2 ? I s capture _CODE_ TYPE_2 thrown | public void METHOD_1 ( final Collection < TYPE_1 > VAR_1 ) { log . info ( STRING_1 + STRING_2 + STRING_3 , VAR_2 . state ( ) , VAR_1 , VAR_3 . METHOD_2 ( ) , VAR_3 . METHOD_3 ( ) ) ; final long start = time . VAR_4 ( ) ; try { VAR_3 . METHOD_4 ( ) ; <START> } catch ( final Exception e ) { <END> throw new TYPE_2 ( STRIN... | public void METHOD_1 ( final Collection < TYPE_1 > VAR_1 ) { log . info ( STRING_1 + STRING_2 + STRING_3 , VAR_2 . state ( ) , VAR_1 , VAR_3 . METHOD_2 ( ) , VAR_3 . METHOD_3 ( ) ) ; final long start = time . VAR_4 ( ) ; try { VAR_3 . METHOD_4 ( ) ; } finally { log . info ( STRING_5 , time . VAR_4 ( ) - start ) ; } } |
calling close doesn t avoid warnings ? warnings coming | public void METHOD_1 ( ) throws InterruptedException , TYPE_1 { TYPE_2 client = new TYPE_3 ( ) ; assertTrue ( client . VAR_1 ( STRING_1 ) ) ; assertTrue ( client . VAR_1 ( STRING_2 ) ) ; assertTrue ( client . VAR_1 ( STRING_3 ) ) ; METHOD_2 ( client . VAR_1 ( STRING_4 ) ) ; METHOD_2 ( client . VAR_1 ( STRING_5 ) ) ; ME... | public void METHOD_1 ( ) throws InterruptedException , TYPE_1 { TYPE_2 client = new TYPE_3 ( ) ; assertTrue ( client . VAR_1 ( STRING_1 ) ) ; assertTrue ( client . VAR_1 ( STRING_2 ) ) ; assertTrue ( client . VAR_1 ( STRING_3 ) ) ; METHOD_2 ( client . VAR_1 ( STRING_4 ) ) ; METHOD_2 ( client . VAR_1 ( STRING_5 ) ) ; ME... |
endup locking method s reason a block synchronized method applies similar method | public void METHOD_1 ( ) { <START> synchronized ( this ) { <END> log . info ( STRING_1 , this ) ; VAR_1 = true ; METHOD_2 ( ) ; } } | public synchronized void METHOD_1 ( ) { log . info ( STRING_1 , this ) ; VAR_1 = true ; METHOD_2 ( ) ; } |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.