ReviewComments stringlengths 1 2.35k | OriginalCode stringlengths 28 487 | ReviewedCode stringlengths 14 463 |
|---|---|---|
remove public modifier null checks | <START> public TYPE_5 ( TYPE_1 VAR_2 , TYPE_2 < TYPE_3 > VAR_3 ) { <END> this . VAR_2 = ( TYPE_4 ) METHOD_1 ( VAR_2 , STRING_1 ) ; this . VAR_3 = METHOD_1 ( VAR_3 , STRING_2 ) ; } | TYPE_5 ( TYPE_1 VAR_2 , TYPE_2 < TYPE_3 > VAR_3 ) { this . VAR_2 = ( TYPE_4 ) VAR_2 ; this . VAR_3 = VAR_3 ; } |
return | public TYPE_2 . TYPE_3 METHOD_1 ( ) { TYPE_2 . TYPE_3 result = TYPE_2 . TYPE_3 . create ( name , VAR_1 , VAR_2 , VAR_3 , VAR_4 , VAR_5 , VAR_6 ) ; <START> return result ; <END> } | public TYPE_2 . TYPE_3 METHOD_1 ( ) { return TYPE_2 . TYPE_3 . create ( name , VAR_1 , VAR_2 , VAR_3 , VAR_4 , VAR_5 , VAR_6 ) ; } |
necessary ? isn t base class method working | protected TYPE_1 METHOD_1 ( ) { synchronized ( this ) { if ( VAR_1 == null ) { VAR_1 = new TYPE_2 ( ) ; } } return VAR_1 ; <START> } <END> | protected TYPE_1 METHOD_1 ( ) { if ( VAR_1 == null ) { VAR_1 = new TYPE_2 ( ) ; } return VAR_1 ; } |
redundant check fail expected VAR_2 null | public void METHOD_1 ( ) { TYPE_1 binder = new TYPE_1 ( ) ; TYPE_3 . TYPE_4 . TYPE_5 VAR_2 = TYPE_3 . TYPE_4 . TYPE_5 . builder ( ) . METHOD_2 ( STRING_1 ) . METHOD_3 ( STRING_2 ) . METHOD_4 ( STRING_3 ) . build ( ) ; String VAR_3 = binder . VAR_4 ( VAR_2 ) ; <START> assertNotNull ( VAR_3 , STRING_4 ) ; <END> assertEqu... | public void METHOD_1 ( ) { TYPE_1 binder = new TYPE_1 ( ) ; TYPE_3 . TYPE_4 . TYPE_5 VAR_2 = TYPE_3 . TYPE_4 . TYPE_5 . builder ( ) . METHOD_2 ( STRING_1 ) . METHOD_3 ( STRING_2 ) . METHOD_4 ( STRING_3 ) . build ( ) ; String VAR_3 = binder . VAR_4 ( VAR_2 ) ; assertEquals ( VAR_5 , VAR_3 ) ; } |
needed | protected String METHOD_1 ( TYPE_2 . TYPE_3 . TYPE_4 VAR_2 ) { VAR_3 . append ( STRING_1 ) . append ( STRING_2 ) ; for ( String s : VAR_2 . METHOD_2 ( ) ) { VAR_3 . append ( format ( STRING_3 , s ) ) ; } VAR_3 . append ( format ( STRING_4 , VAR_2 . id ( ) ) ) . append ( STRING_5 ) . append ( STRING_6 ) ; <START> return... | protected String METHOD_1 ( TYPE_2 . TYPE_3 . TYPE_4 VAR_2 ) { VAR_3 . append ( STRING_1 ) . append ( STRING_2 ) ; for ( String s : VAR_2 . METHOD_2 ( ) ) { VAR_3 . append ( format ( STRING_3 , s ) ) ; } VAR_3 . append ( format ( STRING_4 , VAR_2 . id ( ) ) ) . append ( STRING_5 ) . append ( STRING_6 ) ; return VAR_3 .... |
package private | <START> protected TYPE_5 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 , TYPE_3 VAR_4 ) { <END> super ( VAR_2 , VAR_3 , VAR_4 ) ; this . VAR_5 = TYPE_4 . METHOD_1 ( ) ; } | TYPE_5 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 , TYPE_3 VAR_4 ) { super ( VAR_2 , VAR_3 , VAR_4 ) ; this . VAR_5 = TYPE_4 . METHOD_1 ( ) ; } |
API return null lists remove executed creating load balancer | public void METHOD_1 ( ) { List < TYPE_1 > VAR_1 = VAR_2 . METHOD_2 ( ) . METHOD_3 ( ) ; <START> assertNotNull ( VAR_1 ) ; <END> METHOD_4 ( VAR_1 . isEmpty ( ) ) ; } | public void METHOD_1 ( ) { List < TYPE_1 > VAR_1 = VAR_2 . METHOD_2 ( ) . METHOD_3 ( ) ; METHOD_4 ( VAR_1 . isEmpty ( ) ) ; } |
remove | public void METHOD_1 ( ) { TYPE_1 VAR_1 = VAR_2 . METHOD_2 ( ) . METHOD_3 ( VAR_3 ) ; <START> System . out . println ( VAR_1 ) ; <END> assertNotNull ( VAR_1 ) ; } | public void METHOD_1 ( ) { TYPE_1 VAR_1 = VAR_2 . METHOD_2 ( ) . METHOD_3 ( VAR_3 ) ; assertNotNull ( VAR_1 ) ; } |
[ ] more concise : _CODE_ ( ! ( VAR_1 = = null ^ VAR_2 = = null ) STRING_1 ) ; | protected void METHOD_1 ( ) { METHOD_2 ( ( VAR_1 == null && VAR_2 == null ) <START> || ( VAR_1 != null && VAR_2 != null ) , STRING_1 ) ; <END> if ( VAR_1 != null ) { METHOD_2 ( VAR_3 == TYPE_1 . VAR_5 || VAR_3 == TYPE_1 . VAR_6 , STRING_2 ) ; METHOD_2 ( VAR_1 > VAR_2 , STRING_3 ) ; METHOD_2 ( VAR_1 >= 1 && VAR_1 <= INT... | protected void METHOD_1 ( ) { METHOD_2 ( ! ( VAR_1 == null ^ VAR_2 == null ) , STRING_1 ) ; if ( VAR_1 != null ) { METHOD_2 ( VAR_3 == TYPE_1 . VAR_5 || VAR_3 == TYPE_1 . VAR_6 , STRING_2 ) ; METHOD_2 ( VAR_1 > VAR_2 , STRING_3 ) ; METHOD_2 ( VAR_1 >= 1 && VAR_1 <= INT_1 , STRING_4 ) ; METHOD_2 ( VAR_2 >= 1 && VAR_2 <=... |
a _good_ property ? api work users don t override ? passed credential | public static TYPE_1 METHOD_1 ( ) { TYPE_1 properties = TYPE_2 . METHOD_1 ( ) ; properties . VAR_1 ( Constants . VAR_2 , STRING_1 ) ; <START> properties . VAR_1 ( TYPE_3 . VAR_4 , STRING_2 ) ; <END> return properties ; } | public static TYPE_1 METHOD_1 ( ) { return TYPE_2 . METHOD_1 ( ) ; } |
constructor package protected guice injector enforce parameters present remove METHOD_1 check | <START> public TYPE_3 ( ANNOTATION_1 TYPE_1 < TYPE_2 > VAR_2 ) { <END> this . VAR_2 = METHOD_1 ( VAR_2 , STRING_1 ) ; } | TYPE_3 ( ANNOTATION_1 TYPE_1 < TYPE_2 > VAR_2 ) { this . VAR_2 = VAR_2 ; } |
method private | <START> public String METHOD_1 ( TYPE_1 response ) { <END> if ( response . VAR_1 ( ) == null ) return null ; try { return TYPE_2 . METHOD_2 ( response . VAR_1 ( ) . METHOD_3 ( ) ) ; } catch ( IOException e ) { throw TYPE_3 . METHOD_4 ( e ) ; } } | private String METHOD_1 ( TYPE_1 response ) { if ( response . VAR_1 ( ) == null ) return null ; try { return TYPE_2 . METHOD_2 ( response . VAR_1 ( ) . METHOD_3 ( ) ) ; } catch ( IOException e ) { throw TYPE_3 . METHOD_4 ( e ) ; } } |
weird indent class inconsistent safe copies auto generate builders won t safe copies ensure calling safe copies | public Builder METHOD_1 ( List < String > VAR_1 ) { <START> this . VAR_1 = ImmutableList . VAR_2 ( METHOD_2 ( VAR_1 , STRING_1 ) ) ; <END> return this ; } | public Builder METHOD_1 ( List < String > VAR_1 ) { this . VAR_1 = VAR_1 ; return this ; } |
[ minor ] ( CS VAR_1 : response ) | public void METHOD_1 ( ) { List < TYPE_1 > response = METHOD_2 ( ) . list ( ) ; <START> for ( TYPE_1 VAR_1 : METHOD_2 ( ) . list ( ) ) { <END> METHOD_3 ( VAR_1 ) ; } if ( ! response . isEmpty ( ) ) { TYPE_1 VAR_1 = response . iterator ( ) . next ( ) ; assertEquals ( METHOD_2 ( ) . get ( VAR_1 . name ( ) ) , VAR_1 ) ; }... | public void METHOD_1 ( ) { List < TYPE_1 > response = METHOD_2 ( ) . list ( ) ; for ( TYPE_1 VAR_1 : response ) { METHOD_3 ( VAR_1 ) ; } if ( ! response . isEmpty ( ) ) { TYPE_1 VAR_1 = response . iterator ( ) . next ( ) ; assertEquals ( METHOD_2 ( ) . get ( VAR_1 . name ( ) ) , VAR_1 ) ; } } |
[ minor ] new implementations remove METHOD_2 intentionally left ? | public String toString ( ) { <START> return TYPE_1 . METHOD_1 ( this ) . METHOD_2 ( ) . add ( STRING_1 , VAR_1 ) . add ( STRING_2 , message ) . toString ( ) ; <END> } | public String toString ( ) { return METHOD_1 ( this ) . add ( STRING_1 , VAR_1 ) . add ( STRING_2 , message ) . toString ( ) ; } |
guice practices : constructor visible package level | <START> public TYPE_3 ( TYPE_1 VAR_2 ) { <END> super ( VAR_2 ) ; this . builder = TYPE_2 . builder ( ) ; } | TYPE_3 ( TYPE_1 VAR_2 ) { super ( VAR_2 ) ; this . builder = TYPE_2 . builder ( ) ; } |
injected constructor package private | <START> public TYPE_3 ( TYPE_1 VAR_2 ) { <END> super ( VAR_2 ) ; this . VAR_3 = TYPE_2 . METHOD_1 ( ) ; } | TYPE_3 ( TYPE_1 VAR_2 ) { super ( VAR_2 ) ; this . VAR_3 = TYPE_2 . METHOD_1 ( ) ; } |
created guice injector constructor protected | <START> public TYPE_1 ( String VAR_2 ) { <END> this . VAR_2 = METHOD_1 ( VAR_2 , STRING_1 ) ; } | protected TYPE_1 ( String VAR_2 ) { this . VAR_2 = METHOD_1 ( VAR_2 , STRING_1 ) ; } |
constructor called guice injector package private removing public modifier | <START> public TYPE_1 ( ) { <END> super ( STRING_1 ) ; this . VAR_2 = new StringBuilder ( INT_1 ) ; } | TYPE_1 ( ) { super ( STRING_1 ) ; this . VAR_2 = new StringBuilder ( INT_1 ) ; } |
catching IllegalArgumentException | public void METHOD_1 ( ) throws Exception { String [ ] VAR_1 = { STRING_1 , STRING_2 , STRING_3 , "" } ; for ( String name : VAR_1 ) try { TYPE_2 . TYPE_3 . TYPE_1 . create ( name , TYPE_4 . VAR_6 ) ; METHOD_2 ( STRING_4 . METHOD_3 ( name ) ) ; } catch ( Exception ex ) { <START> assertTrue ( ex instanceof IllegalArgume... | public void METHOD_1 ( ) throws Exception { String [ ] VAR_1 = { STRING_1 , STRING_2 , STRING_3 , "" } ; for ( String name : VAR_1 ) { try { TYPE_2 . TYPE_3 . TYPE_1 . create ( name , TYPE_4 . VAR_6 ) ; METHOD_2 ( STRING_4 . METHOD_3 ( name ) ) ; } catch ( IllegalArgumentException ex ) { } } } |
checking boot order _greater_ zero means a boot device | public TYPE_1 apply ( TYPE_2 VAR_1 ) { TYPE_3 builder = new TYPE_3 ( ) ; TYPE_4 VAR_2 = VAR_3 . METHOD_1 ( VAR_1 . METHOD_2 ( ) ) ; builder . id ( VAR_2 . METHOD_3 ( ) ) ; builder . size ( VAR_2 . METHOD_4 ( ) . METHOD_5 ( ) ) ; builder . VAR_4 ( true ) ; builder . type ( TYPE_1 . Type . VAR_5 ) ; <START> builder . VAR... | public TYPE_1 apply ( TYPE_2 VAR_1 ) { TYPE_3 builder = new TYPE_3 ( ) ; TYPE_4 VAR_2 = VAR_3 . METHOD_1 ( VAR_1 . METHOD_2 ( ) ) ; builder . id ( VAR_2 . METHOD_3 ( ) ) ; builder . size ( VAR_2 . METHOD_4 ( ) . METHOD_5 ( ) ) ; builder . VAR_4 ( true ) ; builder . type ( TYPE_1 . Type . VAR_5 ) ; builder . VAR_6 ( VAR... |
need local variable return detected os family | private TYPE_1 < String , TYPE_2 > METHOD_1 ( ) { return new TYPE_1 < String , TYPE_2 > ( ) { <START> TYPE_2 VAR_1 = TYPE_2 . VAR_2 ; <END> @Override public TYPE_2 apply ( final String description ) { if ( description != null ) { if ( description . contains ( VAR_3 ) ) VAR_1 = TYPE_2 . VAR_3 ; else if ( description . c... | private TYPE_1 < String , TYPE_2 > METHOD_1 ( ) { return new TYPE_1 < String , TYPE_2 > ( ) { @Override public TYPE_2 apply ( final String description ) { if ( description != null ) { if ( description . contains ( VAR_3 ) ) return TYPE_2 . VAR_3 ; else if ( description . contains ( VAR_4 ) ) return TYPE_2 . VAR_4 ; } r... |
property ( jclouds prefix ) | public static TYPE_1 METHOD_1 ( ) { TYPE_1 properties = TYPE_2 . METHOD_1 ( ) ; properties . VAR_1 ( Constants . VAR_2 , STRING_1 ) ; properties . VAR_1 ( STRING_2 , STRING_3 ) ; properties . VAR_1 ( Constants . VAR_3 , STRING_4 ) ; <START> properties . VAR_1 ( STRING_5 , STRING_6 ) ; <END> properties . VAR_1 ( TYPE_3 ... | public static TYPE_1 METHOD_1 ( ) { TYPE_1 properties = TYPE_2 . METHOD_1 ( ) ; properties . VAR_1 ( Constants . VAR_2 , STRING_1 ) ; properties . VAR_1 ( STRING_2 , STRING_3 ) ; properties . VAR_1 ( Constants . VAR_3 , STRING_4 ) ; properties . VAR_1 ( TYPE_3 . VAR_5 , STRING_7 ) ; properties . VAR_1 ( VAR_6 , STRING_... |
payload closeable close payload avoid deprecation warning | public String METHOD_1 ( TYPE_1 response ) { if ( response . VAR_1 ( ) == null ) return null ; try { return TYPE_2 . toString ( response . VAR_1 ( ) ) ; } catch ( IOException e ) { throw TYPE_3 . METHOD_2 ( e ) ; } finally { try { <START> response . VAR_1 ( ) . METHOD_3 ( ) . close ( ) ; <END> } catch ( IOException e )... | public String METHOD_1 ( TYPE_1 response ) { if ( response . VAR_1 ( ) == null ) return null ; try { return TYPE_2 . toString ( response . VAR_1 ( ) ) ; } catch ( IOException e ) { throw TYPE_3 . METHOD_2 ( e ) ; } finally { try { response . VAR_1 ( ) . close ( ) ; } catch ( IOException e ) { throw TYPE_3 . METHOD_2 ( ... |
save check : ( instanceof TYPE_3 ) { } else ( instanceof TYPE_4 ) { } else { throw new } | public void write ( TYPE_1 out , TYPE_2 value ) throws IOException { METHOD_1 ( value instanceof TYPE_3 || value instanceof TYPE_4 , STRING_1 ) ; if ( value instanceof TYPE_3 ) { out . value ( TYPE_5 . METHOD_2 ( ( TYPE_3 ) value ) ) ; } else { out . value ( TYPE_6 . METHOD_2 ( ( TYPE_4 ) value ) ) ; <START> } <END> } | public void write ( TYPE_1 out , TYPE_2 value ) throws IOException { if ( value instanceof TYPE_3 ) { out . value ( TYPE_5 . METHOD_2 ( ( TYPE_3 ) value ) ) ; } else if ( value instanceof TYPE_4 ) { out . value ( TYPE_6 . METHOD_2 ( ( TYPE_4 ) value ) ) ; } else { throw new IllegalArgumentException ( STRING_1 ) ; } } |
a static variable asList ( TYPE_1 values ( ) | public static TYPE_1 METHOD_1 ( String value ) { <START> return METHOD_2 ( asList ( TYPE_1 . values ( ) ) , METHOD_3 ( value ) ) . METHOD_4 ( VAR_1 ) ; <END> } | public static TYPE_1 METHOD_1 ( String value ) { return METHOD_2 ( values , METHOD_3 ( value ) ) . METHOD_4 ( VAR_1 ) ; } |
catch removed a guard provider properly implemented error / retry handlers | public TYPE_1 METHOD_1 ( String name , String id ) { TYPE_2 VAR_1 = null ; try { VAR_1 = VAR_2 . METHOD_2 ( ) . get ( Integer . valueOf ( id ) ) ; <START> } catch ( Exception ex ) { <END> throw new TYPE_3 ( STRING_1 + id ) ; } if ( VAR_1 == null ) { throw new TYPE_3 ( STRING_1 + id ) ; } return new TYPE_5 . TYPE_6 ( ) ... | public TYPE_1 METHOD_1 ( String name , String id ) { TYPE_2 VAR_1 = VAR_2 . METHOD_2 ( ) . get ( Integer . valueOf ( id ) ) ; if ( VAR_1 == null ) { throw new TYPE_3 ( STRING_1 + id ) ; } return new TYPE_5 . TYPE_6 ( ) . METHOD_3 ( id ) . name ( name ) . build ( ) ; } |
formatting : move previous line | public TYPE_1 build ( ) { return new TYPE_1 ( VAR_1 , VAR_2 , VAR_3 , VAR_4 , VAR_5 , VAR_6 , resource <START> , VAR_7 ) ; <END> } | public TYPE_1 build ( ) { return new TYPE_1 ( VAR_1 , VAR_2 , VAR_3 , VAR_5 , VAR_6 , resource , VAR_7 , VAR_4 ) ; } |
function called marker present practice input parameter won t null remove ANNOTATION_1 annotation ( apply parser classes ) | protected TYPE_1 < Object , TYPE_2 < TYPE_3 > > METHOD_1 ( List < Object > args ) { return new TYPE_1 < Object , TYPE_2 < TYPE_3 > > ( ) { @Override <START> public TYPE_2 < TYPE_3 > apply ( ANNOTATION_1 Object input ) { <END> TYPE_4 VAR_1 = TYPE_4 . class . METHOD_2 ( input ) ; return VAR_2 . METHOD_3 ( VAR_1 ) ; } } ;... | protected TYPE_1 < Object , TYPE_2 < TYPE_3 > > METHOD_1 ( List < Object > args ) { return new TYPE_1 < Object , TYPE_2 < TYPE_3 > > ( ) { @Override public TYPE_2 < TYPE_3 > apply ( Object input ) { TYPE_4 VAR_1 = TYPE_4 . class . METHOD_2 ( input ) ; return VAR_2 . METHOD_3 ( VAR_1 ) ; } } ; } |
constructor package protected | <START> TYPE_4 ( TYPE_1 < TYPE_2 > VAR_2 , TYPE_3 VAR_3 ) { <END> super ( VAR_2 , VAR_3 ) ; } | public TYPE_4 ( TYPE_1 < TYPE_2 > VAR_2 , TYPE_3 VAR_3 ) { super ( VAR_2 , VAR_3 ) ; } |
avoid statements simply declaring TYPE_1 instance builder modifying : public Builder { private final TYPE_1 options = new TYPE_1 ( ) ; public Builder page ( int page ) { options VAR_2 put ( STRING_2 String valueOf ( page ) ) ; return ; } public TYPE_1 build ( ) { return METHOD_1 ( options ) ; } } | public TYPE_1 build ( ) { TYPE_1 options = new TYPE_1 ( ) ; if ( VAR_1 != null ) { options . VAR_2 . put ( STRING_1 , String . valueOf ( VAR_1 ) ) ; VAR_1 = null ; } if ( page != null ) { options . VAR_2 . put ( STRING_2 , String . valueOf ( page ) ) ; <START> } <END> return METHOD_1 ( options ) ; } | public TYPE_1 build ( ) { return METHOD_1 ( this . options ) ; } |
remove | protected TYPE_5 ( String id , Date VAR_2 , TYPE_1 VAR_3 , String name , String description , String VAR_4 , TYPE_1 VAR_5 , TYPE_2 VAR_6 , TYPE_3 VAR_7 ) { super ( TYPE_4 . VAR_9 , id , VAR_2 , VAR_3 , name , description ) ; this . VAR_4 = METHOD_1 ( VAR_4 , STRING_1 , name ) ; this . VAR_5 = METHOD_2 ( VAR_5 ) ; this ... | protected TYPE_5 ( String id , Date VAR_2 , TYPE_1 VAR_3 , String name , String description , String VAR_4 , TYPE_1 VAR_5 , TYPE_2 VAR_6 , TYPE_3 VAR_7 ) { super ( TYPE_4 . VAR_9 , id , VAR_2 , VAR_3 , name , description ) ; this . VAR_4 = METHOD_1 ( VAR_4 , STRING_1 , name ) ; this . VAR_5 = METHOD_2 ( VAR_5 ) ; this ... |
add exception parameter ? won t able error happened message | public void METHOD_1 ( ) { try { if ( METHOD_2 ( ) ) { TYPE_1 VAR_1 = TYPE_2 . METHOD_3 ( VAR_2 , VAR_3 ) ; VAR_1 . METHOD_4 ( ) . METHOD_5 ( ) ; } } catch ( TYPE_3 | TYPE_4 e ) { <START> log . VAR_4 ( e . getMessage ( ) ) ; <END> } } | public void METHOD_1 ( ) { try { if ( METHOD_2 ( ) ) { TYPE_1 VAR_1 = TYPE_2 . METHOD_3 ( VAR_2 , VAR_3 ) ; VAR_1 . METHOD_4 ( ) . METHOD_5 ( ) ; } } catch ( TYPE_3 | TYPE_4 e ) { log . VAR_4 ( e . getMessage ( ) , e ) ; } } |
omit | public Builder METHOD_1 ( TYPE_1 VAR_1 ) { <START> this . VAR_2 . add ( VAR_1 ) ; <END> return this ; } | public Builder METHOD_1 ( TYPE_1 VAR_1 ) { VAR_2 . add ( VAR_1 ) ; return this ; } |
remember / forgets shouldn t | public void METHOD_1 ( TYPE_1 event ) { this . event = event ; TYPE_2 entity = event . VAR_1 ( ) ; TYPE_2 target = event . VAR_2 ( ) ; this . entity = new TYPE_3 ( entity ) ; this . target = target != null ? new TYPE_3 ( target ) : null ; TYPE_3 . METHOD_2 ( entity ) ; <START> TYPE_3 . METHOD_2 ( target ) ; <END> METHO... | public void METHOD_1 ( TYPE_1 event ) { this . event = event ; this . entity = new TYPE_3 ( event . VAR_1 ( ) ) ; TYPE_2 target = event . VAR_2 ( ) ; this . target = target != null ? new TYPE_3 ( target ) : null ; METHOD_3 ( event ) ; } |
( ) stringify enum | public static void METHOD_1 ( ) { TYPE_3 < TYPE_1 > METHOD_2 ( STRING_1 , ( VAR_2 , VAR_3 ) - > { <START> return new TYPE_2 ( String . valueOf ( VAR_3 . METHOD_3 ( ) . METHOD_4 ( ) ) ) ; <END> } ) ; } | public static void METHOD_1 ( ) { TYPE_3 < TYPE_1 > METHOD_2 ( STRING_1 , ( VAR_2 , VAR_3 ) - > { return new TYPE_2 ( VAR_3 . METHOD_3 ( ) . METHOD_4 ( ) . name ( ) ) ; } ) ; } |
else | public int METHOD_1 ( ) { if ( METHOD_2 ( ) ) { return METHOD_3 ( ) . METHOD_4 ( ) ; } <START> if ( METHOD_5 ( ) ) { <END> return METHOD_6 ( ) . METHOD_7 ( ) ; } else if ( METHOD_8 ( ) ) { return METHOD_9 ( ) ; } return METHOD_10 ( ) . METHOD_11 ( ) ; } | public int METHOD_1 ( ) { if ( METHOD_2 ( ) ) { return METHOD_3 ( ) . METHOD_4 ( ) ; } else if ( METHOD_5 ( ) ) { return METHOD_6 ( ) . METHOD_7 ( ) ; } else if ( METHOD_8 ( ) ) { return METHOD_9 ( ) ; } return METHOD_10 ( ) . METHOD_11 ( ) ; } |
list alphabetized ( order events _CODE_ class listing ) | public static void METHOD_1 ( ) { TYPE_1 . log ( STRING_1 ) ; TYPE_2 . METHOD_2 ( new TYPE_3 ( ) ) ; TYPE_2 . METHOD_2 ( new TYPE_4 ( ) ) ; TYPE_2 . METHOD_2 ( new TYPE_5 ( ) ) ; <START> TYPE_2 . METHOD_2 ( new TYPE_6 ( ) ) ; <END> TYPE_2 . METHOD_2 ( new TYPE_7 ( ) ) ; TYPE_2 . METHOD_2 ( new TYPE_8 ( ) ) ; TYPE_2 . M... | public static void METHOD_1 ( ) { TYPE_1 . log ( STRING_1 ) ; TYPE_2 . METHOD_2 ( new TYPE_6 ( ) ) ; TYPE_2 . METHOD_2 ( new TYPE_3 ( ) ) ; TYPE_2 . METHOD_2 ( new TYPE_4 ( ) ) ; TYPE_2 . METHOD_2 ( new TYPE_5 ( ) ) ; TYPE_2 . METHOD_2 ( new TYPE_7 ( ) ) ; TYPE_2 . METHOD_2 ( new TYPE_8 ( ) ) ; TYPE_2 . METHOD_2 ( new ... |
s null check | public TYPE_1 METHOD_1 ( ) { <START> return new TYPE_2 ( event != null ? TYPE_3 . METHOD_2 ( event . VAR_1 ( ) ) : null , null ) ; <END> } | public TYPE_1 METHOD_1 ( ) { return new TYPE_2 ( TYPE_3 . METHOD_2 ( event . VAR_1 ( ) ) , null ) ; } |
unneeded tern ( s a creeper s reading line ) | public String METHOD_1 ( ) { <START> return entity . VAR_1 ( ) instanceof TYPE_1 ? ( ( TYPE_1 ) entity . VAR_1 ( ) ) . METHOD_2 ( ) + "" : null ; <END> } | public String METHOD_1 ( ) { return String . valueOf ( ( ( TYPE_1 ) entity . VAR_1 ( ) ) . METHOD_2 ( ) ) ; } |
unneeded instanceof check reason | public void METHOD_1 ( TYPE_1 VAR_1 ) { <START> if ( VAR_1 . METHOD_2 ( STRING_1 ) && entity . VAR_2 ( ) instanceof TYPE_2 && VAR_1 . METHOD_3 ( ) ) { <END> ( ( TYPE_2 ) entity . VAR_2 ( ) ) . METHOD_4 ( VAR_1 . getValue ( ) . METHOD_5 ( ) ) ; } } | public void METHOD_1 ( TYPE_1 VAR_1 ) { if ( VAR_1 . METHOD_2 ( STRING_1 ) && VAR_1 . METHOD_3 ( ) ) { ( ( TYPE_2 ) entity . VAR_2 ( ) ) . METHOD_4 ( VAR_1 . getValue ( ) . METHOD_5 ( ) ) ; } } |
unneeded check | public String METHOD_1 ( TYPE_1 VAR_1 ) { if ( VAR_1 == null ) { return null ; } <START> if ( VAR_1 . startsWith ( STRING_1 ) && entity . VAR_2 ( ) instanceof TYPE_2 ) { <END> return new TYPE_3 ( ( ( TYPE_2 ) entity . VAR_2 ( ) ) . METHOD_2 ( ) ) . METHOD_1 ( VAR_1 . METHOD_3 ( 1 ) ) ; } return null ; } | public String METHOD_1 ( TYPE_1 VAR_1 ) { if ( VAR_1 == null ) { return null ; } if ( VAR_1 . startsWith ( STRING_1 ) ) { return new TYPE_3 ( ( ( TYPE_2 ) entity . VAR_2 ( ) ) . METHOD_2 ( ) ) . METHOD_1 ( VAR_1 . METHOD_3 ( 1 ) ) ; } return null ; } |
remove bit^ | public void METHOD_1 ( TYPE_1 VAR_1 ) { TYPE_2 . METHOD_2 ( this , VAR_1 ) ; if ( ! VAR_1 . METHOD_3 ( ) ) { <START> VAR_1 . METHOD_4 ( ) ; <END> } } | public void METHOD_1 ( TYPE_1 VAR_1 ) { TYPE_2 . METHOD_2 ( this , VAR_1 ) ; } |
mixed tabs spaces alsoreturn VAR_2 ! = null && STRING_1 equals ( VAR_2 ) ; : P | public Boolean METHOD_1 ( String VAR_1 ) { String VAR_2 = this . METHOD_2 ( VAR_1 ) ; <START> if ( VAR_2 != null && STRING_1 . equals ( VAR_2 ) ) { <END> return true ; } else { return false ; } } | public Boolean METHOD_1 ( String VAR_1 ) { String VAR_2 = this . METHOD_2 ( VAR_1 ) ; return VAR_2 != null && STRING_1 . equals ( VAR_2 ) ; } |
riittäisikö tässäkin käyttää event VAR_3 ( ) ja event VAR_4 ( ) sen sijaan että haetaan VAR_1 ja käytetään sen default identifieriä | public synchronized void METHOD_1 ( ANNOTATION_1 TYPE_1 event ) { <START> TYPE_2 VAR_1 = VAR_2 . METHOD_2 ( event . VAR_3 ( ) , event . VAR_4 ( ) ) ; <END> String VAR_5 = VAR_1 . METHOD_3 ( ) ; String VAR_6 = VAR_1 . METHOD_4 ( ) . METHOD_5 ( ) ; TYPE_3 user = new TYPE_3 ( VAR_5 , VAR_6 ) ; VAR_7 . METHOD_6 ( user ) ; ... | public synchronized void METHOD_1 ( ANNOTATION_1 TYPE_1 event ) { String VAR_5 = event . VAR_4 ( ) ; String VAR_6 = event . VAR_3 ( ) ; TYPE_3 user = new TYPE_3 ( VAR_5 , VAR_6 ) ; VAR_7 . METHOD_6 ( user ) ; } |
move a util class s marked - public api | public static boolean METHOD_1 ( String string ) { if ( string == null ) { return true ; } int length = string . length ( ) ; if ( length > 0 ) { for ( int i = 0 ; i < length ; i ++ ) { if ( ! TYPE_1 . METHOD_2 ( string . VAR_1 ( i ) ) ) { return false ; } } } <START> return true ; <END> } | private static boolean METHOD_1 ( String string ) { if ( string == null ) { return true ; } int length = string . length ( ) ; if ( length > 0 ) { for ( int i = 0 ; i < length ; i ++ ) { if ( ! TYPE_1 . METHOD_2 ( string . VAR_1 ( i ) ) ) { return false ; } } } return true ; } |
line removed | private boolean METHOD_1 ( TYPE_1 VAR_1 ) { <START> TYPE_2 . get ( VAR_1 . toString ( ) . METHOD_2 ( ) ) ; <END> return VAR_1 . METHOD_3 ( TYPE_6 . VAR_3 . getProperty ( ) , TYPE_4 . TYPE_5 . METHOD_4 ( ) ) ; } | private boolean METHOD_1 ( TYPE_1 VAR_1 ) { return VAR_1 . METHOD_3 ( TYPE_6 . VAR_3 . getProperty ( ) , TYPE_4 . TYPE_5 . METHOD_4 ( ) ) ; } |
sake consistency getId ( ) instead METHOD_3 ( ) other lowercase calls | public TYPE_1 METHOD_1 ( TYPE_1 VAR_1 ) { return VAR_2 ? VAR_3 . METHOD_2 ( ) : TYPE_2 . get ( VAR_4 , <START> VAR_1 . METHOD_3 ( ) . METHOD_4 ( ) ) ; <END> } | public TYPE_1 METHOD_1 ( TYPE_1 VAR_1 ) { return VAR_2 ? VAR_3 . METHOD_2 ( ) : TYPE_2 . get ( VAR_4 , VAR_1 . getId ( ) . METHOD_4 ( ) ) ; } |
hmm IMAGE_JP2000 boxc3 VAR_2 update _CODE_ js request datastreams jp2 ( I s current VAR_2 ) kind funny METHOD_1 default VAR_2 behavior actual controller methods require VAR_2 path | private boolean METHOD_1 ( TYPE_1 VAR_1 , String VAR_2 ) { <START> if ( VAR_2 . equals ( STRING_1 ) || VAR_2 == null ) { <END> VAR_2 = TYPE_2 . getId ( ) ; } TYPE_3 VAR_3 = TYPE_4 . METHOD_2 ( VAR_2 ) ; TYPE_5 VAR_4 = TYPE_5 . METHOD_3 ( ) ; LOG . debug ( STRING_2 , VAR_4 . METHOD_4 ( ) , VAR_2 , VAR_1 ) ; return VAR_5... | private boolean METHOD_1 ( TYPE_1 VAR_1 , String VAR_2 ) { if ( VAR_2 == null ) { VAR_2 = TYPE_2 . getId ( ) ; } TYPE_3 VAR_3 = TYPE_4 . METHOD_2 ( VAR_2 ) ; TYPE_5 VAR_4 = TYPE_5 . METHOD_3 ( ) ; LOG . debug ( STRING_2 , VAR_4 . METHOD_4 ( ) , VAR_2 , VAR_1 ) ; return VAR_5 . METHOD_1 ( VAR_1 , VAR_4 . METHOD_5 ( ) , ... |
method private | <START> byte [ ] METHOD_1 ( ) { <END> return STRING_1 . METHOD_2 ( ) ; } | private byte [ ] METHOD_1 ( ) { return STRING_1 . METHOD_2 ( ) ; } |
need determination deposit staff i d suggest checking line 54 TYPE_2 model = _CODE_ ( ) ; early return staff alternatively remove check check ( ) happen _CODE_ | private void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 model ) { Map < String , String > VAR_2 = METHOD_2 ( ) ; String VAR_3 = VAR_2 . get ( TYPE_4 . VAR_3 . name ( ) ) ; <START> if ( Boolean . VAR_5 ( VAR_3 ) ) { <END> model . add ( VAR_1 , TYPE_3 . VAR_7 , VAR_8 ) ; model . add ( VAR_1 , TYPE_3 . VAR_7 , VAR_9 ) ; } } | private void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 model ) { model . add ( VAR_1 , TYPE_3 . VAR_7 , VAR_8 ) ; model . add ( VAR_1 , TYPE_3 . VAR_7 , VAR_9 ) ; } |
skip a variable immediately return true false ( fine return catch block ) return type doesn t need a Boolean case primative boolean fine | private Boolean METHOD_1 ( TYPE_1 VAR_1 ) { <START> Boolean VAR_2 ; <END> try { TYPE_1 VAR_3 = VAR_1 . METHOD_2 ( STRING_1 , VAR_4 ) . METHOD_2 ( STRING_2 , VAR_4 ) ; VAR_2 = true ; } catch ( TYPE_2 e ) { VAR_2 = false ; } return VAR_2 ; } | private boolean METHOD_1 ( TYPE_1 VAR_1 ) { boolean VAR_2 ; try { TYPE_1 VAR_3 = VAR_1 . METHOD_2 ( STRING_1 , VAR_4 ) . METHOD_2 ( STRING_2 , VAR_4 ) ; VAR_2 = true ; } catch ( TYPE_2 e ) { VAR_2 = false ; } return VAR_2 ; } |
test assign instance passing VAR_1 | public static synchronized TYPE_1 getInstance ( ) { TYPE_1 VAR_1 = instance ; <START> if ( VAR_1 == null ) { <END> VAR_1 = new TYPE_1 ( ) ; instance = VAR_1 ; TYPE_2 . METHOD_1 ( ) ; } return VAR_1 ; } | public static synchronized TYPE_1 getInstance ( ) { if ( instance == null ) { instance = new TYPE_1 ( ) ; TYPE_2 . METHOD_1 ( ) ; } return instance ; } |
constructor protected access ? other processors public constructors | <START> protected TYPE_1 ( String VAR_2 ) { <END> this . VAR_2 = VAR_2 ; if ( ! VAR_2 . METHOD_1 ( STRING_1 ) ) { this . VAR_2 += STRING_1 ; } } | public TYPE_1 ( String VAR_2 ) { this . VAR_2 = VAR_2 ; if ( ! VAR_2 . METHOD_1 ( STRING_1 ) ) { this . VAR_2 += STRING_1 ; } } |
thinking some I don t METHOD_1 needs providing a model changing properties pretty refreshing need replace properties a point other ways | public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 , String VAR_2 , String VAR_3 , String VAR_4 , String VAR_5 ) { String VAR_6 = METHOD_2 ( ) ; <START> TYPE_3 VAR_7 = TYPE_4 . METHOD_3 ( ) ; <END> TYPE_5 VAR_8 = VAR_7 . METHOD_4 ( VAR_6 ) ; VAR_8 . METHOD_5 ( VAR_9 . type , TYPE_6 . TYPE_7 ) ; return VAR_12 . METHOD_6 ( VAR_13 , V... | public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 , String VAR_2 , String VAR_3 , String VAR_4 , String VAR_5 ) { return VAR_12 . METHOD_6 ( VAR_13 , VAR_14 , VAR_1 , VAR_2 , VAR_3 , VAR_4 , VAR_5 , null ) ; } |
wondering called VAR_2 METHOD_3 ( ) reflect updated MODS ? I don t caching | public void METHOD_1 ( ) throws Exception { METHOD_2 ( STRING_1 ) ; TYPE_1 VAR_1 = VAR_2 . METHOD_3 ( ) . METHOD_4 ( ) ; METHOD_5 ( VAR_1 ) ; VAR_3 = METHOD_6 ( STRING_2 ) ; METHOD_7 ( ) ; job . run ( ) ; METHOD_8 ( VAR_4 ) . METHOD_9 ( METHOD_10 ( TYPE_2 . class ) ) ; <START> TYPE_1 VAR_5 = VAR_6 . METHOD_11 ( VAR_2 .... | public void METHOD_1 ( ) throws Exception { METHOD_2 ( STRING_1 ) ; TYPE_1 VAR_1 = VAR_2 . METHOD_3 ( ) . METHOD_4 ( ) ; METHOD_5 ( VAR_1 ) ; VAR_3 = METHOD_6 ( STRING_2 ) ; METHOD_7 ( ) ; job . run ( ) ; METHOD_8 ( VAR_4 ) . METHOD_9 ( METHOD_10 ( TYPE_2 . class ) ) ; TYPE_1 VAR_5 = VAR_2 . METHOD_3 ( ) . METHOD_4 ( )... |
t lines 149 - 150 combined | private void METHOD_1 ( TYPE_1 VAR_1 ) { VAR_2 . METHOD_2 ( STRING_1 + VAR_3 . METHOD_3 ( ) + STRING_2 + VAR_1 , VAR_1 , VAR_3 . METHOD_4 ( ) , TYPE_4 . VAR_5 ) ; TYPE_2 VAR_6 = VAR_7 . METHOD_5 ( VAR_1 ) ; <START> TYPE_3 VAR_8 = ( TYPE_3 ) VAR_6 ; <END> METHOD_6 ( VAR_1 ) ; VAR_9 . METHOD_7 ( VAR_8 ) ; } | private void METHOD_1 ( TYPE_1 VAR_1 ) { VAR_2 . METHOD_2 ( STRING_1 + VAR_3 . METHOD_3 ( ) + STRING_2 + VAR_1 , VAR_1 , VAR_3 . METHOD_4 ( ) , TYPE_4 . VAR_5 ) ; TYPE_3 VAR_8 = ( TYPE_3 ) VAR_7 . METHOD_5 ( VAR_1 ) ; METHOD_6 ( VAR_1 ) ; VAR_9 . METHOD_7 ( VAR_8 ) ; } |
I d suggest calling METHOD_1 method context file instead | public void METHOD_1 ( ) throws Exception { METHOD_2 ( TYPE_1 . VAR_2 ) ; <START> VAR_3 . METHOD_1 ( ) ; <END> } | public void METHOD_1 ( ) throws Exception { METHOD_2 ( TYPE_1 . VAR_2 ) ; } |
change new ArrayList < > ( ) ; | private List < TYPE_1 > METHOD_1 ( int VAR_1 ) { <START> List < TYPE_1 > VAR_2 = new ArrayList < TYPE_1 > ( ) ; <END> int i = 0 ; while ( i < VAR_1 ) { TYPE_1 VAR_3 = METHOD_2 ( TYPE_1 . class ) ; when ( VAR_3 . getId ( ) ) . METHOD_3 ( STRING_1 + TYPE_2 . METHOD_4 ( ) . toString ( ) ) ; VAR_2 . add ( VAR_3 ) ; i ++ ; ... | private List < TYPE_1 > METHOD_1 ( int VAR_1 ) { List < TYPE_1 > VAR_2 = new ArrayList < > ( ) ; int i = 0 ; while ( i < VAR_1 ) { TYPE_1 VAR_3 = METHOD_2 ( TYPE_1 . class ) ; when ( VAR_3 . getId ( ) ) . METHOD_3 ( STRING_1 + TYPE_2 . METHOD_4 ( ) . toString ( ) ) ; VAR_2 . add ( VAR_3 ) ; i ++ ; } return VAR_2 ; } |
method ends line clearer remove rest method | public void METHOD_1 ( ) throws Exception { <START> VAR_1 = new TYPE_1 ( VAR_2 , VAR_3 , VAR_4 , VAR_5 ) ; <END> try { VAR_1 . METHOD_2 ( VAR_6 ) ; } finally { METHOD_3 ( VAR_1 ) . equals ( TYPE_2 . class ) ; } } | public void METHOD_1 ( ) throws Exception { VAR_1 = new TYPE_1 ( VAR_2 , VAR_3 , VAR_4 , VAR_5 ) ; } |
pass event type METHOD_5 instead VAR_4 shouldn t event type EVENT_NS | public void METHOD_1 ( ) throws Exception { METHOD_2 ( STRING_1 ) . METHOD_3 ( 0 ) ; METHOD_4 ( VAR_1 ) ; Map < String , Object > VAR_2 = METHOD_5 ( VAR_3 , VAR_4 ) ; <START> VAR_2 . put ( VAR_5 , STRING_2 ) ; <END> VAR_6 . METHOD_6 ( "" , VAR_2 ) ; METHOD_7 ( ) ; } | public void METHOD_1 ( ) throws Exception { METHOD_2 ( STRING_1 ) . METHOD_3 ( 0 ) ; METHOD_4 ( VAR_1 ) ; Map < String , Object > VAR_2 = METHOD_5 ( VAR_3 ) ; VAR_2 . put ( VAR_5 , STRING_2 ) ; VAR_6 . METHOD_6 ( "" , VAR_2 ) ; METHOD_7 ( ) ; } |
returned ? isn t supposed throw exception invalid member type | public void METHOD_1 ( ) { VAR_1 . METHOD_2 ( VAR_2 ) ; TYPE_1 < TYPE_2 > VAR_3 = TYPE_1 . METHOD_3 ( TYPE_2 . class ) ; <START> METHOD_4 ( VAR_4 ) . METHOD_2 ( METHOD_5 ( VAR_1 ) , VAR_3 . METHOD_6 ( ) ) ; <END> TYPE_2 child = VAR_3 . getValue ( ) ; METHOD_7 ( STRING_1 , child instanceof TYPE_3 ) ; } | public void METHOD_1 ( ) { VAR_1 . METHOD_2 ( VAR_2 ) ; } |
return VAR_5 | private TYPE_1 METHOD_1 ( TYPE_1 VAR_1 ) { String VAR_2 = TYPE_2 . METHOD_2 ( VAR_1 , TYPE_6 . VAR_4 ) ; TYPE_1 VAR_5 = TYPE_1 . create ( VAR_2 ) ; if ( METHOD_3 ( VAR_5 ) ) { <START> return VAR_1 ; <END> } TYPE_3 model = TYPE_4 . METHOD_4 ( ) ; TYPE_5 VAR_6 = model . VAR_7 ( VAR_2 ) ; VAR_6 . METHOD_5 ( VAR_8 . VAR_9 ... | private TYPE_1 METHOD_1 ( TYPE_1 VAR_1 ) { String VAR_2 = TYPE_2 . METHOD_2 ( VAR_1 , TYPE_6 . VAR_4 ) ; TYPE_1 VAR_5 = TYPE_1 . create ( VAR_2 ) ; if ( METHOD_3 ( VAR_5 ) ) { return VAR_5 ; } TYPE_3 model = TYPE_4 . METHOD_4 ( ) ; TYPE_5 VAR_6 = model . VAR_7 ( VAR_2 ) ; VAR_6 . METHOD_5 ( VAR_8 . VAR_9 , STRING_1 ) ;... |
I d suggest renaming variable VAR_1 implies source metadata context resource current _CODE_ | public TYPE_1 METHOD_1 ( ) { <START> TYPE_2 VAR_1 = this . METHOD_2 ( ) ; <END> TYPE_3 s = VAR_1 . getProperty ( TYPE_6 . VAR_3 ) ; if ( s != null ) { TYPE_4 VAR_4 = TYPE_5 . get ( s . VAR_5 ( ) . METHOD_3 ( ) ) ; return VAR_6 . METHOD_4 ( VAR_4 ) ; } else { return null ; } } | public TYPE_1 METHOD_1 ( ) { TYPE_2 res = this . METHOD_2 ( ) ; TYPE_3 s = res . getProperty ( TYPE_6 . VAR_3 ) ; if ( s != null ) { TYPE_4 VAR_4 = TYPE_5 . get ( s . VAR_5 ( ) . METHOD_3 ( ) ) ; return VAR_6 . METHOD_4 ( VAR_4 ) ; } else { return null ; } } |
I t run test moment I don t line test VAR_3 METHOD_2 VAR_5 METHOD_5 VAR_3 create methods called TYPE_1 class _CODE_ _CODE_ methods _CODE_ I m clear need I m left TYPE_1 | public void METHOD_1 ( ) { TYPE_1 VAR_1 = new TYPE_1 ( VAR_2 , VAR_3 , VAR_4 ) ; <START> when ( VAR_3 . METHOD_2 ( METHOD_3 ( TYPE_2 . class ) , METHOD_3 ( TYPE_3 . class ) ) ) <END> . METHOD_4 ( VAR_1 ) ; VAR_5 . METHOD_5 ( VAR_1 ) ; } | public void METHOD_1 ( ) { TYPE_1 VAR_1 = new TYPE_1 ( VAR_2 , VAR_3 , VAR_4 ) ; VAR_5 . METHOD_5 ( VAR_1 ) ; } |
curiosity return type setter void | <START> public TYPE_1 METHOD_1 ( TYPE_2 model ) { <END> this . model = model ; return this ; } | public void METHOD_1 ( TYPE_2 model ) { this . model = model ; } |
TYPE_5 _CODE_ | public TYPE_1 METHOD_1 ( String VAR_1 ) { TYPE_2 VAR_2 = TYPE_3 . METHOD_2 ( ) ; <START> TYPE_4 VAR_3 = VAR_2 . METHOD_3 ( STRING_1 ) ; <END> METHOD_4 ( TYPE_5 . VAR_5 , VAR_3 , STRING_2 , VAR_1 ) ; return this ; } | public TYPE_1 METHOD_1 ( String VAR_1 ) { TYPE_2 VAR_2 = TYPE_3 . METHOD_2 ( ) ; TYPE_4 VAR_3 = VAR_2 . METHOD_3 ( TYPE_5 . VAR_5 ) ; METHOD_4 ( TYPE_5 . VAR_5 , VAR_3 , STRING_2 , VAR_1 ) ; return this ; } |
doesn t a reason hold VAR_4 VAR_3 instance variables TYPE_3 class don t need live long enough call METHOD_1 pass parameters | public TYPE_3 ( String VAR_2 , TYPE_1 VAR_3 , Date VAR_4 , TYPE_2 VAR_5 ) { this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; <START> this . VAR_4 = VAR_4 ; <END> this . VAR_5 = VAR_5 ; METHOD_1 ( ) ; } | public TYPE_3 ( String VAR_2 , TYPE_1 VAR_3 , Date VAR_4 , TYPE_2 VAR_5 ) { this . VAR_2 = VAR_2 ; this . VAR_5 = VAR_5 ; METHOD_1 ( VAR_3 , VAR_4 ) ; } |
I drop METHOD_4 method calling constructor TYPE_1 actual file creation | public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { File file = new File ( VAR_2 , TYPE_3 . VAR_4 + STRING_1 + VAR_1 . METHOD_2 ( ) + STRING_2 ) ; try { TYPE_1 VAR_5 ; if ( ! file . exists ( ) ) { file . VAR_6 ( ) . METHOD_3 ( ) ; } <START> VAR_5 = METHOD_4 ( VAR_1 , file ) ; <END> return VAR_5 ; } catch ( IOException e ) { METH... | public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { File file = new File ( VAR_2 , TYPE_3 . VAR_4 + STRING_1 + VAR_1 . METHOD_2 ( ) + STRING_2 ) ; try { if ( ! file . exists ( ) ) { file . VAR_6 ( ) . METHOD_3 ( ) ; } return new TYPE_1 ( VAR_1 , file ) ; } catch ( Exception e ) { METHOD_5 ( e , STRING_3 , file . VAR_7 ( ) ) ; } ... |
move line loop | public void METHOD_1 ( ) throws Exception { LOG . info ( STRING_1 ) ; Map < String , TYPE_1 > VAR_1 = VAR_2 . METHOD_2 ( TYPE_1 . class ) ; for ( TYPE_1 VAR_3 : VAR_1 . values ( ) ) { VAR_3 . METHOD_3 ( true ) ; <START> VAR_2 . METHOD_1 ( ) ; <END> } } | public void METHOD_1 ( ) throws Exception { LOG . info ( STRING_1 ) ; Map < String , TYPE_1 > VAR_1 = VAR_2 . METHOD_2 ( TYPE_1 . class ) ; for ( TYPE_1 VAR_3 : VAR_1 . values ( ) ) { VAR_3 . METHOD_3 ( true ) ; } VAR_2 . METHOD_1 ( ) ; } |
reason return staging location | protected String METHOD_1 ( ) { String result = null ; ANNOTATION_1 ( STRING_1 ) Iterator i = VAR_1 . METHOD_2 ( new TYPE_1 ( STRING_2 , TYPE_3 . VAR_3 ) ) ; while ( i . hasNext ( ) ) { TYPE_2 e = ( TYPE_2 ) i . next ( ) ; String VAR_4 = e . VAR_5 ( ) ; <START> if ( VAR_4 . length ( ) > 0 ) result = VAR_4 ; <END> } ret... | protected String METHOD_1 ( ) { String result = null ; ANNOTATION_1 ( STRING_1 ) Iterator i = VAR_1 . METHOD_2 ( new TYPE_1 ( STRING_2 , TYPE_3 . VAR_3 ) ) ; while ( i . hasNext ( ) ) { TYPE_2 e = ( TYPE_2 ) i . next ( ) ; String VAR_4 = e . VAR_5 ( ) ; if ( VAR_4 . length ( ) > 0 ) { result = VAR_4 ; break ; } } retur... |
enforce immutability lists ImmutableList _CODE_ list null | private static TYPE_1 create ( String name , int VAR_1 , List < TYPE_2 > VAR_2 ) { <START> return builder ( ) . name ( name ) . METHOD_1 ( VAR_1 ) . METHOD_2 ( VAR_2 ) . build ( ) ; <END> } | static TYPE_1 create ( String name , int VAR_1 , List < TYPE_2 > VAR_2 ) { return builder ( ) . name ( name ) . METHOD_1 ( VAR_1 ) . METHOD_2 ( VAR_2 ) . build ( ) ; } |
full package names necessary TYPE_1 suffice previous 2 lines | public org . VAR_1 . VAR_2 . VAR_3 . VAR_4 . TYPE_1 build ( ) { <START> return new org . VAR_1 . VAR_2 . VAR_3 . VAR_4 . TYPE_1 ( this ) ; <END> } | public TYPE_1 build ( ) { return new TYPE_1 ( this ) ; } |
curious reason fully - qualified | public TYPE_1 METHOD_1 ( String VAR_1 ) { METHOD_2 ( VAR_1 ) ; <START> return new org . VAR_2 . VAR_3 . VAR_4 . VAR_5 . VAR_6 . VAR_7 . TYPE_2 ( <END> METHOD_3 ( VAR_1 ) , VAR_9 ) ; } | public TYPE_1 METHOD_1 ( String VAR_1 ) { METHOD_2 ( VAR_1 ) ; return new TYPE_2 ( METHOD_3 ( VAR_1 ) , VAR_9 ) ; } |
don t need METHOD_1 ( ) ? ; - ) | protected TYPE_2 ( long VAR_2 , long VAR_3 , long VAR_4 , Map < String , String > metadata , TYPE_1 < String , String > VAR_5 ) { this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; this . VAR_4 = VAR_4 ; this . metadata = metadata == null ? TYPE_3 < String , String > of ( ) : METHOD_1 ( metadata , STRING_1 ) ; <START> this ... | protected TYPE_2 ( long VAR_2 , long VAR_3 , long VAR_4 , Map < String , String > metadata , TYPE_1 < String , String > VAR_5 ) { this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; this . VAR_4 = VAR_4 ; this . metadata = metadata == null ? TYPE_3 < String , String > of ( ) : metadata ; this . VAR_5 = VAR_5 == null ? TYPE_4... |
optimization ? METHOD_2 expensive s put | public TYPE_1 METHOD_1 ( TYPE_2 < String , String > VAR_1 ) { <START> if ( ! VAR_1 . isEmpty ( ) ) { <END> this . VAR_1 . METHOD_2 ( VAR_1 ) ; } return this ; } | public TYPE_1 METHOD_1 ( TYPE_2 < String , String > VAR_1 ) { this . VAR_1 . METHOD_2 ( VAR_1 ) ; return this ; } |
assertions wrong | public void METHOD_1 ( ) { TYPE_1 options = new TYPE_1 ( ) . METHOD_2 ( TYPE_2 . of ( VAR_1 , STRING_1 ) ) ; <START> assertEquals ( ImmutableList . of ( STRING_1 ) , options . VAR_2 ( ) . get ( VAR_1 ) ) ; <END> } | public void METHOD_1 ( ) { TYPE_1 options = new TYPE_1 ( ) . METHOD_2 ( TYPE_2 . of ( VAR_1 , STRING_1 ) ) ; assertEquals ( options . VAR_2 ( ) . get ( VAR_1 ) , ImmutableList . of ( STRING_1 ) ) ; } |
assertions wrong | public void METHOD_1 ( ) { TYPE_1 < String , String > VAR_1 = TYPE_2 . of ( VAR_2 , STRING_1 ) ; TYPE_3 options = new TYPE_3 ( ) . METHOD_2 ( VAR_1 ) ; <START> assertEquals ( ImmutableList . of ( STRING_1 ) , options . VAR_3 ( ) . get ( VAR_2 ) ) ; <END> } | public void METHOD_1 ( ) { TYPE_1 < String , String > VAR_1 = TYPE_2 . of ( VAR_2 , STRING_1 ) ; TYPE_3 options = new TYPE_3 ( ) . METHOD_2 ( VAR_1 ) ; assertEquals ( options . VAR_3 ( ) . get ( VAR_2 ) , ImmutableList . of ( STRING_1 ) ) ; } |
don t need assertion | public void METHOD_1 ( ) throws Exception { for ( String VAR_1 : VAR_2 ) { TYPE_1 VAR_3 = VAR_4 . METHOD_2 ( VAR_1 , VAR_5 ) ; TYPE_2 response = VAR_3 . list ( ) ; assertEquals ( response . VAR_6 ( ) , VAR_4 . METHOD_3 ( VAR_1 ) . get ( VAR_5 ) ) ; <START> assertNotNull ( response ) ; <END> for ( TYPE_3 object : respon... | public void METHOD_1 ( ) throws Exception { for ( String VAR_1 : VAR_2 ) { TYPE_1 VAR_3 = VAR_4 . METHOD_2 ( VAR_1 , VAR_5 ) ; TYPE_2 response = VAR_3 . list ( ) ; assertEquals ( response . VAR_6 ( ) , VAR_4 . METHOD_3 ( VAR_1 ) . get ( VAR_5 ) ) ; for ( TYPE_3 object : response ) { METHOD_4 ( object ) ; } } } |
instead catch METHOD_7 ( expected = TYPE_4 ) | public void METHOD_1 ( ) throws Exception { TYPE_1 VAR_1 = TYPE_1 . builder ( ) . METHOD_2 ( INT_1 ) . message ( STRING_1 ) . METHOD_3 ( METHOD_4 ( STRING_2 , STRING_3 ) ) . build ( ) ; TYPE_2 VAR_2 = METHOD_5 ( VAR_3 , VAR_4 , VAR_5 , VAR_1 ) ; try { VAR_2 . METHOD_6 ( STRING_4 ) . list ( ) ; } catch ( TYPE_3 e ) { if... | public void METHOD_1 ( ) throws Exception { TYPE_1 VAR_1 = TYPE_1 . builder ( ) . METHOD_2 ( INT_1 ) . message ( STRING_1 ) . METHOD_3 ( METHOD_4 ( STRING_2 , STRING_3 ) ) . build ( ) ; TYPE_2 VAR_2 = METHOD_5 ( VAR_3 , VAR_4 , VAR_5 , VAR_1 ) ; VAR_2 . METHOD_6 ( STRING_4 ) . list ( ) ; } |
constructor logic metadata = metadata | public Builder metadata ( Map < String , Object > metadata ) { if ( metadata == null ) { this . metadata = TYPE_1 . of ( ) ; } else { this . metadata = TYPE_1 . METHOD_1 ( metadata ) ; <START> } <END> return this ; } | public Builder metadata ( Map < String , Object > metadata ) { this . metadata = metadata ; return this ; } |
null a valid input | public static TYPE_1 METHOD_1 ( String value ) { <START> if ( value == null ) return null ; <END> return TYPE_1 . valueOf ( value . VAR_1 ( ) ) ; } | public static TYPE_1 METHOD_1 ( String value ) { return TYPE_1 . valueOf ( value . VAR_1 ( ) ) ; } |
else ? reason System | public static TYPE_1 METHOD_1 ( ) { System . VAR_1 ( VAR_2 , STRING_1 ) ; System . VAR_1 ( VAR_3 , STRING_2 ) ; System . VAR_1 ( VAR_4 , STRING_3 ) ; <START> System . VAR_1 ( VAR_5 , STRING_4 ) ; <END> TYPE_1 properties = TYPE_2 . METHOD_1 ( ) ; properties . VAR_1 ( VAR_6 , TYPE_3 . VAR_8 ) ; properties . VAR_1 ( VAR_9... | public static TYPE_1 METHOD_1 ( ) { TYPE_1 properties = TYPE_2 . METHOD_1 ( ) ; properties . VAR_1 ( VAR_6 , TYPE_3 . VAR_8 ) ; properties . VAR_1 ( VAR_9 , TYPE_4 . VAR_11 ) ; return properties ; } |
fact combine check : VAR_1 X Y ( inclusive ) Z | public Builder METHOD_1 ( int VAR_1 ) { METHOD_2 ( VAR_1 >= METHOD_3 ( VAR_2 ) , STRING_1 , METHOD_3 ( VAR_2 ) ) ; <START> METHOD_2 ( VAR_1 <= METHOD_3 ( VAR_3 ) , STRING_2 , METHOD_3 ( VAR_3 ) ) ; <END> this . VAR_1 = VAR_1 ; return METHOD_4 ( ) ; } | public Builder METHOD_1 ( int VAR_1 ) { this . VAR_1 = VAR_1 ; return METHOD_4 ( ) ; } |
injectable _CODE_ function | <START> protected static String METHOD_1 ( String VAR_1 ) { <END> return VAR_1 . substring ( VAR_1 . METHOD_2 ( CHAR_1 ) + 1 ) ; } | private static String METHOD_1 ( String VAR_1 ) { return VAR_1 . substring ( VAR_1 . METHOD_2 ( CHAR_1 ) + 1 ) ; } |
binding redundant _CODE_ adds remove | protected void METHOD_1 ( ) { <START> bind ( TYPE_1 . class ) . to ( TYPE_2 . class ) ; <END> super . METHOD_1 ( ) ; } | protected void METHOD_1 ( ) { super . METHOD_1 ( ) ; } |
throw _CODE_ | public int METHOD_1 ( TYPE_1 that ) { <START> if ( that == null ) <END> return 1 ; if ( this == that ) return 0 ; return this . METHOD_2 ( ) . METHOD_1 ( that . VAR_1 ( ) ) ; } | public int METHOD_1 ( TYPE_1 that ) { return this . METHOD_2 ( ) . METHOD_1 ( that . VAR_1 ( ) ) ; } |
extract a constant | public TYPE_1 filter ( TYPE_1 request ) throws TYPE_2 { String VAR_1 = request . VAR_2 ( ) . toString ( ) ; <START> TYPE_3 VAR_3 = TYPE_3 . METHOD_1 ( STRING_1 ) ; <END> TYPE_4 matcher = VAR_3 . matcher ( VAR_1 ) ; matcher . VAR_4 ( ) ; String VAR_5 = matcher . group ( ) ; String VAR_6 = VAR_5 . METHOD_2 ( STRING_2 , S... | public TYPE_1 filter ( TYPE_1 request ) throws TYPE_2 { String VAR_1 = request . VAR_2 ( ) . toString ( ) ; TYPE_4 matcher = VAR_3 . matcher ( VAR_1 ) ; if ( ! matcher . VAR_4 ( ) ) return request ; String VAR_5 = matcher . group ( ) ; String VAR_6 = VAR_5 . METHOD_2 ( STRING_2 , STRING_3 ) ; String VAR_7 = matcher . V... |
I s store reference future enhancements instead copying content I love idea a configuration object : + 1 : | public TYPE_5 ( Object VAR_2 , TYPE_1 VAR_3 ) { if ( VAR_2 == null ) return ; new TYPE_2 ( ) . parse ( VAR_2 , this ) ; if ( VAR_3 . METHOD_1 ( ) ) { Collections . VAR_4 ( options , new TYPE_3 < TYPE_4 > ( ) { public int METHOD_2 ( TYPE_4 VAR_5 , TYPE_4 VAR_6 ) { return VAR_5 . VAR_7 . toString ( ) . METHOD_3 ( VAR_6 .... | public TYPE_5 ( Object VAR_2 , TYPE_1 VAR_3 ) { this . VAR_3 = VAR_3 ; if ( VAR_2 == null ) return ; new TYPE_2 ( ) . parse ( VAR_2 , this ) ; if ( VAR_3 . METHOD_1 ( ) ) { Collections . VAR_4 ( options , new TYPE_3 < TYPE_4 > ( ) { public int METHOD_2 ( TYPE_4 VAR_5 , TYPE_4 VAR_6 ) { return VAR_5 . VAR_7 . toString (... |
a builder pattern combination fluent interface some kind immutable class pattern immutable class more complicated class grows setter a big constructor call necessary | public TYPE_1 METHOD_1 ( int VAR_1 ) { if ( VAR_1 < 0 ) throw new IllegalArgumentException ( STRING_1 ) ; if ( this . VAR_1 == VAR_1 ) return this ; <START> return new TYPE_1 ( VAR_1 , this . VAR_2 ) ; <END> } | public TYPE_1 METHOD_1 ( int VAR_1 ) { if ( VAR_1 < 0 ) throw new IllegalArgumentException ( STRING_1 ) ; this . VAR_1 = VAR_1 ; return this ; } |
able diamond operator i e new ArrayList < > ( ) | public static List < Class < ? > > METHOD_1 ( Class VAR_1 ) { <START> ArrayList < Class < ? > > result = new ArrayList < Class < ? > > ( ) ; <END> METHOD_2 ( VAR_1 , result ) ; return result ; } | public static List < Class < ? > > METHOD_1 ( Class VAR_1 ) { ArrayList < Class < ? > > result = new ArrayList < > ( ) ; METHOD_2 ( VAR_1 , result ) ; return result ; } |
case alter table new version VAR_2 = = 3 && VAR_1 < = 2 | public static void METHOD_1 ( Context context , TYPE_1 db , int VAR_1 , int VAR_2 ) { if ( VAR_2 <= 2 ) { db . VAR_3 ( VAR_4 ) ; METHOD_2 ( context , db ) ; } else if ( VAR_2 >= 3 ) { final String VAR_5 = STRING_1 + VAR_6 + STRING_2 + VAR_7 + STRING_3 ; <START> db . VAR_3 ( VAR_5 ) ; <END> } } | public static void METHOD_1 ( Context context , TYPE_1 db , int VAR_1 , int VAR_2 ) { if ( VAR_1 <= 2 ) { final String VAR_5 = STRING_1 + VAR_6 + STRING_2 + VAR_7 + STRING_3 ; db . VAR_3 ( VAR_5 ) ; } } |
[ x ] unnecessary VAR_3 size zero METHOD_7 ( VAR_3 ( STRING_1 ) ) ; METHOD_7 ( VAR_3 ( STRING_2 ) ) ; - - - removed 059df0362e3fc35b1ec81490950162cfbd065425 | public void METHOD_1 ( ) { TYPE_1 VAR_1 = new TYPE_1 ( ) ; VAR_1 . METHOD_2 ( VAR_2 ) ; VAR_1 . METHOD_3 ( STRING_1 ) ; VAR_1 . METHOD_4 ( STRING_2 ) ; VAR_1 . METHOD_5 ( STRING_3 ) ; Map < String , String > VAR_3 = VAR_1 . METHOD_6 ( ) ; assertThat ( VAR_3 . size ( ) , is ( 0 ) ) ; METHOD_7 ( VAR_3 . get ( STRING_1 ) ... | public void METHOD_1 ( ) { TYPE_1 VAR_1 = new TYPE_1 ( ) ; VAR_1 . METHOD_2 ( VAR_2 ) ; VAR_1 . METHOD_3 ( STRING_1 ) ; VAR_1 . METHOD_4 ( STRING_2 ) ; VAR_1 . METHOD_5 ( STRING_3 ) ; Map < String , String > VAR_3 = VAR_1 . METHOD_6 ( ) ; assertThat ( VAR_3 . size ( ) , is ( 0 ) ) ; } |
I logs chatty messages important startup change LOGGER info ( ) | private void METHOD_1 ( ) throws IOException { <START> LOGGER . debug ( STRING_1 , VAR_1 ) ; <END> LOGGER . debug ( STRING_2 , VAR_2 ) ; LOGGER . debug ( STRING_3 , VAR_3 ) ; TYPE_1 . METHOD_2 ( VAR_1 ) ; TYPE_1 . METHOD_2 ( VAR_2 ) ; TYPE_1 . METHOD_2 ( VAR_3 ) ; } | private void METHOD_1 ( ) throws IOException { LOGGER . info ( STRING_1 , VAR_1 ) ; LOGGER . info ( STRING_2 , VAR_2 ) ; LOGGER . info ( STRING_3 , VAR_3 ) ; TYPE_1 . METHOD_2 ( VAR_1 ) ; TYPE_1 . METHOD_2 ( VAR_2 ) ; TYPE_1 . METHOD_2 ( VAR_3 ) ; } |
reduce logging debug favor cleaner output _CODE_ | public TYPE_3 ( ANNOTATION_1 ( STRING_1 ) final Path VAR_2 ) { <START> LOGGER . info ( STRING_2 , <END> VAR_2 ) ; try { this . VAR_2 = TYPE_1 . METHOD_1 ( VAR_2 ) ; } catch ( IOException e ) { throw new TYPE_2 ( e ) ; } } | public TYPE_3 ( ANNOTATION_1 ( STRING_1 ) final Path VAR_2 ) { LOGGER . debug ( STRING_2 , VAR_2 ) ; try { this . VAR_2 = TYPE_1 . METHOD_1 ( VAR_2 ) ; } catch ( IOException e ) { throw new TYPE_2 ( e ) ; } } |
remove throws clause | <START> private String METHOD_1 ( final String value ) throws Exception { <END> return TYPE_1 . METHOD_1 ( value , TYPE_2 . VAR_2 ) ; } | private String METHOD_1 ( final String value ) { return TYPE_1 . METHOD_1 ( value , TYPE_2 . VAR_2 ) ; } |
remove final method static | <START> public static final TYPE_1 METHOD_1 ( final String VAR_1 ) { <END> for ( TYPE_1 o : TYPE_1 . values ( ) ) { if ( o . value . equals ( VAR_1 ) ) { return o ; } } throw new IllegalArgumentException ( STRING_1 + VAR_1 + STRING_2 ) ; } | public static TYPE_1 METHOD_1 ( final String VAR_1 ) { for ( TYPE_1 o : TYPE_1 . values ( ) ) { if ( o . value . equals ( VAR_1 ) ) { return o ; } } throw new IllegalArgumentException ( STRING_1 + VAR_1 + STRING_2 ) ; } |
a thought push expression parse logic class I TYPE_3 public static methods : * public static TYPE_3 _CODE_ ( final String _CODE_ ) ; * public static TYPE_3 _CODE_ ( final String field final String VAR_2 final String object ) ; * public static TYPE_3 _CODE_ ( final TYPE_1 field final TYPE_2 VAR_2 final String object ) ;... | <START> public TYPE_3 ( final TYPE_1 field , final TYPE_2 VAR_2 , final String object ) { <END> this . field = field ; this . VAR_2 = VAR_2 ; this . object = object ; } | private TYPE_3 ( final TYPE_1 field , final TYPE_2 VAR_2 , final String object ) { this . field = field ; this . VAR_2 = VAR_2 ; this . object = object ; } |
doesn t feel required | public void METHOD_1 ( TYPE_1 context ) throws Exception { <START> TYPE_2 . getInstance ( ) . METHOD_2 ( ) ; <END> super . METHOD_1 ( context ) ; } | public void METHOD_1 ( TYPE_1 context ) throws Exception { try { TYPE_2 . getInstance ( ) . METHOD_2 ( ) ; } finally { super . METHOD_1 ( context ) ; } } |
I placement a problem a number call sites call METHOD_1 ( int boolean ) essentially bypass resolution I edit main METHOD_1 method capturing return statement else wrap method a method substitution ( reduce maximum stack VAR_3 achieved ) | protected Object METHOD_1 ( final boolean VAR_1 ) throws TYPE_1 , IOException { <START> final Object obj = VAR_2 . METHOD_2 ( METHOD_1 ( METHOD_3 ( ) , VAR_1 ) ) ; <END> if ( VAR_3 == 0 ) { final TYPE_2 < TYPE_3 > VAR_4 = this . VAR_4 ; if ( VAR_4 != null ) { this . VAR_4 = null ; VAR_5 = 0 ; for ( TYPE_3 VAR_6 : VAR_4... | protected Object METHOD_1 ( final boolean VAR_1 ) throws TYPE_1 , IOException { final Object obj = METHOD_1 ( METHOD_3 ( ) , VAR_1 ) ; if ( VAR_3 == 0 ) { final TYPE_2 < TYPE_3 > VAR_4 = this . VAR_4 ; if ( VAR_4 != null ) { this . VAR_4 = null ; VAR_5 = 0 ; for ( TYPE_3 VAR_6 : VAR_4 ) { VAR_6 . METHOD_4 ( ) . METHOD_... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.