ReviewComments stringlengths 1 2.35k | OriginalCode stringlengths 28 487 | ReviewedCode stringlengths 14 463 |
|---|---|---|
consumer log METHOD_4 ( ) | private void METHOD_1 ( final Set < TYPE_1 > VAR_1 ) { final Set < TYPE_1 > VAR_2 = new HashSet < > ( VAR_3 . METHOD_2 ( ) ) ; if ( VAR_2 . METHOD_3 ( VAR_1 ) ) { throw new IllegalStateException ( STRING_1 + VAR_3 . METHOD_2 ( ) + STRING_2 + STRING_3 + VAR_1 ) ; } VAR_2 . addAll ( VAR_1 ) ; VAR_3 . METHOD_4 ( VAR_2 ) ;... | private void METHOD_1 ( final Set < TYPE_1 > VAR_1 ) { final Set < TYPE_1 > VAR_2 = new HashSet < > ( VAR_3 . METHOD_2 ( ) ) ; if ( VAR_2 . METHOD_3 ( VAR_1 ) ) { throw new IllegalStateException ( STRING_1 + VAR_3 . METHOD_2 ( ) + STRING_2 + STRING_3 + VAR_1 ) ; } VAR_2 . addAll ( VAR_1 ) ; VAR_3 . METHOD_4 ( VAR_2 ) ;... |
unneeded newline | private void METHOD_1 ( TYPE_1 VAR_1 , Set < String > VAR_2 ) throws InterruptedException { for ( String VAR_3 : VAR_2 ) { TYPE_2 . METHOD_2 ( ( ) - > METHOD_3 ( VAR_1 , VAR_3 , VAR_4 ) , STRING_1 + VAR_3 + STRING_2 ) ; } <START> <END> } | private void METHOD_1 ( TYPE_1 VAR_1 , Set < String > VAR_2 ) throws InterruptedException { for ( String VAR_3 : VAR_2 ) { TYPE_2 . METHOD_2 ( ( ) - > METHOD_3 ( VAR_1 , VAR_3 ) , STRING_1 + VAR_3 + STRING_2 ) ; } } |
assuming VAR_1 - empty | void METHOD_1 ( Collection < TYPE_1 > VAR_1 ) { METHOD_2 ( ) ; if ( ! VAR_2 . isEmpty ( ) ) { METHOD_3 ( ) ; } for ( TYPE_1 VAR_3 : VAR_1 ) { VAR_2 . put ( VAR_3 . METHOD_4 ( ) . name ( ) , VAR_3 ) ; <START> } <END> METHOD_5 ( ) ; } | void METHOD_1 ( Collection < TYPE_1 > VAR_1 ) { METHOD_2 ( ) ; if ( VAR_1 . isEmpty ( ) ) { return ; } if ( ! VAR_2 . isEmpty ( ) ) { METHOD_3 ( ) ; } for ( TYPE_1 VAR_3 : VAR_1 ) { VAR_2 . put ( VAR_3 . METHOD_4 ( ) . name ( ) , VAR_3 ) ; } METHOD_5 ( ) ; } |
making protected instead mock a - class ? _CODE_ part public API want public ( a public API change ? ) | <START> public TYPE_3 ( Map < String , TYPE_1 < TYPE_2 > > VAR_2 ) { <END> this . VAR_2 = VAR_2 ; } | protected TYPE_3 ( Map < String , TYPE_1 < TYPE_2 > > VAR_2 ) { this . VAR_2 = VAR_2 ; } |
I don t need delay adding store _CODE_ ( ) | public void METHOD_1 ( ) { this . VAR_1 = VAR_2 ; if ( VAR_3 != null ) { <START> VAR_3 . METHOD_2 ( true ) ; <END> } } | public void METHOD_1 ( ) { this . VAR_1 = VAR_2 ; } |
change generation VAR_2 VAR_1 | private boolean METHOD_1 ( String VAR_1 ) { <START> return VAR_1 != null && ! VAR_1 . equals ( METHOD_2 ( ) . VAR_2 ) ; <END> } | private boolean METHOD_1 ( String VAR_1 ) { return VAR_1 != null && ! VAR_1 . equals ( METHOD_2 ( ) . VAR_1 ) ; } |
s remove brace changes please | private TYPE_1 < TYPE_3 . TYPE_4 > METHOD_1 ( String node ) { TYPE_1 < TYPE_3 . TYPE_4 > VAR_1 = VAR_2 . get ( node ) ; if ( VAR_1 == null || VAR_1 . isEmpty ( ) ) { throw new IllegalStateException ( STRING_1 + node ) ; <START> } <END> return VAR_1 ; } | private TYPE_1 < TYPE_3 . TYPE_4 > METHOD_1 ( String node ) { TYPE_1 < TYPE_3 . TYPE_4 > VAR_1 = VAR_2 . get ( node ) ; if ( VAR_1 == null || VAR_1 . isEmpty ( ) ) throw new IllegalStateException ( STRING_1 + node ) ; return VAR_1 ; } |
ensure testing state machine expected provide a valid VAR_1 similarly | public void METHOD_1 ( ) { METHOD_2 ( true ) ; <START> String VAR_1 = null ; <END> VAR_2 . METHOD_3 ( null , VAR_1 ) ; } | public void METHOD_1 ( ) { METHOD_2 ( true ) ; VAR_2 . METHOD_3 ( null , VAR_1 ) ; } |
wait ? I thought agreed fatal producer ? I a separate branch similar handling GROUP_AUTHORIZATION_FAILED | private boolean METHOD_1 ( TYPE_1 error ) { return error == TYPE_1 . VAR_1 || error == TYPE_1 . VAR_2 || error == TYPE_1 . VAR_3 || error == TYPE_1 . VAR_4 ; <START> } <END> | private boolean METHOD_1 ( TYPE_1 error ) { return error == TYPE_1 . VAR_1 || error == TYPE_1 . VAR_2 || error == TYPE_1 . VAR_3 ; } |
change logic answer true | public boolean hasNext ( ) { <START> if ( this . VAR_1 != null ) { <END> return true ; } if ( ! this . iterator . hasNext ( ) ) { this . iterator = this . VAR_2 . iterator ( ) ; } return this . iterator . hasNext ( ) ; } | public boolean hasNext ( ) { return true ; } |
simply return true ? written adjusting internal state isolate state manipulation places | public boolean hasNext ( ) { <START> if ( this . VAR_1 ) { <END> return true ; } if ( ! this . iterator . hasNext ( ) ) { this . iterator = this . VAR_2 . iterator ( ) ; } return true ; } | public boolean hasNext ( ) { return true ; } |
need constructor | public T next ( ) { <START> final T next = this . VAR_1 ; <END> this . VAR_1 = METHOD_1 ( ) ; return next ; } | public T next ( ) { final T next = VAR_1 ; VAR_1 = METHOD_1 ( ) ; return next ; } |
borderline overkill I m considering avoid copy logic : ( ! VAR_2 isEmpty ( ) ) return VAR_2 ; elsereturn VAR_3 ; basically relying group VAR_3 a superset local VAR_3 defined | synchronized Set < String > METHOD_1 ( ) { <START> Set < String > VAR_1 = new HashSet < > ( VAR_2 ) ; <END> VAR_1 . addAll ( VAR_3 ) ; return VAR_1 ; } | synchronized Set < String > METHOD_1 ( ) { return VAR_2 . isEmpty ( ) ? VAR_3 : VAR_2 ; } |
parens unnecessary | public Iterator < TYPE_1 > iterator ( ) { <START> return ( VAR_1 == null ) ? Collections . VAR_2 ( ) : <END> VAR_1 . iterator ( ) ; } | public Iterator < TYPE_1 > iterator ( ) { return VAR_1 == null ? Collections . VAR_2 ( ) : VAR_1 . iterator ( ) ; } |
want return a clone VAR_1 ? declare fields final update create a new TYPE_1 object I safely return cached object | public TYPE_1 METHOD_1 ( ) { <START> return new TYPE_1 ( VAR_1 ) ; <END> } | public TYPE_1 METHOD_1 ( ) { return VAR_1 ; } |
don t need print stack trace ignore | public void METHOD_1 ( ) { Thread VAR_1 = TYPE_1 . METHOD_2 ( VAR_2 , true ) . METHOD_3 ( VAR_3 ) ; try { Assert . assertEquals ( VAR_1 . getName ( ) , VAR_2 ) ; Assert . assertTrue ( VAR_1 . METHOD_4 ( ) ) ; } finally { try { VAR_1 . METHOD_5 ( ) ; } catch ( InterruptedException e ) { <START> e . VAR_4 ( ) ; <END> } }... | public void METHOD_1 ( ) { Thread VAR_1 = TYPE_1 . METHOD_2 ( VAR_2 , true ) . METHOD_3 ( VAR_3 ) ; try { assertEquals ( VAR_2 , VAR_1 . getName ( ) ) ; assertTrue ( VAR_1 . METHOD_4 ( ) ) ; } finally { try { VAR_1 . METHOD_5 ( ) ; } catch ( InterruptedException e ) { } } } |
pass false | private TYPE_1 METHOD_1 ( final TYPE_2 VAR_1 , final TYPE_3 VAR_2 , final List < TYPE_4 > VAR_3 , final boolean VAR_4 ) { return new TYPE_1 ( VAR_1 , new TYPE_5 ( ) , VAR_5 , VAR_3 , metadata , VAR_6 , VAR_2 , STRING_1 + VAR_7 , time , VAR_4 , VAR_8 , <START> false , <END> null ) ; } | private TYPE_1 METHOD_1 ( final TYPE_2 VAR_1 , final TYPE_3 VAR_2 , final List < TYPE_4 > VAR_3 , final boolean VAR_4 ) { return new TYPE_1 ( VAR_1 , new TYPE_5 ( ) , VAR_5 , VAR_3 , metadata , VAR_6 , VAR_2 , STRING_1 + VAR_7 , time , VAR_4 , VAR_8 , null ) ; } |
I m wondering care concurrent modification list | public void METHOD_1 ( ) { <START> VAR_1 . clear ( ) ; <END> } | private synchronized void METHOD_1 ( ) { if ( VAR_1 != null ) { VAR_1 . clear ( ) ; } } |
cleaner move METHOD_4 logic a TYPE_1 METHOD_3 method performs METHOD_3 VAR_3 child batches | public void METHOD_1 ( ) throws InterruptedException { try { for ( TYPE_1 VAR_1 : this . VAR_2 . METHOD_2 ( ) ) { VAR_1 . VAR_3 . METHOD_3 ( ) ; <START> METHOD_4 ( VAR_1 ) ; <END> VAR_1 . METHOD_5 ( ) ; } } finally { this . VAR_4 . METHOD_6 ( ) ; } } | public void METHOD_1 ( ) throws InterruptedException { try { for ( TYPE_1 VAR_1 : this . VAR_2 . METHOD_2 ( ) ) { VAR_1 . METHOD_3 ( ) ; } } finally { this . VAR_4 . METHOD_6 ( ) ; } } |
synchronized | private void METHOD_1 ( final TYPE_1 VAR_1 ) { if ( VAR_2 == null ) { VAR_2 = new ArrayList < > ( ) ; } <START> VAR_2 . add ( VAR_1 ) ; <END> } | private synchronized void METHOD_1 ( final TYPE_1 VAR_1 ) { if ( VAR_2 == null ) { VAR_2 = new ArrayList < > ( ) ; } VAR_2 . add ( VAR_1 ) ; } |
java assert statement proper unit testing asserts assertThat ( e getMessage ( ) _CODE_ ( ) ) ; | public void METHOD_1 ( ) { final String VAR_1 = STRING_1 ; final TYPE_1 e = METHOD_2 ( TYPE_1 . class , ( ) - > TYPE_2 . METHOD_3 ( VAR_1 ) ) ; <START> assert e . getMessage ( ) . equals ( STRING_2 + VAR_1 + <END> STRING_3 + STRING_4 ) ; } | public void METHOD_1 ( ) { final String VAR_1 = STRING_1 ; final TYPE_1 e = METHOD_2 ( TYPE_1 . class , ( ) - > TYPE_2 . METHOD_3 ( VAR_1 ) ) ; assertEquals ( e . getMessage ( ) , STRING_2 + VAR_1 + STRING_3 + STRING_4 ) ; } |
req : unnecessary | public void close ( ) { log . debug ( STRING_1 ) ; METHOD_1 ( ) ; if ( VAR_1 ) { try { VAR_2 . close ( ) ; } catch ( final TYPE_1 e ) { throw new TYPE_2 ( STRING_2 , e ) ; } <START> VAR_2 = null ; <END> } METHOD_2 ( ) ; } | public void close ( ) { log . debug ( STRING_1 ) ; METHOD_1 ( ) ; if ( VAR_1 ) { try { VAR_2 . close ( ) ; } catch ( final TYPE_1 e ) { throw new TYPE_2 ( STRING_2 , e ) ; } } METHOD_2 ( ) ; } |
VAR_3 set null constructor I wondering pass null ? ( similar question _CODE_ ) | public TYPE_1 < TYPE_2 < TYPE_3 > , TYPE_4 > METHOD_1 ( final TYPE_5 < TYPE_4 > VAR_1 , final TYPE_6 < ? super TYPE_3 , TYPE_4 > VAR_2 ) { <START> return METHOD_1 ( VAR_1 , VAR_2 , TYPE_7 . METHOD_2 ( VAR_3 , null ) ) ; <END> } | public TYPE_1 < TYPE_2 < TYPE_3 > , TYPE_4 > METHOD_1 ( final TYPE_5 < TYPE_4 > VAR_1 , final TYPE_6 < ? super TYPE_3 , TYPE_4 > VAR_2 ) { return METHOD_1 ( VAR_1 , VAR_2 , TYPE_7 . METHOD_2 ( null , null ) ) ; } |
a public API s change need a TYPE_4 VAR_4 test create a static method _CODE_ change confined test code | public TYPE_4 ( String name , String value , TYPE_1 source , boolean VAR_2 , boolean VAR_3 , <START> List < TYPE_2 > VAR_4 ) { <END> TYPE_3 . METHOD_1 ( name , STRING_1 ) ; this . name = name ; this . value = value ; this . source = source ; this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; this . VAR_4 = VAR_4 ; } | TYPE_4 ( String name , String value , TYPE_1 source , boolean VAR_2 , boolean VAR_3 , List < TYPE_2 > VAR_4 ) { TYPE_3 . METHOD_1 ( name , STRING_1 ) ; this . name = name ; this . value = value ; this . source = source ; this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; this . VAR_4 = VAR_4 ; } |
move VAR_1 line | public < TYPE_1 extends TYPE_2 > TYPE_3 < TYPE_4 , TYPE_5 > METHOD_1 ( final TYPE_6 < TYPE_1 > VAR_1 ) { TYPE_7 . METHOD_2 ( VAR_1 , STRING_1 ) ; <START> return new TYPE_8 < > ( VAR_1 , <END> builder , VAR_2 , name , VAR_3 , null , VAR_4 , VAR_5 , VAR_6 ) ; } | public < TYPE_1 extends TYPE_2 > TYPE_3 < TYPE_4 , TYPE_5 > METHOD_1 ( final TYPE_6 < TYPE_1 > VAR_1 ) { TYPE_7 . METHOD_2 ( VAR_1 , STRING_1 ) ; return new TYPE_8 < > ( VAR_1 , builder , VAR_2 , name , VAR_4 , VAR_5 , VAR_6 ) ; } |
exists check s equal new information wanted register skip METHOD_2 metric + METHOD_3 metric dance | public void METHOD_1 ( final TYPE_1 VAR_1 ) { <START> if ( this . VAR_1 != null ) { <END> VAR_2 . VAR_3 . METHOD_2 ( this . VAR_1 ) ; } this . VAR_1 = VAR_1 ; VAR_2 . VAR_3 . METHOD_3 ( VAR_1 ) ; } | public void METHOD_1 ( final TYPE_1 VAR_1 ) { if ( this . VAR_1 != null ) { if ( this . VAR_1 . equals ( VAR_1 ) ) return ; VAR_2 . VAR_3 . METHOD_2 ( this . VAR_1 ) ; } this . VAR_1 = VAR_1 ; VAR_2 . VAR_3 . METHOD_3 ( VAR_1 ) ; } |
argument _CODE_ apply - - _CODE_ don t write read TYPE_2 happen | private void METHOD_1 ( ) { try { VAR_1 . METHOD_2 ( ) ; } catch ( final TYPE_1 e ) { <START> if ( e . VAR_2 ( ) instanceof TYPE_2 ) { <END> log . warn ( STRING_1 , e ) ; throw new TYPE_3 ( this , e ) ; } } VAR_1 . METHOD_3 ( Collections . VAR_3 ( ) ) ; } | private void METHOD_1 ( ) { VAR_1 . METHOD_2 ( ) ; VAR_1 . METHOD_3 ( Collections . VAR_3 ( ) ) ; } |
a bit awkward a _CODE_ call side effects I understand motivation I guess revisit a subsequent refactoring / follow - PR | boolean METHOD_1 ( ) { <START> if ( VAR_1 . isEmpty ( ) ) { <END> VAR_2 . clear ( ) ; VAR_3 . clear ( ) ; } return ! VAR_1 . isEmpty ( ) ; } | boolean METHOD_1 ( ) { return ! VAR_1 . isEmpty ( ) ; } |
VAR_3 ( ) mandate update ? need call VAR_5 | public void METHOD_1 ( ) { TYPE_1 time = new TYPE_1 ( ) ; TYPE_2 metadata = new TYPE_2 ( VAR_1 , VAR_2 , new TYPE_3 ( ) , new TYPE_4 ( ) ) ; metadata . VAR_3 ( Collections . VAR_4 ( new TYPE_5 ( STRING_1 , INT_1 ) ) ) ; <START> metadata . VAR_5 ( ) ; <END> assertEquals ( 0 , metadata . VAR_6 ( time . VAR_7 ( ) ) ) ; as... | public void METHOD_1 ( ) { TYPE_1 time = new TYPE_1 ( ) ; TYPE_2 metadata = new TYPE_2 ( VAR_1 , VAR_2 , new TYPE_3 ( ) , new TYPE_4 ( ) ) ; metadata . VAR_3 ( Collections . VAR_4 ( new TYPE_5 ( STRING_1 , INT_1 ) ) ) ; assertEquals ( 0 , metadata . VAR_6 ( time . VAR_7 ( ) ) ) ; assertEquals ( 0 , metadata . VAR_8 ( t... |
I missing cases want regular expressions ? need mess predicate functions | public void METHOD_1 ( Map < String , ? > VAR_1 ) { synchronized ( VAR_2 ) { <START> this . VAR_3 = TYPE_1 . METHOD_2 ( VAR_4 , VAR_1 ) ; <END> VAR_5 . forEach ( ( name , VAR_6 ) - > { if ( VAR_3 . METHOD_3 ( name ) ) { METHOD_4 ( VAR_6 ) ; } else { METHOD_5 ( VAR_6 ) ; } } ) ; } } | public void METHOD_1 ( Map < String , ? > VAR_1 ) { synchronized ( VAR_2 ) { this . VAR_3 = TYPE_1 . METHOD_2 ( VAR_1 ) ; VAR_5 . forEach ( ( name , VAR_6 ) - > { if ( VAR_3 . METHOD_3 ( name ) ) { METHOD_4 ( VAR_6 ) ; } else { METHOD_5 ( VAR_6 ) ; } } ) ; } } |
VAR_13 a mock ? I feel state METHOD_3 called returning | public void METHOD_1 ( ) { final String VAR_1 = STRING_1 ; final String VAR_2 = STRING_2 ; final String VAR_3 = STRING_3 ; if ( VAR_4 == TYPE_3 . VAR_6 ) { METHOD_2 ( VAR_1 , VAR_3 , VAR_2 , TYPE_2 . VAR_8 ) ; } else { METHOD_3 ( VAR_9 . METHOD_4 ( VAR_10 , VAR_11 , VAR_12 , VAR_1 , TYPE_2 . VAR_8 <START> ) ) . METHOD_... | public void METHOD_1 ( ) { final String VAR_1 = STRING_1 ; final String VAR_2 = STRING_2 ; final String VAR_3 = STRING_3 ; METHOD_2 ( VAR_1 , VAR_3 , VAR_2 , TYPE_2 . VAR_8 ) ; METHOD_6 ( ( ) - > TYPE_1 . METHOD_7 ( VAR_10 , VAR_11 , VAR_12 , VAR_9 ) ) ; } |
need public ? making private forces method I good | <START> public TYPE_1 ( List < Integer > VAR_2 ) { <END> this . VAR_2 = Collections . VAR_3 ( new ArrayList < > ( VAR_2 ) ) ; } | private TYPE_1 ( List < Integer > VAR_2 ) { this . VAR_2 = Collections . VAR_3 ( new ArrayList < > ( VAR_2 ) ) ; } |
hmm move check _CODE_ s catch block close | public static synchronized void METHOD_1 ( String VAR_1 , String id , TYPE_1 VAR_2 ) { TYPE_2 server = TYPE_3 . METHOD_2 ( ) ; try { <START> id = id == null ? "" : id ; <END> TYPE_4 name = new TYPE_4 ( VAR_1 + STRING_1 + TYPE_5 . METHOD_3 ( id ) ) ; if ( server . VAR_3 ( name ) ) server . VAR_4 ( name ) ; METHOD_4 ( VA... | public static synchronized void METHOD_1 ( String VAR_1 , String id , TYPE_1 VAR_2 ) { TYPE_2 server = TYPE_3 . METHOD_2 ( ) ; try { TYPE_4 name = new TYPE_4 ( VAR_1 + STRING_1 + TYPE_5 . METHOD_3 ( id ) ) ; if ( server . VAR_3 ( name ) ) server . VAR_4 ( name ) ; METHOD_4 ( VAR_2 ) ; } catch ( TYPE_6 e ) { log . warn ... |
I able put VAR_4 TYPE_2 VAR_2 front capture returned put return previous previous null add VAR_4 null add VAR_3 save additional containsKey check | public void add ( TYPE_1 VAR_1 , TYPE_2 data ) { <START> if ( VAR_2 . containsKey ( VAR_1 ) ) { <END> VAR_3 . add ( VAR_1 ) ; } else { VAR_4 . add ( VAR_1 ) ; } next . put ( VAR_1 , data ) ; VAR_2 . put ( VAR_1 , data ) ; } | public void add ( TYPE_1 VAR_1 , TYPE_2 data ) { if ( VAR_2 . put ( VAR_1 , data ) != null ) { VAR_3 . add ( VAR_1 ) ; } else { VAR_4 . add ( VAR_1 ) ; } next . put ( VAR_1 , data ) ; } |
partitions ? assumption _CODE_ VAR_2 ( especially locking ) VAR_3 | public void remove ( TYPE_1 VAR_1 ) { VAR_2 . add ( VAR_1 ) ; <START> next . remove ( VAR_1 ) ; <END> VAR_3 . remove ( VAR_1 ) ; } | public void remove ( TYPE_1 VAR_1 ) { if ( VAR_3 . remove ( VAR_1 ) != null ) { VAR_2 . add ( VAR_1 ) ; } } |
necessary | public TYPE_1 METHOD_1 ( int VAR_1 , Throwable VAR_2 ) { TYPE_2 error = TYPE_2 . METHOD_2 ( VAR_2 ) ; TYPE_3 response = new TYPE_3 ( ) . METHOD_3 ( VAR_1 ) . METHOD_4 ( error . error ( ) . METHOD_5 ( ) ) . METHOD_6 ( error . message ( ) ) <START> . METHOD_7 ( Collections . VAR_3 ( ) ) ; <END> return new TYPE_4 ( respon... | public TYPE_1 METHOD_1 ( int VAR_1 , Throwable VAR_2 ) { TYPE_2 error = TYPE_2 . METHOD_2 ( VAR_2 ) ; TYPE_3 response = new TYPE_3 ( ) . METHOD_3 ( VAR_1 ) . METHOD_4 ( error . error ( ) . METHOD_5 ( ) ) . METHOD_6 ( error . message ( ) ) ; return new TYPE_4 ( response ) ; } |
odd buffer a couple lines METHOD_2 ( ) refer | public int METHOD_1 ( ) { if ( buffer == null ) return size . position ( ) ; <START> return METHOD_2 ( ) . position ( ) + size . position ( ) ; <END> } | public int METHOD_1 ( ) { if ( buffer == null ) return size . position ( ) ; return buffer . position ( ) + size . position ( ) ; } |
put @Override line | <START> @Override public TYPE_1 METHOD_1 ( String VAR_1 , byte [ ] data ) { <END> if ( data != null ) throw new IllegalArgumentException ( STRING_1 ) ; return null ; } | public TYPE_1 METHOD_1 ( String VAR_1 , byte [ ] data ) { if ( data != null ) throw new IllegalArgumentException ( STRING_1 ) ; return null ; } |
default implementation close ( ) wait s reasoning TYPE_1 VAR_3 | public void close ( ) { <START> this . VAR_1 . close ( TYPE_1 . VAR_3 ) ; <END> } | public void close ( ) { this . VAR_1 . close ( ) ; } |
outdated debug statement ? add a similar line METHOD_2 ( ) | private TYPE_1 METHOD_1 ( final TYPE_2 < String , String > VAR_1 ) { return new TYPE_1 ( ) { @Override public void METHOD_2 ( Collection < TYPE_3 > VAR_2 ) { } @Override public void METHOD_3 ( Collection < TYPE_3 > VAR_2 ) { for ( TYPE_3 VAR_3 : VAR_2 ) VAR_1 . METHOD_4 ( VAR_3 , 0 ) ; } @Override public void METHOD_5 ... | private TYPE_1 METHOD_1 ( final TYPE_2 < String , String > VAR_1 ) { return new TYPE_1 ( ) { @Override public void METHOD_2 ( Collection < TYPE_3 > VAR_2 ) { } @Override public void METHOD_3 ( Collection < TYPE_3 > VAR_2 ) { for ( TYPE_3 VAR_3 : VAR_2 ) VAR_1 . METHOD_4 ( VAR_3 , 0 ) ; } } ; } |
wrong unsynchronized access a map more stale inconsistent data null pointer exceptions other issues access synchronization | <START> public TYPE_1 get ( String VAR_1 ) { <END> return VAR_2 . get ( VAR_1 ) ; } | public synchronized TYPE_1 get ( String VAR_1 ) { return VAR_2 . get ( VAR_1 ) ; } |
functions private intention accessed other classes | <START> TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { <END> TYPE_3 entry = VAR_2 . get ( VAR_1 ) ; if ( entry != null && entry . VAR_3 != TYPE_4 . VAR_5 ) return TYPE_1 . of ( entry . VAR_3 ) ; else return TYPE_1 . empty ( ) ; } | private TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { TYPE_3 entry = VAR_2 . get ( VAR_1 ) ; if ( entry != null && entry . VAR_3 != TYPE_4 . VAR_5 ) return TYPE_1 . of ( entry . VAR_3 ) ; else return TYPE_1 . empty ( ) ; } |
simplified : METHOD_2 ( VAR_1 ) && VAR_2 = = VAR_3 ( VAR_1 ) | <START> private boolean METHOD_1 ( TYPE_1 VAR_1 , int VAR_2 ) { <END> if ( this . METHOD_2 ( VAR_1 ) ) { return VAR_2 == this . VAR_3 . get ( VAR_1 ) ; } return false ; } | private boolean METHOD_1 ( TYPE_1 VAR_1 , int VAR_2 ) { return this . METHOD_2 ( VAR_1 ) && VAR_2 == this . VAR_3 . get ( VAR_1 ) ; } |
exception longer thrown | <START> public void METHOD_1 ( ) throws Exception { <END> final long VAR_1 = INT_1 ; TYPE_1 VAR_2 = METHOD_2 ( ) ; METHOD_3 ( VAR_2 ) ; METHOD_4 ( VAR_1 , TYPE_2 . NONE ) ; assertTrue ( VAR_2 . METHOD_5 ( ) ) ; assertEquals ( VAR_1 , VAR_2 . METHOD_6 ( ) . VAR_1 ) ; assertEquals ( ( short ) 0 , VAR_2 . METHOD_6 ( ) . V... | public void METHOD_1 ( ) { final long VAR_1 = INT_1 ; TYPE_1 VAR_2 = METHOD_2 ( ) ; METHOD_3 ( VAR_2 ) ; METHOD_4 ( VAR_1 , TYPE_2 . NONE ) ; assertTrue ( VAR_2 . METHOD_5 ( ) ) ; assertEquals ( VAR_1 , VAR_2 . METHOD_6 ( ) . VAR_1 ) ; assertEquals ( ( short ) 0 , VAR_2 . METHOD_6 ( ) . VAR_4 ) ; } |
doesn t VAR_5 ( VAR_1 ) exist | private int METHOD_1 ( TYPE_1 VAR_1 , int VAR_2 ) { if ( VAR_2 > METHOD_2 ( VAR_1 ) . METHOD_3 ( VAR_3 ) ) { VAR_4 . METHOD_4 ( VAR_1 ) . VAR_5 = VAR_2 ; return VAR_2 ; } <START> return VAR_3 ; <END> } | private int METHOD_1 ( TYPE_1 VAR_1 , int VAR_2 ) { int VAR_5 = METHOD_2 ( VAR_1 ) . METHOD_3 ( VAR_3 ) ; if ( VAR_2 > VAR_5 ) { VAR_4 . METHOD_4 ( VAR_1 ) . VAR_5 = VAR_2 ; return VAR_2 ; } return VAR_5 ; } |
put a variable | private int METHOD_1 ( TYPE_1 VAR_1 , int VAR_2 ) { if ( VAR_2 > METHOD_2 ( VAR_1 ) . METHOD_3 ( VAR_3 ) ) { VAR_4 . METHOD_4 ( VAR_1 ) . VAR_5 = VAR_2 ; return VAR_2 ; } <START> return METHOD_2 ( VAR_1 ) . METHOD_3 ( VAR_3 ) ; <END> } | private int METHOD_1 ( TYPE_1 VAR_1 , int VAR_2 ) { int VAR_5 = METHOD_2 ( VAR_1 ) . METHOD_3 ( VAR_3 ) ; if ( VAR_2 > VAR_5 ) { VAR_4 . METHOD_4 ( VAR_1 ) . VAR_5 = VAR_2 ; return VAR_2 ; } return VAR_5 ; } |
ternary operator easier | int METHOD_1 ( ) { <START> if ( ! VAR_1 ) { <END> return VAR_2 . METHOD_2 ( ) ; } return - 1 ; } | int METHOD_1 ( ) { return VAR_1 ? - 1 : VAR_2 . METHOD_2 ( ) ; } |
long separate tags VAR_4 primary tasks commit I don t metrics messed | int METHOD_1 ( ) { <START> if ( VAR_1 ) { <END> return - 1 ; } final int VAR_2 = VAR_3 . commit ( ) ; return VAR_2 + VAR_4 . commit ( ) ; } | int METHOD_1 ( ) { return VAR_1 ? - 1 : VAR_3 . commit ( ) + VAR_4 . commit ( ) ; } |
s ? finally block | public void METHOD_1 ( ) { final TYPE_1 VAR_1 = new TYPE_1 ( new TYPE_2 ( ) . build ( ) , props , VAR_2 , time ) ; try { VAR_1 . METHOD_2 ( ) ; VAR_1 . start ( ) ; } finally { VAR_1 . close ( ) ; } <START> VAR_1 . METHOD_2 ( ) ; <END> } | public void METHOD_1 ( ) { final TYPE_1 VAR_1 = new TYPE_1 ( new TYPE_2 ( ) . build ( ) , props , VAR_2 , time ) ; try { VAR_1 . METHOD_2 ( ) ; VAR_1 . start ( ) ; } finally { VAR_1 . close ( ) ; VAR_1 . METHOD_2 ( ) ; } } |
return VAR_3 instanceof TYPE_1 ? ( TYPE_1 ) VAR_3 : null ; wdyt ? instanceof closer cast s concise | public TYPE_1 METHOD_1 ( String name ) { if ( ! TYPE_2 . METHOD_2 ( name ) ) { return null ; } TYPE_3 < TYPE_4 < ? > , TYPE_5 > VAR_1 = VAR_2 . get ( name ) ; if ( VAR_1 == null ) { return null ; } TYPE_5 VAR_3 = VAR_1 . get ( VAR_1 . METHOD_3 ( ) ) ; <START> if ( ! ( VAR_3 instanceof TYPE_1 ) ) { <END> return null ; }... | public TYPE_1 METHOD_1 ( String name ) { if ( ! TYPE_2 . METHOD_2 ( name ) ) { return null ; } TYPE_3 < TYPE_4 < ? > , TYPE_5 > VAR_1 = VAR_2 . get ( name ) ; if ( VAR_1 == null ) { return null ; } TYPE_5 VAR_3 = VAR_1 . get ( VAR_1 . METHOD_3 ( ) ) ; return VAR_3 instanceof TYPE_1 ? ( TYPE_1 ) VAR_3 : null ; } |
extend _CODE_ | public TYPE_1 ( ) { <START> super ( STRING_1 + <END> STRING_2 + STRING_3 ) ; } | public TYPE_1 ( ) { super ( ) ; } |
default access constructors result types similarly _CODE_ | <START> public TYPE_4 ( TYPE_1 < Map < TYPE_2 , TYPE_3 > > VAR_2 ) { <END> this . VAR_2 = VAR_2 ; } | TYPE_4 ( TYPE_1 < Map < TYPE_2 , TYPE_3 > > VAR_2 ) { this . VAR_2 = VAR_2 ; } |
method static depend local state _CODE_ | <START> public boolean METHOD_1 ( TYPE_1 error ) { <END> return error == TYPE_1 . VAR_1 || error == TYPE_1 . VAR_2 ; } | public static boolean METHOD_1 ( TYPE_1 error ) { return error == TYPE_1 . VAR_1 || error == TYPE_1 . VAR_2 ; } |
default access | <START> public TYPE_1 ( long offset , long VAR_2 , Optional < Integer > VAR_3 ) { <END> this . offset = offset ; this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; } | TYPE_1 ( long offset , long VAR_2 , Optional < Integer > VAR_3 ) { this . offset = offset ; this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; } |
METHOD_2 ( VAR_1 ( new line ) | public < TYPE_1 , TYPE_2 > TYPE_3 < TYPE_4 , TYPE_2 > METHOD_1 ( final TYPE_3 < TYPE_4 , TYPE_1 > VAR_1 , final TYPE_5 < ? super TYPE_6 , ? super TYPE_1 , ? extends TYPE_2 > VAR_2 , final TYPE_7 VAR_3 , final TYPE_8 < TYPE_4 , TYPE_6 , TYPE_1 > VAR_4 ) { return METHOD_2 ( <START> VAR_1 , <END> VAR_2 , VAR_3 , VAR_4 , n... | public < TYPE_1 , TYPE_2 > TYPE_3 < TYPE_4 , TYPE_2 > METHOD_1 ( final TYPE_3 < TYPE_4 , TYPE_1 > VAR_1 , final TYPE_5 < ? super TYPE_6 , ? super TYPE_1 , ? extends TYPE_2 > VAR_2 , final TYPE_7 VAR_3 , final TYPE_8 < TYPE_4 , TYPE_6 , TYPE_1 > VAR_4 ) { return METHOD_2 ( VAR_1 , VAR_2 , VAR_3 , VAR_4 , new TYPE_9 ( bu... |
synchronized | <START> public void METHOD_1 ( TYPE_1 < TYPE_2 > VAR_1 ) { <END> this . VAR_2 . METHOD_2 ( ) . forEach ( VAR_1 ) ; } | public synchronized void METHOD_1 ( TYPE_1 < TYPE_2 > VAR_1 ) { this . VAR_2 . METHOD_2 ( ) . forEach ( VAR_1 ) ; } |
mentioned offline a behavioral change previously didn t validate offset reset case I offset returned _CODE_ request VAR_6 I simple Optional empty ( ) defining position | private void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 , TYPE_3 VAR_3 ) { TYPE_5 . TYPE_6 position = new TYPE_5 . TYPE_6 ( VAR_3 . offset , VAR_3 . VAR_4 , metadata . VAR_5 ( VAR_1 ) ) ; VAR_3 . VAR_4 . METHOD_2 ( VAR_6 - > metadata . VAR_7 ( VAR_1 , VAR_6 ) ) ; <START> VAR_8 . METHOD_3 ( VAR_1 , position , VAR_2 ) ; <END... | private void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 , TYPE_3 VAR_3 ) { TYPE_5 . TYPE_6 position = new TYPE_5 . TYPE_6 ( VAR_3 . offset , Optional . empty ( ) , metadata . VAR_5 ( VAR_1 ) ) ; VAR_3 . VAR_4 . METHOD_2 ( VAR_6 - > metadata . VAR_7 ( VAR_1 , VAR_6 ) ) ; VAR_8 . METHOD_3 ( VAR_1 , position , VAR_2 ) ; } |
VAR_3 ! = null && VAR_3 < = VAR_2 | private boolean METHOD_1 ( TYPE_1 VAR_1 , long VAR_2 ) { Long VAR_3 = VAR_4 . get ( VAR_1 ) ; boolean result = VAR_3 != null && VAR_3 > VAR_2 ; <START> if ( ! result ) <END> VAR_4 . remove ( VAR_1 ) ; return result ; } | private boolean METHOD_1 ( TYPE_1 VAR_1 , long VAR_2 ) { Long VAR_3 = VAR_4 . get ( VAR_1 ) ; if ( VAR_3 == null ) return false ; if ( VAR_2 >= VAR_3 ) { VAR_4 . remove ( VAR_1 ) ; return false ; } return true ; } |
I inverted | private boolean METHOD_1 ( TYPE_1 VAR_1 , long VAR_2 ) { Long VAR_3 = VAR_4 . get ( VAR_1 ) ; boolean VAR_5 = VAR_3 != null && VAR_2 >= VAR_3 ; if ( VAR_5 ) VAR_4 . remove ( VAR_1 ) ; <START> return VAR_5 ; <END> } | private boolean METHOD_1 ( TYPE_1 VAR_1 , long VAR_2 ) { Long VAR_3 = VAR_4 . get ( VAR_1 ) ; if ( VAR_3 == null ) return false ; if ( VAR_2 >= VAR_3 ) { VAR_4 . remove ( VAR_1 ) ; return false ; } return true ; } |
method static | <START> private TYPE_1 METHOD_1 ( ) { <END> final TYPE_2 properties = new TYPE_2 ( ) ; properties . put ( TYPE_4 . VAR_2 , TYPE_3 . METHOD_2 ( ) ) ; return TYPE_1 . create ( properties ) ; } | private static TYPE_1 METHOD_1 ( ) { final TYPE_2 properties = new TYPE_2 ( ) ; properties . put ( TYPE_4 . VAR_2 , TYPE_3 . METHOD_2 ( ) ) ; return TYPE_1 . create ( properties ) ; } |
null checks a single place METHOD_3 ( ) - - other methods < _CODE_ > t null ( please remove parameter consistency ) | public TYPE_1 < TYPE_2 , TYPE_3 > METHOD_1 ( final TYPE_4 < TYPE_2 , TYPE_3 > VAR_1 ) { <START> TYPE_5 . METHOD_2 ( VAR_1 , STRING_1 ) ; <END> return METHOD_3 ( VAR_1 , null ) ; } | public TYPE_1 < TYPE_2 , TYPE_3 > METHOD_1 ( final TYPE_4 < TYPE_2 , TYPE_3 > VAR_1 ) { return METHOD_3 ( VAR_1 ) ; } |
typo : moreq - > more | public boolean METHOD_1 ( ) { if ( ! VAR_1 . METHOD_2 ( ) ) return false ; if ( VAR_2 != null && ! VAR_2 . METHOD_3 ( VAR_3 ) ) { <START> METHOD_4 ( STRING_1 ) ; <END> return true ; } if ( VAR_4 != null && ! VAR_4 . equals ( VAR_1 . METHOD_5 ( ) ) ) { METHOD_4 ( STRING_2 ) ; return true ; } return super . METHOD_1 ( ) ... | public boolean METHOD_1 ( ) { if ( ! VAR_1 . METHOD_2 ( ) ) return false ; if ( VAR_2 != null && ! VAR_2 . METHOD_3 ( VAR_3 ) ) return true ; if ( VAR_4 != null && ! VAR_4 . equals ( VAR_1 . METHOD_5 ( ) ) ) { return true ; } return super . METHOD_1 ( ) ; } |
motivation change | public void close ( TYPE_1 VAR_1 ) { if ( VAR_1 . METHOD_1 ( ) < 0 ) throw new IllegalArgumentException ( STRING_1 ) ; METHOD_2 ( ) ; try { if ( ! VAR_2 ) { close ( VAR_1 . METHOD_1 ( ) , false ) ; <START> VAR_2 = true ; <END> } } finally { METHOD_3 ( ) ; } } | public void close ( TYPE_1 VAR_1 ) { if ( VAR_1 . METHOD_1 ( ) < 0 ) throw new IllegalArgumentException ( STRING_1 ) ; METHOD_2 ( ) ; try { if ( ! VAR_2 ) { close ( VAR_1 . METHOD_1 ( ) , false ) ; } } finally { VAR_2 = true ; METHOD_3 ( ) ; } } |
line long | private TYPE_1 METHOD_1 ( final String VAR_1 ) { <START> final TYPE_2 < TYPE_3 < String , String > > VAR_2 = TYPE_4 . METHOD_2 ( TYPE_4 . METHOD_3 ( VAR_1 ) , TYPE_5 . String ( ) , TYPE_5 . String ( ) ) ; <END> return VAR_3 . METHOD_4 ( STRING_1 , VAR_4 , VAR_4 , VAR_5 ) . METHOD_5 ( STRING_2 , METHOD_6 ( new TYPE_6 ( ... | private TYPE_1 METHOD_1 ( final String VAR_1 ) { final TYPE_2 < TYPE_3 < String , String > > VAR_2 = TYPE_4 . METHOD_2 ( TYPE_4 . METHOD_3 ( VAR_1 ) , TYPE_5 . String ( ) , TYPE_5 . String ( ) ) ; return VAR_3 . METHOD_4 ( STRING_1 , VAR_4 , VAR_4 , VAR_5 ) . METHOD_5 ( STRING_2 , METHOD_6 ( ( ) - > new TYPE_6 ( VAR_1 ... |
default access good enough consistent _CODE_ | <START> protected TYPE_2 ( int VAR_2 , <END> byte VAR_3 , long offset , long VAR_4 , int VAR_5 , ByteBuffer key , ByteBuffer value , TYPE_1 [ ] VAR_6 ) { this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; this . offset = offset ; this . VAR_4 = VAR_4 ; this . VAR_5 = VAR_5 ; this . key = key ; this . value = value ; this . ... | TYPE_2 ( int VAR_2 , byte VAR_3 , long offset , long VAR_4 , int VAR_5 , ByteBuffer key , ByteBuffer value , TYPE_1 [ ] VAR_6 ) { this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; this . offset = offset ; this . VAR_4 = VAR_4 ; this . VAR_5 = VAR_5 ; this . key = key ; this . value = value ; this . VAR_6 = VAR_6 ; } |
I simplify functions : javaprivate static byte METHOD_1 ( ByteBuffer buffer TYPE_1 input TYPE_2 VAR_1 ) throws IOException { ( buffer VAR_3 ( ) < 1 ) METHOD_2 ( buffer input VAR_1 ) ; return buffer ( ) ; } private static long _CODE_ ( ByteBuffer buffer TYPE_1 input TYPE_2 VAR_1 ) throws IOException { ( buffer VAR_3 ( )... | <START> private static byte METHOD_1 ( ByteBuffer buffer , TYPE_1 input , TYPE_2 VAR_1 ) throws IOException { <END> boolean VAR_2 = false ; while ( true ) { if ( VAR_2 ) { METHOD_2 ( buffer , input , VAR_1 ) ; VAR_2 = false ; } if ( buffer . VAR_3 ( ) < 1 && VAR_1 . value > 0 ) { VAR_2 = true ; } else { return buffer .... | private static byte METHOD_1 ( ByteBuffer buffer , TYPE_1 input , TYPE_2 VAR_1 ) throws IOException { if ( buffer . VAR_3 ( ) < 1 && VAR_1 . value > 0 ) { METHOD_2 ( buffer , input , VAR_1 ) ; } return buffer . get ( ) ; } |
NPE prone check map null need check map simply call : suggestionif ( map ! = null ) { return map ( key ) ; } | public Object METHOD_1 ( Object VAR_1 ) { Map map = METHOD_2 ( 0 ) . METHOD_1 ( VAR_1 , Map . VAR_2 ) ; String key = METHOD_2 ( 1 ) . METHOD_1 ( VAR_1 , String . VAR_2 ) ; <START> if ( map . containsKey ( key ) ) { <END> return map . get ( key ) ; } return null ; } | public Object METHOD_1 ( Object VAR_1 ) { Map map = METHOD_2 ( 0 ) . METHOD_1 ( VAR_1 , Map . VAR_2 ) ; String key = METHOD_2 ( 1 ) . METHOD_1 ( VAR_1 , String . VAR_2 ) ; if ( map != null ) { return map . get ( key ) ; } return null ; } |
I error prone _CODE_ guidance error prone require some configuration ignore autogenerated folders | public boolean METHOD_1 ( int VAR_1 ) { switch ( VAR_1 ) { case TYPE_2 . VAR_3 : return VAR_4 != null ; case TYPE_2 . VAR_5 : return VAR_6 != null && ! VAR_6 . isEmpty ( ) ; case TYPE_2 . VAR_7 : return VAR_8 != null ; case TYPE_2 . VAR_9 : <START> return TYPE_1 == null ? VAR_10 != null : ! Arrays . equals ( TYPE_1 , V... | public boolean METHOD_1 ( int VAR_1 ) { switch ( VAR_1 ) { case TYPE_2 . VAR_3 : return VAR_4 != null ; case TYPE_2 . VAR_5 : return VAR_6 != null && ! VAR_6 . isEmpty ( ) ; case TYPE_2 . VAR_7 : return VAR_8 != null ; case TYPE_2 . VAR_9 : return TYPE_1 == null ? VAR_10 != null : ! TYPE_1 . equals ( VAR_10 ) ; case TY... |
suggestionif ( f = = null || f equals ( TYPE_3 VAR_2 ) ) { | protected TYPE_1 METHOD_1 ( TYPE_2 query ) throws IOException { TYPE_3 f = query . VAR_1 ( ) ; <START> if ( f != null && f . equals ( TYPE_3 . VAR_2 ) ) { <END> try { return new TYPE_1 ( TYPE_4 . METHOD_2 ( VAR_3 . METHOD_3 ( ) . METHOD_4 ( ) , VAR_4 ) ) ; } catch ( TYPE_5 e ) { throw new RuntimeException ( STRING_1 , ... | protected TYPE_1 METHOD_1 ( TYPE_2 query ) throws IOException { TYPE_3 f = query . VAR_1 ( ) ; if ( f == null || f . equals ( TYPE_3 . VAR_2 ) ) { try { return new TYPE_1 ( TYPE_4 . METHOD_2 ( VAR_3 . METHOD_3 ( ) . METHOD_4 ( ) , VAR_4 ) ) ; } catch ( TYPE_5 e ) { throw new RuntimeException ( STRING_1 , e ) ; } } else... |
A question : omitting map isEmpty ( ) check intended ? overrided default method check a null check done | public boolean METHOD_1 ( ) { <START> return VAR_1 != null ; <END> } | public boolean METHOD_1 ( ) { return VAR_1 != null && ! VAR_1 . isEmpty ( ) ; } |
please TYPE_1 INTEGER instead 4 | public void METHOD_1 ( Map < Integer , String > VAR_1 ) { <START> VAR_1 . put ( 4 , STRING_1 ) ; <END> VAR_1 . put ( TYPE_1 . VAR_3 , STRING_2 ) ; VAR_1 . put ( TYPE_1 . VAR_4 , STRING_3 ) ; VAR_1 . put ( TYPE_1 . VAR_5 , STRING_4 ) ; } | public void METHOD_1 ( Map < Integer , String > VAR_1 ) { VAR_1 . put ( TYPE_1 . VAR_3 , STRING_2 ) ; VAR_1 . put ( TYPE_1 . VAR_4 , STRING_3 ) ; VAR_1 . put ( TYPE_1 . VAR_5 , STRING_4 ) ; } |
simpler return : return METHOD_2 ( VAR_5 ) > 0 && METHOD_2 ( VAR_6 ) = = 0 | private boolean METHOD_1 ( double VAR_1 , double VAR_2 , double VAR_3 , double VAR_4 ) { final int VAR_5 = ( int ) ( VAR_2 - VAR_1 ) ; final int VAR_6 = ( int ) ( VAR_4 - VAR_3 ) ; <START> if ( METHOD_2 ( VAR_5 ) == 0 || VAR_6 == 0 ) { <END> return false ; } return true ; } | private boolean METHOD_1 ( double VAR_1 , double VAR_2 , double VAR_3 , double VAR_4 ) { final int VAR_5 = ( int ) ( VAR_2 - VAR_1 ) ; final int VAR_6 = ( int ) ( VAR_4 - VAR_3 ) ; return VAR_5 > 0 && VAR_6 > 0 ; } |
beginning VAR_2 = = null || ! _CODE_ | protected TYPE_1 METHOD_1 ( TYPE_1 VAR_1 , String VAR_2 ) { if ( VAR_2 == null ) { return VAR_1 ; } TYPE_1 result ; if ( VAR_1 == null ) { result = new TYPE_1 ( ) ; } else { result = new TYPE_1 ( VAR_1 ) ; } <START> if ( VAR_3 ) METHOD_2 ( result , VAR_2 ) ; <END> return result ; } | protected TYPE_1 METHOD_1 ( TYPE_1 VAR_1 , String VAR_2 ) { if ( VAR_2 == null || ! VAR_3 ) { return VAR_1 ; } TYPE_1 result ; if ( VAR_1 == null ) { result = new TYPE_1 ( ) ; } else { result = new TYPE_1 ( VAR_1 ) ; } METHOD_2 ( result , VAR_2 ) ; return result ; } |
works a bit weird return Object returning a TYPE_1 ( s VAR_2 tranfsorm method ) a critical issue fix | <START> private Object METHOD_1 ( TYPE_1 VAR_1 ) throws TYPE_2 { <END> return VAR_2 . METHOD_2 ( VAR_1 ) ; } | private TYPE_1 METHOD_1 ( TYPE_1 VAR_1 ) throws TYPE_2 { return VAR_2 . METHOD_2 ( VAR_1 ) ; } |
system outs tests please ( some leftovers ) | public void METHOD_1 ( ) throws IOException { String [ ] VAR_1 = VAR_2 . METHOD_2 ( ) ; for ( String name : VAR_1 ) { <START> System . out . println ( name ) ; <END> System . out . println ( METHOD_3 ( name ) ) ; METHOD_4 ( STRING_1 , name . startsWith ( STRING_2 ) ) ; METHOD_4 ( STRING_3 , name . VAR_3 ( STRING_4 ) ) ... | public void METHOD_1 ( ) throws IOException { String [ ] VAR_1 = VAR_2 . METHOD_2 ( ) ; for ( String name : VAR_1 ) { METHOD_4 ( STRING_1 , name . startsWith ( STRING_2 ) ) ; METHOD_4 ( STRING_3 , name . VAR_3 ( STRING_4 ) ) ; METHOD_4 ( STRING_5 , name . VAR_3 ( STRING_6 ) ) ; } } |
generics new HashMap < > ( ) ; | public Map < String , String > METHOD_1 ( ) { if ( VAR_1 == null ) { <START> VAR_1 = new HashMap ( ) ; <END> VAR_2 . METHOD_2 ( VAR_1 ) ; } return VAR_1 ; } | public Map < String , String > METHOD_1 ( ) { if ( VAR_1 == null ) { VAR_1 = new HashMap < > ( ) ; VAR_2 . METHOD_2 ( VAR_1 ) ; } return VAR_1 ; } |
thanks a clear describe cache condition tend braces single line statements | for ( TYPE_5 factory : TYPE_1 . VAR_3 ( TYPE_5 . VAR_4 ) ) { boolean VAR_5 = factory instanceof TYPE_4 || factory instanceof TYPE_3 || factory instanceof TYPE_2 ; if ( ! VAR_5 ) <START> cache . add ( factory ) ; <END> } | for ( TYPE_5 factory : TYPE_1 . VAR_3 ( TYPE_5 . VAR_4 ) ) { boolean VAR_5 = factory instanceof TYPE_4 || factory instanceof TYPE_3 || factory instanceof TYPE_2 ; if ( ! VAR_5 ) { cache . add ( factory ) ; } } |
formatting } else { I won t repeat occurrences please check diffs changes ( ) respect coding conventions | public void METHOD_1 ( TYPE_1 VAR_1 ) { if ( VAR_1 . METHOD_2 ( ) != null ) { String VAR_2 = VAR_1 . METHOD_2 ( ) ; if ( ! VAR_2 . equals ( STRING_1 ) ) { throw new IllegalStateException ( STRING_2 ) ; } <START> } else { <END> VAR_1 . METHOD_3 ( STRING_1 , false ) ; ; } this . VAR_1 = VAR_1 ; } | public void METHOD_1 ( TYPE_1 VAR_1 ) { if ( VAR_1 . METHOD_2 ( ) != null ) { String VAR_2 = VAR_1 . METHOD_2 ( ) ; if ( ! VAR_2 . equals ( STRING_1 ) ) { throw new IllegalStateException ( STRING_2 ) ; } } else { VAR_1 . METHOD_3 ( STRING_1 , false ) ; } this . VAR_1 = VAR_1 ; } |
bit a nitpick - else : ( VAR_2 ( STRING_1 ) instanceof TYPE_1 ) { return null } else { } a bit clearer | public List < String > METHOD_1 ( ) { String [ ] VAR_1 ; <START> if ( ! ( VAR_2 . get ( STRING_1 ) instanceof TYPE_1 ) ) { <END> VAR_1 = parse . VAR_3 ( String . VAR_4 , VAR_2 , STRING_1 , new String [ ] { STRING_2 , STRING_3 } ) ; return Arrays . asList ( VAR_1 ) ; } else { return null ; } } | public List < String > METHOD_1 ( ) { String [ ] VAR_1 ; if ( VAR_2 . get ( STRING_1 ) instanceof TYPE_1 ) { return null ; } else { VAR_1 = parse . VAR_3 ( String . VAR_4 , VAR_2 , STRING_1 , new String [ ] { STRING_2 , STRING_3 } ) ; return Arrays . asList ( VAR_1 ) ; } } |
tend braces placing a statement a seperate line check developers guide sun - java - conventions + 100 cols | protected TYPE_1 METHOD_1 ( ) { TYPE_1 VAR_1 = TYPE_1 . create ( METHOD_2 ( ) . METHOD_3 ( ) ) ; for ( TYPE_2 VAR_2 : list ) { <START> if ( VAR_2 == null ) <END> continue ; TYPE_1 VAR_3 = TYPE_1 . METHOD_4 ( VAR_2 . METHOD_5 ( ) ) ; if ( VAR_3 == null || VAR_3 . isEmpty ( ) || VAR_3 . METHOD_6 ( ) ) continue ; VAR_1 . ... | protected TYPE_1 METHOD_1 ( ) { TYPE_1 VAR_1 = TYPE_1 . create ( METHOD_2 ( ) . METHOD_3 ( ) ) ; for ( TYPE_2 VAR_2 : list ) { if ( VAR_2 == null ) { continue ; } TYPE_1 VAR_3 = TYPE_1 . METHOD_4 ( VAR_2 . METHOD_5 ( ) ) ; if ( VAR_3 == null || VAR_3 . isEmpty ( ) || VAR_3 . METHOD_6 ( ) ) { continue ; } VAR_1 . METHOD... |
covered need _CODE_ | public void METHOD_1 ( ) { TYPE_1 VAR_1 = VAR_2 . METHOD_2 ( ) ; VAR_1 . METHOD_3 ( VAR_2 . METHOD_4 ( ) ) ; TYPE_2 < Double > VAR_3 = TYPE_2 . create ( FLOAT_1 , FLOAT_2 ) ; TYPE_3 VAR_4 = VAR_5 . METHOD_5 ( null , VAR_1 , VAR_3 ) ; assertNotNull ( VAR_4 ) ; TYPE_4 VAR_6 = ( TYPE_4 ) VAR_4 ; assertEquals ( FLOAT_3 , V... | public void METHOD_1 ( ) { TYPE_1 VAR_1 = VAR_2 . METHOD_2 ( ) ; VAR_1 . METHOD_3 ( VAR_2 . METHOD_4 ( ) ) ; TYPE_2 < Double > VAR_3 = TYPE_2 . create ( FLOAT_1 , FLOAT_2 ) ; TYPE_3 VAR_4 = VAR_5 . METHOD_5 ( null , VAR_1 , VAR_3 ) ; assertNotNull ( VAR_4 ) ; } |
underscore a dash | public TYPE_1 METHOD_1 ( ) { <START> if ( VAR_1 . get ( STRING_1 ) != null ) { <END> return ( TYPE_1 ) VAR_1 . get ( STRING_2 ) ; } else { return FLOAT_1 ; } } | public TYPE_1 METHOD_1 ( ) { if ( VAR_1 . get ( STRING_2 ) != null ) { return ( TYPE_1 ) VAR_1 . get ( STRING_2 ) ; } else { return FLOAT_1 ; } } |
s s confusing TYPE_4 referenced TYPE_1 constant pull request | public void METHOD_1 ( TYPE_1 VAR_1 ) { super . METHOD_1 ( VAR_1 ) ; TYPE_1 VAR_2 = ( TYPE_1 ) VAR_3 . METHOD_2 ( ) ; TYPE_2 < TYPE_3 > VAR_4 = VAR_2 . METHOD_3 ( ) ; METHOD_4 ( VAR_2 . METHOD_5 ( ) , VAR_4 ) ; METHOD_6 ( VAR_2 . METHOD_7 ( ) , VAR_4 ) ; <START> METHOD_8 ( VAR_2 . METHOD_9 ( ) , TYPE_4 . VAR_6 , VAR_4 ... | public void METHOD_1 ( TYPE_1 VAR_1 ) { super . METHOD_1 ( VAR_1 ) ; TYPE_1 VAR_2 = ( TYPE_1 ) VAR_3 . METHOD_2 ( ) ; TYPE_2 < TYPE_3 > VAR_4 = VAR_2 . METHOD_3 ( ) ; METHOD_4 ( VAR_2 . METHOD_5 ( ) , VAR_4 ) ; METHOD_6 ( VAR_2 . METHOD_7 ( ) , VAR_4 ) ; METHOD_8 ( VAR_2 . METHOD_9 ( ) , TYPE_1 . VAR_6 , VAR_4 ) ; VAR_... |
block | private TYPE_1 METHOD_1 ( final String VAR_1 ) throws IOException { METHOD_2 ( VAR_1 ) ; synchronized ( VAR_2 ) { if ( VAR_2 . containsKey ( VAR_1 ) ) { return VAR_2 . get ( VAR_1 ) ; } TYPE_1 source = VAR_3 . METHOD_3 ( new TYPE_2 ( VAR_1 ) , null , TYPE_4 . VAR_5 , null , null ) ; if ( source instanceof TYPE_3 ) { } ... | private TYPE_1 METHOD_1 ( final String VAR_1 ) throws IOException { METHOD_2 ( VAR_1 ) ; synchronized ( VAR_2 ) { if ( VAR_2 . containsKey ( VAR_1 ) ) { return VAR_2 . get ( VAR_1 ) ; } TYPE_1 source = VAR_3 . METHOD_3 ( new TYPE_2 ( VAR_1 ) , null , TYPE_4 . VAR_5 , null , null ) ; VAR_2 . put ( VAR_1 , source ) ; ret... |
VAR_7 variable need simply : return VAR_4 build ( ) ; | private TYPE_1 METHOD_1 ( String VAR_1 , String VAR_2 , String [ ] VAR_3 ) { TYPE_2 VAR_4 = new TYPE_2 ( ) . METHOD_2 ( VAR_1 , VAR_5 ) . METHOD_3 ( VAR_2 ) ; for ( String VAR_6 : VAR_3 ) { VAR_4 . METHOD_4 ( VAR_6 , VAR_5 ) ; } TYPE_1 VAR_7 = VAR_4 . build ( ) ; <START> return VAR_7 ; <END> } | private TYPE_1 METHOD_1 ( String VAR_1 , String VAR_2 , String [ ] VAR_3 ) { TYPE_2 VAR_4 = new TYPE_2 ( ) . METHOD_2 ( VAR_1 , VAR_5 ) . METHOD_3 ( VAR_2 ) ; for ( String VAR_6 : VAR_3 ) { VAR_4 . METHOD_4 ( VAR_6 , VAR_5 ) ; } return VAR_4 . build ( ) ; } |
minor suggestions : please check formatting ( need some whitespaces ) I personally ! hasNext ( ) instead explicit check false ( = = null && ! hasNext ( ) ) { | public TYPE_1 next ( ) throws TYPE_2 { if ( next == null && this . hasNext ( ) == false ) { <START> throw new TYPE_2 ( ) ; <END> } TYPE_1 f = next ; next = null ; return f ; } | public TYPE_1 next ( ) throws TYPE_2 { if ( next == null && ! this . hasNext ( ) ) { throw new TYPE_2 ( ) ; } TYPE_1 f = next ; next = null ; return f ; } |
public ? method else | <START> public static String METHOD_1 ( String path , boolean VAR_1 ) { <END> return VAR_2 != null ? METHOD_2 ( path , VAR_1 ) . METHOD_3 ( ) : null ; } | private static String METHOD_1 ( String path , boolean VAR_1 ) { return VAR_2 != null ? METHOD_2 ( path , VAR_1 ) . METHOD_3 ( ) : null ; } |
static class | <START> private static void METHOD_1 ( int [ ] VAR_1 , int size ) throws IOException { <END> int VAR_2 = 0 ; for ( int VAR_3 : VAR_1 ) { if ( VAR_3 == TYPE_1 . VAR_5 ) { return ; } else if ( VAR_3 == TYPE_1 . VAR_6 ) { throw new IOException ( STRING_1 ) ; } VAR_2 += VAR_3 ; } if ( VAR_2 != size ) { throw new IOExceptio... | static void METHOD_1 ( int [ ] VAR_1 , int size ) throws IOException { int VAR_2 = 0 ; for ( int VAR_3 : VAR_1 ) { if ( VAR_3 == TYPE_1 . VAR_5 ) { return ; } else if ( VAR_3 == TYPE_1 . VAR_6 ) { throw new IOException ( STRING_1 ) ; } VAR_2 += VAR_3 ; } if ( VAR_2 != size ) { throw new IOException ( STRING_1 ) ; } } |
shouldn t call empty constructor ? empty constructor useless code | public TYPE_2 ( TYPE_1 VAR_2 ) { <START> METHOD_1 ( VAR_2 ) ; <END> } | public TYPE_2 ( TYPE_1 VAR_2 ) { this ( ) ; METHOD_1 ( VAR_2 ) ; } |
done a QA run ensure closed writers return hasNext ( ) : false ( thrown IOException ) lets stick consistency ( principle surprise ) | public boolean hasNext ( ) throws IOException { if ( VAR_1 == null ) { <START> throw new IOException ( STRING_1 ) ; <END> } if ( this . VAR_2 ) { return false ; } return iterator . hasNext ( ) ; } | public boolean hasNext ( ) throws IOException { if ( VAR_1 == null ) { return false ; } if ( this . VAR_2 ) { return false ; } return iterator . hasNext ( ) ; } |
add a final ensure set : final TYPE_1 VAR_2 | public StringBuilder METHOD_1 ( Date VAR_1 , StringBuilder output ) { <START> TYPE_1 VAR_2 ; <END> if ( VAR_1 . METHOD_2 ( ) % INT_1 == 0 ) { VAR_2 = new TYPE_2 ( STRING_1 ) ; } else { VAR_2 = new TYPE_2 ( STRING_2 ) ; } VAR_2 . METHOD_3 ( TYPE_3 . METHOD_4 ( STRING_3 ) ) ; String text = VAR_2 . format ( VAR_1 ) ; text... | public StringBuilder METHOD_1 ( Date VAR_1 , StringBuilder output ) { final TYPE_1 VAR_2 ; if ( VAR_1 . METHOD_2 ( ) % INT_1 == 0 ) { VAR_2 = new TYPE_2 ( STRING_1 ) ; } else { VAR_2 = new TYPE_2 ( STRING_2 ) ; } VAR_2 . METHOD_3 ( TYPE_3 . METHOD_4 ( STRING_3 ) ) ; String text = VAR_2 . format ( VAR_1 ) ; text = text ... |
discussions other _CODE_ agreed approach good suppresses kinds system < code > error < / code > s supposed system failures | protected TYPE_1 METHOD_1 ( TYPE_2 < ? , ? > job ) { TYPE_1 VAR_1 = new TYPE_1 ( ) ; for ( TYPE_3 VAR_2 : TYPE_3 . METHOD_2 ( ) ) { try { VAR_2 . METHOD_3 ( job , VAR_1 , TYPE_4 . VAR_4 ) ; <START> } catch ( Throwable t ) { <END> LOGGER . debug ( STRING_1 , VAR_2 . getClass ( ) , t . getMessage ( ) , t ) ; } } return V... | protected TYPE_1 METHOD_1 ( TYPE_2 < ? , ? > job ) { TYPE_1 VAR_1 = new TYPE_1 ( ) ; for ( TYPE_3 VAR_2 : TYPE_3 . METHOD_2 ( ) ) { try { VAR_2 . METHOD_3 ( job , VAR_1 , TYPE_4 . VAR_4 ) ; } catch ( Exception e ) { LOGGER . debug ( STRING_1 , VAR_2 . getClass ( ) , e . getMessage ( ) , e ) ; } } return VAR_1 ; } |
write METHOD_2 ( VAR_1 ) METHOD_3 ( project ) ; ( other places static imports ) | public static TYPE_1 < TYPE_2 > METHOD_1 ( final TYPE_3 < ? , ? > project ) { return new TYPE_1 < TYPE_2 > ( ) { @Override public boolean apply ( TYPE_2 VAR_1 ) { TYPE_4 . METHOD_2 ( VAR_1 ) ; <START> return VAR_1 . METHOD_3 ( project ) ; <END> } } ; } | public static TYPE_1 < TYPE_2 > METHOD_1 ( final TYPE_3 < ? , ? > project ) { return new TYPE_1 < TYPE_2 > ( ) { @Override public boolean apply ( TYPE_2 VAR_1 ) { return METHOD_2 ( VAR_1 ) . METHOD_3 ( project ) ; } } ; } |
a type - check | public void METHOD_1 ( TYPE_1 < ? , ? > job , Collection < TYPE_2 > result ) { <START> TYPE_6 . TYPE_7 p = ( TYPE_6 . TYPE_7 ) job ; <END> for ( TYPE_4 VAR_1 : TYPE_5 . filter ( p . VAR_2 ( ) . values ( ) , TYPE_4 . class ) ) { result . addAll ( VAR_1 . METHOD_2 ( ) ) ; } } | public void METHOD_1 ( TYPE_1 < ? , ? > job , Collection < TYPE_2 > result ) { if ( job instanceof TYPE_6 . TYPE_7 ) { TYPE_6 . TYPE_7 p = ( TYPE_6 . TYPE_7 ) job ; for ( TYPE_4 VAR_1 : TYPE_5 . filter ( p . VAR_2 ( ) . values ( ) , TYPE_4 . class ) ) { result . addAll ( VAR_1 . METHOD_2 ( ) ) ; } } } |
a safety precaution assignment grab line number case generated synthetic lambda method more line numbers | public void METHOD_1 ( int line , TYPE_1 start ) { <START> VAR_1 = line ; <END> } | public void METHOD_1 ( int line , TYPE_1 start ) { if ( VAR_1 == - 1 ) { VAR_1 = line ; } } |
TODO + logger level DEBUG | public void METHOD_1 ( int VAR_1 , String VAR_2 , String name , String VAR_3 , boolean VAR_4 ) { switch ( VAR_1 ) { case TYPE_1 . VAR_6 : case TYPE_1 . VAR_7 : case TYPE_1 . VAR_8 : VAR_9 = name ; VAR_10 = VAR_2 ; VAR_11 = VAR_3 ; VAR_12 = VAR_1 ; break ; default : <START> LOGGER . debug ( STRING_1 ) ; <END> break ; } ... | public void METHOD_1 ( int VAR_1 , String VAR_2 , String name , String VAR_3 , boolean VAR_4 ) { switch ( VAR_1 ) { case TYPE_1 . VAR_6 : case TYPE_1 . VAR_7 : case TYPE_1 . VAR_8 : VAR_9 = name ; VAR_10 = VAR_2 ; VAR_11 = VAR_3 ; VAR_12 = VAR_1 ; break ; default : System . out . println ( STRING_1 ) ; break ; } super ... |
nope I missed | protected TYPE_1 < ? extends T > run ( Context context ) { VAR_1 = System . currentTimeMillis ( ) ; <START> TYPE_2 < T > task = METHOD_1 ( 0 ) ; <END> context . run ( task ) ; return task ; } | private TYPE_1 < ? extends T > run ( Context context ) { VAR_1 = System . currentTimeMillis ( ) ; TYPE_2 < T > task = METHOD_1 ( 0 ) ; context . run ( task ) ; return task ; } |
return promise symmetric start ( ) | <START> public void METHOD_1 ( ) throws InterruptedException { <END> if ( VAR_1 != null ) { VAR_1 . close ( ) ; VAR_2 . METHOD_1 ( ) ; } } | public void METHOD_1 ( ) throws InterruptedException { if ( VAR_1 != null ) { VAR_1 . close ( ) ; } } |
a synchronization step a lines TYPE_1 clarity synchronize operations start method | public void start ( ) { if ( VAR_1 != null ) { VAR_2 = new TYPE_1 ( VAR_1 ) ; } else { if ( VAR_3 == null ) { VAR_3 = METHOD_1 ( ) ; } } METHOD_2 ( ) ; if ( VAR_3 == null || METHOD_3 ( ) ) { VAR_3 = VAR_2 . METHOD_4 ( ) ; <START> synchronized ( VAR_3 ) { <END> for ( Class < ? > VAR_4 : VAR_5 ) { METHOD_5 ( VAR_3 , VAR_... | public void start ( ) { synchronized ( monitor ) { if ( VAR_1 != null ) { VAR_2 = new TYPE_1 ( VAR_1 ) ; } else { if ( VAR_3 == null ) { VAR_3 = METHOD_1 ( ) ; } } METHOD_2 ( ) ; if ( VAR_3 == null || METHOD_3 ( ) ) { VAR_3 = VAR_2 . METHOD_4 ( ) ; for ( Class < ? > VAR_4 : VAR_5 ) { METHOD_5 ( VAR_3 , VAR_4 ) ; } } TY... |
canonical write avoids repetition METHOD_2 a bit error prone String line ; ( ( line = VAR_1 METHOD_2 ( ) ) ! = null ) { println ( VAR_2 + line ) ; } : good ! don t forget indent code properly | private void METHOD_1 ( TYPE_1 event ) { out . println ( ) ; try ( TYPE_2 VAR_1 = new TYPE_2 ( new TYPE_3 ( event . text ) ) ) { String line = VAR_1 . METHOD_2 ( ) ; while ( line != null ) { out . println ( VAR_2 + line ) ; line = VAR_1 . METHOD_2 ( ) ; } <START> } catch ( IOException e ) { <END> throw new TYPE_4 ( e )... | private void METHOD_1 ( TYPE_1 event ) { out . println ( ) ; try ( TYPE_2 VAR_1 = new TYPE_2 ( new TYPE_3 ( event . text ) ) ) { String line ; while ( ( line = VAR_1 . METHOD_2 ( ) ) != null ) { out . println ( VAR_2 + line ) ; } } catch ( IOException e ) { throw new TYPE_4 ( e ) ; } out . println ( ) ; } |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.