Datasets:
YabTad
/
CodeRev

Dataset card Data Studio Files
xet
 Community
ReviewComments
stringlengths
1
2.35k
OriginalCode
stringlengths
28
487
ReviewedCode
stringlengths
14
463
need a reference nodes setup
private String METHOD_1 ( String VAR_1 ) { <START> String [ ] VAR_2 = { STRING_1 , STRING_2 , STRING_3 } ; <END> for ( String VAR_3 : VAR_2 ) { if ( new File ( VAR_3 + VAR_1 ) . exists ( ) ) { return VAR_3 + VAR_1 ; } } return null ; }
private String METHOD_1 ( String VAR_1 ) { String [ ] VAR_2 = { STRING_1 , STRING_2 } ; for ( String VAR_3 : VAR_2 ) { if ( new File ( VAR_3 + VAR_1 ) . exists ( ) ) { return VAR_3 + VAR_1 ; } } return null ; }
logging spammy log
public void METHOD_1 ( TYPE_1 VAR_1 , String path , TYPE_2 VAR_2 ) throws IOException { List < TYPE_3 > VAR_3 = new ArrayList < > ( ) ; for ( TYPE_6 . TYPE_7 . VAR_4 . TYPE_3 entry : VAR_2 . METHOD_2 ( ) ) { TYPE_3 VAR_6 = METHOD_3 ( entry ) ; VAR_3 . add ( VAR_6 ) ; } try { VAR_1 . METHOD_1 ( new Path ( path ) , VAR_3...
public void METHOD_1 ( TYPE_1 VAR_1 , String path , TYPE_2 VAR_2 ) throws IOException { List < TYPE_3 > VAR_3 = new ArrayList < > ( ) ; for ( TYPE_6 . TYPE_7 . VAR_4 . TYPE_3 entry : VAR_2 . METHOD_2 ( ) ) { TYPE_3 VAR_6 = METHOD_3 ( entry ) ; VAR_3 . add ( VAR_6 ) ; } try { VAR_1 . METHOD_1 ( new Path ( path ) , VAR_3...
lets a TAG variable
public void METHOD_1 ( TYPE_1 VAR_1 ) { TYPE_2 VAR_2 = new TYPE_2 ( VAR_1 ) ; METHOD_2 ( VAR_2 ) ; <START> Log . i ( STRING_1 , STRING_2 ) ; <END> }
public void METHOD_1 ( TYPE_1 VAR_1 ) { TYPE_2 VAR_2 = new TYPE_2 ( VAR_1 ) ; METHOD_2 ( VAR_2 ) ; }
- else dont t need increment line ? split line don t include statement line
private int METHOD_1 ( ) { <START> if ( TYPE_1 . METHOD_2 ( VAR_1 ) ) VAR_1 = TYPE_1 . VAR_2 + 1 ; <END> return VAR_1 ++ ; }
int METHOD_1 ( ) { if ( TYPE_1 . METHOD_2 ( VAR_1 ) ) { VAR_1 = TYPE_1 . VAR_2 + 1 ; } return VAR_1 ++ ; }
static import
public void METHOD_1 ( ) throws TYPE_1 { TYPE_2 VAR_1 = METHOD_2 ( ) . message ( of ( STRING_1 ) ) . build ( ) ; TYPE_2 VAR_2 = METHOD_2 ( ) . message ( of ( STRING_2 ) ) . build ( ) ; assertThat ( STRING_3 , VAR_1 . METHOD_3 ( ) . METHOD_4 ( ) , <START> METHOD_5 ( TYPE_3 . is ( VAR_2 . METHOD_3 ( ) . METHOD_4 ( ) ) ) ...
public void METHOD_1 ( ) throws TYPE_1 { TYPE_2 VAR_1 = METHOD_2 ( ) . message ( of ( STRING_1 ) ) . build ( ) ; TYPE_2 VAR_2 = METHOD_2 ( ) . message ( of ( STRING_2 ) ) . build ( ) ; assertThat ( STRING_3 , VAR_1 . METHOD_3 ( ) . METHOD_4 ( ) , METHOD_5 ( is ( VAR_2 . METHOD_3 ( ) . METHOD_4 ( ) ) ) ) ; }
single
private void METHOD_1 ( final TYPE_1 state ) { if ( state != null ) { <START> if ( ! VAR_1 ) { <END> METHOD_2 ( state . VAR_2 ( VAR_3 , false ) ) ; } } }
private void METHOD_1 ( final TYPE_1 state ) { if ( state != null && ! VAR_1 ) { METHOD_2 ( state . VAR_2 ( VAR_3 , false ) ) ; } }
hardcode
public TYPE_1 getParameters ( TYPE_2 VAR_1 , TYPE_3 entity ) { TYPE_4 VAR_2 = METHOD_1 ( VAR_3 , TYPE_4 . class ) . map ( VAR_1 , entity . VAR_4 ( ) ) ; <START> TYPE_5 VAR_5 = new TYPE_5 ( VAR_2 , STRING_1 , "" , false ) ; <END> if ( VAR_1 . METHOD_2 ( ) ) { VAR_5 . METHOD_3 ( VAR_1 . METHOD_4 ( ) ) ; } return VAR_5 ; ...
public TYPE_1 getParameters ( TYPE_2 VAR_1 , TYPE_3 entity ) { TYPE_4 VAR_2 = METHOD_1 ( VAR_3 , TYPE_4 . class ) . map ( VAR_1 , entity . VAR_4 ( ) ) ; TYPE_5 VAR_5 = new TYPE_5 ( VAR_2 , "" , false ) ; if ( VAR_1 . METHOD_2 ( ) ) { VAR_5 . METHOD_3 ( VAR_1 . METHOD_4 ( ) ) ; } return VAR_5 ; }
style - : method static
<START> private boolean METHOD_1 ( String a , String b ) { <END> int VAR_1 = a . VAR_2 ( CHAR_1 ) ; int VAR_3 = b . VAR_2 ( CHAR_1 ) ; return a . substring ( 0 , VAR_1 + 1 ) . equals ( b . substring ( 0 , VAR_3 + 1 ) ) ; }
private static boolean METHOD_1 ( String a , String b ) { int VAR_1 = a . VAR_2 ( CHAR_1 ) ; int VAR_3 = b . VAR_2 ( CHAR_1 ) ; return a . substring ( 0 , VAR_1 + 1 ) . equals ( b . substring ( 0 , VAR_3 + 1 ) ) ; }
need METHOD_1 ? more sense put start method ( remove field init )
public void METHOD_1 ( TYPE_1 context ) throws InterruptedException { super . METHOD_1 ( context ) ; <START> VAR_1 = new TYPE_2 ( ) ; <END> }
public void METHOD_1 ( TYPE_1 context ) throws InterruptedException { super . METHOD_1 ( context ) ; VAR_1 = null ; }
I a fan move _CODE_ initialized
<START> public synchronized void METHOD_1 ( ) { <END> if ( this . VAR_1 == null ) { this . VAR_1 = TYPE_1 . METHOD_2 ( METHOD_3 ( ) , this . VAR_2 ) ; if ( this . VAR_1 == null ) { throw new TYPE_2 ( STRING_1 ) ; } try { METHOD_3 ( ) . METHOD_4 ( this . VAR_1 , true , false ) ; } catch ( Exception e ) { throw new TYPE_...
public void METHOD_1 ( ) { if ( this . VAR_1 == null ) { this . VAR_1 = TYPE_1 . METHOD_2 ( METHOD_3 ( ) , this . VAR_2 ) ; if ( this . VAR_1 == null ) { throw new TYPE_2 ( STRING_1 ) ; } try { METHOD_3 ( ) . METHOD_4 ( this . VAR_1 , true , false ) ; } catch ( Exception e ) { throw new TYPE_2 ( e ) ; } } }
a live test a symptom users build - predicates2 retry construct wait server deleted consider binding guice context reused needed
public void METHOD_1 ( ) throws InterruptedException { METHOD_2 ( ) . METHOD_3 ( VAR_1 . id ( ) ) ; <START> Thread . VAR_2 ( INT_1 ) ; <END> METHOD_4 ( VAR_3 ) ; METHOD_5 ( VAR_3 . id ( ) ) ; }
public void METHOD_1 ( ) throws InterruptedException { METHOD_4 ( VAR_3 ) ; METHOD_2 ( ) . METHOD_3 ( VAR_1 . id ( ) ) ; METHOD_4 ( VAR_3 ) ; METHOD_5 ( VAR_3 . id ( ) ) ; }
improvement
public Object next ( ) { if ( position >= VAR_1 ) { throw new TYPE_1 ( ) ; } Object result = TYPE_2 . get ( VAR_2 , position ) ; position ++ ; <START> return result ; <END> }
public Object next ( ) { if ( position >= VAR_1 ) { throw new TYPE_1 ( ) ; } int offset = position ++ ; return TYPE_2 . get ( VAR_2 , offset ) ; }
assigning 0 VAR_3 assign some line
protected int METHOD_1 ( TYPE_1 VAR_1 ) { METHOD_2 ( INT_1 , TimeUnit . VAR_2 ) ; <START> int VAR_3 = 0 ; <END> try { VAR_3 = VAR_4 . METHOD_3 ( VAR_1 ) . size ( ) ; } catch ( Exception ex ) { VAR_3 = 0 ; } finally { METHOD_4 ( ) ; } return VAR_3 ; }
protected int METHOD_1 ( TYPE_1 VAR_1 ) { METHOD_2 ( INT_1 , TimeUnit . VAR_2 ) ; int VAR_3 ; try { VAR_3 = VAR_4 . METHOD_3 ( VAR_1 ) . size ( ) ; } catch ( Exception ex ) { VAR_3 = 0 ; } finally { METHOD_4 ( ) ; } return VAR_3 ; }
I don t understand testing field empty ? shouldn t removed
public void set ( String field , final String value ) { <START> if ( ! "" . equals ( field ) ) { <END> if ( METHOD_1 ( field ) ) { VAR_1 . put ( field , value ) ; String VAR_2 = METHOD_2 ( field ) ; if ( VAR_2 != null ) { VAR_3 . add ( new TYPE_1 ( VAR_2 ) ) ; } field = VAR_2 ; } if ( field != null ) { values . put ( f...
public void set ( String field , final String value ) { if ( field != null && METHOD_1 ( field ) ) { VAR_1 . put ( field , value ) ; String VAR_2 = METHOD_2 ( field ) ; if ( VAR_2 != null ) { VAR_3 . add ( new TYPE_1 ( VAR_2 ) ) ; } field = VAR_2 ; } if ( field != null && ! "" . equals ( field ) ) { values . put ( fiel...
merge lines METHOD_1 return argument
public TYPE_3 ( String VAR_2 , TYPE_1 VAR_3 ) { TYPE_2 . METHOD_1 ( VAR_2 , STRING_1 ) ; TYPE_2 . METHOD_1 ( VAR_3 , STRING_2 ) ; this . VAR_2 = VAR_2 ; <START> this . VAR_3 = VAR_3 ; <END> }
public TYPE_3 ( String VAR_2 , TYPE_1 VAR_3 ) { this . VAR_2 = TYPE_2 . METHOD_1 ( VAR_2 , STRING_1 ) ; this . VAR_3 = TYPE_2 . METHOD_1 ( VAR_3 , STRING_2 ) ; }
change _CODE_ ( VAR_2 ! = null && VAR_2 METHOD_2 ( ) = = TYPE_3 VAR_6 ) rid VAR_4
public boolean METHOD_1 ( TYPE_1 VAR_1 ) { TYPE_2 VAR_2 = VAR_3 ; boolean VAR_4 = ( VAR_2 != null && VAR_2 . METHOD_2 ( ) != TYPE_3 . VAR_6 ) ; <START> VAR_1 . METHOD_3 ( VAR_7 ) . METHOD_4 ( ! VAR_4 ) ; <END> VAR_1 . METHOD_3 ( VAR_8 ) . METHOD_5 ( VAR_2 != null ) ; return super . METHOD_1 ( VAR_1 ) ; }
public boolean METHOD_1 ( TYPE_1 VAR_1 ) { TYPE_2 VAR_2 = VAR_3 ; VAR_1 . METHOD_3 ( VAR_7 ) . METHOD_4 ( VAR_2 != null && VAR_2 . METHOD_2 ( ) == TYPE_3 . VAR_6 ) ; VAR_1 . METHOD_3 ( VAR_8 ) . METHOD_5 ( VAR_2 != null ) ; return super . METHOD_1 ( VAR_1 ) ; }
strange
public void METHOD_1 ( ) { <START> page . VAR_1 ( VAR_2 , VAR_3 ) ; <END> }
public void METHOD_1 ( ) { page . VAR_1 ( VAR_3 , VAR_2 ) ; }
StringUtils truncate instead
<START> protected static String METHOD_1 ( String VAR_1 , int VAR_2 ) { <END> if ( StringUtils . length ( VAR_1 ) <= VAR_2 ) { return VAR_1 ; } else { return VAR_1 . substring ( 0 , VAR_2 ) ; } }
protected String METHOD_1 ( String VAR_1 , int VAR_2 ) { return StringUtils . substring ( VAR_1 , 0 , VAR_2 ) ; }
style : don t braces single line blocks
private void METHOD_1 ( ) { <START> if ( VAR_1 == null ) { <END> METHOD_2 ( ) ; } }
private void METHOD_1 ( ) { if ( VAR_1 == null ) METHOD_2 ( ) ; }
prefer isEmpty ( ) a size ( ) comparison
private static TYPE_1 METHOD_1 ( TYPE_2 id ) { TYPE_1 VAR_1 = null ; <START> if ( id != null && id . getValue ( ) != null && id . getValue ( ) . size ( ) > 0 ) { <END> VAR_1 = id . getValue ( ) . get ( 0 ) ; } return VAR_1 ; }
private static TYPE_1 METHOD_1 ( TYPE_2 id ) { TYPE_1 VAR_1 = null ; if ( id != null && id . getValue ( ) != null && ! id . getValue ( ) . isEmpty ( ) ) { VAR_1 = id . getValue ( ) . get ( 0 ) ; } return VAR_1 ; }
improved VAR_1 check shows method mixing concerns : map lookup caching I prefer caching done a separate wrapper class ( _CODE_ ) returned _CODE_ _CODE_ called ( instead backing map unmodifiable _CODE_ )
public TYPE_1 METHOD_1 ( ) { if ( this . VAR_1 && this . VAR_2 != null ) { return this . VAR_2 ; } else { String value = METHOD_2 ( VAR_3 ) ; TYPE_1 VAR_4 = ( StringUtils . VAR_5 ( value ) ? TYPE_1 . METHOD_3 ( value ) : null ) ; if ( this . VAR_1 ) { this . VAR_2 = VAR_4 ; } return VAR_4 ; <START> } <END> }
public TYPE_1 METHOD_1 ( ) { String value = METHOD_2 ( VAR_3 ) ; return ( StringUtils . VAR_5 ( value ) ? TYPE_1 . METHOD_3 ( value ) : null ) ; }
change List
protected String [ ] METHOD_1 ( ) { <START> ArrayList < String > <END> list = new ArrayList < > ( ) ; for ( TYPE_1 VAR_1 : TYPE_2 . getInstance ( ) . METHOD_2 ( ) ) { list . add ( VAR_1 . getName ( ) ) ; } return list . VAR_2 ( new String [ 0 ] ) ; }
protected String [ ] METHOD_1 ( ) { List < String > list = new ArrayList < > ( ) ; for ( TYPE_1 VAR_1 : TYPE_2 . getInstance ( ) . METHOD_2 ( ) ) { list . add ( VAR_1 . getName ( ) ) ; } return list . VAR_2 ( new String [ 0 ] ) ; }
simplified VAR_2 ! = null && VAR_2 METHOD_1 ( ) METHOD_2 ( ) METHOD_3 ( )
public TYPE_3 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 , String VAR_4 ) { this . VAR_2 = VAR_2 ; <START> this . VAR_5 = VAR_2 != null ? VAR_2 . METHOD_1 ( ) . METHOD_2 ( ) . METHOD_3 ( ) : false ; <END> this . VAR_3 = VAR_3 ; this . VAR_4 = VAR_4 ; }
public TYPE_3 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 , String VAR_4 ) { this . VAR_2 = VAR_2 ; this . VAR_5 = VAR_2 != null && VAR_2 . METHOD_1 ( ) . METHOD_2 ( ) . METHOD_3 ( ) ; this . VAR_3 = VAR_3 ; this . VAR_4 = VAR_4 ; }
I don t putting a synchronized block line fire doesn t need a global lock type stuff I find production environments
public static TYPE_1 METHOD_1 ( ) { <START> synchronized ( VAR_1 ) { <END> if ( VAR_2 == null ) { TYPE_1 c = TYPE_2 . getInstance ( ) . METHOD_2 ( ) . METHOD_3 ( ) ; if ( c != null ) { VAR_2 = c ; } else { VAR_2 = new TYPE_3 ( ) ; } } return VAR_2 ; } }
public static TYPE_1 METHOD_1 ( ) { TYPE_1 s = VAR_2 ; if ( s != null ) { return s ; } synchronized ( VAR_1 ) { if ( VAR_2 == null ) { TYPE_1 c = TYPE_2 . getInstance ( ) . METHOD_2 ( ) . METHOD_3 ( ) ; if ( c != null ) { VAR_2 = c ; } else { VAR_2 = new TYPE_3 ( ) ; } } return VAR_2 ; } }
missing return
public TYPE_1 METHOD_1 ( String VAR_1 , Collection < TYPE_2 > VAR_2 ) { <START> METHOD_1 ( VAR_1 , <END> VAR_2 , METHOD_2 ( ) , METHOD_2 ( ) , null , null ) ; }
public TYPE_1 METHOD_1 ( String VAR_1 , Collection < TYPE_2 > VAR_2 ) { return METHOD_1 ( VAR_1 , VAR_2 , METHOD_2 ( ) , METHOD_2 ( ) , null , null ) ; }
point TYPE_2 append stores X amount
public void METHOD_1 ( ) throws TYPE_1 { <START> try { TYPE_2 VAR_1 = new TYPE_2 ( 1 ) ; VAR_1 . add ( INT_1 ) ; VAR_1 . add ( INT_2 ) ; } catch ( TYPE_1 e ) { METHOD_2 ( STRING_1 ) ; } <END> }
public void METHOD_1 ( ) throws TYPE_1 { TYPE_2 VAR_1 = new TYPE_2 ( 1 ) ; VAR_1 . add ( INT_1 ) ; VAR_1 . add ( INT_2 ) ; assertEquals ( VAR_1 . get ( 0 ) , INT_2 ) ; }
I don t log message adds
public Double METHOD_1 ( TYPE_1 VAR_1 ) { if ( METHOD_2 ( VAR_1 ) ) { return VAR_2 . get ( VAR_1 ) . get ( TYPE_2 . VAR_4 ) ; } <START> LOG . warn ( STRING_1 , VAR_1 ) ; <END> return null ; }
public Double METHOD_1 ( TYPE_1 VAR_1 ) { if ( METHOD_2 ( VAR_1 ) ) { return VAR_2 . get ( VAR_1 ) . get ( TYPE_2 . VAR_4 ) ; } return null ; }
- resources ? tabs fixed
public static void METHOD_1 ( final TYPE_1 in , final TYPE_2 VAR_1 ) throws IOException { TYPE_3 out = null ; try { out = new TYPE_3 ( VAR_1 . out ( ) ) ; TYPE_4 . METHOD_2 ( in , out ) ; out . VAR_2 ( ) ; } finally { <START> out . close ( ) ; <END> } }
public static void METHOD_1 ( final TYPE_1 in , final TYPE_2 VAR_1 ) throws IOException { try ( TYPE_3 out = new TYPE_3 ( VAR_1 . out ( ) ) ) { TYPE_4 . METHOD_2 ( in , out ) ; out . VAR_2 ( ) ; } }
please dont { 0 } String format instead
private void METHOD_1 ( TYPE_1 vm ) { if ( TYPE_2 . getInstance ( ) . METHOD_2 ( ) . METHOD_3 ( vm . getId ( ) ) . size ( ) > 0 ) { <START> log . VAR_1 ( STRING_1 , vm . getId ( ) ) ; <END> TYPE_3 . getInstance ( ) . METHOD_4 ( TYPE_7 . TYPE_6 , new TYPE_4 ( vm . getId ( ) ) , new TYPE_5 ( METHOD_5 ( ) ) ) ; } }
private void METHOD_1 ( TYPE_1 vm ) { if ( METHOD_2 ( ) . METHOD_3 ( vm . getId ( ) ) . size ( ) > 0 ) { log . VAR_1 ( STRING_1 , vm . getId ( ) ) ; TYPE_3 . getInstance ( ) . METHOD_4 ( TYPE_7 . TYPE_6 , new TYPE_4 ( vm . getId ( ) ) , new TYPE_5 ( METHOD_5 ( ) ) ) ; } }
please Map < ? ? >
public void METHOD_1 ( Object [ ] params ) { if ( params . length != 1 ) { throw new IllegalArgumentException ( STRING_1 ) ; } <START> METHOD_1 ( ( Map < Object , TYPE_1 > ) params [ 0 ] ) ; <END> }
public void METHOD_1 ( Object [ ] params ) { if ( params . length != 1 ) { throw new IllegalArgumentException ( STRING_1 ) ; } METHOD_1 ( ( Map < ? , ? > ) params [ 0 ] ) ; }
super ( ) ; needed
public TYPE_2 ( Class < TYPE_1 > VAR_2 ) { <START> super ( ) ; <END> this . VAR_2 = VAR_2 ; }
public TYPE_2 ( Class < TYPE_1 > VAR_2 ) { this . VAR_2 = VAR_2 ; }
introduction 5 seconds delay a test a lot instead create a new _CODE_ _CODE_ = VAR_1 increment successful session execute change METHOD_3 : _CODE_ ( ( ) _CODE_ = = VAR_1 ) ? test characteristic waiting succeed error happen wdyt
public void METHOD_1 ( ) throws InterruptedException { int VAR_1 = VAR_2 * VAR_3 ; for ( int i = 0 ; i < VAR_1 ; i ++ ) { METHOD_2 ( null , null ) ; } <START> TYPE_1 . METHOD_3 ( 5 ) ; <END> VAR_4 . METHOD_4 ( ) ; Throwable VAR_5 = VAR_6 . get ( ) ; if ( VAR_5 != null ) { METHOD_5 ( STRING_1 , VAR_5 ) ; } }
public void METHOD_1 ( ) throws InterruptedException { int VAR_1 = VAR_2 * VAR_3 ; for ( int i = 0 ; i < VAR_1 ; i ++ ) { METHOD_2 ( null , null ) ; } TYPE_1 . METHOD_3 ( 1 ) ; VAR_4 . METHOD_4 ( ) ; Throwable VAR_5 = VAR_6 . get ( ) ; if ( VAR_5 != null ) { METHOD_5 ( STRING_1 , VAR_5 ) ; } }
assertTrue ( b ) ;
public void METHOD_1 ( ) throws Exception { when ( VAR_1 . getProperty ( STRING_1 , false ) ) . METHOD_2 ( true ) ; boolean b = VAR_2 . METHOD_3 ( ) . METHOD_4 ( ) ; <START> assertTrue ( b == true ) ; <END> }
public void METHOD_1 ( ) throws Exception { when ( VAR_1 . getProperty ( STRING_1 , false ) ) . METHOD_2 ( true ) ; boolean b = VAR_2 . METHOD_3 ( ) . METHOD_4 ( ) ; assertTrue ( b ) ; }
i don t VAR_3 null i miss null checks added dispose method
private TYPE_1 METHOD_1 ( ) { TYPE_1 VAR_1 = Status . VAR_2 ; if ( VAR_3 != null && VAR_3 . METHOD_2 ( ) != null ) { VAR_1 = VAR_3 . METHOD_2 ( ) ; } <START> return VAR_1 ; <END> }
private TYPE_1 METHOD_1 ( ) { TYPE_1 status = Status . VAR_2 ; if ( VAR_3 . METHOD_2 ( ) != null ) { status = VAR_3 . METHOD_2 ( ) ; } return status ; }
put STRING_1 + getName ( ) a local variable avoid repetition
protected void METHOD_1 ( ) { TYPE_1 VAR_1 = TYPE_2 . METHOD_2 ( TYPE_1 . class ) ; if ( VAR_1 != null ) { if ( VAR_2 . VAR_3 == null ) { cache . VAR_4 ( STRING_1 + getName ( ) ) ; <START> VAR_1 . METHOD_3 ( STRING_1 + getName ( ) ) ; <END> } if ( VAR_2 . VAR_5 == null ) { cache . VAR_6 ( STRING_2 + getName ( ) ) ; VAR...
protected void METHOD_1 ( ) { TYPE_1 VAR_1 = TYPE_2 . METHOD_2 ( TYPE_1 . class ) ; if ( VAR_1 != null ) { if ( VAR_2 . VAR_3 == null ) { String VAR_3 = STRING_1 + getName ( ) ; cache . VAR_4 ( VAR_3 ) ; VAR_1 . METHOD_3 ( VAR_3 ) ; } if ( VAR_2 . VAR_5 == null ) { String VAR_5 = STRING_2 + getName ( ) ; cache . VAR_6 ...
reason formatting changes
public void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 , List < String > VAR_3 , TYPE_3 VAR_4 ) { <START> if ( VAR_1 . METHOD_2 ( ) ) { <END> TYPE_4 VAR_5 = METHOD_3 ( VAR_1 ) ; if ( VAR_5 != null ) { VAR_3 . add ( new TYPE_5 ( STRING_1 , VAR_5 . METHOD_4 ( ) ) . METHOD_5 ( ) ) ; } } }
public void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 , List < String > VAR_3 , TYPE_3 VAR_4 ) { if ( ! VAR_1 . METHOD_2 ( ) ) return ; TYPE_4 VAR_5 = METHOD_3 ( VAR_1 ) ; if ( VAR_5 != null ) VAR_3 . add ( new TYPE_5 ( STRING_1 , VAR_5 . METHOD_4 ( ) ) . METHOD_5 ( ) ) ; }
whitespace < = - good enclose blocks / else { }
private static String METHOD_1 ( String VAR_1 ) { <START> if ( VAR_1 . METHOD_2 ( STRING_1 ) <= 0 ) <END> VAR_1 = VAR_1 . METHOD_3 ( ) . trim ( ) ; else VAR_1 = VAR_1 . METHOD_3 ( ) . trim ( ) . substring ( 0 , VAR_1 . METHOD_2 ( STRING_1 ) ) ; return VAR_1 ; }
private static String METHOD_1 ( String VAR_1 ) { if ( VAR_1 . METHOD_2 ( STRING_1 ) <= 0 ) { VAR_1 = VAR_1 . METHOD_3 ( ) . trim ( ) ; } else { VAR_1 = VAR_1 . METHOD_3 ( ) . trim ( ) . substring ( 0 , VAR_1 . METHOD_2 ( STRING_1 ) ) ; } return VAR_1 ; }
private
<START> public String METHOD_1 ( String table , String path ) <END> { return METHOD_2 ( TYPE_1 . builder ( ) . METHOD_3 ( ) . METHOD_4 ( TYPE_2 . create ( String . format ( STRING_1 , METHOD_5 ( table ) , path ) ) ) , Optional . empty ( ) , Optional . empty ( ) ) ; }
private String METHOD_1 ( String table , String path ) { return METHOD_2 ( TYPE_1 . builder ( ) . METHOD_3 ( ) . METHOD_4 ( TYPE_2 . create ( String . format ( STRING_1 , METHOD_5 ( table ) , path ) ) ) , Optional . empty ( ) , Optional . empty ( ) ) ; }
place print I thinking useful print config file ended
<START> public TYPE_1 METHOD_1 ( String VAR_1 ) { <END> try { return METHOD_2 ( VAR_1 ) ; } catch ( TYPE_2 e ) { TYPE_1 config = new TYPE_1 ( METHOD_3 ( ) ) ; config . VAR_2 ( VAR_1 ) ; return config ; } }
public TYPE_1 METHOD_1 ( String VAR_1 ) { return METHOD_1 ( VAR_1 , true ) ; }
variable useless please return / … branches
public String METHOD_1 ( ) { <START> String VAR_1 ; <END> if ( VAR_2 . VAR_3 == null || VAR_2 . VAR_3 . length ( ) == 0 ) VAR_1 = STRING_1 ; else if ( Double . VAR_4 ( METHOD_2 ( ) ) ) VAR_1 = STRING_2 ; else VAR_1 = "" + ( int ) METHOD_2 ( ) ; return VAR_1 ; }
public String METHOD_1 ( ) { final String VAR_1 ; if ( VAR_2 . VAR_3 == null || VAR_2 . VAR_3 . length ( ) == 0 ) { VAR_1 = STRING_1 ; } else if ( Double . VAR_4 ( METHOD_2 ( ) ) ) { VAR_1 = STRING_2 ; } else { VAR_1 = String . valueOf ( ( int ) METHOD_2 ( ) ) ; } return VAR_1 ; }
please { } line clauses
public static boolean METHOD_1 ( ) { TYPE_1 VAR_1 [ ] = TYPE_2 . METHOD_2 ( ) . METHOD_3 ( ) . METHOD_4 ( ) ; TYPE_3 VAR_2 ; for ( int i = 0 ; i < VAR_1 . length ; i ++ ) { if ( VAR_1 [ i ] instanceof TYPE_3 ) { VAR_2 = ( TYPE_3 ) VAR_1 [ i ] ; if ( VAR_2 . METHOD_5 ( ) ) <START> return true ; <END> } } return false ; ...
public static boolean METHOD_1 ( ) { TYPE_1 VAR_1 [ ] = TYPE_2 . METHOD_2 ( ) . METHOD_3 ( ) . METHOD_4 ( ) ; TYPE_3 VAR_2 ; for ( int i = 0 ; i < VAR_1 . length ; i ++ ) { if ( VAR_1 [ i ] instanceof TYPE_3 ) { VAR_2 = ( TYPE_3 ) VAR_1 [ i ] ; if ( VAR_2 . METHOD_5 ( ) ) { return true ; } } } return false ; }
oups bad rebase
private void METHOD_1 ( TYPE_1 VAR_1 , TYPE_4 . TYPE_5 VAR_2 ) { if ( METHOD_2 ( ) && VAR_1 != null && VAR_2 != null ) { if ( VAR_1 . VAR_3 != VAR_2 . VAR_4 ) { TYPE_3 . d ( TAG , VAR_1 . name + STRING_1 + VAR_1 . VAR_3 + STRING_2 + VAR_2 . VAR_4 ) ; METHOD_3 ( VAR_2 , TYPE_6 . VAR_6 ) ; <START> <END> return true ; } i...
private void METHOD_1 ( TYPE_1 VAR_1 , TYPE_4 . TYPE_5 VAR_2 ) { if ( METHOD_2 ( ) && VAR_1 != null && VAR_2 != null ) { if ( VAR_1 . VAR_3 != VAR_2 . VAR_4 ) { TYPE_3 . d ( TAG , VAR_1 . name + STRING_1 + VAR_1 . VAR_3 + STRING_2 + VAR_2 . VAR_4 ) ; METHOD_3 ( VAR_2 , TYPE_6 . VAR_6 ) ; return ; } if ( VAR_7 ) { TYPE_...
_CODE_ info ( Log user + user _CODE_ ( ) ) ;
TYPE_1 METHOD_1 ( TYPE_2 user , TYPE_3 < TYPE_2 > VAR_1 ) { METHOD_2 ( STRING_1 ) ; return new TYPE_4 < TYPE_2 > ( TYPE_7 . VAR_3 , VAR_1 ) { @Override public TYPE_2 run ( ) throws TYPE_5 { <START> TYPE_6 . error ( STRING_2 ) ; <END> METHOD_3 ( user ) ; return user ; } } . start ( ) ; }
TYPE_1 METHOD_1 ( TYPE_2 user , TYPE_3 < TYPE_2 > VAR_1 ) { METHOD_2 ( STRING_1 ) ; return new TYPE_4 < TYPE_2 > ( TYPE_7 . VAR_3 , VAR_1 ) { @Override public TYPE_2 run ( ) throws TYPE_5 { METHOD_3 ( user ) ; return user ; } } . start ( ) ; }
please put @Override annotation line
<START> @Override <END> protected Map < String , Pair < String , String > > METHOD_1 ( ) { final TYPE_1 VAR_1 = METHOD_2 ( ) ; return VAR_2 . stream ( ) . collect ( Collectors . VAR_3 ( VAR_4 - > VAR_4 . getId ( ) . toString ( ) , VAR_4 - > TYPE_2 . METHOD_3 ( TYPE_3 . VAR_6 , VAR_1 ) ) ) ; }
protected Map < String , Pair < String , String > > METHOD_1 ( ) { final TYPE_1 VAR_1 = METHOD_2 ( ) ; return VAR_2 . stream ( ) . collect ( Collectors . VAR_3 ( VAR_4 - > VAR_4 . getId ( ) . toString ( ) , VAR_4 - > TYPE_2 . METHOD_3 ( TYPE_3 . VAR_6 , VAR_1 ) ) ) ; }
imo added s needed message need add disk alias a message vm isn t example messages
protected void METHOD_1 ( ) { METHOD_2 ( TYPE_1 . VAR_2 ) ; METHOD_2 ( TYPE_1 . VAR_3 ) ; if ( METHOD_3 ( ) != null ) { METHOD_2 ( String . format ( STRING_1 , STRING_2 , METHOD_4 ( ) ) ) ; <START> } <END> }
protected void METHOD_1 ( ) { METHOD_2 ( TYPE_1 . VAR_2 ) ; METHOD_2 ( TYPE_1 . VAR_3 ) ; }
final
<START> public < TYPE_1 > TYPE_2 < TYPE_1 > map ( final TYPE_3 < TYPE_4 , TYPE_1 > f ) { <END> return bind ( a - > METHOD_1 ( f . f ( a ) ) ) ; }
public final < TYPE_1 > TYPE_2 < TYPE_1 > map ( final TYPE_3 < TYPE_4 , TYPE_1 > f ) { return bind ( a - > METHOD_1 ( f . f ( a ) ) ) ; }
remove qualifier
protected TYPE_1 METHOD_1 ( TYPE_1 child ) { <START> return new TYPE_2 ( child , this . VAR_1 ) ; <END> }
protected TYPE_1 METHOD_1 ( TYPE_1 child ) { return new TYPE_2 ( child , VAR_1 ) ; }
_CODE_ a copy
public synchronized List < TYPE_1 < ? > > METHOD_1 ( ) { <START> return TYPE_2 . METHOD_2 ( VAR_1 . METHOD_3 ( ) ) ; <END> }
public synchronized List < TYPE_1 < ? > > METHOD_1 ( ) { return VAR_1 . METHOD_3 ( ) ; }
return proper ID - mimic real behavior
private void METHOD_1 ( ) { when ( METHOD_2 ( ) . METHOD_3 ( ) ) . METHOD_4 ( VAR_1 ) ; when ( VAR_1 . get ( VAR_2 ) ) . METHOD_4 ( ( VAR_3 ) ) ; <START> when ( VAR_3 . METHOD_5 ( ) ) . METHOD_4 ( null ) ; <END> }
private void METHOD_1 ( ) { when ( METHOD_2 ( ) . METHOD_3 ( ) ) . METHOD_4 ( VAR_1 ) ; when ( VAR_1 . get ( VAR_2 ) ) . METHOD_4 ( ( VAR_3 ) ) ; }
shouldn t actual < - - > expected replaced
public void METHOD_1 ( ) { METHOD_2 ( TYPE_5 . TYPE_4 ) ; METHOD_3 ( cmd . VAR_3 ( TYPE_5 . TYPE_4 ) ) ; List < String > VAR_4 = cmd . VAR_5 ( ) . METHOD_4 ( ) ; <START> assertEquals ( 2 , VAR_4 . size ( ) ) ; <END> assertEquals ( VAR_4 . get ( 0 ) , TYPE_2 . TYPE_3 . toString ( ) ) ; assertEquals ( VAR_4 . get ( 1 ) ,...
public void METHOD_1 ( ) { METHOD_2 ( TYPE_5 . TYPE_4 ) ; METHOD_3 ( cmd . VAR_3 ( TYPE_5 . TYPE_4 ) ) ; List < String > VAR_4 = cmd . VAR_5 ( ) . METHOD_4 ( ) ; assertEquals ( 2 , VAR_4 . size ( ) ) ; assertEquals ( TYPE_2 . TYPE_3 . toString ( ) , VAR_4 . get ( 0 ) ) ; assertEquals ( String . format ( STRING_1 , TYPE...
replaced VAR_1 isEmpty ( )
public TYPE_1 METHOD_1 ( ) throws TYPE_2 { String VAR_1 = text == null ? "" : text . VAR_2 ( VAR_3 ) ; <START> if ( VAR_1 . equals ( "" ) ) { <END> return null ; } return new TYPE_1 ( VAR_1 , VAR_3 , type ) ; }
public TYPE_1 METHOD_1 ( ) throws TYPE_2 { String VAR_1 = text == null ? "" : text . VAR_2 ( VAR_3 ) ; if ( VAR_1 . isEmpty ( ) ) { return null ; } return new TYPE_1 ( VAR_1 , VAR_3 , type ) ; }
remove package import statements
public List < String > METHOD_1 ( String VAR_1 ) { List < String > VAR_2 = VAR_3 . get ( VAR_1 ) ; if ( VAR_2 == null ) { VAR_2 = new ArrayList < String > ( 0 ) ; } <START> return new TYPE_2 . TYPE_3 . ArrayList < String > ( VAR_2 ) ; <END> }
public List < String > METHOD_1 ( String VAR_1 ) { List < String > VAR_2 = VAR_3 . get ( VAR_1 ) ; if ( VAR_2 == null ) { VAR_2 = new ArrayList < String > ( 0 ) ; } return new ArrayList < String > ( VAR_2 ) ; }
please leave - s intentionally referencing deprecated version
public TYPE_1 METHOD_1 ( ) { <START> return VAR_1 . METHOD_2 ( ) ; <END> }
public TYPE_1 METHOD_1 ( ) { return VAR_1 . METHOD_1 ( ) ; }
style : braces single line blocks
public Object execute ( TYPE_1 event ) throws TYPE_2 { TYPE_3 VAR_1 = METHOD_1 ( event ) ; <START> if ( VAR_1 == null ) { <END> return null ; } TYPE_4 VAR_2 = new TYPE_4 ( VAR_1 ) ; TYPE_5 VAR_3 = new TYPE_5 ( TYPE_6 . METHOD_2 ( event ) , VAR_2 ) ; VAR_3 . METHOD_3 ( false ) ; VAR_3 . METHOD_4 ( ) ; return null ; }
public Object execute ( TYPE_1 event ) throws TYPE_2 { TYPE_3 VAR_1 = METHOD_1 ( event ) ; if ( VAR_1 == null ) return null ; TYPE_4 VAR_2 = new TYPE_4 ( VAR_1 ) ; TYPE_5 VAR_3 = new TYPE_5 ( TYPE_6 . METHOD_2 ( event ) , VAR_2 ) ; VAR_3 . METHOD_3 ( false ) ; VAR_3 . METHOD_4 ( ) ; return null ; }
I remove VAR_3 field
public TYPE_5 ( TYPE_1 buf ) { VAR_2 = TYPE_2 . METHOD_1 ( buf , TYPE_3 . class ) ; <START> VAR_3 = null ; <END> data = TYPE_2 . METHOD_1 ( buf , TYPE_4 . class ) ; }
public TYPE_5 ( TYPE_1 buf ) { VAR_2 = TYPE_2 . METHOD_1 ( buf , TYPE_3 . class ) ; data = TYPE_2 . METHOD_1 ( buf , TYPE_4 . class ) ; }
need METHOD_2 ( ) methods ? concrete tests a reference obtained stats instance means time operations return stats instance updated
protected void METHOD_1 ( ) { METHOD_2 ( ( ) - > { <START> long VAR_1 = VAR_2 . METHOD_3 ( ) ; <END> METHOD_4 ( STRING_1 , VAR_3 , VAR_1 ) ; VAR_3 = VAR_1 ; } ) ; }
protected void METHOD_1 ( ) { long VAR_1 = VAR_2 . METHOD_3 ( ) ; METHOD_4 ( STRING_1 , VAR_3 , VAR_1 ) ; VAR_3 = VAR_1 ; }
missing ! operator
public List < TYPE_1 > METHOD_1 ( Guid VAR_1 , TYPE_2 VAR_2 , boolean VAR_3 ) { if ( ! METHOD_2 ( VAR_1 ) ) { throw new TYPE_3 ( TYPE_5 . TYPE_4 ) ; } if ( VAR_3 ) { <START> if ( METHOD_3 ( VAR_1 , VAR_2 ) ) { <END> throw new TYPE_3 ( TYPE_5 . VAR_6 ) ; } } else { METHOD_4 ( VAR_1 , VAR_2 ) ; } return METHOD_5 ( VAR_1 ...
public List < TYPE_1 > METHOD_1 ( Guid VAR_1 , TYPE_2 VAR_2 , boolean VAR_3 ) { if ( ! METHOD_2 ( VAR_1 ) ) { throw new TYPE_3 ( TYPE_5 . TYPE_4 ) ; } if ( VAR_3 ) { if ( ! METHOD_3 ( VAR_1 , VAR_2 ) ) { throw new TYPE_3 ( TYPE_5 . VAR_6 ) ; } } else { METHOD_4 ( VAR_1 , VAR_2 ) ; } return METHOD_5 ( VAR_1 , VAR_2 ) ; ...
I wouldn t VAR_1 forces a TYPE_4 ( TYPE_2 ) constructor class doesn t need I d parameterless constructors _CODE_ _CODE_ ( ) _CODE_ ( ) TYPE_5 _CODE_ ( ) instead
private static TYPE_1 METHOD_1 ( ) { TYPE_2 VAR_1 = TYPE_2 . METHOD_2 ( ) ; Assert . VAR_2 ( VAR_1 ) ; if ( TYPE_3 . METHOD_3 ( ) . METHOD_4 ( ) . METHOD_5 ( TYPE_6 . VAR_4 ) ) { return new TYPE_4 ( VAR_1 ) ; } <START> return new TYPE_5 ( VAR_1 ) ; <END> }
private static TYPE_1 METHOD_1 ( ) { if ( TYPE_3 . METHOD_3 ( ) . METHOD_4 ( ) . METHOD_5 ( TYPE_6 . VAR_4 ) ) { return new TYPE_4 ( ) ; } return new TYPE_5 ( ) ; }
synchronized block part - catch block ? shouldn t catch part run synchronized block
public long METHOD_1 ( ) { long VAR_1 = - 1 ; try { synchronized ( this ) { VAR_1 = VAR_2 / VAR_3 ; <START> } <END> } catch ( Exception e ) { if ( VAR_3 == 0 && VAR_2 == 0 ) { VAR_1 = 0 ; } } return VAR_1 ; }
public long METHOD_1 ( ) { long VAR_1 = - 1 ; synchronized ( this ) { try { VAR_1 = VAR_2 / VAR_3 ; } catch ( Exception e ) { if ( VAR_3 == 0 && VAR_2 == 0 ) { VAR_1 = 0 ; } } } return VAR_1 ; }
technically need null - check ftrace other fields test fails line exploded method called null
public void METHOD_1 ( ) { <START> VAR_1 . METHOD_2 ( ) ; <END> VAR_2 . METHOD_2 ( ) ; VAR_2 = null ; VAR_3 . METHOD_2 ( ) ; VAR_4 = null ; }
public void METHOD_1 ( ) { if ( VAR_1 != null ) { VAR_1 . METHOD_2 ( ) ; VAR_1 = null ; } if ( VAR_2 != null ) { VAR_2 . METHOD_2 ( ) ; VAR_2 = null ; } if ( VAR_3 != null ) { VAR_3 . METHOD_2 ( ) ; VAR_3 = null ; } }
call append ( VAR_1 METHOD_3 ( ) ) build ( ) ;
public int METHOD_1 ( ) { <START> return TYPE_1 . METHOD_2 ( VAR_1 . METHOD_3 ( ) ) ; <END> }
public int METHOD_1 ( ) { return new TYPE_1 ( ) . append ( VAR_1 . METHOD_3 ( ) ) . build ( ) ; }
annotate nullable
public static byte [ ] METHOD_1 ( final String string ) { if ( string == null ) { <START> return null ; <END> } try { return string . VAR_1 ( VAR_2 ) ; } catch ( TYPE_1 e ) { throw TYPE_2 . METHOD_2 ( e ) ; } }
public static byte [ ] METHOD_1 ( final String string ) { try { return string . VAR_1 ( VAR_2 ) ; } catch ( TYPE_1 e ) { throw TYPE_2 . METHOD_2 ( e ) ; } }
I don t need condition TYPE_3 METHOD_3 return emptylist key isn t set fine
private void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 entity ) { <START> if ( VAR_1 . METHOD_2 ( VAR_2 ) ) { <END> List < TYPE_1 > VAR_3 = TYPE_3 . METHOD_3 ( VAR_1 , VAR_2 ) ; entity . VAR_4 ( TYPE_4 . METHOD_4 ( VAR_3 , new TYPE_5 < TYPE_1 , TYPE_6 > ( ) { @Override public TYPE_6 apply ( TYPE_1 input ) { return VAR_5 . METHO...
private void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 entity ) { List < TYPE_1 > VAR_3 = TYPE_3 . METHOD_3 ( VAR_1 , VAR_2 ) ; entity . VAR_4 ( TYPE_4 . METHOD_4 ( VAR_3 , new TYPE_5 < TYPE_1 , TYPE_6 > ( ) { @Override public TYPE_6 apply ( TYPE_1 input ) { return VAR_5 . METHOD_5 ( input , new TYPE_6 ( ) ) ; } } ) ) ; }
a chance a NPE ? METHOD_2 ( ) null
public String METHOD_1 ( Object element ) { if ( element instanceof String ) { return ( String ) element ; } if ( element instanceof TYPE_1 ) { <START> return ( ( TYPE_1 ) element ) . METHOD_2 ( ) . getName ( ) ; <END> } return null ; }
public String METHOD_1 ( Object element ) { if ( element instanceof String ) { return ( String ) element ; } if ( element instanceof TYPE_1 ) { final File file = ( ( TYPE_1 ) element ) . METHOD_2 ( ) ; if ( file != null ) { return file . getName ( ) ; } } return null ; }
needs a concurrent hashmap
public TYPE_5 ( ) { this . VAR_2 = TYPE_1 . METHOD_1 ( TYPE_4 < String , TYPE_2 > create ( ) ) ; <START> this . VAR_4 = TYPE_3 . METHOD_2 ( ) ; <END> }
public TYPE_5 ( ) { this . VAR_2 = TYPE_1 . METHOD_1 ( TYPE_4 < String , TYPE_2 > create ( ) ) ; this . VAR_4 = TYPE_1 . METHOD_1 ( TYPE_4 < String , String > create ( ) ) ; }
please final
<START> public void METHOD_1 ( String VAR_1 ) { <END> this . VAR_1 = VAR_1 ; }
public final void METHOD_1 ( String VAR_1 ) { this . VAR_1 = VAR_1 ; }
consider paranoid prefix line length ( ) > 0
static String METHOD_1 ( String line ) { <START> if ( line . VAR_1 ( line . length ( ) - 1 ) == CHAR_1 ) { <END> return line . substring ( 0 , line . length ( ) - 1 ) ; } return line ; }
static String METHOD_1 ( String line ) { if ( line != null && ! line . isEmpty ( ) && line . VAR_1 ( line . length ( ) - 1 ) == CHAR_1 ) { return line . substring ( 0 , line . length ( ) - 1 ) ; } return line ; }
removed throw new TYPE_2 ( ) ; method throw exception anymore suggestionprivate TYPE_1 METHOD_1 ( ) {
<START> private TYPE_1 METHOD_1 ( ) throws TYPE_2 { <END> logger . trace ( STRING_1 ) ; METHOD_2 ( TYPE_3 . METHOD_3 ( STRING_2 ) ) ; final TYPE_1 VAR_1 = TYPE_1 . METHOD_1 ( ) ; if ( ! VAR_1 . METHOD_4 ( ) && ! VAR_1 . METHOD_5 ( ) && ! VAR_1 . METHOD_6 ( ) ) { logger . warn ( STRING_3 , VAR_1 ) ; } logger . debug ( S...
private TYPE_1 METHOD_1 ( ) { logger . trace ( STRING_1 ) ; METHOD_2 ( TYPE_3 . METHOD_3 ( STRING_2 ) ) ; final TYPE_1 VAR_1 = TYPE_1 . METHOD_1 ( ) ; if ( ! VAR_1 . METHOD_4 ( ) && ! VAR_1 . METHOD_5 ( ) && ! VAR_1 . METHOD_6 ( ) ) { logger . warn ( STRING_3 , VAR_1 ) ; } logger . debug ( STRING_4 , VAR_1 ) ; return V...
package - private
<START> public TYPE_3 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 ) <END> { super ( VAR_2 , VAR_3 ) ; }
TYPE_3 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 ) { super ( VAR_2 , VAR_3 ) ; }
I atomic operation
public void close ( ) throws IOException { <START> this . VAR_1 = true ; <END> for ( final TYPE_1 listener : this . VAR_2 ) { try { listener . VAR_3 ( this ) ; } catch ( Throwable t ) { logger . debug ( STRING_1 + this , t ) ; } } this . VAR_4 . METHOD_1 ( ) ; }
public synchronized void close ( ) throws IOException { if ( VAR_1 ) { return ; } this . VAR_1 = true ; for ( final TYPE_1 listener : this . VAR_2 ) { try { listener . VAR_3 ( this ) ; } catch ( Throwable t ) { logger . debug ( STRING_1 + this , t ) ; } } this . VAR_4 . METHOD_1 ( ) ; }
don t catch bare Exception
public void run ( ) { log . info ( STRING_1 ) ; try { VAR_1 . METHOD_1 ( this ) ; VAR_2 = true ; METHOD_2 ( ) ; } catch ( InterruptedException VAR_3 ) { log . info ( STRING_2 ) ; Thread . VAR_4 ( ) . METHOD_3 ( ) ; <START> } catch ( Exception e ) { <END> log . error ( STRING_3 , e . getMessage ( ) , e ) ; } finally { V...
public void run ( ) { log . info ( STRING_1 ) ; try { VAR_1 . METHOD_1 ( this ) ; VAR_2 = true ; METHOD_2 ( ) ; } catch ( InterruptedException VAR_3 ) { log . info ( STRING_2 ) ; Thread . VAR_4 ( ) . METHOD_3 ( ) ; } finally { VAR_2 = false ; VAR_1 . METHOD_4 ( this ) ; } }
I feel a factory approach coming : factory _CODE_ ( type ) abstract renaming nice ( ) btw explicit VAR_1 ! : )
private TYPE_1 METHOD_1 ( ) { TYPE_2 VAR_1 = METHOD_2 ( ) ; <START> TYPE_3 VAR_2 = new TYPE_3 ( ) ; <END> VAR_2 . METHOD_3 ( VAR_1 . METHOD_4 ( METHOD_5 ( ) ) ) ; VAR_2 . METHOD_6 ( VAR_1 . METHOD_4 ( METHOD_7 ( ) ) ) ; VAR_2 . METHOD_8 ( VAR_1 . METHOD_4 ( METHOD_9 ( ) ) ) ; VAR_2 . METHOD_10 ( VAR_1 . METHOD_4 ( METH...
private TYPE_1 METHOD_1 ( ) { TYPE_2 VAR_1 = METHOD_2 ( ) ; return TYPE_3 . METHOD_12 ( VAR_1 . METHOD_4 ( METHOD_5 ( ) ) , VAR_1 . METHOD_4 ( METHOD_7 ( ) ) , VAR_1 . METHOD_4 ( METHOD_9 ( ) ) , VAR_1 . METHOD_4 ( METHOD_11 ( ) ) ) ; }
please < operator > null convention
public static TYPE_1 METHOD_1 ( String VAR_1 , boolean VAR_2 ) { TYPE_1 result = VAR_2 ? null : TYPE_1 . VAR_3 ; try { result = org . VAR_4 . VAR_5 . VAR_6 . TYPE_2 . METHOD_2 ( VAR_1 ) ; <START> if ( null == result && VAR_2 ) { <END> result = TYPE_1 . VAR_3 ; } } catch ( IllegalArgumentException e ) { result = VAR_2 ?...
public static TYPE_1 METHOD_1 ( String VAR_1 , boolean VAR_2 ) { TYPE_1 result = VAR_2 ? null : TYPE_1 . VAR_3 ; try { result = org . VAR_4 . VAR_5 . VAR_6 . TYPE_2 . METHOD_2 ( VAR_1 ) ; if ( result == null && VAR_2 ) { result = TYPE_1 . VAR_3 ; } } catch ( IllegalArgumentException e ) { result = VAR_2 ? TYPE_1 . VAR_...
callers conditioned METHOD_3 ( )
private void METHOD_1 ( final Set < String > VAR_1 , final String VAR_2 ) { final Collection < String > VAR_3 = METHOD_2 ( ) ; <START> if ( METHOD_3 ( ) && ! VAR_3 . equals ( VAR_1 ) ) { <END> VAR_1 . addAll ( VAR_3 ) ; VAR_4 . clear ( ) ; VAR_4 . addAll ( VAR_1 ) ; log . debug ( STRING_1 , VAR_2 , VAR_1 . size ( ) ) ;...
private void METHOD_1 ( final Set < String > VAR_1 , final String VAR_2 ) { final Collection < String > VAR_3 = METHOD_2 ( ) ; if ( ! VAR_3 . equals ( VAR_1 ) ) { VAR_1 . addAll ( VAR_3 ) ; VAR_4 . clear ( ) ; VAR_4 . addAll ( VAR_1 ) ; log . debug ( STRING_1 , VAR_2 , VAR_1 . size ( ) ) ; METHOD_4 ( ) ; METHOD_5 ( ) ;...
a typo ? ( checking VAR_1 ! = null calling method VAR_2 )
public void METHOD_1 ( ) throws Exception { super . METHOD_1 ( ) ; <START> if ( VAR_1 != null ) TYPE_1 . METHOD_2 ( VAR_2 . METHOD_3 ( ) ) ; <END> if ( VAR_3 != null ) TYPE_2 . METHOD_4 ( VAR_3 ) ; }
public void METHOD_1 ( ) throws Exception { super . METHOD_1 ( ) ; if ( VAR_1 != null ) TYPE_1 . METHOD_2 ( VAR_1 . METHOD_3 ( ) ) ; if ( VAR_3 != null ) TYPE_2 . METHOD_4 ( VAR_3 ) ; }
a new array iteration ? avoid _CODE_ multi - thread case a synchronized block more adapted
public void METHOD_1 ( Collection < ? extends TYPE_1 > VAR_1 ) { <START> for ( TYPE_2 listener : TYPE_3 . METHOD_2 ( VAR_2 ) ) { <END> listener . VAR_3 ( ( Collection < TYPE_1 > ) VAR_1 ) ; } }
public void METHOD_1 ( Collection < ? extends TYPE_1 > VAR_1 ) { for ( TYPE_2 listener : VAR_2 ) { listener . VAR_3 ( ( Collection < TYPE_1 > ) VAR_1 ) ; } }
reason return Path ? s new API
<START> public File METHOD_1 ( ) { <END> return this . VAR_1 . METHOD_2 ( ) ; }
public Path METHOD_1 ( ) { return this . VAR_1 ; }
please invert condition additional loop breakers code reading worse
protected void METHOD_1 ( Object VAR_1 ) { for ( int VAR_2 = 0 ; VAR_2 < VAR_3 . length ; VAR_2 ++ ) { Object VAR_4 = VAR_5 . METHOD_2 ( VAR_1 , VAR_3 [ VAR_2 ] ) ; <START> if ( VAR_4 == null ) { <END> continue ; } VAR_6 [ VAR_2 ] . write ( VAR_4 ) ; } }
protected void METHOD_1 ( Object VAR_1 ) { for ( int VAR_2 = 0 ; VAR_2 < VAR_3 . length ; VAR_2 ++ ) { Object VAR_4 = VAR_5 . METHOD_2 ( VAR_1 , VAR_3 [ VAR_2 ] ) ; if ( VAR_4 != null ) { VAR_6 [ VAR_2 ] . write ( VAR_4 ) ; } } }
logic correct stop CHAR_2 / / blah \r blah \r\n
private void METHOD_1 ( boolean VAR_1 ) { int c = METHOD_2 ( ) ; <START> while ( c != CHAR_1 && c != VAR_2 && ( VAR_1 || ( c != CHAR_2 ) ) ) { <END> c = METHOD_2 ( ) ; } if ( c == VAR_2 || ! VAR_1 ) { METHOD_3 ( c ) ; } }
private void METHOD_1 ( boolean VAR_1 ) { int c = METHOD_2 ( ) ; while ( c != CHAR_1 && c != VAR_2 ) { int next = METHOD_2 ( ) ; if ( c == CHAR_2 && next == CHAR_1 && ! VAR_1 ) { METHOD_3 ( next ) ; break ; } c = next ; } if ( c == VAR_2 || ! VAR_1 ) { METHOD_3 ( c ) ; } }
privilege Exception calling bl method need throw privilege Exception
<START> private TYPE_1 METHOD_1 ( final TYPE_2 VAR_1 ) throws TYPE_3 , TYPE_4 , TYPE_5 , TYPE_6 , TYPE_7 , TYPE_8 { <END> final TYPE_9 VAR_2 = METHOD_2 ( ) ; final TYPE_1 VAR_3 = VAR_4 . METHOD_3 ( ) . METHOD_4 ( sess , VAR_1 , VAR_2 ) ; return VAR_3 ; }
private TYPE_1 METHOD_1 ( final TYPE_2 VAR_1 ) throws TYPE_3 , TYPE_4 , TYPE_5 , TYPE_6 , TYPE_7 { final TYPE_9 VAR_2 = METHOD_2 ( ) ; final TYPE_1 VAR_3 = VAR_4 . METHOD_3 ( ) . METHOD_4 ( sess , VAR_1 , VAR_2 ) ; return VAR_3 ; }
missing translation VAR_3 _CODE_ ( VAR_2 - 1 ) ; allocation needs updated match
private TYPE_1 METHOD_1 ( int i , long VAR_1 , long VAR_2 ) { TYPE_1 VAR_3 = TYPE_2 . buffer ( 4 + INT_1 ) ; VAR_3 . METHOD_2 ( VAR_1 ) ; <START> VAR_3 . METHOD_2 ( VAR_2 ) ; <END> VAR_3 . METHOD_3 ( i ) ; return VAR_3 ; }
private TYPE_1 METHOD_1 ( int i , long VAR_1 , long VAR_2 ) { TYPE_1 VAR_3 = TYPE_2 . buffer ( 4 + INT_1 ) ; VAR_3 . METHOD_2 ( VAR_1 ) ; VAR_3 . METHOD_2 ( VAR_2 ) ; VAR_3 . METHOD_2 ( VAR_2 - 1 ) ; VAR_3 . METHOD_3 ( i ) ; return VAR_3 ; }
METHOD_4 ( ) please apply dao calls class
private void METHOD_1 ( Guid VAR_1 ) { TYPE_1 VAR_2 = getParameters ( ) . METHOD_2 ( ) ; TYPE_2 VAR_3 = new TYPE_2 ( VAR_2 . getId ( ) , VAR_1 ) ; VAR_3 . METHOD_3 ( TYPE_6 . TYPE_5 ) ; <START> TYPE_3 . getInstance ( ) . METHOD_4 ( ) . METHOD_5 ( VAR_3 ) ; <END> TYPE_4 . METHOD_6 ( VAR_1 , VAR_2 . getId ( ) ) ; }
private void METHOD_1 ( Guid VAR_1 ) { TYPE_1 VAR_2 = getParameters ( ) . METHOD_2 ( ) ; TYPE_2 VAR_3 = new TYPE_2 ( VAR_2 . getId ( ) , VAR_1 ) ; VAR_3 . METHOD_3 ( TYPE_6 . TYPE_5 ) ; METHOD_4 ( ) . METHOD_5 ( VAR_3 ) ; TYPE_4 . METHOD_6 ( VAR_1 , VAR_2 . getId ( ) ) ; }
version a enum compare = =
public double METHOD_1 ( TYPE_1 node , TYPE_2 version ) { <START> TYPE_3 VAR_1 = ( TYPE_8 . TYPE_9 . equals ( version ) ) <END> ? new TYPE_5 ( ) : new TYPE_6 ( ) ; TYPE_7 VAR_2 = ( TYPE_7 ) node . VAR_3 ( VAR_1 , new TYPE_7 ( 1 ) ) ; return ( double ) VAR_2 . getValue ( ) ; }
public double METHOD_1 ( TYPE_1 node , TYPE_2 version ) { TYPE_3 VAR_1 = ( TYPE_8 . TYPE_9 == version ) ? new TYPE_5 ( ) : new TYPE_6 ( ) ; TYPE_7 VAR_2 = ( TYPE_7 ) node . VAR_3 ( VAR_1 , new TYPE_7 ( 1 ) ) ; return ( double ) VAR_2 . getValue ( ) ; }
druid code convention METHOD_2 ( element - > VAR_3 getValue ( element ) length ( ) * TYPE_1 VAR_2 ) METHOD_3 ( ) ;
public long METHOD_1 ( int [ ] key ) { long VAR_1 = ( key . length * Integer . VAR_2 ) ; VAR_1 += Arrays . stream ( key ) . filter ( element - > VAR_3 . getValue ( element ) != null ) <START> . METHOD_2 ( element - > VAR_3 . getValue ( element ) . length ( ) * TYPE_1 . VAR_2 ) . METHOD_3 ( ) ; <END> return VAR_1 ; }
public long METHOD_1 ( int [ ] key ) { long VAR_1 = key . length * Integer . VAR_2 ; VAR_1 += Arrays . stream ( key ) . filter ( element - > VAR_3 . getValue ( element ) != null ) . METHOD_2 ( element - > VAR_3 . getValue ( element ) . length ( ) * TYPE_1 . VAR_2 ) . METHOD_3 ( ) ; return VAR_1 ; }
nicely done ! consideration : VAR_2 information wrong ( i e actual index size list ) catching throwing a new lose information please change stacktrace message original exception passed : } catch ( TYPE_1 VAR_2 ) { VAR_1 remove ( element ) ; throw VAR_2 ;
public void add ( int index , T element ) { if ( VAR_1 . add ( element ) ) { try { super . add ( index , element ) ; } catch ( TYPE_1 VAR_2 ) { VAR_1 . remove ( element ) ; <START> throw new TYPE_1 ( ) ; <END> } } }
public void add ( int index , T element ) { if ( VAR_1 . add ( element ) ) { try { super . add ( index , element ) ; } catch ( TYPE_1 VAR_2 ) { VAR_1 . remove ( element ) ; throw VAR_2 ; } } }
a VAR_1 null
public String METHOD_1 ( ) { final String VAR_1 = client . VAR_2 ( ) . METHOD_1 ( ) ; <START> if ( VAR_1 == null ) { <END> throw new RuntimeException ( STRING_1 ) ; } return VAR_1 ; }
public String METHOD_1 ( ) { return client . VAR_2 ( ) . METHOD_1 ( ) ; }
redundant else
public TYPE_1 METHOD_1 ( ) { String VAR_1 = METHOD_2 ( ) ; if ( VAR_1 . equals ( VAR_2 ) ) { return null ; <START> } else { <END> return ( TYPE_1 ) VAR_3 . METHOD_3 ( VAR_1 ) ; } }
public TYPE_1 METHOD_1 ( ) { String VAR_1 = METHOD_2 ( ) ; if ( VAR_1 . equals ( VAR_2 ) ) { return null ; } return ( TYPE_1 ) VAR_3 . METHOD_3 ( VAR_1 ) ; }
VAR_1 unused
protected void METHOD_1 ( ) { <START> TYPE_1 VAR_1 = new TYPE_1 ( ) ; <END> VAR_1 . METHOD_2 ( STRING_1 , STRING_2 ) ; VAR_1 . METHOD_2 ( STRING_3 , new TYPE_2 ( STRING_4 ) . format ( new Date ( ) ) ) ; synchronized ( this ) { VAR_2 . METHOD_3 ( VAR_3 , TYPE_3 . builder ( ) . command ( STRING_5 ) . build ( ) ) ; } }
protected void METHOD_1 ( ) { synchronized ( this ) { VAR_2 . METHOD_3 ( VAR_3 , TYPE_3 . builder ( ) . command ( STRING_5 ) . build ( ) ) ; } }
else redundant branch returns conditionally generally prefer write expressions asjavaif ( ) { return ; } return ;
private static String METHOD_1 ( TYPE_1 VAR_1 , String value ) { if ( METHOD_2 ( VAR_1 . getType ( ) ) ) { return String . format ( STRING_1 , VAR_1 . getName ( ) , value ) ; } <START> else { <END> return String . format ( STRING_2 , VAR_1 . getName ( ) , value ) ; } }
private static String METHOD_1 ( TYPE_1 VAR_1 , String value ) { if ( METHOD_2 ( VAR_1 . getType ( ) ) ) { return String . format ( STRING_1 , VAR_1 . getName ( ) , value ) ; } return String . format ( STRING_2 , VAR_1 . getName ( ) , value ) ; }
warning logged setting queue size reading I mind :
int METHOD_1 ( ) { <START> log . warn ( STRING_1 ) ; <END> return VAR_1 . get ( ) ; }
int METHOD_1 ( ) { return VAR_1 . get ( ) ; }
art : personally I lean a guard statement javaif ( entity = = null ) { return null }
public TYPE_1 METHOD_1 ( TYPE_2 entity ) { <START> if ( entity != null ) { <END> Class VAR_1 ; if ( entity . VAR_2 ( ) . equals ( TYPE_5 . TYPE_7 . toString ( ) ) ) { VAR_1 = TYPE_4 . class ; } else { VAR_1 = TYPE_5 . METHOD_2 ( entity . VAR_2 ( ) ) . METHOD_3 ( ) ; } TYPE_6 VAR_3 = TYPE_6 . instance ( ) ; TYPE_1 p = V...
public TYPE_1 METHOD_1 ( TYPE_2 entity ) { if ( entity == null ) { return null ; } Class VAR_1 ; if ( entity . VAR_2 ( ) . equals ( TYPE_5 . TYPE_7 . toString ( ) ) ) { VAR_1 = TYPE_4 . class ; } else { VAR_1 = TYPE_5 . METHOD_2 ( entity . VAR_2 ( ) ) . METHOD_3 ( ) ; } TYPE_6 VAR_3 = TYPE_6 . instance ( ) ; TYPE_1 p =...
move VAR_2 ! = null ( add )
public static List < String > METHOD_1 ( TYPE_1 VAR_1 ) throws Exception { Iterator < String > VAR_2 = VAR_1 . METHOD_2 ( ) ; List < String > VAR_3 = new ArrayList < String > ( ) ; <START> while ( VAR_2 != null && VAR_2 . hasNext ( ) ) { <END> VAR_3 . add ( VAR_2 . next ( ) ) ; } LOG . debug ( STRING_1 , VAR_3 ) ; retu...
public static List < String > METHOD_1 ( TYPE_1 VAR_1 ) throws Exception { Iterator < String > VAR_2 = VAR_1 . METHOD_2 ( ) ; List < String > VAR_3 = new ArrayList < String > ( ) ; if ( VAR_2 != null ) { while ( VAR_2 . hasNext ( ) ) { VAR_3 . add ( VAR_2 . next ( ) ) ; } } LOG . debug ( STRING_1 , VAR_3 ) ; return VAR...
return _CODE_ ? another clause
private ANNOTATION_1 Map < ANNOTATION_2 String , ANNOTATION_2 TYPE_1 > METHOD_1 ( long start , long VAR_1 , TYPE_2 monitor ) { Collection < ANNOTATION_2 TYPE_3 > VAR_2 = METHOD_2 ( start , VAR_1 ) ; if ( VAR_2 == null ) { <START> return null ; <END> } if ( monitor . VAR_3 ( ) ) { return Collections . VAR_4 ; } return M...
private ANNOTATION_1 Map < ANNOTATION_2 String , ANNOTATION_2 TYPE_1 > METHOD_1 ( long start , long VAR_1 , TYPE_2 monitor ) { Collection < ANNOTATION_2 TYPE_3 > VAR_2 = METHOD_2 ( start , VAR_1 ) ; if ( VAR_2 == null || monitor . VAR_3 ( ) ) { return null ; } return METHOD_3 ( VAR_2 , monitor ) ; }
override
<START> protected void METHOD_1 ( StringBuilder builder ) <END> { builder . append ( this . VAR_1 ) ; }
protected void METHOD_1 ( StringBuilder builder ) { builder . append ( this . VAR_1 ) ; super . METHOD_1 ( builder ) ; }
force refreshes
public void METHOD_1 ( ) { start ( ) ; <START> super . METHOD_1 ( true ) ; <END> }
public void METHOD_1 ( ) { start ( ) ; super . METHOD_1 ( ) ; }
else block removed information saved request URL compare
private boolean METHOD_1 ( TYPE_1 request , TYPE_2 VAR_1 ) { if ( VAR_1 == null ) { return false ; <START> } else if ( VAR_1 instanceof TYPE_3 ) { <END> TYPE_3 VAR_2 = ( TYPE_3 ) VAR_1 ; return VAR_2 . METHOD_2 ( request , this . VAR_3 ) ; } else { String VAR_4 = TYPE_4 . METHOD_3 ( request ) ; return VAR_1 . METHOD_4 ...
private boolean METHOD_1 ( TYPE_1 request , TYPE_2 VAR_1 ) { if ( VAR_1 == null ) { return false ; } else { String VAR_4 = TYPE_4 . METHOD_3 ( request ) ; return VAR_1 . METHOD_4 ( ) . equals ( VAR_4 ) ; } }
wouldn t more sense add / remove a style class instead hard coding a background color box ? change default background color application white change I a quick search I t find other disabled color application #E5E5E5 color
public void METHOD_1 ( boolean VAR_1 ) { METHOD_2 ( ) . METHOD_1 ( VAR_1 ) ; <START> if ( VAR_1 ) { <END> METHOD_2 ( ) . METHOD_3 ( ) . METHOD_4 ( ) . METHOD_5 ( STRING_1 ) ; } else { METHOD_2 ( ) . METHOD_3 ( ) . METHOD_4 ( ) . METHOD_5 ( STRING_2 ) ; } }
public void METHOD_1 ( boolean VAR_1 ) { METHOD_2 ( ) . METHOD_1 ( VAR_1 ) ; }
TYPE_2 - delete
public void METHOD_1 ( TYPE_1 VAR_1 ) { if ( VAR_2 != null ) { VAR_1 . METHOD_2 ( ) . METHOD_3 ( VAR_2 ) ; } <START> VAR_2 = new TYPE_2 ( VAR_1 , this ) ; <END> METHOD_4 ( VAR_1 ) ; }
public void METHOD_1 ( TYPE_1 VAR_1 ) { METHOD_4 ( VAR_1 ) ; }
ternary operator drop return intermediate variable
public String toString ( ) { <START> String VAR_1 = ( TYPE_1 < 0 ) ? STRING_1 : "" ; <END> return String . format ( STRING_2 , VAR_1 , TYPE_3 , TYPE_2 , TYPE_6 , TYPE_4 , TYPE_5 ) ; }
public String toString ( ) { return String . format ( STRING_2 , ( TYPE_1 < 0 ) ? STRING_1 : "" , TYPE_3 , TYPE_2 , TYPE_6 , TYPE_4 , TYPE_5 ) ; }
assuming another debugging call
private void METHOD_1 ( final TYPE_1 VAR_1 ) { this . VAR_2 . remove ( VAR_1 ) ; this . VAR_3 . METHOD_2 ( ) ; <START> System . out . println ( STRING_1 + this . VAR_3 . METHOD_3 ( ) ) ; <END> }
private void METHOD_1 ( final TYPE_1 VAR_1 ) { this . VAR_2 . remove ( VAR_1 ) ; this . VAR_3 . METHOD_2 ( ) ; }