ReviewComments
stringlengths
1
2.35k
OriginalCode
stringlengths
28
487
ReviewedCode
stringlengths
14
463
s unsafe store lists ( reference modify list ) d worth making VAR_2 final method a clear ( ) shallow - copy list contents
public void METHOD_1 ( List < TYPE_1 > VAR_1 ) { <START> VAR_2 = VAR_1 ; <END> }
public void METHOD_1 ( List < TYPE_1 > VAR_1 ) { VAR_2 = new ArrayList < TYPE_1 > ( VAR_1 ) ; }
a getInt variant
public static TYPE_1 METHOD_1 ( byte [ ] VAR_1 ) throws TYPE_2 { final TYPE_3 obj = new TYPE_3 ( new String ( VAR_1 , TYPE_4 . VAR_3 ) ) ; <START> return new TYPE_1 ( obj . getString ( VAR_4 ) , obj . getString ( VAR_5 ) , ( int ) obj . VAR_6 ( VAR_7 ) ) ; <END> }
public static TYPE_1 METHOD_1 ( byte [ ] VAR_1 ) throws TYPE_2 { final TYPE_3 obj = new TYPE_3 ( new String ( VAR_1 , TYPE_4 . VAR_3 ) ) ; return new TYPE_1 ( obj . getString ( VAR_4 ) , obj . getString ( VAR_5 ) , obj . getInt ( VAR_7 ) ) ; }
otherway
public void METHOD_1 ( TYPE_1 VAR_1 ) throws TYPE_2 { if ( ! METHOD_2 ( ) ) { VAR_2 . VAR_3 . METHOD_3 ( ) ; throw new TYPE_2 ( STRING_1 , TYPE_5 . TYPE_4 ) ; } else { VAR_6 . add ( VAR_1 ) ; <START> TYPE_3 . METHOD_4 ( VAR_1 ) ; <END> } }
public void METHOD_1 ( TYPE_1 VAR_1 ) throws TYPE_2 { if ( ! METHOD_2 ( ) ) { VAR_2 . VAR_3 . METHOD_3 ( ) ; throw new TYPE_2 ( STRING_1 , TYPE_5 . TYPE_4 ) ; } else { VAR_6 . add ( TYPE_3 . METHOD_4 ( VAR_1 ) ) ; } }
need assign a temporary variable
private String METHOD_1 ( final TYPE_1 TYPE_1 ) { <START> final StringBuilder sb = new StringBuilder ( ) <END> . append ( TYPE_1 . METHOD_2 ( ) ) . append ( TYPE_1 . METHOD_3 ( ) ? STRING_1 : STRING_2 ) ; return sb . toString ( ) ; }
private String METHOD_1 ( final TYPE_1 TYPE_1 ) { return new StringBuilder ( ) . append ( TYPE_1 . METHOD_2 ( ) ) . append ( TYPE_1 . METHOD_3 ( ) ? STRING_1 : STRING_2 ) . toString ( ) ; }
zeer matig geschreven methode maar bon
<START> public void execute ( ) { <END> if ( ! VAR_1 ) { if ( VAR_2 ) VAR_3 . METHOD_1 ( ) ; return ; } VAR_3 . METHOD_2 ( 3 + ( VAR_2 ? 1 : 0 ) ) ; }
public void execute ( ) { if ( ! VAR_1 ) { if ( VAR_2 ) VAR_3 . METHOD_1 ( ) ; } else { VAR_3 . METHOD_2 ( 3 + ( VAR_2 ? 1 : 0 ) ) ; } }
[ minor ] I return ( i e ) jclouds
public String getName ( ) { <START> return this . name ; <END> }
public String getName ( ) { return name ; }
call ( ) s clunky
public TYPE_2 ( ) { VAR_2 = TYPE_1 . VAR_4 ; <START> VAR_5 = false ; <END> }
public TYPE_2 ( ) { this ( null , TYPE_1 . VAR_4 , false , null ) ; }
method previous line
public void METHOD_1 ( ) throws IOException { if ( VAR_1 ) { VAR_2 . METHOD_2 ( IOException . VAR_3 ) ; VAR_2 . METHOD_3 ( STRING_1 ) ; <START> TYPE_1 . METHOD_4 ( VAR_2 ) ; <END> } TYPE_2 builder = METHOD_5 ( ) ; String [ ] args = builder . build ( ) ; METHOD_6 ( args ) ; if ( ! VAR_1 ) { METHOD_7 ( ) ; } }
public void METHOD_1 ( ) throws IOException { if ( VAR_1 ) { TYPE_1 . METHOD_4 ( VAR_2 ) ; } TYPE_2 builder = METHOD_5 ( ) ; String [ ] args = builder . build ( ) ; METHOD_6 ( args ) ; if ( ! VAR_1 ) { METHOD_7 ( ) ; } }
more : put method method METHOD_1 doesn t METHOD_4
void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) throws IOException , TYPE_3 , TYPE_4 { List < TYPE_5 > VAR_3 = METHOD_2 ( VAR_1 ) ; if ( ! VAR_3 . isEmpty ( ) ) { METHOD_3 ( VAR_3 , VAR_1 , VAR_2 ) ; } <START> VAR_1 . METHOD_4 ( ) ; <END> }
void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) throws IOException , TYPE_3 , TYPE_4 { List < TYPE_5 > VAR_3 = METHOD_2 ( VAR_1 ) ; if ( ! VAR_3 . isEmpty ( ) ) { METHOD_3 ( VAR_3 , VAR_1 , VAR_2 ) ; } }
need change order don t rely visitor finding
public void METHOD_1 ( TYPE_1 VAR_1 ) { super . METHOD_1 ( VAR_1 ) ; <START> METHOD_2 ( VAR_1 ) ; <END> }
public void METHOD_1 ( TYPE_1 VAR_1 ) { METHOD_2 ( VAR_1 ) ; super . METHOD_1 ( VAR_1 ) ; }
surround return parenthesis
private boolean METHOD_1 ( ) { int VAR_1 = VAR_2 . size ( ) ; <START> return VAR_1 > 0 && VAR_1 >= Math . VAR_3 ( VAR_4 , this . VAR_5 ) ; <END> }
private boolean METHOD_1 ( ) { int VAR_1 = VAR_2 . size ( ) ; return VAR_1 > 0 && VAR_1 >= VAR_4 ; }
previous code pretty bad readability new a more expressive - - VAR_1 > = 0
public boolean METHOD_1 ( ) { <START> return -- VAR_1 >= 0 ; <END> }
boolean METHOD_1 ( ) { return -- VAR_1 >= 0 ; }
❗️ prevents a user assigning a custom display TYPE_1 INVALID_TYPE adding a restriction doesn t provide benefit user
public String METHOD_1 ( int VAR_1 ) { <START> if ( VAR_1 >= TYPE_1 . VAR_3 && VAR_1 < VAR_4 . length ) { <END> String VAR_5 = VAR_4 [ VAR_1 ] ; if ( VAR_5 != null ) { return VAR_5 ; } } String VAR_6 = METHOD_2 ( VAR_1 ) ; if ( VAR_6 != null ) { return VAR_6 ; } String VAR_7 = METHOD_3 ( VAR_1 ) ; if ( VAR_7 != null ) ...
public String METHOD_1 ( int VAR_1 ) { if ( VAR_1 >= 0 && VAR_1 < VAR_4 . length ) { String VAR_5 = VAR_4 [ VAR_1 ] ; if ( VAR_5 != null ) { return VAR_5 ; } } String VAR_6 = METHOD_2 ( VAR_1 ) ; if ( VAR_6 != null ) { return VAR_6 ; } String VAR_7 = METHOD_3 ( VAR_1 ) ; if ( VAR_7 != null ) { return VAR_7 ; } return I...
necessary I
private boolean METHOD_1 ( ) { final TYPE_1 VAR_1 = <START> this . METHOD_2 ( ) ; <END> return ( VAR_1 != null && ( VAR_1 . METHOD_3 ( TYPE_1 . VAR_2 ) || VAR_1 . METHOD_3 ( TYPE_1 . VAR_3 ) ) ) ; }
private boolean METHOD_1 ( ) { final TYPE_1 VAR_1 = METHOD_2 ( ) ; return ( VAR_1 != null && ( VAR_1 . METHOD_3 ( TYPE_1 . VAR_2 ) || VAR_1 . METHOD_3 ( TYPE_1 . VAR_3 ) ) ) ; }
Boolean methods null return type boolean instead Boolean
public Boolean METHOD_1 ( ) { <START> return ( VAR_1 != null ) ? VAR_1 : Boolean . VAR_2 ; <END> }
public boolean METHOD_1 ( ) { return VAR_1 ; }
switching eqauls ( VAR_1 METHOD_2 ( ) ) don t need null check
private boolean METHOD_1 ( ) { if <START> ( VAR_1 . METHOD_2 ( ) == null || VAR_1 . METHOD_2 ( ) . equals ( "" ) ) { <END> METHOD_3 ( STRING_1 ) ; return false ; } if ( 0 == VAR_2 . METHOD_4 ( ) . length ) { METHOD_3 ( STRING_2 ) ; return false ; } if ( ! METHOD_5 ( ) ) { METHOD_3 ( STRING_3 ) ; return false ; } METHOD...
private boolean METHOD_1 ( ) { if ( "" . equals ( VAR_1 . METHOD_2 ( ) ) ) { METHOD_3 ( STRING_1 ) ; return false ; } if ( 0 == VAR_2 . METHOD_4 ( ) . length ) { METHOD_3 ( STRING_2 ) ; return false ; } if ( ! METHOD_5 ( ) ) { METHOD_3 ( STRING_3 ) ; return false ; } METHOD_3 ( null ) ; return true ; }
please add { }
public boolean METHOD_1 ( TYPE_1 VAR_1 ) { TYPE_2 connection = TYPE_3 . getInstance ( ) . METHOD_2 ( ) . get ( VAR_1 . METHOD_3 ( ) ) ; <START> <END> if ( connection != null ) TYPE_3 . getInstance ( ) . METHOD_2 ( ) . remove ( connection . VAR_2 ( ) ) ; return true ; }
public boolean METHOD_1 ( TYPE_1 VAR_1 ) { TYPE_2 connection = TYPE_3 . getInstance ( ) . METHOD_2 ( ) . get ( VAR_1 . METHOD_3 ( ) ) ; if ( connection != null ) { TYPE_3 . getInstance ( ) . METHOD_2 ( ) . remove ( connection . VAR_2 ( ) ) ; } return true ; }
StringUtils
public void METHOD_1 ( ) throws IOException { writer = TYPE_1 . METHOD_2 ( VAR_1 , <START> String . format ( STRING_1 , VAR_2 ) , <END> VAR_3 , VAR_4 ) ; writer . VAR_5 ( ) ; }
public void METHOD_1 ( ) throws IOException { writer = TYPE_1 . METHOD_2 ( VAR_1 , StringUtils . format ( STRING_1 , VAR_2 ) , VAR_3 , VAR_4 ) ; writer . VAR_5 ( ) ; }
duplicately
public TYPE_5 ( Map conf , List < String > VAR_2 , TYPE_1 VAR_3 , String VAR_4 , String id , TYPE_2 < TYPE_3 > VAR_5 , TYPE_2 < TYPE_4 > VAR_6 ) { this . conf = conf ; this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; this . VAR_5 = VAR_5 ; this . id = id ; <START> this . VAR_5 = VAR_5 ; <END> this . VAR_6 = VAR_6 ; }
public TYPE_5 ( Map conf , List < String > VAR_2 , TYPE_1 VAR_3 , String VAR_4 , String id , TYPE_2 < TYPE_3 > VAR_5 , TYPE_2 < TYPE_4 > VAR_6 ) { this . conf = conf ; this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; this . VAR_4 = VAR_4 ; this . id = id ; this . VAR_5 = VAR_5 ; this . VAR_6 = VAR_6 ; }
s reason need protected
<START> protected Class < ? > METHOD_1 ( TYPE_1 < ? > configuration , TYPE_2 VAR_1 ) { <END> String VAR_2 = configuration . VAR_3 ( ) ; TYPE_3 VAR_4 = VAR_1 . METHOD_2 ( ) ; try { return org . VAR_5 . VAR_6 . TYPE_6 . METHOD_3 ( VAR_2 , VAR_4 ) ; } catch ( TYPE_4 | TYPE_5 e ) { LOGGER . warn ( String . format ( VAR_8 ,...
private Class < ? > METHOD_1 ( TYPE_1 < ? > configuration , TYPE_2 VAR_1 ) { String VAR_2 = configuration . VAR_3 ( ) ; TYPE_3 VAR_4 = VAR_1 . METHOD_2 ( ) ; try { return org . VAR_5 . VAR_6 . TYPE_6 . METHOD_3 ( VAR_2 , VAR_4 ) ; } catch ( TYPE_4 | TYPE_5 e ) { LOGGER . warn ( String . format ( VAR_8 , METHOD_4 ( ) , ...
I moved _CODE_ ( ) raise error ASAP
protected void METHOD_1 ( ) { Assert . state ( this . VAR_1 != null || StringUtils . VAR_2 ( this . VAR_3 ) , <START> STRING_1 ) ; <END> }
protected void METHOD_1 ( ) { }
return session VAR_6 ( VAR_2 ) ;
protected TYPE_1 METHOD_1 ( boolean VAR_1 ) { TYPE_1 VAR_2 = session . VAR_3 ( STRING_1 , STRING_2 , STRING_3 ) ; if ( VAR_1 ) { VAR_2 . METHOD_2 ( VAR_4 , ( TYPE_2 ) TYPE_3 . METHOD_3 ( VAR_5 ) ) ; } <START> VAR_2 = session . VAR_6 ( VAR_2 ) ; return VAR_2 ; <END> }
protected TYPE_1 METHOD_1 ( boolean VAR_1 ) { TYPE_1 VAR_2 = session . VAR_3 ( STRING_1 , STRING_2 , STRING_3 ) ; if ( VAR_1 ) { VAR_2 . METHOD_2 ( VAR_4 , ( TYPE_2 ) TYPE_3 . METHOD_3 ( VAR_5 ) ) ; } return session . VAR_6 ( VAR_2 ) ; }
static import TYPE_2 METHOD_2
private boolean METHOD_1 ( TYPE_1 VAR_1 , String VAR_2 , int VAR_3 , Object VAR_4 ) { <START> if ( VAR_4 == null && ! TYPE_2 . METHOD_2 ( VAR_1 . METHOD_3 ( ) ) . get ( VAR_3 ) . METHOD_4 ( TYPE_3 . class ) ) <END> throw new TYPE_4 ( format ( STRING_1 , VAR_2 , VAR_1 . METHOD_3 ( ) . METHOD_5 ( ) . METHOD_6 ( ) . METHO...
private boolean METHOD_1 ( TYPE_1 VAR_1 , String VAR_2 , int VAR_3 , Object VAR_4 ) { if ( VAR_4 == null && ! METHOD_2 ( VAR_1 . METHOD_3 ( ) ) . get ( VAR_3 ) . METHOD_4 ( TYPE_3 . class ) ) throw new TYPE_4 ( format ( STRING_1 , VAR_2 , VAR_1 . METHOD_3 ( ) . METHOD_5 ( ) . METHOD_6 ( ) . METHOD_7 ( ) , VAR_1 . METHO...
allowed flush events device user opt gdpr
<START> public void METHOD_1 ( ) { <END> METHOD_2 ( ) . METHOD_3 ( new TYPE_2 . TYPE_3 ( VAR_1 ) ) ; if ( METHOD_4 ( ) . METHOD_5 ( ) ) { METHOD_4 ( ) . METHOD_6 ( ) ; METHOD_4 ( ) . METHOD_7 ( ) ; } VAR_2 . METHOD_8 ( ) ; synchronized ( VAR_3 ) { VAR_3 . clear ( ) ; VAR_2 . METHOD_9 ( ) ; } VAR_2 . METHOD_10 ( ) ; VAR...
public void METHOD_1 ( ) { METHOD_2 ( ) . METHOD_3 ( new TYPE_2 . TYPE_3 ( VAR_1 ) ) ; if ( METHOD_4 ( ) . METHOD_5 ( ) ) { METHOD_4 ( ) . METHOD_6 ( ) ; METHOD_4 ( ) . METHOD_7 ( ) ; } VAR_2 . METHOD_8 ( ) ; synchronized ( VAR_3 ) { VAR_3 . clear ( ) ; VAR_2 . METHOD_9 ( ) ; } VAR_2 . METHOD_10 ( ) ; VAR_2 . METHOD_11...
fully qualified package
<START> protected org . VAR_1 . VAR_2 . TYPE_4 METHOD_1 ( ) { <END> return super . METHOD_1 ( ) . METHOD_2 ( ) . METHOD_3 ( TYPE_1 . class ) . METHOD_3 ( TYPE_2 . class ) . METHOD_3 ( TYPE_3 . class ) . build ( ) ; }
protected TYPE_4 METHOD_1 ( ) { return super . METHOD_1 ( ) . METHOD_2 ( ) . METHOD_3 ( TYPE_1 . class ) . METHOD_3 ( TYPE_2 . class ) . METHOD_3 ( TYPE_3 . class ) . build ( ) ; }
column refer ? plan IR shouldn t references column names column handles instead
public static String METHOD_1 ( TYPE_1 value ) { return value . VAR_1 ( ) . name ( ) + STRING_1 + value . VAR_2 ( ) ; <START> } <END>
static String METHOD_1 ( TYPE_1 value ) { return value . VAR_1 ( ) . name ( ) + STRING_1 + value . VAR_2 ( ) ; }
a ! missing
private static void METHOD_1 ( File to ) throws IOException { <START> boolean VAR_1 = to . exists ( ) ; <END> if ( VAR_1 ) { return ; } boolean VAR_2 = to . VAR_3 ( ) ; if ( VAR_2 ) { return ; } throw new IOException ( STRING_1 + to . VAR_4 ( ) ) ; }
private static void METHOD_1 ( File to ) throws IOException { boolean VAR_1 = ! to . exists ( ) ; if ( VAR_1 ) { return ; } boolean VAR_2 = to . VAR_3 ( ) ; if ( VAR_2 ) { return ; } throw new IOException ( STRING_1 + to . VAR_4 ( ) ) ; }
inline key IMO
public Map . Entry < TYPE_1 , Collection < TYPE_2 > > next ( ) { final Map . Entry < TYPE_1 , Collection < TYPE_2 > > entry = super . next ( ) ; final TYPE_1 key = entry . getKey ( ) ; final Collection < TYPE_2 > value = entry . getValue ( ) ; <START> return new TYPE_3 < > ( key , value ) ; <END> }
public Map . Entry < TYPE_1 , Collection < TYPE_2 > > next ( ) { final Map . Entry < TYPE_1 , Collection < TYPE_2 > > entry = super . next ( ) ; return new TYPE_3 < > ( entry . getKey ( ) , entry . getValue ( ) ) ; }
I call future : VAR_1 METHOD_4 ( call ) ( )
public void METHOD_1 ( TYPE_1 call ) throws Exception { TYPE_2 VAR_1 = METHOD_2 ( METHOD_3 ( ) ) ; <START> VAR_1 . METHOD_4 ( call ) ; <END> }
public void METHOD_1 ( TYPE_1 call ) throws Exception { TYPE_2 VAR_1 = METHOD_2 ( METHOD_3 ( ) ) ; VAR_1 . METHOD_4 ( call ) . get ( ) ; }
position adjustment restore wrapped a / finally don t want buffer left invalid state exception thrown
public void METHOD_1 ( ByteBuffer buf , int position ) { final int VAR_1 = buf . position ( ) ; buf . position ( position ) ; METHOD_2 ( buf ) ; <START> buf . position ( VAR_1 ) ; <END> }
public void METHOD_1 ( ByteBuffer buf , int position ) { final int VAR_1 = buf . position ( ) ; try { buf . position ( position ) ; METHOD_2 ( buf ) ; } finally { buf . position ( VAR_1 ) ; } }
add braces / else statement
public List < TYPE_1 > METHOD_1 ( ) { <START> if ( VAR_1 != null ) <END> return VAR_1 . METHOD_1 ( ) ; else return null ; }
public List < TYPE_1 > METHOD_1 ( ) { if ( VAR_1 != null ) { return VAR_1 . METHOD_1 ( ) ; } else { return null ; } }
correct VAR_1 : foo# { bar } baz meaning evaluate a template part concatenate rest strings _CODE_ _CODE_ doesn t sense deprecate private method point log warn templating deprecated more context variable
private boolean METHOD_1 ( String VAR_1 ) { <START> return VAR_1 . startsWith ( TYPE_1 . METHOD_2 ( ) ) && VAR_1 . METHOD_3 ( TYPE_1 . METHOD_4 ( ) ) ; <END> }
private boolean METHOD_1 ( String VAR_1 ) { return VAR_1 . contains ( TYPE_1 . METHOD_2 ( ) ) && VAR_1 . contains ( TYPE_1 . METHOD_4 ( ) ) ; }
t null
public String toString ( ) { return TYPE_1 . METHOD_1 ( this ) . METHOD_2 ( ) . add ( STRING_1 , VAR_1 . getName ( ) ) <START> . add ( STRING_2 , VAR_2 . getName ( ) ) <END> . add ( STRING_3 , path ) . toString ( ) ; }
public String toString ( ) { return TYPE_1 . METHOD_1 ( this ) . METHOD_2 ( ) . add ( STRING_1 , VAR_1 . getName ( ) ) . add ( STRING_2 , VAR_2 != null ? VAR_2 . getName ( ) : null ) . add ( STRING_3 , path ) . toString ( ) ; }
METHOD_4 method throw exception assertion redundant _CODE_ want explicit remove assertion
public void METHOD_1 ( ) { List < TYPE_1 > VAR_1 = METHOD_2 ( ) . METHOD_3 ( ) ; assertNotNull ( VAR_1 ) ; TYPE_1 VAR_2 = TYPE_2 . METHOD_4 ( VAR_1 , new TYPE_3 < TYPE_1 > ( ) { @Override public boolean apply ( TYPE_1 input ) { return input . VAR_3 ( ) . contains ( STRING_1 ) ; } <START> } ) ; <END> assertNotNull ( VAR...
public void METHOD_1 ( ) { List < TYPE_1 > VAR_1 = METHOD_2 ( ) . METHOD_3 ( ) ; assertNotNull ( VAR_1 ) ; TYPE_2 . METHOD_4 ( VAR_1 , new TYPE_3 < TYPE_1 > ( ) { @Override public boolean apply ( TYPE_1 input ) { return input . VAR_3 ( ) . contains ( STRING_1 ) ; } } ) ; }
need methods static private void fine
private static void METHOD_1 ( ) { <START> client . VAR_1 ( TYPE_1 . VAR_3 , false ) ; <END> }
private void METHOD_1 ( ) { client . VAR_1 ( TYPE_1 . VAR_3 , false ) ; }
ah yeah some limitations linter thanks care
private int METHOD_1 ( final String VAR_1 ) throws TYPE_1 , InterruptedException { <START> try ( TYPE_2 VAR_2 = METHOD_2 ( ) ) { <END> final TYPE_3 VAR_3 = VAR_2 . METHOD_3 ( Collections . VAR_4 ( VAR_1 ) ) . values ( ) . get ( VAR_1 ) . get ( ) ; return VAR_3 . METHOD_4 ( ) . size ( ) ; } }
private int METHOD_1 ( final String VAR_1 ) throws Exception { try ( final TYPE_2 VAR_2 = METHOD_2 ( ) ) { final TYPE_3 VAR_3 = VAR_2 . METHOD_3 ( Collections . VAR_4 ( VAR_1 ) ) . values ( ) . get ( VAR_1 ) . get ( ) ; return VAR_3 . METHOD_4 ( ) . size ( ) ; } }
need remove leftover debug output
public List < String > METHOD_1 ( String name ) { TYPE_1 < String , String > VAR_1 = VAR_2 . METHOD_2 ( ) ; <START> System . out . println ( VAR_1 . get ( name ) ) ; <END> return VAR_1 . get ( name ) ; }
public List < String > METHOD_1 ( String name ) { TYPE_1 < String , String > VAR_1 = VAR_2 . METHOD_2 ( ) ; return VAR_1 . get ( name ) ; }
don t need synchronized
public boolean METHOD_1 ( String id ) { <START> synchronized ( VAR_1 ) <END> { return METHOD_1 ( id , null ) ; } }
public boolean METHOD_1 ( String id ) { return METHOD_1 ( id , null ) ; }
add a TODO response aren t side - effects
public TYPE_1 METHOD_1 ( final TYPE_2 VAR_1 , final TYPE_3 VAR_2 , final Collection < TYPE_4 > VAR_3 , final TYPE_5 VAR_4 , final TYPE_6 request ) { VAR_5 . log ( STRING_1 , new TYPE_7 ( VAR_3 ) ) ; <START> final TYPE_8 VAR_6 = VAR_7 . METHOD_2 ( new TYPE_9 ( VAR_2 , VAR_4 , VAR_3 ) , VAR_1 ) ; <END> return METHOD_1 ( ...
public TYPE_1 METHOD_1 ( final TYPE_2 VAR_1 , final TYPE_3 VAR_2 , final Collection < TYPE_4 > VAR_3 , final TYPE_5 VAR_4 , final TYPE_6 request ) { VAR_5 . log ( STRING_1 , new TYPE_7 ( VAR_3 ) ) ; VAR_7 . METHOD_2 ( new TYPE_9 ( VAR_2 , VAR_4 , VAR_3 ) , VAR_1 ) ; return METHOD_1 ( request , VAR_1 , VAR_3 ) ; }
needs changed support locked stream syntax
private TYPE_1 METHOD_1 ( TYPE_2 key , TYPE_3 < ? super TYPE_2 , ? super TYPE_1 , ? extends TYPE_1 > VAR_1 , boolean VAR_2 , TYPE_4 metadata , long VAR_3 ) { METHOD_2 ( key ) ; METHOD_3 ( VAR_1 ) ; TYPE_5 ctx = METHOD_4 ( false , 1 ) ; TYPE_6 command = VAR_4 . METHOD_5 ( key , VAR_1 , VAR_2 , metadata , VAR_3 ) ; <STAR...
private TYPE_1 METHOD_1 ( TYPE_2 key , TYPE_3 < ? super TYPE_2 , ? super TYPE_1 , ? extends TYPE_1 > VAR_1 , boolean VAR_2 , TYPE_4 metadata , long VAR_3 ) { return METHOD_1 ( key , VAR_1 , VAR_2 , metadata , VAR_3 , METHOD_4 ( false , 1 ) ) ; }
put
protected void METHOD_1 ( List < Object > VAR_1 ) { <START> log ( STRING_1 ) ; <END> if ( TYPE_1 . getInstance ( ) . METHOD_2 ( ) ) { TYPE_2 VAR_2 = Context . VAR_3 ( TYPE_2 . class ) ; for ( Object VAR_4 : VAR_1 ) { if ( VAR_4 instanceof TYPE_3 ) { VAR_2 . METHOD_3 ( ( TYPE_3 ) VAR_4 ) ; } } } }
protected void METHOD_1 ( List < Object > VAR_1 ) { if ( TYPE_1 . getInstance ( ) . METHOD_2 ( ) ) { log ( STRING_1 ) ; TYPE_2 VAR_2 = Context . VAR_3 ( TYPE_2 . class ) ; for ( Object VAR_4 : VAR_1 ) { if ( VAR_4 instanceof TYPE_3 ) { VAR_2 . METHOD_3 ( ( TYPE_3 ) VAR_4 ) ; } } } }
able ( VAR_2 equals ( VAR_1 ) )
public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { <START> for ( TYPE_1 VAR_2 : VAR_3 ) { <END> if ( VAR_2 . getId ( ) . equals ( VAR_1 . getId ( ) ) ) { return VAR_2 ; } } return null ; }
public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { for ( TYPE_1 VAR_2 : VAR_3 ) { if ( VAR_2 . equals ( VAR_1 ) ) { return VAR_2 ; } } return null ; }
great place a lambda ; ) javareturn TYPE_3 iterator ( config - > new TYPE_4 < TYPE_2 > ( ) { TYPE_6 stream ( ) { return VAR_1 = factory apply ( config ) ; } TYPE_7 < TYPE_2 > VAR_2 ( ) { return VAR_2 ; } } ) ;
public Iterator < TYPE_1 < TYPE_2 > > iterator ( ) { <START> return TYPE_3 . iterator ( new TYPE_1 < TYPE_2 > ( ) <END> { @Override public TYPE_4 < TYPE_2 > create ( TYPE_5 config ) { return new TYPE_4 < TYPE_2 > ( ) { @Override public TYPE_6 stream ( ) { return VAR_1 = factory . apply ( config ) ; } @Override public T...
public Iterator < TYPE_1 < TYPE_2 > > iterator ( ) { return TYPE_3 . iterator ( config - > new TYPE_4 < TYPE_2 > ( ) { @Override public TYPE_6 stream ( ) { return VAR_1 = factory . apply ( config ) ; } @Override public TYPE_7 < TYPE_2 > METHOD_1 ( ) { return VAR_2 ; } } ) ; }
TYPE_5 part part VAR_5 execution
public void METHOD_1 ( TYPE_1 VAR_1 ) throws IOException { TYPE_2 session = TYPE_3 . METHOD_2 ( ) ; long VAR_2 = ( long ) TYPE_4 . METHOD_3 ( VAR_1 . toString ( ) ) ; TYPE_5 VAR_3 = VAR_4 . bind ( VAR_2 , VAR_1 . toString ( ) , "" ) ; TYPE_6 . Context VAR_5 = TYPE_7 . METHOD_4 ( TYPE_8 . VAR_7 ) ; try { <START> session...
public void METHOD_1 ( TYPE_1 VAR_1 ) throws IOException { TYPE_2 session = TYPE_3 . METHOD_2 ( ) ; long VAR_2 = ( long ) TYPE_4 . METHOD_3 ( VAR_1 . toString ( ) ) ; TYPE_6 . Context VAR_5 = TYPE_7 . METHOD_4 ( TYPE_8 . VAR_7 ) ; try { TYPE_5 VAR_3 = VAR_4 . bind ( VAR_2 , VAR_1 . toString ( ) , "" ) ; session . execu...
2 operations ? flatmap sufficient
private Set < Type > METHOD_1 ( TYPE_3 . TYPE_4 VAR_1 , TYPE_2 VAR_2 ) { return VAR_1 . METHOD_2 ( ) . stream ( ) <START> . map ( VAR_3 - > METHOD_3 ( VAR_3 , VAR_2 ) ) <END> . METHOD_4 ( VAR_4 - > METHOD_5 ( VAR_4 ) . stream ( ) ) . collect ( Collectors . VAR_5 ( ) ) ; }
private Set < Type > METHOD_1 ( TYPE_3 . TYPE_4 VAR_1 , TYPE_2 VAR_2 ) { return VAR_1 . METHOD_2 ( ) . stream ( ) . METHOD_4 ( VAR_3 - > METHOD_5 ( METHOD_3 ( VAR_3 , VAR_2 ) ) . stream ( ) ) . collect ( Collectors . VAR_5 ( ) ) ; }
fluent chaining nice
<START> public void METHOD_1 ( ) { <END> METHOD_2 ( TYPE_1 . VAR_1 . VAR_2 ) ; METHOD_3 ( VAR_3 ) ; VAR_3 . METHOD_4 ( ) ; TYPE_2 . log ( STRING_1 , STRING_2 , true ) ; }
public TYPE_1 METHOD_1 ( ) { METHOD_2 ( TYPE_1 . VAR_1 . VAR_2 ) ; METHOD_3 ( VAR_3 ) ; VAR_3 . METHOD_4 ( ) ; TYPE_2 . log ( STRING_1 , STRING_2 , true ) ; return this ; }
curious need change access qualifier protected
<START> protected StringUtils ( ) { <END> }
private StringUtils ( ) { }
? : int VAR_6 = VAR_4 > 0
public int METHOD_1 ( ) throws Exception { TYPE_1 < ? > VAR_1 = VAR_2 . METHOD_2 ( ) ; int VAR_3 = VAR_2 . METHOD_3 ( ) . METHOD_4 ( ) ; long VAR_4 = Math . VAR_5 ( VAR_3 , VAR_2 . METHOD_5 ( ) ) ; <START> int VAR_6 = 0 ; <END> if ( VAR_4 > 0 ) { VAR_6 = METHOD_6 ( VAR_1 , VAR_4 ) ; } VAR_2 . METHOD_7 ( VAR_6 ) ; retur...
public int METHOD_1 ( ) throws Exception { TYPE_1 < ? > VAR_1 = VAR_2 . METHOD_2 ( ) ; int VAR_3 = VAR_2 . METHOD_3 ( ) . METHOD_4 ( ) ; long VAR_4 = Math . VAR_5 ( VAR_3 , VAR_2 . METHOD_5 ( ) ) ; int VAR_6 = VAR_4 > 0 ? METHOD_6 ( VAR_1 , VAR_4 ) : 0 ; VAR_2 . METHOD_7 ( VAR_6 ) ; return VAR_6 ; }
initialize VAR_1
public List < TYPE_1 > METHOD_1 ( ) { <START> List < TYPE_1 > VAR_1 ; <END> try { VAR_1 = VAR_2 . METHOD_2 ( ) ; for ( TYPE_1 VAR_3 : VAR_1 ) { METHOD_3 ( VAR_3 ) ; } } catch ( TYPE_2 e ) { throw new RuntimeException ( STRING_1 , e ) ; } return VAR_1 ; }
public List < TYPE_1 > METHOD_1 ( ) { List < TYPE_1 > VAR_1 ; try { VAR_1 = VAR_2 . METHOD_2 ( ) ; } catch ( TYPE_2 e ) { throw new RuntimeException ( STRING_1 , e ) ; } return VAR_1 ; }
I replace ArrayList List ( VAR_1 instanceof List ) { List VAR_3 = ( List ) VAR_1 ; List VAR_4 = new ArrayList ( VAR_3 size ( ) ) ; ( Object VAR_5 : VAR_3 ) { VAR_4 add ( METHOD_1 ( VAR_5 ) ) ; }
public static Object METHOD_1 ( Object VAR_1 ) { Object VAR_2 = VAR_1 ; if ( VAR_1 instanceof byte [ ] ) { VAR_2 = TYPE_1 . METHOD_2 ( ( byte [ ] ) VAR_1 ) ; <START> } else if ( VAR_1 instanceof ArrayList ) { ArrayList VAR_3 = ( ArrayList ) VAR_1 ; ArrayList VAR_4 = new ArrayList ( VAR_3 . size ( ) ) ; for ( Object VAR...
public static Object METHOD_1 ( Object VAR_1 ) { if ( VAR_1 instanceof byte [ ] ) { return TYPE_1 . METHOD_2 ( ( byte [ ] ) VAR_1 ) ; } if ( VAR_1 instanceof List ) { List VAR_3 = ( List ) VAR_1 ; List VAR_4 = new ArrayList ( VAR_3 . size ( ) ) ; for ( Object VAR_5 : VAR_3 ) { VAR_4 . add ( METHOD_1 ( VAR_5 ) ) ; } ret...
ctor invoke other similar logic I DRY - other words
public TYPE_3 ( TYPE_1 factory , String VAR_2 ) { VAR_3 = new TYPE_2 ( factory ) ; this . VAR_2 = ( StringUtils . VAR_4 ( VAR_2 ) ) ? VAR_2 : VAR_5 ; <START> } <END>
public TYPE_3 ( TYPE_1 factory , String VAR_2 ) { this ( new TYPE_2 ( factory ) , VAR_2 ) ; }
: METHOD_3
private void METHOD_1 ( long VAR_1 , long VAR_2 ) { <START> VAR_3 . METHOD_2 ( ( ) - > METHOD_3 ( ) , <END> VAR_2 , VAR_1 , TimeUnit . VAR_4 ) ; }
private void METHOD_1 ( long VAR_1 , long VAR_2 ) { VAR_3 . METHOD_2 ( this : : METHOD_3 , VAR_2 , VAR_1 , TimeUnit . VAR_4 ) ; }
shouldn t synchronized
public void METHOD_1 ( TYPE_1 < T > VAR_1 ) { <START> TYPE_2 < T > VAR_2 = this . VAR_3 ; <END> synchronized ( this ) { VAR_3 = new TYPE_3 < > ( VAR_1 ) ; VAR_2 . METHOD_1 ( VAR_1 ) ; } }
public synchronized void METHOD_1 ( TYPE_1 < T > VAR_1 ) { TYPE_2 < T > VAR_2 = this . VAR_3 ; VAR_3 = new TYPE_3 < > ( VAR_1 ) ; VAR_2 . METHOD_1 ( VAR_1 ) ; }
doc
<START> public void METHOD_1 ( TYPE_1 id ) { <END> TYPE_2 VAR_1 = VAR_2 . get ( id ) ; if ( VAR_1 != null ) { VAR_1 . METHOD_1 ( id ) ; } }
public boolean METHOD_1 ( TYPE_1 id ) { TYPE_2 VAR_1 = VAR_2 . get ( id ) ; return VAR_1 != null && VAR_1 . METHOD_1 ( id ) ; }
multi - catch
public Class < ? > METHOD_1 ( TYPE_1 < ? > VAR_1 ) throws TYPE_2 { try { return METHOD_2 ( VAR_1 ) ; } catch ( TYPE_3 | TYPE_4 e ) { throw new TYPE_2 ( e ) ; } catch ( IOException e ) { throw new TYPE_2 ( e ) ; <START> } <END> }
public Class < ? > METHOD_1 ( TYPE_1 < ? > VAR_1 ) throws TYPE_2 { try { return METHOD_2 ( VAR_1 ) ; } catch ( TYPE_3 | TYPE_4 | IOException e ) { throw new TYPE_2 ( e ) ; } }
GSON initializes classes reflection constructor default definition set field declaration
public TYPE_3 ( TYPE_1 VAR_2 , List < TYPE_2 > VAR_3 , float VAR_4 , int VAR_5 ) { this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; this . VAR_4 = VAR_4 ; this . VAR_5 = VAR_5 ; int VAR_6 = 0 ; for ( TYPE_2 VAR_7 : VAR_3 ) VAR_6 += VAR_7 . METHOD_1 ( ) ; this . VAR_8 = VAR_6 ; <START> this . VAR_9 = INT_1 ; <END> }
public TYPE_3 ( TYPE_1 VAR_2 , List < TYPE_2 > VAR_3 , float VAR_4 , int VAR_5 ) { this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; this . VAR_4 = VAR_4 ; this . VAR_5 = VAR_5 ; int VAR_6 = 0 ; for ( TYPE_2 VAR_7 : VAR_3 ) VAR_6 += VAR_7 . METHOD_1 ( ) ; this . VAR_8 = VAR_6 ; }
response guaranteed - null point
private byte [ ] METHOD_1 ( TYPE_1 response ) throws TYPE_2 { TYPE_3 VAR_1 = new TYPE_3 ( ) ; <START> if ( response . VAR_2 ( ) != null && response . VAR_2 ( ) . METHOD_2 ( ) != null ) { <END> METHOD_3 ( ) . METHOD_4 ( response . VAR_2 ( ) . METHOD_2 ( ) , VAR_1 ) ; } return VAR_1 . METHOD_5 ( ) ; }
private byte [ ] METHOD_1 ( TYPE_1 response ) throws TYPE_2 { TYPE_3 VAR_1 = new TYPE_3 ( ) ; if ( response != null && response . VAR_2 ( ) != null && response . VAR_2 ( ) . METHOD_2 ( ) != null ) { METHOD_3 ( ) . METHOD_4 ( response . VAR_2 ( ) . METHOD_2 ( ) , VAR_1 ) ; } return VAR_1 . METHOD_5 ( ) ; }
expected exception matching row database ignore instead
public List < TYPE_1 > METHOD_1 ( final TYPE_2 type , final Collection < TYPE_3 > VAR_1 ) { final List < TYPE_1 > result = new ArrayList < > ( VAR_1 . size ( ) ) ; for ( final TYPE_3 VAR_2 : VAR_1 ) { try { result . add ( METHOD_2 ( type , VAR_2 ) ) ; } catch ( TYPE_4 VAR_3 ) { <START> LOGGER . debug ( STRING_1 , VAR_3...
public List < TYPE_1 > METHOD_1 ( final TYPE_2 type , final Collection < TYPE_3 > VAR_1 ) { final List < TYPE_1 > result = new ArrayList < > ( VAR_1 . size ( ) ) ; for ( final TYPE_3 VAR_2 : VAR_1 ) { try { result . add ( METHOD_2 ( type , VAR_2 ) ) ; } catch ( TYPE_4 VAR_3 ) { } } return result ; }
I don t s necessary cast returned collection ArrayList assertions checking collection s total size
public void METHOD_1 ( ) { byte [ ] content = VAR_1 . METHOD_2 ( VAR_2 ) ; <START> ArrayList < TYPE_1 > VAR_3 = ( ArrayList < TYPE_1 > ) VAR_1 . METHOD_3 ( content ) ; <END> METHOD_4 ( content . length , 0 ) ; assertEquals ( VAR_4 , VAR_3 . size ( ) ) ; }
public void METHOD_1 ( ) { byte [ ] content = VAR_1 . METHOD_2 ( VAR_2 ) ; Collection < TYPE_1 > VAR_3 = VAR_1 . METHOD_3 ( content ) ; METHOD_4 ( content . length , 0 ) ; assertEquals ( VAR_4 , VAR_3 . size ( ) ) ; }
METHOD_1 ( ) public
<START> public static long METHOD_1 ( final long VAR_1 ) { <END> long VAR_2 = VAR_1 - 1 ; return ( VAR_2 / 4 ) - ( VAR_2 / 100 ) + ( VAR_2 / INT_1 ) ; }
static long METHOD_1 ( final long VAR_1 ) { long VAR_2 = VAR_1 - 1 ; return ( VAR_2 / 4 ) - ( VAR_2 / 100 ) + ( VAR_2 / INT_1 ) ; }
cast needed ? time ( x ) method
public void time ( ) throws Exception { TYPE_1 VAR_1 = new TYPE_1 ( VAR_2 ) ; <START> VAR_1 . time ( ( TYPE_2 < TYPE_3 > ) ( ) - > { <END> VAR_2 . METHOD_1 ( 10 , TimeUnit . VAR_3 ) ; return null ; } ) ; TYPE_4 VAR_4 = VAR_1 . METHOD_2 ( ) ; assertEquals ( VAR_4 . METHOD_3 ( ) , FLOAT_1 ) ; assertEquals ( VAR_4 . METHO...
public void time ( ) throws Exception { TYPE_1 VAR_1 = new TYPE_1 ( VAR_2 ) ; VAR_1 . time ( ( ) - > { VAR_2 . METHOD_1 ( 10 , TimeUnit . VAR_3 ) ; return null ; } ) ; TYPE_4 VAR_4 = VAR_1 . METHOD_2 ( ) ; assertEquals ( VAR_4 . METHOD_3 ( ) , FLOAT_1 ) ; assertEquals ( VAR_4 . METHOD_4 ( ) , FLOAT_2 ) ; assertEquals (...
group _CODE_ defined easier find related methods ? need public ? protected private
public boolean METHOD_1 ( ) throws TYPE_1 { return parse . VAR_1 ( VAR_2 , STRING_1 ) ; <START> } <END>
private boolean METHOD_1 ( ) throws TYPE_1 { return parse . VAR_1 ( VAR_2 , STRING_1 ) ; }
I suggest : javareturn TYPE_1 METHOD_2 ( key getName ( ) - > new TYPE_2 ( TYPE_3 METHOD_1 ( ) ) ) ; a readability note parameter METHOD_1 changed key
public static Logger METHOD_1 ( Class < ? > key ) { <START> return TYPE_1 . METHOD_2 ( key . getName ( ) , name - > new TYPE_2 ( TYPE_3 . METHOD_1 ( key ) ) ) ; <END> }
public static Logger METHOD_1 ( Class < ? > key ) { return TYPE_1 . METHOD_2 ( key . getName ( ) , name - > new TYPE_2 ( TYPE_3 . METHOD_1 ( name ) ) ) ; }
justreturn else METHOD_3 ( VAR_3 VAR_1 ) ; instead else block
public boolean METHOD_1 ( List < String > VAR_1 , int VAR_2 , int VAR_3 , TYPE_1 VAR_4 ) { if ( ! METHOD_2 ( VAR_1 , VAR_2 , VAR_4 ) ) { return false ; } <START> else if ( ! METHOD_3 ( VAR_3 , VAR_1 ) ) { return false ; } return true ; <END> }
public boolean METHOD_1 ( List < String > VAR_1 , int VAR_2 , int VAR_3 , TYPE_1 VAR_4 ) { return ! METHOD_2 ( VAR_1 , VAR_2 , VAR_4 ) && METHOD_3 ( VAR_3 , VAR_1 ) ; }
! VAR_1 equals ( ) - > ! VAR_1 isEmpty ( )
public boolean METHOD_1 ( TYPE_1 state , String [ ] params ) { <START> if ( ( this . VAR_1 != null && ! this . VAR_1 . equals ( "" ) ) && ! this . VAR_1 . equals ( params [ 1 ] ) ) { <END> return false ; } TYPE_2 VAR_2 = state . VAR_3 ( params [ 1 ] ) ; return TYPE_3 . METHOD_2 ( VAR_2 ) ; }
public boolean METHOD_1 ( TYPE_1 state , String [ ] params ) { if ( ( this . VAR_1 != null && ! this . VAR_1 . isEmpty ( ) ) && ! this . VAR_1 . equals ( params [ 1 ] ) ) { return false ; } TYPE_2 VAR_2 = state . VAR_3 ( params [ 1 ] ) ; return TYPE_3 . METHOD_2 ( VAR_2 ) ; }
I VAR_2 ( TYPE_6 TYPE_7 VAR_5 ) shouldn t necessary
public void METHOD_1 ( TYPE_1 VAR_1 ) { TYPE_2 VAR_2 = ( ( TYPE_3 ) VAR_1 ) . METHOD_2 ( ) ; TYPE_4 parameters = VAR_1 . parameters ( ) ; <START> if ( VAR_2 != null && VAR_2 . is ( TYPE_6 . TYPE_7 . VAR_5 ) && parameters != null ) { <END> TYPE_5 VAR_6 = ( TYPE_5 ) VAR_2 ; VAR_6 . METHOD_3 ( parameters ) ; } super . MET...
public void METHOD_1 ( TYPE_1 VAR_1 ) { TYPE_2 VAR_2 = ( ( TYPE_3 ) VAR_1 ) . METHOD_2 ( ) ; TYPE_4 parameters = VAR_1 . parameters ( ) ; if ( VAR_2 != null && parameters != null ) { TYPE_5 VAR_6 = ( TYPE_5 ) VAR_2 ; VAR_6 . METHOD_3 ( parameters ) ; } super . METHOD_1 ( VAR_1 ) ; }
final
<START> public TYPE_1 < TYPE_2 > <END> METHOD_1 ( ) { return VAR_1 ; }
public final TYPE_1 < TYPE_2 > METHOD_1 ( ) { return VAR_1 ; }
n variable
public static TYPE_1 parse ( String VAR_1 ) { int n = 0 ; for ( TYPE_2 VAR_2 : VAR_3 ) { try { return METHOD_1 ( VAR_2 . parse ( VAR_1 ) ) ; } catch ( TYPE_3 VAR_4 ) { <START> n ++ ; <END> continue ; } } if ( TYPE_4 . matcher ( VAR_1 ) . METHOD_2 ( ) ) { long VAR_5 = Long . VAR_6 ( VAR_1 ) ; return TYPE_5 . METHOD_3 ( ...
public static TYPE_1 parse ( String VAR_1 ) { for ( TYPE_2 VAR_2 : VAR_3 ) { try { return METHOD_1 ( VAR_2 . parse ( VAR_1 ) ) ; } catch ( TYPE_3 VAR_4 ) { continue ; } } if ( TYPE_4 . matcher ( VAR_1 ) . METHOD_2 ( ) ) { long VAR_5 = Long . VAR_6 ( VAR_1 ) ; return TYPE_5 . METHOD_3 ( VAR_5 ) . METHOD_4 ( VAR_7 ) ; } ...
copy / paste error : TYPE_5 errors tests : java lang _CODE_ : org eclipse sirius diagram business internal metamodel spec _CODE_ cast org eclipse sirius diagram _CODE_ org eclipse sirius diagram ui business internal query _CODE_ METHOD_1 ( _CODE_ java : 105 )
public Optional < TYPE_1 > METHOD_1 ( ) { TYPE_1 VAR_1 = null ; if ( VAR_2 instanceof TYPE_2 ) { VAR_1 = new TYPE_3 ( ( TYPE_2 ) VAR_2 ) . METHOD_2 ( ) . get ( ) ; } else if ( VAR_2 instanceof TYPE_4 ) { VAR_1 = ( ( TYPE_4 ) VAR_2 ) . METHOD_2 ( ) ; } else if ( VAR_2 instanceof TYPE_5 ) { VAR_1 = <START> ( ( TYPE_4 ) V...
public Optional < TYPE_1 > METHOD_1 ( ) { TYPE_1 VAR_1 = null ; if ( VAR_2 instanceof TYPE_2 ) { VAR_1 = new TYPE_3 ( ( TYPE_2 ) VAR_2 ) . METHOD_2 ( ) . get ( ) ; } else if ( VAR_2 instanceof TYPE_4 ) { VAR_1 = ( ( TYPE_4 ) VAR_2 ) . METHOD_2 ( ) ; } else if ( VAR_2 instanceof TYPE_5 ) { VAR_1 = ( ( TYPE_5 ) VAR_2 ) ....
need flush
public void METHOD_1 ( ) throws InterruptedException { TYPE_1 VAR_1 = TYPE_2 . METHOD_2 ( VAR_2 ) . METHOD_3 ( TYPE_3 . class ) ; VAR_1 . METHOD_4 ( ) ; <START> TYPE_2 . METHOD_2 ( VAR_2 ) . METHOD_5 ( ) ; <END> }
public void METHOD_1 ( ) throws InterruptedException { TYPE_1 VAR_1 = TYPE_2 . METHOD_2 ( VAR_2 ) . METHOD_3 ( TYPE_3 . class ) ; VAR_1 . METHOD_4 ( ) ; }
declare function throws TYPE_2 instead - catch ? ( other functions similarly ) _CODE_ METHOD_3 throw
public void METHOD_1 ( ) { try { TYPE_1 . METHOD_2 ( null , VAR_1 [ 0 ] ) ; } catch ( TYPE_2 e ) { <START> METHOD_3 ( STRING_1 ) ; <END> } }
public void METHOD_1 ( ) { TYPE_1 . METHOD_2 ( null , VAR_1 [ 0 ] ) ; }
another minor note reason merge a single check ? ( values = = null || values isEmpty ( ) ) return true ;
private boolean METHOD_1 ( List < String > values ) { if ( values == null ) return true ; <START> if ( values . isEmpty ( ) ) return true ; <END> for ( String VAR_1 : values ) { if ( StringUtils . VAR_2 ( VAR_1 ) ) return true ; } return false ; }
private boolean METHOD_1 ( List < String > values ) { if ( values == null || values . isEmpty ( ) ) return true ; for ( String VAR_1 : values ) { if ( StringUtils . VAR_2 ( VAR_1 ) ) return true ; } return false ; }
+ _CODE_ return type
<START> public static < T > TYPE_1 < T > METHOD_1 ( ANNOTATION_1 Optional < T > VAR_1 ) { <END> TYPE_2 . METHOD_2 ( VAR_1 , STRING_1 ) ; return VAR_1 . map ( TYPE_1 : : METHOD_3 ) . METHOD_4 ( TYPE_1 : : empty ) ; }
public static < T > TYPE_1 < ANNOTATION_1 T > METHOD_1 ( ANNOTATION_1 Optional < T > VAR_1 ) { TYPE_2 . METHOD_2 ( VAR_1 , STRING_1 ) ; return VAR_1 . map ( TYPE_1 : : METHOD_3 ) . METHOD_4 ( TYPE_1 : : empty ) ; }
unused
private static Map < TYPE_1 , TYPE_2 > METHOD_1 ( TYPE_3 < ? , ? > run ) { <START> TYPE_4 < ? , ? > build = null ; <END> if ( run instanceof TYPE_4 ) return ( ( TYPE_4 ) run ) . METHOD_1 ( ( TYPE_4 ) run ) ; else return TYPE_5 . METHOD_2 ( ) ; }
private static Map < TYPE_1 , TYPE_2 > METHOD_1 ( TYPE_3 < ? , ? > run ) { if ( run instanceof TYPE_4 ) return ( ( TYPE_4 ) run ) . METHOD_1 ( ( TYPE_4 ) run ) ; else return TYPE_5 . METHOD_2 ( ) ; }
cast
public void METHOD_1 ( TYPE_1 < TYPE_2 < ? extends TYPE_3 , ? extends TYPE_4 > > VAR_1 ) throws TYPE_5 { <START> for ( Object VAR_2 : VAR_1 ) { <END> TYPE_2 event = ( TYPE_2 ) VAR_2 ; Assert . assertEquals ( TYPE_6 . VAR_4 , event . VAR_5 ( ) ) ; this . VAR_6 . METHOD_2 ( ) ; event . getKey ( ) ; if ( event . VAR_7 ( )...
public void METHOD_1 ( TYPE_1 < TYPE_2 < ? extends TYPE_3 , ? extends TYPE_4 > > VAR_1 ) throws TYPE_5 { for ( TYPE_2 < ? extends TYPE_3 , ? extends TYPE_4 > event : VAR_1 ) { Assert . assertEquals ( TYPE_6 . VAR_4 , event . VAR_5 ( ) ) ; this . VAR_6 . METHOD_2 ( ) ; if ( event . VAR_7 ( ) ) { event . VAR_8 ( ) ; } } ...
attribute required d reporting incorrect metadata work a test fixture problem
TYPE_4 ( String name , TYPE_1 type , TYPE_2 VAR_2 ) { <START> this . VAR_3 = new TYPE_3 ( name , type , true ) <END> . METHOD_1 ( VAR_2 ) . METHOD_2 ( TYPE_5 . VAR_5 ) . build ( ) ; }
TYPE_4 ( String name , TYPE_1 type , TYPE_2 VAR_2 ) { this . VAR_3 = new TYPE_3 ( name , type ) . METHOD_1 ( VAR_2 ) . METHOD_2 ( TYPE_5 . VAR_5 ) . build ( ) ; }
I ( ) stay java 6 syntax
TYPE_1 < TYPE_2 > METHOD_1 ( TYPE_3 VAR_1 ) { if ( VAR_1 != null ) { <START> return new TYPE_4 < > ( Collections . VAR_2 ( new TYPE_2 ( ) ) , VAR_1 , 1 ) ; <END> } return new TYPE_4 < > ( Collections . VAR_3 ( ) , VAR_1 , 0 ) ; }
TYPE_1 < TYPE_2 > METHOD_1 ( TYPE_3 VAR_1 ) { if ( VAR_1 != null ) { return new TYPE_4 < TYPE_2 > ( Collections . VAR_2 ( new TYPE_2 ( ) ) , VAR_1 , 1 ) ; } return new TYPE_4 < TYPE_2 > ( Collections . VAR_3 ( ) , VAR_1 , 0 ) ; }
combine lines return String
public String METHOD_1 ( ) { String VAR_1 = VAR_2 . METHOD_2 ( STRING_1 ) ; <START> return VAR_1 ; <END> }
public String METHOD_1 ( ) { return VAR_2 . METHOD_2 ( STRING_1 ) ; }
account instead accoun
public TYPE_1 METHOD_1 ( ) { TYPE_1 VAR_1 = new TYPE_1 ( ) ; VAR_1 . METHOD_2 ( TYPE_2 . VAR_3 ) ; VAR_1 . METHOD_3 ( STRING_1 ) ; <START> VAR_1 . METHOD_4 ( STRING_2 ) ; <END> VAR_1 . METHOD_5 ( Integer . VAR_4 . getName ( ) ) ; VAR_1 . METHOD_6 ( STRING_3 ) ; return VAR_1 ; }
public TYPE_1 METHOD_1 ( ) { TYPE_1 VAR_1 = new TYPE_1 ( ) ; VAR_1 . METHOD_2 ( TYPE_2 . VAR_3 ) ; VAR_1 . METHOD_3 ( STRING_1 ) ; VAR_1 . METHOD_4 ( STRING_3 ) ; VAR_1 . METHOD_5 ( Integer . VAR_4 . getName ( ) ) ; VAR_1 . METHOD_6 ( STRING_3 ) ; return VAR_1 ; }
VAR_1 METHOD_3 ( new TYPE_2 ( ) ) ; / /
private TYPE_1 METHOD_1 ( TYPE_1 parent ) { TYPE_1 VAR_1 = new TYPE_1 ( ) ; VAR_1 . METHOD_2 ( parent . getId ( ) ) ; <START> VAR_1 . METHOD_3 ( new TYPE_2 ( ) ) ; <END> if ( parent . VAR_2 ( ) ) { VAR_1 . METHOD_4 ( ) . METHOD_2 ( parent . VAR_3 ( ) . getId ( ) ) ; } return VAR_1 ; }
private TYPE_1 METHOD_1 ( TYPE_1 parent ) { TYPE_1 VAR_1 = new TYPE_1 ( ) ; VAR_1 . METHOD_2 ( parent . getId ( ) ) ; if ( parent . VAR_2 ( ) ) { VAR_1 . METHOD_3 ( new TYPE_2 ( ) ) ; VAR_1 . METHOD_4 ( ) . METHOD_2 ( parent . VAR_3 ( ) . getId ( ) ) ; } return VAR_1 ; }
synchronized
public boolean METHOD_1 ( ) { final boolean VAR_1 = <START> VAR_2 . size ( ) <END> > 0 ; return VAR_1 ; }
public boolean METHOD_1 ( ) { synchronized ( VAR_2 ) { final boolean VAR_1 = VAR_2 . size ( ) > 0 ; return VAR_1 ; } }
reason longer version ? EDIT : hibernate String METHOD_1 java 8
public static String METHOD_1 ( String [ ] VAR_1 ) { StringBuilder sb = new StringBuilder ( ) ; boolean VAR_2 = true ; for ( String s : VAR_1 ) { if ( VAR_2 ) { VAR_2 = false ; } else { sb . append ( CHAR_1 ) ; } sb . append ( s ) ; } <START> return sb . toString ( ) ; <END> }
public static String METHOD_1 ( String [ ] VAR_1 ) { return METHOD_1 ( Arrays . asList ( VAR_1 ) ) ; }
I imagine synchronized keyword move init private situation want locked externally
<START> public synchronized void METHOD_1 ( ) { <END> VAR_1 = true ; VAR_2 = TYPE_1 . METHOD_2 ( VAR_2 ) ; }
private void METHOD_1 ( ) { VAR_1 = true ; VAR_2 = TYPE_1 . METHOD_2 ( VAR_2 ) ; }
! [ MINOR ] ( severity : MINOR ) returns a string s need call toString ( ) [ ! [ rule ] ( ) ] ( )
private String METHOD_1 ( String VAR_1 ) throws TYPE_1 { String VAR_2 = null ; TYPE_2 VAR_3 = new TYPE_2 ( ) ; VAR_3 . METHOD_2 ( VAR_4 ) ; VAR_3 . METHOD_3 ( VAR_1 ) ; List < Map < String , String > > result = VAR_3 . METHOD_4 ( ) ; if ( ! result . isEmpty ( ) ) { <START> VAR_2 = result . get ( 0 ) . get ( STRING_1 ) ...
private String METHOD_1 ( String VAR_1 ) throws TYPE_1 { String VAR_2 = null ; TYPE_2 VAR_3 = new TYPE_2 ( ) ; VAR_3 . METHOD_2 ( VAR_4 ) ; VAR_3 . METHOD_3 ( VAR_1 ) ; List < Map < String , String > > result = VAR_3 . METHOD_4 ( ) ; if ( ! result . isEmpty ( ) ) { VAR_2 = result . get ( 0 ) . get ( STRING_1 ) ; } retu...
call _CODE_ _CODE_ ( ) method ? _CODE_ ( ) method aslo request canceling
<START> public void METHOD_1 ( ) { <END> synchronized ( VAR_1 ) { for ( TYPE_1 VAR_2 : VAR_1 ) { VAR_2 . METHOD_2 ( ) ; } VAR_1 . clear ( ) ; } METHOD_3 ( ) ; }
public void METHOD_1 ( ) { METHOD_3 ( ) ; }
shouldn t set token null ? a token succesfully closed link deleted shouldn t references
public boolean commit ( ) { if ( VAR_1 != null ) { METHOD_1 ( ) ; throw new IllegalStateException ( TYPE_1 . format ( TYPE_2 . get ( ) . VAR_2 , VAR_3 ) ) ; } METHOD_2 ( ) ; try { TYPE_3 . METHOD_3 ( VAR_4 , VAR_3 , TYPE_4 . VAR_6 ) ; VAR_7 = false ; <START> token . close ( ) ; <END> return true ; } catch ( IOException...
public boolean commit ( ) { if ( VAR_1 != null ) { METHOD_1 ( ) ; throw new IllegalStateException ( TYPE_1 . format ( TYPE_2 . get ( ) . VAR_2 , VAR_3 ) ) ; } METHOD_2 ( ) ; try { TYPE_3 . METHOD_3 ( VAR_4 , VAR_3 , TYPE_4 . VAR_6 ) ; VAR_7 = false ; token . close ( ) ; token = null ; return true ; } catch ( IOExceptio...
don t need properties don t exist apply
public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { TYPE_1 VAR_2 = new TYPE_1 ( ) ; VAR_2 . METHOD_2 ( STRING_1 ) ; VAR_2 . METHOD_2 ( STRING_2 ) ; <START> VAR_2 . METHOD_2 ( STRING_3 ) ; <END> VAR_2 . METHOD_3 ( STRING_4 , STRING_5 + TYPE_3 . VAR_4 ) ; VAR_2 . METHOD_4 ( ) ; return VAR_2 ; }
public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { TYPE_1 VAR_2 = new TYPE_1 ( ) ; VAR_2 . METHOD_2 ( STRING_1 ) ; VAR_2 . METHOD_2 ( STRING_2 ) ; return VAR_2 ; }
I don t method
public TYPE_3 . TYPE_4 . VAR_1 . VAR_2 . VAR_3 . VAR_4 . TYPE_5 METHOD_1 ( <START> TYPE_3 . TYPE_4 . VAR_1 . VAR_2 . VAR_3 . VAR_4 . TYPE_6 VAR_7 ) { <END> LOG . info ( STRING_1 ) ; TYPE_2 VAR_8 = new TYPE_2 ( ) ; return VAR_8 . METHOD_1 ( VAR_7 ) ; }
public TYPE_3 . TYPE_4 . VAR_1 . VAR_2 . VAR_3 . VAR_4 . TYPE_5 METHOD_1 ( TYPE_3 . TYPE_4 . VAR_1 . VAR_2 . VAR_3 . VAR_4 . TYPE_6 VAR_7 ) { LOG . trace ( STRING_1 ) ; TYPE_2 VAR_8 = new TYPE_2 ( ) ; return VAR_8 . METHOD_1 ( VAR_7 ) ; }
synchronization issue
<START> void remove ( TYPE_1 VAR_1 ) { <END> if ( VAR_2 != null ) { VAR_2 . remove ( VAR_1 ) ; } }
synchronized void remove ( TYPE_1 VAR_1 ) { if ( VAR_2 != null ) { VAR_2 . remove ( VAR_1 ) ; } }
return condition s
private boolean METHOD_1 ( TYPE_1 VAR_1 , TYPE_1 VAR_2 ) { <START> if <END> ( VAR_1 . METHOD_2 ( VAR_3 ) <= 0 && VAR_2 . METHOD_2 ( VAR_4 ) >= 0 ) { return true ; } return false ; }
private boolean METHOD_1 ( TYPE_1 VAR_1 , TYPE_1 VAR_2 ) { return VAR_1 . METHOD_2 ( VAR_3 ) <= 0 && VAR_2 . METHOD_2 ( VAR_4 ) >= 0 ; }
missing semicolon ;
public void VAR_1 ( ) { <START> VAR_2 ( STRING_1 , STRING_2 ) <END> }
public void VAR_1 ( ) { VAR_2 ( STRING_1 , STRING_2 ) ; }
VAR_2 METHOD_4 ( 1 ) ( equal 2 ) I misunderstand
ANNOTATION_1 public void METHOD_1 ( ) { assertThat ( METHOD_2 ( TYPE_1 . class ) , METHOD_3 ( 2 ) ) ; <START> assertThat ( TYPE_2 . VAR_2 , METHOD_4 ( 0 ) ) ; <END> }
ANNOTATION_1 public void METHOD_1 ( ) { assertThat ( METHOD_2 ( TYPE_1 . class ) , METHOD_3 ( 2 ) ) ; assertThat ( TYPE_2 . VAR_2 , METHOD_4 ( 1 ) ) ; }
needed
private void METHOD_1 ( final long VAR_1 , final Status status ) throws InterruptedException , TYPE_1 { TYPE_2 . METHOD_2 ( STRING_1 , ( ) - > { try { return VAR_2 . getStatus ( VAR_1 ) . getStatus ( ) == status ; } catch ( Exception e ) { TYPE_3 . METHOD_3 ( e ) ; } return null ; <START> } , TYPE_4 . METHOD_4 ( ) . ME...
private void METHOD_1 ( final long VAR_1 , final Status status ) throws InterruptedException , TYPE_1 { TYPE_2 . METHOD_2 ( STRING_1 , ( ) - > { try { return VAR_2 . getStatus ( VAR_1 ) . getStatus ( ) == status ; } catch ( Exception e ) { TYPE_3 . METHOD_3 ( e ) ; } return null ; } , TYPE_4 . METHOD_4 ( ) . METHOD_6 (...
message operator supported secondary index enabled check creating predicate ( done file operator ) : ( args index = = _CODE_ DISABLED ) { throw error ( secondary index enabled message : + text ) ; }
public TYPE_1 < TYPE_2 > message ( String text ) { <START> return new TYPE_3 ( args . VAR_1 , args . VAR_2 , args . index , text ) ; <END> }
public TYPE_1 < TYPE_2 > message ( String text ) { return new TYPE_3 ( args . VAR_1 , args . index , text ) ; }
other setters class void
public <START> boolean METHOD_1 ( boolean <END> VAR_1 ) { return this . VAR_1 = VAR_1 ; }
public void METHOD_1 ( boolean VAR_1 ) { this . VAR_1 = VAR_1 ; }
edge : toll = yestoll : hgv = _CODE_ result TYPE_6 VAR_8 TYPE_6 VAR_7
public TYPE_1 METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 , TYPE_4 . TYPE_5 VAR_3 , long VAR_4 ) { if ( VAR_2 . METHOD_2 ( STRING_1 , STRING_2 ) ) VAR_5 . METHOD_3 ( false , VAR_1 , TYPE_6 . VAR_7 ) ; if ( VAR_2 . METHOD_2 ( STRING_3 , STRING_2 ) ) <START> VAR_5 . METHOD_3 ( false , VAR_1 , TYPE_6 . VAR_8 ) ; <END> return V...
public TYPE_1 METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 , TYPE_4 . TYPE_5 VAR_3 , long VAR_4 ) { if ( VAR_2 . METHOD_2 ( STRING_1 , STRING_2 ) ) VAR_5 . METHOD_3 ( false , VAR_1 , TYPE_6 . VAR_7 ) ; else if ( VAR_2 . METHOD_2 ( STRING_3 , STRING_2 ) ) VAR_5 . METHOD_3 ( false , VAR_1 , TYPE_6 . VAR_8 ) ; return VAR_1 ; }
fix formatter settings please disable : wink :
<START> @Override public boolean METHOD_1 ( ) <END> { return false ; }
public boolean METHOD_1 ( ) { return false ; }
doesn t matter : javareturn new byte [ ] { ( byte ) ( val > > > INT_3 ) ( byte ) ( val > > > INT_2 ) ( byte ) ( val > > > INT_1 ) ( byte ) val } ;
byte [ ] METHOD_1 ( int val ) { byte [ ] b = new byte [ 4 ] ; b [ 3 ] = ( byte ) ( val ) ; b [ 2 ] = ( byte ) ( val > > > INT_1 ) ; b [ 1 ] = ( byte ) ( val > > > INT_2 ) ; b [ 0 ] = ( byte ) ( val > > > INT_3 ) ; <START> return b ; <END> }
byte [ ] METHOD_1 ( int val ) { return new byte [ ] { ( byte ) ( val > > > INT_3 ) , ( byte ) ( val > > > INT_2 ) , ( byte ) ( val > > > INT_1 ) , ( byte ) ( val ) } ; }
useful method _CODE_
<START> protected int <END> METHOD_1 ( String VAR_1 , TYPE_1 VAR_2 , TYPE_2 VAR_3 , TYPE_3 text ) { int VAR_4 = VAR_3 . METHOD_2 ( ) ; if ( VAR_1 != null && ! VAR_1 . isEmpty ( ) ) { TYPE_4 VAR_5 = new TYPE_4 ( VAR_6 , VAR_7 ) ; String VAR_8 = VAR_5 . get ( VAR_2 , VAR_1 , String . VAR_9 ) ; VAR_4 = METHOD_1 ( VAR_8 , ...
private int METHOD_1 ( String VAR_1 , TYPE_1 VAR_2 , TYPE_2 VAR_3 , TYPE_3 text ) { int VAR_4 = VAR_3 . METHOD_2 ( ) ; if ( VAR_1 != null && ! VAR_1 . isEmpty ( ) ) { TYPE_4 VAR_5 = new TYPE_4 ( VAR_6 , VAR_7 ) ; String VAR_8 = VAR_5 . get ( VAR_2 , VAR_1 , String . VAR_9 ) ; VAR_4 = METHOD_1 ( VAR_8 , VAR_4 , text ) ;...
variable declaration return VAR_1 METHOD_2 ( ) METHOD_3 ( ) ;
private static TYPE_1 METHOD_1 ( Class < ? extends TYPE_1 > VAR_1 ) { TYPE_1 VAR_2 ; try { <START> VAR_2 = VAR_1 . METHOD_2 ( ) . METHOD_3 ( ) ; <END> } catch ( TYPE_2 e ) { throw new IllegalStateException ( STRING_1 + VAR_1 + STRING_2 , e ) ; } return VAR_2 ; }
private static TYPE_1 METHOD_1 ( Class < ? extends TYPE_1 > VAR_1 ) { try { return VAR_1 . METHOD_2 ( ) . METHOD_3 ( ) ; } catch ( TYPE_2 e ) { throw new IllegalStateException ( STRING_1 + VAR_1 + STRING_2 , e ) ; } }