ReviewComments
stringlengths
1
2.35k
OriginalCode
stringlengths
28
487
ReviewedCode
stringlengths
14
463
modifier private redundant enum constructor - needs removed
<START> private VAR_1 ( String VAR_2 ) { <END> this . VAR_2 = VAR_2 ; }
VAR_1 ( String VAR_2 ) { this . VAR_2 = VAR_2 ; }
need +
public TYPE_1 append ( final boolean VAR_1 , final boolean VAR_2 ) { if ( VAR_3 != 0 ) { return this ; } if ( VAR_1 == VAR_2 ) { return this ; } if ( VAR_1 ) { <START> VAR_3 = + 1 ; <END> } else { VAR_3 = - 1 ; } return this ; }
public TYPE_1 append ( final boolean VAR_1 , final boolean VAR_2 ) { if ( VAR_3 != 0 ) { return this ; } if ( VAR_1 == VAR_2 ) { return this ; } if ( VAR_1 ) { VAR_3 = 1 ; } else { VAR_3 = - 1 ; } return this ; }
pretty impact performance change
<START> private TYPE_1 METHOD_1 ( TYPE_1 node ) { <END> TYPE_1 VAR_1 = ( TYPE_1 ) node . VAR_2 ( this ) ; while ( ! node . equals ( VAR_1 ) ) { node = VAR_1 ; VAR_1 = ( TYPE_1 ) node . VAR_2 ( this ) ; } return node ; }
private TYPE_1 METHOD_1 ( TYPE_1 node ) { TYPE_1 VAR_1 = ( TYPE_1 ) node . VAR_2 ( this ) ; while ( node != VAR_1 ) { node = VAR_1 ; VAR_1 = ( TYPE_1 ) node . VAR_2 ( this ) ; } return node ; }
variable s bounds check TYPE_1 METHOD_1 ( VAR_2 ) discard return ( IDE show a warning unused variable ? want turn general please avoid introducing new warnings avoided ( avoided ; example _CODE_ derives _CODE_ technically public API API tooling a warning s suppress ) )
public TYPE_3 ( int VAR_2 ) { try { <START> TYPE_1 s = TYPE_1 . METHOD_1 ( VAR_2 ) ; <END> value = VAR_2 ; VAR_3 = true ; } catch ( IllegalArgumentException e ) { try { TYPE_2 c = TYPE_2 . METHOD_1 ( VAR_2 ) ; value = VAR_2 ; VAR_3 = false ; } catch ( IllegalArgumentException y ) { throw new IllegalArgumentException ( STRING_1 ) ; } } }
public TYPE_3 ( int VAR_2 ) { try { TYPE_1 . METHOD_1 ( VAR_2 ) ; value = VAR_2 ; VAR_3 = true ; } catch ( IllegalArgumentException e ) { try { TYPE_2 . METHOD_1 ( VAR_2 ) ; value = VAR_2 ; VAR_3 = false ; } catch ( IllegalArgumentException y ) { throw new IllegalArgumentException ( STRING_1 ) ; } } }
returning true result yield true meaning instance s type METHOD_3 type a type filter included matter result unconditional filters
private boolean METHOD_1 ( TYPE_1 instance ) { for ( String type : this . VAR_1 . keySet ( ) ) { if ( METHOD_2 ( instance . VAR_2 ( ) , type ) ) { for ( TYPE_2 VAR_3 : this . VAR_1 . get ( type ) ) { if ( VAR_3 . METHOD_3 ( instance ) ) return true ; } return false ; } } <START> return true ; <END> }
private boolean METHOD_1 ( TYPE_1 instance ) { for ( String type : this . VAR_1 . keySet ( ) ) { if ( METHOD_2 ( instance . VAR_2 ( ) , type ) ) { for ( TYPE_2 VAR_3 : this . VAR_1 . get ( type ) ) { if ( VAR_3 . METHOD_3 ( instance ) ) return true ; } return false ; } } return false ; }
synchronized void didn t run mvn clean package making change else compiler caught travis error
<START> public void synchronized VAR_1 ( TYPE_1 ctx ) { <END> VAR_3 ( ctx ) ; }
public synchronized void VAR_1 ( TYPE_1 ctx ) { VAR_3 ( ctx ) ; }
strictly necessary ( ) throw s VAR_1 content
public void METHOD_1 ( ) throws IOException { TYPE_1 row = METHOD_2 ( STRING_1 ) ; Optional < TYPE_2 > VAR_1 = VAR_2 . METHOD_3 ( row ) ; <START> assertTrue ( VAR_1 . isPresent ( ) ) ; <END> TYPE_2 content = VAR_1 . get ( ) ; TYPE_3 VAR_3 = ( TYPE_3 ) content ; METHOD_4 ( VAR_3 . METHOD_5 ( ) ) ; }
public void METHOD_1 ( ) throws IOException { TYPE_1 row = METHOD_2 ( STRING_1 ) ; Optional < TYPE_2 > VAR_1 = VAR_2 . METHOD_3 ( row ) ; TYPE_2 content = VAR_1 . get ( ) ; TYPE_3 VAR_3 = ( TYPE_3 ) content ; METHOD_4 ( VAR_3 . METHOD_5 ( ) ) ; }
map defined base class
public TYPE_1 list ( ) { TYPE_1 VAR_1 = new TYPE_1 ( ) ; Set < TYPE_2 > VAR_2 = TYPE_3 . METHOD_1 ( this , version ) ; VAR_2 . forEach ( VAR_3 - > { org . VAR_4 . VAR_5 . VAR_6 . model . TYPE_5 VAR_8 = <START> METHOD_2 ( TYPE_4 . map ( VAR_3 , <END> null ) ) ; VAR_1 . METHOD_1 ( ) . add ( VAR_8 ) ; } ) ; return VAR_1 ; }
public TYPE_1 list ( ) { TYPE_1 VAR_1 = new TYPE_1 ( ) ; Set < TYPE_2 > VAR_2 = TYPE_3 . METHOD_1 ( this , version ) ; VAR_2 . forEach ( VAR_3 - > { org . VAR_4 . VAR_5 . VAR_6 . model . TYPE_5 VAR_8 = METHOD_2 ( map ( VAR_3 , null ) ) ; VAR_1 . METHOD_1 ( ) . add ( VAR_8 ) ; } ) ; return VAR_1 ; }
remove
public TYPE_1 METHOD_1 ( Optional < TYPE_2 > VAR_1 ) { TYPE_1 VAR_2 = METHOD_2 ( VAR_1 ) ; if ( VAR_2 . METHOD_3 ( ) ) { <START> session . VAR_3 ( ) . log ( ( ) - > STRING_1 ) ; <END> VAR_2 . METHOD_4 ( session . VAR_3 ( ) . METHOD_5 ( ) ) ; VAR_4 . METHOD_6 ( Optional . empty ( ) , Optional . of ( VAR_2 ) ) ; } return VAR_2 ; }
public TYPE_1 METHOD_1 ( Optional < TYPE_2 > VAR_1 ) { TYPE_1 VAR_2 = METHOD_2 ( VAR_1 ) ; if ( VAR_2 . METHOD_3 ( ) ) { VAR_2 . METHOD_4 ( session . VAR_3 ( ) . METHOD_5 ( ) ) ; VAR_4 . METHOD_6 ( Optional . empty ( ) , Optional . of ( VAR_2 ) ) ; } return VAR_2 ; }
VAR_4 isEmpty ( )
public Object execute ( TYPE_1 event ) { TYPE_2 VAR_1 = new TYPE_2 ( TYPE_3 . METHOD_1 ( ) . METHOD_2 ( ) , Messages . TYPE_6 , Messages . TYPE_7 , "" , new TYPE_4 ( ) { @Override public String METHOD_3 ( String VAR_4 ) { <START> if ( "" . equals ( VAR_4 ) ) { <END> return Messages . TYPE_8 ; } return null ; } } ) ; if ( VAR_1 . METHOD_4 ( ) == TYPE_5 . VAR_7 ) { METHOD_5 ( VAR_1 . getValue ( ) ) ; } return null ; }
public Object execute ( TYPE_1 event ) { TYPE_2 VAR_1 = new TYPE_2 ( TYPE_3 . METHOD_1 ( ) . METHOD_2 ( ) , Messages . TYPE_6 , Messages . TYPE_7 , "" , new TYPE_4 ( ) { @Override public String METHOD_3 ( String VAR_4 ) { if ( VAR_4 . isEmpty ( ) ) { return Messages . TYPE_8 ; } return null ; } } ) ; if ( VAR_1 . METHOD_4 ( ) == TYPE_5 . VAR_7 ) { METHOD_5 ( VAR_1 . getValue ( ) ) ; } return null ; }
VAR_3 clear ( ) ; loop
public void METHOD_1 ( TYPE_1 < T > VAR_1 ) { for ( TYPE_1 < T > VAR_2 : VAR_3 ) { if ( VAR_2 != VAR_1 ) { VAR_2 . METHOD_2 ( ) ; } <START> VAR_3 . clear ( ) ; <END> } }
public void METHOD_1 ( TYPE_1 < T > VAR_1 ) { for ( TYPE_1 < T > VAR_2 : VAR_3 ) { if ( VAR_2 != VAR_1 ) { VAR_2 . METHOD_2 ( ) ; } } VAR_3 . clear ( ) ; }
nice chain configurable a field general more spring ( case spring filters ) implemented a List add filter places delegate other add new filters filters add ( 0 new _CODE_ ( ) ) ; WDYT
protected TYPE_1 METHOD_1 ( ) { TYPE_2 VAR_1 = VAR_2 . METHOD_2 ( ) ; TYPE_3 VAR_3 = VAR_1 . METHOD_3 ( ) ; File VAR_4 = VAR_1 . METHOD_4 ( ) ; <START> if ( VAR_1 . METHOD_5 ( ) ) { <END> return new TYPE_4 ( new TYPE_5 ( new TYPE_6 ( VAR_2 . getName ( ) , VAR_4 , VAR_3 ) ) , METHOD_6 ( ) ) ; } else { return new TYPE_6 ( VAR_2 . getName ( ) , VAR_4 , VAR_3 , METHOD_6 ( ) ) ; } }
protected TYPE_1 METHOD_1 ( ) { TYPE_2 VAR_1 = VAR_2 . METHOD_2 ( ) ; TYPE_3 VAR_3 = VAR_1 . METHOD_3 ( ) ; File VAR_4 = VAR_1 . METHOD_4 ( ) ; return new TYPE_6 ( VAR_2 . getName ( ) , VAR_4 , VAR_3 ) ; }
amazon implementation slightly google implementation happen gradle copy script doesn t execute properly building google variant - building project google build variants ( oba agencyx agencyy ) - generate amazon code push new version
public void METHOD_1 ( TYPE_1 VAR_1 ) { VAR_2 . METHOD_2 ( ) ; TYPE_2 status = VAR_3 . METHOD_3 ( VAR_1 ) ; <START> String VAR_4 = VAR_5 . METHOD_4 ( ) ; <END> if ( VAR_5 != null && VAR_5 . VAR_6 != null ) { TYPE_3 . start ( VAR_7 , status . VAR_8 ( ) , VAR_4 ) ; } else { TYPE_3 . start ( VAR_7 , status . VAR_8 ( ) ) ; } }
public void METHOD_1 ( TYPE_1 VAR_1 ) { VAR_2 . METHOD_2 ( ) ; TYPE_2 status = VAR_3 . METHOD_3 ( VAR_1 ) ; if ( VAR_5 != null && VAR_5 . METHOD_4 ( ) != null ) { TYPE_3 . start ( VAR_7 , status . VAR_8 ( ) , VAR_5 . METHOD_4 ( ) ) ; } else { TYPE_3 . start ( VAR_7 , status . VAR_8 ( ) ) ; } }
( factory null false false 1 ) add / remove a new parameter main constructor / needs a decision
public TYPE_2 ( TYPE_1 factory ) { <START> VAR_2 = factory ; <END> VAR_3 = null ; VAR_4 = false ; VAR_5 = false ; VAR_6 = 1 ; }
public TYPE_2 ( TYPE_1 factory ) { this ( factory , null , false , false , 1 , true , false ) ; }
I m need natural logarithmic logarithmic behaviour general ? case more efficient log2 I suppose write ( int ) ( Math log2 ( VAR_5 ) / VAR_3 ) + VAR_7
public int METHOD_1 ( TYPE_1 VAR_1 , TYPE_1 VAR_2 , int VAR_3 , int VAR_4 ) { double VAR_5 = VAR_2 . METHOD_2 ( ) / VAR_1 . METHOD_2 ( ) ; <START> final int i = ( int ) ( Math . log ( VAR_5 ) / Math . log ( Math . VAR_6 ( 2 , VAR_3 ) ) ) + VAR_7 ; <END> return i ; }
public int METHOD_1 ( TYPE_1 VAR_1 , TYPE_1 VAR_2 , int VAR_3 , int VAR_4 ) { double VAR_5 = VAR_2 . METHOD_2 ( ) / VAR_1 . METHOD_2 ( ) ; return ( int ) ( Math . log ( VAR_5 ) / Math . log ( Math . VAR_6 ( 2 , VAR_3 ) ) ) + VAR_7 ; }
_matcher_ reused multiple times - list doesn t
public TYPE_2 ( List < TYPE_1 > VAR_2 ) { <START> Collections . VAR_3 ( VAR_2 , VAR_4 ) ; <END> }
public TYPE_2 ( List < TYPE_1 > VAR_2 ) { VAR_4 = new ArrayList < > ( ) ; Collections . VAR_3 ( VAR_2 , VAR_4 ) ; }
VAR_1 empty point
public void METHOD_1 ( ) { <START> if ( VAR_1 . get ( 0 ) . METHOD_2 ( ) != null ) { <END> VAR_1 . add ( 0 , new TYPE_1 ( ) ) ; } }
public void METHOD_1 ( ) { if ( ( ! VAR_1 . isEmpty ( ) && VAR_1 . get ( 0 ) . METHOD_2 ( ) != null ) || VAR_1 . isEmpty ( ) ) { VAR_1 . add ( 0 , new TYPE_1 ( ) ) ; } }
new HashSet < > ( list ) size ( ) = = list size ( ) ;
public static boolean METHOD_1 ( List < String > VAR_1 ) { <START> return VAR_1 . stream ( ) . METHOD_2 ( new HashSet < > ( ) : : add ) ; <END> }
public static boolean METHOD_1 ( List < String > VAR_1 ) { return VAR_1 . size ( ) == new HashSet < > ( VAR_1 ) . size ( ) ; }
shouldn t METHOD_5 called VAR_1 control instead shell
private void METHOD_1 ( ) { VAR_1 . METHOD_2 ( ) ; VAR_1 . METHOD_3 ( ) . METHOD_2 ( ) ; <START> VAR_1 . METHOD_4 ( ) . METHOD_5 ( ) ; <END> }
private void METHOD_1 ( ) { VAR_1 . METHOD_2 ( ) ; VAR_1 . METHOD_3 ( ) . METHOD_2 ( ) ; VAR_1 . METHOD_5 ( ) ; }
switch statement more natural hereswitch ( VAR_1 ) { case VAR_3 : return VAR_4 ; case VAR_5 : return TYPE_1 METHOD_2 ( 0 VAR_6 ) METHOD_3 ( i - > i % 2 = = 0 ? METHOD_4 ( ) : null ) collect ( METHOD_5 ( ) ) ; default : return TYPE_1 METHOD_2 ( 0 VAR_6 ) METHOD_3 ( i - > METHOD_4 ( ) ) collect ( METHOD_5 ( ) ) ; }
protected final List < ? > METHOD_1 ( ) { <START> if ( VAR_1 == TYPE_2 . VAR_3 ) { <END> return VAR_4 ; } if ( VAR_1 == TYPE_2 . VAR_5 ) { return TYPE_1 . METHOD_2 ( 0 , VAR_6 ) . METHOD_3 ( i - > i % 2 == 0 ? METHOD_4 ( ) : null ) . collect ( METHOD_5 ( ) ) ; } return TYPE_1 . METHOD_2 ( 0 , VAR_6 ) . METHOD_3 ( i - > METHOD_4 ( ) ) . collect ( METHOD_5 ( ) ) ; }
protected final List < ? > METHOD_1 ( ) { switch ( VAR_1 ) { case VAR_3 : return VAR_4 ; case VAR_5 : return TYPE_1 . METHOD_2 ( 0 , VAR_6 ) . METHOD_3 ( i - > i % 2 == 0 ? METHOD_4 ( ) : null ) . collect ( METHOD_5 ( ) ) ; default : return TYPE_1 . METHOD_2 ( 0 , VAR_6 ) . METHOD_3 ( i - > METHOD_4 ( ) ) . collect ( METHOD_5 ( ) ) ; } }
( Object item : VAR_2 ) { VAR_3 add ( item ) ; } METHOD_3 ( VAR_3 ) ; - loop redundant reset VAR_2 set VAR_1
protected void METHOD_1 ( TYPE_1 VAR_1 ) { this . VAR_1 = VAR_1 ; TYPE_2 VAR_2 = METHOD_2 ( ) ; if ( VAR_2 == null ) { return ; } TYPE_2 VAR_3 = ( VAR_1 == null ) ? new ArrayList ( ) : new TYPE_3 ( VAR_1 ) ; for ( Object item : VAR_2 ) { <START> METHOD_3 ( VAR_3 ) ; <END> } }
protected void METHOD_1 ( TYPE_1 VAR_1 ) { if ( VAR_1 == this . VAR_1 ) { return ; } this . VAR_1 = VAR_1 ; TYPE_2 VAR_2 = METHOD_2 ( ) ; if ( VAR_2 == null ) { return ; } Collection VAR_3 = ( VAR_1 == null ) ? new ArrayList ( ) : new TYPE_3 ( VAR_1 ) ; for ( Object item : VAR_2 ) { VAR_3 . add ( item ) ; } METHOD_3 ( VAR_3 ) ; }
isEmpty ( ) alternatively don t check size loop run empty
public void METHOD_1 ( ) { super . METHOD_1 ( ) ; <START> if ( VAR_1 . size ( ) > 0 ) { <END> for ( TYPE_1 VAR_2 : VAR_1 ) { TYPE_2 VAR_3 = VAR_2 . METHOD_2 ( ) ; if ( VAR_3 != null ) { VAR_3 . METHOD_3 ( ) ; } VAR_2 . close ( ) ; } VAR_1 . clear ( ) ; } }
public void METHOD_1 ( ) { super . METHOD_1 ( ) ; if ( ! VAR_1 . isEmpty ( ) ) { for ( TYPE_1 VAR_2 : VAR_1 ) { TYPE_2 VAR_3 = VAR_2 . METHOD_2 ( ) ; if ( VAR_3 != null ) { VAR_3 . METHOD_3 ( ) ; } VAR_2 . close ( ) ; } VAR_1 . clear ( ) ; } }
ternary
private T METHOD_1 ( ) { <START> if ( VAR_1 . size ( ) == 1 ) { <END> return VAR_1 . iterator ( ) . next ( ) ; } return VAR_2 ; }
private T METHOD_1 ( ) { return VAR_1 . size ( ) == 1 ? VAR_1 . iterator ( ) . next ( ) : null ; }
need ? threadsafe
public TYPE_1 METHOD_1 ( ) { if ( metadata == null ) { <START> metadata = new TYPE_1 ( ) ; <END> } return metadata ; }
public synchronized TYPE_1 METHOD_1 ( ) { if ( metadata == null ) { metadata = new TYPE_1 ( ) ; } return metadata ; }
_CODE_ a weird ; inline variables VAR_4 ( )
public void METHOD_1 ( long VAR_1 , long VAR_2 ) { <START> long VAR_3 = VAR_4 . METHOD_2 ( VAR_1 ) ; <END> long VAR_5 = VAR_6 . METHOD_2 ( VAR_2 ) ; VAR_7 . METHOD_3 ( VAR_8 - > Math . max ( VAR_3 , VAR_8 ) ) ; VAR_9 . METHOD_3 ( VAR_8 - > Math . max ( VAR_5 , VAR_8 ) ) ; }
public void METHOD_1 ( long VAR_1 , long VAR_2 ) { VAR_4 . METHOD_2 ( VAR_1 ) ; VAR_6 . METHOD_2 ( VAR_2 ) ; VAR_7 . METHOD_3 ( VAR_8 - > Math . max ( VAR_4 . get ( ) , VAR_8 ) ) ; VAR_9 . METHOD_3 ( VAR_8 - > Math . max ( VAR_6 . get ( ) , VAR_8 ) ) ; }
[ ] ( start = 15 length = 4 ) please
public final Date METHOD_1 ( ) { <START> return this . VAR_1 ; <END> }
public final Date METHOD_1 ( ) { return VAR_1 ; }
constructor call
public TYPE_2 ( TYPE_1 VAR_2 , Path VAR_3 , String VAR_4 ) { this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; <START> this . VAR_5 = null ; <END> this . VAR_6 = null ; this . VAR_7 = true ; this . VAR_4 = VAR_4 ; }
public TYPE_2 ( TYPE_1 VAR_2 , Path VAR_3 , String VAR_4 ) { this ( VAR_2 , VAR_3 , null , null , true , VAR_4 ) ; }
existing object ids start 1 define VAR_2 / VAR_4 = 0 default safely : session VAR_1 ( VAR_2 ) || session VAR_3 ( VAR_4 )
public boolean METHOD_1 ( ) { if ( session . VAR_1 ( VAR_2 ) ) { return true ; } else { <START> return group != null && session . VAR_3 ( VAR_4 ) ; <END> } }
public boolean METHOD_1 ( ) { return ( session . VAR_1 ( VAR_2 ) || session . VAR_3 ( VAR_4 ) ) ; }
STRING_1 STRING_2 added STANDARD_ALIASES instead creating aliases
public String METHOD_1 ( TYPE_1 VAR_1 , boolean VAR_2 ) { VAR_1 . METHOD_2 ( STRING_1 , STRING_1 ) ; <START> VAR_1 . METHOD_2 ( STRING_2 , STRING_2 ) ; <END> return VAR_2 ? STRING_3 : STRING_4 ; }
public String METHOD_1 ( TYPE_1 VAR_1 , boolean VAR_2 ) { return VAR_2 ? STRING_3 : STRING_4 ; }
final
public List < TYPE_1 > METHOD_1 ( TYPE_2 VAR_1 , TYPE_3 VAR_2 ) { <START> List < TYPE_1 > result = VAR_3 . METHOD_2 ( ) <END> . METHOD_3 ( TYPE_1 . class ) . add ( TYPE_4 . METHOD_4 ( STRING_1 , VAR_1 ) ) . add ( TYPE_4 . METHOD_4 ( STRING_2 , VAR_2 ) ) . list ( ) ; return result == null ? new ArrayList < TYPE_1 > ( ) : result ; }
public List < TYPE_1 > METHOD_1 ( TYPE_2 VAR_1 , TYPE_3 VAR_2 ) { final List < TYPE_1 > result = VAR_3 . METHOD_2 ( ) . METHOD_3 ( TYPE_1 . class ) . add ( TYPE_4 . METHOD_4 ( STRING_1 , VAR_1 ) ) . add ( TYPE_4 . METHOD_4 ( STRING_2 , VAR_2 ) ) . list ( ) ; return result == null ? new ArrayList < TYPE_1 > ( ) : result ; }
double checking intent ? change odd
public static Boolean METHOD_1 ( TYPE_1 ctx , List VAR_1 , Object target ) { for ( Object VAR_2 : VAR_1 ) { Boolean r = METHOD_2 ( ctx , VAR_2 , target ) ; <START> if ( r != null && r ) return false ; <END> } return true ; }
public static Boolean METHOD_1 ( TYPE_1 ctx , List VAR_1 , Object target ) { for ( Object VAR_2 : VAR_1 ) { Boolean r = METHOD_2 ( ctx , VAR_2 , target ) ; if ( r == null || r ) return false ; } return true ; }
VAR_5 sense called VAR_1 getId ( ) beginning method : null wouldn t arrived code VAR_1 parameter meant - null
public Optional < TYPE_1 > METHOD_1 ( final TYPE_2 context , final TYPE_1 VAR_1 ) { METHOD_2 ( ) ; final TYPE_1 VAR_2 = VAR_3 . METHOD_3 ( VAR_1 . getId ( ) ) ; if ( VAR_2 != null ) { return Optional . of ( VAR_2 ) ; } else { if ( VAR_4 ) { throw new TYPE_3 ( STRING_1 + VAR_1 ) ; } else { <START> return Optional . VAR_5 ( VAR_1 ) ; <END> } } }
public TYPE_1 METHOD_1 ( final TYPE_2 context , final TYPE_1 VAR_1 ) { METHOD_2 ( ) ; final TYPE_1 VAR_2 = VAR_3 . METHOD_3 ( VAR_1 . getId ( ) ) ; if ( VAR_2 != null ) { return VAR_2 ; } else { if ( VAR_4 ) { throw new TYPE_3 ( STRING_1 + VAR_1 ) ; } else { return VAR_1 ; } } }
need check null ? I write return STRING_1 + VAR_1 +
public String toString ( ) { <START> return STRING_1 + ( VAR_1 == null ? STRING_2 : VAR_1 ) + <END> STRING_3 + ( VAR_2 == null ? STRING_2 : VAR_2 ) + STRING_4 + ( version == null ? STRING_2 : version ) + STRING_5 + ( VAR_3 == null ? STRING_2 : VAR_3 ) + STRING_6 + Long . toString ( VAR_4 ) + STRING_7 + ( VAR_5 == null ? STRING_2 : VAR_5 . toString ( ) ) + STRING_8 ; }
public String toString ( ) { return STRING_1 + VAR_1 + STRING_3 + VAR_2 + STRING_4 + version + STRING_5 + VAR_3 + STRING_6 + Long . toString ( VAR_4 ) + STRING_7 + VAR_5 + STRING_8 ; }
I move 2508 s
void METHOD_1 ( ) { final boolean VAR_1 = TYPE_1 . METHOD_2 ( ) . METHOD_3 ( TYPE_3 . VAR_3 ) ; if ( ! VAR_1 ) { METHOD_4 ( ) ; } else { <START> final int VAR_4 = Math . max ( 1 , TYPE_2 . METHOD_5 ( ) . METHOD_6 ( ) ) ; <END> METHOD_7 ( VAR_4 , ( ) - > METHOD_4 ( ) ) ; } }
void METHOD_1 ( ) { final boolean VAR_1 = TYPE_1 . METHOD_2 ( ) . METHOD_3 ( TYPE_3 . VAR_3 ) ; if ( ! VAR_1 ) { METHOD_4 ( ) ; } else { METHOD_7 ( ( ) - > METHOD_4 ( ) ) ; } }
change package - private access
<START> public String METHOD_1 ( ) { <END> return y ; }
String METHOD_1 ( ) { return y ; }
calls METHOD_3 a null VAR_2 delete call METHOD_3 ( build VAR_2 )
public void run ( ) { Object VAR_1 = METHOD_1 ( ) . METHOD_2 ( ) ; if ( VAR_1 instanceof TYPE_1 ) { TYPE_1 build = ( TYPE_1 ) VAR_1 ; if ( VAR_2 != null ) { METHOD_3 ( build , VAR_2 ) ; } else { <START> METHOD_3 ( build ) ; <END> } } else if ( VAR_1 instanceof TYPE_2 ) { TYPE_2 VAR_3 = ( TYPE_2 ) VAR_1 ; METHOD_3 ( VAR_3 . METHOD_4 ( ) ) ; } }
public void run ( ) { Object VAR_1 = METHOD_1 ( ) . METHOD_2 ( ) ; if ( VAR_1 instanceof TYPE_1 ) { TYPE_1 build = ( TYPE_1 ) VAR_1 ; METHOD_3 ( build ) ; } else if ( VAR_1 instanceof TYPE_2 ) { TYPE_2 VAR_3 = ( TYPE_2 ) VAR_1 ; METHOD_3 ( VAR_3 . METHOD_4 ( ) ) ; } }
changed ? logic
private boolean METHOD_1 ( TYPE_1 token ) { boolean result = false ; if ( ! VAR_1 ) { <START> result = METHOD_2 ( token ) && METHOD_3 ( token ) ; <END> } return result ; }
private boolean METHOD_1 ( TYPE_1 token ) { return ! VAR_1 && METHOD_2 ( token ) && METHOD_3 ( token ) ; }
rewrite a single boolean expression : javareturn TYPE_4 TYPE_3 && METHOD_2 ( ) VAR_3 ( ) &&
public boolean METHOD_1 ( String type , TYPE_1 uri , String VAR_1 ) { <START> boolean VAR_2 = true ; <END> VAR_2 &= TYPE_4 . TYPE_3 . toString ( ) . equalsIgnoreCase ( type ) ; VAR_2 &= METHOD_2 ( ) . METHOD_3 ( ) . equalsIgnoreCase ( uri . VAR_3 ( ) ) ; VAR_2 &= METHOD_2 ( ) . METHOD_4 ( ) . equalsIgnoreCase ( uri . VAR_4 ( ) ) ; return VAR_2 ; }
public boolean METHOD_1 ( String type , TYPE_1 uri , String VAR_1 ) { return TYPE_3 . equalsIgnoreCase ( type ) ; }
VAR_3 ! = null && VAR_3 METHOD_2 ( VAR_2 )
public static boolean METHOD_1 ( TYPE_1 VAR_1 , boolean VAR_2 , String in ) { TYPE_2 VAR_3 = TYPE_3 . get ( VAR_1 ) ; <START> return VAR_3 != null ? VAR_3 . METHOD_2 ( VAR_2 , in ) : false ; <END> }
public static boolean METHOD_1 ( TYPE_1 VAR_1 , boolean VAR_2 , String in ) { TYPE_2 VAR_3 = TYPE_3 . get ( VAR_1 ) ; return VAR_3 != null && VAR_3 . METHOD_2 ( VAR_2 , in ) ; }
point TYPE_1 protecting map synchronized methods
private TYPE_4 ( ) { <START> VAR_2 = new TYPE_1 < TYPE_2 , TYPE_3 > ( ) ; <END> }
private TYPE_4 ( ) { VAR_2 = new HashMap < TYPE_2 , TYPE_3 > ( ) ; }
want throw a _CODE_ ? thinking couldn t acquire METHOD_3 return running interceptor a noop method defines
public final Object METHOD_1 ( TYPE_1 ctx , TYPE_2 command ) throws Throwable { if ( ! VAR_1 ) { return METHOD_2 ( ctx , command ) ; } final Object key = command . getKey ( ) ; try { <START> VAR_2 . METHOD_3 ( key , true ) ; <END> return METHOD_2 ( ctx , command ) ; } finally { VAR_2 . METHOD_4 ( key ) ; } }
public final Object METHOD_1 ( TYPE_1 ctx , TYPE_2 command ) throws Throwable { if ( ! VAR_1 ) { return METHOD_2 ( ctx , command ) ; } final Object key = command . getKey ( ) ; if ( ! VAR_2 . METHOD_3 ( key , true ) ) { return null ; } try { return METHOD_2 ( ctx , command ) ; } finally { VAR_2 . METHOD_4 ( key ) ; } }
method need synchronized
<START> boolean METHOD_1 ( TYPE_1 VAR_1 ) { <END> return VAR_2 . contains ( VAR_1 ) && ! VAR_2 . METHOD_2 ( VAR_1 ) . VAR_3 . isEmpty ( ) ; }
synchronized boolean METHOD_1 ( TYPE_1 VAR_1 ) { return VAR_2 . contains ( VAR_1 ) && ! VAR_2 . METHOD_2 ( VAR_1 ) . VAR_3 . isEmpty ( ) ; }
question ( matter choise ) - don t prefer set ? _CODE_ null empty _CODE_ a null empty list - s problem
protected void METHOD_1 ( ) { List < TYPE_1 > VAR_1 = null ; if ( getParameters ( ) . METHOD_2 ( ) == null ) { VAR_1 = METHOD_3 ( ) . METHOD_4 ( getParameters ( ) . getId ( ) ) ; } else { VAR_1 = METHOD_3 ( ) . METHOD_5 ( getParameters ( ) . getId ( ) , getParameters ( ) . METHOD_2 ( ) ) ; } <START> if ( VAR_1 != null && VAR_1 . size ( ) > 0 ) { <END> METHOD_6 ( ) . METHOD_7 ( VAR_1 ) ; } }
protected void METHOD_1 ( ) { List < TYPE_1 > VAR_1 = null ; if ( getParameters ( ) . METHOD_2 ( ) == null ) { VAR_1 = METHOD_3 ( ) . METHOD_4 ( getParameters ( ) . getId ( ) ) ; } else { VAR_1 = METHOD_3 ( ) . METHOD_5 ( getParameters ( ) . getId ( ) , getParameters ( ) . METHOD_2 ( ) ) ; } METHOD_6 ( ) . METHOD_7 ( VAR_1 ) ; }
package - visible
<START> TYPE_1 METHOD_1 ( ) throws TYPE_2 { <END> Object VAR_1 = element . VAR_2 ( VAR_3 ) ; if ( VAR_1 instanceof TYPE_1 ) { return ( TYPE_1 ) VAR_1 ; } if ( VAR_1 instanceof TYPE_3 ) { return new TYPE_4 ( ( TYPE_3 ) VAR_1 ) ; } throw new TYPE_5 ( STRING_1 + element . VAR_4 ( ) + STRING_2 + TYPE_6 . VAR_6 + STRING_3 + TYPE_6 . VAR_7 + STRING_4 + TYPE_3 . class . getName ( ) + STRING_5 + VAR_1 . getClass ( ) . getName ( ) ) ; }
private TYPE_1 METHOD_1 ( ) throws TYPE_2 { Object VAR_1 = element . VAR_2 ( VAR_3 ) ; if ( VAR_1 instanceof TYPE_1 ) { return ( TYPE_1 ) VAR_1 ; } if ( VAR_1 instanceof TYPE_3 ) { return new TYPE_4 ( ( TYPE_3 ) VAR_1 ) ; } throw new TYPE_5 ( STRING_1 + element . VAR_4 ( ) + STRING_2 + TYPE_6 . VAR_6 + STRING_3 + TYPE_6 . VAR_7 + STRING_4 + TYPE_3 . class . getName ( ) + STRING_5 + VAR_1 . getClass ( ) . getName ( ) ) ; }
debug message useful
public < TYPE_1 > TYPE_1 METHOD_1 ( Long value , Class < TYPE_1 > type , TYPE_2 options ) { <START> log . debug ( STRING_1 ) ; <END> byte [ ] VAR_1 = ByteBuffer . VAR_2 ( Long . VAR_3 ) . METHOD_2 ( value ) . METHOD_3 ( ) ; return ( TYPE_1 ) new TYPE_3 ( VAR_1 ) ; }
public < TYPE_1 > TYPE_1 METHOD_1 ( Long value , Class < TYPE_1 > type , TYPE_2 options ) { byte [ ] VAR_1 = ByteBuffer . VAR_2 ( Long . VAR_3 ) . METHOD_2 ( value ) . METHOD_3 ( ) ; return ( TYPE_1 ) new TYPE_3 ( VAR_1 ) ; }
please add 2 1 7 - experimental
<START> public final < R > R METHOD_1 ( ANNOTATION_1 TYPE_1 < ? extends R > VAR_1 ) { <END> try { return TYPE_2 . METHOD_2 ( VAR_1 , STRING_1 ) . apply ( this ) ; } catch ( Throwable ex ) { TYPE_3 . METHOD_3 ( ex ) ; throw TYPE_4 . METHOD_4 ( ex ) ; } }
public final < R > R METHOD_1 ( ANNOTATION_1 TYPE_1 < ? extends R > VAR_1 ) { return TYPE_2 . METHOD_2 ( VAR_1 , STRING_1 ) . apply ( this ) ; }
a find / replace artifact ? semantically explicitly set 0 ( I imagine ve initialized please IDE / checkstyle )
public Object METHOD_1 ( TYPE_1 VAR_1 , int position ) { <START> int VAR_2 = VAR_3 ; <END> switch ( position ) { case VAR_3 : VAR_2 = R . id . VAR_4 ; break ; case VAR_5 : VAR_2 = R . id . VAR_6 ; break ; default : } return METHOD_2 ( ) . METHOD_3 ( VAR_2 ) ; }
public Object METHOD_1 ( TYPE_1 VAR_1 , int position ) { int VAR_2 ; switch ( position ) { case VAR_5 : VAR_2 = R . id . VAR_6 ; break ; case VAR_3 : default : VAR_2 = R . id . VAR_4 ; break ; } return METHOD_2 ( ) . METHOD_3 ( VAR_2 ) ; }
remove
public void METHOD_1 ( TYPE_1 uri , TYPE_2 configuration ) throws IOException { <START> this . VAR_1 . METHOD_1 ( uri , configuration ) ; <END> }
public void METHOD_1 ( TYPE_1 uri , TYPE_2 configuration ) throws IOException { VAR_1 . METHOD_1 ( uri , configuration ) ; }
System VAR_1 ( METHOD_2 ( args ) ) ;
public static void METHOD_1 ( String [ ] args ) { <START> int status = METHOD_2 ( args ) ; <END> System . VAR_1 ( status ) ; }
public static void METHOD_1 ( String [ ] args ) { System . VAR_1 ( METHOD_2 ( args ) ) ; }
done
public void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 writer ) throws TYPE_3 { <START> System . out . println ( writer . VAR_2 ( ) ) ; <END> }
public void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 writer ) throws TYPE_3 { }
changing behaviour I d separately
public List < ANNOTATION_1 TYPE_1 > METHOD_1 ( ) { <START> return TYPE_2 < ANNOTATION_1 TYPE_1 > METHOD_2 ( ) ; <END> }
public List < ANNOTATION_1 TYPE_1 > METHOD_1 ( ) { return null ; }
logic part message s unnecessary check headers suffice
public void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 message , int VAR_2 ) { boolean VAR_3 = false ; <START> for ( String VAR_4 : message . VAR_5 ( STRING_1 ) ) { <END> if ( VAR_4 . contains ( context . getString ( R . string . VAR_6 ) ) ) VAR_3 = true ; } VAR_7 . METHOD_1 ( VAR_1 , message , VAR_2 , VAR_3 ) ; }
public void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 message , int VAR_2 ) { VAR_7 . METHOD_1 ( VAR_1 , message , VAR_2 ) ; }
I m change intentional shouldn t a difference _CODE_ _CODE_ ( ) METHOD_2 ( ) abstract METHOD_3 ( ) called
public void METHOD_1 ( TYPE_1 trace ) { super . METHOD_1 ( trace ) ; METHOD_2 ( ) ; <START> METHOD_3 ( ) ; <END> }
public void METHOD_1 ( TYPE_1 trace ) { super . METHOD_1 ( trace ) ; METHOD_3 ( ) ; METHOD_2 ( ) ; }
useful method return a list hadoop jobs killed method caller print
<START> public static void METHOD_1 ( String VAR_1 , Logger log ) { <END> Set < String > VAR_2 = METHOD_2 ( VAR_1 , log ) ; log . info ( STRING_1 + VAR_2 ) ; for ( String VAR_3 : VAR_2 ) { try { METHOD_3 ( VAR_3 , log ) ; } catch ( Throwable t ) { log . warn ( STRING_2 + VAR_3 , t ) ; } } }
public static Set < String > METHOD_1 ( String VAR_1 , Logger log ) { Set < String > VAR_2 = METHOD_2 ( VAR_1 , log ) ; log . info ( STRING_1 + VAR_2 ) ; for ( String VAR_3 : VAR_2 ) { try { METHOD_3 ( VAR_3 , log ) ; } catch ( Throwable t ) { log . warn ( STRING_2 + VAR_3 , t ) ; } } return VAR_2 ; }
inheritance
public boolean equals ( Object o ) { if ( o == null ) { return false ; } if ( this == o ) { return true ; } <START> if ( ! ( this . getClass ( ) . equals ( o . getClass ( ) ) ) ) { <END> return false ; } TYPE_1 that = ( TYPE_1 ) o ; return TYPE_2 . METHOD_1 ( VAR_1 , that . VAR_1 ) ; }
public boolean equals ( Object o ) { if ( this == o ) { return true ; } if ( o == null || this . getClass ( ) != o . getClass ( ) ) { return false ; } TYPE_1 that = ( TYPE_1 ) o ; return TYPE_2 . METHOD_1 ( VAR_1 , that . VAR_1 ) ; }
need change some other tests ? VAR_5 METHOD_3
public void METHOD_1 ( ) { METHOD_2 ( ) ; METHOD_3 ( METHOD_4 ( VAR_1 ) ) ; VAR_2 . METHOD_5 ( VAR_1 , 0 ) ; <START> client . VAR_3 ( VAR_4 ) ; <END> TYPE_1 node = VAR_5 . METHOD_6 ( ) . iterator ( ) . next ( ) ; client . VAR_6 ( node , INT_1 ) ; assertEquals ( 0 , VAR_7 . METHOD_7 ( ) ) ; time . VAR_8 ( INT_1 ) ; assertEquals ( 1 , VAR_7 . METHOD_7 ( ) ) ; }
public void METHOD_1 ( ) { METHOD_2 ( ) ; METHOD_3 ( METHOD_4 ( VAR_1 ) ) ; VAR_2 . METHOD_5 ( VAR_1 , 0 ) ; TYPE_1 node = VAR_5 . METHOD_6 ( ) . iterator ( ) . next ( ) ; client . VAR_6 ( node , INT_1 ) ; assertEquals ( 0 , VAR_7 . METHOD_7 ( ) ) ; time . VAR_8 ( INT_1 ) ; assertEquals ( 1 , VAR_7 . METHOD_7 ( ) ) ; }
merge lines METHOD_1 return argument
public TYPE_3 ( TYPE_1 data ) { TYPE_2 . METHOD_1 ( data , STRING_1 ) ; <START> this . data = data ; <END> }
public TYPE_3 ( TYPE_1 data ) { this . data = TYPE_2 . METHOD_1 ( data , STRING_1 ) ; }
I clearer VAR_2 remove block I don t throwing IOException METHOD_3 done a problem linkedlist remove ( ) case VAR_1 close ( ) s block
public synchronized void METHOD_1 ( TYPE_1 VAR_1 ) { try { <START> VAR_2 . remove ( VAR_1 ) ; <END> VAR_1 . close ( ) ; } catch ( IOException VAR_3 ) { VAR_4 . VAR_5 . METHOD_2 ( VAR_1 , VAR_3 ) ; } finally { METHOD_3 ( ) ; } }
public synchronized void METHOD_1 ( TYPE_1 VAR_1 ) { VAR_2 . remove ( VAR_1 ) ; try { VAR_1 . close ( ) ; } catch ( IOException VAR_3 ) { VAR_4 . VAR_5 . METHOD_2 ( VAR_1 , VAR_3 ) ; } finally { METHOD_3 ( ) ; } }
display todo a search VAR_1 a bug _CODE_ code wrong
public List < TYPE_1 > METHOD_1 ( ) { <START> String VAR_1 = VAR_2 . METHOD_2 ( ) . METHOD_3 ( ) ; <END> List < TYPE_2 > VAR_3 = VAR_4 . METHOD_4 ( VAR_1 ) ; List < TYPE_1 > VAR_5 = new ArrayList < TYPE_1 > ( VAR_3 . size ( ) ) ; for ( TYPE_2 VAR_6 : VAR_3 ) { VAR_5 . add ( new TYPE_3 ( VAR_6 , this ) ) ; } return VAR_5 ; }
public List < TYPE_1 > METHOD_1 ( ) { String VAR_1 = VAR_2 . METHOD_2 ( ) . getId ( ) ; List < TYPE_2 > VAR_3 = VAR_4 . METHOD_4 ( VAR_1 ) ; List < TYPE_1 > VAR_5 = new ArrayList < TYPE_1 > ( VAR_3 . size ( ) ) ; for ( TYPE_2 VAR_6 : VAR_3 ) { VAR_5 . add ( new TYPE_3 ( VAR_6 , this ) ) ; } return VAR_5 ; }
point pass VAR_2 instead
protected TYPE_4 ( TYPE_1 item , TYPE_1 VAR_2 , Integer VAR_3 , TYPE_2 config ) { this . item = item ; this . VAR_3 = VAR_3 ; if ( config instanceof TYPE_3 ) { TYPE_3 VAR_4 = ( TYPE_3 ) config ; <START> VAR_4 . METHOD_1 ( item , VAR_2 ) ; <END> this . config = VAR_4 ; } else { this . config = config ; } }
protected TYPE_4 ( TYPE_1 item , TYPE_1 VAR_2 , Integer VAR_3 , TYPE_2 config ) { this . item = item ; this . VAR_3 = VAR_3 ; if ( config instanceof TYPE_3 ) { TYPE_3 VAR_4 = ( TYPE_3 ) config ; VAR_4 . METHOD_1 ( VAR_2 ) ; this . config = VAR_4 ; } else { this . config = config ; } }
consider replacing 96 - 97 block ( line 455 )
public static void METHOD_1 ( File source , File VAR_1 ) throws IOException { <START> try ( TYPE_1 in = new TYPE_2 ( source ) ) { <END> try ( TYPE_3 out = new TYPE_4 ( new TYPE_5 ( VAR_1 ) ) ) { METHOD_2 ( in , out ) ; } } }
public static void METHOD_1 ( File source , File VAR_1 ) throws IOException { try ( TYPE_1 in = new TYPE_2 ( source ) ; TYPE_3 out = new TYPE_4 ( new TYPE_5 ( VAR_1 ) ) ) { METHOD_2 ( in , out ) ; } }
set ( ) care simply return result set ( )
public TYPE_1 METHOD_1 ( TYPE_1 VAR_1 ) { VAR_1 . METHOD_2 ( this ) ; TYPE_2 list = this . VAR_2 ; <START> TYPE_1 VAR_3 = list . VAR_4 ( VAR_1 . METHOD_3 ( ) ) ; <END> list . set ( VAR_1 ) ; return VAR_3 ; }
public TYPE_1 METHOD_1 ( TYPE_1 VAR_1 ) { return this . VAR_2 . set ( VAR_1 ) ; }
call ( VAR_2 VAR_3 data null )
public TYPE_2 ( TYPE_1 VAR_2 , long VAR_3 , byte [ ] data ) { <START> this . VAR_2 = VAR_2 ; <END> this . VAR_3 = VAR_3 ; this . data = data ; this . VAR_4 = VAR_2 . VAR_5 ; }
public TYPE_2 ( TYPE_1 VAR_2 , long VAR_3 , byte [ ] data ) { this ( VAR_2 , VAR_3 , data , VAR_2 . VAR_5 ) ; }
parameter names
<START> public boolean METHOD_1 ( char VAR_1 , int VAR_2 ) { <END> if ( super . METHOD_1 ( VAR_1 , VAR_2 ) || ! VAR_3 ) { return true ; } else if ( TYPE_1 . METHOD_2 ( VAR_1 ) ) { this . METHOD_3 ( TYPE_2 . toString ( VAR_1 ) ) ; return true ; } else { return false ; } }
public boolean METHOD_1 ( char VAR_1 , int VAR_2 ) { if ( super . METHOD_1 ( VAR_1 , VAR_2 ) || ! VAR_3 ) return true ; else if ( TYPE_1 . METHOD_2 ( VAR_1 ) ) { this . METHOD_3 ( TYPE_2 . toString ( VAR_1 ) ) ; return true ; } else return false ; }
great return empty map instead null
Map < String , String > METHOD_1 ( ) throws TYPE_1 , TYPE_2 { Map < String , String > parameters ; try { parameters = TYPE_3 . METHOD_1 ( ) ; } catch ( IOException e ) { throw new TYPE_2 ( e ) ; } <START> return parameters ; <END> }
protected Map < String , String > METHOD_1 ( ) throws TYPE_1 , TYPE_2 { try { return TYPE_3 . METHOD_1 ( ) ; } catch ( IOException e ) { throw new TYPE_2 ( e ) ; } }
move METHOD_2 checks a separate line calling inline messy
public static TYPE_1 METHOD_1 ( TYPE_2 VAR_1 , List < TYPE_3 > VAR_2 ) { <START> TYPE_1 VAR_3 = new TYPE_1 ( METHOD_2 ( VAR_1 , STRING_1 ) , METHOD_2 ( VAR_2 , STRING_2 ) ) ; <END> VAR_3 . METHOD_3 ( ) ; return VAR_3 ; }
public static TYPE_1 METHOD_1 ( TYPE_2 VAR_1 , List < TYPE_3 > VAR_2 ) { METHOD_2 ( VAR_1 , STRING_1 ) ; METHOD_2 ( VAR_2 , STRING_2 ) ; TYPE_1 VAR_3 = new TYPE_1 ( VAR_1 , VAR_2 ) ; VAR_3 . METHOD_3 ( ) ; return VAR_3 ; }
inorg eclipse mylyn commons core TYPE_2 _CODE_ ( TYPE_3 )
public static TYPE_1 METHOD_1 ( ) { TYPE_2 < TYPE_1 > reader = new TYPE_2 < TYPE_1 > ( TYPE_6 . VAR_2 , STRING_1 , STRING_1 , TYPE_1 . class ) ; TYPE_3 status = reader . read ( ) ; if ( ! status . VAR_3 ( ) ) { <START> TYPE_4 . log ( status ) ; <END> } TYPE_1 VAR_4 = reader . VAR_5 ( ) ; if ( VAR_4 != null ) { return VAR_4 ; } return new TYPE_5 ( ) ; }
public static TYPE_1 METHOD_1 ( ) { TYPE_2 < TYPE_1 > reader = new TYPE_2 < TYPE_1 > ( TYPE_6 . VAR_2 , STRING_1 , STRING_1 , TYPE_1 . class ) ; reader . read ( ) ; TYPE_1 VAR_4 = reader . VAR_5 ( ) ; if ( VAR_4 != null ) { return VAR_4 ; } return new TYPE_5 ( ) ; }
s a _CODE_ buffer append ( message ) append ( STRING_1 ) ; PS : wrong ping
public void METHOD_1 ( String message ) { <START> buffer . append ( message + STRING_1 ) ; <END> }
public void METHOD_1 ( String message ) { buffer . append ( message ) . append ( STRING_1 ) ; }
a VAR_5 I 2 VAR_3 variant information added TYPE_1 _CODE_ : added _CODE_ - adds existing variant metric removing line starts work correctly
private void METHOD_1 ( final TYPE_1 VAR_1 , final String VAR_2 , final int VAR_3 , final Boolean VAR_4 , final String VAR_5 ) { final TYPE_2 VAR_6 = new TYPE_2 ( ) ; VAR_6 . METHOD_2 ( VAR_1 ) ; VAR_6 . METHOD_3 ( VAR_2 ) ; VAR_6 . METHOD_4 ( VAR_3 ) ; VAR_6 . METHOD_5 ( VAR_4 ) ; VAR_6 . METHOD_6 ( VAR_5 ) ; <START> VAR_1 . METHOD_7 ( ) . add ( VAR_6 ) ; <END> VAR_7 . METHOD_8 ( VAR_6 ) ; }
private void METHOD_1 ( final TYPE_1 VAR_1 , final String VAR_2 , final int VAR_3 , final Boolean VAR_4 , final String VAR_5 ) { final TYPE_2 VAR_6 = new TYPE_2 ( ) ; VAR_6 . METHOD_2 ( VAR_1 ) ; VAR_6 . METHOD_3 ( VAR_2 ) ; VAR_6 . METHOD_4 ( VAR_3 ) ; VAR_6 . METHOD_5 ( VAR_4 ) ; VAR_6 . METHOD_6 ( VAR_5 ) ; VAR_7 . METHOD_8 ( VAR_6 ) ; }
private
<START> public void METHOD_1 ( ) { <END> VAR_1 = new TYPE_1 ( ( TYPE_2 ) VAR_2 . METHOD_2 ( ) , this ) ; TYPE_3 VAR_3 = new TYPE_3 ( ) { @Override public void METHOD_3 ( Collection < ? extends TYPE_4 > VAR_4 ) { VAR_5 . METHOD_4 ( VAR_4 ) ; VAR_5 . METHOD_5 ( ) . remove ( VAR_4 ) ; VAR_5 . METHOD_5 ( ) . METHOD_6 ( VAR_6 ) ; } } ; VAR_7 = new TYPE_5 ( ( TYPE_2 ) VAR_2 . METHOD_2 ( ) , this , VAR_3 ) ; }
private void METHOD_1 ( ) { VAR_1 = new TYPE_1 ( ( TYPE_2 ) VAR_2 . METHOD_2 ( ) , this ) ; TYPE_3 VAR_3 = new TYPE_3 ( ) { @Override public void METHOD_3 ( Collection < ? extends TYPE_4 > VAR_4 ) { VAR_5 . METHOD_4 ( VAR_4 ) ; VAR_5 . METHOD_5 ( ) . remove ( VAR_4 ) ; VAR_5 . METHOD_5 ( ) . METHOD_6 ( VAR_6 ) ; } } ; VAR_7 = new TYPE_5 ( ( TYPE_2 ) VAR_2 . METHOD_2 ( ) , this , VAR_3 ) ; }
move _CODE_ _CODE_ ( )
ANNOTATION_1 public void METHOD_1 ( ) throws Exception { if ( VAR_1 != null ) { VAR_1 . METHOD_2 ( ) ; } if ( cache != null ) { cache . VAR_2 ( ) ; } client . VAR_3 ( ) . METHOD_3 ( ) ; <START> if ( client . VAR_3 ( ) . METHOD_4 ( ) > 0 ) { <END> System . out . println ( STRING_1 ) ; Thread . VAR_4 ( INT_1 ) ; System . out . println ( STRING_2 + client . VAR_3 ( ) . METHOD_4 ( ) ) ; } }
ANNOTATION_1 public void METHOD_1 ( ) throws Exception { if ( VAR_1 != null ) { VAR_1 . METHOD_2 ( ) ; } if ( cache != null ) { cache . VAR_2 ( ) ; } }
Arrays toString
public void METHOD_1 ( String ... VAR_1 ) { try { METHOD_2 ( Arrays . stream ( VAR_1 ) ) ; } catch ( TYPE_1 e ) { <START> throw new TYPE_1 ( STRING_1 + VAR_1 , e . VAR_2 ( ) ) ; <END> } super . METHOD_1 ( VAR_1 ) ; }
public void METHOD_1 ( String ... VAR_1 ) { try { METHOD_2 ( Arrays . stream ( VAR_1 ) ) ; } catch ( TYPE_1 e ) { throw new TYPE_1 ( STRING_1 + Arrays . asList ( VAR_1 ) , e . VAR_2 ( ) ) ; } super . METHOD_1 ( VAR_1 ) ; }
kind breaks clean streak new client ( ) calls arguments adhere pattern
protected void METHOD_1 ( int VAR_1 ) { if ( VAR_1 == 0 ) { METHOD_2 ( ) ; } METHOD_3 ( new TYPE_1 ( ) ) ; METHOD_3 ( new TYPE_2 ( ) ) ; METHOD_3 ( new TYPE_3 ( ) ) ; METHOD_3 ( new TYPE_4 ( ) ) ; METHOD_3 ( new TYPE_5 ( ) ) ; <START> METHOD_3 ( new TYPE_6 ( new TYPE_7 ( METHOD_4 ( ) , METHOD_5 ( ) ) ) ) ; <END> }
protected void METHOD_1 ( int VAR_1 ) { if ( VAR_1 == 0 ) { METHOD_2 ( ) ; } METHOD_3 ( new TYPE_1 ( ) ) ; METHOD_3 ( new TYPE_2 ( ) ) ; METHOD_3 ( new TYPE_3 ( ) ) ; METHOD_3 ( new TYPE_4 ( ) ) ; METHOD_3 ( new TYPE_5 ( ) ) ; METHOD_3 ( new TYPE_6 ( ) ) ; }
debugging logging ? level log error
private TYPE_1 METHOD_1 ( TYPE_2 VAR_1 , String VAR_2 ) throws Exception { TYPE_3 . debug ( STRING_1 + VAR_1 ) ; TYPE_4 request = METHOD_2 ( VAR_1 ) . METHOD_3 ( TYPE_5 . create ( VAR_3 , VAR_2 ) ) . build ( ) ; <START> TYPE_3 . error ( VAR_1 . toString ( ) ) ; <END> TYPE_3 . error ( VAR_2 ) ; TYPE_6 call = client . VAR_4 ( request ) ; Response response = call . execute ( ) ; return TYPE_1 . from ( response ) ; }
private TYPE_1 METHOD_1 ( TYPE_2 VAR_1 , String VAR_2 ) throws Exception { TYPE_3 . debug ( STRING_1 + VAR_1 ) ; TYPE_4 request = METHOD_2 ( VAR_1 ) . METHOD_3 ( TYPE_5 . create ( VAR_3 , VAR_2 ) ) . build ( ) ; TYPE_6 call = client . VAR_4 ( request ) ; Response response = call . execute ( ) ; return TYPE_1 . from ( response ) ; }
need public - public class
<START> public TYPE_1 ( List < T > VAR_2 ) { <END> this . VAR_2 = VAR_2 ; this . i = 0 ; }
TYPE_1 ( List < T > VAR_2 ) { this . VAR_2 = VAR_2 ; this . i = 0 ; }
haha fair enough
<START> private void METHOD_1 ( TYPE_2 . TYPE_3 [ ] VAR_1 ) { <END> for ( int i = 0 ; i < VAR_1 . length ; i ++ ) { VAR_1 [ i ] . METHOD_2 ( ) ; } }
private void METHOD_1 ( TYPE_2 . TYPE_3 [ ] VAR_1 ) { for ( int i = VAR_1 . length - 1 ; i >= 0 ; i -- ) { VAR_1 [ i ] . METHOD_2 ( ) ; } }
METHOD_2 handles null
public void METHOD_1 ( TYPE_1 output ) throws IOException { output . VAR_1 ( VAR_2 ) ; if ( VAR_2 != null ) { output . VAR_3 ( id ) ; } output . VAR_4 ( VAR_5 ) ; <START> if ( VAR_6 != null ) { <END> TYPE_2 . METHOD_2 ( VAR_6 , output ) ; } else { assert VAR_7 != null ; TYPE_2 . METHOD_3 ( VAR_7 , output ) ; } }
public void METHOD_1 ( TYPE_1 output ) throws IOException { output . VAR_1 ( VAR_2 ) ; if ( VAR_2 != null ) { output . VAR_3 ( id ) ; } output . VAR_4 ( VAR_5 ) ; TYPE_2 . METHOD_2 ( VAR_6 , output ) ; }
good a null case _CODE_
public static TYPE_1 METHOD_1 ( ) { <START> return new TYPE_1 ( METHOD_2 ( ) , METHOD_3 ( 1 , INT_1 ) , METHOD_2 ( ) ) ; <END> }
public static TYPE_1 METHOD_1 ( ) { return new TYPE_1 ( METHOD_2 ( ) , METHOD_3 ( 1 , INT_1 ) , METHOD_2 ( ) ? METHOD_2 ( ) : null ) ; }
function private
<START> boolean METHOD_1 ( String VAR_1 ) { <END> String VAR_2 = VAR_1 + VAR_3 ; return VAR_4 . remove ( TYPE_1 . name ( TYPE_2 . class , VAR_2 + STRING_1 ) ) && VAR_4 . remove ( TYPE_1 . name ( Log . VAR_5 , VAR_2 + STRING_2 ) ) && VAR_4 . remove ( TYPE_1 . name ( TYPE_2 . VAR_5 , VAR_2 + STRING_3 ) ) && VAR_4 . remove ( TYPE_1 . name ( TYPE_2 . VAR_5 , VAR_2 + STRING_4 ) ) ; }
private boolean METHOD_1 ( String VAR_1 ) { String VAR_2 = VAR_1 + VAR_3 ; return VAR_4 . remove ( TYPE_1 . name ( TYPE_2 . VAR_5 , VAR_2 + STRING_1 ) ) && VAR_4 . remove ( TYPE_1 . name ( Log . VAR_5 , VAR_2 + STRING_2 ) ) && VAR_4 . remove ( TYPE_1 . name ( TYPE_2 . VAR_5 , VAR_2 + STRING_3 ) ) && VAR_4 . remove ( TYPE_1 . name ( TYPE_2 . VAR_5 , VAR_2 + STRING_4 ) ) ; }
need
public void METHOD_1 ( ) { <START> this . METHOD_2 ( ( ) - > { <END> log . info ( STRING_1 ) ; METHOD_3 ( ) ; METHOD_4 ( ) . METHOD_5 ( VAR_1 ) ; METHOD_4 ( ) . METHOD_5 ( VAR_2 ) ; VAR_3 = true ; } ) ; }
public void METHOD_1 ( ) { METHOD_2 ( ( ) - > { log . info ( STRING_1 ) ; METHOD_3 ( ) ; METHOD_4 ( ) . METHOD_5 ( VAR_1 ) ; METHOD_4 ( ) . METHOD_5 ( VAR_2 ) ; VAR_3 = true ; } ) ; }
a regression longer works multiple repositories note extra code handles multiple repositories
public boolean METHOD_1 ( ) { <START> return METHOD_2 ( ) ; <END> }
public boolean METHOD_1 ( ) { return true ; }
updating code replace plain asserts testing framework
private void METHOD_1 ( float VAR_1 ) { METHOD_2 ( STRING_1 , VAR_1 ) ; <START> assert VAR_1 == VAR_2 . METHOD_3 ( ) . METHOD_4 ( ) ; <END> }
private void METHOD_1 ( float VAR_1 ) { METHOD_2 ( STRING_1 , VAR_1 ) ; assertEquals ( VAR_1 , ( float ) VAR_2 . METHOD_3 ( ) . METHOD_4 ( ) ) ; }
covered TYPE_1
public static boolean METHOD_1 ( Class < ? > VAR_1 ) { if ( VAR_1 == null ) { return false ; } else if ( VAR_1 . METHOD_2 ( ) ) { return TYPE_1 . contains ( VAR_1 ) ; } else { <START> return TYPE_2 . class . METHOD_3 ( VAR_1 ) ; <END> } }
public static boolean METHOD_1 ( Class < ? > VAR_1 ) { if ( VAR_1 == null ) { return false ; } else { return TYPE_1 . contains ( VAR_1 ) ; } }
type List < Object >
public List < TYPE_1 > METHOD_1 ( TYPE_2 element , TYPE_2 VAR_1 , int VAR_2 ) { <START> ArrayList < Object > VAR_3 = new ArrayList < > ( ) ; <END> return METHOD_1 ( element , VAR_1 , VAR_3 , VAR_4 , VAR_2 ) ; }
public List < TYPE_1 > METHOD_1 ( TYPE_2 element , TYPE_2 VAR_1 , int VAR_2 ) { List < Object > VAR_3 = new ArrayList < > ( ) ; return METHOD_1 ( element , VAR_1 , VAR_3 , VAR_4 , VAR_2 ) ; }
a - avoid checking 2 conditions ( true CAS )
public final TYPE_1 < TYPE_2 > METHOD_1 ( TYPE_1 < TYPE_2 > VAR_1 ) { <START> while ( true ) { <END> TYPE_1 < TYPE_2 > VAR_2 = VAR_3 . get ( ) ; if ( VAR_3 . METHOD_2 ( VAR_2 , VAR_1 ) ) return VAR_2 ; } }
public final TYPE_1 < TYPE_2 > METHOD_1 ( TYPE_1 < TYPE_2 > VAR_1 ) { TYPE_1 < TYPE_2 > VAR_2 ; do { VAR_2 = VAR_3 . get ( ) ; } while ( ! VAR_3 . METHOD_2 ( VAR_2 , VAR_1 ) ) ; return VAR_2 ; }
TYPE_3 implement TYPE_1 VAR_2 function return VAR_2 ; means classes lines code read a delta 🙃
public TYPE_1 METHOD_1 ( ) { <START> return new TYPE_1 ( ) { @Override public boolean METHOD_2 ( ) { return TYPE_3 . this . METHOD_2 ( ) ; } @Override public TYPE_2 METHOD_3 ( ) { return TYPE_3 . VAR_2 . METHOD_3 ( ) ; } @Override public void METHOD_4 ( ) { TYPE_3 . VAR_2 . METHOD_4 ( ) ; } } ; <END> }
public TYPE_1 METHOD_1 ( ) { return this ; }
METHOD_2 copies elements list array I depend implementation ways loop lose type information
public void METHOD_1 ( ) { <START> for ( Object VAR_1 : VAR_2 . METHOD_2 ( ) ) { <END> TYPE_1 VAR_3 = ( TYPE_1 ) VAR_1 ; VAR_3 . METHOD_3 ( TYPE_1 . TYPE_2 . VAR_5 , STRING_1 ) ; } VAR_6 . set ( false ) ; }
public void METHOD_1 ( ) { for ( TYPE_1 VAR_3 : VAR_2 ) { VAR_3 . METHOD_3 ( TYPE_1 . TYPE_2 . VAR_5 , STRING_1 ) ; } VAR_6 . set ( false ) ; }
initial size HashMap
public void METHOD_1 ( long VAR_1 , TYPE_1 location ) { <START> VAR_2 . METHOD_2 ( VAR_1 , x - > new HashMap < > ( ) ) ; <END> VAR_2 . get ( VAR_1 ) . put ( location . VAR_3 ( ) , location ) ; }
public void METHOD_1 ( long VAR_1 , TYPE_1 location ) { VAR_2 . METHOD_2 ( VAR_1 , x - > new HashMap < > ( 4 ) ) ; VAR_2 . get ( VAR_1 ) . put ( location . VAR_3 ( ) , location ) ; }
METHOD_1 ( ) method - I -
public String getName ( ) { return METHOD_1 ( Constants . VAR_1 ) != null <START> ? VAR_2 . METHOD_2 ( ) . get ( Constants . VAR_1 ) <END> : METHOD_3 ( ) ; }
public String getName ( ) { return METHOD_1 ( Constants . VAR_1 ) != null ? METHOD_1 ( Constants . VAR_1 ) : METHOD_3 ( ) ; }
please diamond operator i e < > instead type parameters reduces clutter code easier maintain
public TYPE_6 ( TYPE_1 project , TYPE_2 VAR_2 ) { this . project = project ; this . VAR_2 = VAR_2 ; VAR_3 = ( TYPE_3 ) TYPE_4 . METHOD_1 ( ) ; <START> parameters = new HashMap < String , List < TYPE_5 > > ( ) ; <END> }
public TYPE_6 ( TYPE_1 project , TYPE_2 VAR_2 ) { this . project = project ; this . VAR_2 = VAR_2 ; VAR_3 = ( TYPE_3 ) TYPE_4 . METHOD_1 ( ) ; parameters = new HashMap < > ( ) ; }
s DRY String url = VAR_3 METHOD_4 ( ) METHOD_5 ( ) METHOD_6 ( ) ; VAR_2 METHOD_3 ( url ) ; VAR_2 METHOD_7 ( url ) ;
protected void METHOD_1 ( TYPE_1 VAR_1 ) { if ( VAR_1 != null ) { if ( ! METHOD_2 ( ) ) { VAR_2 . METHOD_3 ( VAR_3 . METHOD_4 ( ) . METHOD_5 ( ) . METHOD_6 ( ) ) ; <START> VAR_2 . METHOD_7 ( VAR_3 . METHOD_4 ( ) . METHOD_5 ( ) . METHOD_6 ( ) ) ; <END> } } }
protected void METHOD_1 ( TYPE_1 VAR_1 ) { if ( VAR_1 != null ) { if ( ! METHOD_2 ( ) ) { String url = VAR_3 . METHOD_4 ( ) . METHOD_5 ( ) . METHOD_6 ( ) ; VAR_2 . METHOD_3 ( url ) ; VAR_2 . METHOD_7 ( url ) ; } } }
VAR_4 variable ; remove itreturn VAR_2 ;
public int read ( int offset , int [ ] VAR_1 , int VAR_2 ) { VAR_3 = METHOD_1 ( VAR_3 , VAR_1 , VAR_2 ) ; <START> VAR_4 = VAR_2 ; <END> return VAR_4 ; }
public int read ( int offset , int [ ] VAR_1 , int VAR_2 ) { VAR_3 = METHOD_1 ( VAR_3 , VAR_1 , VAR_2 ) ; return VAR_2 ; }
method synchronized
<START> public void start ( TYPE_1 ctx ) <END> throws TYPE_2 { if ( VAR_1 == null ) { VAR_1 = new TYPE_3 ( ) ; VAR_1 . start ( ) ; } }
public synchronized void start ( TYPE_1 ctx ) throws TYPE_2 { if ( VAR_1 == null ) { VAR_1 = new TYPE_3 ( ) ; VAR_1 . start ( ) ; } }
wouldn t preferred store type case instead creating time method invoked
public String getValue ( ) { <START> return name ( ) . METHOD_1 ( ) ; <END> }
public String getValue ( ) { return value ; }
start stop called time
<START> public boolean start ( ) <END> { if ( ! VAR_1 . get ( ) ) { LOGGER . info ( STRING_1 , id ) ; VAR_1 . set ( VAR_2 . METHOD_1 ( ) ) ; } return VAR_1 . get ( ) ; }
public boolean start ( ) { synchronized ( VAR_1 ) { if ( ! VAR_1 . get ( ) ) { LOGGER . info ( STRING_1 , id ) ; VAR_1 . set ( VAR_2 . METHOD_1 ( ) ) ; } return VAR_1 . get ( ) ; } }
moved METHOD_5
public void METHOD_1 ( final TYPE_1 VAR_1 , final String VAR_2 ) { try { TYPE_2 . METHOD_2 ( VAR_1 . METHOD_3 ( ) ) ; } catch ( Exception e ) { throw new RuntimeException ( e ) ; } try { <START> TYPE_2 . METHOD_4 ( VAR_1 . METHOD_3 ( ) ) ; <END> } catch ( Exception e ) { throw new RuntimeException ( e ) ; } METHOD_5 ( VAR_1 . METHOD_3 ( ) , VAR_3 , false ) ; METHOD_5 ( VAR_1 . METHOD_3 ( ) , VAR_4 , false ) ; }
public void METHOD_1 ( final TYPE_1 VAR_1 , final String VAR_2 ) { METHOD_5 ( VAR_1 . METHOD_3 ( ) , VAR_3 , false ) ; METHOD_5 ( VAR_1 . METHOD_3 ( ) , VAR_4 , false ) ; }
I assume VAR_2 ! = null
public int METHOD_1 ( ) { final int VAR_1 = INT_1 ; int result = 1 ; result = VAR_1 * result <START> + ( ( VAR_2 == null ) ? 0 : VAR_2 . METHOD_1 ( ) ) ; <END> result = VAR_1 * result + ( ( VAR_3 == null ) ? 0 : VAR_3 . METHOD_1 ( ) ) ; return result ; }
public int METHOD_1 ( ) { final int VAR_1 = INT_1 ; int result = 1 ; result = VAR_1 * result + VAR_2 . METHOD_1 ( ) ; result = VAR_1 * result + ( ( VAR_3 == null ) ? 0 : VAR_3 . METHOD_1 ( ) ) ; return result ; }
I List fine
private <START> List < TYPE_1 > list ( final <END> TYPE_2 request ) throws TYPE_3 { TYPE_4 VAR_1 = VAR_2 . get ( ) ; VAR_1 . METHOD_1 ( request . VAR_3 ( ) ) ; VAR_1 . METHOD_2 ( request . VAR_4 ( ) ) ; VAR_1 . METHOD_3 ( request . VAR_5 ( ) ) ; VAR_1 . METHOD_4 ( request . VAR_6 ( ) ) ; Map < String , TYPE_1 > result = VAR_1 . apply ( ) ; return ImmutableList . VAR_7 ( result . values ( ) ) ; }
private List < TYPE_1 > list ( final TYPE_2 request ) throws TYPE_3 { TYPE_4 VAR_1 = VAR_2 . get ( ) ; VAR_1 . METHOD_1 ( request . VAR_3 ( ) ) ; VAR_1 . METHOD_2 ( request . VAR_4 ( ) ) ; VAR_1 . METHOD_3 ( request . VAR_5 ( ) ) ; VAR_1 . METHOD_4 ( request . VAR_6 ( ) ) ; return ImmutableList . VAR_7 ( VAR_1 . apply ( ) . values ( ) ) ; }
replace 1 line : assertEquals ( _CODE_ TYPE_3 item VAR_3 ( ) ) ;
public void METHOD_1 ( ) { <START> Long VAR_1 = TYPE_2 . TYPE_3 . getId ( ) ; <END> Long VAR_2 = item . VAR_3 ( ) . getId ( ) ; assertEquals ( VAR_1 , VAR_2 ) ; }
public void METHOD_1 ( ) { assertEquals ( TYPE_2 . TYPE_3 , item . VAR_3 ( ) ) ; }
I put pause
public void METHOD_1 ( ) { super . METHOD_1 ( ) ; <START> ( ( TYPE_1 ) METHOD_2 ( ) ) . METHOD_3 ( ) . METHOD_4 ( true ) ; <END> VAR_1 . METHOD_5 ( ) . METHOD_6 ( this ) ; }
public void METHOD_1 ( ) { super . METHOD_1 ( ) ; VAR_1 . METHOD_5 ( ) . METHOD_6 ( this ) ; }