Datasets:
YabTad
/
CodeRev

Dataset card Data Studio Files
xet
 Community
ReviewComments
stringlengths
1
2.35k
OriginalCode
stringlengths
28
487
ReviewedCode
stringlengths
14
463
a tiiny bit safer / nicer put config - > VAR_1 conversion METHOD_2 method
public void start ( ) throws Exception { logger . info ( STRING_1 ) ; METHOD_1 ( ) ; logger . trace ( STRING_2 ) ; METHOD_2 ( ) ; <START> if ( VAR_1 == null ) { <END> VAR_1 = new ArrayList < TYPE_1 > ( ) ; if ( config != null ) { TYPE_1 VAR_2 = new TYPE_1 ( VAR_3 ) ; VAR_2 . METHOD_3 ( config ) ; VAR_1 . add ( VAR_2 ) ; } } for ( TYPE_1 s : VAR_1 ) { s . start ( ) ; } }
public void start ( ) throws Exception { logger . info ( STRING_1 ) ; METHOD_1 ( ) ; logger . trace ( STRING_2 ) ; METHOD_2 ( ) ; for ( TYPE_1 s : VAR_1 ) { s . start ( ) ; } }
I thought changed ichi2 anki JSON classes avoid / catch throw _CODE_ ? #5550
private boolean METHOD_1 ( ) { int VAR_1 ; try { VAR_1 = METHOD_2 ( ) . getInt ( STRING_1 ) ; <START> } catch ( TYPE_1 e ) { <END> throw new RuntimeException ( e ) ; } return VAR_1 == TYPE_2 . VAR_3 ; }
private boolean METHOD_1 ( ) { return METHOD_2 ( ) . getInt ( STRING_1 ) == TYPE_2 . VAR_3 ; }
I avoid declaring handle invoke execute shared handle
public void METHOD_1 ( ) { <START> final TYPE_1 VAR_1 = this . VAR_2 . METHOD_2 ( ) ; <END> VAR_1 . execute ( STRING_1 ) ; }
public void METHOD_1 ( ) { this . VAR_2 . METHOD_2 ( ) . execute ( STRING_1 ) ; }
need close - - resource
public void METHOD_1 ( ) throws IOException , TYPE_1 { try ( TYPE_2 stream = VAR_1 . METHOD_2 ( STRING_1 , STRING_2 , STRING_3 ) ) { TYPE_3 . METHOD_3 ( stream ) ; <START> stream . close ( ) ; <END> } }
public void METHOD_1 ( ) throws IOException , TYPE_1 { try ( TYPE_2 stream = VAR_1 . METHOD_2 ( STRING_1 , STRING_2 , STRING_3 ) ) { TYPE_3 . METHOD_3 ( stream ) ; } }
enough latest 3 3 version
private void METHOD_1 ( ) { try ( TYPE_1 VAR_1 = db . VAR_2 ( ) ) { db . execute ( STRING_1 + VAR_3 ) ; VAR_1 . METHOD_2 ( ) ; } try ( TYPE_1 VAR_1 = db . VAR_2 ( ) ) { <START> db . VAR_4 ( ) . METHOD_3 ( 1 , TimeUnit . VAR_5 ) ; <END> VAR_1 . METHOD_2 ( ) ; } }
private void METHOD_1 ( ) { try ( TYPE_1 VAR_1 = db . VAR_2 ( ) ) { db . execute ( STRING_1 + VAR_3 ) ; VAR_1 . METHOD_2 ( ) ; } try ( TYPE_1 VAR_1 = db . VAR_2 ( ) ) { db . VAR_4 ( ) . METHOD_3 ( 5 , TimeUnit . VAR_5 ) ; VAR_1 . METHOD_2 ( ) ; } }
needed ? storing a context a good idea general
public int METHOD_1 ( TYPE_1 VAR_1 ) { <START> if ( VAR_2 == null ) <END> return TYPE_2 . METHOD_2 ( STRING_1 , METHOD_3 ( ) ) . METHOD_4 ( TYPE_2 . METHOD_2 ( STRING_1 , VAR_1 . METHOD_3 ( ) ) ) ; TYPE_3 VAR_3 = TYPE_3 . getInstance ( TYPE_4 . METHOD_5 ( ) ) ; return VAR_3 . METHOD_6 ( TYPE_2 . METHOD_2 ( STRING_1 , METHOD_3 ( ) ) , TYPE_2 . METHOD_2 ( STRING_1 , VAR_1 . METHOD_3 ( ) ) ) ; }
public int METHOD_1 ( TYPE_1 VAR_1 ) { TYPE_3 VAR_3 = TYPE_3 . getInstance ( TYPE_4 . METHOD_5 ( ) ) ; return VAR_3 . METHOD_6 ( TYPE_2 . METHOD_2 ( STRING_1 , METHOD_3 ( ) ) , TYPE_2 . METHOD_2 ( STRING_1 , VAR_1 . METHOD_3 ( ) ) ) ; }
VAR_1 set ( 0 ) ; a race condition _CODE_ method invoked time CAS operation doesn t work properly returned a incremented CAS occur causing a missed reset
void METHOD_1 ( ) { <START> VAR_1 . METHOD_2 ( VAR_1 . get ( ) , 0 ) ; <END> }
void METHOD_1 ( ) { VAR_1 . set ( 0 ) ; }
making method implementation : return cmd VAR_2 ( ) startsWith ( VAR_3 ) ;
private boolean METHOD_1 ( final TYPE_1 cmd ) { <START> String VAR_1 = cmd . VAR_2 ( ) ; <END> if ( VAR_1 . startsWith ( VAR_3 ) ) { return true ; } return false ; }
private boolean METHOD_1 ( final TYPE_1 cmd ) { return cmd . VAR_2 ( ) . startsWith ( VAR_3 ) ; }
need capture autobuild state setup restore teardown
public void METHOD_1 ( ) throws Exception { <START> METHOD_2 ( true ) ; <END> TYPE_1 . METHOD_3 ( ) . METHOD_4 ( false ) ; TYPE_2 . METHOD_5 ( 100 ) ; TYPE_3 . METHOD_6 ( ) ; TYPE_4 . METHOD_7 ( ) ; TYPE_5 . METHOD_8 ( ) ; TYPE_2 . METHOD_5 ( ) ; }
public void METHOD_1 ( ) throws Exception { TYPE_2 . METHOD_5 ( 100 ) ; TYPE_3 . METHOD_6 ( ) ; TYPE_4 . METHOD_7 ( ) ; TYPE_5 . METHOD_8 ( ) ; TYPE_2 . METHOD_5 ( ) ; }
I line means _CODE_ needs a METHOD_1 method
public byte [ ] METHOD_1 ( ) { byte [ ] VAR_1 = VAR_2 == null ? new byte [ ] { } : StringUtils . VAR_3 ( VAR_2 ) ; <START> byte [ ] VAR_4 = StringUtils . VAR_3 ( VAR_5 . toString ( ) ) ; <END> int VAR_6 = 2 + VAR_1 . length + VAR_4 . length ; return ByteBuffer . VAR_7 ( VAR_6 ) . put ( VAR_8 ) . put ( VAR_1 ) . put ( VAR_9 ) . put ( VAR_4 ) . METHOD_2 ( ) ; }
public byte [ ] METHOD_1 ( ) { byte [ ] VAR_1 = VAR_2 == null ? new byte [ ] { } : StringUtils . VAR_3 ( VAR_2 ) ; byte [ ] VAR_4 = VAR_5 . METHOD_1 ( ) ; int VAR_6 = 2 + VAR_1 . length + VAR_4 . length ; return ByteBuffer . VAR_7 ( VAR_6 ) . put ( VAR_8 ) . put ( VAR_1 ) . put ( VAR_9 ) . put ( VAR_4 ) . METHOD_2 ( ) ; }
technically setting VAR_5 = false isn t needed default a boolean
public TYPE_3 ( Map < String , Object > VAR_2 , TYPE_1 VAR_3 ) { this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; this . VAR_4 = METHOD_1 ( ) ; <START> this . VAR_5 = false ; <END> this . VAR_6 = new TYPE_2 < > ( ) ; }
public TYPE_3 ( Map < String , Object > VAR_2 , TYPE_1 VAR_3 ) { this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; this . VAR_4 = METHOD_1 ( ) ; }
creating TYPE_2 omitted
public void METHOD_1 ( ) { long VAR_1 = VAR_2 . value ; long VAR_3 = VAR_4 . value ; <START> TYPE_1 . time . TYPE_2 VAR_6 = TYPE_1 . time . TYPE_2 . METHOD_2 ( VAR_1 - ( VAR_1 % VAR_3 ) ) ; <END> out . value = VAR_6 . METHOD_3 ( ) ; }
public void METHOD_1 ( ) { long VAR_1 = VAR_2 . value ; long VAR_3 = VAR_4 . value ; out . value = ( VAR_1 - ( VAR_1 % VAR_3 ) ) ; }
forEach doesn t values avoid sending caller simply returning null
public TYPE_1 METHOD_1 ( Map . Entry < TYPE_2 , TYPE_1 > entry ) { action . VAR_1 ( entry . getKey ( ) , entry . getValue ( ) ) ; <START> return entry . getValue ( ) ; <END> }
public TYPE_1 METHOD_1 ( Map . Entry < TYPE_2 , TYPE_1 > entry ) { action . VAR_1 ( entry . getKey ( ) , entry . getValue ( ) ) ; return null ; }
please implement a mock version _CODE_ a normal HashMap
private TYPE_1 user ( TYPE_6 . TYPE_7 ... VAR_1 ) { TYPE_4 . TYPE_8 VAR_2 = new TYPE_4 . TYPE_8 ( ) { @Override public TYPE_4 create ( final TYPE_1 VAR_3 , final String VAR_4 ) { <START> return new TYPE_4 ( VAR_5 , VAR_3 , VAR_4 , null ) ; <END> } } ; return new TYPE_1 ( TYPE_9 < TYPE_6 . TYPE_7 > METHOD_1 ( ) , TYPE_9 < TYPE_6 . TYPE_7 > METHOD_1 ( ) , VAR_2 , new TYPE_5 ( VAR_1 ) , METHOD_2 ( ) ) ; }
private TYPE_1 user ( TYPE_6 . TYPE_7 ... VAR_1 ) { TYPE_4 . TYPE_8 VAR_2 = new TYPE_4 . TYPE_8 ( ) { @Override public TYPE_4 create ( final TYPE_1 VAR_3 , final String VAR_4 ) { return new TYPE_4 ( VAR_5 , VAR_3 , VAR_4 ) ; } } ; return new TYPE_1 ( VAR_5 , TYPE_9 < TYPE_6 . TYPE_7 > METHOD_1 ( ) , TYPE_9 < TYPE_6 . TYPE_7 > METHOD_1 ( ) , VAR_2 , new TYPE_5 ( VAR_1 ) , METHOD_2 ( ) ) ; }
pattern match arguments
private boolean METHOD_1 ( TYPE_1 connection ) { Thread VAR_1 = Thread . VAR_1 ( ) ; String VAR_2 = VAR_1 . getName ( ) ; <START> String VAR_3 = String . format ( STRING_1 , VAR_2 , connection . VAR_4 ( ) , VAR_5 ) ; <END> VAR_1 . METHOD_2 ( VAR_3 ) ; try { return connection . VAR_6 ( ) ; } finally { VAR_1 . METHOD_2 ( VAR_2 ) ; } }
private boolean METHOD_1 ( TYPE_1 connection ) { Thread VAR_1 = Thread . VAR_1 ( ) ; String VAR_2 = VAR_1 . getName ( ) ; String VAR_3 = String . format ( STRING_1 , VAR_2 , connection . VAR_4 ( ) ) ; VAR_1 . METHOD_2 ( VAR_3 ) ; try { return connection . VAR_6 ( ) ; } finally { VAR_1 . METHOD_2 ( VAR_2 ) ; } }
needed s called line 176 ? mention CDA s run
protected boolean METHOD_1 ( TYPE_1 VAR_1 ) { if ( METHOD_2 ( ) ) { if ( METHOD_3 ( ) . getStatus ( ) != TYPE_4 . TYPE_2 && VAR_4 . METHOD_4 ( ) ) { return METHOD_5 ( TYPE_3 . VAR_6 ) ; } <START> if ( ! METHOD_6 ( ) ) { <END> return false ; } return METHOD_7 ( VAR_1 . METHOD_8 ( ) ) ; } return true ; }
protected boolean METHOD_1 ( TYPE_1 VAR_1 ) { if ( METHOD_2 ( ) ) { if ( METHOD_3 ( ) . getStatus ( ) != TYPE_4 . TYPE_2 && VAR_4 . METHOD_4 ( ) ) { return METHOD_5 ( TYPE_3 . VAR_6 ) ; } return METHOD_7 ( VAR_1 . METHOD_8 ( ) ) ; } return true ; }
remove thises
public TYPE_2 ( TYPE_1 from , TYPE_1 to ) { this . VAR_2 = from ; <START> this . VAR_3 = to ; <END> this . VAR_4 = TYPE_3 . VAR_6 ; }
public TYPE_2 ( TYPE_1 from , TYPE_1 to ) { VAR_2 = from ; VAR_3 = to ; VAR_4 = TYPE_3 . VAR_6 ; }
remove VAR_4 METHOD_3 ( ) - - VAR_4 iterator ( ) calls METHOD_3 _CODE_
public void METHOD_1 ( ) { if ( state == TYPE_4 . VAR_2 ) { state = TYPE_4 . VAR_3 ; TYPE_1 < TYPE_2 > VAR_4 = METHOD_2 ( new TYPE_3 ( VAR_5 , VAR_6 , VAR_7 ) ) ; <START> VAR_4 . METHOD_3 ( ) ; <END> VAR_8 = VAR_4 . iterator ( ) ; } }
public void METHOD_1 ( ) { if ( state == TYPE_4 . VAR_2 ) { state = TYPE_4 . VAR_3 ; TYPE_1 < TYPE_2 > VAR_4 = METHOD_2 ( new TYPE_3 ( VAR_5 , VAR_6 , VAR_7 ) ) ; VAR_8 = VAR_4 . iterator ( ) ; } }
called child class METHOD_1 ( ) method
public void METHOD_1 ( ) { <START> super . METHOD_1 ( ) ; <END> METHOD_2 ( VAR_1 ) ; }
public void METHOD_1 ( ) { METHOD_2 ( VAR_1 ) ; super . METHOD_1 ( ) ; }
I find easier read : _CODE_ < TYPE_2 < TYPE_3 > > VAR_1 = VAR_1 ; ( VAR_2 ) { VAR_1 = METHOD_1 ( VAR_1 VAR_3 - > ! VAR_3 METHOD_2 ( ) ) ; } return new TYPE_1 ( VAR_4 VAR_1 VAR_5 ) ;
public TYPE_1 build ( ) { <START> List < TYPE_2 < TYPE_3 > > VAR_1 = VAR_2 ? METHOD_1 ( this . VAR_1 , VAR_3 - > ! VAR_3 . METHOD_2 ( ) ) : this . VAR_1 ; <END> return new TYPE_1 ( VAR_4 , VAR_1 , VAR_5 ) ; }
public TYPE_1 build ( ) { List < TYPE_2 < TYPE_3 > > VAR_1 = this . VAR_1 ; if ( VAR_2 ) { VAR_1 = METHOD_1 ( this . VAR_1 , VAR_3 - > ! VAR_3 . METHOD_2 ( ) ) ; } return new TYPE_1 ( VAR_4 , VAR_1 , VAR_5 ) ; }
toString ( )
public String METHOD_1 ( TYPE_1 VAR_1 ) { <START> return METHOD_2 ( ) . get ( VAR_1 . toString ( ) ) ; <END> }
public String METHOD_1 ( TYPE_1 VAR_1 ) { return METHOD_2 ( ) . get ( VAR_1 ) ; }
synchronizing synchronizing lock
<START> public synchronized TYPE_1 METHOD_1 ( TYPE_1 uri , TYPE_2 VAR_1 ) { <END> TYPE_3 args = new TYPE_3 ( uri ) ; synchronized ( VAR_2 ) { TYPE_4 db = VAR_3 . METHOD_2 ( ) ; final long VAR_4 = db . VAR_5 ( args . table , null , VAR_1 ) ; if ( VAR_4 <= 0 ) return null ; uri = TYPE_5 . METHOD_3 ( uri , VAR_4 ) ; METHOD_4 ( uri ) ; return uri ; } }
public TYPE_1 METHOD_1 ( TYPE_1 uri , TYPE_2 VAR_1 ) { TYPE_3 args = new TYPE_3 ( uri ) ; synchronized ( VAR_2 ) { TYPE_4 db = VAR_3 . METHOD_2 ( ) ; final long VAR_4 = db . VAR_5 ( args . table , null , VAR_1 ) ; if ( VAR_4 <= 0 ) return null ; uri = TYPE_5 . METHOD_3 ( uri , VAR_4 ) ; METHOD_4 ( uri ) ; return uri ; } }
need VAR_2 block : - )
protected void METHOD_1 ( TYPE_1 m ) { try { TYPE_2 VAR_1 = METHOD_2 ( new TYPE_1 [ ] { m } ) ; <START> TYPE_3 VAR_2 = METHOD_3 ( ) ; <END> boolean VAR_3 = TYPE_4 . METHOD_4 ( METHOD_5 ( ) ) ; if ( VAR_3 ) { TYPE_4 . METHOD_6 ( VAR_1 , VAR_2 ) ; TYPE_4 . METHOD_7 ( VAR_1 , VAR_2 ) ; } } catch ( TYPE_5 VAR_4 ) { TYPE_6 . log ( VAR_4 ) ; } }
protected void METHOD_1 ( TYPE_1 m ) { try { TYPE_2 VAR_1 = METHOD_2 ( new TYPE_1 [ ] { m } ) ; boolean VAR_3 = TYPE_4 . METHOD_4 ( METHOD_5 ( ) ) ; if ( VAR_3 ) { TYPE_3 VAR_2 = METHOD_3 ( ) ; TYPE_4 . METHOD_6 ( VAR_1 , VAR_2 ) ; TYPE_4 . METHOD_7 ( VAR_1 , VAR_2 ) ; } } catch ( TYPE_5 VAR_4 ) { TYPE_6 . log ( VAR_4 ) ; } }
t getPath instead
public void METHOD_1 ( ANNOTATION_1 TYPE_1 VAR_1 , ANNOTATION_2 TYPE_1 VAR_2 ) throws Exception { System . VAR_3 ( STRING_1 , STRING_2 <START> + STRING_3 ) ; <END> TYPE_2 . METHOD_2 ( STRING_4 , STRING_5 , getPath ( STRING_6 ) ) ; assertThat ( STRING_7 , VAR_2 . METHOD_3 ( ) , is ( VAR_4 ) ) ; assertThat ( STRING_8 , VAR_1 . METHOD_3 ( ) , is ( "" ) ) ; }
public void METHOD_1 ( ANNOTATION_1 TYPE_1 VAR_1 , ANNOTATION_2 TYPE_1 VAR_2 ) throws Exception { System . VAR_3 ( STRING_1 , getPath ( STRING_3 ) ) ; TYPE_2 . METHOD_2 ( STRING_4 , STRING_5 , getPath ( STRING_6 ) ) ; assertThat ( STRING_7 , VAR_2 . METHOD_3 ( ) , is ( VAR_4 ) ) ; assertThat ( STRING_8 , VAR_1 . METHOD_3 ( ) , is ( "" ) ) ; }
remove println
private static Map < String , String > METHOD_1 ( final TYPE_1 < String , String > VAR_1 ) { final HashMap < String , String > result = new HashMap < > ( ) ; VAR_1 . METHOD_2 ( ) . METHOD_3 ( VAR_2 - > { <START> System . out . println ( VAR_2 ) ; <END> result . put ( VAR_2 . key , VAR_2 . value ) ; } ) ; return result ; }
private static Map < String , String > METHOD_1 ( final TYPE_1 < String , String > VAR_1 ) { final HashMap < String , String > result = new HashMap < > ( ) ; VAR_1 . METHOD_2 ( ) . METHOD_3 ( VAR_2 - > result . put ( VAR_2 . key , VAR_2 . value ) ) ; return result ; }
final
public TYPE_1 METHOD_1 ( TYPE_2 request , String name , long VAR_1 ) { <START> TYPE_1 VAR_2 ; <END> if ( VAR_3 ) { VAR_2 = new TYPE_3 ( name , VAR_1 , VAR_4 ) ; } else if ( VAR_5 ) { VAR_2 = new TYPE_4 ( name , VAR_1 , VAR_6 , VAR_4 ) ; } else { VAR_2 = new TYPE_5 ( name , VAR_1 ) ; } VAR_2 . METHOD_2 ( VAR_7 ) ; List < TYPE_6 > list = METHOD_3 ( request ) ; list . add ( VAR_2 ) ; return VAR_2 ; }
public TYPE_1 METHOD_1 ( TYPE_2 request , String name , long VAR_1 ) { final TYPE_1 VAR_2 ; if ( VAR_3 ) { VAR_2 = new TYPE_3 ( name , VAR_1 , VAR_4 ) ; } else if ( VAR_5 ) { VAR_2 = new TYPE_4 ( name , VAR_1 , VAR_6 , VAR_4 ) ; } else { VAR_2 = new TYPE_5 ( name , VAR_1 ) ; } VAR_2 . METHOD_2 ( VAR_7 ) ; List < TYPE_6 > list = METHOD_3 ( request ) ; list . add ( VAR_2 ) ; return VAR_2 ; }
METHOD_4 ( ) checks VAR_4 = = null don t need check null
public boolean METHOD_1 ( Date VAR_1 ) { if ( VAR_2 != null && VAR_3 != null && VAR_2 . METHOD_2 ( VAR_3 ) ) { throw new TYPE_1 ( STRING_1 , ( Object [ ] ) null ) ; } if ( METHOD_3 ( ) ) { return false ; } if ( VAR_1 == null ) { VAR_1 = new Date ( ) ; } <START> if ( VAR_4 == null || ! METHOD_4 ( VAR_1 ) || VAR_2 == null ) { <END> return false ; } return VAR_1 . METHOD_2 ( VAR_2 ) ; }
public boolean METHOD_1 ( Date VAR_1 ) { if ( VAR_2 != null && VAR_3 != null && VAR_2 . METHOD_2 ( VAR_3 ) ) { throw new TYPE_1 ( STRING_1 , ( Object [ ] ) null ) ; } if ( METHOD_3 ( ) ) { return false ; } if ( VAR_1 == null ) { VAR_1 = new Date ( ) ; } if ( ! METHOD_4 ( VAR_1 ) || VAR_2 == null ) { return false ; } return VAR_1 . METHOD_2 ( VAR_2 ) ; }
readability reasons please add braces
private void METHOD_1 ( TYPE_1 VAR_1 ) { <START> if ( ! VAR_2 . isEmpty ( ) ) for <END> ( TYPE_2 VAR_3 : VAR_2 ) { VAR_3 . METHOD_1 ( this , VAR_1 ) ; } }
private void METHOD_1 ( TYPE_1 VAR_1 ) { if ( ! VAR_2 . isEmpty ( ) ) { for ( TYPE_2 VAR_3 : VAR_2 ) { VAR_3 . METHOD_1 ( this , VAR_1 ) ; } } }
pick : please consider putting top instead bottom ( I prevent / stop event handle )
public void METHOD_1 ( TYPE_1 event ) { TYPE_2 VAR_1 = null ; if ( event . VAR_2 ( ) instanceof TYPE_2 ) { VAR_1 = ( TYPE_2 ) event . VAR_2 ( ) ; } if ( VAR_1 != null ) { boolean VAR_3 = VAR_1 . METHOD_2 ( ) ; METHOD_3 ( ) ; VAR_1 . METHOD_4 ( ! VAR_3 ) ; METHOD_4 ( ) ; } else { METHOD_3 ( ) ; } event . VAR_4 ( ) ; <START> event . VAR_5 ( ) ; <END> }
public void METHOD_1 ( TYPE_1 event ) { event . VAR_4 ( ) ; event . VAR_5 ( ) ; TYPE_2 VAR_1 = null ; if ( event . VAR_2 ( ) instanceof TYPE_2 ) { VAR_1 = ( TYPE_2 ) event . VAR_2 ( ) ; } if ( VAR_1 != null ) { boolean VAR_3 = VAR_1 . METHOD_2 ( ) ; METHOD_3 ( ) ; VAR_1 . METHOD_4 ( ! VAR_3 ) ; METHOD_4 ( ) ; } else { METHOD_3 ( ) ; } }
consistency declared throw IllegalStateException null checking I remove consistency
<START> public void METHOD_1 ( TYPE_1 VAR_1 ) throws IllegalStateException { <END> if ( VAR_2 == null ) { throw new IllegalStateException ( STRING_1 ) ; } if ( VAR_1 == null ) { VAR_1 = TYPE_1 . NONE ; } if ( VAR_3 . equals ( VAR_1 ) ) { return ; } VAR_3 = VAR_1 ; TYPE_2 . METHOD_2 ( VAR_1 . getValue ( ) ) ; }
public void METHOD_1 ( TYPE_1 VAR_1 ) { if ( VAR_2 == null ) { throw new IllegalStateException ( STRING_1 ) ; } if ( VAR_1 == null ) { VAR_1 = TYPE_1 . NONE ; } if ( VAR_3 . equals ( VAR_1 ) ) { return ; } VAR_3 = VAR_1 ; TYPE_2 . METHOD_2 ( VAR_1 . getValue ( ) ) ; }
please long don t need wrap unwrap primitive
<START> public synchronized Long METHOD_1 ( ) { <END> return VAR_1 . METHOD_2 ( ) ; }
public synchronized long METHOD_1 ( ) { return VAR_1 . METHOD_2 ( ) ; }
please explain need store upper case please
public TYPE_2 ( TYPE_1 writer , String VAR_2 ) { this . writer = writer ; <START> this . VAR_2 = VAR_2 != null ? VAR_2 . METHOD_1 ( ) : null ; <END> }
public TYPE_2 ( TYPE_1 writer , String VAR_2 ) { this . writer = writer ; this . VAR_2 = VAR_2 ; }
String valueOf ( ) instead appending empty string
public String METHOD_1 ( ) { <START> return ( ( TYPE_1 ) entity . VAR_1 ( ) ) . METHOD_2 ( ) + "" ; <END> }
public String METHOD_1 ( ) { return String . valueOf ( ( ( TYPE_1 ) entity . VAR_1 ( ) ) . METHOD_2 ( ) ) ; }
I selector mobile desktop please : invisible - high - impact - wrapper interstitial provider - container iframe
public static Object [ ] [ ] METHOD_1 ( ) { return new Object [ ] [ ] { { new TYPE_1 ( STRING_1 , STRING_2 ) , <START> STRING_3 , <END> new TYPE_2 ( INT_1 , INT_2 ) } , } ; }
public static Object [ ] [ ] METHOD_1 ( ) { return new Object [ ] [ ] { { new TYPE_1 ( STRING_1 , STRING_2 ) , new TYPE_2 ( INT_1 , INT_2 ) } , } ; }
worth enforcing map wrapped empty ? _CODE_ ( ) method a copy map properly importing keys wrong impression constructor remove - insert values currently map accessible wrap a map uppercase key names members able extracted interface
protected TYPE_2 ( final Map < String , TYPE_1 > VAR_2 ) { <START> this . VAR_2 = VAR_2 ; <END> }
private TYPE_2 ( final Map < String , TYPE_1 > VAR_2 ) { this . VAR_2 = VAR_2 ; }
skip criteria enforced VAR_3 ( e g [ _CODE_ ] ( ) ) VAR_3 respect more data other criteria determine doesn t want continue reading VAR_3 checks auto read a more natural fit read pending check ( e g auto read enabled || asked read )
public final boolean METHOD_1 ( TYPE_1 VAR_1 ) { <START> return ( VAR_2 && METHOD_2 ( ) ) || VAR_3 . METHOD_1 ( VAR_1 ) ; <END> }
public final boolean METHOD_1 ( TYPE_1 VAR_1 ) { return VAR_3 . METHOD_1 ( VAR_1 ) ; }
context VAR_5 ( resource TYPE_3 VAR_7 )
private void METHOD_1 ( org . VAR_1 . VAR_2 . VAR_3 . File resource , TYPE_1 context ) { TYPE_2 < Integer > VAR_4 = context . VAR_5 ( resource , TYPE_3 . VAR_7 ) ; if ( VAR_4 != null ) { <START> double VAR_8 = context . VAR_5 ( resource , TYPE_3 . VAR_7 ) . getValue ( ) ; <END> context . VAR_9 ( resource , METHOD_2 ( resource , context ) ) ; context . VAR_9 ( resource , VAR_10 , VAR_8 ) ; context . VAR_9 ( resource , VAR_11 , VAR_8 ) ; } }
private void METHOD_1 ( org . VAR_1 . VAR_2 . VAR_3 . File resource , TYPE_1 context ) { TYPE_2 < Integer > VAR_4 = context . VAR_5 ( resource , TYPE_3 . VAR_7 ) ; if ( VAR_4 != null ) { double VAR_8 = VAR_4 . getValue ( ) ; context . VAR_9 ( resource , METHOD_2 ( resource , context ) ) ; context . VAR_9 ( resource , VAR_10 , VAR_8 ) ; context . VAR_9 ( resource , VAR_11 , VAR_8 ) ; } }
ternary
TYPE_1 METHOD_1 ( String VAR_1 ) { TYPE_2 resource = METHOD_2 ( METHOD_3 ( VAR_1 ) ) ; <START> if ( resource != null ) { <END> return METHOD_4 ( VAR_2 . METHOD_5 ( resource . VAR_3 ( ) ) . METHOD_6 ( ) ) ; } return null ; }
TYPE_1 METHOD_1 ( String VAR_1 ) { TYPE_2 resource = METHOD_2 ( METHOD_3 ( VAR_1 ) ) ; return resource != null ? METHOD_4 ( VAR_2 . METHOD_5 ( resource . VAR_3 ( ) ) . METHOD_6 ( ) ) : null ; }
super : - picky empty line necessary I
public void METHOD_1 ( ) { VAR_1 = new TYPE_1 < > ( TYPE_2 . class ) ; VAR_2 = METHOD_2 ( TYPE_3 . class ) ; <START> <END> }
public void METHOD_1 ( ) { VAR_1 = new TYPE_1 < > ( TYPE_2 . class ) ; }
button disposed
public boolean METHOD_1 ( int VAR_1 ) { if ( VAR_1 == TYPE_3 . VAR_3 ) { if ( METHOD_2 ( ) != null ) { METHOD_3 ( true ) ; } else { TYPE_1 . METHOD_4 ( TYPE_2 . METHOD_5 ( ) . METHOD_6 ( ) , Messages . TYPE_4 , Messages . TYPE_5 ) ; } return true ; } else if ( VAR_1 == TYPE_3 . VAR_6 ) { <START> if ( ! VAR_7 . METHOD_7 ( ) ) { <END> METHOD_8 ( ) ; return false ; } return true ; } return false ; }
public boolean METHOD_1 ( int VAR_1 ) { if ( VAR_1 == TYPE_3 . VAR_3 ) { if ( METHOD_2 ( ) != null ) { METHOD_3 ( true ) ; } else { TYPE_1 . METHOD_4 ( TYPE_2 . METHOD_5 ( ) . METHOD_6 ( ) , Messages . TYPE_4 , Messages . TYPE_5 ) ; } return true ; } else if ( VAR_1 == TYPE_3 . VAR_6 ) { METHOD_8 ( ) ; return true ; } return false ; }
done
public TYPE_1 apply ( TYPE_2 VAR_1 ) { <START> VAR_2 = true ; <END> return null ; }
public void apply ( TYPE_2 VAR_1 ) { VAR_2 = true ; }
s meaning 0
public boolean METHOD_1 ( Object request , Object target ) { int VAR_1 = <START> 0 ; <END> if ( request instanceof TYPE_1 ) { VAR_1 = ( ( TYPE_1 ) request ) . METHOD_2 ( ) ; } else if ( request instanceof TYPE_2 ) { VAR_1 = ( ( TYPE_2 ) request ) . VAR_2 ; } return ( VAR_1 == SWT . VAR_3 + SWT . VAR_4 ) ; }
public boolean METHOD_1 ( Object request , Object target ) { int VAR_1 = SWT . NONE ; if ( request instanceof TYPE_1 ) { VAR_1 = ( ( TYPE_1 ) request ) . METHOD_2 ( ) ; } else if ( request instanceof TYPE_2 ) { VAR_1 = ( ( TYPE_2 ) request ) . VAR_2 ; } return ( VAR_1 == SWT . VAR_3 + SWT . VAR_4 ) ; }
I check null
public Object METHOD_1 ( Object VAR_1 ) { <START> METHOD_2 ( ) ; <END> if ( VAR_1 == null ) return null ; return VAR_2 . METHOD_1 ( VAR_3 . METHOD_3 ( VAR_1 ) ) ; }
public Object METHOD_1 ( Object VAR_1 ) { if ( VAR_1 == null ) return null ; METHOD_2 ( ) ; return VAR_2 . METHOD_1 ( VAR_3 . METHOD_3 ( VAR_1 ) ) ; }
ImmutableList builder ( )
public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 , int VAR_2 , TYPE_3 VAR_3 , TYPE_4 VAR_4 ) { <START> List < TYPE_5 > VAR_5 = new ArrayList < > ( ) ; <END> for ( TYPE_6 VAR_6 : VAR_7 ) { VAR_5 . add ( METHOD_2 ( VAR_1 , VAR_3 , VAR_4 , VAR_6 ) ) ; } return new TYPE_1 ( VAR_5 , VAR_8 ) ; }
public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 , int VAR_2 , TYPE_3 VAR_3 , TYPE_4 VAR_4 ) { ImmutableList . Builder < TYPE_5 > VAR_5 = ImmutableList . builder ( ) ; for ( TYPE_6 VAR_6 : VAR_7 ) { VAR_5 . add ( METHOD_2 ( VAR_1 , VAR_3 , VAR_4 , VAR_6 ) ) ; } return new TYPE_1 ( VAR_5 . build ( ) , VAR_8 ) ; }
I null case return type : select pg_typeof ( null : : bigint ) ; pg_typeof - - - - - - - - - - - bigint
public final String METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 < Object > ... args ) { assert args . length == 1 : STRING_1 + args . length ; Object VAR_2 = args [ 0 ] . value ( ) ; <START> return null != VAR_2 ? type : TYPE_4 . TYPE_5 . getName ( ) ; <END> }
public final String METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 < Object > ... args ) { assert args . length == 1 : STRING_1 + args . length ; return type ; }
gotcha ! : - ) please add braces return null ? I automatically put mentally returns indentation
public TYPE_1 METHOD_1 ( ) { TYPE_2 VAR_1 = METHOD_2 ( STRING_1 ) ; if ( VAR_1 . METHOD_3 ( ) ) return null ; <START> return ( TYPE_1 ) TYPE_3 . METHOD_4 ( VAR_1 ) ; <END> }
public TYPE_1 METHOD_1 ( ) { TYPE_2 VAR_1 = METHOD_2 ( STRING_1 ) ; if ( VAR_1 . METHOD_3 ( ) ) { return null ; } return ( TYPE_1 ) TYPE_3 . METHOD_4 ( VAR_1 ) ; }
TYPE_4 imported beginning METHOD_7
private TYPE_1 < Long > METHOD_1 ( TYPE_2 channel , TYPE_3 VAR_1 ) { return METHOD_2 ( VAR_2 . VAR_3 , VAR_4 - > VAR_5 . METHOD_3 ( VAR_1 . METHOD_4 ( ) , VAR_1 . METHOD_5 ( ) , <START> METHOD_6 ( VAR_1 . METHOD_4 ( ) , TYPE_4 . METHOD_7 ( channel ) ) , <END> METHOD_8 ( VAR_1 ) ) , uri , LOGGER , VAR_6 ) ; }
private TYPE_1 < Long > METHOD_1 ( TYPE_2 channel , TYPE_3 VAR_1 ) { return METHOD_2 ( VAR_2 . VAR_3 , VAR_4 - > VAR_5 . METHOD_3 ( VAR_1 . METHOD_4 ( ) , VAR_1 . METHOD_5 ( ) , METHOD_6 ( VAR_1 . METHOD_4 ( ) , METHOD_7 ( channel ) ) , METHOD_8 ( VAR_1 ) ) , uri , LOGGER , VAR_6 ) ; }
stripe - mock
public void METHOD_1 ( ) throws Exception { String VAR_1 = METHOD_2 ( STRING_1 ) ; TYPE_1 resource = TYPE_3 . TYPE_4 . METHOD_3 ( VAR_1 , TYPE_1 . class ) ; assertNotNull ( resource ) ; assertEquals ( STRING_2 , resource . getId ( ) ) ; <START> assertEquals ( STRING_3 , resource . VAR_2 ( ) ) ; <END> }
public void METHOD_1 ( ) throws Exception { final String VAR_1 = METHOD_2 ( STRING_1 ) ; final TYPE_1 resource = TYPE_3 . TYPE_4 . METHOD_3 ( VAR_1 , TYPE_1 . class ) ; assertNotNull ( resource ) ; assertEquals ( STRING_2 , resource . getId ( ) ) ; assertEquals ( STRING_3 , resource . VAR_2 ( ) ) ; }
Log conflicting classes easier tracking
public boolean equals ( Object obj ) { if ( this == obj ) return true ; if ( obj == null ) return false ; if ( getClass ( ) != obj . getClass ( ) ) return false ; <START> throw new RuntimeException ( STRING_1 ) ; <END> }
public boolean equals ( Object obj ) { return this == obj ; }
note METHOD_4 method throws _CODE_ instead returning null VAR_3 isn t please create a test case verify behavior
public void METHOD_1 ( TYPE_1 < ? > message , TYPE_2 VAR_1 ) throws Exception { if ( METHOD_2 ( VAR_1 ) ) { String VAR_2 = ( ( TYPE_3 ) VAR_1 ) . METHOD_3 ( ) . toString ( ) ; TYPE_4 < T > VAR_3 = METHOD_4 ( VAR_2 ) ; <START> if ( VAR_3 != null ) { <END> VAR_3 . METHOD_5 ( message ) ; } else { logger . debug ( STRING_1 , VAR_2 , message ) ; } } }
public void METHOD_1 ( TYPE_1 < ? > message , TYPE_2 VAR_1 ) throws Exception { if ( METHOD_2 ( VAR_1 ) ) { String VAR_2 = ( ( TYPE_3 ) VAR_1 ) . METHOD_3 ( ) . toString ( ) ; METHOD_4 ( VAR_2 ) . METHOD_5 ( message ) ; } }
minor - TYPE_2 s METHOD_7 a null check need VAR_1 METHOD_6 ( ) ! = null
protected void METHOD_1 ( ) { super . METHOD_1 ( ) ; TYPE_1 VAR_1 = ( TYPE_1 ) METHOD_2 ( ) ; METHOD_3 ( ) . METHOD_4 ( VAR_1 != null && VAR_1 . METHOD_5 ( ) <START> && VAR_1 . METHOD_6 ( ) != null <END> && TYPE_2 . VAR_3 . METHOD_7 ( VAR_1 . METHOD_6 ( ) ) <= 0 ) ; }
protected void METHOD_1 ( ) { super . METHOD_1 ( ) ; TYPE_1 VAR_1 = ( TYPE_1 ) METHOD_2 ( ) ; METHOD_3 ( ) . METHOD_4 ( VAR_1 != null && VAR_1 . METHOD_5 ( ) && TYPE_2 . VAR_3 . METHOD_7 ( VAR_1 . METHOD_6 ( ) ) <= 0 ) ; }
a simple setter ( deprecated ) shouldn t mess system property favor deprecated System VAR_2 ( ) dangerous : presume a single JVM process runs 2 solver configs constructed java ( xml ) calls METHOD_1 ( true ) doesn t feel = > remove - else block
public void METHOD_1 ( Boolean VAR_1 ) { if ( TYPE_1 . METHOD_2 ( VAR_1 ) ) { System . VAR_2 ( VAR_3 , STRING_1 ) ; } else { System . VAR_4 ( VAR_3 ) ; } <START> this . VAR_1 = VAR_1 ; <END> }
public void METHOD_1 ( Boolean VAR_1 ) { this . VAR_1 = VAR_1 ; }
save a lines moving return null default case instead break
public static String METHOD_1 ( final int value ) { switch ( value ) { case VAR_1 : return STRING_1 ; case VAR_2 : return STRING_2 ; case VAR_3 : return STRING_3 ; default : break ; } <START> return null ; <END> }
public static String METHOD_1 ( final int value ) { switch ( value ) { case VAR_1 : return STRING_1 ; case VAR_2 : return STRING_2 ; case VAR_3 : return STRING_3 ; default : return null ; } }
need check METHOD_2 ( ) null _CODE_ new audit log user skipped please usage example _CODE_ _CODE_
protected boolean METHOD_1 ( ) { <START> return StringUtils . equals ( METHOD_2 ( ) . METHOD_3 ( ) , getParameters ( ) . METHOD_4 ( ) ) ; <END> }
protected boolean METHOD_1 ( ) { if ( METHOD_2 ( ) == null ) { return false ; } return StringUtils . equals ( METHOD_2 ( ) . METHOD_3 ( ) , getParameters ( ) . METHOD_4 ( ) ) ; }
javafor ( int VAR_4 = 0 ; VAR_4 < INT_1 ; VAR_4 + + ) { changed code : javafor ( int VAR_4 = 0 ; VAR_4 < 100 ; VAR_4 + = 5 ) {
public static boolean METHOD_1 ( TYPE_1 client , String VAR_1 , TYPE_2 VAR_2 , TYPE_3 . Status VAR_3 ) throws TYPE_4 , InterruptedException { for ( int VAR_4 = 0 ; VAR_4 < INT_1 ; VAR_4 ++ ) { TYPE_3 . Status status = METHOD_2 ( client , VAR_1 , VAR_2 ) ; logger . info ( STRING_1 + status ) ; if ( status == VAR_3 ) { return true ; } <START> TimeUnit . VAR_5 . METHOD_3 ( 5 ) ; <END> } return false ; }
public static boolean METHOD_1 ( TYPE_1 client , String VAR_1 , TYPE_2 VAR_2 , TYPE_3 . Status VAR_3 ) throws TYPE_4 , InterruptedException { for ( int VAR_4 = 0 ; VAR_4 < 100 ; VAR_4 += 5 ) { TYPE_3 . Status status = METHOD_2 ( client , VAR_1 , VAR_2 ) ; logger . info ( STRING_1 + status ) ; if ( status == VAR_3 ) { return true ; } TimeUnit . VAR_5 . METHOD_3 ( 5 ) ; } return false ; }
forgot call super METHOD_1 ( )
public void METHOD_1 ( ) throws TYPE_1 { <START> TYPE_2 . METHOD_2 ( this , TYPE_6 . VAR_2 , TYPE_6 . VAR_3 , TYPE_5 . VAR_5 ) ; <END> VAR_6 = TYPE_3 . METHOD_3 ( TYPE_4 . class ) ; METHOD_4 ( ) ; }
public void METHOD_1 ( ) throws TYPE_1 { super . METHOD_1 ( ) ; TYPE_2 . METHOD_2 ( this , TYPE_6 . VAR_2 , TYPE_6 . VAR_3 , TYPE_5 . VAR_5 ) ; VAR_6 = TYPE_3 . METHOD_3 ( TYPE_4 . class ) ; METHOD_4 ( ) ; }
recursive call METHOD_1 ( g m )
public static final void METHOD_1 ( TYPE_1 group , TYPE_2 m ) { for ( TYPE_3 VAR_1 : group . VAR_2 ( ) ) { METHOD_1 ( VAR_1 , m ) ; } for ( TYPE_1 VAR_3 : group . VAR_4 ( ) ) { <START> for ( TYPE_3 VAR_1 : VAR_3 . METHOD_2 ( ) ) { <END> METHOD_1 ( VAR_1 , m ) ; } } }
public static final void METHOD_1 ( TYPE_1 group , TYPE_2 m ) { for ( TYPE_3 VAR_1 : group . VAR_2 ( ) ) { METHOD_1 ( VAR_1 , m ) ; } for ( TYPE_1 VAR_3 : group . VAR_4 ( ) ) { METHOD_1 ( VAR_3 , m ) ; } }
key create VAR_1
public void METHOD_1 ( TYPE_1 task ) { <START> VAR_1 . put ( task . VAR_2 ( ) , task ) ; <END> }
public void METHOD_1 ( TYPE_1 task ) { VAR_1 . put ( task . getId ( ) , task ) ; }
pattern i e return ( TYPE_1 ) TYPE_2 METHOD_2 ( TYPE_1 VAR_2 ) ;
public static TYPE_1 METHOD_1 ( String value ) { <START> TYPE_1 [ ] VAR_1 = TYPE_1 . values ( ) ; <END> for ( TYPE_1 item : VAR_1 ) { if ( item . toString ( ) . equalsIgnoreCase ( value ) ) { return item ; } } return ( TYPE_1 ) TYPE_2 . METHOD_2 ( value , VAR_2 ) ; }
public static TYPE_1 METHOD_1 ( String value ) { return ( TYPE_1 ) TYPE_2 . METHOD_2 ( value , TYPE_1 . VAR_2 ) ; }
simplify : _CODE_ METHOD_2 ( location VAR_5 - > new HashMap < > ( ) ) METHOD_2 ( VAR_2 VAR_5 - > new ArrayList < > ( ) ) add ( VAR_3 ) ;
protected static void METHOD_1 ( Map < String , Map < TYPE_1 , List < TYPE_2 > > > VAR_1 , String location , TYPE_1 VAR_2 , TYPE_2 VAR_3 ) { <START> Map < TYPE_1 , List < TYPE_2 > > VAR_4 = VAR_1 . METHOD_2 ( location , VAR_5 - > new HashMap < > ( ) ) ; List < TYPE_2 > VAR_6 = VAR_4 . METHOD_2 ( VAR_2 , VAR_5 - > new ArrayList < > ( ) ) ; <END> VAR_6 . add ( VAR_3 ) ; }
protected static void METHOD_1 ( Map < String , Map < TYPE_1 , List < TYPE_2 > > > VAR_1 , String location , TYPE_1 VAR_2 , TYPE_2 VAR_3 ) { VAR_1 . METHOD_2 ( location , VAR_5 - > new HashMap < > ( ) ) . METHOD_2 ( VAR_2 , VAR_5 - > new ArrayList < > ( ) ) . add ( VAR_3 ) ; }
constructor private a static factory method
<START> public TYPE_5 ( <END> TYPE_1 VAR_2 , TYPE_2 VAR_3 , TYPE_3 reader , TYPE_4 VAR_4 ) { this . VAR_2 = METHOD_1 ( VAR_2 ) ; this . VAR_3 = METHOD_1 ( VAR_3 ) ; this . reader = METHOD_1 ( reader ) ; this . VAR_4 = METHOD_1 ( VAR_4 ) ; }
private TYPE_5 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 , TYPE_3 reader , TYPE_4 VAR_4 ) { this . VAR_2 = METHOD_1 ( VAR_2 ) ; this . VAR_3 = METHOD_1 ( VAR_3 ) ; this . reader = METHOD_1 ( reader ) ; this . VAR_4 = METHOD_1 ( VAR_4 ) ; }
replace file previous version commit - remove review
public TYPE_4 ( TYPE_1 VAR_2 , TYPE_2 location ) { super ( VAR_2 , TYPE_3 . METHOD_1 ( ) . METHOD_2 ( ) ) ; <START> System . out . println ( STRING_1 + TYPE_3 . METHOD_1 ( ) . METHOD_2 ( ) ) ; <END> METHOD_3 ( location , null , null , null , null ) ; }
public TYPE_4 ( TYPE_1 VAR_2 , TYPE_2 location ) { super ( VAR_2 , TYPE_3 . METHOD_1 ( ) . METHOD_2 ( ) ) ; METHOD_3 ( location , null , null , null , null ) ; }
empty string redundent
private String METHOD_1 ( ) { StringBuilder VAR_1 = new StringBuilder ( "" ) ; <START> for ( TYPE_1 a : TYPE_3 < TYPE_1 > METHOD_2 ( METHOD_3 ( ) ) ) <END> { if ( a . VAR_3 ( ) == TYPE_2 . VAR_5 ) { VAR_1 . append ( a . VAR_6 ( ) ) . append ( STRING_1 ) ; } } return VAR_1 . substring ( 0 , VAR_1 . length ( ) - 2 ) ; }
private String METHOD_1 ( ) { StringBuilder VAR_1 = new StringBuilder ( ) ; for ( TYPE_1 a : TYPE_3 < TYPE_1 > METHOD_2 ( METHOD_3 ( ) ) ) { if ( a . VAR_3 ( ) == TYPE_2 . VAR_5 ) { VAR_1 . append ( a . VAR_6 ( ) ) . append ( STRING_1 ) ; } } return VAR_1 . substring ( 0 , VAR_1 . length ( ) - 2 ) ; }
setting ? class level variables
public void METHOD_1 ( ) { <START> VAR_1 = new TYPE_1 ( ) ; <END> VAR_2 = new TYPE_2 ( ) ; }
public void METHOD_1 ( ) { VAR_2 = new TYPE_2 ( ) ; }
I don t understand ignoring UI event diff base popup selects another field edit mode fixes linked issue A more descriptive commit message VAR_2 widget supposed disabled invisible edit mode
void METHOD_1 ( ANNOTATION_1 ( STRING_1 ) TYPE_1 e ) { int VAR_1 = VAR_2 . METHOD_2 ( ) ; <START> if ( 0 <= VAR_1 && VAR_3 == TYPE_3 . TYPE_2 . VAR_6 ) { <END> String n = VAR_2 . getValue ( VAR_1 ) ; METHOD_3 ( VAR_7 , ! n . isEmpty ( ) ? n : null ) ; } }
void METHOD_1 ( ANNOTATION_1 ( STRING_1 ) TYPE_1 e ) { int VAR_1 = VAR_2 . METHOD_2 ( ) ; if ( 0 <= VAR_1 ) { String n = VAR_2 . getValue ( VAR_1 ) ; METHOD_3 ( VAR_7 , ! n . isEmpty ( ) ? n : null ) ; } }
removed
public String METHOD_1 ( TYPE_1 VAR_1 ) { if ( VAR_2 == null ) { VAR_2 = METHOD_2 ( ) ; } String VAR_3 = VAR_1 . getName ( ) ; final int VAR_4 ; try { VAR_4 = VAR_2 . METHOD_3 ( VAR_3 , VAR_1 ) ; <START> System . out . println ( STRING_1 + VAR_4 + STRING_2 ) ; <END> } catch ( IOException | TYPE_2 e ) { throw new RuntimeException ( e ) ; } return Integer . toString ( VAR_4 ) ; }
public String METHOD_1 ( TYPE_1 VAR_1 ) { final String VAR_3 = VAR_1 . getName ( ) ; final int VAR_4 ; try { VAR_4 = VAR_2 . METHOD_3 ( VAR_3 , VAR_1 ) ; } catch ( IOException | TYPE_2 e ) { throw new RuntimeException ( e ) ; } return Integer . toString ( VAR_4 ) ; }
I testing import declaring type I assume a problem importing a declaring type : condition useless
private boolean METHOD_1 ( TYPE_1 VAR_1 ) { if ( VAR_1 != null ) { <START> if ( ! METHOD_2 ( VAR_1 , false ) && ( METHOD_3 ( VAR_1 ) || METHOD_4 ( VAR_1 ) ) ) { <END> return true ; } if ( ! METHOD_2 ( VAR_1 , false ) && METHOD_5 ( VAR_1 ) ) { return true ; } while ( VAR_1 != null ) { if ( VAR_1 . equals ( VAR_2 ) ) { return true ; } VAR_1 = VAR_1 . METHOD_6 ( ) ; } } return false ; }
private boolean METHOD_1 ( TYPE_1 VAR_1 ) { if ( VAR_1 != null ) { if ( ! METHOD_2 ( VAR_1 , false ) && METHOD_5 ( VAR_1 ) ) { return true ; } if ( METHOD_3 ( VAR_1 ) || METHOD_4 ( VAR_1 ) ) { return true ; } while ( VAR_1 != null ) { if ( VAR_1 . equals ( VAR_2 ) ) { return true ; } VAR_1 = VAR_1 . METHOD_6 ( ) ; } } return false ; }
+ + index
TYPE_3 ( final int VAR_2 ) { this . VAR_3 = new ArrayList < TYPE_1 > ( VAR_2 ) ; <START> for ( int index = 0 ; index < VAR_2 ; index += 1 ) { <END> this . VAR_3 . add ( index , new TYPE_2 ( index ) ) ; } }
TYPE_3 ( final int VAR_2 ) { this . VAR_3 = new ArrayList < TYPE_1 > ( VAR_2 ) ; for ( int index = 0 ; index < VAR_2 ; ++ index ) { this . VAR_3 . add ( index , new TYPE_2 ( index ) ) ; } }
left side preferred style ( annotations extra line )
<START> @Override public String METHOD_1 ( String VAR_1 ) { <END> return VAR_1 ; }
public String METHOD_1 ( String VAR_1 ) { return VAR_1 ; }
throws Exception
private static TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) <START> throws TYPE_3 , TYPE_4 , TYPE_5 , TYPE_6 , <END> TYPE_7 { boolean VAR_2 = new TYPE_8 ( VAR_1 ) . VAR_3 || new TYPE_9 ( VAR_1 ) . VAR_4 . length ( ) > 0 ; return VAR_2 ? TYPE_1 . METHOD_2 ( new TYPE_10 ( VAR_1 ) ) : null ; }
private static TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) throws Exception { boolean VAR_2 = new TYPE_8 ( VAR_1 ) . VAR_3 || new TYPE_9 ( VAR_1 ) . VAR_4 . length ( ) > 0 ; return VAR_2 ? TYPE_1 . METHOD_2 ( new TYPE_10 ( VAR_1 ) ) : null ; }
newly added line DRY some reason : _CODE_ javareturn METHOD_1 ( String valueOf ( ) ) ;
public T METHOD_1 ( int value ) { METHOD_2 ( ) . VAR_1 = String . valueOf ( value ) ; METHOD_2 ( ) . VAR_2 = TYPE_1 . TYPE_2 . VAR_5 ; <START> return METHOD_3 ( ) ; <END> }
public T METHOD_1 ( int value ) { return METHOD_1 ( String . valueOf ( value ) ) ; }
please follow existed coding style put new line override
<START> @Override public void METHOD_1 ( ) throws Exception { <END> }
public void METHOD_1 ( ) throws Exception { }
( VAR_4 ) return true ? need continue looping finding condition correct
boolean METHOD_1 ( TYPE_1 VAR_1 , TYPE_1 VAR_2 ) { boolean VAR_3 = false ; for ( TYPE_2 VAR_4 : VAR_1 . METHOD_2 ( ) ) { <START> VAR_3 |= VAR_4 . METHOD_3 ( ) . METHOD_4 ( ) . equals ( VAR_2 . METHOD_4 ( ) ) ; <END> } return VAR_3 ; }
boolean METHOD_1 ( TYPE_1 VAR_1 , TYPE_1 VAR_2 ) { for ( TYPE_2 VAR_4 : VAR_1 . METHOD_2 ( ) ) { if ( VAR_4 . METHOD_3 ( ) . METHOD_4 ( ) . equals ( VAR_2 . METHOD_4 ( ) ) ) { return true ; } } return false ; }
new echo server test a single tests suffice ? a single suffice declare variables static turn functions
public void METHOD_1 ( ) <START> throws Exception { <END> VAR_1 = TYPE_1 . METHOD_2 ( ) ; TYPE_2 VAR_2 = VAR_1 . METHOD_3 ( ) ; VAR_3 = VAR_2 . METHOD_4 ( ) ; VAR_4 = new TYPE_3 ( VAR_1 , VAR_5 ) ; VAR_4 . start ( ) ; }
public void METHOD_1 ( ) throws Exception { }
needed method
public boolean METHOD_1 ( ) { <START> METHOD_2 ( VAR_1 . get ( ) , STRING_1 ) ; <END> METHOD_3 ( STRING_2 ) ; Optional < Boolean > result = METHOD_4 ( this : : METHOD_5 ) ; return result . VAR_2 ( ( ) - > state . get ( ) != TYPE_1 . VAR_4 || VAR_5 . METHOD_6 ( ) ) ; }
public boolean METHOD_1 ( ) { METHOD_3 ( STRING_2 ) ; Optional < Boolean > result = METHOD_4 ( this : : METHOD_5 ) ; return result . VAR_2 ( ( ) - > state . get ( ) != TYPE_1 . VAR_4 || VAR_5 . METHOD_6 ( ) ) ; }
a 3 param constructor call reduce code rep
<START> public TYPE_3 ( String VAR_2 , String VAR_3 ) { <END> this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; this . VAR_4 = new TYPE_1 ( this ) ; this . start = new TYPE_2 ( this ) ; }
public TYPE_3 ( String VAR_2 , String VAR_3 ) { this ( VAR_2 , null , VAR_3 ) ; }
kind Exception thrown ? more specific ? some other mechanism detecting problem exception detecting ? exceptions slow compared other forms flow control I m concerned a post - aggregator compute function
private double METHOD_1 ( double x ) { try { TYPE_1 VAR_1 = new TYPE_1 ( ) ; return VAR_1 . METHOD_1 ( x ) ; <START> } catch ( Exception ex ) { <END> return Double . TYPE_2 ; } }
private double METHOD_1 ( double x ) { try { TYPE_1 VAR_1 = new TYPE_1 ( ) ; return VAR_1 . METHOD_1 ( x ) ; } catch ( IllegalArgumentException ex ) { return Double . TYPE_2 ; } }
I code apply scan progress
public Response METHOD_1 ( ANNOTATION_1 ( VAR_1 . VAR_2 ) TYPE_1 VAR_3 ) { <START> if ( VAR_4 . METHOD_2 ( ) < 2 ) { <END> return Response . status ( Response . Status . VAR_5 ) . build ( ) ; } return Response . VAR_6 ( ) . build ( ) ; }
public Response METHOD_1 ( ANNOTATION_1 ( VAR_1 . VAR_2 ) TYPE_1 VAR_3 ) { if ( VAR_4 . METHOD_2 ( ) < 1 ) { return Response . status ( Response . Status . VAR_5 ) . build ( ) ; } return Response . VAR_6 ( ) . build ( ) ; }
work ? validate method i expects hashed passwords shouldn t validate ticket _CODE_ methods I delegate _CODE_ method validates password centralize code
public void METHOD_1 ( TYPE_1 user , String VAR_1 , String VAR_2 ) throws TYPE_2 { <START> TYPE_3 . METHOD_2 ( user . VAR_3 ( ) , VAR_1 , user . VAR_4 ( ) ) ; <END> VAR_5 . METHOD_1 ( user , VAR_1 , VAR_2 ) ; }
public void METHOD_1 ( TYPE_1 user , String VAR_1 , String VAR_2 ) throws TYPE_2 { VAR_5 . METHOD_1 ( user , VAR_1 , VAR_2 ) ; }
consider adding VAR_3 _CODE_ ( VAR_4 ) shot Optional
public void METHOD_1 ( long VAR_1 ) { if ( VAR_2 == null ) { <START> Optional < TYPE_1 > VAR_2 = VAR_3 . METHOD_2 ( VAR_4 ) ; <END> METHOD_3 ( VAR_2 . isPresent ( ) , STRING_1 ) ; this . VAR_2 = VAR_2 . get ( ) ; } if ( VAR_1 > 0 ) { VAR_2 . METHOD_4 ( VAR_1 ) ; } else { VAR_2 . METHOD_5 ( - VAR_1 ) ; } }
public void METHOD_1 ( long VAR_1 ) { if ( VAR_2 == null ) { VAR_2 = VAR_3 . METHOD_2 ( VAR_4 ) ; } if ( VAR_1 > 0 ) { VAR_2 . METHOD_4 ( VAR_1 ) ; } else { VAR_2 . METHOD_5 ( - VAR_1 ) ; } }
static import
public void METHOD_1 ( ) throws Exception { METHOD_2 ( ) . assertThat ( new TYPE_1 ( ) ) <START> . METHOD_3 ( p - > METHOD_4 ( p , TYPE_2 . METHOD_5 ( ) ) ) <END> . METHOD_6 ( ) ; }
public void METHOD_1 ( ) throws Exception { METHOD_2 ( ) . assertThat ( new TYPE_1 ( ) ) . METHOD_3 ( p - > METHOD_4 ( p , METHOD_5 ( ) ) ) . METHOD_6 ( ) ; }
synchronized
<START> public void METHOD_1 ( int count ) { <END> VAR_1 = count ; }
public synchronized void METHOD_1 ( int count ) { VAR_1 = count ; }
doesn t aligned original implementation
public TYPE_2 ( ) { <START> METHOD_1 ( TYPE_1 . METHOD_2 ( p - > ! VAR_2 . METHOD_3 ( ) . equals ( p ) ) ) ; <END> }
public TYPE_2 ( ) { METHOD_1 ( TYPE_1 . METHOD_2 ( p - > ! VAR_2 . METHOD_3 ( ) . equals ( getValue ( p ) ) ) ) ; }
rid parenthesis
private boolean METHOD_1 ( ) { <START> return ( VAR_1 == null ) <END> || ( VAR_1 . METHOD_2 ( ) == METHOD_3 ( ) ) ; }
private boolean METHOD_1 ( ) { return VAR_1 == null || VAR_1 . METHOD_2 ( ) == METHOD_3 ( ) ; }
synchronized
<START> void METHOD_1 ( Object VAR_1 ) { <END> this . VAR_1 = VAR_1 ; }
synchronized void METHOD_1 ( Object VAR_1 ) { this . VAR_1 = VAR_1 ; }
public
<START> public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { <END> TYPE_3 < TYPE_2 > VAR_2 = new TYPE_4 < > ( VAR_3 ) ; VAR_2 . METHOD_2 ( VAR_1 ) ; return new TYPE_1 ( this , VAR_2 ) ; }
TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { TYPE_3 < TYPE_2 > VAR_2 = new TYPE_4 < > ( VAR_3 ) ; VAR_2 . METHOD_2 ( VAR_1 ) ; return new TYPE_1 ( this , VAR_2 ) ; }
equals ( ) instead METHOD_3
private TYPE_1 METHOD_1 ( List < TYPE_1 > VAR_1 , List < TYPE_1 > VAR_2 , TYPE_1 child ) { if ( null != child && TYPE_2 . METHOD_2 ( VAR_2 ) ) { for ( TYPE_1 VAR_3 : VAR_2 ) { <START> if ( child . VAR_4 ( ) . METHOD_3 ( VAR_3 . METHOD_4 ( ) ) == 0 ) { <END> VAR_1 . add ( VAR_3 ) ; VAR_2 . remove ( VAR_3 ) ; return VAR_3 ; } } } return null ; }
private TYPE_1 METHOD_1 ( List < TYPE_1 > VAR_1 , List < TYPE_1 > VAR_2 , TYPE_1 child ) { if ( null != child && TYPE_2 . METHOD_2 ( VAR_2 ) ) { for ( TYPE_1 VAR_3 : VAR_2 ) { if ( child . VAR_4 ( ) . equals ( VAR_3 . METHOD_4 ( ) ) ) { VAR_1 . add ( 0 , VAR_3 ) ; VAR_2 . remove ( VAR_3 ) ; return VAR_3 ; } } } return null ; }
move private method public analyze * methods
<START> private void METHOD_1 ( final byte [ ] source ) { <END> final long VAR_1 = TYPE_1 . METHOD_2 ( source ) ; final int version = TYPE_2 . read ( source ) ; final byte [ ] b = TYPE_2 . METHOD_3 ( version , source ) ; final TYPE_3 reader = new TYPE_3 ( b ) ; final TYPE_4 VAR_2 = METHOD_4 ( VAR_1 , reader . VAR_3 ( ) ) ; reader . VAR_4 ( VAR_2 , 0 ) ; }
private void METHOD_1 ( final byte [ ] source ) { final long VAR_1 = TYPE_1 . METHOD_2 ( source ) ; final int version = TYPE_2 . get ( source ) ; final byte [ ] b = TYPE_2 . METHOD_3 ( version , source ) ; final TYPE_3 reader = new TYPE_3 ( b ) ; final TYPE_4 VAR_2 = METHOD_4 ( VAR_1 , reader . VAR_3 ( ) ) ; reader . VAR_4 ( VAR_2 , 0 ) ; }
removing configuration option simplifies methods
public void close ( ) throws TYPE_1 { if ( ! VAR_1 && VAR_2 instanceof TYPE_2 ) { ( ( TYPE_2 ) VAR_2 ) . close ( ) ; } <START> } <END>
public void close ( ) throws TYPE_1 { if ( VAR_2 instanceof TYPE_2 ) { ( ( TYPE_2 ) VAR_2 ) . close ( ) ; } }
style : missing braces
public TYPE_1 METHOD_1 ( File f , TYPE_3 . TYPE_4 VAR_1 ) { <START> if ( VAR_1 . METHOD_2 ( ) ) <END> return TYPE_1 . VAR_2 ; else if ( VAR_1 . METHOD_3 ( ) ) { return TYPE_1 . VAR_3 ; } else if ( VAR_1 . METHOD_4 ( ) ) return TYPE_1 . VAR_4 ; else return TYPE_1 . VAR_5 ; }
public TYPE_1 METHOD_1 ( File f , TYPE_3 . TYPE_4 VAR_1 ) { if ( VAR_1 . METHOD_2 ( ) ) { return TYPE_1 . VAR_2 ; } else if ( VAR_1 . METHOD_3 ( ) ) { return TYPE_1 . VAR_3 ; } else if ( VAR_1 . METHOD_4 ( ) ) { return TYPE_1 . VAR_4 ; } else { return TYPE_1 . VAR_5 ; } }
please StringBuilder
protected TYPE_1 METHOD_1 ( TYPE_2 VAR_1 , TYPE_3 VAR_2 ) { String type = VAR_2 . type ( ) . name ( ) . METHOD_2 ( ) ; if ( VAR_2 . METHOD_3 ( ) ) { for ( int i = 0 ; i < VAR_2 . METHOD_4 ( ) ; i ++ ) { <START> type += STRING_1 ; <END> } } return METHOD_1 ( VAR_1 , type ) ; }
protected TYPE_1 METHOD_1 ( TYPE_2 VAR_1 , TYPE_3 VAR_2 ) { StringBuilder buf = new StringBuilder ( ) . append ( VAR_2 . type ( ) . name ( ) . METHOD_2 ( ) ) ; if ( VAR_2 . METHOD_3 ( ) ) { for ( int i = 0 ; i < VAR_2 . METHOD_4 ( ) ; i ++ ) { buf . append ( STRING_1 ) ; } } return METHOD_1 ( VAR_1 , buf . toString ( ) ) ; }
static import TYPE_3 TYPE_1 TYPE_4 VAR_5
public void METHOD_1 ( ) throws Exception { METHOD_2 ( STRING_1 , VAR_1 , VAR_2 , <START> TYPE_1 . get ( TYPE_2 . METHOD_3 ( ) , TYPE_3 : : METHOD_4 ) . METHOD_5 ( TYPE_3 . TYPE_1 . TYPE_4 . VAR_5 ) ) ; <END> }
public void METHOD_1 ( ) throws Exception { METHOD_2 ( STRING_1 , VAR_1 , VAR_2 , TYPE_1 . get ( TYPE_2 . METHOD_3 ( ) , TYPE_3 : : METHOD_4 ) . METHOD_5 ( VAR_5 ) ) ; }
a convention typically responsibility _CODE_ ( ) method extract style change figure _CODE_ ( ) typically calls _CODE_ ( ) methods method reads style notation calls _CODE_ ( ) _CODE_ _CODE_ ( ) methods protected subclasses adapt behavior install listeners ( case I doubt ll override _CODE_ _CODE_ )
protected void METHOD_1 ( ) { TYPE_1 VAR_1 = ( TYPE_1 ) METHOD_2 ( ) ; <START> TYPE_2 VAR_2 = VAR_1 . METHOD_3 ( TYPE_6 . TYPE_5 . VAR_5 , STRING_1 ) ; <END> if ( VAR_2 instanceof TYPE_3 ) { METHOD_4 ( ( TYPE_3 ) VAR_2 ) ; } else { ( ( TYPE_4 ) METHOD_5 ( ) ) . METHOD_6 ( 0 ) ; } super . METHOD_1 ( ) ; }
protected void METHOD_1 ( ) { METHOD_4 ( ) ; super . METHOD_1 ( ) ; }
weird calling METHOD_3
@Override public void METHOD_1 ( ANNOTATION_1 TYPE_1 VAR_1 , TYPE_1 VAR_2 , TYPE_5 . TYPE_7 VAR_3 , Context VAR_4 , TYPE_5 . TYPE_6 VAR_5 ) { if ( VAR_6 == null ) { VAR_6 = new TYPE_4 ( VAR_7 ) ; VAR_6 . METHOD_2 ( TYPE_8 . VAR_9 ) ; } VAR_6 . setText ( VAR_2 . getKey ( ) . toString ( ) ) ; <START> VAR_7 . METHOD_3 ( VAR_6 ) ; <END> VAR_5 . METHOD_4 ( ) ; }
@Override public void METHOD_1 ( ANNOTATION_1 TYPE_1 VAR_1 , TYPE_1 VAR_2 , TYPE_5 . TYPE_7 VAR_3 , Context VAR_4 , TYPE_5 . TYPE_6 VAR_5 ) { if ( VAR_6 == null ) { VAR_6 = new TYPE_4 ( VAR_7 ) ; VAR_6 . METHOD_2 ( TYPE_8 . VAR_9 ) ; VAR_7 . METHOD_3 ( VAR_6 ) ; } VAR_6 . setText ( VAR_2 . getKey ( ) . toString ( ) ) ; VAR_5 . METHOD_4 ( ) ; }
return returned called METHOD_1
public String METHOD_1 ( TYPE_1 < ? > element ) { <START> return "" ; <END> }
public String METHOD_1 ( TYPE_1 < ? > element ) { return element . getValue ( ) . toString ( ) ; }
_CODE_ modules throw exception _CODE_ _CODE_ ( ) instead calling System exit ( )
public TYPE_3 ( ) { <START> TYPE_1 . METHOD_1 ( ) ; <END> VAR_2 = new TYPE_2 ( ) ; }
public TYPE_3 ( ) { VAR_2 = new TYPE_2 ( ) ; }
removing public access modifier methods invisible package break code methods other packages please update PR public access modifier :
<START> void METHOD_1 ( String to ) { <END> if ( to != null && ! "" . equals ( to ) ) { to = to . VAR_1 ( STRING_1 , STRING_2 ) ; props . put ( STRING_3 , to ) ; } }
public void METHOD_1 ( String to ) { if ( to != null && ! "" . equals ( to ) ) { to = to . VAR_1 ( STRING_1 , STRING_2 ) ; props . put ( STRING_3 , to ) ; } }
I method final others similar reason final methods
<START> private void METHOD_1 ( ) throws TYPE_1 { <END> when ( VAR_1 . METHOD_2 ( VAR_2 + VAR_3 , VAR_2 + VAR_4 , VAR_2 + VAR_5 , VAR_2 + VAR_6 ) ) . METHOD_3 ( new TYPE_2 ( VAR_7 ) ) ; when ( VAR_1 . METHOD_2 ( VAR_2 + VAR_3 , VAR_2 + VAR_4 , VAR_2 + VAR_5 , VAR_2 + VAR_8 ) ) . METHOD_3 ( new TYPE_2 ( VAR_9 ) ) ; }
private final void METHOD_1 ( ) throws TYPE_1 { when ( VAR_1 . METHOD_2 ( VAR_2 + VAR_3 , VAR_2 + VAR_4 , VAR_2 + VAR_5 , VAR_2 + VAR_6 ) ) . METHOD_3 ( new TYPE_2 ( VAR_7 ) ) ; when ( VAR_1 . METHOD_2 ( VAR_2 + VAR_3 , VAR_2 + VAR_4 , VAR_2 + VAR_5 , VAR_2 + VAR_8 ) ) . METHOD_3 ( new TYPE_2 ( VAR_9 ) ) ; }
notice : s preferable manage comparison < = instead = =
public TYPE_1 METHOD_1 ( Object [ ] VAR_1 ) { String VAR_2 = "" ; <START> if ( VAR_1 . length == 0 ) { <END> VAR_2 = VAR_3 ; } else { final Object VAR_4 = VAR_1 [ 0 ] ; if ( VAR_1 . length != 1 || false == VAR_4 instanceof TYPE_2 || ( VAR_4 instanceof TYPE_2 && false == ( ( TYPE_2 ) VAR_4 ) . getType ( ) instanceof TYPE_3 ) ) { VAR_2 = Messages . TYPE_4 ; } } return METHOD_2 ( VAR_2 ) ; }
public TYPE_1 METHOD_1 ( Object [ ] VAR_1 ) { String VAR_2 = "" ; if ( VAR_1 . length <= 0 ) { VAR_2 = VAR_3 ; } else { final Object VAR_4 = VAR_1 [ 0 ] ; if ( VAR_1 . length != 1 || false == VAR_4 instanceof TYPE_2 || ( VAR_4 instanceof TYPE_2 && false == ( ( TYPE_2 ) VAR_4 ) . getType ( ) instanceof TYPE_3 ) ) { VAR_2 = Messages . TYPE_4 ; } } return METHOD_2 ( VAR_2 ) ; }
efficient looses short circuit property Boolean logic
public boolean METHOD_1 ( int VAR_1 , TYPE_1 VAR_2 ) { if ( VAR_1 == VAR_3 ) { boolean VAR_4 = TYPE_2 . METHOD_2 ( VAR_2 ) ; boolean VAR_5 = TYPE_2 . METHOD_3 ( VAR_2 ) ; TYPE_3 filter = METHOD_4 ( ) ; boolean VAR_6 = filter == null ; boolean VAR_7 = TYPE_2 . METHOD_5 ( VAR_2 , filter ) ; <START> return VAR_4 && ( VAR_5 || VAR_6 || VAR_7 ) ; <END> } return false ; }
public boolean METHOD_1 ( int VAR_1 , TYPE_1 VAR_2 ) { if ( VAR_1 == VAR_3 ) { if ( ! TYPE_2 . METHOD_2 ( VAR_2 ) ) return false ; if ( TYPE_2 . METHOD_3 ( VAR_2 ) ) return true ; TYPE_3 filter = METHOD_4 ( ) ; return filter == null || TYPE_2 . METHOD_5 ( VAR_2 , filter ) ; } return false ; }