ReviewComments stringlengths 1 2.35k | OriginalCode stringlengths 28 487 | ReviewedCode stringlengths 14 463 |
|---|---|---|
A HTTP header named treated invalid I refuse construction coerce | private boolean METHOD_1 ( TYPE_1 request ) { if ( VAR_1 == null <START> || VAR_1 . length ( ) == 0 ) { <END> return false ; } return request . VAR_2 ( VAR_1 ) == null ; } | private boolean METHOD_1 ( TYPE_1 request ) { if ( VAR_1 == null ) return false ; return request . VAR_2 ( VAR_1 ) == null ; } |
METHOD_1 info level a _CODE_ another hop enable debug topology | private void METHOD_1 ( List < List < Object > > VAR_1 , List < TYPE_1 > VAR_2 ) { for ( int i = 0 ; i < VAR_1 . size ( ) ; i ++ ) { TYPE_1 VAR_3 = VAR_2 . get ( i ) ; Object VAR_4 = ( ( TYPE_2 ) VAR_3 ) . METHOD_2 ( ) ; <START> LOG . debug ( STRING_1 , VAR_5 , VAR_1 . get ( i ) , VAR_4 ) ; <END> } } | private void METHOD_1 ( List < List < Object > > VAR_1 , List < TYPE_1 > VAR_2 ) { for ( int i = 0 ; i < VAR_1 . size ( ) ; i ++ ) { TYPE_1 VAR_3 = VAR_2 . get ( i ) ; Object VAR_4 = ( ( TYPE_2 ) VAR_3 ) . METHOD_2 ( ) ; LOG . info ( STRING_1 , VAR_5 , VAR_1 . get ( i ) , VAR_4 ) ; } } |
omitted | public TYPE_2 ( String VAR_2 , String VAR_3 , List < TYPE_1 > VAR_4 ) { <START> super ( ) ; <END> this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; this . VAR_4 = new ArrayList < TYPE_1 > ( VAR_4 ) ; } | public TYPE_2 ( String VAR_2 , String VAR_3 , List < TYPE_1 > VAR_4 ) { this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; this . VAR_4 = new ArrayList < TYPE_1 > ( VAR_4 ) ; } |
change ( VAR_2 new TYPE_6 ( ) ) | public TYPE_7 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 , TYPE_3 VAR_4 ) { <START> super ( VAR_2 ) ; <END> this . response = new TYPE_4 ( ) ; this . VAR_5 = new TYPE_5 ( ) ; this . VAR_3 = VAR_3 ; this . VAR_4 = VAR_4 ; this . VAR_6 = new TYPE_6 ( ) ; } | public TYPE_7 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 , TYPE_3 VAR_4 ) { this ( VAR_2 , VAR_3 , VAR_4 , new TYPE_6 ( ) ) ; } |
I don t feel good constructor counter - intuitive VAR_3 argument VAR_3 embededed VAR_2 object a access | <START> public TYPE_4 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 ) { <END> super ( VAR_2 ) ; VAR_4 = VAR_3 ; VAR_5 = new TYPE_3 ( VAR_4 ) ; } | public TYPE_4 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 ) { super ( VAR_2 ) ; VAR_4 = VAR_3 ; } |
I d remove guard simply return null ( VAR_1 set null session left a realm - null transport detached ) | public long METHOD_1 ( ) { <START> if ( ! METHOD_2 ( ) ) { <END> throw new IllegalStateException ( STRING_1 ) ; } return VAR_1 ; } | public long METHOD_1 ( ) { return VAR_1 ; } |
shouldn t return TYPE_1 error ( e ) | static public < T > TYPE_1 < T > METHOD_1 ( TYPE_2 < TYPE_1 < T > > VAR_1 , TYPE_3 VAR_2 ) { if ( VAR_2 == null ) { return TYPE_1 . METHOD_2 ( ( ) - > { try { return VAR_1 . call ( ) ; } catch ( Exception e ) { <START> return TYPE_4 . error ( e ) ; <END> } } ) ; } else { return TYPE_5 . METHOD_3 ( ( ) - > VAR_1 . call ... | static public < T > TYPE_1 < T > METHOD_1 ( TYPE_2 < TYPE_1 < T > > VAR_1 , TYPE_3 VAR_2 ) { if ( VAR_2 == null ) { return TYPE_1 . METHOD_2 ( ( ) - > { try { return VAR_1 . call ( ) ; } catch ( Exception e ) { return TYPE_1 . error ( e ) ; } } ) ; } else { return TYPE_5 . METHOD_3 ( ( ) - > VAR_1 . call ( ) , VAR_2 ) ... |
style : missing braces | public int METHOD_1 ( ) { <START> if ( VAR_1 == null ) <END> return 0 ; return VAR_1 . VAR_2 ; } | public int METHOD_1 ( ) { if ( VAR_1 == null ) { return 0 ; } return VAR_1 . VAR_2 ; } |
reason METHOD_1 ( VAR_1 null ) ? METHOD_3 ( ) handles null callbacks similar question similar functions | public TYPE_1 < TYPE_2 > METHOD_1 ( String VAR_1 ) { TYPE_3 < TYPE_2 > VAR_2 = new TYPE_3 < TYPE_2 > ( ) ; TYPE_4 VAR_3 = METHOD_2 ( ) ; if ( VAR_3 == null ) { METHOD_3 ( VAR_2 , null , null , VAR_4 ) ; } else { VAR_3 . METHOD_1 ( VAR_1 , VAR_2 , null ) ; } <START> return VAR_2 ; <END> } | public TYPE_1 < TYPE_2 > METHOD_1 ( String VAR_1 ) { return METHOD_1 ( VAR_1 , null ) ; } |
talked real _CODE_ want | public void METHOD_1 ( ) { <START> VAR_1 . METHOD_2 ( VAR_2 , STRING_1 ) ; <END> System . VAR_3 ( TYPE_1 . VAR_5 , STRING_2 ) ; METHOD_3 ( false ) ; } | public void METHOD_1 ( ) { METHOD_3 ( false ) ; } |
lambda | public TYPE_7 ( TYPE_1 parent , TYPE_2 VAR_2 ) { super ( parent , VAR_2 , SWT . VAR_3 | SWT . VAR_4 | SWT . VAR_5 ) ; TYPE_3 . METHOD_1 ( this ) ; METHOD_2 ( this ) ; METHOD_3 ( this ) ; TYPE_4 . METHOD_4 ( ) ; METHOD_5 ( new TYPE_5 ( ) { @Override <START> public void METHOD_6 ( TYPE_6 e ) { <END> TYPE_3 . METHOD_7 ( T... | public TYPE_7 ( TYPE_1 parent , TYPE_2 VAR_2 ) { super ( parent , VAR_2 , SWT . VAR_3 | SWT . VAR_4 | SWT . VAR_5 ) ; TYPE_3 . METHOD_1 ( this ) ; METHOD_2 ( this ) ; METHOD_3 ( this ) ; TYPE_4 . METHOD_4 ( ) ; METHOD_5 ( ( e ) - > { TYPE_3 . METHOD_7 ( TYPE_7 . VAR_6 ) ; } ) ; } |
I store actual Map instead return map wrapped unmodifiable map extra allocations operation unmodifiable wrappers internally aren t needed | private Map < String , TYPE_1 > METHOD_1 ( Integer s , Map < String , TYPE_1 > VAR_1 ) { if ( VAR_1 == null ) { return Collections . VAR_2 ( VAR_3 , TYPE_1 . METHOD_2 ( VAR_4 ) ) ; } else { Map < String , TYPE_1 > VAR_5 = new HashMap < > ( VAR_1 ) ; VAR_5 . METHOD_3 ( VAR_3 , this : : METHOD_4 ) ; <START> return Collec... | private Map < String , TYPE_1 > METHOD_1 ( Integer s , Map < String , TYPE_1 > VAR_1 ) { if ( VAR_1 == null ) { return Collections . VAR_2 ( VAR_3 , TYPE_1 . METHOD_2 ( VAR_4 ) ) ; } else { Map < String , TYPE_1 > VAR_5 = new HashMap < > ( VAR_1 ) ; VAR_5 . METHOD_3 ( VAR_3 , this : : METHOD_4 ) ; return VAR_5 ; } } |
Map | <START> private HashMap < String , String > METHOD_1 ( ) { <END> HashMap < String , String > params = new HashMap < > ( ) ; params . put ( VAR_1 , METHOD_2 ( name ) ) ; params . put ( VAR_2 , VAR_3 ) ; params . put ( VAR_4 , VAR_5 ) ; return params ; } | private Map < String , String > METHOD_1 ( ) { HashMap < String , String > params = new HashMap < > ( ) ; params . put ( VAR_1 , METHOD_2 ( name ) ) ; params . put ( VAR_2 , VAR_3 ) ; params . put ( VAR_4 , VAR_5 ) ; return params ; } |
METHOD_3 METHOD_1 | public String METHOD_1 ( ) { TYPE_1 VAR_1 = this . METHOD_2 ( ) ; if ( VAR_1 == null ) return null ; <START> return VAR_1 . METHOD_3 ( ) ; <END> } | public String METHOD_1 ( ) { return METHOD_3 ( ) ; } |
ImmutableList VAR_4 ( | public TYPE_1 ( List < Type > VAR_2 , List < Type > VAR_3 ) { this . VAR_2 = ImmutableList . VAR_4 ( VAR_2 ) ; <START> this . VAR_3 = VAR_3 ; <END> } | public TYPE_1 ( List < Type > VAR_2 , List < Type > VAR_3 ) { this . VAR_2 = ImmutableList . VAR_4 ( VAR_2 ) ; this . VAR_3 = ImmutableList . VAR_4 ( VAR_3 ) ; } |
lines moved _CODE_ class instead user _CODE_ check ( _CODE_ ) | public boolean METHOD_1 ( ) { if ( VAR_1 . METHOD_2 ( ) ) { <START> return VAR_1 . METHOD_3 ( ) . METHOD_4 ( ) ; <END> } return VAR_1 . METHOD_1 ( ) ; } | public boolean METHOD_1 ( ) { return VAR_1 . METHOD_1 ( ) ; } |
rely _CODE_ toString | public void METHOD_1 ( List < String > VAR_1 ) { log . debug ( STRING_1 , <START> Arrays . toString ( VAR_1 . METHOD_2 ( ) ) ) ; <END> VAR_1 . forEach ( TYPE_1 : : METHOD_3 ) ; } | public void METHOD_1 ( List < String > VAR_1 ) { log . debug ( STRING_1 , VAR_1 ) ; VAR_1 . forEach ( TYPE_1 : : METHOD_3 ) ; } |
suggestionreturn VAR_2 METHOD_4 ( ) + STRING_1 + VAR_3 ; | public String METHOD_1 ( String VAR_1 ) { TYPE_1 VAR_2 = METHOD_2 ( VAR_1 ) ; if ( VAR_2 == null ) { return null ; } String VAR_3 = VAR_2 . METHOD_3 ( ) ; if ( VAR_3 . isEmpty ( ) ) { return VAR_2 . METHOD_4 ( ) ; } <START> return VAR_2 . METHOD_4 ( ) + STRING_1 + VAR_2 . METHOD_3 ( ) ; <END> } | public String METHOD_1 ( String VAR_1 ) { TYPE_1 VAR_2 = METHOD_2 ( VAR_1 ) ; if ( VAR_2 == null ) { return null ; } String VAR_3 = VAR_2 . METHOD_3 ( ) ; if ( VAR_3 . isEmpty ( ) ) { return VAR_2 . METHOD_4 ( ) ; } return VAR_2 . METHOD_4 ( ) + STRING_1 + VAR_3 ; } |
public static call live test avoid code duplication | <START> private void METHOD_1 ( Map < String , List < String > > VAR_1 , String VAR_2 , <END> String ... VAR_3 ) { assertTrue ( VAR_1 . containsKey ( VAR_2 ) , STRING_1 + VAR_2 ) ; assertEquals ( VAR_1 . get ( VAR_2 ) . size ( ) , VAR_3 . length , STRING_2 + VAR_2 ) ; assertTrue ( VAR_1 . get ( VAR_2 ) . METHOD_2 ( Arr... | public static void METHOD_1 ( Map < String , List < String > > VAR_1 , String VAR_2 , String ... VAR_3 ) { assertTrue ( VAR_1 . containsKey ( VAR_2 ) , STRING_1 + VAR_2 ) ; assertEquals ( VAR_1 . get ( VAR_2 ) . size ( ) , VAR_3 . length , STRING_2 + VAR_2 ) ; assertTrue ( VAR_1 . get ( VAR_2 ) . METHOD_2 ( Arrays . as... |
couldn t check VAR_2 null ? wouldn t need _CODE_ variable | private void METHOD_1 ( ) { if ( ! VAR_1 ) return ; <START> if ( ! METHOD_2 ( ) ) { <END> throw VAR_2 ; } } | private void METHOD_1 ( ) { if ( ! VAR_1 ) return ; if ( VAR_2 != null ) { throw VAR_2 ; } } |
logger | public void METHOD_1 ( Class < ? > VAR_1 ) { <START> System . out . println ( STRING_1 + VAR_1 . getName ( ) ) ; <END> VAR_2 . add ( VAR_1 ) ; } | public void METHOD_1 ( Class < ? > VAR_1 ) { VAR_2 . add ( VAR_1 ) ; } |
constructor called builder remove public modifier | <START> public TYPE_2 ( boolean VAR_2 , TYPE_1 VAR_3 ) { <END> this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; } | TYPE_2 ( boolean VAR_2 , TYPE_1 VAR_3 ) { this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; } |
historically String type _CODE_ s production _CODE_ please fix type String modules ( user|member : virt : loa ) thank | public TYPE_1 METHOD_1 ( ) { TYPE_1 VAR_1 = new TYPE_1 ( ) ; VAR_1 . METHOD_2 ( TYPE_2 . VAR_3 ) ; VAR_1 . METHOD_3 ( STRING_1 ) ; VAR_1 . METHOD_4 ( STRING_2 ) ; <START> VAR_1 . METHOD_5 ( Integer . VAR_4 . getName ( ) ) ; <END> VAR_1 . METHOD_6 ( STRING_3 ) ; return VAR_1 ; } | public TYPE_1 METHOD_1 ( ) { TYPE_1 VAR_1 = new TYPE_1 ( ) ; VAR_1 . METHOD_2 ( TYPE_2 . VAR_3 ) ; VAR_1 . METHOD_3 ( STRING_1 ) ; VAR_1 . METHOD_4 ( STRING_2 ) ; VAR_1 . METHOD_5 ( String . VAR_4 . getName ( ) ) ; VAR_1 . METHOD_6 ( STRING_3 ) ; return VAR_1 ; } |
suggestion useful put TYPE_2 code a special case attribute I don t issues | public TYPE_4 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 ) { this . VAR_4 = ( TYPE_3 ) VAR_2 . METHOD_1 ( ) ; this . VAR_5 = VAR_3 ; this . VAR_6 = ( Integer ) VAR_5 . getValue ( VAR_7 , VAR_2 ) ; this . VAR_8 = ( Double ) VAR_5 . getValue ( VAR_9 , VAR_2 ) ; <START> this . VAR_10 = METHOD_2 ( VAR_5 . getValue ( VAR_11 , VAR_2 ) ) ... | public TYPE_4 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 ) { this . VAR_4 = ( TYPE_3 ) VAR_2 . METHOD_1 ( ) ; this . VAR_5 = VAR_3 ; this . VAR_6 = ( Integer ) VAR_5 . getValue ( VAR_7 , VAR_2 ) ; this . VAR_8 = ( Double ) VAR_5 . getValue ( VAR_9 , VAR_2 ) ; this . VAR_10 = VAR_5 . METHOD_2 ( VAR_5 . getValue ( VAR_11 , VAR_2 ) ) ... |
s public | <START> TYPE_1 ( String VAR_2 ) { <END> this . VAR_2 = VAR_2 ; } | public TYPE_1 ( String VAR_2 ) { this . VAR_2 = VAR_2 ; } |
I understand start column replaced * * calcite need check * | public static List < TYPE_1 > METHOD_1 ( String ... VAR_1 ) { List < TYPE_1 > VAR_2 = new ArrayList < > ( ) ; for ( String name : VAR_1 ) { if ( name . equals ( TYPE_1 . VAR_3 ) || <START> name . equals ( STRING_1 ) ) { <END> VAR_2 . add ( TYPE_1 . VAR_4 ) ; } else { VAR_2 . add ( TYPE_1 . METHOD_2 ( name ) ) ; } } ret... | public static List < TYPE_1 > METHOD_1 ( String ... VAR_1 ) { List < TYPE_1 > VAR_2 = new ArrayList < > ( ) ; for ( String name : VAR_1 ) { if ( name . equals ( TYPE_1 . VAR_3 ) ) { VAR_2 . add ( TYPE_1 . VAR_4 ) ; } else { VAR_2 . add ( TYPE_1 . METHOD_2 ( name ) ) ; } } return VAR_2 ; } |
static import | private static String METHOD_1 ( TYPE_1 node ) { <START> TYPE_2 . METHOD_2 ( node . VAR_1 ( ) ) ; <END> return node . VAR_2 ( ) ? null : node . VAR_3 ( ) ; } | private static String METHOD_1 ( TYPE_1 node ) { METHOD_2 ( node . VAR_1 ( ) ) ; return node . VAR_2 ( ) ? null : node . VAR_3 ( ) ; } |
assertions necessary ? checking VAR_7 size ( ) = = 0 | public void METHOD_1 ( ) { when ( VAR_1 . METHOD_2 ( ) ) . METHOD_3 ( TYPE_2 . VAR_3 ) ; final String [ ] result = page . VAR_4 ( TYPE_1 . VAR_6 ) ; final List < String > VAR_7 = Arrays . asList ( result ) ; <START> METHOD_4 ( VAR_7 . contains ( STRING_1 ) ) ; <END> METHOD_4 ( VAR_7 . contains ( STRING_2 ) ) ; assertEq... | public void METHOD_1 ( ) { when ( VAR_1 . METHOD_2 ( ) ) . METHOD_3 ( TYPE_2 . VAR_3 ) ; final String [ ] result = page . VAR_4 ( TYPE_1 . VAR_6 ) ; final List < String > VAR_7 = Arrays . asList ( result ) ; assertEquals ( 0 , VAR_7 . size ( ) ) ; } |
main logic run : counter - intuitive more a style issue : _CODE_ ( ) METHOD_3 ( ) run asynchronously | public static TYPE_1 < ? > METHOD_1 ( final Context context , final long VAR_1 ) { if ( TYPE_2 . METHOD_2 ( ) ) { TYPE_3 . METHOD_3 ( context , TYPE_4 . METHOD_4 ( VAR_1 ) . METHOD_5 ( ) , false ) ; } <START> return METHOD_6 ( context , VAR_1 ) ; <END> } | public static TYPE_1 < ? > METHOD_1 ( final Context context , final long VAR_1 ) { TYPE_1 res = METHOD_6 ( context , VAR_1 ) ; if ( TYPE_2 . METHOD_2 ( ) ) { TYPE_3 . METHOD_3 ( context , TYPE_4 . METHOD_4 ( VAR_1 ) . METHOD_5 ( ) , false ) ; } return res ; } |
combine line | public void METHOD_1 ( TYPE_1 response ) throws Exception { VAR_1 [ VAR_2 ] = new TYPE_2 ( VAR_3 , response ) ; <START> VAR_4 . METHOD_2 ( ) ; <END> if ( VAR_4 . get ( ) == 0 ) { VAR_5 . METHOD_1 ( VAR_1 ) ; } } | public void METHOD_1 ( TYPE_1 response ) throws Exception { VAR_1 [ VAR_2 ] = new TYPE_2 ( VAR_3 , response ) ; if ( VAR_4 . METHOD_2 ( ) == 0 ) { VAR_5 . METHOD_1 ( VAR_1 ) ; } } |
I prefer IllegalArgumentException | public synchronized TYPE_1 METHOD_1 ( TYPE_2 VAR_1 , TYPE_3 VAR_2 ) { if ( VAR_1 == null ) throw new TYPE_4 ( STRING_1 ) ; <START> if ( VAR_2 == null ) throw new TYPE_4 ( STRING_2 ) ; <END> org . VAR_3 . VAR_4 . VAR_5 . TYPE_5 project = get ( VAR_1 ) ; if ( project == null ) throw new TYPE_4 ( STRING_3 + VAR_1 + STRING... | public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 , TYPE_3 VAR_2 ) { if ( VAR_1 == null ) throw new IllegalStateException ( STRING_1 ) ; if ( VAR_2 == null ) throw new IllegalStateException ( STRING_2 ) ; org . VAR_3 . VAR_4 . VAR_5 . TYPE_5 project = get ( VAR_1 ) ; if ( project == null ) throw new TYPE_4 ( STRING_3 + VAR_1 + STR... |
convert conditional expression ( ? : ) | protected boolean METHOD_1 ( TYPE_1 VAR_1 , Object parent , Object element ) { if ( element instanceof TYPE_2 ) { if ( METHOD_2 ( ) && VAR_1 instanceof TYPE_3 ) { TYPE_2 VAR_2 = ( TYPE_2 ) element ; <START> if ( VAR_2 . METHOD_3 ( ) . length > 0 ) { return METHOD_4 ( ( TYPE_3 ) VAR_1 , VAR_2 ) ; } return false ; <END> ... | protected boolean METHOD_1 ( TYPE_1 VAR_1 , Object parent , Object element ) { if ( element instanceof TYPE_2 ) { if ( METHOD_2 ( ) && VAR_1 instanceof TYPE_3 ) { TYPE_2 VAR_2 = ( TYPE_2 ) element ; return VAR_2 . METHOD_3 ( ) . length > 0 ? METHOD_4 ( ( TYPE_3 ) VAR_1 , VAR_2 ) : false ; } } return true ; } |
remove sorting don t convert a List JSON serialization prints a Set a JSON array | public Response METHOD_1 ( ) throws Exception { TYPE_1 session = METHOD_2 ( ) . METHOD_3 ( METHOD_4 ( ) . METHOD_3 ( ) ) ; <START> List < String > VAR_1 = new ArrayList < String > ( session . VAR_2 ( ) . METHOD_5 ( ) ) ; <END> Collections . VAR_3 ( VAR_1 ) ; return METHOD_6 ( VAR_1 ) ; } | public Response METHOD_1 ( ) throws Exception { TYPE_1 session = METHOD_2 ( ) . METHOD_3 ( METHOD_4 ( ) . METHOD_3 ( ) ) ; Set < String > VAR_1 = session . VAR_2 ( ) . METHOD_5 ( ) ; return METHOD_6 ( VAR_1 ) ; } |
duplicate - null check ( done TYPE_4 ) | public boolean METHOD_1 ( final TYPE_1 from , final TYPE_2 event , final TYPE_1 to ) { <START> TYPE_3 . METHOD_2 ( from , STRING_1 ) ; <END> TYPE_3 . METHOD_2 ( event , STRING_2 ) ; TYPE_3 . METHOD_2 ( to , STRING_3 ) ; TYPE_4 VAR_1 = new TYPE_4 ( from , event , to ) ; return METHOD_1 ( VAR_1 ) ; } | public boolean METHOD_1 ( final TYPE_1 from , final TYPE_2 event , final TYPE_1 to ) { return METHOD_1 ( new TYPE_4 ( from , event , to ) ) ; } |
convulotions list array | Type METHOD_1 ( List < Type > VAR_1 ) { <START> return VAR_2 . METHOD_1 ( VAR_1 . METHOD_2 ( new Type [ VAR_1 . size ( ) ] ) ) ; <END> } | Type METHOD_1 ( List < Type > VAR_1 ) { return VAR_2 . METHOD_1 ( VAR_1 ) ; } |
thread safe needs done startup / postconstruct | public Response METHOD_1 ( ANNOTATION_1 TYPE_1 VAR_1 , ANNOTATION_1 TYPE_2 VAR_2 , ANNOTATION_2 ( STRING_1 ) String type , ANNOTATION_1 TYPE_3 config , ANNOTATION_1 TYPE_4 VAR_3 ) throws Exception { <START> METHOD_2 ( VAR_4 ) ; <END> Response response = super . METHOD_3 ( VAR_1 , config , VAR_3 , VAR_2 , type ) ; respo... | public Response METHOD_1 ( ANNOTATION_1 TYPE_1 VAR_1 , ANNOTATION_1 TYPE_2 VAR_2 , ANNOTATION_2 ( STRING_1 ) String type , ANNOTATION_1 TYPE_3 config , ANNOTATION_1 TYPE_4 VAR_3 ) throws Exception { Response response = METHOD_3 ( VAR_1 , config , VAR_3 , VAR_2 , type ) ; response . VAR_5 ( ) . add ( STRING_2 , STRING_3... |
I m builders creating children time worth differently | public Optional < TYPE_1 > build ( ) { if ( this . VAR_1 ) { try { METHOD_1 ( ) ; } catch ( Exception e ) { throw logger . VAR_2 ( e ) ; } return Optional . of ( new TYPE_1 ( VAR_3 , VAR_4 ) ) ; } <START> return Optional . empty ( ) ; <END> } | public TYPE_1 build ( ) { if ( this . VAR_1 ) { try { METHOD_1 ( ) ; } catch ( Exception e ) { throw logger . VAR_2 ( e ) ; } return new TYPE_1 ( VAR_3 , VAR_4 ) ; } return null ; } |
METHOD_3 ( ) METHOD_4 ( ) ! = null | protected void METHOD_1 ( ) { final TYPE_1 VAR_1 = METHOD_2 ( ) ; final Collection < TYPE_1 > VAR_2 = VAR_3 == null ? new ArrayList < TYPE_1 > ( ) : VAR_3 ; <START> if ( METHOD_3 ( ) . METHOD_4 ( ) != VAR_2 ) { <END> METHOD_3 ( ) . METHOD_5 ( VAR_2 , VAR_1 ) ; } else { METHOD_3 ( ) . METHOD_6 ( VAR_1 ) ; } } | protected void METHOD_1 ( ) { final TYPE_1 VAR_1 = METHOD_2 ( ) ; final Collection < TYPE_1 > VAR_2 = VAR_3 == null ? new ArrayList < TYPE_1 > ( ) : VAR_3 ; if ( METHOD_3 ( ) . METHOD_4 ( ) == null ) { METHOD_3 ( ) . METHOD_5 ( VAR_2 , VAR_1 ) ; } else { METHOD_3 ( ) . METHOD_6 ( VAR_1 ) ; } } |
need a super ( ) | public TYPE_1 ( ) throws IOException { <START> super ( ) ; <END> } | public TYPE_1 ( ) throws IOException { } |
isn t a item present return idea ? save mapping complete list return ( IIUC ) | private Guid METHOD_1 ( Guid VAR_1 , TYPE_1 type , TYPE_2 status ) { return METHOD_2 ( VAR_1 , type , <START> status ) . stream ( ) . map ( TYPE_3 : : getId ) . METHOD_3 ( ) . METHOD_4 ( Guid . TYPE_4 ) ; <END> } | private Guid METHOD_1 ( Guid VAR_1 , TYPE_1 type , TYPE_2 status ) { return METHOD_2 ( VAR_1 , type , status ) . stream ( ) . METHOD_3 ( ) . map ( TYPE_3 : : getId ) . METHOD_4 ( Guid . TYPE_4 ) ; } |
doesn t need public s called file | <START> public static List < TYPE_1 > METHOD_1 ( TYPE_2 query ) <END> { return TYPE_3 . METHOD_2 ( query . VAR_1 ( ) , query . VAR_2 ( ) . METHOD_3 ( query . VAR_3 ( ) ) ) ; } | private static List < TYPE_1 > METHOD_1 ( TYPE_2 query ) { return TYPE_3 . METHOD_2 ( query . VAR_1 ( ) , query . VAR_2 ( ) . METHOD_3 ( query . VAR_3 ( ) ) ) ; } |
I put method _CODE_ ( ) group methods logical call order | <START> private boolean METHOD_1 ( TYPE_1 VAR_1 ) { <END> if ( VAR_1 . is ( TYPE_7 . TYPE_6 . VAR_4 ) ) { TYPE_2 VAR_5 = ( TYPE_2 ) VAR_1 ; TYPE_3 TYPE_4 = METHOD_2 ( VAR_5 ) ; return TYPE_5 . stream ( ) . METHOD_3 ( TYPE_4 : : equals ) ; } return false ; } | private boolean METHOD_1 ( TYPE_1 VAR_1 ) { if ( VAR_1 . is ( TYPE_7 . TYPE_6 . VAR_4 ) ) { TYPE_3 TYPE_4 = METHOD_2 ( ( TYPE_2 ) VAR_1 ) ; return TYPE_5 . stream ( ) . METHOD_3 ( TYPE_4 : : equals ) ; } return false ; } |
removing response some figured request coming response time future | private TYPE_1 METHOD_1 ( ) { final TYPE_1 VAR_1 = TYPE_1 . get ( request ) ; return VAR_1 . VAR_2 ? VAR_1 : <START> TYPE_2 . METHOD_2 ( ) . METHOD_3 ( user , request , uri , response ) ; <END> } | private TYPE_1 METHOD_1 ( ) { final TYPE_1 VAR_1 = TYPE_1 . get ( request ) ; return VAR_1 . VAR_2 ? VAR_1 : TYPE_2 . METHOD_2 ( ) . METHOD_3 ( user , request , uri ) ; } |
I d put other : + 1 : need locks temp dir won t change ( shouldn t ) | public File METHOD_1 ( ) { if ( VAR_1 == null ) { VAR_1 = METHOD_2 ( ) ; if ( VAR_1 == null ) { VAR_1 = METHOD_3 ( ) ; <START> } <END> } return VAR_1 . METHOD_4 ( ) ; } | public File METHOD_1 ( ) { if ( VAR_1 == null ) { VAR_1 = METHOD_2 ( ) ; } if ( VAR_1 == null ) { VAR_1 = METHOD_3 ( ) ; } return VAR_1 . METHOD_4 ( ) ; } |
remove else return block | public boolean METHOD_1 ( TYPE_1 VAR_1 ) { VAR_2 = VAR_1 . getMessage ( ) . split ( STRING_1 ) [ 0 ] ; if ( VAR_2 . METHOD_1 ( VAR_3 ) ) { return VAR_1 . getMessage ( ) . contains ( VAR_4 ) == VAR_5 ; <START> } else { <END> return false ; } } | public boolean METHOD_1 ( TYPE_1 VAR_1 ) { VAR_2 = VAR_1 . getMessage ( ) . split ( STRING_1 ) [ 0 ] ; if ( VAR_2 . METHOD_1 ( VAR_3 ) ) { return VAR_1 . getMessage ( ) . contains ( VAR_4 ) == VAR_5 ; } return false ; } |
I method need static | <START> private static void METHOD_1 ( Collection < Pair < Object , String > > result , String element ) { <END> if ( element . length ( ) > 0 ) { List < String > list = Arrays . asList ( element . split ( STRING_1 ) ) ; list . forEach ( VAR_1 - > { String value = VAR_1 . split ( STRING_2 ) [ 0 ] ; result . add ( new P... | private void METHOD_1 ( Collection < Pair < Object , String > > result , String element ) { if ( element . length ( ) > 0 ) { List < String > list = Arrays . asList ( element . split ( STRING_1 ) ) ; list . forEach ( VAR_1 - > { String value = VAR_1 . split ( STRING_2 ) [ 0 ] ; result . add ( new Pair < > ( value , val... |
unnecessary else return VAR_4 statement | public List < String > METHOD_1 ( final String VAR_1 ) throws TYPE_1 { List < TYPE_2 > VAR_2 = VAR_3 . METHOD_1 ( VAR_1 ) ; List < String > VAR_4 = new ArrayList < > ( ) ; if ( null != VAR_2 && ! VAR_2 . isEmpty ( ) ) { for ( TYPE_2 VAR_5 : VAR_2 ) { VAR_4 . add ( VAR_5 . METHOD_2 ( ) ) ; } return VAR_4 ; <START> } els... | public List < String > METHOD_1 ( final String VAR_1 ) throws TYPE_1 { List < TYPE_2 > VAR_2 = VAR_3 . METHOD_1 ( VAR_1 ) ; List < String > VAR_4 = new ArrayList < > ( ) ; if ( null != VAR_2 && ! VAR_2 . isEmpty ( ) ) { for ( TYPE_2 VAR_5 : VAR_2 ) { VAR_4 . add ( VAR_5 . METHOD_2 ( ) ) ; } } return VAR_4 ; } |
I thought default false | public void METHOD_1 ( ) { VAR_1 = VAR_2 ; VAR_3 = true ; VAR_4 = true ; VAR_5 = false ; VAR_6 = false ; <START> VAR_7 = true ; <END> VAR_8 = null ; VAR_9 = null ; VAR_10 = null ; VAR_11 = null ; } | public void METHOD_1 ( ) { VAR_1 = VAR_2 ; VAR_3 = true ; VAR_4 = true ; VAR_5 = false ; VAR_6 = false ; VAR_7 = false ; VAR_8 = null ; VAR_9 = null ; VAR_10 = null ; VAR_11 = null ; } |
reverse return ? I missed itteration | public static boolean METHOD_1 ( final String VAR_1 , final String VAR_2 ) { if ( ! METHOD_2 ( VAR_1 ) ) { return false ; } if ( ! METHOD_3 ( VAR_2 ) ) { return false ; } final TYPE_1 VAR_3 = new TYPE_1 ( VAR_2 ) ; VAR_3 . METHOD_4 ( true ) ; final boolean VAR_4 = VAR_3 . METHOD_5 ( ) . METHOD_6 ( VAR_1 ) ; <START> ret... | public static boolean METHOD_1 ( final String VAR_1 , final String VAR_2 ) { if ( ! METHOD_2 ( VAR_1 ) ) { return false ; } if ( ! METHOD_3 ( VAR_2 ) ) { return false ; } final TYPE_1 VAR_3 = new TYPE_1 ( VAR_2 ) ; VAR_3 . METHOD_4 ( true ) ; final boolean VAR_4 = VAR_3 . METHOD_5 ( ) . METHOD_6 ( VAR_1 ) ; return VAR_... |
isn t true default | public void METHOD_1 ( final TYPE_1 object ) { super . METHOD_1 ( object ) ; if ( object . VAR_1 ( ) ) { object . VAR_2 ( ) . METHOD_2 ( 1 ) ; } <START> VAR_3 . METHOD_3 ( true ) ; <END> } | public void METHOD_1 ( final TYPE_1 object ) { super . METHOD_1 ( object ) ; if ( object . VAR_1 ( ) ) { object . VAR_2 ( ) . METHOD_2 ( 1 ) ; } } |
handle case ctx null consider returning null throwing a IllegalStateException similar other methods _CODE_ java | public String [ ] METHOD_1 ( long VAR_1 ) { <START> ctx . VAR_2 ( VAR_1 ) ; <END> return TYPE_1 . METHOD_1 ( VAR_1 ) ; } | public String [ ] METHOD_1 ( long VAR_1 ) { if ( ctx != null ) ctx . VAR_2 ( VAR_1 ) ; return TYPE_1 . METHOD_1 ( VAR_1 ) ; } |
remove | public synchronized boolean METHOD_1 ( ) { if ( ( Boolean ) METHOD_2 ( ) . get ( STRING_1 ) && METHOD_3 ( ) == null ) { METHOD_4 ( METHOD_5 ( ) ) ; <START> log . error ( STRING_2 ) ; <END> return true ; } return false ; } | public synchronized boolean METHOD_1 ( ) { if ( ( Boolean ) METHOD_2 ( ) . get ( STRING_1 ) && METHOD_3 ( ) == null ) { METHOD_4 ( METHOD_5 ( ) ) ; return true ; } return false ; } |
convert VAR_2 a local variable _CODE_ ( ) doreturn new TYPE_1 ( VAR_4 _CODE_ ( ) ) ; | public TYPE_5 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 ) throws IOException { <START> this . VAR_2 = new TYPE_1 ( VAR_2 ) ; <END> this . VAR_4 = TYPE_3 . get ( this . VAR_2 ) ; this . VAR_5 = new TYPE_4 ( this . VAR_2 ) ; this . VAR_3 = VAR_3 ; this . VAR_6 = true ; } | public TYPE_5 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 ) throws IOException { VAR_2 = new TYPE_1 ( VAR_2 ) ; this . VAR_4 = TYPE_3 . get ( VAR_2 ) ; this . VAR_5 = new TYPE_4 ( VAR_2 ) ; this . VAR_3 = VAR_3 ; } |
white space changes | ANNOTATION_1 public void METHOD_1 ( ) throws TYPE_1 { final TYPE_2 parser = TYPE_2 . METHOD_2 ( STRING_1 ) ; assertEquals ( STRING_2 , parser . type . name ) ; assertEquals ( STRING_3 , parser . VAR_1 ) ; assertEquals ( STRING_4 , parser . version . toString ( ) ) ; <START> assertEquals ( STRING_5 , parser . VAR_2 ) ; ... | public void METHOD_1 ( ) throws TYPE_1 { final TYPE_2 parser = TYPE_2 . METHOD_2 ( STRING_1 ) ; assertEquals ( STRING_2 , parser . type . name ) ; assertEquals ( STRING_3 , parser . VAR_1 ) ; assertEquals ( STRING_4 , parser . version . toString ( ) ) ; assertEquals ( STRING_5 , parser . VAR_2 ) ; assertEquals ( STRING... |
related fix t rid extra _CODE_ operation METHOD_2 ( ) ctor | public void METHOD_1 ( ) throws Exception { <START> this . VAR_1 = this . VAR_2 . METHOD_2 ( ) ; <END> Assert . VAR_3 ( this . VAR_1 , STRING_1 ) ; } | public void METHOD_1 ( ) throws Exception { } |
status repeated I guess original code | public int METHOD_1 ( ) { return TYPE_1 . METHOD_2 ( VAR_1 , VAR_2 , VAR_3 , VAR_4 , status , description , <START> status <END> ) ; } | public int METHOD_1 ( ) { return TYPE_1 . METHOD_2 ( VAR_1 , VAR_2 , VAR_3 , VAR_4 , description , status ) ; } |
line | public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { return new TYPE_3 ( ) . METHOD_2 ( STRING_1 , new TYPE_4 ( ) ) . METHOD_2 ( STRING_2 , new TYPE_4 ( ) ) . METHOD_2 ( STRING_3 , new TYPE_4 ( ) ) . METHOD_2 ( STRING_4 , new TYPE_4 ( ) ) . METHOD_2 ( STRING_5 , new TYPE_4 ( ) ) . METHOD_2 ( STRING_6 , new TYPE_4 ( ) ) . METHOD_2... | public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { return new TYPE_3 ( ) . METHOD_2 ( STRING_1 , new TYPE_4 ( ) ) . METHOD_2 ( STRING_3 , new TYPE_4 ( ) ) . METHOD_2 ( STRING_4 , new TYPE_4 ( ) ) . METHOD_2 ( STRING_5 , new TYPE_4 ( ) ) . METHOD_2 ( STRING_6 , new TYPE_4 ( ) ) . METHOD_2 ( STRING_7 , new TYPE_4 ( ) ) ; } |
please import | public String METHOD_1 ( ) throws IOException { if ( VAR_1 == null ) { <START> throw new TYPE_4 . TYPE_5 . TYPE_2 ( STRING_1 ) ; <END> } return ( ( TYPE_3 ) VAR_1 ) . METHOD_1 ( ) ; } | public String METHOD_1 ( ) throws IOException { if ( VAR_1 == null ) { throw new TYPE_2 ( STRING_1 ) ; } return ( ( TYPE_3 ) VAR_1 ) . METHOD_1 ( ) ; } |
1 means | public void METHOD_1 ( final String VAR_1 ) throws IOException { try { new TYPE_1 ( this . VAR_2 . source ( ) ) . METHOD_2 ( STRING_1 ) . set ( this . VAR_3 ) . set ( VAR_1 ) <START> . set ( 1 ) <END> . METHOD_3 ( TYPE_3 . VAR_5 ) ; } catch ( final TYPE_2 ex ) { throw new IOException ( ex ) ; } } | public void METHOD_1 ( final String VAR_1 ) throws IOException { try { new TYPE_1 ( this . VAR_2 . source ( ) ) . METHOD_2 ( STRING_1 ) . set ( this . VAR_3 ) . set ( VAR_1 ) . set ( true ) . METHOD_3 ( TYPE_3 . VAR_5 ) ; } catch ( final TYPE_2 ex ) { throw new IOException ( ex ) ; } } |
false = > true ( changing _CODE_ ) | public TYPE_2 ( TYPE_1 parameters ) { <START> super ( parameters , false ) ; <END> } | public TYPE_2 ( TYPE_1 parameters ) { super ( parameters , true ) ; } |
unnecessary cast long | void run ( ) { if ( VAR_1 ) { return ; } TYPE_1 < ? super Long > VAR_2 = this . VAR_2 ; long e = VAR_3 ; for ( long i = index ; i != e && get ( ) == 0 ; i ++ ) { <START> VAR_2 . METHOD_1 ( ( long ) i ) ; <END> } if ( get ( ) == 0 ) { METHOD_2 ( 1 ) ; VAR_2 . METHOD_3 ( ) ; } } | void run ( ) { if ( VAR_1 ) { return ; } TYPE_1 < ? super Long > VAR_2 = this . VAR_2 ; long e = VAR_3 ; for ( long i = index ; i != e && get ( ) == 0 ; i ++ ) { VAR_2 . METHOD_1 ( i ) ; } if ( get ( ) == 0 ) { METHOD_2 ( 1 ) ; VAR_2 . METHOD_3 ( ) ; } } |
a situation some VAR_3 lost I meant VAR_2 map moment call method more elements processed loop VAR_2 backed VAR_3 map | private void METHOD_1 ( TYPE_1 VAR_1 ) { final TYPE_2 < TYPE_1 , TYPE_3 > VAR_2 = VAR_3 . METHOD_2 ( VAR_1 , true ) ; for ( TYPE_3 VAR_4 : VAR_2 . values ( ) ) VAR_4 . run ( ) ; <START> VAR_2 . clear ( ) ; <END> } | private void METHOD_1 ( TYPE_1 VAR_1 ) { final Iterator < TYPE_3 > VAR_2 = VAR_3 . METHOD_2 ( VAR_1 , true ) . values ( ) . iterator ( ) ; while ( VAR_2 . hasNext ( ) ) { VAR_2 . next ( ) . run ( ) ; VAR_2 . remove ( ) ; } } |
unused args | public void METHOD_1 ( ) { METHOD_2 ( ) . METHOD_3 ( VAR_1 , VAR_2 ) ; <START> Object [ ] args = { VAR_3 , VAR_2 , false } ; <END> METHOD_4 ( VAR_4 . create ( VAR_3 , true ) . apply ( VAR_2 ) , STRING_1 ) ; } | public void METHOD_1 ( ) { METHOD_2 ( ) . METHOD_3 ( VAR_1 , VAR_2 ) ; METHOD_4 ( VAR_4 . create ( VAR_3 , true ) . apply ( VAR_2 ) , STRING_1 ) ; } |
a good implementation spatial reference instance shared instances geometry coming dataset VAR_3 size contribute OGC types don t enforce geometry side | public long METHOD_1 ( ) { return VAR_1 + ( VAR_2 != null ? VAR_2 . METHOD_1 ( ) : 0 ) + <START> ( VAR_3 != null ? VAR_3 . METHOD_1 ( ) : 0 ) ; <END> } | public long METHOD_1 ( ) { return VAR_1 + ( VAR_2 != null ? VAR_2 . METHOD_1 ( ) : 0 ) ; } |
cases reverse ? ( i e don t instantiate logger audit logging ) | public void METHOD_1 ( T request , TYPE_1 response , TYPE_2 VAR_1 , TYPE_3 target , String VAR_2 , String VAR_3 , Boolean VAR_4 , TYPE_4 VAR_5 , String VAR_6 ) { LOG . trace ( STRING_1 ) ; <START> if ( METHOD_2 ( ) != null && METHOD_3 ( VAR_6 ) ) { <END> METHOD_2 ( ) . METHOD_1 ( request , response , VAR_1 , target , V... | public void METHOD_1 ( T request , TYPE_1 response , TYPE_2 VAR_1 , TYPE_3 target , String VAR_2 , String VAR_3 , Boolean VAR_4 , TYPE_4 VAR_5 , String VAR_6 ) { LOG . trace ( STRING_1 ) ; if ( METHOD_3 ( VAR_6 ) && METHOD_2 ( ) != null ) { METHOD_2 ( ) . METHOD_1 ( request , response , VAR_1 , target , VAR_2 , VAR_3 ,... |
I VAR_8 converted a local variable ( instead member variable ) ? TYPE_6 extends layer a reference TYPE_5 superclass renderer layers METHOD_1 ( ) | public TYPE_6 ( TYPE_1 map , TYPE_2 VAR_2 ) { if ( VAR_2 == null ) { throw new IllegalArgumentException ( STRING_1 ) ; } VAR_3 = null ; TYPE_3 parser = new TYPE_3 ( VAR_2 ) ; VAR_3 = parser . VAR_4 ( ) ; HashMap < TYPE_4 , Object > VAR_5 = new HashMap < > ( ) ; for ( TYPE_4 VAR_6 : parser . VAR_7 ( ) ) { VAR_5 . put ( ... | public TYPE_6 ( TYPE_1 map , TYPE_2 VAR_2 ) { if ( VAR_2 == null ) { throw new IllegalArgumentException ( STRING_1 ) ; } VAR_3 = null ; TYPE_3 parser = new TYPE_3 ( VAR_2 ) ; VAR_3 = parser . VAR_4 ( ) ; HashMap < TYPE_4 , Object > VAR_5 = new HashMap < > ( ) ; for ( TYPE_4 VAR_6 : parser . VAR_7 ( ) ) { VAR_5 . put ( ... |
condition incorporated loop | protected int METHOD_1 ( int [ ] VAR_1 , int VAR_2 , int VAR_3 ) { int VAR_4 = 0 ; int length = 0 ; for ( int i = VAR_2 ; i < VAR_1 . length ; i ++ ) { length ++ ; if ( VAR_5 != VAR_1 [ i ] ) { VAR_4 ++ ; } <START> if ( VAR_4 == VAR_3 ) { <END> break ; } } return length ; } | protected int METHOD_1 ( int [ ] VAR_1 , int VAR_2 , int VAR_3 ) { int VAR_4 = 0 ; int length = 0 ; for ( int i = VAR_2 ; i < VAR_1 . length && VAR_4 < VAR_3 ; i ++ ) { length ++ ; if ( VAR_5 != VAR_1 [ i ] ) { VAR_4 ++ ; } } return length ; } |
I throw TYPE_5 caller deal else want else log error | <START> protected TYPE_1 METHOD_1 ( String model , TYPE_2 config , TYPE_3 session ) { <END> TYPE_4 VAR_1 = null ; try { VAR_1 = new TYPE_4 ( model , config , session ) ; } catch ( TYPE_5 e ) { TYPE_6 . METHOD_2 ( ) . METHOD_3 ( ) . log ( e . getStatus ( ) ) ; } return VAR_1 ; } | protected TYPE_1 METHOD_1 ( String model , TYPE_2 config , TYPE_3 session ) throws TYPE_5 { return new TYPE_4 ( model , config , session ) ; } |
protected | <START> public TYPE_1 ( ) { <END> } | protected TYPE_1 ( ) { this ( null ) ; } |
I expect METHOD_2 size - 1 cases | private int METHOD_1 ( Object o , int index ) { if ( o instanceof TYPE_1 ) { TYPE_2 VAR_1 = ( ( TYPE_1 ) o ) . get ( index ) ; int size ; if ( VAR_1 instanceof TYPE_3 ) size = 0 ; else <START> size = VAR_1 . METHOD_2 ( ) . size ( ) ; <END> return size ; } if ( o instanceof List ) { return ( ( List < TYPE_4 > ) o ) . ge... | private int METHOD_1 ( Object o , int index ) { if ( o instanceof TYPE_1 ) { TYPE_2 VAR_1 = ( ( TYPE_1 ) o ) . get ( index ) ; return VAR_1 . METHOD_1 ( ) ; } if ( o instanceof List ) { return ( ( List < TYPE_4 > ) o ) . get ( index ) . METHOD_1 ( ) ; } throw new IllegalStateException ( STRING_1 ) ; } |
TYPE_3 METHOD_2 ( ) handle | private TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { final TYPE_1 VAR_2 = new TYPE_1 ( ) ; TYPE_3 . METHOD_2 ( VAR_1 , VAR_2 ) ; if ( VAR_1 . METHOD_3 ( ) != null ) { VAR_2 . METHOD_4 ( TYPE_4 . METHOD_5 ( STRING_1 , VAR_1 . METHOD_3 ( ) ) ) ; } <START> VAR_2 . METHOD_6 ( VAR_1 . METHOD_7 ( ) ) ; <END> return VAR_2 ; } | private TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { final TYPE_1 VAR_2 = new TYPE_1 ( ) ; TYPE_3 . METHOD_2 ( VAR_1 , VAR_2 ) ; if ( VAR_1 . METHOD_3 ( ) != null ) { VAR_2 . METHOD_4 ( TYPE_4 . METHOD_5 ( STRING_1 , VAR_1 . METHOD_3 ( ) ) ) ; } return VAR_2 ; } |
return | protected boolean METHOD_1 ( TYPE_1 VAR_1 ) { if ( VAR_1 == this || VAR_1 instanceof TYPE_2 ) { return true ; } <START> return false ; <END> } | protected boolean METHOD_1 ( TYPE_1 VAR_1 ) { return VAR_1 == this || VAR_1 instanceof TYPE_2 ; } |
A minor optimization create new ArrayList VAR_1 init size node + edge | private Collection < TYPE_1 > METHOD_1 ( ) { List < TYPE_1 > result = new ArrayList < > ( ) ; result . addAll ( VAR_1 ) ; <START> result . addAll ( VAR_2 ) ; <END> return result ; } | private Collection < TYPE_1 > METHOD_1 ( ) { List < TYPE_1 > result = new ArrayList < > ( VAR_1 . size ( ) + VAR_2 . size ( ) ) ; result . addAll ( VAR_1 ) ; result . addAll ( VAR_2 ) ; return result ; } |
VAR_1 ! = null redundant VAR_1 instanceof TYPE_1 returns false VAR_1 null | @Override public boolean equals ( Object VAR_1 ) { <START> return VAR_1 != null && ( VAR_1 instanceof TYPE_1 ) && TYPE_2 . equals ( name , ( ( TYPE_1 ) VAR_1 ) . name ) ; <END> } | @Override public boolean equals ( Object VAR_1 ) { return ( VAR_1 instanceof TYPE_1 ) && TYPE_2 . equals ( name , ( ( TYPE_1 ) VAR_1 ) . name ) ; } |
I agree a lot sense topic debatable point view private static sense because1 ) emphasizes fact method doesn t depend other class members ( doesn t internal state ) 2 ) JVM doesn t pass parameter _CODE_ points call - fi : ) | <START> public static boolean METHOD_1 ( String VAR_1 , String text , boolean VAR_2 ) { <END> return VAR_2 ? StringUtils . VAR_3 ( VAR_1 , text ) : StringUtils . contains ( VAR_1 , text ) ; } | private boolean METHOD_1 ( String VAR_1 , String text , boolean VAR_2 ) { return VAR_2 ? StringUtils . VAR_3 ( VAR_1 , text ) : StringUtils . contains ( VAR_1 , text ) ; } |
File | public <START> List < String > METHOD_1 ( ) <END> { return new ArrayList < > ( VAR_1 ) ; } | public List < File > METHOD_1 ( ) { return new ArrayList < > ( VAR_1 ) ; } |
need METHOD_2 s implementation TYPE_1 METHOD_2 bind interface RPC REST dispatchers implementations | protected void METHOD_1 ( ) { <START> METHOD_2 ( TYPE_1 . class ) . to ( builder . VAR_1 ( ) ) . in ( TYPE_2 . class ) ; <END> bind ( TYPE_3 . class ) . to ( TYPE_4 . class ) . in ( TYPE_2 . class ) ; bind ( TYPE_5 . class ) . to ( TYPE_6 . class ) . in ( TYPE_2 . class ) ; } | protected void METHOD_1 ( ) { bind ( TYPE_1 . class ) . to ( builder . VAR_1 ( ) ) . in ( TYPE_2 . class ) ; bind ( TYPE_3 . class ) . to ( TYPE_4 . class ) . in ( TYPE_2 . class ) ; bind ( TYPE_5 . class ) . to ( TYPE_6 . class ) . in ( TYPE_2 . class ) ; } |
log necessary | protected void METHOD_1 ( ) { <START> TYPE_1 . log ( this . toString ( ) + STRING_1 ) ; <END> VAR_1 . METHOD_1 ( METHOD_2 ( ) , new TYPE_2 ( view ) , context . getStatus ( ) . METHOD_3 ( ) ) ; } | protected void METHOD_1 ( ) { VAR_1 . METHOD_1 ( METHOD_2 ( ) , new TYPE_2 ( view ) , context . getStatus ( ) . METHOD_3 ( ) ) ; } |
super implied | public TYPE_2 ( ) { <START> super ( ) ; <END> VAR_2 = new TYPE_1 ( this ) ; } | public TYPE_2 ( ) { VAR_2 = new TYPE_1 ( this ) ; } |
I : _CODE_ _CODE_ ( ) changes please | <START> public TYPE_1 ( ) { <END> super ( ) ; } | TYPE_1 ( ) { super ( ) ; } |
generated a _CODE_ exception VAR_6 _CODE_ Map a id current storage managers | public TYPE_1 METHOD_1 ( String VAR_1 , String [ ] VAR_2 ) throws TYPE_2 { final long VAR_3 = Long . VAR_4 ( VAR_1 ) ; METHOD_2 ( VAR_3 ) ; final TYPE_3 result = new TYPE_3 ( VAR_2 ) ; <START> result . VAR_5 ( VAR_6 . METHOD_3 ( VAR_3 ) ) ; <END> return result ; } | public TYPE_1 METHOD_1 ( String VAR_1 , String [ ] VAR_2 ) throws TYPE_2 { final long VAR_3 = Long . VAR_4 ( VAR_1 ) ; METHOD_2 ( VAR_3 ) ; final TYPE_3 result = new TYPE_3 ( VAR_2 ) ; if ( result != null ) result . VAR_5 ( VAR_6 . METHOD_3 ( VAR_3 ) ) ; return result ; } |
[ bit ] prefer inline conditionals kind stuff : javarequest = VAR_1 ? METHOD_1 ( request VAR_2 ) : METHOD_2 ( request ) ; | public TYPE_1 filter ( TYPE_1 request ) throws TYPE_2 { if ( this . VAR_1 ) { request = METHOD_1 ( request , this . VAR_2 ) ; } else { request = METHOD_2 ( request ) ; <START> } <END> VAR_3 . METHOD_3 ( VAR_4 , request , STRING_1 ) ; return request ; } | public TYPE_1 filter ( TYPE_1 request ) throws TYPE_2 { request = this . VAR_1 ? METHOD_1 ( request , this . VAR_2 ) : METHOD_2 ( request ) ; VAR_3 . METHOD_3 ( VAR_4 , request , STRING_1 ) ; return request ; } |
add version check default - record - store client initiated operations caught | public void METHOD_1 ( TYPE_1 key , long VAR_1 , TimeUnit VAR_2 ) { <START> if ( METHOD_2 ( ) . METHOD_3 ( ) . METHOD_4 ( ) . METHOD_5 ( TYPE_3 . VAR_4 ) ) { <END> throw new TYPE_2 ( STRING_1 ) ; } METHOD_6 ( key ) ; METHOD_7 ( key , VAR_1 , VAR_2 ) ; } | public void METHOD_1 ( TYPE_1 key , long VAR_1 , TimeUnit VAR_2 ) { METHOD_6 ( key ) ; METHOD_6 ( VAR_2 ) ; METHOD_7 ( key , VAR_1 , VAR_2 ) ; } |
_CODE_ synchronized ? I need more _CODE_ stuff determine behaviour correct methods I hope provide correct answer | <START> public TYPE_1 METHOD_1 ( String name ) { <END> TYPE_1 channel = this . VAR_1 . METHOD_2 ( name ) ; if ( channel == null ) { channel = this . VAR_1 . METHOD_3 ( name ) ; METHOD_4 ( name , channel ) ; } return channel ; } | public synchronized TYPE_1 METHOD_1 ( String name ) { TYPE_1 channel = this . VAR_1 . METHOD_2 ( name ) ; if ( channel == null ) { channel = this . VAR_1 . METHOD_3 ( name ) ; METHOD_4 ( name , channel ) ; } return channel ; } |
METHOD_3 _CODE_ | protected TYPE_1 METHOD_1 ( ANNOTATION_1 final TYPE_2 VAR_1 , ANNOTATION_1 TYPE_3 session ) { return new TYPE_1 ( ) { @Override public void METHOD_2 ( ANNOTATION_1 TYPE_4 o ) { <START> super . METHOD_2 ( o ) ; <END> METHOD_3 ( o . VAR_2 ( ) , o . VAR_3 ( ) , VAR_1 ) ; } @Override public void METHOD_4 ( ANNOTATION_1 TYP... | protected TYPE_1 METHOD_1 ( ANNOTATION_1 final TYPE_2 VAR_1 , ANNOTATION_1 TYPE_3 session ) { return new TYPE_1 ( ) { @Override public void METHOD_2 ( ANNOTATION_1 TYPE_4 o ) { METHOD_3 ( o . VAR_2 ( ) , o . VAR_3 ( ) , VAR_1 ) ; } @Override public void METHOD_4 ( ANNOTATION_1 TYPE_5 o ) { METHOD_3 ( o . VAR_2 ( ) , o ... |
sense METHOD_1 ( ) final : suggestionthis = VAR_2 METHOD_2 ( ) ; readers code methods jump understand code | public TYPE_2 ( TYPE_1 VAR_2 ) { super ( VAR_2 ) ; <START> this . name = this . METHOD_1 ( ) . METHOD_2 ( ) ; <END> } | public TYPE_2 ( TYPE_1 VAR_2 ) { super ( VAR_2 ) ; this . name = VAR_2 . METHOD_2 ( ) ; } |
longer | public void start ( ) { VAR_1 = TYPE_1 . METHOD_1 ( cache . getName ( ) ) ; this . VAR_2 = configuration . VAR_3 ( ) . METHOD_2 ( ) . METHOD_3 ( ) ; this . VAR_4 = configuration . VAR_3 ( ) . METHOD_4 ( ) . METHOD_5 ( ) ; <START> this . VAR_5 = configuration . VAR_6 ( ) . METHOD_6 ( ) . METHOD_7 ( ) || configuration . ... | public void start ( ) { VAR_1 = TYPE_1 . METHOD_1 ( cache . getName ( ) ) ; this . VAR_2 = configuration . VAR_3 ( ) . METHOD_2 ( ) . METHOD_3 ( ) ; this . VAR_4 = configuration . VAR_3 ( ) . METHOD_4 ( ) . METHOD_5 ( ) ; } |
I _CODE_ ( ) VAR_4 ( ) I agree stick method code loggers | private TYPE_1 METHOD_1 ( ) { String VAR_1 = null ; TYPE_1 url = null ; try { VAR_1 = VAR_2 . METHOD_2 ( VAR_3 ) ; } catch ( TYPE_2 ex ) { <START> LOG . error ( STRING_1 , ex . VAR_4 ( ) , ex ) ; <END> } try { url = new TYPE_1 ( VAR_1 ) ; } catch ( TYPE_3 ex ) { LOG . error ( STRING_2 , ex . getMessage ( ) , ex ) ; } r... | private TYPE_1 METHOD_1 ( ) { String VAR_1 = null ; TYPE_1 url = null ; try { VAR_1 = VAR_2 . METHOD_2 ( VAR_3 ) ; } catch ( TYPE_2 ex ) { LOG . error ( STRING_1 , ex . VAR_4 ( ) , ex ) ; } try { url = new TYPE_1 ( VAR_1 ) ; } catch ( TYPE_3 ex ) { LOG . error ( STRING_2 , ex . VAR_4 ( ) , ex ) ; } return url ; } |
_CODE_ / equals TYPE_1 correct ? I m tested | public List < TYPE_1 > METHOD_1 ( ) { List < TYPE_1 > result = new ArrayList < > ( ) ; Set < TYPE_1 > VAR_1 = new HashSet < > ( ) ; for ( TYPE_2 f : METHOD_2 ( ) ) { <START> TYPE_1 VAR_2 = f . VAR_3 ( ) ; <END> if ( VAR_1 . add ( VAR_2 ) ) { result . add ( VAR_2 ) ; } } return Collections . VAR_4 ( result ) ; } | public List < TYPE_1 > METHOD_1 ( ) { List < TYPE_1 > result = new ArrayList < > ( ) ; for ( TYPE_2 f : METHOD_2 ( ) ) { TYPE_1 VAR_2 = f . VAR_3 ( ) ; if ( ! result . contains ( VAR_2 ) ) { result . add ( VAR_2 ) ; } } return Collections . VAR_4 ( result ) ; } |
instead line don t call METHOD_1 ( VAR_1 VAR_4 ) | public TYPE_1 METHOD_1 ( String VAR_1 , Object content ) { TYPE_1 request = request ( TYPE_3 . VAR_3 , VAR_1 ) ; try { String VAR_4 = new TYPE_2 ( ) . METHOD_2 ( content ) ; <START> request . VAR_5 ( VAR_4 . METHOD_3 ( STRING_1 ) ) ; <END> } catch ( Exception e ) { throw new RuntimeException ( e ) ; } return request ; ... | public TYPE_1 METHOD_1 ( String VAR_1 , Object content ) { try { String VAR_4 = new TYPE_2 ( ) . METHOD_2 ( content ) ; return METHOD_1 ( VAR_1 , VAR_4 ) ; } catch ( Exception e ) { throw new RuntimeException ( e ) ; } } |
int [ ] props including style checker happier | private int [ ] METHOD_1 ( ) { <START> int props [ ] = new int [ VAR_1 ] ; <END> for ( int i = 0 ; i < VAR_1 ; i ++ ) { props [ i ] = i ; } return props ; } | private int [ ] METHOD_1 ( ) { int [ ] props = new int [ VAR_1 ] ; for ( int i = 0 ; i < VAR_1 ; i ++ ) { props [ i ] = i ; } return props ; } |
null purging | public void METHOD_1 ( ) throws Exception { TYPE_1 req = request ( TYPE_2 . VAR_2 , METHOD_2 ( ) + STRING_1 + METHOD_3 ( ) ) ; req . VAR_3 ( STRING_2 , "" ) ; METHOD_4 ( req ) ; <START> METHOD_5 ( VAR_4 <END> . METHOD_6 ( Context . VAR_5 ( ) . METHOD_7 ( METHOD_3 ( ) ) ) ) ; } | public void METHOD_1 ( ) throws Exception { assertNotNull ( VAR_4 . METHOD_6 ( Integer . parseInt ( METHOD_3 ( ) ) ) ) ; TYPE_1 req = request ( TYPE_2 . VAR_2 , METHOD_2 ( ) + STRING_1 + METHOD_3 ( ) ) ; req . VAR_3 ( STRING_2 , "" ) ; METHOD_4 ( req ) ; METHOD_5 ( VAR_4 . METHOD_6 ( Integer . parseInt ( METHOD_3 ( ) )... |
Arrays VAR_4 System _CODE_ | public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { METHOD_2 ( VAR_1 , STRING_1 ) ; if ( VAR_2 != VAR_1 . METHOD_3 ( ) ) { throw new IllegalArgumentException ( STRING_2 ) ; } TYPE_2 [ ] VAR_3 = Arrays . VAR_4 ( VAR_5 , VAR_5 . length + 1 ) ; <START> System . VAR_6 ( VAR_5 , 0 , VAR_3 , 0 , VAR_5 . length ) ; <END> VAR_3 [ VAR_5 ... | public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { METHOD_2 ( VAR_1 , STRING_1 ) ; if ( VAR_2 != VAR_1 . METHOD_3 ( ) ) { throw new IllegalArgumentException ( STRING_2 ) ; } TYPE_2 [ ] VAR_3 = Arrays . VAR_4 ( VAR_5 , VAR_5 . length + 1 ) ; VAR_3 [ VAR_5 . length ] = VAR_1 ; return new TYPE_1 ( VAR_3 ) ; } |
empty finally block | public void close ( ) { TYPE_1 . METHOD_1 ( VAR_1 ) ; try { VAR_2 . METHOD_2 ( ) ; } <START> finally { <END> } } | public void close ( ) { TYPE_1 . METHOD_1 ( VAR_1 ) ; try { VAR_2 . METHOD_2 ( ) ; } catch ( Exception e ) { } } |
new ArrayList < > ( VAR_2 values ( ) ) ; | private void METHOD_1 ( Throwable t ) { List < TYPE_1 > VAR_1 ; synchronized ( VAR_2 ) { <START> VAR_1 = new ArrayList < > ( VAR_2 . size ( ) ) ; <END> VAR_1 . addAll ( VAR_2 . values ( ) ) ; } for ( TYPE_1 data : VAR_1 ) { data . VAR_3 . METHOD_2 ( false ) ; data . VAR_4 ( t ) ; } } | private void METHOD_1 ( Throwable t ) { List < TYPE_1 > VAR_1 ; synchronized ( VAR_2 ) { VAR_1 = new ArrayList < > ( VAR_2 . values ( ) ) ; } for ( TYPE_1 data : VAR_1 ) { data . VAR_3 . METHOD_2 ( false ) ; data . VAR_4 ( t ) ; } } |
VAR_1 ? shift ? doesn t matter | <START> public final int METHOD_1 ( ) { return ( int ) ( VAR_1 > > > INT_1 ) ; } <END> | public final int METHOD_1 ( ) { return ( int ) ( VAR_1 ) ; } |
loader checked s - null similar paradigm client call close ( ) main ( ) s exception block - > case initialize fails initializing loader some reason logic initialized client connection closed leaked | private void close ( ) { try { METHOD_1 ( ) ; <START> VAR_1 . close ( ) ; <END> if ( VAR_2 != null ) { VAR_2 . close ( ) ; VAR_2 = null ; } } catch ( Exception ex ) { } } | private void close ( ) { try { METHOD_1 ( ) ; if ( VAR_1 != null ) { VAR_1 . close ( ) ; VAR_1 = null ; } if ( VAR_2 != null ) { VAR_2 . close ( ) ; VAR_2 = null ; } } catch ( Exception ex ) { } } |
- resources takes care closing | private static void METHOD_1 ( TYPE_1 VAR_1 , File file , String VAR_2 ) { byte [ ] VAR_3 = VAR_2 . METHOD_2 ( ) ; try ( TYPE_2 VAR_4 = VAR_1 . create ( file ) ) { VAR_4 . write ( ByteBuffer . VAR_5 ( VAR_3 ) ) ; <START> VAR_4 . close ( ) ; <END> } catch ( IOException e ) { throw new RuntimeException ( e ) ; } } | private static void METHOD_1 ( TYPE_1 VAR_1 , File file , String VAR_2 ) { byte [ ] VAR_3 = VAR_2 . METHOD_2 ( ) ; try ( TYPE_2 VAR_4 = VAR_1 . create ( file ) ) { VAR_4 . write ( ByteBuffer . VAR_5 ( VAR_3 ) ) ; } catch ( IOException e ) { throw new RuntimeException ( e ) ; } } |
change unnecessary PR limited _just_ s necessary achieve PR s aims | public boolean METHOD_1 ( ) { <START> return VAR_1 != null && VAR_1 . METHOD_1 ( ) ; <END> } | public boolean METHOD_1 ( ) { return VAR_1 != null ? VAR_1 . METHOD_1 ( ) : false ; } |
A DB call constuctor - a good practice | public TYPE_1 ( T parameters ) { super ( parameters ) ; <START> METHOD_1 ( METHOD_2 ( ) . METHOD_3 ( ) ) ; <END> } | public TYPE_1 ( T parameters ) { super ( parameters ) ; } |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.