ReviewComments stringlengths 1 2.35k | OriginalCode stringlengths 28 487 | ReviewedCode stringlengths 14 463 |
|---|---|---|
remove return types ingest methods aren t | private TYPE_1 METHOD_1 ( TYPE_2 parent , TYPE_3 VAR_1 , TYPE_3 VAR_2 ) throws TYPE_4 , IOException { if ( METHOD_2 ( VAR_2 ) ) { <START> return null ; <END> } TYPE_5 VAR_3 = ( TYPE_5 ) parent ; TYPE_1 obj = METHOD_3 ( VAR_3 , VAR_2 ) ; METHOD_4 ( obj ) ; METHOD_5 ( obj ) ; METHOD_6 ( VAR_3 ) ; METHOD_7 ( 1 ) ; log . info ( STRING_1 , obj . VAR_4 ( ) , METHOD_8 ( ) ) ; return obj ; } | private void METHOD_1 ( TYPE_2 parent , TYPE_3 VAR_1 , TYPE_3 VAR_2 ) throws TYPE_4 , IOException { if ( METHOD_2 ( VAR_2 ) ) { return ; } TYPE_5 VAR_3 = ( TYPE_5 ) parent ; TYPE_1 obj = METHOD_3 ( VAR_3 , VAR_2 ) ; METHOD_4 ( obj ) ; METHOD_5 ( obj ) ; METHOD_6 ( obj ) ; METHOD_7 ( 1 ) ; log . info ( STRING_1 , obj . VAR_4 ( ) , METHOD_8 ( ) ) ; } |
shouldn t METHOD_2 ( super METHOD_1 VAR_1 ) changes super class break | public int METHOD_1 ( ) { <START> return METHOD_2 ( METHOD_3 ( ) , METHOD_4 ( ) , METHOD_5 ( ) , METHOD_6 ( ) , METHOD_7 ( ) , VAR_1 ) ; <END> } | public int METHOD_1 ( ) { return METHOD_2 ( super . METHOD_1 ( ) , VAR_1 ) ; } |
simpler rewrite block ( VAR_2 ! = 1 ) | public void METHOD_1 ( TYPE_1 < ? super TYPE_2 > s ) { VAR_1 = s ; ++ VAR_2 ; s . VAR_3 ( new TYPE_3 ( ) { @Override public void request ( long n ) { <START> if ( VAR_2 == 1 ) { <END> } else { METHOD_2 ( n ) ; } } @Override public void METHOD_3 ( ) { VAR_4 = 0 ; } } ) ; } | public void METHOD_1 ( TYPE_1 < ? super TYPE_2 > s ) { VAR_1 = s ; ++ VAR_2 ; s . VAR_3 ( new TYPE_3 ( ) { @Override public void request ( long n ) { if ( VAR_2 != 1 ) { METHOD_2 ( n ) ; } } @Override public void METHOD_3 ( ) { VAR_4 = 0 ; } } ) ; } |
please remove TYPE_2 TYPE_3 | protected static boolean METHOD_1 ( Guid VAR_1 ) { <START> boolean VAR_2 = ! METHOD_2 ( VAR_1 , new TYPE_2 . TYPE_3 . ArrayList < String > ( ) ) ; <END> VAR_2 = VAR_2 && METHOD_3 ( VAR_1 ) ; return VAR_2 ; } | protected static boolean METHOD_1 ( Guid VAR_1 ) { return ! METHOD_2 ( VAR_1 , new ArrayList < String > ( ) ) && METHOD_3 ( VAR_1 ) ; } |
state reference part object monitor VAR_4 cover states object remove synchronized block extract a local variable | public void METHOD_1 ( Object VAR_1 ) { VAR_2 = VAR_1 ; TYPE_1 [ ] input = VAR_3 . METHOD_2 ( VAR_1 ) ; synchronized ( VAR_4 ) { <START> VAR_5 = null ; <END> } if ( VAR_6 != null ) { METHOD_3 ( input ) ; METHOD_4 ( 0 ) ; VAR_7 = SWT . VAR_8 ; VAR_9 = SWT . VAR_8 ; VAR_10 = null ; METHOD_5 ( input ) ; } } | public void METHOD_1 ( Object VAR_1 ) { VAR_2 = VAR_1 ; TYPE_1 [ ] input = VAR_3 . METHOD_2 ( VAR_1 ) ; VAR_5 = null ; if ( VAR_6 != null ) { METHOD_3 ( input ) ; METHOD_4 ( 0 ) ; VAR_7 = SWT . VAR_8 ; VAR_9 = SWT . VAR_8 ; VAR_10 = null ; METHOD_5 ( input ) ; } } |
remove VAR_5 outputs production | public void METHOD_1 ( TYPE_1 event ) { if ( event . VAR_1 ( ) ) { index = 0 ; METHOD_2 ( ) ; METHOD_3 ( VAR_2 ) . METHOD_4 ( VAR_3 , new TYPE_2 ( ) { @Override public void f ( ) { <START> TYPE_3 . VAR_5 . log ( STRING_1 ) ; <END> VAR_6 = false ; METHOD_3 ( STRING_2 , VAR_2 ) . remove ( ) ; } } ) ; } else { METHOD_3 ( VAR_2 ) . METHOD_5 ( VAR_3 ) ; } } | public void METHOD_1 ( TYPE_1 event ) { if ( event . VAR_1 ( ) ) { index = 0 ; METHOD_2 ( ) ; METHOD_3 ( VAR_2 ) . METHOD_4 ( VAR_3 , new TYPE_2 ( ) { @Override public void f ( ) { VAR_6 = false ; METHOD_3 ( STRING_2 , VAR_2 ) . remove ( ) ; } } ) ; } else { METHOD_3 ( VAR_2 ) . METHOD_5 ( VAR_3 ) ; } } |
info | public int METHOD_1 ( TYPE_1 VAR_1 ) throws TYPE_2 { if ( LOG . VAR_2 ( ) ) { <START> LOG . trace ( STRING_1 + VAR_1 + STRING_2 ) ; <END> } return 0 ; } | public int METHOD_1 ( TYPE_1 VAR_1 ) throws TYPE_2 { LOG . info ( STRING_1 + VAR_1 + STRING_2 ) ; return 0 ; } |
constructor pass TYPE_3 | public void update ( TYPE_1 name , String VAR_1 ) throws TYPE_2 { TYPE_3 VAR_2 = new TYPE_3 ( name , VAR_1 ) ; Map < String , String > VAR_3 = VAR_2 . METHOD_1 ( ) ; <START> TYPE_4 conf = new TYPE_4 ( VAR_3 , VAR_2 ) ; <END> try { VAR_4 . METHOD_2 ( conf ) ; } catch ( TYPE_5 e ) { throw new TYPE_2 ( e ) ; } builder . VAR_5 ( name . VAR_6 ( ) ) ; } | public void update ( TYPE_1 name , String VAR_1 ) throws TYPE_2 { TYPE_3 VAR_2 = new TYPE_3 ( name , VAR_1 ) ; TYPE_4 conf = new TYPE_4 ( VAR_2 ) ; try { VAR_4 . METHOD_2 ( conf ) ; } catch ( TYPE_5 e ) { throw new TYPE_2 ( e ) ; } builder . VAR_5 ( name . VAR_6 ( ) ) ; } |
superfluous | @Override public Pair < TYPE_1 , TYPE_2 > METHOD_1 ( TYPE_1 VAR_1 ) throws TYPE_3 { <START> final TYPE_1 VAR_2 = this . METHOD_2 ( VAR_1 ) ; <END> final TYPE_2 type = VAR_3 . METHOD_3 ( VAR_2 ) ; return Pair . of ( VAR_2 , type ) ; } | @Override public Pair < TYPE_1 , TYPE_2 > METHOD_1 ( TYPE_1 VAR_1 ) throws TYPE_3 { final TYPE_1 VAR_2 = METHOD_2 ( VAR_1 ) ; final TYPE_2 type = VAR_3 . METHOD_3 ( VAR_2 ) ; return Pair . of ( VAR_2 , type ) ; } |
I return null similar default _CODE_ implementation _CODE_ | public Object METHOD_1 ( Object instance ) throws TYPE_1 { <START> return instance ; <END> } | public Object METHOD_1 ( Object instance ) throws TYPE_1 { return null ; } |
please negate condition move #121 - clause | private void METHOD_1 ( TYPE_1 action ) { <START> if ( ! ( action . VAR_1 ( ) && action . VAR_2 ( ) . METHOD_2 ( ) ) ) { return ; } action . VAR_2 ( ) . METHOD_3 ( ) . forEach ( this : : METHOD_4 ) ; <END> } | private void METHOD_1 ( TYPE_1 action ) { if ( action . VAR_1 ( ) && action . VAR_2 ( ) . METHOD_2 ( ) ) { action . VAR_2 ( ) . METHOD_3 ( ) . forEach ( this : : METHOD_4 ) ; } } |
catch instance packagemanager | public TYPE_1 METHOD_1 ( Context context ) { final TYPE_2 VAR_1 = context . VAR_2 ( ) ; TYPE_3 VAR_3 ; try { <START> if ( VAR_4 . VAR_5 != null ) { <END> return new TYPE_4 ( VAR_4 . VAR_5 ) ; } VAR_3 = VAR_1 . METHOD_2 ( VAR_4 . VAR_6 ) ; final int id = VAR_3 . METHOD_3 ( VAR_4 . VAR_7 , null , null ) ; return VAR_3 . METHOD_1 ( id ) ; } catch ( TYPE_5 e ) { } return null ; } | public TYPE_1 METHOD_1 ( Context context ) { final TYPE_2 VAR_1 = context . VAR_2 ( ) ; TYPE_3 VAR_3 ; if ( VAR_4 . VAR_5 != null ) { return new TYPE_4 ( VAR_4 . VAR_5 ) ; } try { VAR_3 = VAR_1 . METHOD_2 ( VAR_4 . VAR_6 ) ; final int id = VAR_3 . METHOD_3 ( VAR_4 . VAR_7 , null , null ) ; return VAR_3 . METHOD_1 ( id ) ; } catch ( TYPE_5 e ) { } return null ; } |
dianne remove logspam | protected boolean METHOD_1 ( String VAR_1 , String VAR_2 ) { <START> Log . d ( TAG , STRING_1 ) ; Log . d ( TAG , STRING_2 + VAR_1 ) ; <END> return false ; } | protected boolean METHOD_1 ( String VAR_1 , String VAR_2 ) { return false ; } |
style - : don t cuddle line isn t shorter ? TYPE_1 VAR_1 = ( TYPE_1 ) o ; return group equals ( VAR_1 group ) && VAR_2 equals ( VAR_1 VAR_2 ) ; | public boolean equals ( Object o ) { TYPE_1 VAR_1 = ( TYPE_1 ) o ; <START> if ( ! group . equals ( VAR_1 . group ) ) return false ; <END> if ( ! VAR_2 . equals ( VAR_1 . VAR_2 ) ) return false ; return true ; } | public boolean equals ( Object o ) { TYPE_1 VAR_1 = ( TYPE_1 ) o ; return group . equals ( VAR_1 . group ) && VAR_2 . equals ( VAR_1 . VAR_2 ) ; } |
step handler change needed avoid some memory leak ? isn t enough assign new | public void METHOD_1 ( final TYPE_1 < TYPE_2 > VAR_1 ) { input . VAR_2 = null ; <START> input . VAR_2 = event - > { <END> VAR_1 . METHOD_2 ( event ) ; return this ; } ; } | public void METHOD_1 ( final TYPE_1 < TYPE_2 > VAR_1 ) { input . VAR_2 = event - > { VAR_1 . METHOD_2 ( event ) ; return this ; } ; } |
context immutable return false | public boolean METHOD_1 ( Object key ) { <START> throw new TYPE_1 ( STRING_1 ) ; <END> } | public boolean METHOD_1 ( Object key ) { return false ; } |
remove curly braces | protected TYPE_1 METHOD_1 ( ) { return ( ) <START> - > { return ImmutableList . of ( METHOD_2 ( Messages . TYPE_5 , TYPE_2 . METHOD_3 ( TYPE_3 : : getName ) ) , new TYPE_4 ( Messages . TYPE_6 ) ) ; } ; <END> } | protected TYPE_1 METHOD_1 ( ) { return ( ) - > ImmutableList . of ( METHOD_2 ( Messages . TYPE_5 , TYPE_2 . METHOD_3 ( TYPE_3 : : getName ) ) , new TYPE_4 ( Messages . TYPE_6 ) ) ; } |
odd | public void METHOD_1 ( TYPE_1 VAR_1 , TYPE_1 VAR_2 , int VAR_3 ) { VAR_4 = VAR_1 ; VAR_5 = VAR_2 ; <START> VAR_6 . add ( new TYPE_2 ( TYPE_4 . TYPE_5 . METHOD_2 ( TYPE_6 . VAR_8 ) , <END> STRING_1 , TYPE_7 . VAR_10 , FLOAT_1 ) ) ; if ( VAR_3 == 0 ) { METHOD_3 ( ) ; } else { METHOD_4 ( ) ; } } | public void METHOD_1 ( TYPE_1 VAR_1 , TYPE_1 VAR_2 , int VAR_3 ) { VAR_4 = VAR_1 ; VAR_5 = VAR_2 ; if ( VAR_3 == 0 ) { METHOD_3 ( ) ; } else { METHOD_4 ( ) ; } } |
close channel I s useless remove publisher VAR_3 channel garbage collected | protected void METHOD_1 ( ) { logger . debug ( STRING_1 ) ; try { VAR_1 . METHOD_2 ( ) ; } catch ( Exception t ) { logger . error ( t . getMessage ( ) , t ) ; } VAR_2 . METHOD_3 ( VAR_1 . METHOD_4 ( ) ) ; VAR_2 . METHOD_5 ( channel ) ; <START> channel . VAR_3 ( ) . remove ( TYPE_1 . class ) ; <END> } | protected void METHOD_1 ( ) { logger . debug ( STRING_1 ) ; try { VAR_1 . METHOD_2 ( ) ; } catch ( Exception t ) { logger . debug ( t . getMessage ( ) , t ) ; } VAR_2 . METHOD_5 ( channel ) ; } |
a null check VAR_1 prior calling METHOD_2 method List < String > VAR_2 = ( VAR_1 ! = null ) ? VAR_1 METHOD_2 ( ) : null ; | public static List < String > METHOD_1 ( TYPE_1 VAR_1 ) { <START> List < String > VAR_2 = VAR_1 . METHOD_2 ( ) ; <END> if ( VAR_2 == null || VAR_2 . isEmpty ( ) ) { VAR_2 = new ArrayList < > ( ) ; VAR_2 . add ( "" ) ; } return VAR_2 ; } | public static List < String > METHOD_1 ( TYPE_1 VAR_1 ) { List < String > VAR_2 = VAR_1 != null ? VAR_1 . METHOD_2 ( ) : new ArrayList < > ( ) ; if ( VAR_2 == null || VAR_2 . isEmpty ( ) ) { VAR_2 = new ArrayList < > ( ) ; VAR_2 . add ( "" ) ; } return VAR_2 ; } |
legacy extensions _CODE_ | public void METHOD_1 ( TYPE_1 trace ) { TYPE_2 VAR_1 = METHOD_2 ( ) ; <START> if ( ! ( VAR_1 instanceof TYPE_3 ) ) { <END> return ; } try { VAR_1 . METHOD_3 ( trace ) ; VAR_1 . METHOD_4 ( ) ; if ( VAR_2 != null ) { VAR_2 . METHOD_5 ( ) ; } VAR_2 = ( TYPE_3 ) VAR_1 ; } catch ( TYPE_4 e ) { TYPE_5 . METHOD_6 ( ) . METHOD_7 ( STRING_1 , e ) ; } } | public void METHOD_1 ( TYPE_1 trace ) { TYPE_2 VAR_1 = METHOD_2 ( ) ; if ( VAR_1 == null ) { return ; } try { VAR_1 . METHOD_3 ( trace ) ; VAR_1 . METHOD_4 ( ) ; if ( VAR_2 != null ) { VAR_2 . METHOD_5 ( ) ; } VAR_2 = VAR_1 ; } catch ( TYPE_4 e ) { TYPE_5 . METHOD_6 ( ) . METHOD_7 ( STRING_1 , e ) ; } } |
formatting | @Override public void METHOD_1 ( Context context , TYPE_1 VAR_1 ) { String action = VAR_1 . METHOD_2 ( ) ; TYPE_2 VAR_2 = VAR_1 . METHOD_3 ( ) ; if ( TYPE_3 . equals ( action ) ) { if ( VAR_2 != null ) { <START> METHOD_4 ( VAR_2 . METHOD_5 ( VAR_3 , false ) ) ; <END> } } else if ( TYPE_4 . equals ( action ) ) { METHOD_6 ( VAR_4 . METHOD_7 ( ) ) ; } } | @Override public void METHOD_1 ( Context context , TYPE_1 VAR_1 ) { if ( null == VAR_1 ) { return ; } String action = VAR_1 . METHOD_2 ( ) ; TYPE_2 VAR_2 = VAR_1 . METHOD_3 ( ) ; if ( TYPE_3 . equals ( action ) ) { METHOD_4 ( VAR_2 . METHOD_5 ( VAR_3 , false ) ) ; } else if ( TYPE_4 . equals ( action ) ) { METHOD_6 ( VAR_4 . METHOD_7 ( ) ) ; } } |
instead adding a METHOD_6 consider a _CODE_ changes observed ( I _CODE_ ? ) allow remove tab change logic | public void METHOD_1 ( ANNOTATION_1 TYPE_1 VAR_1 ) { METHOD_2 ( VAR_1 ) ; TYPE_1 . TYPE_3 . METHOD_3 ( VAR_1 ) ; VAR_2 . METHOD_4 ( VAR_1 , VAR_3 . size ( ) ) ; METHOD_5 ( ) ; <START> if ( METHOD_6 ( ) != null ) { <END> METHOD_6 ( ) . METHOD_7 ( ) ; } } | public void METHOD_1 ( ANNOTATION_1 TYPE_1 VAR_1 ) { METHOD_2 ( VAR_1 ) ; TYPE_1 . TYPE_3 . METHOD_3 ( VAR_1 ) ; VAR_2 . METHOD_4 ( VAR_1 , VAR_3 . size ( ) ) ; METHOD_5 ( ) ; } |
I m pretty a factory making public constructor required ( a lot refactoring achieve s uphold flag ) | <START> public TYPE_1 ( int VAR_2 , int ... VAR_3 ) <END> { this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; } | TYPE_1 ( int VAR_2 , int ... VAR_3 ) { this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; } |
_CODE_ response = Optional ( token ) map ( VAR_1 : : METHOD_2 ) | public Map < String , Object > METHOD_1 ( String token ) { <START> TYPE_1 response = Optional . of ( this . VAR_1 . METHOD_2 ( token ) ) <END> . map ( this : : METHOD_3 ) . map ( this : : METHOD_4 ) . map ( this : : METHOD_5 ) . map ( this : : METHOD_6 ) . filter ( TYPE_1 : : METHOD_7 ) . METHOD_8 ( ( ) - > new TYPE_2 ( STRING_1 + token + STRING_2 ) ) ; return METHOD_9 ( response ) ; } | public Map < String , Object > METHOD_1 ( String token ) { TYPE_1 response = Optional . of ( token ) . map ( this . VAR_1 : : METHOD_2 ) . map ( this : : METHOD_3 ) . map ( this : : METHOD_4 ) . map ( this : : METHOD_5 ) . map ( this : : METHOD_6 ) . filter ( TYPE_1 : : METHOD_7 ) . METHOD_8 ( ( ) - > new TYPE_2 ( STRING_1 + token + STRING_2 ) ) ; return METHOD_9 ( response ) ; } |
shouldn t perform cold reboot volatile runs | private boolean METHOD_1 ( ) { boolean VAR_1 = ( METHOD_2 ( ) . METHOD_3 ( ) && <START> ! METHOD_2 ( ) . METHOD_4 ( ) ) <END> || METHOD_2 ( ) . METHOD_5 ( ) ; log . info ( STRING_1 , METHOD_2 ( ) . getName ( ) , VAR_1 ? STRING_2 : STRING_3 , METHOD_2 ( ) . METHOD_3 ( ) , METHOD_2 ( ) . METHOD_4 ( ) , METHOD_2 ( ) . METHOD_5 ( ) ) ; return VAR_1 ; } | private boolean METHOD_1 ( ) { boolean VAR_1 = ( METHOD_2 ( ) . METHOD_3 ( ) && METHOD_2 ( ) . METHOD_4 ( ) ) || METHOD_2 ( ) . METHOD_5 ( ) ; log . info ( STRING_1 , METHOD_2 ( ) . getName ( ) , VAR_1 ? STRING_2 : STRING_3 , METHOD_2 ( ) . METHOD_3 ( ) , METHOD_2 ( ) . METHOD_4 ( ) , METHOD_2 ( ) . METHOD_5 ( ) ) ; return VAR_1 ; } |
I don t understand needed ? isn t _CODE_ | public void METHOD_1 ( ) { super . METHOD_1 ( ) ; VAR_1 . METHOD_2 ( false ) ; <START> VAR_2 . METHOD_2 ( VAR_3 . METHOD_3 ( ) . getValue ( ) ) ; <END> } | public void METHOD_1 ( ) { super . METHOD_1 ( ) ; VAR_1 . METHOD_2 ( false ) ; } |
please rename VAR_1 | protected void METHOD_1 ( ) { <START> VAR_1 = METHOD_2 ( ) . METHOD_3 ( getParameters ( ) . METHOD_4 ( ) . toString ( ) ) ; <END> METHOD_5 ( ) ; TYPE_1 VAR_2 = METHOD_6 ( VAR_1 . VAR_3 ) ; VAR_2 . METHOD_7 ( getParameters ( ) . METHOD_4 ( ) ) ; METHOD_8 ( VAR_2 ) ; } | protected void METHOD_1 ( ) { result = METHOD_2 ( ) . METHOD_3 ( getParameters ( ) . METHOD_4 ( ) . toString ( ) ) ; METHOD_5 ( ) ; TYPE_1 VAR_2 = METHOD_6 ( result . VAR_3 ) ; VAR_2 . METHOD_7 ( getParameters ( ) . METHOD_4 ( ) ) ; METHOD_8 ( VAR_2 ) ; } |
Boolean a reason ( boolean ) ? asking Boolean mind a tri - boolean ( true false null ) | <START> Boolean METHOD_1 ( ) { <END> final String VAR_1 = TYPE_2 . VAR_3 ; final TYPE_1 user = VAR_4 . METHOD_2 ( ) ; return VAR_5 . METHOD_3 ( VAR_1 , user ) ; } | boolean METHOD_1 ( ) { final String VAR_1 = TYPE_2 . VAR_3 ; final TYPE_1 user = VAR_4 . METHOD_2 ( ) ; return VAR_5 . METHOD_3 ( VAR_1 , user ) ; } |
a bug cinder disks exists return call ( null ) parameter added previous patch | public TYPE_1 METHOD_1 ( ) { <START> return METHOD_2 ( ) ? null : new TYPE_2 ( ) ; <END> } | public TYPE_1 METHOD_1 ( ) { return METHOD_2 ( ) ? new TYPE_2 ( ) : null ; } |
- resources | private TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) throws IOException { TYPE_3 VAR_2 = METHOD_2 ( VAR_3 , TYPE_4 . class ) ; TYPE_5 VAR_4 = VAR_2 . in ( ) ; try { return new TYPE_6 ( VAR_4 ) . build ( ) ; } finally { VAR_4 . close ( ) ; <START> } <END> } | private TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) throws IOException { TYPE_3 VAR_2 = METHOD_2 ( VAR_3 , TYPE_4 . class ) ; try ( TYPE_5 VAR_4 = VAR_2 . in ( ) ) { return new TYPE_6 ( VAR_4 ) . build ( ) ; } } |
want specific edge - case fixtures ensure deserialization works needed | public void METHOD_1 ( ) throws Exception { String data = METHOD_2 ( STRING_1 ) ; TYPE_1 resource = TYPE_3 . TYPE_4 . METHOD_3 ( data , TYPE_1 . class ) ; assertNotNull ( resource ) ; <START> assertNotNull ( resource . getId ( ) ) ; <END> } | public void METHOD_1 ( ) throws Exception { final String data = METHOD_2 ( STRING_1 ) ; final TYPE_1 resource = TYPE_3 . TYPE_4 . METHOD_3 ( data , TYPE_1 . class ) ; assertNotNull ( resource ) ; assertNotNull ( resource . getId ( ) ) ; } |
flip constructor VAR_2 call constructor parameter ? don t pass null constructor functionally difference reads a nicer IMO | public TYPE_1 ( String VAR_2 ) { <START> this . VAR_2 = VAR_2 ; <END> VAR_3 = true ; } | public TYPE_1 ( String VAR_2 ) { this ( ) ; this . VAR_2 = VAR_2 ; } |
I m concerned inlined | private int METHOD_1 ( int VAR_1 ) { <START> if ( VAR_2 ) VAR_3 . METHOD_2 ( ) ; <END> if ( VAR_1 == VAR_4 ) { VAR_1 = 0 ; Thread . VAR_5 ( ) ; } else { VAR_1 ++ ; TYPE_1 . METHOD_3 ( ) ; } return VAR_1 ; } | private int METHOD_1 ( int VAR_1 ) { if ( VAR_2 ) VAR_3 . METHOD_2 ( ) ; if ( VAR_1 == VAR_4 ) { Thread . VAR_5 ( ) ; return 0 ; } TYPE_1 . METHOD_3 ( ) ; return VAR_1 + 1 ; } |
need assign a variable | private static String METHOD_1 ( ) { <START> final StringBuilder sb = new StringBuilder ( ) <END> . append ( METHOD_2 ( VAR_1 ) ) . append ( STRING_1 ) . append ( METHOD_2 ( VAR_2 ) ) ; return sb . toString ( ) ; } | private static String METHOD_1 ( ) { return new StringBuilder ( ) . append ( METHOD_2 ( VAR_1 ) ) . append ( STRING_1 ) . append ( METHOD_2 ( VAR_2 ) ) . toString ( ) ; } |
correctly cycles pager button pressed position reached button effect ( i e dialog close pressed ) handle final case add else : else { super METHOD_1 ( ) ; } | public void METHOD_1 ( ) { if ( VAR_1 . METHOD_2 ( ) > 0 ) { VAR_1 . METHOD_3 ( VAR_1 . METHOD_2 ( ) - 1 , true ) ; <START> } <END> } | public void METHOD_1 ( ) { if ( VAR_1 . METHOD_2 ( ) > 0 ) { VAR_1 . METHOD_3 ( VAR_1 . METHOD_2 ( ) - 1 , true ) ; } else { super . METHOD_1 ( ) ; } } |
ditto readability : int result = = = null ? 0 : VAR_1 ( ) ; | public int METHOD_1 ( ) { <START> int result = name != null ? name . VAR_1 ( ) : 0 ; <END> result = INT_1 * result + ( VAR_2 != null ? VAR_2 . METHOD_1 ( ) : 0 ) ; result = INT_1 * result + ( VAR_3 != null ? VAR_3 . METHOD_1 ( ) : 0 ) ; return result ; } | public int METHOD_1 ( ) { int result = name == null ? 0 : name . VAR_1 ( ) ; result = INT_1 * result + ( VAR_2 != null ? VAR_2 . METHOD_1 ( ) : 0 ) ; result = INT_1 * result + ( VAR_3 != null ? VAR_3 . METHOD_1 ( ) : 0 ) ; return result ; } |
done start ( ) | public TYPE_3 ( ) { VAR_2 = this ; <START> VAR_3 = new TYPE_1 ( ) ; VAR_3 . METHOD_1 ( new TYPE_2 ( ) ) ; <END> } | public TYPE_3 ( ) { VAR_2 = this ; } |
+ 1 : | public TYPE_1 METHOD_1 ( TYPE_2 < ? > VAR_1 , boolean VAR_2 ) { if ( VAR_1 . equals ( METHOD_2 ( ) ) ) { return this ; <START> } else if ( TYPE_3 . METHOD_3 ( VAR_1 ) . equals ( TYPE_6 . TYPE_7 ) <END> && METHOD_2 ( ) . id ( ) == TYPE_6 . TYPE_7 . id ( ) ) { return this ; } return TYPE_5 . METHOD_4 ( this , VAR_1 , VAR_2 ) ; } | public TYPE_1 METHOD_1 ( TYPE_2 < ? > VAR_1 , boolean VAR_2 ) { if ( VAR_1 . equals ( METHOD_2 ( ) ) ) { return this ; } else if ( TYPE_3 . METHOD_3 ( VAR_1 ) . equals ( TYPE_6 . TYPE_7 ) && METHOD_2 ( ) . id ( ) == VAR_1 . id ( ) ) { return this ; } return TYPE_5 . METHOD_4 ( this , VAR_1 , VAR_2 ) ; } |
LOG warn ( STRING_1 VAR_2 ) ; | public static boolean METHOD_1 ( ) { boolean VAR_1 = true ; for ( Map . Entry < String , String > entry : METHOD_2 ( ) . entrySet ( ) ) { String VAR_2 = entry . getKey ( ) ; if ( ! TYPE_1 . METHOD_3 ( VAR_2 ) ) { <START> LOG . warn ( STRING_1 + VAR_2 ) ; <END> VAR_1 = false ; } } return VAR_1 ; } | public static boolean METHOD_1 ( ) { boolean VAR_1 = true ; for ( Map . Entry < String , String > entry : METHOD_2 ( ) . entrySet ( ) ) { String VAR_2 = entry . getKey ( ) ; if ( ! TYPE_1 . METHOD_3 ( VAR_2 ) ) { LOG . warn ( STRING_1 , VAR_2 ) ; VAR_1 = false ; } } return VAR_1 ; } |
wrapping else body a new method cleaner | public String METHOD_1 ( ) { if ( VAR_1 != null ) { METHOD_2 ( ) ; } else { synchronized ( this ) { <START> log . info ( STRING_1 ) ; <END> METHOD_3 ( TYPE_1 . VAR_3 ) ; try { METHOD_4 ( ) ; METHOD_5 ( ) ; METHOD_6 ( ) ; } catch ( Exception e ) { log . error ( STRING_2 , e ) ; } finally { METHOD_3 ( TYPE_1 . VAR_4 ) ; log . info ( STRING_3 ) ; } } } return METHOD_7 ( ) ; } | private void METHOD_1 ( ) { synchronized ( this ) { log . info ( STRING_1 ) ; METHOD_3 ( TYPE_1 . VAR_3 ) ; try { METHOD_4 ( ) ; METHOD_5 ( ) ; METHOD_6 ( ) ; } catch ( Exception e ) { log . error ( STRING_2 , e ) ; } finally { METHOD_3 ( TYPE_1 . VAR_4 ) ; log . info ( STRING_3 ) ; } } } |
bytecode equivalent - syntax array | static List < TYPE_1 > list ( Type [ ] VAR_1 ) { List < TYPE_1 > result = new ArrayList < > ( VAR_1 . length ) ; <START> for ( int i = 0 ; i < VAR_1 . length ; i ++ ) { <END> result . add ( get ( VAR_1 [ i ] ) ) ; } return result ; } | static List < TYPE_1 > list ( Type [ ] VAR_1 ) { List < TYPE_1 > result = new ArrayList < > ( VAR_1 . length ) ; for ( Type type : VAR_1 ) { result . add ( get ( type ) ) ; } return result ; } |
NULL Boolean VAR_2 ( ) return FALSE I understand more explicit | private boolean METHOD_1 ( ) { String value = Optional . VAR_1 ( TYPE_1 . getProperty ( STRING_1 ) ) <START> . METHOD_2 ( STRING_2 ) ; <END> return Boolean . VAR_2 ( value ) ; } | private boolean METHOD_1 ( ) { String value = TYPE_1 . getProperty ( STRING_1 ) ; return Boolean . VAR_2 ( value ) ; } |
entire body synchronized put synchronized method | public Map < String , Integer > METHOD_1 ( ) { <START> synchronized ( this ) { <END> Map < String , Integer > VAR_1 = new HashMap < String , Integer > ( ) ; VAR_1 . put ( STRING_1 , VAR_2 . size ( ) ) ; VAR_1 . put ( STRING_2 , VAR_3 . size ( ) ) ; return VAR_1 ; } } | public synchronized Map < String , Integer > METHOD_1 ( ) { Map < String , Integer > VAR_1 = new HashMap < String , Integer > ( ) ; VAR_1 . put ( STRING_1 , VAR_2 . size ( ) ) ; VAR_1 . put ( STRING_2 , VAR_3 . size ( ) ) ; return VAR_1 ; } |
remove | public void next ( ) { <START> TYPE_1 VAR_1 = ( TYPE_1 ) this . METHOD_1 ( ) ; <END> TYPE_2 VAR_2 = VAR_1 . METHOD_2 ( ) . METHOD_3 ( VAR_3 ) ; if ( VAR_2 != null ) new TYPE_5 . TYPE_4 ( VAR_4 , VAR_2 , VAR_5 ) . execute ( ) ; } | public void next ( ) { TYPE_1 VAR_1 = ( TYPE_1 ) METHOD_1 ( ) ; TYPE_2 VAR_2 = VAR_1 . METHOD_2 ( ) . METHOD_3 ( VAR_3 ) ; if ( VAR_2 != null ) new TYPE_4 ( VAR_4 , VAR_2 , VAR_5 ) . execute ( ) ; } |
please inline variable | public void METHOD_1 ( ) throws IOException { final TYPE_1 VAR_1 = TYPE_2 . METHOD_2 ( ) ; final TYPE_3 VAR_2 = new TYPE_3 ( ) ; try { VAR_1 . METHOD_3 ( ) ; VAR_2 . METHOD_4 ( STRING_1 ) ; <START> final int VAR_3 = VAR_2 . METHOD_5 ( ) ; <END> TYPE_4 . assertThat ( TYPE_5 . METHOD_6 ( VAR_3 ) , TYPE_6 . METHOD_7 ( true ) ) ; TYPE_4 . assertThat ( VAR_2 . METHOD_8 ( ) , TYPE_6 . METHOD_7 ( true ) ) ; } finally { VAR_1 . close ( ) ; } } | public void METHOD_1 ( ) throws IOException { final TYPE_1 VAR_1 = TYPE_2 . METHOD_2 ( ) ; final TYPE_3 VAR_2 = new TYPE_3 ( ) ; try { VAR_1 . METHOD_3 ( ) ; VAR_2 . METHOD_4 ( STRING_1 ) ; TYPE_4 . assertThat ( TYPE_5 . METHOD_6 ( VAR_2 . METHOD_5 ( ) ) , TYPE_6 . METHOD_7 ( true ) ) ; TYPE_4 . assertThat ( VAR_2 . METHOD_8 ( ) , TYPE_6 . METHOD_7 ( true ) ) ; } finally { VAR_1 . close ( ) ; } } |
put a finally local - - resources case VAR_1 close ( ) throws some reason s extremely careful | @Override public void close ( ) { TYPE_1 VAR_1 = TYPE_2 . get ( STRING_1 ) ; if ( VAR_1 != null ) { VAR_1 . close ( ) ; TYPE_2 . METHOD_1 ( STRING_1 ) ; } <START> factory . close ( ) ; <END> } | @Override public void close ( ) { TYPE_1 VAR_1 = TYPE_2 . get ( STRING_1 ) ; if ( VAR_1 != null ) { VAR_1 . close ( ) ; TYPE_2 . METHOD_1 ( STRING_1 ) ; } } |
I m work a concurrent environment isn t a shared channel ? instead [ ] ( ) | void METHOD_1 ( long VAR_1 , long size ) throws IOException { long VAR_2 = Math . VAR_3 ( size , METHOD_2 ( ) . METHOD_3 ( ) - VAR_1 ) ; VAR_4 = ByteBuffer . VAR_5 ( ( int ) VAR_2 ) ; <START> METHOD_4 ( ) . position ( offset . VAR_6 ( ) + VAR_1 ) ; <END> METHOD_4 ( ) . read ( VAR_4 ) ; VAR_7 = VAR_1 ; } | void METHOD_1 ( long VAR_1 , long size ) throws IOException { long VAR_2 = Math . VAR_3 ( size , METHOD_2 ( ) . METHOD_3 ( ) - VAR_1 ) ; VAR_4 = ByteBuffer . VAR_5 ( ( int ) VAR_2 ) ; METHOD_4 ( ) . read ( VAR_4 , offset . VAR_6 ( ) + VAR_1 ) ; VAR_7 = VAR_1 ; } |
returns VAR_2 combine line | public TYPE_2 ( String VAR_2 , TYPE_1 VAR_3 ) { super ( VAR_3 ) ; <START> METHOD_1 ( VAR_2 , STRING_1 ) ; <END> this . VAR_2 = VAR_2 ; } | public TYPE_2 ( String VAR_2 , TYPE_1 VAR_3 ) { super ( VAR_3 ) ; this . VAR_2 = METHOD_1 ( VAR_2 , STRING_1 ) ; } |
final | public TYPE_1 build ( ) throws IllegalArgumentException { <START> List < long [ ] > cache = new ArrayList < long [ ] > ( ) ; <END> for ( byte [ ] VAR_1 : VAR_2 ) { long [ ] result = new long [ 2 ] ; result [ 0 ] = VAR_3 . apply ( VAR_1 , 0 ) ; result [ 1 ] = VAR_3 . apply ( VAR_1 , 1 ) - result [ 0 ] ; cache . add ( result ) ; } return new TYPE_1 ( VAR_3 , cache ) ; } | public final TYPE_1 build ( ) throws IllegalArgumentException { List < long [ ] > cache = new ArrayList < long [ ] > ( ) ; for ( byte [ ] VAR_1 : VAR_2 ) { long [ ] result = new long [ 2 ] ; result [ 0 ] = VAR_3 . apply ( VAR_1 , 0 ) ; result [ 1 ] = VAR_3 . apply ( VAR_1 , 1 ) - result [ 0 ] ; cache . add ( result ) ; } return new TYPE_1 ( VAR_3 , cache ) ; } |
remove extra space consistent formattingsuggestionpublic Object METHOD_1 ( Object parent ) { | <START> public Object METHOD_1 ( Object parent ) { <END> if ( parent == null ) { return this ; } if ( parent instanceof TYPE_1 ) { this . VAR_1 = ( TYPE_2 ) parent ; return this . VAR_1 ; } else { throw new IllegalArgumentException ( STRING_1 + parent . getClass ( ) . getName ( ) + STRING_2 ) ; } } | public Object METHOD_1 ( Object parent ) { if ( parent == null ) { return this ; } if ( parent instanceof TYPE_2 ) { this . parent = ( TYPE_2 ) parent ; return this ; } else { throw new IllegalArgumentException ( STRING_1 + parent . getClass ( ) . getName ( ) + STRING_2 ) ; } } |
lambda | public TYPE_1 < TYPE_2 , TYPE_3 < TYPE_4 > , TYPE_5 > METHOD_1 ( ) { <START> return bind ( a - > METHOD_2 ( ) . map ( new TYPE_6 < TYPE_3 < TYPE_4 > , TYPE_3 < TYPE_4 > > ( ) { <END> public TYPE_3 < TYPE_4 > f ( final TYPE_3 < TYPE_4 > VAR_1 ) { return VAR_1 . METHOD_3 ( a ) ; } } ) ) ; } | public TYPE_1 < TYPE_2 , TYPE_3 < TYPE_4 > , TYPE_5 > METHOD_1 ( ) { return bind ( a - > METHOD_2 ( ) . map ( VAR_1 - > VAR_1 . METHOD_3 ( a ) ) ) ; } |
line more lisibility | public String METHOD_1 ( ) { <START> if ( null == this . VAR_1 ) { return "" ; } return this . VAR_1 ; <END> } | public String METHOD_1 ( ) { return this . VAR_1 != null ? this . VAR_1 : "" ; } |
formatting VAR_1 ( ) 1 bad component break components | public boolean execute ( short a , TYPE_1 b ) { try { <START> for ( TYPE_2 c : b . values ( ) ) { <END> c . VAR_1 ( ) ; } } catch ( Exception e ) { TYPE_3 . METHOD_1 ( ) . log ( Level . VAR_2 , STRING_1 , e ) ; } return true ; } | public boolean execute ( short a , TYPE_1 b ) { for ( TYPE_2 c : b . values ( ) ) { try { c . VAR_1 ( ) ; } catch ( Exception e ) { TYPE_3 . METHOD_1 ( ) . log ( Level . VAR_2 , STRING_1 , e ) ; } } return true ; } |
1 correct ? I guess _CODE_ - > 0 | protected static double METHOD_1 ( TYPE_1 node , TYPE_2 key , TYPE_3 version , boolean VAR_1 ) { List < TYPE_4 > VAR_2 = METHOD_2 ( node , VAR_1 ) ; double VAR_3 = 0 ; for ( TYPE_4 VAR_4 : VAR_2 ) { double val = TYPE_5 . get ( key , VAR_4 , version ) ; <START> VAR_3 += val == Double . TYPE_6 ? 1 : val ; <END> } return VAR_3 / VAR_2 . size ( ) ; } | protected static double METHOD_1 ( TYPE_1 node , TYPE_2 key , TYPE_3 version , boolean VAR_1 ) { List < TYPE_4 > VAR_2 = METHOD_2 ( node , VAR_1 ) ; double VAR_3 = 0 ; for ( TYPE_4 VAR_4 : VAR_2 ) { double val = TYPE_5 . get ( key , VAR_4 , version ) ; VAR_3 += val == Double . TYPE_6 ? 0 : val ; } return VAR_3 / VAR_2 . size ( ) ; } |
I add a final : suggestionfinal TYPE_2 element = VAR_1 METHOD_2 ( ) ; | public void METHOD_1 ( final TYPE_1 VAR_1 ) { type . VAR_2 = "" ; <START> TYPE_2 element = VAR_1 . METHOD_2 ( ) ; <END> if ( element instanceof TYPE_3 ) { new TYPE_4 ( ( TYPE_3 ) element , STRING_1 ) . METHOD_3 ( ) ; } type . VAR_3 ( VAR_1 . METHOD_2 ( ) ) ; } | public void METHOD_1 ( final TYPE_1 VAR_1 ) { type . VAR_2 = "" ; final TYPE_2 element = VAR_1 . METHOD_2 ( ) ; new TYPE_4 ( element , STRING_1 ) . METHOD_3 ( ) ; type . VAR_3 ( element ) ; } |
counterintuitive need reassign VAR_1 ? VAR_2 METHOD_2 ( ) false returning true | public boolean METHOD_1 ( ) { <START> VAR_1 = VAR_1 || VAR_2 . METHOD_2 ( ) ; <END> return VAR_1 ; } | public boolean METHOD_1 ( ) { return VAR_2 . METHOD_2 ( ) ; } |
I validate method return Set < TYPE_2 > avoiding double VAR_3 call addition I add vararg methods java config convenience done separate JIRA | public void METHOD_1 ( String VAR_1 ) { TYPE_1 . METHOD_2 ( TYPE_2 . class , VAR_1 ) ; final Set < String > VAR_2 = StringUtils <START> . VAR_3 ( VAR_1 ) ; <END> Assert . VAR_4 ( VAR_2 , STRING_1 ) ; this . VAR_2 = VAR_2 ; } | public void METHOD_1 ( String VAR_1 ) { final Set < String > VAR_2 = TYPE_1 . METHOD_2 ( TYPE_2 . class , VAR_1 ) ; Assert . VAR_4 ( VAR_2 , STRING_1 ) ; this . VAR_2 = VAR_2 ; } |
method change state ( others ) I prefer declare static | <START> final TYPE_1 METHOD_1 ( TYPE_1 VAR_1 ) { <END> while ( VAR_1 != null && ( VAR_1 . getType ( ) == TYPE_1 . VAR_2 || VAR_1 . getType ( ) == TYPE_1 . VAR_3 || VAR_1 . getType ( ) == TYPE_1 . VAR_4 ) ) { VAR_1 = VAR_1 . METHOD_2 ( ) ; } return VAR_1 ; } | static TYPE_1 METHOD_1 ( TYPE_1 VAR_1 ) { while ( VAR_1 != null && ( VAR_1 . getType ( ) == TYPE_1 . VAR_2 || VAR_1 . getType ( ) == TYPE_1 . VAR_3 || VAR_1 . getType ( ) == TYPE_1 . VAR_4 ) ) { VAR_1 = VAR_1 . METHOD_2 ( ) ; } return VAR_1 ; } |
return VAR_1 = = null || = = null ; | public boolean METHOD_1 ( ) { <START> if ( this . VAR_1 == null || VAR_2 == null ) { <END> return true ; } else { return false ; } } | protected boolean METHOD_1 ( ) { return this . VAR_1 == null || VAR_2 == null ; } |
shouldn t VAR_1 instead VAR_1 ? overload METHOD_1 instead changing signature | public TYPE_1 METHOD_1 ( TYPE_2 < String , TYPE_3 > VAR_1 ) { <START> return new TYPE_1 ( this . VAR_1 ) ; <END> } | public TYPE_1 METHOD_1 ( TYPE_2 < String , TYPE_3 > VAR_1 ) { return new TYPE_1 ( VAR_1 ) ; } |
TYPE_2 handled left _CODE_ METHOD_3 ( ) needs check a custom marshaller defined TYPE_2 | public boolean METHOD_1 ( Object o ) { if ( o instanceof String || o instanceof Long || o instanceof Integer || o instanceof Double || o instanceof TYPE_1 <START> || o instanceof Boolean || o instanceof byte [ ] || o instanceof TYPE_2 ) { <END> return true ; } return METHOD_2 ( ) . METHOD_3 ( o . getClass ( ) ) ; } | public boolean METHOD_1 ( Object o ) { if ( o instanceof String || o instanceof Long || o instanceof Integer || o instanceof Double || o instanceof TYPE_1 || o instanceof Boolean || o instanceof byte [ ] ) { return true ; } return METHOD_2 ( ) . METHOD_3 ( o . getClass ( ) ) ; } |
static import METHOD_2 METHOD_3 | private void METHOD_1 ( ) { TYPE_1 VAR_1 = <START> TYPE_2 . METHOD_2 ( false , TYPE_3 . create ( new TYPE_4 ( STRING_1 ) ) ) ; <END> VAR_2 = TYPE_2 . METHOD_3 ( VAR_1 , new TYPE_4 ( STRING_2 ) ) ; } | private void METHOD_1 ( ) { TYPE_1 VAR_1 = METHOD_2 ( false , TYPE_3 . create ( new TYPE_4 ( STRING_1 ) ) ) ; VAR_2 = METHOD_3 ( VAR_1 , new TYPE_4 ( STRING_2 ) ) ; } |
add safety checks null empty strings plz | public Builder METHOD_1 ( String VAR_1 ) { <START> this . VAR_2 . add ( VAR_1 ) ; <END> return this ; } | public Builder METHOD_1 ( String VAR_1 ) { if ( VAR_1 != null && ! VAR_1 . isEmpty ( ) ) { this . VAR_2 . add ( VAR_1 ) ; } return this ; } |
doesn t work e g want build deep representation a method : javapublic void _CODE_ ( provider < ? extends T > provider ) { } result METHOD_1 : void _CODE_ ( javax inject provider ) voidprovider { } | <START> public String METHOD_1 ( TYPE_1 VAR_1 ) { <END> TYPE_2 VAR_2 = new TYPE_2 ( ) ; VAR_2 . METHOD_2 ( VAR_1 ) ; return VAR_2 . METHOD_3 ( ) ; } | private String METHOD_1 ( TYPE_1 VAR_1 ) { TYPE_2 VAR_2 = new TYPE_2 ( ) ; VAR_2 . METHOD_2 ( VAR_1 ) ; return VAR_2 . METHOD_3 ( ) ; } |
please check verify VAR_2 computed means processing production definition ? work expected | public TYPE_1 ( Context context ) { super ( TYPE_1 . class . getName ( ) , context ) ; <START> for ( String VAR_1 : context . VAR_2 ) { <END> TYPE_2 VAR_3 = new TYPE_2 ( new TYPE_3 ( VAR_1 ) ) ; VAR_4 . add ( VAR_3 ) ; } } | public TYPE_1 ( Context context ) { super ( TYPE_1 . class . getName ( ) , context ) ; for ( String VAR_1 : context . VAR_2 ) { VAR_4 . add ( new TYPE_2 ( VAR_1 ) ) ; } } |
order colors changed content changed ( e g checking / unchecking a counter ) | protected void METHOD_1 ( ) { <START> VAR_1 . clear ( ) ; <END> METHOD_2 ( ) . METHOD_3 ( ) . METHOD_4 ( 0 ) . METHOD_5 ( ) . METHOD_6 ( null ) ; super . METHOD_1 ( ) ; } | protected void METHOD_1 ( ) { METHOD_2 ( ) . METHOD_3 ( ) . METHOD_4 ( 0 ) . METHOD_5 ( ) . METHOD_6 ( null ) ; super . METHOD_1 ( ) ; } |
call METHOD_5 ( ) | protected void METHOD_1 ( TYPE_1 VAR_1 ) { if ( ! VAR_2 . METHOD_2 ( ) . toString ( ) . isEmpty ( ) ) { Log . i ( TAG , STRING_1 ) ; VAR_2 . setText ( "" ) ; } if ( METHOD_3 ( ) ) { METHOD_4 ( false ) ; } <START> TYPE_2 . this . METHOD_5 ( ) ; <END> } | protected void METHOD_1 ( TYPE_1 VAR_1 ) { if ( ! VAR_2 . METHOD_2 ( ) . toString ( ) . isEmpty ( ) ) { Log . i ( TAG , STRING_1 ) ; VAR_2 . setText ( "" ) ; } if ( METHOD_3 ( ) ) { METHOD_4 ( false ) ; } METHOD_5 ( ) ; } |
method static | <START> private void METHOD_1 ( String VAR_1 ) throws TYPE_1 { <END> if ( ! VAR_1 . equalsIgnoreCase ( STRING_1 ) ) { throw new TYPE_1 ( STRING_2 + VAR_1 + STRING_3 ) ; } } | public static void METHOD_1 ( String VAR_1 ) throws TYPE_1 { if ( ! VAR_1 . equalsIgnoreCase ( STRING_1 ) ) { throw new TYPE_1 ( STRING_2 + VAR_1 + STRING_3 ) ; } } |
lines happen branch ? I don t need VAR_1 VAR_2 compact | public byte [ ] METHOD_1 ( ) { <START> Object VAR_1 = VAR_2 . METHOD_2 ( ) ; <END> METHOD_3 ( VAR_1 instanceof byte [ ] , STRING_1 , VAR_1 . getClass ( ) ) ; byte [ ] VAR_3 = ( byte [ ] ) VAR_1 ; if ( VAR_2 . METHOD_4 ( ) ) { return VAR_3 ; } return VAR_2 . METHOD_5 ( ) ; } | public byte [ ] METHOD_1 ( ) { if ( VAR_2 . METHOD_4 ( ) ) { Object VAR_1 = VAR_2 . METHOD_2 ( ) ; METHOD_3 ( VAR_1 instanceof byte [ ] , STRING_1 , VAR_1 . getClass ( ) ) ; return ( byte [ ] ) VAR_1 ; } return VAR_2 . METHOD_5 ( ) ; } |
check _CODE_ configured extension ID ( e g _CODE_ ( ) ! = - 1 ) | public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { <START> if ( VAR_1 . METHOD_2 ( ) && VAR_1 . METHOD_3 ( ) <END> == METHOD_4 ( ) ) { return VAR_1 . METHOD_5 ( METHOD_4 ( ) ) ; } return null ; } | public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { if ( VAR_1 . METHOD_2 ( ) && METHOD_4 ( ) != - 1 ) { return VAR_1 . METHOD_5 ( METHOD_4 ( ) ) ; } return null ; } |
( rawtypes ) | <START> public TYPE_3 ( TYPE_1 VAR_2 ) { <END> Assert . VAR_3 ( VAR_2 , STRING_1 ) ; this . VAR_4 = new TYPE_2 ( ) ; this . VAR_4 . METHOD_1 ( VAR_2 ) ; this . VAR_4 . METHOD_2 ( false ) ; this . VAR_4 . METHOD_3 ( ) ; } | public TYPE_3 ( TYPE_1 VAR_2 ) { Assert . VAR_3 ( VAR_2 , STRING_1 ) ; this . VAR_4 = new TYPE_2 < Object , Object > ( ) ; this . VAR_4 . METHOD_1 ( VAR_2 ) ; this . VAR_4 . METHOD_2 ( false ) ; this . VAR_4 . METHOD_3 ( ) ; } |
I s nicer call TYPE_1 constructor suggested earlier sole parameter TYPE_1 constructor pull _CODE_ _CODE_ | public TYPE_1 build ( ) { <START> try { <END> return VAR_1 ; } finally { VAR_1 = null ; } } | public TYPE_1 build ( ) { return new TYPE_1 ( this ) ; } |
e VAR_4 ( ) please doesn t provide info pollutes logs CI builds | protected void METHOD_1 ( TYPE_1 VAR_1 ) { try { TYPE_2 method = TYPE_3 . class . METHOD_2 ( STRING_1 ) ; method . VAR_2 ( true ) ; method . VAR_3 ( VAR_1 ) ; } catch ( Exception e ) { <START> e . VAR_4 ( ) ; <END> METHOD_3 ( STRING_2 + e . toString ( ) ) ; } } | protected void METHOD_1 ( TYPE_1 VAR_1 ) { try { TYPE_2 method = TYPE_3 . class . METHOD_2 ( STRING_1 ) ; method . VAR_2 ( true ) ; method . VAR_3 ( VAR_1 ) ; } catch ( Exception e ) { METHOD_3 ( STRING_2 + e . toString ( ) ) ; } } |
nitpick : redundant | public TYPE_1 ( String VAR_2 , String val , String VAR_3 ) { <START> super ( ) ; <END> this . VAR_2 = VAR_2 ; this . val = val ; this . VAR_3 = VAR_3 ; } | public TYPE_1 ( String VAR_2 , String val , String VAR_3 ) { this . VAR_2 = VAR_2 ; this . val = val ; this . VAR_3 = VAR_3 ; } |
method deprecated VAR_4 version ( ) instead | private TYPE_1 METHOD_1 ( ) { org . VAR_1 . client . VAR_2 . configuration . TYPE_4 VAR_4 = super . METHOD_2 ( VAR_5 . get ( 0 ) . METHOD_3 ( ) ) ; VAR_4 . METHOD_4 ( new TYPE_2 ( ) ) ; <START> VAR_4 . METHOD_5 ( METHOD_6 ( ) ) ; <END> return new TYPE_3 ( VAR_4 . build ( ) ) ; } | private TYPE_1 METHOD_1 ( ) { org . VAR_1 . client . VAR_2 . configuration . TYPE_4 VAR_4 = super . METHOD_2 ( VAR_5 . get ( 0 ) . METHOD_3 ( ) ) ; VAR_4 . METHOD_4 ( new TYPE_2 ( ) ) ; VAR_4 . version ( METHOD_6 ( ) ) ; return new TYPE_3 ( VAR_4 . build ( ) ) ; } |
visibility missing synchronized _CODE_ return TYPE_1 ? return a List < _CODE_ > | <START> static synchronized TYPE_1 < TYPE_2 > METHOD_1 ( ) { <END> return new ArrayList < TYPE_2 > ( VAR_1 ) ; } | private static synchronized TYPE_1 < TYPE_2 > METHOD_1 ( ) { return new ArrayList < TYPE_2 > ( VAR_1 ) ; } |
( enable ) loop gracefully s > 0 | private void METHOD_1 ( final boolean VAR_1 , final TYPE_1 ... VAR_2 ) { for ( TYPE_1 VAR_3 : VAR_2 ) { VAR_3 . METHOD_2 ( VAR_1 ) ; } if ( VAR_2 . length > 0 <START> && VAR_1 ) <END> { for ( TYPE_1 VAR_3 : VAR_2 ) { if ( VAR_3 instanceof TYPE_2 ) { VAR_3 . METHOD_3 ( ) ; break ; } } } } | private void METHOD_1 ( final boolean VAR_1 , final TYPE_1 ... VAR_2 ) { for ( TYPE_1 VAR_3 : VAR_2 ) { VAR_3 . METHOD_2 ( VAR_1 ) ; } if ( VAR_1 ) { for ( TYPE_1 VAR_3 : VAR_2 ) { if ( VAR_3 instanceof TYPE_2 ) { VAR_3 . METHOD_3 ( ) ; break ; } } } } |
yea A METHOD_2 : ) | public Object METHOD_1 ( Object VAR_1 , TYPE_1 method , Object [ ] args ) throws Throwable { Object object = method . VAR_2 ( VAR_3 , args ) ; if ( method . getName ( ) . equals ( STRING_1 ) && VAR_4 . contains ( object . getClass ( ) ) ) { <START> object = METHOD_2 ( object ) ; <END> } return object ; } | public Object METHOD_1 ( Object VAR_1 , TYPE_1 method , Object [ ] args ) throws Throwable { Object object = method . VAR_2 ( VAR_3 , args ) ; if ( object != null && method . getName ( ) . equals ( STRING_1 ) && VAR_4 . contains ( object . getClass ( ) ) ) { object = METHOD_2 ( object ) ; } return object ; } |
filter filter enabled please careful test code submitting | private boolean METHOD_1 ( TYPE_1 position ) { return VAR_1 && ! position . VAR_2 ( ) <START> || position . VAR_3 ( ) > INT_1 || position . VAR_4 ( ) > INT_2 <END> || position . VAR_3 ( ) < - INT_1 || position . VAR_4 ( ) < - INT_2 ; } | private boolean METHOD_1 ( TYPE_1 position ) { if ( VAR_1 == true ) { return ! position . VAR_2 ( ) || position . VAR_3 ( ) > INT_1 || position . VAR_4 ( ) > INT_2 || position . VAR_3 ( ) < - INT_1 || position . VAR_4 ( ) < - INT_2 ; } return false ; } |
_CODE_ ( ) null set container calling method | public TYPE_8 ( final TYPE_1 VAR_2 , final TYPE_2 VAR_3 , final TYPE_3 VAR_4 , final TYPE_4 source , final TYPE_4 target ) { this ( VAR_2 , VAR_3 ) ; VAR_5 = new TYPE_5 ( VAR_4 , VAR_3 , source , target , TYPE_6 . METHOD_1 ( METHOD_2 ( ) ) ) ; <START> this . container = ( TYPE_7 ) source ; <END> } | public TYPE_8 ( final TYPE_1 VAR_2 , final TYPE_2 VAR_3 , final TYPE_3 VAR_4 , final TYPE_4 source , final TYPE_4 target ) { this ( VAR_2 , VAR_3 ) ; this . container = ( TYPE_7 ) source ; VAR_5 = new TYPE_5 ( VAR_4 , VAR_3 , source , target , TYPE_6 . METHOD_1 ( METHOD_2 ( ) ) ) ; } |
declare VAR_4 Map | public static TYPE_1 METHOD_1 ( final String VAR_1 , final String VAR_2 ) { final TYPE_1 VAR_3 = new TYPE_1 ( 1 ) ; <START> final TYPE_2 < String , List < TYPE_3 > > VAR_4 = new TYPE_2 < > ( ) ; <END> final List < TYPE_3 > VAR_5 = new ArrayList < > ( ) ; VAR_5 . add ( new TYPE_3 ( VAR_1 , 1 , VAR_2 ) ) ; VAR_4 . put ( VAR_1 , VAR_5 ) ; VAR_3 . METHOD_2 ( VAR_4 ) ; VAR_3 . METHOD_3 ( VAR_1 ) ; return VAR_3 ; } | public static TYPE_1 METHOD_1 ( final String VAR_1 , final String VAR_2 ) { final TYPE_1 VAR_3 = new TYPE_1 ( 1 ) ; final Map < String , List < TYPE_3 > > VAR_4 = new TYPE_2 < > ( ) ; final List < TYPE_3 > VAR_5 = new ArrayList < > ( ) ; VAR_5 . add ( new TYPE_3 ( VAR_1 , 1 , VAR_2 ) ) ; VAR_4 . put ( VAR_1 , VAR_5 ) ; VAR_3 . METHOD_2 ( VAR_4 ) ; VAR_3 . METHOD_3 ( VAR_1 ) ; return VAR_3 ; } |
metadata dump need reset table parameters related stats false | public TYPE_1 < TYPE_2 > table ( final String VAR_1 , TYPE_3 conf ) throws TYPE_4 { <START> boolean VAR_2 = ! conf . VAR_3 ( TYPE_3 . TYPE_5 . VAR_5 ) ; <END> return new TYPE_1 < > ( VAR_6 , ( ) - > db . VAR_7 ( VAR_8 , VAR_1 , false , false , VAR_2 ) ) ; } | public TYPE_1 < TYPE_2 > table ( final String VAR_1 , TYPE_3 conf ) throws TYPE_4 { boolean VAR_2 = ! conf . VAR_3 ( TYPE_3 . TYPE_5 . VAR_5 ) ; return new TYPE_1 < > ( VAR_6 , ( ) - > db . VAR_7 ( VAR_8 , VAR_1 , true , false , VAR_2 ) ) ; } |
returning a Set emphasis specific order returned collection | <START> public List < TYPE_1 > METHOD_1 ( TYPE_2 session ) { <END> return METHOD_2 ( session ) . METHOD_1 ( ) ; } | public Set < TYPE_1 > METHOD_1 ( TYPE_2 session ) { return METHOD_2 ( session ) . METHOD_1 ( ) ; } |
calles TYPE_7 METHOD_4 please remove | public static TYPE_1 METHOD_1 ( TYPE_2 VAR_1 , TYPE_3 VAR_2 ) { TYPE_4 configuration = METHOD_2 ( ) ; VAR_2 . METHOD_3 ( configuration ) ; configuration . set ( STRING_1 , STRING_2 ) ; try { <START> TYPE_5 . METHOD_4 ( configuration ) ; <END> } catch ( IOException exception ) { throw new TYPE_6 ( exception ) ; } TYPE_7 . METHOD_4 ( configuration ) ; return new TYPE_1 ( VAR_1 ) ; } | public static TYPE_1 METHOD_1 ( TYPE_2 VAR_1 , TYPE_3 VAR_2 ) { TYPE_4 configuration = METHOD_2 ( ) ; VAR_2 . METHOD_3 ( configuration ) ; configuration . set ( STRING_1 , STRING_2 ) ; TYPE_7 . METHOD_4 ( configuration ) ; return new TYPE_1 ( VAR_1 ) ; } |
_CODE_ care cleanup automagically ? reasons | public void METHOD_1 ( ) throws Exception { if ( this . VAR_1 != null ) { this . VAR_1 . close ( ) ; } final Path VAR_2 = TYPE_1 . METHOD_2 ( ) ; if ( TYPE_2 . exists ( VAR_2 ) ) { <START> TYPE_2 . METHOD_3 ( TYPE_1 ) ; <END> } } | public void METHOD_1 ( ) throws Exception { if ( this . VAR_1 != null ) { this . VAR_1 . close ( ) ; } } |
didn t 2 lines ? I thought added cover happy path ? removed | public List < String > METHOD_1 ( final String ... args ) { final List < String > list = new ArrayList < String > ( args . length ) ; list . addAll ( Arrays . asList ( args ) ) ; <START> final List < String > result = new TYPE_1 < > ( ) ; <END> result . addAll ( list . VAR_1 ( 0 , TYPE_2 . VAR_3 ) ) ; return result ; } | public List < String > METHOD_1 ( final String ... args ) { final List < String > list = new ArrayList < String > ( args . length ) ; list . addAll ( Arrays . asList ( args ) ) ; return list ; } |
List | List < Object > METHOD_1 ( int VAR_1 ) { <START> ArrayList < Object > result = new ArrayList < Object > ( ) ; <END> for ( Object [ ] VAR_2 : VAR_3 ) { result . add ( VAR_2 [ VAR_1 ] ) ; } return result ; } | public List < Object > METHOD_1 ( int VAR_1 ) { List < Object > result = new ArrayList < > ( ) ; for ( Object [ ] VAR_2 : VAR_3 ) { result . add ( VAR_2 [ VAR_1 ] ) ; } return result ; } |
else ternary | private static TYPE_1 METHOD_1 ( Context context ) { final int VAR_1 = R . string . VAR_2 ; final String VAR_3 = context . getString ( R . string . TYPE_3 ) ; final String VAR_5 = context . getString ( R . string . TYPE_4 ) ; if ( TYPE_2 . METHOD_2 ( context ) ) return context . getString ( VAR_1 , VAR_3 ) ; <START> return context . getString ( VAR_1 , VAR_5 ) ; <END> } | private static TYPE_1 METHOD_1 ( Context context ) { final int VAR_1 = R . string . VAR_2 ; final String VAR_3 = context . getString ( R . string . TYPE_3 ) ; final String VAR_5 = context . getString ( R . string . TYPE_4 ) ; if ( TYPE_2 . METHOD_2 ( context ) ) { return context . getString ( VAR_1 , VAR_3 ) ; } else { return context . getString ( VAR_1 , VAR_5 ) ; } } |
initially load data callback ? loading manually ? prevent loading | public void METHOD_1 ( TYPE_1 view , int VAR_1 , int VAR_2 , int VAR_3 ) { if ( VAR_3 < VAR_4 ) { VAR_5 = VAR_6 ; VAR_4 = VAR_3 ; if ( VAR_3 == 0 ) { <START> VAR_7 = true ; <END> } } if ( VAR_7 && ( VAR_3 > VAR_4 ) ) { VAR_7 = false ; VAR_4 = VAR_3 ; VAR_5 ++ ; } if ( ! VAR_7 && ( VAR_3 - VAR_2 ) <= ( VAR_1 + VAR_8 ) ) { VAR_7 = METHOD_2 ( VAR_5 + 1 , VAR_3 ) ; } } | public void METHOD_1 ( TYPE_1 view , int VAR_1 , int VAR_2 , int VAR_3 ) { if ( VAR_3 < VAR_4 ) { VAR_5 = VAR_6 ; VAR_4 = VAR_3 ; if ( VAR_3 == 0 ) { VAR_7 = true ; } } if ( VAR_7 && ( VAR_3 > VAR_4 ) ) { VAR_7 = false ; VAR_4 = VAR_3 ; VAR_5 ++ ; } if ( ! VAR_7 && ( VAR_3 - VAR_2 ) <= ( VAR_1 + VAR_8 ) ) { VAR_7 = METHOD_2 ( VAR_5 + 1 ) ; } } |
return String VAR_3 creating new String | private String METHOD_1 ( List < TYPE_1 > VAR_1 ) { <START> String VAR_2 = String . VAR_3 ( STRING_1 , VAR_1 . stream ( ) . map ( t - > t . id ( ) ) . collect ( Collectors . VAR_4 ( ) ) ) ; <END> return VAR_2 ; } | private String METHOD_1 ( List < TYPE_1 > VAR_1 ) { return String . VAR_3 ( STRING_1 , VAR_1 . stream ( ) . map ( t - > t . id ( ) ) . collect ( Collectors . VAR_4 ( ) ) ) ; } |
a tiny micro - optimization I ll mention add readability : sets _CODE_ ( s split ( STRING_1 ) | public void METHOD_1 ( String s ) { if ( s != null && ! s . equals ( "" ) ) <START> VAR_1 = new HashSet < String > ( Arrays . asList ( s . split ( STRING_1 ) ) ) ; <END> } | public void METHOD_1 ( String s ) { if ( ! s . isEmpty ( ) ) { VAR_1 = new HashSet < > ( ) ; Collections . addAll ( VAR_1 , s . split ( STRING_1 ) ) ; } } |
I m a bit confused exception catching METHOD_2 t fail error null isn t TYPE_1 ; cases handled a check | private Throwable METHOD_1 ( Object error ) { try { return ( ( TYPE_1 ) error ) . METHOD_2 ( ) ; <START> } catch ( Exception e ) { <END> return ( Throwable ) error ; } } | private Throwable METHOD_1 ( Object error ) { if ( error instanceof TYPE_1 ) { return ( ( TYPE_1 ) error ) . METHOD_2 ( ) ; } return ( Throwable ) error ; } |
swallowing exception ? intentionally mistake | public void run ( ) { try { this . VAR_1 . METHOD_1 ( ) ; } catch ( final InterruptedException ex ) { Thread . VAR_2 ( ) . METHOD_2 ( ) ; Logger . warn ( this , STRING_1 , ex ) ; } catch ( final Throwable ex ) { <START> Logger . error ( this , STRING_1 , TYPE_1 . METHOD_3 ( ex ) ) ; <END> } } | public void run ( ) { try { this . VAR_1 . METHOD_1 ( ) ; } catch ( final InterruptedException ex ) { Thread . VAR_2 ( ) . METHOD_2 ( ) ; Logger . warn ( this , STRING_1 , ex ) ; } } |
VAR_3 null method | public boolean METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) { <START> return VAR_3 . METHOD_1 ( VAR_1 , VAR_2 ) ; <END> } | public boolean METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) { return VAR_3 != null ? VAR_3 . METHOD_1 ( VAR_1 , VAR_2 ) : false ; } |
set field declaration | public TYPE_1 ( ) { <START> this . VAR_2 = METHOD_1 ( 100 ) ; <END> } | public TYPE_1 ( ) { } |
private - > protected | <START> private boolean METHOD_1 ( TYPE_1 VAR_1 , String VAR_2 ) { <END> return VAR_1 . METHOD_2 ( ) || VAR_1 . METHOD_3 ( ) . contains ( VAR_2 ) ; } | protected boolean METHOD_1 ( TYPE_1 VAR_1 , String VAR_2 ) { return VAR_1 . METHOD_2 ( ) || VAR_1 . METHOD_3 ( ) . contains ( VAR_2 ) ; } |
call METHOD_1 | public void start ( ) throws Exception { <START> METHOD_1 ( ) ; <END> TYPE_1 . METHOD_2 ( METHOD_3 ( ) . METHOD_4 ( ) ) ; } | public void start ( ) throws Exception { TYPE_1 . METHOD_2 ( METHOD_3 ( ) . METHOD_4 ( ) ) ; } |
change ( i = length - 1 ; i > = 0 ; i - - ) don t extra subtraction | public static TYPE_1 METHOD_1 ( String ... VAR_1 ) { TYPE_2 s = null ; final int length = VAR_1 . length ; <START> for ( int i = 0 ; i < length ; i ++ ) { <END> s = new TYPE_2 ( VAR_1 [ length - 1 - i ] , s ) ; } return new TYPE_1 ( s ) ; } | public static TYPE_1 METHOD_1 ( String ... VAR_1 ) { TYPE_2 s = null ; for ( int i = VAR_1 . length - 1 ; i >= 0 ; i -- ) { s = new TYPE_2 ( VAR_1 [ i ] , s ) ; } return new TYPE_1 ( s ) ; } |
code METHOD_2 ( ) done constructor TYPE_2 | private void METHOD_1 ( ) { this . VAR_1 = new TYPE_1 ( session ) ; this . VAR_1 . METHOD_2 ( ) ; this . VAR_2 = new TYPE_2 ( session ) ; <START> this . VAR_2 . METHOD_2 ( ) ; <END> } | private void METHOD_1 ( ) { this . VAR_1 = new TYPE_1 ( session ) ; this . VAR_2 = new TYPE_2 ( session ) ; this . VAR_2 . METHOD_2 ( ) ; } |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.