ReviewComments
stringlengths
1
2.35k
OriginalCode
stringlengths
28
487
ReviewedCode
stringlengths
14
463
space STARTS ?
public String METHOD_1 ( ) { String VAR_1 = METHOD_2 ( VAR_2 [ VAR_3 ] ) ; String VAR_4 = METHOD_2 ( VAR_2 [ VAR_5 ] ) ; TYPE_1 sb = new TYPE_1 ( ) ; <START> sb . append ( VAR_1 ) . append ( CHAR_1 ) . append ( TYPE_2 . VAR_7 ) . append ( TYPE_2 . VAR_8 ) . append ( CHAR_1 ) ; <END> sb . append ( VAR_4 ) ; return sb . toString ( ) ; }
public String METHOD_1 ( ) { String VAR_1 = METHOD_2 ( VAR_2 [ VAR_3 ] ) ; String VAR_4 = METHOD_2 ( VAR_2 [ VAR_5 ] ) ; TYPE_1 sb = new TYPE_1 ( ) ; sb . append ( VAR_1 ) . append ( CHAR_1 ) . append ( TYPE_2 . VAR_7 ) . append ( CHAR_1 ) . append ( TYPE_2 . VAR_8 ) . append ( CHAR_1 ) ; sb . append ( VAR_4 ) ; return sb . toString ( ) ; }
simplify : return
public boolean METHOD_1 ( TYPE_1 request ) throws TYPE_2 { TYPE_3 VAR_1 = request . VAR_2 ( ) ; TYPE_4 VAR_3 = VAR_4 . METHOD_2 ( TYPE_4 . class ) ; if ( null == VAR_3 ) { return true ; } TYPE_3 [ ] VAR_5 = VAR_3 . METHOD_3 ( ) ; <START> if ( TYPE_5 . isEmpty ( VAR_5 ) || TYPE_5 . contains ( VAR_5 , VAR_1 ) ) { <END> return true ; } return false ; }
public boolean METHOD_1 ( TYPE_1 request ) throws TYPE_2 { TYPE_3 VAR_1 = request . VAR_2 ( ) ; TYPE_4 VAR_3 = VAR_4 . METHOD_2 ( TYPE_4 . class ) ; if ( null == VAR_3 ) { return true ; } TYPE_3 [ ] VAR_5 = VAR_3 . METHOD_3 ( ) ; return ( TYPE_5 . isEmpty ( VAR_5 ) || TYPE_5 . contains ( VAR_5 , VAR_1 ) ) ; }
return false
private boolean METHOD_1 ( String string ) { try { TYPE_1 uri = new TYPE_1 ( STRING_1 + string ) ; if ( uri . VAR_1 ( ) == null || uri . VAR_2 ( ) == - 1 ) { <START> throw new TYPE_2 ( uri . toString ( ) , STRING_2 ) ; <END> } } catch ( TYPE_2 ex ) { return false ; } return true ; }
private boolean METHOD_1 ( String string ) { try { TYPE_1 uri = new TYPE_1 ( STRING_1 + string ) ; if ( uri . VAR_1 ( ) == null || uri . VAR_2 ( ) == - 1 ) { return false ; } } catch ( TYPE_2 ex ) { return false ; } return true ; }
- else increment case
private int METHOD_1 ( ) { <START> if ( ! METHOD_2 ( VAR_1 ) ) VAR_1 = VAR_2 ; <END> return VAR_1 ++ ; }
int METHOD_1 ( ) { if ( ! METHOD_2 ( VAR_1 ) ) VAR_1 = VAR_2 ; return VAR_1 ++ ; }
VAR_2 = Arrays asList ( VAR_2 ) ;
public TYPE_2 ( TYPE_1 ... VAR_2 ) { <START> this . VAR_2 = new ArrayList < > ( Arrays . asList ( VAR_2 ) ) ; <END> }
public TYPE_2 ( TYPE_1 ... VAR_2 ) { this . VAR_2 = Arrays . asList ( VAR_2 ) ; }
assertEquals ( ) ( useful message ) instead assertTrue ( ) ll a useful stack trace fails ? future users file example write a good _CODE_ test
public void METHOD_1 ( ) { int i = VAR_1 . get ( 0 ) ; <START> assertTrue ( i == 1 ) ; <END> try { VAR_1 . get ( VAR_1 . size ( ) ) ; } catch ( TYPE_1 e ) { return ; } METHOD_2 ( STRING_1 ) ; }
public void METHOD_1 ( ) { int i = VAR_1 . get ( 0 ) ; assertEquals ( 1 , i ) ; try { VAR_1 . get ( VAR_1 . size ( ) ) ; } catch ( TYPE_1 e ) { return ; } METHOD_2 ( STRING_1 ) ; }
needs a space needs { } else
public String METHOD_1 ( TYPE_1 [ ] args , String [ ] VAR_1 ) { TYPE_2 VAR_2 = TYPE_3 . METHOD_2 ( args , VAR_1 ) ; TYPE_4 . METHOD_3 ( VAR_2 ) ; String cmd = VAR_2 . getString ( 0 ) ; <START> if ( args . length == 2 ) <END> return VAR_3 . METHOD_1 ( cmd , VAR_2 . getInt ( 1 ) ) ; else return VAR_3 . METHOD_1 ( cmd ) ; }
public String METHOD_1 ( TYPE_1 [ ] args , String [ ] VAR_1 ) { TYPE_2 VAR_2 = TYPE_3 . METHOD_2 ( args , VAR_1 ) ; TYPE_4 . METHOD_3 ( VAR_2 ) ; String cmd = VAR_2 . getString ( 0 ) ; if ( args . length == 2 ) { return VAR_3 . METHOD_1 ( cmd , VAR_2 . getInt ( 1 ) ) ; } else { return VAR_3 . METHOD_1 ( cmd ) ; } }
remove synchronized
<START> public synchronized static Set < Class < ? extends TYPE_1 > > METHOD_1 ( TYPE_2 VAR_1 ) { <END> final Set < Class < ? extends TYPE_1 > > VAR_2 = VAR_1 . METHOD_2 ( TYPE_1 . class ) ; logger . debug ( STRING_1 , VAR_2 . size ( ) , VAR_2 ) ; return VAR_2 ; }
public static Set < Class < ? extends TYPE_1 > > METHOD_1 ( TYPE_2 VAR_1 ) { final Set < Class < ? extends TYPE_1 > > VAR_2 = VAR_1 . METHOD_2 ( TYPE_1 . class ) ; logger . debug ( STRING_1 , VAR_2 . size ( ) , VAR_2 ) ; return VAR_2 ; }
good catch null check I forgot maps null a key
protected Map < String , Object > METHOD_1 ( String VAR_1 ) { Map < String , Object > VAR_2 = new TYPE_1 < String , Object > ( ) ; for ( Map . Entry < String , Object > e : VAR_3 . entrySet ( ) ) { <START> if ( e . getKey ( ) != null && e . getKey ( ) . startsWith ( VAR_1 ) ) { <END> VAR_2 . put ( e . getKey ( ) , e . getValue ( ) ) ; } } return VAR_2 ; }
protected Map < String , String > METHOD_1 ( String VAR_1 ) { Map < String , String > VAR_2 = new TYPE_1 < String , String > ( ) ; for ( Map . Entry < String , String > e : VAR_3 . entrySet ( ) ) { if ( e . getKey ( ) != null && e . getKey ( ) . startsWith ( VAR_1 ) ) { VAR_2 . put ( e . getKey ( ) , e . getValue ( ) ) ; } } return VAR_2 ; }
s debug level instead info
public TYPE_1 METHOD_1 ( String VAR_1 ) { TYPE_1 VAR_2 = new TYPE_1 ( ) ; VAR_2 = METHOD_2 ( VAR_2 ) ; if ( R . VAR_3 . METHOD_3 ( TYPE_2 . VAR_5 ) && ! R . VAR_3 . get ( TYPE_2 . VAR_5 ) . isEmpty ( ) ) { <START> LOGGER . info ( STRING_1 ) ; <END> METHOD_4 ( VAR_2 ) ; } return VAR_2 ; }
public TYPE_1 METHOD_1 ( String VAR_1 ) { TYPE_1 VAR_2 = new TYPE_1 ( ) ; VAR_2 = METHOD_2 ( VAR_2 ) ; return VAR_2 ; }
longer needs synchronized protect connections longer needed create a new TYPE_3
<START> public synchronized TYPE_1 METHOD_1 ( String VAR_1 , String host , int VAR_2 , TYPE_2 [ ] VAR_3 ) { <END> return new TYPE_3 ( VAR_4 , VAR_3 , VAR_5 , VAR_6 , host , VAR_2 , this ) ; }
public TYPE_1 METHOD_1 ( String VAR_1 , String host , int VAR_2 , TYPE_2 [ ] VAR_3 ) { return new TYPE_3 ( VAR_4 , VAR_3 , VAR_5 , VAR_6 , host , VAR_2 ) ; }
cleaner rid VAR_2 filter rewrite code METHOD_2 false access filters create a _CODE_ I move VAR_1 filter TYPE_1 java file anonymization config settings
<START> public static TYPE_1 get ( ) { <END> return TYPE_2 . METHOD_1 ( TYPE_3 . class ) . METHOD_2 ( ) ? VAR_1 : VAR_2 ; }
public static TYPE_3 get ( ) { return TYPE_2 . METHOD_1 ( TYPE_3 . class ) ; }
( string comparison )
public TYPE_1 METHOD_1 ( ) { TYPE_2 VAR_1 = new TYPE_2 ( METHOD_2 ( ) , STRING_1 ) ; TYPE_3 res = METHOD_3 ( ) . execute ( VAR_1 ) ; if ( res != null && res . VAR_2 ( ) ) { <START> if ( res . VAR_3 ( ) . equals ( STRING_2 ) ) { <END> return TYPE_1 . VAR_4 ; } } return TYPE_1 . VAR_5 ; }
public TYPE_1 METHOD_1 ( ) { TYPE_2 VAR_1 = new TYPE_2 ( METHOD_2 ( ) , STRING_1 ) ; TYPE_3 res = METHOD_3 ( ) . execute ( VAR_1 ) ; if ( res != null && res . VAR_2 ( ) ) { if ( STRING_2 . equals ( res . VAR_3 ( ) ) ) { return TYPE_1 . VAR_4 ; } } return TYPE_1 . VAR_5 ; }
remove remark
public boolean METHOD_1 ( ) { boolean VAR_1 = false ; if <START> ( TYPE_2 . TYPE_3 . METHOD_2 ( ) . equals ( METHOD_3 ( ) ) ) <END> { VAR_1 = true ; } return VAR_1 ; }
public boolean METHOD_1 ( ) { boolean VAR_1 = false ; if ( TYPE_2 . TYPE_3 . equals ( METHOD_3 ( ) ) ) { VAR_1 = true ; } return VAR_1 ; }
implement ? _CODE_ Object _CODE_ ( channel channel _CODE_ ) throws IOException { return Response HEARTBEAT_EVENT ; }
private void METHOD_1 ( TYPE_1 out , Object data ) throws IOException { if ( data != null ) { <START> out . VAR_1 ( data ) ; <END> } else { logger . warn ( STRING_1 ) ; } }
private void METHOD_1 ( TYPE_1 out , Object data ) throws IOException { out . VAR_1 ( data ) ; }
a need log debug transaction scope
public void METHOD_1 ( ) { try { log . debug ( STRING_1 ) ; TYPE_1 . METHOD_2 ( TYPE_2 . TYPE_3 , ( ) - > { VAR_3 . METHOD_3 ( new Date ( ) ) ; VAR_4 . METHOD_4 ( VAR_3 ) ; <START> log . debug ( STRING_2 ) ; <END> return null ; } ) ; } catch ( Exception ex ) { log . error ( STRING_3 , ex . getMessage ( ) ) ; log . debug ( STRING_4 , ex ) ; } }
public void METHOD_1 ( ) { try { log . debug ( STRING_1 ) ; TYPE_1 . METHOD_2 ( TYPE_2 . TYPE_3 , ( ) - > { VAR_3 . METHOD_3 ( new Date ( ) ) ; VAR_4 . METHOD_4 ( VAR_3 ) ; return null ; } ) ; log . debug ( STRING_2 ) ; } catch ( Exception ex ) { log . error ( STRING_3 , ex . getMessage ( ) ) ; log . debug ( STRING_4 , ex ) ; } }
missing args - > TYPE_3 METHOD_2 ( VAR_1 STRING_1 ) ;
public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { <START> TYPE_3 . METHOD_2 ( STRING_1 ) ; <END> this . VAR_2 . put ( Utils . VAR_3 , VAR_1 ) ; return this ; }
public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { TYPE_3 . METHOD_2 ( VAR_1 , STRING_1 ) ; this . VAR_2 . put ( Utils . VAR_3 , VAR_1 ) ; return this ; }
considered case ? more entity relevant more block position relevant ? more d gain a smidgen performance inverting expressions
private boolean METHOD_1 ( TYPE_1 entity , TYPE_2 position ) { <START> return entity . VAR_1 ( ) || VAR_2 . METHOD_2 ( position ) ; <END> }
private boolean METHOD_1 ( TYPE_1 entity , TYPE_2 position ) { return VAR_2 . METHOD_2 ( position ) || entity . VAR_1 ( ) ; }
declared unused
public String METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) { TYPE_3 VAR_3 = METHOD_2 ( VAR_1 , VAR_2 ) ; <START> TYPE_4 VAR_4 = null ; <END> if ( ( VAR_3 != null ) && ( VAR_3 instanceof TYPE_4 ) ) { return ( ( TYPE_4 ) VAR_3 ) . METHOD_3 ( ) ; } return null ; }
public String METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) { TYPE_3 VAR_3 = METHOD_2 ( VAR_1 , VAR_2 ) ; if ( VAR_3 != null && ( VAR_3 instanceof TYPE_4 ) ) { return ( ( TYPE_4 ) VAR_3 ) . METHOD_3 ( ) ; } return null ; }
_CODE_ codestyle
<START> @Override public String toString ( ) <END> { return STRING_1 + metadata + CHAR_1 ; }
public String toString ( ) { return STRING_1 + metadata + CHAR_1 ; }
lines merged
public static TYPE_1 METHOD_1 ( final List < TYPE_2 > VAR_1 , final TYPE_3 VAR_2 ) { <START> final TYPE_1 VAR_3 = new TYPE_1 ( <END> new TYPE_4 ( STRING_1 ) , VAR_1 , VAR_2 ) ; return VAR_3 ; }
public static TYPE_1 METHOD_1 ( final List < TYPE_2 > VAR_1 , final TYPE_3 VAR_2 ) { return new TYPE_1 ( new TYPE_4 ( STRING_1 ) , VAR_1 , VAR_2 ) ; }
new _CODE_ ( GENERIC_RECOVERY_ERROR ) ? rethrow : ( catch _CODE_ specifically a special case )
public synchronized void METHOD_1 ( TYPE_1 VAR_1 ) throws TYPE_2 { METHOD_2 ( VAR_2 . isPresent ( ) , STRING_1 ) ; if ( VAR_3 ) { <START> throw new IllegalStateException ( STRING_2 ) ; <END> } VAR_2 . get ( ) . METHOD_3 ( VAR_1 . getId ( ) , VAR_4 ) ; }
public synchronized void METHOD_1 ( TYPE_1 VAR_1 ) { METHOD_2 ( VAR_2 . isPresent ( ) , STRING_1 ) ; if ( VAR_3 ) { throw new IllegalStateException ( STRING_2 ) ; } VAR_2 . get ( ) . METHOD_3 ( VAR_1 . getId ( ) , VAR_4 ) ; }
[ 0 length )
public TYPE_1 [ ] METHOD_1 ( int start , int length ) { TYPE_2 VAR_1 = TYPE_3 . METHOD_2 ( new TYPE_4 ( ) , length ) ; <START> for ( int i = start ; i < start + length ; i ++ ) { <END> VAR_1 . METHOD_3 ( ) ; } return new TYPE_1 [ ] { VAR_1 . build ( ) } ; }
public TYPE_1 [ ] METHOD_1 ( int start , int length ) { TYPE_2 VAR_1 = TYPE_3 . METHOD_2 ( new TYPE_4 ( ) , length ) ; for ( int i = 0 ; i < length ; i ++ ) { VAR_1 . METHOD_3 ( ) ; } return new TYPE_1 [ ] { VAR_1 . build ( ) } ; }
I don t need LOG info - more ; LOG debug removed
public List < TYPE_1 > METHOD_1 ( ) { <START> LOG . info ( STRING_1 ) ; <END> TYPE_2 VAR_1 = new TYPE_2 ( ) ; return VAR_1 . METHOD_2 ( ) ; }
public List < TYPE_1 > METHOD_1 ( ) { TYPE_2 VAR_1 = new TYPE_2 ( ) ; return VAR_1 . METHOD_2 ( ) ; }
shouldn t exception logged
protected void METHOD_1 ( ) { logger ( ) . debug ( STRING_1 , getName ( ) , METHOD_2 ( ) ) ; try { client . close ( ) ; VAR_1 . METHOD_3 ( ) ; } catch ( Exception e ) { <START> } <END> }
protected void METHOD_1 ( ) { logger ( ) . debug ( STRING_1 , getName ( ) , METHOD_2 ( ) ) ; }
consider VAR_1 METHOD_5 ( VAR_1 METHOD_4 ( ) > 2 > View VAR_4 : View VAR_3 ) ; emphasize conditional effects function input other logic
private void METHOD_1 ( String description ) { VAR_1 . setText ( description ) ; VAR_1 . METHOD_2 ( new TYPE_1 ( ) { @Override public void run ( ) { if ( ! VAR_2 . METHOD_3 ( ) ) { return ; } if ( VAR_1 . METHOD_4 ( ) > 2 ) { <START> VAR_1 . METHOD_5 ( View . VAR_3 ) ; <END> } else { VAR_1 . METHOD_5 ( View . VAR_4 ) ; } } } ) ; }
private void METHOD_1 ( String description ) { VAR_1 . setText ( description ) ; VAR_1 . METHOD_2 ( new TYPE_1 ( ) { @Override public void run ( ) { if ( ! VAR_2 . METHOD_3 ( ) ) { return ; } VAR_1 . METHOD_5 ( VAR_1 . METHOD_4 ( ) > 2 ? View . VAR_3 : View . VAR_4 ) ; } } ) ; }
a reason protected
<START> TYPE_1 METHOD_1 ( ) { <END> return TYPE_1 . this ; }
protected TYPE_1 METHOD_1 ( ) { return TYPE_1 . this ; }
VAR_1 java 7
<START> public static String get ( ) { return props . VAR_1 ( VAR_2 , STRING_1 ) ; } <END>
public static String get ( ) { return props . get ( VAR_2 ) ; }
! [ MAJOR ] ( severity : MAJOR ) add @Override annotation method signature [ ! [ rule ] ( ) ] ( )
<START> protected TYPE_1 METHOD_1 ( TYPE_1 parent , TYPE_2 VAR_1 , TYPE_3 VAR_2 ) { <END> TYPE_1 VAR_3 = METHOD_2 ( parent , VAR_2 ) ; METHOD_3 ( VAR_3 , VAR_2 ) ; METHOD_4 ( VAR_3 , VAR_2 , VAR_1 ) ; METHOD_5 ( parent , VAR_1 , VAR_2 ) ; return VAR_3 ; }
protected TYPE_1 METHOD_1 ( TYPE_1 parent , TYPE_2 VAR_1 , TYPE_3 VAR_2 ) { TYPE_1 VAR_3 = METHOD_2 ( parent , VAR_2 ) ; METHOD_3 ( VAR_3 , VAR_2 ) ; METHOD_4 ( VAR_3 , VAR_2 , VAR_1 ) ; METHOD_5 ( VAR_3 , VAR_1 , VAR_2 ) ; return VAR_3 ; }
TODO : remove log release
private void METHOD_1 ( TYPE_1 VAR_1 ) { if ( VAR_2 . size ( ) > 0 ) { METHOD_2 ( VAR_1 ) ; } else { METHOD_3 ( VAR_1 ) ; } <START> Log . d ( getClass ( ) . METHOD_4 ( ) , STRING_1 + VAR_2 . size ( ) ) ; <END> }
private void METHOD_1 ( TYPE_1 VAR_1 ) { if ( VAR_2 . size ( ) > 0 ) { METHOD_2 ( VAR_1 ) ; } else { METHOD_3 ( VAR_1 ) ; } }
decide stream
private static void METHOD_1 ( File VAR_1 ) { long VAR_2 = System . currentTimeMillis ( ) - ( VAR_3 * Constants . VAR_4 ) ; File [ ] VAR_5 = VAR_1 . METHOD_2 ( ) ; for ( File file : VAR_5 ) { if ( ! TYPE_1 . METHOD_3 ( file , VAR_2 ) ) { <START> METHOD_4 ( file ) ; <END> } } }
private static void METHOD_1 ( File VAR_1 ) { long VAR_2 = System . currentTimeMillis ( ) - ( VAR_3 * Constants . VAR_4 ) ; Arrays . asList ( VAR_1 . METHOD_2 ( ) ) . stream ( ) . filter ( file - > ! TYPE_1 . METHOD_3 ( file , VAR_2 ) ) . forEach ( file - > METHOD_4 ( file ) ) ; }
long
boolean VAR_1 ( ) throws Exception ; } public static void VAR_2 ( String message , <START> int VAR_3 , <END> TYPE_2 VAR_5 ) throws Exception { int VAR_6 = INT_1 ; final long VAR_7 = System . currentTimeMillis ( ) + VAR_3 * INT_2 ; while ( System . currentTimeMillis ( ) < VAR_7 ) { if ( VAR_5 . VAR_1 ( ) ) { return ; } TYPE_1 . VAR_9 ( ) . VAR_6 ( VAR_6 ) ; } VAR_10 ( message ) ; }
boolean VAR_1 ( ) throws Exception ; } public static void VAR_2 ( String message , long VAR_3 , TYPE_2 VAR_5 ) throws Exception { int VAR_6 = INT_1 ; final long VAR_7 = System . currentTimeMillis ( ) + VAR_3 * INT_2 ; while ( System . currentTimeMillis ( ) < VAR_7 ) { if ( VAR_5 . VAR_1 ( ) ) { return ; } TYPE_1 . VAR_9 ( ) . VAR_6 ( VAR_6 ) ; } VAR_10 ( message ) ; }
missing return
protected void METHOD_1 ( ) { METHOD_2 ( false ) ; if ( METHOD_3 ( ) == null ) { log . warn ( STRING_1 ) ; <START> METHOD_4 ( true ) ; <END> } METHOD_3 ( ) . METHOD_5 ( TYPE_2 . TYPE_1 ) ; METHOD_6 ( ) . METHOD_7 ( METHOD_8 ( ) ) ; METHOD_9 ( ) . update ( METHOD_3 ( ) . METHOD_10 ( ) ) ; METHOD_4 ( true ) ; }
protected void METHOD_1 ( ) { METHOD_2 ( false ) ; if ( METHOD_3 ( ) == null ) { log . warn ( STRING_1 ) ; METHOD_4 ( true ) ; return ; } METHOD_3 ( ) . METHOD_5 ( TYPE_2 . TYPE_1 ) ; METHOD_6 ( ) . METHOD_7 ( METHOD_8 ( ) ) ; METHOD_9 ( ) . update ( METHOD_3 ( ) . METHOD_10 ( ) ) ; METHOD_4 ( true ) ; }
element VAR_1 returns a _CODE_ doesn t change TYPE_1 i guess method returns a new TYPE_1
protected TYPE_1 METHOD_1 ( ) { TYPE_1 element = new TYPE_1 ( ) ; element . VAR_1 ( TYPE_2 . METHOD_2 ( METHOD_3 ( ) ) . METHOD_4 ( TYPE_3 . from ( Arrays . asList ( <START> VAR_2 . METHOD_5 ( ) ) ) . METHOD_6 ( VAR_3 ) ) ) ; <END> return element ; }
protected TYPE_1 METHOD_1 ( ) { return new TYPE_1 ( ) ; }
remove Log please
public void METHOD_1 ( ) { super . METHOD_1 ( ) ; if ( VAR_1 != null ) { VAR_1 = VAR_2 . METHOD_2 ( ) . METHOD_3 ( VAR_1 . METHOD_4 ( ) ) ; METHOD_5 ( VAR_1 ) ; ( ( TYPE_1 ) VAR_2 ) . METHOD_6 ( VAR_1 ) ; <START> TYPE_2 . d ( TAG , STRING_1 + VAR_1 . METHOD_7 ( ) + STRING_2 ) ; <END> } }
public void METHOD_1 ( ) { super . METHOD_1 ( ) ; if ( VAR_1 != null ) { VAR_1 = VAR_2 . METHOD_2 ( ) . METHOD_3 ( VAR_1 . METHOD_4 ( ) ) ; METHOD_5 ( VAR_1 ) ; ( ( TYPE_1 ) VAR_2 ) . METHOD_6 ( VAR_1 ) ; } }
change Object equals Double VAR_1 part previous commit
public boolean equals ( Object o ) { if ( this == o ) { return true ; } if ( o == null || getClass ( ) != o . getClass ( ) ) { return false ; } TYPE_1 that = ( TYPE_1 ) o ; <START> return Double . VAR_1 ( that . VAR_2 , VAR_2 ) == 0 && <END> Double . VAR_1 ( that . VAR_3 , VAR_3 ) == 0 && TYPE_2 . equals ( VAR_4 , that . VAR_4 ) ; }
public boolean equals ( Object o ) { if ( this == o ) { return true ; } if ( o == null || getClass ( ) != o . getClass ( ) ) { return false ; } TYPE_1 that = ( TYPE_1 ) o ; return Double . VAR_1 ( VAR_2 , that . VAR_2 ) == 0 && TYPE_2 . equals ( VAR_4 , that . VAR_4 ) ; }
suggest renaming VAR_10 getter
public TYPE_2 ( final TYPE_1 VAR_2 , final TYPE_1 VAR_3 , final String VAR_4 , final String VAR_5 , final String VAR_6 , final boolean VAR_7 , final long VAR_8 , final int VAR_9 ) { this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; this . VAR_4 = VAR_4 ; this . VAR_5 = VAR_5 ; this . VAR_6 = VAR_6 ; this . VAR_7 = VAR_7 ; this . VAR_8 = VAR_8 ; <START> this . VAR_10 = VAR_9 ; <END> }
public TYPE_2 ( final TYPE_1 VAR_2 , final TYPE_1 VAR_3 , final String VAR_4 , final String VAR_5 , final String VAR_6 , final boolean VAR_7 , final long VAR_8 , final int VAR_9 ) { this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; this . VAR_4 = VAR_4 ; this . VAR_5 = VAR_5 ; this . VAR_6 = VAR_6 ; this . VAR_7 = VAR_7 ; this . VAR_8 = VAR_8 ; this . VAR_9 = VAR_9 ; }
please pass VAR_2 VAR_3 methods
public void METHOD_1 ( String VAR_1 , boolean VAR_2 ) { table . VAR_3 ( STRING_1 , true ) ; <START> VAR_4 . METHOD_1 ( STRING_1 , true ) ; <END> }
public void METHOD_1 ( String VAR_1 , boolean VAR_2 ) { table . VAR_3 ( STRING_1 , VAR_2 ) ; VAR_4 . METHOD_1 ( STRING_1 , VAR_2 ) ; }
commit apply question answer answers
private void METHOD_1 ( String s ) { TYPE_1 VAR_1 = TYPE_2 . METHOD_2 ( TYPE_2 . getInstance ( ) ) ; TYPE_1 . TYPE_4 e = VAR_1 . METHOD_3 ( ) ; e . VAR_2 ( STRING_1 , true ) ; e . VAR_3 ( STRING_2 , s ) ; <START> e . commit ( ) ; <END> }
private void METHOD_1 ( String s ) { TYPE_1 VAR_1 = TYPE_2 . METHOD_2 ( TYPE_2 . getInstance ( ) ) ; TYPE_1 . TYPE_4 e = VAR_1 . METHOD_3 ( ) ; e . VAR_2 ( STRING_1 , true ) ; e . VAR_3 ( STRING_2 , s ) ; e . apply ( ) ; }
generally qualify making static import ; s coming ( implement some reason ? ) I tend static imports constants unit tests obvious provided custom code ( _CODE_ ( ) mock ( ) ) suggestionreturn Collections VAR_3 ( ) ;
default List < TYPE_1 > VAR_2 ( ) { <START> return VAR_3 ( ) ; <END> }
default List < TYPE_1 > VAR_2 ( ) { return Collections . VAR_3 ( ) ; }
I don t case required assumed VAR_5 VAR_8 invalid ( _CODE_ ( ) )
public TYPE_7 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 ) { VAR_4 = new TYPE_3 ( VAR_2 ) ; VAR_5 = new TYPE_4 ( VAR_2 ) ; VAR_6 = new TYPE_5 ( VAR_3 ) ; VAR_7 = <START> VAR_5 . VAR_8 . equals ( TYPE_4 . VAR_9 ) <END> ? null : new TYPE_6 ( VAR_5 . VAR_8 , VAR_4 ) ; }
public TYPE_7 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 ) { this ( new TYPE_3 ( VAR_2 ) , new TYPE_4 ( VAR_2 ) , new TYPE_5 ( VAR_3 ) , new TYPE_6 ( new TYPE_4 ( VAR_2 ) . VAR_8 , new TYPE_3 ( VAR_2 ) ) ) ; }
debug detected ll INFO branch
private void METHOD_1 ( Exception ex , TYPE_1 VAR_1 , TYPE_2 < ? > message ) { if ( this . logger . VAR_2 ( ) ) { this . logger . info ( STRING_1 + VAR_1 + STRING_2 + message + STRING_3 + ex . getMessage ( ) + STRING_4 ) ; } else if ( this . logger . VAR_3 ( ) ) { this . logger . debug ( STRING_1 + VAR_1 + STRING_2 + message + <START> STRING_5 , ex ) ; <END> } }
private void METHOD_1 ( Exception ex , TYPE_1 VAR_1 , TYPE_2 < ? > message ) { if ( this . logger . VAR_3 ( ) ) { this . logger . debug ( STRING_1 + VAR_1 + STRING_2 + message + STRING_5 , ex ) ; } else if ( this . logger . VAR_2 ( ) ) { this . logger . info ( STRING_1 + VAR_1 + STRING_2 + message + STRING_3 + ex . getMessage ( ) + STRING_4 ) ; } }
creating location attributes idgen module startup a core function idgen module other implications implementer wants _CODE_ responsibility ensuring correct _CODE_ _CODE_ exist
public void METHOD_1 ( ) { TYPE_1 . METHOD_2 ( true ) ; <START> METHOD_3 ( ) ; <END> log . info ( STRING_1 ) ; }
public void METHOD_1 ( ) { TYPE_1 . METHOD_2 ( true ) ; log . info ( STRING_1 ) ; }
pls diamond new ArrayList < > ( ) ;
private static List < TYPE_1 > METHOD_1 ( TYPE_2 [ ] VAR_1 ) { <START> List < TYPE_1 > VAR_2 = new ArrayList < TYPE_1 > ( ) ; <END> for ( TYPE_2 VAR_3 : VAR_1 ) { TYPE_3 args = new TYPE_3 ( new ArrayList < String > ( ) ) ; VAR_2 . add ( new TYPE_1 ( VAR_3 , args ) ) ; } return VAR_2 ; }
private static List < TYPE_1 > METHOD_1 ( TYPE_2 [ ] VAR_1 ) { List < TYPE_1 > VAR_2 = new ArrayList < > ( ) ; for ( TYPE_2 VAR_3 : VAR_1 ) { TYPE_3 args = new TYPE_3 ( new ArrayList < String > ( ) ) ; VAR_2 . add ( new TYPE_1 ( VAR_3 , args ) ) ; } return VAR_2 ; }
follow _CODE_ codestyle ( missing { } )
public String METHOD_1 ( String name ) throws IOException { String output = "" ; if ( METHOD_2 ( ) != null ) { try ( TYPE_1 is = METHOD_3 ( name ) ) { if ( is == null ) { output = TYPE_2 . METHOD_4 ( new File ( name ) , VAR_1 ) ; } <START> else output = TYPE_3 . toString ( is , VAR_1 ) ; <END> } } return output ; }
public String METHOD_1 ( String name ) throws IOException { if ( METHOD_2 ( ) != null ) { try ( TYPE_1 is = METHOD_3 ( name ) ) { if ( is != null ) { return TYPE_3 . toString ( is , VAR_1 ) ; } } } return TYPE_2 . METHOD_4 ( new File ( name ) , VAR_1 ) ; }
adding TYPE_3
public void METHOD_1 ( int VAR_1 , String startsWith ) { List < TYPE_1 > VAR_2 = VAR_3 . METHOD_2 ( new TYPE_2 ( ) . METHOD_3 ( TYPE_3 . METHOD_4 ( VAR_4 , VAR_5 ) , <START> new TYPE_4 ( new TYPE_5 ( VAR_6 ) , TYPE_7 . VAR_8 , TYPE_6 . METHOD_5 ( startsWith ) ) ) ) ; <END> assertEquals ( VAR_1 , VAR_2 . size ( ) ) ; }
public void METHOD_1 ( int VAR_1 , String startsWith ) { List < TYPE_1 > VAR_2 = VAR_3 . METHOD_2 ( new TYPE_2 ( ) . METHOD_3 ( TYPE_3 . METHOD_4 ( VAR_4 , VAR_5 ) , TYPE_3 . startsWith ( VAR_6 , startsWith ) ) ) ; assertEquals ( VAR_1 , VAR_2 . size ( ) ) ; }
inverse combine lines rid entire branch
public static boolean METHOD_1 ( TYPE_1 VAR_1 , List < TYPE_1 > VAR_2 ) { String VAR_3 = METHOD_2 ( VAR_1 ) ; <START> if ( null == VAR_3 ) { <END> return false ; } String VAR_4 = null ; for ( TYPE_1 VAR_5 : VAR_2 ) { VAR_4 = METHOD_2 ( VAR_5 ) ; if ( VAR_3 . equals ( VAR_4 ) ) { return true ; } } return false ; }
public static boolean METHOD_1 ( TYPE_1 VAR_1 , List < TYPE_1 > VAR_2 ) { String VAR_3 = METHOD_2 ( VAR_1 ) ; if ( null != VAR_3 ) { for ( TYPE_1 VAR_5 : VAR_2 ) { String VAR_4 = METHOD_2 ( VAR_5 ) ; if ( VAR_3 . equals ( VAR_4 ) ) { return true ; } } } return false ; }
convert a double leave exact long
public static TYPE_1 < TYPE_2 , Double > METHOD_1 ( ) { return new TYPE_1 < TYPE_2 , Double > ( ) { @Override ANNOTATION_1 public Double apply ( TYPE_2 input ) { if ( input . VAR_1 ( ) == null ) return null ; <START> return input . VAR_1 ( ) . METHOD_2 ( ) ; <END> } } ; }
public static TYPE_1 < TYPE_2 , Long > METHOD_1 ( ) { return new TYPE_1 < TYPE_2 , Long > ( ) { public Long apply ( TYPE_2 input ) { return input . VAR_1 ( ) ; } } ; }
isn t a result interrupt I throwing a RuntimeException IllegalStateException a fit
public void METHOD_1 ( TYPE_1 request ) throws InterruptedException { TYPE_2 stream = new TYPE_2 ( request . VAR_1 ( ) ) ; try { stream . VAR_2 ( ) ; } catch ( IOException e ) { <START> throw new InterruptedException ( STRING_1 + e ) ; <END> } VAR_3 . put ( request ) ; }
public void METHOD_1 ( TYPE_1 request ) throws InterruptedException { TYPE_2 stream = new TYPE_2 ( request . VAR_1 ( ) ) ; try { stream . VAR_2 ( ) ; } catch ( IOException e ) { throw new IllegalStateException ( STRING_1 + e ) ; } VAR_3 . put ( request ) ; }
need final static methods
<START> public static final TYPE_1 create ( ) { <END> return new TYPE_2 ( ) ; }
public static TYPE_1 create ( ) { return new TYPE_2 ( ) ; }
reverse order prevent races blindly METHOD_2 check exists
public void METHOD_1 ( ) { for ( Path file : VAR_1 ) { try { if ( VAR_2 . exists ( file ) && ! VAR_2 . METHOD_2 ( file , false ) ) { throw new IOException ( STRING_1 ) ; } } catch ( IOException e ) { log . warn ( e , STRING_2 + file ) ; } <START> } <END> VAR_3 . METHOD_1 ( ) ; }
public void METHOD_1 ( ) { for ( Path file : VAR_1 ) { try { VAR_2 . METHOD_2 ( file , false ) ; if ( VAR_2 . exists ( file ) ) { throw new IOException ( STRING_1 ) ; } } catch ( IOException e ) { log . warn ( e , STRING_2 + file ) ; } } VAR_3 . METHOD_1 ( ) ; }
shouldn t a simple System _CODE_ ( ) instead TYPE_1
private void METHOD_1 ( String content ) throws IOException { File VAR_1 = new File ( VAR_2 . METHOD_2 ( ) , STRING_1 ) ; write ( VAR_1 , content ) ; <START> final long VAR_3 = TYPE_1 . getInstance ( ) . METHOD_3 ( ) ; <END> final int VAR_4 = INT_1 * INT_2 ; VAR_1 . METHOD_4 ( VAR_3 - VAR_4 ) ; }
private void METHOD_1 ( String content ) throws IOException { File VAR_1 = new File ( VAR_2 . METHOD_2 ( ) , STRING_1 ) ; write ( VAR_1 , content ) ; final long VAR_3 = System . currentTimeMillis ( ) ; final int VAR_4 = INT_1 * INT_2 ; VAR_1 . METHOD_4 ( VAR_3 - VAR_4 ) ; }
replaced unmodifiable version List ( )
protected TYPE_1 METHOD_1 ( ) { <START> return new TYPE_2 ( STRING_1 , new ArrayList < > ( ) , false , true ) ; <END> }
protected TYPE_1 METHOD_1 ( ) { return new TYPE_2 ( STRING_1 , List . of ( ) , false , true ) ; }
doesn t VAR_3 merging
private void METHOD_1 ( String path , String source , String VAR_1 ) throws Exception { String VAR_2 = METHOD_2 ( path , source , VAR_1 ) ; VAR_3 . METHOD_3 ( new TYPE_1 ( VAR_2 ) , <START> TYPE_2 . METHOD_4 ( TYPE_3 . METHOD_5 ( ) ) ) ; <END> }
private void METHOD_1 ( String path , String source , String VAR_1 ) throws Exception { String VAR_2 = METHOD_2 ( path , source , VAR_1 ) ; VAR_3 . METHOD_3 ( new TYPE_1 ( VAR_2 ) ) ; }
replace test ( VAR_2 = = null ) execute statements else block return VAR_2 field VAR_1 local variable useful
public TYPE_1 METHOD_1 ( ) { TYPE_1 VAR_1 = null ; <START> if ( VAR_2 != null ) { <END> VAR_1 = VAR_2 ; } else { for ( TYPE_1 VAR_3 : this . METHOD_2 ( ) ) { if ( VAR_3 instanceof TYPE_2 ) { TYPE_2 VAR_4 = ( TYPE_2 ) VAR_3 ; if ( VAR_4 . METHOD_3 ( ) . METHOD_4 ( ) && ( this . METHOD_5 ( ) == VAR_4 . getValue ( ) ) ) { VAR_1 = VAR_4 ; break ; } } } } return VAR_1 ; }
public TYPE_1 METHOD_1 ( ) { if ( VAR_2 == null ) { for ( TYPE_1 VAR_3 : this . METHOD_2 ( ) ) { if ( VAR_3 instanceof TYPE_2 ) { TYPE_2 VAR_4 = ( TYPE_2 ) VAR_3 ; if ( VAR_4 . METHOD_3 ( ) . METHOD_4 ( ) && ( this . METHOD_5 ( ) == VAR_4 . getValue ( ) ) ) { VAR_2 = VAR_4 ; break ; } } } } return VAR_2 ; }
constructor delegate other constructor
<START> TYPE_1 ( TYPE_1 VAR_1 ) <END> { super ( VAR_1 ) ; this . id = VAR_1 . id ; this . VAR_2 = VAR_1 . VAR_2 ; this . name = VAR_1 . name ; }
protected TYPE_1 ( TYPE_1 VAR_1 ) { super ( VAR_1 ) ; this . id = VAR_1 . id ; this . VAR_2 = VAR_1 . VAR_2 ; this . name = VAR_1 . name ; }
return void instead TYPE_1 won t return null
<START> public TYPE_1 METHOD_1 ( ANNOTATION_1 ( TYPE_2 . VAR_2 ) Long id ) { <END> VAR_3 . METHOD_1 ( id ) ; return null ; }
public void METHOD_1 ( ANNOTATION_1 ( TYPE_2 . VAR_2 ) Long id ) { VAR_3 . METHOD_1 ( id ) ; }
version check removed move 2 6 x
protected TYPE_1 METHOD_1 ( ) { String version = TYPE_2 . METHOD_2 ( ) ; TYPE_3 VAR_1 = null ; <START> if ( version . startsWith ( STRING_1 ) && ( version . contains ( STRING_2 ) || version . contains ( STRING_3 ) ) ) { <END> VAR_1 = new TYPE_3 ( new String ( STRING_4 ) ) ; } else { VAR_1 = new TYPE_3 ( new String ( STRING_5 ) ) ; } METHOD_3 ( VAR_1 ) ; return VAR_1 ; }
protected TYPE_1 METHOD_1 ( ) { TYPE_3 VAR_1 = new TYPE_3 ( new String ( STRING_4 ) ) ; METHOD_3 ( VAR_1 ) ; return VAR_1 ; }
extract local variable variable null - check
private void METHOD_1 ( TYPE_1 event , boolean VAR_1 ) { if ( VAR_2 && METHOD_2 ( ) ) { return ; } if ( ( VAR_3 . equals ( TYPE_3 . VAR_5 ) || VAR_1 ) && VAR_6 != null ) { <START> ANNOTATION_1 TYPE_2 VAR_7 = VAR_6 ; <END> METHOD_3 ( VAR_7 , event ) ; if ( ! VAR_7 . METHOD_4 ( ) ) { METHOD_5 ( VAR_7 ) ; VAR_6 = null ; } } }
private void METHOD_1 ( TYPE_1 event , boolean VAR_1 ) { if ( VAR_2 && METHOD_2 ( ) ) { return ; } TYPE_2 VAR_7 = VAR_6 ; if ( ( VAR_3 . equals ( TYPE_3 . VAR_5 ) || VAR_1 ) && VAR_7 != null ) { METHOD_3 ( VAR_7 , event ) ; if ( ! VAR_7 . METHOD_4 ( ) ) { METHOD_5 ( VAR_7 ) ; VAR_6 = null ; } } }
oops
public boolean METHOD_1 ( ) { <START> throw new TYPE_1 ( STRING_1 ) ; <END> }
public boolean METHOD_1 ( ) { return true ; }
I check more sense METHOD_4 method move
private Guid METHOD_1 ( TYPE_1 action ) { if ( action . VAR_1 ( ) && <START> ( action . VAR_2 ( ) . METHOD_2 ( ) || action . VAR_2 ( ) . METHOD_3 ( ) ) ) { <END> return METHOD_4 ( action ) ; } return null ; }
private Guid METHOD_1 ( TYPE_1 action ) { if ( action . VAR_1 ( ) ) { return METHOD_4 ( action ) ; } return null ; }
trouble array initializers
public Object [ ] factory ( ) { <START> List VAR_1 = new ArrayList < > ( ) ; <END> VAR_1 . add ( new TYPE_1 ( ) . METHOD_1 ( false ) . METHOD_2 ( TYPE_2 . VAR_3 ) . METHOD_3 ( false ) ) ; VAR_1 . add ( new TYPE_1 ( ) . METHOD_1 ( true ) . METHOD_2 ( TYPE_2 . VAR_3 ) . METHOD_3 ( false ) ) ; return VAR_1 . METHOD_4 ( ) ; }
public Object [ ] factory ( ) { return new Object [ ] { new TYPE_1 ( ) . METHOD_1 ( false ) . METHOD_2 ( TYPE_2 . VAR_3 ) . METHOD_3 ( false ) , new TYPE_1 ( ) . METHOD_1 ( true ) . METHOD_2 ( TYPE_2 . VAR_3 ) . METHOD_3 ( false ) , } ; }
unnecessary assignment moved
private boolean METHOD_1 ( TYPE_1 VAR_1 ) { <START> Set < TYPE_2 > VAR_2 = null ; <END> boolean VAR_3 = false ; if ( VAR_1 != null ) { VAR_2 = VAR_1 . METHOD_2 ( ) ; for ( TYPE_2 VAR_4 : VAR_2 ) { if ( VAR_4 instanceof TYPE_3 ) { VAR_3 = true ; } } } return VAR_3 ; }
private boolean METHOD_1 ( TYPE_1 VAR_1 ) { Set < TYPE_2 > VAR_2 ; boolean VAR_3 = false ; if ( VAR_1 != null ) { VAR_2 = VAR_1 . METHOD_2 ( ) ; for ( TYPE_2 VAR_4 : VAR_2 ) { if ( VAR_4 instanceof TYPE_3 ) { VAR_3 = true ; } } } return VAR_3 ; }
return
TYPE_1 read ( long VAR_1 ) { if ( ! VAR_2 . getParameters ( ) . METHOD_1 ( ) ) { TYPE_1 data = VAR_3 . METHOD_2 ( VAR_1 ) ; if ( data == null ) { final TYPE_1 VAR_4 = METHOD_3 ( VAR_1 ) ; <START> data = VAR_3 . METHOD_4 ( ) . METHOD_5 ( VAR_1 , ( VAR_5 ) - > VAR_4 ) ; <END> } return data ; } return METHOD_3 ( VAR_1 ) ; }
TYPE_1 read ( long VAR_1 ) { if ( ! VAR_2 . getParameters ( ) . METHOD_1 ( ) ) { TYPE_1 data = VAR_3 . METHOD_2 ( VAR_1 ) ; if ( data == null ) { final TYPE_1 VAR_4 = METHOD_3 ( VAR_1 ) ; return VAR_3 . METHOD_4 ( ) . METHOD_5 ( VAR_1 , ( VAR_5 ) - > VAR_4 ) ; } return data ; } return METHOD_3 ( VAR_1 ) ; }
VAR_1 close ( ) ;
public void METHOD_1 ( ) { <START> METHOD_2 ( VAR_1 ) ; <END> VAR_1 = null ; }
public void METHOD_1 ( ) { VAR_1 . close ( ) ; }
method called validate method check shorter _CODE_ method
public TYPE_1 METHOD_1 ( ) { TYPE_2 VAR_1 = METHOD_2 ( ) ; <START> if ( VAR_1 != null && METHOD_3 ( VAR_1 ) ) { <END> return METHOD_4 ( ) ? TYPE_1 . VAR_2 : TYPE_1 . VAR_3 ; } else { return METHOD_4 ( ) ? TYPE_1 . VAR_4 : TYPE_1 . VAR_5 ; } }
public TYPE_1 METHOD_1 ( ) { TYPE_2 VAR_1 = METHOD_2 ( ) ; if ( VAR_1 != null ) { return METHOD_4 ( ) ? TYPE_1 . VAR_2 : TYPE_1 . VAR_3 ; } else { return METHOD_4 ( ) ? TYPE_1 . VAR_4 : TYPE_1 . VAR_5 ; } }
aren t test methods require METHOD_4
public TYPE_1 METHOD_1 ( ) { TYPE_1 VAR_1 = new TYPE_1 ( ) ; VAR_1 . METHOD_2 ( ) . METHOD_3 ( TYPE_2 . VAR_3 ) ; <START> VAR_1 . METHOD_4 ( ) . METHOD_5 ( ) ; <END> return VAR_1 ; }
public TYPE_1 METHOD_1 ( ) { TYPE_1 VAR_1 = new TYPE_1 ( ) ; VAR_1 . METHOD_2 ( ) . METHOD_3 ( TYPE_2 . VAR_3 ) ; return VAR_1 ; }
UTF8
public boolean METHOD_1 ( String key , int VAR_1 ) { <START> String VAR_2 = String . format ( TYPE_1 . VAR_4 , STRING_1 , key , VAR_1 ) ; <END> return METHOD_2 ( VAR_2 ) ; }
public boolean METHOD_1 ( String key , int VAR_1 ) { String VAR_2 = String . format ( STRING_1 , key , VAR_1 ) ; return METHOD_2 ( VAR_2 ) ; }
a static helper function _CODE_ ( VAR_1 ) ; VAR_1 instanceof TYPE_3
public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { <START> METHOD_2 ( VAR_1 . METHOD_3 ( ) . equals ( VAR_2 ) , STRING_1 ) ; <END> return VAR_3 . METHOD_1 ( ( TYPE_3 ) VAR_1 ) ; }
public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { return VAR_3 . METHOD_1 ( VAR_1 ) ; }
I don t escape level explicitly escape title a video passing a method s move _CODE_ ( String _CODE_ ) _CODE_
public void METHOD_1 ( String VAR_1 , String VAR_2 , String value ) { METHOD_2 ( INT_1 , TimeUnit . VAR_3 ) ; try { VAR_4 . METHOD_3 ( TYPE_1 . METHOD_4 ( <START> TYPE_2 . METHOD_5 ( VAR_1 ) , VAR_2 , METHOD_6 ( value ) ) ) ; <END> } finally { METHOD_7 ( ) ; } }
public void METHOD_1 ( String VAR_1 , String VAR_2 , String value ) { METHOD_2 ( INT_1 , TimeUnit . VAR_3 ) ; try { VAR_4 . METHOD_3 ( TYPE_1 . METHOD_4 ( TYPE_2 . METHOD_5 ( VAR_1 ) , VAR_2 , value ) ) ; } finally { METHOD_7 ( ) ; } }
А вообще надо два append ( ) делать
public String parse ( ) { StringBuilder VAR_1 = new StringBuilder ( "" ) ; for ( String VAR_2 : VAR_3 ) { <START> VAR_1 . append ( VAR_2 + STRING_1 ) ; <END> } return VAR_1 . toString ( ) ; }
public String parse ( ) { StringBuilder VAR_1 = new StringBuilder ( "" ) ; for ( String VAR_2 : VAR_3 ) { VAR_1 . append ( VAR_2 ) ; VAR_1 . append ( STRING_1 ) ; } return VAR_1 . toString ( ) ; }
a - - resource pattern
public void METHOD_1 ( ) throws IOException { TYPE_1 < ? > VAR_1 = new TYPE_1 < > ( new TYPE_2 < > ( ) ) ; VAR_1 . create ( TYPE_3 . create ( Type . VAR_2 ) , new TYPE_4 ( ) ) ; VAR_1 . METHOD_2 ( STRING_1 , STRING_2 ) ; <START> VAR_1 . close ( ) ; <END> }
public void METHOD_1 ( ) throws IOException { try ( TYPE_1 < ? > VAR_1 = new TYPE_1 < > ( new TYPE_2 < > ( ) ) ) { VAR_1 . create ( TYPE_3 . create ( Type . VAR_2 ) , new TYPE_4 ( ) ) ; VAR_1 . METHOD_2 ( STRING_1 , STRING_2 ) ; } }
fluent required ? a a basic setter instead
public TYPE_1 METHOD_1 ( String VAR_1 ) { this . VAR_1 = VAR_1 ; <START> return this ; <END> }
public void METHOD_1 ( String VAR_1 ) { this . VAR_1 = VAR_1 ; }
method a simple converter dependent frequency dependent VAR_3 offset return VAR_1 * VAR_3 _CODE_ ( ) VAR_1 VAR_3 null
<START> public long METHOD_1 ( long VAR_1 ) { <END> TYPE_1 trace = VAR_2 ; if ( trace != null ) { TYPE_2 VAR_3 = trace . VAR_4 ( ) ; return trace . VAR_5 ( VAR_1 - trace . VAR_6 ( ) ) + VAR_3 . METHOD_2 ( ) ; } return 0 ; }
public long METHOD_1 ( long VAR_1 ) { TYPE_1 trace = VAR_2 ; if ( trace != null ) { return trace . VAR_5 ( VAR_1 - trace . VAR_6 ( ) ) ; } return 0 ; }
dont exception propagated a error reporting generate jacoco report due methods static methods
private TYPE_1 METHOD_1 ( ) { TYPE_1 VAR_1 = null ; try { TYPE_2 VAR_2 = TYPE_2 . METHOD_2 ( ) ; TYPE_3 VAR_3 = VAR_2 . METHOD_3 ( ) ; VAR_1 = VAR_3 . METHOD_4 ( ) ; } catch ( TYPE_4 VAR_4 ) { <START> VAR_4 . METHOD_5 ( ) ; <END> } return VAR_1 ; }
private static TYPE_1 METHOD_1 ( ) throws TYPE_4 { TYPE_1 VAR_1 = null ; TYPE_2 VAR_2 = TYPE_2 . METHOD_2 ( ) ; TYPE_3 VAR_3 = VAR_2 . METHOD_3 ( ) ; VAR_1 = VAR_3 . METHOD_4 ( ) ; return VAR_1 ; }
_CODE_ job = VAR_2 remove ( buffer VAR_3 ( ) ) ; ( job ! = null ) { job VAR_4 ( ) ; }
public TYPE_7 ( ) { TYPE_5 . TYPE_6 . METHOD_1 ( new TYPE_2 ( ) { @Override public void METHOD_2 ( TYPE_3 buffer ) { <START> TYPE_4 job = VAR_2 . get ( buffer . VAR_3 ( ) ) ; <END> if ( job != null ) { job . VAR_4 ( ) ; } VAR_2 . remove ( buffer . VAR_3 ( ) ) ; } } ) ; }
public TYPE_7 ( ) { TYPE_5 . TYPE_6 . METHOD_1 ( new TYPE_2 ( ) { @Override public void METHOD_2 ( TYPE_3 buffer ) { TYPE_4 job = VAR_2 . remove ( buffer . VAR_3 ( ) ) ; if ( job != null ) { job . VAR_4 ( ) ; } } } ) ; }
protected
<START> public void METHOD_1 ( ) { <END> this . VAR_1 = new TYPE_1 ( node ) ; }
protected void METHOD_1 ( ) { this . VAR_1 = new TYPE_1 ( node ) ; }
simplify avoiding temporary : VAR_3 add ( new TYPE_3 ( ) ) ;
protected void METHOD_1 ( final TYPE_1 id , final int type , final byte [ ] data ) { try { super . METHOD_1 ( id , type , data ) ; } catch ( TYPE_2 e ) { <START> TYPE_3 o = new TYPE_3 ( id . VAR_1 ( ) , type , <END> e . VAR_2 ( ) ) ; VAR_3 . add ( o ) ; } }
protected void METHOD_1 ( final TYPE_1 id , final int type , final byte [ ] data ) { try { super . METHOD_1 ( id , type , data ) ; } catch ( TYPE_2 e ) { VAR_3 . add ( new TYPE_3 ( id . VAR_1 ( ) , type , e . VAR_2 ( ) ) ) ; } }
pick : more consistent constructor behavior I d prefer dothis ( false )
public TYPE_1 ( ) { <START> this . VAR_2 = false ; <END> }
public TYPE_1 ( ) { this ( false ) ; }
nl return
public String METHOD_1 ( ) { if ( VAR_1 == null ) { return "" ; } <START> String s = VAR_1 . getName ( ) . METHOD_2 ( STRING_1 , "" ) + STRING_2 + VAR_2 ; <END> return s ; }
public String METHOD_1 ( ) { if ( VAR_1 == null ) { return "" ; } return VAR_1 . getName ( ) . METHOD_2 ( STRING_1 , "" ) + STRING_2 + VAR_2 ; }
sole VAR_1 stormpath_token please assert parameter stormpath_token additionally public ( protected minimum ) invoked internally class created
public void METHOD_1 ( String VAR_1 ) { <START> METHOD_2 ( VAR_2 , VAR_1 ) ; <END> }
protected void METHOD_1 ( String VAR_1 ) { METHOD_2 ( VAR_2 , VAR_1 ) ; }
other ( example item ) instead VAR_2
private static < T > void METHOD_1 ( TYPE_1 < T > VAR_1 ) { <START> for ( T VAR_2 : VAR_1 ) { <END> System . out . println ( STRING_1 + VAR_2 ) ; } }
private static < T > void METHOD_1 ( TYPE_1 < T > VAR_1 ) { for ( T item : VAR_1 ) { System . out . println ( STRING_1 + item ) ; } }
simplified tojavareturn VAR_1 = = null ? 0 : VAR_1 METHOD_1 ( ) ;
public int METHOD_1 ( ) { if ( VAR_1 == null ) { return 0 ; } else { return VAR_1 . METHOD_1 ( ) ; <START> } <END> }
public int METHOD_1 ( ) { return VAR_1 . METHOD_1 ( ) ; }
return empty list ( ImmutableList ( ) ) null log = = null
public Response METHOD_1 ( ) throws Exception { TYPE_1 session = METHOD_2 ( ) . METHOD_3 ( METHOD_4 ( ) . METHOD_3 ( ) ) ; TYPE_2 VAR_1 = METHOD_4 ( ) . METHOD_5 ( ) ; String type = VAR_1 . getString ( STRING_1 ) ; TYPE_3 log = ( TYPE_3 ) session . VAR_2 ( ) . METHOD_6 ( type ) ; <START> List < TYPE_4 > VAR_3 = ( log == null ? null : log . VAR_4 ( ) ) ; <END> return METHOD_7 ( VAR_3 ) ; }
public Response METHOD_1 ( ) throws Exception { TYPE_1 session = METHOD_2 ( ) . METHOD_3 ( METHOD_4 ( ) . METHOD_3 ( ) ) ; TYPE_2 VAR_1 = METHOD_4 ( ) . METHOD_5 ( ) ; String type = VAR_1 . getString ( STRING_1 ) ; List < TYPE_4 > VAR_3 = session . VAR_2 ( ) . METHOD_6 ( type ) ; return METHOD_7 ( VAR_3 ) ; }
params null null null
public TYPE_1 METHOD_1 ( ) { <START> return METHOD_2 ( "" , new String [ ] { } , null ) ; <END> }
public TYPE_1 METHOD_1 ( ) { return METHOD_2 ( null , null , null ) ; }
I need / catch stuff ) )
public int getId ( ) { try { return id ; } catch ( RuntimeException e ) { throw METHOD_1 ( e ) ; } catch ( TYPE_1 e ) { throw METHOD_1 ( e ) ; } catch ( Throwable t ) { throw METHOD_1 ( t ) ; <START> } <END> }
public int getId ( ) { return id ; }
catched ? shouldn t caller react
public TYPE_3 ( HashMap < String , String > VAR_2 ) { this . VAR_2 = VAR_2 ; try { String VAR_3 = VAR_2 . get ( STRING_1 ) ; TYPE_1 url = new TYPE_1 ( VAR_3 ) ; String VAR_4 = url . VAR_5 ( ) ; VAR_6 = STRING_2 + VAR_4 ; <START> } catch ( TYPE_2 VAR_7 ) { <END> VAR_7 . METHOD_1 ( ) ; } }
public TYPE_3 ( HashMap < String , String > VAR_2 ) throws TYPE_2 { this . VAR_2 = VAR_2 ; String VAR_3 = VAR_2 . get ( STRING_1 ) ; TYPE_1 url = new TYPE_1 ( VAR_3 ) ; String VAR_4 = url . VAR_5 ( ) ; VAR_6 = STRING_2 + VAR_4 ; }
test adjusted removed strlen change
public void METHOD_1 ( ) { METHOD_2 ( STRING_1 , INT_1 ) ; METHOD_2 ( STRING_2 , TYPE_1 . METHOD_3 ( ) ) ; <START> METHOD_4 ( STRING_3 , TYPE_2 . class , null ) ; <END> }
public void METHOD_1 ( ) { METHOD_2 ( STRING_1 , INT_1 ) ; METHOD_2 ( STRING_2 , TYPE_1 . METHOD_3 ( ) ) ; }
METHOD_1 ( file )
public boolean METHOD_1 ( File file , boolean VAR_1 ) { if ( VAR_1 ) { return this . METHOD_2 ( file ) ; } <START> return file . VAR_2 ( ) ; <END> }
public boolean METHOD_1 ( File file , boolean VAR_1 ) { if ( VAR_1 ) { return this . METHOD_2 ( file ) ; } return this . METHOD_1 ( file ) ; }
program interface implementation please List instead ArrayList I m mentioning
public ArrayList < TYPE_1 > METHOD_1 ( int resource ) { <START> ArrayList < TYPE_1 > VAR_1 = new ArrayList < TYPE_1 > ( ) ; <END> for ( TYPE_1 VAR_2 : VAR_3 ) { if ( ( VAR_2 . METHOD_2 ( ) & resource ) > 0 ) { VAR_1 . add ( VAR_2 ) ; } } return VAR_1 ; }
public List < TYPE_1 > METHOD_1 ( int resource ) { List < TYPE_1 > VAR_1 = new ArrayList < TYPE_1 > ( ) ; for ( TYPE_1 VAR_2 : VAR_3 ) { if ( ( VAR_2 . METHOD_2 ( ) & resource ) != 0 ) { VAR_1 . add ( VAR_2 ) ; } } return VAR_1 ; }
line moved block TYPE_1 instance created ? code instance VAR_1 = VAR_1 rid VAR_2 method I assuming status need set server variable null true
public static TYPE_1 getInstance ( final TYPE_2 VAR_1 ) { if ( instance == null ) { instance = new TYPE_1 ( ) ; } <START> instance . VAR_2 ( VAR_1 ) ; <END> return instance ; }
public static TYPE_1 getInstance ( final TYPE_2 VAR_1 ) { if ( instance == null ) { instance = new TYPE_1 ( ) ; instance . VAR_1 = VAR_1 ; } return instance ; }
meiner meinung nach ist die überprüfung überflüssig VAR_1 darf null sein und es mag auch fälle geben wo ein request * ohne * VAR_1 gemacht werden soll die abfrage METHOD_1 ( null ) ist m E ein gültiger verwendung
public TYPE_1 METHOD_1 ( String VAR_1 ) { <START> if ( TYPE_2 . METHOD_2 ( VAR_1 ) ) <END> this . VAR_1 = VAR_1 ; return this ; }
public TYPE_1 METHOD_1 ( String VAR_1 ) { this . VAR_1 = VAR_1 ; return this ; }
final
<START> public void <END> METHOD_1 ( TYPE_1 VAR_1 ) { VAR_2 = VAR_1 ; }
public final void METHOD_1 ( TYPE_1 VAR_1 ) { VAR_2 = VAR_1 ; }
null check necessary clear called super class constructor
<START> public synchronized void clear ( ) { <END> VAR_1 . METHOD_1 ( INT_1 , INT_1 ) ; VAR_1 . METHOD_2 ( INT_1 , INT_1 ) ; VAR_1 . METHOD_3 ( ) ; super . clear ( ) ; }
public synchronized void clear ( ) { if ( VAR_1 != null ) { VAR_1 . METHOD_1 ( INT_1 , INT_1 ) ; VAR_1 . METHOD_2 ( INT_1 , INT_1 ) ; VAR_1 . METHOD_3 ( ) ; } super . clear ( ) ; }
s point
public List < Object > METHOD_1 ( ) { <START> Set < Object > VAR_1 = METHOD_2 ( new TYPE_1 < > ( VAR_2 ) ) ; <END> for ( List < Object > VAR_3 : VAR_4 ) { if ( VAR_3 != null ) { VAR_1 . addAll ( VAR_3 ) ; } } return new ArrayList < > ( VAR_1 ) ; }
public List < Object > METHOD_1 ( ) { List < Object > VAR_1 = new ArrayList < > ( VAR_2 ) ; for ( List < Object > VAR_3 : VAR_4 ) { if ( VAR_3 != null ) { VAR_1 . addAll ( VAR_3 ) ; } } return VAR_1 ; }
please ! string isEmpty ( )
public void METHOD_1 ( String VAR_1 ) { METHOD_2 ( ) ; VAR_2 = VAR_1 ; if ( VAR_3 != null && VAR_1 != null && <START> VAR_1 . length ( ) > 0 ) { <END> TYPE_1 VAR_4 = TYPE_2 . METHOD_3 ( VAR_3 , TYPE_3 . VAR_6 , TYPE_3 . OS ) ; VAR_4 . METHOD_4 ( VAR_1 ) ; } else { METHOD_5 ( TYPE_3 . VAR_6 , TYPE_3 . OS ) ; } }
public void METHOD_1 ( String VAR_1 ) { METHOD_2 ( ) ; VAR_2 = VAR_1 ; if ( VAR_3 != null && VAR_1 != null && ! VAR_1 . isEmpty ( ) ) { TYPE_1 VAR_4 = TYPE_2 . METHOD_3 ( VAR_3 , TYPE_3 . VAR_6 , TYPE_3 . OS ) ; VAR_4 . METHOD_4 ( VAR_1 ) ; } else { METHOD_5 ( TYPE_3 . VAR_6 , TYPE_3 . OS ) ; } }
stray doublenewline _CODE_ newlines individual _CODE_ m confused isn t formatted _CODE_ event I referencing ? javareturn new TYPE_2 ( damager ! = null && damager VAR_2 ( ) ? damager VAR_3 ( ) : entity VAR_2 ( ) ? entity VAR_3 ( ) : null damager ! = null && damager VAR_4 ( ) ? damager VAR_5 ( ) : entity VAR_4 ( ) ? entity VAR_5 ( ) : null ) ;
public TYPE_1 METHOD_1 ( ) { return new TYPE_2 ( VAR_1 . METHOD_2 ( ) ? VAR_1 . METHOD_3 ( ) : ( entity . VAR_2 ( ) ? entity . VAR_3 ( ) : null ) , <START> <END> VAR_1 . METHOD_4 ( ) ? VAR_1 . METHOD_5 ( ) : ( entity . VAR_4 ( ) ? entity . VAR_5 ( ) : null ) ) ; }
public TYPE_1 METHOD_1 ( ) { return new TYPE_2 ( VAR_1 . METHOD_2 ( ) ? VAR_1 . METHOD_3 ( ) : entity . VAR_2 ( ) ? entity . VAR_3 ( ) : null , VAR_1 . METHOD_4 ( ) ? VAR_1 . METHOD_5 ( ) : entity . VAR_4 ( ) ? entity . VAR_5 ( ) : null ) ; }
doesn t matter val - var - TYPE_3 pass false VAR_1 conceptually pass false
public TYPE_1 METHOD_1 ( Boolean VAR_1 , TYPE_2 VAR_2 ) { for ( TYPE_3 VAR_3 : VAR_2 . METHOD_2 ( ) ) { <START> VAR_3 . METHOD_3 ( this , VAR_1 ) ; <END> } return null ; }
public TYPE_1 METHOD_1 ( Boolean VAR_1 , TYPE_2 VAR_2 ) { for ( TYPE_3 VAR_3 : VAR_2 . METHOD_2 ( ) ) { VAR_3 . METHOD_3 ( this , false ) ; } return null ; }
s expected benefit change ? method typically called VM - - s prioritize simplicity - traffic methods
public TYPE_1 METHOD_1 ( List < TYPE_2 > VAR_1 ) { synchronized ( VAR_2 ) { this . VAR_1 . clear ( ) ; this . VAR_1 . addAll ( VAR_1 ) ; <START> } <END> return this ; }
public TYPE_1 METHOD_1 ( List < TYPE_2 > VAR_1 ) { this . VAR_1 = new ArrayList < > ( VAR_1 ) ; return this ; }
VAR_6 variable avoided
private static TYPE_1 METHOD_1 ( TYPE_1 VAR_1 , Collection < TYPE_2 > VAR_2 , List < TYPE_2 > VAR_3 ) { VAR_2 = METHOD_2 ( VAR_2 , VAR_1 ) ; List < TYPE_2 > VAR_4 = METHOD_3 ( VAR_1 ) ; Set < TYPE_2 > VAR_5 = METHOD_4 ( VAR_2 , VAR_4 , VAR_3 ) ; TYPE_1 VAR_6 = METHOD_5 ( VAR_1 , VAR_5 ) ; <START> return VAR_6 ; <END> }
private static TYPE_1 METHOD_1 ( TYPE_1 VAR_1 , Collection < TYPE_2 > VAR_2 , List < TYPE_2 > VAR_3 ) { VAR_2 = METHOD_2 ( VAR_2 , VAR_1 ) ; List < TYPE_2 > VAR_4 = METHOD_3 ( VAR_1 ) ; Set < TYPE_2 > VAR_5 = METHOD_4 ( VAR_2 , VAR_4 , VAR_3 ) ; return METHOD_5 ( VAR_1 , VAR_5 ) ; }