Datasets:
YabTad
/
CodeRev

Dataset card Data Studio Files
xet
 Community
ReviewComments
stringlengths
1
2.35k
OriginalCode
stringlengths
28
487
ReviewedCode
stringlengths
14
463
logic excluding VAR_3 correct done method call instead done VAR_1 list VAR_1 loaded
private void METHOD_1 ( List < String > VAR_1 , TYPE_1 VAR_2 ) { <START> final TYPE_2 VAR_3 = VAR_4 . METHOD_2 ( ) ; <END> for ( String key : VAR_1 ) { if ( key == null ) break ; if ( ! key . equals ( VAR_3 . toString ( ) ) ) { TYPE_3 entry = VAR_5 . get ( key ) ; if ( entry != null ) { METHOD_3 ( entry , VAR_2 ) ; } }...
private void METHOD_1 ( List < String > VAR_1 , TYPE_1 VAR_2 ) { for ( String key : VAR_1 ) { if ( key == null ) break ; TYPE_3 entry = VAR_5 . get ( key ) ; if ( entry != null ) { METHOD_3 ( entry , VAR_2 ) ; } } }
block METHOD_2 ( ) call
public boolean METHOD_1 ( List < String > VAR_1 ) { TYPE_1 . METHOD_2 ( ) ; if ( VAR_1 . isEmpty ( ) ) { return false ; <START> } <END> return METHOD_3 ( connection - > VAR_2 . METHOD_1 ( connection , VAR_1 ) , true ) ; }
public boolean METHOD_1 ( List < String > VAR_1 ) { if ( VAR_1 . isEmpty ( ) ) { return false ; } TYPE_1 . METHOD_2 ( ) ; return METHOD_3 ( connection - > VAR_2 . METHOD_1 ( connection , VAR_1 ) , true ) ; }
default case longs binaries other _CODE_ s
protected Object METHOD_1 ( Object value ) { switch ( type ) { case VAR_1 : case VAR_2 : case VAR_3 : case VAR_4 : case VAR_5 : case VAR_6 : case VAR_7 : return VAR_8 . METHOD_2 ( ) . create ( value ) ; case VAR_9 : <START> return ( ( TYPE_1 ) value ) . METHOD_3 ( ) ; <END> } return value ; }
protected Object METHOD_1 ( Object value ) { switch ( type ) { case VAR_1 : case VAR_2 : case VAR_3 : case VAR_4 : case VAR_5 : case VAR_6 : case VAR_7 : return VAR_8 . METHOD_2 ( ) . create ( value ) ; case VAR_9 : return ( ( TYPE_1 ) value ) . METHOD_3 ( ) ; default : return value ; } }
exception left bubble fail test ? METHOD_1 fails means repository shutdown properly
public void METHOD_1 ( ) throws Exception { try { METHOD_2 ( ) ; <START> } catch ( Exception e ) { <END> } finally { TYPE_1 . METHOD_3 ( STRING_1 ) ; } }
public void METHOD_1 ( ) throws Exception { try { METHOD_2 ( ) ; } finally { TYPE_1 . METHOD_3 ( STRING_1 ) ; } }
another option change TYPE_3 METHOD_8 check unordered unordered collections allow SNS logic repeated
private boolean METHOD_1 ( TYPE_1 cache ) { TYPE_2 VAR_1 = METHOD_2 ( cache ) . METHOD_3 ( ) ; if ( VAR_1 == null ) { return true ; } TYPE_3 VAR_2 = VAR_1 . METHOD_4 ( ) ; if ( VAR_2 == null ) { return true ; } TYPE_4 VAR_3 = METHOD_5 ( cache ) ; if ( VAR_2 . METHOD_6 ( VAR_3 ) ) { return false ; } Set < TYPE_4 > VAR_4...
private boolean METHOD_1 ( TYPE_1 cache ) { TYPE_4 VAR_3 = METHOD_5 ( cache ) ; Set < TYPE_4 > VAR_4 = METHOD_7 ( cache ) ; TYPE_2 VAR_1 = METHOD_2 ( cache ) . METHOD_3 ( ) ; if ( VAR_1 == null ) { return true ; } TYPE_3 VAR_2 = VAR_1 . METHOD_4 ( ) ; return VAR_2 == null || VAR_2 . METHOD_8 ( VAR_3 , VAR_4 ) ; }
strictly speaking else 230 completely unnecessary line 229 a return statement line 228 add a VAR_1 = null ; a new line
public boolean hasNext ( ) { if ( VAR_1 != null ) return true ; while ( super . hasNext ( ) ) { VAR_1 = super . next ( ) ; if ( VAR_1 . getName ( ) . equals ( name ) ) { return true ; } else { VAR_1 = null ; <START> } <END> } return false ; }
public boolean hasNext ( ) { if ( VAR_1 != null ) return true ; while ( super . hasNext ( ) ) { VAR_1 = super . next ( ) ; if ( VAR_1 . getName ( ) . equals ( name ) ) return true ; VAR_1 = null ; } return false ; }
need synchronized ? threads ( txn ) hit time ? isn t completion state entered number threads participating txn
<START> protected synchronized void METHOD_1 ( ) { <END> if ( VAR_1 != null ) { METHOD_2 ( VAR_1 ) ; VAR_1 = null ; } }
protected void METHOD_1 ( ) { if ( VAR_1 != null ) { METHOD_2 ( VAR_1 ) ; VAR_1 = null ; } }
lines : ( VAR_8 METHOD_4 ( VAR_7 ) ) VAR_9 add ( VAR_7 ) ; case t METHOD_4 VAR_7 ( reason )
public void METHOD_1 ( TYPE_1 listener , int VAR_1 , String VAR_2 , boolean VAR_3 , String [ ] VAR_4 , String [ ] VAR_5 , boolean VAR_6 ) throws TYPE_2 { TYPE_3 . METHOD_2 ( listener , STRING_1 ) ; METHOD_3 ( ) ; TYPE_4 VAR_7 = new TYPE_4 ( listener , VAR_1 , VAR_2 , VAR_3 , VAR_4 , VAR_5 , VAR_6 ) ; this . VAR_8 . MET...
public void METHOD_1 ( TYPE_1 listener , int VAR_1 , String VAR_2 , boolean VAR_3 , String [ ] VAR_4 , String [ ] VAR_5 , boolean VAR_6 ) throws TYPE_2 { TYPE_3 . METHOD_2 ( listener , STRING_1 ) ; METHOD_3 ( ) ; TYPE_4 VAR_7 = new TYPE_4 ( listener , VAR_1 , VAR_2 , VAR_3 , VAR_4 , VAR_5 , VAR_6 ) ; if ( this . VAR_8 ...
good VAR_1 METHOD_1 ( session ) call other cleanup ? IMO place
final void METHOD_1 ( ) throws TYPE_1 { VAR_1 . METHOD_1 ( session ) ; for ( String token : new ArrayList < String > ( VAR_2 . keySet ( ) ) ) { METHOD_2 ( token ) ; <START> } <END> }
final void METHOD_1 ( ) throws TYPE_1 { VAR_1 . METHOD_1 ( session ) ; for ( String token : VAR_2 . keySet ( ) ) { METHOD_2 ( token ) ; } }
I m picky returning block need else block ? ( context ! = null && context VAR_1 ( ) ! = null ) { / / want context - sensitive behavior VAR_1 ve precomputed SNS indexreturn super iterator ( context ) ; } return iterator ( ) ;
public Iterator < TYPE_1 > iterator ( TYPE_2 name , Context context ) { if ( context != null && context . VAR_1 ( ) != null ) { return super . iterator ( name , context ) ; } else { return iterator ( name ) ; <START> } <END> }
public Iterator < TYPE_1 > iterator ( TYPE_2 name , Context context ) { if ( context != null && context . VAR_1 ( ) != null ) { return super . iterator ( name , context ) ; } return iterator ( name ) ; }
benefit waking other consumers GC consumer closes ? I understand GC consumer null entries sleeping consumer shouldn t benefit waking
public void close ( ) { if ( this . VAR_1 . METHOD_1 ( true , false ) ) { try { <START> VAR_2 . METHOD_2 ( ) ; <END> this . VAR_3 . METHOD_3 ( ) ; } catch ( InterruptedException e ) { } } }
public void close ( ) { if ( this . VAR_1 . METHOD_1 ( true , false ) ) { try { this . VAR_3 . METHOD_3 ( ) ; } catch ( InterruptedException e ) { } } }
I m curious change VAR_3 thread safe METHOD_2 needed update VAR_6
private void METHOD_1 ( TYPE_1 VAR_1 ) { <START> VAR_2 . METHOD_2 ( ) ; <END> try { if ( VAR_3 != null ) { VAR_3 . METHOD_3 ( TYPE_3 . VAR_5 ) ; } if ( ! this . VAR_6 . containsKey ( VAR_1 . METHOD_4 ( ) ) ) { VAR_6 . put ( VAR_1 . METHOD_4 ( ) , new TYPE_2 ( VAR_7 . size ( ) ) ) ; } } finally { VAR_2 . METHOD_5 ( ) ; ...
private void METHOD_1 ( TYPE_1 VAR_1 ) { if ( VAR_3 != null ) { VAR_3 . METHOD_3 ( TYPE_3 . VAR_5 ) ; } VAR_2 . METHOD_2 ( ) ; try { if ( ! this . VAR_6 . containsKey ( VAR_1 . METHOD_4 ( ) ) ) { VAR_6 . put ( VAR_1 . METHOD_4 ( ) , new TYPE_2 ( VAR_7 . size ( ) ) ) ; } } finally { VAR_2 . METHOD_5 ( ) ; } }
need change ( VAR_2 ! = null ) VAR_2 METHOD_2 ( true ) ; VAR_1 true creating a VAR_2 failed watch service supported current OS line 282 result NPE
public void METHOD_1 ( ) { if ( VAR_1 ) { VAR_2 . METHOD_2 ( true ) ; <START> } <END> }
public void METHOD_1 ( ) { if ( VAR_1 && VAR_2 != null ) { try { VAR_2 . METHOD_2 ( true ) ; } finally { VAR_2 = null ; } } }
strange equals _CODE_ check _both_ VAR_1 ( process - specific ) content s UUID ( universal _CODE_ ) comparing TYPE_1 instances separate machines duplicates ? ( ? )
public boolean equals ( Object o ) { if ( this == o ) { return true ; } if ( o == null || getClass ( ) != o . getClass ( ) ) { return false ; } TYPE_1 record = ( TYPE_1 ) o ; if ( VAR_1 != record . VAR_1 ) { return false ; } <START> if ( content != null ? ! content . VAR_2 ( ) . equals ( record . content . METHOD_1 ( )...
public boolean equals ( Object o ) { if ( this == o ) { return true ; } if ( o == null || getClass ( ) != o . getClass ( ) ) { return false ; } TYPE_1 record = ( TYPE_1 ) o ; return content . VAR_2 ( ) . equals ( record . content . METHOD_1 ( ) ) ; }
happen ? won t METHOD_2 ( cache ) throw a _CODE_ a reference
protected TYPE_1 METHOD_1 ( TYPE_2 cache ) { TYPE_3 VAR_1 = METHOD_2 ( cache ) ; <START> if ( VAR_1 == null ) { <END> VAR_1 = METHOD_2 ( cache ) ; } return VAR_1 . METHOD_1 ( ) ; }
protected TYPE_1 METHOD_1 ( TYPE_2 cache ) { return METHOD_2 ( cache ) . METHOD_1 ( ) ; }
null ? add assertion
private TYPE_1 ( String name ) { <START> this . name = name ; <END> }
private TYPE_1 ( String name ) { assert ( name != null ) ; this . name = name ; }
return path VAR_2 ( )
public int METHOD_1 ( ) { int VAR_1 = 5 ; VAR_1 = INT_1 * VAR_1 + ( this . path != null ? this . path . VAR_2 ( ) : 0 ) ; <START> return VAR_1 ; <END> }
public int METHOD_1 ( ) { return this . path . VAR_2 ( ) ; }
woa I m I public
<START> public final void METHOD_1 ( String key , <END> String value ) { this . context = context . VAR_1 ( key , value ) ; this . cache . VAR_2 ( key , value ) ; }
final void METHOD_1 ( String key , String value ) { this . context = context . VAR_1 ( key , value ) ; this . cache . VAR_2 ( key , value ) ; }
need public
<START> public final TYPE_1 context ( ) { <END> return context ; }
final TYPE_1 context ( ) { return context ; }
protected public changes change access modifiers modified methods limited
<START> public TYPE_1 METHOD_1 ( String VAR_1 , <END> String VAR_2 ) throws TYPE_2 , TYPE_3 , TYPE_4 , TYPE_5 , TYPE_6 , TYPE_7 , TYPE_8 { METHOD_2 ( ) ; return METHOD_3 ( VAR_1 , VAR_2 , null , true ) ; }
protected TYPE_1 METHOD_1 ( String VAR_1 , String VAR_2 ) throws TYPE_2 , TYPE_3 , TYPE_4 , TYPE_5 , TYPE_6 , TYPE_7 , TYPE_8 { METHOD_2 ( ) ; return METHOD_3 ( VAR_1 , VAR_2 , null , true ) ; }
public I d suggest protected remove - helpful _CODE_
<START> public TYPE_4 ( TYPE_1 session ) { <END> this . session = session ; this . VAR_2 = new TYPE_2 ( session ) ; this . VAR_3 = TYPE_3 . METHOD_1 ( this ) ; }
protected TYPE_4 ( TYPE_1 session ) { this . session = session ; this . VAR_2 = new TYPE_2 ( session ) ; this . VAR_3 = TYPE_3 . METHOD_1 ( this ) ; }
I d recommend initializing VAR_3 Collections _CODE_ ( TYPE_1 METHOD_1 ( VAR_2 ) ) resulting list immutable efficient implementation
protected TYPE_2 ( String VAR_2 ) { this . VAR_2 = VAR_2 ; <START> VAR_3 . add ( TYPE_1 . METHOD_1 ( VAR_2 ) ) ; <END> }
protected TYPE_2 ( String VAR_2 ) { this . VAR_2 = VAR_2 ; }
explain check ? a read - session able effective VAR_2
public TYPE_1 [ ] METHOD_1 ( String path ) throws TYPE_2 , TYPE_3 , TYPE_4 { if ( session . VAR_1 ( ) ) { throw new TYPE_3 ( STRING_1 ) ; <START> } <END> TYPE_1 [ ] VAR_2 = METHOD_2 ( path ) ; if ( VAR_2 . length == 0 ) { return new TYPE_1 [ ] { ( TYPE_1 ) this . METHOD_3 ( path ) . next ( ) } ; } return VAR_2 ; }
public TYPE_1 [ ] METHOD_1 ( String path ) throws TYPE_2 , TYPE_3 , TYPE_4 { TYPE_1 [ ] VAR_2 = METHOD_2 ( path ) ; if ( VAR_2 . length == 0 ) { return new TYPE_1 [ ] { ( TYPE_1 ) this . METHOD_3 ( path ) . next ( ) } ; } return VAR_2 ; }
VAR_1 field removed change method toreturn cache VAR_1 ( ) ;
public final boolean METHOD_1 ( ) { <START> return this . VAR_1 ; <END> }
public final boolean METHOD_1 ( ) { return cache ( ) . METHOD_1 ( ) ; }
need synchronized block
private void METHOD_1 ( TYPE_1 VAR_1 ) { synchronized ( VAR_2 ) { VAR_2 . add ( VAR_1 ) ; <START> } <END> }
private void METHOD_1 ( TYPE_1 VAR_1 ) { VAR_2 . add ( VAR_1 ) ; }
code correct implemented a more succinct manner a bit easier read : public boolean equals ( Object VAR_1 ) { ( VAR_1 = = ) return true ; ( VAR_1 instanceof TYPE_1 ) return = = VAR_1 ; return false ; }
public boolean equals ( Object VAR_1 ) { if ( VAR_1 == null ) { return false ; } if ( VAR_1 == this ) { return true ; } if ( ! ( VAR_1 instanceof TYPE_1 ) ) { return false ; } <START> return this == ( TYPE_1 ) VAR_1 ; <END> }
public boolean equals ( Object VAR_1 ) { if ( VAR_1 == this ) { return true ; } if ( VAR_1 instanceof TYPE_1 ) { return this == VAR_1 ; } return false ; }
oops please remove System println call
public TYPE_5 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 , TYPE_3 VAR_4 ) throws TYPE_4 { <START> System . out . println ( STRING_1 + VAR_2 ) ; <END> this . VAR_3 = VAR_3 ; this . VAR_4 = VAR_4 ; try { this . VAR_5 = VAR_2 . METHOD_1 ( ) ; } catch ( Exception e ) { throw new TYPE_4 ( e ) ; } }
public TYPE_5 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 , TYPE_3 VAR_4 ) throws TYPE_4 { this . VAR_3 = VAR_3 ; this . VAR_4 = VAR_4 ; try { this . VAR_5 = VAR_2 . METHOD_1 ( ) ; } catch ( Exception e ) { throw new TYPE_4 ( e ) ; } }
a bitwise shouldn t a boolean ( || )
private boolean METHOD_1 ( String uri ) { <START> return ! ( uri . startsWith ( STRING_1 ) | uri . startsWith ( STRING_2 ) ) ; <END> }
private boolean METHOD_1 ( String uri ) { return ! ( uri . startsWith ( STRING_1 ) || uri . startsWith ( STRING_2 ) ) ; }
set VAR_1 null a finally block ? I m checks null ( line 177 )
public void METHOD_1 ( ) { if ( VAR_1 != null ) { <START> VAR_1 . METHOD_2 ( ) ; <END> } }
public synchronized void METHOD_1 ( ) { if ( VAR_1 != null ) { VAR_1 . METHOD_2 ( ) ; VAR_1 = null ; } }
method synchronized multiple concurrent calls stomp other
<START> protected TYPE_1 METHOD_1 ( ) throws TYPE_2 { <END> if ( this . VAR_1 == null ) { this . VAR_1 = METHOD_2 ( VAR_2 ) ; } return this . VAR_1 ; }
protected synchronized TYPE_1 METHOD_1 ( ) throws TYPE_2 { if ( this . VAR_1 == null ) { this . VAR_1 = METHOD_2 ( VAR_2 ) ; } return this . VAR_1 ; }
I don t method public provides a backdoor state management operations _CODE_ I understand changing visibility required move _CODE_ implementations org modeshape jcr factories package I a cleaner API more important separate package
<START> public void start ( ) throws Exception { <END> METHOD_1 ( ) ; }
void start ( ) throws Exception { METHOD_1 ( ) ; }
issue change visibility method _CODE_ start ( )
<START> public Set < String > METHOD_1 ( ) { <END> METHOD_2 ( ) ; final TYPE_1 VAR_1 = this . VAR_1 . METHOD_3 ( ) ; try { VAR_1 . METHOD_4 ( ) ; return new HashSet < String > ( VAR_2 . keySet ( ) ) ; } finally { VAR_1 . METHOD_5 ( ) ; } }
protected Set < String > METHOD_1 ( ) { METHOD_2 ( ) ; final TYPE_1 VAR_1 = this . VAR_1 . METHOD_3 ( ) ; try { VAR_1 . METHOD_4 ( ) ; return new HashSet < String > ( VAR_2 . keySet ( ) ) ; } finally { VAR_1 . METHOD_5 ( ) ; } }
VAR_2 param doesn t ctr ( source cache container )
public TYPE_3 ( TYPE_1 source , <START> TYPE_2 VAR_2 ) { <END> super ( source ) ; this . VAR_2 = source . VAR_3 ( ) ; assert this . VAR_2 != null ; Set < String > VAR_4 = new HashSet < String > ( ) ; for ( String VAR_5 : source . VAR_6 ( ) ) { VAR_4 . add ( VAR_5 ) ; } this . VAR_7 = Collections . VAR_8 ( VAR_4 ) ; MET...
public TYPE_3 ( TYPE_1 source , TYPE_2 VAR_2 ) { super ( source ) ; this . VAR_2 = VAR_2 ; assert this . VAR_2 != null ; Set < String > VAR_4 = new HashSet < String > ( ) ; for ( String VAR_5 : source . VAR_6 ( ) ) { VAR_4 . add ( VAR_5 ) ; } this . VAR_7 = Collections . VAR_8 ( VAR_4 ) ; METHOD_1 ( ) ; }
wrong AFAIR projectnaming strategy set core plugins shouldn t manual assignment
public TYPE_2 ( boolean VAR_2 ) { this . VAR_2 = VAR_2 ; <START> TYPE_1 . getInstance ( ) . METHOD_1 ( this ) ; <END> }
public TYPE_2 ( boolean VAR_2 ) { this . VAR_2 = VAR_2 ; }
slow logging
private boolean METHOD_1 ( String VAR_1 , TYPE_1 VAR_2 , TYPE_2 VAR_3 ) { <START> LOGGER . debug ( STRING_1 + VAR_1 + STRING_2 + VAR_3 . METHOD_2 ( TYPE_2 . VAR_4 ) ) ; <END> return METHOD_3 ( VAR_1 , VAR_2 , VAR_3 . METHOD_2 ( TYPE_2 . VAR_4 ) ) ; }
private boolean METHOD_1 ( String VAR_1 , TYPE_1 VAR_2 , TYPE_2 VAR_3 ) { return METHOD_3 ( VAR_1 , VAR_2 , VAR_3 . METHOD_2 ( TYPE_2 . VAR_4 ) ) ; }
new situation line duplicated
static Object [ ] [ ] METHOD_1 ( ) { return new Object [ ] [ ] { new Object [ ] { STRING_1 , STRING_2 , STRING_3 } , <START> new Object [ ] { STRING_1 , STRING_2 , STRING_3 } , <END> new Object [ ] { STRING_4 , STRING_5 , STRING_6 } } ; }
static Object [ ] [ ] METHOD_1 ( ) { return new Object [ ] [ ] { new Object [ ] { STRING_1 , STRING_2 , STRING_3 } , new Object [ ] { STRING_4 , STRING_5 , STRING_6 } } ; }
TYPE_1 VAR_2 ( ) return a boolean instead Boolean _CODE_ states active required
public String METHOD_1 ( TYPE_1 user ) { <START> if ( ! Boolean . VAR_1 . equals ( user . VAR_2 ( ) ) ) { <END> throw new TYPE_2 ( ) ; } METHOD_2 ( user ) ; return METHOD_3 ( user ) ; }
public String METHOD_1 ( TYPE_1 user ) { if ( ! user . VAR_2 ( ) ) { throw new TYPE_2 ( ) ; } METHOD_2 ( user ) ; return METHOD_3 ( user ) ; }
test data shows encoding issues possibly build ( true ) helps ( side effects )
private TYPE_1 METHOD_1 ( ) { <START> return TYPE_2 . METHOD_2 ( ) . build ( ) . METHOD_3 ( ) ; <END> }
private TYPE_1 METHOD_1 ( ) { return METHOD_1 ( null ) ; }
sonar reports error line : - remove useless assignment local variable VAR_2
public static void METHOD_1 ( TYPE_1 VAR_1 , int VAR_2 ) { TYPE_2 VAR_3 = VAR_1 . METHOD_2 ( ) ; if ( VAR_3 != null && VAR_3 . METHOD_3 ( ) ) { VAR_3 . METHOD_4 ( VAR_2 ) ; VAR_2 ++ ; } TYPE_2 VAR_4 = VAR_1 . METHOD_5 ( ) ; if ( VAR_4 != null && VAR_3 != null && ! VAR_3 . getName ( ) . equals ( VAR_4 . getName ( ) ) ) ...
public static void METHOD_1 ( TYPE_1 VAR_1 , int VAR_2 ) { TYPE_2 VAR_3 = VAR_1 . METHOD_2 ( ) ; if ( VAR_3 != null && VAR_3 . METHOD_3 ( ) ) { VAR_3 . METHOD_4 ( VAR_2 ) ; VAR_2 ++ ; } TYPE_2 VAR_4 = VAR_1 . METHOD_5 ( ) ; if ( VAR_4 != null && VAR_3 != null && ! VAR_3 . getName ( ) . equals ( VAR_4 . getName ( ) ) ) ...
_CODE_ tells private 🤔
<START> protected void METHOD_1 ( <END> TYPE_1 < TYPE_2 > repo , TYPE_3 VAR_1 ) { if ( repo == null ) return ; int VAR_2 = 1 ; for ( TYPE_2 VAR_3 : METHOD_2 ( repo ) ) { VAR_2 ++ ; METHOD_3 ( VAR_1 , VAR_2 , VAR_3 ) ; } }
private void METHOD_1 ( TYPE_1 < TYPE_2 > repo , TYPE_3 VAR_1 ) { if ( repo == null ) return ; int VAR_2 = 1 ; for ( TYPE_2 VAR_3 : METHOD_2 ( repo ) ) { VAR_2 ++ ; METHOD_3 ( VAR_1 , VAR_2 , VAR_3 ) ; } }
new ArrayList < > ( ) ;
public static TYPE_1 create ( ANNOTATION_1 TYPE_2 VAR_1 , TYPE_3 VAR_2 ) { return new TYPE_4 ( VAR_1 , VAR_2 , METHOD_1 ( ) , <START> METHOD_2 ( ) , <END> METHOD_2 ( ) , METHOD_2 ( ) , METHOD_2 ( ) , METHOD_2 ( ) ) ; }
public static TYPE_1 create ( ANNOTATION_1 TYPE_2 VAR_1 , TYPE_3 VAR_2 ) { return new TYPE_1 ( VAR_1 , VAR_2 ) ; }
autovalue generates immutable classes ImmutableList _CODE_ prevent manipulation lists / maps getters I suspect mutating class need a normal POJO instead a immutable class
public static TYPE_1 create ( ANNOTATION_1 TYPE_2 VAR_1 , TYPE_3 VAR_2 ) { return new TYPE_4 ( VAR_1 , VAR_2 , <START> new ArrayList < > ( ) , <END> new HashMap < > ( ) , new HashMap < > ( ) , new HashMap < > ( ) , new HashMap < > ( ) , new HashMap < > ( ) ) ; }
public static TYPE_1 create ( ANNOTATION_1 TYPE_2 VAR_1 , TYPE_3 VAR_2 ) { return new TYPE_1 ( VAR_1 , VAR_2 ) ; }
throw redundancy warnings _CODE_
private List < String > METHOD_1 ( ) { List < String > VAR_1 = new ArrayList < > ( ) ; <START> return VAR_1 ; <END> }
private List < String > METHOD_1 ( ) { return new ArrayList < > ( ) ; }
_CODE_ ( VAR_3 METHOD_5 ( STRING_1 ) ) ;
public void METHOD_1 ( ) { TYPE_1 VAR_1 = METHOD_2 ( TYPE_1 . class ) ; when ( VAR_2 . METHOD_3 ( STRING_1 ) ) . METHOD_4 ( VAR_1 ) ; <START> assertEquals ( true , VAR_3 . METHOD_5 ( STRING_1 ) ) ; <END> }
public void METHOD_1 ( ) { TYPE_1 VAR_1 = METHOD_2 ( TYPE_1 . class ) ; when ( VAR_2 . METHOD_3 ( STRING_1 ) ) . METHOD_4 ( VAR_1 ) ; assertTrue ( VAR_3 . METHOD_5 ( STRING_1 ) ) ; }
java 8 String VAR_2 instead a party library
private static String METHOD_1 ( TYPE_1 VAR_1 ) { <START> return VAR_1 . METHOD_1 ( ) != null ? StringUtils . VAR_2 ( VAR_1 . METHOD_1 ( ) , STRING_1 ) : "" ; <END> }
private static String METHOD_1 ( TYPE_1 VAR_1 ) { return VAR_1 . METHOD_1 ( ) != null ? String . VAR_2 ( STRING_1 , VAR_1 . METHOD_1 ( ) ) : "" ; }
I : - a separate PR _CODE_ issue - needs a unit test
public void METHOD_1 ( Exception ex ) { TYPE_1 . error ( STRING_1 + ex . getMessage ( ) , ex ) ; VAR_1 . METHOD_2 ( TYPE_2 . METHOD_3 ( ) ) ; VAR_1 . METHOD_4 ( VAR_2 ) ; <START> VAR_1 . METHOD_5 ( ex . VAR_3 ( ) ) ; <END> METHOD_6 ( VAR_1 . METHOD_7 ( ) , VAR_1 . getType ( ) + STRING_2 , VAR_1 . METHOD_8 ( ) ) ; updat...
public void METHOD_1 ( Exception ex ) { TYPE_1 . error ( STRING_1 + ex . getMessage ( ) , ex ) ; VAR_1 . METHOD_2 ( TYPE_2 . METHOD_3 ( ) ) ; VAR_1 . METHOD_4 ( VAR_2 ) ; VAR_1 . METHOD_5 ( ex . getMessage ( ) ) ; METHOD_6 ( VAR_1 . METHOD_7 ( ) , VAR_1 . getType ( ) + STRING_2 , VAR_1 . METHOD_8 ( ) ) ; update ( ) ; T...
! [ MAJOR ] ( severity : MAJOR ) define throw a dedicated exception instead a generic [ ! [ rule ] ( ) ] ( )
public static Path METHOD_1 ( ) { if ( VAR_1 == null ) { <START> throw new RuntimeException ( STRING_1 ) ; <END> } return VAR_1 ; }
public static Path METHOD_1 ( ) { if ( VAR_1 == null ) { throw new IllegalStateException ( STRING_1 ) ; } return VAR_1 ; }
add curly braces
public String METHOD_1 ( TYPE_1 model ) { model . VAR_1 ( STRING_1 , this . VAR_2 . METHOD_2 ( ) ) ; <START> if ( ! model . VAR_3 ( VAR_4 ) ) model . VAR_1 ( VAR_4 , STRING_1 ) ; <END> return STRING_2 ; }
public String METHOD_1 ( TYPE_1 model ) { model . VAR_1 ( STRING_1 , this . VAR_2 . METHOD_2 ( ) ) ; if ( ! model . VAR_3 ( VAR_4 ) ) { model . VAR_1 ( VAR_4 , STRING_1 ) ; } return STRING_2 ; }
occurs CGD resource expected attributes wrong case
protected Object METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) { if ( VAR_1 . getName ( ) . equals ( TYPE_3 . METHOD_2 ( ) ) ) { return METHOD_3 ( VAR_2 ) ; } String VAR_3 = TYPE_4 . METHOD_4 ( VAR_1 . getName ( ) ) ; if ( VAR_3 == null ) <START> throw new IllegalArgumentException ( String . format ( STRING_1 , VAR_1 . getN...
protected Object METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) { if ( VAR_1 . getName ( ) . equals ( TYPE_3 . METHOD_2 ( ) ) ) { return METHOD_3 ( VAR_2 ) ; } String VAR_3 = TYPE_4 . METHOD_4 ( VAR_1 . getName ( ) ) ; if ( VAR_3 == null ) { throw new IllegalArgumentException ( String . format ( STRING_1 , VAR_1 . getName ( ...
happen ANNOTATION_2 required default remove check
public void create ( ANNOTATION_1 ( STRING_1 ) String VAR_1 , ANNOTATION_2 Map < String , Object > VAR_2 , TYPE_1 response ) { if ( VAR_2 == null ) { <START> throw new TYPE_2 ( STRING_2 , STRING_3 ) ; <END> } METHOD_1 ( VAR_1 , VAR_2 , response ) ; }
public void create ( ANNOTATION_1 ( STRING_1 ) String VAR_1 , ANNOTATION_2 Map < String , Object > VAR_2 , TYPE_1 response ) { METHOD_1 ( VAR_1 , VAR_2 , response ) ; }
fix imports
private static TYPE_1 METHOD_1 ( TYPE_2 VAR_1 , String VAR_2 ) { try { return METHOD_2 ( VAR_2 ) ; } <START> catch ( TYPE_3 . time . format . TYPE_4 e ) <END> { throw new TYPE_5 ( VAR_1 , VAR_2 ) ; } }
private static TYPE_1 METHOD_1 ( TYPE_2 VAR_1 , String VAR_2 ) { try { return METHOD_2 ( VAR_2 ) ; } catch ( TYPE_4 e ) { throw new TYPE_5 ( VAR_1 , VAR_2 ) ; } }
null VAR_1 evaluates true errored exception evaluates false I I d throw
private boolean METHOD_1 ( String VAR_1 , TYPE_1 entity ) { if ( VAR_1 == null ) { return true ; } else { Object value ; try { value = VAR_2 . METHOD_2 ( VAR_1 , entity ) ; } catch ( TYPE_2 VAR_3 ) { <START> return false ; <END> } return value != null ? Boolean . valueOf ( value . toString ( ) ) : false ; } }
private boolean METHOD_1 ( String VAR_1 , TYPE_1 entity ) { if ( VAR_1 == null ) { return true ; } else { Object value = VAR_2 . METHOD_2 ( VAR_1 , entity ) ; return value != null ? Boolean . valueOf ( value . toString ( ) ) : false ; } }
WARN FAIR INFO other unknown entities
public TYPE_1 METHOD_1 ( TYPE_2 e ) { <START> LOG . warn ( e . getMessage ( ) , e ) ; <END> return new TYPE_3 ( ) ; }
public TYPE_1 METHOD_1 ( TYPE_2 e ) { LOG . info ( e . getMessage ( ) , e ) ; return new TYPE_3 ( ) ; }
s a deep stub I need
public TYPE_1 METHOD_1 ( ) { <START> return METHOD_2 ( TYPE_1 . class , VAR_1 ) ; <END> }
public TYPE_1 METHOD_1 ( ) { return METHOD_2 ( TYPE_1 . class ) ; }
overriding quiet hard method private ; - )
<START> private void METHOD_1 ( Map < String , Object > VAR_1 ) <END> { }
protected void METHOD_1 ( Map < String , Object > VAR_1 ) { }
simplified tojavareturn VAR_1 = = null || TYPE_2 ( VAR_2 VAR_1 ) ;
private boolean METHOD_1 ( String VAR_1 , TYPE_1 < String > VAR_2 ) { <START> if ( VAR_1 == null || TYPE_2 . contains ( VAR_2 , VAR_1 ) ) <END> { return true ; } return false ; }
private boolean METHOD_1 ( String VAR_1 , TYPE_1 < String > VAR_2 ) { return ( VAR_1 == null || TYPE_2 . contains ( VAR_2 , VAR_1 ) ) ; }
METHOD_1
public TYPE_6 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 , TYPE_3 VAR_4 , TYPE_4 VAR_5 , TYPE_5 VAR_6 ) { this . VAR_2 = METHOD_1 ( VAR_2 ) ; this . VAR_3 = METHOD_1 ( VAR_3 ) ; this . VAR_4 = METHOD_1 ( VAR_4 ) ; <START> this . VAR_5 = VAR_5 ; <END> this . VAR_6 = VAR_6 ; }
public TYPE_6 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 , TYPE_3 VAR_4 , TYPE_4 VAR_5 , TYPE_5 VAR_6 ) { this . VAR_2 = METHOD_1 ( VAR_2 ) ; this . VAR_3 = METHOD_1 ( VAR_3 ) ; this . VAR_4 = METHOD_1 ( VAR_4 ) ; this . VAR_5 = METHOD_1 ( VAR_5 ) ; this . VAR_6 = METHOD_1 ( VAR_6 ) ; }
rid METHOD_1 ? move METHOD_2 factory class
<START> public void METHOD_1 ( ) <END> { super . METHOD_1 ( ) ; METHOD_2 ( VAR_1 ) ; }
private void METHOD_1 ( ) { METHOD_2 ( VAR_1 ) ; }
shouldnt VAR_4 = = null
public double METHOD_1 ( String row , String column ) { if ( ! VAR_1 ) METHOD_2 ( ) ; Integer VAR_2 = VAR_3 . get ( row ) ; Integer VAR_4 = VAR_5 . get ( column ) ; if ( VAR_2 == null ) throw new TYPE_1 ( STRING_1 + row + STRING_2 ) ; <START> if ( VAR_2 == null ) throw new TYPE_1 ( STRING_3 + column + STRING_2 ) ; <END...
public double METHOD_1 ( String row , String column ) { if ( ! VAR_1 ) METHOD_2 ( ) ; Integer VAR_2 = VAR_3 . get ( row ) ; Integer VAR_4 = VAR_5 . get ( column ) ; if ( VAR_2 == null ) throw new TYPE_1 ( STRING_1 + row + STRING_2 ) ; if ( VAR_4 == null ) throw new TYPE_1 ( STRING_3 + column + STRING_2 ) ; return METHO...
variable
private TYPE_1 METHOD_1 ( String VAR_1 ) { <START> TYPE_1 VAR_2 = null ; <END> TYPE_2 entity = VAR_3 . METHOD_2 ( TYPE_4 . VAR_5 + STRING_1 + TYPE_4 . VAR_6 , VAR_1 ) ; if ( entity != null ) { return METHOD_3 ( VAR_1 , entity ) ; } else { throw new TYPE_3 ( STRING_2 + VAR_1 + STRING_3 ) ; } }
private TYPE_1 METHOD_1 ( String VAR_1 ) { TYPE_2 entity = VAR_3 . METHOD_2 ( TYPE_4 . VAR_5 + STRING_1 + TYPE_4 . VAR_6 , VAR_1 ) ; if ( entity != null ) { return METHOD_3 ( entity ) ; } else { throw new TYPE_3 ( STRING_2 + VAR_1 + STRING_3 ) ; } }
call VAR_1 ( true ) consistency
public TYPE_1 METHOD_1 ( ) { <START> VAR_1 = true ; <END> return this ; }
public TYPE_1 METHOD_1 ( ) { return METHOD_1 ( true ) ; }
debug logging accidentally left
public void METHOD_1 ( ) { <START> Log . d ( STRING_1 , STRING_2 ) ; <END> new TYPE_1 ( TYPE_2 . METHOD_2 ( ) ) . METHOD_3 ( new TYPE_3 ( ) { @Override public void run ( ) { if ( VAR_1 != null ) { VAR_1 . METHOD_4 ( ) ; } } } ) ; }
public void METHOD_1 ( ) { new TYPE_1 ( TYPE_2 . METHOD_2 ( ) ) . METHOD_3 ( new TYPE_3 ( ) { @Override public void run ( ) { if ( VAR_1 != null ) { VAR_1 . METHOD_4 ( ) ; } } } ) ; }
IIRC wrong a couple plugins want rewrite VAR_1 ( maven - shade - plugin flatten - maven - plugin ) VAR_1 target directory cleaned basedir stay
public TYPE_1 METHOD_1 ( File VAR_1 ) { this . VAR_1 = VAR_1 ; <START> if ( this . VAR_1 != null && this . VAR_1 . METHOD_2 ( ) != null ) <END> { this . METHOD_3 ( this . VAR_1 . METHOD_2 ( ) ) ; } return this ; }
public TYPE_1 METHOD_1 ( File VAR_1 ) { this . VAR_1 = VAR_1 ; return this ; }
METHOD_3 lambda method reference s reason TYPE_2 METHOD_3 introduced java 1 8 simple ! = null
private void METHOD_1 ( TYPE_1 properties ) { if ( properties != null ) { for ( Map . Entry < Object , Object > entry : properties . entrySet ( ) ) { Object v = entry . getValue ( ) ; if ( v instanceof String ) { String value = ( String ) v ; String VAR_1 = METHOD_2 ( value ) ; <START> if ( value != VAR_1 && TYPE_2 . M...
private void METHOD_1 ( TYPE_1 properties ) { if ( properties != null ) { for ( Map . Entry < Object , Object > entry : properties . entrySet ( ) ) { Object v = entry . getValue ( ) ; if ( v instanceof String ) { String value = ( String ) v ; String VAR_1 = METHOD_2 ( value ) ; if ( value != VAR_1 && VAR_1 != null ) { ...
wrong construct a URI please : _CODE_ ( ) _CODE_ ( ) _CODE_ ( )
protected TYPE_1 METHOD_1 ( ) throws Exception { TYPE_2 VAR_1 = METHOD_2 ( TYPE_2 . class , STRING_1 ) ; <START> TYPE_1 r = VAR_2 . METHOD_3 ( STRING_2 , STRING_3 + METHOD_4 ( ) . METHOD_5 ( ) , VAR_1 , null , null ) ; <END> return r ; }
protected TYPE_1 METHOD_1 ( ) throws Exception { TYPE_2 VAR_1 = METHOD_2 ( TYPE_2 . class ) ; TYPE_1 r = VAR_2 . METHOD_3 ( STRING_2 , STRING_3 + METHOD_4 ( ) . METHOD_5 ( ) , VAR_1 , null , null ) ; return r ; }
compare null necessary null instanceof TYPE_1 false
public boolean equals ( Object obj ) { if ( this == obj ) { return true ; } <START> if ( ( obj == null ) || ! ( obj instanceof TYPE_1 ) ) <END> { return false ; } TYPE_1 VAR_1 = ( TYPE_1 ) obj ; return METHOD_1 ( ) . equals ( VAR_1 . METHOD_1 ( ) ) ; }
public boolean equals ( Object obj ) { if ( this == obj ) { return true ; } if ( ! ( obj instanceof TYPE_1 ) ) { return false ; } TYPE_1 VAR_1 = ( TYPE_1 ) obj ; return METHOD_1 ( ) . equals ( VAR_1 . METHOD_1 ( ) ) ; }
please remove whitespace
public TYPE_1 METHOD_1 ( Exception e ) { if ( VAR_1 == null ) { VAR_1 = METHOD_2 ( VAR_1 ) ; } VAR_1 . add ( e ) ; <START> return this ; <END> }
public TYPE_1 METHOD_1 ( Exception e ) { VAR_1 = METHOD_2 ( VAR_1 ) ; VAR_1 . add ( e ) ; return this ; }
necessay ? called 20ms ! sufficient set top
<START> void METHOD_1 ( ) { <END> System . out . println ( STRING_1 ) ; METHOD_2 ( false ) ; METHOD_3 ( ) ; METHOD_2 ( true ) ; METHOD_3 ( ) ; }
void METHOD_1 ( ) { METHOD_2 ( false ) ; METHOD_3 ( ) ; METHOD_2 ( true ) ; METHOD_3 ( ) ; }
UTF - 8 version supported ? version charset
public void METHOD_1 ( String data , String VAR_1 ) throws TYPE_1 { <START> this . METHOD_1 ( data , VAR_1 , VAR_2 . VAR_3 , TYPE_2 . VAR_5 ) ; <END> }
public void METHOD_1 ( String data , String VAR_1 ) throws TYPE_1 { this . METHOD_1 ( data , VAR_1 , VAR_2 . VAR_3 ) ; }
I wasn t more clear need oshi prevent conflicting other properties files class path define string final instead changing
private String METHOD_1 ( ) { if ( this . VAR_1 == 10 ) { <START> VAR_2 = STRING_1 ; <END> TYPE_1 VAR_3 = TYPE_2 . METHOD_2 ( VAR_2 ) ; String VAR_4 = this . VAR_1 + STRING_2 + this . VAR_5 ; String VAR_6 = VAR_3 . getProperty ( VAR_4 ) ; return VAR_6 ; } LOG . warn ( STRING_3 , this . VAR_1 , this . VAR_5 ) ; return "...
private String METHOD_1 ( ) { if ( this . VAR_1 == 10 ) { TYPE_1 VAR_3 = TYPE_2 . METHOD_2 ( VAR_2 ) ; return VAR_3 . getProperty ( this . VAR_1 + STRING_2 + this . VAR_5 ) ; } LOG . warn ( STRING_3 , this . VAR_1 , this . VAR_5 ) ; return "" ; }
a part original method anymore more sense unwrap original exception order lose trace leading executor thread METHOD_1 method I original attempt stack trace shorter potential reducing clarity improving ( other words I a stupid originally )
private void METHOD_1 ( Collection < TYPE_1 < TYPE_2 > > results ) throws Throwable { for ( final TYPE_1 < TYPE_2 > result : results ) { try { result . get ( ) ; <START> } catch ( final TYPE_3 e ) { <END> throw e . VAR_1 ( ) ; } } }
private static void METHOD_1 ( Collection < TYPE_1 < TYPE_2 > > results ) throws InterruptedException , TYPE_3 { for ( final TYPE_1 < TYPE_2 > result : results ) { result . get ( ) ; } }
returning boxed Double
<START> public static Double get ( String key , double VAR_1 ) { <END> String value = configuration . getProperty ( key ) ; return value == null ? VAR_1 : TYPE_1 . METHOD_1 ( value , VAR_1 ) ; }
public static double get ( String key , double VAR_1 ) { String value = configuration . getProperty ( key ) ; return value == null ? VAR_1 : TYPE_1 . METHOD_1 ( value , VAR_1 ) ; }
public private
<START> static String METHOD_1 ( String VAR_1 ) { <END> return VAR_2 . entrySet ( ) . stream ( ) . filter ( entry - > VAR_1 . startsWith ( entry . getKey ( ) ) ) . map ( Map . Entry : : getValue ) . collect ( Collectors . VAR_3 ( ) ) ; }
public static String METHOD_1 ( String VAR_1 ) { return VAR_2 . entrySet ( ) . stream ( ) . filter ( entry - > VAR_1 . startsWith ( entry . getKey ( ) ) ) . map ( Map . Entry : : getValue ) . collect ( Collectors . VAR_3 ( ) ) ; }
unnecessary s default initialization
public TYPE_2 ( ) { name = "" ; model = "" ; VAR_2 = "" ; <START> size = INT_1 ; <END> VAR_3 = INT_1 ; VAR_4 = INT_1 ; VAR_5 = INT_1 ; VAR_6 = INT_1 ; VAR_7 = INT_1 ; VAR_8 = INT_1 ; VAR_9 = new TYPE_1 [ 0 ] ; VAR_10 = INT_1 ; }
public TYPE_2 ( ) { }
line ( VAR_3 startsWith ( VAR_3 ) ) correct ? aren t checking VAR_2
private Boolean METHOD_1 ( List < String > VAR_1 , String VAR_2 ) { for ( String VAR_3 : VAR_1 ) { <START> if ( VAR_3 . startsWith ( VAR_3 ) ) { <END> return Boolean . VAR_4 ; } } return Boolean . VAR_5 ; }
private Boolean METHOD_1 ( List < String > VAR_1 , String VAR_2 ) { for ( String VAR_3 : VAR_1 ) { if ( VAR_3 . startsWith ( VAR_2 ) ) { return Boolean . VAR_4 ; } } return Boolean . VAR_5 ; }
touch positive engine
private List < TYPE_1 > METHOD_1 ( ) { List < TYPE_1 > VAR_1 = new TYPE_2 < > ( ) ; TYPE_1 VAR_2 = new TYPE_1 ( STRING_1 , STRING_2 , TYPE_3 . class ) ; VAR_1 . add ( VAR_2 ) ; VAR_2 = new TYPE_1 ( STRING_1 , STRING_3 , TYPE_4 . class ) ; VAR_1 . add ( VAR_2 ) ; return VAR_1 ; <START> } <END>
private List < TYPE_1 > METHOD_1 ( ) { List < TYPE_1 > VAR_1 = new TYPE_2 < > ( ) ; TYPE_1 VAR_2 = new TYPE_1 ( STRING_1 , STRING_2 , TYPE_3 . class ) ; VAR_1 . add ( VAR_2 ) ; return VAR_1 ; }
extra ( ) s superfluous
protected TYPE_1 METHOD_1 ( ) throws Exception { if ( this . VAR_1 == null ) { throw new TYPE_2 ( STRING_1 , getName ( ) ) ; } <START> final byte [ ] data = ( this . VAR_1 . METHOD_2 ( ) == 0 ) ? new byte [ 0 ] <END> : VAR_2 . METHOD_3 ( ) . METHOD_4 ( this . path ) ; return new TYPE_3 ( data ) ; }
protected TYPE_1 METHOD_1 ( ) throws Exception { if ( this . VAR_1 == null ) { throw new TYPE_2 ( STRING_1 , getName ( ) ) ; } final byte [ ] data = this . VAR_1 . METHOD_2 ( ) == 0 ? new byte [ 0 ] : VAR_2 . METHOD_3 ( ) . METHOD_4 ( this . path ) ; return new TYPE_3 ( data ) ; }
need hide methods tests reusing code more difficult discovery features _CODE_ CTRL - space method names
<START> private static File METHOD_1 ( final File file ) { <END> try { return file . VAR_1 ( ) ; } catch ( final IOException e ) { return file . VAR_2 ( ) ; } }
public static File METHOD_1 ( final File file ) { try { return file . VAR_1 ( ) ; } catch ( final IOException e ) { return file . VAR_2 ( ) ; } }
petrov more detail I create a protected method called _CODE_ returns Arrays asList ( TYPE_2 VAR_5 TYPE_2 VAR_6 ) clear defaults possibility easy override subclassing gary
public List < Integer > METHOD_1 ( final TYPE_1 VAR_1 ) { ANNOTATION_1 ( STRING_1 ) List < Integer > VAR_2 = ( List < Integer > ) METHOD_2 ( VAR_1 , VAR_3 ) ; <START> return VAR_2 != null ? VAR_2 : Arrays . asList ( TYPE_2 . VAR_5 , TYPE_2 . VAR_6 ) ; <END> }
public List < Integer > METHOD_1 ( final TYPE_1 VAR_1 ) { return ( List < Integer > ) METHOD_2 ( VAR_1 , VAR_3 ) ; }
needed ? removed efficiency reasons ( I don t method )
public int METHOD_1 ( TYPE_1 < ? > VAR_1 ) { <START> if ( ! VAR_1 . getClass ( ) . equals ( this . getClass ( ) ) ) { <END> throw new IllegalArgumentException ( STRING_1 + VAR_1 . getClass ( ) . METHOD_2 ( ) + STRING_2 ) ; } TYPE_2 VAR_2 = ( ( TYPE_3 ) VAR_1 ) . getValue ( ) ; return value . VAR_3 ( VAR_2 ) * - 1 ; }
public int METHOD_1 ( TYPE_1 < ? > VAR_1 ) { TYPE_2 VAR_2 = ( ( TYPE_3 ) VAR_1 ) . getValue ( ) ; return value . VAR_3 ( VAR_2 ) * - 1 ; }
needed ? removed efficiency reasons ( I don t method )
protected TYPE_1 METHOD_1 ( TYPE_2 < ? > VAR_1 ) { if ( VAR_1 == null ) return null ; <START> if ( ! VAR_1 . getClass ( ) . equals ( this . getClass ( ) ) ) { <END> throw new IllegalArgumentException ( STRING_1 + VAR_1 . getClass ( ) . METHOD_2 ( ) + STRING_2 ) ; } else { return ( TYPE_1 ) VAR_1 ; } }
protected TYPE_1 METHOD_1 ( TYPE_2 < ? > VAR_1 ) { if ( VAR_1 == null ) return null ; return ( TYPE_1 ) VAR_1 ; }
catch exception
public TYPE_1 METHOD_1 ( ) { TYPE_1 result = new TYPE_1 ( STRING_1 ) ; result . VAR_1 ( STRING_2 , VAR_2 ) ; result . VAR_1 ( STRING_3 , VAR_3 ) ; <START> result . VAR_1 ( STRING_4 , METHOD_2 ( ) ) ; <END> result . VAR_1 ( STRING_5 , METHOD_3 ( ) ) ; return result ; }
public TYPE_1 METHOD_1 ( ) { TYPE_1 result = new TYPE_1 ( STRING_1 ) ; result . VAR_1 ( STRING_2 , VAR_2 ) ; result . VAR_1 ( STRING_3 , VAR_3 ) ; try { result . VAR_1 ( STRING_4 , METHOD_2 ( ) ) ; result . VAR_1 ( STRING_5 , METHOD_3 ( ) ) ; } catch ( Exception e ) { } return result ; }
( VAR_2 VAR_3 VAR_4 VAR_5 false ) ; ? ?
public TYPE_1 ( double VAR_2 , double VAR_3 , double VAR_4 , int VAR_5 ) { <START> super ( VAR_4 ) ; <END> this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; this . VAR_6 = METHOD_1 ( VAR_2 ) ; this . VAR_7 = METHOD_2 ( METHOD_3 ( ) , VAR_2 , this . VAR_6 ) ; this . VAR_5 = VAR_5 ; }
public TYPE_1 ( double VAR_2 , double VAR_3 , double VAR_4 , int VAR_5 ) { this ( VAR_2 , VAR_3 , VAR_4 , VAR_5 , false ) ; }
please a switch statement
public TYPE_1 METHOD_1 ( TYPE_2 type ) { if ( type == TYPE_2 . VAR_1 ) { return METHOD_2 ( STRING_1 ) ; } <START> if ( type == TYPE_2 . VAR_2 ) { return METHOD_2 ( STRING_2 ) ; } <END> if ( type == TYPE_2 . VAR_3 ) { return METHOD_2 ( STRING_3 ) ; } if ( type == TYPE_2 . VAR_4 ) { return METHOD_2 ( STRING_4 ) ; } throw...
public TYPE_1 METHOD_1 ( TYPE_2 type ) { if ( type == TYPE_2 . VAR_1 ) { return METHOD_2 ( STRING_1 ) ; } else if ( type == TYPE_2 . VAR_2 ) { return METHOD_2 ( STRING_2 ) ; } else if ( type == TYPE_2 . VAR_3 ) { return METHOD_2 ( STRING_3 ) ; } else if ( type == TYPE_2 . VAR_4 ) { return METHOD_2 ( STRING_4 ) ; } else...
revert VAR_1 - null AFAICS
public int METHOD_1 ( ) { <START> return TYPE_1 . METHOD_1 ( VAR_1 ) ; <END> }
public int METHOD_1 ( ) { return VAR_1 . METHOD_1 ( ) ; }
more sense
public TYPE_1 METHOD_1 ( ) { TYPE_2 VAR_1 = VAR_2 . METHOD_2 ( ) . get ( 0 ) ; <START> return ( ( TYPE_3 ) VAR_1 ) . METHOD_3 ( ) . METHOD_1 ( ) ; <END> }
public TYPE_1 METHOD_1 ( ) { TYPE_2 VAR_1 = VAR_2 . METHOD_2 ( ) . get ( 0 ) ; return VAR_1 . METHOD_1 ( ) ; }
swap method parametrr orders
private static void METHOD_1 ( Exception exception , Class < ? > type , String message ) { Throwable VAR_1 = exception ; while ( VAR_1 . METHOD_2 ( ) != null ) { VAR_1 = VAR_1 . METHOD_2 ( ) ; } METHOD_3 ( type , VAR_1 ) ; <START> assertEquals ( VAR_1 . getMessage ( ) , message ) ; <END> }
private static void METHOD_1 ( Exception exception , Class < ? > type , String message ) { Throwable VAR_1 = exception ; while ( VAR_1 . METHOD_2 ( ) != null ) { VAR_1 = VAR_1 . METHOD_2 ( ) ; } METHOD_3 ( type , VAR_1 ) ; assertEquals ( message , VAR_1 . getMessage ( ) ) ; }
minor nitpicking I ve removing unnecessary helpers : null reason TYPE_1 ( ( String ) ) isEmpty ( )
public static < T > T METHOD_1 ( T ... values ) { if ( values == null ) { return null ; } for ( T value : values ) { if ( value != null ) { if ( String . VAR_1 . METHOD_2 ( value ) ) { <START> if ( TYPE_1 . METHOD_3 ( ( String ) value ) ) { <END> return value ; } } else { return value ; } } } return null ; }
public static < T > T METHOD_1 ( T ... values ) { if ( values == null ) { return null ; } for ( T value : values ) { if ( value != null ) { if ( String . VAR_1 . METHOD_2 ( value ) ) { if ( ! ( ( String ) value ) . isEmpty ( ) ) { return value ; } } else { return value ; } } } return null ; }
upper limit corrected error message VAR_2 - 1
private String [ ] METHOD_1 ( int VAR_1 ) { final int index = VAR_1 - METHOD_2 ( ) ; if ( index >= VAR_2 . length ) { throw new IllegalArgumentException ( STRING_1 + VAR_2 . length <START> + STRING_2 <END> ) ; } return VAR_2 [ index ] ; }
private String [ ] METHOD_1 ( int VAR_1 ) { final int index = VAR_1 - METHOD_2 ( ) ; if ( index >= VAR_2 . length ) { throw new IllegalArgumentException ( STRING_1 + ( VAR_2 . length - 1 ) + STRING_2 ) ; } return VAR_2 [ index ] ; }
great space chars consistently existing coding format asif ( VAR_2 ! = null && VAR_2 length = = 1 && VAR_2 [ 0 ] = = null )
protected String [ ] METHOD_1 ( TYPE_1 VAR_1 , int j ) { String [ ] VAR_2 = VAR_1 . METHOD_2 ( j ) ; <START> if ( VAR_2 != null && VAR_2 . length == 1 && VAR_2 [ 0 ] == null ) { <END> return new String [ ] { VAR_1 . METHOD_3 ( ) [ j ] } ; } return VAR_2 ; }
protected String [ ] METHOD_1 ( TYPE_1 VAR_1 , int j ) { String [ ] VAR_2 = VAR_1 . METHOD_2 ( j ) ; if ( Arrays . equals ( VAR_2 , new String [ ] { null } ) ) { return new String [ ] { VAR_1 . METHOD_3 ( ) [ j ] } ; } return VAR_2 ; }
condition : ( ! METHOD_2 ( ) )
public TYPE_1 METHOD_1 ( int VAR_1 , int VAR_2 , int VAR_3 , int VAR_4 , int VAR_5 , int VAR_6 , int VAR_7 , TYPE_2 VAR_8 ) { if ( METHOD_2 ( ) ) { <START> VAR_7 = 0 ; <END> } return add ( VAR_8 , VAR_4 , VAR_5 , VAR_6 , VAR_7 , VAR_1 , VAR_2 , VAR_3 ) ; }
public TYPE_1 METHOD_1 ( int VAR_1 , int VAR_2 , int VAR_3 , int VAR_4 , int VAR_5 , int VAR_6 , int VAR_7 , TYPE_2 VAR_8 ) { if ( ! METHOD_2 ( ) ) { VAR_7 = 0 ; } return add ( VAR_8 , VAR_4 , VAR_5 , VAR_6 , VAR_7 , VAR_1 , VAR_2 , VAR_3 ) ; }
condition : ( ! METHOD_1 ( ) )
public TYPE_1 add ( int VAR_1 , int VAR_2 , int VAR_3 , int VAR_4 , int VAR_5 , int VAR_6 , int VAR_7 , String offset , TYPE_2 VAR_8 ) { if ( METHOD_1 ( ) ) { <START> VAR_7 = 0 ; <END> } return add ( VAR_8 , VAR_1 , VAR_2 , VAR_3 , VAR_4 , VAR_5 , VAR_6 , VAR_7 , offset ) ; }
public TYPE_1 add ( int VAR_1 , int VAR_2 , int VAR_3 , int VAR_4 , int VAR_5 , int VAR_6 , int VAR_7 , String offset , TYPE_2 VAR_8 ) { if ( ! METHOD_1 ( ) ) { VAR_7 = 0 ; } return add ( VAR_8 , VAR_1 , VAR_2 , VAR_3 , VAR_4 , VAR_5 , VAR_6 , VAR_7 , offset ) ; }
condition : ( ! METHOD_2 ( ) )
public TYPE_1 METHOD_1 ( int VAR_1 , int VAR_2 , int VAR_3 , int VAR_4 , int VAR_5 , int VAR_6 , int VAR_7 , String offset , TYPE_2 VAR_8 ) { if ( METHOD_2 ( ) ) { <START> VAR_7 = 0 ; <END> } return add ( VAR_8 , VAR_4 , VAR_5 , VAR_6 , VAR_7 , offset , VAR_1 , VAR_2 , VAR_3 ) ; }
public TYPE_1 METHOD_1 ( int VAR_1 , int VAR_2 , int VAR_3 , int VAR_4 , int VAR_5 , int VAR_6 , int VAR_7 , String offset , TYPE_2 VAR_8 ) { if ( ! METHOD_2 ( ) ) { VAR_7 = 0 ; } return add ( VAR_8 , VAR_4 , VAR_5 , VAR_6 , VAR_7 , offset , VAR_1 , VAR_2 , VAR_3 ) ; }
condition : ( ! METHOD_1 ( ) )
public TYPE_1 add ( int VAR_1 , int VAR_2 , int VAR_3 , int VAR_4 , int VAR_5 , int VAR_6 , int VAR_7 , String VAR_8 , TYPE_2 VAR_9 ) { if ( METHOD_1 ( ) ) { <START> VAR_7 = 0 ; <END> } return add ( VAR_9 , VAR_1 , VAR_2 , VAR_3 , VAR_4 , VAR_5 , VAR_6 , VAR_7 , VAR_8 ) ; }
public TYPE_1 add ( int VAR_1 , int VAR_2 , int VAR_3 , int VAR_4 , int VAR_5 , int VAR_6 , int VAR_7 , String VAR_8 , TYPE_2 VAR_9 ) { if ( ! METHOD_1 ( ) ) { VAR_7 = 0 ; } return add ( VAR_9 , VAR_1 , VAR_2 , VAR_3 , VAR_4 , VAR_5 , VAR_6 , VAR_7 , VAR_8 ) ; }
process removing other logger calls s add more
void METHOD_1 ( long VAR_1 ) { <START> log . VAR_2 ( STRING_1 , query ) ; <END> VAR_3 . METHOD_2 ( ) ; VAR_4 . METHOD_3 ( VAR_1 ) ; }
void METHOD_1 ( long VAR_1 ) { VAR_3 . METHOD_2 ( ) ; VAR_4 . METHOD_3 ( VAR_1 ) ; }
process removing other logger calls s add more
void METHOD_1 ( ) { <START> log . VAR_1 ( STRING_1 , query ) ; <END> VAR_2 . METHOD_2 ( ) ; }
void METHOD_1 ( ) { VAR_2 . METHOD_2 ( ) ; }
I don t need VAR_3 ( ) clear ( ) considering init specific test method I moved test method remove METHOD_1 ( ) altogether
public void METHOD_1 ( ) throws Exception { METHOD_2 ( this : : METHOD_3 , s - > { TYPE_1 VAR_1 = new TYPE_1 ( ) ; VAR_1 . METHOD_4 ( new TYPE_2 ( ) ) ; VAR_1 . METHOD_5 ( ) . METHOD_6 ( STRING_1 ) ; VAR_1 . METHOD_5 ( ) . METHOD_7 ( new Date ( ) ) ; VAR_1 . METHOD_8 ( STRING_2 ) ; s . VAR_2 ( VAR_1 ) ; s . VAR_3 ( ) ;...
public void METHOD_1 ( ) throws Exception { METHOD_2 ( this : : METHOD_3 , s - > { TYPE_1 VAR_1 = new TYPE_1 ( ) ; VAR_1 . METHOD_4 ( new TYPE_2 ( ) ) ; VAR_1 . METHOD_5 ( ) . METHOD_6 ( STRING_1 ) ; VAR_1 . METHOD_5 ( ) . METHOD_7 ( new Date ( ) ) ; VAR_1 . METHOD_8 ( STRING_2 ) ; s . VAR_2 ( VAR_1 ) ; } ) ; }
I don t needed
<START> public String METHOD_1 ( ) { <END> TYPE_1 VAR_1 = METHOD_2 ( ) ; return ( VAR_1 != null ) ? VAR_1 . METHOD_1 ( ) : STRING_1 ; }
private String METHOD_1 ( ) { TYPE_1 VAR_1 = METHOD_2 ( ) ; return ( VAR_1 != null ) ? VAR_1 . METHOD_1 ( ) : STRING_1 ; }
want a other METHOD_1 ( ) method calls METHOD_2 executing code a bug ? a dumb suggestion couldn t move code caller ( s ) METHOD_1 ( ) ? type benefit code types extending _CODE_ I s simple remove need type implementations refer TYPE_2 SPI type
public final Object METHOD_1 ( Object VAR_1 , Object target , TYPE_1 session , Object VAR_2 , Map VAR_3 ) { if ( VAR_1 == null && target == null ) { return null ; } if ( VAR_1 == TYPE_2 . VAR_5 ) { return target ; } if ( target == TYPE_2 . VAR_5 ) { return METHOD_2 ( ( T ) VAR_1 , null , session ) ; <START> } <END> ret...
public final Object METHOD_1 ( Object VAR_1 , Object target , TYPE_1 session , Object VAR_2 , Map VAR_3 ) { if ( VAR_1 == null && target == null ) { return null ; } return METHOD_2 ( ( T ) VAR_1 , ( T ) target , session ) ; }
final Set < TYPE_2 > VAR_3 = VAR_4 remove ( VAR_1 ) ; remove ( ) call ? need access map change behavior slightly METHOD_2 throws exception VAR_4 s a good idea
public void METHOD_1 ( TYPE_1 VAR_1 ) { log . VAR_2 ( STRING_1 , VAR_1 ) ; <START> final Set < TYPE_2 > VAR_3 = VAR_4 . get ( VAR_1 ) ; <END> if ( VAR_3 != null ) { METHOD_2 ( VAR_3 ) ; VAR_4 . remove ( VAR_1 ) ; } else if ( log . VAR_5 ( ) ) { log . VAR_6 ( ) ; } close ( VAR_1 ) ; if ( VAR_7 == VAR_1 ) { VAR_7 = null ...
public void METHOD_1 ( TYPE_1 VAR_1 ) { log . VAR_2 ( STRING_1 , VAR_1 ) ; if ( log . VAR_5 ( ) && ! VAR_4 . containsKey ( VAR_1 ) ) { log . VAR_6 ( ) ; } else { final Set < TYPE_2 > VAR_3 = VAR_4 . get ( VAR_1 ) ; if ( VAR_3 != null ) { METHOD_2 ( VAR_3 ) ; } VAR_4 . remove ( VAR_1 ) ; } close ( VAR_1 ) ; if ( VAR_7 =...