Datasets:
YabTad
/
CodeRev

Dataset card Data Studio Files
xet
 Community
ReviewComments
stringlengths
1
2.35k
OriginalCode
stringlengths
28
487
ReviewedCode
stringlengths
14
463
added container part METHOD_2
private TYPE_1 METHOD_1 ( ) { return new TYPE_1 ( VAR_1 , VAR_2 , VAR_3 , VAR_4 , TYPE_2 . METHOD_2 ( TYPE_6 < TYPE_3 < ? super TYPE_4 > > of ( METHOD_3 ( VAR_6 , VAR_7 , VAR_8 , VAR_9 , VAR_10 , VAR_11 , VAR_12 , VAR_13 ) , TYPE_2 . and ( TYPE_2 . METHOD_4 ( TYPE_5 . class ) , METHOD_3 ( VAR_14 , VAR_15 , VAR_16 , VAR...
private TYPE_1 METHOD_1 ( ) { return new TYPE_1 ( VAR_1 , VAR_2 , VAR_3 , VAR_4 , TYPE_2 . METHOD_2 ( TYPE_6 < TYPE_3 < ? super TYPE_4 > > of ( METHOD_3 ( VAR_6 , VAR_7 , VAR_8 , VAR_9 , VAR_10 , VAR_11 , VAR_12 , VAR_13 , VAR_23 ) , TYPE_2 . and ( TYPE_2 . METHOD_4 ( TYPE_5 . class ) , METHOD_3 ( VAR_14 , VAR_15 , VAR...
doesn t ll a single reporter life worker ( a single reporter means a single task I ? ) I thought talked a new task hour similar
public TYPE_9 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 , TYPE_3 VAR_4 , TYPE_4 < TYPE_5 > VAR_5 , TYPE_6 < TYPE_5 > filter ) { this . VAR_2 = METHOD_1 ( VAR_2 ) ; this . VAR_3 = METHOD_1 ( VAR_3 ) ; this . VAR_4 = METHOD_1 ( VAR_4 ) ; this . VAR_5 = METHOD_1 ( VAR_5 ) ; this . filter = METHOD_1 ( filter ) ; this . VAR_6 = TYPE_7 ...
public TYPE_9 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 , TYPE_3 VAR_4 , TYPE_4 < TYPE_5 > VAR_5 , TYPE_6 < TYPE_5 > filter ) { this . VAR_2 = METHOD_1 ( VAR_2 ) ; this . VAR_3 = METHOD_1 ( VAR_3 ) ; this . VAR_4 = METHOD_1 ( VAR_4 ) ; this . VAR_5 = METHOD_1 ( VAR_5 ) ; this . filter = METHOD_1 ( filter ) ; }
I d personally a _CODE_ method don t need + 1 time s nitpicking
private void METHOD_1 ( ) { if ( VAR_1 == null ) { VAR_1 = TYPE_1 . create ( TYPE_3 . VAR_3 , TYPE_4 . Type . VAR_5 ) ; VAR_1 . METHOD_2 ( ) ; <START> VAR_6 = TYPE_2 . METHOD_3 ( ) ; <END> } else if ( VAR_6 . METHOD_4 ( 1 ) . METHOD_5 ( ) ) { VAR_1 . METHOD_6 ( ) ; VAR_1 . METHOD_2 ( ) ; } }
private void METHOD_1 ( ) { if ( VAR_1 == null ) { VAR_1 = TYPE_1 . create ( TYPE_3 . VAR_3 , TYPE_4 . Type . VAR_5 ) ; VAR_1 . METHOD_2 ( ) ; VAR_6 = TYPE_2 . METHOD_3 ( ) ; } else if ( VAR_6 . METHOD_4 ( 1 ) . METHOD_5 ( ) ) { VAR_1 . METHOD_6 ( ) ; VAR_1 = TYPE_1 . create ( TYPE_3 . VAR_3 , TYPE_4 . Type . VAR_5 ) ;...
shouldn t necessary people aren t watching logs carefully enough ingest stage realising
private static TYPE_1 METHOD_1 ( TYPE_2 name ) { TYPE_3 VAR_1 ; try { VAR_1 = TYPE_3 . valueOf ( TYPE_4 . VAR_3 ) ; } catch ( IllegalArgumentException e ) { <START> log . error ( STRING_1 , TYPE_4 . VAR_3 ) ; <END> e . VAR_4 ( ) ; VAR_1 = TYPE_3 . VAR_5 ; } return TYPE_1 . create ( name . VAR_6 ( ) , name . VAR_7 ( ) ,...
private static TYPE_1 METHOD_1 ( TYPE_2 name ) { TYPE_3 VAR_1 ; try { VAR_1 = TYPE_3 . valueOf ( VAR_3 ) ; } catch ( IllegalArgumentException e ) { VAR_1 = TYPE_3 . VAR_5 ; log . error ( STRING_1 , VAR_3 , e ) ; } return TYPE_1 . create ( name . VAR_6 ( ) , name . VAR_7 ( ) , VAR_1 ) ; }
URI a trailing / similar cruft
private String METHOD_1 ( TYPE_1 channel ) { return channel . VAR_1 ( ) <START> . METHOD_2 ( VAR_2 , "" ) <END> . trim ( ) ; }
String METHOD_1 ( TYPE_1 channel ) { return channel . VAR_1 ( ) . METHOD_2 ( VAR_2 , "" ) . trim ( ) ; }
bother - wrapping returned s passed method Optional present
private Optional < TYPE_1 > METHOD_1 ( TYPE_1 channel , TYPE_2 VAR_1 , TYPE_2 VAR_2 ) { if ( VAR_1 != null && VAR_1 . METHOD_2 ( ) > 0 ) { channel . VAR_3 ( VAR_1 ) ; } else { channel . VAR_3 ( null ) ; } if ( VAR_2 != null && VAR_2 . METHOD_2 ( ) > 0 ) { channel . VAR_4 ( VAR_2 ) ; } else { channel . VAR_4 ( null ) ; ...
private TYPE_1 METHOD_1 ( TYPE_1 channel , TYPE_2 VAR_1 , TYPE_2 VAR_2 ) { if ( VAR_1 != null && VAR_1 . METHOD_2 ( ) > 0 ) { channel . VAR_3 ( VAR_1 ) ; } else { channel . VAR_3 ( null ) ; } if ( VAR_2 != null && VAR_2 . METHOD_2 ( ) > 0 ) { channel . VAR_4 ( VAR_2 ) ; } else { channel . VAR_4 ( null ) ; } VAR_5 . MET...
objects equals JIC null safety required
private void METHOD_1 ( Set < Long > VAR_1 , TYPE_1 < TYPE_2 > VAR_2 ) { for ( TYPE_2 channel : VAR_2 ) { if ( ! VAR_1 . contains ( channel . getId ( ) ) ) { channel . VAR_3 ( channel . VAR_4 ( ) . stream ( ) <START> . filter ( VAR_5 - > ! VAR_5 . METHOD_2 ( ) . equals ( VAR_6 ) ) <END> . collect ( Collectors . VAR_7 (...
private void METHOD_1 ( Set < Long > VAR_1 , TYPE_1 < TYPE_2 > VAR_2 ) { for ( TYPE_2 channel : VAR_2 ) { if ( ! VAR_1 . contains ( channel . getId ( ) ) ) { channel . VAR_3 ( channel . VAR_4 ( ) . stream ( ) . filter ( VAR_5 - > ! VAR_5 . METHOD_2 ( ) . equals ( VAR_6 ) ) . collect ( Collectors . VAR_7 ( ) ) ) ; VAR_8...
wouldn t false false
private boolean METHOD_1 ( String VAR_1 , String VAR_2 ) { <START> return false && VAR_1 . equals ( VAR_2 ) ; <END> }
private boolean METHOD_1 ( String VAR_1 , String VAR_2 ) { return VAR_1 . equals ( VAR_2 ) ; }
streamed
public void METHOD_1 ( ) { TYPE_1 TYPE_2 = TYPE_3 . METHOD_2 ( VAR_1 ) ; Set < TYPE_4 > VAR_2 = TYPE_5 . METHOD_3 ( ) ; if ( Boolean . VAR_3 ( VAR_4 ) && Boolean . VAR_3 ( VAR_5 ) ) { log . info ( STRING_1 ) ; METHOD_4 ( VAR_2 ) ; } <START> for ( TYPE_4 VAR_6 : VAR_2 ) { <END> TYPE_2 . METHOD_5 ( VAR_6 ) ; } }
public void METHOD_1 ( ) { TYPE_1 TYPE_2 = TYPE_3 . METHOD_2 ( VAR_1 ) ; Set < TYPE_4 > VAR_2 = TYPE_5 . METHOD_3 ( ) ; if ( Boolean . VAR_3 ( VAR_4 ) && Boolean . VAR_3 ( VAR_5 ) ) { log . info ( STRING_1 ) ; METHOD_4 ( VAR_2 ) ; } VAR_2 . forEach ( TYPE_2 : : METHOD_5 ) ; }
METHOD_1
private TYPE_2 ( String VAR_2 , String VAR_3 , String VAR_4 , String VAR_5 , TYPE_1 VAR_6 ) { this . VAR_2 = METHOD_1 ( VAR_2 ) ; this . VAR_3 = METHOD_1 ( VAR_3 ) ; this . VAR_4 = METHOD_1 ( VAR_4 ) ; this . VAR_5 = METHOD_1 ( VAR_5 ) ; <START> this . VAR_7 = VAR_6 ; <END> }
private TYPE_2 ( String VAR_2 , String VAR_3 , String VAR_4 , String VAR_5 , TYPE_1 VAR_6 ) { this . VAR_2 = METHOD_1 ( VAR_2 ) ; this . VAR_3 = METHOD_1 ( VAR_3 ) ; this . VAR_4 = METHOD_1 ( VAR_4 ) ; this . VAR_5 = METHOD_1 ( VAR_5 ) ; this . VAR_7 = METHOD_1 ( VAR_6 ) ; }
convert private constructor a static create method
<START> public TYPE_3 ( TYPE_1 VAR_2 ) { <END> this . VAR_2 = METHOD_1 ( VAR_2 ) ; this . VAR_3 = TYPE_2 . METHOD_2 ( ) ; }
private TYPE_3 ( TYPE_1 VAR_2 ) { this . VAR_2 = METHOD_1 ( VAR_2 ) ; this . VAR_3 = TYPE_2 . METHOD_2 ( ) ; }
convert private constructor a static create method
<START> public TYPE_4 ( TYPE_1 < String > VAR_2 , TYPE_1 < String > VAR_3 ) { <END> this . VAR_2 = TYPE_2 . METHOD_1 ( VAR_2 ) ; this . VAR_3 = TYPE_2 . METHOD_1 ( VAR_3 ) ; this . VAR_4 = TYPE_3 . METHOD_2 ( ) ; }
private TYPE_4 ( TYPE_1 < String > VAR_2 , TYPE_1 < String > VAR_3 ) { this . VAR_2 = TYPE_2 . METHOD_1 ( VAR_2 ) ; this . VAR_3 = TYPE_2 . METHOD_1 ( VAR_3 ) ; this . VAR_4 = TYPE_3 . METHOD_2 ( ) ; }
convert private constructor a static create method
<START> public TYPE_4 ( <END> TYPE_1 < ? extends TYPE_2 < T > > VAR_2 , Set < String > VAR_3 , Set < String > VAR_4 ) { this . VAR_2 = ImmutableList . VAR_5 ( VAR_2 ) ; this . VAR_3 = VAR_3 ; this . VAR_4 = VAR_4 ; this . VAR_6 = TYPE_3 . METHOD_1 ( ) ; }
private TYPE_4 ( TYPE_1 < ? extends TYPE_2 < T > > VAR_2 , Set < String > VAR_3 , Set < String > VAR_4 ) { this . VAR_2 = ImmutableList . VAR_5 ( VAR_2 ) ; this . VAR_3 = VAR_3 ; this . VAR_4 = VAR_4 ; this . VAR_6 = TYPE_3 . METHOD_1 ( ) ; }
I d write some explicit tests ID list instead adding id s uri tests s quick a lot clearer testing decoding string representation ID a long variable tests a lot clearer show ID matches
public void METHOD_1 ( ) { TYPE_1 item = new TYPE_1 ( ) ; <START> item . VAR_1 ( INT_1 ) ; <END> item . VAR_2 ( STRING_1 ) ; VAR_3 . METHOD_2 ( item , VAR_4 ) ; METHOD_3 ( VAR_5 ) . METHOD_2 ( item , VAR_4 ) ; }
public void METHOD_1 ( ) { TYPE_1 item = new TYPE_1 ( ) ; item . VAR_2 ( STRING_1 ) ; VAR_3 . METHOD_2 ( item , VAR_4 ) ; METHOD_3 ( VAR_5 ) . METHOD_2 ( item , VAR_4 ) ; }
classes part atlas repo s change static factory methods code style
private TYPE_1 METHOD_1 ( ) { return TYPE_1 . create ( VAR_1 , VAR_2 , VAR_3 , VAR_4 , METHOD_2 ( ) , VAR_5 , VAR_6 , VAR_7 , new TYPE_2 ( VAR_6 , VAR_8 , VAR_9 ) , <START> new TYPE_3 ( <END> new TYPE_4 ( VAR_10 , new TYPE_5 ( VAR_10 , VAR_5 ) ) , VAR_7 , VAR_6 ) ) ; }
private TYPE_1 METHOD_1 ( ) { return TYPE_1 . create ( VAR_1 , VAR_2 , VAR_3 , VAR_4 , METHOD_2 ( ) , VAR_5 , VAR_6 , VAR_7 , TYPE_2 . create ( VAR_6 , VAR_8 , VAR_9 ) , TYPE_3 . create ( new TYPE_4 ( VAR_10 , new TYPE_5 ( VAR_10 , VAR_5 ) ) , VAR_7 , VAR_6 ) ) ; }
passed
private TYPE_1 METHOD_1 ( ) { return TYPE_1 . create ( VAR_1 , VAR_2 , VAR_3 , VAR_4 , METHOD_2 ( ) , VAR_5 , VAR_6 , VAR_7 , new TYPE_2 ( VAR_6 , VAR_8 , VAR_9 ) , VAR_10 , <START> VAR_1 <END> ) ; }
private TYPE_1 METHOD_1 ( ) { return TYPE_1 . create ( VAR_1 , VAR_2 , VAR_3 , VAR_4 , METHOD_2 ( ) , VAR_5 , VAR_6 , VAR_7 , new TYPE_2 ( VAR_6 , VAR_8 , VAR_9 ) , VAR_10 ) ; }
needs a static import
public void METHOD_1 ( ) { map . put ( STRING_1 , STRING_2 ) ; <START> Assert . assertThat ( <END> TYPE_1 . METHOD_2 ( STRING_3 , map ) , is ( STRING_4 ) ) ; }
public void METHOD_1 ( ) { map . put ( STRING_1 , STRING_2 ) ; assertThat ( TYPE_1 . METHOD_2 ( STRING_3 , map ) , is ( STRING_4 ) ) ; }
code style static factory methods builders classes constructors private
private TYPE_1 METHOD_1 ( ) { <START> return new TYPE_1 ( <END> VAR_1 , VAR_2 , new TYPE_2 ( ) , new TYPE_3 ( METHOD_2 ( ) , new TYPE_4 ( ) ) ) ; }
TYPE_1 METHOD_1 ( ) { return TYPE_1 . create ( VAR_1 , VAR_2 , TYPE_2 . create ( ) , TYPE_3 . create ( METHOD_2 ( ) , TYPE_4 . create ( ) ) ) ; }
unused member left
private TYPE_1 < TYPE_2 < TYPE_3 > > METHOD_1 ( TYPE_1 < TYPE_3 > VAR_1 ) throws TYPE_4 , TYPE_5 { return new TYPE_6 ( VAR_1 , <START> VAR_2 , <END> VAR_3 , VAR_4 , VAR_5 ) ; }
private TYPE_1 < TYPE_2 < TYPE_3 > > METHOD_1 ( TYPE_1 < TYPE_3 > VAR_1 ) throws TYPE_4 , TYPE_5 { return new TYPE_6 ( VAR_1 , VAR_3 , VAR_4 , VAR_5 ) ; }
return boolean
public boolean hasNext ( ) { <START> if ( VAR_1 . hasNext ( ) ) { <END> return true ; } return false ; }
public boolean hasNext ( ) { return VAR_1 . hasNext ( ) ; }
simplify { return VAR_4 METHOD_4 ( VAR_2 ) ;
public List < TYPE_1 > METHOD_1 ( String VAR_1 , String uri ) { TYPE_2 VAR_2 = new TYPE_2 ( ) ; VAR_2 . METHOD_2 ( VAR_1 ) ; VAR_2 . METHOD_3 ( uri ) ; List < TYPE_1 > VAR_3 ; try { <START> VAR_3 = VAR_4 . METHOD_4 ( VAR_2 ) ; <END> } catch ( TYPE_3 e ) { throw TYPE_4 . METHOD_5 ( e ) ; } return VAR_3 ; }
public List < TYPE_1 > METHOD_1 ( String VAR_1 , String uri ) { TYPE_2 VAR_2 = new TYPE_2 ( ) ; VAR_2 . METHOD_2 ( VAR_1 ) ; VAR_2 . METHOD_3 ( uri ) ; try { return VAR_4 . METHOD_4 ( VAR_2 ) ; } catch ( TYPE_3 e ) { throw TYPE_4 . METHOD_5 ( e ) ; } }
need guard
private void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 content ) { Set < String > VAR_2 = VAR_3 . map ( content . VAR_4 ( ) ) ; <START> if ( ! VAR_2 . isEmpty ( ) ) { <END> content . VAR_5 ( VAR_2 ) ; } }
private void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 content ) { Set < String > VAR_2 = VAR_3 . map ( content . VAR_4 ( ) ) ; content . VAR_5 ( VAR_2 ) ; }
eliminate : return ! TYPE_4 METHOD_5 ( VAR_3 VAR_5 ) isEmpty ( ) ;
protected boolean METHOD_1 ( TYPE_1 VAR_1 , TYPE_1 VAR_2 ) { TYPE_2 < String > VAR_3 = TYPE_3 . from ( VAR_2 . METHOD_2 ( ) ) . METHOD_3 ( VAR_4 ) . METHOD_4 ( ) ; TYPE_2 < String > VAR_5 = TYPE_3 . from ( VAR_1 . METHOD_2 ( ) ) . METHOD_3 ( VAR_4 ) . METHOD_4 ( ) ; if ( ! TYPE_4 . METHOD_5 ( VAR_3 , VAR_5 ) . isEmpty ...
protected boolean METHOD_1 ( TYPE_1 VAR_1 , TYPE_1 VAR_2 ) { TYPE_2 < String > VAR_3 = TYPE_3 . from ( VAR_2 . METHOD_2 ( ) ) . METHOD_3 ( VAR_4 ) . METHOD_4 ( ) ; TYPE_2 < String > VAR_5 = TYPE_3 . from ( VAR_1 . METHOD_2 ( ) ) . METHOD_3 ( VAR_4 ) . METHOD_4 ( ) ; return ! TYPE_4 . METHOD_5 ( VAR_3 , VAR_5 ) . isEmpt...
s a primitive
public TYPE_3 ( Optional < TYPE_1 > VAR_2 , TYPE_2 VAR_3 , boolean VAR_4 ) { this . VAR_2 = METHOD_1 ( VAR_2 ) ; this . VAR_3 = METHOD_1 ( VAR_3 ) ; <START> this . VAR_4 = METHOD_1 ( VAR_4 ) ; <END> }
public TYPE_3 ( Optional < TYPE_1 > VAR_2 , TYPE_2 VAR_3 , boolean VAR_4 ) { this . VAR_2 = METHOD_1 ( VAR_2 ) ; this . VAR_3 = METHOD_1 ( VAR_3 ) ; this . VAR_4 = VAR_4 ; }
double semi - colon
public void METHOD_1 ( TYPE_1 < T > result ) { try { <START> VAR_1 . METHOD_2 ( METHOD_3 ( result ) ) ; ; <END> } catch ( Exception e ) { log . error ( STRING_1 + result . VAR_2 ( ) , e ) ; } }
public void METHOD_1 ( TYPE_1 < T > result ) { try { VAR_1 . METHOD_2 ( METHOD_3 ( result ) ) ; } catch ( Exception e ) { log . error ( STRING_1 + result . VAR_2 ( ) , e ) ; } }
METHOD_3
public TYPE_5 ( Optional < TYPE_1 > VAR_2 , TYPE_2 < TYPE_3 > VAR_3 , TYPE_4 VAR_4 ) { METHOD_1 ( ! METHOD_2 ( VAR_2 ) , STRING_1 ) ; METHOD_3 ( VAR_3 ) ; METHOD_3 ( VAR_4 ) ; <START> this . VAR_5 = VAR_2 ; <END> this . VAR_3 = VAR_3 ; this . VAR_4 = VAR_4 ; }
public TYPE_5 ( Optional < TYPE_1 > VAR_2 , TYPE_2 < TYPE_3 > VAR_3 , TYPE_4 VAR_4 ) { METHOD_1 ( ! METHOD_2 ( VAR_2 ) , STRING_1 ) ; this . VAR_5 = METHOD_3 ( VAR_2 ) ; this . VAR_3 = METHOD_3 ( VAR_3 ) ; this . VAR_4 = METHOD_3 ( VAR_4 ) ; }
static import
public TYPE_5 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 , TYPE_3 VAR_4 ) { <START> this . VAR_5 = TYPE_4 . METHOD_1 ( VAR_2 ) ; <END> this . writer = TYPE_4 . METHOD_1 ( VAR_3 ) ; this . VAR_4 = TYPE_4 . METHOD_1 ( VAR_4 ) ; }
public TYPE_5 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 , TYPE_3 VAR_4 ) { this . VAR_5 = METHOD_1 ( VAR_2 ) ; this . writer = METHOD_1 ( VAR_3 ) ; this . VAR_4 = METHOD_1 ( VAR_4 ) ; }
isn t _CODE_
<START> private boolean METHOD_1 ( TYPE_1 VAR_1 , TYPE_1 VAR_2 ) { <END> return VAR_1 . METHOD_2 ( ) . equals ( VAR_2 . METHOD_2 ( ) ) ; }
private boolean METHOD_1 ( TYPE_1 VAR_1 , TYPE_1 VAR_2 ) { return ! VAR_1 . METHOD_2 ( ) . equals ( VAR_2 . METHOD_2 ( ) ) ; }
minor broken lines
private TYPE_1 METHOD_1 ( ) { try { TYPE_2 context ; <START> context = TYPE_2 . METHOD_2 ( STRING_1 ) ; <END> TYPE_3 VAR_1 = context . VAR_2 ( ) ; TYPE_4 factory = TYPE_4 . METHOD_2 ( ) ; factory . VAR_3 ( true ) ; TYPE_1 reader = factory . VAR_4 ( ) . METHOD_3 ( ) ; reader . VAR_5 ( VAR_1 . METHOD_4 ( ) ) ; VAR_1 . ME...
private TYPE_1 METHOD_1 ( ) { try { TYPE_2 context = TYPE_2 . METHOD_2 ( STRING_1 ) ; TYPE_3 VAR_1 = context . VAR_2 ( ) ; TYPE_4 factory = TYPE_4 . METHOD_2 ( ) ; factory . VAR_3 ( true ) ; TYPE_1 reader = factory . VAR_4 ( ) . METHOD_3 ( ) ; reader . VAR_5 ( VAR_1 . METHOD_4 ( ) ) ; VAR_1 . METHOD_5 ( METHOD_6 ( ) ) ...
( [ boolean condition ] ) return boolean ? other news doreturn ! TYPE_2 METHOD_2 ( VAR_1 METHOD_3 ( ) ) ;
private boolean METHOD_1 ( TYPE_1 VAR_1 ) { if ( TYPE_2 . METHOD_2 ( VAR_1 . METHOD_3 ( ) ) ) { return false ; } <START> return true ; <END> }
private boolean METHOD_1 ( TYPE_1 VAR_1 ) { return ! TYPE_2 . METHOD_2 ( VAR_1 . METHOD_3 ( ) ) ; }
another instance returning boolean result a boolean check BAD
private boolean METHOD_1 ( TYPE_1 VAR_1 ) { if ( VAR_1 . METHOD_2 ( ) != null && ! TYPE_2 . METHOD_3 ( VAR_1 . METHOD_2 ( ) . METHOD_4 ( ) ) ) { return true ; } <START> return false ; <END> }
private boolean METHOD_1 ( TYPE_1 VAR_1 ) { return ( VAR_1 . METHOD_2 ( ) != null && ! TYPE_2 . METHOD_3 ( VAR_1 . METHOD_2 ( ) . METHOD_4 ( ) ) ) ; }
VAR_2
public void write ( ByteBuffer buffer ) { buffer . VAR_1 ( offset ) ; <START> buffer . VAR_2 ( ) ; <END> }
public void write ( ByteBuffer buffer ) { buffer . VAR_1 ( offset ) ; }
remove
public TYPE_3 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 , long VAR_4 ) { <START> super ( ) ; <END> this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; this . VAR_4 = VAR_4 ; }
public TYPE_3 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 , long VAR_4 ) { this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; this . VAR_4 = VAR_4 ; }
recursive call pass false a field result
public TYPE_1 METHOD_1 ( Boolean VAR_1 , TYPE_2 VAR_2 ) { <START> VAR_2 . METHOD_2 ( ) . METHOD_3 ( this , VAR_1 ) ; <END> return null ; }
public TYPE_1 METHOD_1 ( Boolean VAR_1 , TYPE_2 VAR_2 ) { VAR_2 . METHOD_2 ( ) . METHOD_3 ( this , false ) ; return null ; }
duplicates initialization location other constructor s called previous line
public TYPE_2 ( ) { this ( ( TYPE_1 ) null ) ; <START> location = null ; <END> }
public TYPE_2 ( ) { this ( ( TYPE_1 ) null ) ; }
declare abstract a default implementation override subclasses _CODE_ a resource ; _CODE_ depending s type ; _CODE_ a resource
<START> public boolean METHOD_1 ( ) { <END> return this . VAR_1 ; }
public boolean METHOD_1 ( ) { return false ; }
private don t want resource attribute set externally
<START> public void METHOD_1 ( boolean VAR_1 ) { <END> this . VAR_1 = VAR_1 ; }
private void METHOD_1 ( boolean VAR_1 ) { this . VAR_1 = VAR_1 ; }
technically bind free variables VAR_2 part VAR_3 VAR_4 else
<START> public Set < String > METHOD_1 ( ) { <END> Set < String > VAR_1 = VAR_2 . METHOD_1 ( ) ; VAR_1 . addAll ( VAR_3 . METHOD_1 ( ) ) ; VAR_1 . remove ( VAR_4 ) ; return VAR_1 ; }
public Set < String > METHOD_1 ( ) { return VAR_2 . METHOD_1 ( ) ; }
definition bound VAR_2 - - - level core IL recursive calls form mymethod ( ) mymethod ( ) [ a sugar work source level translation core ]
public Set < String > METHOD_1 ( ) { Set < String > VAR_1 = VAR_2 . METHOD_1 ( ) ; <START> VAR_1 . remove ( this . getName ( ) ) ; <END> for ( TYPE_1 VAR_3 : VAR_4 ) { VAR_1 . remove ( VAR_3 . getName ( ) ) ; } return VAR_1 ; }
public Set < String > METHOD_1 ( ) { Set < String > VAR_1 = VAR_2 . METHOD_1 ( ) ; for ( TYPE_1 VAR_3 : VAR_4 ) { VAR_1 . remove ( VAR_3 . getName ( ) ) ; } return VAR_1 ; }
instead check String values equal
public boolean equals ( Object obj ) { if ( this == obj ) { return true ; } if ( obj == null ) { return false ; } if ( this . getClass ( ) != obj . getClass ( ) ) { return false ; } try { TYPE_1 VAR_1 = ( TYPE_1 ) obj ; <START> return this . equals ( VAR_1 ) ; <END> } catch ( TYPE_2 e ) { return false ; } }
public boolean equals ( Object obj ) { if ( this == obj ) { return true ; } if ( obj == null ) { return false ; } if ( this . getClass ( ) != obj . getClass ( ) ) { return false ; } try { TYPE_1 VAR_1 = ( TYPE_1 ) obj ; return this . getValue ( ) . equals ( VAR_1 . getValue ( ) ) ; } catch ( TYPE_2 e ) { return false ;...
VAR_1 isEmpty ( ) instead checking size < = 0
private boolean METHOD_1 ( List < TYPE_1 > VAR_1 ) { <START> return VAR_1 . size ( ) <= 0 || VAR_2 >= VAR_1 . size ( ) ; <END> }
private boolean METHOD_1 ( List < TYPE_1 > VAR_1 ) { return VAR_1 . isEmpty ( ) || VAR_2 >= VAR_1 . size ( ) ; }
shouldnt System println / System err println _CODE_ java _CODE_ java indication a serious problem throw exception : )
public TYPE_1 < String > METHOD_1 ( ) { TYPE_2 VAR_1 = new TYPE_2 ( ) ; if ( this . VAR_2 == null ) { <START> System . err . println ( STRING_1 ) ; <END> } VAR_1 . VAR_2 = ( TYPE_3 ) this . VAR_2 . METHOD_1 ( ) ; return VAR_1 ; }
public TYPE_1 < String > METHOD_1 ( ) { TYPE_2 VAR_1 = new TYPE_2 ( ) ; VAR_1 . VAR_2 = ( TYPE_3 ) this . VAR_2 . METHOD_1 ( ) ; return VAR_1 ; }
I d default false - I more sense false
public boolean METHOD_1 ( TYPE_1 response ) { <START> boolean VAR_1 = true ; <END> for ( TYPE_2 VAR_2 : METHOD_2 ( ) ) { VAR_1 = VAR_1 && VAR_2 . METHOD_3 ( response ) ; if ( ! VAR_1 ) break ; } return VAR_1 ; }
public boolean METHOD_1 ( TYPE_1 response ) { if ( METHOD_2 ( ) . isEmpty ( ) ) return false ; boolean VAR_1 = true ; for ( TYPE_2 VAR_2 : METHOD_2 ( ) ) { VAR_1 = VAR_1 && VAR_2 . METHOD_3 ( response ) ; if ( ! VAR_1 ) break ; } return VAR_1 ; }
dont need METHOD_1 ed
public TYPE_1 METHOD_1 ( ) { TYPE_1 VAR_1 = new TYPE_1 ( ) ; List < String > VAR_2 = new ArrayList < > ( VAR_3 ) ; List < String > VAR_4 = new ArrayList < > ( VAR_5 ) ; List < TYPE_2 > VAR_6 = new ArrayList < > ( VAR_7 ) ; <START> List < TYPE_2 > VAR_8 = new ArrayList < > ( VAR_9 ) ; <END> VAR_1 . VAR_9 = VAR_8 ; VAR_1...
public TYPE_1 METHOD_1 ( ) { TYPE_1 VAR_1 = new TYPE_1 ( ) ; List < String > VAR_2 = new ArrayList < > ( VAR_3 ) ; List < String > VAR_4 = new ArrayList < > ( VAR_5 ) ; VAR_1 . VAR_3 = VAR_2 ; VAR_1 . VAR_5 = VAR_4 ; return VAR_1 ; }
I copy / pasted : innocent :
private String VAR_1 ( long VAR_2 ) { long VAR_3 = ( VAR_2 < 0 ) ? - VAR_2 : VAR_2 ; int VAR_4 = ( int ) ( ( VAR_3 / ( INT_1 * INT_2 ) ) % INT_2 ) ; int VAR_5 = ( int ) ( ( VAR_3 / ( INT_1 * INT_2 * INT_2 ) ) % INT_3 ) ; <START> return String . format ( STRING_1 , VAR_2 >= 0 ? CHAR_1 : CHAR_2 , VAR_5 , VAR_4 ) <END> }
private String VAR_1 ( long VAR_2 ) { long VAR_3 = ( VAR_2 < 0 ) ? - VAR_2 : VAR_2 ; int VAR_4 = ( int ) ( ( VAR_3 / ( INT_1 * INT_2 ) ) % INT_2 ) ; int VAR_5 = ( int ) ( ( VAR_3 / ( INT_1 * INT_2 * INT_2 ) ) % INT_3 ) ; return String . format ( STRING_1 , VAR_2 >= 0 ? CHAR_1 : CHAR_2 , VAR_5 , VAR_4 ) ; }
creates a TYPE_6 table copy n paste ? ; - )
public TYPE_8 ( String VAR_2 , TYPE_1 client ) { <START> super ( new TYPE_2 < TYPE_5 . TYPE_7 > ( client , TYPE_5 . TYPE_6 . METHOD_1 ( VAR_2 ) ) ) ; <END> }
public TYPE_8 ( String VAR_2 , TYPE_1 client ) { super ( new TYPE_2 < TYPE_5 . TYPE_7 > ( client , TYPE_5 . TYPE_7 . METHOD_1 ( VAR_2 ) ) ) ; }
don t METHOD_2 instead test expected outcome _CODE_ ( new TYPE_1 ( TYPE_3 VAR_2 true new TYPE_2 ( ) ) ( ) ( new TYPE_2 ( ) ( ) | TYPE_3 VAR_2 ) ) ; assertThat ( new TYPE_1 ( TYPE_3 VAR_2 false new TYPE_2 ( ) ) ( ) ( new TYPE_2 ( ) ( ) ) ) ;
public void METHOD_1 ( ) { <START> assertTrue ( METHOD_2 ( <END> new TYPE_1 ( TYPE_3 . VAR_2 , true , new TYPE_2 ( ) ) . value ( ) , TYPE_3 . VAR_2 ) ) ; METHOD_3 ( METHOD_2 ( new TYPE_1 ( TYPE_3 . VAR_2 , false , new TYPE_2 ( ) ) . value ( ) , TYPE_3 . VAR_2 ) ) ; }
public void METHOD_1 ( ) { assertThat ( new TYPE_1 ( TYPE_3 . VAR_2 , true , new TYPE_2 ( ) ) . value ( ) , is ( new TYPE_2 ( ) . value ( ) | TYPE_3 . VAR_2 ) ) ; assertThat ( new TYPE_1 ( TYPE_3 . VAR_2 , false , new TYPE_2 ( ) ) . value ( ) , is ( new TYPE_2 ( ) . value ( ) ) ) ; }
accidental copy & paste error
protected double METHOD_1 ( double VAR_1 ) { <START> return VAR_1 / VAR_2 ; LOG . error ( STRING_1 , TYPE_1 . this . getClass ( ) . METHOD_2 ( ) , ex ) ; <END> }
protected double METHOD_1 ( double VAR_1 ) { return VAR_1 / VAR_2 ; }
VAR_2 isEmpty ( )
public String METHOD_1 ( TYPE_1 VAR_1 ) { final String VAR_2 = VAR_1 . METHOD_2 ( ) ; <START> if ( VAR_2 == null || VAR_2 . length ( ) == 0 ) { <END> return STRING_1 ; } return null ; }
public String METHOD_1 ( TYPE_1 VAR_1 ) { final String VAR_2 = VAR_1 . METHOD_2 ( ) ; return VAR_2 == null || VAR_2 . isEmpty ( ) ? STRING_1 : null ; }
reading mutable fields synchronization trim put mutation : - VAR_6 - VAR_7 - _CODE_ result totaly wrong negative
private int METHOD_1 ( TYPE_1 < TYPE_2 > VAR_1 ) { TYPE_2 VAR_2 ; VAR_3 . METHOD_2 ( ) ; try { VAR_2 = VAR_4 ; } finally { VAR_3 . METHOD_3 ( ) ; } int VAR_5 = 0 ; while ( true ) { VAR_5 += VAR_2 . VAR_6 - VAR_2 . VAR_7 ; if ( VAR_1 != null ) { VAR_1 . METHOD_4 ( VAR_2 ) ; } if ( VAR_2 . VAR_8 == null ) { break ; } <ST...
private int METHOD_1 ( TYPE_1 < TYPE_2 > VAR_1 ) { TYPE_2 VAR_2 = VAR_4 ; int VAR_5 = 0 ; while ( true ) { VAR_5 += VAR_2 . VAR_6 - VAR_2 . VAR_7 ; if ( VAR_1 != null ) { VAR_1 . METHOD_4 ( VAR_2 ) ; } if ( VAR_2 . VAR_8 == null ) { break ; } VAR_2 = VAR_2 . VAR_8 ; } return VAR_5 ; }
I s dereference channel a finally block case METHOD_1 failed close
public void close ( ) throws IOException { VAR_1 . METHOD_1 ( ) . close ( ) ; <START> VAR_1 = null ; <END> }
public void close ( ) throws IOException { try { VAR_1 . METHOD_1 ( ) . close ( ) ; } finally { VAR_1 = null ; } }
another method instances TYPE_1 ? I dropwizard a metrics VAR_2 created framework I instance default proposed : _CODE_ add ( default bootstrap _CODE_ ( ) ) ; _CODE_ METHOD_1 ( default ) ; overloaded METHOD_1 method _CODE_ METHOD_1 ( default bootstrap _CODE_ ( ) ) ;
<START> public synchronized static TYPE_1 METHOD_1 ( String name ) { <END> if ( VAR_1 == null ) { final TYPE_1 VAR_2 = METHOD_2 ( name ) ; VAR_1 = name ; return VAR_2 ; } throw new IllegalStateException ( STRING_1 ) ; }
public synchronized static TYPE_1 METHOD_1 ( String name ) { final TYPE_1 VAR_2 = METHOD_2 ( name ) ; return METHOD_1 ( name , VAR_2 ) ; }
IMO
public void add ( Entry entry ) { <START> if ( VAR_1 . size ( ) >= VAR_2 ) { <END> VAR_1 . METHOD_1 ( ) ; } VAR_1 . add ( entry ) ; }
public void add ( Entry entry ) { while ( VAR_1 . size ( ) >= VAR_2 ) { VAR_1 . METHOD_1 ( ) ; } VAR_1 . add ( entry ) ; }
build fails TYPE_6 java : [ 72 21 ] call statement constructor fix : javathis ( VAR_3 filter VAR_5 VAR_6 TYPE_4 VAR_10 ( new TYPE_2 ( + CHAR_1 + VAR_12 VAR_13 ( ) ) ) ) ;
protected TYPE_6 ( TYPE_3 VAR_3 , String name , TYPE_5 filter , TimeUnit VAR_5 , TimeUnit VAR_6 ) { TYPE_1 VAR_8 = TYPE_4 . VAR_10 ( new TYPE_2 ( name + CHAR_1 + VAR_12 . VAR_13 ( ) ) ) ; <START> this ( VAR_3 , name , filter , VAR_5 , VAR_6 , VAR_8 ) ; <END> }
protected TYPE_6 ( TYPE_3 VAR_3 , String name , TYPE_5 filter , TimeUnit VAR_5 , TimeUnit VAR_6 ) { this ( VAR_3 , name , filter , VAR_5 , VAR_6 , TYPE_4 . VAR_10 ( new TYPE_2 ( name + CHAR_1 + VAR_12 . VAR_13 ( ) ) ) ) ; }
final VAR_1 dealing creating a list capacity
private < T > Collection < ? extends TYPE_1 < T > > METHOD_1 ( Collection < ? extends TYPE_1 < T > > VAR_1 ) { <START> List < TYPE_2 < T > > VAR_2 = new ArrayList < TYPE_2 < T > > ( ) ; <END> for ( TYPE_1 < T > task : VAR_1 ) { VAR_2 . add ( new TYPE_2 ( task ) ) ; } return VAR_2 ; }
private < T > Collection < ? extends TYPE_1 < T > > METHOD_1 ( Collection < ? extends TYPE_1 < T > > VAR_1 ) { final List < TYPE_2 < T > > VAR_2 = new ArrayList < TYPE_2 < T > > ( VAR_1 . size ( ) ) ; for ( TYPE_1 < T > task : VAR_1 ) { VAR_2 . add ( new TYPE_2 ( task ) ) ; } return VAR_2 ; }
final
public void run ( ) { VAR_1 . METHOD_1 ( ) ; <START> TYPE_1 . Context context = VAR_2 . time ( ) ; <END> try { task . run ( ) ; } finally { context . VAR_3 ( ) ; VAR_1 . METHOD_2 ( ) ; VAR_4 . METHOD_3 ( ) ; } }
public void run ( ) { VAR_1 . METHOD_1 ( ) ; final TYPE_1 . Context context = VAR_2 . time ( ) ; try { task . run ( ) ; } finally { context . VAR_3 ( ) ; VAR_1 . METHOD_2 ( ) ; VAR_4 . METHOD_3 ( ) ; } }
final
public T call ( ) throws Exception { VAR_1 . METHOD_1 ( ) ; <START> TYPE_1 . Context context = VAR_2 . time ( ) ; <END> try { return VAR_3 . call ( ) ; } finally { context . VAR_4 ( ) ; VAR_1 . METHOD_2 ( ) ; VAR_5 . METHOD_3 ( ) ; } }
public T call ( ) throws Exception { VAR_1 . METHOD_1 ( ) ; final TYPE_1 . Context context = VAR_2 . time ( ) ; try { return VAR_3 . call ( ) ; } finally { context . VAR_4 ( ) ; VAR_1 . METHOD_2 ( ) ; VAR_5 . METHOD_3 ( ) ; } }
( VAR_3 getClass ( ) )
public TYPE_3 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 ) { <START> this ( VAR_2 , VAR_3 , VAR_3 . getClass ( ) . getName ( ) ) ; <END> }
public TYPE_3 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 ) { this ( VAR_2 , VAR_3 , name ( VAR_3 . getClass ( ) ) ) ; }
I cleaner TYPE_3 TYPE_2 VAR_4 defined factory constructor _CODE_ TYPE_1 map underlying type making a shortcut responsibility os class _CODE_ else
public static TYPE_1 METHOD_1 ( ) { <START> return new TYPE_1 ( METHOD_2 ( VAR_1 ) , TYPE_3 . TYPE_2 . VAR_4 ) ; <END> }
public static TYPE_1 METHOD_1 ( ) { return new TYPE_1 ( METHOD_2 ( VAR_1 ) ) ; }
public feels problematic classes need call don t live io realm
<START> public void METHOD_1 ( long version ) { <END> TYPE_1 . METHOD_2 ( VAR_1 , version ) ; }
void METHOD_1 ( long version ) { TYPE_1 . METHOD_2 ( VAR_1 , version ) ; }
intended calling multiple times trigger multiple remote operations ? I a bit confused _collection / iterable_ terms
<START> public TYPE_1 < TYPE_2 < TYPE_3 > > iterator ( ) { <END> return VAR_1 . METHOD_1 ( ( ) - > new TYPE_2 < > ( METHOD_2 ( ) . iterator ( ) , VAR_1 ) ) ; }
public TYPE_1 < TYPE_2 < TYPE_3 > > iterator ( ) { return VAR_1 . METHOD_1 ( ( ) - > new TYPE_2 < > ( METHOD_2 ( ) . iterator ( ) ) ) ; }
annotate METHOD_2 call a static _CODE_ user = TYPE_4 METHOD_2 ( VAR_1 ) ;
public void METHOD_1 ( ) { VAR_1 = new TYPE_1 ( ) ; <START> TYPE_2 user = TYPE_4 . TYPE_5 . METHOD_2 ( VAR_1 ) ; <END> config = VAR_2 . METHOD_3 ( user ) . build ( ) ; }
public void METHOD_1 ( ) { VAR_1 = new TYPE_1 ( ) ; TYPE_2 user = TYPE_4 . METHOD_2 ( VAR_1 ) ; config = VAR_2 . METHOD_3 ( user ) . build ( ) ; }
closing _CODE_
public void METHOD_1 ( ) throws InterruptedException { final TYPE_1 VAR_1 = METHOD_2 ( VAR_2 ) ; Thread t = new Thread ( ( ) - > { TYPE_2 < TYPE_3 > results = VAR_1 . METHOD_3 ( TYPE_3 . class ) . METHOD_4 ( ) ; assertEquals ( VAR_2 , results . size ( ) ) ; } ) ; t . start ( ) ; t . VAR_3 ( ) ; <START> VAR_1 . close ( ...
public void METHOD_1 ( ) throws InterruptedException { final TYPE_1 VAR_1 = METHOD_2 ( VAR_2 ) ; Thread t = new Thread ( ( ) - > { TYPE_2 < TYPE_3 > results = VAR_1 . METHOD_3 ( TYPE_3 . class ) . METHOD_4 ( ) ; assertEquals ( VAR_2 , results . size ( ) ) ; } ) ; t . start ( ) ; t . VAR_3 ( ) ; }
public
<START> public void METHOD_1 ( TYPE_1 VAR_1 ) { <END> new TYPE_2 ( this , VAR_1 , VAR_2 ) ; }
void METHOD_1 ( TYPE_1 VAR_1 ) { new TYPE_2 ( this , VAR_1 , VAR_2 ) ; }
public ? call JNI s private
<START> public long METHOD_1 ( ) { <END> return table . VAR_1 ( ) ; }
private long METHOD_1 ( ) { return table . VAR_1 ( ) ; }
null code _CODE_
public int METHOD_1 ( ) { <START> return VAR_1 == null ? 0 : VAR_1 . size ( ) ; <END> }
public int METHOD_1 ( ) { return VAR_1 . size ( ) ; }
support java 8 examples feel free lamdas
private void METHOD_1 ( ) { VAR_1 = METHOD_2 ( R . id . VAR_1 ) ; VAR_1 . METHOD_3 ( new View . TYPE_1 ( ) { @Override <START> public void METHOD_4 ( View v ) { <END> if ( ! VAR_3 . METHOD_5 ( ) ) { VAR_3 . start ( ) ; } else { VAR_3 . METHOD_6 ( ) ; } METHOD_7 ( ) ; } } ) ; }
private void METHOD_1 ( ) { VAR_1 = METHOD_2 ( R . id . VAR_1 ) ; VAR_1 . METHOD_3 ( v - > { if ( ! VAR_3 . METHOD_5 ( ) ) { VAR_3 . start ( ) ; } else { VAR_3 . METHOD_6 ( ) ; } METHOD_7 ( ) ; } ) ; }
closed TYPE_2 thrown
private static TYPE_1 METHOD_1 ( String VAR_1 ) throws IOException , TYPE_2 { TYPE_3 stream = new TYPE_4 ( VAR_1 . METHOD_2 ( STRING_1 ) ) ; TYPE_1 VAR_2 = ( TYPE_1 ) TYPE_5 . METHOD_3 ( stream ) ; <START> stream . close ( ) ; <END> return VAR_2 ; }
private static TYPE_1 METHOD_1 ( String VAR_1 ) throws IOException , TYPE_2 { TYPE_3 stream = null ; try { stream = new TYPE_4 ( VAR_1 . METHOD_2 ( STRING_1 ) ) ; return ( TYPE_1 ) TYPE_5 . METHOD_3 ( stream ) ; } finally { if ( stream != null ) { stream . close ( ) ; } } }
minor suggestion / subjective : rid nesting : javaif ( VAR_1 ! = null ) { return VAR_1 ; } ( = = null ) { return VAR_2 ; } ( version = = null ) { return ; } return + STRING_1 + version ;
public String METHOD_1 ( ) { if ( VAR_1 == null ) { if ( name != null ) { if ( version != null ) { return name + STRING_1 + version ; } else { return name ; } } else { return this . VAR_2 ; <START> } <END> } return this . VAR_1 ; }
public String METHOD_1 ( ) { if ( VAR_1 != null ) { return VAR_1 ; } if ( name == null ) { return VAR_2 ; } if ( version == null ) { return name ; } return name + STRING_1 + version ; }
treat CHAR_1 a string need add a && VAR_1 length ( ) > 1
private static boolean METHOD_1 ( final String VAR_1 ) { if ( VAR_1 == null || VAR_1 . isEmpty ( ) ) { return false ; } <START> if ( VAR_1 . METHOD_2 ( 0 ) == CHAR_1 ) { <END> return false ; } for ( int i = 0 ; i < VAR_1 . length ( ) ; i ++ ) { final char c = VAR_1 . METHOD_2 ( i ) ; if ( c < CHAR_1 || c > CHAR_2 ) { r...
static boolean METHOD_1 ( final String VAR_1 ) { if ( VAR_1 == null || VAR_1 . isEmpty ( ) ) { return false ; } if ( VAR_1 . METHOD_2 ( 0 ) == CHAR_1 && VAR_1 . length ( ) > 1 ) { return false ; } for ( int i = 0 ; i < VAR_1 . length ( ) ; i ++ ) { final char c = VAR_1 . METHOD_2 ( i ) ; if ( c < CHAR_1 || c > CHAR_2 )...
transaction mandatory kind error show case a transaction present ? s clear enough improve a separate issue
public Object METHOD_1 ( ) { <START> return VAR_1 != null ? VAR_1 . getId ( ) : null ; <END> }
public Object METHOD_1 ( ) { return VAR_1 . getId ( ) ; }
critical I find counter intuitive lookup method clear move start method
private void METHOD_1 ( ) { try { log . VAR_1 ( STRING_1 , config . VAR_2 ( ) ) ; VAR_3 = ( TYPE_1 ) VAR_4 . METHOD_2 ( config . VAR_2 ( ) ) ; } catch ( RuntimeException e ) { throw log . VAR_5 ( config . VAR_2 ( ) ) ; } <START> this . VAR_4 = null ; <END> }
private void METHOD_1 ( ) { try { log . VAR_1 ( STRING_1 , config . VAR_2 ( ) ) ; VAR_3 = ( TYPE_1 ) VAR_4 . METHOD_2 ( config . VAR_2 ( ) ) ; } catch ( RuntimeException e ) { throw log . VAR_5 ( config . VAR_2 ( ) ) ; } }
critical I find counter intuitive lookup method clear move start method
private void METHOD_1 ( ) { try { log . VAR_1 ( STRING_1 , configuration . VAR_2 ( ) ) ; TYPE_1 VAR_3 = ( TYPE_1 ) VAR_4 . METHOD_2 ( configuration . VAR_2 ( ) ) ; this . client = new TYPE_2 ( VAR_3 ) ; } catch ( RuntimeException e ) { throw log . VAR_5 ( configuration . VAR_2 ( ) ) ; } <START> this . VAR_4 = null ; <E...
private void METHOD_1 ( ) { try { log . VAR_1 ( STRING_1 , configuration . VAR_2 ( ) ) ; TYPE_1 VAR_3 = ( TYPE_1 ) VAR_4 . METHOD_2 ( configuration . VAR_2 ( ) ) ; this . client = new TYPE_2 ( VAR_3 ) ; } catch ( RuntimeException e ) { throw log . VAR_5 ( configuration . VAR_2 ( ) ) ; } }
class integration tests module server a file system position
public void METHOD_1 ( ) throws Exception { synchronized ( VAR_1 ) { if ( VAR_1 . METHOD_2 ( false , true ) ) { <START> TYPE_1 . METHOD_3 ( ) ; <END> TYPE_2 builder = TYPE_2 . of ( STRING_1 ) ; builder . VAR_2 ( VAR_3 ) ; if ( VAR_4 != 0 ) { builder . VAR_5 ( STRING_2 + VAR_4 ) ; } TYPE_3 VAR_6 = TYPE_3 . of ( builder ...
public void METHOD_1 ( ) throws Exception { synchronized ( VAR_1 ) { if ( VAR_1 . METHOD_2 ( false , true ) ) { TYPE_2 builder = TYPE_2 . of ( STRING_1 ) ; builder . VAR_2 ( VAR_3 ) ; if ( VAR_4 != 0 ) { builder . VAR_5 ( STRING_2 + VAR_4 ) ; } TYPE_3 VAR_6 = TYPE_3 . of ( builder ) ; VAR_7 = VAR_6 . METHOD_5 ( ) ; MET...
wondering fix test s a good example done tests s worth fixing
public void METHOD_1 ( ) { try { if ( ! VAR_1 . METHOD_2 ( ) . METHOD_3 ( ) ) { VAR_1 . METHOD_2 ( ) . METHOD_4 ( ) ; <START> } <END> TYPE_1 VAR_2 = VAR_1 . METHOD_5 ( TYPE_1 . class , VAR_3 . getName ( ) ) ; if ( VAR_2 != null ) { VAR_1 . remove ( VAR_2 ) ; } VAR_1 . METHOD_2 ( ) . commit ( ) ; } finally { VAR_1 . clo...
public void METHOD_1 ( ) { try { VAR_1 . METHOD_2 ( ) . METHOD_4 ( ) ; TYPE_1 VAR_2 = VAR_1 . METHOD_5 ( TYPE_1 . class , VAR_3 . getName ( ) ) ; if ( VAR_2 != null ) { VAR_1 . remove ( VAR_2 ) ; } VAR_1 . METHOD_2 ( ) . commit ( ) ; } finally { VAR_1 . close ( ) ; } }
I t a difference 2 codes
private void METHOD_1 ( ) { if ( VAR_1 == null ) { Class < TYPE_1 < ? > > VAR_2 = VAR_3 . METHOD_2 ( ) ; <START> this . VAR_1 = VAR_2 . METHOD_3 ( ) ; <END> if ( VAR_1 == null ) { throw new TYPE_2 ( STRING_1 ) ; } } }
private void METHOD_1 ( ) { if ( VAR_1 == null ) { Class < ? extends TYPE_1 < ? > > VAR_2 = VAR_3 . METHOD_2 ( ) ; this . VAR_1 = VAR_2 . METHOD_3 ( ) ; if ( VAR_1 == null ) { throw new TYPE_2 ( STRING_1 ) ; } } }
remember remove
public List METHOD_1 ( ) { <START> log . info ( STRING_1 ) ; <END> if ( METHOD_2 ( ) ) { return VAR_1 ; } return null ; }
public List METHOD_1 ( ) { if ( METHOD_2 ( ) ) { return VAR_1 ; } return null ; }
s add instead beginning s common other operations
public TYPE_1 METHOD_1 ( ) { <START> return METHOD_2 ( METHOD_3 ( ) , METHOD_4 ( ) , METHOD_5 ( ) , METHOD_6 ( ) , METHOD_7 ( ) , METHOD_8 ( ) , METHOD_9 ( ) , METHOD_10 ( ) ) ; <END> }
public TYPE_1 METHOD_1 ( ) { return METHOD_2 ( METHOD_4 ( ) , METHOD_5 ( ) , METHOD_6 ( ) , METHOD_7 ( ) , METHOD_8 ( ) , METHOD_9 ( ) , METHOD_10 ( ) , METHOD_3 ( ) ) ; }
remove useless super ( )
public TYPE_2 ( TYPE_1 VAR_2 , String VAR_3 ) { <START> super ( ) ; <END> this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; }
public TYPE_2 ( TYPE_1 VAR_2 , String VAR_3 ) { this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; }
returned
private Object METHOD_1 ( TYPE_1 VAR_1 , String VAR_2 ) { Object value = null ; <START> VAR_1 . METHOD_2 ( ) ; <END> if ( VAR_1 . METHOD_3 ( VAR_2 ) ) { value = VAR_1 . getProperty ( VAR_2 ) ; } return value ; }
private Object METHOD_1 ( TYPE_1 VAR_1 , String VAR_2 ) { Object value = null ; if ( VAR_1 . METHOD_3 ( VAR_2 ) ) { value = VAR_1 . getProperty ( VAR_2 ) ; } return value ; }
remove System ? unecessary
public void METHOD_1 ( ) { <START> System . out . println ( STRING_1 ) ; <END> String [ ] VAR_1 = new String [ ] { STRING_2 , STRING_3 , STRING_4 } ; int VAR_2 = 0 ; int length = 2 ; String [ ] VAR_3 = new String [ ] { STRING_2 , STRING_3 } ; String [ ] result = TYPE_1 . METHOD_2 ( VAR_1 , VAR_2 , length ) ; METHOD_3 (...
public void METHOD_1 ( ) { String [ ] VAR_1 = new String [ ] { STRING_2 , STRING_3 , STRING_4 } ; int VAR_2 = 0 ; int length = 2 ; String [ ] VAR_3 = new String [ ] { STRING_2 , STRING_3 } ; String [ ] result = TYPE_1 . METHOD_2 ( VAR_1 , VAR_2 , length ) ; METHOD_3 ( VAR_3 , result ) ; }
builder VAR_1 ( ) invoked TYPE_2 ( ) I don t need
public TYPE_1 METHOD_1 ( ) { return METHOD_2 ( <START> METHOD_3 ( METHOD_4 ( ) , builder . VAR_1 ( TYPE_2 . VAR_3 ) ) , <END> METHOD_3 ( METHOD_5 ( ) , builder . VAR_1 ( TYPE_2 . VAR_4 ) ) ) ; }
public TYPE_1 METHOD_1 ( ) { return METHOD_2 ( METHOD_4 ( ) , METHOD_5 ( ) ) ; }
JSON ? I missing I d sense transaction semantics write rows association
public void METHOD_1 ( TYPE_1 key , TYPE_2 VAR_1 ) { byte [ ] VAR_2 = METHOD_2 ( key ) ; connection . VAR_3 ( VAR_2 ) ; for ( Object row : VAR_1 . METHOD_3 ( ) ) { <START> connection . VAR_4 ( VAR_2 , VAR_5 . METHOD_4 ( row ) ) ; <END> } }
private void METHOD_1 ( TYPE_1 key , TYPE_2 VAR_1 ) { byte [ ] VAR_2 = METHOD_2 ( key ) ; connection . VAR_3 ( VAR_2 ) ; for ( Object row : VAR_1 . METHOD_3 ( ) ) { connection . VAR_4 ( VAR_2 , VAR_5 . METHOD_4 ( row ) ) ; } }
handling specific implementation _entitymanagerimpl class_ METHOD_2 ( ) implementation TYPE_1 work METHOD_2 ( ) able cast _entitymanager_ ( interface ) works actual implementation _entitymanagerimpl_ shouldn t cast explicitly
public TYPE_1 METHOD_1 ( ) { <START> return new TYPE_2 ( this , VAR_1 . METHOD_1 ( ) . METHOD_2 ( TYPE_3 . class ) ) ; <END> }
public TYPE_1 METHOD_1 ( ) { return new TYPE_2 ( this , ( TYPE_3 ) VAR_1 . METHOD_1 ( ) ) ; }
strange indentation method parameters happend ? : )
public static TYPE_1 < ? , ? , ? > METHOD_1 ( TYPE_2 VAR_1 , TYPE_3 VAR_2 , TYPE_4 VAR_3 , Set < TYPE_5 > VAR_4 , <START> Set < TYPE_6 > VAR_5 , <END> Set < TYPE_7 > VAR_6 ) { TYPE_8 VAR_7 = new TYPE_8 ( ) ; TYPE_9 VAR_8 = VAR_1 != null ? new TYPE_9 ( VAR_1 , VAR_4 , VAR_5 , VAR_6 ) : new TYPE_9 ( VAR_2 , VAR_3 , VAR_4...
private static TYPE_1 < ? , ? , ? > METHOD_1 ( TYPE_2 VAR_1 , TYPE_3 VAR_2 , TYPE_4 VAR_3 , Set < TYPE_5 > VAR_4 , Set < TYPE_6 > VAR_5 , Set < TYPE_7 > VAR_6 ) { TYPE_8 VAR_7 = new TYPE_8 ( ) ; TYPE_9 VAR_8 = VAR_1 != null ? new TYPE_9 ( VAR_1 , VAR_4 , VAR_5 , VAR_6 ) : new TYPE_9 ( VAR_2 , VAR_3 , VAR_4 , VAR_5 , VA...
I m wondering triggered schema initializer couldn t done dialect construction ? schema initializer create / update persistent structures datastore avoid need _CODE_ ( ) method
public void METHOD_1 ( TYPE_1 configuration , TYPE_2 factory ) { TYPE_2 VAR_1 = factory ; TYPE_3 VAR_2 = VAR_1 . METHOD_2 ( ) ; TYPE_4 VAR_3 = ( TYPE_4 ) VAR_2 . METHOD_3 ( TYPE_5 . class ) ; METHOD_4 ( VAR_1 , VAR_3 ) ; METHOD_5 ( VAR_3 . METHOD_6 ( ) , configuration ) ; <START> METHOD_7 ( VAR_1 , VAR_2 ) ; <END> }
public void METHOD_1 ( TYPE_1 configuration , TYPE_2 factory ) { TYPE_2 VAR_1 = factory ; TYPE_3 VAR_2 = VAR_1 . METHOD_2 ( ) ; TYPE_4 VAR_3 = ( TYPE_4 ) VAR_2 . METHOD_3 ( TYPE_5 . class ) ; METHOD_4 ( VAR_1 , VAR_3 ) ; METHOD_5 ( VAR_3 . METHOD_6 ( ) , configuration ) ; }
a test passing wrong type creating a typed query
public void METHOD_1 ( ) throws Exception { <START> List < TYPE_1 > VAR_1 = VAR_2 . METHOD_2 ( STRING_1 , TYPE_1 . class ) <END> . METHOD_3 ( ) ; TYPE_2 . assertThat ( VAR_1 . size ( ) ) . METHOD_4 ( 2 ) ; }
public void METHOD_1 ( ) throws Exception { List < TYPE_1 > VAR_1 = VAR_2 . METHOD_2 ( STRING_1 , TYPE_1 . class ) . METHOD_3 ( ) ; assertThat ( VAR_1 . size ( ) ) . METHOD_4 ( 2 ) ; }
I List < TYPE_1 >
public List < TYPE_1 > METHOD_1 ( ) { <START> ArrayList < TYPE_1 > VAR_1 = new ArrayList < TYPE_1 > ( ) ; <END> if ( VAR_2 . size ( ) > 0 ) { for ( TYPE_2 row : VAR_2 ) { VAR_1 . add ( new TYPE_1 ( new TYPE_3 ( row . getValue ( ) . METHOD_2 ( ) ) ) ) ; } } return VAR_1 ; }
public List < TYPE_1 > METHOD_1 ( ) { List < TYPE_1 > VAR_1 = new ArrayList < TYPE_1 > ( VAR_2 . size ( ) ) ; if ( VAR_2 . size ( ) > 0 ) { for ( TYPE_2 row : VAR_2 ) { VAR_1 . add ( new TYPE_1 ( new TYPE_3 ( row . getValue ( ) . METHOD_2 ( ) ) ) ) ; } } return VAR_1 ; }
s a interesting debate TYPE_3 mutually exclusive startable ? sense lose call super manageable startable TYPE_3 don t sense simply call super super METHOD_1
public < R extends TYPE_1 > void METHOD_1 ( TYPE_2 < R > VAR_1 ) { <START> if ( TYPE_3 . class . METHOD_2 ( VAR_1 . METHOD_3 ( ) ) ) { <END> ( ( TYPE_3 ) VAR_1 . METHOD_3 ( ) ) . start ( configuration , VAR_2 ) ; } else { super . METHOD_1 ( VAR_1 ) ; } }
public < R extends TYPE_1 > void METHOD_1 ( TYPE_2 < R > VAR_1 ) { super . METHOD_1 ( VAR_1 ) ; if ( TYPE_3 . class . METHOD_2 ( VAR_1 . METHOD_3 ( ) ) ) { ( ( TYPE_3 ) VAR_1 . METHOD_3 ( ) ) . start ( configuration , VAR_2 ) ; } }
thrown generates exception
public TYPE_2 ( ) { try { Class . VAR_2 ( STRING_1 ) ; } catch ( TYPE_1 e ) { <START> log . VAR_3 ( STRING_1 ) ; <END> } }
public TYPE_2 ( ) { try { Class . VAR_2 ( STRING_1 ) ; } catch ( TYPE_1 e ) { throw log . VAR_3 ( STRING_1 ) ; } }
shouldn t return null ? I don t API return Object a meaning : )
public Object get ( String column ) { TYPE_1 result = VAR_1 . get ( column ) ; if ( result == null ) { return VAR_2 . get ( column ) ; } else if ( result . getType ( ) == VAR_3 || result . getType ( ) == VAR_4 ) { <START> return result ; <END> } else { return result . getValue ( ) ; } }
public Object get ( String column ) { TYPE_1 result = VAR_1 . get ( column ) ; if ( result == null ) { return VAR_2 . get ( column ) ; } else if ( result . getType ( ) == VAR_3 || result . getType ( ) == VAR_4 ) { return null ; } else { return result . getValue ( ) ; } }
want else ? ( I ll reading )
public void METHOD_1 ( TYPE_1 VAR_1 ) { final Boolean VAR_2 = VAR_1 . VAR_3 . METHOD_2 ( STRING_1 ) ; if ( VAR_2 == null || ! VAR_2 . METHOD_3 ( ) ) { VAR_4 . add ( VAR_1 ) ; } <START> METHOD_4 ( VAR_1 . METHOD_5 ( ) ) ; <END> }
public void METHOD_1 ( TYPE_1 VAR_1 ) { final Boolean VAR_2 = VAR_1 . VAR_3 . METHOD_2 ( STRING_1 ) ; if ( VAR_2 != null && VAR_2 . METHOD_3 ( ) ) { METHOD_4 ( VAR_1 . METHOD_5 ( ) ) ; } else { VAR_4 . add ( VAR_1 ) ; } }
I suggest sibling _CODE_ final
<START> protected final TYPE_1 METHOD_1 ( ) { <END> return METHOD_1 ( this . METHOD_2 ( ) ) ; }
protected TYPE_1 METHOD_1 ( ) { return METHOD_1 ( this . METHOD_2 ( ) ) ; }
careful throw a _CODE_ getString a _CODE_ calling METHOD_1 result VAR_3 I d inclined wrap : { … } catch ( Exception e ) { throw new IllegalArgumentException ( … ) ; / / rethrow } a suitable bad JSON input beats a random NPE a missing version
public TYPE_3 ( TYPE_1 object ) throws TYPE_2 { this . VAR_2 = object . getString ( STRING_1 ) ; <START> this . version = object . VAR_3 ( STRING_2 ) . METHOD_1 ( ) ; <END> }
public TYPE_3 ( TYPE_1 object ) { try { this . VAR_2 = object . getString ( STRING_1 ) ; this . version = object . VAR_3 ( STRING_2 ) . METHOD_1 ( ) ; } catch ( Exception e ) { throw new IllegalArgumentException ( e ) ; } }
inline VAR_1
protected void METHOD_1 ( TYPE_1 record ) throws TYPE_2 , TYPE_3 , TYPE_4 { TYPE_5 VAR_1 = ( TYPE_5 ) METHOD_2 ( record ) ; <START> METHOD_3 ( VAR_1 ) ; <END> }
protected void METHOD_1 ( TYPE_1 record ) throws TYPE_2 , TYPE_3 , TYPE_4 { METHOD_3 ( ( TYPE_5 ) METHOD_2 ( record ) ) ; }
please key SEPARATOR STRING_1
public String read ( TYPE_1 record ) { TYPE_2 VAR_1 = new TYPE_2 ( ) ; TYPE_3 VAR_2 = new TYPE_3 ( ) ; String VAR_3 = record . VAR_4 ( ) . toString ( ) ; String VAR_5 = VAR_1 . read ( record ) ; String client = VAR_2 . read ( record ) ; <START> return VAR_3 + STRING_1 + VAR_5 + STRING_1 + client ; <END> }
public String read ( TYPE_1 record ) { Long VAR_3 = record . VAR_4 ( ) ; String VAR_5 = ( new TYPE_2 ( ) ) . read ( record ) ; String client = ( new TYPE_3 ( ) ) . read ( record ) ; return Long . toString ( VAR_3 ) + STRING_1 + VAR_5 + STRING_1 + client ; }
_CODE_ I don t want please leave _CODE_ unchanged
private void METHOD_1 ( ) { if ( VAR_1 . METHOD_2 ( ) ) { METHOD_3 ( ) ; return ; } String VAR_2 = VAR_3 . METHOD_4 ( ) . toString ( ) ; TYPE_1 VAR_4 = VAR_5 . METHOD_5 ( VAR_2 ) ; <START> if ( VAR_4 == null ) { <END> VAR_4 = VAR_6 . METHOD_5 ( VAR_2 ) ; } if ( VAR_4 != null ) { METHOD_6 ( VAR_4 ) ; } else { METHOD_3 (...
private void METHOD_1 ( ) { if ( VAR_1 . METHOD_2 ( ) ) { METHOD_3 ( ) ; return ; } String VAR_2 = VAR_3 . METHOD_4 ( ) . toString ( ) ; TYPE_1 VAR_4 = VAR_5 . METHOD_5 ( VAR_2 ) ; if ( VAR_4 != null ) { METHOD_6 ( VAR_4 ) ; } else { METHOD_3 ( ) ; } }
want match a specific _CODE_ eq ( ) : suggestioneq ( TYPE_6 TYPE_7 VAR_5 ) ) ) METHOD_7 s need call getClass ( ) instance write : suggestionany ( TYPE_6 TYPE_7 class ) ) )
private TYPE_1 METHOD_1 ( TYPE_2 VAR_1 , TYPE_3 . Builder builder ) { TYPE_1 VAR_2 = METHOD_2 ( TYPE_1 . class ) ; when ( VAR_2 . METHOD_3 ( ) ) . METHOD_4 ( TYPE_8 . VAR_4 ) ; when ( VAR_2 . METHOD_5 ( ) ) . METHOD_4 ( VAR_1 ) ; when ( VAR_2 . METHOD_6 ( METHOD_7 ( TYPE_4 . class ) , <START> METHOD_7 ( TYPE_6 . TYPE_7...
private TYPE_1 METHOD_1 ( TYPE_2 VAR_1 , TYPE_3 . Builder builder ) { TYPE_1 VAR_2 = METHOD_2 ( TYPE_1 . class ) ; when ( VAR_2 . METHOD_3 ( ) ) . METHOD_4 ( TYPE_8 . VAR_4 ) ; when ( VAR_2 . METHOD_5 ( ) ) . METHOD_4 ( VAR_1 ) ; when ( VAR_2 . METHOD_6 ( METHOD_7 ( TYPE_4 . class ) , METHOD_7 ( TYPE_6 . TYPE_7 . class...
wouldn t assertEquals ( VAR_1 METHOD_3 ( result ) ) communicate expectation ? ( I realize input needs changed )
public void METHOD_1 ( ) { String VAR_1 = STRING_1 + STRING_2 + STRING_3 ; TYPE_1 result = VAR_2 . METHOD_2 ( VAR_1 ) ; <START> assertEquals ( STRING_4 + <END> STRING_2 + STRING_3 , METHOD_3 ( result ) ) ; }
public void METHOD_1 ( ) { String VAR_1 = STRING_4 + STRING_2 + STRING_3 ; TYPE_1 result = VAR_2 . METHOD_2 ( VAR_1 ) ; assertEquals ( VAR_1 , METHOD_3 ( result ) ) ; }
folder abstraction _CODE_ opaque strings _CODE_ numbers implementation detail _CODE_ replace interface more flexible s interface clean ( e g emptying trash folder ) unconstrained EXPUNGE sense I d original method add a new describes suggestion : javapublic void _CODE_ ( List < String > uids ) throws TYPE_3
public abstract void METHOD_1 ( List < ? extends TYPE_1 > VAR_1 , Set < TYPE_2 > VAR_2 , boolean value ) throws TYPE_3 ; public abstract void METHOD_1 ( Set < TYPE_2 > VAR_2 , boolean value ) throws TYPE_3 ; public abstract String METHOD_2 ( TYPE_1 message ) throws TYPE_3 ; <START> public void METHOD_3 ( List < Long > ...
public abstract void METHOD_1 ( List < ? extends TYPE_1 > VAR_1 , Set < TYPE_2 > VAR_2 , boolean value ) throws TYPE_3 ; public abstract void METHOD_1 ( Set < TYPE_2 > VAR_2 , boolean value ) throws TYPE_3 ; public abstract String METHOD_2 ( TYPE_1 message ) throws TYPE_3 ; public void METHOD_3 ( ) throws TYPE_3 { }