ReviewComments
stringlengths
1
2.35k
OriginalCode
stringlengths
28
487
ReviewedCode
stringlengths
14
463
instance entity loader TYPE_3 please move line line line 4118 reuse instance
protected void METHOD_1 ( ) { final Map VAR_1 = METHOD_2 ( ) ; VAR_1 . put ( TYPE_3 . NONE , METHOD_3 ( TYPE_3 . NONE ) ) ; <START> <END> VAR_3 = METHOD_3 ( TYPE_3 . NONE ) ; VAR_4 = METHOD_3 ( TYPE_3 . VAR_5 ) ; VAR_1 . put ( STRING_1 , new TYPE_1 ( this , TYPE_2 . VAR_7 , METHOD_4 ( ) ) ) ; VAR_1 . put ( STRING_2 , n...
protected void METHOD_1 ( ) { VAR_3 = METHOD_3 ( TYPE_3 . NONE ) ; VAR_4 = METHOD_3 ( TYPE_3 . VAR_5 ) ; final Map VAR_1 = METHOD_2 ( ) ; VAR_1 . put ( STRING_1 , new TYPE_1 ( this , TYPE_2 . VAR_7 , METHOD_4 ( ) ) ) ; VAR_1 . put ( STRING_2 , new TYPE_1 ( this , TYPE_2 . VAR_8 , METHOD_4 ( ) ) ) ; }
common practice hibernate = = compare enum values equality follow practice
private TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { <START> if ( TYPE_2 . NONE . equals ( VAR_1 ) ) { <END> return VAR_2 ; } else if ( TYPE_2 . TYPE_4 . equals ( VAR_1 ) ) { return VAR_3 ; } return VAR_4 . METHOD_2 ( VAR_1 , this : : METHOD_3 ) ; }
private TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { if ( TYPE_2 . NONE == VAR_1 ) { return VAR_2 ; } else if ( TYPE_2 . TYPE_4 == VAR_1 ) { return VAR_3 ; } return VAR_4 . METHOD_2 ( VAR_1 , this : : METHOD_3 ) ; }
case returning array type
public static String METHOD_1 ( TYPE_1 type , Context context ) { TYPE_2 VAR_1 = type . VAR_2 ( ) ; if ( ! VAR_1 . METHOD_2 ( ) . isEmpty ( ) ) { TYPE_2 VAR_3 = type . VAR_2 ( ) . METHOD_3 ( new TYPE_3 < TYPE_2 , TYPE_4 > ( ) { @Override protected TYPE_2 METHOD_4 ( TYPE_2 e , TYPE_4 VAR_4 ) { return e ; } } , null ) ; ...
public static String METHOD_1 ( TYPE_1 type , Context context ) { TYPE_2 VAR_3 = type . VAR_2 ( ) . METHOD_3 ( new TYPE_3 < TYPE_2 , TYPE_4 > ( ) { @Override protected TYPE_2 METHOD_4 ( TYPE_2 e , TYPE_4 VAR_4 ) { return e ; } } , null ) ; return METHOD_5 ( VAR_3 , context ) + STRING_1 ; }
changing ? generally done avoid expensive resolution message log case fact doesn t perform worse ? IIUC simply forces 2 debug enabled checks
public void METHOD_1 ( ) { if ( ! session . VAR_1 ( ) ) { throw new IllegalStateException ( STRING_1 ) ; } if ( VAR_2 == null ) { VAR_2 = VAR_3 . METHOD_2 ( ) ; } if ( METHOD_3 ( ) ) { throw new IllegalStateException ( STRING_2 ) ; } <START> if ( LOG . VAR_4 ( ) ) { <END> LOG . debug ( STRING_3 ) ; } this . VAR_2 . MET...
public void METHOD_1 ( ) { if ( ! session . VAR_1 ( ) ) { throw new IllegalStateException ( STRING_1 ) ; } if ( VAR_2 == null ) { VAR_2 = VAR_3 . METHOD_2 ( ) ; } if ( METHOD_3 ( ) ) { throw new IllegalStateException ( STRING_2 ) ; } LOG . debug ( STRING_3 ) ; this . VAR_2 . METHOD_1 ( ) ; }
accessors final
<START> public String getMessage ( ) { <END> return message ; }
public final String getMessage ( ) { return message ; }
oops I meant accessors abstract chat message class overridden undo abstract class
<START> public final String METHOD_1 ( ) { <END> return VAR_1 ; }
public String METHOD_1 ( ) { return VAR_1 ; }
confusing people params considered equal ? ? some part code wants treat params equal long equal names comparison logic close area a local comparator class data object allow reusability class future
public boolean equals ( Object o ) { if ( this == o ) return true ; if ( o == null || getClass ( ) != o . getClass ( ) ) return false ; TYPE_1 that = ( TYPE_1 ) o ; return name . equals ( that . name ) ; <START> } <END>
public boolean equals ( Object o ) { if ( this == o ) return true ; if ( o == null || getClass ( ) != o . getClass ( ) ) return false ; TYPE_1 that = ( TYPE_1 ) o ; return name . equals ( that . name ) && value . equals ( that . value ) ; }
I assume list null
public boolean METHOD_1 ( ) { <START> return ! results . isEmpty ( ) ; <END> }
public boolean METHOD_1 ( ) { return results != null && ! results . isEmpty ( ) ; }
identity comparison equal ( sense equals ( ) ) integers = = ( ! = ) please equals provide proper null - handling code
public boolean equals ( Object o ) { if ( this == o ) { return true ; } if ( o == null || getClass ( ) != o . getClass ( ) ) { return false ; } TYPE_1 that = ( TYPE_1 ) o ; <START> if ( id != that . id ) { <END> return false ; } return true ; }
public boolean equals ( Object o ) { if ( this == o ) return true ; if ( o == null || getClass ( ) != o . getClass ( ) ) return false ; TYPE_1 that = ( TYPE_1 ) o ; if ( id != null ? ! id . equals ( that . id ) : that . id != null ) return false ; return true ; }
need null check s a matter personal preference
public TYPE_1 METHOD_1 ( int VAR_1 ) { <START> if ( VAR_2 == null ) return null ; <END> for ( TYPE_1 VAR_3 : VAR_2 ) { if ( VAR_1 == VAR_3 . getId ( ) ) { return VAR_3 ; } } return null ; }
public TYPE_1 METHOD_1 ( int VAR_1 ) { for ( TYPE_1 VAR_3 : VAR_2 ) { if ( VAR_1 == VAR_3 . getId ( ) ) { return VAR_3 ; } } return null ; }
wrong
public void run ( final TYPE_1 server , final TYPE_2 VAR_1 , final String VAR_2 , final String [ ] args ) throws Exception { if ( args . length > 1 ) { <START> TYPE_3 target = METHOD_1 ( server , args , 0 , true ) ; <END> VAR_1 . METHOD_2 ( STRING_1 + ( target . VAR_3 ( ) ? METHOD_3 ( STRING_2 ) : METHOD_3 ( STRING_3 )...
public void run ( final TYPE_1 server , final TYPE_2 VAR_1 , final String VAR_2 , final String [ ] args ) throws Exception { if ( args . length > 1 ) { TYPE_3 target = METHOD_1 ( server , args , 0 , true , false ) ; VAR_1 . METHOD_2 ( STRING_1 + ( target . VAR_3 ( ) ? METHOD_3 ( STRING_2 ) : METHOD_3 ( STRING_3 ) ) ) ;...
2 - space indent I dispense else statements write : ( ) { return ; } ( ) { return ; }
private static int METHOD_1 ( TYPE_1 state ) { <START> if ( state . VAR_1 > INT_1 ) { <END> return INT_2 ; } else if ( state . VAR_1 > INT_3 ) { return INT_4 ; } else if ( state . VAR_1 > 0 ) { return 10 ; } else { return 0 ; } }
private static int METHOD_1 ( TYPE_1 state ) { if ( state . VAR_1 > INT_1 ) { return INT_2 ; } if ( state . VAR_1 > INT_3 ) { return INT_4 ; } if ( state . VAR_1 > 0 ) { return 10 ; } return 0 ; }
able write ( expected = TYPE_1 class ) body test line exception
<START> public void METHOD_1 ( ) throws TYPE_1 { <END> int VAR_1 = 0 ; try { TYPE_2 result = new TYPE_3 ( ) . METHOD_2 ( STRING_1 , TYPE_4 . VAR_3 , 0 , 0 ) ; } catch ( IllegalArgumentException e ) { VAR_1 = 1 ; } assertEquals ( VAR_1 , 1 ) ; }
public void METHOD_1 ( ) throws TYPE_1 { new TYPE_3 ( ) . METHOD_2 ( STRING_1 , TYPE_4 . VAR_3 , 0 , 0 ) ; }
= VAR_5 ! = 0
protected static int METHOD_1 ( boolean [ ] target , int VAR_1 , int [ ] VAR_2 , boolean VAR_3 ) { int VAR_4 = INT_1 ; for ( int VAR_5 : VAR_2 ) { <START> target [ VAR_1 ++ ] = VAR_5 == 0 ? false : true ; <END> } return VAR_4 ; }
protected static int METHOD_1 ( boolean [ ] target , int VAR_1 , int [ ] VAR_2 , boolean VAR_3 ) { for ( int VAR_5 : VAR_2 ) { target [ VAR_1 ++ ] = VAR_5 != 0 ; } return INT_1 ; }
trivial return
private static int METHOD_1 ( String VAR_1 , int VAR_2 ) { int VAR_3 = 1 ; int VAR_4 = 0 ; for ( int i = VAR_1 . length ( ) - 1 ; i >= 0 ; i -- ) { int VAR_5 = TYPE_2 . TYPE_3 . METHOD_2 ( VAR_1 . METHOD_3 ( i ) ) ; VAR_4 += VAR_5 * VAR_3 ; if ( ++ VAR_3 > VAR_2 ) { VAR_3 = 1 ; } } <START> int VAR_6 = VAR_4 % INT_1 ; <...
private static int METHOD_1 ( String VAR_1 , int VAR_2 ) { int VAR_3 = 1 ; int VAR_4 = 0 ; for ( int i = VAR_1 . length ( ) - 1 ; i >= 0 ; i -- ) { int VAR_5 = TYPE_2 . TYPE_3 . METHOD_2 ( VAR_1 . METHOD_3 ( i ) ) ; VAR_4 += VAR_5 * VAR_3 ; if ( ++ VAR_3 > VAR_2 ) { VAR_3 = 1 ; } } return VAR_4 % INT_1 ; }
isn t changed ; INT_1 ? return INT_1
protected static int METHOD_1 ( boolean [ ] target , int VAR_1 , int [ ] VAR_2 , boolean VAR_3 ) { <START> int VAR_4 = INT_1 ; <END> for ( int VAR_5 : VAR_2 ) { target [ VAR_1 ++ ] = VAR_5 != 0 ; } return VAR_4 ; }
protected static int METHOD_1 ( boolean [ ] target , int VAR_1 , int [ ] VAR_2 , boolean VAR_3 ) { for ( int VAR_5 : VAR_2 ) { target [ VAR_1 ++ ] = VAR_5 != 0 ; } return INT_1 ; }
I method work set ( ) complement VAR_2 & =
public void METHOD_1 ( int x , int y ) { int offset = y * VAR_1 + ( x / INT_1 ) ; <START> int VAR_2 = ( 1 < < ( x & INT_2 ) ) ; <END> if ( ( VAR_3 [ offset ] & VAR_2 ) > 0 ) { VAR_3 [ offset ] ^= VAR_2 ; } }
public void METHOD_1 ( int x , int y ) { int offset = y * VAR_1 + ( x / INT_1 ) ; VAR_3 [ offset ] &= ~ ( 1 < < ( x & INT_2 ) ) ; }
update VAR_2 field mutually exclusive
protected void METHOD_1 ( Collection < TYPE_1 > VAR_1 ) { <START> VAR_2 = ( ) - > VAR_1 ; <END> }
protected void METHOD_1 ( Collection < TYPE_1 > VAR_1 ) { VAR_2 . set ( ( ) - > VAR_1 ) ; }
please protected
<START> public TYPE_1 ( String VAR_2 ) { <END> this . VAR_2 = VAR_2 ; }
protected TYPE_1 ( String VAR_2 ) { this . VAR_2 = VAR_2 ; }
other locations code interprets null * * - s maintain convention ( fix other code - _CODE_ ) javadefault T VAR_1 ( TYPE_1 VAR_3 ) throws IOException { return ( duration = = null ) ? VAR_1 ( ) : VAR_1 ( VAR_3 VAR_4 ( ) ) ; }
default T VAR_1 ( TYPE_1 VAR_3 ) throws IOException { <START> return VAR_1 ( VAR_3 . VAR_4 ( ) ) ; <END> }
default T VAR_1 ( TYPE_1 VAR_3 ) throws IOException { return VAR_3 != null ? VAR_1 ( VAR_3 . VAR_4 ( ) ) : VAR_1 ( ) ; }
other locations code interprets null * * - s maintain convention ( fix other code - _CODE_ )
default boolean VAR_1 ( TYPE_1 VAR_3 ) throws IOException { <START> return VAR_1 ( VAR_3 . VAR_4 ( ) ) ; <END> }
default boolean VAR_1 ( TYPE_1 VAR_3 ) throws IOException { return VAR_3 != null ? VAR_1 ( VAR_3 . VAR_4 ( ) ) : VAR_1 ( ) ; }
protected please - allow users override behavior
<START> private void METHOD_1 ( Path p , TYPE_1 listener , TYPE_2 session , <END> boolean VAR_1 ) throws IOException { if ( VAR_1 ) { listener . VAR_2 ( session , p ) ; } else { listener . VAR_3 ( session , p ) ; } }
protected void METHOD_1 ( Path p , TYPE_1 listener , TYPE_2 session , boolean VAR_1 ) throws IOException { if ( VAR_1 ) { listener . VAR_2 ( session , p ) ; } else { listener . VAR_3 ( session , p ) ; } }
protected please - allow users override behavior
<START> private void METHOD_1 ( Path p , TYPE_1 listener , TYPE_2 session , <END> boolean VAR_1 , Exception e ) throws IOException { if ( VAR_1 ) { listener . VAR_2 ( session , p , e ) ; } else { listener . VAR_3 ( session , p , e ) ; } }
protected void METHOD_1 ( Path p , TYPE_1 listener , TYPE_2 session , boolean VAR_1 , Exception e ) throws IOException { if ( VAR_1 ) { listener . VAR_2 ( session , p , e ) ; } else { listener . VAR_3 ( session , p , e ) ; } }
s _protected_ allow users override want
private synchronized void METHOD_1 ( int cmd , TYPE_1 buffer , boolean VAR_1 ) { <START> try { <END> if ( VAR_1 ) { METHOD_2 ( cmd , buffer ) ; } else { METHOD_3 ( cmd , buffer ) ; } } catch ( Exception e ) { log . warn ( STRING_1 , e . getMessage ( ) , e ) ; } }
protected synchronized void METHOD_1 ( int cmd , TYPE_1 buffer , boolean VAR_1 ) { try { if ( VAR_1 ) { METHOD_2 ( cmd , buffer ) ; } else { METHOD_3 ( cmd , buffer ) ; } } catch ( Exception e ) { log . warn ( STRING_1 , e . getMessage ( ) , e ) ; } }
simpler code : javatry { TYPE_2 VAR_2 = TYPE_3 METHOD_2 ( path options } return ( VAR_2 ! = null ) ? VAR_2 getName ( ) : null ; } catch ( TYPE_4 e ) { return null ; / / ignore }
public static String METHOD_1 ( Path path , TYPE_1 ... options ) throws IOException { String VAR_1 = null ; try { TYPE_2 VAR_2 = TYPE_3 . METHOD_2 ( path , options ) ; if ( VAR_2 != null ) { VAR_1 = VAR_2 . getName ( ) ; } } catch ( TYPE_4 e ) { } return VAR_1 ; <START> } <END>
public static String METHOD_1 ( Path path , TYPE_1 ... options ) throws IOException { try { TYPE_2 VAR_2 = TYPE_3 . METHOD_2 ( path , options ) ; return ( VAR_2 == null ) ? null : VAR_2 . getName ( ) ; } catch ( TYPE_4 e ) { return null ; } }
VAR_4 a convention a constant variable I suggest move method add private static match java convention
public TYPE_1 METHOD_1 ( ) { TYPE_2 metadata = new TYPE_2 ( STRING_1 , TYPE_3 . VAR_2 , STRING_2 ) ; metadata . VAR_3 ( STRING_3 ) ; <START> final int [ ] VAR_4 = { INT_1 , INT_2 , INT_3 , INT_1 , INT_2 , INT_4 , INT_5 , INT_6 , INT_7 , INT_8 , INT_2 , INT_9 , INT_2 , INT_10 , INT_1 } ; <END> VAR_5 = VAR_6 . METHOD_2 (...
public TYPE_1 METHOD_1 ( ) { TYPE_2 metadata = new TYPE_2 ( STRING_1 , TYPE_3 . VAR_2 , STRING_2 ) ; metadata . VAR_3 ( STRING_3 ) ; VAR_5 = VAR_6 . METHOD_2 ( metadata ) ; for ( int VAR_7 : VAR_4 ) { VAR_5 . update ( VAR_7 ) ; } return VAR_5 ; }
null check needed class METHOD_4 ( ) call method returns false passing a null argument
public TYPE_1 METHOD_1 ( ) { TYPE_2 . METHOD_2 ( VAR_1 , STRING_1 ) ; final Object VAR_2 = VAR_1 . METHOD_3 ( TYPE_1 . class . getName ( ) ) ; <START> if ( VAR_2 != null && TYPE_3 . class . METHOD_4 ( VAR_2 ) ) { <END> return ( TYPE_1 ) TYPE_3 . class . METHOD_5 ( VAR_2 ) . apply ( VAR_1 ) ; } return null ; }
public TYPE_1 METHOD_1 ( ) { TYPE_2 . METHOD_2 ( VAR_1 , STRING_1 ) ; final Object VAR_2 = VAR_1 . METHOD_3 ( TYPE_1 . class . getName ( ) ) ; if ( TYPE_3 . class . METHOD_4 ( VAR_2 ) ) { return ( TYPE_1 ) TYPE_3 . class . METHOD_5 ( VAR_2 ) . apply ( VAR_1 ) ; } return null ; }
JLS order public final boolean consistency other methods
<START> final public boolean equals ( Object obj ) { <END> if ( obj == this ) { return true ; } else if ( obj instanceof TYPE_1 < ? > ) { TYPE_1 < ? > that = ( TYPE_1 < ? > ) obj ; return this . VAR_1 . equals ( that . VAR_1 ) ; } else { return false ; } }
public final boolean equals ( Object obj ) { if ( obj == this ) { return true ; } else if ( obj instanceof TYPE_1 < ? > ) { TYPE_1 < ? > that = ( TYPE_1 < ? > ) obj ; return this . VAR_1 . equals ( that . VAR_1 ) ; } else { return false ; } }
wrap + 4
ANNOTATION_1 ANNOTATION_2 TYPE_1 METHOD_1 ( TYPE_2 <START> VAR_1 ) { <END> return new TYPE_3 ( VAR_1 ) ; }
ANNOTATION_1 ANNOTATION_2 TYPE_3 METHOD_1 ( TYPE_2 VAR_1 ) { return new TYPE_3 ( VAR_1 ) ; }
logic reversedjavaif ( ! nf isEmpty ( ) ) { throw ; } return ;
public TYPE_1 contains ( TYPE_2 ... VAR_1 ) { METHOD_1 ( VAR_1 ) ; Set < TYPE_2 > VAR_2 = new TYPE_3 < TYPE_2 > ( ) ; for ( TYPE_2 entry : VAR_1 ) { if ( ! METHOD_2 ( VAR_3 , entry ) ) { VAR_2 . add ( entry ) ; } } if ( VAR_2 . isEmpty ( ) ) { return this ; } <START> throw TYPE_4 . instance ( ) . METHOD_3 ( new TYPE_5 ...
public TYPE_1 contains ( TYPE_2 ... VAR_1 ) { METHOD_1 ( VAR_1 ) ; Set < TYPE_2 > VAR_2 = new TYPE_3 < TYPE_2 > ( ) ; for ( TYPE_2 entry : VAR_1 ) { if ( ! METHOD_2 ( VAR_3 , entry ) ) { VAR_2 . add ( entry ) ; } } if ( ! VAR_2 . isEmpty ( ) ) { throw TYPE_4 . instance ( ) . METHOD_3 ( new TYPE_5 ( ) , METHOD_4 ( VAR_3...
annotations line method declaration
<START> public boolean equals ( Object obj ) { <END> if ( this == obj ) { return true ; } if ( obj == null ) { return false ; } if ( getClass ( ) != obj . getClass ( ) ) { return false ; } TYPE_1 VAR_1 = ( TYPE_1 ) obj ; return METHOD_1 ( key , VAR_1 . key ) && METHOD_1 ( value , VAR_1 . value ) ; }
@Override public boolean equals ( Object obj ) { if ( this == obj ) { return true ; } if ( obj == null ) { return false ; } if ( getClass ( ) != obj . getClass ( ) ) { return false ; } TYPE_1 VAR_1 = ( TYPE_1 ) obj ; return METHOD_1 ( key , VAR_1 . key ) && METHOD_1 ( value , VAR_1 . value ) ; }
generic type avoid warnings : TYPE_1 < TYPE_2 > a couple test class
public void METHOD_1 ( ) throws Exception { <START> TYPE_1 VAR_1 = new TYPE_1 ( output , VAR_2 , TYPE_2 . class ) ; <END> VAR_1 . METHOD_2 ( ) ; VAR_1 . METHOD_3 ( new TYPE_3 ( ) ) ; VAR_1 . write ( this . METHOD_4 ( ) ) ; VAR_1 . close ( ) ; METHOD_5 ( outputStream . VAR_3 ( ) , this . METHOD_4 ( ) , TYPE_2 . class ) ...
public void METHOD_1 ( ) throws Exception { TYPE_1 < TYPE_2 > VAR_1 = new TYPE_1 ( output , VAR_2 , TYPE_2 . class ) ; VAR_1 . METHOD_3 ( new TYPE_3 ( ) ) ; VAR_1 . write ( this . METHOD_4 ( ) ) ; VAR_1 . close ( ) ; METHOD_5 ( outputStream . VAR_3 ( ) , this . METHOD_4 ( ) , TYPE_2 . class ) ; }
I m a bit confused test _CODE_ test especially part : _CODE_ < TYPE_2 > VAR_1 = new TYPE_1 < > ( output VAR_2 TYPE_2 class ) ; VAR_1 METHOD_2 ( false ) ; I provide a schema I set _CODE_ false ? reader read TYPE_2 s avro file a schema providing a schema able write TYPE_2 s avro file embedding schema case schema mandator...
<START> public void METHOD_1 ( ) throws Exception { <END> TYPE_1 VAR_1 = new TYPE_1 ( output , VAR_2 , TYPE_2 . class ) ; VAR_1 . METHOD_2 ( false ) ; VAR_1 . METHOD_3 ( ) ; VAR_1 . METHOD_4 ( new TYPE_3 ( ) ) ; VAR_1 . write ( this . METHOD_5 ( ) ) ; VAR_1 . close ( ) ; METHOD_6 ( outputStream . VAR_3 ( ) , this . MET...
public void METHOD_1 ( ) throws Exception { TYPE_1 < TYPE_2 > VAR_1 = new TYPE_1 ( output , TYPE_2 . class ) ; VAR_1 . METHOD_4 ( new TYPE_3 ( ) ) ; VAR_1 . write ( this . METHOD_5 ( ) ) ; VAR_1 . close ( ) ; METHOD_6 ( outputStream . VAR_3 ( ) , this . METHOD_5 ( ) , TYPE_2 . class , false ) ; }
a reason package private ? a fluent builder feels odd
<START> TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { <END> this . VAR_1 = VAR_1 ; return this ; }
public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { this . VAR_1 = VAR_1 ; return this ; }
shouldn t calling responsibility container s injected
public TYPE_5 ( TYPE_1 VAR_2 ) throws Exception { super ( ) ; Assert . VAR_3 ( VAR_2 , STRING_1 ) ; <START> VAR_2 . METHOD_1 ( ) ; <END> TYPE_2 VAR_4 = VAR_2 . METHOD_2 ( ) ; TYPE_3 VAR_5 = new TYPE_3 ( VAR_4 ) ; TYPE_4 < T > VAR_6 = new TYPE_4 < > ( ) ; VAR_6 . METHOD_3 ( VAR_5 ) ; VAR_6 . METHOD_1 ( ) ; METHOD_3 ( VA...
public TYPE_5 ( TYPE_1 VAR_2 ) { Assert . VAR_3 ( VAR_2 , STRING_1 ) ; this . VAR_4 = VAR_2 . METHOD_2 ( ) ; }
a minimum return _CODE_ TYPE_3 implement _CODE_ components I recommend returning concrete type spring interfaces implemented
<START> public TYPE_1 < Integer > METHOD_1 ( ) { <END> TYPE_2 VAR_1 = new TYPE_2 ( ) ; VAR_1 . METHOD_2 ( METHOD_3 ( ) ) ; TYPE_3 < Integer > VAR_2 = new TYPE_3 < > ( ) ; VAR_2 . METHOD_4 ( VAR_1 ) ; VAR_2 . METHOD_5 ( METHOD_6 ( ) ) ; return VAR_2 ; }
public TYPE_3 < Integer > METHOD_1 ( ) { TYPE_2 VAR_1 = new TYPE_2 ( ) ; VAR_1 . METHOD_2 ( METHOD_3 ( ) ) ; TYPE_3 < Integer > VAR_2 = new TYPE_3 < > ( ) ; VAR_2 . METHOD_4 ( VAR_1 ) ; VAR_2 . METHOD_5 ( METHOD_6 ( ) ) ; return VAR_2 ; }
missing generic return
<START> public TYPE_1 METHOD_1 ( TYPE_2 < T , TYPE_3 < ? super T > > VAR_1 ) { <END> Assert . VAR_2 ( VAR_1 , STRING_1 ) ; this . VAR_1 = VAR_1 ; return this ; }
public TYPE_1 < T > METHOD_1 ( TYPE_2 < T , TYPE_3 < ? super T > > VAR_1 ) { this . VAR_1 = VAR_1 ; return this ; }
move assert build sits invalid writer ( invalid default ) : new _CODE_ ( ) build ( ) ; A test case condition added
public TYPE_1 < T > METHOD_1 ( TYPE_2 < T , TYPE_3 < ? super T > > VAR_1 ) { <START> Assert . VAR_2 ( VAR_1 , STRING_1 ) ; <END> this . VAR_1 = VAR_1 ; return this ; }
public TYPE_1 < T > METHOD_1 ( TYPE_2 < T , TYPE_3 < ? super T > > VAR_1 ) { this . VAR_1 = VAR_1 ; return this ; }
I ve asserts build method prevent duplication ( null check ) user passes null s long don t call build call else
public TYPE_1 METHOD_1 ( List < TYPE_2 < ? super T > > VAR_1 ) { Assert . VAR_2 ( VAR_1 , STRING_1 ) ; <START> Assert . VAR_3 ( VAR_1 , STRING_2 ) ; <END> this . VAR_1 = VAR_1 ; return this ; }
public TYPE_1 METHOD_1 ( List < TYPE_2 < ? super T > > VAR_1 ) { this . VAR_1 = VAR_1 ; return this ; }
want people able override
<START> protected TYPE_1 METHOD_1 ( ) { <END> TYPE_1 VAR_1 = new TYPE_1 ( ) ; if ( METHOD_2 ( ) . METHOD_3 ( VAR_2 ) ) { TYPE_2 VAR_3 = METHOD_2 ( ) . METHOD_4 ( VAR_2 ) ; TYPE_1 properties = ( TYPE_1 ) VAR_3 . METHOD_5 ( ) . METHOD_6 ( TYPE_1 . class ) . getValue ( ) ; if ( properties == null ) { return new TYPE_1 ( )...
private TYPE_1 METHOD_1 ( ) { TYPE_1 VAR_1 = new TYPE_1 ( ) ; if ( METHOD_2 ( ) . METHOD_3 ( VAR_2 ) ) { TYPE_2 VAR_3 = METHOD_2 ( ) . METHOD_4 ( VAR_2 ) ; TYPE_1 properties = ( TYPE_1 ) VAR_3 . METHOD_5 ( ) . METHOD_6 ( TYPE_1 . class ) . getValue ( ) ; if ( properties == null ) { return new TYPE_1 ( ) ; } VAR_1 . MET...
VAR_2 ! = null Assert VAR_3 clearer
public void METHOD_1 ( ) throws Exception { <START> Assert . VAR_1 ( ! ( VAR_2 == null ) , STRING_1 ) ; <END> Assert . VAR_3 ( name , STRING_2 ) ; }
public void METHOD_1 ( ) throws Exception { Assert . VAR_1 ( VAR_2 != null , STRING_1 ) ; Assert . VAR_3 ( name , STRING_2 ) ; }
revert ( declaration )
void METHOD_1 ( TYPE_1 VAR_1 ) { <START> if ( METHOD_2 ( VAR_1 . METHOD_3 ( ) . VAR_2 ) ) { <END> TYPE_2 result = VAR_1 . METHOD_4 ( ) ; if ( result != null ) { if ( result instanceof TYPE_2 . TYPE_4 ) { TYPE_4 VAR_3 = ( ( TYPE_2 . TYPE_4 ) result ) . METHOD_5 ( ) ; cache . set ( VAR_1 . getKey ( ) , VAR_3 ) ; } } } VA...
void METHOD_1 ( TYPE_1 VAR_1 ) { if ( METHOD_2 ( VAR_1 . data . VAR_2 ) ) { TYPE_2 result = VAR_1 . METHOD_4 ( ) ; if ( result != null ) { if ( result instanceof TYPE_2 . TYPE_4 ) { TYPE_4 VAR_3 = ( ( TYPE_2 . TYPE_4 ) result ) . METHOD_5 ( ) ; cache . set ( VAR_1 . getKey ( ) , VAR_3 ) ; } } } VAR_4 . remove ( VAR_1 ....
remove checks VAR_2 flag checks don t add
public Builder METHOD_1 ( ANNOTATION_1 TYPE_1 VAR_1 ) { METHOD_2 ( VAR_1 , STRING_1 ) ; if ( ! VAR_2 && this . VAR_3 != null ) { <START> throw new IllegalStateException ( STRING_2 ) ; <END> } this . VAR_3 = VAR_1 ; return this ; }
public Builder METHOD_1 ( ANNOTATION_1 TYPE_1 VAR_1 ) { METHOD_2 ( VAR_1 , STRING_1 ) ; this . VAR_3 = VAR_1 ; return this ; }
public
<START> public TYPE_2 ( TYPE_1 data ) { <END> this . data = data ; }
TYPE_2 ( TYPE_1 data ) { this . data = data ; }
private
<START> static int METHOD_1 ( int VAR_1 ) { <END> int VAR_2 ; switch ( VAR_1 ) { case VAR_3 : case VAR_4 : VAR_2 = INT_1 ; break ; case VAR_5 : case VAR_6 : VAR_2 = INT_2 ; break ; case VAR_7 : case VAR_8 : VAR_2 = INT_3 ; break ; default : VAR_2 = 0 ; } return VAR_2 ; }
private static int METHOD_1 ( int VAR_1 ) { int VAR_2 ; switch ( VAR_1 ) { case VAR_3 : case VAR_4 : VAR_2 = INT_1 ; break ; case VAR_5 : case VAR_6 : VAR_2 = INT_2 ; break ; case VAR_7 : case VAR_8 : VAR_2 = INT_3 ; break ; default : VAR_2 = 0 ; } return VAR_2 ; }
private
<START> static int METHOD_1 ( int VAR_1 ) { <END> int VAR_2 ; switch ( VAR_1 ) { case VAR_3 : case VAR_4 : case VAR_5 : case VAR_6 : VAR_2 = - 1 ; break ; default : VAR_2 = 1 ; } return VAR_2 ; }
private static int METHOD_1 ( int VAR_1 ) { int VAR_2 ; switch ( VAR_1 ) { case VAR_3 : case VAR_4 : case VAR_5 : case VAR_6 : VAR_2 = - 1 ; break ; default : VAR_2 = 1 ; } return VAR_2 ; }
I m pretty IllegalArgumentException else
public void METHOD_1 ( TYPE_1 view ) { if ( view == null ) { <START> throw new TYPE_2 ( STRING_1 ) ; <END> } METHOD_2 ( view ) ; }
public void METHOD_1 ( TYPE_1 view ) { if ( view == null ) { throw new IllegalArgumentException ( STRING_1 ) ; } METHOD_2 ( view ) ; }
inline return line
static int METHOD_1 ( TYPE_1 uri ) throws IOException { TYPE_2 VAR_1 = new TYPE_2 ( uri . getPath ( ) ) ; int VAR_2 = VAR_1 . METHOD_2 ( VAR_3 , VAR_4 ) ; <START> return VAR_2 ; <END> }
static int METHOD_1 ( TYPE_1 uri ) throws IOException { TYPE_2 VAR_1 = new TYPE_2 ( uri . getPath ( ) ) ; return VAR_1 . METHOD_2 ( VAR_3 , VAR_4 ) ; }
want List < ? super TYPE_1 > TYPE_1 objects casting
<START> public Builder METHOD_1 ( List < ? extends TYPE_1 > VAR_1 ) { <END> if ( VAR_1 == null ) { throw new IllegalArgumentException ( STRING_1 ) ; } for ( Object VAR_2 : VAR_1 ) { METHOD_1 ( ( TYPE_1 ) VAR_2 ) ; } return this ; }
public Builder METHOD_1 ( List < ? extends TYPE_1 > VAR_1 ) { if ( VAR_1 == null ) { throw new IllegalArgumentException ( STRING_1 ) ; } for ( TYPE_1 VAR_2 : VAR_1 ) { METHOD_1 ( VAR_2 ) ; } return this ; }
methods need public I integer passed downloader means
<START> static boolean METHOD_1 ( int VAR_1 ) { <END> return ( VAR_1 & TYPE_1 . VAR_3 . index ) == TYPE_1 . VAR_3 . index ; }
public static boolean METHOD_1 ( int VAR_1 ) { return ( VAR_1 & TYPE_1 . VAR_3 . index ) != 0 ; }
ugly suppressing warning a _CODE_ ( STRING_1 ) / / public API
<START> ANNOTATION_1 ( STRING_1 ) public void METHOD_1 ( boolean VAR_1 ) { <END> VAR_2 = VAR_1 ; }
public void METHOD_1 ( boolean VAR_1 ) { VAR_2 = VAR_1 ; }
null explicit choice user reject exception
public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 , TYPE_2 ... VAR_2 ) { if ( VAR_1 == null ) { throw new IllegalArgumentException ( STRING_1 ) ; } this . VAR_3 |= VAR_1 . index ; <START> if ( VAR_2 != null && VAR_2 . length > 0 ) { <END> for ( TYPE_2 VAR_3 : VAR_2 ) { if ( VAR_3 == null ) { throw new IllegalArgumentException ( ST...
public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 , TYPE_2 ... VAR_2 ) { if ( VAR_1 == null ) { throw new IllegalArgumentException ( STRING_1 ) ; } this . VAR_3 |= VAR_1 . index ; if ( VAR_2 == null ) { throw new IllegalArgumentException ( STRING_1 ) ; } if ( VAR_2 . length > 0 ) { for ( TYPE_2 VAR_3 : VAR_2 ) { if ( VAR_3 == null...
package scoped public
<START> public void error ( ) { <END> if ( VAR_1 != null ) { VAR_1 . METHOD_1 ( ) ; } }
@Override void error ( ) { if ( VAR_1 != null ) { VAR_1 . METHOD_1 ( ) ; } }
_CODE_ instead ? happen
public TYPE_1 < ? > METHOD_1 ( TYPE_2 task ) { if ( task == null ) { <START> throw new TYPE_3 ( ) ; <END> } TYPE_4 VAR_1 = new TYPE_4 ( ( TYPE_5 ) task ) ; execute ( VAR_1 ) ; return VAR_1 ; }
public TYPE_1 < ? > METHOD_1 ( TYPE_2 task ) { TYPE_4 VAR_1 = new TYPE_4 ( ( TYPE_5 ) task ) ; execute ( VAR_1 ) ; return VAR_1 ; }
don t need wrap ArrayList
ANNOTATION_1 public void METHOD_1 ( ) { TYPE_1 action = METHOD_2 ( VAR_1 , VAR_2 ) ; TYPE_2 VAR_3 = new TYPE_2 ( context ) ; <START> List < TYPE_3 > VAR_4 = new ArrayList < TYPE_3 > ( Arrays . asList ( VAR_3 ) ) ; <END> TYPE_4 VAR_5 = new TYPE_4 ( context , VAR_6 , cache , null , null , VAR_4 , VAR_7 , false , false ) ...
ANNOTATION_1 public void METHOD_1 ( ) { TYPE_1 action = METHOD_2 ( VAR_1 , VAR_2 ) ; TYPE_3 VAR_3 = new TYPE_2 ( context ) ; List < TYPE_3 > VAR_4 = Arrays . asList ( VAR_3 ) ; TYPE_4 VAR_5 = new TYPE_4 ( context , VAR_6 , cache , null , null , VAR_4 , VAR_7 , false , false ) ; TYPE_5 VAR_8 = METHOD_3 ( VAR_5 , VAR_6 ,...
cache instance a field ? called
@Override TYPE_1 METHOD_1 ( ) { <START> return new TYPE_1 ( VAR_1 , VAR_2 ) ; <END> }
@Override TYPE_1 METHOD_1 ( ) { if ( target == null ) { target = new TYPE_1 ( VAR_1 , VAR_2 ) ; } return target ; }
I a bit early support loading places other internet
public Builder ( Context context ) { if ( context == null ) { throw new IllegalArgumentException ( STRING_1 ) ; } <START> if ( ! METHOD_1 ( context , TYPE_1 . VAR_2 . VAR_3 ) ) { <END> throw new IllegalArgumentException ( STRING_2 ) ; } this . context = context . VAR_4 ( ) ; }
public Builder ( Context context ) { if ( context == null ) { throw new IllegalArgumentException ( STRING_1 ) ; } this . context = context . VAR_4 ( ) ; }
IllegalStateException
public TYPE_11 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 , TYPE_3 cache , TYPE_4 VAR_4 , TYPE_5 action , TYPE_6 VAR_5 ) { super ( VAR_2 , VAR_3 , cache , VAR_4 , action ) ; this . VAR_5 = VAR_5 ; this . VAR_6 = VAR_7 ; if ( ! METHOD_1 ( VAR_2 . context , TYPE_12 . VAR_9 . VAR_10 ) ) { TYPE_1 . TYPE_10 . METHOD_2 ( new TYPE_8 ( ) {...
public TYPE_11 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 , TYPE_3 cache , TYPE_4 VAR_4 , TYPE_5 action , TYPE_6 VAR_5 ) { super ( VAR_2 , VAR_3 , cache , VAR_4 , action ) ; this . VAR_5 = VAR_5 ; this . VAR_6 = VAR_7 ; if ( ! METHOD_1 ( VAR_2 . context , TYPE_12 . VAR_9 . VAR_10 ) ) { TYPE_1 . TYPE_10 . METHOD_2 ( new TYPE_8 ( ) {...
inline method body line
public int METHOD_1 ( ) { int result = VAR_1 . METHOD_1 ( ) ; result = INT_1 * result + VAR_2 ; <START> return result ; <END> }
@Override public int METHOD_1 ( ) { return INT_1 * VAR_1 . METHOD_1 ( ) + VAR_2 ; }
else
void METHOD_1 ( TYPE_1 action ) { <START> if ( VAR_1 != null ) { <END> VAR_1 . remove ( action ) ; } if ( this . action == action ) { this . action = null ; } }
void METHOD_1 ( TYPE_1 action ) { if ( this . action == action ) { this . action = null ; } else if ( VAR_1 != null ) { VAR_1 . remove ( action ) ; } }
chain previous line s assertion
ANNOTATION_1 public void METHOD_1 ( ) throws Exception { TYPE_1 VAR_1 = METHOD_2 ( VAR_2 , VAR_3 , METHOD_3 ( ) ) ; TYPE_1 VAR_4 = METHOD_2 ( VAR_2 , VAR_3 , METHOD_3 ( ) ) ; TYPE_2 VAR_5 = new TYPE_3 ( VAR_6 , VAR_7 , cache , VAR_8 , VAR_1 ) ; assertThat ( VAR_5 . VAR_9 ) . METHOD_4 ( ) ; VAR_5 . METHOD_5 ( VAR_4 ) ; ...
ANNOTATION_1 public void METHOD_1 ( ) throws Exception { TYPE_1 VAR_1 = METHOD_2 ( VAR_2 , VAR_3 , METHOD_3 ( ) ) ; TYPE_1 VAR_4 = METHOD_2 ( VAR_2 , VAR_3 , METHOD_3 ( ) ) ; TYPE_2 VAR_5 = new TYPE_3 ( VAR_6 , VAR_7 , cache , VAR_8 , VAR_1 ) ; assertThat ( VAR_5 . VAR_9 ) . METHOD_4 ( ) ; VAR_5 . METHOD_5 ( VAR_4 ) ; ...
isn t descriptive : _CODE_ TYPE_4 options = null ; ( VAR_3 || VAR_1 ) { options = new }
static TYPE_3 . TYPE_4 METHOD_1 ( TYPE_2 data ) { final boolean VAR_1 = data . VAR_2 ( ) ; final boolean VAR_3 = data . config != null ; <START> final boolean VAR_4 = VAR_3 || VAR_1 ; <END> final TYPE_3 . TYPE_4 options = VAR_4 ? new TYPE_3 . TYPE_4 ( ) : null ; if ( VAR_1 ) { options . VAR_5 = true ; } if ( VAR_3 ) { ...
static TYPE_3 . TYPE_4 METHOD_1 ( TYPE_2 data ) { final boolean VAR_1 = data . VAR_2 ( ) ; final boolean VAR_3 = data . config != null ; TYPE_3 . TYPE_4 options = null ; if ( VAR_1 || VAR_3 ) { options = new TYPE_3 . TYPE_4 ( ) ; options . VAR_5 = VAR_1 ; if ( VAR_3 ) { options . VAR_6 = data . config ; } } return opti...
VAR_1 null
public int METHOD_1 ( ) { TYPE_1 VAR_1 = VAR_2 ; <START> return ( VAR_1 == null || VAR_1 . METHOD_2 ( ) || VAR_3 . METHOD_3 ( ) < INT_1 ) <END> ? TYPE_2 . VAR_5 : TYPE_2 . VAR_6 ; }
@Override public int METHOD_1 ( ) { TYPE_1 VAR_1 = VAR_2 ; return ( VAR_1 . METHOD_2 ( ) || VAR_3 . METHOD_3 ( ) < INT_1 ) ? TYPE_2 . VAR_5 : TYPE_2 . VAR_6 ; }
add { }
@Override public void METHOD_1 ( Context context , TYPE_1 VAR_1 ) { <START> if ( null == VAR_1 ) <END> return ; String action = VAR_1 . METHOD_2 ( ) ; TYPE_2 VAR_2 = VAR_1 . METHOD_3 ( ) ; if ( TYPE_3 . equals ( action ) ) { METHOD_4 ( VAR_2 . METHOD_5 ( VAR_3 , false ) ) ; } else if ( TYPE_4 . equals ( action ) ) { ME...
@Override public void METHOD_1 ( Context context , TYPE_1 VAR_1 ) { if ( null == VAR_1 ) { return ; } String action = VAR_1 . METHOD_2 ( ) ; TYPE_2 VAR_2 = VAR_1 . METHOD_3 ( ) ; if ( TYPE_3 . equals ( action ) ) { METHOD_4 ( VAR_2 . METHOD_5 ( VAR_3 , false ) ) ; } else if ( TYPE_4 . equals ( action ) ) { METHOD_6 ( V...
I overflow s coerced a long cast arguments a long ensure long multiplication performed
static long METHOD_1 ( File VAR_1 ) { long size = VAR_2 ; try { TYPE_1 VAR_3 = new TYPE_1 ( VAR_1 . METHOD_2 ( ) ) ; <START> long VAR_4 = VAR_3 . METHOD_3 ( ) * VAR_3 . METHOD_4 ( ) ; <END> size = VAR_4 / INT_1 ; } catch ( IllegalArgumentException VAR_5 ) { } return Math . max ( Math . VAR_6 ( size , VAR_7 ) , VAR_2 ) ...
static long METHOD_1 ( File VAR_1 ) { long size = VAR_2 ; try { TYPE_1 VAR_3 = new TYPE_1 ( VAR_1 . METHOD_2 ( ) ) ; long VAR_4 = ( ( long ) VAR_3 . METHOD_3 ( ) ) * VAR_3 . METHOD_4 ( ) ; size = VAR_4 / INT_1 ; } catch ( IllegalArgumentException VAR_5 ) { } return Math . max ( Math . VAR_6 ( size , VAR_7 ) , VAR_2 ) ;...
need change method names more descriptive
TYPE_1 METHOD_1 ( String key ) { TYPE_1 VAR_1 = cache . get ( key ) ; if ( VAR_1 != null ) { VAR_2 . METHOD_2 ( ) ; } else { <START> VAR_2 . METHOD_3 ( ) ; <END> } return VAR_1 ; }
TYPE_1 METHOD_1 ( String key ) { TYPE_1 VAR_1 = cache . get ( key ) ; if ( VAR_1 != null ) { VAR_2 . METHOD_2 ( ) ; } return VAR_1 ; }
s suppression ? call VAR_5
<START> ANNOTATION_1 ( STRING_1 ) public void METHOD_1 ( ) { <END> cache . clear ( ) ; VAR_1 . METHOD_1 ( ) ; VAR_2 . METHOD_1 ( ) ; VAR_3 . METHOD_1 ( ) ; if ( this == VAR_4 ) { VAR_4 = null ; } VAR_5 = true ; }
public void METHOD_1 ( ) { if ( VAR_5 ) { return ; } cache . clear ( ) ; VAR_1 . METHOD_1 ( ) ; VAR_2 . METHOD_1 ( ) ; VAR_3 . METHOD_1 ( ) ; if ( this == VAR_4 ) { VAR_4 = null ; } VAR_5 = true ; }
I don t false remove
TYPE_9 ( TYPE_1 VAR_2 , TYPE_2 uri , int VAR_3 , TYPE_3 VAR_4 , TYPE_4 options , List < TYPE_5 > VAR_5 , boolean VAR_6 , boolean VAR_7 , int VAR_8 , TYPE_6 VAR_9 , String key , TYPE_7 VAR_10 ) { super ( VAR_2 , uri , VAR_3 , VAR_4 , options , VAR_5 , VAR_6 , VAR_7 , VAR_8 , VAR_9 , key , VAR_10 ) ; TYPE_8 VAR_11 = VAR_...
TYPE_9 ( TYPE_1 VAR_2 , TYPE_2 uri , int VAR_3 , TYPE_3 VAR_4 , TYPE_4 options , List < TYPE_5 > VAR_5 , boolean VAR_6 , boolean VAR_7 , int VAR_8 , TYPE_6 VAR_9 , String key , TYPE_7 VAR_10 ) { super ( VAR_2 , uri , VAR_3 , VAR_4 , options , VAR_5 , VAR_6 , VAR_7 , VAR_8 , VAR_9 , key , VAR_10 ) ; TYPE_8 VAR_11 = VAR_...
drop fit line
TYPE_2 ( Context context ) { <START> this . VAR_2 = <END> ( TYPE_1 ) context . VAR_3 ( VAR_4 ) ; }
TYPE_2 ( Context context ) { VAR_2 = ( TYPE_1 ) context . VAR_3 ( VAR_4 ) ; }
( = = null ) return ; instead
static void METHOD_1 ( TYPE_1 is ) { <START> try { <END> if ( is != null ) { is . close ( ) ; } } catch ( IOException VAR_1 ) { } }
static void METHOD_1 ( TYPE_1 is ) { if ( is == null ) { return ; } try { is . close ( ) ; } catch ( IOException VAR_1 ) { } }
inline VAR_1 return BH _CODE_ ( ) METHOD_2 ( )
TYPE_1 execute ( TYPE_2 request ) throws IOException { TYPE_3 VAR_1 = TYPE_3 . METHOD_1 ( context , this , VAR_2 , request , VAR_3 ) ; <START> return VAR_1 . METHOD_2 ( ) ; <END> }
TYPE_1 execute ( TYPE_2 request ) throws IOException { return TYPE_3 . METHOD_1 ( context , this , VAR_2 , request , VAR_3 ) . METHOD_2 ( ) ; }
sketchy hash codes aren t unique
void METHOD_1 ( TYPE_1 request ) { Object target = request . VAR_1 ( ) ; if ( target == null ) return ; METHOD_2 ( target , request . uri ) ; VAR_2 . put ( target , request ) ; <START> VAR_3 . put ( request . VAR_4 ( ) . METHOD_3 ( ) , request ) ; <END> request . VAR_5 = VAR_6 . METHOD_1 ( request ) ; }
void METHOD_1 ( TYPE_1 request ) { Object target = request . VAR_1 ( ) ; if ( target == null ) return ; METHOD_2 ( target , request . uri ) ; VAR_2 . put ( target , request ) ; request . VAR_5 = VAR_6 . METHOD_1 ( request ) ; }
substring ( 1 ) don t allocate a new String instance
TYPE_1 METHOD_1 ( TYPE_2 uri , TYPE_3 VAR_1 ) throws IOException { <START> String path = uri . getPath ( ) . METHOD_2 ( STRING_1 , "" ) ; <END> TYPE_4 VAR_2 = context . VAR_3 ( ) ; if ( VAR_1 != null && VAR_1 . VAR_4 ) { TYPE_5 . METHOD_3 ( VAR_2 . METHOD_4 ( path ) , null , VAR_1 ) ; METHOD_5 ( VAR_1 ) ; } return METH...
TYPE_1 METHOD_1 ( TYPE_2 uri , TYPE_3 VAR_1 ) throws IOException { String path = uri . getPath ( ) . substring ( 1 ) ; TYPE_4 VAR_2 = context . VAR_3 ( ) ; if ( VAR_1 != null && VAR_1 . VAR_4 ) { TYPE_5 . METHOD_3 ( VAR_2 . METHOD_4 ( path ) , null , VAR_1 ) ; METHOD_5 ( VAR_1 ) ; } return METHOD_3 ( VAR_2 . METHOD_4 (...
substring ( 1 ) don t allocate a new String instance
TYPE_1 METHOD_1 ( TYPE_2 uri , TYPE_3 VAR_1 ) throws IOException { <START> String path = uri . getPath ( ) . METHOD_2 ( STRING_1 , "" ) ; <END> try { return METHOD_1 ( Integer . parseInt ( path ) , VAR_1 ) ; } catch ( TYPE_4 VAR_2 ) { throw new IOException ( STRING_2 + path + STRING_3 ) ; } }
TYPE_1 METHOD_1 ( TYPE_2 uri , TYPE_3 VAR_1 ) throws IOException { String path = uri . getPath ( ) . substring ( 1 ) ; try { return METHOD_1 ( Integer . parseInt ( path ) , VAR_1 ) ; } catch ( TYPE_4 exception ) { throw new IOException ( STRING_2 + path + STRING_3 , exception ) ; } }
? trace ( ) methods signatures change String Object : _CODE_ _CODE_ _CODE_ Object Throwable
private void METHOD_1 ( TYPE_1 VAR_1 , long VAR_2 ) { if ( VAR_3 == VAR_1 ) { return ; } VAR_3 = VAR_1 ; if ( logger . VAR_4 ( ) ) { logger . trace ( Logger . TYPE_2 . VAR_6 , VAR_7 . METHOD_2 ( STRING_1 , VAR_2 ) . METHOD_3 ( STRING_2 , METHOD_4 ( ) ) <START> . METHOD_5 ( STRING_3 , VAR_1 ) . toString ( ) ) ; <END> } ...
private void METHOD_1 ( TYPE_1 VAR_1 , long VAR_2 ) { if ( VAR_3 == VAR_1 ) { return ; } VAR_3 = VAR_1 ; if ( logger . VAR_4 ( ) ) { logger . trace ( Logger . TYPE_2 . VAR_6 , VAR_7 . METHOD_2 ( STRING_1 , VAR_2 ) . METHOD_3 ( STRING_2 , METHOD_4 ( ) ) . METHOD_5 ( STRING_3 , VAR_1 ) ) ; } }
I hooks delagate transformer bypassing _CODE_ ( )
public TYPE_1 METHOD_1 ( ) { <START> return this . VAR_1 . METHOD_1 ( ) ; <END> }
public TYPE_1 METHOD_1 ( ) { return this ; }
I pt logging s implicitly converted a byte int
public TYPE_1 METHOD_1 ( TYPE_1 VAR_1 ) { if ( VAR_2 != - 1 ) { TYPE_1 . TYPE_4 VAR_3 = VAR_1 . METHOD_2 ( ( byte ) VAR_2 ) ; if ( VAR_3 != null && VAR_3 . METHOD_3 ( ) == 2 ) { int VAR_4 = TYPE_3 . METHOD_4 ( VAR_3 . METHOD_5 ( ) , VAR_3 . METHOD_6 ( ) + 1 ) ; <START> METHOD_7 ( <END> VAR_4 , VAR_1 . METHOD_8 ( ) , VA...
public TYPE_1 METHOD_1 ( TYPE_1 VAR_1 ) { if ( VAR_2 != - 1 ) { TYPE_1 . TYPE_4 VAR_3 = VAR_1 . METHOD_2 ( ( byte ) VAR_2 ) ; if ( VAR_3 != null && VAR_3 . METHOD_3 ( ) == 2 ) { int VAR_4 = TYPE_3 . METHOD_4 ( VAR_3 . METHOD_5 ( ) , VAR_3 . METHOD_6 ( ) + 1 ) ; METHOD_7 ( VAR_4 , TYPE_1 . METHOD_8 ( VAR_1 ) , VAR_1 . M...
static ? missing docs
private static String METHOD_1 ( byte b ) { char [ ] VAR_1 <START> = new char [ ] <END> { CHAR_1 , CHAR_2 , CHAR_3 , CHAR_4 , CHAR_5 , CHAR_6 , CHAR_7 , CHAR_8 , CHAR_9 , CHAR_10 , CHAR_11 , CHAR_12 , CHAR_13 , CHAR_14 , CHAR_15 , CHAR_16 } ; StringBuilder VAR_2 = new StringBuilder ( 2 ) ; VAR_2 . append ( VAR_1 [ ( b ...
private static String METHOD_1 ( byte b ) { StringBuilder VAR_2 = new StringBuilder ( 2 ) ; VAR_2 . append ( VAR_1 [ ( b & INT_1 ) > > 4 ] ) ; VAR_2 . append ( VAR_1 [ b & INT_2 ] ) ; return VAR_2 . toString ( ) ; }
static versions METHOD_2 METHOD_3
public TYPE_1 METHOD_1 ( byte [ ] buf , int VAR_1 , int VAR_2 ) { TYPE_2 VAR_3 = new TYPE_2 ( buf , VAR_1 , VAR_2 ) ; <START> return METHOD_1 ( VAR_3 . METHOD_2 ( ) , VAR_3 . METHOD_3 ( ) ) ; <END> }
public TYPE_1 METHOD_1 ( byte [ ] buf , int VAR_1 , int VAR_2 ) { return METHOD_1 ( TYPE_2 . METHOD_2 ( buf , VAR_1 , VAR_2 ) , TYPE_2 . METHOD_3 ( buf , VAR_1 , VAR_2 ) ) ; }
please remove VAR_2 ? testing jitsi - meet abs - send - time configured id = 3 test
public byte METHOD_1 ( ) { <START> return VAR_1 == - 1 ? VAR_2 : VAR_1 ; <END> }
public byte METHOD_1 ( ) { return VAR_1 ; }
private
<START> public < TYPE_1 , TYPE_2 > List < TYPE_1 > METHOD_1 ( TYPE_3 < TYPE_1 , TYPE_2 > VAR_1 ) <END> { ArrayList < TYPE_1 > VAR_2 = new ArrayList < TYPE_1 > ( ) ; for ( Map . Entry < TYPE_1 , TYPE_2 > entry : VAR_1 . entrySet ( ) ) { VAR_2 . add ( entry . getKey ( ) ) ; } return VAR_2 ; }
private < TYPE_1 , TYPE_2 > List < TYPE_1 > METHOD_1 ( TYPE_3 < TYPE_1 , TYPE_2 > VAR_1 ) { ArrayList < TYPE_1 > VAR_2 = new ArrayList < TYPE_1 > ( ) ; for ( Map . Entry < TYPE_1 , TYPE_2 > entry : VAR_1 . entrySet ( ) ) { VAR_2 . add ( entry . getKey ( ) ) ; } return VAR_2 ; }
private
<START> long METHOD_1 ( long VAR_1 ) <END> { long VAR_2 = ( long ) ( ( ( VAR_1 < < VAR_3 ) + INT_1 ) / INT_2 ) & INT_3 ; return VAR_2 ; }
private long METHOD_1 ( long VAR_1 ) { long VAR_2 = ( long ) ( ( ( VAR_1 < < VAR_3 ) + INT_1 ) / INT_2 ) & INT_3 ; return VAR_2 ; }
private
<START> boolean METHOD_1 ( long VAR_1 , TYPE_1 VAR_2 ) <END> { if ( VAR_2 . count == 0 ) { return true ; } double VAR_3 = VAR_2 . VAR_4 / ( double ) VAR_2 . count ; return Math . VAR_5 ( ( double ) VAR_1 - VAR_3 ) < FLOAT_1 ; }
private boolean METHOD_1 ( long VAR_1 , TYPE_1 VAR_2 ) { if ( VAR_2 . count == 0 ) { return true ; } double VAR_3 = VAR_2 . VAR_4 / ( double ) VAR_2 . count ; return Math . VAR_5 ( ( double ) VAR_1 - VAR_3 ) < FLOAT_1 ; }
private
<START> void METHOD_1 ( List < TYPE_1 > VAR_1 , TYPE_1 cluster ) <END> { cluster . VAR_2 /= ( double ) cluster . count ; cluster . VAR_3 /= ( double ) cluster . count ; cluster . VAR_4 /= cluster . count ; VAR_1 . add ( cluster ) ; }
private void METHOD_1 ( List < TYPE_1 > VAR_1 , TYPE_1 cluster ) { cluster . VAR_2 /= ( double ) cluster . count ; cluster . VAR_3 /= ( double ) cluster . count ; cluster . VAR_4 /= cluster . count ; VAR_1 . add ( cluster ) ; }
return ( VAR_2 = = VAR_1 || VAR_3 = = VAR_1 )
public boolean METHOD_1 ( long VAR_1 ) { <START> if ( VAR_2 != VAR_1 && VAR_3 != VAR_1 ) <END> { return false ; } return true ; }
public boolean METHOD_1 ( long VAR_1 ) { return VAR_2 == VAR_1 || VAR_3 == VAR_1 ; }
a null reaches point
public static boolean METHOD_1 ( TYPE_1 VAR_1 ) { <START> if ( VAR_1 . METHOD_2 ( ) < 2 ) <END> return false ; byte b = VAR_1 . METHOD_3 ( ) [ VAR_1 . METHOD_4 ( ) + 1 ] ; return ( b & VAR_2 ) != 0 ; }
public static boolean METHOD_1 ( TYPE_1 VAR_1 ) { if ( VAR_1 == null || VAR_1 . METHOD_2 ( ) < 2 ) { return false ; } byte b = VAR_1 . METHOD_3 ( ) [ VAR_1 . METHOD_4 ( ) + 1 ] ; return ( b & VAR_2 ) != 0 ; }
rid checks VAR_1 _CODE_
public TYPE_1 METHOD_1 ( TYPE_1 VAR_1 ) { <START> if ( VAR_2 && ! VAR_3 && VAR_1 != null && VAR_1 . METHOD_2 ( ) == 2 ) <END> { VAR_4 . METHOD_3 ( VAR_1 ) ; } return VAR_1 ; }
public TYPE_1 METHOD_1 ( TYPE_1 VAR_1 ) { if ( VAR_2 && ! VAR_3 ) { VAR_4 . METHOD_3 ( VAR_1 ) ; } return VAR_1 ; }
please move static method top file sanity check length
<START> public static boolean METHOD_1 ( byte [ ] buffer , int offset , int length ) <END> { return ( buffer [ offset + 1 ] & INT_1 ) != 0 ; }
public static boolean METHOD_1 ( byte [ ] buffer , int offset , int length ) { if ( buffer == null || buffer . length < offset + length || length < 2 ) { return false ; } return ( buffer [ offset + 1 ] & INT_1 ) != 0 ; }
I m a moot point I admit isn t easier read initialize VAR_4 s final doesn t initialized a constructor argument
public TYPE_2 ( int VAR_2 ) { super ( VAR_3 ) ; this . VAR_2 = VAR_2 ; <START> this . VAR_4 = new TYPE_1 ( 0 ) ; <END> this . VAR_5 = 0 ; }
public TYPE_2 ( int VAR_2 ) { super ( VAR_3 ) ; this . VAR_2 = VAR_2 ; this . VAR_5 = 0 ; }
please inline VAR_3
public TYPE_1 node ( ) { final TYPE_1 VAR_1 = TYPE_1 . class . METHOD_1 ( this . cache ) ; final TYPE_1 VAR_2 ; <START> final boolean VAR_3 = VAR_1 instanceof TYPE_2 ; <END> if ( VAR_3 ) { VAR_2 = VAR_1 . METHOD_2 ( true ) ; } else { VAR_2 = this . METHOD_3 ( VAR_1 ) ; } return VAR_2 ; }
public TYPE_1 node ( ) { final TYPE_1 VAR_1 = TYPE_1 . class . METHOD_1 ( this . cache ) ; final TYPE_1 VAR_2 ; if ( VAR_1 instanceof TYPE_2 ) { VAR_2 = VAR_1 . METHOD_2 ( true ) ; } else { VAR_2 = this . METHOD_3 ( VAR_1 ) ; } return VAR_2 ; }
please remove assert don t
private TYPE_1 METHOD_1 ( final TYPE_1 node ) { <START> assert ! ( node instanceof TYPE_2 ) ; <END> final TYPE_2 VAR_1 ; try { VAR_1 = TYPE_3 . METHOD_2 ( ) . METHOD_3 ( ) ; } catch ( final TYPE_4 ex ) { throw new IllegalStateException ( ex ) ; } final TYPE_1 VAR_2 = VAR_1 . METHOD_4 ( node , true ) ; VAR_1 . METHOD_5 ...
private TYPE_1 METHOD_1 ( final TYPE_1 node ) { final TYPE_2 VAR_1 ; try { VAR_1 = TYPE_3 . METHOD_2 ( ) . METHOD_3 ( ) ; } catch ( final TYPE_4 ex ) { throw new IllegalStateException ( ex ) ; } final TYPE_1 VAR_2 = VAR_1 . METHOD_4 ( node , true ) ; VAR_1 . METHOD_5 ( VAR_2 ) ; return VAR_2 ; }
throw RuntimeException ? throw IllegalArgumentException remove _CODE_
public String METHOD_1 ( ) { try { return TYPE_1 . toString ( this . stream ) ; } catch ( final IOException exception ) { <START> throw new RuntimeException ( STRING_1 , exception ) ; <END> } }
public String METHOD_1 ( ) { try { return TYPE_1 . toString ( this . stream ) ; } catch ( final IOException exception ) { throw new IllegalArgumentException ( STRING_1 , exception ) ; } }
pass variable
public String toString ( ) { <START> return METHOD_1 ( STRING_1 ) ; <END> }
public String toString ( ) { return name ; }
need public
<START> public String METHOD_1 ( String VAR_1 ) { <END> return METHOD_2 ( VAR_2 . apply ( VAR_1 ) . METHOD_3 ( STRING_1 , STRING_2 ) . METHOD_3 ( STRING_3 , "" ) . METHOD_4 ( ) ) ; }
private String METHOD_1 ( String VAR_1 ) { return METHOD_2 ( VAR_2 . apply ( VAR_1 ) . METHOD_3 ( STRING_1 , STRING_2 ) . METHOD_3 ( STRING_3 , "" ) . METHOD_4 ( ) ) ; }
I d add a METHOD_1 builder field a Boolean sets field instead defaulting false
private TYPE_1 ( Builder builder ) { this . VAR_2 = METHOD_1 ( builder . VAR_2 ) ; this . VAR_3 = METHOD_1 ( builder . VAR_3 ) ; this . VAR_4 = METHOD_1 ( builder . VAR_4 ) ; this . VAR_5 = METHOD_2 ( METHOD_1 ( builder . VAR_5 ) ) ; this . VAR_6 = METHOD_1 ( builder . VAR_6 ) ; <START> this . VAR_7 = builder . VAR_7 ;...
private TYPE_1 ( Builder builder ) { this . VAR_2 = METHOD_1 ( builder . VAR_2 ) ; this . VAR_3 = METHOD_1 ( builder . VAR_3 ) ; this . VAR_4 = METHOD_1 ( builder . VAR_4 ) ; this . VAR_5 = METHOD_2 ( builder . VAR_5 ) ; this . VAR_6 = METHOD_1 ( builder . VAR_6 ) ; this . VAR_7 = METHOD_1 ( builder . VAR_7 ) ; this . ...
equiv
public void METHOD_1 ( ) { METHOD_2 ( STRING_1 , STRING_2 , STRING_3 , VAR_1 ) ; <START> METHOD_2 ( STRING_4 , STRING_5 , STRING_6 , VAR_2 ) ; <END> }
public void METHOD_1 ( ) { METHOD_2 ( STRING_1 , STRING_2 , STRING_3 , VAR_1 ) ; }
cast feels a bit place I don t a suggestion - autowired add a separate bean a return type TYPE_3 returns object normal _CODE_ bean
private TYPE_1 METHOD_1 ( final TYPE_2 ... VAR_1 ) { return new TYPE_1 ( <START> ( TYPE_3 ) VAR_2 , <END> VAR_3 , METHOD_2 ( ) , METHOD_3 ( ) , VAR_4 , VAR_5 ) . METHOD_4 ( VAR_1 ) ; }
private TYPE_1 METHOD_1 ( final TYPE_2 ... VAR_1 ) { return new TYPE_1 ( VAR_2 , VAR_3 , METHOD_2 ( ) , METHOD_3 ( ) , VAR_4 , VAR_5 ) . METHOD_4 ( VAR_1 ) ; }
style : put line method declarations parameters line long list parameters line linee g public TYPE_1 < TYPE_2 > METHOD_1 ( TYPE_2 VAR_1 Set < ? extends TYPE_2 > VAR_2 TYPE_3 VAR_3 ) {
<START> @Override public TYPE_1 < TYPE_2 > METHOD_1 ( TYPE_2 VAR_1 , Set < ? extends TYPE_2 > VAR_2 , <END> TYPE_3 VAR_3 ) { TYPE_4 . Builder < TYPE_2 > VAR_4 = TYPE_4 . METHOD_2 ( VAR_5 ) ; for ( TYPE_2 VAR_6 : VAR_2 ) { VAR_4 . METHOD_3 ( VAR_6 , METHOD_1 ( VAR_1 , VAR_6 ) ) ; } return VAR_4 . build ( ) ; }
public TYPE_1 < TYPE_2 > METHOD_1 ( TYPE_2 VAR_1 , Set < ? extends TYPE_2 > VAR_2 , TYPE_3 VAR_3 ) { TYPE_4 . Builder < TYPE_2 > VAR_4 = TYPE_4 . METHOD_2 ( VAR_5 ) ; VAR_2 . forEach ( VAR_6 - > VAR_4 . METHOD_3 ( VAR_6 , METHOD_1 ( VAR_1 , VAR_6 ) ) ) ; return VAR_4 . build ( ) ; }
style : stick bottom class neatness don t forget move line
<START> @Override public String toString ( ) { <END> return VAR_1 ; }
public String toString ( ) { return VAR_1 ; }
TYPE_1 objects VAR_1 field ? e g aliases
public boolean contains ( ANNOTATION_1 TYPE_1 VAR_1 ) { return VAR_1 != null && VAR_1 . equals ( VAR_2 . get ( VAR_1 . getId ( ) ) ) ; <START> } <END>
public boolean contains ( ANNOTATION_1 TYPE_1 VAR_1 ) { return VAR_1 != null && VAR_2 . get ( VAR_1 . getId ( ) ) . contains ( VAR_1 ) ; }