Datasets:
YabTad
/
CodeRev

Dataset card Data Studio Files
xet
 Community
ReviewComments
stringlengths
1
2.35k
OriginalCode
stringlengths
28
487
ReviewedCode
stringlengths
14
463
instantiated L47
public Map < String , Object > METHOD_1 ( ) { if ( VAR_1 == null || VAR_1 . length == 0 ) { return Collections . VAR_2 ( ) ; } Map < String , Object > VAR_3 = null ; for ( TYPE_2 . TYPE_3 VAR_4 : VAR_1 ) { if ( VAR_4 != null ) { if ( VAR_3 == null ) { <START> VAR_3 = new HashMap < > ( ) ; <END> } VAR_3 . put ( VAR_4 . ...
public Map < String , Object > METHOD_1 ( ) { if ( VAR_1 == null || VAR_1 . length == 0 ) { return Collections . VAR_2 ( ) ; } Map < String , Object > VAR_3 = new HashMap < > ( ) ; for ( TYPE_2 . TYPE_3 VAR_4 : VAR_1 ) { if ( VAR_4 != null ) { VAR_3 . put ( VAR_4 . getName ( ) , VAR_4 . getValue ( ) ) ; } } return VAR_...
stylistic nitpick : case I d invert conditional top return empty immediately top function wrapping bulk real code conditional block ( idomatic java style ? )
protected Collection < String > METHOD_1 ( TYPE_1 VAR_1 ) { if ( VAR_1 . METHOD_2 ( ) . containsKey ( VAR_2 ) ) { ArrayList < String > VAR_3 = new ArrayList < > ( ) ; for ( String VAR_4 : VAR_1 . METHOD_2 ( ) . get ( VAR_2 ) . split ( STRING_1 ) ) { if ( ! VAR_4 . trim ( ) . equals ( "" ) ) { VAR_3 . add ( VAR_4 ) ; } ...
protected Collection < String > METHOD_1 ( TYPE_1 VAR_1 ) { if ( ! VAR_1 . METHOD_2 ( ) . containsKey ( VAR_2 ) ) { return Collections . VAR_5 ( ) ; } ArrayList < String > VAR_3 = new ArrayList < > ( ) ; for ( String VAR_4 : VAR_1 . METHOD_2 ( ) . get ( VAR_2 ) . split ( STRING_1 ) ) { if ( ! VAR_4 . trim ( ) . equals ...
d worth logging invalid silently ignoring input
public static int METHOD_1 ( String value , int VAR_1 ) { if ( METHOD_2 ( value ) ) { return VAR_1 ; } try { return Integer . parseInt ( value ) ; } catch ( TYPE_1 e ) { <START> return VAR_1 ; <END> } }
public static int METHOD_1 ( String value , int VAR_1 ) { if ( METHOD_2 ( value ) ) { return VAR_1 ; } return Integer . parseInt ( value ) ; }
I don t needs / catch block — shouldn t unrelated HTTP helper
public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { TYPE_1 VAR_2 = new TYPE_1 ( ) ; VAR_2 . METHOD_2 ( METHOD_3 ( VAR_1 ) ) ; try { Class . VAR_3 ( STRING_1 , false , this . getClass ( ) . METHOD_4 ( ) ) ; VAR_2 . METHOD_5 ( new TYPE_3 ( ) ) ; <START> VAR_2 . METHOD_5 ( new TYPE_4 ( VAR_2 ) ) ; <END> } catch ( TYPE_5 e ) { logge...
public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { TYPE_1 VAR_2 = new TYPE_1 ( ) ; VAR_2 . METHOD_2 ( METHOD_3 ( VAR_1 ) ) ; try { Class . VAR_3 ( STRING_1 , false , this . getClass ( ) . METHOD_4 ( ) ) ; VAR_2 . METHOD_5 ( new TYPE_3 ( ) ) ; } catch ( TYPE_5 e ) { logger . debug ( STRING_2 + STRING_3 ) ; } VAR_2 . METHOD_5 ( n...
constructors a lot duplicated code reduced call other
TYPE_8 ( TYPE_1 VAR_2 , List < TYPE_2 > VAR_3 , TYPE_3 VAR_4 ) { this . id = TYPE_8 . VAR_5 . METHOD_1 ( ) ; this . VAR_6 = new TYPE_4 < > ( ) ; this . VAR_4 = VAR_4 ; this . VAR_3 = VAR_3 ; this . VAR_7 . add ( VAR_2 ) ; this . VAR_8 = TYPE_7 . VAR_10 ; VAR_11 = new TYPE_5 ( 1 ) ; VAR_12 = TYPE_6 . VAR_14 ; <START> } ...
TYPE_8 ( TYPE_1 VAR_2 , List < TYPE_2 > VAR_3 , TYPE_3 VAR_4 ) { this ( Arrays . asList ( VAR_2 ) , VAR_4 ) ; this . VAR_3 . addAll ( VAR_3 ) ; }
TYPE_1 VAR_5 applies
void METHOD_1 ( List < Long > VAR_1 ) { if ( VAR_2 . equals ( TYPE_1 . VAR_4 ) || VAR_2 . equals ( TYPE_1 . VAR_5 ) ) { <START> TYPE_2 . VAR_7 . METHOD_2 ( this , VAR_1 ) ; <END> } else { METHOD_3 ( Level . VAR_8 , STRING_1 + VAR_2 . toString ( ) + STRING_2 ) ; } }
void METHOD_1 ( List < Long > VAR_1 ) { if ( VAR_2 . equals ( TYPE_1 . VAR_4 ) ) { TYPE_2 . VAR_7 . METHOD_2 ( this , VAR_1 ) ; } else { METHOD_3 ( Level . VAR_8 , STRING_1 + VAR_2 . toString ( ) + STRING_2 ) ; } }
I believed codacy flagged I replaced VAR_2 && = VAR_1 METHOD_1 ( )
public void add ( TYPE_1 < T > VAR_1 ) { <START> this . VAR_2 = ( this . VAR_2 == false ) <END> ? false : VAR_1 . METHOD_1 ( ) ; this . VAR_3 . addAll ( VAR_1 . METHOD_2 ( ) ) ; }
public void add ( TYPE_1 < T > VAR_1 ) { this . VAR_2 = this . VAR_2 && VAR_1 . METHOD_1 ( ) ; this . VAR_3 . addAll ( VAR_1 . METHOD_2 ( ) ) ; }
method private
void METHOD_1 ( ) { <START> Collection < TYPE_1 > results = Collections . VAR_1 ; <END> try { results = TYPE_1 . METHOD_2 ( VAR_2 . METHOD_3 ( ) ) ; } catch ( TYPE_2 ex ) { TYPE_3 . METHOD_4 ( ex ) ; } METHOD_5 ( results ) ; }
private void METHOD_1 ( ) { Collection < TYPE_1 > results = Collections . VAR_1 ; try { results = TYPE_1 . METHOD_2 ( VAR_2 . METHOD_3 ( ) ) ; } catch ( TYPE_2 ex ) { TYPE_3 . METHOD_4 ( ex ) ; } METHOD_5 ( results ) ; }
method build warning
List < String > METHOD_1 ( ) { List < String > VAR_1 = new ArrayList ( VAR_2 . keySet ( ) ) ; <START> Collections . VAR_3 ( VAR_1 ) ; <END> return VAR_1 ; }
List < String > METHOD_1 ( ) { List < String > VAR_1 = new ArrayList < > ( VAR_2 . keySet ( ) ) ; Collections . VAR_3 ( VAR_1 ) ; return VAR_1 ; }
s remove call thanks
public boolean METHOD_1 ( ) { String VAR_1 = file . VAR_2 ( ) ; if ( StringUtils . isEmpty ( VAR_1 ) ) { TYPE_1 VAR_3 = null ; try { VAR_3 = new TYPE_1 ( ) ; } catch ( TYPE_1 . TYPE_4 ex ) { logger . log ( Level . VAR_4 , STRING_1 ) ; return false ; } VAR_1 = VAR_3 . METHOD_2 ( file ) ; if ( ! StringUtils . isEmpty ( V...
public boolean METHOD_1 ( ) { String VAR_1 = file . VAR_2 ( ) ; if ( StringUtils . isEmpty ( VAR_1 ) ) { TYPE_1 VAR_3 = null ; try { VAR_3 = new TYPE_1 ( ) ; } catch ( TYPE_1 . TYPE_4 ex ) { logger . log ( Level . VAR_4 , STRING_1 ) ; return false ; } VAR_1 = VAR_3 . METHOD_2 ( file ) ; } return TYPE_3 . equals ( VAR_1...
public constructor private class package level constructor
<START> public TYPE_2 ( List < TYPE_1 > VAR_2 , List < TYPE_1 > VAR_3 , int VAR_4 , int VAR_5 ) { <END> this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; this . VAR_4 = VAR_4 ; this . VAR_5 = VAR_5 ; }
TYPE_2 ( List < TYPE_1 > VAR_2 , List < TYPE_1 > VAR_3 , int VAR_4 , int VAR_5 ) { this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; this . VAR_4 = VAR_4 ; this . VAR_5 = VAR_5 ; }
wrong substitution VAR_3 null
protected void METHOD_1 ( TYPE_1 . Set properties ) { if ( TYPE_2 . getInstance ( ) . METHOD_2 ( ) && TYPE_3 . METHOD_3 ( ) ) { properties . put ( new TYPE_4 < > ( VAR_1 , VAR_2 , "" , <START> VAR_3 != null ? VAR_3 : "" ) ) ; <END> if ( VAR_3 == null ) { new TYPE_5 ( VAR_4 , this , new TYPE_6 ( ) ) . METHOD_4 ( ) ; } }...
protected void METHOD_1 ( TYPE_1 . Set properties ) { if ( TYPE_2 . getInstance ( ) . METHOD_2 ( ) && TYPE_3 . METHOD_3 ( ) ) { properties . put ( new TYPE_4 < > ( VAR_1 , VAR_2 , "" , VAR_3 != null ? VAR_4 : "" ) ) ; if ( VAR_3 == null ) { new TYPE_5 ( VAR_4 , this , new TYPE_6 ( ) ) . METHOD_4 ( ) ; } } }
a public setter necessary ? abstraction _CODE_ instance primitive
<START> public void METHOD_1 ( Long VAR_1 ) { <END> this . VAR_1 = VAR_1 ; }
void METHOD_1 ( Long VAR_1 ) { this . VAR_1 = VAR_1 ; }
public constructor - public class
<START> public TYPE_1 ( String key , String value , String VAR_2 ) { <END> this . key = key . trim ( ) ; this . value = value . trim ( ) ; this . VAR_2 = VAR_2 . trim ( ) ; }
TYPE_1 ( String key , String value , String VAR_2 ) { this . key = key . trim ( ) ; this . value = value . trim ( ) ; this . VAR_2 = VAR_2 . trim ( ) ; }
node t a file parent key
public String METHOD_1 ( ) { <START> return TYPE_1 . VAR_2 ; <END> }
public String METHOD_1 ( ) { return getClass ( ) . getName ( ) ; }
public methods package access classes a strange
<START> public static TYPE_1 get ( String VAR_1 ) { <END> if ( VAR_1 == null ) { throw new IllegalArgumentException ( STRING_1 ) ; } switch ( VAR_1 . METHOD_1 ( ) ) { case STRING_2 : return new TYPE_2 ( ) ; case STRING_3 : return new TYPE_3 ( ) ; case STRING_4 : return new TYPE_4 ( ) ; case STRING_5 : return new TYPE_5...
static TYPE_1 get ( String VAR_1 ) { if ( VAR_1 == null ) { throw new IllegalArgumentException ( STRING_1 ) ; } switch ( VAR_1 . trim ( ) . METHOD_1 ( ) ) { case STRING_2 : return new TYPE_2 ( ) ; case STRING_3 : return new TYPE_3 ( ) ; case STRING_4 : return new TYPE_4 ( ) ; case STRING_5 : return new TYPE_5 ( ) ; cas...
throws exception file writer closed consider a resources
static void METHOD_1 ( TYPE_1 model ) throws IOException { METHOD_2 ( ) ; <START> TYPE_2 VAR_1 = new TYPE_2 ( new File ( VAR_2 ) ) ; <END> TYPE_3 VAR_3 ; VAR_3 = new TYPE_3 ( model , new TYPE_4 ( VAR_1 ) ) ; VAR_3 . METHOD_3 ( ) ; VAR_1 . close ( ) ; }
static void METHOD_1 ( TYPE_1 model ) throws IOException { METHOD_2 ( ) ; try ( TYPE_2 VAR_1 = new TYPE_2 ( new File ( VAR_2 ) ) ) { TYPE_3 VAR_3 ; VAR_3 = new TYPE_3 ( model , new TYPE_4 ( VAR_1 ) ) ; VAR_3 . METHOD_3 ( ) ; } }
wrap a TYPE_2 ? query run case database client need catch a TYPE_3 order interact TYPE_1
public TYPE_1 METHOD_1 ( String VAR_1 ) throws TYPE_2 { TYPE_1 VAR_2 = null ; try { VAR_2 = VAR_3 . METHOD_2 ( VAR_1 ) ; } catch ( TYPE_3 ex ) { <START> throw new TYPE_2 ( STRING_1 + ex . getMessage ( ) , ex ) ; <END> } return VAR_2 ; }
public TYPE_1 METHOD_1 ( String VAR_1 ) throws TYPE_3 { TYPE_1 VAR_2 = null ; if ( null != VAR_1 ) { VAR_2 = VAR_3 . METHOD_2 ( VAR_1 ) ; } return VAR_2 ; }
logical imager cancellation shouldn t VAR_4 PR
void METHOD_1 ( ) { VAR_1 ++ ; <START> TYPE_2 . this . METHOD_2 ( TYPE_1 . METHOD_3 ( TYPE_1 . VAR_3 ) ) ; <END> METHOD_4 ( ) ; TYPE_2 . VAR_4 . METHOD_2 ( null ) ; }
void METHOD_1 ( ) { VAR_1 ++ ; METHOD_4 ( ) ; }
necessary ? saving VAR_2 general
public void METHOD_1 ( ) { if ( VAR_1 != null ) { <START> VAR_2 . METHOD_2 ( ) ; <END> VAR_1 . METHOD_3 ( ) ; } }
public void METHOD_1 ( ) { if ( VAR_1 != null ) { VAR_1 . METHOD_3 ( ) ; } }
need public - public class
<START> public int size ( ) { <END> return VAR_1 . size ( ) ; }
int size ( ) { return VAR_1 . size ( ) ; }
need public - public class
<START> public static String METHOD_1 ( ) { <END> return METHOD_2 ( ) . METHOD_3 ( ) + File . VAR_1 + VAR_2 ; }
static String METHOD_1 ( ) { return METHOD_2 ( ) . METHOD_3 ( ) + File . VAR_1 + VAR_2 ; }
I don t report progress Logger status update : add logs call site message logging message report module sufficient
public void METHOD_1 ( String VAR_1 ) { if ( status != TYPE_1 . VAR_3 ) { <START> logger . log ( Level . VAR_4 , STRING_1 , VAR_1 ) ; <END> } }
public void METHOD_1 ( String VAR_1 ) { if ( status != TYPE_1 . VAR_3 ) { logger . log ( Level . VAR_4 , VAR_1 ) ; } }
public - public class public removed
<START> public TYPE_4 ( TYPE_1 < TYPE_2 < ? > > VAR_2 , TYPE_3 listener ) { <END> this . VAR_3 = VAR_2 ; this . listener = listener ; }
TYPE_4 ( TYPE_1 < TYPE_2 < ? > > VAR_2 , TYPE_3 listener ) { this . VAR_3 = VAR_2 ; this . listener = listener ; }
_CODE_ level classes propagate exceptions handling top level classes E g server _CODE_ needs context a menu selection UI a user ? exceptions propagate public METHOD_1 method propagate errors chain exceptions wrapped other exceptions needed
private void METHOD_1 ( Long VAR_1 ) { String VAR_2 = Long . toString ( VAR_1 ) ; String VAR_3 = STRING_1 + VAR_2 ; try { TYPE_1 VAR_4 = VAR_5 . METHOD_2 ( VAR_3 ) ; } catch ( TYPE_2 | IOException ex ) { <START> logger . log ( Level . VAR_6 , STRING_2 + VAR_2 , ex ) ; <END> } }
private void METHOD_1 ( Long VAR_1 ) throws IOException , TYPE_2 { String VAR_2 = Long . toString ( VAR_1 ) ; String VAR_3 = STRING_1 + VAR_2 ; VAR_5 . METHOD_2 ( VAR_3 ) ; }
_CODE_ a private class point debatable codacy suggests accessor methods _CODE_ private
<START> int METHOD_1 ( ) { <END> int VAR_1 = - 1 ; String value = VAR_2 . get ( VAR_3 ) ; if ( value != null ) { VAR_1 = Integer . parseInt ( value ) ; } return VAR_1 ; }
private int METHOD_1 ( ) { int VAR_1 = - 1 ; String value = properties . getProperty ( VAR_3 ) ; if ( value != null ) { VAR_1 = Integer . parseInt ( value ) ; } return VAR_1 ; }
variable named VAR_2 exist prevents pr building
public void METHOD_1 ( TYPE_1 file ) { TYPE_2 . METHOD_2 ( ) . METHOD_3 ( ) . METHOD_4 ( TYPE_3 . METHOD_5 ( TYPE_3 . VAR_1 ) ) ; <START> VAR_2 = file ; <END> VAR_3 . METHOD_6 ( METHOD_7 ( file ) ) ; TYPE_2 . METHOD_2 ( ) . METHOD_3 ( ) . METHOD_4 ( TYPE_3 . METHOD_5 ( TYPE_3 . VAR_4 ) ) ; }
public void METHOD_1 ( TYPE_1 file ) { TYPE_2 . METHOD_2 ( ) . METHOD_3 ( ) . METHOD_4 ( TYPE_3 . METHOD_5 ( TYPE_3 . VAR_1 ) ) ; VAR_3 . METHOD_6 ( METHOD_7 ( file ) ) ; TYPE_2 . METHOD_2 ( ) . METHOD_3 ( ) . METHOD_4 ( TYPE_3 . METHOD_5 ( TYPE_3 . VAR_4 ) ) ; }
hitting ESC doesn t
private void METHOD_1 ( ) { METHOD_2 ( ) . METHOD_3 ( action - > { METHOD_4 ( false ) ; } , TYPE_1 . METHOD_5 ( TYPE_3 . VAR_2 , 0 ) , <START> TYPE_4 . VAR_4 ) ; <END> VAR_5 = new TYPE_2 ( this ) ; add ( VAR_5 ) ; METHOD_6 ( ) ; METHOD_7 ( false ) ; }
private void METHOD_1 ( ) { VAR_5 = new TYPE_2 ( this ) ; add ( VAR_5 ) ; METHOD_6 ( ) ; METHOD_7 ( false ) ; }
necessary null VAR_1 ? won t garbage collected enclosing _CODE_ garbage collected
synchronized private void METHOD_1 ( ) { if ( VAR_1 != null ) { VAR_1 . METHOD_2 ( ) ; try { VAR_1 . METHOD_3 ( INT_1 , TimeUnit . VAR_2 ) ; } catch ( InterruptedException ex ) { logger . log ( Level . VAR_3 , STRING_1 , ex ) ; } <START> VAR_1 = null ; <END> } }
synchronized private void METHOD_1 ( ) { VAR_1 . METHOD_2 ( ) ; try { VAR_1 . METHOD_3 ( INT_1 , TimeUnit . VAR_2 ) ; } catch ( InterruptedException ex ) { logger . log ( Level . VAR_3 , STRING_1 , ex ) ; } }
passing event id super class constructor making a field a confusing personally I prefer approach _CODE_ id object obtained _CODE_ long id = ( Long ) super _CODE_ ( ) extra field required thoughts
public TYPE_3 ( org . VAR_2 . VAR_3 . TYPE_2 . TYPE_3 event ) { super ( TYPE_4 . TYPE_1 . VAR_7 . name ( ) , null , event . VAR_8 ( ) . METHOD_1 ( ) ) ; <START> VAR_9 = event . VAR_8 ( ) ; <END> VAR_10 = VAR_9 . METHOD_1 ( ) ; }
public TYPE_3 ( org . VAR_2 . VAR_3 . TYPE_2 . TYPE_3 event ) { super ( TYPE_4 . TYPE_1 . VAR_7 . name ( ) , null , event . VAR_8 ( ) . METHOD_1 ( ) ) ; VAR_9 = event . VAR_8 ( ) ; }
I d put booleans parentheses easier reading
private void METHOD_1 ( TYPE_1 VAR_1 ) { <START> boolean VAR_2 = VAR_1 == null || VAR_1 . METHOD_2 ( ) == null ; <END> VAR_3 . METHOD_3 ( VAR_2 ) ; VAR_4 . METHOD_3 ( VAR_2 ) ; }
private void METHOD_1 ( TYPE_1 VAR_1 ) { boolean VAR_2 = ( null == VAR_1 ) || ( null == VAR_1 . METHOD_2 ( ) ) ; VAR_3 . METHOD_3 ( VAR_2 ) ; VAR_4 . METHOD_3 ( VAR_2 ) ; }
I protected package access
<START> void METHOD_1 ( boolean status ) { <END> VAR_1 = status ; }
protected void METHOD_1 ( boolean status ) { VAR_1 = status ; }
multithreading issues ? threads accessing root archive object
<START> boolean METHOD_1 ( ) { <END> return VAR_1 ; }
synchronized boolean METHOD_1 ( ) { return VAR_1 ; }
constructor call 5 parameter instead assigning values
<START> TYPE_2 ( String VAR_2 , boolean VAR_3 , boolean VAR_4 ) { <END> this . VAR_2 = TYPE_1 . METHOD_1 ( VAR_2 , TYPE_1 . TYPE_3 . VAR_6 ) ; ; this . VAR_3 = VAR_3 ; this . VAR_4 = VAR_4 ; this . VAR_7 = "" ; this . VAR_8 = VAR_2 ; }
TYPE_2 ( String VAR_2 , boolean VAR_3 , boolean VAR_4 ) { this ( VAR_2 , VAR_3 , VAR_4 , "" , VAR_2 ) ; }
I don t throws exception rid entire throws part allow remove exception handling _CODE_ possibly rid new exception class isn t else
<START> private TYPE_6 ( TYPE_1 file , String VAR_2 ) throws TYPE_2 , TYPE_3 , TYPE_4 { <END> super ( VAR_2 ) ; this . VAR_2 = VAR_2 ; VAR_3 = TYPE_5 . METHOD_1 ( file ) ; if ( VAR_3 == null ) { VAR_4 = true ; VAR_3 = TYPE_5 . METHOD_2 ( file ) ; } }
private TYPE_6 ( TYPE_1 file , String VAR_2 ) { super ( VAR_2 ) ; this . VAR_2 = VAR_2 ; VAR_3 = TYPE_5 . METHOD_1 ( file ) ; if ( VAR_3 == null ) { VAR_4 = true ; VAR_3 = TYPE_5 . METHOD_2 ( file ) ; } }
leftover debug line - edit leftover s logger suggested saving error string display creating exception a lines
} catch ( TYPE_1 e ) { VAR_2 = false ; <START> System . out . println ( STRING_1 + e . toString ( ) ) ; <END> }
} catch ( TYPE_1 e ) { VAR_2 = false ; exception = e ; }
delete frequently fails ( worked a times failing consistantly ) delete case dir _CODE_ causing test fail
public void METHOD_1 ( ) { try { TYPE_1 . METHOD_2 ( ) ; try { Thread . VAR_1 ( INT_1 ) ; } catch ( InterruptedException ex ) { } <START> TYPE_2 . METHOD_3 ( TYPE_3 ) ; <END> } catch ( TYPE_4 | IOException ex ) { TYPE_5 . METHOD_4 ( ex ) ; } METHOD_5 ( TYPE_3 . exists ( ) ) ; }
public void METHOD_1 ( ) { try { TYPE_1 . METHOD_2 ( ) ; } catch ( TYPE_4 ex ) { TYPE_5 . METHOD_4 ( ex ) ; } }
don t need
TYPE_5 ( TYPE_1 VAR_2 ) { super ( TYPE_2 . create ( new TYPE_3 ( VAR_2 ) , true ) , TYPE_4 . METHOD_1 ( VAR_2 ) ) ; <START> VAR_3 = this . METHOD_2 ( ) ; <END> }
TYPE_5 ( TYPE_1 VAR_2 ) { super ( TYPE_2 . create ( new TYPE_3 ( VAR_2 ) , true ) , TYPE_4 . METHOD_1 ( VAR_2 ) ) ; }
fix making a local copy reference VAR_2 checking local reference null finally returning local reference prevent another thread closing case a bit risk returning null violating contract method dealing possibility current case closed other objects a reference a bigger problem another story
public static TYPE_1 METHOD_1 ( ) throws TYPE_2 { try { TYPE_1 VAR_1 = new TYPE_1 ( VAR_2 . METHOD_2 ( ) , VAR_2 . METHOD_3 ( ) , new TYPE_3 ( VAR_2 . METHOD_4 ( ) , VAR_2 . METHOD_5 ( ) , VAR_2 . METHOD_6 ( ) , VAR_2 . METHOD_7 ( ) , VAR_2 . METHOD_8 ( ) , VAR_2 . METHOD_9 ( ) ) ) ; <START> return VAR_1 ; <END> } catc...
public static TYPE_1 METHOD_1 ( ) throws TYPE_2 { TYPE_1 VAR_1 = VAR_2 ; if ( null != VAR_1 ) { return VAR_1 ; } else { throw new TYPE_2 ( ) ; } }
line extra : TYPE_2 METHOD_5 ( ) ;
public TYPE_4 ( ) { VAR_2 = new org . VAR_3 . VAR_4 . view . TYPE_3 ( ) ; METHOD_1 ( ) ; VAR_6 = VAR_2 . METHOD_2 ( ) ; ( ( TYPE_1 ) VAR_6 . METHOD_3 ( ) ) . METHOD_4 ( STRING_1 ) ; TYPE_2 . METHOD_5 ( ) ; <START> VAR_2 . METHOD_6 ( <END> STRING_2 , TYPE_2 . METHOD_7 ( ) , STRING_3 , TYPE_2 . METHOD_8 ( ) ) ; METHOD_9 ...
public TYPE_4 ( ) { VAR_2 = new org . VAR_3 . VAR_4 . view . TYPE_3 ( ) ; METHOD_1 ( ) ; VAR_6 = VAR_2 . METHOD_2 ( ) ; ( ( TYPE_1 ) VAR_6 . METHOD_3 ( ) ) . METHOD_4 ( STRING_1 ) ; VAR_2 . METHOD_6 ( STRING_2 , TYPE_2 . METHOD_7 ( ) , STRING_3 , TYPE_2 . METHOD_8 ( ) ) ; METHOD_9 ( ) ; }
Map ( key ) returns null key contained map
private TYPE_1 METHOD_1 ( String VAR_1 ) { <START> return VAR_2 . containsKey ( VAR_1 ) ? VAR_2 . get ( VAR_1 ) : null ; <END> }
private TYPE_1 METHOD_1 ( String VAR_1 ) { return VAR_2 . get ( VAR_1 ) ; }
s pass unknown args method I a tad simpler
public synchronized TYPE_1 METHOD_1 ( String VAR_1 , String description , TYPE_1 . TYPE_6 VAR_2 ) throws TYPE_3 , TYPE_4 { TYPE_7 . TYPE_8 VAR_3 = TYPE_7 . TYPE_8 . VAR_4 ; if ( METHOD_2 ( ) . contains ( VAR_1 ) ) { VAR_3 = TYPE_7 . TYPE_8 . VAR_5 ; } <START> return METHOD_1 ( VAR_1 , description , VAR_2 , VAR_3 ) ; <E...
public synchronized TYPE_1 METHOD_1 ( String VAR_1 , String description , TYPE_1 . TYPE_6 VAR_2 ) throws TYPE_3 , TYPE_4 { return METHOD_1 ( VAR_1 , description , VAR_2 , VAR_3 , TYPE_7 . TYPE_8 . VAR_4 ) ; }
System properties shouldn t reset test tears ? don t want unexpected side effects other tests run
public void METHOD_1 ( ) throws Exception { <START> System . VAR_1 ( STRING_1 , STRING_2 ) ; <END> System . VAR_1 ( STRING_3 , STRING_4 ) ; System . VAR_1 ( STRING_5 , STRING_6 ) ; System . VAR_1 ( STRING_7 , STRING_8 ) ; System . VAR_1 ( STRING_9 , STRING_10 ) ; this . VAR_2 = new TYPE_1 ( ) ; }
public void METHOD_1 ( ) throws Exception { this . VAR_2 = new TYPE_1 ( ) ; }
braces generally considered a practice situation required language
public int METHOD_1 ( String VAR_1 , Object key , byte [ ] VAR_2 , Object value , byte [ ] VAR_3 , TYPE_1 cluster ) { <START> if ( ( ( String ) key ) . length ( ) % 2 == 0 ) return 0 ; <END> return 1 ; }
public int METHOD_1 ( String VAR_1 , Object key , byte [ ] VAR_2 , Object value , byte [ ] VAR_3 , TYPE_1 cluster ) { if ( ( ( String ) key ) . length ( ) % 2 == 0 ) { return 0 ; } return 1 ; }
odd test serialization : load object toString object assert fields TYPE_3 object ? a glance string processing s a date object middle
public void METHOD_1 ( ) throws IOException { final String VAR_1 = STRING_1 ; final TYPE_1 VAR_2 = new TYPE_1 ( ) ; VAR_2 . METHOD_2 ( new TYPE_2 ( ) ) ; VAR_2 . METHOD_3 ( TYPE_4 . VAR_4 ) ; final String VAR_5 = VAR_2 . METHOD_4 ( VAR_1 , TYPE_3 . class ) <START> . toString ( ) ; <END> assertThat ( VAR_5 , METHOD_5 ( ...
public void METHOD_1 ( ) throws IOException { String VAR_1 = STRING_1 ; TYPE_1 VAR_2 = new TYPE_1 ( ) ; VAR_2 . METHOD_2 ( new TYPE_2 ( ) ) ; VAR_2 . METHOD_3 ( TYPE_4 . VAR_4 ) ; TYPE_3 result = VAR_2 . METHOD_4 ( VAR_1 , TYPE_3 . class ) ; assertThat ( result . toString ( ) , METHOD_5 ( STRING_2 ) ) ; }
stdouts irrelevant s remove
public TYPE_1 < Response > apply ( TYPE_2 request , TYPE_3 < TYPE_2 , Response > VAR_1 ) { System . out . println ( STRING_1 + request . host ( ) . METHOD_1 ( ( ) - > "" ) ) ; <START> System . out . println ( STRING_2 ) ; <END> request . VAR_2 ( ) . forEach ( entry - > System . out . println ( STRING_3 + entry . getKey...
public TYPE_1 < Response > apply ( TYPE_2 request , TYPE_3 < TYPE_2 , Response > VAR_1 ) { logger . info ( STRING_1 + request . host ( ) . METHOD_1 ( ( ) - > "" ) ) ; logger . info ( STRING_2 ) ; request . VAR_2 ( ) . forEach ( entry - > logger . info ( STRING_3 + entry . getKey ( ) + STRING_4 + entry . getValue ( ) ) ...
hey - vlasov - picky extra set brackets
protected void METHOD_1 ( TYPE_1 VAR_1 ) throws Exception { VAR_1 . METHOD_2 ( ) . and ( ) . METHOD_3 ( ) . METHOD_4 ( TYPE_4 . VAR_3 , STRING_1 ) . METHOD_5 ( STRING_2 ) . and ( ) . METHOD_6 ( ) . METHOD_7 ( STRING_3 ) . METHOD_8 ( VAR_4 ) <START> . METHOD_9 ( ( new TYPE_2 ( TYPE_3 . VAR_6 ) ) ) <END> . METHOD_10 ( ) ...
protected void METHOD_1 ( TYPE_1 VAR_1 ) throws Exception { VAR_1 . METHOD_2 ( ) . and ( ) . METHOD_3 ( ) . METHOD_4 ( TYPE_4 . VAR_3 , STRING_1 ) . METHOD_5 ( STRING_2 ) . and ( ) . METHOD_6 ( ) . METHOD_7 ( STRING_3 ) . METHOD_8 ( VAR_4 ) . METHOD_9 ( new TYPE_2 ( TYPE_3 . VAR_6 ) ) . METHOD_10 ( ) . and ( ) . METHOD...
s imports
protected TYPE_1 METHOD_1 ( ) throws Exception { <START> try ( TYPE_5 . TYPE_6 . TYPE_3 VAR_1 = getClass ( ) <END> . METHOD_2 ( ) . METHOD_3 ( STRING_1 ) ) { return new TYPE_4 ( ) . build ( VAR_1 ) ; } }
protected TYPE_1 METHOD_1 ( ) throws Exception { try ( TYPE_3 VAR_1 = getClass ( ) . METHOD_2 ( ) . METHOD_3 ( STRING_1 ) ) { return new TYPE_4 ( ) . build ( VAR_1 ) ; } }
? s format properly annotations method definitions lines
<START> @Override protected TYPE_4 . TYPE_5 . TYPE_2 METHOD_1 ( ) { <END> TYPE_3 VAR_1 = new TYPE_3 ( ) ; VAR_1 . METHOD_2 ( VAR_2 ) ; VAR_1 . METHOD_3 ( STRING_1 ) ; VAR_1 . METHOD_4 ( "" ) ; return VAR_1 ; }
protected TYPE_2 METHOD_1 ( ) { TYPE_3 VAR_1 = new TYPE_3 ( ) ; VAR_1 . METHOD_2 ( VAR_2 ) ; VAR_1 . METHOD_3 ( STRING_1 ) ; VAR_1 . METHOD_4 ( "" ) ; return VAR_1 ; }
I remove exception fails test s reported hide
public void METHOD_1 ( ) { try { TYPE_3 . TYPE_4 response = VAR_1 . get ( ) . uri ( STRING_1 , 1 ) . METHOD_2 ( ) ; response . VAR_2 ( ) . METHOD_3 ( ) . METHOD_4 ( String . VAR_3 ) . METHOD_5 ( STRING_2 ) ; <START> } catch ( TYPE_2 e ) { <END> Assert . VAR_4 ( ) ; } }
public void METHOD_1 ( ) { TYPE_3 . TYPE_4 response = VAR_1 . get ( ) . uri ( STRING_1 , 1 ) . METHOD_2 ( ) ; response . VAR_2 ( ) . METHOD_3 ( ) . METHOD_4 ( String . VAR_3 ) . METHOD_5 ( STRING_2 ) ; }
removed exception thrown _CODE_ VAR_3 expecting
public void METHOD_1 ( ) { exception . VAR_1 ( TYPE_1 . class ) ; VAR_2 . get ( ) . uri ( STRING_1 , 3 ) . METHOD_2 ( ) ; <START> Assert . VAR_3 ( ) ; <END> }
public void METHOD_1 ( ) { exception . VAR_1 ( TYPE_1 . class ) ; VAR_2 . get ( ) . uri ( STRING_1 , 3 ) . METHOD_2 ( ) ; }
wouldn t infinite loop ? risky infinitely I d recommend : javalock VAR_1 ( ) ; { return map put ( STRING_1 + key STRING_2 + key ) ; } finally { VAR_1 METHOD_3 ( ) ; } _CODE_ recommends return result map put don t need extra return null ; bottom
protected TYPE_1 < ? > METHOD_1 ( Map < String , String > map , int key ) { return ( ( ) - > { try { VAR_1 . METHOD_2 ( ) ; map . put ( STRING_1 + key , STRING_2 + key ) ; } catch ( Exception e ) { <START> this . METHOD_1 ( map , key ) ; <END> } finally { try { VAR_1 . METHOD_3 ( ) ; } catch ( Exception e ) { } } retur...
protected TYPE_1 < ? > METHOD_1 ( Map < String , String > map , int key ) { return ( ( ) - > { VAR_1 . METHOD_2 ( ) ; try { return map . put ( STRING_1 + key , STRING_2 + key ) ; } finally { VAR_1 . METHOD_3 ( ) ; } } ) ; }
typically put array designators [ ] type variable
public TYPE_1 METHOD_1 ( String source ) { <START> String data [ ] = source . split ( STRING_1 ) ; <END> return new TYPE_1 ( data [ 0 ] , data [ 1 ] ) ; }
public TYPE_1 METHOD_1 ( String source ) { String [ ] data = source . split ( STRING_1 ) ; return new TYPE_1 ( data [ 0 ] , data [ 1 ] ) ; }
switch order arguments assertEquals ( expected actual ) assertEquals ( 1 VAR_3 getId ( ) ) ; assertEquals ( STRING_2 VAR_3 METHOD_4 ( ) ) ; assertEquals ( STRING_3 VAR_3 METHOD_5 ( ) ) ;
public void METHOD_1 ( ) { String url = VAR_1 + VAR_2 + STRING_1 ; String result = TYPE_1 . METHOD_2 ( url ) ; TYPE_2 VAR_3 = TYPE_3 . create ( ) . METHOD_3 ( result , TYPE_2 . class ) ; assertEquals ( VAR_3 . getId ( ) , 1 ) ; assertEquals ( VAR_3 . METHOD_4 ( ) , STRING_2 ) ; <START> assertEquals ( VAR_3 . METHOD_5 (...
public void METHOD_1 ( ) { String url = VAR_1 + VAR_2 + STRING_1 ; String result = TYPE_1 . METHOD_2 ( url ) ; TYPE_2 VAR_3 = TYPE_3 . create ( ) . METHOD_3 ( result , TYPE_2 . class ) ; assertEquals ( 1 , VAR_3 . getId ( ) ) ; assertEquals ( STRING_2 , VAR_3 . METHOD_4 ( ) ) ; assertEquals ( STRING_3 , VAR_3 . METHOD_...
_CODE_ ( INT_1 result ) ;
public void VAR_1 ( ) { VAR_2 VAR_3 = 4 ; VAR_2 VAR_4 = STRING_1 ; VAR_2 result = switch ( VAR_4 ) { case STRING_2 - > { VAR_5 VAR_3 * 2 ; } case STRING_1 - > { VAR_5 VAR_3 * VAR_3 ; } default - > VAR_3 ; } ; <START> assertEquals ( result , INT_1 ) ; <END> }
public void VAR_1 ( ) { VAR_2 VAR_3 = 4 ; VAR_2 VAR_4 = STRING_1 ; VAR_2 result = switch ( VAR_4 ) { case STRING_2 - > { VAR_5 VAR_3 * 2 ; } case STRING_1 - > { VAR_5 VAR_3 * VAR_3 ; } default - > VAR_3 ; } ; assertEquals ( INT_1 , result ) ; }
@Override line function
<START> @Override protected TYPE_1 METHOD_1 ( ) { <END> return new TYPE_2 ( ) . build ( ) ; }
protected TYPE_1 METHOD_1 ( ) { return new TYPE_2 ( ) . build ( ) ; }
avoid calls System a proper logger
public void METHOD_1 ( ) { TYPE_1 VAR_1 = VAR_2 ; if ( VAR_2 != null ) { do { <START> System . out . METHOD_2 ( VAR_1 . value + STRING_1 ) ; <END> VAR_1 = VAR_1 . VAR_3 ; } while ( VAR_1 != VAR_2 ) ; } }
public void METHOD_1 ( ) { TYPE_1 VAR_1 = VAR_2 ; if ( VAR_2 != null ) { do { LOGGER . info ( VAR_1 . value + STRING_1 ) ; VAR_1 = VAR_1 . VAR_3 ; } while ( VAR_1 != VAR_2 ) ; } }
couldn t a typed Iterator don t casting loop
public void METHOD_1 ( ) { for ( TYPE_1 VAR_1 : VAR_2 ) { <START> Iterator it = VAR_1 . METHOD_2 ( ) . entrySet ( ) . iterator ( ) ; while ( it . hasNext ( ) ) { Map . Entry VAR_3 = ( Map . Entry ) it . next ( ) ; ( ( TYPE_2 ) VAR_3 . getValue ( ) ) . METHOD_3 ( false ) ; } <END> } }
public void METHOD_1 ( ) { for ( TYPE_1 VAR_1 : VAR_2 ) { Iterator < Map . Entry < TYPE_1 , TYPE_2 > > it = VAR_1 . METHOD_2 ( ) . entrySet ( ) . iterator ( ) ; while ( it . hasNext ( ) ) { Map . Entry < TYPE_1 , TYPE_2 > VAR_3 = it . next ( ) ; VAR_3 . getValue ( ) . METHOD_3 ( false ) ; } } }
couldn t import TYPE_5 TYPE_6 Map don t fully qualify
public String METHOD_1 ( TYPE_1 request ) { <START> TYPE_5 . TYPE_6 . Map < String , ? > VAR_1 = TYPE_3 . METHOD_2 ( request ) ; <END> if ( VAR_1 != null ) { TYPE_4 VAR_2 = ( TYPE_4 ) VAR_1 . get ( STRING_1 ) ; return STRING_2 ; } else { return STRING_3 ; } }
public String METHOD_1 ( TYPE_1 request ) { Map < String , ? > VAR_1 = TYPE_3 . METHOD_2 ( request ) ; if ( VAR_1 != null ) { TYPE_4 VAR_2 = ( TYPE_4 ) VAR_1 . get ( STRING_1 ) ; return STRING_2 ; } else { return STRING_3 ; } }
needlessly complex a boolean supplier assertTrue call METHOD_2 ( )
public void METHOD_1 ( ) { <START> assertTrue ( this : : METHOD_2 ) ; <END> }
void METHOD_1 ( ) { assertTrue ( METHOD_2 ( ) ) ; }
need VAR_3 temp variable ? call fluently ( )
private void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) { <START> final TYPE_4 . TYPE_5 VAR_3 = VAR_1 . METHOD_2 ( VAR_2 ) ; <END> VAR_3 . METHOD_3 ( ) . METHOD_4 ( ( VAR_4 , ex ) - > log . info ( STRING_1 ) ) ; }
private void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) { VAR_1 . METHOD_2 ( VAR_2 ) . METHOD_3 ( ) . METHOD_4 ( ( VAR_4 , ex ) - > log . info ( STRING_1 ) ) ; }
I change
private boolean METHOD_1 ( TYPE_1 VAR_1 ) { <START> if ( new Date ( ) . METHOD_2 ( ) - VAR_1 . METHOD_3 ( ) . METHOD_2 ( ) > VAR_2 ) { return true ; } else { return false ; } <END> }
private boolean METHOD_1 ( TYPE_1 VAR_1 ) { return new Date ( ) . METHOD_2 ( ) - VAR_1 . METHOD_3 ( ) . METHOD_2 ( ) > VAR_2 ; }
idea checking keys map null ? applies tests
public void METHOD_1 ( ) throws IOException { reader . VAR_1 ( VAR_2 , VAR_3 ) ; assertNotNull ( VAR_3 ) ; METHOD_2 ( VAR_3 . isEmpty ( ) ) ; for ( final Map . Entry < Object , Object > e : VAR_3 . entrySet ( ) ) { <START> assertNotNull ( e . getKey ( ) ) ; <END> } }
public void METHOD_1 ( ) throws IOException { reader . VAR_1 ( VAR_2 , VAR_3 ) ; assertNotNull ( VAR_3 ) ; METHOD_2 ( VAR_3 . isEmpty ( ) ) ; }
instead creating a File object another TYPE_2 constructor accepts file
public void METHOD_1 ( String VAR_1 , TYPE_1 VAR_2 ) throws IOException { File file = new File ( VAR_1 ) ; <START> TYPE_2 VAR_3 = new TYPE_2 ( file ) ; <END> VAR_2 . METHOD_2 ( VAR_3 ) ; VAR_3 . close ( ) ; }
public void METHOD_1 ( String VAR_1 , TYPE_1 VAR_2 ) throws IOException { TYPE_2 VAR_3 = new TYPE_2 ( VAR_1 ) ; VAR_2 . METHOD_2 ( VAR_3 ) ; VAR_3 . close ( ) ; }
need create VAR_3 variable
private List < TYPE_1 > METHOD_1 ( String VAR_1 , String VAR_2 ) throws TYPE_2 { <START> TYPE_3 VAR_3 = VAR_4 . METHOD_2 ( VAR_1 , VAR_2 ) ; <END> return VAR_3 . METHOD_1 ( ) ; }
private List < TYPE_1 > METHOD_1 ( String VAR_1 , String VAR_2 ) throws TYPE_2 { return VAR_4 . METHOD_2 ( VAR_1 , VAR_2 ) . METHOD_1 ( ) ; }
need create a variable s
private List < TYPE_1 > METHOD_1 ( List < TYPE_1 > VAR_1 , List < TYPE_1 > VAR_2 ) { List < TYPE_1 > VAR_3 = new ArrayList < > ( ) ; for ( TYPE_1 VAR_4 : VAR_1 ) { String VAR_5 = VAR_4 . METHOD_2 ( ) ; for ( TYPE_1 VAR_6 : VAR_2 ) { <START> String VAR_7 = VAR_6 . METHOD_2 ( ) ; <END> if ( VAR_5 . equals ( VAR_7 ) ) { V...
private List < TYPE_1 > METHOD_1 ( List < TYPE_1 > VAR_1 , List < TYPE_1 > VAR_2 ) { List < TYPE_1 > VAR_3 = new ArrayList < > ( ) ; for ( TYPE_1 VAR_4 : VAR_1 ) { String VAR_5 = VAR_4 . METHOD_2 ( ) ; for ( TYPE_1 VAR_6 : VAR_2 ) { if ( VAR_5 . equals ( VAR_6 . METHOD_2 ( ) ) ) { VAR_3 . add ( VAR_4 ) ; } } } return V...
skip storing VAR_2 a variable call return new TYPE_5 ( ) METHOD_3 ( ) METHOD_4 ( VAR_1 new TYPE_6 ( ) ) ;
public static TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) throws IOException { if ( ! VAR_1 . METHOD_2 ( ) ) throw new TYPE_3 ( STRING_1 ) ; TYPE_4 VAR_2 = new TYPE_5 ( ) . METHOD_3 ( ) ; <START> return VAR_2 . METHOD_4 ( VAR_1 , new TYPE_6 ( ) ) ; <END> }
public static TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) throws IOException { if ( ! VAR_1 . METHOD_2 ( ) ) throw new TYPE_3 ( STRING_1 ) ; return new TYPE_5 ( ) . METHOD_3 ( ) . METHOD_4 ( VAR_1 , new TYPE_6 ( ) ) ; }
needed log information ? opinion s useful information log info level
private void METHOD_1 ( TYPE_1 VAR_1 , String VAR_2 ) throws TYPE_2 { try { VAR_1 . METHOD_2 ( VAR_2 ) ; <START> LOGGER . info ( STRING_1 + VAR_2 ) ; <END> } catch ( Exception e ) { TYPE_3 VAR_3 = new TYPE_3 ( ) ; VAR_1 . METHOD_3 ( VAR_2 , VAR_3 ) ; LOGGER . info ( STRING_2 + VAR_2 ) ; } }
private void METHOD_1 ( TYPE_1 VAR_1 , String VAR_2 ) throws TYPE_2 { try { VAR_1 . METHOD_2 ( VAR_2 ) ; } catch ( Exception e ) { TYPE_3 VAR_3 = new TYPE_3 ( ) ; VAR_1 . METHOD_3 ( VAR_2 , VAR_3 ) ; } }
clear passing SSL context constructor * ( test pass environment odd )
public TYPE_6 ( final TYPE_1 VAR_2 , final TYPE_2 uri , final int VAR_3 , final TYPE_3 VAR_4 , final TYPE_4 VAR_5 , final TYPE_5 VAR_6 ) { <START> this ( VAR_2 , uri , VAR_3 , VAR_3 ) ; <END> }
public TYPE_6 ( final TYPE_1 VAR_2 , final TYPE_2 uri , final int VAR_3 , final TYPE_3 VAR_4 , final TYPE_4 VAR_5 , final TYPE_5 VAR_6 ) { this ( VAR_2 , uri , VAR_3 , VAR_3 , VAR_4 , VAR_5 , VAR_6 ) ; }
_CODE_ ( VAR_3 < VAR_5 ) ;
public void METHOD_1 ( ) { TYPE_1 VAR_1 = new TYPE_1 ( VAR_2 . METHOD_2 ( ) , VAR_2 . METHOD_3 ( ) , INT_1 ) ; VAR_1 . METHOD_4 ( STRING_1 ) ; VAR_1 . METHOD_5 ( STRING_2 ) ; long VAR_3 = client . VAR_4 ( ) ; long VAR_5 = VAR_1 . METHOD_6 ( ) ; <START> Assert . assertTrue ( VAR_3 < VAR_5 ) ; <END> VAR_1 . close ( ) ; }
public void METHOD_1 ( ) { TYPE_1 VAR_1 = new TYPE_1 ( VAR_2 . METHOD_2 ( ) , VAR_2 . METHOD_3 ( ) , INT_1 ) ; VAR_1 . METHOD_4 ( STRING_1 ) ; VAR_1 . METHOD_5 ( STRING_2 ) ; long VAR_3 = client . VAR_4 ( ) ; long VAR_5 = VAR_1 . METHOD_6 ( ) ; assertTrue ( VAR_3 < VAR_5 ) ; VAR_1 . close ( ) ; }
throwing runtime exception map null isn t throw _CODE_
public TYPE_1 ( Map < String , Object > map ) { if ( map != null && map . size ( ) > 0 ) { VAR_2 = map ; name = ( String ) map . get ( VAR_3 ) ; VAR_4 = ( long ) map . get ( VAR_5 ) ; VAR_6 = ( long ) map . get ( VAR_7 ) ; <START> } else throw new IllegalArgumentException ( ) ; <END> }
public TYPE_1 ( Map < String , Object > map ) { VAR_2 = map ; name = ( String ) map . get ( VAR_3 ) ; VAR_4 = ( long ) map . get ( VAR_5 ) ; VAR_6 = ( long ) map . get ( VAR_7 ) ; }
don t s a need add a constructor final _CODE_ _CODE_ final _CODE_ _CODE_ final _CODE_ _CODE_
public TYPE_2 ( String VAR_2 , Set < String > VAR_3 , final TYPE_1 VAR_4 , final int VAR_5 , final int VAR_6 , final String VAR_7 , final int VAR_8 , final Boolean VAR_9 ) { <START> this ( VAR_2 , VAR_3 , VAR_4 , VAR_5 , VAR_6 , VAR_7 , VAR_8 , null , VAR_9 ) ; <END> }
public TYPE_2 ( String VAR_2 , Set < String > VAR_3 , final TYPE_1 VAR_4 , final int VAR_5 , final int VAR_6 , final String VAR_7 , final int VAR_8 , final Boolean VAR_9 ) { this ( VAR_2 , VAR_3 , VAR_4 , VAR_5 , VAR_6 , VAR_7 , VAR_8 , null , VAR_9 , null , null , null ) ; }
won t required constructor
public TYPE_2 ( final TYPE_1 VAR_2 , int VAR_3 ) { <START> this ( VAR_2 , VAR_3 , VAR_3 , null , null , false , null , null , null , null ) ; <END> }
public TYPE_2 ( final TYPE_1 VAR_2 , int VAR_3 ) { this ( VAR_2 , VAR_3 , VAR_3 , null , null ) ; }
I accident revert explain change necessary
public void METHOD_1 ( ) { VAR_1 . METHOD_2 ( STRING_1 ) ; <START> TYPE_1 VAR_1 = new TYPE_1 ( STRING_2 ) ; <END> VAR_1 . METHOD_3 ( ) ; }
public void METHOD_1 ( ) { TYPE_1 VAR_1 = new TYPE_1 ( STRING_2 ) ; VAR_1 . METHOD_2 ( STRING_1 ) ; VAR_1 . METHOD_3 ( ) ; }
return null set user
<START> int count ( ) { <END> if ( params . containsKey ( VAR_1 ) ) { return params . get ( VAR_1 ) . getInt ( ) ; } else { return TYPE_1 . getInt ( ) ; } }
Integer count ( ) { if ( params . containsKey ( VAR_1 ) ) { return params . get ( VAR_1 ) . getInt ( ) ; } else { return null ; } }
AFAIK pattern doesn t need restricted STRING_1 keys hashtag slot condition scan redis cluster
public static boolean METHOD_1 ( String VAR_1 ) { String VAR_2 = METHOD_2 ( VAR_1 , true , true ) ; if ( VAR_2 != null && ! VAR_2 . isEmpty ( ) && VAR_1 . startsWith ( VAR_2 ) ) { <START> return VAR_1 . substring ( VAR_2 . length ( ) ) . equals ( STRING_1 ) ; <END> } else { return false ; } }
public static boolean METHOD_1 ( String VAR_1 ) { String VAR_2 = METHOD_2 ( VAR_1 , false ) ; return VAR_2 != null && ! VAR_2 . isEmpty ( ) ; }
s consistent match ( ) count ( ) I s change return type Integer ( users null ) return null s presented user
int count ( ) { if ( params . containsKey ( VAR_1 ) ) { return params . get ( VAR_1 ) . getInt ( ) ; } else { <START> return 0 ; <END> } }
Integer count ( ) { if ( params . containsKey ( VAR_1 ) ) { return params . get ( VAR_1 ) . getInt ( ) ; } else { return null ; } }
parameter sequence swapped : max VAR_1 correct
public void METHOD_1 ( final byte [ ] key , final double max , final double VAR_1 ) { <START> METHOD_2 ( VAR_2 , key , METHOD_3 ( VAR_1 ) , METHOD_3 ( max ) , VAR_3 . VAR_4 ) ; <END> }
public void METHOD_1 ( final byte [ ] key , final double max , final double VAR_1 ) { METHOD_2 ( VAR_2 , key , METHOD_3 ( max ) , METHOD_3 ( VAR_1 ) , VAR_3 . VAR_4 ) ; }
parameter sequence swapped : max VAR_1 correct
public void METHOD_1 ( final byte [ ] key , final double max , final double VAR_1 , final int offset , int count ) { <START> METHOD_2 ( VAR_2 , key , METHOD_3 ( VAR_1 ) , METHOD_3 ( max ) , VAR_3 . VAR_4 , METHOD_3 ( offset ) , <END> METHOD_3 ( count ) ) ; }
public void METHOD_1 ( final byte [ ] key , final double max , final double VAR_1 , final int offset , int count ) { METHOD_2 ( VAR_2 , key , METHOD_3 ( max ) , METHOD_3 ( VAR_1 ) , VAR_3 . VAR_4 , METHOD_3 ( offset ) , METHOD_3 ( count ) ) ; }
parameter sequence swapped : max VAR_1 correct
public void METHOD_1 ( final byte [ ] key , final double max , final double VAR_1 ) { <START> METHOD_2 ( VAR_2 , key , METHOD_3 ( VAR_1 ) , METHOD_3 ( max ) ) ; <END> }
public void METHOD_1 ( final byte [ ] key , final double max , final double VAR_1 ) { METHOD_2 ( VAR_2 , key , METHOD_3 ( max ) , METHOD_3 ( VAR_1 ) ) ; }
guys weren t marked I problem delete _CODE_ marked : + 1 :
<START> public Long METHOD_1 ( final String key ) { <END> return new TYPE_1 < Long > ( VAR_1 , VAR_2 , VAR_3 ) { @Override public Long execute ( TYPE_2 connection ) { return connection . VAR_4 ( key ) ; } } . run ( key ) ; }
public Long METHOD_1 ( final String key ) { return new TYPE_1 < Long > ( VAR_1 , VAR_3 ) { @Override public Long execute ( TYPE_2 connection ) { return connection . VAR_4 ( key ) ; } } . run ( key ) ; }
remove unused local variables VAR_1 VAR_3
public static void METHOD_1 ( ) throws InterruptedException { <START> String [ ] VAR_1 = VAR_2 . METHOD_2 ( ) . split ( STRING_1 ) ; <END> String VAR_3 = VAR_1 [ 0 ] . split ( STRING_2 ) [ 0 ] ; VAR_2 . METHOD_3 ( TYPE_1 . VAR_5 ) ; VAR_6 . METHOD_3 ( TYPE_1 . VAR_5 ) ; }
public static void METHOD_1 ( ) throws InterruptedException { VAR_2 . METHOD_3 ( TYPE_1 . VAR_5 ) ; VAR_6 . METHOD_3 ( TYPE_1 . VAR_5 ) ; }
I don t new TYPE_1 repetition I don t alternative some lambda
public String set ( final byte [ ] key , final byte [ ] value ) { <START> return new TYPE_1 < String > ( VAR_1 , VAR_2 , VAR_3 ) { <END> @Override public String execute ( TYPE_2 connection ) { return connection . set ( key , value ) ; } } . METHOD_1 ( key ) ; }
public String set ( final byte [ ] key , final byte [ ] value ) { return new TYPE_1 < String > ( VAR_1 , VAR_3 ) { @Override public String execute ( TYPE_2 connection ) { return connection . set ( key , value ) ; } } . METHOD_1 ( key ) ; }
calling METHOD_2 ( null ) leads _CODE_ due null / length check dispatch command arbitrary cluster node a dedicated slot required operation
public byte [ ] METHOD_1 ( final byte [ ] VAR_1 ) { return new TYPE_1 < byte [ ] > ( VAR_2 , VAR_3 , VAR_4 ) { @Override public byte [ ] execute ( TYPE_2 connection ) { return connection . VAR_5 ( VAR_1 ) ; } <START> } . METHOD_2 ( null ) ; <END> }
public byte [ ] METHOD_1 ( final byte [ ] VAR_1 ) { return new TYPE_1 < byte [ ] > ( VAR_2 , VAR_4 ) { @Override public byte [ ] execute ( TYPE_2 connection ) { return connection . VAR_5 ( VAR_1 ) ; } } . METHOD_2 ( VAR_1 ) ; }
VAR_1 key call METHOD_2 VAR_1 confused naming I VAR_1 changed key
public List < byte [ ] > METHOD_1 ( final byte [ ] VAR_1 ) { return new TYPE_1 < List < byte [ ] > > ( VAR_2 , VAR_3 , VAR_4 ) { @Override public List < byte [ ] > execute ( TYPE_2 connection ) { return connection . VAR_5 ( VAR_1 ) ; } <START> } . METHOD_2 ( null ) ; <END> }
public List < byte [ ] > METHOD_1 ( final byte [ ] VAR_1 ) { return new TYPE_1 < List < byte [ ] > > ( VAR_2 , VAR_3 , VAR_4 ) { @Override public List < byte [ ] > execute ( TYPE_2 connection ) { return connection . VAR_5 ( VAR_1 ) ; } } . METHOD_2 ( VAR_1 ) ; }
redis cluster specification > redis cluster support multiple databases stand version redis database 0 SELECT allowed VAR_5 method compatible redis cluster exception separate interface cluster commands finally remove method ( String version ) ( binary ) _CODE_ more proper
<START> public Long METHOD_1 ( final byte [ ] key , final int VAR_1 ) { <END> return new TYPE_1 < Long > ( VAR_2 , VAR_3 , VAR_4 ) { @Override public Long execute ( TYPE_2 connection ) { return connection . VAR_5 ( key , VAR_1 ) ; } } . METHOD_2 ( key ) ; }
public Long METHOD_1 ( final byte [ ] key , final int VAR_1 ) { return new TYPE_1 < Long > ( VAR_2 , VAR_3 , VAR_4 ) { @Override public Long execute ( TYPE_2 connection ) { return connection . VAR_5 ( key , VAR_1 ) ; } } . METHOD_2 ( null ) ; }
I run ( key ) more faster TYPE_1 run ( String byte [ ] )
public Object METHOD_1 ( final String VAR_1 , final String key ) { return new TYPE_1 < Object > ( VAR_2 , VAR_3 , VAR_4 ) { @Override public Object execute ( TYPE_2 connection ) { return connection . VAR_5 ( VAR_1 ) ; } <START> } . run ( 1 , key ) ; <END> }
public Object METHOD_1 ( final String VAR_1 , final String key ) { return new TYPE_1 < Object > ( VAR_2 , VAR_3 , VAR_4 ) { @Override public Object execute ( TYPE_2 connection ) { return connection . VAR_5 ( VAR_1 ) ; } } . run ( key ) ; }
I run ( key ) more faster TYPE_1 run ( String byte [ ] )
public List < Boolean > METHOD_1 ( final String key , final String ... VAR_1 ) { return new TYPE_1 < List < Boolean > > ( VAR_2 , VAR_3 , VAR_4 ) { @Override public List < Boolean > execute ( TYPE_2 connection ) { return connection . VAR_5 ( VAR_1 ) ; } <START> } . run ( 1 , key ) ; <END> }
public List < Boolean > METHOD_1 ( final String key , final String ... VAR_1 ) { return new TYPE_1 < List < Boolean > > ( VAR_2 , VAR_3 , VAR_4 ) { @Override public List < Boolean > execute ( TYPE_2 connection ) { return connection . VAR_5 ( VAR_1 ) ; } } . run ( key ) ; }
I run ( key ) more faster TYPE_1 run ( String byte [ ] )
public String METHOD_1 ( final String VAR_1 , final String key ) { return new TYPE_1 < String > ( VAR_2 , VAR_3 , VAR_4 ) { @Override public String execute ( TYPE_2 connection ) { return connection . VAR_5 ( VAR_1 ) ; } <START> } . run ( 1 , key ) ; <END> }
public String METHOD_1 ( final String VAR_1 , final String key ) { return new TYPE_1 < String > ( VAR_2 , VAR_3 , VAR_4 ) { @Override public String execute ( TYPE_2 connection ) { return connection . VAR_5 ( VAR_1 ) ; } } . run ( key ) ; }
hmm s a bit odd METHOD_1 byte [ ] VAR_2 a string - decode byte [ ] result simply versions fields
public TYPE_2 ( byte [ ] VAR_2 , List < T > results ) { <START> this . VAR_2 = TYPE_1 . METHOD_1 ( VAR_2 ) ; <END> this . results = results ; }
public TYPE_2 ( byte [ ] VAR_2 , List < T > results ) { this . VAR_2 = VAR_2 ; this . results = results ; }
add a & finally block return resource case a RuntimeException
private void METHOD_1 ( Set < TYPE_1 > VAR_1 ) { for ( TYPE_1 VAR_2 : VAR_1 ) { TYPE_2 VAR_3 = new TYPE_2 ( VAR_2 . METHOD_2 ( ) , VAR_2 . METHOD_3 ( ) ) ; this . VAR_1 . put ( VAR_2 . METHOD_2 ( ) + VAR_2 . METHOD_3 ( ) , VAR_3 ) ; <START> TYPE_3 VAR_4 = VAR_3 . METHOD_4 ( ) ; <END> METHOD_5 ( VAR_4 ) ; VAR_3 . METHOD...
private void METHOD_1 ( Set < TYPE_1 > VAR_1 ) { for ( TYPE_1 VAR_2 : VAR_1 ) { TYPE_2 VAR_3 = new TYPE_2 ( VAR_2 . METHOD_2 ( ) , VAR_2 . METHOD_3 ( ) ) ; this . VAR_1 . put ( VAR_2 . METHOD_2 ( ) + VAR_2 . METHOD_3 ( ) , VAR_3 ) ; TYPE_3 VAR_4 = VAR_3 . METHOD_4 ( ) ; try { METHOD_5 ( VAR_4 ) ; } finally { VAR_3 . ME...
trailing white space lines
private File METHOD_1 ( File key , String user ) throws IOException { File VAR_1 = METHOD_2 ( STRING_1 , STRING_2 ) ; File VAR_2 = METHOD_3 ( ) ; <START> <END> try ( TYPE_1 VAR_3 = new TYPE_1 ( VAR_1 , this . VAR_4 ) ) { VAR_3 . println ( STRING_3 ) ; VAR_3 . println ( STRING_4 + VAR_2 . METHOD_4 ( ) + STRING_5 + key ....
private File METHOD_1 ( File key , String user ) throws IOException { File VAR_1 = METHOD_2 ( STRING_1 , STRING_2 ) ; File VAR_2 = METHOD_3 ( ) ; try ( TYPE_1 VAR_3 = new TYPE_1 ( VAR_1 , VAR_4 ) ) { VAR_3 . println ( STRING_3 ) ; VAR_3 . println ( STRING_4 + VAR_2 . METHOD_4 ( ) + STRING_5 + key . VAR_5 ( ) + STRING_6...
simpler : _CODE_ METHOD_3 ( VAR_3 - > TYPE_4 METHOD_4 ( getName ( ) ) ) ) ;
public String toString ( ) { final String VAR_1 = VAR_2 != null ? VAR_2 . name ( ) : STRING_1 ; StringBuilder s = new StringBuilder ( STRING_2 + VAR_1 + STRING_3 ) ; if ( VAR_3 != null ) { TYPE_1 . METHOD_1 ( STRING_4 ) . METHOD_2 ( s , <START> TYPE_2 . METHOD_3 ( VAR_3 , ( TYPE_3 from ) - > TYPE_4 . METHOD_4 ( from . ...
public String toString ( ) { final String VAR_1 = VAR_2 != null ? VAR_2 . name ( ) : STRING_1 ; StringBuilder s = new StringBuilder ( STRING_2 + VAR_1 + STRING_3 ) ; if ( VAR_3 != null ) { TYPE_1 . METHOD_1 ( STRING_4 ) . METHOD_2 ( s , TYPE_2 . METHOD_3 ( VAR_3 , from - > TYPE_4 . METHOD_4 ( from . getName ( ) ) ) ) ;...
I want clarify I m a java programmer I sense a common practice java t set a default parameter public void METHOD_1 ( boolean _CODE_ = false )
public void METHOD_1 ( ) throws TYPE_1 , InterruptedException { METHOD_2 ( true ) ; String cmd = STRING_1 ; METHOD_3 ( STRING_2 , cmd ) ; <START> } <END>
public void METHOD_1 ( ) throws TYPE_1 , InterruptedException { this . METHOD_1 ( false ) ; }
repository _CODE_ - - resources - VAR_1 close fails initial error swallowed code : - ( ( surely move parent 1 625 ? )
public < T > T METHOD_1 ( TYPE_1 < T > VAR_1 ) throws IOException , InterruptedException { TYPE_2 repo = METHOD_2 ( ) ; <START> try { <END> return VAR_1 . METHOD_3 ( repo , TYPE_3 . TYPE_4 . VAR_4 ) ; } finally { repo . close ( ) ; } }
public < T > T METHOD_1 ( TYPE_1 < T > VAR_1 ) throws IOException , InterruptedException { try ( TYPE_2 repo = METHOD_2 ( ) ) { return VAR_1 . METHOD_3 ( repo , TYPE_3 . TYPE_4 . VAR_4 ) ; } }
multi - catch - ( surely move parent 1 625 ? )
public List < TYPE_1 > METHOD_1 ( ) throws TYPE_2 { List < TYPE_1 > VAR_1 = new ArrayList < > ( ) ; TYPE_3 VAR_2 = METHOD_2 ( ) ; VAR_2 . METHOD_3 ( ) ; VAR_2 . to ( VAR_1 ) ; try { VAR_2 . execute ( ) ; } catch ( InterruptedException e ) { throw new TYPE_2 ( e ) ; <START> } catch ( IOException e ) { <END> throw new TY...
public List < TYPE_1 > METHOD_1 ( ) throws TYPE_2 { List < TYPE_1 > VAR_1 = new ArrayList < > ( ) ; TYPE_3 VAR_2 = METHOD_2 ( ) ; VAR_2 . METHOD_3 ( ) ; VAR_2 . to ( VAR_1 ) ; try { VAR_2 . execute ( ) ; } catch ( InterruptedException | IOException e ) { throw new TYPE_2 ( e ) ; } return VAR_1 ; }
throw IllegalArgumentException
public TYPE_4 ( TYPE_1 VAR_2 , Collection < TYPE_2 > VAR_3 ) { <START> if ( VAR_2 == null ) throw new TYPE_3 ( STRING_1 ) ; <END> this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; }
public TYPE_4 ( TYPE_1 VAR_2 , Collection < TYPE_2 > VAR_3 ) { this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; }
infinite invocation
public void METHOD_1 ( String VAR_1 , TYPE_1 VAR_2 ) throws TYPE_2 , InterruptedException { <START> METHOD_1 ( VAR_1 , VAR_2 ) ; <END> }
public void METHOD_1 ( String VAR_1 , TYPE_1 VAR_2 ) throws TYPE_2 , InterruptedException { METHOD_1 ( VAR_1 , new TYPE_1 [ ] { VAR_2 } ) ; }
I m I interface—it wordy a cumbersome user prospect TYPE_2 class else I ll work a simplifying
protected TYPE_1 METHOD_1 ( ) throws Exception { return TYPE_1 . builder ( ) <START> . METHOD_2 ( TYPE_2 . builder ( ) <END> . METHOD_3 ( STRING_1 ) . build ( ) ) . METHOD_2 ( TYPE_2 . builder ( ) . METHOD_3 ( STRING_2 ) . build ( ) ) . build ( ) ; }
protected TYPE_1 METHOD_1 ( ) throws Exception { return TYPE_1 . builder ( ) . METHOD_3 ( STRING_1 , STRING_2 ) . build ( ) ; }
I move a finally block method
protected String METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 metadata ) { try { <START> TYPE_3 . METHOD_2 ( VAR_1 ) ; <END> TYPE_4 VAR_2 = VAR_3 . METHOD_1 ( null , metadata ) ; if ( logger . VAR_4 ( ) ) { logger . trace ( STRING_1 + metadata . get ( TYPE_2 . VAR_5 ) + STRING_2 + VAR_2 ) ; } return VAR_2 . toString ( ) ; } catch ...
protected String METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 metadata ) { try { TYPE_4 VAR_2 = VAR_3 . METHOD_1 ( null , metadata ) ; if ( logger . VAR_4 ( ) ) { logger . trace ( STRING_1 + metadata . get ( TYPE_2 . VAR_5 ) + STRING_2 + VAR_2 ) ; } return VAR_2 . toString ( ) ; } catch ( Exception e ) { logger . debug ( e , STRIN...