Datasets:
YabTad
/
CodeRev

Dataset card Data Studio Files
xet
 Community
ReviewComments
stringlengths
1
2.35k
OriginalCode
stringlengths
28
487
ReviewedCode
stringlengths
14
463
s reasoning helper initializing constructor initializing declaration
public TYPE_3 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 ) { VAR_4 = VAR_2 ; VAR_5 = VAR_3 ; <START> METHOD_1 ( ) ; <END> }
public TYPE_3 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 ) { VAR_4 = VAR_2 ; VAR_5 = VAR_3 ; }
java 8 lambda function simplify
public synchronized List < TYPE_1 > METHOD_1 ( final TYPE_2 options ) throws IOException { <START> return METHOD_2 ( new TYPE_3 < List < TYPE_1 > > ( ) { <END> @Override public List < TYPE_1 > call ( ) throws TYPE_4 { List < TYPE_1 > result = new ArrayList < > ( ) ; for ( TYPE_7 . TYPE_8 . TYPE_1 VAR_1 : VAR_2 . METHOD...
public synchronized List < TYPE_1 > METHOD_1 ( final TYPE_2 options ) throws IOException { return METHOD_2 ( ( ) - > { List < TYPE_1 > result = new ArrayList < > ( ) ; for ( TYPE_7 . TYPE_8 . TYPE_1 VAR_1 : VAR_2 . METHOD_1 ( options . VAR_3 ( ) ) . METHOD_3 ( ) ) { result . add ( TYPE_6 . METHOD_4 ( VAR_1 ) ) ; } retu...
java 8 lambda function
public TYPE_1 METHOD_1 ( TYPE_2 options ) throws TYPE_3 { <START> return TYPE_4 . call ( LOG , new TYPE_5 < TYPE_1 > ( ) { <END> @Override public TYPE_1 call ( ) throws TYPE_6 , TYPE_7 { List < TYPE_8 > VAR_1 = new ArrayList < > ( ) ; for ( TYPE_11 . TYPE_12 . TYPE_8 VAR_2 : VAR_3 . METHOD_1 ( ) ) { VAR_1 . add ( TYPE_...
public TYPE_1 METHOD_1 ( TYPE_2 options ) throws TYPE_3 { return TYPE_4 . call ( LOG , ( TYPE_5 < TYPE_1 > ) ( ) - > { List < TYPE_8 > VAR_1 = new ArrayList < > ( ) ; for ( TYPE_11 . TYPE_12 . TYPE_8 VAR_2 : VAR_3 . METHOD_1 ( ) ) { VAR_1 . add ( TYPE_10 . METHOD_2 ( VAR_2 ) ) ; } return new TYPE_1 ( VAR_1 ) ; } ) ; }
sort
public TYPE_1 METHOD_1 ( ) { return new TYPE_1 ( ) <START> . METHOD_2 ( VAR_1 ) <END> . METHOD_2 ( VAR_2 ) . METHOD_2 ( VAR_3 ) . METHOD_2 ( VAR_4 ) ; }
public TYPE_1 METHOD_1 ( ) { return new TYPE_1 ( ) . METHOD_2 ( VAR_4 ) . METHOD_2 ( VAR_1 ) . METHOD_2 ( VAR_2 ) . METHOD_2 ( VAR_3 ) ; }
I sort lines subcommands
public String METHOD_1 ( ) { return STRING_1 + STRING_2 + STRING_3 + STRING_4 <START> + STRING_5 <END> + STRING_6 ; }
public String METHOD_1 ( ) { return STRING_1 + STRING_2 + STRING_3 + STRING_4 + STRING_6 + STRING_5 ; }
wire types basic objects store retrieve data simple getters setters shouldn t - trivial code need filter negative capacities done class a defensive copy new HashMap < > ( VAR_1 )
public TYPE_1 METHOD_1 ( Map < String , Long > VAR_1 ) { VAR_2 = new HashMap < > ( ) ; for ( Map . Entry < String , Long > entry : VAR_1 . entrySet ( ) ) { long VAR_3 = entry . getValue ( ) ; <START> if ( VAR_3 > 0 ) { <END> VAR_2 . put ( entry . getKey ( ) , VAR_3 ) ; } } return this ; }
public TYPE_1 METHOD_1 ( Map < String , Long > VAR_1 ) { VAR_2 = new HashMap < > ( VAR_1 ) ; return this ; }
sort member var names ? future adding a new member a deterministic location
public int METHOD_1 ( ) { <START> return TYPE_1 . METHOD_1 ( VAR_1 , VAR_2 , VAR_3 , VAR_4 , <END> VAR_5 , VAR_6 , VAR_7 ) ; }
public int METHOD_1 ( ) { return TYPE_1 . METHOD_1 ( VAR_3 , VAR_6 , VAR_5 , VAR_1 , VAR_2 , VAR_4 , VAR_7 ) ; }
class member variable null default typically don t init null
public TYPE_2 ( TYPE_1 conf ) { super ( conf ) ; <START> VAR_2 = null ; <END> }
public TYPE_2 ( TYPE_1 conf ) { super ( conf ) ; }
simplify code a minor optimization ( avoid creating unused HashSet instance ) : _CODE_ < TYPE_6 TYPE_7 TYPE_2 > VAR_2 = null ; ( VAR_1 ! = null ) { VAR_2 = new HashSet < > ( ) ; ( TYPE_2 field : VAR_1 ) { } }
public synchronized TYPE_1 METHOD_1 ( final Set < TYPE_2 > VAR_1 ) throws IOException { return METHOD_2 ( ( ) - > { <START> Set < TYPE_6 . TYPE_7 . TYPE_2 > VAR_2 = new HashSet < > ( ) ; <END> if ( VAR_1 == null ) { VAR_2 = null ; } else { for ( TYPE_2 field : VAR_1 ) { VAR_2 . add ( field . VAR_3 ( ) ) ; } } return TY...
public synchronized TYPE_1 METHOD_1 ( final Set < TYPE_2 > VAR_1 ) throws IOException { return METHOD_2 ( ( ) - > { Set < TYPE_6 . TYPE_7 . TYPE_2 > VAR_2 = null ; if ( VAR_1 != null ) { VAR_2 = new HashSet < > ( ) ; for ( TYPE_2 field : VAR_1 ) { VAR_2 . add ( field . VAR_3 ( ) ) ; } } return TYPE_4 . METHOD_3 ( VAR_4...
isn t arg summary
public void METHOD_1 ( String ... args ) throws TYPE_1 { <START> if ( args . length > 2 ) { <END> throw new TYPE_1 ( TYPE_3 . TYPE_4 . getMessage ( METHOD_2 ( ) ) ) ; } }
public void METHOD_1 ( String ... args ) throws TYPE_1 { if ( args . length > 1 ) { throw new TYPE_1 ( TYPE_3 . TYPE_4 . getMessage ( METHOD_2 ( ) ) ) ; } }
wrap System another TYPE_4
public TYPE_5 ( ) { VAR_2 = new TYPE_1 ( TYPE_2 . METHOD_1 ( ) ) ; VAR_3 = new TYPE_3 ( TYPE_2 . METHOD_1 ( ) ) ; <START> VAR_4 = new TYPE_4 ( System . out ) ; <END> }
public TYPE_5 ( ) { VAR_2 = new TYPE_1 ( TYPE_2 . METHOD_1 ( ) ) ; VAR_3 = new TYPE_3 ( TYPE_2 . METHOD_1 ( ) ) ; VAR_4 = System . out ; }
null check enough convince checker framework object - null point
public boolean remove ( ANNOTATION_1 Object object ) { if ( object == null ) { return false ; } <START> assert object != null : STRING_1 ; <END> synchronized ( object ) { if ( VAR_1 != null && VAR_1 . METHOD_1 ( ( T ) object ) ) { ANNOTATION_2 ( STRING_2 ) T VAR_2 = ( T ) object ; METHOD_2 ( VAR_2 ) ; return true ; } e...
public boolean remove ( ANNOTATION_1 Object object ) { if ( object == null ) { return false ; } synchronized ( object ) { if ( VAR_1 . METHOD_1 ( ( T ) object ) ) { ANNOTATION_2 ( STRING_2 ) T VAR_2 = ( T ) object ; METHOD_2 ( VAR_2 ) ; return true ; } else { return false ; } } }
wasn t alphabetized nice
public TYPE_1 METHOD_1 ( ) { return new TYPE_1 ( ) . METHOD_2 ( VAR_1 ) . METHOD_2 ( VAR_2 ) . METHOD_2 ( VAR_3 ) . METHOD_2 ( VAR_4 ) . METHOD_2 ( VAR_5 ) <START> . METHOD_2 ( VAR_6 ) <END> . METHOD_2 ( VAR_7 ) ; }
public TYPE_1 METHOD_1 ( ) { return new TYPE_1 ( ) . METHOD_2 ( VAR_2 ) . METHOD_2 ( VAR_3 ) . METHOD_2 ( VAR_5 ) . METHOD_2 ( VAR_4 ) . METHOD_2 ( VAR_1 ) . METHOD_2 ( VAR_7 ) . METHOD_2 ( VAR_6 ) ; }
return correct ? another thread brings safe mode safe mode
public boolean METHOD_1 ( ) { if ( ! VAR_1 . METHOD_2 ( ) ) { return false ; } Long VAR_2 = VAR_1 . METHOD_3 ( ) ; if ( VAR_2 == null ) { return true ; } long VAR_3 = TYPE_1 . METHOD_4 ( TYPE_2 . VAR_5 ) ; if ( VAR_6 . METHOD_5 ( ) - VAR_2 < VAR_3 ) { return true ; } <START> return ! VAR_1 . METHOD_6 ( VAR_2 , null , t...
public boolean METHOD_1 ( ) { if ( ! VAR_1 . METHOD_2 ( ) ) { return false ; } Long VAR_2 = VAR_1 . METHOD_3 ( ) ; if ( VAR_2 == null ) { return true ; } long VAR_3 = TYPE_1 . METHOD_4 ( TYPE_2 . VAR_5 ) ; if ( VAR_6 . METHOD_5 ( ) - VAR_2 < VAR_3 ) { return true ; } VAR_1 . METHOD_6 ( VAR_2 , null , true , false ) ; r...
method defined interface more sense _CODE_ class call method skip task instead task
public boolean METHOD_1 ( Map < String , String > VAR_1 ) { <START> if ( METHOD_2 ( ) ) { <END> return true ; } if ( ! METHOD_3 ( VAR_1 ) ) { return false ; } return true ; }
public boolean METHOD_1 ( Map < String , String > VAR_1 ) { if ( ! METHOD_3 ( VAR_1 ) ) { return false ; } return true ; }
immediately calling _CODE_ serve ( ) METHOD_9
protected void METHOD_1 ( String VAR_1 , String VAR_2 ) { TYPE_1 . METHOD_2 ( ) ; <START> VAR_3 . METHOD_3 ( ) ; <END> METHOD_4 ( ) ; METHOD_5 ( ) ; LOG . info ( STRING_1 + STRING_2 , TYPE_4 . VAR_5 , VAR_1 , TYPE_2 . METHOD_6 ( TYPE_3 . VAR_7 ) , TYPE_2 . METHOD_7 ( TYPE_3 . VAR_7 ) , TYPE_2 . METHOD_8 ( TYPE_3 . VAR_...
protected void METHOD_1 ( String VAR_1 , String VAR_2 ) { TYPE_1 . METHOD_2 ( ) ; METHOD_4 ( ) ; METHOD_5 ( ) ; LOG . info ( STRING_1 + STRING_2 , TYPE_4 . VAR_5 , VAR_1 , TYPE_2 . METHOD_6 ( TYPE_3 . VAR_7 ) , TYPE_2 . METHOD_7 ( TYPE_3 . VAR_7 ) , TYPE_2 . METHOD_8 ( TYPE_3 . VAR_7 ) , TYPE_2 . METHOD_8 ( TYPE_3 . VA...
guaranteed IOException path existing
private void METHOD_1 ( long offset ) throws TYPE_1 , IOException { TYPE_2 VAR_1 = VAR_2 . get ( VAR_3 . METHOD_2 ( ) ) . METHOD_3 ( ) ; VAR_1 . METHOD_4 ( TYPE_3 . METHOD_5 ( TYPE_3 . TYPE_7 . VAR_5 ) ) ; try { METHOD_6 ( offset ) ; } catch ( IOException e ) { throw new TYPE_1 ( TYPE_5 . TYPE_6 . getMessage ( VAR_3 . ...
private void METHOD_1 ( long offset ) throws IOException { TYPE_2 VAR_1 = VAR_2 . get ( VAR_3 . METHOD_2 ( ) ) . METHOD_3 ( ) ; VAR_1 . METHOD_4 ( TYPE_3 . METHOD_5 ( TYPE_3 . TYPE_7 . VAR_5 ) ) ; METHOD_6 ( offset ) ; METHOD_8 ( offset ) ; }
configuration call expensive ? I suggest lookup open call values else
protected TYPE_6 ( TYPE_1 uri , TYPE_2 VAR_2 ) { super ( uri , VAR_2 ) ; int VAR_3 = TYPE_3 . getInt ( TYPE_5 . VAR_5 ) ; VAR_6 = TYPE_4 . METHOD_1 ( STRING_1 , VAR_3 ) . create ( ) ; VAR_7 = ( int ) TYPE_3 . METHOD_2 ( TYPE_5 . VAR_8 ) ; VAR_9 = ( int ) TYPE_3 . METHOD_2 ( TYPE_5 . VAR_10 ) ; VAR_11 = <START> TYPE_3 ....
protected TYPE_6 ( TYPE_1 uri , TYPE_2 VAR_2 ) { super ( uri , VAR_2 ) ; int VAR_3 = TYPE_3 . getInt ( TYPE_5 . VAR_5 ) ; VAR_6 = TYPE_4 . METHOD_1 ( STRING_1 , VAR_3 ) . create ( ) ; }
a good idea kill thread arbitrarily
public long METHOD_1 ( ) { try { return ( ( TYPE_1 ) in ) . METHOD_1 ( ) ; } catch ( IOException e ) { <START> throw new RuntimeException ( STRING_1 + e ) ; <END> } }
public long METHOD_1 ( ) throws IOException { return ( ( TYPE_1 ) in ) . METHOD_1 ( ) ; }
move _CODE_
public static TYPE_1 create ( final String VAR_1 ) throws IOException { if ( ! TYPE_2 . METHOD_1 ( TYPE_3 . get ( VAR_1 ) ) ) { TYPE_2 . METHOD_2 ( TYPE_3 . get ( VAR_1 ) ) ; } <START> TYPE_4 . set ( TYPE_5 . VAR_3 , STRING_1 ) ; <END> return new TYPE_1 ( ) ; }
public static TYPE_1 create ( final String VAR_1 ) throws IOException { if ( ! TYPE_2 . METHOD_1 ( TYPE_3 . get ( VAR_1 ) ) ) { TYPE_2 . METHOD_2 ( TYPE_3 . get ( VAR_1 ) ) ; } return new TYPE_1 ( ) ; }
! entry VAR_3 ( )
public void METHOD_1 ( TYPE_1 entry ) throws TYPE_2 { TYPE_3 VAR_1 = TYPE_3 . METHOD_2 ( entry ) ; if ( VAR_1 . getName ( ) . equals ( VAR_2 ) ) { METHOD_3 ( ) ; METHOD_4 ( VAR_1 ) ; <START> if ( TYPE_4 . METHOD_5 ( ) && entry . VAR_3 ( ) ) { <END> VAR_4 . METHOD_6 ( Constants . VAR_5 ) ; } } else { METHOD_7 ( VAR_1 , ...
public void METHOD_1 ( TYPE_1 entry ) throws TYPE_2 { TYPE_3 VAR_1 = TYPE_3 . METHOD_2 ( entry ) ; if ( VAR_1 . getName ( ) . equals ( VAR_2 ) ) { METHOD_3 ( ) ; METHOD_4 ( VAR_1 ) ; } else { METHOD_7 ( VAR_1 ) ; } }
sort
public boolean equals ( Object o ) { if ( this == o ) { return true ; } if ( ! ( o instanceof TYPE_1 ) ) { return false ; } TYPE_1 that = ( TYPE_1 ) o ; <START> return TYPE_2 . METHOD_1 ( VAR_1 , that . VAR_1 ) <END> && TYPE_2 . METHOD_1 ( VAR_2 , that . VAR_2 ) && TYPE_2 . METHOD_1 ( VAR_3 , that . VAR_3 ) ; }
public boolean equals ( Object o ) { if ( this == o ) { return true ; } if ( ! ( o instanceof TYPE_1 ) ) { return false ; } TYPE_1 that = ( TYPE_1 ) o ; return TYPE_2 . METHOD_1 ( VAR_2 , that . VAR_2 ) && TYPE_2 . METHOD_1 ( VAR_1 , that . VAR_1 ) && TYPE_2 . METHOD_1 ( VAR_3 , that . VAR_3 ) ; }
ditto others
public int METHOD_1 ( ) { <START> return TYPE_1 . METHOD_1 ( VAR_1 , VAR_2 ) ; <END> }
public int METHOD_1 ( ) { return TYPE_1 . METHOD_1 ( VAR_2 , VAR_1 ) ; }
sort
public int METHOD_1 ( ) { return TYPE_1 <START> . METHOD_1 ( VAR_1 , VAR_2 , VAR_3 , VAR_4 , VAR_5 , VAR_6 , VAR_7 ) ; <END> }
public int METHOD_1 ( ) { return TYPE_1 . METHOD_1 ( VAR_1 , VAR_7 , VAR_2 , VAR_3 , VAR_4 , VAR_5 , VAR_6 ) ; }
( ) shorter version VAR_1 METHOD_1 ( VAR_2 VAR_3 true ) ;
public static void METHOD_1 ( String message ) { System . err . println ( message ) ; TYPE_1 VAR_1 = new TYPE_1 ( ) ; <START> VAR_1 . METHOD_1 ( VAR_2 , null , VAR_3 , null , true ) ; <END> }
public static void METHOD_1 ( String message ) { System . err . println ( message ) ; TYPE_1 VAR_1 = new TYPE_1 ( ) ; VAR_1 . METHOD_1 ( VAR_2 , VAR_3 , true ) ; }
state VAR_2 instead other member variables
protected void METHOD_1 ( ) throws IOException { long VAR_1 = VAR_2 . METHOD_2 ( ) ; if ( VAR_1 == VAR_3 && VAR_4 != null && VAR_4 . METHOD_3 ( ) != 0 ) { return ; } METHOD_4 ( ) ; METHOD_5 ( VAR_1 ) ; if ( VAR_5 ) { METHOD_6 ( VAR_1 ) ; } VAR_3 = VAR_1 ; VAR_6 = VAR_2 . METHOD_7 ( ) ; <START> VAR_7 = VAR_2 . METHOD_8 ...
private void METHOD_1 ( ) throws IOException { long VAR_1 = VAR_2 . METHOD_2 ( ) ; if ( VAR_4 != null && VAR_4 . getId ( ) == VAR_1 && VAR_4 . METHOD_3 ( ) != 0 ) { return ; } METHOD_4 ( ) ; METHOD_5 ( VAR_1 ) ; if ( VAR_5 ) { METHOD_6 ( VAR_1 ) ; } }
want METHOD_5 METHOD_3 VAR_1 returns failure
public void METHOD_1 ( TYPE_1 VAR_1 ) { if ( ! VAR_1 . METHOD_2 ( ) ) { VAR_1 . channel ( ) . close ( ) ; } try ( TYPE_2 VAR_2 = new TYPE_2 ( VAR_3 ) ) { if ( VAR_1 . METHOD_3 ( ) != null ) { METHOD_4 ( VAR_1 . METHOD_3 ( ) ) ; VAR_4 . METHOD_5 ( ) ; VAR_5 . METHOD_5 ( ) ; VAR_6 . METHOD_5 ( ) ; <START> } <END> } }
public void METHOD_1 ( TYPE_1 VAR_1 ) { if ( ! VAR_1 . METHOD_2 ( ) ) { VAR_1 . channel ( ) . close ( ) ; try ( TYPE_2 VAR_2 = new TYPE_2 ( VAR_3 ) ) { METHOD_4 ( VAR_1 . METHOD_3 ( ) ) ; VAR_4 . METHOD_5 ( ) ; VAR_5 . METHOD_5 ( ) ; VAR_6 . METHOD_5 ( ) ; } } }
var
public void METHOD_1 ( ) throws Exception { VAR_1 = TYPE_1 . METHOD_2 ( ) . METHOD_3 ( STRING_1 ) . METHOD_4 ( TYPE_3 . VAR_3 , STRING_2 ) . METHOD_5 ( 3 ) . METHOD_6 ( 2 ) . build ( ) ; <START> boolean VAR_4 = false ; <END> try { VAR_1 . start ( ) ; TYPE_2 VAR_5 = VAR_1 . METHOD_7 ( ) ; METHOD_8 ( VAR_5 ) ; VAR_6 = tr...
public void METHOD_1 ( ) throws Exception { VAR_1 = TYPE_1 . METHOD_2 ( ) . METHOD_3 ( STRING_1 ) . METHOD_4 ( TYPE_3 . VAR_3 , STRING_2 ) . METHOD_5 ( 3 ) . METHOD_6 ( 2 ) . build ( ) ; try { VAR_1 . start ( ) ; TYPE_2 VAR_5 = VAR_1 . METHOD_7 ( ) ; METHOD_8 ( VAR_5 ) ; VAR_6 = true ; } finally { METHOD_9 ( ) ; } }
thread started s set null
public TYPE_1 METHOD_1 ( ) { VAR_1 = null ; <START> VAR_2 = true ; <END> return this ; }
public void METHOD_1 ( ) { VAR_1 = null ; }
throw IOException
<START> private boolean METHOD_1 ( ) throws IOException { <END> return VAR_1 && VAR_2 ; }
private boolean METHOD_1 ( ) { return VAR_1 && VAR_2 ; }
throw TYPE_3 test fails detect error
public void METHOD_1 ( ) throws Exception { final String VAR_1 = STRING_1 ; try { new TYPE_1 ( VAR_2 , VAR_3 , VAR_4 + TYPE_5 . VAR_6 + VAR_1 , VAR_7 , TYPE_4 . VAR_9 , null , TYPE_2 . METHOD_2 ( ) . METHOD_3 ( TYPE_2 . VAR_10 ) ) . run ( ) ; <START> Assert . VAR_11 ( STRING_2 ) ; <END> } catch ( TYPE_3 e ) { } }
public void METHOD_1 ( ) throws Exception { final String VAR_1 = STRING_1 ; try { new TYPE_1 ( VAR_2 , VAR_3 , VAR_4 + TYPE_5 . VAR_6 + VAR_1 , VAR_7 , TYPE_4 . VAR_9 , null , TYPE_2 . METHOD_2 ( ) . METHOD_3 ( TYPE_2 . VAR_10 ) ) . run ( ) ; } catch ( TYPE_3 e ) { return ; } Assert . VAR_11 ( STRING_2 ) ; }
VAR_5 a string input add bash - c place call
private TYPE_1 ( String name , String command , Integer VAR_2 , Integer VAR_3 ) { VAR_4 = name ; <START> VAR_5 = new String [ ] { STRING_1 , STRING_2 , command } ; <END> VAR_6 = VAR_2 ; VAR_7 = VAR_3 ; }
private TYPE_1 ( String name , String command , Integer VAR_2 , Integer VAR_3 ) { VAR_4 = name ; VAR_5 = command ; VAR_6 = VAR_2 ; VAR_7 = VAR_3 ; }
include error message
public static void METHOD_1 ( final TYPE_1 VAR_1 ) { TYPE_2 . METHOD_2 ( ) . METHOD_3 ( new Thread ( ) { @Override public void run ( ) { try { VAR_1 . METHOD_4 ( ) ; } catch ( Exception e ) { <START> LOG . error ( STRING_1 ) ; <END> System . VAR_2 ( 0 ) ; } } } ) ; }
public static void METHOD_1 ( final TYPE_1 VAR_1 ) { TYPE_2 . METHOD_2 ( ) . METHOD_3 ( new Thread ( ) { @Override public void run ( ) { try { VAR_1 . METHOD_4 ( ) ; } catch ( Exception e ) { LOG . error ( STRING_1 , e ) ; System . VAR_2 ( 0 ) ; } } } ) ; }
synchronizes entire method ? define method : public synchronized void METHOD_1 ( )
public void METHOD_1 ( ) { <START> synchronized ( this ) { <END> if ( ! VAR_1 ) { VAR_2 . METHOD_2 ( ) ; try { VAR_2 . METHOD_3 ( ) ; } catch ( InterruptedException e ) { Thread . VAR_3 ( ) . METHOD_2 ( ) ; } finally { VAR_1 = true ; VAR_2 = null ; LOG . info ( STRING_1 ) ; } } } }
public synchronized void METHOD_1 ( ) { if ( ! VAR_1 ) { VAR_2 . METHOD_2 ( ) ; try { VAR_2 . METHOD_3 ( ) ; } catch ( InterruptedException e ) { Thread . VAR_3 ( ) . METHOD_2 ( ) ; } finally { VAR_1 = true ; VAR_2 = null ; LOG . info ( STRING_1 ) ; } } }
extra space
<START> public synchronized TYPE_1 METHOD_1 ( ) { <END> TYPE_1 < ? > VAR_1 = VAR_2 . get ( VAR_2 . size ( ) - 1 ) ; return VAR_1 ; }
public synchronized TYPE_1 METHOD_1 ( ) { return VAR_2 . get ( VAR_2 . size ( ) - 1 ) ; }
put conditions
public static boolean METHOD_1 ( String input ) { if ( TYPE_1 . containsKey ( input ) ) { return true ; } if ( TYPE_2 . containsKey ( input ) ) { return true ; <START> } <END> for ( TYPE_3 VAR_1 : TYPE_3 . values ( ) ) { TYPE_4 matcher = VAR_1 . VAR_2 . matcher ( input ) ; if ( matcher . VAR_3 ( ) ) { return true ; } }...
public static boolean METHOD_1 ( String input ) { if ( TYPE_1 . containsKey ( input ) || TYPE_2 . containsKey ( input ) ) { return true ; } for ( TYPE_3 VAR_1 : TYPE_3 . values ( ) ) { TYPE_4 matcher = VAR_1 . VAR_2 . matcher ( input ) ; if ( matcher . VAR_3 ( ) ) { return true ; } } return false ; }
need guard
private void METHOD_1 ( ) { <START> VAR_1 = TYPE_4 . TYPE_5 . create ( ) ; <END> VAR_2 = new TYPE_2 ( VAR_3 , VAR_1 ) ; VAR_4 = new TYPE_3 ( VAR_3 , VAR_1 ) ; }
private synchronized void METHOD_1 ( ) { VAR_1 = TYPE_4 . TYPE_5 . create ( ) ; VAR_2 = new TYPE_2 ( VAR_3 , VAR_1 ) ; VAR_4 = new TYPE_3 ( VAR_3 , VAR_1 ) ; }
remove empty line
public String METHOD_1 ( ) { <START> <END> return VAR_1 != null ? VAR_1 : STRING_1 ; }
public String METHOD_1 ( ) { return VAR_1 ; }
work ? tail command show INT_2 byte I bejavabyte [ ] VAR_5 = TYPE_2 METHOD_3 ( INT_1 - INT_2 INT_2 ) ;
public void METHOD_1 ( ) throws Exception { TYPE_1 . METHOD_2 ( VAR_1 , STRING_1 , TYPE_3 . VAR_3 , INT_1 ) ; VAR_4 . run ( STRING_2 , STRING_3 , STRING_4 , STRING_1 ) ; <START> byte [ ] VAR_5 = TYPE_2 . METHOD_3 ( 0 , INT_2 ) ; <END> Assert . VAR_6 ( VAR_5 , VAR_7 . METHOD_4 ( ) ) ; }
public void METHOD_1 ( ) throws Exception { TYPE_1 . METHOD_2 ( VAR_1 , STRING_1 , TYPE_3 . VAR_3 , INT_1 ) ; VAR_4 . run ( STRING_2 , STRING_3 , STRING_4 , STRING_1 ) ; byte [ ] VAR_5 = TYPE_2 . METHOD_3 ( INT_1 - INT_2 , INT_2 ) ; Assert . VAR_6 ( VAR_5 , VAR_7 . METHOD_4 ( ) ) ; }
VAR_1 add ( TYPE_1 class VAR_4 ) ; register implementations based type ( interface )
public TYPE_1 create ( TYPE_2 VAR_1 , TYPE_3 VAR_2 ) { TYPE_4 . METHOD_1 ( VAR_2 != null , STRING_1 ) ; LOG . info ( STRING_2 , TYPE_5 . class . getName ( ) ) ; TYPE_6 VAR_3 = VAR_1 . get ( TYPE_6 . class ) ; TYPE_1 VAR_4 = new TYPE_5 ( VAR_3 , VAR_2 ) ; <START> VAR_1 . add ( TYPE_5 . class , VAR_4 ) ; <END> return VAR...
public TYPE_1 create ( TYPE_2 VAR_1 , TYPE_3 VAR_2 ) { TYPE_4 . METHOD_1 ( VAR_2 != null , STRING_1 ) ; LOG . info ( STRING_2 , TYPE_1 . class . getName ( ) ) ; TYPE_6 VAR_3 = VAR_1 . get ( TYPE_6 . class ) ; TYPE_1 VAR_4 = new TYPE_5 ( VAR_3 , VAR_2 ) ; VAR_1 . add ( TYPE_1 . class , VAR_4 ) ; return VAR_4 ; }
check VAR_3 null
static TYPE_1 create ( String name , Object VAR_1 , String [ ] VAR_2 ) { TYPE_1 key = new TYPE_1 ( name ) ; <START> for ( String VAR_3 : VAR_2 ) { <END> TYPE_2 . put ( VAR_3 , key ) ; } TYPE_2 . put ( name , key ) ; TYPE_3 . put ( key , VAR_1 ) ; return key ; }
static TYPE_1 create ( String name , Object VAR_1 , String [ ] VAR_2 ) { TYPE_1 key = create ( name , VAR_1 ) ; if ( VAR_2 != null ) { for ( String VAR_3 : VAR_2 ) { TYPE_2 . put ( VAR_3 , key ) ; } } return key ; }
need ? TYPE_3 a subclass IOException
public static void METHOD_1 ( String VAR_1 ) throws IOException { Path VAR_2 = TYPE_1 . get ( VAR_1 ) ; TYPE_2 . METHOD_2 ( VAR_2 . METHOD_3 ( ) ) ; try { TYPE_2 . METHOD_1 ( VAR_2 ) ; <START> } catch ( TYPE_3 e ) { <END> throw new IOException ( STRING_1 + VAR_1 ) ; } }
public static void METHOD_1 ( String VAR_1 ) throws IOException { Path VAR_2 = TYPE_1 . get ( VAR_1 ) ; TYPE_2 . METHOD_2 ( VAR_2 . METHOD_3 ( ) ) ; TYPE_2 . METHOD_1 ( VAR_2 ) ; }
need convert TYPE_3 IOException ? a subclass IOException
public static void METHOD_1 ( String path ) throws IOException { try { TYPE_1 . METHOD_2 ( TYPE_2 . get ( path ) ) ; <START> } catch ( TYPE_3 e ) { <END> throw new IOException ( STRING_1 + path ) ; } }
public static void METHOD_1 ( String path ) throws IOException { TYPE_1 . METHOD_2 ( TYPE_2 . get ( path ) ) ; }
debug level remove
public void start ( Boolean VAR_1 ) throws IOException { super . start ( VAR_1 ) ; VAR_2 = new TYPE_1 ( ) ; if ( VAR_1 ) { <START> LOG . info ( STRING_1 , VAR_3 . size ( ) ) ; <END> VAR_4 = METHOD_1 ( ) . METHOD_2 ( new TYPE_2 ( TYPE_5 . VAR_6 , new TYPE_3 ( ) , ( int ) TYPE_4 . METHOD_3 ( TYPE_6 . VAR_8 ) ) ) ; } }
public void start ( Boolean VAR_1 ) throws IOException { super . start ( VAR_1 ) ; VAR_2 = new TYPE_1 ( ) ; if ( VAR_1 ) { VAR_4 = METHOD_1 ( ) . METHOD_2 ( new TYPE_2 ( TYPE_5 . VAR_6 , new TYPE_3 ( ) , ( int ) TYPE_4 . METHOD_3 ( TYPE_6 . VAR_8 ) ) ) ; } }
warn e getMessage ( ) logged
private TYPE_1 METHOD_1 ( TYPE_2 request ) { TYPE_1 result ; try { result = VAR_1 . METHOD_2 ( request ) ; request . VAR_2 ( result . VAR_3 ( ) ) ; } catch ( TYPE_3 e ) { <START> LOG . error ( STRING_1 , request . VAR_4 ( ) , e ) ; <END> result = null ; } return result ; }
private TYPE_1 METHOD_1 ( TYPE_2 request ) throws IOException { TYPE_1 result ; try { result = VAR_1 . METHOD_2 ( request ) ; request . VAR_2 ( result . VAR_3 ( ) ) ; } catch ( TYPE_3 e ) { throw new IOException ( e ) ; } return result ; }
longer throws IOException
TYPE_4 ( TYPE_1 request , TYPE_2 result ) <START> throws IOException { <END> TYPE_3 . METHOD_1 ( result , STRING_1 ) ; VAR_2 = request ; VAR_3 = result ; }
TYPE_4 ( TYPE_1 request , TYPE_2 result ) { TYPE_3 . METHOD_1 ( result , STRING_1 ) ; VAR_2 = request ; VAR_3 = result ; }
IOException ( e ) original preserved
private TYPE_1 METHOD_1 ( TYPE_2 request ) throws IOException { TYPE_1 result ; try { result = VAR_1 . METHOD_2 ( request ) ; request . VAR_2 ( result . VAR_3 ( ) ) ; } catch ( TYPE_3 e ) { <START> throw new IOException ( e . getMessage ( ) ) ; <END> } return result ; }
private TYPE_1 METHOD_1 ( TYPE_2 request ) throws IOException { TYPE_1 result ; try { result = VAR_1 . METHOD_2 ( request ) ; request . VAR_2 ( result . VAR_3 ( ) ) ; } catch ( TYPE_3 e ) { throw new IOException ( e ) ; } return result ; }
inconsistent _CODE_ requires METHOD_1 close called _CODE_ requires close called required PR
public void METHOD_1 ( ) { if ( VAR_1 ) { return ; } VAR_1 = true ; VAR_2 . METHOD_1 ( ) ; <START> VAR_2 . close ( ) ; <END> }
public void METHOD_1 ( ) throws IOException { if ( VAR_1 ) { return ; } VAR_1 = true ; VAR_2 . METHOD_1 ( ) ; }
optional : package private
<START> public TYPE_5 ( TYPE_1 VAR_2 , TYPE_2 conf , <END> TYPE_3 VAR_3 ) { super ( VAR_2 ) ; VAR_4 = conf ; Path path = new Path ( VAR_2 . toString ( ) ) ; try { TYPE_4 . METHOD_1 ( VAR_3 ) ; VAR_5 = path . VAR_6 ( VAR_3 ) ; } catch ( IOException e ) { LOG . warn ( STRING_1 , VAR_2 , e . getMessage ( ) ) ; throw new R...
TYPE_5 ( TYPE_1 VAR_2 , TYPE_2 conf , TYPE_3 VAR_3 ) { super ( VAR_2 ) ; VAR_4 = conf ; Path path = new Path ( VAR_2 . toString ( ) ) ; try { TYPE_4 . METHOD_1 ( VAR_3 ) ; VAR_5 = path . VAR_6 ( VAR_3 ) ; } catch ( IOException e ) { LOG . warn ( STRING_1 , VAR_2 , e . getMessage ( ) ) ; throw new RuntimeException ( STR...
explicitly check VAR_4 ( ) add a else block error handling
public void METHOD_1 ( TYPE_1 ctx , Object msg ) { if ( ! METHOD_2 ( msg ) ) { ctx . VAR_1 ( msg ) ; return ; } TYPE_2 message = ( ( TYPE_3 ) msg ) . getMessage ( ) ; if ( message . VAR_2 ( ) ) { METHOD_3 ( ctx , message . VAR_3 ( ) ) ; <START> } else { <END> TYPE_4 . METHOD_4 ( message . VAR_4 ( ) ) ; METHOD_5 ( ctx ,...
public void METHOD_1 ( TYPE_1 ctx , Object msg ) { if ( ! ( msg instanceof TYPE_3 ) ) { ctx . VAR_1 ( msg ) ; return ; } TYPE_2 message = ( ( TYPE_3 ) msg ) . getMessage ( ) ; if ( message . VAR_2 ( ) ) { METHOD_3 ( ctx , message . VAR_3 ( ) ) ; } else if ( message . VAR_4 ( ) ) { METHOD_5 ( ctx , message . VAR_5 ( ) )...
consider putting init constructor ? block guaranteed reader successfully created
public TYPE_1 METHOD_1 ( ) { if ( VAR_1 >= VAR_2 ) { return null ; } <START> METHOD_2 ( ) ; <END> ByteBuffer buffer = VAR_3 . read ( VAR_1 , Math . VAR_4 ( VAR_5 , VAR_2 - VAR_1 ) ) ; TYPE_1 VAR_6 = new TYPE_2 ( buffer , buffer . VAR_7 ( ) ) ; VAR_1 += VAR_6 . METHOD_3 ( ) ; return VAR_6 ; }
public TYPE_1 METHOD_1 ( ) { if ( VAR_1 >= VAR_2 ) { return null ; } ByteBuffer buffer = VAR_3 . read ( VAR_1 , Math . VAR_4 ( VAR_5 , VAR_2 - VAR_1 ) ) ; TYPE_1 VAR_6 = new TYPE_2 ( buffer , buffer . VAR_7 ( ) ) ; VAR_1 += VAR_6 . METHOD_3 ( ) ; return VAR_6 ; }
sense push logic utility method ? I expect pattern true caller point sense encapsulate
private TYPE_3 ( ) { <START> if ( TYPE_1 . METHOD_1 ( ) ) { <END> VAR_2 = TYPE_1 . METHOD_2 ( ) ; VAR_3 = TYPE_1 . METHOD_3 ( ) ; } else { VAR_2 = "" ; VAR_3 = "" ; } VAR_4 = TYPE_2 . METHOD_4 ( ) . METHOD_5 ( ) ; }
private TYPE_3 ( ) { VAR_2 = TYPE_1 . METHOD_2 ( ) ; VAR_3 = TYPE_1 . METHOD_3 ( ) ; VAR_4 = TYPE_2 . METHOD_4 ( ) . METHOD_5 ( ) ; }
messages duplicates
protected void METHOD_1 ( ) throws Exception { <START> LOG . info ( STRING_1 , <END> TYPE_2 . VAR_2 , VAR_3 , VAR_4 ) ; if ( VAR_5 != null ) { VAR_5 . METHOD_2 ( ) ; VAR_5 = null ; } if ( VAR_6 != null ) { VAR_6 . METHOD_2 ( ) ; VAR_6 = null ; } TYPE_1 . METHOD_3 ( ) ; VAR_4 = false ; }
protected void METHOD_1 ( ) throws Exception { if ( VAR_5 != null ) { VAR_5 . METHOD_2 ( ) ; VAR_5 = null ; } if ( VAR_6 != null ) { VAR_6 . METHOD_2 ( ) ; VAR_6 = null ; } TYPE_1 . METHOD_3 ( ) ; VAR_4 = false ; }
I replace hadoop - 1 checking _CODE_ static void _CODE_ ( ) { assume _CODE_ ( TYPE_1 METHOD_2 ( ) ) ; }
public final void METHOD_1 ( ) throws Exception { <START> if ( TYPE_1 . METHOD_2 ( ) ) { <END> return ; } VAR_1 . METHOD_3 ( ) ; }
public final void METHOD_1 ( ) throws Exception { VAR_1 . METHOD_3 ( ) ; }
logging necessary I handling _CODE_ ( work unit tests )
public void start ( ) throws Exception { <START> LOG . info ( STRING_1 , VAR_1 ) ; <END> METHOD_1 ( true ) ; METHOD_2 ( ) ; }
public void start ( ) throws Exception { METHOD_1 ( true ) ; METHOD_2 ( ) ; }
previous error level log stopping VAR_1
public static void run ( TYPE_1 VAR_1 ) { try { LOG . info ( STRING_1 , VAR_1 ) ; VAR_1 . start ( ) ; System . VAR_2 ( 0 ) ; } catch ( Exception e ) { LOG . error ( STRING_2 , VAR_1 , e ) ; try { <START> LOG . info ( STRING_3 , VAR_1 ) ; <END> VAR_1 . METHOD_1 ( ) ; } catch ( Exception VAR_3 ) { LOG . error ( STRING_4 ...
public static void run ( TYPE_1 VAR_1 ) { try { LOG . info ( STRING_1 , VAR_1 ) ; VAR_1 . start ( ) ; LOG . info ( STRING_3 , VAR_1 ) ; System . VAR_2 ( 0 ) ; } catch ( Exception e ) { LOG . error ( STRING_2 , VAR_1 , e ) ; try { VAR_1 . METHOD_1 ( ) ; } catch ( Exception VAR_3 ) { LOG . error ( STRING_4 , VAR_1 , VAR_...
VAR_2 total number objects pool acquired A method decrease
public void METHOD_1 ( T resource ) { if ( resource != null ) { VAR_1 . add ( resource ) ; <START> VAR_2 . METHOD_2 ( ) ; <END> try ( TYPE_1 r = new TYPE_1 ( VAR_3 ) ) { VAR_4 . METHOD_3 ( ) ; } } }
public void METHOD_1 ( T resource ) { if ( resource != null ) { VAR_1 . add ( resource ) ; try ( TYPE_1 r = new TYPE_1 ( VAR_3 ) ) { VAR_4 . METHOD_3 ( ) ; } } }
- resource pattern
public void run ( ) { TYPE_1 client = null ; <START> try { <END> client = TYPE_3 . TYPE_4 . METHOD_1 ( ) ; } catch ( IOException e ) { Assert . VAR_1 ( STRING_1 ) ; } finally { TYPE_3 . TYPE_4 . METHOD_2 ( client ) ; } }
public void run ( ) { TYPE_1 client = TYPE_3 . TYPE_4 . METHOD_1 ( ) ; TYPE_3 . TYPE_4 . METHOD_2 ( client ) ; }
I prefer some large instead introducing - 1 adds complexity unnecessarily consistent _CODE_ ( simpler ) METHOD_1 ( 100 TimeUnit DAYS )
public T METHOD_1 ( ) throws IOException { <START> return METHOD_1 ( VAR_1 , null ) ; <END> }
public T METHOD_1 ( ) { return METHOD_1 ( VAR_1 , null ) ; }
argument Math VAR_5 ( VAR_2 - VAR_1 VAR_6 )
public TYPE_1 METHOD_1 ( ) throws IOException { if ( VAR_1 >= VAR_2 ) { return null ; } ByteBuffer buffer = <START> ByteBuffer . VAR_3 ( VAR_4 , ( int ) VAR_1 , ( int ) ( Math . VAR_5 ( VAR_6 , VAR_2 ) - VAR_1 ) ) ; <END> TYPE_1 VAR_7 = new TYPE_2 ( buffer , buffer . VAR_8 ( ) ) ; VAR_1 += VAR_7 . METHOD_2 ( ) ; return...
public TYPE_1 METHOD_1 ( ) throws IOException { if ( VAR_1 >= VAR_2 ) { return null ; } ByteBuffer buffer = ByteBuffer . VAR_3 ( VAR_4 , ( int ) VAR_1 , ( int ) ( Math . VAR_5 ( VAR_6 , VAR_2 - VAR_1 ) ) ) ; TYPE_1 VAR_7 = new TYPE_2 ( buffer , buffer . VAR_8 ( ) ) ; VAR_1 += VAR_7 . METHOD_2 ( ) ; return VAR_7 ; }
property keys equal formatted templates
public void METHOD_1 ( ) throws Exception { Assert . assertEquals ( TYPE_1 . TYPE_2 . VAR_3 . format ( STRING_1 ) , TYPE_1 . TYPE_2 . VAR_3 . format ( STRING_1 ) ) ; <START> Assert . VAR_4 ( TYPE_1 . VAR_5 , TYPE_1 . VAR_5 ) ; <END> }
public void METHOD_1 ( ) throws Exception { Assert . assertEquals ( TYPE_1 . TYPE_2 . VAR_3 . format ( STRING_1 ) , TYPE_1 . TYPE_2 . VAR_3 . format ( STRING_1 ) ) ; Assert . assertEquals ( TYPE_1 . VAR_5 , TYPE_1 . VAR_5 ) ; }
TYPE_1 VAR_1 = new TYPE_1 ( _CODE_ _CODE_ ( ) ) ;
public void METHOD_1 ( ) { <START> TYPE_1 VAR_1 = new TYPE_1 ( ) ; <END> boolean VAR_2 = VAR_1 . METHOD_2 ( ) ; long VAR_3 = VAR_1 . METHOD_3 ( ) ; TYPE_2 options = TYPE_2 . METHOD_4 ( ) ; options . VAR_4 ( VAR_2 ) ; Assert . assertEquals ( VAR_2 , options . VAR_2 ( ) ) ; options . VAR_5 ( VAR_3 ) ; Assert . assertEqua...
public void METHOD_1 ( ) throws Exception { TYPE_1 VAR_1 = new TYPE_1 ( ) ; boolean VAR_2 = VAR_1 . METHOD_2 ( ) ; long VAR_3 = VAR_1 . METHOD_3 ( ) ; TYPE_2 options = TYPE_2 . METHOD_4 ( ) ; options . VAR_4 ( VAR_2 ) ; Assert . assertEquals ( VAR_2 , options . VAR_2 ( ) ) ; options . VAR_5 ( VAR_3 ) ; Assert . assertE...
finally block executed
public void run ( ) { try { METHOD_1 ( ) ; } catch ( RuntimeException e ) { LOG . error ( STRING_1 , VAR_1 . getName ( ) , e ) ; <START> System . VAR_2 ( - 1 ) ; <END> } finally { if ( VAR_3 != null ) { try { VAR_3 . close ( ) ; } catch ( IOException e ) { LOG . warn ( STRING_2 , VAR_1 . getName ( ) , e . getMessage ( ...
public void run ( ) { try { METHOD_1 ( ) ; } catch ( RuntimeException e ) { LOG . error ( STRING_1 , VAR_1 . getName ( ) , e ) ; throw e ; } }
TYPE_4 TYPE_3 separate concepts shouldn t obtained METHOD_1 call
public TYPE_1 METHOD_1 ( TYPE_2 options ) { if ( options . VAR_1 ( ) != null ) { return new TYPE_3 ( options ) ; } else { return new TYPE_4 ( this , options ) ; } <START> } <END>
public TYPE_1 METHOD_1 ( TYPE_2 options ) { return new TYPE_4 ( this , options ) ; }
return a TYPE_5 instead a TYPE_1
public TYPE_1 create ( TYPE_2 VAR_1 , TYPE_3 VAR_2 ) { TYPE_4 . METHOD_1 ( VAR_2 != null , STRING_1 ) ; LOG . info ( STRING_2 , TYPE_5 . class . getName ( ) ) ; <START> return new TYPE_6 ( VAR_1 , VAR_2 ) ; <END> }
public TYPE_5 create ( TYPE_2 VAR_1 , TYPE_3 VAR_2 ) { TYPE_4 . METHOD_1 ( VAR_2 != null , STRING_1 ) ; LOG . info ( STRING_2 , TYPE_5 . class . getName ( ) ) ; return new TYPE_6 ( VAR_1 , VAR_2 ) ; }
work including System getProperty ( STRING_1 )
protected File METHOD_1 ( String path , byte [ ] VAR_1 ) throws IOException , TYPE_1 { <START> File VAR_2 = new File ( System . getProperty ( STRING_1 ) + path ) ; <END> VAR_2 . METHOD_2 ( ) ; TYPE_2 VAR_3 = new TYPE_2 ( VAR_2 ) ; VAR_3 . write ( VAR_1 ) ; VAR_3 . close ( ) ; return VAR_2 ; }
protected File METHOD_1 ( String path , byte [ ] VAR_1 ) throws IOException , TYPE_1 { File VAR_2 = new File ( path ) ; VAR_2 . METHOD_2 ( ) ; TYPE_2 VAR_3 = new TYPE_2 ( VAR_2 ) ; VAR_3 . write ( VAR_1 ) ; VAR_3 . close ( ) ; return VAR_2 ; }
options sorted alphabetically
public String METHOD_1 ( ) { return STRING_1 + STRING_2 + STRING_3 + STRING_4 <START> + STRING_5 <END> + STRING_6 ; }
public String METHOD_1 ( ) { return STRING_1 + STRING_3 + STRING_4 + STRING_6 + STRING_2 + STRING_5 ; }
order matters more sense return a List
<START> public Collection < TYPE_1 > METHOD_1 ( ) { <END> List < Map . Entry < Class < ? > , TYPE_1 > > VAR_1 = new ArrayList < > ( VAR_2 . entrySet ( ) ) ; Collections . VAR_3 ( VAR_1 , new TYPE_2 ( ) ) ; List < TYPE_1 > VAR_4 = new ArrayList < > ( ) ; for ( Map . Entry < Class < ? > , TYPE_1 > entry : VAR_1 ) { VAR_4...
public List < TYPE_1 > METHOD_1 ( ) { List < TYPE_1 > VAR_4 = new ArrayList < > ( VAR_2 . values ( ) ) ; Collections . VAR_3 ( VAR_4 , new TYPE_2 ( ) ) ; return VAR_4 ; }
TYPE_1 closable - - resource safety
public void METHOD_1 ( boolean VAR_1 ) throws IOException { LOG . info ( STRING_1 , VAR_2 . getName ( ) ) ; <START> TYPE_1 is = VAR_3 . METHOD_2 ( ) ; <END> if ( VAR_1 ) { VAR_2 . METHOD_1 ( is ) ; } VAR_4 = is . VAR_5 ( ) ; is . close ( ) ; }
public void METHOD_1 ( boolean VAR_1 ) throws IOException { LOG . info ( STRING_1 , VAR_2 . getName ( ) ) ; try ( TYPE_1 is = VAR_3 . METHOD_2 ( ) ) { if ( VAR_1 ) { VAR_2 . METHOD_1 ( is ) ; } VAR_4 = is . VAR_5 ( ) ; } }
catch
public void METHOD_1 ( ) { try { final String VAR_1 = STRING_1 ; TYPE_1 VAR_2 = new TYPE_1 ( STRING_2 , VAR_1 , STRING_3 ) ; TYPE_2 exception = TYPE_2 . METHOD_2 ( VAR_2 ) ; Assert . assertEquals ( VAR_1 , exception . getMessage ( ) ) ; <START> } catch ( Exception e ) { <END> Assert . VAR_3 ( STRING_4 + e . getMessage ...
public void METHOD_1 ( ) { final String VAR_1 = STRING_1 ; TYPE_1 VAR_2 = new TYPE_1 ( STRING_2 , VAR_1 , STRING_3 ) ; TYPE_2 exception = TYPE_2 . METHOD_2 ( VAR_2 ) ; Assert . assertEquals ( VAR_1 , exception . getMessage ( ) ) ; }
values creating _CODE_
public TYPE_4 ( TYPE_2 . TYPE_3 request ) throws Exception { VAR_2 = VAR_3 . METHOD_1 ( request . VAR_4 ( ) , request . getId ( ) , request . VAR_5 ( ) , request . VAR_6 ( ) ) ; VAR_7 = request . getId ( ) ; VAR_8 = request . VAR_5 ( ) ; <START> VAR_9 = VAR_8 + request . VAR_10 ( ) ; <END> }
public TYPE_4 ( TYPE_2 . TYPE_3 request ) throws Exception { VAR_7 = request . getId ( ) ; VAR_8 = request . VAR_5 ( ) ; VAR_9 = VAR_8 + request . VAR_10 ( ) ; VAR_2 = VAR_3 . METHOD_1 ( request . VAR_4 ( ) , VAR_7 , VAR_8 , request . VAR_6 ( ) ) ; }
a static method
<START> private void METHOD_1 ( String VAR_1 ) throws IOException { <END> TYPE_1 . METHOD_2 ( VAR_1 ) ; TYPE_1 . METHOD_3 ( VAR_1 ) ; TYPE_1 . METHOD_4 ( VAR_1 ) ; LOG . debug ( STRING_1 , VAR_1 ) ; }
private static void METHOD_1 ( String VAR_1 ) throws IOException { TYPE_1 . METHOD_2 ( VAR_1 ) ; TYPE_1 . METHOD_3 ( VAR_1 ) ; TYPE_1 . METHOD_4 ( VAR_1 ) ; LOG . debug ( STRING_1 , VAR_1 ) ; }
please fix
private TYPE_1 METHOD_1 ( long VAR_1 , long VAR_2 ) throws TYPE_2 { TYPE_3 key = new TYPE_3 ( VAR_1 , VAR_2 ) ; TYPE_1 VAR_3 = VAR_4 . get ( key ) ; if ( VAR_3 == null ) { <START> try { <END> throw new TYPE_2 ( TYPE_4 . VAR_6 , VAR_2 , VAR_1 ) ; } catch ( Throwable e ) { LOG . error ( STRING_1 , e ) ; throw e ; } } ret...
private TYPE_1 METHOD_1 ( long VAR_1 , long VAR_2 ) throws TYPE_2 { TYPE_3 key = new TYPE_3 ( VAR_1 , VAR_2 ) ; TYPE_1 VAR_3 = VAR_4 . get ( key ) ; if ( VAR_3 == null ) { throw new TYPE_2 ( TYPE_4 . VAR_6 , VAR_2 , VAR_1 ) ; } return VAR_3 ; }
sort fileds alphabetically
public String toString ( ) { return TYPE_1 . METHOD_1 ( this ) <START> . add ( STRING_1 , VAR_1 ) <END> . add ( STRING_2 , VAR_2 ) . add ( STRING_3 , VAR_3 ) . add ( STRING_4 , VAR_4 ) . toString ( ) ; }
public String toString ( ) { return TYPE_1 . METHOD_1 ( this ) . add ( STRING_3 , VAR_3 ) . add ( STRING_4 , VAR_4 ) . add ( STRING_2 , VAR_2 ) . add ( STRING_1 , VAR_1 ) . toString ( ) ; }
remove
public long METHOD_1 ( ) { LOG . debug ( STRING_1 ) ; long VAR_1 = Constants . VAR_2 ; LOG . debug ( STRING_2 ) ; <START> return VAR_1 ; <END> }
public long METHOD_1 ( ) { return Constants . VAR_2 ; }
factory constructors private ? unclear other
<START> public static TYPE_1 create ( TYPE_2 VAR_1 ) { <END> return new TYPE_3 ( null , VAR_1 ) ; }
public static TYPE_1 create ( TYPE_2 VAR_1 ) { return create ( null , VAR_1 ) ; }
factory
protected TYPE_1 METHOD_1 ( ) { TYPE_1 client = <START> new TYPE_2 ( VAR_1 , VAR_2 ) ; <END> VAR_3 . add ( client ) ; return client ; }
protected TYPE_1 METHOD_1 ( ) { TYPE_1 client = TYPE_2 . create ( VAR_1 , VAR_2 ) ; VAR_3 . add ( client ) ; return client ; }
5 seconds weather interference other builds
public void METHOD_1 ( ) throws Exception { TYPE_1 VAR_1 = TYPE_1 . create ( ) ; Assert . assertEquals ( VAR_2 , VAR_1 . METHOD_2 ( ) ) ; for ( int VAR_3 = 0 ; VAR_3 < VAR_4 - 1 ; VAR_3 ++ ) { Assert . assertTrue ( VAR_5 . METHOD_3 ( ) ) ; VAR_5 . METHOD_4 ( VAR_6 ) ; <START> METHOD_5 ( VAR_1 , 1 , Constants . VAR_7 ) ...
public void METHOD_1 ( ) throws Exception { TYPE_1 VAR_1 = TYPE_1 . create ( ) ; Assert . assertEquals ( VAR_2 , VAR_1 . METHOD_2 ( ) ) ; for ( int VAR_3 = 0 ; VAR_3 < VAR_4 - 1 ; VAR_3 ++ ) { Assert . assertTrue ( VAR_5 . METHOD_3 ( ) ) ; VAR_5 . METHOD_4 ( VAR_6 ) ; METHOD_5 ( VAR_1 , 1 , 5 * Constants . VAR_7 ) ; As...
equals instead METHOD_1
<START> public void METHOD_1 ( ) throws Exception { <END> TYPE_1 . METHOD_2 ( TYPE_2 . class , STRING_1 ) ; }
public void METHOD_1 ( ) throws Exception { TYPE_1 . METHOD_2 ( TYPE_2 . class ) ; }
I guess TYPE_2 VAR_4 private completely internal state
private TYPE_1 ( ) { <START> VAR_2 = TYPE_2 . VAR_4 ; <END> }
private TYPE_1 ( ) { VAR_2 = VAR_4 ; }
die methode muss nicht public sein oder
<START> public long METHOD_1 ( ) <END> { int VAR_1 = VAR_2 . getInt ( TYPE_1 . TYPE_2 . VAR_5 , INT_1 ) ; if ( VAR_1 > 0 ) { long VAR_6 = INT_2 * INT_3 * VAR_1 ; return VAR_6 ; } return INT_4 ; }
private long METHOD_1 ( ) { int VAR_1 = VAR_2 . getInt ( TYPE_1 . TYPE_2 . VAR_5 , INT_1 ) ; if ( VAR_1 > 0 ) { long VAR_6 = INT_2 * INT_3 * VAR_1 ; return VAR_6 ; } return INT_4 ; }
want a path path rest json adds noise data network transfer
public String METHOD_1 ( ) { Object path = VAR_1 . get ( VAR_2 ) ; return path != null ? path . toString ( ) : VAR_3 ; <START> } <END>
public String METHOD_1 ( ) { Object path = VAR_1 . get ( VAR_2 ) ; return path != null ? path . toString ( ) : null ; }
original path values item null included json content network transfer smaller
public int METHOD_1 ( ) { Object version = VAR_1 . get ( VAR_2 ) ; return version != null ? Integer . parseInt ( version . toString ( ) ) : VAR_3 ; <START> } <END>
public int METHOD_1 ( ) { Object version = VAR_1 . get ( VAR_2 ) ; return version != null ? Integer . parseInt ( version . toString ( ) ) : 1 ; }
throwing UOE ? UOE a runtime exception need a throws clause fact need a throws clauses means catching undetermined replace a normal exception throwing exception
public final void METHOD_1 ( final TYPE_1 VAR_1 , final String VAR_2 ) throws TYPE_2 { <START> throw new TYPE_2 ( ) ; <END> }
public final void METHOD_1 ( final TYPE_1 VAR_1 , final String VAR_2 ) { throw new TYPE_2 ( ) ; }
parts function tested I codecov bails checks needed ? specifically check class equality problems case subclasses TYPE_1 ? statements written asreturn equals ( ) ; avoid a branch need tested
public boolean equals ( Object o ) { if ( this == o ) return true ; if ( o == null || getClass ( ) != o . getClass ( ) ) return false ; TYPE_1 that = ( TYPE_1 ) o ; if ( ! name . equals ( that . name ) ) return false ; return true ; <START> } <END>
public boolean equals ( Object o ) { if ( this == o ) return true ; if ( ! ( o instanceof TYPE_1 ) ) return false ; TYPE_1 that = ( TYPE_1 ) o ; return name . equals ( that . name ) ; }
space {
<START> public TYPE_2 ( TYPE_1 VAR_2 , String VAR_3 ) { <END> VAR_4 = VAR_2 ; VAR_5 = VAR_3 ; }
public TYPE_2 ( TYPE_1 VAR_2 , String VAR_3 ) { this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; }
nice : + 1 : - - resource idiom
public void remove ( TYPE_1 file ) throws IOException , TYPE_2 { TYPE_3 s = VAR_1 . METHOD_1 ( STRING_1 , STRING_2 , TYPE_4 . METHOD_2 ( file . getPath ( ) ) ) ; TYPE_5 . METHOD_3 ( s ) ; <START> s . close ( ) ; <END> }
public void remove ( TYPE_1 file ) throws IOException , TYPE_2 { try ( TYPE_3 stream = VAR_1 . METHOD_1 ( STRING_1 , STRING_2 , TYPE_4 . METHOD_2 ( file . getPath ( ) ) ) ) { TYPE_5 . METHOD_3 ( stream ) ; } }
needed
public void METHOD_1 ( TYPE_1 name ) throws IOException , TYPE_2 { TYPE_3 s = VAR_1 . METHOD_2 ( STRING_1 , STRING_2 , name . toString ( ) , STRING_3 , STRING_4 , STRING_5 ) ; <START> TYPE_4 . METHOD_3 ( s ) ; <END> s . close ( ) ; }
public void METHOD_1 ( TYPE_1 name ) throws IOException , TYPE_2 { try ( TYPE_3 stream = VAR_1 . METHOD_2 ( STRING_1 , STRING_2 , name . toString ( ) , STRING_3 , STRING_4 , STRING_5 ) ) { TYPE_4 . METHOD_3 ( stream ) ; } }
remember revert file VAR_1 class
public void close ( ) throws IOException { super . close ( ) ; VAR_1 . close ( ) ; <START> } <END>
public void close ( ) throws IOException { super . close ( ) ; }
need public s private
<START> public int METHOD_1 ( File file ) { <END> return INT_1 ; }
private int METHOD_1 ( File file ) { return INT_1 ; }
important exception lost please pass e TYPE_2 constructor
public void METHOD_1 ( TYPE_1 event ) throws TYPE_2 { try ( TYPE_3 is = VAR_1 . METHOD_2 ( STRING_1 , event . VAR_2 ( ) ) ) { TYPE_4 . METHOD_3 ( is ) ; } catch ( IOException e ) { <START> throw new TYPE_2 ( e . getMessage ( ) ) ; <END> } }
public void METHOD_1 ( TYPE_1 event ) throws TYPE_2 { try ( TYPE_3 is = VAR_1 . METHOD_2 ( STRING_1 , event . VAR_2 ( ) ) ) { TYPE_4 . METHOD_3 ( is ) ; } catch ( IOException e ) { throw new TYPE_2 ( e ) ; } }
close needed - - resource ? s wring _CODE_ method ? I feel clearer
public void remove ( TYPE_1 file ) throws IOException , TYPE_2 { try ( TYPE_3 stream = VAR_1 . METHOD_1 ( STRING_1 , STRING_2 , TYPE_4 . METHOD_2 ( file . getPath ( ) ) ) ) { TYPE_5 . METHOD_3 ( stream ) ; <START> stream . close ( ) ; <END> } }
public void remove ( TYPE_1 file ) throws IOException , TYPE_2 { try ( TYPE_3 stream = VAR_1 . METHOD_1 ( STRING_1 , STRING_2 , TYPE_4 . METHOD_2 ( file . getPath ( ) ) ) ) { TYPE_5 . METHOD_3 ( stream ) ; } }
close needed - - resource ? s wring _CODE_ method ? I feel clearer
public void METHOD_1 ( TYPE_1 name ) throws IOException , TYPE_2 { try ( TYPE_3 stream = VAR_1 . METHOD_2 ( STRING_1 , STRING_2 , name . toString ( ) , STRING_3 , STRING_4 , STRING_5 ) ) { TYPE_4 . METHOD_3 ( stream ) ; <START> stream . close ( ) ; <END> } }
public void METHOD_1 ( TYPE_1 name ) throws IOException , TYPE_2 { try ( TYPE_3 stream = VAR_1 . METHOD_2 ( STRING_1 , STRING_2 , name . toString ( ) , STRING_3 , STRING_4 , STRING_5 ) ) { TYPE_4 . METHOD_3 ( stream ) ; } }
- resources please
public Map < String , String > METHOD_1 ( ) throws IOException , TYPE_1 { TYPE_2 VAR_1 = null ; <START> try { <END> VAR_1 = new TYPE_2 ( new TYPE_3 ( VAR_2 . METHOD_2 ( STRING_1 ) ) ) ; return METHOD_3 ( VAR_1 ) ; } finally { if ( VAR_1 != null ) { VAR_1 . close ( ) ; } } }
public Map < String , String > METHOD_1 ( ) throws IOException , TYPE_1 { try ( TYPE_2 VAR_1 = new TYPE_2 ( new TYPE_3 ( VAR_2 . METHOD_2 ( STRING_1 ) ) ) ) { return METHOD_3 ( VAR_1 ) ; } }
I feel liner hurt readability please previous syntax clarity
private String METHOD_1 ( ) { String VAR_1 = System . VAR_2 ( STRING_1 ) ; <START> return VAR_1 != null && ! VAR_1 . equals ( "" ) ? VAR_1 + STRING_2 : STRING_3 ; <END> }
private String METHOD_1 ( ) { String VAR_1 = System . VAR_2 ( STRING_1 ) ; if ( VAR_1 == null || VAR_1 . equals ( "" ) ) { return STRING_3 ; } return VAR_1 + STRING_2 ; }
qualify
public String METHOD_1 ( ) { <START> return VAR_1 . getId ( ) ; <END> }
public String METHOD_1 ( ) { return this . VAR_1 . getId ( ) ; }
line 89 _CODE_ METHOD_2 ( VAR_1 STRING_2 ) ;
public List < TYPE_1 > METHOD_1 ( String source , String VAR_1 , String VAR_2 ) { TYPE_2 . METHOD_2 ( source , STRING_1 ) ; <START> TYPE_2 . METHOD_2 ( source , STRING_2 ) ; <END> logger . debug ( STRING_3 + STRING_4 , source , VAR_1 , VAR_2 ) ; final List < TYPE_3 > VAR_3 = VAR_4 . METHOD_1 ( source , VAR_1 , VAR_2 ) ...
public List < TYPE_1 > METHOD_1 ( String source , String VAR_1 , String VAR_2 ) { TYPE_2 . METHOD_2 ( source , STRING_1 ) ; TYPE_2 . METHOD_2 ( VAR_1 , STRING_2 ) ; logger . debug ( STRING_3 + STRING_4 , source , VAR_1 , VAR_2 ) ; final List < TYPE_3 > VAR_3 = VAR_4 . METHOD_1 ( source , VAR_1 , VAR_2 ) ; logger . debu...
VAR_5 set request
public Response METHOD_1 ( final TYPE_1 request , final int [ ] VAR_1 , int VAR_2 , final long VAR_3 ) { Response response = null ; while ( VAR_2 > 0 ) { response = METHOD_2 ( request ) ; if ( ! METHOD_3 ( response , VAR_1 ) ) { break ; } try { Thread . VAR_4 ( VAR_3 ) ; } catch ( final InterruptedException e ) { } VAR...
public Response METHOD_1 ( final TYPE_1 request , final int [ ] VAR_1 , int VAR_2 , final long VAR_3 ) { VAR_5 = request ; Response response = null ; while ( VAR_2 > 0 ) { response = METHOD_2 ( request ) ; if ( ! METHOD_3 ( response , VAR_1 ) ) { break ; } try { Thread . VAR_4 ( VAR_3 ) ; } catch ( final InterruptedExc...
VAR_1 entrySet ( )
public Map < String , Integer > METHOD_1 ( ) { Map < String , Object > VAR_1 = ( Map < String , Object > ) METHOD_2 ( ) . get ( VAR_2 ) ; Map < String , Integer > VAR_3 = new HashMap < String , Integer > ( ) ; <START> for ( String VAR_4 : VAR_1 . keySet ( ) ) { <END> VAR_3 . put ( VAR_4 , ( Integer ) VAR_1 . get ( VAR_...
public Map < String , Integer > METHOD_1 ( ) { Map < String , Object > VAR_1 = ( Map < String , Object > ) METHOD_2 ( ) . get ( VAR_2 ) ; Map < String , Integer > VAR_3 = new HashMap < String , Integer > ( ) ; for ( Entry < String , Object > entry : VAR_1 . entrySet ( ) ) { VAR_3 . put ( entry . getKey ( ) , ( Integer ...
/ / nitpick - mode - _CODE_ change ctx ctx ? / / nitpick - mode -
private boolean METHOD_1 ( String VAR_1 ) { <START> int res = this . ctx . VAR_2 ( VAR_1 ) ; <END> return ( res == TYPE_1 . VAR_4 ) ; }
private boolean METHOD_1 ( String VAR_1 ) { int res = ctx . VAR_2 ( VAR_1 ) ; return ( res == TYPE_1 . VAR_4 ) ; }