ReviewComments stringlengths 1 2.35k | OriginalCode stringlengths 28 487 | ReviewedCode stringlengths 14 463 |
|---|---|---|
opacity unknown | public int METHOD_1 ( ) { <START> return TYPE_1 . VAR_2 ; <END> } | public int METHOD_1 ( ) { return 0 ; } |
VAR_4 METHOD_7 ( ) | public void METHOD_1 ( TYPE_3 . TYPE_4 . TYPE_5 location , boolean VAR_2 ) { if ( VAR_3 . METHOD_2 ( ) ) { return ; } if ( location != null ) { METHOD_3 ( ) ; } if ( VAR_2 ) { METHOD_4 ( location ) ; } <START> VAR_4 . METHOD_5 ( ) . METHOD_6 ( location , VAR_4 . METHOD_7 ( ) . VAR_5 ) ; <END> TYPE_2 . METHOD_8 ( locati... | public void METHOD_1 ( TYPE_3 . TYPE_4 . TYPE_5 location , boolean VAR_2 ) { if ( VAR_3 . METHOD_2 ( ) ) { return ; } if ( location != null ) { METHOD_3 ( ) ; } if ( VAR_2 ) { METHOD_4 ( location ) ; } VAR_4 . METHOD_5 ( ) . METHOD_6 ( location , VAR_5 ) ; TYPE_2 . METHOD_8 ( location ) ; VAR_4 . METHOD_9 ( ) . METHOD_... |
point - return null | TYPE_1 METHOD_1 ( ) { TYPE_1 VAR_1 ; if ( METHOD_2 ( ) ) { VAR_1 = new TYPE_1 ( METHOD_3 ( ) . METHOD_4 ( ) , METHOD_3 ( ) . METHOD_5 ( ) ) ; } else { <START> VAR_1 = new TYPE_1 ( 0 , 0 ) ; <END> } return VAR_1 ; } | public TYPE_1 METHOD_1 ( ) { TYPE_1 VAR_1 ; if ( METHOD_2 ( ) ) { VAR_1 = new TYPE_1 ( METHOD_3 ( ) . METHOD_4 ( ) , METHOD_3 ( ) . METHOD_5 ( ) ) ; } else { VAR_1 = null ; } return VAR_1 ; } |
check top method | public void METHOD_1 ( TYPE_1 event ) { if ( event . VAR_1 . getType ( ) == TYPE_2 . VAR_3 ) { if ( event . values [ 0 ] >= - VAR_4 && event . values [ 0 ] <= VAR_4 ) { <START> if ( METHOD_2 ( ) ) { <END> METHOD_3 ( ) ; } } } } | public void METHOD_1 ( TYPE_1 event ) { if ( event . VAR_1 . getType ( ) == TYPE_2 . VAR_3 ) { if ( event . values [ 0 ] >= - VAR_4 && event . values [ 0 ] <= VAR_4 ) { METHOD_3 ( ) ; } } } |
static | <START> public static boolean METHOD_1 ( long id ) { <END> return VAR_1 . remove ( id ) != null ; } | public boolean METHOD_1 ( long id ) { for ( Long key : VAR_1 . keySet ( ) ) { if ( key == id ) { VAR_1 . remove ( id ) ; return true ; } } return false ; } |
upgrade drop existing markers | <START> private void METHOD_1 ( TYPE_1 db , int VAR_1 , int VAR_2 ) { <END> db . VAR_3 ( STRING_1 + VAR_4 ) ; db . VAR_3 ( STRING_1 + VAR_5 ) ; METHOD_2 ( db ) ; } | private void METHOD_1 ( TYPE_1 db , int VAR_1 , int VAR_2 ) { } |
codestyle | public Set < String > METHOD_1 ( ) { Set < String > result = new TYPE_1 < > ( ) ; String VAR_1 = TYPE_2 . get ( ) ; <START> if ( VAR_1 != null ) <END> Collections . addAll ( result , VAR_1 . split ( STRING_1 ) ) ; return result ; } | public Set < String > METHOD_1 ( ) { Set < String > result = new TYPE_1 < > ( ) ; String VAR_1 = TYPE_2 . get ( ) ; if ( VAR_1 != null ) { Collections . addAll ( result , VAR_1 . split ( STRING_1 ) ) ; } return result ; } |
return ( VAR_1 < = VAR_2 && VAR_1 > = VAR_3 ) ; | public boolean METHOD_1 ( int VAR_1 ) { <START> if ( VAR_1 <= VAR_2 && VAR_1 >= VAR_3 ) { <END> return true ; } else { return false ; } } | public boolean METHOD_1 ( int VAR_1 ) { return VAR_1 <= VAR_2 && VAR_1 >= VAR_3 ; } |
s throw exception caller catch | private static int METHOD_1 ( TYPE_1 channel ) { ByteBuffer VAR_1 = ByteBuffer . VAR_2 ( VAR_3 ) ; int result = - 1 ; try { while ( VAR_1 . METHOD_2 ( ) && ( channel . read ( VAR_1 ) >= 0 ) ) { } if ( ! VAR_1 . METHOD_2 ( ) ) { VAR_1 . METHOD_3 ( ) ; result = VAR_1 . METHOD_4 ( ) . get ( 0 ) ; } } catch ( Exception VAR... | private static int METHOD_1 ( TYPE_1 channel ) throws IOException { ByteBuffer VAR_1 = ByteBuffer . VAR_2 ( VAR_3 ) ; int result = - 1 ; while ( VAR_1 . METHOD_2 ( ) && ( channel . read ( VAR_1 ) >= 0 ) ) { } if ( ! VAR_1 . METHOD_2 ( ) ) { VAR_1 . METHOD_3 ( ) ; result = VAR_1 . METHOD_4 ( ) . get ( 0 ) ; } return res... |
handle exception | public String getPath ( ) { try { TYPE_1 url = new TYPE_1 ( METHOD_1 ( ) ) ; return url . getPath ( ) ; } catch ( TYPE_2 e ) { <START> return "" ; <END> } } | public String getPath ( ) { try { TYPE_1 url = new TYPE_1 ( METHOD_1 ( ) ) ; return url . getPath ( ) ; } catch ( TYPE_2 e ) { return METHOD_1 ( ) ; } } |
return empty string instead null | public String getProperty ( String key ) { if ( properties != null && ! properties . isEmpty ( ) ) { if ( properties . containsKey ( key ) ) { return properties . get ( key ) ; } else { String VAR_1 = TYPE_1 . VAR_3 + key ; if ( properties . containsKey ( VAR_1 ) ) { return properties . get ( VAR_1 ) ; } } } <START> re... | public String getProperty ( String key ) { if ( properties != null && ! properties . isEmpty ( ) ) { if ( properties . containsKey ( key ) ) { return properties . get ( key ) ; } else { String VAR_1 = TYPE_1 . VAR_3 + key ; if ( properties . containsKey ( VAR_1 ) ) { return properties . get ( VAR_1 ) ; } } } return nul... |
please brackets : ( ! METHOD_1 ( VAR_1 VAR_2 ) ) { return false ; } | public static boolean METHOD_1 ( TYPE_1 VAR_1 , int VAR_2 , int VAR_3 ) { long start = System . currentTimeMillis ( ) ; <START> if ( ! METHOD_1 ( VAR_1 , VAR_2 ) ) return false ; <END> long t ; if ( ( t = System . currentTimeMillis ( ) - start ) < VAR_3 ) { TYPE_2 . METHOD_1 ( ( int ) ( VAR_3 - t ) ) ; } return true ; ... | public static boolean METHOD_1 ( TYPE_1 VAR_1 , int VAR_2 , int VAR_3 ) { long start = System . currentTimeMillis ( ) ; if ( ! METHOD_1 ( VAR_1 , VAR_2 ) ) { return false ; } long t ; if ( ( t = System . currentTimeMillis ( ) - start ) < VAR_3 ) { TYPE_2 . METHOD_1 ( ( int ) ( VAR_3 - t ) ) ; } return true ; } |
brackets ( { } ) | public int METHOD_1 ( TYPE_1 o ) { <START> if ( this . METHOD_2 ( ) . equalsIgnoreCase ( o . VAR_1 ( ) ) ) <END> return 1 ; return this . METHOD_2 ( ) . METHOD_1 ( o . VAR_1 ( ) ) ; } | public int METHOD_1 ( TYPE_1 o ) { if ( this . METHOD_2 ( ) . equalsIgnoreCase ( o . VAR_1 ( ) ) ) { return 1 ; } return this . METHOD_2 ( ) . METHOD_1 ( o . VAR_1 ( ) ) ; } |
missing a bracket | public void METHOD_1 ( int version , int VAR_1 , String name , String VAR_2 , String VAR_3 , String [ ] VAR_4 ) { this . VAR_5 = name ; super . METHOD_1 ( version , VAR_1 , name , VAR_2 , VAR_3 , VAR_4 ) ; <START> if ( VAR_6 != null ) <END> VAR_6 . println ( VAR_5 + STRING_1 ) ; } | public void METHOD_1 ( int version , int VAR_1 , String name , String VAR_2 , String VAR_3 , String [ ] VAR_4 ) { this . VAR_5 = name ; super . METHOD_1 ( version , VAR_1 , name , VAR_2 , VAR_3 , VAR_4 ) ; if ( VAR_6 != null ) { VAR_6 . println ( VAR_5 + STRING_1 ) ; } } |
defined changed line | public static TYPE_1 getInstance ( final TYPE_2 VAR_1 ) { TYPE_1 result = instance ; if ( result == null ) { synchronized ( TYPE_1 . class ) { if ( result == null ) { <START> result = instance ; <END> instance = result = new TYPE_1 ( ) ; result . VAR_2 = VAR_1 ; } } } return result ; } | public static TYPE_1 getInstance ( final TYPE_2 VAR_1 ) { TYPE_1 result = instance ; if ( result == null ) { synchronized ( TYPE_1 . class ) { if ( result == null ) { instance = result = new TYPE_1 ( ) ; result . VAR_2 = VAR_1 ; } } } return result ; } |
error | private TYPE_3 ( final String url ) { TYPE_1 VAR_2 = null ; try { VAR_2 = new TYPE_1 ( url ) ; } catch ( TYPE_2 e ) { <START> LOG . info ( TYPE_4 . VAR_4 , e ) ; <END> } if ( VAR_2 == null ) { return ; } VAR_5 = VAR_2 . METHOD_1 ( VAR_6 ) ; } | private TYPE_3 ( final String url ) { TYPE_1 VAR_2 = null ; try { VAR_2 = new TYPE_1 ( url ) ; } catch ( TYPE_2 e ) { LOG . error ( TYPE_4 . VAR_4 , e ) ; } if ( VAR_2 == null ) { return ; } VAR_5 = VAR_2 . METHOD_1 ( VAR_6 ) ; } |
change error | public final void METHOD_1 ( final TYPE_1 parent ) { try { METHOD_2 ( parent , METHOD_3 ( ) , STRING_1 , VAR_1 , this . METHOD_4 ( ) , TYPE_2 . class ) ; } catch ( TYPE_3 e ) { <START> LOG . info ( TYPE_4 . VAR_3 , e ) ; <END> } } | public final void METHOD_1 ( final TYPE_1 parent ) { try { METHOD_2 ( parent , METHOD_3 ( ) , STRING_1 , VAR_1 , this . METHOD_4 ( ) , TYPE_2 . class ) ; } catch ( TYPE_3 e ) { LOG . error ( TYPE_4 . VAR_3 , e ) ; } } |
change debug | public void METHOD_1 ( final String VAR_1 , final String VAR_2 , final String VAR_3 , final TYPE_1 VAR_4 ) throws TYPE_2 { <START> LOG . info ( STRING_1 , VAR_1 ) ; <END> LOG . info ( STRING_2 , VAR_2 ) ; TYPE_3 . METHOD_2 ( getInstance ( ) . VAR_5 , VAR_1 , VAR_2 , VAR_3 , VAR_4 ) ; } | public void METHOD_1 ( final String VAR_1 , final String VAR_2 , final String VAR_3 , final TYPE_1 VAR_4 ) throws TYPE_2 { LOG . debug ( STRING_1 , VAR_1 ) ; LOG . info ( STRING_2 , VAR_2 ) ; TYPE_3 . METHOD_2 ( getInstance ( ) . VAR_5 , VAR_1 , VAR_2 , VAR_3 , VAR_4 ) ; } |
usuń _CODE_ : D | private int METHOD_1 ( ) { TYPE_1 VAR_1 = ( TYPE_1 ) METHOD_2 ( VAR_2 ) ; VAR_1 . METHOD_3 ( this ) ; short VAR_3 = 0 ; boolean VAR_4 = VAR_1 . METHOD_4 ( TYPE_1 . VAR_5 ) ; if ( ! VAR_4 ) VAR_3 = TYPE_4 . VAR_7 ; else if ( VAR_8 && ( VAR_9 == null || VAR_9 . METHOD_5 ( ) > TYPE_3 . VAR_11 ) ) VAR_3 = TYPE_4 . VAR_12 ;... | private int METHOD_1 ( ) { TYPE_1 VAR_1 = ( TYPE_1 ) METHOD_2 ( VAR_2 ) ; VAR_1 . METHOD_3 ( this ) ; short VAR_3 = 0 ; boolean VAR_4 = VAR_1 . METHOD_4 ( TYPE_1 . VAR_5 ) ; if ( ! VAR_4 ) { VAR_3 = TYPE_4 . VAR_7 ; } else if ( VAR_8 && ( VAR_9 == null || VAR_9 . METHOD_5 ( ) > TYPE_3 . VAR_11 ) ) { VAR_3 = TYPE_4 . VA... |
chyba już niepotrzebne | private List < TYPE_1 > METHOD_1 ( ) { TYPE_2 db = new TYPE_2 ( this ) ; List < TYPE_1 > VAR_1 ; VAR_1 = db . VAR_2 ( ) ; <START> TYPE_1 [ ] VAR_3 = new TYPE_1 [ 0 ] ; <END> return VAR_1 ; } | private List < TYPE_1 > METHOD_1 ( ) { TYPE_2 db = new TYPE_2 ( this ) ; List < TYPE_1 > VAR_1 ; VAR_1 = db . VAR_2 ( ) ; return VAR_1 ; } |
note put line : = METHOD_1 ( ) ; improve readability arguments ( helps spot unchecked arguments ) | public TYPE_2 ( TYPE_1 VAR_2 ) { METHOD_1 ( VAR_2 ) ; <START> this . VAR_2 = VAR_2 ; <END> } | public TYPE_2 ( TYPE_1 VAR_2 ) { this . VAR_2 = METHOD_1 ( VAR_2 ) ; } |
java lets drop throws arguments implemented methods implemented method doesn t throw exception drop throws want compile | <START> public TYPE_1 METHOD_1 ( ) throws IllegalStateException { <END> throw new TYPE_2 ( ) ; } | public TYPE_1 METHOD_1 ( ) { throw new TYPE_2 ( ) ; } |
! [ CRITICAL ] ( ) result integer multiplication cast long org sonatype sisu litmus testsupport concurrent _CODE_ METHOD_1 ( List ) [ ! [ rule ] ( ) ] ( ) | private List < TYPE_1 < TYPE_2 > > METHOD_1 ( final List < TYPE_3 > VAR_1 ) throws InterruptedException { TYPE_4 VAR_2 = TYPE_5 . METHOD_2 ( VAR_3 . size ( ) ) ; <START> final List < TYPE_1 < TYPE_2 > > VAR_4 = VAR_2 <END> . METHOD_3 ( VAR_1 , VAR_5 * VAR_6 , TimeUnit . VAR_7 ) ; VAR_2 . METHOD_4 ( ) ; return VAR_4 ; } | private List < TYPE_1 < TYPE_2 > > METHOD_1 ( final List < TYPE_3 > VAR_1 ) throws InterruptedException { TYPE_4 VAR_2 = TYPE_5 . METHOD_2 ( VAR_3 . size ( ) ) ; final List < TYPE_1 < TYPE_2 > > VAR_4 = VAR_2 . METHOD_3 ( VAR_1 , ( long ) VAR_5 * VAR_6 , TimeUnit . VAR_7 ) ; VAR_2 . METHOD_4 ( ) ; return VAR_4 ; } |
more readable mark relevant methods synchronized arbitrary member locking | public void METHOD_1 ( final TYPE_1 < Integer > VAR_1 ) { METHOD_2 ( VAR_1 ) ; <START> synchronized ( VAR_2 ) { <END> this . VAR_3 . add ( VAR_1 ) ; } } | public synchronized void METHOD_1 ( final TYPE_1 < Integer > VAR_1 ) { METHOD_2 ( VAR_1 ) ; this . VAR_3 . add ( VAR_1 ) ; } |
due nature run ( ) potentially duplicate health check runs scheduled | public void METHOD_1 ( ) { for ( TYPE_1 VAR_1 : VAR_2 . values ( ) ) { <START> VAR_1 . run ( ) ; <END> } } | void METHOD_1 ( ) { for ( TYPE_1 VAR_1 : VAR_2 . values ( ) ) { VAR_1 . run ( ) ; } } |
thread - safe | public < T > TYPE_1 < T > METHOD_1 ( String name , TYPE_1 < T > VAR_1 ) { METHOD_2 ( name ) ; METHOD_3 ( VAR_1 ) ; String VAR_2 = name ( name ) ; <START> TYPE_1 < T > VAR_3 = ( TYPE_1 < T > ) VAR_4 . get ( VAR_2 ) ; <END> if ( VAR_3 == null ) { VAR_3 = VAR_5 . METHOD_4 ( VAR_2 , VAR_1 ) ; } return VAR_3 ; } | public synchronized < T > TYPE_1 < T > METHOD_1 ( String name , TYPE_1 < T > VAR_1 ) { METHOD_2 ( name ) ; METHOD_3 ( VAR_1 ) ; String VAR_2 = name ( name ) ; TYPE_1 < T > VAR_3 = ( TYPE_1 < T > ) VAR_4 . get ( VAR_2 ) ; if ( VAR_3 == null ) { VAR_3 = VAR_5 . METHOD_4 ( VAR_2 , VAR_1 ) ; } return VAR_3 ; } |
don t need check s started anymore a TYPE_1 rid previous lines | public TYPE_4 ( TYPE_1 connection ) { METHOD_1 ( connection ) ; TYPE_2 VAR_2 = ( ( TYPE_3 ) connection ) . METHOD_2 ( ) ; METHOD_1 ( VAR_2 ) ; <START> METHOD_3 ( VAR_2 . METHOD_4 ( ) ) ; <END> VAR_3 = connection ; } | public TYPE_4 ( TYPE_1 connection ) { METHOD_1 ( connection ) ; VAR_3 = connection ; } |
explode parameter null | private String METHOD_1 ( ) { <START> return new File ( VAR_1 , STRING_1 ) . METHOD_2 ( ) ; <END> } | private String METHOD_1 ( ) { if ( VAR_1 == null ) { return null ; } return new File ( VAR_1 , STRING_1 ) . METHOD_2 ( ) ; } |
starting control I idea add plugin I understand a follow pr I created [ JENKINS - 49367 ] ( ) | public boolean METHOD_1 ( Map < String , Object > info ) throws Exception { <START> return TYPE_1 . METHOD_2 ( info ) || TYPE_2 . METHOD_3 ( info ) <END> || TYPE_3 . METHOD_4 ( info ) || TYPE_4 . METHOD_5 ( info ) ; } | public boolean METHOD_1 ( Map < String , Object > info ) throws Exception { return TYPE_1 . METHOD_2 ( info ) || TYPE_2 . METHOD_3 ( info ) || TYPE_3 . METHOD_4 ( info ) ; } |
intention ? globals longer involved stream creation VAR_3 base axioms unused | public final ANNOTATION_1 TYPE_1 < TYPE_2 > METHOD_1 ( ) { TYPE_1 < TYPE_2 > VAR_1 = VAR_2 . stream ( ) ; VAR_1 = TYPE_1 . METHOD_2 ( VAR_3 . stream ( ) . METHOD_3 ( Set : : stream ) , VAR_1 ) ; <START> return VAR_2 . stream ( ) ; <END> } | public final ANNOTATION_1 TYPE_1 < TYPE_2 > METHOD_1 ( ) { return VAR_2 . stream ( ) ; } |
message METHOD_2 ( entity entity ) | private void METHOD_1 ( TYPE_1 entity , TYPE_2 status ) { <START> METHOD_2 ( entity , STRING_1 ) ; <END> ( ( TYPE_3 ) entity ) . METHOD_3 ( VAR_1 , status ) ; } | private void METHOD_1 ( TYPE_1 entity , TYPE_2 status ) { ( ( TYPE_3 ) entity ) . METHOD_3 ( VAR_1 , status ) ; } |
I generally ( t = = null ) throw e some full stacktrace exception unexpected | protected void METHOD_1 ( TYPE_1 VAR_1 ) { try { VAR_1 . start ( ImmutableList . of ( VAR_2 . METHOD_2 ( ) ) ) ; METHOD_3 ( STRING_1 ) ; } catch ( Exception e ) { <START> Throwable t = TYPE_2 . METHOD_4 ( e , TYPE_3 . class ) ; <END> assertTrue ( t != null , STRING_2 + TYPE_3 . class . getName ( ) + STRING_3 + e ) ; } ... | protected void METHOD_1 ( TYPE_1 VAR_1 ) { try { VAR_1 . start ( ImmutableList . of ( VAR_2 . METHOD_2 ( ) ) ) ; METHOD_3 ( STRING_1 ) ; } catch ( Exception e ) { Throwable t = TYPE_2 . METHOD_4 ( e , TYPE_3 . class ) ; if ( t == null ) { throw new RuntimeException ( e ) ; } } } |
don t modify VAR_1 object retrieved config instead copy modify default VAR_2 inherited config shared multiple instances | protected TYPE_1 < ? > METHOD_1 ( ) { ANNOTATION_1 ( STRING_1 ) TYPE_1 < TYPE_2 > VAR_1 = ( TYPE_1 < TYPE_2 > ) METHOD_2 ( VAR_2 , TYPE_1 . create ( TYPE_2 . class ) ) ; <START> VAR_1 . METHOD_3 ( TYPE_2 . VAR_3 , METHOD_2 ( TYPE_3 . VAR_3 ) ) <END> . METHOD_3 ( TYPE_2 . VAR_5 , STRING_2 + VAR_6 . METHOD_4 ( ) ) ; retu... | protected TYPE_1 < ? > METHOD_1 ( ) { TYPE_1 < ? > VAR_1 = TYPE_1 . create ( METHOD_2 ( VAR_2 , TYPE_1 . create ( TYPE_2 . class ) ) ) ; VAR_1 . METHOD_3 ( TYPE_2 . VAR_3 , METHOD_2 ( TYPE_3 . VAR_3 ) ) . METHOD_3 ( TYPE_2 . VAR_5 , STRING_2 + VAR_6 . METHOD_4 ( ) ) ; return VAR_1 ; } |
Integer toString ( METHOD_3 ( ) METHOD_4 ( ) ) automagic coercion String addition | public Map < String , String > METHOD_1 ( ) { TYPE_1 < String , String > result = TYPE_1 . METHOD_2 ( super . METHOD_1 ( ) ) ; <START> result . put ( STRING_1 , "" + METHOD_3 ( ) . METHOD_4 ( ) ) ; <END> return result ; } | public Map < String , String > METHOD_1 ( ) { TYPE_1 < String , String > result = TYPE_1 . METHOD_2 ( super . METHOD_1 ( ) ) ; result . put ( STRING_1 , "" + Integer . toString ( METHOD_3 ( ) . METHOD_4 ( ) ) ) ; return result ; } |
call _CODE_ ( ) METHOD_1 ( ) moving code TYPE_1 mentioned | private Boolean METHOD_1 ( ) { <START> return Optional . VAR_1 ( entity . VAR_2 ( TYPE_1 . VAR_3 ) ) . METHOD_2 ( Boolean . VAR_4 ) ; <END> } | private Boolean METHOD_1 ( ) { return ( ( TYPE_1 ) entity ) . METHOD_1 ( ) ; } |
_isn t_ ANNOTATION_1 remove annotation add a guard returns false | public static < T > TYPE_1 < TYPE_2 > METHOD_1 ( final TYPE_2 parent ) { return new TYPE_1 < TYPE_2 > ( ) { @Override <START> public boolean apply ( ANNOTATION_1 TYPE_2 input ) { <END> return TYPE_3 . METHOD_2 ( input . VAR_1 ( ) , parent ) ; } } ; } | public static < T > TYPE_1 < TYPE_2 > METHOD_1 ( final TYPE_2 parent ) { return new TYPE_1 < TYPE_2 > ( ) { @Override public boolean apply ( ANNOTATION_1 TYPE_2 input ) { return ( input != null ) && TYPE_3 . METHOD_2 ( input . VAR_1 ( ) , parent ) ; } } ; } |
input ANNOTATION_1 remove annotation add null check | public static < T > TYPE_1 < TYPE_2 > METHOD_1 ( final T val ) { return new TYPE_1 < TYPE_2 > ( ) { @Override <START> public boolean apply ( ANNOTATION_1 TYPE_2 input ) { <END> return TYPE_3 . METHOD_2 ( input . VAR_1 ( ) , val ) ; } } ; } | public static < T > TYPE_1 < TYPE_2 > METHOD_1 ( final T val ) { return new TYPE_1 < TYPE_2 > ( ) { @Override public boolean apply ( ANNOTATION_1 TYPE_2 input ) { return ( input != null ) && TYPE_3 . METHOD_2 ( input . VAR_1 ( ) , val ) ; } } ; } |
input ANNOTATION_1 remove annotation add null check | public static < T > TYPE_1 < TYPE_2 > METHOD_1 ( final T val ) { return new TYPE_1 < TYPE_2 > ( ) { @Override <START> public boolean apply ( ANNOTATION_1 TYPE_2 input ) { <END> return TYPE_3 . METHOD_2 ( input . getId ( ) , val ) ; } } ; } | public static < T > TYPE_1 < TYPE_2 > METHOD_1 ( final T val ) { return new TYPE_1 < TYPE_2 > ( ) { @Override public boolean apply ( ANNOTATION_1 TYPE_2 input ) { return ( input != null ) && TYPE_3 . METHOD_2 ( input . getId ( ) , val ) ; } } ; } |
prefer token VAR_1 | public static < T > TYPE_1 < T > METHOD_1 ( TYPE_1 < T > token , Class < ? super T > VAR_1 ) { if ( VAR_1 != null ) return TYPE_1 . of ( ( Class < T > ) VAR_1 ) ; <START> if ( token != null ) return token ; <END> throw new IllegalStateException ( STRING_1 ) ; } | public static < T > TYPE_1 < T > METHOD_1 ( TYPE_1 < T > token , Class < ? super T > VAR_1 ) { if ( token != null ) return token ; if ( VAR_1 != null ) return TYPE_1 . of ( ( Class < T > ) VAR_1 ) ; throw new IllegalStateException ( STRING_1 ) ; } |
add a METHOD_2 ( ) override returns a cast super METHOD_2 ( ) neater | public void METHOD_1 ( String VAR_1 , String VAR_2 , String VAR_3 , String VAR_4 , Integer VAR_5 , Integer VAR_6 , String VAR_7 , Integer VAR_8 , Integer VAR_9 , Integer VAR_10 , Integer VAR_11 , Integer VAR_12 , Integer VAR_13 ) { <START> ( ( TYPE_1 ) METHOD_2 ( ) ) . METHOD_1 ( VAR_1 , VAR_2 , VAR_3 , VAR_4 , <END> V... | public void METHOD_1 ( String VAR_1 , String VAR_2 , String VAR_3 , String VAR_4 , Integer VAR_5 , Integer VAR_6 , String VAR_7 , Integer VAR_8 , Integer VAR_9 , Integer VAR_10 , Integer VAR_11 , Integer VAR_12 , Integer VAR_13 ) { METHOD_2 ( ) . METHOD_1 ( VAR_1 , VAR_2 , VAR_3 , VAR_4 , VAR_5 , VAR_6 , VAR_7 , VAR_8 ... |
eliminate duplication attempting VAR_1 METHOD_1 ( ) : VAR_1 METHOD_1 ( ) ; / / don t care succeeds failsif ( VAR_1 METHOD_2 ( ) ) return VAR_1 ; throw | public static File METHOD_1 ( File VAR_1 ) { if ( VAR_1 . METHOD_2 ( ) ) return VAR_1 ; boolean VAR_2 = VAR_1 . METHOD_1 ( ) ; if ( ! VAR_2 ) { if ( VAR_1 . METHOD_2 ( ) ) return VAR_1 ; throw TYPE_1 . METHOD_3 ( new IOException ( STRING_1 + VAR_1 + ( VAR_1 . METHOD_4 ( ) ? STRING_2 : "" ) ) ) ; <START> } <END> return ... | public static File METHOD_1 ( File VAR_1 ) { VAR_1 . METHOD_1 ( ) ; if ( VAR_1 . METHOD_2 ( ) ) { return VAR_1 ; } throw TYPE_1 . METHOD_3 ( new IOException ( STRING_1 + VAR_1 + ( VAR_1 . METHOD_4 ( ) ? STRING_2 : "" ) ) ) ; } |
simply return 0 relying SSH arguably necessary restrict integration tests ve weeded - SSH | public int execute ( List < String > VAR_1 , String VAR_2 ) { if ( VAR_3 ) { throw new TYPE_1 ( STRING_1 ) ; } <START> return super . execute ( VAR_1 , VAR_2 ) ; <END> } | public int execute ( List < String > VAR_1 , String VAR_2 ) { if ( VAR_3 ) { throw new TYPE_1 ( STRING_1 ) ; } return 0 ; } |
a good idea - - sets a thread local interfere other tests I suspect TYPE_2 queue ( _CODE_ ) won t run _CODE_ _CODE_ t submitted executor ( another reason _CODE_ fail gracefully outwith a TQC _CODE_ ) | public void METHOD_1 ( ) throws Exception { TYPE_1 < Object > t = new TYPE_1 < Object > ( ) ; <START> TYPE_2 . METHOD_2 ( t ) ; <END> VAR_1 = TYPE_3 . METHOD_3 ( TYPE_4 . class ) ; VAR_2 = VAR_1 . METHOD_4 ( ) ; TYPE_5 VAR_3 = VAR_2 . METHOD_5 ( ) . METHOD_6 ( TYPE_6 . create ( TYPE_5 . class ) ) ; host = VAR_3 . METHO... | public void METHOD_1 ( ) throws Exception { VAR_1 = TYPE_3 . METHOD_3 ( TYPE_4 . class ) ; VAR_2 = VAR_1 . METHOD_4 ( ) ; TYPE_5 VAR_3 = VAR_2 . METHOD_5 ( ) . METHOD_6 ( TYPE_6 . create ( TYPE_5 . class ) ) ; host = VAR_3 . METHOD_7 ( ) ; VAR_1 . start ( Arrays . asList ( host ) ) ; } |
reset a finally block | public TYPE_1 METHOD_1 ( ) { TYPE_1 VAR_1 = VAR_2 ; if ( VAR_1 == null ) { TYPE_2 . METHOD_2 ( STRING_1 ) ; synchronized ( VAR_3 ) { VAR_1 = VAR_2 ; if ( VAR_1 == null ) { VAR_2 = VAR_1 = TYPE_3 . METHOD_3 ( this ) ; } } <START> TYPE_2 . METHOD_4 ( ) ; <END> } return VAR_1 ; } | public TYPE_1 METHOD_1 ( ) { TYPE_1 VAR_1 = VAR_2 ; if ( VAR_1 == null ) { TYPE_2 . METHOD_2 ( STRING_1 ) ; try { synchronized ( VAR_3 ) { VAR_1 = VAR_2 ; if ( VAR_1 == null ) { VAR_2 = VAR_1 = TYPE_3 . METHOD_3 ( this ) ; } } } finally { TYPE_2 . METHOD_4 ( ) ; } } return VAR_1 ; } |
prevent null place ; i e fail early _CODE_ : import static google common base preconditions _CODE_ ; VAR_5 add ( _CODE_ ( listener listener ) ) ; | public void METHOD_1 ( ) { log . info ( STRING_1 + builder ) ; TYPE_1 properties = builder . build ( ) ; VAR_1 = properties ; if ( VAR_2 != null ) { log . info ( STRING_2 + VAR_2 ) ; VAR_1 . METHOD_2 ( VAR_2 ) ; } this . VAR_3 = TYPE_2 . METHOD_3 ( VAR_1 ) ; this . VAR_4 = null ; for ( TYPE_3 listener : VAR_5 ) { <STAR... | public void METHOD_1 ( ) { log . info ( STRING_1 + builder ) ; TYPE_1 properties = builder . build ( ) ; VAR_1 = properties ; if ( VAR_2 != null ) { log . info ( STRING_2 + VAR_2 ) ; VAR_1 . METHOD_2 ( VAR_2 ) ; } this . VAR_3 = TYPE_2 . METHOD_3 ( VAR_1 ) ; this . VAR_4 = null ; for ( TYPE_3 listener : VAR_5 ) { liste... |
I don t want propagate exception thread want return throwable wasn t thread error | public static Throwable METHOD_1 ( TYPE_1 < ? > t ) { if ( t == null ) return null ; if ( ! t . VAR_1 ( ) ) return null ; if ( t . VAR_2 ( ) ) return new TYPE_2 ( ) ; try { t . get ( ) ; return null ; } catch ( Throwable error ) { <START> TYPE_3 . METHOD_2 ( error ) ; <END> return error ; } } | public static Throwable METHOD_1 ( TYPE_1 < ? > t ) { if ( t == null ) return null ; if ( ! t . VAR_1 ( ) ) return null ; if ( t . VAR_2 ( ) ) return new TYPE_2 ( ) ; try { t . get ( ) ; return null ; } catch ( Throwable error ) { return error ; } } |
done 3 lines | protected void METHOD_1 ( Exception e , String context ) { TYPE_1 . METHOD_2 ( e ) ; if ( METHOD_3 ( ) ) { LOG . warn ( STRING_1 + context , e ) ; } else { <START> TYPE_1 . METHOD_2 ( e ) ; <END> LOG . debug ( STRING_1 + context + STRING_2 , e ) ; } } | protected void METHOD_1 ( Exception e , String context ) { TYPE_1 . METHOD_2 ( e ) ; if ( METHOD_3 ( ) ) { LOG . warn ( STRING_1 + context , e ) ; } else { LOG . debug ( STRING_1 + context + STRING_2 , e ) ; } } |
delete - debugging | public void METHOD_1 ( TYPE_1 val ) { if ( val == null && ( val instanceof TYPE_2 ) ) { <START> System . out . println ( STRING_1 ) ; <END> } this . VAR_1 = METHOD_2 ( val , STRING_2 ) ; this . VAR_2 = new TYPE_3 ( val ) ; this . VAR_3 = new TYPE_4 ( val ) ; this . VAR_4 = new TYPE_5 ( val ) ; this . VAR_5 = new TYPE_6... | public void METHOD_1 ( TYPE_1 val ) { this . VAR_1 = METHOD_2 ( val , STRING_2 ) ; this . VAR_2 = new TYPE_3 ( val ) ; this . VAR_3 = new TYPE_4 ( val ) ; this . VAR_4 = new TYPE_5 ( val ) ; this . VAR_5 = new TYPE_6 ( val ) ; } |
I d : VAR_2 = METHOD_2 ( VAR_1 STRING_1 ) ; note I static imports others static imports clear enough ( Assert assertTrue tests ) | public void METHOD_1 ( TYPE_1 VAR_1 ) { <START> TYPE_2 . METHOD_2 ( VAR_1 , STRING_1 ) ; <END> this . VAR_2 = VAR_1 ; } | public void METHOD_1 ( TYPE_1 VAR_1 ) { this . VAR_2 = TYPE_2 . METHOD_2 ( VAR_1 , STRING_1 ) ; } |
cast ? I missing ? strong feelings | <START> <END> public <END> TYPE_1 <END> < <END> TYPE_2 <END> <END> , T <END> <END> > <END> METHOD_1 ( <END> final <END> TYPE_3 <END> < ? <END> extends <END> TYPE_2 <END> <END> > <END> val ) { METHOD_2 <END> <END> <END> <END> ( val <END> <END> , <END> <END> STRING_1 <END> ) <END> ; <END> this . VAR_1 <END> = new TYPE_4 ... | public TYPE_1 < TYPE_2 , T > METHOD_1 ( final TYPE_3 < ? extends TYPE_2 > val ) { METHOD_2 ( val , STRING_1 ) ; this . VAR_1 = new TYPE_4 < TYPE_2 > ( ) { @Override public TYPE_2 call ( ) throws Exception { return val . get ( ) ; } } ; return this ; } |
line isn t required a temporary hack disable kafka - zookeeper jmx | public Map < String , String > METHOD_1 ( ) { Map < String , String > VAR_1 = super . METHOD_1 ( ) ; String VAR_2 = VAR_1 . remove ( STRING_1 ) ; <START> if ( TYPE_1 . METHOD_2 ( VAR_2 ) ) VAR_2 = STRING_2 ; <END> return TYPE_2 < String , String > builder ( ) . METHOD_3 ( VAR_1 ) . METHOD_4 ( STRING_3 , VAR_2 ) . build... | public Map < String , String > METHOD_1 ( ) { Map < String , String > VAR_1 = super . METHOD_1 ( ) ; String VAR_2 = VAR_1 . remove ( STRING_1 ) ; return TYPE_2 < String , String > builder ( ) . METHOD_3 ( VAR_1 ) . METHOD_4 ( STRING_3 , VAR_2 ) . build ( ) ; } |
implement closeable interest | <START> void close ( ) throws IOException { <END> client . close ( ) ; } | public void close ( ) throws IOException { client . close ( ) ; } |
I d assertEquals ( b a ) rely a impl assertEquals _CODE_ equals ( _CODE_ ) case | public void METHOD_1 ( ) { List < Object > a = TYPE_2 < Object > of ( STRING_1 , 1 , STRING_2 , false ) ; List < Object > b = TYPE_1 < Object > asList ( STRING_1 , 1 , STRING_2 , false ) ; <START> Assert . assertEquals ( a , b ) ; <END> } | public void METHOD_1 ( ) { List < Object > a = TYPE_2 < Object > of ( STRING_1 , 1 , STRING_2 , false ) ; List < Object > b = TYPE_1 < Object > asList ( STRING_1 , 1 , STRING_2 , false ) ; Assert . assertEquals ( a , b ) ; Assert . assertEquals ( b , a ) ; } |
I METHOD_1 ( true ) a jboss7 entity I logging : 2014 - 01 - 28 22 : 18 : 47 089 WARN brooklyn management internal _CODE_ call stop management unknown entity ( unmanaged ? ) _CODE_ { id = _CODE_ } ; skipping _CODE_ TYPE_5 METHOD_4 METHOD_6 want - else VAR_2 METHOD_5 ( ) METHOD_6 ( entity ) else block | public TYPE_1 < ? > METHOD_1 ( final TYPE_2 entity , final boolean VAR_1 ) { return VAR_2 . METHOD_2 ( ) . METHOD_3 ( TYPE_3 . of ( STRING_1 , STRING_2 + entity , STRING_3 , STRING_4 + entity . VAR_3 ( ) + STRING_5 + entity + STRING_6 ) , new TYPE_4 ( ) { @Override public void run ( ) { if ( VAR_1 ) <START> TYPE_5 . ME... | public TYPE_1 < ? > METHOD_1 ( final TYPE_2 entity , final boolean VAR_1 ) { return VAR_2 . METHOD_2 ( ) . METHOD_3 ( TYPE_3 . of ( STRING_1 , STRING_2 + entity , STRING_3 , STRING_4 + entity . VAR_3 ( ) + STRING_5 + entity + STRING_6 ) , new TYPE_4 ( ) { @Override public void run ( ) { if ( VAR_1 ) TYPE_5 . METHOD_4 (... |
I d : return ImmutableList ( STRING_1 STRING_2 STRING_3 VAR_1 STRING_4 STRING_5 ) | protected List < String > METHOD_1 ( ) { <START> TYPE_1 < String > result = new TYPE_1 < String > ( ) ; <END> result . add ( STRING_1 ) ; result . add ( STRING_2 ) ; result . add ( STRING_3 ) ; result . add ( VAR_1 ) ; result . add ( STRING_4 ) ; result . add ( STRING_5 ) ; return result ; } | protected List < String > METHOD_1 ( ) { return ImmutableList . of ( STRING_1 , STRING_2 , STRING_3 , VAR_1 , STRING_4 , STRING_5 ) ; } |
suggesting giving more info ( e g connect ) stderr helpful | public void METHOD_1 ( TYPE_1 val ) { <START> log . error ( STRING_1 , new Object [ ] { val . VAR_1 ( ) , val . VAR_2 ( ) , val . VAR_3 ( ) } ) ; <END> for ( TYPE_2 VAR_4 : VAR_5 ) { if ( ! VAR_4 . getName ( ) . startsWith ( VAR_6 ) ) continue ; entity . VAR_7 ( VAR_4 , null ) ; } } | public void METHOD_1 ( TYPE_1 val ) { log . error ( STRING_1 , new Object [ ] { val . VAR_1 ( ) , val . VAR_2 ( ) , val . VAR_3 ( ) } ) ; for ( TYPE_2 VAR_4 : VAR_5 . values ( ) ) { if ( ! VAR_4 . getName ( ) . startsWith ( VAR_6 ) ) continue ; entity . VAR_7 ( VAR_4 , null ) ; } } |
feel wrong : ) | public static Status METHOD_1 ( TYPE_1 state ) { if ( state == null ) return VAR_1 ; switch ( state ) { case VAR_2 : return VAR_3 ; case VAR_4 : return VAR_4 ; case VAR_5 : return VAR_5 ; case VAR_6 : return VAR_6 ; case VAR_7 : return VAR_7 ; case VAR_8 : <START> return VAR_9 ; <END> case VAR_10 : default : return VAR... | public static Status METHOD_1 ( TYPE_1 state ) { if ( state == null ) return VAR_1 ; switch ( state ) { case VAR_2 : return VAR_3 ; case VAR_4 : return VAR_4 ; case VAR_5 : return VAR_5 ; case VAR_6 : return VAR_6 ; case VAR_7 : return VAR_7 ; case VAR_8 : return VAR_8 ; case VAR_10 : default : return VAR_1 ; } } |
I d private part a public API want called other moved utility place ( renamed clearer return null positive ) | <START> public static Long METHOD_1 ( Long time ) { <END> if ( time == null || time <= 0 ) return null ; return time ; } | private static Long METHOD_1 ( Long time ) { if ( time == null || time <= 0 ) return null ; return time ; } |
yikes I didn t master ? ! shouldn t unwrap TYPE_2 exception happened thread other thread example other thread interrupted TYPE_2 METHOD_2 ( ) return InterruptedException rethrowing _this_ thread interrupted ( interrupt handled incorrectly caught wrapped marking thread Thread interrupt ( ) | public static RuntimeException METHOD_1 ( Throwable VAR_1 ) { if ( VAR_1 instanceof InterruptedException ) throw new TYPE_1 ( ( InterruptedException ) VAR_1 ) ; <START> if ( VAR_1 instanceof TYPE_2 ) <END> return TYPE_3 . METHOD_1 ( VAR_1 . METHOD_2 ( ) ) ; return TYPE_3 . METHOD_1 ( VAR_1 ) ; } | public static RuntimeException METHOD_1 ( Throwable VAR_1 ) { if ( VAR_1 instanceof InterruptedException ) throw new TYPE_1 ( ( InterruptedException ) VAR_1 ) ; return TYPE_3 . METHOD_1 ( VAR_1 ) ; } |
shouldn t | public static void METHOD_1 ( Throwable VAR_1 ) { if ( VAR_1 instanceof InterruptedException ) throw new TYPE_1 ( ( InterruptedException ) VAR_1 ) ; if ( VAR_1 instanceof TYPE_2 ) <START> METHOD_1 ( VAR_1 . METHOD_2 ( ) ) ; <END> if ( VAR_1 instanceof TYPE_3 ) throw ( TYPE_3 ) VAR_1 ; } | public static void METHOD_1 ( Throwable VAR_1 ) { if ( VAR_1 instanceof InterruptedException ) throw new TYPE_1 ( ( InterruptedException ) VAR_1 ) ; if ( VAR_1 instanceof TYPE_3 ) throw ( TYPE_3 ) VAR_1 ; } |
needs a _CODE_ synchronization ( getters ) | public void METHOD_1 ( String VAR_1 , String VAR_2 ) { <START> String VAR_3 = VAR_4 . put ( VAR_1 , VAR_2 ) ; <END> if ( VAR_3 != null && ! VAR_3 . equals ( VAR_2 ) ) log . warn ( STRING_1 + VAR_1 + STRING_2 + VAR_3 + STRING_3 + VAR_2 ) ; } | public void METHOD_1 ( String VAR_1 , String VAR_2 ) { synchronized ( VAR_4 ) { String VAR_3 = VAR_4 . put ( VAR_1 , VAR_2 ) ; if ( VAR_3 != null && ! VAR_3 . equals ( VAR_2 ) ) log . warn ( STRING_1 + VAR_1 + STRING_2 + VAR_3 + STRING_3 + VAR_2 ) ; } } |
want _CODE_ generate id null passed ? hide some programming errors want overload constructor a version id parameter | public TYPE_3 ( String id , String name , String VAR_2 , Map < String , ? extends Object > config ) { <START> this . id = id != null ? id : TYPE_1 . METHOD_1 ( ) ; <END> this . name = name ; this . VAR_2 = TYPE_2 . METHOD_2 ( VAR_2 ) ; this . config = config == null ? TYPE_4 < String , Object > of ( ) : TYPE_4 < String... | public TYPE_3 ( String id , String name , String VAR_2 , Map < String , ? extends Object > config ) { this . id = TYPE_2 . METHOD_2 ( id ) ; this . name = name ; this . VAR_2 = TYPE_2 . METHOD_2 ( VAR_2 ) ; this . config = config == null ? TYPE_4 < String , Object > of ( ) : TYPE_4 < String , Object > METHOD_3 ( config... |
pass true dryrun calling parse | public boolean METHOD_1 ( String VAR_1 , TYPE_1 VAR_2 ) { if ( TYPE_2 . METHOD_2 ( this , VAR_1 , true ) ) return true ; <START> TYPE_3 VAR_3 = TYPE_3 . parse ( VAR_1 , false ) ; <END> if ( VAR_3 == null ) return false ; if ( VAR_3 . METHOD_3 ( ) || VAR_3 . METHOD_4 ( ) ) return true ; return false ; } | public boolean METHOD_1 ( String VAR_1 , TYPE_1 VAR_2 ) { if ( TYPE_2 . METHOD_2 ( this , VAR_1 , true ) ) return true ; TYPE_3 VAR_3 = TYPE_3 . parse ( VAR_1 , true ) ; if ( VAR_3 == null ) return false ; if ( VAR_3 . METHOD_3 ( ) || VAR_3 . METHOD_4 ( ) ) return true ; return false ; } |
initial size VAR_2 size ( ) + VAR_1 size ( ) create copy return Collections VAR_4 ( maps _CODE_ ( VAR_2 ) ) | public Map < TYPE_1 < ? > , Object > METHOD_1 ( ) { <START> Map < TYPE_1 < ? > , Object > result = new TYPE_2 < TYPE_1 < ? > , Object > ( VAR_1 . size ( ) + VAR_2 . size ( ) ) ; <END> result . VAR_3 ( VAR_2 ) ; return Collections . VAR_4 ( result ) ; } | public Map < TYPE_1 < ? > , Object > METHOD_1 ( ) { Map < TYPE_1 < ? > , Object > result = new TYPE_2 < TYPE_1 < ? > , Object > ( VAR_2 . size ( ) ) ; result . VAR_3 ( VAR_2 ) ; return Collections . VAR_4 ( result ) ; } |
I want pass null instead a super constructor takes class calls other constructor a null entity instance fail fast | public TYPE_2 ( Class < ? extends TYPE_1 > VAR_2 ) { <START> super ( VAR_2 , null ) ; <END> } | public TYPE_2 ( Class < ? extends TYPE_1 > VAR_2 ) { super ( VAR_2 ) ; } |
cast ( List < ? extends TYPE_1 > ) needed ? method signature | public TYPE_2 ( Class < TYPE_1 > VAR_2 , String name , String description , List < ? extends TYPE_1 > VAR_3 ) { <START> super ( ( Class ) List . VAR_4 , name , description , ( List < ? extends TYPE_1 > ) VAR_3 ) ; <END> this . VAR_2 = VAR_2 ; } | public TYPE_2 ( Class < TYPE_1 > VAR_2 , String name , String description , List < ? extends TYPE_1 > VAR_3 ) { super ( ( Class ) List . VAR_4 , name , description , VAR_3 ) ; this . VAR_2 = VAR_2 ; } |
treating singleton ( static INSTANCE field ) constructor private | <START> public TYPE_3 ( ) { <END> super ( ) ; try { VAR_2 . METHOD_1 ( null , new TYPE_1 [ ] { VAR_3 } , null ) ; } catch ( Exception e ) { throw TYPE_2 . METHOD_2 ( e ) ; } } | protected TYPE_3 ( ) { super ( ) ; try { VAR_2 . METHOD_1 ( null , new TYPE_1 [ ] { VAR_3 } , null ) ; } catch ( Exception e ) { throw TYPE_2 . METHOD_2 ( e ) ; } } |
METHOD_4 return null | protected String METHOD_1 ( String VAR_1 ) { return METHOD_2 ( entity . getClass ( ) . METHOD_3 ( ) , <START> entity . getClass ( ) . getName ( ) ) + ( ! METHOD_4 ( ) . equals ( TYPE_1 ) ? VAR_1 + METHOD_4 ( ) : "" ) ; <END> } | protected String METHOD_1 ( String VAR_1 ) { return METHOD_2 ( entity . getClass ( ) . METHOD_3 ( ) , entity . getClass ( ) . getName ( ) ) + ( ! TYPE_1 . equals ( METHOD_4 ( ) ) ? VAR_1 + METHOD_4 ( ) : "" ) ; } |
strange a TYPE_2 a predicate matching a criteria | <START> public TYPE_1 METHOD_1 ( TYPE_2 < TYPE_1 , TYPE_1 > ... VAR_1 ) { <END> return METHOD_2 ( VAR_1 ) . apply ( METHOD_3 ( ) ) ; } | public TYPE_1 METHOD_1 ( TYPE_2 < TYPE_1 , TYPE_1 > ... VAR_1 ) { return METHOD_2 ( VAR_1 ) . apply ( METHOD_1 ( ) ) ; } |
don t synchronized a volatile read covers need synchronized imply METHOD_2 other calls METHOD_2 ( ) need synchronized ? | public TYPE_1 METHOD_1 ( int count , TYPE_2 VAR_1 ) { TYPE_1 VAR_2 ; synchronized ( this ) { <START> VAR_2 = METHOD_2 ( METHOD_3 ( VAR_1 ) ) ; <END> } if ( VAR_2 . size ( ) >= count ) return VAR_2 ; TYPE_1 VAR_3 = create ( count - VAR_2 . size ( ) , VAR_1 ) ; return VAR_2 . METHOD_4 ( VAR_3 ) ; } | public TYPE_1 METHOD_1 ( int count , TYPE_2 VAR_1 ) { TYPE_1 VAR_2 ; VAR_2 = METHOD_2 ( METHOD_3 ( VAR_1 ) ) ; if ( VAR_2 . size ( ) >= count ) return VAR_2 ; TYPE_1 VAR_3 = create ( count - VAR_2 . size ( ) , VAR_1 ) ; return VAR_2 . METHOD_4 ( VAR_3 ) ; } |
return boolean id ( similar semantics Set remove ) | <START> public void remove ( int id ) { <END> VAR_1 . remove ( id ) ; } | public boolean remove ( int id ) { return VAR_1 . remove ( id ) != null ; } |
I delegate VAR_1 a field initialized constructor avoids creating time call METHOD_1 sense | public TYPE_1 < ? > METHOD_1 ( TYPE_2 field ) { TYPE_3 VAR_1 = TYPE_4 . METHOD_2 ( ) . METHOD_3 ( VAR_2 ) <START> . METHOD_4 ( TYPE_5 . METHOD_5 ( ) . METHOD_6 ( Constants . VAR_3 ) , TYPE_5 . METHOD_5 ( ) ) <END> . build ( ) ; return ( ( ) - > VAR_1 . METHOD_7 ( field . getType ( ) ) ) ; } | public TYPE_1 < ? > METHOD_1 ( TYPE_2 field ) { if ( VAR_1 == null ) { VAR_1 = TYPE_4 . METHOD_2 ( ) . METHOD_3 ( VAR_2 ) . METHOD_4 ( TYPE_5 . METHOD_5 ( ) . METHOD_6 ( Constants . VAR_3 ) , TYPE_5 . METHOD_5 ( ) ) . build ( ) ; } return ( ) - > VAR_1 . METHOD_7 ( field . getType ( ) ) ; } |
checked construction time don t create object inconsistent state | protected List < TYPE_1 > METHOD_1 ( ) { List < TYPE_1 > VAR_1 = new ArrayList < > ( ) ; Collections . addAll ( VAR_1 , VAR_2 . METHOD_2 ( ) ) ; <START> if ( VAR_3 != null ) { <END> for ( TYPE_1 element : VAR_3 ) { VAR_1 . remove ( element ) ; } } return VAR_1 ; } | private List < TYPE_1 > METHOD_1 ( ) { List < TYPE_1 > VAR_1 = new ArrayList < > ( ) ; Collections . addAll ( VAR_1 , VAR_2 . METHOD_2 ( ) ) ; if ( VAR_3 != null ) { for ( TYPE_1 element : VAR_3 ) { VAR_1 . remove ( element ) ; } } return VAR_1 ; } |
ditch debugging : ) | TYPE_1 METHOD_1 ( final String VAR_1 , final TYPE_1 command ) { METHOD_2 ( ) ; try { try { <START> System . out . println ( command ) ; <END> return METHOD_3 ( VAR_1 , command ) ; } catch ( TYPE_2 e ) { METHOD_2 ( ) ; return METHOD_3 ( VAR_1 , command ) ; } } catch ( TYPE_3 e ) { throw METHOD_4 ( e ) ; } } | TYPE_1 METHOD_1 ( final String VAR_1 , final TYPE_1 command ) { METHOD_2 ( ) ; try { try { return METHOD_3 ( VAR_1 , command ) ; } catch ( TYPE_2 e ) { METHOD_2 ( ) ; return METHOD_3 ( VAR_1 , command ) ; } } catch ( TYPE_3 e ) { throw METHOD_4 ( e ) ; } } |
remove line doesn t sense a primitive s happening primitive boolean auto - boxed a Boolean | public TYPE_1 < TYPE_2 > METHOD_1 ( final boolean VAR_1 ) { <START> this . VAR_1 = METHOD_2 ( STRING_1 , VAR_1 ) ; <END> return this ; } | public TYPE_1 < TYPE_2 > METHOD_1 ( final boolean VAR_1 ) { this . VAR_1 = VAR_1 ; return this ; } |
change casts wide a net method called methods implementing extended JSON methods implementing shell mode e g _CODE_ s correct shell : { _id : _CODE_ ( 5aaff8caa33024673db4cddf ) } s called read values some places keys address I need leave current method add a new method read extended JSON keys e g _CODE_ | private String METHOD_1 ( ) { <START> TYPE_1 VAR_1 = METHOD_2 ( ) ; <END> if ( VAR_1 . getType ( ) != TYPE_3 . VAR_3 && VAR_1 . getType ( ) != TYPE_3 . VAR_4 ) { throw new TYPE_2 ( STRING_1 , VAR_1 . getValue ( ) ) ; } return VAR_1 . getValue ( String . VAR_5 ) ; } | private String METHOD_1 ( ) { TYPE_1 VAR_1 = METHOD_2 ( ) ; if ( VAR_1 . getType ( ) != TYPE_3 . VAR_3 ) { throw new TYPE_2 ( STRING_1 , VAR_1 . getValue ( ) ) ; } return VAR_1 . getValue ( String . VAR_5 ) ; } |
A method starting set more parameter define a property thrown exception | private static TYPE_1 < ? > METHOD_1 ( final TYPE_2 method ) { if ( METHOD_2 ( method . getName ( ) ) ) { return METHOD_1 ( method . VAR_1 ( ) , method . VAR_2 ( ) ) ; } else { <START> if ( method . VAR_3 ( ) . length != 1 ) { <END> throw new TYPE_3 ( format ( STRING_1 , method . getName ( ) ) ) ; } return METHOD_1 ( m... | private static TYPE_1 < ? > METHOD_1 ( final TYPE_2 method ) { if ( METHOD_2 ( method ) ) { return METHOD_1 ( method . VAR_1 ( ) , method . VAR_2 ( ) ) ; } else { return METHOD_1 ( method . VAR_3 ( ) [ 0 ] , method . VAR_4 ( ) [ 0 ] ) ; } } |
parameters I want final configured checkstyle I don t a big benefit I don t I ve accidentally modified exception reference a catch clause | public void close ( ) { try { if ( channel != null ) { channel . close ( ) ; } <START> } catch ( final IOException e ) { <END> } finally { channel = null ; VAR_1 = true ; } } | public void close ( ) { try { if ( channel != null ) { channel . close ( ) ; } } catch ( IOException e ) { } finally { channel = null ; VAR_1 = true ; } } |
local variable : final needed IDE configured differently checkstyle | public void METHOD_1 ( final TYPE_1 < TYPE_2 > event ) { description = event . VAR_1 ( ) ; <START> for ( final TYPE_3 < TYPE_2 > listener : VAR_2 ) { <END> listener . VAR_3 ( event ) ; } } | public void METHOD_1 ( final TYPE_1 < TYPE_2 > event ) { description = event . VAR_1 ( ) ; for ( TYPE_3 < TYPE_2 > listener : VAR_2 ) { listener . VAR_3 ( event ) ; } } |
I guess _will_ allow variable null planning a placeholder some kind | public TYPE_7 ( TYPE_1 < ? extends TYPE_2 > VAR_2 , TYPE_3 a , TYPE_4 VAR_3 ) { <START> if ( VAR_2 . getValue ( ) == null ) { <END> throw new TYPE_5 ( STRING_1 ) ; } if ( VAR_2 . getValue ( ) instanceof TYPE_6 && a == null ) { throw new TYPE_5 ( STRING_2 ) ; } if ( VAR_3 == null ) { throw new TYPE_5 ( STRING_3 ) ; } VA... | public TYPE_7 ( TYPE_1 < ? extends TYPE_2 > VAR_2 , TYPE_3 a , TYPE_4 VAR_3 ) { if ( VAR_2 . getValue ( ) instanceof TYPE_6 && a == null ) throw new TYPE_5 ( STRING_2 ) ; if ( VAR_3 == null ) throw new TYPE_5 ( STRING_3 ) ; VAR_4 = VAR_2 ; VAR_5 = a ; VAR_6 = VAR_3 ; } |
simulation decision phase build panel | public static TYPE_1 METHOD_1 ( final TYPE_2 model ) { TYPE_1 VAR_1 = new TYPE_1 ( TYPE_7 . TYPE_8 . METHOD_2 ( TYPE_10 . VAR_3 ) ) ; <START> VAR_1 . METHOD_3 ( false ) ; <END> VAR_1 . setText ( STRING_1 ) ; VAR_1 . METHOD_4 ( STRING_2 ) ; VAR_1 . METHOD_5 ( new TYPE_4 ( ) { public void METHOD_6 ( TYPE_5 e ) { ( ( TYPE... | public static TYPE_1 METHOD_1 ( final TYPE_2 model ) { TYPE_1 VAR_1 = new TYPE_1 ( TYPE_7 . TYPE_8 . METHOD_2 ( TYPE_10 . VAR_3 ) ) ; VAR_1 . setText ( STRING_1 ) ; VAR_1 . METHOD_4 ( STRING_2 ) ; VAR_1 . METHOD_5 ( new TYPE_4 ( ) { public void METHOD_6 ( TYPE_5 e ) { ( ( TYPE_6 ) ( ( TYPE_6 ) model . VAR_4 ( ) ) ) . M... |
I bed_quantiles [ 1 ] - ( VAR_2 [ 2 ] - VAR_2 [ 1 ] ) ; | private synchronized void METHOD_1 ( ) { if ( VAR_1 . METHOD_2 ( ) < 2 ) return ; VAR_2 = new double [ 3 ] ; VAR_2 [ 1 ] = TYPE_1 . METHOD_3 ( ) * 4 - 2 ; VAR_2 [ 2 ] = VAR_2 [ 1 ] + TYPE_1 . METHOD_3 ( ) * FLOAT_1 ; <START> VAR_2 [ 0 ] = VAR_2 [ 2 ] - VAR_2 [ 1 ] ; <END> VAR_3 = true ; METHOD_4 ( VAR_4 , null , VAR_3 ... | private synchronized void METHOD_1 ( ) { if ( VAR_1 . METHOD_2 ( ) < 2 ) return ; VAR_2 = new double [ 3 ] ; VAR_2 [ 1 ] = TYPE_1 . METHOD_3 ( ) * 4 - 2 ; VAR_2 [ 2 ] = VAR_2 [ 1 ] + TYPE_1 . METHOD_3 ( ) * FLOAT_1 ; VAR_2 [ 0 ] = VAR_2 [ 1 ] - ( VAR_2 [ 2 ] - VAR_2 [ 1 ] ) ; VAR_3 = true ; METHOD_4 ( VAR_4 , null , VA... |
i´d ´this ´ usages necessary consistent style rest library code | Collection < TYPE_1 > METHOD_1 ( ) { <START> return this . VAR_1 ; <END> } | Collection < TYPE_1 > METHOD_1 ( ) { return VAR_1 ; } |
called concurrently ? consider java util concurrent atomic _CODE_ | public int METHOD_1 ( TYPE_1 VAR_1 , int VAR_2 ) { <START> int VAR_3 = this . VAR_4 ++ ; <END> VAR_5 . put ( VAR_3 , new Pair < TYPE_1 , Integer > ( VAR_1 , VAR_2 ) ) ; return VAR_3 ; } | public synchronized int METHOD_1 ( TYPE_1 VAR_1 , int VAR_2 ) { int VAR_3 = this . VAR_4 ++ ; VAR_5 . put ( VAR_3 , new Pair < TYPE_1 , Integer > ( VAR_1 , VAR_2 ) ) ; return VAR_3 ; } |
aye ; I missed I changed a _b_ oolean | public Boolean METHOD_1 ( String url ) { <START> return true ; <END> } | public Boolean METHOD_1 ( String url ) { return null ; } |
skip empty strings | private Set < String > METHOD_1 ( String input ) { Set < String > VAR_1 = new HashSet < > ( ) ; <START> VAR_1 . addAll ( TYPE_1 . of ( input . split ( STRING_1 ) ) . map ( String : : trim ) . collect ( Collectors . VAR_2 ( ) ) ) ; <END> return VAR_1 ; } | private static Set < String > METHOD_1 ( String input ) { Set < String > VAR_1 = new HashSet < > ( ) ; VAR_1 . addAll ( TYPE_1 . of ( input . split ( STRING_1 ) ) . map ( String : : trim ) . collect ( Collectors . VAR_2 ( ) ) ) ; return VAR_1 ; } |
METHOD_3 returns generic type _CODE_ ( C implementation ) necessary include cast TYPE_7 ? doesn t clean edit - I looked figured issue poor generics change class definition _CODE_ remove need castold : javapublic abstract class _CODE_ < T extends _CODE_ Builder < ? > > extends _CODE_ < T _CODE_ > { new : javapublic abst... | public void METHOD_1 ( TYPE_1 request , TYPE_2 < TYPE_3 > VAR_1 ) { TYPE_4 options = request . VAR_2 ( ) ; TYPE_5 . call ( LOG , ( ) - > { TYPE_6 VAR_3 = METHOD_2 ( request . getPath ( ) ) ; VAR_4 . METHOD_1 ( VAR_3 , ( TYPE_7 ) TYPE_7 <START> . create ( options . VAR_5 ( ) ) . METHOD_3 ( new TYPE_8 ( VAR_1 ) ) ) ; <EN... | public void METHOD_1 ( TYPE_1 request , TYPE_2 < TYPE_3 > VAR_1 ) { TYPE_4 options = request . VAR_2 ( ) ; TYPE_5 . call ( LOG , ( ) - > { TYPE_6 VAR_3 = METHOD_2 ( request . getPath ( ) ) ; VAR_4 . METHOD_1 ( VAR_3 , TYPE_7 . create ( options . VAR_5 ( ) ) . METHOD_3 ( new TYPE_8 ( VAR_1 ) ) ) ; return TYPE_3 . METHOD... |
need path - conf | private TYPE_1 METHOD_1 ( TYPE_2 VAR_1 , int VAR_2 ) { <START> final TYPE_3 VAR_3 = TYPE_3 . create ( VAR_4 . METHOD_2 ( VAR_1 ) ) ; <END> if ( VAR_5 == null ) { VAR_5 = TYPE_8 . TYPE_9 . create ( TYPE_5 . METHOD_3 ( VAR_3 ) . build ( ) ) ; } TYPE_1 VAR_6 = new TYPE_1 ( new TYPE_6 ( VAR_1 . getPath ( ) , VAR_2 ) , new ... | private TYPE_1 METHOD_1 ( TYPE_2 VAR_1 , int VAR_2 ) { TYPE_1 VAR_6 = new TYPE_1 ( new TYPE_6 ( VAR_1 . getPath ( ) , VAR_2 ) , new TYPE_7 ( 3 ) ) ; VAR_6 . run ( ) ; return VAR_6 ; } |
need throw exception I thought null signal failed create | public static synchronized TYPE_1 get ( TYPE_2 conf ) throws IOException { if ( VAR_1 == null ) { try { VAR_1 = Optional . of ( create ( conf ) ) ; } catch ( IOException e ) { VAR_1 = Optional . empty ( ) ; <START> throw e ; <END> } } return VAR_1 . METHOD_1 ( null ) ; } | public static synchronized TYPE_1 get ( TYPE_2 conf ) throws IOException { if ( VAR_1 == null ) { VAR_1 = create ( conf ) ; } return VAR_1 ; } |
supposed shell | public TYPE_3 ( TYPE_1 VAR_2 ) { super ( VAR_2 ) ; LOG . info ( STRING_1 ) ; VAR_3 = VAR_2 . METHOD_1 ( ) ; <START> VAR_4 = TYPE_2 . METHOD_2 ( TYPE_4 . VAR_6 ) ; <END> VAR_7 = TYPE_2 . METHOD_2 ( TYPE_4 . VAR_8 ) ; } | public TYPE_3 ( TYPE_1 VAR_2 ) { super ( VAR_2 ) ; LOG . info ( STRING_1 ) ; VAR_3 = VAR_2 . METHOD_1 ( ) ; VAR_7 = TYPE_2 . METHOD_2 ( TYPE_4 . VAR_8 ) ; } |
reason want _CODE_ | public TYPE_2 ( ) { <START> VAR_2 = new TYPE_1 < > ( ) ; <END> } | public TYPE_2 ( ) { VAR_2 = new HashMap < > ( ) ; } |
METHOD_1 sequential count set 0 | public void METHOD_1 ( long position ) throws IOException { <START> if ( Math . VAR_1 ( position - VAR_2 ) > VAR_3 ) { <END> VAR_4 = 0 ; } else { ( ( TYPE_1 ) in ) . METHOD_1 ( position ) ; } VAR_2 = position ; } | public void METHOD_1 ( long position ) throws IOException { if ( position < VAR_2 || position - VAR_2 > VAR_3 ) { VAR_4 = 0 ; } VAR_2 = position ; } |
guaranteed positioned correctly | public long METHOD_1 ( long n ) throws IOException { if ( n > VAR_1 ) { VAR_2 = 0 ; VAR_3 += n ; return n ; } else { <START> long VAR_4 = ( ( TYPE_1 ) in ) . METHOD_1 ( n ) ; <END> VAR_3 += VAR_4 ; return VAR_4 ; } } | public long METHOD_1 ( long n ) throws IOException { if ( n <= 0 ) { return 0 ; } if ( n > VAR_1 ) { VAR_2 = 0 ; } VAR_3 += n ; return n ; } |
if1 stream random read mode VAR_1 = 02 _CODE_ METHOD_1 ( VAR_2 - 1 ) 3 calling METHOD_1 _CODE_ undesired ? instead refactor creating auxiliary method _CODE_ = VAR_3 > sequential_read_limitif ( position < VAR_1 || position - VAR_1 > VAR_2 ) { VAR_3 = 0 ; } ( _CODE_ ( ) ) { ( ( TYPE_1 ) ) METHOD_1 ( position ) ; | public void METHOD_1 ( long position ) throws IOException { if ( position < VAR_1 || position - VAR_1 > VAR_2 ) { VAR_3 = 0 ; } else { <START> ( ( TYPE_1 ) in ) . METHOD_1 ( position ) ; <END> } VAR_1 = position ; } | public void METHOD_1 ( long position ) throws IOException { if ( position < VAR_1 || position - VAR_1 > VAR_2 ) { VAR_3 = 0 ; } VAR_1 = position ; } |
VAR_1 | public void METHOD_1 ( TYPE_1 path , TYPE_2 status ) { <START> TYPE_2 VAR_1 = VAR_2 . METHOD_2 ( path , status ) ; <END> if ( ! path . getName ( ) . equals ( status . getName ( ) ) ) { throw new IllegalArgumentException ( String . format ( STRING_1 , path . getName ( ) , status . getName ( ) ) ) ; } } | public TYPE_2 METHOD_1 ( TYPE_1 path , TYPE_2 status ) { if ( ! path . getName ( ) . equals ( status . getName ( ) ) ) { throw new IllegalArgumentException ( String . format ( STRING_1 , path . getName ( ) , status . getName ( ) ) ) ; } return VAR_2 . put ( path , status ) ; } |
LRU evictor : void _CODE_ ( long _CODE_ long VAR_1 _CODE_ location ) { / / temp block committed update evictor new added _CODE_ put ( VAR_1 UNUSED_MAP_VALUE ) ; } doesn t newly created blocks added tail LRU cache ( ) | public TYPE_1 METHOD_1 ( long VAR_1 , TYPE_2 VAR_2 ) { long VAR_3 = 0 ; <START> if ( VAR_2 != null ) { <END> VAR_3 = VAR_4 . METHOD_2 ( ) ; } if ( LOG . VAR_5 ( ) ) { LOG . debug ( STRING_1 , VAR_1 , VAR_3 ) ; } return new TYPE_2 ( VAR_3 ) ; } | public TYPE_1 METHOD_1 ( long VAR_1 , TYPE_2 VAR_2 ) { long VAR_3 = VAR_4 . METHOD_2 ( ) ; if ( LOG . VAR_5 ( ) ) { LOG . debug ( STRING_1 , VAR_1 , VAR_3 ) ; } return new TYPE_2 ( VAR_3 ) ; } |
add synchronization | <START> protected synchronized long METHOD_1 ( ) throws TYPE_1 { <END> return METHOD_2 ( ( ) - > VAR_1 . METHOD_3 ( TYPE_2 . METHOD_4 ( ) . METHOD_5 ( METHOD_6 ( ) ) . build ( ) ) . METHOD_7 ( ) , LOG , STRING_1 , "" ) ; } | protected long METHOD_1 ( ) throws TYPE_1 { return METHOD_2 ( ( ) - > VAR_1 . METHOD_3 ( TYPE_2 . METHOD_4 ( ) . METHOD_5 ( METHOD_6 ( ) ) . build ( ) ) . METHOD_7 ( ) , LOG , STRING_1 , "" ) ; } |
lines | public String METHOD_1 ( String url ) throws IOException { <START> String VAR_1 ; <END> VAR_1 = TYPE_1 . get ( url , VAR_2 ) ; return String . format ( STRING_1 , url , VAR_1 ) ; } | public String METHOD_1 ( String url ) throws IOException { String VAR_1 = TYPE_1 . get ( url , VAR_2 ) ; return String . format ( STRING_1 , url , VAR_1 ) ; } |
h optional I num args stay 1 please build alluxio give a manual test | public void METHOD_1 ( TYPE_1 VAR_1 ) throws TYPE_2 { <START> TYPE_3 . METHOD_2 ( this , VAR_1 , 2 ) ; <END> } | public void METHOD_1 ( TYPE_1 VAR_1 ) throws TYPE_2 { TYPE_3 . METHOD_2 ( this , VAR_1 , 1 ) ; } |
want - null issue METHOD_1 ? basically set null finally | public synchronized void close ( ) { if ( VAR_1 != null ) { try { VAR_1 . METHOD_1 ( ) ; <START> VAR_1 = null ; <END> } catch ( TYPE_1 VAR_2 ) { LOG . debug ( STRING_1 , VAR_2 ) ; } } } | public synchronized void close ( ) { if ( VAR_1 != null ) { try { VAR_1 . METHOD_1 ( ) ; } catch ( TYPE_1 VAR_2 ) { LOG . debug ( STRING_1 , VAR_2 ) ; } finally { VAR_1 = null ; } } } |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.