ReviewComments
stringlengths
1
2.35k
OriginalCode
stringlengths
28
487
ReviewedCode
stringlengths
14
463
remove VAR_2 TYPE_2 ( need screenshot )
public void METHOD_1 ( ) { METHOD_2 ( VAR_1 ) ; TYPE_1 . assertTrue ( VAR_1 . METHOD_3 ( ) ) ; <START> TYPE_2 . log ( STRING_1 , STRING_2 , true , VAR_2 ) ; <END> }
public void METHOD_1 ( ) { METHOD_2 ( VAR_1 ) ; TYPE_1 . assertTrue ( VAR_1 . METHOD_3 ( ) ) ; TYPE_2 . log ( STRING_1 , STRING_2 , true ) ; }
remove VAR_3
public void METHOD_1 ( ) { String VAR_1 = METHOD_2 ( ) ; VAR_2 . METHOD_3 ( VAR_1 ) ; <START> TYPE_1 . log ( STRING_1 , STRING_2 , true , VAR_3 ) ; <END> }
public void METHOD_1 ( ) { String VAR_1 = METHOD_2 ( ) ; VAR_2 . METHOD_3 ( VAR_1 ) ; TYPE_1 . log ( STRING_1 , STRING_2 , true ) ; }
method another method encapsulation
<START> private void METHOD_1 ( String query ) { <END> METHOD_2 ( VAR_1 ) ; VAR_1 . METHOD_3 ( query ) ; }
public void METHOD_1 ( String query ) { VAR_1 . METHOD_3 ( query ) ; }
VAR_2
public void METHOD_1 ( ) { METHOD_2 ( VAR_1 ) ; METHOD_3 ( ) ; <START> TYPE_1 . log ( STRING_1 , STRING_2 , true , VAR_2 ) ; <END> }
public void METHOD_1 ( ) { METHOD_2 ( VAR_1 ) ; TYPE_1 . log ( STRING_1 , STRING_2 , true ) ; }
I argument constructor ( default visibility ) provide a factory method creates TYPE_2 production executor service
public TYPE_2 ( TYPE_1 VAR_2 ) { <START> VAR_3 = METHOD_1 ( ) ; <END> this . VAR_2 = VAR_2 ; }
public TYPE_2 ( TYPE_1 VAR_2 ) { this ( METHOD_1 ( ) , VAR_2 ) ; }
class constructor getter / setter
public TYPE_1 METHOD_1 ( ) { <START> TYPE_1 VAR_1 = new TYPE_1 ( ) ; <END> TYPE_2 status = new TYPE_2 ( ) ; VAR_1 . METHOD_2 ( status ) ; VAR_1 . METHOD_3 ( METHOD_4 ( ) ) ; VAR_1 . METHOD_5 ( TYPE_3 . create ( ) ) ; VAR_1 . METHOD_6 ( TYPE_5 . TYPE_6 . METHOD_7 ( ) ) ; return VAR_1 ; }
public TYPE_1 METHOD_1 ( ) { TYPE_1 VAR_1 = new TYPE_1 ( ) ; VAR_1 . METHOD_3 ( METHOD_4 ( ) ) ; VAR_1 . METHOD_5 ( TYPE_3 . create ( ) ) ; VAR_1 . METHOD_6 ( TYPE_5 . TYPE_6 . METHOD_7 ( ) ) ; return VAR_1 ; }
inline
private TYPE_1 METHOD_1 ( ) { <START> Collection < TYPE_2 > VAR_1 = new ArrayList < > ( ) ; <END> return new TYPE_1 ( STRING_1 , "" , STRING_2 , STRING_3 , null , STRING_4 , STRING_5 , VAR_1 ) ; }
private TYPE_1 METHOD_1 ( ) { return new TYPE_1 ( STRING_1 , "" , STRING_2 , STRING_3 , null , STRING_4 , STRING_5 , new ArrayList < > ( ) ) ; }
please rewrite constructor project style guide
public TYPE_4 ( TYPE_1 VAR_2 ) { <START> super ( VAR_2 ) ; <END> VAR_3 = ( TYPE_2 ) ( ( ( TYPE_3 ) METHOD_1 ( ) ) . METHOD_2 ( ) ) ; Set VAR_4 = VAR_3 . METHOD_3 ( ) ; VAR_4 . forEach ( System . out : : println ) ; VAR_5 = VAR_4 . METHOD_4 ( ) [ 1 ] . toString ( ) ; }
public TYPE_4 ( TYPE_1 VAR_2 ) { super ( VAR_2 ) ; }
making method public necessary ? need expose method public _CODE_ ? t package private
<START> public static TYPE_1 METHOD_1 ( final TYPE_2 in ) throws IOException { <END> TYPE_3 . METHOD_2 ( in , STRING_1 ) ; final List < TYPE_4 > VAR_1 = new TYPE_5 ( ) . METHOD_3 ( new TYPE_6 ( in , TYPE_7 . VAR_3 ) ) ; return new TYPE_1 ( VAR_1 ) ; }
private static TYPE_1 METHOD_1 ( final TYPE_2 in ) throws IOException { final List < TYPE_4 > VAR_1 = new TYPE_5 ( ) . METHOD_3 ( new TYPE_6 ( in , TYPE_7 . VAR_3 ) ) ; return new TYPE_1 ( VAR_1 ) ; }
smotrakov please _CODE_ _CODE_ parameter alternatively want - case sensitive regex matching
static boolean METHOD_1 ( final String VAR_1 ) { <START> final String VAR_2 = VAR_1 . METHOD_2 ( ) ; <END> for ( final TYPE_1 VAR_3 : VAR_4 ) { if ( VAR_3 . matcher ( VAR_2 ) . METHOD_3 ( ) ) { return true ; } } return false ; }
static boolean METHOD_1 ( final String VAR_1 ) { for ( final TYPE_1 VAR_3 : VAR_4 ) { if ( VAR_3 . matcher ( VAR_1 ) . METHOD_3 ( ) ) { return true ; } } return false ; }
a more more direct doesn t METHOD_2 example fail clojure VAR_4
private boolean METHOD_1 ( String VAR_1 , int VAR_2 ) { try { TYPE_1 < Boolean > VAR_3 = new TYPE_1 < > ( ) ; <START> VAR_4 . METHOD_2 ( STRING_1 + VAR_1 + STRING_2 , new TYPE_2 ( ) , VAR_2 , VAR_5 - > { <END> VAR_3 . METHOD_3 ( ! VAR_5 . getStatus ( ) . equals ( TYPE_4 . VAR_7 ) ) ; } ) ; return VAR_3 . get ( ) ; } ca...
private boolean METHOD_1 ( String VAR_1 , int VAR_2 ) { try { TYPE_1 < Boolean > VAR_3 = new TYPE_1 < > ( ) ; VAR_4 . METHOD_2 ( "" , new TYPE_2 ( ) , VAR_2 , VAR_5 - > VAR_3 . METHOD_3 ( ! VAR_5 . getStatus ( ) . equals ( TYPE_4 . VAR_7 ) ) ) ; return VAR_3 . get ( ) ; } catch ( InterruptedException | TYPE_3 e ) { ret...
please empty cell hack
private boolean METHOD_1 ( String VAR_1 , int VAR_2 ) { try { VAR_1 = VAR_1 . METHOD_2 ( STRING_1 , "" ) ; TYPE_1 < Boolean > VAR_3 = new TYPE_1 < > ( ) ; <START> VAR_4 . METHOD_3 ( STRING_2 + VAR_1 + STRING_3 , new TYPE_2 ( ) , VAR_2 , <END> VAR_5 - > VAR_3 . METHOD_4 ( ! VAR_5 . getStatus ( ) . equals ( TYPE_4 . VAR_...
private boolean METHOD_1 ( String VAR_1 , int VAR_2 ) { try { TYPE_1 < Boolean > VAR_3 = new TYPE_1 < > ( ) ; VAR_4 . METHOD_3 ( "" , new TYPE_2 ( ) , VAR_2 , VAR_5 - > VAR_3 . METHOD_4 ( ! VAR_5 . getStatus ( ) . equals ( TYPE_4 . VAR_7 ) ) ) ; return VAR_3 . get ( ) ; } catch ( InterruptedException | TYPE_3 e ) { ret...
warning conditional
private void METHOD_1 ( TYPE_1 message ) { if ( METHOD_2 ( message , TYPE_2 . VAR_2 ) ) { METHOD_3 ( message , TYPE_2 . VAR_2 , this : : METHOD_4 ) ; } <START> LOGGER . warn ( STRING_1 + message . toString ( ) ) ; <END> }
private void METHOD_1 ( TYPE_1 message ) { if ( METHOD_2 ( message , TYPE_2 . VAR_2 ) ) { METHOD_3 ( message , TYPE_2 . VAR_2 , this : : METHOD_4 ) ; } }
needs dates strings
protected boolean METHOD_1 ( final Object value ) { <START> return value instanceof Date ; <END> }
protected boolean METHOD_1 ( final Object value ) { return value instanceof Date || value instanceof String ; }
a reason accessors ? enclosing class read members needed move class file
<START> public Boolean METHOD_1 ( ) { <END> return this . VAR_1 ; }
Boolean METHOD_1 ( ) { return this . VAR_1 ; }
need synchronize ( a TYPE_1 ) immutable
public void METHOD_1 ( TYPE_1 value , TYPE_2 VAR_1 , TYPE_3 VAR_2 ) throws IOException , TYPE_4 { <START> synchronized ( value ) { <END> VAR_1 . METHOD_2 ( ) ; VAR_1 . METHOD_3 ( STRING_1 , value . VAR_3 ( ) ) ; VAR_1 . METHOD_4 ( ) ; } }
public void METHOD_1 ( TYPE_1 value , TYPE_2 VAR_1 , TYPE_3 VAR_2 ) throws IOException , TYPE_4 { VAR_1 . METHOD_2 ( ) ; VAR_1 . METHOD_3 ( STRING_1 , value . VAR_3 ( ) ) ; VAR_1 . METHOD_4 ( ) ; }
TYPE_1 mutable synchronize
public void METHOD_1 ( TYPE_1 value , TYPE_2 VAR_1 , TYPE_3 VAR_2 ) throws IOException , TYPE_4 { <START> VAR_1 . METHOD_2 ( ) ; <END> VAR_1 . METHOD_3 ( STRING_1 , STRING_2 ) ; VAR_1 . METHOD_3 ( STRING_3 , value . VAR_3 ) ; VAR_1 . METHOD_3 ( STRING_4 , value . values ) ; VAR_1 . METHOD_4 ( ) ; }
public void METHOD_1 ( TYPE_1 value , TYPE_2 VAR_1 , TYPE_3 VAR_2 ) throws IOException , TYPE_4 { synchronized ( value ) { VAR_1 . METHOD_2 ( ) ; VAR_1 . METHOD_3 ( STRING_1 , STRING_2 ) ; VAR_1 . METHOD_3 ( STRING_3 , value . VAR_3 ) ; VAR_1 . METHOD_3 ( STRING_4 , value . values ) ; VAR_1 . METHOD_4 ( ) ; } }
ANNOTATION_1 après tu fais assert ! = null
private TYPE_1 < TYPE_2 > METHOD_1 ( final TYPE_3 VAR_1 , TYPE_1 < TYPE_2 > results ) { return results . filter ( new TYPE_4 < TYPE_2 > ( ) { @Override public boolean apply ( ANNOTATION_1 TYPE_2 event ) { <START> assert event != null ; <END> return VAR_1 == null || event . VAR_2 ( ) . METHOD_2 ( VAR_1 ) || event . VAR_...
private TYPE_1 < TYPE_2 > METHOD_1 ( final TYPE_3 VAR_1 , TYPE_1 < TYPE_2 > results ) { return results . filter ( new TYPE_4 < TYPE_2 > ( ) { @Override public boolean apply ( ANNOTATION_1 TYPE_2 event ) { return event != null && ( VAR_1 == null || event . VAR_2 ( ) . METHOD_2 ( VAR_1 ) || event . VAR_2 ( ) . METHOD_3 (...
METHOD_8 ( 1 )
public void METHOD_1 ( TYPE_1 VAR_1 ) throws TYPE_2 , TYPE_3 , TYPE_4 { long VAR_2 = 1 ; TYPE_5 VAR_3 = TYPE_6 . METHOD_2 ( ) ; TYPE_7 node = VAR_3 . METHOD_3 ( TYPE_10 . VAR_5 ) ; node . add ( VAR_2 ) ; when ( VAR_6 . METHOD_4 ( ) ) . METHOD_5 ( VAR_3 ) ; TYPE_8 result = VAR_7 . METHOD_6 ( ) ; assertEquals ( TYPE_9 . ...
public void METHOD_1 ( TYPE_1 VAR_1 ) throws TYPE_2 , TYPE_3 , TYPE_4 { long VAR_2 = 1 ; TYPE_5 VAR_3 = TYPE_6 . METHOD_2 ( ) ; TYPE_7 node = VAR_3 . METHOD_3 ( TYPE_10 . VAR_5 ) ; node . add ( VAR_2 ) ; when ( VAR_6 . METHOD_4 ( ) ) . METHOD_5 ( VAR_3 ) ; TYPE_8 result = VAR_7 . METHOD_6 ( ) ; assertEquals ( TYPE_9 . ...
pourquoi utiliser une valeur invalid plutot null
public TYPE_2 ( ) { VAR_2 = new ArrayList < > ( ) ; <START> VAR_3 = TYPE_1 . VAR_5 ; <END> }
public TYPE_2 ( ) { VAR_2 = new ArrayList < > ( ) ; VAR_3 = null ; }
il semble qu au début de la session s était dit les usages de essayait de les limiter au assignations dans le constructeur
public TYPE_1 METHOD_1 ( TYPE_2 user ) { TYPE_1 VAR_1 = new TYPE_1 ( user ) ; <START> this . VAR_2 . create ( VAR_1 ) ; <END> return VAR_1 ; }
public TYPE_1 METHOD_1 ( TYPE_2 user ) { TYPE_1 VAR_1 = new TYPE_1 ( user ) ; VAR_2 . create ( VAR_1 ) ; return VAR_1 ; }
C est quoi l avantage d utiliser METHOD_6 ajouter l exception à la signature le test va échouer
public void METHOD_1 ( ) { TYPE_1 VAR_1 = METHOD_2 ( TYPE_2 . class ) ; VAR_2 = new TYPE_3 < TYPE_4 > ( VAR_1 ) { } ; VAR_2 . create ( new TYPE_4 ( ) ) ; try { METHOD_3 ( VAR_1 , METHOD_4 ( 1 ) ) . METHOD_5 ( VAR_2 ) ; } catch ( Exception ex ) { <START> METHOD_6 ( STRING_1 ) ; <END> } }
public void METHOD_1 ( ) throws IOException { TYPE_1 VAR_1 = METHOD_2 ( TYPE_2 . class ) ; VAR_2 = new TYPE_3 < TYPE_4 > ( VAR_1 ) { } ; VAR_2 . create ( new TYPE_4 ( ) ) ; METHOD_3 ( VAR_1 , METHOD_4 ( 1 ) ) . METHOD_5 ( VAR_2 ) ; }
la meilleure façon de savoir si est dans le champ est le jour ou aura besoin d injecter des services dans les modèles ahah
public void METHOD_1 ( int VAR_1 ) throws TYPE_1 { if ( VAR_2 < VAR_1 ) throw new TYPE_1 ( ) ; <START> VAR_2 -= VAR_1 ; <END> }
public synchronized void METHOD_1 ( int VAR_1 ) throws TYPE_1 { if ( VAR_2 < VAR_1 ) throw new TYPE_1 ( ) ; VAR_2 -= VAR_1 ; }
thanks time review
public void METHOD_1 ( String key , Object value ) { if ( VAR_1 == null ) { VAR_1 = new HashMap < String , Object > ( ) ; VAR_1 . put ( key , value ) ; } else { VAR_1 . put ( key , value ) ; <START> } <END> }
public void METHOD_1 ( String key , Object value ) { if ( VAR_1 == null ) { VAR_1 = new HashMap < String , Object > ( ) ; } VAR_1 . put ( key , value ) ; }
remove line ? printing sysout please
public void METHOD_1 ( ) throws Exception { METHOD_1 ( - INT_1 , - INT_2 ) ; <START> System . out . println ( STRING_1 ) ; <END> }
public void METHOD_1 ( ) throws Exception { METHOD_1 ( - INT_1 , - INT_2 ) ; }
username password part API base ? understanding constant ( case ) parameters appended dynamically username password appended _CODE_ ( ) method
public TYPE_4 ( String user , String VAR_2 ) { super ( TYPE_3 . VAR_4 ) ; <START> VAR_5 = String . format ( STRING_1 , <END> VAR_6 , user , VAR_2 ) ; try { VAR_7 = TYPE_1 . METHOD_1 ( System . getProperty ( TYPE_1 . VAR_8 ) , null ) ; } catch ( final TYPE_2 x ) { throw new RuntimeException ( x ) ; } }
public TYPE_4 ( String user , String VAR_2 ) { super ( TYPE_3 . VAR_4 ) ; this . user = user ; this . VAR_2 = VAR_2 ; try { VAR_7 = TYPE_1 . METHOD_1 ( System . getProperty ( TYPE_1 . VAR_8 ) , null ) ; } catch ( final TYPE_2 x ) { throw new RuntimeException ( x ) ; } }
work CRLF delimited strings ? s LF need call method normalized string stop caring CR clearer return start + 1 ; instead breaking iteration
private static int METHOD_1 ( String s ) { int start = TYPE_1 . length ( ) ; boolean VAR_1 = false ; while ( start < s . length ( ) && TYPE_2 . METHOD_2 ( s . VAR_2 ( start ) ) ) { if ( s . VAR_2 ( start ) == CHAR_1 || s . VAR_2 ( start ) == CHAR_2 ) { <START> VAR_1 = true ; <END> } else if ( VAR_1 ) { break ; } start ...
private static int METHOD_1 ( String s ) { int start = TYPE_1 . length ( ) ; while ( start < s . length ( ) && TYPE_2 . METHOD_2 ( s . VAR_2 ( start ) ) ) { if ( s . VAR_2 ( start ) == CHAR_2 ) { return start + 1 ; } start ++ ; } return start ; }
a solution wrt visibility move _CODE_ _CODE_ package _CODE_ change 7 0 ( method ) _CODE_ experimental remove new API freely 7 0
<START> public static void METHOD_1 ( ) { <END> TYPE_1 . METHOD_1 ( ) ; }
static void METHOD_1 ( ) { TYPE_1 . METHOD_1 ( ) ; }
please call other constructor ( VAR_2 VAR_3 VAR_4 - 1 - 1 ) don t need duplicate logic
public TYPE_2 ( String VAR_2 , String VAR_3 , int VAR_4 ) { METHOD_1 ( VAR_2 ) ; this . VAR_3 = VAR_3 ; this . VAR_4 = VAR_4 ; <START> this . VAR_5 = - 1 ; <END> this . VAR_6 = - 1 ; this . index = TYPE_1 . get ( ) . METHOD_2 ( ) ; }
public TYPE_2 ( String VAR_2 , String VAR_3 , int VAR_4 ) { this ( VAR_2 , VAR_3 , VAR_4 , - 1 , - 1 ) ; }
internalize * _CODE_ impls master
<START> public TYPE_2 ( TYPE_1 VAR_2 ) { <END> super ( VAR_2 ) ; }
TYPE_2 ( TYPE_1 VAR_2 ) { super ( VAR_2 ) ; }
add constructors TYPE_9 ? * TYPE_9 ( ) - default constructor compatibility * TYPE_9 ( _CODE_ ) - new _CODE_ resource loader a property VAR_6 factory a method argument parsing VAR_6 element theory reuse TYPE_9 instance parsing rules ruleset ( don t currently )
private void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 , TYPE_3 VAR_3 ) throws TYPE_4 , TYPE_5 , TYPE_6 { TYPE_7 VAR_4 = ( TYPE_7 ) VAR_3 ; if ( StringUtils . VAR_5 ( VAR_1 . METHOD_2 ( ) ) && ! METHOD_3 ( VAR_4 , VAR_1 . METHOD_2 ( ) ) ) { return ; } <START> TYPE_8 VAR_6 = new TYPE_9 ( ) . METHOD_4 ( VAR_4 , VAR_7 ) ; <E...
private void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 , TYPE_3 VAR_3 ) throws TYPE_4 , TYPE_5 , TYPE_6 { TYPE_7 VAR_4 = ( TYPE_7 ) VAR_3 ; if ( StringUtils . VAR_5 ( VAR_1 . METHOD_2 ( ) ) && ! METHOD_3 ( VAR_4 , VAR_1 . METHOD_2 ( ) ) ) { return ; } TYPE_8 VAR_6 = new TYPE_9 ( VAR_7 ) . METHOD_4 ( VAR_4 ) ; VAR_6 . METH...
please call other constructor : ( new TYPE_1 ( ) VAR_2 VAR_3 ) ; need duplicated code
public TYPE_2 ( String name , String VAR_2 , String VAR_3 ) { <START> this . name = name ; <END> this . VAR_4 = new TYPE_1 ( ) ; METHOD_1 ( VAR_3 ) ; METHOD_2 ( VAR_2 ) ; }
public TYPE_2 ( String name , String VAR_2 , String VAR_3 ) { this ( name , new TYPE_1 ( ) , VAR_2 , VAR_3 ) ; }
Collections _CODE_ instead a new TYPE_2
public static Set < TYPE_1 > METHOD_1 ( ) { <START> return new TYPE_2 < > ( getInstance ( ) . VAR_1 . values ( ) ) ; <END> }
public static Set < TYPE_1 > METHOD_1 ( ) { return getInstance ( ) . VAR_1 ; }
unrelated rest PR related original report
private static long METHOD_1 ( final File VAR_1 ) { try ( TYPE_1 stream = new TYPE_1 ( new TYPE_2 ( TYPE_3 . METHOD_2 ( VAR_1 . METHOD_3 ( ) ) ) , new TYPE_4 ( ) ) ; ) { TYPE_5 . METHOD_4 ( stream , VAR_1 . length ( ) ) ; return stream . VAR_2 ( ) . getValue ( ) ; } catch ( final IOException VAR_3 ) { } <START> return ...
private static long METHOD_1 ( final File VAR_1 ) { try ( TYPE_1 stream = new TYPE_1 ( new TYPE_2 ( TYPE_3 . METHOD_2 ( VAR_1 . METHOD_3 ( ) ) ) , new TYPE_4 ( ) ) ; ) { TYPE_5 . METHOD_4 ( stream , VAR_1 . length ( ) ) ; return stream . VAR_2 ( ) . getValue ( ) ; } catch ( final IOException VAR_3 ) { } return 0 ; }
build behavior TYPE_3 METHOD_4
public TYPE_1 METHOD_1 ( String VAR_1 ) { List < TYPE_1 > VAR_2 = METHOD_2 ( ) ; for ( TYPE_1 VAR_3 : VAR_2 ) { <START> if ( VAR_3 . getType ( ) != null ) { <END> if ( VAR_1 . equals ( VAR_3 . getType ( ) . getName ( ) ) ) { return VAR_3 ; } } else { TYPE_2 name = VAR_3 . METHOD_3 ( TYPE_2 . class ) ; if ( name != null...
public TYPE_1 METHOD_1 ( String VAR_1 ) { List < TYPE_1 > VAR_2 = METHOD_2 ( ) ; for ( TYPE_1 VAR_3 : VAR_2 ) { TYPE_2 name = VAR_3 . METHOD_3 ( TYPE_2 . class ) ; if ( name != null && TYPE_3 . METHOD_4 ( name , VAR_1 ) ) { return VAR_3 ; } } return null ; }
need a boxed primitive
<START> private Boolean METHOD_1 ( final List < TYPE_3 . TYPE_4 > VAR_1 ) { <END> return VAR_1 . stream ( ) . METHOD_2 ( VAR_2 - > TYPE_2 . equals ( VAR_2 . METHOD_3 ( ) ) ) ; }
private boolean METHOD_1 ( final List < TYPE_3 . TYPE_4 > VAR_1 ) { return VAR_1 . stream ( ) . METHOD_2 ( VAR_2 - > TYPE_2 . equals ( VAR_2 . METHOD_3 ( ) ) ) ; }
need a boxed primitive
<START> private Boolean METHOD_1 ( final TYPE_4 . TYPE_6 ctx ) { <END> if ( ctx == null || ctx . VAR_1 ( ) == null ) { return false ; } final List < TYPE_4 . TYPE_5 > VAR_1 = ctx . VAR_1 ( ) . METHOD_2 ( ) ; return VAR_1 . size ( ) == 1 && TYPE_3 . equals ( VAR_1 . get ( 0 ) . METHOD_3 ( ) . METHOD_4 ( ) ) ; }
private boolean METHOD_1 ( final TYPE_4 . TYPE_6 ctx ) { if ( ctx == null || ctx . VAR_1 ( ) == null ) { return false ; } final List < TYPE_4 . TYPE_5 > VAR_1 = ctx . VAR_1 ( ) . METHOD_2 ( ) ; return VAR_1 . size ( ) == 1 && TYPE_3 . equals ( VAR_1 . get ( 0 ) . METHOD_3 ( ) . METHOD_4 ( ) ) ; }
image attribute supposed text node I d separate ( previous attribute fine ) A practical reason future other languages a text node case wouldn t fetched METHOD_1 compatibility a METHOD_2 method _CODE_ #1728 * * deprecate put METHOD_1 soon 7 0 contract super loose
<START> public String METHOD_1 ( ) { <END> return METHOD_2 ( ) ; }
public String METHOD_1 ( ) { return null ; }
please remove System
public void METHOD_1 ( ) throws IOException { final String VAR_1 = TYPE_1 . toString ( TYPE_2 . class . METHOD_2 ( STRING_1 ) , TYPE_5 . VAR_3 ) ; TYPE_3 VAR_4 = parse ( VAR_1 ) ; <START> System . out . println ( VAR_4 . METHOD_3 ( ) ) ; <END> assertTrue ( TYPE_4 . METHOD_4 ( ) != VAR_4 . METHOD_3 ( ) . get ( 0 ) ) ; a...
public void METHOD_1 ( ) throws IOException { final String VAR_1 = TYPE_1 . toString ( TYPE_2 . class . METHOD_2 ( STRING_1 ) , TYPE_5 . VAR_3 ) ; TYPE_3 VAR_4 = parse ( VAR_1 ) ; assertTrue ( TYPE_4 . METHOD_4 ( ) != VAR_4 . METHOD_3 ( ) . get ( 0 ) ) ; assertEquals ( INT_1 , VAR_4 . size ( ) ) ; }
a public test method consider turning METHOD_2 package - private accessible test ( package ) invisible world
<START> public List < TYPE_1 < ? > > METHOD_1 ( TYPE_2 VAR_1 , TYPE_3 VAR_2 ) { <END> return METHOD_2 ( VAR_1 , VAR_2 ) ; }
List < TYPE_1 < ? > > METHOD_1 ( TYPE_2 VAR_1 , TYPE_3 VAR_2 ) { return METHOD_2 ( VAR_1 , VAR_2 ) ; }
I m optional… I throw ( equivalent enum valueOf ) … PR simply calls ( ) optional throw called illegally…
public static Optional < TYPE_1 > METHOD_1 ( String token ) { <START> return Optional . VAR_1 ( TYPE_2 . get ( token ) ) ; <END> }
public static TYPE_1 METHOD_1 ( String token ) { return TYPE_2 . get ( token ) ; }
METHOD_1 package private ? public
<START> TYPE_1 METHOD_1 ( ) { <END> return ( TYPE_1 ) METHOD_2 ( METHOD_3 ( ) - 1 ) ; }
public TYPE_1 METHOD_1 ( ) { return ( TYPE_1 ) METHOD_2 ( METHOD_3 ( ) - 1 ) ; }
constructors package private
<START> public TYPE_1 ( int id ) { <END> super ( id ) ; }
TYPE_1 ( int id ) { super ( id ) ; }
implementation bogus simply call return VAR_1 ( VAR_2 false ) ;
default < T > List < T > VAR_1 ( Class < T > VAR_2 ) { final List < T > list = new ArrayList < > ( ) ; TYPE_1 . VAR_1 ( this , VAR_2 , list , false ) ; <START> return list ; <END> }
default < T > List < T > VAR_1 ( Class < T > VAR_2 ) { return VAR_1 ( VAR_2 , false ) ; }
I d move line 83 ( visit ( TYPE_1 node Object data ) ) ignore overridden methods setters
private void METHOD_1 ( TYPE_1 node , Object data , String VAR_1 ) { <START> if ( ! METHOD_2 ( node ) ) { <END> TYPE_2 VAR_2 = node . VAR_3 ( ) ; if ( METHOD_3 ( VAR_1 , STRING_1 ) && ! VAR_2 . METHOD_4 ( ) ) { METHOD_5 ( data , node , STRING_2 , new Object [ ] { VAR_1 } ) ; } } }
private void METHOD_1 ( TYPE_1 node , Object data , String VAR_1 ) { TYPE_2 VAR_2 = node . VAR_3 ( ) ; if ( METHOD_3 ( VAR_1 , STRING_1 ) && ! VAR_2 . METHOD_4 ( ) ) { METHOD_5 ( data , node , STRING_2 , new Object [ ] { VAR_1 } ) ; } }
digging sorting I java io File implements comparable VAR_4 files correctly depending operating system Collections VAR_4 ( VAR_3 ) ; change method METHOD_2 instead sorting : _CODE_ [ ] candidates = VAR_1 _CODE_ ( filter ) ; ( candidates = = null ) { return ; } Arrays VAR_4 ( candidates ) ; File instead String advantage ...
public List < File > METHOD_1 ( File VAR_1 , TYPE_1 filter , boolean VAR_2 ) { this . filter = filter ; List < File > VAR_3 = new ArrayList < > ( ) ; METHOD_2 ( VAR_1 , VAR_3 , VAR_2 ) ; Collections . VAR_4 ( VAR_3 , new TYPE_2 < File > ( ) { @Override public int METHOD_3 ( File VAR_5 , File VAR_6 ) { <START> return VA...
public List < File > METHOD_1 ( File VAR_1 , TYPE_1 filter , boolean VAR_2 ) { this . filter = filter ; List < File > VAR_3 = new ArrayList < > ( ) ; METHOD_2 ( VAR_1 , VAR_3 , VAR_2 ) ; return VAR_3 ; }
constructor doesn t rule chain a call ( ) ; missing
TYPE_1 ( Class < ? > VAR_2 ) { <START> this . VAR_2 = VAR_2 ; <END> }
TYPE_1 ( Class < ? > VAR_2 ) { this ( ) ; this . VAR_2 = VAR_2 ; }
PMD specific I guess fail time PMD wouldn t subclass _CODE_ ( _CODE_ test a single rule )
protected void METHOD_1 ( ) { String [ ] VAR_1 = getClass ( ) . METHOD_2 ( ) . getName ( ) . split ( STRING_1 ) ; <START> String VAR_2 = VAR_1 [ VAR_1 . length - 1 ] ; <END> String VAR_3 = VAR_1 [ VAR_1 . length - 3 ] ; String VAR_4 = STRING_2 + VAR_3 + STRING_3 + VAR_2 + STRING_4 ; METHOD_3 ( VAR_4 , getClass ( ) . ME...
protected void METHOD_1 ( ) { }
useless parenthesis STRING_1
private List < String > METHOD_1 ( Class [ ] VAR_1 ) { return Arrays . asList ( VAR_1 ) . stream ( ) . filter ( VAR_2 - > VAR_2 . METHOD_2 ( ) . startsWith ( STRING_1 ) ) <START> . map ( m - > m . VAR_3 ( ) . substring ( ( STRING_1 ) . length ( ) ) ) <END> . collect ( Collectors . VAR_4 ( ) ) ; }
private List < String > METHOD_1 ( Class [ ] VAR_1 ) { return Arrays . asList ( VAR_1 ) . stream ( ) . filter ( VAR_2 - > VAR_2 . METHOD_2 ( ) . startsWith ( STRING_1 ) ) . map ( m - > m . VAR_3 ( ) . substring ( STRING_1 . length ( ) ) ) . collect ( Collectors . VAR_4 ( ) ) ; }
Collectors VAR_5 ( File VAR_3 )
public String METHOD_1 ( ) { String VAR_1 = VAR_2 . getValue ( ) . stream ( ) . map ( p - > File . VAR_3 + p . VAR_4 ( ) ) <START> . collect ( Collectors . VAR_5 ( "" ) ) ; <END> return VAR_1 ; }
public String METHOD_1 ( ) { return VAR_2 . getValue ( ) . stream ( ) . map ( p - > p . VAR_4 ( ) ) . collect ( Collectors . VAR_5 ( File . VAR_3 ) ) ; }
don t _CODE_ add VAR_2
private static TYPE_1 [ ] METHOD_1 ( List < File > VAR_1 ) throws IOException { List < TYPE_1 > VAR_2 = new ArrayList < > ( ) ; for ( File f : VAR_1 ) { <START> METHOD_2 ( VAR_2 , f . VAR_3 ( ) . METHOD_3 ( ) ) ; <END> } return VAR_2 . METHOD_4 ( new TYPE_1 [ VAR_2 . size ( ) ] ) ; }
private static TYPE_1 [ ] METHOD_1 ( List < File > VAR_1 ) throws IOException { List < TYPE_1 > VAR_2 = new ArrayList < > ( ) ; for ( File f : VAR_1 ) { VAR_2 . add ( f . VAR_3 ( ) . METHOD_3 ( ) ) ; } return VAR_2 . METHOD_4 ( new TYPE_1 [ 0 ] ) ; }
callers return method ? needed
<START> public static TYPE_1 METHOD_1 ( ) { <END> if ( ! VAR_1 ) { return VAR_2 ; } return METHOD_2 ( TYPE_2 . VAR_4 ) ; }
public static void METHOD_1 ( ) { if ( ! VAR_1 ) { return ; } METHOD_2 ( TYPE_2 . VAR_4 ) ; }
? shouldn t return null / empty string
public String METHOD_1 ( ) { if ( METHOD_2 ( ) ) { <START> return METHOD_3 ( ) ; <END> } TYPE_1 VAR_1 = METHOD_4 ( TYPE_1 . class ) ; if ( VAR_1 != null ) { return VAR_1 . METHOD_3 ( ) ; } return METHOD_4 ( TYPE_2 . class ) . METHOD_3 ( ) ; }
public String METHOD_1 ( ) { TYPE_1 VAR_1 = METHOD_4 ( TYPE_1 . class ) ; if ( VAR_1 != null ) { return VAR_1 . METHOD_3 ( ) ; } return METHOD_4 ( TYPE_2 . class ) . METHOD_3 ( ) ; }
a METHOD_4
public void METHOD_1 ( ) { METHOD_2 ( VAR_1 ) ; <START> TYPE_1 n = VAR_2 . METHOD_3 ( TYPE_2 . class ) . get ( 0 ) <END> . METHOD_4 ( TYPE_1 . class ) ; assertTrue ( n . VAR_3 ( ) instanceof TYPE_3 ) ; }
public void METHOD_1 ( ) { METHOD_2 ( VAR_1 ) ; TYPE_1 n = VAR_2 . METHOD_4 ( TYPE_2 . class ) . METHOD_4 ( TYPE_1 . class ) ; assertTrue ( n . VAR_3 ( ) instanceof TYPE_3 ) ; }
return Arrays asList ( STRING_1 )
protected Collection < String > METHOD_1 ( ) { Collection < String > VAR_1 = new HashSet < > ( ) ; VAR_1 . add ( STRING_1 ) ; <START> return VAR_1 ; <END> }
protected Collection < String > METHOD_1 ( ) { return Arrays . asList ( STRING_1 ) ; }
a raw type please a parameterized type ( Collection < String > )
protected Collection < String > METHOD_1 ( ) { <START> Collection VAR_1 = new ArrayList < String > ( ) ; <END> VAR_1 . add ( STRING_1 ) ; return VAR_1 ; }
protected Collection < String > METHOD_1 ( ) { Collection < String > VAR_1 = new ArrayList < > ( ) ; VAR_1 . add ( STRING_1 ) ; return VAR_1 ; }
care
public void METHOD_1 ( final TYPE_1 cache ) { <START> if ( cache == null && METHOD_2 ( ) ) { <END> VAR_1 = new TYPE_2 ( ) ; } else { VAR_1 = cache ; } }
public void METHOD_1 ( final TYPE_1 cache ) { this . VAR_1 = cache == null ? new TYPE_2 ( ) : cache ; }
return true cleaner I missing point rule
static boolean METHOD_1 ( TYPE_1 node ) { List < TYPE_2 > VAR_1 = node . VAR_2 ( ) . METHOD_2 ( ) . METHOD_3 ( ) . METHOD_4 ( ) ; boolean VAR_3 = false ; for ( TYPE_2 VAR_4 : VAR_1 ) { if ( METHOD_5 ( VAR_4 . METHOD_6 ( ) ) ) { <START> VAR_3 = true ; <END> break ; } } return VAR_3 ; }
static boolean METHOD_1 ( TYPE_1 node ) { List < TYPE_2 > VAR_1 = node . VAR_2 ( ) . METHOD_2 ( ) . METHOD_3 ( ) . METHOD_4 ( ) ; for ( TYPE_2 VAR_4 : VAR_1 ) { if ( METHOD_5 ( VAR_4 . METHOD_6 ( ) ) ) { return true ; } } return false ; }
check moved call - sites ( l 100 ) btw case l 145
private void METHOD_1 ( ) { <START> if ( METHOD_2 ( ) ) { <END> final String VAR_1 = getProperty ( VAR_2 ) ; final String version = getProperty ( VAR_3 ) ; METHOD_3 ( version ) ; VAR_4 . METHOD_4 ( VAR_1 ) ; VAR_4 . METHOD_5 ( version ) ; VAR_4 . METHOD_6 ( METHOD_7 ( ) ) ; } }
private void METHOD_1 ( ) { String VAR_1 = getProperty ( VAR_2 ) ; String version = getProperty ( VAR_3 ) ; METHOD_3 ( version ) ; VAR_4 . METHOD_4 ( VAR_1 ) ; VAR_4 . METHOD_5 ( version ) ; VAR_4 . METHOD_6 ( METHOD_7 ( ) ) ; }
a ternary expression
private void METHOD_1 ( final String version ) { <START> if ( TYPE_1 . equals ( version ) ) { <END> VAR_1 = new TYPE_2 ( ) ; } else { VAR_1 = new TYPE_3 ( ) ; } }
private void METHOD_1 ( final String version ) { VAR_1 = TYPE_1 . equals ( version ) ? new TYPE_2 ( ) : new TYPE_3 ( ) ; }
inline variable
public TYPE_1 METHOD_1 ( ) throws TYPE_2 { if ( value == null ) { <START> final Object v = VAR_1 . getValue ( ) ; <END> value = TYPE_3 . METHOD_2 ( v ) ; } return value ; }
public TYPE_1 METHOD_1 ( ) { if ( value == null ) { value = TYPE_3 . METHOD_2 ( VAR_1 . getValue ( ) ) ; } return value ; }
arbitrary limit ? able basenode VAR_1 guaranteed a descendant
private boolean METHOD_1 ( TYPE_1 VAR_1 , TYPE_1 VAR_2 ) { TYPE_1 VAR_3 = VAR_1 ; <START> for ( int i = 0 ; i < 10 && VAR_3 != null && VAR_3 != VAR_2 ; i ++ ) { <END> VAR_3 = VAR_3 . METHOD_2 ( ) ; if ( VAR_3 instanceof TYPE_2 ) { return true ; } } return false ; }
private boolean METHOD_1 ( TYPE_1 VAR_1 , TYPE_1 VAR_2 ) { TYPE_1 VAR_3 = VAR_1 ; while ( VAR_3 != VAR_2 ) { VAR_3 = VAR_3 . METHOD_2 ( ) ; if ( VAR_3 instanceof TYPE_2 ) { return true ; } } return false ; }
reason instance field a static final
public TYPE_4 ( final TYPE_1 VAR_2 ) { this . VAR_2 = TYPE_2 . METHOD_1 ( VAR_2 ) ; <START> VAR_3 = new TYPE_3 ( ) ; <END> VAR_4 = new ArrayList < > ( ) ; VAR_5 = false ; }
public TYPE_4 ( final TYPE_1 VAR_2 ) { this . VAR_2 = TYPE_2 . METHOD_1 ( VAR_2 ) ; VAR_4 = new ArrayList < > ( ) ; VAR_5 = false ; }
package - private intended visibility ? missed access modifier
<START> TYPE_1 ( Throwable VAR_2 ) { <END> super ( VAR_2 ) ; }
public TYPE_1 ( Throwable VAR_2 ) { super ( VAR_2 ) ; }
package - private
<START> TYPE_1 METHOD_1 ( String id ) { <END> return VAR_1 . get ( id ) ; }
public TYPE_1 METHOD_1 ( String id ) { return VAR_1 . get ( id ) ; }
package - private
<START> void METHOD_1 ( String id ) { <END> VAR_1 . remove ( id ) ; }
public void METHOD_1 ( String id ) { VAR_1 . remove ( id ) ; }
theory cell factories set fxml : < ? import net sourceforge pmd util fxdesigner util controls TYPE_3 ? > < ? import net sourceforge pmd util fxdesigner util controls TYPE_4 ? > < _CODE_ fx : id = VAR_2 _CODE_ = secondary - panel _CODE_ alignment = CENTER > < _CODE_ > < TYPE_3 / > < / _CODE_ > < / _CODE_ > < _CODE_ fx :...
public void METHOD_1 ( TYPE_1 location , TYPE_2 VAR_1 ) { <START> VAR_2 . METHOD_2 ( VAR_3 - > new TYPE_3 ( ) ) ; <END> VAR_4 . METHOD_2 ( VAR_3 - > new TYPE_4 ( ) ) ; VAR_4 . METHOD_3 ( ) . METHOD_4 ( ) . METHOD_5 ( ( VAR_5 , VAR_6 , VAR_7 ) - > { if ( VAR_7 != null && VAR_7 . getValue ( ) instanceof TYPE_5 ) { parent...
public void METHOD_1 ( TYPE_1 location , TYPE_2 VAR_1 ) { VAR_4 . METHOD_3 ( ) . METHOD_4 ( ) . METHOD_5 ( ( VAR_5 , VAR_6 , VAR_7 ) - > { if ( VAR_7 != null && VAR_7 . getValue ( ) instanceof TYPE_5 ) { parent . VAR_8 ( ( TYPE_5 ) VAR_7 . getValue ( ) ) ; } } ) ; }
loop safely start VAR_1 previous indexes affected
public void METHOD_1 ( final int VAR_1 ) { if ( 0 <= VAR_1 && VAR_1 < METHOD_2 ( ) ) { VAR_2 = TYPE_1 . remove ( VAR_2 , VAR_1 ) ; <START> for ( int i = 0 ; i < METHOD_2 ( ) ; i ++ ) { <END> METHOD_3 ( i ) . METHOD_4 ( i ) ; } } }
public void METHOD_1 ( final int VAR_1 ) { if ( 0 <= VAR_1 && VAR_1 < METHOD_2 ( ) ) { VAR_2 = TYPE_1 . remove ( VAR_2 , VAR_1 ) ; for ( int i = VAR_1 ; i < METHOD_2 ( ) ; i ++ ) { METHOD_3 ( i ) . METHOD_4 ( i ) ; } } }
harmful null check done
protected Class < ? > METHOD_1 ( final String name , final boolean VAR_1 ) throws TYPE_1 { Class < ? > c = METHOD_2 ( name ) ; if ( c == null ) { <START> if ( c == null ) { <END> try { c = METHOD_3 ( name ) ; } catch ( final TYPE_1 e ) { c = super . METHOD_1 ( name , VAR_1 ) ; } } } if ( VAR_1 ) { METHOD_4 ( c ) ; } re...
protected Class < ? > METHOD_1 ( final String name , final boolean VAR_1 ) throws TYPE_1 { Class < ? > c = METHOD_2 ( name ) ; if ( c == null ) { try { c = METHOD_3 ( name ) ; } catch ( final TYPE_1 e ) { c = super . METHOD_1 ( name , VAR_1 ) ; } } if ( VAR_1 ) { METHOD_4 ( c ) ; } return c ; }
I VAR_1 size ( ) ! = 1 isn t
public boolean METHOD_1 ( ) { <START> return VAR_1 . size ( ) == 1 ; <END> }
public boolean METHOD_1 ( ) { return VAR_1 . size ( ) != 1 ; }
unit test failures ( wouldn t ) : VAR_1 METHOD_3 ( VAR_3 ) ( getClass ( ) ) - parent nodes matched ( class a class )
public < T > List < T > METHOD_1 ( Class < T > VAR_1 ) { List < T > VAR_2 = new ArrayList < > ( ) ; TYPE_1 VAR_3 = METHOD_2 ( ) ; while ( VAR_3 != null ) { <START> if ( VAR_1 . METHOD_3 ( VAR_3 . getClass ( ) ) ) { <END> VAR_2 . add ( ( T ) VAR_3 ) ; } VAR_3 = VAR_3 . METHOD_2 ( ) ; } return VAR_2 ; }
public < T > List < T > METHOD_1 ( Class < T > VAR_1 ) { List < T > VAR_2 = new ArrayList < > ( ) ; TYPE_1 VAR_3 = METHOD_2 ( ) ; while ( VAR_3 != null ) { if ( VAR_1 . METHOD_3 ( VAR_3 ) ) { VAR_2 . add ( ( T ) VAR_3 ) ; } VAR_3 = VAR_3 . METHOD_2 ( ) ; } return VAR_2 ; }
derive Class < TYPE_1 > label choices provided ? immutable a real - world case empty enumerations eludes
public TYPE_3 ( String VAR_2 , String VAR_3 , Map < String , TYPE_1 > VAR_4 , TYPE_1 VAR_5 , Class < TYPE_1 > VAR_6 , float VAR_7 ) { super ( VAR_2 , VAR_3 , VAR_5 , VAR_7 ) ; <START> this . VAR_6 = VAR_6 ; <END> VAR_8 = Collections . VAR_9 ( VAR_4 ) ; VAR_10 = Collections . VAR_9 ( TYPE_2 . METHOD_1 ( VAR_8 ) ) ; }
public TYPE_3 ( String VAR_2 , String VAR_3 , Map < String , TYPE_1 > VAR_4 , TYPE_1 VAR_5 , Class < TYPE_1 > VAR_6 , float VAR_7 ) { this ( VAR_2 , VAR_3 , VAR_4 , VAR_5 , VAR_6 , VAR_7 , false ) ; }
public Object [ ] METHOD_1 ( ) {
<START> public Object METHOD_1 ( ) { <END> return new Object ANNOTATION_1 [ 0 ] ; }
public Object [ ] METHOD_1 ( ) { return new Object ANNOTATION_1 [ 0 ] ; }
unnecessary annotation won t null catch api syntax error return caller
public TYPE_1 METHOD_1 ( TYPE_1 VAR_1 ) { <START> if ( VAR_2 == null ) <END> VAR_2 = new TYPE_2 ( 1 , TimeUnit . VAR_3 ) ; METHOD_2 ( VAR_1 ) ; if ( VAR_4 ) { VAR_5 = METHOD_3 ( VAR_5 ) ; } return ( new TYPE_3 ( VAR_1 , METHOD_4 ( ) ) ) ; }
public TYPE_1 METHOD_1 ( TYPE_1 VAR_1 ) { METHOD_2 ( VAR_1 ) ; if ( VAR_4 ) VAR_5 = METHOD_3 ( VAR_5 ) ; return ( new TYPE_3 ( VAR_1 , METHOD_4 ( ) ) ) ; }
rewrite VAR_3 = new HashSet < > ( ) ; space constructor
public TYPE_2 ( String [ ] VAR_2 ) { this . VAR_2 = new TYPE_1 < > ( ) ; <START> this . VAR_3 = new HashSet < > ( ) ; <END> Collections . addAll ( this . VAR_2 , VAR_2 ) ; }
public TYPE_2 ( String [ ] VAR_2 ) { this . VAR_2 = new TYPE_1 < > ( ) ; VAR_3 = new HashSet < > ( ) ; Collections . addAll ( this . VAR_2 , VAR_2 ) ; }
conventions please spaces brackets method parameters brackets new lines checkstyle plugin crash build run mvn install - P run - ? long time complete build cca hour
<START> public synchronized void METHOD_1 ( Map < ? , ? > t ) { <END> for ( Map . Entry < ? , ? > entry : t . entrySet ( ) ) { this . put ( entry . getKey ( ) , entry . getValue ( ) ) ; } }
public synchronized void METHOD_1 ( Map < ? , ? > t ) { for ( Map . Entry < ? , ? > entry : t . entrySet ( ) ) { put ( entry . getKey ( ) , entry . getValue ( ) ) ; } }
nice protected - arg constructor _CODE_ purposes null variables File _CODE_ necessary create new objects unused
public TYPE_3 ( ) { <START> super ( TYPE_1 . METHOD_1 ( TYPE_1 . METHOD_2 ( ) , TYPE_2 . METHOD_3 ( INT_1 ) ) ) ; <END> }
private TYPE_3 ( ) { super ( null , null , null ) ; }
please introduce a new constructor public TYPE_2 ( String source String String message ) call instead TYPE_2 METHOD_2 ? call constructor TYPE_2 METHOD_2 ? thx
public void METHOD_1 ( TYPE_1 VAR_1 ) { <START> this . VAR_2 . METHOD_1 ( TYPE_2 . METHOD_2 ( METHOD_3 ( VAR_1 . METHOD_4 ( ) ) , <END> VAR_1 . METHOD_4 ( ) . METHOD_5 ( ) , VAR_1 . getMessage ( ) ) ) ; VAR_3 . set ( Boolean . VAR_4 ) ; }
public void METHOD_1 ( TYPE_1 VAR_1 ) { VAR_2 . METHOD_1 ( new TYPE_2 ( METHOD_3 ( VAR_1 . METHOD_4 ( ) ) , VAR_1 . METHOD_4 ( ) . METHOD_5 ( ) , VAR_1 . getMessage ( ) ) ) ; VAR_3 . set ( true ) ; }
id optional _CODE_
public TYPE_1 build ( ) { TYPE_1 source = VAR_1 == null ? new TYPE_1 ( VAR_2 , VAR_3 , METHOD_1 ( ) ) : new TYPE_1 ( VAR_1 , VAR_3 , METHOD_1 ( ) ) ; <START> source . VAR_4 ( id ) ; <END> return source ; }
public TYPE_1 build ( ) { TYPE_1 source = VAR_1 == null ? new TYPE_1 ( VAR_2 , VAR_3 , METHOD_1 ( ) ) : new TYPE_1 ( VAR_1 , VAR_3 , METHOD_1 ( ) ) ; source . VAR_4 ( id ( ) ) ; return source ; }
harmless call null _CODE_ IIUC
public TYPE_1 build ( ) { TYPE_1 source = VAR_1 == null ? new TYPE_1 ( VAR_2 , VAR_3 , METHOD_1 ( ) ) : new TYPE_1 ( VAR_1 , VAR_3 , METHOD_1 ( ) ) ; <START> if ( id != null ) { <END> source . VAR_4 ( id ( ) ) ; } return source ; }
public TYPE_1 build ( ) { TYPE_1 source = VAR_1 == null ? new TYPE_1 ( VAR_2 , VAR_3 , METHOD_1 ( ) ) : new TYPE_1 ( VAR_1 , VAR_3 , METHOD_1 ( ) ) ; source . VAR_4 ( id ( ) ) ; return source ; }
scm api rules placement annotations methods
<START> @Override protected void METHOD_1 ( ) { <END> VAR_1 . METHOD_2 ( ) ; }
protected void METHOD_1 ( ) { VAR_1 . METHOD_2 ( ) ; }
annotations wrong line
<START> @Override public final String toString ( ) { <END> return VAR_1 . METHOD_1 ( ) ; }
public final String toString ( ) { return VAR_1 . METHOD_1 ( ) ; }
= = Class es
public static TYPE_1 METHOD_1 ( ANNOTATION_1 TYPE_2 source , ANNOTATION_1 TYPE_1 VAR_1 ) { for ( TYPE_3 m : TYPE_4 . METHOD_2 ( TYPE_3 . class ) ) { <START> if ( m . VAR_2 . equals ( source . getClass ( ) ) <END> && m . VAR_3 . equals ( VAR_1 . getClass ( ) ) ) { TYPE_1 VAR_4 = m . VAR_5 ( source , VAR_1 ) ; if ( VAR_4...
public static TYPE_1 METHOD_1 ( ANNOTATION_1 TYPE_2 source , ANNOTATION_1 TYPE_1 VAR_1 ) { for ( TYPE_3 m : TYPE_4 . METHOD_2 ( TYPE_3 . class ) ) { if ( m . VAR_2 == source . getClass ( ) && m . VAR_3 == VAR_1 . getClass ( ) ) { TYPE_1 VAR_4 = m . VAR_5 ( source , VAR_1 ) ; if ( VAR_4 != null ) { return VAR_4 ; } } } ...
impl package ? SCM implementation wish return others
<START> public TYPE_1 ( ) { <END> super ( STRING_1 , Messages . VAR_2 ( ) ) ; }
private TYPE_1 ( ) { super ( STRING_1 , Messages . VAR_2 ( ) ) ; }
I meant implement methods
public < T extends TYPE_1 > T METHOD_1 ( ANNOTATION_1 Class < T > type ) { <START> return TYPE_2 . class . equals ( type ) ? ( T ) new TYPE_2 ( ) { } : null ; <END> }
public < T extends TYPE_1 > T METHOD_1 ( ANNOTATION_1 Class < T > type ) { return null ; }
I don t difference _CODE_ ? speed reading isn t snuff
<START> public List < TYPE_1 > METHOD_1 ( ANNOTATION_1 TYPE_2 VAR_1 , <END> ANNOTATION_2 TYPE_3 event , ANNOTATION_1 TYPE_4 listener ) throws IOException , InterruptedException { return Collections . VAR_2 ( ) ; }
protected List < TYPE_1 > METHOD_1 ( ANNOTATION_1 TYPE_2 VAR_1 , ANNOTATION_2 TYPE_3 event , ANNOTATION_1 TYPE_4 listener ) throws IOException , InterruptedException { return Collections . VAR_2 ( ) ; }
style guide
<START> @Override public TYPE_1 METHOD_1 ( String name ) { <END> return null ; }
public TYPE_1 METHOD_1 ( String name ) { return null ; }
isn t TYPE_1 empty immutable
public void put ( String VAR_1 , String key , String value ) { if ( VAR_2 . containsKey ( VAR_1 ) ) { VAR_2 . get ( VAR_1 ) . METHOD_1 ( ) . METHOD_2 ( key , value ) ; } else { <START> TYPE_1 parse = TYPE_1 . empty ; <END> parse . put ( key , value ) ; VAR_2 . put ( VAR_1 , parse ) ; } }
public void put ( String VAR_1 , String key , String value ) { if ( VAR_2 . containsKey ( VAR_1 ) ) { VAR_2 . get ( VAR_1 ) . METHOD_1 ( ) . METHOD_2 ( key , value ) ; } else { TYPE_1 parse = new TYPE_1 ( ) ; parse . put ( key , value ) ; VAR_2 . put ( VAR_1 , parse ) ; } }
_CODE_ check values null empty
public void METHOD_1 ( String key , String [ ] values ) { <START> VAR_1 . put ( key , values ) ; <END> }
public void METHOD_1 ( String key , String [ ] values ) { if ( values == null || values . length == 0 ) return ; VAR_1 . put ( key , values ) ; }
extract priority a constant don t change 2 places
public static TYPE_1 . Builder METHOD_1 ( TYPE_1 . Builder builder ) { if ( TYPE_2 . VAR_2 . VAR_3 >= TYPE_2 . VAR_4 . VAR_5 ) { <START> return builder . VAR_6 ( TYPE_3 . VAR_8 ) . METHOD_2 ( TYPE_3 . VAR_9 ) ; <END> } return builder ; }
public static TYPE_1 . Builder METHOD_1 ( TYPE_1 . Builder builder ) { if ( TYPE_2 . VAR_2 . VAR_3 >= TYPE_2 . VAR_4 . VAR_5 ) { return builder . VAR_6 ( TYPE_3 . VAR_8 ) ; } return builder ; }
poorly chose object created a phone a clipping _CODE_ content clipping relevant test
public void METHOD_1 ( ) throws Exception { super . METHOD_1 ( ) ; <START> VAR_1 = new TYPE_1 ( ) . METHOD_2 ( STRING_1 ) <END> . METHOD_3 ( TYPE_1 . TYPE_4 . VAR_3 ) . METHOD_4 ( TYPE_1 . TYPE_3 . VAR_5 ) . METHOD_5 ( new Date ( ) ) . METHOD_6 ( STRING_2 ) ; VAR_6 = new TYPE_1 ( VAR_1 ) . METHOD_2 ( STRING_3 ) . METHO...
public void METHOD_1 ( ) throws Exception { super . METHOD_1 ( ) ; context = TYPE_2 . METHOD_7 ( ) ; }
UI
protected void METHOD_1 ( String result ) { a . VAR_1 ( false ) ; if ( result != null && result . length ( ) > 0 ) { TYPE_1 . METHOD_2 ( a , result , TYPE_1 . VAR_2 ) . METHOD_3 ( ) ; } if ( VAR_3 == VAR_4 || VAR_3 == VAR_5 || VAR_3 == VAR_6 ) { a . VAR_7 ( ) ; } else { a . VAR_8 ( ) ; } <START> METHOD_4 ( ) . METHOD_5...
protected void METHOD_1 ( String result ) { a . VAR_1 ( false ) ; if ( result != null && result . length ( ) > 0 ) { TYPE_1 . METHOD_2 ( a , result , TYPE_1 . VAR_2 ) . METHOD_3 ( ) ; } if ( VAR_3 == VAR_4 || VAR_3 == VAR_5 || VAR_3 == VAR_6 ) { a . VAR_7 ( ) ; } else { a . VAR_8 ( ) ; } }
bad code remove - catch
public void METHOD_1 ( TYPE_1 item ) { try { String id = item . getId ( ) ; if ( id != null ) { item . VAR_1 ( METHOD_2 ( id ) ) ; item . VAR_2 ( METHOD_3 ( id , item . VAR_3 ( ) ) ) ; } VAR_4 . add ( item . VAR_5 ( ) , item ) ; <START> } catch ( TYPE_2 ex ) { <END> VAR_4 . add ( item ) ; } METHOD_4 ( ) ; }
public void METHOD_1 ( TYPE_1 item ) { String id = item . getId ( ) ; if ( id != null ) { item . VAR_1 ( METHOD_2 ( id ) ) ; item . VAR_2 ( METHOD_3 ( id , item . VAR_3 ( ) ) ) ; } VAR_4 . add ( item ) ; METHOD_4 ( ) ; }
wrong code ( id ! = null && ( id startsWith ( VAR_1 ) )
public List < TYPE_1 > METHOD_1 ( ) { String VAR_1 = METHOD_2 ( ) ; List < TYPE_1 > VAR_2 = new ArrayList < > ( ) ; for ( TYPE_1 item : this . VAR_2 ) { String id = item . getId ( ) ; <START> if ( id != null && ( id . startsWith ( VAR_1 ) && ! TYPE_2 . equals ( id ) || id . startsWith ( VAR_3 ) ) ) { <END> VAR_2 . add ...
public List < TYPE_1 > METHOD_1 ( ) { String VAR_1 = METHOD_2 ( ) ; List < TYPE_1 > VAR_2 = new ArrayList < > ( ) ; for ( TYPE_1 item : this . VAR_2 ) { String id = item . getId ( ) ; if ( id != null && ( id . startsWith ( VAR_1 ) ) ) { VAR_2 . add ( item ) ; } } return VAR_2 ; }
clear VAR_3
private List < String > METHOD_1 ( TYPE_1 VAR_1 , ANNOTATION_1 String VAR_2 ) { List < String > list = new ArrayList < > ( ) ; if ( VAR_1 != null ) { for ( int i = 0 ; i < VAR_1 . length ( ) ; i ++ ) { String id = VAR_1 . METHOD_2 ( i ) ; <START> if ( id . startsWith ( VAR_3 ) ) { <END> list . add ( id ) ; } else { lis...
protected List < String > METHOD_1 ( TYPE_1 VAR_1 , ANNOTATION_1 String VAR_2 ) { List < String > list = new ArrayList < > ( ) ; if ( VAR_1 != null ) { for ( int i = 0 ; i < VAR_1 . length ( ) ; i ++ ) { String id = VAR_1 . METHOD_2 ( i ) ; list . add ( VAR_2 + id ) ; } } return list ; }
VAR_13
public TYPE_1 METHOD_1 ( ) { return new TYPE_1 ( VAR_1 , VAR_2 , VAR_3 , VAR_4 , VAR_5 , VAR_6 , VAR_7 , VAR_8 , VAR_9 , VAR_10 , VAR_11 , VAR_12 , <START> VAR_13 , VAR_14 , VAR_15 , VAR_16 , VAR_17 , VAR_18 , VAR_19 , <END> VAR_20 , VAR_21 , VAR_22 , VAR_23 , VAR_24 ) ; }
public TYPE_1 METHOD_1 ( ) { return new TYPE_1 ( VAR_1 , VAR_2 , VAR_3 , VAR_4 , VAR_5 , VAR_6 , VAR_7 , VAR_8 , VAR_9 , VAR_10 , VAR_11 , VAR_12 , VAR_14 , VAR_15 , VAR_16 , VAR_17 , VAR_18 , VAR_19 , VAR_20 , VAR_21 , VAR_22 , VAR_23 , VAR_24 ) ; }
ArrayList - > List
protected List < TYPE_1 > METHOD_1 ( ) { <START> ArrayList < TYPE_1 > VAR_1 = new ArrayList < > ( ) ; <END> VAR_1 . add ( TYPE_2 . VAR_3 ) ; VAR_1 . add ( TYPE_4 . VAR_3 ) ; VAR_1 . add ( TYPE_3 . VAR_3 ) ; return VAR_1 ; }
protected List < TYPE_1 > METHOD_1 ( ) { List < TYPE_1 > VAR_1 = new ArrayList < > ( ) ; VAR_1 . add ( TYPE_2 . VAR_3 ) ; VAR_1 . add ( TYPE_4 . VAR_3 ) ; VAR_1 . add ( TYPE_3 . VAR_3 ) ; return VAR_1 ; }
1 0 system time
public boolean METHOD_1 ( ) { <START> return VAR_1 . VAR_2 != 0 ; <END> }
public boolean METHOD_1 ( ) { return VAR_1 . VAR_2 != - 1 ; }
return VAR_3 ;
private TYPE_1 METHOD_1 ( TYPE_3 . TYPE_4 VAR_1 ) { TYPE_1 VAR_2 = null ; for ( TYPE_1 VAR_3 : VAR_4 ) { if ( VAR_3 instanceof TYPE_3 ) { if ( ( ( TYPE_3 ) VAR_3 ) . getType ( ) == VAR_1 ) { <START> VAR_2 = VAR_3 ; <END> } } } return VAR_2 ; }
private TYPE_1 METHOD_1 ( TYPE_3 . TYPE_4 VAR_1 ) { for ( TYPE_1 VAR_3 : VAR_4 ) { if ( ( ( TYPE_3 ) VAR_3 ) . getType ( ) == VAR_1 ) { return VAR_3 ; } } return null ; }
VAR_1 ? ? run lookup VAR_1 app _CODE_ ( ) METHOD_1 ( ) ;
public void METHOD_1 ( ) { <START> TYPE_1 VAR_1 = ctx . VAR_2 ( ) ; <END> METHOD_2 ( ) ; METHOD_3 ( ) ; for ( TYPE_2 VAR_3 : VAR_4 ) { METHOD_4 ( VAR_3 ) ; } VAR_1 . METHOD_5 ( ) ; VAR_1 . METHOD_6 ( ) ; VAR_1 . METHOD_7 ( ) ; METHOD_8 ( ) ; }
public void METHOD_1 ( ) { METHOD_2 ( ) ; METHOD_3 ( ) ; for ( TYPE_2 VAR_3 : VAR_4 ) { METHOD_4 ( VAR_3 ) ; } METHOD_8 ( ) ; }