Datasets:
YabTad
/
CodeRev

Dataset card Data Studio Files
xet
 Community
ReviewComments
stringlengths
1
2.35k
OriginalCode
stringlengths
28
487
ReviewedCode
stringlengths
14
463
A test checks VAR_3 invocked appreciated please
private void METHOD_1 ( ) { if ( context . VAR_1 ( ) . METHOD_2 ( ) != null ) { final String VAR_2 = context . VAR_1 ( ) . METHOD_2 ( ) ; <START> VAR_3 . METHOD_3 ( Constants . VAR_4 . METHOD_4 ( VAR_2 ) , <END> VAR_5 . METHOD_5 ( ) , VAR_2 , TYPE_1 . VAR_7 , ( ) - > METHOD_6 ( ) , ( ) - > { } ) ; } else { METHOD_6 ( )...
public void METHOD_1 ( ) { if ( context . VAR_1 ( ) . METHOD_2 ( ) != null ) { final String VAR_2 = context . VAR_1 ( ) . METHOD_2 ( ) ; VAR_3 . METHOD_3 ( Constants . VAR_4 . METHOD_4 ( VAR_2 ) , VAR_5 . METHOD_5 ( ) , VAR_2 , TYPE_1 . VAR_7 , ( ) - > METHOD_6 ( ) , ( ) - > { } ) ; } else { METHOD_6 ( ) ; } }
s avoid raw types please
<START> public Map METHOD_1 ( ) { <END> return map ; }
public Map < String , Object > METHOD_1 ( ) { return map ; }
statements erased parse returns true WDYT
public TYPE_1 METHOD_1 ( ) { if ( METHOD_2 ( ) . size ( ) < 1 ) { <START> if ( ! parse ( METHOD_3 ( ) ) ) { <END> return new TYPE_1 ( 0 , 0 , 0 , 0 ) ; } } return METHOD_2 ( ) . METHOD_1 ( ) ; }
public TYPE_1 METHOD_1 ( ) { if ( METHOD_2 ( ) . size ( ) < 1 ) { return new TYPE_1 ( 0 , 0 , 0 , 0 ) ; } return METHOD_2 ( ) . METHOD_1 ( ) ; }
VAR_1 type TYPE_2 map strings missed VAR_1 ( )
public static TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { <START> TYPE_1 VAR_2 = VAR_3 . get ( VAR_1 ) ; <END> if ( VAR_2 == null ) { VAR_2 = METHOD_2 ( VAR_1 ) ; } return VAR_2 ; }
public static TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { TYPE_1 VAR_2 = VAR_3 . get ( VAR_1 . name ( ) ) ; if ( VAR_2 == null ) { VAR_2 = METHOD_2 ( VAR_1 ) ; } return VAR_2 ; }
chianelli s a problem I m forgetting change reason splitting lines code
public void METHOD_1 ( TYPE_1 context ) { VAR_1 . clear ( ) ; VAR_2 . clear ( ) ; if ( context != null ) { <START> TYPE_2 VAR_3 = VAR_1 . METHOD_2 ( context ) ; <END> VAR_2 . add ( VAR_3 ) ; } }
public void METHOD_1 ( TYPE_1 context ) { VAR_1 . clear ( ) ; VAR_2 . clear ( ) ; if ( context != null ) { VAR_2 . add ( VAR_1 . METHOD_2 ( context ) ) ; } }
I a problem error - user doesn t expected type ( added other task )
public void METHOD_1 ( String VAR_1 , String type ) { if ( VAR_2 . containsKey ( VAR_1 ) ) { String VAR_3 = VAR_2 . get ( VAR_1 ) ; if ( ! VAR_3 . equals ( type ) ) { VAR_4 = false ; <START> VAR_5 . add ( STRING_1 + VAR_1 + STRING_2 + VAR_3 + STRING_3 + type + STRING_4 ) ; <END> } } else { VAR_2 . put ( VAR_1 , type ) ...
public void METHOD_1 ( String VAR_1 , String type ) { METHOD_1 ( Optional . empty ( ) , VAR_1 , type ) ; }
package private intentionally ? method test
<START> void METHOD_1 ( ANNOTATION_1 TYPE_1 event ) { <END> METHOD_2 ( STRING_1 , event ) ; final String VAR_1 = event . VAR_2 ( ) ; if ( METHOD_3 ( event ) && METHOD_4 ( VAR_1 ) ) { final TYPE_2 < ? > VAR_3 = METHOD_5 ( VAR_1 ) ; if ( ! VAR_3 . METHOD_6 ( ) ) { METHOD_7 ( VAR_3 ) ; } else { METHOD_8 ( VAR_3 ) ; } } }
private void METHOD_1 ( ANNOTATION_1 TYPE_1 event ) { METHOD_2 ( STRING_1 , event ) ; final String VAR_1 = event . VAR_2 ( ) ; if ( METHOD_3 ( event ) && METHOD_4 ( VAR_1 ) ) { final TYPE_2 < ? > VAR_3 = METHOD_5 ( VAR_1 ) ; if ( ! VAR_3 . METHOD_6 ( ) ) { METHOD_7 ( VAR_3 ) ; } else { METHOD_8 ( VAR_3 ) ; } } }
I line VAR_1 getId ( ) ; code line 112 useless
<START> public String METHOD_1 ( ) { <END> TYPE_1 VAR_1 = VAR_2 . METHOD_2 ( ) ; return VAR_2 . METHOD_2 ( ) . getId ( ) ; }
public String METHOD_1 ( ) { return VAR_2 . METHOD_2 ( ) . getId ( ) ; }
floating semicolon
private void METHOD_1 ( ) { <START> ; <END> this . VAR_1 = new TYPE_1 ( factory , VAR_2 , VAR_3 , VAR_4 , VAR_5 ) ; }
private void METHOD_1 ( ) { this . VAR_1 = new TYPE_1 ( factory , VAR_2 , VAR_3 , VAR_4 , VAR_5 ) ; }
case sense
public TYPE_1 METHOD_1 ( ) { TYPE_2 result = new TYPE_2 ( ) ; <START> result . VAR_1 ( String . VAR_2 . getName ( ) ) ; <END> return result ; }
public TYPE_1 METHOD_1 ( ) { return new TYPE_2 ( ) ; }
I don t internals case STRING_1 returned reached i18n appreciable other case
public String METHOD_1 ( ) { final String description = VAR_1 . METHOD_2 ( TYPE_2 . TYPE_1 ) ; <START> return description != null && ! description . isEmpty ( ) ? description : STRING_1 ; <END> }
public String METHOD_1 ( ) { return VAR_1 . METHOD_2 ( TYPE_2 . TYPE_1 ) ; }
_CODE_ ( java lang Object ) method
private void METHOD_1 ( List < TYPE_1 > VAR_1 ) { <START> assertTrue ( VAR_2 . getProperty ( STRING_1 ) != null ) ; <END> int VAR_3 = VAR_4 . METHOD_2 ( VAR_5 . METHOD_3 ( ) , path ) . size ( ) - 1 ; assertEquals ( STRING_2 , VAR_3 , VAR_1 . size ( ) ) ; }
private void METHOD_1 ( List < TYPE_1 > VAR_1 ) { assertNotNull ( VAR_2 . getProperty ( STRING_1 ) ) ; int VAR_3 = VAR_4 . METHOD_2 ( VAR_5 . METHOD_3 ( ) , path ) . size ( ) - 1 ; assertEquals ( STRING_2 , VAR_3 , VAR_1 . size ( ) ) ; }
consider Optional
public TYPE_1 METHOD_1 ( final TYPE_2 < ? extends TYPE_3 > VAR_1 ) { VAR_1 . forEach ( v - > { final String VAR_2 = v . VAR_3 ( ) ; <START> if ( null != VAR_2 ) { <END> METHOD_2 ( VAR_2 , TYPE_4 . VAR_5 ) ; } } ) ; METHOD_3 ( ) . METHOD_4 ( ) ; return this ; }
public TYPE_1 METHOD_1 ( final TYPE_2 < ? extends TYPE_3 > VAR_1 ) { VAR_1 . forEach ( v - > { final String VAR_2 = v . VAR_3 ( ) ; METHOD_2 ( VAR_2 , TYPE_4 . VAR_5 ) ; } ) ; METHOD_3 ( ) . METHOD_4 ( ) ; return this ; }
heh I m picky occasion Optional required ? execution a command * * * * result a - null result
<START> protected Optional < TYPE_1 < TYPE_2 > > METHOD_1 ( final TYPE_3 element ) { <END> final TYPE_4 < ? > VAR_1 = VAR_2 . METHOD_2 ( ) ; final TYPE_5 < ? > VAR_3 = VAR_1 . METHOD_3 ( element . VAR_4 ( ) ) ; final double x = VAR_3 . METHOD_4 ( ) . METHOD_5 ( ) ; final double y = VAR_3 . METHOD_4 ( ) . METHOD_6 ( ) ;...
private TYPE_1 < TYPE_2 > METHOD_1 ( final TYPE_3 element ) { final TYPE_4 < ? > VAR_1 = VAR_2 . METHOD_2 ( ) ; final TYPE_5 < ? > VAR_3 = VAR_1 . METHOD_3 ( element . VAR_4 ( ) ) ; final double x = VAR_3 . METHOD_4 ( ) . METHOD_5 ( ) ; final double y = VAR_3 . METHOD_4 ( ) . METHOD_6 ( ) ; return METHOD_7 ( element , ...
floating ;
public TYPE_1 build ( ) { final TYPE_1 result = new TYPE_1 ( VAR_1 . getMessage ( ) , VAR_1 . METHOD_1 ( ) ) ; if ( VAR_1 instanceof TYPE_2 ) { final String VAR_2 = ( ( TYPE_2 ) VAR_1 ) . METHOD_2 ( ) ; if ( null != VAR_2 ) { result . VAR_3 ( VAR_2 ) ; <START> ; <END> } } return result ; }
public TYPE_1 build ( ) { final TYPE_1 result = new TYPE_1 ( VAR_1 . getMessage ( ) , VAR_1 . METHOD_1 ( ) ) ; if ( VAR_1 instanceof TYPE_2 ) { final String VAR_2 = ( ( TYPE_2 ) VAR_1 ) . METHOD_2 ( ) ; if ( null != VAR_2 ) { result . VAR_3 ( VAR_2 ) ; } } return result ; }
need FQCN
protected TYPE_1 < TYPE_2 > METHOD_1 ( final TYPE_3 context ) { <START> final org . VAR_1 . VAR_2 . VAR_3 . VAR_4 . VAR_5 . VAR_6 . TYPE_6 VAR_6 = METHOD_2 ( context ) ; <END> final Collection < TYPE_2 > VAR_8 = METHOD_3 ( context , TYPE_7 . TYPE_8 . METHOD_4 ( VAR_6 , METHOD_5 ( ) , TYPE_9 . TYPE_10 . VAR_11 ) ) ; ret...
protected TYPE_1 < TYPE_2 > METHOD_1 ( final TYPE_3 context ) { final TYPE_6 VAR_6 = METHOD_2 ( context ) ; final Collection < TYPE_2 > VAR_8 = METHOD_3 ( context , TYPE_7 . TYPE_8 . METHOD_4 ( VAR_6 , METHOD_5 ( ) , TYPE_9 . TYPE_10 . VAR_11 ) ) ; return new TYPE_5 ( VAR_8 ) . build ( ) ; }
ve Optional class ; Optional nice
<START> private TYPE_1 METHOD_1 ( final TYPE_2 VAR_1 , <END> final TYPE_3 context ) { final TYPE_1 VAR_2 = VAR_3 . METHOD_1 ( VAR_1 . METHOD_2 ( ) ) ; return null != VAR_2 && METHOD_3 ( VAR_2 , VAR_1 , context ) ? VAR_2 : null ; }
private Optional < TYPE_1 > METHOD_1 ( final TYPE_2 VAR_1 , final TYPE_3 context ) { final TYPE_1 VAR_2 = VAR_3 . METHOD_1 ( VAR_1 . METHOD_2 ( ) ) ; return null != VAR_2 && METHOD_3 ( VAR_2 , VAR_1 , context ) ? Optional . of ( VAR_2 ) : Optional . empty ( ) ; }
expect a CCE ? smells a hack fix a problem
public static TYPE_1 METHOD_1 ( final String VAR_1 , final TYPE_1 VAR_2 ) { try { ( ( TYPE_2 ) VAR_2 ) . METHOD_2 ( VAR_1 ) ; <START> } catch ( final TYPE_3 VAR_3 ) { <END> } return VAR_2 ; }
public static TYPE_1 METHOD_1 ( final String VAR_1 , final TYPE_1 VAR_2 ) { if ( VAR_2 instanceof TYPE_2 ) { ( ( TYPE_2 ) VAR_2 ) . METHOD_2 ( VAR_1 ) ; } return VAR_2 ; }
null TYPE_1 ? ( filter list validation nulls )
public < T > Collection < TYPE_1 > METHOD_1 ( final Path path , final T content ) { <START> return ( Collection < TYPE_1 > ) VAR_1 . stream ( ) . filter ( v - > v . VAR_2 ( path ) ) . METHOD_2 ( c - > c . VAR_3 ( path , <END> content ) . stream ( ) . filter ( r - > r != null ) ) . collect ( Collectors . VAR_4 ( ) ) ; }
public < T > Collection < TYPE_1 > METHOD_1 ( final Path path , final T content ) { return ( Collection < TYPE_1 > ) VAR_1 . stream ( ) . filter ( v - > v . VAR_2 ( path ) ) . METHOD_2 ( c - > c . VAR_3 ( path , content ) . stream ( ) ) . collect ( Collectors . VAR_4 ( ) ) ; }
condition covered tests I don t need condition
public void METHOD_1 ( final String VAR_1 , final TYPE_1 element , final TYPE_2 VAR_2 ) { <START> if ( VAR_1 . trim ( ) . length ( ) > 0 ) { <END> VAR_3 . METHOD_1 ( VAR_1 , VAR_2 ) ; METHOD_2 ( element , VAR_2 ) ; } }
public void METHOD_1 ( final String VAR_1 , final TYPE_1 element , final TYPE_2 VAR_2 ) { VAR_3 . METHOD_1 ( VAR_1 , VAR_2 ) ; METHOD_2 ( element , VAR_2 ) ; }
lamda
void METHOD_1 ( ) { <START> VAR_1 . call ( new TYPE_1 < TYPE_2 > ( ) { <END> @Override public void METHOD_2 ( final TYPE_2 VAR_2 ) { METHOD_3 ( VAR_2 ) ; } } ) . METHOD_4 ( METHOD_5 ( ) ) ; }
void METHOD_1 ( ) { VAR_1 . call ( ( TYPE_2 VAR_2 ) - > METHOD_3 ( VAR_2 ) ) . METHOD_4 ( METHOD_5 ( ) ) ; }
method lead _CODE_ : javathis VAR_2 = null ; [ ] VAR_2 METHOD_1 ( ) ;
public void METHOD_1 ( ) { this . VAR_1 = null ; this . VAR_2 = null ; this . VAR_3 = null ; this . VAR_4 . METHOD_1 ( ) ; this . VAR_5 . METHOD_1 ( ) ; this . VAR_6 . METHOD_2 ( null ) ; this . VAR_6 . METHOD_3 ( ) ; this . VAR_7 . METHOD_1 ( ) ; <START> this . VAR_2 . METHOD_1 ( ) ; <END> }
public void METHOD_1 ( ) { this . VAR_4 . METHOD_1 ( ) ; this . VAR_5 . METHOD_1 ( ) ; this . VAR_6 . METHOD_2 ( null ) ; this . VAR_6 . METHOD_3 ( ) ; this . VAR_7 . METHOD_1 ( ) ; this . VAR_2 . METHOD_1 ( ) ; this . VAR_1 = null ; this . VAR_2 = null ; this . VAR_3 = null ; }
nicer terms METHOD_4 METHOD_1 METHOD_4 I d expect METHOD_1
public void METHOD_1 ( ) { METHOD_2 ( ) ; METHOD_3 ( ) ; <START> VAR_1 . METHOD_4 ( ) ; <END> METHOD_5 ( ) . METHOD_1 ( ) ; METHOD_6 ( ) . METHOD_1 ( ) ; VAR_2 = null ; }
public void METHOD_1 ( ) { METHOD_2 ( ) ; METHOD_3 ( ) ; VAR_1 . METHOD_1 ( ) ; METHOD_5 ( ) . METHOD_1 ( ) ; METHOD_6 ( ) . METHOD_1 ( ) ; VAR_2 = null ; }
( optional feel changing ) test _CODE_ ( ) remarkably similar removal duplicated code a shared method single _CODE_ boolean parameter remove duplication
<START> public void METHOD_1 ( ) { <END> METHOD_2 ( true ) . when ( VAR_1 ) . METHOD_3 ( ) ; VAR_2 . METHOD_4 ( ) ; assertTrue ( VAR_2 . METHOD_5 ( ) ) ; METHOD_6 ( VAR_3 ) . METHOD_7 ( TYPE_1 . class ) ; METHOD_6 ( VAR_3 ) . METHOD_8 ( TYPE_1 . class ) ; }
public void METHOD_1 ( ) { METHOD_3 ( true ) ; }
s a missing assert
public void METHOD_1 ( ) throws Exception { final TYPE_1 VAR_1 = new TYPE_1 ( ) ; VAR_2 . METHOD_2 ( new TYPE_2 ( ) , VAR_1 ) ; final HashSet < String > VAR_3 = new HashSet < String > ( ) ; VAR_3 . add ( STRING_1 ) ; VAR_3 . add ( STRING_2 ) ; assertEquals ( 0 , VAR_1 . size ( ) ) ; <START> VAR_2 . METHOD_3 ( VAR_3 ) ;...
public void METHOD_1 ( ) throws Exception { final TYPE_1 VAR_1 = new TYPE_1 ( ) ; VAR_2 . METHOD_2 ( new TYPE_2 ( ) , VAR_1 ) ; final HashSet < String > VAR_3 = new HashSet < String > ( ) ; VAR_3 . add ( STRING_1 ) ; VAR_3 . add ( STRING_2 ) ; assertEquals ( 0 , VAR_1 . size ( ) ) ; VAR_2 . METHOD_3 ( VAR_3 ) ; assertE...
start java8 VAR_1 forEach
public void METHOD_1 ( ) { super . METHOD_2 ( ) ; METHOD_3 ( ) ; METHOD_4 ( ) ; final Collection < TYPE_1 > VAR_1 = METHOD_5 ( ) ; if ( null != VAR_1 && ! VAR_1 . isEmpty ( ) ) { <START> for ( TYPE_1 VAR_2 : VAR_1 ) { <END> METHOD_6 ( ) . METHOD_7 ( VAR_2 ) ; } } }
public void METHOD_1 ( ) { super . METHOD_2 ( ) ; METHOD_3 ( ) ; METHOD_4 ( ) ; final Collection < TYPE_1 > VAR_1 = METHOD_5 ( ) ; if ( null != VAR_1 ) { VAR_1 . forEach ( VAR_2 - > METHOD_6 ( ) . METHOD_7 ( VAR_2 ) ) ; } }
mention lamdas : - )
private TYPE_1 METHOD_1 ( final String text , final TYPE_2 command , final TYPE_3 type ) { <START> TYPE_1 VAR_1 = new TYPE_1 ( text , new TYPE_4 ( ) { <END> @Override public void METHOD_2 ( TYPE_5 event ) { command . execute ( ) ; } } ) ; VAR_1 . METHOD_3 ( type ) ; return VAR_1 ; }
TYPE_1 METHOD_1 ( final String text , final TYPE_2 command , final TYPE_3 type ) { TYPE_1 VAR_1 = new TYPE_1 ( text , event - > command . execute ( ) ) ; VAR_1 . METHOD_3 ( type ) ; return VAR_1 ; }
future move uberfire
void METHOD_1 ( ) { <START> ANNOTATION_1 ( STRING_1 ) <END> final TYPE_1 e = TYPE_2 . get ( STRING_2 ) . METHOD_2 ( ) ; new TYPE_3 ( ) { @Override protected void METHOD_3 ( double VAR_1 ) { e . VAR_2 ( ) . METHOD_4 ( FLOAT_1 - VAR_1 ) ; } @Override protected void METHOD_5 ( ) { e . VAR_2 ( ) . METHOD_6 ( TYPE_4 . TYPE_...
public void METHOD_1 ( ) { ANNOTATION_1 ( STRING_1 ) final TYPE_1 e = TYPE_2 . get ( STRING_2 ) . METHOD_2 ( ) ; new TYPE_3 ( ) { @Override protected void METHOD_3 ( double VAR_1 ) { e . VAR_2 ( ) . METHOD_4 ( FLOAT_1 - VAR_1 ) ; } @Override protected void METHOD_5 ( ) { e . VAR_2 ( ) . METHOD_6 ( TYPE_4 . TYPE_5 . VAR...
I m a lover passing nulls methods constructors another constructor _CODE_
public TYPE_3 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 ) { <START> super ( null , VAR_2 , VAR_3 ) ; <END> }
public TYPE_3 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 ) { super ( VAR_2 , VAR_3 ) ; }
I m a lover passing nulls methods constructors another constructor _CODE_
public TYPE_3 ( String source , TYPE_1 VAR_2 , TYPE_2 VAR_3 ) { <START> super ( null , source , VAR_2 , VAR_3 ) ; <END> }
public TYPE_3 ( String source , TYPE_1 VAR_2 , TYPE_2 VAR_3 ) { super ( source , VAR_2 , VAR_3 ) ; }
_CODE_ safeにした方がよさそうです
public static TYPE_1 getInstance ( ) { <START> if ( VAR_1 == null ) { <END> VAR_1 = new TYPE_1 ( ) ; VAR_1 . METHOD_1 ( VAR_2 , TimeUnit . VAR_3 ) ; VAR_1 . METHOD_2 ( VAR_2 , TimeUnit . VAR_3 ) ; VAR_1 . METHOD_3 ( VAR_2 , TimeUnit . VAR_3 ) ; VAR_1 . METHOD_4 ( ) . add ( new TYPE_2 ( METHOD_5 ( ) ) ) ; } return VAR_1...
public static synchronized TYPE_1 getInstance ( ) { if ( VAR_1 == null ) { VAR_1 = new TYPE_1 ( ) ; VAR_1 . METHOD_1 ( VAR_2 , TimeUnit . VAR_3 ) ; VAR_1 . METHOD_2 ( VAR_2 , TimeUnit . VAR_3 ) ; VAR_1 . METHOD_3 ( VAR_2 , TimeUnit . VAR_3 ) ; VAR_1 . METHOD_4 ( ) . add ( new TYPE_2 ( METHOD_5 ( ) ) ) ; } return VAR_1 ...
called VAR_3 assigned
protected boolean METHOD_1 ( ) { if ( VAR_1 ) { return VAR_2 != null ; } else { <START> return VAR_3 . METHOD_2 ( ) ; <END> } }
protected boolean METHOD_1 ( ) { if ( VAR_1 ) { return VAR_2 != null ; } else { return ( VAR_3 != null && VAR_3 . METHOD_2 ( ) ) ; } }
order previously ? 1 notify ad click 2 launch click target
public void METHOD_1 ( ANNOTATION_1 final View view ) { super . METHOD_1 ( view ) ; VAR_1 . METHOD_2 ( view . VAR_2 ( ) ) ; <START> METHOD_3 ( ) ; <END> }
public void METHOD_1 ( ANNOTATION_1 final View view ) { super . METHOD_1 ( view ) ; METHOD_3 ( ) ; VAR_1 . METHOD_2 ( view . VAR_2 ( ) ) ; }
s issue I s put checks a single line ( ( ! VAR_1 exists ( ) && ! VAR_1 METHOD_2 ( ) ) )
private static void METHOD_1 ( File VAR_1 ) throws IOException { <START> if ( ! VAR_1 . exists ( ) ) { <END> if ( ! VAR_1 . METHOD_2 ( ) ) { throw new IOException ( STRING_1 + VAR_1 ) ; } } }
private static void METHOD_1 ( File VAR_1 ) throws IOException { if ( ! VAR_1 . exists ( ) && ! VAR_1 . METHOD_2 ( ) ) { throw new IOException ( STRING_1 + VAR_1 ) ; } }
I log messages related extensions part METHOD_1
private boolean METHOD_1 ( String VAR_1 ) { if ( VAR_1 != null ) { TYPE_1 VAR_2 = VAR_3 . METHOD_2 ( VAR_1 ) ; if ( TYPE_2 . VAR_5 != VAR_2 . METHOD_3 ( ) ) { return true ; } <START> log . trace ( STRING_1 , VAR_1 ) ; <END> } else { log . trace ( STRING_2 ) ; } return false ; }
private boolean METHOD_1 ( String VAR_1 ) { if ( VAR_1 != null ) { TYPE_1 VAR_2 = VAR_3 . METHOD_2 ( VAR_1 ) ; return TYPE_2 . VAR_5 != VAR_2 . METHOD_3 ( ) ; } return false ; }
a mechanic extraction s enough pass VAR_1
public void METHOD_1 ( ) { for ( TYPE_1 VAR_1 : VAR_2 ) { TYPE_2 VAR_3 = VAR_1 . METHOD_2 ( ) ; if ( ( TYPE_2 . VAR_4 != VAR_3 ) && ( TYPE_2 . VAR_5 != VAR_3 ) ) { <START> METHOD_3 ( VAR_1 , VAR_1 . METHOD_4 ( ) , VAR_3 ) ; <END> } } }
public void METHOD_1 ( ) { for ( TYPE_1 VAR_1 : VAR_2 ) { TYPE_2 VAR_3 = VAR_1 . METHOD_2 ( ) ; if ( ( TYPE_2 . VAR_4 != VAR_3 ) && ( TYPE_2 . VAR_5 != VAR_3 ) ) { METHOD_3 ( VAR_1 ) ; } } }
need change I feel s refactoring action
public void METHOD_1 ( ) { <START> TYPE_1 VAR_1 = METHOD_2 ( TYPE_2 . class ) ; <END> when ( VAR_1 . METHOD_3 ( ) ) . METHOD_4 ( STRING_1 ) ; TYPE_3 VAR_2 = METHOD_2 ( TYPE_3 . class ) ; when ( VAR_2 . METHOD_5 ( ) ) . METHOD_4 ( VAR_1 ) ; when ( VAR_2 . METHOD_6 ( ) ) . METHOD_4 ( getClass ( ) . METHOD_7 ( ) ) ; TYPE_...
public void METHOD_1 ( ) { TYPE_1 VAR_1 = METHOD_2 ( TYPE_1 . class ) ; when ( VAR_1 . METHOD_3 ( ) ) . METHOD_4 ( STRING_1 ) ; TYPE_3 VAR_2 = METHOD_2 ( TYPE_3 . class ) ; when ( VAR_2 . METHOD_5 ( ) ) . METHOD_4 ( VAR_1 ) ; when ( VAR_2 . METHOD_6 ( ) ) . METHOD_4 ( getClass ( ) . METHOD_7 ( ) ) ; TYPE_4 instance = n...
simpler wrap lines : ( VAR_1 > 0 ) { }
public void METHOD_1 ( long VAR_1 ) { <START> VAR_2 += VAR_1 ; <END> VAR_3 += ( VAR_1 == 0 ? 0 : VAR_1 * Math . log ( VAR_1 ) ) ; }
public void METHOD_1 ( long VAR_1 ) { if ( VAR_1 > 0 ) { VAR_2 += VAR_1 ; VAR_3 += VAR_1 * Math . log ( VAR_1 ) ; } }
VAR_1 null
public void METHOD_1 ( ) { <START> if ( this . VAR_1 != null ) { <END> this . VAR_1 . METHOD_2 ( ) ; } }
public void METHOD_1 ( ) { this . VAR_1 . METHOD_2 ( ) ; }
I : javaif ( input = = null || input size ( ) = = 0 ) return null ;
public Object METHOD_1 ( TYPE_1 input ) throws IOException { <START> if ( input . size ( ) == 0 ) <END> { throw new RuntimeException ( STRING_1 ) ; } for ( Object o : input ) { if ( o != null ) { return o ; } } return null ; }
public Object METHOD_1 ( TYPE_1 input ) throws IOException { if ( input == null || input . size ( ) == 0 ) { return null ; } for ( Object o : input ) { if ( o != null ) { return o ; } } return null ; }
test empty filename I expecting METHOD_2 ( )
public void METHOD_1 ( ) { TYPE_1 VAR_1 = new TYPE_1 ( VAR_2 , VAR_3 ) ; <START> TYPE_2 file = VAR_1 . METHOD_2 ( null ) ; <END> METHOD_3 ( file ) ; }
public void METHOD_1 ( ) { TYPE_1 VAR_1 = new TYPE_1 ( VAR_2 , VAR_3 ) ; TYPE_2 file = VAR_1 . METHOD_2 ( "" ) ; METHOD_3 ( file ) ; }
I wondering sense include loop insteadi e ( TYPE_2 equals ( ) ) { } other issue want version included VAR_4 property a tag
public void METHOD_1 ( TYPE_1 VAR_1 ) { VAR_1 . METHOD_2 ( TYPE_4 . VAR_3 + STRING_1 ) ; <START> String VAR_4 = VAR_5 . get ( TYPE_2 ) ; <END> if ( ! TYPE_3 . isEmpty ( VAR_4 ) ) { VAR_1 . METHOD_3 ( VAR_4 ) ; } for ( String key : VAR_5 . keySet ( ) ) { VAR_1 . METHOD_4 ( key , VAR_5 . get ( key ) ) ; } }
public void METHOD_1 ( TYPE_1 VAR_1 ) { VAR_1 . METHOD_2 ( TYPE_4 . VAR_3 + STRING_1 ) ; for ( String key : VAR_5 . keySet ( ) ) { String value = VAR_5 . get ( key ) ; if ( TYPE_2 . equals ( key ) ) { VAR_1 . METHOD_3 ( value ) ; } VAR_1 . METHOD_4 ( key , value ) ; } }
I guess reached
private boolean METHOD_1 ( ANNOTATION_1 Integer VAR_1 ) { return VAR_1 != null && ( VAR_1 == Constants . VAR_2 || VAR_1 == Constants . VAR_3 || VAR_1 == Constants . VAR_4 || VAR_1 == Constants . VAR_5 ) ; <START> return false ; <END> }
private boolean METHOD_1 ( ANNOTATION_1 Integer VAR_1 ) { return VAR_1 != null && ( VAR_1 == Constants . VAR_2 || VAR_1 == Constants . VAR_3 || VAR_1 == Constants . VAR_4 || VAR_1 == Constants . VAR_5 ) ; }
ha ! a new construct I thought id a private field
public boolean equals ( Object o ) { if ( this == o ) { return true ; } if ( o == null || getClass ( ) != o . getClass ( ) ) { return false ; } TYPE_1 that = ( TYPE_1 ) o ; <START> return id . equals ( that . id ) ; <END> }
public boolean equals ( Object o ) { if ( this == o ) { return true ; } if ( o == null || getClass ( ) != o . getClass ( ) ) { return false ; } TYPE_1 that = ( TYPE_1 ) o ; return id . equals ( that . getId ( ) ) ; }
a good practice leave brackets line else adds another line produce a bug
public TYPE_2 . TYPE_3 METHOD_1 ( ) throws IOException { <START> if ( input != null ) <END> throw new RuntimeException ( STRING_1 ) ; if ( VAR_1 ) throw new RuntimeException ( STRING_2 ) ; connection . VAR_2 ( true ) ; input = new TYPE_2 . TYPE_3 ( ) ; return input ; }
public TYPE_2 . TYPE_3 METHOD_1 ( ) throws IOException { if ( input != null ) { throw new RuntimeException ( STRING_1 ) ; } if ( VAR_1 ) { throw new RuntimeException ( STRING_2 ) ; } connection . VAR_2 ( true ) ; input = new TYPE_2 . TYPE_3 ( ) ; return input ; }
missing brackets
public TYPE_2 . TYPE_3 METHOD_1 ( ) throws IOException { <START> if ( output != null ) <END> throw new RuntimeException ( STRING_1 ) ; if ( VAR_1 ) throw new RuntimeException ( STRING_2 ) ; connection . VAR_2 ( true ) ; output = new TYPE_2 . TYPE_3 ( ) ; return output ; }
public TYPE_2 . TYPE_3 METHOD_1 ( ) throws IOException { if ( output != null ) { throw new RuntimeException ( STRING_1 ) ; } if ( VAR_1 ) { throw new RuntimeException ( STRING_2 ) ; } connection . VAR_2 ( true ) ; output = new TYPE_2 . TYPE_3 ( ) ; return output ; }
missing brackets
public TYPE_3 . TYPE_4 METHOD_1 ( ) throws IOException { if ( VAR_1 ) <START> throw new RuntimeException ( STRING_1 ) ; <END> return new TYPE_3 . TYPE_4 ( new TYPE_3 . TYPE_5 ( ) , this ) ; }
public TYPE_3 . TYPE_4 METHOD_1 ( ) throws IOException { if ( VAR_1 ) { throw new RuntimeException ( STRING_1 ) ; } return new TYPE_3 . TYPE_4 ( new TYPE_3 . TYPE_5 ( ) , this ) ; }
method left blank—will called a block - scoped step returning start _CODE_ start
public void METHOD_1 ( Throwable VAR_1 ) throws Exception { <START> if ( VAR_2 != null ) <END> VAR_2 . METHOD_2 ( VAR_1 ) ; TYPE_1 < ? , ? > r = METHOD_3 ( ) . get ( TYPE_1 . class ) ; TYPE_2 listener = METHOD_3 ( ) . get ( TYPE_2 . class ) ; TYPE_5 . TYPE_6 VAR_3 = TYPE_4 . METHOD_4 ( ) . METHOD_5 ( TYPE_5 . TYPE_6 . ...
public void METHOD_1 ( Throwable VAR_1 ) throws Exception { }
boolean
<START> private Boolean METHOD_1 ( TYPE_1 VAR_1 , TYPE_1 VAR_2 ) { <END> for ( String VAR_3 : VAR_1 . METHOD_2 ( ) ) { if ( VAR_2 . METHOD_2 ( ) . contains ( VAR_3 ) ) { return true ; } } return false ; }
private boolean METHOD_1 ( TYPE_1 VAR_1 , TYPE_1 VAR_2 ) { if ( VAR_1 != null && VAR_2 != null ) { for ( String VAR_3 : VAR_1 . METHOD_2 ( ) ) { if ( VAR_2 . METHOD_2 ( ) . contains ( VAR_3 ) ) { return true ; } } } return false ; }
BTW class cast TYPE_3 required
private TYPE_1 METHOD_1 ( TYPE_2 task ) { if ( task instanceof TYPE_3 ) { TYPE_3 < ? , ? > p = ( TYPE_3 < ? , ? > ) task ; if ( task instanceof TYPE_4 ) { <START> p = ( TYPE_3 < ? , ? > ) ( ( TYPE_4 ) task ) . METHOD_2 ( ) ; <END> } TYPE_1 VAR_1 = p . getProperty ( TYPE_1 . class ) ; return VAR_1 ; } return null ; }
private TYPE_1 METHOD_1 ( TYPE_2 task ) { if ( task instanceof TYPE_3 ) { TYPE_3 < ? , ? > p = ( TYPE_3 < ? , ? > ) task ; if ( task instanceof TYPE_4 ) { p = ( ( TYPE_4 ) task ) . METHOD_2 ( ) ; } TYPE_1 VAR_1 = p . getProperty ( TYPE_1 . class ) ; return VAR_1 ; } return null ; }
please save previous constructor change affects binary compatibility previous versions
<START> public TYPE_2 ( String VAR_2 , <END> Integer VAR_3 , Integer VAR_4 , String VAR_5 , List < TYPE_1 > VAR_6 ) { this . VAR_3 = VAR_3 == null ? 0 : VAR_3 ; this . VAR_4 = VAR_4 == null ? 0 : VAR_4 ; this . VAR_2 = VAR_2 ; this . VAR_5 = VAR_5 ; this . VAR_6 = VAR_6 == null ? new ArrayList < TYPE_1 > ( ) : VAR_6 ; ...
public TYPE_2 ( String VAR_2 , Integer VAR_3 , Integer VAR_4 , String VAR_5 , List < TYPE_1 > VAR_6 ) { this ( VAR_2 , VAR_3 , VAR_4 , VAR_6 ) ; this . VAR_5 = VAR_5 ; METHOD_1 ( VAR_5 ) ; }
I don t needs changed ? shouldn t need add null / isEmpty checks TYPE_4 METHOD_6
public void METHOD_1 ( TYPE_1 location , String VAR_1 , String VAR_2 ) { TYPE_2 . METHOD_2 ( METHOD_3 ( ) , TYPE_3 . METHOD_4 ( location ) ) . METHOD_5 ( VAR_3 - > { if ( VAR_3 ) { if ( VAR_1 != null && ! VAR_1 . isEmpty ( ) ) { TYPE_4 . METHOD_6 ( this , VAR_1 ) ; } } else { if ( VAR_2 != null && ! VAR_2 . isEmpty ( )...
public void METHOD_1 ( TYPE_1 location , String VAR_1 , String VAR_2 ) { TYPE_2 . METHOD_2 ( METHOD_3 ( ) , TYPE_3 . METHOD_4 ( location ) ) . METHOD_5 ( VAR_3 - > { if ( VAR_3 ) { if ( ! VAR_1 . isEmpty ( ) ) { TYPE_4 . METHOD_6 ( this , VAR_1 ) ; } } else { METHOD_7 ( VAR_2 ) ; } return VAR_3 ; } ) ; }
extract variable
public boolean METHOD_1 ( ) { <START> if ( VAR_1 . getValue ( ) == null || VAR_1 . getValue ( ) instanceof TYPE_1 ) { <END> return false ; } return super . METHOD_1 ( ) ; }
public boolean METHOD_1 ( ) { final Object data = VAR_1 . getValue ( ) ; if ( data == null || data instanceof TYPE_1 ) { return false ; } return super . METHOD_1 ( ) ; }
< > ( VAR_1 isEmpty ( ) ) return false ;
public boolean METHOD_1 ( ) { if ( VAR_1 . isEmpty ( ) && VAR_2 . METHOD_2 ( ) ) { return false ; } if ( VAR_3 . isEmpty ( ) && ! VAR_2 . METHOD_2 ( ) ) { return false ; <START> } <END> if ( VAR_4 . getValue ( ) instanceof TYPE_1 ) { return METHOD_3 ( ) ? false : super . METHOD_1 ( ) ; } if ( VAR_4 . getValue ( ) insta...
public boolean METHOD_1 ( ) { if ( VAR_1 . isEmpty ( ) && METHOD_2 ( ) || VAR_3 . isEmpty ( ) && ! METHOD_2 ( ) ) { return false ; } if ( VAR_4 . getValue ( ) instanceof TYPE_1 ) { return METHOD_3 ( ) ? false : super . METHOD_1 ( ) ; } if ( VAR_4 . getValue ( ) instanceof TYPE_2 ) { return super . METHOD_1 ( ) ; } retu...
page variable
public void METHOD_1 ( ) { super . METHOD_1 ( ) ; final TYPE_1 VAR_1 = METHOD_2 ( TYPE_3 . VAR_3 ) ; if ( METHOD_3 ( ) instanceof TYPE_2 ) { <START> final TYPE_2 page = ( TYPE_2 ) METHOD_3 ( ) ; <END> VAR_1 . setText ( Messages . VAR_4 ) ; } else { VAR_1 . setText ( TYPE_3 . VAR_5 ) ; } }
public void METHOD_1 ( ) { super . METHOD_1 ( ) ; final TYPE_1 VAR_1 = METHOD_2 ( TYPE_3 . VAR_3 ) ; if ( METHOD_3 ( ) instanceof TYPE_2 ) { VAR_1 . setText ( Messages . VAR_4 ) ; } else { VAR_1 . setText ( TYPE_3 . VAR_5 ) ; } }
some side effects connectors ( sources compile )
private TYPE_1 METHOD_1 ( final TYPE_2 [ ] VAR_1 ) { final TYPE_1 VAR_2 = METHOD_2 ( ) ; VAR_2 . METHOD_3 ( Path . VAR_3 ( VAR_4 . METHOD_4 ( ) ) ) ; VAR_2 . METHOD_5 ( VAR_1 ) ; VAR_2 . METHOD_6 ( true ) ; VAR_2 . METHOD_7 ( VAR_5 ) ; VAR_2 . METHOD_8 ( true ) ; <START> VAR_2 . METHOD_9 ( false ) ; <END> return VAR_2 ...
private TYPE_1 METHOD_1 ( final TYPE_2 [ ] VAR_1 ) { final TYPE_1 VAR_2 = METHOD_2 ( ) ; VAR_2 . METHOD_3 ( Path . VAR_3 ( VAR_4 . METHOD_4 ( ) ) ) ; VAR_2 . METHOD_5 ( VAR_1 ) ; VAR_2 . METHOD_6 ( true ) ; VAR_2 . METHOD_7 ( VAR_5 ) ; VAR_2 . METHOD_8 ( true ) ; return VAR_2 ; }
Boolean valueOf avoid object instanciation
public String METHOD_1 ( final Object element ) { if ( element instanceof TYPE_1 ) { final TYPE_1 VAR_1 = ( TYPE_1 ) element ; <START> return new Boolean ( ! VAR_1 . METHOD_2 ( ) . METHOD_3 ( ) ) . toString ( ) ; <END> } return super . METHOD_1 ( element ) ; }
public String METHOD_1 ( final Object element ) { if ( element instanceof TYPE_1 ) { final TYPE_1 VAR_1 = ( TYPE_1 ) element ; return Boolean . valueOf ( ! VAR_1 . METHOD_2 ( ) . METHOD_3 ( ) ) . toString ( ) ; } return super . METHOD_1 ( element ) ; }
return VAR_2 ! = null && ( VAR_2 ( STRING_2 ) || VAR_2 ( STRING_3 ) ) ;
protected boolean METHOD_1 ( final TYPE_1 VAR_1 ) { final String VAR_2 = VAR_1 . get ( STRING_1 ) ; <START> final boolean VAR_3 = VAR_2 != null <END> && ( VAR_2 . contains ( STRING_2 ) || VAR_2 . contains ( STRING_3 ) ) ; return VAR_3 ; }
protected boolean METHOD_1 ( final TYPE_1 VAR_1 ) { final String VAR_2 = VAR_1 . get ( STRING_1 ) ; return VAR_2 != null && ( VAR_2 . contains ( STRING_2 ) || VAR_2 . contains ( STRING_3 ) ) ; }
shouldn t synchronized ? ( _CODE_ )
<START> private static TYPE_1 METHOD_1 ( ) { <END> if ( VAR_1 == null ) { VAR_1 = TYPE_2 . create ( STRING_1 ) ; } return VAR_1 ; }
private static synchronized TYPE_1 METHOD_1 ( ) { if ( VAR_1 == null ) { VAR_1 = TYPE_2 . create ( STRING_1 ) ; } return VAR_1 ; }
2 columns
public TYPE_1 METHOD_1 ( final TYPE_2 data ) { <START> VAR_1 . METHOD_1 ( data ) ; ; <END> return this ; }
public TYPE_1 METHOD_1 ( final TYPE_2 data ) { VAR_1 . METHOD_1 ( data ) ; return this ; }
I button enabled form defined - > new _CODE_ form defined - > open form
public void update ( ) { if ( VAR_1 != null ) { <START> VAR_1 . METHOD_1 ( METHOD_2 ( ) || METHOD_3 ( ) ) ; <END> final TYPE_1 VAR_2 = METHOD_4 ( VAR_3 . METHOD_5 ( ) ) ; if ( VAR_2 != null ) { if ( VAR_2 instanceof TYPE_2 ) { VAR_1 . METHOD_6 ( TYPE_3 . bind ( Messages . VAR_4 , Messages . VAR_5 ) ) ; } else { VAR_1 ....
public void update ( ) { if ( VAR_1 != null ) { VAR_1 . METHOD_1 ( true ) ; final TYPE_1 VAR_2 = METHOD_4 ( VAR_3 . METHOD_5 ( ) ) ; if ( VAR_2 != null ) { if ( VAR_2 instanceof TYPE_2 ) { VAR_1 . METHOD_6 ( TYPE_3 . bind ( Messages . VAR_4 , Messages . VAR_5 ) ) ; } else { VAR_1 . METHOD_6 ( TYPE_3 . bind ( Messages ....
linebreak place choice
public void METHOD_1 ( ) throws Exception { final TYPE_1 VAR_1 = new TYPE_1 ( METHOD_2 ( ) . METHOD_3 ( STRING_1 ) . METHOD_4 ( STRING_2 ) . build ( ) , new TYPE_2 ( STRING_1 , <START> String . VAR_2 ) , new TYPE_2 ( STRING_2 , <END> String . VAR_2 ) ) ; final TYPE_3 status = VAR_1 . METHOD_5 ( ) ; TYPE_4 . assertThat ...
public void METHOD_1 ( ) throws Exception { final TYPE_1 VAR_1 = new TYPE_1 ( METHOD_2 ( ) . METHOD_3 ( STRING_1 ) . METHOD_4 ( STRING_2 ) . build ( ) , new TYPE_2 ( STRING_1 , String . VAR_2 ) , new TYPE_2 ( STRING_2 , String . VAR_2 ) ) ; final TYPE_3 status = VAR_1 . METHOD_5 ( ) ; assertThat ( status ) . METHOD_6 (...
empty string argument
protected void METHOD_1 ( final TYPE_1 status ) { METHOD_2 ( status ) ; VAR_1 . METHOD_3 ( ) ; if ( ! status . VAR_2 ( ) && METHOD_4 ( ) . METHOD_5 ( ) ) { <START> VAR_1 . METHOD_6 ( "" , status . getMessage ( ) , null , new TYPE_2 ( status ) . METHOD_7 ( ) ) ; <END> } }
protected void METHOD_1 ( final TYPE_1 status ) { METHOD_2 ( status ) ; VAR_1 . METHOD_3 ( ) ; if ( ! status . VAR_2 ( ) && METHOD_4 ( ) . METHOD_5 ( ) ) { VAR_1 . METHOD_6 ( null , status . getMessage ( ) , null , new TYPE_2 ( status ) . METHOD_7 ( ) ) ; } }
return VAR_1 METHOD_2 ( ) instanceof TYPE_2 ;
<START> protected boolean METHOD_1 ( final TYPE_1 VAR_1 ) { <END> if ( VAR_1 . METHOD_2 ( ) instanceof TYPE_2 ) { return true ; } return false ; }
protected boolean METHOD_1 ( final TYPE_1 VAR_1 ) { return VAR_1 . METHOD_2 ( ) instanceof TYPE_2 ; }
left operand useless
public void METHOD_1 ( ) { <START> TYPE_1 VAR_1 = new TYPE_1 ( STRING_1 ) ; <END> }
public void METHOD_1 ( ) { new TYPE_1 ( STRING_1 ) ; }
a clear separation call METHOD_2 ( ) creation a log
public void METHOD_1 ( ) { try { <START> log . info ( STRING_1 + METHOD_2 ( ) ) ; <END> } catch ( IllegalStateException e ) { log . error ( e . getMessage ( ) ) ; } }
public void METHOD_1 ( ) { try { String url = METHOD_2 ( ) ; log . info ( STRING_1 + url ) ; } catch ( IllegalStateException e ) { log . error ( e . getMessage ( ) ) ; } }
doesn t
public void METHOD_1 ( ) { VAR_1 = VAR_2 . getString ( STRING_1 , null ) ; VAR_3 = new TYPE_1 ( VAR_1 , INT_1 , 1 ) ; <START> Integer . parseInt ( VAR_2 . getString ( STRING_2 , STRING_3 ) ) ; <END> }
public void METHOD_1 ( ) { VAR_1 = VAR_2 . getString ( STRING_1 , null ) ; VAR_3 = new TYPE_1 ( VAR_1 , INT_1 , 1 ) ; }
new String ( ) redundant
public void METHOD_1 ( ) { try { <START> String query = new String ( STRING_1 ) ; <END> VAR_1 . METHOD_2 ( query ) ; } catch ( TYPE_1 e ) { log . error ( e . VAR_2 ( ) , e ) ; } catch ( IOException e ) { log . error ( e . VAR_2 ( ) , e ) ; } }
public void METHOD_1 ( ) { try { String query = STRING_1 ; VAR_1 . METHOD_2 ( query ) ; } catch ( TYPE_1 e ) { log . error ( e . VAR_2 ( ) , e ) ; } catch ( IOException e ) { log . error ( e . VAR_2 ( ) , e ) ; } }
I results VAR_2 ( ) a finally block want release connection
public void write ( TYPE_1 out ) { try { TYPE_2 . METHOD_1 ( results . VAR_1 ( ) , out ) ; <START> results . VAR_2 ( ) ; <END> } catch ( IOException e ) { throw new TYPE_3 ( Response . status ( Status . VAR_3 ) . entity ( STRING_1 ) . build ( ) ) ; } }
public void write ( TYPE_1 out ) { try { TYPE_2 . METHOD_1 ( results . VAR_1 ( ) , out ) ; } catch ( IOException e ) { throw new TYPE_3 ( Response . status ( Status . VAR_3 ) . entity ( STRING_1 ) . build ( ) ) ; } finally { results . VAR_2 ( ) ; } }
I loading a TYPE_1 primary key session ( Class serializable ) return item
public TYPE_1 METHOD_1 ( final String id ) { List < Object > results = METHOD_2 ( ) . METHOD_3 ( new TYPE_2 ( ) { public Object METHOD_4 ( TYPE_3 session ) { <START> TYPE_4 query = session . VAR_1 ( <END> STRING_1 + STRING_2 ) . METHOD_5 ( TYPE_1 . class ) ; query . VAR_2 ( STRING_3 , id ) ; return query . list ( ) ; }...
public TYPE_1 METHOD_1 ( final String id ) { return ( TYPE_1 ) METHOD_2 ( ) . execute ( new TYPE_2 ( ) { public TYPE_1 METHOD_4 ( TYPE_3 session ) { return ( TYPE_1 ) session . get ( TYPE_1 . class , id ) ; } } ) ; }
s move bundle stuff METHOD_3 ( ) method : METHOD_3 ( String VAR_8 ) { TYPE_1 args = new TYPE_1 ( ) ; args VAR_6 ( ) } logic contained fragment
public void METHOD_1 ( ) { if ( TYPE_5 . VAR_2 . VAR_3 >= TYPE_5 . VAR_4 . VAR_5 ) { TYPE_1 args = new TYPE_1 ( ) ; args . VAR_6 ( STRING_1 , METHOD_2 ( TYPE_4 . VAR_8 . VAR_9 ) ) ; <START> TYPE_2 VAR_10 = TYPE_2 . METHOD_3 ( ) ; <END> VAR_10 . METHOD_4 ( args ) ; VAR_11 . METHOD_5 ( VAR_10 ) ; } else { TYPE_3 . METHOD...
public void METHOD_1 ( ) { if ( TYPE_5 . VAR_2 . VAR_3 >= TYPE_5 . VAR_4 . VAR_5 ) { VAR_11 . METHOD_5 ( TYPE_2 . METHOD_3 ( this ) ) ; } else { TYPE_3 . METHOD_6 ( this , R . string . VAR_12 , TYPE_3 . VAR_13 ) . METHOD_7 ( ) ; METHOD_8 ( ) ; } }
casting ensure VAR_1 a TYPE_1 defined
protected void METHOD_1 ( ) { Logger . debug ( this , STRING_1 ) ; <START> ( ( TYPE_1 ) VAR_1 ) . METHOD_2 ( METHOD_3 ( ) ) ; <END> }
protected void METHOD_1 ( ) { Logger . debug ( this , STRING_1 ) ; VAR_1 . METHOD_2 ( METHOD_3 ( ) ) ; }
breaks public API _CODE_ case break API returned able represent query parameter content specification I d recommend wit a Map < String Collection < String > > guava stuff internal java standard conform interface outer world
<START> public TYPE_1 < String , String > METHOD_1 ( ) { <END> return VAR_1 ; }
public Map < String , Collection < String > > METHOD_1 ( ) { return VAR_1 ; }
sense overwrite VAR_2 ( i e check list overwrite allowing multiple VAR_2 )
public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { <START> this . VAR_2 . add ( VAR_1 ) ; <END> METHOD_2 ( TYPE_3 . VAR_4 + VAR_1 . getName ( ) , VAR_5 . METHOD_3 ( VAR_1 ) ) ; return this ; }
public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { this . VAR_2 . put ( VAR_1 . getName ( ) , VAR_1 ) ; METHOD_2 ( TYPE_3 . VAR_4 + VAR_1 . getName ( ) , VAR_5 . METHOD_3 ( VAR_1 ) ) ; return this ; }
remove public
<START> public TYPE_2 ( <END> TYPE_1 VAR_2 ) { METHOD_1 ( VAR_2 . METHOD_2 ( this ) ) ; }
TYPE_2 ( TYPE_1 VAR_2 ) { METHOD_1 ( VAR_2 . METHOD_2 ( this ) ) ; }
clean public
<START> public TYPE_6 ( TYPE_1 VAR_2 , TYPE_2 view , TYPE_3 VAR_3 ) { <END> super ( VAR_2 , view , VAR_3 , TYPE_4 . TYPE_5 ) ; }
TYPE_6 ( TYPE_1 VAR_2 , TYPE_2 view , TYPE_3 VAR_3 ) { super ( VAR_2 , view , VAR_3 , TYPE_4 . TYPE_5 ) ; }
spaces empty line
protected void METHOD_1 ( ) { METHOD_2 ( TYPE_1 . class , TYPE_1 . TYPE_8 . class , TYPE_3 . class ) ; <START> <END> bind ( new TYPE_4 < TYPE_5 < TYPE_6 > > ( ) { } ) . to ( new TYPE_4 < TYPE_7 < TYPE_6 > > ( ) { } ) ; bind ( TYPE_6 . class ) . to ( TYPE_1 . class ) ; }
protected void METHOD_1 ( ) { METHOD_2 ( TYPE_1 . class , TYPE_1 . TYPE_8 . class , TYPE_3 . class ) ; }
url I guess inline i e VAR_1 METHOD_7 ( ) ( )
public void METHOD_1 ( ) { new TYPE_1 ( ) . METHOD_2 ( ) . METHOD_3 ( ) . METHOD_4 ( ) . METHOD_5 ( ) . METHOD_6 ( ) ; String url = VAR_1 . METHOD_7 ( ) ; <START> TYPE_2 . assertTrue ( url . contains ( STRING_1 ) ) ; <END> }
public void METHOD_1 ( ) { new TYPE_1 ( ) . METHOD_2 ( ) . METHOD_3 ( ) . METHOD_4 ( ) . METHOD_5 ( ) . METHOD_6 ( ) ; TYPE_2 . assertTrue ( VAR_1 . METHOD_7 ( ) . contains ( STRING_1 ) ) ; }
please add curly braces
public String METHOD_1 ( String VAR_1 ) { <START> if ( "" . equals ( VAR_1 ) ) <END> throw new TYPE_1 ( STRING_1 ) ; return METHOD_2 ( true ) + TYPE_2 . VAR_3 + VAR_1 ; }
public String METHOD_1 ( String VAR_1 ) { if ( "" . equals ( VAR_1 ) ) { throw new TYPE_1 ( STRING_1 ) ; } return METHOD_2 ( true ) + TYPE_2 . VAR_3 + VAR_1 ; }
nice create integer constant assign INT_1 E g public static int WINDOW_HEIGHT = INT_1 d more explicit another person ( magic numbers )
public TYPE_1 METHOD_1 ( String VAR_1 ) { <START> VAR_2 . METHOD_2 ( 0 , INT_1 ) ; <END> VAR_3 . METHOD_3 ( VAR_4 ) ; TYPE_2 . METHOD_4 ( VAR_1 ) ; return this ; }
public TYPE_1 METHOD_1 ( String VAR_1 ) { VAR_3 . METHOD_3 ( VAR_4 ) ; TYPE_2 . METHOD_4 ( VAR_1 ) ; return this ; }
FYI I s a method _CODE_ ( )
public TYPE_1 METHOD_1 ( ) { try { Thread . VAR_1 ( INT_1 ) ; } catch ( Exception e ) { } VAR_2 . METHOD_2 ( VAR_3 ) ; <START> VAR_3 . METHOD_3 ( ) ; <END> return this ; }
public TYPE_1 METHOD_1 ( ) { VAR_2 . METHOD_2 ( VAR_3 ) ; VAR_3 . METHOD_3 ( ) ; return this ; }
! [ MAJOR ] ( severity : MAJOR ) remove unused private METHOD_1 method [ ! [ rule ] ( ) ] ( )
<START> private String METHOD_1 ( String page , String query ) { <END> return VAR_1 . METHOD_2 ( VAR_1 . METHOD_3 ( String . format ( STRING_1 , VAR_1 . METHOD_4 ( page ) ) ) , query ) ; }
private String METHOD_1 ( String page , String query ) { return VAR_1 . METHOD_2 ( VAR_1 . METHOD_3 ( VAR_1 . METHOD_4 ( page ) ) , query ) ; }
I wrote don t need create instance TYPE_4 METHOD_5 ( ) a static method invoke : TYPE_4 METHOD_5 ( VAR_3 )
public void METHOD_1 ( ) { new TYPE_1 ( ) . METHOD_2 ( STRING_1 ) ; TYPE_2 VAR_1 = new TYPE_2 ( ) ; TYPE_3 . assertTrue ( VAR_1 . METHOD_3 ( ) ) ; <START> TYPE_4 VAR_2 = new TYPE_4 ( ) ; <END> TYPE_3 . METHOD_4 ( VAR_2 . METHOD_5 ( VAR_3 ) ) ; }
public void METHOD_1 ( ) { new TYPE_1 ( ) . METHOD_2 ( STRING_1 ) ; TYPE_2 VAR_1 = new TYPE_2 ( ) ; TYPE_3 . assertTrue ( VAR_1 . METHOD_3 ( ) ) ; TYPE_3 . METHOD_4 ( TYPE_4 . METHOD_5 ( VAR_3 ) ) ; }
shouldn t a part logic _CODE_ ? reuse SLOT_TRIGGERS _CODE_ scroll slot s pretty implemented : (
public void METHOD_1 ( ) { <START> METHOD_2 ( TYPE_1 . METHOD_3 ( TYPE_1 . VAR_1 ) ) ; <END> METHOD_4 ( ) ; TYPE_2 . log ( STRING_1 , STRING_2 , true , VAR_2 ) ; }
public void METHOD_1 ( ) { METHOD_4 ( ) ; TYPE_2 . log ( STRING_1 , STRING_2 , true , VAR_2 ) ; }
outer optional shouldnt needed
public Optional < TYPE_1 > METHOD_1 ( String VAR_1 ) { <START> return Optional . VAR_2 ( <END> METHOD_2 ( ) . METHOD_3 ( ) . stream ( ) . METHOD_4 ( VAR_3 - > METHOD_5 ( VAR_3 . METHOD_6 ( ) ) ) . filter ( VAR_3 - > VAR_3 . METHOD_7 ( ) . equals ( VAR_1 ) ) . METHOD_8 ( ) . METHOD_9 ( ( ) - > new RuntimeException ( Str...
public TYPE_1 METHOD_1 ( String VAR_1 ) { return METHOD_2 ( ) . METHOD_3 ( ) . stream ( ) . METHOD_4 ( VAR_3 - > METHOD_5 ( VAR_3 . METHOD_6 ( ) ) ) . filter ( VAR_3 - > VAR_3 . METHOD_7 ( ) . equals ( VAR_1 ) ) . METHOD_8 ( ) . METHOD_9 ( ( ) - > new RuntimeException ( String . format ( STRING_1 , VAR_1 ) ) ) ; }
necessary
public boolean METHOD_1 ( ) { <START> this . METHOD_2 ( ) ; <END> return this . METHOD_3 ( ) . METHOD_4 ( ) . METHOD_5 ( ) ; }
public boolean METHOD_1 ( ) { METHOD_2 ( ) ; return METHOD_3 ( ) . METHOD_4 ( ) . METHOD_5 ( ) ; }
doesn t method return a null
private TYPE_1 METHOD_1 ( String VAR_1 ) throws IOException , TYPE_2 { TYPE_3 url = new TYPE_3 ( METHOD_2 ( VAR_1 ) ) ; TYPE_4 VAR_2 = TYPE_5 . create ( ) . METHOD_3 ( ) . build ( ) ; TYPE_6 VAR_3 = METHOD_4 ( url ) ; <START> if ( METHOD_5 ( ) != null ) { <END> VAR_3 . METHOD_6 ( new TYPE_7 ( METHOD_5 ( ) , TYPE_8 . VA...
private TYPE_1 METHOD_1 ( String VAR_1 ) throws IOException , TYPE_2 { TYPE_3 url = new TYPE_3 ( METHOD_2 ( VAR_1 ) ) ; TYPE_4 VAR_2 = TYPE_5 . create ( ) . METHOD_3 ( ) . build ( ) ; TYPE_6 VAR_3 = METHOD_4 ( url ) ; VAR_3 . METHOD_6 ( new TYPE_7 ( METHOD_5 ( ) , TYPE_8 . VAR_5 ) ) ; return VAR_2 . execute ( VAR_3 ) ;...
I code style suggests annotations methods
<START> @Override public TYPE_1 METHOD_1 ( String VAR_1 ) { <END> METHOD_2 ( VAR_2 , VAR_1 ) ; return this ; }
public TYPE_1 METHOD_1 ( String VAR_1 ) { METHOD_2 ( VAR_2 , VAR_1 ) ; return this ; }
nitpick : else more
public void METHOD_1 ( String VAR_1 ) { if ( VAR_1 . equals ( TYPE_1 . VAR_3 ) ) { METHOD_2 ( ) ; } if ( VAR_1 . equals ( TYPE_1 . VAR_4 ) ) { METHOD_3 ( ) ; <START> } <END> METHOD_4 ( STRING_1 + VAR_1 ) ; }
public void METHOD_1 ( String VAR_1 ) { if ( VAR_1 . equals ( TYPE_1 . VAR_3 ) ) { METHOD_2 ( ) ; } else if ( VAR_1 . equals ( TYPE_1 . VAR_4 ) ) { METHOD_3 ( ) ; } METHOD_4 ( STRING_1 + VAR_1 ) ; }
equals
public boolean METHOD_1 ( String VAR_1 , String VAR_2 , String VAR_3 ) { return VAR_4 . stream ( ) . filter ( VAR_5 - > VAR_5 . getType ( ) == TYPE_1 . VAR_7 ) . filter ( VAR_5 - > VAR_5 . METHOD_2 ( ) . METHOD_3 ( ) . contains ( VAR_1 ) ) <START> . filter ( VAR_5 - > VAR_5 . METHOD_4 ( ) . contains ( VAR_2 ) ) <END> ....
public boolean METHOD_1 ( String VAR_1 , String VAR_2 , String VAR_3 ) { return VAR_4 . stream ( ) . filter ( VAR_5 - > VAR_5 . getType ( ) == TYPE_1 . VAR_7 ) . filter ( VAR_5 - > VAR_5 . METHOD_2 ( ) . METHOD_3 ( ) . contains ( VAR_1 ) ) . filter ( VAR_5 - > VAR_5 . METHOD_4 ( ) . equals ( VAR_2 ) ) . METHOD_5 ( VAR_...
! [ MAJOR ] ( severity : MAJOR ) remove unused private METHOD_1 method [ ! [ rule ] ( ) ] ( )
<START> private void METHOD_1 ( long VAR_1 , String VAR_2 , String VAR_3 , TYPE_1 VAR_4 ) { <END> VAR_4 . METHOD_2 ( VAR_2 ) ; TYPE_2 . assertEquals ( VAR_1 , VAR_4 . METHOD_3 ( TYPE_3 . VAR_6 ) ) ; VAR_4 . METHOD_2 ( VAR_3 ) ; TYPE_2 . assertEquals ( VAR_1 , VAR_4 . METHOD_3 ( TYPE_3 . VAR_7 ) ) ; TYPE_2 . METHOD_4 ( ...
private void METHOD_1 ( long VAR_1 , String VAR_2 , String VAR_3 , TYPE_1 VAR_4 ) { VAR_4 . METHOD_2 ( VAR_2 ) ; TYPE_2 . assertEquals ( VAR_1 , VAR_4 . METHOD_3 ( VAR_2 ) ) ; VAR_4 . METHOD_2 ( VAR_3 ) ; TYPE_2 . assertEquals ( VAR_1 , VAR_4 . METHOD_3 ( VAR_3 ) ) ; }
universal operation checked sth similar performed repo
private String METHOD_1 ( ) { TYPE_1 VAR_1 = new TYPE_2 ( STRING_1 ) ; int VAR_2 = ( int ) Math . VAR_3 ( VAR_4 / INT_1 ) ; int VAR_5 = ( int ) Math . VAR_3 ( VAR_4 / INT_2 % INT_2 ) ; <START> int VAR_6 = ( int ) Math . VAR_3 ( VAR_4 % INT_2 ) ; <END> return String . format ( STRING_2 , VAR_1 . format ( VAR_2 ) , VAR_1...
private String METHOD_1 ( ) { TYPE_1 VAR_1 = new TYPE_2 ( STRING_1 ) ; int VAR_2 = ( int ) Math . VAR_3 ( VAR_4 / INT_1 ) , VAR_5 = ( int ) Math . VAR_3 ( VAR_4 / INT_2 % INT_2 ) , VAR_6 = ( int ) Math . VAR_3 ( VAR_4 % INT_2 ) ; return String . format ( STRING_2 , VAR_1 . format ( VAR_2 ) , VAR_1 . format ( VAR_5 ) , ...
result comparison returned
public boolean METHOD_1 ( double VAR_1 , double VAR_2 ) { int VAR_3 = ( int ) Math . VAR_4 ( 100 - ( 100 / ( VAR_1 / VAR_2 ) ) ) ; if ( VAR_3 == VAR_5 ) { <START> return true ; <END> } TYPE_1 . log ( STRING_1 , STRING_2 + VAR_5 + STRING_3 , false , VAR_6 ) ; return false ; }
public boolean METHOD_1 ( double VAR_1 , double VAR_2 ) { int VAR_3 = ( int ) Math . VAR_4 ( 100 - ( 100 / ( VAR_1 / VAR_2 ) ) ) ; return VAR_3 == VAR_5 ; }
create a ticket improve sonar rules
public void METHOD_1 ( TYPE_1 o ) { try { o . run ( ) ; <START> } catch ( TYPE_2 e ) { <END> TYPE_3 . log ( STRING_1 , e . getMessage ( ) , true ) ; } }
public void METHOD_1 ( TYPE_1 o ) { try { o . run ( ) ; } catch ( TYPE_2 e ) { TYPE_3 . log ( STRING_1 , e , true ) ; } }
static import assertTrue
public void METHOD_1 ( ) { TYPE_1 VAR_1 = new TYPE_1 ( ) ; VAR_1 . METHOD_2 ( VAR_2 ) ; VAR_1 . METHOD_3 ( ) ; VAR_1 . METHOD_4 ( ) ; new TYPE_2 ( ) . METHOD_5 ( VAR_3 . VAR_4 , VAR_3 . VAR_5 ) ; VAR_1 . METHOD_6 ( VAR_3 . VAR_4 ) ; <START> TYPE_3 . assertTrue ( VAR_1 . METHOD_7 ( TYPE_4 . VAR_7 ) ) ; <END> }
public void METHOD_1 ( ) { TYPE_1 VAR_1 = new TYPE_1 ( ) ; VAR_1 . METHOD_2 ( VAR_2 ) ; VAR_1 . METHOD_3 ( ) ; VAR_1 . METHOD_4 ( ) ; new TYPE_2 ( ) . METHOD_5 ( VAR_3 . VAR_4 , VAR_3 . VAR_5 ) ; VAR_1 . METHOD_6 ( VAR_3 . VAR_4 ) ; assertTrue ( VAR_1 . METHOD_7 ( TYPE_4 . VAR_7 ) ) ; }
I pass parameters a lot TYPE_4 VAR_4 TYPE_4 VAR_5 extract method hardcode parameters
public void METHOD_1 ( TYPE_1 page , String VAR_1 , String VAR_2 ) { <START> METHOD_2 ( page , TYPE_4 . VAR_4 , TYPE_4 . VAR_5 ) ; <END> final TYPE_2 VAR_6 = new TYPE_2 ( VAR_7 , VAR_1 , VAR_2 ) ; TYPE_3 . METHOD_3 ( VAR_6 ) ; }
public void METHOD_1 ( TYPE_1 page , String VAR_1 , String VAR_2 ) { METHOD_2 ( page ) ; final TYPE_2 VAR_6 = new TYPE_2 ( VAR_7 , VAR_1 , VAR_2 ) ; TYPE_3 . METHOD_3 ( VAR_6 ) ; }
interface
public void METHOD_1 ( final String VAR_1 , TYPE_1 user ) { <START> ArrayList < TYPE_4 . TYPE_5 > VAR_2 = METHOD_2 ( VAR_1 , user ) ; <END> for ( TYPE_4 . TYPE_5 VAR_3 : VAR_2 ) { TYPE_3 . METHOD_3 ( STRING_1 + VAR_3 . getName ( ) ) ; METHOD_4 ( VAR_1 , VAR_3 ) ; } }
public void METHOD_1 ( final String VAR_1 , TYPE_1 user ) { List < TYPE_4 . TYPE_5 > VAR_2 = METHOD_2 ( VAR_1 , user ) ; for ( TYPE_4 . TYPE_5 VAR_3 : VAR_2 ) { TYPE_3 . METHOD_3 ( STRING_1 + VAR_3 . getName ( ) ) ; METHOD_4 ( VAR_1 , VAR_3 ) ; } }
interface return signature
<START> public ArrayList < TYPE_5 . TYPE_6 > METHOD_1 ( final String VAR_1 , TYPE_2 user ) { <END> return new TYPE_3 ( user ) . execute ( TYPE_4 . METHOD_2 ( VAR_1 , "" ) ) ; }
public List < TYPE_5 . TYPE_6 > METHOD_1 ( final String VAR_1 , TYPE_2 user ) { return new TYPE_3 ( user ) . execute ( TYPE_4 . METHOD_2 ( VAR_1 , "" ) ) ; }
nitpick : missing spaces pipe I d suggest naming exception variables
String execute ( final TYPE_1 request , final TYPE_2 VAR_1 ) { String result = StringUtils . VAR_2 ; try { request . VAR_3 ( TYPE_11 . VAR_5 , TYPE_9 . TYPE_10 . toString ( ) ) ; request . VAR_6 ( new TYPE_4 ( VAR_1 . toString ( ) ) ) ; result = execute ( request ) ; <START> } catch ( TYPE_5 | TYPE_6 x ) { <END> TYPE_7...
String execute ( final TYPE_1 request , final TYPE_2 VAR_1 ) { String result = StringUtils . VAR_2 ; try { request . VAR_3 ( TYPE_11 . VAR_5 , TYPE_9 . TYPE_10 . toString ( ) ) ; request . VAR_6 ( new TYPE_4 ( VAR_1 . toString ( ) ) ) ; result = execute ( request ) ; } catch ( TYPE_5 | TYPE_6 ex ) { TYPE_7 . log ( STRI...
final List < TYPE_2 > VAR_1 = METHOD_2 ( ) ; ( position < VAR_1 size ( ) ) { return new TYPE_1 ( VAR_1 ( position ) ) ; } else { return null ; }
public TYPE_1 METHOD_1 ( int position ) { TYPE_1 result = null ; final List < TYPE_2 > VAR_1 = METHOD_2 ( ) ; if ( position < VAR_1 . size ( ) ) { result = new TYPE_1 ( VAR_1 . get ( position ) ) ; } <START> return result ; <END> }
public TYPE_1 METHOD_1 ( int position ) { final List < TYPE_2 > VAR_1 = METHOD_2 ( ) ; if ( position < VAR_1 . size ( ) ) { return new TYPE_1 ( VAR_1 . get ( position ) ) ; } else { return null ; } }