ReviewComments stringlengths 1 2.35k | OriginalCode stringlengths 28 487 | ReviewedCode stringlengths 14 463 |
|---|---|---|
remove super ( ) ; | public TYPE_1 ( Class < ? > VAR_2 , String VAR_3 ) { <START> super ( ) ; <END> this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; } | public TYPE_1 ( Class < ? > VAR_2 , String VAR_3 ) { this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; } |
a hardcoded constant ( STRING_1 ) simply I won t change practice s case people copy / paste code | public void METHOD_1 ( String name , TYPE_1 builder ) { <START> builder . field ( STRING_1 , TYPE_2 . VAR_2 ) ; <END> } | public void METHOD_1 ( String name , TYPE_1 builder ) { builder . field ( name , TYPE_2 . VAR_2 ) ; } |
TYPE_3 TYPE_4 impl types packages accessed | public void METHOD_1 ( String name , TYPE_1 builder ) { TYPE_2 field = builder . field ( name , TYPE_5 . VAR_2 ) ; if ( VAR_3 != null ) { <START> field . VAR_4 ( TYPE_3 . class ) <END> . METHOD_2 ( TYPE_4 . VAR_6 ) ; } } | public void METHOD_1 ( String name , TYPE_1 builder ) { TYPE_2 field = builder . field ( name , TYPE_5 . VAR_2 ) ; if ( VAR_3 != null ) { field . VAR_4 ( TYPE_3 . class ) . METHOD_2 ( VAR_3 ) ; } } |
else ? s private ( I suppose purpose dropping _CODE_ ) | <START> static String METHOD_1 ( TYPE_1 VAR_1 ) { <END> return VAR_1 . METHOD_2 ( ) == null ? VAR_1 . METHOD_3 ( ) : VAR_1 . METHOD_2 ( ) + STRING_1 + VAR_1 . METHOD_3 ( ) ; } | private String METHOD_1 ( TYPE_1 VAR_1 ) { return VAR_1 . METHOD_2 ( ) == null ? VAR_1 . METHOD_3 ( ) : VAR_1 . METHOD_2 ( ) + STRING_1 + VAR_1 . METHOD_3 ( ) ; } |
need a elasticsearch | public void METHOD_1 ( ) throws Exception { super . METHOD_1 ( ) ; TYPE_1 VAR_1 = METHOD_2 ( ) . METHOD_3 ( ) ; <START> TYPE_2 a = new TYPE_2 ( ) ; <END> a . value = STRING_1 ; METHOD_4 ( ) . METHOD_5 ( a ) ; VAR_1 . commit ( ) ; METHOD_4 ( ) . close ( ) ; this . VAR_2 = TYPE_3 . METHOD_6 ( METHOD_2 ( ) ) ; } | public void METHOD_1 ( ) throws Exception { super . METHOD_1 ( ) ; TYPE_1 VAR_1 = METHOD_2 ( ) . METHOD_3 ( ) ; METHOD_4 ( ) . METHOD_5 ( new TYPE_2 ( ) ) ; VAR_1 . commit ( ) ; METHOD_4 ( ) . close ( ) ; this . VAR_2 = TYPE_3 . METHOD_6 ( METHOD_2 ( ) ) ; } |
simply delete toString formatter invoke s needed avoid creating String log level disabled s WARN case shouldn t matter pointing a toString ( ) suspicious | private String METHOD_1 ( Class < ? > VAR_1 , TYPE_1 VAR_2 ) { TYPE_2 VAR_3 = VAR_2 . METHOD_2 ( ) ; if ( VAR_3 . is ( TYPE_3 . class ) ) { return VAR_3 . METHOD_3 ( TYPE_3 . class ) . getName ( ) ; } <START> LOG . VAR_4 ( VAR_1 , VAR_2 . METHOD_4 ( ) , VAR_3 . toString ( ) ) ; <END> return null ; } | private String METHOD_1 ( Class < ? > VAR_1 , TYPE_1 VAR_2 ) { TYPE_2 VAR_3 = VAR_2 . METHOD_2 ( ) ; if ( VAR_3 . is ( TYPE_3 . class ) ) { return VAR_3 . METHOD_3 ( TYPE_3 . class ) . getName ( ) ; } LOG . VAR_4 ( VAR_1 , VAR_2 . METHOD_4 ( ) , VAR_3 ) ; return null ; } |
locking thingy I d / else class done esp plug another type ? single user method raises exception case type supported a bit odd I don t work | public static boolean METHOD_1 ( Class < ? extends TYPE_1 > type ) { if ( TYPE_2 == null ) { <START> TYPE_3 . METHOD_2 ( ) ; <END> try { if ( TYPE_2 == null ) { Set < Class < ? extends TYPE_1 > > set = new HashSet < > ( ) ; set . add ( TYPE_4 . class ) ; TYPE_2 = Collections . VAR_1 ( set ) ; } } finally { TYPE_3 . MET... | public static boolean METHOD_1 ( Class < ? extends TYPE_1 > type ) { if ( TYPE_4 . class == type ) { return true ; } return false ; } |
log a constant making clear shortcut logging error handler | private TYPE_1 METHOD_1 ( String VAR_1 , TYPE_2 VAR_2 ) { <START> if ( TYPE_3 . isEmpty ( VAR_1 ) || STRING_1 . equals ( VAR_1 . trim ( ) ) ) { <END> return new TYPE_4 ( ) ; } else { Class < ? > VAR_3 = VAR_2 . METHOD_2 ( VAR_1 ) ; return TYPE_5 . METHOD_3 ( TYPE_1 . class , VAR_3 , STRING_2 ) ; } } | private TYPE_1 METHOD_1 ( String VAR_1 , TYPE_2 VAR_2 ) { if ( TYPE_3 . isEmpty ( VAR_1 ) || TYPE_1 . LOG . equals ( VAR_1 . trim ( ) ) ) { return new TYPE_4 ( ) ; } else { Class < ? > VAR_3 = VAR_2 . METHOD_2 ( VAR_1 ) ; return TYPE_5 . METHOD_3 ( TYPE_1 . class , VAR_3 , STRING_2 ) ; } } |
I a tricky race condition : fail METHOD_3 consumer thread consumer park ( check queue empty ) | private void METHOD_1 ( ) { <START> if ( TYPE_1 . METHOD_2 ( VAR_1 ) != null ) { <END> TYPE_1 . METHOD_3 ( VAR_1 ) ; } } | private void METHOD_1 ( ) { TYPE_1 . METHOD_3 ( VAR_1 ) ; } |
I need _CODE_ thread safe I perfectly fine isn t thread safe | public void METHOD_1 ( Collection < File > VAR_1 ) { <START> VAR_2 . METHOD_2 ( ) . METHOD_3 ( ) ; <END> try { METHOD_4 ( ) ; METHOD_5 ( server , METHOD_6 ( VAR_1 ) ) ; } finally { VAR_2 . METHOD_2 ( ) . METHOD_7 ( ) ; } } | public void METHOD_1 ( Collection < File > VAR_1 ) { METHOD_4 ( ) ; METHOD_5 ( server , METHOD_6 ( VAR_1 ) ) ; } |
lines redundant lines 291 - 293 | public < T > T METHOD_1 ( final TYPE_1 < T > query ) { TYPE_2 options = new TYPE_2 ( ) <START> . remove ( true ) <END> . METHOD_2 ( false ) . METHOD_3 ( false ) ; return METHOD_1 ( query , options ) ; } | public < T > T METHOD_1 ( final TYPE_1 < T > query ) { return METHOD_1 ( query , new TYPE_2 ( ) ) ; } |
add a close a finally block | public T get ( final TYPE_1 options ) { final TYPE_2 < T , T > it = METHOD_1 ( options . VAR_1 ( ) . METHOD_2 ( 1 ) ) ; T t = ( it . hasNext ( ) ) ? it . next ( ) : null ; <START> it . close ( ) ; <END> return t ; } | public T get ( final TYPE_1 options ) { final TYPE_2 < T , T > it = METHOD_1 ( options . VAR_1 ( ) . METHOD_2 ( 1 ) ) ; try { return ( it . hasNext ( ) ) ? it . next ( ) : null ; } finally { it . close ( ) ; } } |
implications breaking binary compatibility ? class users affect ? existing public constructors deprecated removed | <START> TYPE_3 ( final TYPE_1 VAR_2 , final TYPE_2 VAR_3 , final String VAR_4 ) { <END> this ( VAR_2 , VAR_2 . METHOD_1 ( ) , VAR_3 , VAR_4 ) ; } | public TYPE_3 ( final TYPE_1 VAR_2 , final TYPE_2 VAR_3 , final String VAR_4 ) { this ( VAR_2 , VAR_2 . METHOD_1 ( ) , VAR_3 , VAR_4 ) ; } |
I don t point making db lazily created s expensive operation | public TYPE_1 METHOD_1 ( ) { <START> return db != null ? db : VAR_1 . METHOD_1 ( VAR_2 . getName ( ) ) ; <END> } | public TYPE_1 METHOD_1 ( ) { return db ; } |
don t allow comparison s confusing | public static TYPE_1 METHOD_1 ( final Object value ) { for ( TYPE_1 VAR_1 : values ( ) ) { <START> if ( VAR_1 . type . equals ( value ) || VAR_1 . name ( ) . equals ( value ) ) { <END> return VAR_1 ; } } throw new IllegalArgumentException ( STRING_1 + value ) ; } | public static TYPE_1 METHOD_1 ( final Object value ) { for ( TYPE_1 VAR_1 : values ( ) ) { if ( VAR_1 . type . equals ( value ) ) { return VAR_1 ; } } throw new IllegalArgumentException ( STRING_1 + value ) ; } |
binary compat break | <START> List < TYPE_1 > METHOD_1 ( final Class < TYPE_2 > VAR_1 ) { <END> return VAR_2 . get ( VAR_1 ) ; } | public List < TYPE_1 > METHOD_1 ( final Class < TYPE_2 > VAR_1 ) { return VAR_2 . get ( VAR_1 ) ; } |
need wrap a TYPE_3 a _CODE_ a subclass TYPE_3 | public TYPE_1 read ( ) throws IOException { METHOD_1 ( ) . info ( STRING_1 ) ; TYPE_1 model = new TYPE_1 ( ) ; model . VAR_1 ( TYPE_1 . TYPE_5 . VAR_3 ) ; <START> TYPE_2 < String > VAR_4 = new TYPE_3 ( in ) . METHOD_2 ( ) ; <END> VAR_4 . filter ( this : : METHOD_3 ) . map ( this : : METHOD_4 ) . filter ( TYPE_4 : : MET... | public TYPE_1 read ( ) throws IOException { METHOD_1 ( ) . info ( STRING_1 ) ; TYPE_1 model = new TYPE_1 ( ) ; model . VAR_1 ( TYPE_1 . TYPE_5 . VAR_3 ) ; TYPE_2 < String > VAR_4 = in . VAR_4 ( ) ; VAR_4 . filter ( this : : METHOD_3 ) . map ( this : : METHOD_4 ) . filter ( TYPE_4 : : METHOD_5 ) . forEach ( model : : ad... |
ANNOTATION_1 annotation implies argument null correct fix ANNOTATION_1 annotation : return VAR_2 ! = null ? VAR_2 METHOD_3 ( ) : null ; | public TYPE_1 < String > METHOD_1 ( ) { return TYPE_2 . METHOD_2 ( VAR_1 , new TYPE_3 < TYPE_4 , String > ( ) { @Override ANNOTATION_1 <START> public String apply ( TYPE_4 VAR_2 ) <END> { return VAR_2 . METHOD_3 ( ) ; } } ) ; } | public TYPE_1 < String > METHOD_1 ( ) { return TYPE_2 . METHOD_2 ( VAR_1 , new TYPE_3 < TYPE_4 , String > ( ) { @Override ANNOTATION_1 public String apply ( ANNOTATION_1 TYPE_4 VAR_2 ) { return VAR_2 != null ? VAR_2 . METHOD_3 ( ) : null ; } } ) ; } |
case redundant default | public static String METHOD_1 ( TYPE_2 . TYPE_3 VAR_1 ) { switch ( VAR_1 ) { case VAR_2 : return VAR_3 ; case VAR_4 : return VAR_5 ; case VAR_6 : return VAR_7 ; default : <START> case VAR_8 : <END> return VAR_9 ; } } | public static String METHOD_1 ( TYPE_2 . TYPE_3 VAR_1 ) { switch ( VAR_1 ) { case VAR_2 : return VAR_3 ; case VAR_4 : return VAR_5 ; case VAR_6 : return VAR_7 ; default : return VAR_9 ; } } |
JSON lines opening [ isn t necessary anymore | public TYPE_3 ( TYPE_1 out ) { this . out = out ; VAR_2 . METHOD_1 ( ) . METHOD_2 ( TYPE_4 . TYPE_5 . VAR_5 , true ) ; VAR_6 = VAR_2 . writer ( new TYPE_2 ( ) ) ; try { <START> out . VAR_7 ( STRING_1 ) ; <END> } catch ( IOException e ) { } } | public TYPE_3 ( TYPE_1 out ) { this . out = out ; VAR_2 . METHOD_1 ( ) . METHOD_2 ( TYPE_4 . TYPE_5 . VAR_5 , true ) ; VAR_6 = VAR_2 . writer ( new TYPE_2 ( ) ) ; } |
possibly TYPE_1 find ( ) instead TYPE_1 METHOD_1 ( ) : - patterns shorter : \ jpg$ instead * \ jpg ( * \ jpg$ ) - ( more important ) syntax urlfilter - regex rules | public boolean filter ( String VAR_1 , String VAR_2 ) { if ( VAR_3 != null ) { for ( TYPE_1 VAR_4 : VAR_3 ) { <START> if ( VAR_4 . matcher ( VAR_2 ) . METHOD_1 ( ) ) { <END> return true ; } } } return false ; } | public boolean filter ( String VAR_1 , String VAR_2 ) { return this . filter ( VAR_2 ) != null ; } |
s reason invoke jackson mapping ? shouldn t a plain toString ( ) sufficient | <START> private String METHOD_1 ( TYPE_1 VAR_1 , Object VAR_2 ) { <END> if ( VAR_1 . METHOD_2 ( ) ) { TYPE_2 < Object > VAR_3 = TYPE_2 . create ( VAR_2 , VAR_4 ) ; Object version = VAR_3 . getProperty ( VAR_1 . METHOD_3 ( ) ) ; try { return STRING_1 + VAR_5 . METHOD_4 ( version ) + STRING_1 ; } catch ( TYPE_3 e ) { LOG... | private String METHOD_1 ( TYPE_1 VAR_1 , Object VAR_2 ) { if ( VAR_1 . METHOD_2 ( ) ) { TYPE_2 < Object > VAR_3 = TYPE_2 . create ( VAR_2 , VAR_4 ) ; Object version = VAR_3 . getProperty ( VAR_1 . METHOD_3 ( ) ) ; return STRING_1 + version . toString ( ) + STRING_1 ; } return null ; } |
worth replacing new lines * * sides ? ( sounds useless I missing ) | public void METHOD_1 ( ) throws Exception { TYPE_1 VAR_1 = VAR_2 . METHOD_2 ( STRING_1 ) ; String VAR_3 = VAR_1 . toString ( ) ; System . out . println ( STRING_2 + VAR_3 ) ; <START> assertThat ( METHOD_3 ( VAR_3 ) ) . METHOD_4 ( METHOD_3 ( TYPE_2 . toString ( <END> TYPE_2 . METHOD_5 ( STRING_3 ) , TYPE_3 . VAR_5 ) ) )... | public void METHOD_1 ( ) throws Exception { TYPE_1 VAR_1 = VAR_2 . METHOD_2 ( STRING_1 ) ; String VAR_3 = VAR_1 . toString ( ) ; assertThat ( VAR_3 ) . METHOD_4 ( TYPE_2 . toString ( TYPE_2 . METHOD_5 ( STRING_3 ) , TYPE_3 . VAR_5 ) ) ; } |
METHOD_2 ( ) METHOD_3 ( ) enough | private TYPE_1 METHOD_1 ( ) { <START> return ( ) - > TYPE_2 . this . METHOD_2 ( ) . METHOD_3 ( ) ; <END> } | private TYPE_1 METHOD_1 ( ) { return ( ) - > this . METHOD_2 ( ) . METHOD_3 ( ) ; } |
I d prefer condition check VAR_2 METHOD_4 ( ) s a big deal | private TYPE_1 build ( final TYPE_2 VAR_1 , final String field ) throws IOException { TYPE_3 iterator = new TYPE_3 ( new TYPE_4 ( VAR_1 , field ) . METHOD_1 ( ) , VAR_1 , field , METHOD_2 ( field ) ) ; TYPE_1 VAR_2 = METHOD_3 ( ) ; VAR_2 . build ( iterator ) ; <START> if ( iterator . VAR_3 > 0 ) { <END> double VAR_4 = ... | private TYPE_1 build ( final TYPE_2 VAR_1 , final String field ) throws IOException { TYPE_3 iterator = new TYPE_3 ( new TYPE_4 ( VAR_1 , field ) . METHOD_1 ( ) , VAR_1 , field , METHOD_2 ( field ) ) ; TYPE_1 VAR_2 = METHOD_3 ( ) ; VAR_2 . build ( iterator ) ; if ( VAR_2 . METHOD_4 ( ) > 0 ) { double VAR_4 = ( double )... |
I d qualify class a context | static String METHOD_1 ( Collection < TYPE_5 . TYPE_6 > VAR_1 ) { return VAR_1 . stream ( ) . map ( TYPE_5 . TYPE_6 : : METHOD_2 ) . <START> max ( VAR_2 ) . <END> map ( TYPE_3 . TYPE_4 : : toString ) . METHOD_3 ( null ) ; } | static String METHOD_1 ( Collection < TYPE_5 . TYPE_6 > VAR_1 ) { return VAR_1 . stream ( ) . map ( TYPE_5 . TYPE_6 : : METHOD_2 ) . max ( TYPE_3 . TYPE_4 . VAR_2 ) . map ( TYPE_3 . TYPE_4 : : toString ) . METHOD_3 ( null ) ; } |
METHOD_2 ( ) more understandable remember 0 means wait | public void close ( ) { if ( VAR_1 == null ) { return ; } try { run = false ; synchronized ( VAR_2 ) { VAR_2 . METHOD_1 ( ) ; } <START> VAR_1 . METHOD_2 ( 0 ) ; <END> } catch ( InterruptedException e ) { logger . log ( Level . VAR_3 , STRING_1 ) ; } } | public void close ( ) { if ( VAR_1 == null ) { return ; } try { run = false ; synchronized ( VAR_2 ) { VAR_2 . METHOD_1 ( ) ; } VAR_1 . METHOD_2 ( ) ; } catch ( InterruptedException e ) { logger . log ( Level . VAR_3 , STRING_1 ) ; } } |
theoretically accessed multiple threads ? want a singleton revise | public TYPE_1 METHOD_1 ( ) { try { VAR_1 . METHOD_2 ( ) . METHOD_3 ( ) ; if ( VAR_2 == null ) { <START> VAR_2 = new TYPE_1 ( METHOD_4 ( ) , METHOD_5 ( ) ) ; <END> } return VAR_2 ; } finally { VAR_1 . METHOD_2 ( ) . METHOD_6 ( ) ; } } | public TYPE_1 METHOD_1 ( ) { synchronized ( VAR_1 ) { if ( VAR_2 == null ) { VAR_2 = new TYPE_1 ( METHOD_4 ( ) , METHOD_5 ( ) ) ; } return VAR_2 ; } } |
i new Object ( ) synchronize object | private TYPE_7 ( ) { configuration = new TYPE_1 ( ) ; VAR_2 = new TYPE_2 ( ) ; <START> VAR_3 = new TYPE_3 ( ) ; <END> VAR_4 = new TYPE_4 ( ) ; VAR_5 = TYPE_5 . METHOD_1 ( ( ) - > new TYPE_6 ( this ) ) ; VAR_6 = TYPE_5 . METHOD_1 ( ( ) - > METHOD_2 ( ) ) ; } | private TYPE_7 ( ) { configuration = new TYPE_1 ( ) ; VAR_2 = new TYPE_2 ( ) ; VAR_4 = new TYPE_4 ( ) ; VAR_5 = TYPE_5 . METHOD_1 ( ( ) - > new TYPE_6 ( this ) ) ; VAR_6 = TYPE_5 . METHOD_1 ( ( ) - > METHOD_2 ( ) ) ; } |
necessary METHOD_3 VAR_1 iso standard | public void METHOD_1 ( final TYPE_1 VAR_1 , final TYPE_2 VAR_2 , final TYPE_3 VAR_3 ) throws IOException { if ( VAR_1 != null ) { <START> VAR_2 . METHOD_2 ( TYPE_4 . METHOD_3 ( VAR_1 . toString ( ) ) ) ; <END> } else { VAR_2 . METHOD_4 ( ) ; } } | public void METHOD_1 ( final TYPE_1 VAR_1 , final TYPE_2 VAR_2 , final TYPE_3 VAR_3 ) throws IOException { if ( VAR_1 != null ) { VAR_2 . METHOD_2 ( VAR_1 . toString ( ) ) ; } else { VAR_2 . METHOD_4 ( ) ; } } |
IDEA METHOD_2 ( new String [ collection size ( ) ] ) performance improvement METHOD_2 ( new String [ 0 ] ) call encouraged | private static String METHOD_1 ( List < String > VAR_1 ) { <START> String [ ] VAR_2 = new String [ VAR_1 . size ( ) ] ; <END> return METHOD_1 ( VAR_1 . METHOD_2 ( VAR_2 ) ) ; } | private static String METHOD_1 ( List < String > VAR_1 ) { return METHOD_1 ( VAR_1 . METHOD_2 ( new String [ 0 ] ) ) ; } |
return path ? url toString ( ) differ path | public static String METHOD_1 ( String path ) { TYPE_1 url ; try { url = new TYPE_1 ( path ) ; } catch ( TYPE_2 e ) { return path ; } if ( url . VAR_1 ( ) != null ) { return url . toString ( ) . METHOD_2 ( url . VAR_1 ( ) , VAR_2 ) ; } else { <START> return url . toString ( ) ; <END> } } | public static String METHOD_1 ( String path ) { TYPE_1 url ; try { url = new TYPE_1 ( path ) ; } catch ( TYPE_2 e ) { return path ; } if ( url . VAR_1 ( ) != null ) { return url . toString ( ) . METHOD_2 ( url . VAR_1 ( ) , VAR_2 ) ; } else { return path ; } } |
simplify return | public Map < String , TYPE_1 > METHOD_1 ( ) { Map < String , TYPE_1 > VAR_1 = ( Map < String , TYPE_1 > ) METHOD_2 ( STRING_1 ) ; <START> return VAR_1 ; <END> } | public Map < String , TYPE_1 > METHOD_1 ( ) { return ( Map < String , TYPE_1 > ) METHOD_2 ( STRING_1 ) ; } |
TYPE_3 shared runs tests I noticed a reversion original settings — e g VAR_2 METHOD_3 ( _CODE_ ) I tests passing done correctness | public static void METHOD_1 ( ) throws Exception { VAR_1 = new TYPE_1 ( ) ; VAR_1 . create ( TYPE_2 . class . METHOD_2 ( STRING_1 ) ) ; TYPE_3 VAR_2 = TYPE_3 . getInstance ( ) ; <START> VAR_2 . METHOD_3 ( true ) ; <END> VAR_2 . METHOD_4 ( VAR_1 . METHOD_5 ( ) ) ; } | public static void METHOD_1 ( ) throws Exception { VAR_1 = new TYPE_1 ( ) ; VAR_1 . create ( TYPE_2 . class . METHOD_2 ( STRING_1 ) ) ; TYPE_3 VAR_2 = TYPE_3 . getInstance ( ) ; VAR_2 . METHOD_4 ( VAR_1 . METHOD_5 ( ) ) ; VAR_2 . METHOD_3 ( true ) ; } |
potential NPE VAR_1 null doesn t | public boolean METHOD_1 ( ) { <START> return VAR_1 ; <END> } | public boolean METHOD_1 ( ) { return VAR_1 != null && VAR_1 ; } |
VAR_1 consistent _CODE_ ( ) | public void METHOD_1 ( String value ) { <START> VAR_1 = value ; <END> } | public void METHOD_1 ( String value ) { this . VAR_1 = value ; } |
lockpick factory : - D | <START> TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { <END> String VAR_2 = VAR_1 . METHOD_2 ( ) ; switch ( VAR_2 ) { case TYPE_3 . VAR_4 : return TYPE_4 . VAR_6 ; case TYPE_3 . VAR_7 : case TYPE_3 . VAR_8 : return TYPE_6 . VAR_6 ; case TYPE_3 . VAR_10 : return TYPE_5 . VAR_6 ; default : LOGGER . log ( Level . VAR_12 , STRING_1 , ... | TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { switch ( VAR_1 . METHOD_2 ( ) ) { case VAR_7 : case VAR_8 : return TYPE_6 . VAR_6 ; case VAR_10 : return TYPE_5 . VAR_6 ; case VAR_4 : default : return TYPE_4 . VAR_6 ; } } |
property definition | public void METHOD_1 ( Map < String , Object > parameters ) { super . METHOD_1 ( parameters ) ; if ( ( VAR_1 = ( String ) parameters . get ( VAR_2 ) ) == null ) { throw new TYPE_1 ( STRING_1 + VAR_2 + STRING_2 ) ; } if ( ! METHOD_2 ( VAR_1 ) ) { throw new TYPE_1 ( STRING_3 + VAR_1 + STRING_4 ) ; } <START> VAR_3 = TYPE_... | public void METHOD_1 ( Map < String , Object > parameters ) { super . METHOD_1 ( parameters ) ; if ( ( VAR_1 = ( String ) parameters . get ( VAR_2 ) ) == null ) { throw new TYPE_1 ( STRING_1 + VAR_2 + STRING_2 ) ; } if ( ! METHOD_2 ( VAR_1 ) ) { throw new TYPE_1 ( STRING_3 + VAR_1 + STRING_4 ) ; } LOGGER . log ( Level ... |
I purpose substring operations removed | public void METHOD_1 ( ) { TYPE_1 instance = TYPE_1 . getInstance ( ) ; String page = STRING_1 ; METHOD_2 ( instance . VAR_1 ( ) ) ; <START> instance . VAR_2 ( page . substring ( 5 ) ) ; <END> assertEquals ( page . substring ( 5 ) , instance . VAR_1 ( ) ) ; } | public void METHOD_1 ( ) { TYPE_1 instance = TYPE_1 . getInstance ( ) ; String page = STRING_1 ; METHOD_2 ( instance . VAR_1 ( ) ) ; instance . VAR_2 ( page ) ; assertEquals ( page , instance . VAR_1 ( ) ) ; } |
pls method signature a wrapper calls adjusted null argument | <START> TYPE_1 ( String name , String VAR_1 , long VAR_2 , int size , List < TYPE_1 > VAR_3 ) { <END> this . name = name ; this . VAR_1 = VAR_1 ; this . VAR_2 = VAR_2 ; this . size = size ; this . VAR_3 = VAR_3 ; } | private TYPE_1 ( String name , String VAR_1 , long VAR_2 , int size , List < TYPE_1 > VAR_3 ) { this ( ) ; this . name = name ; this . VAR_1 = VAR_1 ; this . VAR_2 = VAR_2 ; this . size = size ; this . VAR_3 = VAR_3 ; } |
synchronized present | <START> private synchronized boolean METHOD_1 ( TYPE_1 entity , TYPE_2 < TYPE_3 > VAR_1 ) { <END> VAR_2 . METHOD_2 ( ) . METHOD_3 ( ) ; try { return VAR_3 . METHOD_4 ( entity , VAR_1 ) ; } finally { VAR_2 . METHOD_2 ( ) . METHOD_5 ( ) ; } } | private boolean METHOD_1 ( TYPE_1 entity , TYPE_2 < TYPE_3 > VAR_1 ) { VAR_2 . METHOD_2 ( ) . METHOD_3 ( ) ; try { return VAR_3 . METHOD_4 ( entity , VAR_1 ) ; } finally { VAR_2 . METHOD_2 ( ) . METHOD_5 ( ) ; } } |
work 2 threads racing code val null read val null create new instance 1 count lost update map possibly synchronized cases needed | public void METHOD_1 ( TYPE_1 req , String VAR_1 ) { TYPE_2 val = VAR_2 . get ( VAR_1 ) ; if ( val == null ) { <START> val = new TYPE_2 ( 0 ) ; <END> } val . VAR_3 ( ) ; VAR_2 . put ( VAR_1 , val ) ; } | synchronized public void METHOD_1 ( TYPE_1 req , String VAR_1 ) { Long val = VAR_2 . get ( VAR_1 ) ; if ( val == null ) { val = new Long ( 0 ) ; } val += 1 ; VAR_2 . put ( VAR_1 , val ) ; } |
change container type finally changed List Set ( _CODE_ ) ultra speedup lookup ultra I significant single project container size app 700 I m event done times request | public static TYPE_1 METHOD_1 ( String name ) { TYPE_2 VAR_1 = TYPE_2 . getInstance ( ) ; if ( VAR_1 . METHOD_2 ( ) ) { for ( TYPE_1 VAR_2 : VAR_1 . METHOD_3 ( ) ) { <START> if ( name . equals ( VAR_2 . getName ( ) ) ) { <END> return ( VAR_2 ) ; } } } return null ; } | public static TYPE_1 METHOD_1 ( String name ) { TYPE_2 VAR_1 = TYPE_2 . getInstance ( ) ; if ( VAR_1 . METHOD_2 ( ) ) { TYPE_1 VAR_2 ; if ( ( VAR_2 = VAR_1 . METHOD_3 ( ) . get ( name ) ) != null ) { return ( VAR_2 ) ; } } return null ; } |
supertype Set | <START> public HashSet < TYPE_1 > METHOD_1 ( ) { <END> return VAR_1 ; } | public Map < String , TYPE_1 > METHOD_1 ( ) { return VAR_1 ; } |
supertype Set | <START> public HashSet < TYPE_1 > METHOD_1 ( ) { <END> return VAR_1 . get ( ) . METHOD_1 ( ) ; } | public Map < String , TYPE_1 > METHOD_1 ( ) { return VAR_1 . get ( ) . METHOD_1 ( ) ; } |
doesn t size method return number mappings ? I s necessary keySet | public boolean METHOD_1 ( ) { <START> Set < String > VAR_1 = METHOD_2 ( ) . keySet ( ) ; <END> return ( VAR_1 != null && ! VAR_1 . isEmpty ( ) ) ; } | public boolean METHOD_1 ( ) { return ( METHOD_2 ( ) . size ( ) > 0 ) ; } |
[ ] ( ) cast necessary | public void METHOD_1 ( Map < String , TYPE_1 > VAR_1 ) { <START> this . VAR_1 = ( HashMap < String , TYPE_1 > ) VAR_1 ; <END> } | public void METHOD_1 ( Map < String , TYPE_1 > VAR_1 ) { this . VAR_1 = VAR_1 ; } |
TYPE_1 a subclass IOException | <START> public void METHOD_1 ( File file ) throws IOException , TYPE_1 { <END> METHOD_2 ( TYPE_2 . read ( file ) ) ; } | public void METHOD_1 ( File file ) throws IOException { METHOD_2 ( TYPE_2 . read ( file ) ) ; } |
possibly shorter writejavaenv METHOD_2 ( METHOD_1 ( STRING_1 ) ) ; | public byte [ ] apply ( TYPE_1 VAR_1 ) throws IOException { <START> if ( METHOD_1 ( STRING_1 ) ) { <END> VAR_1 . METHOD_2 ( this , true ) ; } else { VAR_1 . METHOD_2 ( this , false ) ; } return null ; } | public byte [ ] apply ( TYPE_1 VAR_1 ) throws IOException { VAR_1 . METHOD_2 ( this , METHOD_1 ( STRING_1 ) ) ; return null ; } |
system VAR_3 a main program throw exception return a boolean check main program | public void METHOD_1 ( String VAR_1 ) { try { byte [ ] VAR_2 = TYPE_1 . METHOD_2 ( TYPE_2 . get ( VAR_1 ) ) ; this . text = new String ( VAR_2 ) ; } catch ( IOException ex ) { System . err . println ( STRING_1 + VAR_1 + STRING_2 + ex ) ; <START> System . VAR_3 ( 1 ) ; <END> } } | public void METHOD_1 ( String VAR_1 ) throws IOException { byte [ ] VAR_2 = TYPE_1 . METHOD_2 ( TYPE_2 . get ( VAR_1 ) ) ; this . text = new String ( VAR_2 ) ; } |
project ! = null check avoid substring operation | public static boolean METHOD_1 ( TYPE_1 project , String path ) { TYPE_2 VAR_1 = TYPE_2 . getInstance ( ) ; String VAR_2 = VAR_1 . METHOD_2 ( ) ; if ( path . startsWith ( VAR_2 ) ) { <START> if ( VAR_1 . METHOD_3 ( ) ) { <END> String VAR_3 = path . substring ( VAR_2 . length ( ) ) ; if ( project != null && project . eq... | public static boolean METHOD_1 ( TYPE_1 project , String path ) { TYPE_2 VAR_1 = TYPE_2 . getInstance ( ) ; String VAR_2 = VAR_1 . METHOD_2 ( ) ; if ( path . startsWith ( VAR_2 ) ) { if ( VAR_1 . METHOD_3 ( ) ) { if ( project != null && project . equals ( TYPE_1 . METHOD_4 ( path . substring ( VAR_2 . length ( ) ) ) ) ... |
knowledge : impact ? multiple time tag list | public void METHOD_1 ( final List < String > VAR_1 ) { <START> this . VAR_1 = VAR_1 != null ? TYPE_1 . METHOD_2 ( VAR_1 ) : null ; <END> } | public void METHOD_1 ( final List < String > VAR_1 ) { this . VAR_1 = VAR_1 != null ? TYPE_1 . METHOD_2 ( new ArrayList ( VAR_1 ) ) : null ; } |
avoid logic class inconsistent other collection fields t update field set null a tree set | public Set < String > METHOD_1 ( ) { <START> return VAR_1 != null ? new TYPE_1 < > ( VAR_1 ) : null ; <END> } | public Set < String > METHOD_1 ( ) { return VAR_1 ; } |
avoid logic class | public void METHOD_1 ( final Set < String > VAR_1 ) { <START> this . VAR_1 = VAR_1 != null ? new TYPE_1 < > ( VAR_1 ) : null ; <END> } | public void METHOD_1 ( final Set < String > VAR_1 ) { this . VAR_1 = VAR_1 ; } |
remove ( VAR_6 ) | private static TYPE_1 METHOD_1 ( ) { TYPE_1 VAR_1 = new TYPE_1 ( ) ; VAR_1 . METHOD_2 ( TYPE_3 . VAR_3 , false ) ; VAR_1 . METHOD_2 ( TYPE_6 . VAR_5 , false ) ; <START> VAR_1 . METHOD_2 ( TYPE_6 . VAR_6 , true ) ; <END> VAR_1 . METHOD_3 ( TYPE_4 . TYPE_5 . VAR_9 ) ; VAR_1 . METHOD_4 ( new TYPE_2 ( ) ) ; return VAR_1 ; ... | private static TYPE_1 METHOD_1 ( ) { TYPE_1 VAR_1 = new TYPE_1 ( ) ; VAR_1 . METHOD_2 ( TYPE_3 . VAR_3 , false ) ; VAR_1 . METHOD_2 ( TYPE_6 . VAR_5 , false ) ; VAR_1 . METHOD_3 ( TYPE_4 . TYPE_5 . VAR_9 ) ; VAR_1 . METHOD_4 ( new TYPE_2 ( ) ) ; return VAR_1 ; } |
timeout google recommends ? I apache HTTP a internal default 3 minutes timeout overridden apache s newer package version | static public TYPE_1 METHOD_1 ( String token ) { TYPE_2 VAR_1 = new TYPE_2 ( ) . METHOD_2 ( token ) ; return new TYPE_1 . Builder ( VAR_2 , VAR_3 , VAR_1 ) . METHOD_3 ( new TYPE_3 ( ) { @Override public void METHOD_4 ( TYPE_4 VAR_4 ) throws IOException { VAR_1 . METHOD_4 ( VAR_4 ) ; <START> VAR_4 . METHOD_5 ( INT_1 * I... | static public TYPE_1 METHOD_1 ( String token ) { TYPE_2 VAR_1 = new TYPE_2 ( ) . METHOD_2 ( token ) ; return new TYPE_1 . Builder ( VAR_2 , VAR_3 , VAR_1 ) . METHOD_3 ( new TYPE_3 ( ) { @Override public void METHOD_4 ( TYPE_4 VAR_4 ) throws IOException { VAR_1 . METHOD_4 ( VAR_4 ) ; VAR_4 . METHOD_5 ( 3 * INT_2 ) ; VAR... |
missing brace | static public TYPE_1 METHOD_1 ( String s ) { if ( s . VAR_1 ( STRING_1 ) ) { TYPE_2 VAR_2 = TYPE_2 . parse ( s ) ; return TYPE_1 . METHOD_2 ( VAR_2 , TYPE_3 . METHOD_3 ( ) ) ; <START> } else <END> return TYPE_1 . parse ( s , TYPE_4 . VAR_4 ) ; } | static public TYPE_1 METHOD_1 ( String s ) { if ( s . VAR_1 ( STRING_1 ) ) { TYPE_2 VAR_2 = TYPE_2 . parse ( s ) ; return TYPE_1 . METHOD_2 ( VAR_2 , TYPE_3 . METHOD_3 ( ) ) ; } else { return TYPE_1 . parse ( s , TYPE_4 . VAR_4 ) ; } } |
I understand key point TYPE_1 METHOD_4 method calling execptoin occurs assume date valid more specific exception type catched assumption - sense assuming generic exception occurs due date valid ( : leap days ) ? other Exception subtype catch block instead ? brainstorming asking : ) | private static boolean METHOD_1 ( final String value ) { List < String > VAR_1 = METHOD_2 ( value ) ; if ( ! VAR_1 . isEmpty ( ) ) { try { TYPE_1 TYPE_2 = TYPE_1 . METHOD_3 ( STRING_1 ) ; VAR_1 . forEach ( TYPE_2 : : METHOD_4 ) ; <START> } catch ( Exception e ) { <END> return false ; } } return true ; } | private static boolean METHOD_1 ( final String value ) { List < String > VAR_1 = METHOD_2 ( value ) ; if ( ! VAR_1 . isEmpty ( ) ) { try { TYPE_1 TYPE_2 = TYPE_1 . METHOD_3 ( STRING_1 ) ; VAR_1 . forEach ( TYPE_2 : : METHOD_4 ) ; } catch ( IllegalArgumentException e ) { return false ; } } return true ; } |
inlined a single return line | private static int METHOD_1 ( String string ) { int index = string . VAR_1 ( CHAR_1 ) ; <START> if ( index == - 1 ) { <END> return string . VAR_1 ( CHAR_2 ) ; } return index ; } | private static int METHOD_1 ( String string ) { int index = string . VAR_1 ( CHAR_1 ) ; return index == - 1 ? string . VAR_1 ( CHAR_2 ) : index ; } |
small suggestion investigate avoid a generic exception hard inspect happen METHOD_3 throw exception _CODE_ METHOD_4 throw some exception ( bcs skipped ) | protected String METHOD_1 ( final String name ) { final String VAR_1 = Optional . VAR_2 ( name ) . METHOD_2 ( "" ) ; try { final TYPE_1 VAR_3 = TYPE_2 . METHOD_3 ( VAR_1 ) ; if ( VAR_3 != null ) { return METHOD_4 ( VAR_1 , VAR_3 ) ; } <START> } catch ( Exception e ) { <END> LOGGER . VAR_4 ( STRING_1 + VAR_1 + STRING_2 ... | protected String METHOD_1 ( final String name ) { final String VAR_1 = Optional . VAR_2 ( name ) . METHOD_2 ( "" ) ; final TYPE_1 VAR_3 = TYPE_2 . METHOD_3 ( VAR_1 ) ; if ( VAR_3 != null ) { return METHOD_4 ( VAR_1 , VAR_3 ) ; } return METHOD_5 ( VAR_1 ) ; } |
I understood condition read great ! ! thanks a lot small I important long term easier maintan : + 1 : | public void METHOD_1 ( String value , boolean VAR_1 ) { String VAR_2 = VAR_3 ; VAR_3 = value ; <START> if ( VAR_3 . equals ( STRING_1 ) ) { <END> view . VAR_4 ( ) ; } else { view . VAR_5 ( VAR_3 ) ; } if ( VAR_1 ) { TYPE_1 . METHOD_2 ( this , VAR_2 , value ) ; } } | public void METHOD_1 ( String value , boolean VAR_1 ) { String VAR_2 = VAR_3 ; VAR_3 = value ; view . VAR_5 ( VAR_3 ) ; if ( VAR_1 ) { TYPE_1 . METHOD_2 ( this , VAR_2 , value ) ; } } |
private ? package protected access | <START> protected String METHOD_1 ( final String value ) { <END> return METHOD_1 ( VAR_1 , value ) ; } | private String METHOD_1 ( final String value ) { return METHOD_1 ( VAR_1 , value ) ; } |
private ? package protected access | <START> protected String METHOD_1 ( final String value ) { <END> if ( value == null || value . isEmpty ( ) || VAR_1 == null ) { return null ; } String VAR_2 ; if ( ! VAR_3 ) { VAR_2 = value . VAR_4 ( ) ; } else { VAR_2 = value ; } if ( VAR_1 . contains ( VAR_2 ) ) { return VAR_5 ; } else { return null ; } } | private String METHOD_1 ( final String value ) { if ( value == null || value . isEmpty ( ) || VAR_1 == null ) { return null ; } String VAR_2 ; if ( ! VAR_3 ) { VAR_2 = value . VAR_4 ( ) ; } else { VAR_2 = value ; } if ( VAR_1 . contains ( VAR_2 ) ) { return VAR_5 ; } else { return null ; } } |
method public doesn t sense arguments flush ( _CODE_ String ) method session ( editor ) a TYPE_1 instance set METHOD_1 please change package protected access ( access modifier set ) ? work / sense | <START> public void METHOD_1 ( TYPE_1 container ) { <END> this . container = container ; } | void METHOD_1 ( TYPE_1 container ) { this . container = container ; } |
private ( package protected ) ? s class | <START> public String getName ( ) { <END> if ( StringUtils . isEmpty ( name ) ) { this . name = METHOD_1 ( ) ; } return this . name ; } | private String getName ( ) { return this . name ; } |
fact need ! ? s class test test constructs instance | <START> public Optional < TYPE_1 > METHOD_1 ( ) { <END> return VAR_1 ; } | Optional < TYPE_1 > METHOD_1 ( ) { return VAR_1 ; } |
appply KIE style formatting | public TYPE_1 METHOD_1 ( ) { METHOD_2 ( ) ; VAR_1 . METHOD_1 ( ) ; <START> if ( VAR_2 ) { <END> VAR_2 = false ; METHOD_3 ( ) ; } return this ; } | public TYPE_1 METHOD_1 ( ) { if ( VAR_2 ) { VAR_2 = false ; } else { METHOD_2 ( ) ; VAR_1 . METHOD_1 ( ) ; } return this ; } |
VAR_1 METHOD_3 ( ) returns null | public static TYPE_1 METHOD_1 ( final TYPE_2 VAR_1 ) { if ( TYPE_3 . METHOD_2 ( VAR_1 ) ) { return null ; } else if ( StringUtils . isEmpty ( VAR_1 . METHOD_3 ( ) . getValue ( ) ) ) { return null ; <START> } <END> return TYPE_4 . METHOD_1 ( VAR_1 ) ; } | public static TYPE_1 METHOD_1 ( final TYPE_2 VAR_1 ) { if ( TYPE_3 . METHOD_2 ( VAR_1 ) ) { return null ; } else if ( TYPE_3 . METHOD_2 ( VAR_1 . METHOD_3 ( ) ) ) { return null ; } else if ( StringUtils . isEmpty ( VAR_1 . METHOD_3 ( ) . getValue ( ) ) ) { return null ; } return TYPE_4 . METHOD_1 ( VAR_1 ) ; } |
don t need METHOD_2 ( ) ve ed | public void METHOD_1 ( ) { <START> VAR_1 = METHOD_2 ( TYPE_1 . class ) ; <END> final TYPE_2 VAR_2 = METHOD_3 ( new TYPE_2 ( builder , VAR_3 , VAR_1 ) ) ; final TYPE_3 VAR_4 = METHOD_2 ( TYPE_3 . class ) ; METHOD_4 ( ) . when ( VAR_2 ) . METHOD_5 ( METHOD_6 ( ) ) ; METHOD_7 ( VAR_4 ) . when ( VAR_2 ) . METHOD_8 ( ) ; VA... | public void METHOD_1 ( ) { final TYPE_2 VAR_2 = METHOD_3 ( new TYPE_2 ( builder , VAR_3 , VAR_1 ) ) ; final TYPE_3 VAR_4 = METHOD_2 ( TYPE_3 . class ) ; METHOD_4 ( ) . when ( VAR_2 ) . METHOD_5 ( METHOD_6 ( ) ) ; METHOD_7 ( VAR_4 ) . when ( VAR_2 ) . METHOD_8 ( ) ; VAR_2 . METHOD_9 ( VAR_5 ) ; METHOD_10 ( VAR_2 ) . MET... |
streams result more readable | public static TYPE_3 . TYPE_4 < List < String > , Object > METHOD_1 ( List < String > VAR_1 , TYPE_2 VAR_2 ) { return VAR_3 - > { List < String > VAR_4 = new ArrayList < > ( VAR_1 ) ; <START> for ( String type : VAR_3 ) { <END> String VAR_5 = METHOD_2 ( type ) ; METHOD_3 ( ) . put ( VAR_5 , type ) ; VAR_4 . add ( VAR_5... | static TYPE_3 . TYPE_4 < List < String > , Object > METHOD_1 ( List < String > VAR_1 , TYPE_2 VAR_2 ) { return VAR_3 - > { List < String > VAR_4 = new ArrayList < > ( VAR_1 ) ; for ( String type : VAR_3 ) { String VAR_5 = METHOD_2 ( type ) ; METHOD_3 ( ) . put ( VAR_5 , type ) ; VAR_4 . add ( VAR_5 ) ; } VAR_2 . METHOD... |
suggestionif ( VAR_1 ! = VAR_1 ) { | public boolean equals ( final Object o ) { if ( this == o ) { return true ; } if ( ! ( o instanceof TYPE_1 ) ) { return false ; } final TYPE_1 that = ( TYPE_1 ) o ; if ( ! context . equals ( that . context ) ) { return false ; } <START> if ( ! VAR_1 == that . VAR_1 ) { <END> return false ; } return path . equals ( that... | public boolean equals ( final Object o ) { if ( this == o ) { return true ; } if ( ! ( o instanceof TYPE_1 ) ) { return false ; } final TYPE_1 that = ( TYPE_1 ) o ; if ( ! context . equals ( that . context ) ) { return false ; } return path . equals ( that . path ) ; } |
I fine want javafor ( final TYPE_3 element : VAR_2 ) { TYPE_2 METHOD_3 ( element + + VAR_3 ) ; } | public void METHOD_1 ( final TYPE_1 VAR_1 , final List < TYPE_1 > VAR_2 ) { Integer VAR_3 = TYPE_2 . METHOD_2 ( VAR_1 ) ; <START> for ( final TYPE_3 element : VAR_2 ) { VAR_3 ++ ; TYPE_2 . METHOD_3 ( element , VAR_3 ) ; <END> } } | public void METHOD_1 ( final TYPE_1 VAR_1 , final List < TYPE_1 > VAR_2 ) { Integer VAR_3 = TYPE_2 . METHOD_2 ( VAR_1 ) ; for ( final TYPE_3 element : VAR_2 ) { TYPE_2 . METHOD_3 ( element , ++ VAR_3 ) ; } } |
formatting | <START> public void METHOD_1 ( ) { <END> final String VAR_1 = STRING_1 ; final TYPE_1 VAR_2 = METHOD_2 ( TYPE_1 . class ) ; final Optional < TYPE_1 > type = Optional . of ( VAR_2 ) ; METHOD_3 ( type ) . when ( VAR_3 ) . METHOD_4 ( VAR_1 ) ; final TYPE_1 VAR_4 = VAR_3 . METHOD_5 ( VAR_1 ) ; assertEquals ( VAR_2 , VAR_4 ... | public void METHOD_1 ( ) { final String VAR_1 = STRING_1 ; final TYPE_1 VAR_2 = METHOD_2 ( TYPE_1 . class ) ; final Optional < TYPE_1 > type = Optional . of ( VAR_2 ) ; METHOD_3 ( type ) . when ( VAR_3 ) . METHOD_4 ( VAR_1 ) ; final Optional < TYPE_1 > VAR_4 = VAR_3 . METHOD_5 ( VAR_1 ) ; assertTrue ( VAR_4 . isPresent... |
please assertj assertion case fail error message explaining list sizes current implementation print assertion error expected true false reference list size | public void METHOD_1 ( ) { <START> assertTrue ( VAR_1 . METHOD_2 ( null ) . isEmpty ( ) ) ; <END> } | public void METHOD_1 ( ) { assertThat ( VAR_1 . METHOD_2 ( null ) ) . isEmpty ( ) ; } |
I understand need method please clarify | public void METHOD_1 ( ) { final TYPE_1 VAR_1 = METHOD_2 ( TYPE_1 . class ) ; <START> VAR_2 . METHOD_3 ( false ) ; <END> METHOD_4 ( VAR_1 ) . when ( VAR_2 ) . METHOD_5 ( ) ; VAR_2 . METHOD_6 ( ) ; METHOD_7 ( VAR_3 ) . remove ( VAR_1 ) ; } | public void METHOD_1 ( ) { final TYPE_1 VAR_1 = METHOD_2 ( TYPE_1 . class ) ; METHOD_4 ( VAR_1 ) . when ( VAR_2 ) . METHOD_5 ( ) ; VAR_2 . METHOD_6 ( ) ; METHOD_7 ( VAR_3 ) . remove ( VAR_1 ) ; } |
t Collections _CODE_ ( ) asking knwo troubles return - modifiable list | private static TYPE_4 . TYPE_5 METHOD_1 ( final TYPE_2 target ) { TYPE_4 . TYPE_5 VAR_1 = target . VAR_2 ( ) == null ? new TYPE_4 . TYPE_5 ( ) : target . VAR_2 ( ) ; if ( ! TYPE_3 . METHOD_2 ( VAR_1 ) && TYPE_3 . METHOD_2 ( VAR_1 . METHOD_3 ( ) ) ) { <START> VAR_1 . METHOD_4 ( new ArrayList < > ( ) ) ; <END> } return V... | private static TYPE_4 . TYPE_5 METHOD_1 ( final TYPE_2 target ) { TYPE_4 . TYPE_5 VAR_1 = TYPE_3 . METHOD_2 ( target . VAR_2 ( ) ) ? new TYPE_4 . TYPE_5 ( ) : target . VAR_2 ( ) ; if ( ! TYPE_3 . METHOD_2 ( VAR_1 ) && TYPE_3 . METHOD_2 ( VAR_1 . METHOD_3 ( ) ) ) { VAR_1 . METHOD_4 ( new ArrayList < > ( ) ) ; } return V... |
TYPE_1 class managed exclusively class possibility override behavior I suggest put private visibility method choice | <START> TYPE_1 METHOD_1 ( ) { <END> return TYPE_1 . create ( VAR_1 ) ; } | protected TYPE_1 METHOD_1 ( ) { return TYPE_1 . create ( VAR_1 ) ; } |
throws Exception necessary | <START> public void METHOD_1 ( ) throws Exception { <END> VAR_1 = new TYPE_1 ( VAR_2 ) { @Override public Object METHOD_2 ( final String VAR_3 ) { return VAR_4 ; } } ; VAR_1 . METHOD_1 ( VAR_5 ) ; METHOD_3 ( VAR_5 ) . METHOD_4 ( VAR_6 . METHOD_5 ( ) ) ; } | public void METHOD_1 ( ) { VAR_1 = new TYPE_1 ( VAR_2 ) { @Override public Object METHOD_2 ( final String VAR_3 ) { return VAR_4 ; } } ; VAR_1 . METHOD_1 ( VAR_5 ) ; METHOD_3 ( VAR_5 ) . METHOD_4 ( VAR_6 . METHOD_5 ( ) ) ; } |
throws Exception necessary | <START> public void METHOD_1 ( ) throws <END> Exception { VAR_1 = METHOD_2 ( new TYPE_1 ( VAR_2 , STRING_1 , VAR_3 , VAR_4 ) { @Override TYPE_2 METHOD_3 ( ) { return VAR_5 ; } } ) ; } | public void METHOD_1 ( ) { VAR_1 = METHOD_2 ( new TYPE_1 ( VAR_2 , STRING_1 , VAR_3 , VAR_4 ) { @Override protected TYPE_2 METHOD_3 ( ) { return VAR_5 ; } } ) ; } |
suggestionfinal boolean VAR_1 = false ; | public void METHOD_1 ( ) { <START> boolean VAR_1 = false ; <END> view . VAR_2 ( VAR_1 ) ; METHOD_2 ( VAR_3 ) . METHOD_3 ( VAR_1 ) ; } | public void METHOD_1 ( ) { final boolean VAR_1 = false ; view . VAR_2 ( VAR_1 ) ; METHOD_2 ( VAR_3 ) . METHOD_3 ( VAR_1 ) ; } |
variable misleading VAR_2 ! TYPE_1 equals ( VAR_1 VAR_3 ) | public void METHOD_1 ( final String VAR_1 ) { <START> final boolean VAR_2 = TYPE_1 . equals ( VAR_1 , VAR_3 ) ; <END> final Optional < TYPE_2 < T > > result ; if ( VAR_2 ) { result = METHOD_2 ( VAR_1 ) ; } else { result = METHOD_3 ( VAR_1 ) ; } VAR_4 = result . VAR_5 ( VAR_4 ) ; VAR_3 = VAR_1 ; METHOD_4 ( ) ; } | public void METHOD_1 ( final String VAR_1 ) { final boolean VAR_2 = ! TYPE_1 . equals ( VAR_1 , VAR_3 ) ; final Optional < TYPE_2 < T > > result ; if ( VAR_2 ) { result = METHOD_3 ( VAR_1 ) ; } else { result = METHOD_2 ( VAR_1 ) ; } VAR_4 = result . VAR_5 ( null ) ; VAR_3 = VAR_1 ; METHOD_4 ( ) ; } |
javaif ( o instanceof TYPE_1 ) { TYPE_1 = ( TYPE_1 ) o ; return TYPE_2 equals ( ) ; } return false ; instanceof operator check null | public boolean equals ( Object o ) { if ( this == o ) { return true ; } <START> if ( o == null || getClass ( ) != o . getClass ( ) ) { <END> return false ; } TYPE_1 that = ( TYPE_1 ) o ; return TYPE_2 . equals ( value , that . value ) ; } | public boolean equals ( Object o ) { if ( this == o ) { return true ; } if ( o instanceof TYPE_1 ) { TYPE_1 that = ( TYPE_1 ) o ; return TYPE_2 . equals ( value , that . value ) ; } return false ; } |
acquire _lock_ icon editor title project explorer ? personally I d prefer _behaviour_ presenter ( dumb ) View delete consumer METHOD_2 event close ( IIRC _consumer_ a View physical delete firing event place WDYT | public void METHOD_1 ( final TYPE_1 VAR_1 ) { <START> VAR_2 . METHOD_2 ( new TYPE_2 ( ) ) ; <END> if ( ! TYPE_3 . METHOD_3 ( METHOD_4 ( ) ) ) { METHOD_4 ( ) . METHOD_5 ( VAR_3 ) ; } } | public void METHOD_1 ( final TYPE_1 VAR_1 ) { if ( ! TYPE_3 . METHOD_3 ( METHOD_4 ( ) ) ) { METHOD_4 ( ) . METHOD_5 ( VAR_3 ) ; } } |
assertEquals express expected | public void METHOD_1 ( ) { TYPE_1 a = new TYPE_1 ( new TYPE_2 ( ) , new TYPE_3 ( VAR_1 ) ) ; <START> Assert . assertTrue ( a . VAR_2 ( ) . getValue ( ) . equals ( VAR_1 ) ) ; <END> } | public void METHOD_1 ( ) { TYPE_1 a = new TYPE_1 ( new TYPE_2 ( ) , new TYPE_3 ( VAR_1 ) ) ; assertEquals ( VAR_1 , a . VAR_2 ( ) . getValue ( ) ) ; } |
VAR_1 METHOD_1 ( ) ; | private Object [ ] METHOD_1 ( List < ? > VAR_1 ) { <START> return VAR_1 . stream ( ) . METHOD_1 ( Object [ ] : : new ) ; <END> } | private Object [ ] METHOD_1 ( List < ? > VAR_1 ) { return VAR_1 . METHOD_1 ( new Object [ 0 ] ) ; } |
optional present check access | public TYPE_1 METHOD_1 ( TYPE_2 metadata , TYPE_3 input ) throws IOException { TYPE_4 < TYPE_1 > VAR_1 = METHOD_2 ( TYPE_5 . builder ( ) . metadata ( metadata ) . input ( input ) . METHOD_3 ( TYPE_5 . TYPE_6 . VAR_3 ) . build ( ) ) ; <START> return VAR_1 . METHOD_4 ( ) . get ( ) ; <END> } | public TYPE_1 METHOD_1 ( TYPE_2 metadata , TYPE_3 input ) { TYPE_4 < TYPE_1 > VAR_1 = METHOD_2 ( TYPE_5 . builder ( ) . metadata ( metadata ) . input ( input ) . METHOD_3 ( TYPE_5 . TYPE_6 . VAR_3 ) . build ( ) ) ; return VAR_1 . METHOD_4 ( ) ; } |
method reference instead o getId ( ) | public static < T extends TYPE_1 > TYPE_2 < T > METHOD_1 ( ) { return TYPE_2 . of ( o - > Optional . VAR_1 ( o . getName ( ) ) <START> . METHOD_2 ( ( ) - > o . getId ( ) ) , <END> VAR_2 - > VAR_2 . getClass ( ) . METHOD_3 ( ) ) ; } | public static < T extends TYPE_1 > TYPE_2 < T > METHOD_1 ( ) { return TYPE_2 . of ( o - > Optional . VAR_1 ( o . getName ( ) ) . METHOD_2 ( o : : getId ) , VAR_2 - > VAR_2 . getClass ( ) . METHOD_3 ( ) ) ; } |
I a null returned question affect callers method a null es returned callers method fail returning a NPE exception thrown expected variable XXX | <START> private TYPE_1 METHOD_1 ( String id ) { <END> return VAR_1 . METHOD_2 ( id ) . map ( TYPE_3 . TYPE_4 : : METHOD_3 ) . METHOD_4 ( null ) ; } | private Optional < TYPE_1 > METHOD_1 ( String id ) { return VAR_1 . METHOD_2 ( id ) . map ( TYPE_3 . TYPE_4 : : METHOD_3 ) ; } |
final | String METHOD_1 ( final TYPE_1 VAR_1 ) { <START> TYPE_2 metadata = VAR_1 . METHOD_2 ( ) ; <END> final Optional < Path > path = Optional . VAR_2 ( metadata . getPath ( ) ) ; return path . map ( Path : : METHOD_1 ) . METHOD_3 ( VAR_3 . format ( TYPE_3 ) ) ; } | String METHOD_1 ( final TYPE_1 VAR_1 ) { final TYPE_2 metadata = VAR_1 . METHOD_2 ( ) ; final Optional < Path > path = Optional . VAR_2 ( metadata . getPath ( ) ) ; return path . map ( Path : : METHOD_1 ) . METHOD_3 ( VAR_3 . format ( TYPE_3 ) ) ; } |
_CODE_ ( VAR_5 METHOD_8 ( ) VAR_9 VAR_10 VAR_9 ) ; | public void METHOD_1 ( ) throws Exception { TYPE_1 < TYPE_2 , TYPE_3 > VAR_1 = METHOD_2 ( VAR_2 , VAR_3 ) ; METHOD_3 ( VAR_1 , VAR_4 ) ; TYPE_4 VAR_5 = METHOD_4 ( VAR_1 , VAR_6 , VAR_7 , VAR_8 ) ; METHOD_5 ( VAR_5 . METHOD_6 ( ) , VAR_9 , VAR_9 ) ; <START> METHOD_7 ( VAR_5 . METHOD_8 ( ) , VAR_9 , VAR_10 , "" ) ; <END>... | public void METHOD_1 ( ) throws Exception { TYPE_1 < TYPE_2 , TYPE_3 > VAR_1 = METHOD_2 ( VAR_2 , VAR_3 ) ; METHOD_3 ( VAR_1 , VAR_4 ) ; TYPE_4 VAR_5 = METHOD_4 ( VAR_1 , VAR_6 , VAR_7 , VAR_8 ) ; METHOD_5 ( VAR_5 . METHOD_6 ( ) , VAR_9 , VAR_9 ) ; METHOD_7 ( VAR_5 . METHOD_8 ( ) , VAR_9 , VAR_10 , VAR_9 ) ; METHOD_9 (... |
_CODE_ ( VAR_5 METHOD_8 ( ) VAR_10 VAR_9 ) ; | public void METHOD_1 ( ) throws Exception { TYPE_1 < TYPE_2 , TYPE_3 > VAR_1 = METHOD_2 ( VAR_2 , VAR_3 ) ; METHOD_3 ( VAR_1 , VAR_4 ) ; TYPE_4 VAR_5 = METHOD_4 ( VAR_1 , VAR_6 , VAR_7 , VAR_8 ) ; METHOD_5 ( VAR_5 . METHOD_6 ( ) , VAR_9 , VAR_9 ) ; <START> METHOD_7 ( VAR_5 . METHOD_8 ( ) , VAR_10 , "" ) ; <END> } | public void METHOD_1 ( ) throws Exception { TYPE_1 < TYPE_2 , TYPE_3 > VAR_1 = METHOD_2 ( VAR_2 , VAR_3 ) ; METHOD_3 ( VAR_1 , VAR_4 ) ; TYPE_4 VAR_5 = METHOD_4 ( VAR_1 , VAR_6 , VAR_7 , VAR_8 ) ; METHOD_5 ( VAR_5 . METHOD_6 ( ) , VAR_9 , VAR_9 ) ; METHOD_7 ( VAR_5 . METHOD_8 ( ) , VAR_10 , VAR_9 ) ; } |
suggestionempty_value ) ; | public void METHOD_1 ( ) throws Exception { TYPE_1 < TYPE_2 , TYPE_3 > VAR_1 = METHOD_2 ( VAR_2 , VAR_3 ) ; METHOD_3 ( VAR_1 , VAR_4 ) ; TYPE_4 VAR_5 = METHOD_4 ( VAR_1 , VAR_6 , VAR_7 , VAR_8 ) ; METHOD_5 ( VAR_5 . METHOD_6 ( ) , VAR_9 , VAR_9 ) ; METHOD_7 ( VAR_5 . METHOD_8 ( ) , VAR_10 , VAR_11 , VAR_12 , VAR_13 , <... | public void METHOD_1 ( ) throws Exception { TYPE_1 < TYPE_2 , TYPE_3 > VAR_1 = METHOD_2 ( VAR_2 , VAR_3 ) ; METHOD_3 ( VAR_1 , VAR_4 ) ; TYPE_4 VAR_5 = METHOD_4 ( VAR_1 , VAR_6 , VAR_7 , VAR_8 ) ; METHOD_5 ( VAR_5 . METHOD_6 ( ) , VAR_9 , VAR_9 ) ; METHOD_7 ( VAR_5 . METHOD_8 ( ) , VAR_10 , VAR_11 , VAR_12 , VAR_13 , V... |
a VAR_3 ( o - > METHOD_3 ( VAR_1 ) ) ; | public Collection < TYPE_1 > METHOD_1 ( final String VAR_1 , final Object VAR_2 ) { <START> final TYPE_2 VAR_3 = o - > METHOD_2 ( VAR_1 ) && METHOD_3 ( VAR_1 ) ; <END> final TYPE_1 VAR_4 = new TYPE_1 ( STRING_1 , VAR_3 ) ; return Collections . VAR_5 ( VAR_4 ) ; } | public Collection < TYPE_1 > METHOD_1 ( final String VAR_1 , final Object VAR_2 ) { TYPE_2 VAR_3 = o - > METHOD_2 ( VAR_1 ) ; VAR_3 = VAR_3 . and ( o - > METHOD_3 ( VAR_1 ) ) ; final TYPE_1 VAR_4 = new TYPE_1 ( STRING_1 , VAR_3 ) ; return Collections . VAR_5 ( VAR_4 ) ; } |
Exception thrown | <START> public void METHOD_1 ( ) throws Exception { <END> final TYPE_1 VAR_1 = METHOD_2 ( TYPE_1 . class ) ; when ( VAR_1 . METHOD_3 ( ) ) . METHOD_4 ( child ) ; when ( parent . VAR_2 ( ) ) . METHOD_4 ( Collections . VAR_3 ( VAR_1 ) ) ; assertEquals ( 0 , TYPE_2 . METHOD_5 ( parent , child ) ) ; } | public void METHOD_1 ( ) { final TYPE_1 VAR_1 = METHOD_2 ( TYPE_1 . class ) ; when ( VAR_1 . METHOD_3 ( ) ) . METHOD_4 ( child ) ; when ( parent . VAR_2 ( ) ) . METHOD_4 ( Collections . VAR_3 ( VAR_1 ) ) ; assertEquals ( 0 , TYPE_2 . METHOD_5 ( parent , child ) ) ; } |
Exception thrown please more descriptive test method | <START> public void METHOD_1 ( ) throws Exception { <END> METHOD_2 ( ) ; assertTrue ( TYPE_1 . METHOD_3 ( child ) ) ; } | public void METHOD_1 ( ) { METHOD_2 ( ) ; assertTrue ( TYPE_1 . METHOD_3 ( child ) ) ; } |
Exception thrown | <START> public void METHOD_1 ( ) throws Exception { <END> final TYPE_1 < TYPE_2 > VAR_1 = TYPE_3 . METHOD_2 ( ) ; final TYPE_2 VAR_2 = METHOD_3 ( TYPE_2 . class ) ; when ( VAR_2 . METHOD_4 ( ) ) . METHOD_5 ( METHOD_3 ( TYPE_4 . class ) ) ; assertTrue ( VAR_1 . METHOD_6 ( VAR_2 ) ) ; } | public void METHOD_1 ( ) { final TYPE_1 < TYPE_2 > VAR_1 = TYPE_3 . METHOD_2 ( ) ; final TYPE_2 VAR_2 = METHOD_3 ( TYPE_2 . class ) ; when ( VAR_2 . METHOD_4 ( ) ) . METHOD_5 ( METHOD_3 ( TYPE_4 . class ) ) ; assertTrue ( VAR_1 . METHOD_6 ( VAR_2 ) ) ; } |
Exception thrown | <START> public void METHOD_1 ( ) throws Exception { <END> String id = TYPE_1 . METHOD_2 ( ) . toString ( ) ; TYPE_2 VAR_1 = VAR_2 . METHOD_3 ( ) ; VAR_1 . METHOD_4 ( id ) ; TYPE_4 . VAR_4 . of ( VAR_1 ) . set ( Boolean . VAR_5 ) ; VAR_6 = new TYPE_3 ( VAR_1 , VAR_7 . METHOD_5 ( ) , VAR_7 ) ; METHOD_6 ( VAR_6 . METHOD_7... | public void METHOD_1 ( ) { String id = TYPE_1 . METHOD_2 ( ) . toString ( ) ; TYPE_2 VAR_1 = VAR_2 . METHOD_3 ( ) ; VAR_1 . METHOD_4 ( id ) ; TYPE_4 . VAR_4 . of ( VAR_1 ) . set ( Boolean . VAR_5 ) ; VAR_6 = new TYPE_3 ( VAR_1 , VAR_7 . METHOD_5 ( ) , VAR_7 ) ; METHOD_6 ( VAR_6 . METHOD_7 ( ) ) ; } |
Exception thrown | <START> public void METHOD_1 ( ) throws Exception { <END> METHOD_2 ( TYPE_1 . class , TYPE_2 . class , false ) ; } | public void METHOD_1 ( ) { METHOD_2 ( TYPE_1 . class , TYPE_2 . class , false ) ; } |
Exception thrown | <START> public void METHOD_1 ( ) throws Exception { <END> VAR_1 = new TYPE_1 ( VAR_2 , VAR_3 ) ; } | public void METHOD_1 ( ) { VAR_1 = new TYPE_1 ( VAR_2 , VAR_3 ) ; } |
Exception thrown | <START> public void METHOD_1 ( ) throws Exception { <END> final TYPE_1 VAR_1 = METHOD_2 ( TYPE_1 . class ) ; VAR_2 . METHOD_3 ( VAR_1 ) ; METHOD_4 ( VAR_3 , METHOD_5 ( 1 ) ) . METHOD_6 ( ) ; METHOD_4 ( VAR_3 , METHOD_5 ( 1 ) ) . METHOD_7 ( METHOD_8 ( VAR_1 ) , METHOD_9 ( TYPE_3 . TYPE_4 . class ) ) ; } | public void METHOD_1 ( ) { final TYPE_1 VAR_1 = METHOD_2 ( TYPE_1 . class ) ; VAR_2 . METHOD_3 ( VAR_1 ) ; METHOD_4 ( VAR_3 , METHOD_5 ( 1 ) ) . METHOD_6 ( ) ; METHOD_4 ( VAR_3 , METHOD_5 ( 1 ) ) . METHOD_7 ( METHOD_8 ( VAR_1 ) , METHOD_9 ( TYPE_3 . TYPE_4 . class ) ) ; } |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.