ReviewComments stringlengths 1 2.35k | OriginalCode stringlengths 28 487 | ReviewedCode stringlengths 14 463 |
|---|---|---|
Exception thrown | <START> public void METHOD_1 ( ) throws Exception { <END> VAR_1 = new TYPE_1 ( STRING_1 , STRING_2 , VAR_2 , STRING_3 , STRING_4 , VAR_3 ) ; } | public void METHOD_1 ( ) { VAR_1 = new TYPE_1 ( STRING_1 , STRING_2 , VAR_2 , STRING_3 , STRING_4 , VAR_3 ) ; } |
I message _CODE_ ? general method logging I t | default void VAR_1 ( final TYPE_1 error ) { <START> warn ( STRING_1 ) ; <END> warn ( error . getMessage ( ) ) ; } | default void VAR_1 ( final TYPE_1 error ) { warn ( error . getMessage ( ) ) ; } |
consistency please final boolean VAR_3 | public void METHOD_1 ( ) { when ( VAR_1 . getId ( ) ) . METHOD_2 ( VAR_2 . getClass ( ) . getName ( ) ) ; <START> boolean VAR_3 = VAR_4 . METHOD_3 ( VAR_1 , context ) ; <END> assertTrue ( VAR_3 ) ; } | public void METHOD_1 ( ) { when ( VAR_1 . getId ( ) ) . METHOD_2 ( VAR_2 . getClass ( ) . getName ( ) ) ; final boolean VAR_3 = VAR_4 . METHOD_3 ( VAR_1 , context ) ; assertTrue ( VAR_3 ) ; } |
consistency please final boolean VAR_2 | public void METHOD_1 ( ) { when ( VAR_1 . getId ( ) ) . METHOD_2 ( STRING_1 ) ; <START> boolean VAR_2 = VAR_3 . METHOD_3 ( VAR_1 , context ) ; <END> METHOD_4 ( VAR_2 ) ; } | public void METHOD_1 ( ) { when ( VAR_1 . getId ( ) ) . METHOD_2 ( STRING_1 ) ; final boolean VAR_2 = VAR_3 . METHOD_3 ( VAR_1 , context ) ; METHOD_4 ( VAR_2 ) ; } |
suggestionempty_value ) ; | public void METHOD_1 ( ) throws Exception { TYPE_1 < TYPE_2 , TYPE_3 > VAR_1 = METHOD_2 ( VAR_2 , VAR_3 ) ; METHOD_3 ( VAR_1 , VAR_4 ) ; TYPE_4 VAR_5 = METHOD_4 ( VAR_1 , VAR_6 , TYPE_4 . class ) ; METHOD_5 ( VAR_5 . METHOD_6 ( ) , VAR_7 , VAR_7 ) ; METHOD_7 ( VAR_5 . METHOD_8 ( ) , VAR_8 , VAR_9 , VAR_10 , VAR_11 , <S... | public void METHOD_1 ( ) throws Exception { TYPE_1 < TYPE_2 , TYPE_3 > VAR_1 = METHOD_2 ( VAR_2 , VAR_3 ) ; METHOD_3 ( VAR_1 , VAR_4 ) ; TYPE_4 VAR_5 = METHOD_4 ( VAR_1 , VAR_6 , TYPE_4 . class ) ; METHOD_5 ( VAR_5 . METHOD_6 ( ) , VAR_7 , VAR_7 ) ; METHOD_7 ( VAR_5 . METHOD_8 ( ) , VAR_8 , VAR_9 , VAR_10 , VAR_11 , VA... |
_CODE_ ( VAR_5 METHOD_9 ( ) VAR_7 VAR_8 VAR_7 ) ; | public void METHOD_1 ( ) throws Exception { TYPE_1 < TYPE_2 , TYPE_3 > VAR_1 = METHOD_2 ( VAR_2 , VAR_3 ) ; METHOD_3 ( VAR_1 , VAR_4 ) ; TYPE_4 VAR_5 = METHOD_4 ( VAR_1 , VAR_6 , METHOD_5 ( ) ) ; METHOD_6 ( VAR_5 . METHOD_7 ( ) , VAR_7 , VAR_7 ) ; <START> METHOD_8 ( VAR_5 . METHOD_9 ( ) , VAR_7 , VAR_8 , "" ) ; <END> M... | public void METHOD_1 ( ) throws Exception { TYPE_1 < TYPE_2 , TYPE_3 > VAR_1 = METHOD_2 ( VAR_2 , VAR_3 ) ; METHOD_3 ( VAR_1 , VAR_4 ) ; TYPE_4 VAR_5 = METHOD_4 ( VAR_1 , VAR_6 , METHOD_5 ( ) ) ; METHOD_6 ( VAR_5 . METHOD_7 ( ) , VAR_7 , VAR_7 ) ; METHOD_8 ( VAR_5 . METHOD_9 ( ) , VAR_7 , VAR_8 , VAR_7 ) ; METHOD_10 ( ... |
_CODE_ ( VAR_5 METHOD_8 ( ) VAR_7 VAR_8 VAR_7 ) ; | public void METHOD_1 ( ) throws Exception { TYPE_1 < TYPE_2 , TYPE_3 > VAR_1 = METHOD_2 ( VAR_2 , VAR_3 ) ; METHOD_3 ( VAR_1 , VAR_4 ) ; TYPE_4 VAR_5 = METHOD_4 ( VAR_1 , VAR_6 , TYPE_4 . class ) ; METHOD_5 ( VAR_5 . METHOD_6 ( ) , VAR_7 , VAR_7 ) ; <START> METHOD_7 ( VAR_5 . METHOD_8 ( ) , VAR_7 , VAR_8 , "" ) ; <END>... | public void METHOD_1 ( ) throws Exception { TYPE_1 < TYPE_2 , TYPE_3 > VAR_1 = METHOD_2 ( VAR_2 , VAR_3 ) ; METHOD_3 ( VAR_1 , VAR_4 ) ; TYPE_4 VAR_5 = METHOD_4 ( VAR_1 , VAR_6 , TYPE_4 . class ) ; METHOD_5 ( VAR_5 . METHOD_6 ( ) , VAR_7 , VAR_7 ) ; METHOD_7 ( VAR_5 . METHOD_8 ( ) , VAR_7 , VAR_8 , VAR_7 ) ; METHOD_9 (... |
missing assertNotNull _CODE_ | <START> public void METHOD_1 ( ) throws Exception { <END> final String VAR_1 = STRING_1 ; final String VAR_2 = STRING_2 ; TYPE_1 < TYPE_2 , TYPE_3 > VAR_3 = METHOD_2 ( VAR_4 , VAR_5 ) ; METHOD_3 ( VAR_3 , VAR_6 ) ; TYPE_4 VAR_7 = METHOD_4 ( VAR_3 , VAR_8 , TYPE_4 . class ) ; METHOD_5 ( VAR_7 . METHOD_6 ( ) , VAR_1 , VA... | public void METHOD_1 ( ) throws Exception { final String VAR_1 = STRING_1 ; final String VAR_2 = STRING_2 ; TYPE_1 < TYPE_2 , TYPE_3 > VAR_3 = METHOD_2 ( VAR_4 , VAR_5 ) ; METHOD_3 ( VAR_3 , VAR_6 ) ; TYPE_4 VAR_7 = METHOD_4 ( VAR_3 , VAR_8 , TYPE_4 . class ) ; METHOD_5 ( VAR_7 . METHOD_6 ( ) , VAR_1 , VAR_2 ) ; assert... |
consistency need keyword getter _CODE_ | public TYPE_1 METHOD_1 ( ) { <START> return this . item ; <END> } | public TYPE_1 METHOD_1 ( ) { return item ; } |
reading [ ] ( ) I map instead METHOD_2 I miss | private List < TYPE_1 > METHOD_1 ( final List < TYPE_1 > VAR_1 , final String VAR_2 ) { return VAR_1 . stream ( ) <START> . METHOD_2 ( VAR_3 - > METHOD_3 ( VAR_3 , VAR_2 ) ) <END> . collect ( Collectors . VAR_4 ( ) ) ; } | private List < TYPE_1 > METHOD_1 ( final List < TYPE_1 > VAR_1 , final String VAR_2 ) { return VAR_1 . stream ( ) . map ( VAR_3 - > METHOD_3 ( VAR_3 , VAR_2 ) ) . collect ( Collectors . VAR_4 ( ) ) ; } |
VAR_2 empty ? asked chat assume | private void METHOD_1 ( final TYPE_1 VAR_1 , final String VAR_2 ) { <START> final String VAR_3 = VAR_2 + STRING_1 + VAR_1 . getName ( ) ; <END> final List < TYPE_1 > VAR_4 = VAR_1 . METHOD_2 ( ) ; if ( VAR_1 . METHOD_3 ( ) != null && ! METHOD_4 ( VAR_1 . METHOD_3 ( ) ) ) { VAR_1 . METHOD_5 ( METHOD_6 ( VAR_1 . METHOD_3... | private TYPE_1 METHOD_1 ( final TYPE_1 VAR_1 , final String VAR_2 ) { final String VAR_3 = VAR_2 + STRING_1 + VAR_1 . getName ( ) ; final List < TYPE_1 > VAR_4 = VAR_1 . METHOD_2 ( ) ; if ( VAR_1 . METHOD_3 ( ) != null && ! METHOD_4 ( VAR_1 . METHOD_3 ( ) ) ) { VAR_1 . METHOD_5 ( METHOD_6 ( VAR_1 . METHOD_3 ( ) , VAR_2... |
please restore original formatting | <START> METHOD_1 ( final String description ) { <END> if ( description == null ) { return new TYPE_1 ( "" ) ; } else { return new TYPE_1 ( description ) ; } } | public static TYPE_1 METHOD_1 ( final String description ) { if ( description == null ) { return new TYPE_1 ( "" ) ; } else { return new TYPE_1 ( description ) ; } } |
condition _CODE_ overriding method specific subprocesses sense | public void METHOD_1 ( TYPE_1 < ? extends View , ? > node ) { Object VAR_1 = node . VAR_2 ( ) . METHOD_2 ( ) ; METHOD_3 ( METHOD_4 ( node ) ) ; <START> if ( VAR_1 instanceof TYPE_2 || <END> VAR_1 instanceof TYPE_3 || VAR_1 instanceof TYPE_4 ) { VAR_3 . METHOD_5 ( true ) ; } } | public void METHOD_1 ( TYPE_1 < ? extends View , ? > node ) { METHOD_3 ( METHOD_4 ( node ) ) ; } |
returning Optional < TYPE_1 > | public static TYPE_1 < View , TYPE_2 > METHOD_1 ( final TYPE_1 < ? extends View , ? > node ) { return ( TYPE_1 < View , TYPE_2 > ) node . VAR_1 ( ) . stream ( ) . filter ( TYPE_3 : : METHOD_2 ) . map ( TYPE_2 : : METHOD_3 ) . METHOD_4 ( ) <START> . METHOD_5 ( null ) ; <END> } | public static Optional < TYPE_1 < View , TYPE_2 > > METHOD_1 ( final TYPE_1 < ? extends View , ? > node ) { return node . VAR_1 ( ) . stream ( ) . filter ( TYPE_3 : : METHOD_2 ) . map ( TYPE_2 : : METHOD_3 ) . map ( n - > ( TYPE_1 < View , TYPE_2 > ) n ) . METHOD_4 ( ) ; } |
don t need set TYPE_1 s done setup ( ) method ( harm test clearer ! ) | public void METHOD_1 ( ) { <START> VAR_1 . METHOD_2 ( new TYPE_1 ( STRING_1 ) ) ; <END> VAR_2 . METHOD_2 ( new TYPE_1 ( STRING_1 ) ) ; assertEquals ( VAR_1 , VAR_2 ) ; } | public void METHOD_1 ( ) { assertEquals ( VAR_1 , VAR_2 ) ; } |
check pointless NPE thrown L#120 | void METHOD_1 ( final ANNOTATION_1 TYPE_1 VAR_1 ) { TYPE_2 VAR_2 = VAR_1 . METHOD_2 ( ) ; if ( METHOD_3 ( ) . METHOD_2 ( ) . equals ( VAR_2 ) ) { <START> METHOD_4 ( STRING_1 , <END> VAR_1 ) ; if ( null != VAR_1 . METHOD_5 ( ) ) { VAR_3 . METHOD_6 ( VAR_1 . METHOD_5 ( ) ) ; } METHOD_7 ( ) ; } } | void METHOD_1 ( final ANNOTATION_1 TYPE_1 VAR_1 ) { METHOD_4 ( STRING_1 , VAR_1 ) ; TYPE_2 VAR_2 = VAR_1 . METHOD_2 ( ) ; if ( METHOD_3 ( ) . METHOD_2 ( ) . equals ( VAR_2 ) ) { if ( null != VAR_1 . METHOD_5 ( ) ) { VAR_3 . METHOD_6 ( VAR_1 . METHOD_5 ( ) ) ; } METHOD_7 ( ) ; } } |
I method private : suggestionprivate void METHOD_1 ( ) { | <START> void METHOD_1 ( ) { <END> VAR_1 . VAR_2 = this : : METHOD_2 ; VAR_1 . VAR_3 = this : : METHOD_3 ; VAR_1 . VAR_4 = this : : METHOD_4 ; } | private void METHOD_1 ( ) { VAR_1 . VAR_2 = this : : METHOD_2 ; VAR_1 . VAR_3 = this : : METHOD_3 ; VAR_1 . VAR_4 = this : : METHOD_4 ; } |
typo resource - > true ( VAR_5 ) | public static < TYPE_1 > Collection < TYPE_2 < TYPE_1 > > METHOD_1 ( TYPE_3 VAR_1 , Path VAR_2 , Collection < String > VAR_3 , TYPE_4 < TYPE_5 , TYPE_1 > VAR_4 ) { <START> return METHOD_1 ( VAR_1 , VAR_2 , VAR_3 , VAR_4 , VAR_5 - > true ) ; <END> } | public static < TYPE_1 > Collection < TYPE_2 < TYPE_1 > > METHOD_1 ( TYPE_3 VAR_1 , Path VAR_2 , Collection < String > VAR_3 , TYPE_4 < TYPE_5 , TYPE_1 > VAR_4 ) { return METHOD_1 ( VAR_1 , VAR_2 , VAR_3 , VAR_4 , resource - > true ) ; } |
I _CODE_ METHOD_1 public main feature class I miss | <START> String METHOD_1 ( final String VAR_1 , <END> final String VAR_2 ) { final TYPE_1 value = new TYPE_1 ( ) ; value . VAR_3 ( VAR_1 ) ; value . VAR_4 ( VAR_2 ) ; return METHOD_1 ( value ) ; } | public String METHOD_1 ( final String VAR_1 , final String VAR_2 ) { final TYPE_1 value = new TYPE_1 ( ) ; value . VAR_3 ( VAR_1 ) ; value . VAR_4 ( VAR_2 ) ; return METHOD_1 ( value ) ; } |
public rest private | <START> String METHOD_1 ( final String VAR_1 ) { <END> final TYPE_1 VAR_2 = METHOD_2 ( VAR_1 ) ; return METHOD_1 ( VAR_2 ) ; } | public String METHOD_1 ( final String VAR_1 ) { final TYPE_1 VAR_2 = METHOD_2 ( VAR_1 ) ; return METHOD_1 ( VAR_2 ) ; } |
I m fine server side classes case _CODE_ core - common module s correct class visible GWT compiler I emulate METHOD_2 method JRE s reason I remember comparison classname method emulated compare js strings feel free test guys I m wrong lemme I m agree change | public static boolean METHOD_1 ( Class < ? > type , Object instance ) { <START> return instance . getClass ( ) . METHOD_2 ( type ) ; <END> } | public static boolean METHOD_1 ( Class < ? > type , Object instance ) { return instance . getClass ( ) . getName ( ) . equals ( type . getName ( ) ) ; } |
please add TYPE_4 TYPE_5 Date imports declare variable final Date VAR_3 = TYPE_2 parse ( VAR_2 ) ; | String METHOD_1 ( final String VAR_1 ) { if ( StringUtils . isEmpty ( VAR_1 ) ) { return "" ; } final String VAR_2 = METHOD_2 ( VAR_1 ) ; try { <START> final TYPE_4 . TYPE_5 . Date VAR_3 = TYPE_2 . parse ( VAR_2 ) ; <END> return TYPE_3 . format ( VAR_3 ) ; } catch ( final IllegalArgumentException exception ) { return "... | String METHOD_1 ( final String VAR_1 ) { if ( StringUtils . isEmpty ( VAR_1 ) ) { return "" ; } final String VAR_2 = METHOD_2 ( VAR_1 ) ; try { final Date VAR_3 = TYPE_2 . parse ( VAR_2 ) ; return TYPE_3 . format ( VAR_3 ) ; } catch ( final IllegalArgumentException exception ) { return "" ; } } |
methods need static | <START> private static void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 , TYPE_3 VAR_3 , TYPE_4 VAR_4 ) { <END> when ( VAR_5 . METHOD_2 ( METHOD_3 ( Class . VAR_6 ) ) ) . METHOD_4 ( VAR_2 ) ; when ( VAR_5 . METHOD_5 ( METHOD_3 ( Class . VAR_6 ) ) ) . METHOD_4 ( VAR_1 ) ; when ( VAR_5 . METHOD_6 ( METHOD_3 ( Class . VAR_6 ) ... | private void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 , TYPE_3 VAR_3 , TYPE_4 VAR_4 ) { when ( VAR_5 . METHOD_2 ( METHOD_3 ( Class . VAR_6 ) ) ) . METHOD_4 ( VAR_2 ) ; when ( VAR_5 . METHOD_5 ( METHOD_3 ( Class . VAR_6 ) ) ) . METHOD_4 ( VAR_1 ) ; when ( VAR_5 . METHOD_6 ( METHOD_3 ( Class . VAR_6 ) ) ) . METHOD_4 ( VAR_... |
I s a format issue : suggestionpublic void METHOD_1 ( ) { | <START> public void METHOD_1 ( ) { <END> final TYPE_1 VAR_1 = METHOD_2 ( TYPE_1 . class ) ; METHOD_3 ( ) . when ( VAR_2 ) . METHOD_4 ( ) ; final TYPE_2 VAR_3 = METHOD_2 ( TYPE_2 . class ) ; METHOD_5 ( VAR_3 ) . when ( VAR_1 ) . METHOD_6 ( ) ; VAR_2 . METHOD_7 ( VAR_1 ) ; final TYPE_2 VAR_4 = VAR_2 . METHOD_6 ( ) ; asse... | public void METHOD_1 ( ) { final TYPE_1 VAR_1 = METHOD_2 ( TYPE_1 . class ) ; final TYPE_2 VAR_3 = METHOD_2 ( TYPE_2 . class ) ; METHOD_3 ( ) . when ( VAR_2 ) . METHOD_4 ( ) ; METHOD_5 ( VAR_3 ) . when ( VAR_1 ) . METHOD_6 ( ) ; VAR_2 . METHOD_7 ( VAR_1 ) ; final TYPE_2 VAR_4 = VAR_2 . METHOD_6 ( ) ; assertEquals ( VAR... |
unnecessary * * ; * * | public TYPE_4 ( final TYPE_1 VAR_2 , final TYPE_2 [ ] VAR_3 ) { this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; VAR_4 = TYPE_3 . of ( METHOD_1 ( VAR_2 ) ) . map ( TYPE_2 : : METHOD_2 ) . METHOD_3 ( TYPE_2 [ ] : : new ) ; <START> ; <END> } | public TYPE_4 ( final TYPE_1 VAR_2 , final TYPE_2 [ ] VAR_3 ) { this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; VAR_4 = TYPE_3 . of ( METHOD_1 ( VAR_2 ) ) . map ( TYPE_2 : : METHOD_2 ) . METHOD_3 ( TYPE_2 [ ] : : new ) ; } |
need METHOD_2 case | public void METHOD_1 ( ) { <START> this . VAR_1 = METHOD_2 ( new TYPE_1 ( ) ) ; <END> } | public void METHOD_1 ( ) { this . VAR_1 = new TYPE_1 ( ) ; } |
I package - private : suggestionvoid METHOD_1 ( ) { | <START> public void METHOD_1 ( ) { <END> VAR_1 . METHOD_1 ( ) ; } | void METHOD_1 ( ) { VAR_1 . METHOD_1 ( ) ; } |
change setup method : _CODE_ void setup ( ) { view = spy ( new TYPE_1 ( _CODE_ _CODE_ _CODE_ _CODE_ ) ) ; } simplify method : _CODE_ void METHOD_1 ( ) { view METHOD_4 ( VAR_2 ) ; METHOD_6 ( view ) METHOD_7 ( ) ; } | public void METHOD_1 ( ) { final TYPE_1 VAR_1 = METHOD_2 ( TYPE_1 . class ) ; METHOD_3 ( ) . when ( VAR_1 ) . METHOD_4 ( METHOD_5 ( ) ) ; VAR_1 . METHOD_4 ( VAR_2 ) ; <START> METHOD_6 ( VAR_1 ) . METHOD_7 ( ) ; <END> } | public void METHOD_1 ( ) { METHOD_6 ( view ) . METHOD_7 ( ) ; } |
_CODE_ ( _CODE_ class ) public class _CODE_ { private static final String VAR_7 = _CODE_ ; private static final String VAR_9 = 1 2 3 ; private static final TYPE_1 key = new TYPE_1 ( TYPE_2 TYPE_4 VAR_3 METHOD_2 ( ) TYPE_3 VAR_5 TYPE_2 TYPE_4 VAR_3 METHOD_3 ( ) ) ; org kie dmn model api _CODE_ VAR_6 ; Map < TYPE_1 Strin... | <START> public void METHOD_1 ( ) { <END> final TYPE_1 key = new TYPE_1 ( TYPE_2 . TYPE_4 . VAR_3 . METHOD_2 ( ) , TYPE_3 . VAR_5 , TYPE_2 . TYPE_4 . VAR_3 . METHOD_3 ( ) ) ; when ( VAR_6 . getId ( ) ) . METHOD_4 ( VAR_7 ) ; when ( VAR_6 . METHOD_5 ( ) ) . METHOD_4 ( VAR_8 ) ; when ( VAR_6 . METHOD_6 ( ) ) . METHOD_4 ( ... | public void METHOD_1 ( ) { when ( VAR_6 . getId ( ) ) . METHOD_4 ( VAR_7 ) ; when ( VAR_6 . METHOD_5 ( ) ) . METHOD_4 ( VAR_8 ) ; when ( VAR_6 . METHOD_6 ( ) ) . METHOD_4 ( VAR_9 ) ; } |
shorten condition : java ( StringUtils _CODE_ ( ) && VAR_1 = = null ) FQN StringUtils org kie workbench common stunner core util StringUtils | void METHOD_1 ( final String type , final String value , final TYPE_1 VAR_1 ) { this . VAR_2 = value ; <START> if ( ! TYPE_2 . METHOD_2 ( value ) && ! value . isEmpty ( ) && VAR_1 == null ) { <END> this . VAR_1 = METHOD_3 ( value ) ; } else { this . VAR_1 = VAR_1 ; } METHOD_4 ( type , value , VAR_1 ) ; } | void METHOD_1 ( final String type , final String value , final TYPE_1 VAR_1 ) { this . VAR_2 = value ; if ( ! StringUtils . isEmpty ( value ) && VAR_1 == null ) { this . VAR_1 = METHOD_3 ( value ) ; } else { this . VAR_1 = VAR_1 ; } METHOD_4 ( type , value , VAR_1 ) ; } |
I add a final : suggestionfinal TYPE_2 VAR_2 = TYPE_2 METHOD_2 ( VAR_1 ) ; | void METHOD_1 ( final TYPE_1 event ) { final String VAR_1 = event . target . value ; if ( ! isEmpty ( VAR_1 ) ) { <START> TYPE_2 VAR_2 = TYPE_2 . METHOD_2 ( VAR_1 ) ; <END> METHOD_3 ( VAR_2 ) ; VAR_3 . METHOD_4 ( VAR_2 ) ; } } | void METHOD_1 ( final TYPE_1 event ) { final String VAR_1 = event . target . value ; if ( ! isEmpty ( VAR_1 ) ) { final TYPE_2 VAR_2 = TYPE_2 . METHOD_2 ( VAR_1 ) ; METHOD_3 ( VAR_2 ) ; VAR_3 . METHOD_4 ( VAR_2 ) ; } } |
useless semicolon | public void METHOD_1 ( ) throws Exception { super . METHOD_1 ( ) ; when ( VAR_1 . METHOD_2 ( ) ) . METHOD_3 ( VAR_2 ) ; when ( VAR_3 . METHOD_4 ( ) ) . METHOD_3 ( new TYPE_1 < > ( METHOD_5 ( Object . VAR_4 ) , VAR_5 ) ) ; <START> ; <END> } | public void METHOD_1 ( ) throws Exception { super . METHOD_1 ( ) ; when ( VAR_1 . METHOD_2 ( ) ) . METHOD_3 ( VAR_2 ) ; when ( VAR_3 . METHOD_4 ( ) ) . METHOD_3 ( new TYPE_1 < > ( METHOD_5 ( Object . VAR_4 ) , VAR_5 ) ) ; } |
return method | <START> private String METHOD_1 ( ) throws TYPE_1 { <END> int index = METHOD_2 ( ) ; if ( index < 0 || VAR_1 . METHOD_3 ( index ) != CHAR_1 ) { throw new TYPE_1 ( METHOD_4 ( VAR_2 , VAR_3 ) , VAR_4 ) ; } METHOD_5 ( index + 1 ) ; return STRING_1 ; } | private void METHOD_1 ( ) throws TYPE_1 { int index = METHOD_2 ( ) ; if ( index < 0 || VAR_1 . METHOD_3 ( index ) != CHAR_1 ) { throw new TYPE_1 ( METHOD_4 ( VAR_2 , VAR_3 ) , VAR_4 ) ; } METHOD_5 ( index + 1 ) ; } |
return method | <START> private String METHOD_1 ( ) throws TYPE_1 { <END> int index = METHOD_2 ( ) ; if ( index < 0 || VAR_1 . METHOD_3 ( index ) != CHAR_1 ) { throw new TYPE_1 ( METHOD_4 ( VAR_2 ) , VAR_3 ) ; } METHOD_5 ( index + 1 ) ; return STRING_1 ; } | private void METHOD_1 ( ) throws TYPE_1 { int index = METHOD_2 ( ) ; if ( index < 0 || VAR_1 . METHOD_3 ( index ) != CHAR_1 ) { throw new TYPE_1 ( METHOD_4 ( VAR_2 ) , VAR_3 ) ; } METHOD_5 ( index + 1 ) ; } |
Exception thrown method | <START> public void METHOD_1 ( ) throws Exception { <END> for ( String VAR_1 : VAR_2 ) { METHOD_2 ( VAR_1 , VAR_3 ) ; } } | public void METHOD_1 ( ) { for ( String VAR_1 : VAR_2 ) { METHOD_2 ( VAR_1 , VAR_3 ) ; } } |
method private | <START> TYPE_1 METHOD_1 ( String name , String type ) { <END> TYPE_1 VAR_1 = METHOD_2 ( TYPE_1 . class ) ; when ( VAR_1 . getName ( ) ) . METHOD_3 ( name ) ; when ( VAR_1 . getType ( ) ) . METHOD_3 ( type ) ; return VAR_1 ; } | private TYPE_1 METHOD_1 ( String name , String type ) { TYPE_1 VAR_1 = METHOD_2 ( TYPE_1 . class ) ; when ( VAR_1 . getName ( ) ) . METHOD_3 ( name ) ; when ( VAR_1 . getType ( ) ) . METHOD_3 ( type ) ; return VAR_1 ; } |
method private | <START> TYPE_1 METHOD_1 ( ) { <END> TYPE_1 VAR_1 = METHOD_2 ( TYPE_1 . class ) ; TYPE_1 . View VAR_2 = METHOD_2 ( TYPE_1 . View . class ) ; TYPE_2 element = METHOD_2 ( TYPE_2 . class ) ; when ( VAR_1 . METHOD_3 ( ) ) . METHOD_4 ( VAR_2 ) ; when ( VAR_2 . METHOD_5 ( ) ) . METHOD_4 ( element ) ; return VAR_1 ; } | private TYPE_1 METHOD_1 ( ) { TYPE_1 VAR_1 = METHOD_2 ( TYPE_1 . class ) ; TYPE_1 . View VAR_2 = METHOD_2 ( TYPE_1 . View . class ) ; TYPE_2 element = METHOD_2 ( TYPE_2 . class ) ; when ( VAR_1 . METHOD_3 ( ) ) . METHOD_4 ( VAR_2 ) ; when ( VAR_2 . METHOD_5 ( ) ) . METHOD_4 ( element ) ; return VAR_1 ; } |
I m wondering need method METHOD_3 additional check && METHOD_3 ( VAR_1 ) s similar check filter ( VAR_3 - > VAR_3 equals ( VAR_1 METHOD_5 ( ) ) ) happen 2 _CODE_ equal don t identifier ? I remove newly added private METHOD_3 remove && check behave | public void METHOD_1 ( ANNOTATION_1 final TYPE_1 VAR_1 ) { <START> if ( METHOD_2 ( ) && METHOD_3 ( VAR_1 ) ) { <END> VAR_2 . METHOD_4 ( ) . filter ( VAR_3 - > VAR_3 . equals ( VAR_1 . METHOD_5 ( ) ) ) . METHOD_6 ( VAR_3 - > METHOD_7 ( ) ) ; } } | public void METHOD_1 ( ANNOTATION_1 final TYPE_1 VAR_1 ) { if ( METHOD_2 ( ) ) { VAR_2 . METHOD_4 ( ) . filter ( VAR_3 - > VAR_3 . equals ( VAR_1 . METHOD_5 ( ) ) ) . METHOD_6 ( VAR_3 - > this . METHOD_7 ( ) ) ; } } |
method doesn t throw exception | <START> public void METHOD_1 ( ) throws Exception { <END> VAR_1 = METHOD_2 ( new TYPE_1 < > ( VAR_2 , VAR_3 ) ) ; VAR_4 = new TYPE_2 ( VAR_5 , VAR_1 ) ; } | public void METHOD_1 ( ) { VAR_1 = METHOD_2 ( new TYPE_1 < > ( VAR_2 , VAR_3 ) ) ; VAR_4 = new TYPE_2 ( VAR_5 , VAR_1 ) ; } |
explicit type argument TYPE_2 replaced < > | public void METHOD_1 ( ) throws Exception { <START> VAR_1 = METHOD_2 ( new TYPE_1 < TYPE_2 > ( VAR_2 , VAR_3 ) ) ; <END> VAR_4 = new TYPE_3 ( VAR_5 , VAR_1 ) ; } | public void METHOD_1 ( ) { VAR_1 = METHOD_2 ( new TYPE_1 < > ( VAR_2 , VAR_3 ) ) ; VAR_4 = new TYPE_3 ( VAR_5 , VAR_1 ) ; } |
dtto | public void METHOD_1 ( String id ) { context . VAR_1 ( ) ; HashMap < String , String > map = new HashMap < > ( ) ; <START> Optional . VAR_2 ( id ) . METHOD_2 ( node - > map . put ( VAR_3 , id ) ) ; <END> context . VAR_4 ( map ) ; } | public void METHOD_1 ( String id ) { context . VAR_1 ( ) ; HashMap < String , String > map = new HashMap < > ( ) ; if ( id != null ) { map . put ( VAR_3 , id ) ; } context . VAR_4 ( map ) ; } |
don t need a call super ( ) | public TYPE_3 ( List < TYPE_1 > VAR_2 , TYPE_2 VAR_3 ) { <START> super ( ) ; <END> this . VAR_2 = Collections . VAR_4 ( VAR_2 ) ; this . VAR_3 = VAR_3 ; } | public TYPE_3 ( List < TYPE_1 > VAR_2 , TYPE_2 VAR_3 ) { this . VAR_2 = Collections . VAR_4 ( VAR_2 ) ; this . VAR_3 = VAR_3 ; } |
IMO s values e g 0 1 example delegated method simply parameter | public void METHOD_1 ( ) { VAR_1 . METHOD_2 ( 0 , 0 ) ; <START> METHOD_3 ( VAR_2 ) . METHOD_2 ( METHOD_4 ( 0 ) , METHOD_4 ( 0 ) ) ; <END> } | public void METHOD_1 ( ) { VAR_1 . METHOD_2 ( 0 , 1 ) ; METHOD_3 ( VAR_2 ) . METHOD_2 ( METHOD_4 ( 0 ) , METHOD_4 ( 1 ) ) ; } |
please field instead f consistent line | public Optional < ? > getProperty ( T VAR_1 , String VAR_2 ) { return TYPE_1 . METHOD_1 ( VAR_1 . getClass ( ) ) . stream ( ) <START> . filter ( f - > TYPE_2 . equals ( VAR_2 , f . getName ( ) ) ) <END> . map ( field - > TYPE_3 . METHOD_2 ( ( ) - > field . get ( VAR_1 ) , null ) ) . METHOD_3 ( ) ; } | public Optional < ? > getProperty ( T VAR_1 , String VAR_2 ) { return TYPE_1 . METHOD_1 ( VAR_1 . getClass ( ) ) . stream ( ) . filter ( field - > TYPE_2 . equals ( VAR_2 , field . getName ( ) ) ) . map ( field - > TYPE_3 . METHOD_2 ( ( ) - > field . get ( VAR_1 ) , null ) ) . METHOD_3 ( ) ; } |
I simplify method : javaprivate Optional < String > METHOD_1 ( ) { ( TYPE_2 METHOD_3 ( METHOD_2 ( ) ) || TYPE_2 METHOD_3 ( METHOD_4 ( ) ) ) { return Optional empty ( ) ; } return Optional ( METHOD_4 ( ) METHOD_5 ( ) ) ; } feel free : - ) | private Optional < String > METHOD_1 ( ) { final TYPE_1 VAR_1 = METHOD_2 ( ) ; if ( TYPE_2 . METHOD_3 ( VAR_1 ) ) { return Optional . empty ( ) ; } final TYPE_3 VAR_2 = VAR_1 . METHOD_4 ( ) ; if ( TYPE_2 . METHOD_3 ( VAR_2 ) ) { return Optional . empty ( ) ; } return Optional . of ( VAR_2 . METHOD_5 ( ) ) ; <START> } <... | private Optional < String > METHOD_1 ( ) { if ( TYPE_2 . METHOD_3 ( METHOD_4 ( ) ) ) { return Optional . empty ( ) ; } return Optional . of ( METHOD_4 ( ) . METHOD_5 ( ) ) ; } |
replaced I prefer matter taste needs revert | public TYPE_11 ( final TYPE_1 VAR_2 , final TYPE_2 VAR_3 , final TYPE_3 < TYPE_4 , TYPE_5 > VAR_4 , final TYPE_6 < TYPE_7 > TYPE_8 , final TYPE_9 VAR_5 , final TYPE_10 VAR_6 ) { this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; this . VAR_4 = VAR_4 ; <START> this . TYPE_8 = ( ) - > TYPE_8 . get ( ) ; <END> this . VAR_5 = V... | public TYPE_11 ( final TYPE_1 VAR_2 , final TYPE_2 VAR_3 , final TYPE_3 < TYPE_4 , TYPE_5 > VAR_4 , final TYPE_6 < TYPE_7 > TYPE_8 , final TYPE_9 VAR_5 , final TYPE_10 VAR_6 ) { this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; this . VAR_4 = VAR_4 ; this . TYPE_8 = TYPE_8 : : get ; this . VAR_5 = VAR_5 ; this . VAR_6 = VA... |
missing verify VAR_8 fire tests _CODE_ mock event | public void METHOD_1 ( ) throws Exception { TYPE_1 VAR_1 = new TYPE_1 ( ) ; when ( VAR_2 . METHOD_2 ( ) ) . METHOD_3 ( VAR_3 ) ; when ( VAR_4 . METHOD_4 ( ) ) . METHOD_3 ( VAR_5 ) ; when ( VAR_5 . METHOD_5 ( ) ) . METHOD_3 ( VAR_2 ) ; when ( VAR_5 . METHOD_6 ( ) ) . METHOD_3 ( VAR_6 ) ; when ( VAR_5 . METHOD_7 ( ) ) . ... | public void METHOD_1 ( ) throws Exception { TYPE_1 VAR_1 = new TYPE_1 ( ) ; when ( VAR_2 . METHOD_2 ( ) ) . METHOD_3 ( VAR_3 ) ; when ( VAR_4 . METHOD_4 ( ) ) . METHOD_3 ( VAR_5 ) ; when ( VAR_5 . METHOD_5 ( ) ) . METHOD_3 ( VAR_2 ) ; when ( VAR_5 . METHOD_6 ( ) ) . METHOD_3 ( VAR_6 ) ; when ( VAR_5 . METHOD_7 ( ) ) . ... |
I method private | <START> public void METHOD_1 ( final boolean VAR_1 ) { <END> this . VAR_2 = VAR_1 ; } | private void METHOD_1 ( final boolean VAR_1 ) { this . VAR_2 = VAR_1 ; } |
I method private | <START> public double METHOD_1 ( ) { <END> return VAR_1 ; } | private double METHOD_1 ( ) { return VAR_1 ; } |
ordering data types TYPE_2 : : getName a TYPE_2 : : getType function default data types I correctly ordered | TYPE_1 METHOD_1 ( final String VAR_1 , final List < TYPE_2 > VAR_2 , final TYPE_3 < TYPE_2 , String > VAR_3 ) { final TYPE_1 VAR_4 = METHOD_2 ( ) ; VAR_4 . VAR_5 = VAR_1 ; VAR_2 . stream ( ) <START> . METHOD_3 ( VAR_6 ) <END> . forEach ( VAR_7 - > { final TYPE_4 VAR_8 = METHOD_4 ( VAR_7 , VAR_3 ) ; VAR_4 . METHOD_5 ( V... | TYPE_1 METHOD_1 ( final String VAR_1 , final List < TYPE_2 > VAR_2 , final TYPE_3 < TYPE_2 , String > VAR_3 ) { final TYPE_1 VAR_4 = METHOD_2 ( ) ; VAR_4 . VAR_5 = VAR_1 ; VAR_2 . stream ( ) . forEach ( VAR_7 - > { final TYPE_4 VAR_8 = METHOD_4 ( VAR_7 , VAR_3 ) ; VAR_4 . METHOD_5 ( VAR_8 ) ; } ) ; return VAR_4 ; } |
static | <START> private boolean METHOD_1 ( final TYPE_1 VAR_1 ) { <END> final String VAR_2 = VAR_1 . METHOD_2 ( ) != null ? VAR_1 . METHOD_2 ( ) . METHOD_3 ( ) : null ; final String VAR_3 = VAR_1 . METHOD_4 ( ) != null ? VAR_1 . METHOD_4 ( ) . METHOD_3 ( ) : null ; return ! TYPE_2 . equals ( VAR_2 , VAR_3 ) ; } | private static boolean METHOD_1 ( final TYPE_1 VAR_1 ) { final String VAR_2 = VAR_1 . METHOD_2 ( ) != null ? VAR_1 . METHOD_2 ( ) . METHOD_3 ( ) : null ; final String VAR_3 = VAR_1 . METHOD_4 ( ) != null ? VAR_1 . METHOD_4 ( ) . METHOD_3 ( ) : null ; return ! TYPE_2 . equals ( VAR_2 , VAR_3 ) ; } |
I guess return ( TYPE_1 ) node VAR_2 ( ) METHOD_4 ( ) ; more clear | private TYPE_1 METHOD_1 ( TYPE_2 < TYPE_3 , TYPE_4 > VAR_1 , String id ) { TYPE_5 < ? extends TYPE_6 , ? > node = METHOD_2 ( VAR_1 , id ) ; <START> return TYPE_1 . class . METHOD_3 ( node . VAR_2 ( ) . METHOD_4 ( ) ) ; <END> } | private TYPE_1 METHOD_1 ( TYPE_2 < TYPE_3 , TYPE_4 > VAR_1 , String id ) { TYPE_5 < ? extends TYPE_6 , ? > node = METHOD_2 ( VAR_1 , id ) ; return ( TYPE_1 ) node . VAR_2 ( ) . METHOD_4 ( ) ; } |
METHOD_1 ( ) internally I rewrite : javapublic Collection < TYPE_1 > METHOD_1 ( ) { return VAR_1 values ( ) ; } | public List < TYPE_1 > METHOD_1 ( ) { <START> return new ArrayList < > ( VAR_1 . values ( ) ) ; <END> } | private Collection < TYPE_1 > METHOD_1 ( ) { return VAR_1 . values ( ) ; } |
private other classes | <START> public static String METHOD_1 ( TYPE_1 p ) { <END> String name = p . getName ( ) ; return name == null ? p . getId ( ) : name ; } | private static String METHOD_1 ( TYPE_1 p ) { String name = p . getName ( ) ; return name == null ? p . getId ( ) : name ; } |
VAR_3 left | <START> public TYPE_2 ( Path VAR_2 , TYPE_1 VAR_3 ) { <END> this . VAR_2 = VAR_2 ; } | public TYPE_2 ( Path VAR_2 , TYPE_1 VAR_3 ) { this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; } |
_setup_ | public void METHOD_1 ( final String VAR_1 , final String VAR_2 ) { METHOD_2 ( ) . METHOD_3 ( VAR_3 . format ( VAR_1 ) ) ; METHOD_2 ( ) . METHOD_4 ( VAR_3 . format ( VAR_2 ) ) ; <START> METHOD_5 ( ) ; <END> } | public void METHOD_1 ( final String VAR_1 , final String VAR_2 ) { METHOD_2 ( ) . METHOD_3 ( VAR_3 . format ( VAR_1 ) ) ; METHOD_2 ( ) . METHOD_4 ( VAR_3 . format ( VAR_2 ) ) ; METHOD_1 ( ) ; } |
please - - resources | private static void write ( String VAR_1 , String content ) throws IOException { <START> TYPE_1 writer = new TYPE_1 ( new TYPE_2 ( VAR_1 ) ) ; <END> writer . write ( content ) ; writer . close ( ) ; } | private static void write ( String VAR_1 , String content ) throws IOException { try ( TYPE_1 writer = new TYPE_1 ( new TYPE_2 ( VAR_1 ) ) ) { writer . write ( content ) ; } } |
constructor calling more featureful constructor consistency avoid duplication : ( VAR_2 VAR_3 VAR_4 Collections VAR_6 ( ) Collections VAR_6 ( ) VAR_5 ) ; | public TYPE_1 ( final Boolean VAR_2 , final List < String > VAR_3 , final Path VAR_4 , <START> final String VAR_5 ) { <END> this . VAR_2 = VAR_2 ; if ( VAR_3 != null ) { this . VAR_3 = new ArrayList < > ( VAR_3 ) ; } else { this . VAR_3 = Collections . VAR_6 ( ) ; } this . VAR_4 = VAR_4 ; this . VAR_5 = VAR_5 ; } | public TYPE_1 ( final Boolean VAR_2 , final List < String > VAR_3 , final Path VAR_4 , final String VAR_5 ) { this ( VAR_2 , VAR_3 , VAR_4 , Collections . VAR_6 ( ) , Collections . VAR_6 ( ) , VAR_5 ) ; } |
more unnecessary save restore system property please remove consistent entire test suite _CODE_ | public static void METHOD_1 ( ) { <START> VAR_1 = System . getProperty ( STRING_1 ) ; <END> VAR_2 = System . getProperty ( STRING_2 ) ; System . VAR_3 ( STRING_1 , STRING_3 ) ; System . VAR_3 ( STRING_2 , STRING_3 ) ; } | public static void METHOD_1 ( ) { System . VAR_3 ( STRING_1 , STRING_3 ) ; System . VAR_3 ( STRING_2 , STRING_3 ) ; } |
please remove else code more readable | private < T > List < T > METHOD_1 ( List < T > list ) { if ( list == null ) { return Collections . VAR_1 ( ) ; <START> } else { <END> return new ArrayList < > ( list ) ; } } | private < T > List < T > METHOD_1 ( List < T > list ) { if ( list == null ) { return Collections . VAR_1 ( ) ; } return new ArrayList < > ( list ) ; } |
please remove else code more readable ; follow KIE code style | private Path METHOD_1 ( String VAR_1 ) { if ( VAR_1 != null ) { return TYPE_1 . get ( STRING_1 + VAR_1 ) ; } <START> else { <END> return null ; } } | private Path METHOD_1 ( String VAR_1 ) { if ( VAR_1 != null ) { return TYPE_1 . get ( STRING_1 + VAR_1 ) ; } return null ; } |
doesn t change needed | <START> public void METHOD_1 ( final TYPE_1 VAR_1 ) { <END> if ( this . VAR_2 . contains ( VAR_1 ) ) { this . VAR_2 . update ( VAR_1 ) ; } else { this . VAR_2 . add ( VAR_1 ) ; } } | private void METHOD_1 ( final TYPE_1 VAR_1 ) { if ( this . VAR_2 . contains ( VAR_1 ) ) { this . VAR_2 . update ( VAR_1 ) ; } else { this . VAR_2 . add ( VAR_1 ) ; } } |
useless comma | private TYPE_5 . TYPE_6 METHOD_1 ( TYPE_2 VAR_1 ) { TYPE_3 < String , TYPE_4 > VAR_2 = VAR_3 - > VAR_3 . equals ( VAR_4 ) ? VAR_5 : null ; <START> ; <END> return new TYPE_5 . TYPE_6 ( VAR_1 , VAR_2 ) ; } | private TYPE_5 . TYPE_6 METHOD_1 ( TYPE_2 VAR_1 ) { TYPE_3 < String , TYPE_4 > VAR_2 = VAR_3 - > VAR_3 . equals ( VAR_4 ) ? VAR_5 : null ; return new TYPE_5 . TYPE_6 ( VAR_1 , VAR_2 ) ; } |
hide remove doesn t inverted | public TYPE_1 < TYPE_2 > execute ( TYPE_3 context ) { TYPE_4 . METHOD_1 ( VAR_1 , context , VAR_2 ) ; <START> TYPE_4 . METHOD_2 ( VAR_1 , context ) ; <END> TYPE_4 . METHOD_3 ( VAR_1 , context ) ; return METHOD_4 ( ) ; } | public TYPE_1 < TYPE_2 > execute ( TYPE_3 context ) { TYPE_4 . METHOD_2 ( VAR_1 , context ) ; TYPE_4 . METHOD_1 ( VAR_1 , context , VAR_2 ) ; TYPE_4 . METHOD_3 ( VAR_1 , context ) ; return METHOD_4 ( ) ; } |
else redundand please replace return VAR_2 ; VAR_2 added loop VAR_2 empty ; ) method | public static List < TYPE_1 > METHOD_1 ( List < String > VAR_1 ) { List < TYPE_1 > VAR_2 = new ArrayList < > ( ) ; for ( String VAR_3 : VAR_1 ) { try { VAR_2 . add ( new TYPE_1 ( VAR_3 ) ) ; } catch ( TYPE_2 e ) { logger . error ( e . getMessage ( ) ) ; } } <START> if ( VAR_2 . size ( ) > 0 ) { <END> return VAR_2 ; } e... | public static List < TYPE_1 > METHOD_1 ( List < String > VAR_1 ) { List < TYPE_1 > VAR_2 = new ArrayList < > ( ) ; for ( String VAR_3 : VAR_1 ) { try { VAR_2 . add ( new TYPE_1 ( VAR_3 ) ) ; } catch ( TYPE_2 e ) { logger . error ( e . getMessage ( ) ) ; } } return VAR_2 ; } |
please replace size ( ) ) METHOD_4 ( _CODE_ ( 16x PR : ctrl + f size ( ) ) METHOD_4 ( | public void METHOD_1 ( ) throws Exception { TYPE_1 VAR_1 = new TYPE_2 ( ) ; TYPE_3 < TYPE_4 > VAR_2 = VAR_1 . build ( VAR_3 , VAR_4 . toString ( ) , Boolean . VAR_5 ) ; TYPE_4 res = VAR_2 . get ( ) ; assertThat ( res . VAR_6 ( ) ) . METHOD_2 ( ) ; assertThat ( res . VAR_7 ( ) . isEmpty ( ) ) . METHOD_3 ( ) ; <START> as... | public void METHOD_1 ( ) throws Exception { TYPE_1 VAR_1 = new TYPE_2 ( ) ; TYPE_3 < TYPE_4 > VAR_2 = VAR_1 . build ( VAR_3 , VAR_4 . toString ( ) , Boolean . VAR_5 ) ; TYPE_4 res = VAR_2 . get ( ) ; assertThat ( res . VAR_6 ( ) ) . METHOD_2 ( ) ; assertThat ( res . VAR_7 ( ) ) . isEmpty ( ) ; } |
lists shouldn t copied copy ; javathis VAR_5 = new ArrayList < > ( VAR_5 ) ; holds access parameter list modify | public TYPE_1 ( final Boolean VAR_2 , final List < String > VAR_3 , final Path VAR_4 , final List < String > VAR_5 , final List < String > VAR_6 ) { this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; this . VAR_4 = VAR_4 ; <START> this . VAR_5 = VAR_5 ; <END> this . VAR_6 = VAR_6 ; } | public TYPE_1 ( final Boolean VAR_2 , final List < String > VAR_3 , final Path VAR_4 , final List < String > VAR_5 , final List < String > VAR_6 ) { this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; this . VAR_4 = VAR_4 ; this . VAR_5 = new ArrayList < > ( VAR_5 ) ; this . VAR_6 = new ArrayList < > ( VAR_6 ) ; } |
getClass ( ) instead getClass ( ) getName ( ) ? applies bellow | public int METHOD_1 ( ) { <START> return TYPE_1 . METHOD_2 ( TYPE_2 . METHOD_1 ( getClass ( ) . getName ( ) ) , <END> TYPE_2 . METHOD_1 ( VAR_1 ) , TYPE_2 . METHOD_1 ( VAR_2 ) , TYPE_2 . METHOD_1 ( VAR_3 ) , TYPE_2 . METHOD_1 ( VAR_4 ) , TYPE_2 . METHOD_1 ( VAR_5 ) ) ; } | public int METHOD_1 ( ) { return TYPE_1 . METHOD_2 ( TYPE_2 . METHOD_1 ( getClass ( ) ) , TYPE_2 . METHOD_1 ( VAR_1 ) , TYPE_2 . METHOD_1 ( VAR_2 ) , TYPE_2 . METHOD_1 ( VAR_3 ) , TYPE_2 . METHOD_1 ( VAR_4 ) , TYPE_2 . METHOD_1 ( VAR_5 ) ) ; } |
Optional nitpick : VAR_1 isEmpty ( ) | public TYPE_1 METHOD_1 ( ) { <START> if ( VAR_1 . size ( ) == 0 ) { <END> return null ; } return VAR_1 . get ( VAR_2 ) ; } | public TYPE_1 METHOD_1 ( ) { if ( VAR_1 . isEmpty ( ) ) { return null ; } return VAR_1 . get ( VAR_2 ) ; } |
shorten return Optional ( new TYPE_1 ( ) ) ; | public Optional < TYPE_1 > METHOD_1 ( ) { final TYPE_1 VAR_1 = new TYPE_1 ( ) ; <START> return Optional . of ( VAR_1 ) ; <END> } | public Optional < TYPE_1 > METHOD_1 ( ) { return Optional . of ( new TYPE_1 ( ) ) ; } |
shorten line return Optional ( new Context ( ) ) ; | public Optional < Context > METHOD_1 ( ) { final Context context = new Context ( ) ; <START> return Optional . of ( context ) ; <END> } | public Optional < Context > METHOD_1 ( ) { return Optional . of ( new Context ( ) ) ; } |
shortened line more question performance : javareturn Optional _CODE_ ( VAR_3 ( VAR_1 ) ) _CODE_ ( Collections VAR_4 ( ) ) ; | public Set < String > METHOD_1 ( final String VAR_1 ) { final Set < String > VAR_2 = VAR_3 . get ( VAR_1 ) ; if ( null == VAR_2 ) { return Collections . VAR_4 ( ) ; } <START> return VAR_2 ; <END> } | public Set < String > METHOD_1 ( final String VAR_1 ) { final Set < String > VAR_2 = VAR_3 . get ( VAR_1 ) ; return null != VAR_2 ? VAR_2 : Collections . VAR_4 ( ) ; } |
consumer simplified lambda leaving decision _CODE_ - > METHOD_6 ( ) | public void METHOD_1 ( final List < String > VAR_1 ) { String [ ] VAR_2 = VAR_1 . METHOD_2 ( new String [ VAR_1 . size ( ) ] ) ; VAR_3 . METHOD_3 ( VAR_4 , METHOD_4 ( VAR_2 ) , VAR_2 [ 0 ] , new TYPE_1 < String > ( ) { @Override public void METHOD_5 ( String s ) { METHOD_6 ( ) ; } <START> } ) ; <END> } | public void METHOD_1 ( final List < String > VAR_1 ) { String [ ] VAR_2 = VAR_1 . METHOD_2 ( new String [ VAR_1 . size ( ) ] ) ; VAR_3 . METHOD_3 ( VAR_4 , METHOD_4 ( VAR_2 ) , VAR_2 [ 0 ] , s - > METHOD_6 ( ) ) ; } |
parameter private method false | private void METHOD_1 ( final Class < ? extends TYPE_1 > type , <START> final boolean VAR_1 ) { <END> VAR_2 . get ( type ) . METHOD_2 ( VAR_1 ) ; } | public void METHOD_1 ( final Class < ? extends TYPE_1 > type , final boolean VAR_1 ) { VAR_2 . get ( type ) . METHOD_2 ( VAR_1 ) ; } |
nice provide some feedback check fails file BLABLA doesn t exist directory provided please | <START> private boolean METHOD_1 ( String path ) { <END> File VAR_1 = new File ( path + STRING_1 + VAR_2 ) ; return VAR_1 . exists ( ) && VAR_1 . METHOD_2 ( ) ; } | private boolean METHOD_1 ( String path ) { File VAR_1 = new File ( path , VAR_2 ) ; return VAR_1 . exists ( ) && VAR_1 . METHOD_2 ( ) ; } |
don t worry changing FYI a constructor File takes a parent child path concatenates s nice don t worry File VAR_2 concatenating path | private boolean METHOD_1 ( String path ) { <START> File VAR_1 = new File ( path + File . VAR_2 + VAR_3 ) ; <END> return VAR_1 . exists ( ) && VAR_1 . METHOD_2 ( ) ; } | private boolean METHOD_1 ( String path ) { File VAR_1 = new File ( path , VAR_3 ) ; return VAR_1 . exists ( ) && VAR_1 . METHOD_2 ( ) ; } |
interest TYPE_1 values ( ) | public void METHOD_1 ( ) throws Exception { <START> final List < TYPE_1 > VAR_1 = Arrays . asList ( TYPE_1 . VAR_2 , <END> TYPE_1 . VAR_3 , TYPE_1 . VAR_4 , TYPE_1 . VAR_5 ) ; VAR_6 . METHOD_2 ( VAR_1 ) ; VAR_1 . stream ( ) . forEach ( VAR_7 - > METHOD_3 ( VAR_8 ) . METHOD_4 ( VAR_7 . value ( ) ) ) ; } | public void METHOD_1 ( ) throws Exception { final List < TYPE_1 > VAR_1 = Arrays . asList ( TYPE_1 . values ( ) ) ; VAR_6 . METHOD_2 ( VAR_1 ) ; VAR_1 . stream ( ) . forEach ( VAR_7 - > METHOD_3 ( VAR_8 ) . METHOD_4 ( VAR_7 . value ( ) ) ) ; } |
interest TYPE_1 values ( ) | public void METHOD_1 ( ) throws Exception { <START> final List < TYPE_1 > VAR_1 = Arrays . asList ( TYPE_1 . VAR_2 , <END> TYPE_1 . VAR_3 , TYPE_1 . VAR_4 ) ; VAR_5 . METHOD_2 ( VAR_1 ) ; VAR_1 . stream ( ) . forEach ( VAR_6 - > METHOD_3 ( VAR_7 ) . METHOD_4 ( VAR_6 . value ( ) ) ) ; } | public void METHOD_1 ( ) throws Exception { final List < TYPE_1 > VAR_1 = Arrays . asList ( TYPE_1 . values ( ) ) ; VAR_5 . METHOD_2 ( VAR_1 ) ; VAR_1 . stream ( ) . forEach ( VAR_6 - > METHOD_3 ( VAR_7 ) . METHOD_4 ( VAR_6 . value ( ) ) ) ; } |
redundant line | public boolean METHOD_1 ( String VAR_1 ) { METHOD_2 ( ) ; <START> return true ; <END> } | public boolean METHOD_1 ( String VAR_1 ) { METHOD_2 ( ) ; return false ; } |
_CODE_ I line omitted | public void METHOD_1 ( ) { VAR_1 <START> . METHOD_2 ( VAR_2 - > true ) <END> . METHOD_3 ( VAR_3 - > ! TYPE_1 . contains ( VAR_3 ) ) ; } | public void METHOD_1 ( ) { VAR_1 . METHOD_3 ( VAR_3 - > ! TYPE_1 . contains ( VAR_3 ) ) ; } |
private method | <START> static < T , TYPE_1 > TYPE_2 < T , TYPE_3 < TYPE_1 > > METHOD_1 ( Class < ? > VAR_1 ) { <END> return t - > TYPE_3 . METHOD_1 ( STRING_1 + Optional . VAR_2 ( t ) . map ( o - > o . getClass ( ) . METHOD_2 ( ) ) . METHOD_3 ( STRING_2 + VAR_1 . METHOD_2 ( ) ) ) ; } | private static < T , TYPE_1 > TYPE_2 < T , TYPE_3 < TYPE_1 > > METHOD_1 ( Class < ? > VAR_1 ) { return t - > TYPE_3 . METHOD_1 ( STRING_1 + Optional . VAR_2 ( t ) . map ( o - > o . getClass ( ) . METHOD_2 ( ) ) . METHOD_3 ( STRING_2 + VAR_1 . METHOD_2 ( ) ) ) ; } |
Arrays asList ( VAR_1 split ( STRING_1 ) ) stream ( ) replaced Arrays stream ( VAR_1 split ( STRING_1 ) ) | public static TYPE_1 METHOD_1 ( String VAR_1 ) { if ( VAR_1 . isEmpty ( ) ) return new TYPE_1 ( ) ; else return new TYPE_1 ( <START> Arrays . asList ( VAR_1 . split ( STRING_1 ) ) . stream ( ) <END> . map ( TYPE_2 : : METHOD_1 ) . collect ( Collectors . VAR_2 ( ) ) ) ; } | public static TYPE_1 METHOD_1 ( String VAR_1 ) { if ( VAR_1 . isEmpty ( ) ) { return new TYPE_1 ( ) ; } else { return new TYPE_1 ( Arrays . stream ( VAR_1 . split ( STRING_1 ) ) . map ( TYPE_2 : : METHOD_1 ) . collect ( Collectors . VAR_2 ( ) ) ) ; } } |
method private | <START> void METHOD_1 ( String value ) { <END> if ( value == null || value . isEmpty ( ) ) { return ; } TYPE_1 input = input ( value ) ; METHOD_2 ( element ) . METHOD_3 ( ) . add ( ( TYPE_2 ) input . VAR_1 ( ) ) ; element . VAR_2 ( ) . add ( input ) ; } | private void METHOD_1 ( String value ) { if ( value == null || value . isEmpty ( ) ) { return ; } TYPE_1 input = input ( value ) ; METHOD_2 ( element ) . METHOD_3 ( ) . add ( ( TYPE_2 ) input . VAR_1 ( ) ) ; element . VAR_2 ( ) . add ( input ) ; } |
Arrays asList ( ) stream ( ) replaced Arrays stream ( ) | public static TYPE_1 METHOD_1 ( String VAR_1 ) { return new TYPE_1 ( <START> Arrays . asList ( VAR_1 . split ( STRING_1 ) ) . stream ( ) <END> . map ( TYPE_2 : : METHOD_1 ) . collect ( Collectors . VAR_2 ( ) ) ) ; } | public static TYPE_1 METHOD_1 ( String VAR_1 ) { return new TYPE_1 ( Arrays . stream ( VAR_1 . split ( STRING_1 ) ) . map ( TYPE_2 : : METHOD_1 ) . collect ( Collectors . VAR_2 ( ) ) ) ; } |
I d necessary simplified : METHOD_4 ( 0 0 VAR_2 100 ) ; | public void METHOD_1 ( ) throws Exception { VAR_1 . METHOD_2 ( column ) ; VAR_1 . METHOD_3 ( new TYPE_1 ( ) ) ; VAR_1 . METHOD_3 ( new TYPE_1 ( ) ) ; VAR_1 . METHOD_3 ( new TYPE_1 ( ) ) ; <START> METHOD_4 ( 0 , 0 , VAR_2 , FLOAT_1 ) ; <END> METHOD_4 ( 1 , 0 , VAR_2 , INT_1 ) ; METHOD_4 ( 2 , 0 , VAR_2 , INT_2 ) ; TYPE_... | public void METHOD_1 ( ) throws Exception { VAR_1 . METHOD_2 ( column ) ; VAR_1 . METHOD_3 ( new TYPE_1 ( ) ) ; VAR_1 . METHOD_3 ( new TYPE_1 ( ) ) ; VAR_1 . METHOD_3 ( new TYPE_1 ( ) ) ; METHOD_4 ( 0 , 0 , VAR_2 , 100 ) ; METHOD_4 ( 1 , 0 , VAR_2 , INT_1 ) ; METHOD_4 ( 2 , 0 , VAR_2 , INT_2 ) ; TYPE_2 . assertThat ( c... |
local variable values debugging purposes ? shorten statement : javareturn VAR_5 METHOD_2 ( ) stream ( ) map ( row - > row VAR_6 ( ) ( VAR_2 ) ) collect ( Collectors VAR_7 ( ) ) ; WDYT | private List < TYPE_1 > METHOD_1 ( final int VAR_1 ) { final int VAR_2 = VAR_1 - TYPE_2 . VAR_4 ; <START> final List < TYPE_1 > values = VAR_5 . METHOD_2 ( ) . stream ( ) . map ( row - > row . VAR_6 ( ) . get ( VAR_2 ) ) . collect ( Collectors . VAR_7 ( ) ) ; <END> return values ; } | private List < TYPE_1 > METHOD_1 ( final int VAR_1 ) { final int VAR_2 = VAR_1 - TYPE_2 . VAR_4 ; return VAR_5 . METHOD_2 ( ) . stream ( ) . map ( row - > row . VAR_6 ( ) . get ( VAR_2 ) ) . collect ( Collectors . VAR_7 ( ) ) ; } |
version more readable wanted ask noticed update : javafinal Optional < TYPE_1 > VAR_1 = METHOD_2 ( ) ; METHOD_2 declared : javaprivate Optional < TYPE_1 > METHOD_2 ( ) | protected void METHOD_1 ( ) { <START> final Optional < TYPE_1 > VAR_1 = METHOD_2 ( parent ) ; <END> VAR_2 . METHOD_3 ( new TYPE_2 ( VAR_3 . METHOD_4 ( ) , VAR_1 ) ) ; } | protected void METHOD_1 ( ) { final Optional < TYPE_1 > VAR_1 = METHOD_2 ( ) ; VAR_2 . METHOD_3 ( new TYPE_2 ( VAR_3 . METHOD_4 ( ) , VAR_1 ) ) ; } |
I guess null check nice _CODE_ ( a null ) ; b VAR_1 ( null ) ; METHOD_2 ( a b ) ; METHOD_2 ( b a ) ; | public void METHOD_1 ( ) { TYPE_1 < String > a = new TYPE_1 < > ( STRING_1 ) ; TYPE_1 < String > b = new TYPE_1 < > ( STRING_1 ) ; assertEquals ( a , b ) ; b . VAR_1 ( STRING_2 ) ; METHOD_2 ( a , b ) ; b . VAR_1 ( STRING_1 ) ; assertEquals ( a , b ) ; <START> } <END> | public void METHOD_1 ( ) { TYPE_1 < String > a = new TYPE_1 < > ( STRING_1 ) ; TYPE_1 < String > b = new TYPE_1 < > ( STRING_1 ) ; assertEquals ( a , b ) ; b . VAR_1 ( null ) ; METHOD_2 ( a , b ) ; b . VAR_1 ( STRING_2 ) ; METHOD_2 ( a , b ) ; b . VAR_1 ( STRING_1 ) ; assertEquals ( a , b ) ; } |
ll able return block reducing size method a | private static String METHOD_1 ( String VAR_1 ) { String VAR_2 = "" ; try { VAR_2 = TYPE_1 . toString ( TYPE_2 . class . METHOD_2 ( VAR_1 ) , TYPE_3 . VAR_4 ) ; } catch ( IOException e ) { <START> e . VAR_5 ( ) ; <END> } return VAR_2 ; } | private static String METHOD_1 ( String VAR_1 ) throws IOException { return TYPE_1 . toString ( TYPE_2 . class . METHOD_2 ( VAR_1 ) , TYPE_3 . VAR_4 ) ; } |
initialize fields declaration site ? opinion doesn t add ( sense constructors threw exceptions ) | public static void METHOD_1 ( ) { <START> VAR_1 = new TYPE_1 ( ) ; <END> VAR_2 = new TYPE_2 ( ) ; VAR_3 = new TYPE_3 ( ) ; VAR_4 = new TYPE_4 ( ) ; VAR_4 . METHOD_2 ( ) ; VAR_5 = new TYPE_5 ( new TYPE_6 ( ) , new TYPE_7 ( ) , new TYPE_8 ( ) ) ; VAR_6 = METHOD_3 ( STRING_1 ) ; VAR_7 = METHOD_3 ( STRING_2 ) ; VAR_8 = MET... | public static void METHOD_1 ( ) throws IOException { VAR_6 = METHOD_3 ( STRING_1 ) ; VAR_7 = METHOD_3 ( STRING_2 ) ; VAR_8 = METHOD_3 ( STRING_3 ) ; } |
catch some Exception - type ? I some _CODE_ | public void METHOD_1 ( ) { view . VAR_1 ( false ) ; String value = view . VAR_2 ( ) ; try { Date VAR_3 = view . VAR_4 ( value ) ; view . VAR_5 ( VAR_3 ) ; <START> } catch ( Exception e ) { <END> view . VAR_5 ( value ) ; } view . VAR_6 ( true ) ; } | public void METHOD_1 ( ) { view . VAR_1 ( false ) ; String value = view . VAR_2 ( ) ; try { Date VAR_3 = view . VAR_4 ( value ) ; view . VAR_5 ( VAR_3 ) ; } catch ( IllegalArgumentException e ) { view . VAR_5 ( value ) ; } view . VAR_6 ( true ) ; } |
passing METHOD_2 ( ) ( introducing local variable offset ) argument METHOD_4 ( ) improve readability | protected void update ( ) { this . view . clear ( ) ; this . METHOD_1 ( ) ; <START> int offset = METHOD_2 ( ) ; <END> this . METHOD_3 ( ) ; this . METHOD_4 ( this . filter , this . VAR_1 , offset , this . VAR_2 * this . VAR_3 , this : : METHOD_5 ) ; this . view . VAR_4 ( this . VAR_2 ) ; this . METHOD_6 ( ) ; } | protected void update ( ) { this . view . clear ( ) ; this . METHOD_1 ( ) ; this . METHOD_3 ( ) ; this . METHOD_4 ( this . filter , this . VAR_1 , METHOD_2 ( ) , this . VAR_2 * this . VAR_3 , this : : METHOD_5 ) ; this . view . VAR_4 ( this . VAR_2 ) ; this . METHOD_6 ( ) ; } |
please add access modifier private | <START> String METHOD_1 ( final TYPE_1 VAR_1 ) { <END> return VAR_2 . format ( TYPE_3 . TYPE_4 ) + STRING_1 + TYPE_2 . format ( VAR_1 . METHOD_1 ( ) ) ; } | private String METHOD_1 ( final TYPE_1 VAR_1 ) { return VAR_2 . format ( TYPE_3 . TYPE_4 ) + STRING_1 + TYPE_2 . format ( VAR_1 . METHOD_1 ( ) ) ; } |
inject | public TYPE_2 ( ) { <START> VAR_2 = new TYPE_1 ( ) ; <END> } | public TYPE_2 ( ) { } |
inject | public void METHOD_1 ( final TYPE_1 VAR_1 ) { <START> VAR_2 = new TYPE_2 ( ) ; <END> this . VAR_1 = VAR_1 ; METHOD_2 ( ) ; } | public void METHOD_1 ( final TYPE_1 VAR_1 ) { this . VAR_1 = VAR_1 ; METHOD_2 ( ) ; } |
( final ) | private TYPE_1 METHOD_1 ( String VAR_1 ) { <START> TYPE_1 VAR_2 = METHOD_2 ( ) . METHOD_3 ( VAR_1 ) ; <END> if ( VAR_2 == null ) { throw new RuntimeException ( STRING_1 + VAR_1 ) ; } return VAR_2 ; } | private TYPE_1 METHOD_1 ( String VAR_1 ) { final TYPE_1 VAR_2 = METHOD_2 ( ) . METHOD_3 ( VAR_1 ) ; if ( VAR_2 == null ) { throw new RuntimeException ( STRING_1 + VAR_1 ) ; } return VAR_2 ; } |
STRING_1 ? s | private void METHOD_1 ( final TYPE_1 error ) { <START> METHOD_2 ( error . VAR_1 ( ) instanceof TYPE_2 ? STRING_1 : error . getMessage ( ) ) ; <END> } | private void METHOD_1 ( final TYPE_1 error ) { METHOD_2 ( error ) ; } |
personal preference I return VAR_3 list METHOD_2 append argument I don t expect passed values change ( java ) | public static Optional < TYPE_1 > METHOD_1 ( String VAR_1 , String VAR_2 ) { List < String > VAR_3 = new ArrayList < > ( ) ; TYPE_2 . METHOD_2 ( TYPE_3 . get ( TYPE_4 . create ( VAR_4 + VAR_1 ) ) , <START> VAR_3 ) ; <END> List < TYPE_5 > VAR_5 = METHOD_3 ( VAR_3 , VAR_2 ) ; return METHOD_4 ( VAR_5 ) ; } | public static Optional < TYPE_1 > METHOD_1 ( String VAR_1 , String VAR_2 ) { List < String > VAR_3 = TYPE_2 . METHOD_2 ( TYPE_3 . get ( TYPE_4 . create ( VAR_4 + VAR_1 ) ) ) ; List < TYPE_5 > VAR_5 = METHOD_3 ( VAR_3 , VAR_2 ) ; return METHOD_4 ( VAR_5 ) ; } |
method assertion : METHOD_4 ( VAR_3 METHOD_5 ( METHOD_6 ( TYPE_2 class ) ) ) ; shouldn t ? METHOD_4 ( VAR_3 METHOD_5 ( VAR_2 ) ) ; | <START> public void METHOD_1 ( ) { <END> final TYPE_1 VAR_1 = new TYPE_1 ( ) ; final TYPE_2 VAR_2 = new TYPE_2 ( STRING_1 ) ; VAR_1 . METHOD_2 ( VAR_2 ) ; VAR_3 . METHOD_3 ( VAR_4 , VAR_1 , false ) ; METHOD_4 ( VAR_3 . METHOD_5 ( METHOD_6 ( TYPE_2 . class ) ) ) ; } | public void METHOD_1 ( ) { final TYPE_1 VAR_1 = new TYPE_1 ( ) ; final TYPE_2 VAR_2 = new TYPE_2 ( STRING_1 ) ; VAR_1 . METHOD_2 ( VAR_2 ) ; VAR_3 . METHOD_3 ( VAR_4 , VAR_1 , false ) ; METHOD_4 ( VAR_3 . METHOD_5 ( VAR_2 ) ) ; } |
need set text bounds setting fill gradient ? good reason [ ] ( ) potential public methods sets text bounds | public T METHOD_1 ( final Type type , final String VAR_1 , final String VAR_2 ) { this . VAR_3 = type ; this . VAR_4 = VAR_1 ; this . VAR_5 = VAR_2 ; if ( null != METHOD_2 ( ) ) { final TYPE_1 VAR_6 = METHOD_2 ( ) . METHOD_3 ( ) ; <START> VAR_7 . METHOD_4 ( VAR_6 ) ; <END> final double VAR_8 = VAR_6 . METHOD_5 ( ) ; fi... | public T METHOD_1 ( final Type type , final String VAR_1 , final String VAR_2 ) { this . VAR_3 = type ; this . VAR_4 = VAR_1 ; this . VAR_5 = VAR_2 ; if ( null != METHOD_2 ( ) ) { final TYPE_1 VAR_6 = METHOD_2 ( ) . METHOD_3 ( ) ; final double VAR_8 = VAR_6 . METHOD_5 ( ) ; final double VAR_9 = VAR_6 . METHOD_6 ( ) ; M... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.