ReviewComments stringlengths 1 2.35k | OriginalCode stringlengths 28 487 | ReviewedCode stringlengths 14 463 |
|---|---|---|
run METHOD_1 ( ) _CODE_ _CODE_ ( ) thread VAR_5 ? | public boolean close ( final long VAR_1 , final TimeUnit VAR_2 ) { METHOD_1 ( ) ; try { long VAR_3 = TimeUnit . VAR_4 . METHOD_2 ( VAR_1 , VAR_2 ) ; <START> Thread . VAR_5 ( VAR_3 ) ; <END> } catch ( InterruptedException e ) { VAR_6 . forEach ( VAR_7 - > { VAR_7 . METHOD_3 ( e ) ; } ) ; Thread . VAR_8 ( ) . METHOD_4 ( ... | public boolean close ( final long VAR_1 , final TimeUnit VAR_2 ) { METHOD_1 ( ) ; return true ; } |
package protected instead public | <START> public static String METHOD_1 ( TYPE_1 request ) { <END> return METHOD_2 ( request , TYPE_2 . VAR_2 ) ; } | protected static String METHOD_1 ( TYPE_1 request ) { return METHOD_2 ( request , TYPE_2 . VAR_2 ) ; } |
I some doubts change case attempt alter current TYPE_1 instance ( I agree s a practice ) creating a new instance setting singleton reference TYPE_1 altering test I suspect spotted travis CI test running due exclusions RESTEASY - 1935 | public Response METHOD_1 ( ) throws Exception { <START> TYPE_1 factory = TYPE_1 . METHOD_2 ( ) ; <END> factory . VAR_1 ( VAR_2 ) ; factory . VAR_1 ( VAR_3 ) ; return Response . VAR_4 ( STRING_1 ) . build ( ) ; } | public Response METHOD_1 ( ) throws Exception { TYPE_1 factory = TYPE_1 . getInstance ( ) ; factory . VAR_1 ( VAR_2 ) ; factory . VAR_1 ( VAR_3 ) ; return Response . VAR_4 ( STRING_1 ) . build ( ) ; } |
i18n log | public boolean METHOD_1 ( TYPE_1 context ) { if ( context . VAR_1 ( ) . METHOD_2 ( ) == TYPE_4 . VAR_3 ) return false ; TYPE_2 VAR_4 = TYPE_3 . METHOD_3 ( TYPE_2 . class ) ; if ( VAR_4 == null ) { <START> System . err . println ( STRING_1 + context . VAR_1 ( ) . METHOD_2 ( ) + STRING_2 ) ; <END> return false ; } VAR_4 ... | public boolean METHOD_1 ( TYPE_1 context ) { if ( context . VAR_1 ( ) . METHOD_2 ( ) == TYPE_4 . VAR_3 ) return false ; TYPE_2 VAR_4 = TYPE_3 . METHOD_3 ( TYPE_2 . VAR_5 ) ; if ( VAR_4 == null ) { return false ; } VAR_4 . METHOD_4 ( ) . put ( Context . VAR_5 , new Context ( ) ) ; return true ; } |
shouldn t synchronized | <START> public static void METHOD_1 ( String item ) { <END> VAR_1 . add ( item ) ; } | public static synchronized void METHOD_1 ( String item ) { VAR_1 . add ( item ) ; } |
need a Set internally relying a Map ? t simply ArrayList ? I don t care duplicates ( s internal abstraction ) ? basically I d affecting memory footprint considering object created invocation | public TYPE_2 ( ) { <START> this . VAR_2 = new TYPE_1 < > ( ) ; <END> } | public TYPE_2 ( ) { this . VAR_2 = new ArrayList < > ( ) ; } |
line ( VAR_3 = VAR_1 ; ) a bug fix stores a reference VAR_1 resource allowing close ( ) method nice catch | public void METHOD_1 ( ANNOTATION_1 TYPE_1 VAR_1 ) throws IOException { synchronized ( VAR_2 ) { if ( VAR_1 == null ) { throw new IllegalStateException ( STRING_1 ) ; <START> } <END> } VAR_3 = VAR_1 ; if ( VAR_4 == null ) { VAR_4 = VAR_5 . METHOD_2 ( ) ; } VAR_4 . METHOD_3 ( VAR_1 ) ; } | public void METHOD_1 ( ANNOTATION_1 TYPE_1 VAR_1 ) throws IOException { if ( VAR_1 == null ) { throw new IllegalStateException ( STRING_1 ) ; } VAR_3 = VAR_1 ; if ( VAR_4 == null ) { VAR_4 = VAR_5 . METHOD_2 ( ) ; } VAR_4 . METHOD_3 ( VAR_1 ) ; } |
missing ; ; - ) | public void VAR_1 ( TYPE_3 VAR_3 , Object VAR_4 ) { <START> VAR_3 . VAR_5 ( ) . VAR_6 ( TYPE_1 . entity ( VAR_4 == null ? null : new TYPE_2 < Object > ( VAR_4 , VAR_9 ) , VAR_10 , VAR_11 ) ) <END> } | public void VAR_1 ( TYPE_3 VAR_3 , Object VAR_4 ) { VAR_3 . VAR_5 ( ) . VAR_6 ( TYPE_1 . entity ( VAR_4 == null ? null : new TYPE_2 < Object > ( VAR_4 , VAR_9 ) , VAR_10 , VAR_11 ) ) ; } |
permissionnew TYPE_8 ( STRING_4 ) ) required test pass | public static TYPE_1 < ? > METHOD_1 ( ) { TYPE_2 VAR_1 = TYPE_3 . METHOD_2 ( TYPE_4 . class . METHOD_3 ( ) ) ; VAR_1 . METHOD_4 ( TYPE_4 . class ) ; <START> VAR_1 . METHOD_5 ( TYPE_5 . METHOD_6 ( <END> new TYPE_6 ( STRING_1 , STRING_2 ) , new TYPE_7 ( STRING_3 ) , new TYPE_8 ( STRING_4 ) , new TYPE_8 ( STRING_5 ) ) , S... | public static TYPE_1 < ? > METHOD_1 ( ) { TYPE_2 VAR_1 = TYPE_3 . METHOD_2 ( TYPE_4 . class . METHOD_3 ( ) ) ; VAR_1 . METHOD_4 ( TYPE_4 . class ) ; return TYPE_3 . METHOD_7 ( VAR_1 , null , TYPE_9 . class , TYPE_10 . class , TYPE_11 . class , TYPE_12 . class ) ; } |
a major problem rid System ? : - ) | public static TYPE_1 < ? > METHOD_1 ( ) { TYPE_2 VAR_1 = TYPE_3 . METHOD_2 ( TYPE_4 . class . METHOD_3 ( ) + STRING_1 ) ; VAR_1 . METHOD_4 ( TYPE_4 . class . METHOD_5 ( ) , STRING_2 , STRING_3 ) ; <START> System . out . println ( VAR_1 . toString ( true ) ) ; <END> return TYPE_3 . METHOD_6 ( VAR_1 , null , TYPE_5 . cla... | public static TYPE_1 < ? > METHOD_1 ( ) { TYPE_2 VAR_1 = TYPE_3 . METHOD_2 ( TYPE_4 . class . METHOD_3 ( ) + STRING_1 ) ; VAR_1 . METHOD_4 ( TYPE_4 . class . METHOD_5 ( ) , STRING_2 , STRING_3 ) ; return TYPE_3 . METHOD_6 ( VAR_1 , null , TYPE_5 . class ) ; } |
please | <START> public Response METHOD_1 ( TYPE_1 VAR_1 ) throws TYPE_2 { <END> logger . info ( VAR_1 . getName ( ) ) ; String name = STRING_1 ; boolean VAR_2 = false ; String VAR_3 = new String ( name . VAR_4 ( TYPE_3 . VAR_6 ) , TYPE_3 . VAR_6 ) ; if ( VAR_3 . METHOD_2 ( VAR_1 . getName ( ) ) == 0 ) { VAR_2 = true ; } return... | public Response METHOD_1 ( TYPE_1 VAR_1 ) { logger . info ( VAR_1 . getName ( ) ) ; String name = STRING_1 ; boolean VAR_2 = false ; String VAR_3 = new String ( name . VAR_4 ( TYPE_3 . VAR_6 ) , TYPE_3 . VAR_6 ) ; if ( VAR_3 . METHOD_2 ( VAR_1 . getName ( ) ) == 0 ) { VAR_2 = true ; } return VAR_2 ? Response . VAR_7 ( ... |
I ve a minor ( performance ) concern TYPE_3 code case xml escape ends done a 5 chars replacement ( double - quote ampersand - greater - xml apostrophe ) entity string scanned linearly _CODE_ slash replacement builds a pattern matches replaces manually create pattern provide a regexp matching 6 chars perform replacement... | public void filter ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) throws IOException { if ( TYPE_4 . VAR_4 == VAR_2 . getStatus ( ) ) { Object entity = VAR_2 . METHOD_1 ( ) ; if ( entity != null && entity instanceof String ) { <START> String VAR_5 = TYPE_3 . METHOD_2 ( ( String ) entity ) ; <END> String VAR_6 = VAR_5 . METHOD_3 ( STR... | public void filter ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) throws IOException { if ( TYPE_4 . VAR_4 == VAR_2 . getStatus ( ) ) { Object entity = VAR_2 . METHOD_1 ( ) ; if ( entity != null && entity instanceof String ) { String VAR_6 = METHOD_2 ( ( String ) entity ) ; VAR_2 . METHOD_4 ( VAR_6 ) ; } } } |
call super ( text ) applies constructor matchers empty | public TYPE_2 ( String text ) { <START> super ( TYPE_1 . getInstance ( ) . METHOD_1 ( text ) ) ; <END> } | public TYPE_2 ( String text ) { super ( text ) ; } |
please add method METHOD_1 ( TYPE_5 _CODE_ ) TYPE_5 VAR_3 enough cases | <START> public void METHOD_1 ( ) { <END> new TYPE_1 ( this ) . METHOD_2 ( ) ; new TYPE_2 ( new TYPE_3 ( VAR_1 ) ) ; new TYPE_2 ( new TYPE_4 ( ) , TYPE_5 . VAR_3 , false ) ; } | public void METHOD_1 ( ) { METHOD_1 ( TYPE_5 . VAR_3 ) ; } |
difference VAR_1 ! = null VAR_1 ! = null ? true : false IMHO simply call SWT API returns null active VAR_1 a find VAR_1 active | public boolean METHOD_1 ( ) { VAR_1 = TYPE_1 . getInstance ( ) . METHOD_2 ( ) ; <START> return VAR_1 != null ? true : false ; <END> } | public boolean METHOD_1 ( ) { VAR_1 = TYPE_1 . getInstance ( ) . METHOD_2 ( ) ; return VAR_1 != null ; } |
I wouldnt regex matcher a VAR_3 a special char matched properly | public TYPE_4 ( TYPE_1 VAR_2 , String VAR_3 ) { <START> super ( VAR_2 , 0 , new TYPE_2 ( new TYPE_3 ( VAR_3 + STRING_1 ) ) ) ; <END> } | public TYPE_4 ( TYPE_1 VAR_2 , String VAR_3 ) { super ( VAR_2 , 0 , new TYPE_2 ( VAR_3 ) ) ; } |
0 default other requirement choose positive range ( executed sooner ) negative range ( executed ) comparison default implementation | default long VAR_1 ( ) { <START> return 1 ; <END> } | default long VAR_1 ( ) { return 0 ; } |
logger | public void METHOD_1 ( Class < ? > VAR_1 ) { <START> System . out . println ( STRING_1 + VAR_1 . getName ( ) ) ; <END> METHOD_2 ( VAR_1 ) ; VAR_2 . add ( VAR_1 ) ; } | public void METHOD_1 ( Class < ? > VAR_1 ) { METHOD_2 ( VAR_1 ) ; VAR_2 . add ( VAR_1 ) ; } |
braces condition line | private boolean METHOD_1 ( final TYPE_1 VAR_1 ) { <START> if ( VAR_1 . METHOD_2 ( ) ) <END> return false ; return TYPE_2 . METHOD_3 ( new TYPE_3 < Boolean > ( ) { @Override public Boolean run ( ) { return ! ( ( VAR_1 instanceof TYPE_4 ) && ! ( ( TYPE_4 ) VAR_1 ) . METHOD_4 ( ) ) ; } } ) ; } | private boolean METHOD_1 ( final TYPE_1 VAR_1 ) { if ( VAR_1 . METHOD_2 ( ) ) { return false ; } return TYPE_2 . METHOD_3 ( new TYPE_3 < Boolean > ( ) { @Override public Boolean run ( ) { return ! ( ( VAR_1 instanceof TYPE_4 ) && ! ( ( TYPE_4 ) VAR_1 ) . METHOD_4 ( ) ) ; } } ) ; } |
roll changes handler check a VAR_1 disposed handler methods | public boolean METHOD_1 ( TYPE_1 VAR_1 ) { <START> if ( VAR_1 . METHOD_2 ( ) ) <END> return false ; boolean VAR_2 = true ; Object o = null ; try { o = TYPE_2 . METHOD_3 ( VAR_1 , STRING_1 ) ; } catch ( RuntimeException e ) { throw new TYPE_3 ( STRING_2 , e ) ; } if ( o instanceof Boolean ) { VAR_2 = ( ( Boolean ) o ) .... | public boolean METHOD_1 ( TYPE_1 VAR_1 ) { boolean VAR_2 = true ; Object o = null ; try { o = TYPE_2 . METHOD_3 ( VAR_1 , STRING_1 ) ; } catch ( RuntimeException e ) { throw new TYPE_3 ( STRING_2 , e ) ; } if ( o == null ) { return VAR_2 ; } if ( o instanceof Boolean ) { VAR_2 = ( ( Boolean ) o ) . METHOD_4 ( ) ; } ret... |
I pass - existing VAR_1 I some meaningful exception content assistant + VAR_1 + exist another case VAR_1 disabled - content assistant + VAR_1 + disabled | public TYPE_1 METHOD_1 ( String VAR_1 ) { METHOD_2 ( ) ; log . info ( STRING_1 + VAR_1 + STRING_2 ) ; TYPE_2 . METHOD_3 ( TYPE_8 . VAR_3 ) ; TYPE_3 [ ] VAR_4 = TYPE_4 . getInstance ( ) . METHOD_4 ( ) ; <START> new TYPE_5 ( STRING_3 , STRING_4 , VAR_1 ) . METHOD_5 ( ) ; <END> TYPE_6 VAR_5 = new TYPE_6 ( VAR_4 ) ; new TY... | public TYPE_1 METHOD_1 ( String VAR_1 ) { return METHOD_1 ( STRING_3 , STRING_4 , VAR_1 ) ; } |
METHOD_5 | public void METHOD_1 ( ) { TYPE_1 VAR_1 = TYPE_2 . METHOD_2 ( ) ; METHOD_3 ( VAR_1 . METHOD_4 ( ) . isEmpty ( ) ) ; <START> TYPE_3 . METHOD_5 ( TYPE_4 . VAR_3 ) ; <END> } | public void METHOD_1 ( ) { TYPE_1 VAR_1 = TYPE_2 . METHOD_2 ( ) ; METHOD_3 ( VAR_1 . METHOD_4 ( ) . isEmpty ( ) ) ; } |
waiting UI thread done fix | public void METHOD_1 ( ) { org . VAR_1 . VAR_2 . VAR_3 . VAR_4 . TYPE_5 . METHOD_2 ( new TYPE_1 ( ) { @Override public void run ( ) { for ( TYPE_2 VAR_6 : org . VAR_1 . VAR_2 . VAR_3 . VAR_4 . TYPE_5 . METHOD_3 ( ) . METHOD_4 ( ) ) { if ( VAR_6 . METHOD_5 ( ) . equals ( VAR_7 ) ) { VAR_6 . METHOD_6 ( ) ; break ; } } <S... | public void METHOD_1 ( ) { org . VAR_1 . VAR_2 . VAR_3 . VAR_4 . TYPE_5 . METHOD_2 ( new TYPE_1 ( ) { @Override public void run ( ) { for ( TYPE_2 VAR_6 : org . VAR_1 . VAR_2 . VAR_3 . VAR_4 . TYPE_5 . METHOD_3 ( ) . METHOD_4 ( ) ) { if ( VAR_6 . METHOD_5 ( ) . equals ( VAR_7 ) ) { VAR_6 . METHOD_6 ( ) ; break ; } } } ... |
call METHOD_1 ( text 0 ) instead TYPE_1 | public int METHOD_1 ( final String text ) { <START> return TYPE_1 . getInstance ( ) . METHOD_1 ( ( TYPE_2 ) METHOD_2 ( ) , text ) ; <END> } | public int METHOD_1 ( final String text ) { return METHOD_1 ( text , 0 ) ; } |
expression Math VAR_4 ( ( double ) VAR_1 \ * factor ) VAR_4 method return Integer VAR_2 input greater Integer VAR_2 s input parameter VAR_4 method evaluated float returns integer instead long | public long METHOD_1 ( ) { if ( VAR_1 == Long . VAR_2 || VAR_1 == 0 ) { return VAR_1 ; } if ( VAR_3 == 1 ) { return VAR_1 ; } if ( VAR_1 >= Long . VAR_2 / VAR_3 ) { return Long . VAR_2 ; } else { <START> return Math . VAR_4 ( VAR_1 * VAR_3 ) ; <END> } } | public long METHOD_1 ( ) { if ( VAR_1 == Long . VAR_2 || VAR_1 == 0 ) { return VAR_1 ; } if ( VAR_3 == 1 ) { return VAR_1 ; } if ( VAR_1 >= Long . VAR_2 / VAR_3 ) { return Long . VAR_2 ; } else { return Math . VAR_4 ( ( double ) VAR_1 * VAR_3 ) ; } } |
call constructors other please : TYPE_5 ( TYPE_1 type int count ) call ( type count new TYPE_3 [ ] { } ) logic VAR_4 field | public TYPE_5 ( TYPE_1 type , int count ) { if ( type == null ) { throw new TYPE_2 ( STRING_1 ) ; } if ( count < 0 ) { throw new IllegalArgumentException ( STRING_2 ) ; } this . VAR_2 = type ; this . VAR_3 = count ; <START> VAR_4 = new TYPE_3 [ ] { } ; <END> VAR_5 = new TYPE_4 ( ) ; } | public TYPE_5 ( TYPE_1 type , int count ) { this ( type , count , new TYPE_3 [ ] { } ) ; } |
catch please instead ( ! startsWith ( STRING_1 ) | private static TYPE_1 METHOD_1 ( String name ) { TYPE_1 VAR_1 ; <START> try { <END> VAR_1 = TYPE_1 . METHOD_1 ( name ) ; } catch ( TYPE_2 e ) { VAR_1 = TYPE_1 . METHOD_1 ( STRING_1 + name ) ; } return VAR_1 ; } | private static TYPE_1 METHOD_1 ( String name ) { if ( name . startsWith ( STRING_1 ) ) { return TYPE_1 . METHOD_1 ( name ) ; } else { return TYPE_1 . METHOD_1 ( STRING_1 + name ) ; } } |
I able find case File - > save menu enabled im wondering s ? line 37 calling shell menu File - > properties clicking needless operation | <START> public void METHOD_1 ( ) { <END> new TYPE_1 ( STRING_1 , STRING_2 ) . METHOD_2 ( ) ; new TYPE_1 ( STRING_1 , STRING_3 ) . METHOD_2 ( ) ; new TYPE_2 ( STRING_4 ) . METHOD_3 ( ) ; } | public void METHOD_1 ( ) { new TYPE_1 ( STRING_1 , STRING_2 ) . METHOD_2 ( ) ; } |
METHOD_2 можно вынести из ifи можно написать VAR_2 METHOD_4 ( VAR_1 ) и по аналогии для других | public void METHOD_1 ( boolean VAR_1 ) { if ( VAR_1 ) { this . METHOD_2 ( ) ; this . METHOD_3 ( VAR_2 ) ; VAR_2 . METHOD_4 ( true ) ; VAR_3 . METHOD_4 ( true ) ; this . METHOD_3 ( VAR_4 ) ; this . METHOD_3 ( VAR_5 ) ; } else { this . METHOD_2 ( ) ; VAR_2 . METHOD_4 ( false ) ; VAR_3 . METHOD_4 ( false ) ; this . METHOD... | public void METHOD_1 ( boolean VAR_1 ) { this . METHOD_2 ( ) ; this . METHOD_3 ( VAR_4 ) ; this . METHOD_3 ( VAR_5 ) ; if ( VAR_1 ) { this . METHOD_3 ( VAR_2 ) ; VAR_2 . METHOD_4 ( true ) ; VAR_3 . METHOD_4 ( true ) ; } else { VAR_2 . METHOD_4 ( false ) ; VAR_3 . METHOD_4 ( false ) ; } } |
я вообще думал что выстрел будет делаться такgun METHOD_1 ( ) ; т е VAR_2 METHOD_2 ( ) METHOD_3 ( ) METHOD_5 ( VAR_1 METHOD_6 ( ) VAR_1 METHOD_7 ( ) ) ; выполнять в методе класса TYPE_1 | private void METHOD_1 ( ) { TYPE_1 VAR_1 = VAR_2 . METHOD_2 ( ) . METHOD_3 ( ) . METHOD_4 ( ) ; VAR_2 . METHOD_2 ( ) . METHOD_3 ( ) . METHOD_5 ( VAR_1 . METHOD_6 ( ) <START> , VAR_1 . METHOD_7 ( ) ) ; <END> } | private void METHOD_1 ( ) { METHOD_4 ( ) . METHOD_1 ( ) ; } |
часто повторяется лучше сделать метод METHOD_4 в классе _CODE_ или events | private void METHOD_1 ( ) { <START> TYPE_1 VAR_1 = VAR_2 . METHOD_2 ( ) . METHOD_3 ( ) . METHOD_4 ( ) ; <END> VAR_1 . METHOD_5 ( ) ; } | private void METHOD_1 ( ) { METHOD_4 ( ) . METHOD_5 ( ) ; } |
remove explicit initialization | public List < String > METHOD_1 ( ) throws IOException { TYPE_1 reader = new TYPE_1 ( new TYPE_2 ( VAR_1 ) ) ; List < String > VAR_2 = new ArrayList < String > ( ) ; <START> String line ; <END> while ( ( line = reader . VAR_3 ( ) ) != null ) { VAR_2 . add ( line ) ; } return VAR_2 ; } | public List < String > METHOD_1 ( ) throws IOException { TYPE_1 reader = new TYPE_1 ( new TYPE_2 ( VAR_1 ) ) ; List < String > VAR_2 = new ArrayList < String > ( ) ; String line = null ; while ( ( line = reader . VAR_3 ( ) ) != null ) { VAR_2 . add ( line ) ; } return VAR_2 ; } |
please dont remove explicit initialization | private String METHOD_1 ( TYPE_1 VAR_1 ) throws IOException { TYPE_2 VAR_2 = new TYPE_2 ( new TYPE_3 ( VAR_1 ) ) ; TYPE_4 writer = new TYPE_4 ( ) ; <START> String line ; <END> while ( ( line = VAR_2 . METHOD_2 ( ) ) != null ) { if ( line . isEmpty ( ) ) { break ; } writer . write ( line ) ; writer . write ( CHAR_1 ) ; ... | private String METHOD_1 ( TYPE_1 VAR_1 ) throws IOException { TYPE_2 VAR_2 = new TYPE_2 ( new TYPE_3 ( VAR_1 ) ) ; TYPE_4 writer = new TYPE_4 ( ) ; String line = null ; while ( ( line = VAR_2 . METHOD_2 ( ) ) != null ) { if ( line . isEmpty ( ) ) { break ; } writer . write ( line ) ; writer . write ( CHAR_1 ) ; } retur... |
please dont remove explicit initialization | public String METHOD_1 ( ) { <START> String content ; <END> try { final TYPE_1 VAR_1 = TYPE_2 . class . METHOD_2 ( VAR_2 ) ; content = TYPE_3 . METHOD_3 ( VAR_1 , TYPE_3 . VAR_3 ) ; } catch ( Throwable e ) { e . VAR_4 ( ) ; throw new RuntimeException ( STRING_1 + VAR_2 + STRING_2 + e . getMessage ( ) ) ; } return conte... | public String METHOD_1 ( ) { String content = null ; try { final TYPE_1 VAR_1 = TYPE_2 . class . METHOD_2 ( VAR_2 ) ; content = TYPE_3 . METHOD_3 ( VAR_1 , TYPE_3 . VAR_3 ) ; } catch ( Throwable e ) { e . VAR_4 ( ) ; throw new RuntimeException ( STRING_1 + VAR_2 + STRING_2 + e . getMessage ( ) ) ; } return content ; } |
please dont remove explicit initialization | public static List < String > METHOD_1 ( TYPE_1 in ) throws IOException { Assert . VAR_1 ( in ) ; List < String > VAR_2 = new ArrayList < String > ( ) ; TYPE_2 VAR_3 = new TYPE_2 ( new TYPE_3 ( in ) ) ; try { <START> for ( TYPE_4 VAR_4 ; ( VAR_4 = VAR_3 . METHOD_2 ( ) ) != null ; ) { <END> VAR_2 . add ( VAR_4 . getName... | public static List < String > METHOD_1 ( TYPE_1 in ) throws IOException { Assert . VAR_1 ( in ) ; List < String > VAR_2 = new ArrayList < String > ( ) ; TYPE_2 VAR_3 = new TYPE_2 ( new TYPE_3 ( in ) ) ; try { for ( TYPE_4 VAR_4 = null ; ( VAR_4 = VAR_3 . METHOD_2 ( ) ) != null ; ) { VAR_2 . add ( VAR_4 . getName ( ) ) ... |
please dont remove explicit initialization | public void METHOD_1 ( ) throws TYPE_1 { <START> TYPE_2 VAR_1 ; <END> try { VAR_1 = TYPE_3 . METHOD_2 ( user ) ; TYPE_4 . METHOD_3 ( VAR_1 ) ; assertThat ( VAR_1 . METHOD_4 ( ) ) . METHOD_5 ( ) ; VAR_1 . METHOD_6 ( ) ; METHOD_7 ( STRING_1 ) ; } catch ( TYPE_5 e ) { } } | public void METHOD_1 ( ) throws TYPE_1 { TYPE_2 VAR_1 = null ; try { VAR_1 = TYPE_3 . METHOD_2 ( user ) ; TYPE_4 . METHOD_3 ( VAR_1 ) ; assertThat ( VAR_1 . METHOD_4 ( ) ) . METHOD_5 ( ) ; VAR_1 . METHOD_6 ( ) ; METHOD_7 ( STRING_1 ) ; } catch ( TYPE_5 e ) { } } |
please dont remove explicit initialization | private TYPE_1 METHOD_1 ( String VAR_1 ) throws Exception { int VAR_2 = new TYPE_2 ( ) . METHOD_2 ( INT_1 * INT_2 ) + INT_2 ; <START> TYPE_1 VAR_3 ; <END> if ( VAR_1 == null ) { VAR_3 = new TYPE_1 ( VAR_2 ) ; } else { VAR_3 = new TYPE_1 ( VAR_2 , null , VAR_1 ) ; } VAR_3 . start ( ) ; return VAR_3 ; } | private TYPE_1 METHOD_1 ( String VAR_1 ) throws Exception { int VAR_2 = new TYPE_2 ( ) . METHOD_2 ( INT_1 * INT_2 ) + INT_2 ; TYPE_1 VAR_3 = null ; if ( VAR_1 == null ) { VAR_3 = new TYPE_1 ( VAR_2 ) ; } else { VAR_3 = new TYPE_1 ( VAR_2 , null , VAR_1 ) ; } VAR_3 . start ( ) ; return VAR_3 ; } |
some config attributes express conf overload set usernamepublic TYPE_1 < TYPE_2 > METHOD_1 ( String VAR_2 ) { return new TYPE_2 ( config _CODE_ ( ) VAR_2 VAR_3 ) ; } | <START> public TYPE_1 < TYPE_2 > METHOD_1 ( String VAR_1 , String VAR_2 ) { <END> return new TYPE_2 ( VAR_1 , VAR_2 , this . VAR_3 ) ; } | public TYPE_2 METHOD_1 ( String VAR_1 , String VAR_2 ) { return new TYPE_2 ( VAR_1 , VAR_2 , VAR_3 , configuration ) ; } |
I doesnt matter nitpicking : local vars - initialized good practice initialize a defined doesnt matter code | public List < String > METHOD_1 ( TYPE_1 channel ) throws IOException { TYPE_2 reader = new TYPE_2 ( new TYPE_3 ( METHOD_2 ( channel ) ) ) ; List < String > VAR_1 = new ArrayList < String > ( ) ; <START> String line ; <END> while ( ( line = reader . VAR_2 ( ) ) != null ) { VAR_1 . add ( line ) ; } return VAR_1 ; } | public List < String > METHOD_1 ( TYPE_1 channel ) throws IOException { TYPE_2 reader = new TYPE_2 ( new TYPE_3 ( METHOD_2 ( channel ) ) ) ; List < String > VAR_1 = new ArrayList < String > ( ) ; String line = null ; while ( ( line = reader . VAR_2 ( ) ) != null ) { VAR_1 . add ( line ) ; } return VAR_1 ; } |
checking env map null more ( initialize empty map ) | protected void METHOD_1 ( ) throws TYPE_1 { if ( ! METHOD_2 ( ) ) { return ; } <START> if ( VAR_1 == null ) { <END> VAR_1 = METHOD_3 ( ) ; } else { VAR_1 . clear ( ) ; VAR_1 . METHOD_4 ( METHOD_3 ( ) ) ; } } | protected void METHOD_1 ( ) throws TYPE_1 { if ( ! METHOD_2 ( ) ) return ; else { VAR_1 . clear ( ) ; VAR_1 = METHOD_3 ( ) ; } } |
simpler don t ? return ( VAR_1 ! = null ) && VAR_1 METHOD_4 ( ) ; | private boolean METHOD_1 ( ) { TYPE_1 VAR_1 = ( TYPE_1 ) METHOD_2 ( ) . METHOD_3 ( Context . VAR_2 ) ; <START> if ( VAR_1 != null ) { return VAR_1 . METHOD_4 ( ) ; } else { return false ; } <END> } | private boolean METHOD_1 ( ) { TYPE_1 VAR_1 = ( TYPE_1 ) METHOD_2 ( ) . METHOD_3 ( Context . VAR_2 ) ; return ( VAR_1 != null ) && VAR_1 . METHOD_4 ( ) ; } |
instead switch 2 options 👍 | protected void METHOD_1 ( TYPE_1 VAR_1 ) { super . METHOD_1 ( VAR_1 ) ; VAR_2 = this ; METHOD_2 ( ) ; if ( METHOD_3 ( ) ) { VAR_3 = new TYPE_4 . TYPE_5 ( VAR_4 ) ; } TYPE_3 VAR_5 = TYPE_3 . from ( this ) ; <START> switch ( VAR_5 . METHOD_4 ( ) ) { case TYPE_3 . VAR_6 : METHOD_5 ( ) ; <END> break ; default : METHOD_6 ( ... | protected void METHOD_1 ( TYPE_1 VAR_1 ) { super . METHOD_1 ( VAR_1 ) ; VAR_2 = this ; METHOD_2 ( ) ; if ( METHOD_3 ( ) ) { VAR_3 = new TYPE_4 . TYPE_5 ( VAR_4 ) ; } TYPE_3 VAR_5 = TYPE_3 . from ( this ) ; if ( VAR_5 . METHOD_4 ( ) == TYPE_3 . VAR_6 ) { METHOD_5 ( ) ; } else { METHOD_6 ( ) ; } } |
private | <START> public boolean METHOD_1 ( ) { <END> TYPE_1 VAR_1 = TYPE_2 . METHOD_2 ( TYPE_4 . TYPE_5 . METHOD_3 ( ) ) ; return ( VAR_1 . METHOD_4 ( TYPE_6 . VAR_3 , false ) ) ; } | protected boolean METHOD_1 ( ) { TYPE_1 VAR_1 = TYPE_2 . METHOD_2 ( TYPE_4 . TYPE_5 . METHOD_3 ( ) ) ; return ( VAR_1 . METHOD_4 ( TYPE_6 . VAR_3 , false ) ) ; } |
protected needed android studio warns ! [ screenshot 2019 - 03 - 13 17 28 17 ] ( ) | <START> protected boolean METHOD_1 ( ) { <END> TYPE_1 args = METHOD_2 ( ) ; return ( ( args != null ) && args . VAR_1 ( VAR_2 , false ) ) ; } | boolean METHOD_1 ( ) { TYPE_1 args = METHOD_2 ( ) ; return ( ( args != null ) && args . VAR_1 ( VAR_2 , false ) ) ; } |
need check | private void METHOD_1 ( ) { final String VAR_1 = ( String ) METHOD_2 ( R . string . VAR_2 ) ; <START> if ( VAR_1 != null && VAR_1 . length ( ) > 0 ) { <END> TYPE_1 VAR_3 = new TYPE_1 ( TYPE_1 . VAR_4 , TYPE_2 . parse ( VAR_1 ) ) ; METHOD_3 ( VAR_3 ) ; } } | private void METHOD_1 ( ) { final String VAR_1 = ( String ) METHOD_2 ( R . string . VAR_2 ) ; TYPE_1 VAR_3 = new TYPE_1 ( TYPE_1 . VAR_4 , TYPE_2 . parse ( VAR_1 ) ) ; METHOD_3 ( VAR_3 ) ; } |
isn t a STRING_1 instead a hardcoded string | public void METHOD_1 ( TYPE_1 VAR_1 ) { super . METHOD_1 ( VAR_1 ) ; if ( VAR_1 . METHOD_2 ( ) . equals ( VAR_2 ) && <START> VAR_1 . METHOD_3 ( ) . METHOD_4 ( ) . equals ( STRING_1 ) ) { <END> METHOD_5 ( VAR_1 . METHOD_3 ( ) ) ; } } | public void METHOD_1 ( TYPE_1 VAR_1 ) { super . METHOD_1 ( VAR_1 ) ; if ( VAR_1 . METHOD_2 ( ) . equals ( VAR_2 ) ) { METHOD_5 ( VAR_1 . METHOD_3 ( ) ) ; } } |
move else } | public void METHOD_1 ( View v ) { if ( v . getId ( ) == R . id . VAR_1 ) { METHOD_2 ( VAR_2 ) ; METHOD_3 ( ) ; } <START> else if ( v . getId ( ) == R . id . VAR_3 ) { <END> new TYPE_1 ( ) . execute ( ) ; } } | public void METHOD_1 ( View v ) { if ( v . getId ( ) == R . id . VAR_1 ) { METHOD_2 ( VAR_2 ) ; METHOD_3 ( ) ; } else if ( v . getId ( ) == R . id . VAR_3 ) { new TYPE_1 ( null ) . execute ( ) ; } } |
instead declaring VAR_9 global declare initialize pass TYPE_5 ( ) answer ( url ) | protected void METHOD_1 ( int VAR_1 , int VAR_2 , TYPE_1 VAR_3 ) { if ( VAR_1 == VAR_4 && VAR_2 == VAR_5 ) { TYPE_2 VAR_6 = VAR_3 . METHOD_2 ( ) ; TYPE_3 VAR_7 = ( TYPE_3 ) VAR_6 . get ( STRING_1 ) ; TYPE_4 VAR_8 = METHOD_3 ( METHOD_4 ( ) , VAR_7 ) ; <START> VAR_9 = METHOD_5 ( VAR_8 ) ; <END> new TYPE_5 ( ) . execute (... | protected void METHOD_1 ( int VAR_1 , int VAR_2 , TYPE_1 VAR_3 ) { if ( VAR_1 == VAR_4 && VAR_2 == VAR_5 ) { TYPE_2 VAR_6 = VAR_3 . METHOD_2 ( ) ; TYPE_3 VAR_7 = ( TYPE_3 ) VAR_6 . get ( STRING_1 ) ; TYPE_4 VAR_8 = METHOD_3 ( METHOD_4 ( ) , VAR_7 ) ; String VAR_9 = METHOD_5 ( VAR_8 ) ; new TYPE_5 ( VAR_9 ) . execute ( ... |
I add a NULL check VAR_2 condition | public long METHOD_1 ( ) { long VAR_1 = - 1 ; <START> if ( VAR_2 . METHOD_2 ( ) . METHOD_3 ( ) ) { <END> VAR_1 = TYPE_1 . METHOD_4 ( new Date ( ) , VAR_2 . METHOD_5 ( ) ) . METHOD_6 ( ) ; } return VAR_1 ; } | private long METHOD_1 ( ) { long VAR_1 = - 1 ; if ( VAR_2 != null && VAR_2 . METHOD_2 ( ) . METHOD_3 ( ) ) { VAR_1 = TYPE_1 . METHOD_4 ( new Date ( ) , VAR_2 . METHOD_5 ( ) ) . METHOD_6 ( ) ; } return VAR_1 ; } |
I simplify toreturn ( VAR_5 ! = null && VAR_5 METHOD_3 ( ) ) _CODE_ variable declared assigned easier condition | public static boolean METHOD_1 ( Context context ) { boolean VAR_1 = true ; TYPE_1 VAR_2 = ( TYPE_1 ) context . VAR_3 ( Context . VAR_4 ) ; TYPE_2 VAR_5 = VAR_2 . METHOD_2 ( ) ; <START> if ( VAR_5 == null || ( VAR_5 != null && <END> ! VAR_5 . METHOD_3 ( ) ) ) { VAR_1 = false ; } return VAR_1 ; } | public static boolean METHOD_1 ( Context context ) { TYPE_1 VAR_2 = ( TYPE_1 ) context . VAR_3 ( Context . VAR_4 ) ; TYPE_2 VAR_5 = VAR_2 . METHOD_2 ( ) ; return ( VAR_5 != null && VAR_5 . METHOD_3 ( ) ) ; } |
difference depending API level ? curious | public void METHOD_1 ( ) { super . METHOD_1 ( ) ; TYPE_1 . v ( TAG , STRING_1 ) ; <START> if ( ( TYPE_2 . VAR_2 <= INT_1 || VAR_3 == null ) ) { <END> METHOD_2 ( ) ; } } | public void METHOD_1 ( ) { super . METHOD_1 ( ) ; TYPE_1 . v ( TAG , STRING_1 ) ; METHOD_2 ( ) ; } |
general TYPE_3 s shouldn t cached - input block tested prevent occurs | private void METHOD_1 ( TYPE_1 VAR_1 ) { TYPE_2 file = VAR_1 . METHOD_2 ( ) . METHOD_3 ( VAR_2 ) ; try { if ( file . equals ( VAR_3 ) ) { METHOD_4 ( true ) ; } } <START> catch ( TYPE_3 e ) { <END> TYPE_4 . e ( TAG , STRING_1 , e ) ; } } | private void METHOD_1 ( TYPE_1 VAR_1 ) { TYPE_2 file = VAR_1 . METHOD_2 ( ) . METHOD_3 ( VAR_2 ) ; if ( file != null && file . equals ( VAR_3 ) ) { METHOD_4 ( true ) ; } } |
VAR_3 set a single line real need VAR_3 variable _CODE_ parameter pass METHOD_5 | public void METHOD_1 ( TYPE_1 VAR_1 , boolean VAR_2 ) { if ( ! METHOD_2 ( ) ) { return ; } <START> boolean VAR_3 ; <END> if ( VAR_2 ) { VAR_3 = true ; } else { VAR_3 = false ; } ( ( TYPE_2 ) METHOD_3 ( ) ) . METHOD_4 ( ) . METHOD_5 ( VAR_4 , VAR_3 ) ; ; VAR_1 . METHOD_6 ( null ) ; VAR_1 . METHOD_7 ( ) ; VAR_1 . METHOD_... | public void METHOD_1 ( TYPE_1 VAR_1 , boolean VAR_2 ) { if ( ! METHOD_2 ( ) ) { return ; } ( ( TYPE_2 ) METHOD_3 ( ) ) . METHOD_4 ( ) . METHOD_5 ( VAR_4 , VAR_2 ) ; ; VAR_1 . METHOD_6 ( null ) ; VAR_1 . METHOD_7 ( ) ; VAR_1 . METHOD_6 ( VAR_5 ) ; } |
method written a single line ; check reference _CODE_ returns null key doesn t ( java lang Object ) | public static TYPE_1 METHOD_1 ( String VAR_1 ) { <START> if ( VAR_2 . containsKey ( VAR_1 ) ) { <END> return VAR_2 . get ( VAR_1 ) ; } return null ; } | public static TYPE_1 METHOD_1 ( String VAR_1 ) { return VAR_2 . get ( VAR_1 ) ; } |
early return | public boolean METHOD_1 ( TYPE_1 item ) { super . METHOD_1 ( item ) ; switch ( item . VAR_1 ( ) ) { case VAR_2 . R . id . VAR_3 : METHOD_2 ( ) ; <START> break ; <END> default : TYPE_2 . METHOD_3 ( TAG , STRING_1 ) ; return false ; } return true ; } | public boolean METHOD_1 ( TYPE_1 item ) { super . METHOD_1 ( item ) ; switch ( item . VAR_1 ( ) ) { case VAR_2 . R . id . VAR_3 : METHOD_2 ( ) ; return true ; default : TYPE_2 . METHOD_3 ( TAG , STRING_1 ) ; return false ; } } |
I methods private | <START> public static void METHOD_1 ( String key , boolean value , Context context ) { <END> TYPE_2 . TYPE_3 VAR_1 = METHOD_2 ( context . VAR_2 ( ) ) . METHOD_3 ( ) ; VAR_1 . METHOD_4 ( key , value ) ; VAR_1 . apply ( ) ; } | private static void METHOD_1 ( String key , boolean value , Context context ) { TYPE_2 . TYPE_3 VAR_1 = METHOD_2 ( context . VAR_2 ( ) ) . METHOD_3 ( ) ; VAR_1 . METHOD_4 ( key , value ) ; VAR_1 . apply ( ) ; } |
didn t check mplementation sense null check result result VAR_4 ( ) result _CODE_ ( ) ( 0 ) null safe design | protected TYPE_1 run ( TYPE_2 client ) { TYPE_3 VAR_1 = new TYPE_3 ( ) ; TYPE_1 result = VAR_1 . execute ( client ) ; <START> if ( result . VAR_2 ( ) ) { <END> TYPE_4 VAR_3 = ( TYPE_4 ) result . VAR_4 ( ) . get ( 0 ) ; METHOD_1 ( ) . METHOD_2 ( VAR_3 ) ; } return result ; } | protected TYPE_1 run ( TYPE_2 client ) { TYPE_3 VAR_1 = new TYPE_3 ( ) ; TYPE_1 result = VAR_1 . execute ( client ) ; if ( result . VAR_2 ( ) ) { if ( result . VAR_4 ( ) != null && result . VAR_4 ( ) . size ( ) > 0 ) { TYPE_4 VAR_3 = ( TYPE_4 ) result . VAR_4 ( ) . get ( 0 ) ; METHOD_1 ( ) . METHOD_2 ( VAR_3 ) ; } } re... |
code fragment line 325ff | public void METHOD_1 ( TYPE_1 VAR_1 ) { METHOD_2 ( VAR_1 ) ; METHOD_3 ( ) ; METHOD_4 ( VAR_1 , false ) ; TYPE_2 VAR_2 = VAR_3 . METHOD_5 ( R . id . VAR_4 ) ; METHOD_6 ( ) ; <START> if ( TYPE_3 . METHOD_7 ( VAR_1 , METHOD_8 ( ) ) ) { <END> METHOD_9 ( ) ; } else { METHOD_10 ( ) ; } } | public void METHOD_1 ( TYPE_1 VAR_1 ) { METHOD_2 ( VAR_1 ) ; METHOD_3 ( ) ; METHOD_4 ( VAR_1 , false ) ; } |
variable ; please remove line | public void METHOD_1 ( TYPE_1 VAR_1 ) { METHOD_2 ( VAR_1 ) ; METHOD_3 ( ) ; METHOD_4 ( VAR_1 , false ) ; <START> TYPE_2 VAR_2 = VAR_3 . METHOD_5 ( R . id . VAR_4 ) ; <END> METHOD_6 ( ) ; METHOD_7 ( VAR_1 ) ; } | public void METHOD_1 ( TYPE_1 VAR_1 ) { METHOD_2 ( VAR_1 ) ; METHOD_3 ( ) ; METHOD_4 ( VAR_1 , false ) ; } |
variable ; please remove line | public boolean METHOD_1 ( TYPE_1 VAR_1 ) { TYPE_2 VAR_2 = METHOD_2 ( ) ; VAR_2 . METHOD_3 ( R . VAR_1 . VAR_3 , VAR_1 ) ; VAR_4 = VAR_1 ; <START> TYPE_3 VAR_5 = VAR_4 . METHOD_4 ( R . id . VAR_6 ) ; <END> METHOD_5 ( ) ; return true ; } | public boolean METHOD_1 ( TYPE_1 VAR_1 ) { TYPE_2 VAR_2 = METHOD_2 ( ) ; VAR_2 . METHOD_3 ( R . VAR_1 . VAR_3 , VAR_1 ) ; return true ; } |
attributie needed ; please remove | public TYPE_4 ( TYPE_1 VAR_2 ) { VAR_3 = VAR_2 . METHOD_1 ( ) ; VAR_4 = new TYPE_2 < TYPE_3 > ( ( TYPE_3 ) VAR_2 ) ; <START> VAR_5 = VAR_2 ; <END> } | public TYPE_4 ( TYPE_1 VAR_2 ) { VAR_3 = VAR_2 . METHOD_1 ( ) ; VAR_4 = new TYPE_2 < TYPE_3 > ( ( TYPE_3 ) VAR_2 ) ; } |
I d change line a mistake solving conflicts | public void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 file ) { TYPE_3 VAR_2 = null ; synchronized ( VAR_3 ) { VAR_2 = VAR_3 . remove ( METHOD_2 ( VAR_1 , file ) ) ; } if ( VAR_2 != null ) { <START> VAR_4 . METHOD_1 ( ) ; <END> } } | public void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 file ) { TYPE_3 VAR_2 = null ; synchronized ( VAR_3 ) { VAR_2 = VAR_3 . remove ( METHOD_2 ( VAR_1 , file ) ) ; } if ( VAR_2 != null ) { VAR_2 . METHOD_1 ( ) ; } } |
VAR_3 METHOD_4 ( ) pass | private void METHOD_1 ( TYPE_1 client ) { METHOD_2 ( ) ; METHOD_3 ( VAR_1 , client ) ; METHOD_3 ( VAR_2 , client ) ; <START> METHOD_4 ( VAR_3 , client ) ; <END> } | private void METHOD_1 ( TYPE_1 client ) { METHOD_2 ( ) ; METHOD_3 ( VAR_1 , client ) ; METHOD_3 ( VAR_2 , client ) ; METHOD_4 ( client ) ; } |
I d METHOD_2 ( ) applied substring ( ) | private static String METHOD_1 ( String VAR_1 ) { <START> String VAR_2 = VAR_1 . METHOD_2 ( ) . substring ( VAR_1 . METHOD_3 ( STRING_1 ) + 1 ) ; <END> return VAR_2 ; } | private static String METHOD_1 ( String VAR_1 ) { String VAR_2 = VAR_1 . substring ( VAR_1 . METHOD_3 ( STRING_1 ) + 1 ) . METHOD_2 ( ) ; return VAR_2 ; } |
please don t reload text METHOD_1 ( ) _CODE_ ( ) _CODE_ ( ) ; _CODE_ ( ) METHOD_1 ( ) called other windows partially hide fragment ( menu showing apps open file _CODE_ ) stays visible | public void METHOD_1 ( ) { super . METHOD_1 ( ) ; TYPE_1 . e ( TAG , STRING_1 ) ; <START> METHOD_2 ( ) ; <END> } | public void METHOD_1 ( ) { super . METHOD_1 ( ) ; TYPE_1 . e ( TAG , STRING_1 ) ; } |
check user clicks item ( info ) highlighted others a good behaviour | public void METHOD_1 ( View VAR_1 ) { <START> VAR_2 . METHOD_2 ( VAR_1 ) ; <END> VAR_2 . METHOD_3 ( ) ; } | public void METHOD_1 ( View VAR_1 ) { VAR_2 . METHOD_2 ( VAR_1 , null , false ) ; VAR_2 . METHOD_3 ( ) ; } |
call super METHOD_1 ( ) ; | public void METHOD_1 ( TYPE_1 view , int VAR_1 , String description , String VAR_2 ) { TYPE_2 . e ( TAG , STRING_1 + VAR_2 + STRING_2 + VAR_1 + STRING_3 + description ) ; if ( ! VAR_2 . equals ( VAR_3 ) ) { view . VAR_4 ( ) ; VAR_3 = VAR_2 ; <START> } else { <END> VAR_3 = null ; } } | public void METHOD_1 ( TYPE_1 view , int VAR_1 , String description , String VAR_2 ) { TYPE_2 . e ( TAG , STRING_1 + VAR_2 + STRING_2 + VAR_1 + STRING_3 + description ) ; if ( ! VAR_2 . equals ( VAR_3 ) ) { view . VAR_4 ( ) ; VAR_3 = VAR_2 ; } else { VAR_3 = null ; super . METHOD_1 ( view , VAR_1 , description , VAR_2 ... |
reason asserted | public static void METHOD_1 ( TYPE_1 VAR_1 ) { METHOD_2 ( VAR_1 , true ) ; assertThat ( VAR_1 . VAR_2 ) . METHOD_3 ( ) ; assertThat ( VAR_1 . VAR_3 ) . METHOD_3 ( ) ; assertThat ( VAR_1 . VAR_4 ) . METHOD_4 ( ) ; <START> assertThat ( VAR_1 . VAR_4 ) . METHOD_4 ( ) ; <END> if ( VAR_1 . VAR_5 != null ) METHOD_2 ( VAR_1 .... | public static void METHOD_1 ( TYPE_1 VAR_1 ) { METHOD_2 ( VAR_1 , true ) ; assertThat ( VAR_1 . VAR_2 ) . METHOD_3 ( ) ; assertThat ( VAR_1 . VAR_3 ) . METHOD_3 ( ) ; assertThat ( VAR_1 . VAR_4 ) . METHOD_4 ( ) ; if ( VAR_1 . VAR_5 != null ) METHOD_2 ( VAR_1 . VAR_5 , true ) ; } |
reason changed default ? please revert | public void METHOD_1 ( ) throws IOException { TYPE_1 < TYPE_2 > call = METHOD_2 ( ) . METHOD_3 ( ) . METHOD_4 ( null , <START> STRING_1 <END> ) ; TYPE_2 page = call . execute ( ) . METHOD_5 ( ) ; assertThat ( page ) . METHOD_6 ( ) ; assertThat ( page . results ) . METHOD_7 ( ) ; } | public void METHOD_1 ( ) throws IOException { TYPE_1 < TYPE_2 > call = METHOD_2 ( ) . METHOD_3 ( ) . METHOD_4 ( ) ; TYPE_2 page = call . execute ( ) . METHOD_5 ( ) ; assertThat ( page ) . METHOD_6 ( ) ; assertThat ( page . results ) . METHOD_7 ( ) ; } |
support offset length arguments | <START> public TYPE_1 METHOD_1 ( String VAR_1 , String VAR_2 , byte [ ] content ) <END> { return METHOD_2 ( METHOD_3 ( String . format ( STRING_1 , VAR_1 , VAR_2 , STRING_2 ) ) , TYPE_2 . of ( ) , content , TYPE_1 . class ) ; } | public TYPE_1 METHOD_1 ( String VAR_1 , String VAR_2 , byte [ ] content ) { return METHOD_2 ( METHOD_3 ( String . format ( STRING_1 , VAR_1 , VAR_2 , STRING_2 ) ) , TYPE_2 . of ( ) , content , 0 , content . length , TYPE_1 . class ) ; } |
method designed read $HOME / td / td conf print warning case file | public static TYPE_1 METHOD_1 ( ) { TYPE_1 p = new TYPE_1 ( ) ; File file = new File ( System . getProperty ( STRING_1 , STRING_2 ) , String . format ( STRING_3 ) ) ; if ( ! file . exists ( ) ) { <START> logger . debug ( String . format ( STRING_4 , file ) ) ; <END> return p ; } return METHOD_1 ( file ) ; } | public static TYPE_1 METHOD_1 ( ) { TYPE_1 p = new TYPE_1 ( ) ; File file = new File ( System . getProperty ( STRING_1 , STRING_2 ) , String . format ( STRING_3 ) ) ; if ( ! file . exists ( ) ) { logger . warn ( String . format ( STRING_4 , file ) ) ; return p ; } return METHOD_1 ( file ) ; } |
method private | <START> public static < T > void METHOD_1 ( Optional < T > VAR_1 , String VAR_2 ) <END> { if ( ! VAR_1 . isPresent ( ) ) { throw new TYPE_1 ( TYPE_1 . TYPE_2 . VAR_4 , VAR_2 ) ; } } | private static < T > void METHOD_1 ( Optional < T > VAR_1 , String VAR_2 ) { if ( ! VAR_1 . isPresent ( ) ) { throw new TYPE_1 ( TYPE_1 . TYPE_2 . VAR_4 , VAR_2 ) ; } } |
modifier private ? set modifiers _CODE_ _CODE_ methods | private static String METHOD_1 ( String VAR_1 ) <START> { <END> return METHOD_2 ( VAR_1 , STRING_1 ) ; } | static String METHOD_1 ( String VAR_1 ) { return METHOD_2 ( VAR_1 , STRING_1 ) ; } |
need VAR_4 variable ? shouldn t assign result METHOD_3 VAR_3 | public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { TYPE_3 builder = new TYPE_3 ( TYPE_4 . METHOD_2 ( ) ) ; builder . VAR_2 ( ) ; boolean VAR_3 ; boolean VAR_4 = METHOD_3 ( builder , STRING_1 , VAR_1 . getType ( ) , VAR_5 . getType ( ) ) ; <START> VAR_3 = VAR_4 ; <END> builder . VAR_6 ( ) ; if ( VAR_3 ) { Assert . VAR_7 ( VAR_8 ... | public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { TYPE_3 builder = new TYPE_3 ( TYPE_4 . METHOD_2 ( ) ) ; builder . VAR_2 ( ) ; boolean VAR_3 = METHOD_3 ( builder , STRING_1 , VAR_1 . getType ( ) , VAR_5 . getType ( ) ) ; builder . VAR_6 ( ) ; if ( VAR_3 ) { Assert . VAR_7 ( VAR_8 + builder . toString ( ) ) ; } return this ; } |
longer need define pass a backend call start ( ) METHOD_2 ( STRING_1 VAR_3 ) | public void METHOD_1 ( ) { VAR_1 . start ( VAR_2 ) <START> . METHOD_2 ( VAR_2 , STRING_1 , VAR_3 ) <END> . METHOD_3 ( VAR_4 , ctx - > this . VAR_5 = new TYPE_1 ( ctx . VAR_6 ( ) ) , VAR_7 - > this . VAR_8 = VAR_7 ) . METHOD_3 ( VAR_9 , ctx - > this . VAR_10 = new TYPE_2 ( ctx . VAR_6 ( ) ) , VAR_7 - > this . VAR_11 = V... | public void METHOD_1 ( ) { VAR_1 . start ( ) . METHOD_2 ( STRING_1 , VAR_3 ) . METHOD_3 ( VAR_4 , ctx - > this . VAR_5 = new TYPE_1 ( ctx . VAR_6 ( ) ) , VAR_7 - > this . VAR_8 = VAR_7 ) . METHOD_3 ( VAR_9 , ctx - > this . VAR_10 = new TYPE_2 ( ctx . VAR_6 ( ) ) , VAR_7 - > this . VAR_11 = VAR_7 ) . METHOD_1 ( ) ; METH... |
I don t need VAR_2 close ( ) ( ) effectively close bridge s ( impossible ? ) a failure occurs assignment VAR_4 assignment VAR_2 clarify : remove VAR_4 a local variable instead remove line | void METHOD_1 ( ) { try ( TYPE_1 < RuntimeException > VAR_1 = new TYPE_1 < > ( ) ) { VAR_1 . METHOD_2 ( TYPE_2 : : close , VAR_2 ) ; VAR_1 . METHOD_2 ( TYPE_3 : : close , VAR_3 ) ; <START> VAR_1 . METHOD_2 ( TYPE_4 : : close , VAR_4 ) ; <END> } } | void METHOD_1 ( ) { try ( TYPE_1 < RuntimeException > VAR_1 = new TYPE_1 < > ( ) ) { VAR_1 . METHOD_2 ( TYPE_2 : : close , VAR_2 ) ; VAR_1 . METHOD_2 ( TYPE_3 : : close , VAR_3 ) ; } } |
leave burden capturing exception user | public void METHOD_1 ( TYPE_1 context ) { try { String VAR_1 = context . VAR_2 ( ) . toString ( ) ; Throwable VAR_3 = context . VAR_4 ( ) ; } catch ( Throwable t ) { <START> } <END> } | public void METHOD_1 ( TYPE_1 context ) { String VAR_1 = context . VAR_2 ( ) . toString ( ) ; Throwable VAR_3 = context . VAR_4 ( ) ; } |
search analyzers analyzers return true I tests reflect ? fact solve easily keeping search VAR_3 class VAR_3 a default search VAR_3 null | public boolean METHOD_1 ( TYPE_1 VAR_1 ) { if ( ! getClass ( ) . equals ( VAR_1 . getClass ( ) ) ) { return false ; } TYPE_2 VAR_2 = ( TYPE_2 ) VAR_1 ; return TYPE_3 . equals ( VAR_3 , VAR_2 . VAR_3 ) && <START> TYPE_3 . equals ( VAR_4 , VAR_2 . VAR_4 ) && <END> TYPE_3 . equals ( VAR_5 , VAR_2 . VAR_5 ) ; } | public boolean METHOD_1 ( TYPE_1 VAR_1 ) { if ( ! getClass ( ) . equals ( VAR_1 . getClass ( ) ) ) { return false ; } TYPE_2 VAR_2 = ( TYPE_2 ) VAR_1 ; return TYPE_3 . equals ( VAR_3 , VAR_2 . VAR_3 ) && TYPE_3 . equals ( VAR_5 , VAR_2 . VAR_5 ) ; } |
couldn t TYPE_1 METHOD_2 ( VAR_1 ( ) ) ? spare instanceof | public TYPE_1 METHOD_1 ( Date value , TYPE_2 context ) { if ( value == null ) { return null ; } <START> return value instanceof TYPE_4 . TYPE_5 . Date ? TYPE_1 . METHOD_2 ( value . VAR_1 ( ) ) : value . VAR_2 ( ) ; <END> } | public TYPE_1 METHOD_1 ( Date value , TYPE_2 context ) { if ( value == null ) { return null ; } return TYPE_1 . METHOD_2 ( value . VAR_1 ( ) ) ; } |
a reason METHOD_1 mapper level METHOD_4 engine / backend level | <START> void METHOD_1 ( ) { <END> METHOD_2 ( ) ; METHOD_3 ( ) . METHOD_4 ( ) ; } | void METHOD_1 ( ) { METHOD_2 ( ) ; METHOD_3 ( ) . METHOD_1 ( ) ; } |
I d ( String ) VAR_2 VAR_2 toString ( ) else a String fail wrong more point org hibernate search backend lucene types sort impl _CODE_ return TYPE_2 _CODE_ method converts TYPE_2 a String METHOD_1 converts a TYPE_2 I METHOD_1 call _CODE_ happen VAR_2 null _CODE_ MISSING_FIRST _CODE_ MISSING_LAST | public TYPE_1 METHOD_1 ( ) { <START> TYPE_2 VAR_1 = new TYPE_2 ( VAR_2 . toString ( ) ) ; <END> return new TYPE_1 ( VAR_3 , new TYPE_3 ( VAR_1 ) , VAR_4 == TYPE_4 . VAR_6 ) ; } | public TYPE_1 METHOD_1 ( ) { return new TYPE_1 ( VAR_3 , new TYPE_3 ( ( TYPE_2 ) VAR_2 ) , VAR_4 == TYPE_4 . VAR_6 ) ; } |
I m parameter VAR_2 method body | <START> public static void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) throws IOException { <END> if ( TYPE_3 . METHOD_2 ( VAR_1 ) ) { return ; } try { TYPE_4 VAR_3 = new TYPE_4 ( TYPE_8 . VAR_5 ) . METHOD_3 ( TYPE_9 . VAR_7 ) ; TYPE_5 VAR_8 = new TYPE_5 ( VAR_1 , INT_1 , INT_2 ) ; TYPE_6 VAR_9 = new TYPE_6 ( VAR_8 , VAR_... | public static void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) throws IOException { if ( TYPE_3 . METHOD_2 ( VAR_1 ) ) { return ; } try { TYPE_4 VAR_3 = new TYPE_4 ( TYPE_8 . VAR_5 ) . METHOD_3 ( TYPE_9 . VAR_7 ) ; TYPE_5 VAR_8 = new TYPE_5 ( VAR_1 , INT_1 , INT_2 ) ; TYPE_6 VAR_9 = new TYPE_6 ( VAR_8 , VAR_3 ) ; VAR_9 . ... |
I I mentioned : a new test validation attribute _CODE_ I missed isn t | <START> public Integer METHOD_1 ( ) { <END> return VAR_1 ; } | public Double METHOD_1 ( ) { return VAR_1 ; } |
missing < > a raw type | public TYPE_1 < ? , TYPE_2 > METHOD_1 ( ) { <START> return new TYPE_3 ( TYPE_2 . class , VAR_1 ) ; <END> } | public TYPE_1 < ? , TYPE_2 > METHOD_1 ( ) { return new TYPE_3 < > ( TYPE_2 . class , VAR_1 ) ; } |
I don t introduced mutability ? local variables worked want please setters package - private | <START> public void METHOD_1 ( T VAR_1 ) { <END> this . VAR_1 = VAR_1 ; } | void METHOD_1 ( T VAR_1 ) { this . VAR_1 = VAR_1 ; } |
I noticed displaying VAR_1 error message wanted VAR_1 parsing sense changed work : ) | <START> public static TYPE_1 METHOD_1 ( String value ) { <END> TYPE_2 VAR_1 = TYPE_2 . VAR_2 ; try { return TYPE_1 . parse ( value ) ; } catch ( TYPE_3 e ) { throw log . VAR_3 ( TYPE_1 . class , value , VAR_1 , e ) ; } } | public static TYPE_1 METHOD_1 ( String value ) { try { return TYPE_1 . parse ( value ) ; } catch ( TYPE_3 e ) { throw log . VAR_3 ( TYPE_1 . class , value , TYPE_2 . VAR_2 , e ) ; } } |
s critical need expose method instead exposing : _CODE_ ( VAR_1 _CODE_ _CODE_ ) | <START> public TYPE_1 < ? > METHOD_1 ( String VAR_1 ) { <END> if ( TYPE_2 . isEmpty ( VAR_1 ) ) { VAR_1 = METHOD_2 ( ) ; } return VAR_2 . METHOD_3 ( VAR_1 , this : : METHOD_4 ) ; } | TYPE_1 < ? > METHOD_1 ( String VAR_1 ) { if ( TYPE_2 . isEmpty ( VAR_1 ) ) { VAR_1 = METHOD_2 ( ) ; } return VAR_2 . METHOD_3 ( VAR_1 , this : : METHOD_4 ) ; } |
wrong METHOD_1 ( VAR_1 Object VAR_2 ) tests fail missing a test | public TYPE_1 < Object > METHOD_1 ( String VAR_1 ) { <START> return field ( VAR_1 , Object . VAR_2 ) ; <END> } | public TYPE_1 < Object > METHOD_1 ( String VAR_1 ) { return METHOD_1 ( VAR_1 , Object . VAR_2 ) ; } |
a negative | public Optional < TYPE_1 < Double > > METHOD_1 ( ) { return Optional . of ( new TYPE_1 < > ( <START> FLOAT_1 , FLOAT_2 , FLOAT_3 <END> ) ) ; } | public Optional < TYPE_1 < Double > > METHOD_1 ( ) { return Optional . of ( new TYPE_1 < > ( - FLOAT_1 , FLOAT_2 , FLOAT_3 ) ) ; } |
INT_1 I suppose s s prime number 31 multiplying 100 trick s worth hard | public Integer METHOD_1 ( TYPE_1 value ) { if ( value == null ) { return null ; } <START> return INT_1 * value . VAR_1 ( ) + value . VAR_2 ( ) ; <END> } | public Integer METHOD_1 ( TYPE_1 value ) { if ( value == null ) { return null ; } return 100 * value . VAR_1 ( ) + value . VAR_2 ( ) ; } |
yeah other I don t a good idea repository service code | public TYPE_4 ( TYPE_1 VAR_2 , TYPE_2 < ? > VAR_3 , TYPE_3 type ) { this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; this . type = type ; VAR_2 . METHOD_1 ( ) . add ( this ) ; <START> VAR_3 . METHOD_1 ( ) . add ( this ) ; <END> } | public TYPE_4 ( TYPE_1 VAR_2 , TYPE_2 < ? > VAR_3 , TYPE_3 type ) { this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; this . type = type ; } |
move method _CODE_ ? class a bit hard read due methods extra care related methods I shouldn t : / | <START> public long METHOD_1 ( ) { <END> try { return VAR_1 . METHOD_2 ( ) ; } catch ( TYPE_1 | TYPE_2 e ) { throw new IllegalStateException ( e ) ; } catch ( TYPE_3 e ) { throw new IllegalArgumentException ( e ) ; } catch ( TYPE_4 VAR_2 ) { throw METHOD_3 ( ) . METHOD_4 ( VAR_2 ) ; } } | public long METHOD_1 ( ) { try { return VAR_1 . METHOD_2 ( ) ; } catch ( TYPE_1 e ) { throw new IllegalStateException ( e ) ; } catch ( TYPE_3 e ) { throw new IllegalArgumentException ( e ) ; } catch ( TYPE_4 VAR_2 ) { throw METHOD_3 ( ) . METHOD_4 ( VAR_2 ) ; } } |
I avoid lambda | protected TYPE_1 METHOD_1 ( TYPE_2 context ) { Builder builder = new TYPE_3 . Builder ( ) ; <START> values . forEach ( value - > builder . add ( METHOD_2 ( value ) , TYPE_4 . VAR_2 ) ) ; <END> TYPE_3 query = builder . build ( ) ; return query ; } | protected TYPE_1 METHOD_1 ( TYPE_2 context ) { Builder builder = new TYPE_3 . Builder ( ) ; for ( String value : values ) { builder . add ( METHOD_2 ( value ) , TYPE_4 . VAR_2 ) ; } return builder . build ( ) ; } |
pass VAR_1 type Object instead VAR_1 toString ( ) _CODE_ logger call toString ( ) automatically some reason VAR_1 null throw NPE code | public Object get ( Object VAR_1 ) { try { return VAR_2 . METHOD_1 ( VAR_1 ) ; } catch ( TYPE_1 e ) { throw e ; } catch ( Throwable e ) { if ( e instanceof InterruptedException ) { Thread . VAR_3 ( ) . METHOD_2 ( ) ; } <START> throw log . VAR_4 ( VAR_5 . getName ( ) , VAR_1 . toString ( ) , e ) ; <END> } } | public Object get ( Object VAR_1 ) { try { return VAR_2 . METHOD_1 ( VAR_1 ) ; } catch ( TYPE_1 e ) { throw e ; } catch ( Throwable e ) { if ( e instanceof InterruptedException ) { Thread . VAR_3 ( ) . METHOD_2 ( ) ; } throw log . VAR_4 ( VAR_5 , VAR_1 , e ) ; } } |
minor nitpicking s weird order parameters reversed 2 lines | public TYPE_1 METHOD_1 ( String name , TYPE_1 VAR_1 ) { <START> return new TYPE_2 ( VAR_1 , name ) ; <END> } | public TYPE_1 METHOD_1 ( String name , TYPE_1 VAR_1 ) { return new TYPE_2 ( name , VAR_1 ) ; } |
wouldn t happen projects empty list projections ? granted doesn t useful happen especially number results a safer approach a _CODE_ default | public TYPE_1 build ( ) { if ( VAR_1 . isEmpty ( ) ) { <START> throw new TYPE_2 ( STRING_1 ) ; <END> } TYPE_3 VAR_2 ; if ( VAR_1 . size ( ) == 1 ) { VAR_2 = VAR_3 != null ? VAR_3 : VAR_4 ; } else { VAR_2 = TYPE_4 . METHOD_1 ( VAR_1 ) ; } return new TYPE_1 ( VAR_3 , VAR_4 , VAR_2 ) ; } | public TYPE_1 build ( ) { TYPE_3 VAR_2 ; if ( VAR_1 . size ( ) == 1 ) { VAR_2 = VAR_1 . get ( 0 ) ; } else { VAR_2 = TYPE_4 . METHOD_1 ( VAR_1 ) ; } return new TYPE_1 ( VAR_3 , VAR_4 , VAR_2 ) ; } |
discussed _CODE_ s drop support index - sensitive projections restore ( ) | public boolean METHOD_1 ( TYPE_1 < ? > VAR_1 ) { return VAR_2 . METHOD_2 ( VAR_1 . VAR_2 ) && TYPE_2 . equals ( VAR_3 , VAR_1 . VAR_3 ) && VAR_4 . METHOD_2 ( VAR_1 . VAR_4 ) && TYPE_2 . equals ( VAR_5 , VAR_1 . VAR_5 ) <START> && TYPE_2 . equals ( VAR_6 , VAR_1 . VAR_6 ) ; <END> } | public boolean METHOD_1 ( TYPE_1 < ? > VAR_1 ) { return VAR_2 . METHOD_2 ( VAR_1 . VAR_2 ) && TYPE_2 . equals ( VAR_3 , VAR_1 . VAR_3 ) && VAR_4 . METHOD_2 ( VAR_1 . VAR_4 ) && TYPE_2 . equals ( VAR_5 , VAR_1 . VAR_5 ) && VAR_6 . METHOD_2 ( VAR_1 . VAR_6 ) ; } |
method public consistency _CODE_ | <START> protected void METHOD_1 ( ) throws Exception { <END> METHOD_2 ( METHOD_3 ( ) , METHOD_4 ( ) , METHOD_5 ( ) ) ; VAR_1 = getClass ( ) ; } | public void METHOD_1 ( ) throws Exception { METHOD_2 ( METHOD_3 ( ) , METHOD_4 ( ) , METHOD_5 ( ) ) ; VAR_1 = getClass ( ) ; } |
variable line removed | public static < T > T METHOD_1 ( Class < T > VAR_1 , Class < ? > VAR_2 , String VAR_3 ) { METHOD_2 ( VAR_2 , VAR_3 ) ; <START> final TYPE_1 < ? > VAR_4 = METHOD_3 ( VAR_2 , VAR_3 ) ; <END> final Object instance = METHOD_4 ( VAR_2 , VAR_3 ) ; return METHOD_5 ( VAR_1 , instance , VAR_2 , VAR_3 ) ; } | public static < T > T METHOD_1 ( Class < T > VAR_1 , Class < ? > VAR_2 , String VAR_3 ) { METHOD_2 ( VAR_2 , VAR_3 ) ; final Object instance = METHOD_4 ( VAR_2 , VAR_3 ) ; return METHOD_5 ( VAR_1 , instance , VAR_2 , VAR_3 ) ; } |
I understand correctly commit wrappers remain cache stopped I suppose purpose | synchronized void METHOD_1 ( ) { VAR_1 -- ; if ( VAR_1 == 0 ) { if ( status != TYPE_1 . VAR_3 ) { METHOD_2 ( ) ; } <START> METHOD_3 ( ) ; <END> } else if ( status != TYPE_1 . VAR_3 ) { METHOD_2 ( ) ; } } | synchronized void METHOD_1 ( ) { VAR_1 -- ; if ( VAR_1 == 0 ) { METHOD_3 ( ) ; } } |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.