Datasets:
YabTad
/
CodeRev

Dataset card Data Studio Files
xet
 Community
ReviewComments
stringlengths
1
2.35k
OriginalCode
stringlengths
28
487
ReviewedCode
stringlengths
14
463
I confused supposed
public String toString ( ) { <START> return TYPE_1 . METHOD_1 ( "" ) <END> . add ( STRING_1 , VAR_1 ) . add ( STRING_2 , VAR_2 ) . toString ( ) ; }
public String toString ( ) { return TYPE_1 . METHOD_1 ( this ) . add ( STRING_1 , VAR_1 ) . add ( STRING_2 , VAR_2 ) . toString ( ) ; }
t VAR_2 values ( ) add _CODE_ entries
public Iterator < TYPE_5 . TYPE_6 > METHOD_1 ( ) { List < Iterator < TYPE_5 . TYPE_6 > > VAR_1 = TYPE_2 <START> . map ( TYPE_3 : : METHOD_1 , VAR_2 . values ( ) ) ; <END> return TYPE_4 . METHOD_2 ( METHOD_3 ( ) , METHOD_4 ( ) , TYPE_4 . METHOD_2 ( VAR_1 . iterator ( ) ) ) ; }
public Iterator < TYPE_5 . TYPE_6 > METHOD_1 ( ) { List < Iterator < TYPE_5 . TYPE_6 > > VAR_1 = TYPE_2 . map ( TYPE_3 : : METHOD_1 , VAR_2 . values ( ) ) ; return TYPE_4 . METHOD_2 ( METHOD_3 ( ) , TYPE_4 . METHOD_2 ( VAR_1 . iterator ( ) ) ) ; }
explain logic
public int METHOD_1 ( ) throws IOException { <START> int VAR_1 = in . VAR_1 ( ) + ( int ) ( ( ( TYPE_1 ) in ) . METHOD_2 ( ) - VAR_2 ) ; <END> return VAR_1 > 0 ? VAR_1 : 0 ; }
public int METHOD_1 ( ) throws IOException { if ( VAR_2 != ( ( TYPE_1 ) in ) . METHOD_2 ( ) ) { return 0 ; } return in . VAR_1 ( ) ; }
valid hit EOS return - 1
public int read ( ) throws IOException { byte [ ] buffer = new byte [ 1 ] ; int VAR_1 = ( ( TYPE_1 ) in ) . read ( VAR_2 , buffer , 0 , buffer . length ) ; if ( VAR_1 > 0 ) { VAR_2 += VAR_1 ; return TYPE_2 . METHOD_1 ( buffer [ 0 ] ) ; } TYPE_3 . METHOD_2 ( VAR_1 != 0 , <START> STRING_1 ) ; <END> return VAR_1 ; }
public int read ( ) throws IOException { byte [ ] buffer = new byte [ 1 ] ; int VAR_1 = read ( buffer ) ; if ( VAR_1 > 0 ) { return TYPE_2 . METHOD_1 ( buffer [ 0 ] ) ; } TYPE_3 . METHOD_2 ( VAR_1 != 0 , STRING_1 ) ; return VAR_1 ; }
needs public reflection work
<START> protected TYPE_3 ( TYPE_1 VAR_2 ) { <END> VAR_3 = VAR_2 ; VAR_4 = TYPE_2 . create ( VAR_2 ) ; VAR_5 . METHOD_1 ( VAR_3 ) ; }
public TYPE_3 ( TYPE_1 VAR_2 ) { VAR_3 = VAR_2 ; VAR_4 = TYPE_2 . create ( VAR_2 ) ; VAR_5 . METHOD_1 ( VAR_3 ) ; }
I want null instead empty arrays
static TYPE_1 create ( TYPE_2 conf ) { return TYPE_3 . METHOD_1 ( <START> conf . getClass ( TYPE_4 . VAR_2 ) , new Class [ 0 ] , new Object [ 0 ] ) ; <END> }
static TYPE_1 create ( TYPE_2 conf ) { return TYPE_3 . METHOD_1 ( conf . getClass ( TYPE_4 . VAR_2 ) , null , null ) ; }
switch statement
public void METHOD_1 ( TYPE_1 VAR_1 ) { Status status = VAR_1 . getStatus ( ) ; <START> if ( status . equals ( Status . VAR_2 ) ) { <END> METHOD_2 ( VAR_1 . getId ( ) ) ; } else if ( status . equals ( Status . VAR_3 ) || status . equals ( Status . VAR_4 ) ) { METHOD_3 ( VAR_1 . getId ( ) , status , VAR_1 . METHOD_4 ( )...
public void METHOD_1 ( TYPE_1 VAR_1 ) { Status status = VAR_1 . getStatus ( ) ; switch ( status ) { case VAR_2 : METHOD_2 ( VAR_1 . getId ( ) ) ; break ; case VAR_3 : case VAR_4 : METHOD_3 ( VAR_1 . getId ( ) , status , VAR_1 . METHOD_4 ( ) ) ; break ; default : break ; } }
super constructor ? ( VAR_5 final )
public TYPE_2 ( String VAR_2 , String [ ] VAR_3 ) { super ( VAR_3 ) ; VAR_4 = VAR_2 ; <START> VAR_5 = new String [ ] { STRING_1 , STRING_2 , <END> String . format ( STRING_3 , TYPE_1 . VAR_7 , VAR_2 , String . VAR_8 ( STRING_4 , VAR_3 ) ) } ; }
public TYPE_2 ( String VAR_2 , String [ ] VAR_3 ) { super ( new String [ ] { STRING_1 , STRING_2 , String . format ( STRING_3 , TYPE_1 . VAR_7 , VAR_2 , String . VAR_8 ( STRING_4 , VAR_3 ) ) } ) ; VAR_4 = VAR_2 ; }
calling super constructor
public TYPE_2 ( String VAR_2 , String VAR_3 , String VAR_4 , boolean VAR_5 ) { super ( new String [ ] { } ) ; String VAR_6 = STRING_1 ; if ( VAR_5 ) { VAR_6 = STRING_2 ; } <START> VAR_7 = new String [ ] { STRING_3 , STRING_4 , <END> String . format ( VAR_6 , TYPE_1 . VAR_9 , VAR_2 , VAR_3 , VAR_4 ) } ; VAR_10 = VAR_2 ;...
public TYPE_2 ( String VAR_2 , String VAR_3 , String VAR_4 , boolean VAR_5 ) { super ( new String [ ] { STRING_3 , STRING_4 , String . format ( VAR_5 ? STRING_2 : STRING_1 , TYPE_1 . VAR_9 , VAR_2 , VAR_3 , VAR_4 ) } ) ; VAR_10 = VAR_2 ; }
I thread safe a lock protect changes cached client a RW lock read client write update
<START> private TYPE_1 METHOD_1 ( ) throws IOException { <END> if ( VAR_1 != null ) { return VAR_1 ; } VAR_1 = METHOD_2 ( ) ; return VAR_1 ; }
private TYPE_1 METHOD_1 ( ) throws IOException { if ( VAR_1 != null ) { return VAR_1 ; } METHOD_2 ( ) ; return VAR_1 ; }
protected a lock
private void METHOD_1 ( long VAR_1 , TYPE_1 . Builder command ) { if ( ! VAR_2 . containsKey ( VAR_1 ) ) { <START> VAR_2 . put ( VAR_1 , TYPE_2 . METHOD_2 ( ) ) ; <END> } VAR_2 . get ( VAR_1 ) . add ( command . build ( ) ) ; }
private synchronized void METHOD_1 ( long VAR_1 , TYPE_1 . Builder command ) { if ( ! VAR_2 . containsKey ( VAR_1 ) ) { VAR_2 . put ( VAR_1 , TYPE_2 . METHOD_2 ( ) ) ; } VAR_2 . get ( VAR_1 ) . add ( command . build ( ) ) ; }
finally block
protected void METHOD_1 ( Thread t , TYPE_1 r ) { super . METHOD_1 ( t , r ) ; VAR_1 . METHOD_2 ( ) ; try { VAR_2 ++ ; while ( VAR_3 ) { VAR_4 . METHOD_3 ( ) ; } <START> VAR_2 -- ; <END> } catch ( InterruptedException e ) { t . VAR_5 ( ) ; } finally { VAR_1 . METHOD_4 ( ) ; } }
protected void METHOD_1 ( Thread t , TYPE_1 r ) { super . METHOD_1 ( t , r ) ; VAR_1 . METHOD_2 ( ) ; try { VAR_2 ++ ; while ( VAR_3 ) { VAR_4 . METHOD_3 ( ) ; } } catch ( InterruptedException e ) { t . VAR_5 ( ) ; } finally { VAR_2 -- ; VAR_1 . METHOD_4 ( ) ; } }
a change behavior - give some time server threads finish RPC calls METHOD_4
public boolean METHOD_1 ( ) { VAR_1 . METHOD_1 ( ) ; try { VAR_2 . close ( ) ; } catch ( IOException e ) { LOG . warn ( STRING_1 , e ) ; } <START> VAR_1 . METHOD_2 ( ) ; <END> try { return VAR_1 . METHOD_3 ( VAR_3 , TimeUnit . VAR_4 ) ; } catch ( InterruptedException VAR_5 ) { Thread . VAR_6 ( ) . METHOD_4 ( ) ; return...
public boolean METHOD_1 ( ) { VAR_1 . METHOD_1 ( ) ; try { VAR_2 . close ( ) ; } catch ( IOException e ) { LOG . error ( STRING_1 , e ) ; } VAR_1 . METHOD_2 ( ) ; try { return VAR_1 . METHOD_3 ( VAR_3 , TimeUnit . VAR_4 ) ; } catch ( InterruptedException VAR_5 ) { Thread . VAR_6 ( ) . METHOD_4 ( ) ; return false ; } }
s reason copy _CODE_ a new list
public TYPE_5 ( TYPE_3 . TYPE_4 . TYPE_5 VAR_2 ) { VAR_3 = VAR_2 . METHOD_1 ( ) ; <START> VAR_4 = TYPE_2 . METHOD_2 ( VAR_2 . METHOD_3 ( ) ) ; <END> VAR_5 = VAR_2 . METHOD_4 ( ) ; VAR_6 = VAR_2 . METHOD_5 ( ) ; }
public TYPE_5 ( TYPE_3 . TYPE_4 . TYPE_5 VAR_2 ) { VAR_3 = VAR_2 . METHOD_1 ( ) ; VAR_4 = VAR_2 . METHOD_3 ( ) ; VAR_5 = VAR_2 . METHOD_4 ( ) ; VAR_6 = VAR_2 . METHOD_5 ( ) ; }
( ) - static remove
public static void METHOD_1 ( ) throws Exception { VAR_1 = new TYPE_1 ( ) ; VAR_1 . METHOD_2 ( TYPE_2 . VAR_3 , STRING_1 ) ; VAR_1 . start ( ) ; <START> VAR_4 = VAR_5 . get ( ) . METHOD_3 ( ) ; <END> }
public static void METHOD_1 ( ) throws Exception { VAR_1 = new TYPE_1 ( ) ; VAR_1 . METHOD_2 ( TYPE_2 . VAR_3 , STRING_1 ) ; VAR_1 . start ( ) ; }
shorten intervals cluster shorten ? line wait ? line
public void METHOD_1 ( ) throws Exception { TYPE_1 VAR_1 = new TYPE_1 ( TYPE_2 . METHOD_2 ( ) ) ; METHOD_3 ( VAR_2 , VAR_1 , INT_1 ) ; <START> TYPE_3 . METHOD_4 ( INT_2 ) ; <END> TYPE_4 . METHOD_5 ( VAR_3 , VAR_2 , VAR_1 , 2 ) ; }
public void METHOD_1 ( ) throws Exception { TYPE_1 VAR_1 = new TYPE_1 ( TYPE_2 . METHOD_2 ( ) ) ; METHOD_3 ( VAR_2 , VAR_1 , INT_1 ) ; TYPE_4 . METHOD_5 ( VAR_3 , VAR_2 , VAR_1 , 2 ) ; }
new TYPE_1 ( VAR_1 ) conf / VAR_4 creation constructor
public static TYPE_1 create ( TYPE_2 uri ) throws IOException { Path VAR_1 = new Path ( uri . VAR_2 ( ) , uri . VAR_3 ( ) . toString ( ) , uri . getPath ( ) ) ; TYPE_3 conf = TYPE_4 . METHOD_1 ( ) ; TYPE_5 VAR_4 = VAR_1 . METHOD_2 ( conf ) ; <START> return new TYPE_1 ( VAR_4 , VAR_1 ) ; <END> }
public static TYPE_1 create ( TYPE_2 uri ) throws IOException { return new TYPE_1 ( new Path ( uri . VAR_2 ( ) , uri . VAR_3 ( ) . toString ( ) , uri . getPath ( ) ) ) ; }
catch throwable instead
private void METHOD_1 ( ) { try { VAR_1 . METHOD_2 ( ) ; } catch ( IOException e ) { TYPE_1 . METHOD_3 ( LOG , e , STRING_1 ) ; } <START> } <END>
private void METHOD_1 ( ) { try { VAR_1 . METHOD_2 ( ) ; } catch ( Throwable e ) { TYPE_1 . METHOD_3 ( LOG , e , STRING_1 ) ; } }
previous log message removed trivial logic
public void METHOD_1 ( ) throws IOException { try ( TYPE_1 VAR_1 = new TYPE_1 ( VAR_2 ) ) { TYPE_2 . METHOD_2 ( ! VAR_3 , STRING_1 ) ; LOG . info ( STRING_2 ) ; VAR_3 = true ; <START> LOG . info ( STRING_3 , VAR_4 ) ; <END> } }
public void METHOD_1 ( ) throws IOException { try ( TYPE_1 VAR_1 = new TYPE_1 ( VAR_2 ) ) { TYPE_2 . METHOD_2 ( ! VAR_3 , STRING_1 ) ; VAR_3 = true ; LOG . info ( STRING_3 , VAR_4 ) ; } }
heartbeat need stopped
public void start ( Boolean VAR_1 ) throws IOException { super . start ( VAR_1 ) ; <START> VAR_2 . METHOD_1 ( METHOD_2 ( ) , VAR_3 . METHOD_3 ( ) ) ; <END> }
public void start ( Boolean VAR_1 ) throws IOException { super . start ( VAR_1 ) ; if ( VAR_1 ) { VAR_2 . start ( METHOD_2 ( ) , VAR_3 . METHOD_3 ( ) ) ; } }
method needs return true journal entry handled
public boolean METHOD_1 ( TYPE_3 . TYPE_4 entry ) { if ( entry . VAR_1 ( ) ) { apply ( entry . VAR_2 ( ) ) ; return true ; } else if ( entry . VAR_3 ( ) ) { TYPE_2 db = VAR_4 . get ( entry . VAR_5 ( ) . METHOD_2 ( ) ) ; return db . VAR_6 ( entry ) ; } else if ( entry . VAR_7 ( ) ) { <START> apply ( entry . VAR_8 ( ) ) ...
public boolean METHOD_1 ( TYPE_3 . TYPE_4 entry ) { if ( entry . VAR_1 ( ) ) { apply ( entry . VAR_2 ( ) ) ; return true ; } else if ( entry . VAR_3 ( ) ) { TYPE_2 db = VAR_4 . get ( entry . VAR_5 ( ) . METHOD_2 ( ) ) ; return db . VAR_6 ( entry ) ; } else if ( entry . VAR_7 ( ) ) { apply ( entry . VAR_8 ( ) ) ; return...
I feel output isn t helpful reprinting user - options
public int run ( TYPE_1 VAR_1 ) throws TYPE_2 { String [ ] args = VAR_1 . METHOD_1 ( ) ; String VAR_2 = args [ 0 ] ; String VAR_3 = args [ 1 ] ; TYPE_3 p = VAR_1 . METHOD_2 ( TYPE_4 . METHOD_3 ( ) ) ; VAR_4 . METHOD_4 ( VAR_2 , VAR_3 , TYPE_5 . METHOD_5 ( p ) ) ; <START> System . out . println ( String . format ( STRIN...
public int run ( TYPE_1 VAR_1 ) throws TYPE_2 { String [ ] args = VAR_1 . METHOD_1 ( ) ; String VAR_2 = args [ 0 ] ; String VAR_3 = args [ 1 ] ; TYPE_3 p = VAR_1 . METHOD_2 ( TYPE_4 . METHOD_3 ( ) ) ; VAR_4 . METHOD_4 ( VAR_2 , VAR_3 , TYPE_5 . METHOD_5 ( p ) ) ; return 0 ; }
I remove check checks alluxio scheme authority
public TYPE_1 METHOD_1 ( TYPE_1 VAR_1 ) throws IOException , TYPE_2 { <START> METHOD_2 ( VAR_1 ) ; <END> return METHOD_3 ( client - > { TYPE_1 path = client . VAR_2 ( VAR_1 ) ; LOG . debug ( STRING_1 , VAR_1 . getPath ( ) , path . getPath ( ) ) ; return path ; } ) ; }
public TYPE_1 METHOD_1 ( TYPE_1 VAR_1 ) throws IOException , TYPE_2 { return METHOD_3 ( client - > { TYPE_1 path = client . VAR_2 ( VAR_1 ) ; LOG . debug ( STRING_1 , VAR_1 . getPath ( ) , path . getPath ( ) ) ; return path ; } ) ; }
return
public List < TYPE_5 . TYPE_6 . VAR_1 . TYPE_4 > METHOD_1 ( String VAR_3 , String VAR_4 , TYPE_2 VAR_5 ) throws IOException { TYPE_3 table = METHOD_2 ( VAR_3 , VAR_4 ) ; List < TYPE_4 > VAR_6 = table . VAR_7 ( ) ; List < TYPE_5 . TYPE_6 . VAR_1 . TYPE_4 > VAR_8 = <START> VAR_6 . stream ( ) . map ( TYPE_4 : : METHOD_3 )...
public List < TYPE_5 . TYPE_6 . VAR_1 . TYPE_4 > METHOD_1 ( String VAR_3 , String VAR_4 , TYPE_2 VAR_5 ) throws IOException { TYPE_3 table = METHOD_2 ( VAR_3 , VAR_4 ) ; List < TYPE_4 > VAR_6 = table . VAR_7 ( ) ; return VAR_6 . stream ( ) . map ( TYPE_4 : : METHOD_3 ) . collect ( Collectors . VAR_9 ( ) ) ; }
e getMessage ( ) message ? want full stack trace exception want message
public boolean METHOD_1 ( ) { try { return METHOD_2 ( "" , true ) != null ; } catch ( Exception e ) { <START> LOG . debug ( STRING_1 , super . VAR_1 . toString ( ) , e . getMessage ( ) ) ; <END> return false ; } }
public boolean METHOD_1 ( ) { try { return METHOD_2 ( "" , true ) != null ; } catch ( Exception e ) { LOG . debug ( STRING_1 , super . VAR_1 . toString ( ) , e ) ; return false ; } }
synchronized block redundant ? remove method synchronization
public synchronized void METHOD_1 ( List < TYPE_1 > VAR_1 ) { <START> synchronized ( VAR_2 ) { <END> for ( TYPE_1 VAR_3 : VAR_1 ) { VAR_2 . METHOD_2 ( VAR_3 . METHOD_3 ( ) , VAR_3 ) ; } METHOD_4 ( ) ; } }
public void METHOD_1 ( List < TYPE_1 > VAR_1 ) { synchronized ( VAR_2 ) { for ( TYPE_1 VAR_3 : VAR_1 ) { VAR_2 . METHOD_2 ( VAR_3 . METHOD_3 ( ) , VAR_3 ) ; } METHOD_4 ( ) ; } }
redundant synchronization
public synchronized void METHOD_1 ( long VAR_1 ) { Integer VAR_2 = VAR_3 . get ( VAR_1 ) ; if ( VAR_2 == null ) { return ; } TYPE_1 VAR_4 = VAR_5 . METHOD_2 ( VAR_2 ) ; if ( VAR_4 . getStatus ( ) . METHOD_3 ( ) ) { return ; } <START> synchronized ( VAR_5 ) { <END> if ( ! VAR_5 . getStatus ( ) . METHOD_3 ( ) ) { VAR_4 ....
public void METHOD_1 ( long VAR_1 ) { synchronized ( VAR_5 ) { Integer VAR_2 = VAR_3 . get ( VAR_1 ) ; if ( VAR_2 == null ) { return ; } TYPE_1 VAR_4 = VAR_5 . METHOD_2 ( VAR_2 ) ; if ( VAR_4 . getStatus ( ) . METHOD_3 ( ) ) { return ; } if ( ! VAR_5 . getStatus ( ) . METHOD_3 ( ) ) { VAR_4 . METHOD_4 ( Status . VAR_6 ...
necessary
private void METHOD_1 ( TYPE_1 VAR_1 , long VAR_2 ) { VAR_1 . METHOD_2 ( ) ; try { VAR_1 . METHOD_3 ( VAR_2 , TimeUnit . VAR_3 ) ; } catch ( InterruptedException e ) { Thread . VAR_4 ( ) . METHOD_4 ( ) ; } finally { VAR_1 . METHOD_5 ( ) ; } <START> TYPE_2 . METHOD_6 ( VAR_1 . METHOD_7 ( ) ) ; <END> }
private void METHOD_1 ( TYPE_1 VAR_1 , long VAR_2 ) { VAR_1 . METHOD_2 ( ) ; try { VAR_1 . METHOD_3 ( VAR_2 , TimeUnit . VAR_3 ) ; } catch ( InterruptedException e ) { Thread . VAR_4 ( ) . METHOD_4 ( ) ; } finally { VAR_1 . METHOD_5 ( ) ; } }
useful a member method TYPE_1 a util method ( stays I static method )
<START> private String METHOD_1 ( TYPE_1 uri ) { <END> if ( uri . VAR_1 ( ) ) { return uri . toString ( ) ; } else { return uri . getPath ( ) ; } }
private static String METHOD_1 ( TYPE_1 uri ) { if ( uri . VAR_1 ( ) ) { return uri . toString ( ) ; } else { return uri . getPath ( ) ; } }
options sorted alphabetically
public TYPE_1 METHOD_1 ( ) { return new TYPE_1 ( ) . METHOD_2 ( VAR_1 ) . METHOD_2 ( VAR_2 ) . METHOD_2 ( VAR_3 ) . METHOD_2 ( VAR_4 ) <START> . METHOD_2 ( VAR_5 ) <END> . METHOD_2 ( VAR_6 ) . METHOD_2 ( VAR_7 ) . METHOD_2 ( VAR_8 ) ; }
public TYPE_1 METHOD_1 ( ) { return new TYPE_1 ( ) . METHOD_2 ( VAR_1 ) . METHOD_2 ( VAR_2 ) . METHOD_2 ( VAR_3 ) . METHOD_2 ( VAR_4 ) . METHOD_2 ( VAR_6 ) . METHOD_2 ( VAR_7 ) . METHOD_2 ( VAR_8 ) . METHOD_2 ( VAR_5 ) ; }
dangerous hide some issues future change implementation need unboxing
public boolean equals ( Object o ) { if ( this == o ) { return true ; } if ( ! ( o instanceof TYPE_1 ) ) { return VAR_1 == o ; <START> } <END> try { TYPE_1 < T > VAR_2 = ( TYPE_1 < T > ) o ; return VAR_1 == VAR_2 . VAR_1 ; } catch ( TYPE_2 e ) { return false ; } }
public boolean equals ( Object o ) { if ( this == o ) { return true ; } if ( ! ( o instanceof TYPE_1 ) ) { return false ; } try { TYPE_1 < T > VAR_2 = ( TYPE_1 < T > ) o ; return VAR_1 == VAR_2 . VAR_1 ; } catch ( TYPE_2 e ) { return false ; } }
a bug ? happen
public synchronized TYPE_1 METHOD_1 ( ) throws TYPE_2 { if ( VAR_1 != TYPE_5 . VAR_3 ) { throw new TYPE_2 ( STRING_1 + VAR_1 ) ; } TYPE_3 writer = VAR_4 ; <START> if ( writer == null ) { <END> throw new TYPE_2 ( STRING_2 ) ; } return new TYPE_4 ( writer ) ; }
public synchronized TYPE_1 METHOD_1 ( ) throws TYPE_2 { if ( VAR_1 != TYPE_5 . VAR_3 ) { throw new TYPE_2 ( STRING_1 + VAR_1 ) ; } return new TYPE_4 ( VAR_4 ) ; }
don t need assert VAR_1 a part alluxio logic : )
public void METHOD_1 ( ) throws Exception { String VAR_1 = String . VAR_2 ( "" , Collections . VAR_3 ( INT_1 , STRING_1 ) ) ; <START> assertEquals ( INT_2 , VAR_1 . length ( ) ) ; <END> VAR_4 . VAR_5 . set ( TYPE_1 . METHOD_2 ( ) ) ; assertEquals ( - TYPE_2 . METHOD_3 ( ) , VAR_6 . create ( STRING_2 + VAR_1 , 0 , VAR_4...
public void METHOD_1 ( ) throws Exception { String VAR_1 = String . VAR_2 ( "" , Collections . VAR_3 ( INT_1 , STRING_1 ) ) ; VAR_4 . VAR_5 . set ( TYPE_1 . METHOD_2 ( ) ) ; assertEquals ( - TYPE_2 . METHOD_3 ( ) , VAR_6 . create ( STRING_2 + VAR_1 , 0 , VAR_4 ) ) ; }
move line - catch avoid error due calling METHOD_4 closed call
public static < T > void call ( Logger logger , TYPE_1 < T > VAR_1 , String VAR_2 , boolean VAR_3 , String description , TYPE_2 < T > VAR_4 , Object ... args ) { try { VAR_4 . METHOD_1 ( METHOD_2 ( logger , VAR_1 , VAR_2 , VAR_3 , description , args ) ) ; <START> VAR_4 . METHOD_3 ( ) ; <END> } catch ( TYPE_3 e ) { VAR_...
public static < T > void call ( Logger logger , TYPE_1 < T > VAR_1 , String VAR_2 , boolean VAR_3 , String description , TYPE_2 < T > VAR_4 , Object ... args ) { T response ; try { response = METHOD_2 ( logger , VAR_1 , VAR_2 , VAR_3 , description , args ) ; } catch ( TYPE_3 e ) { VAR_4 . METHOD_4 ( e ) ; return ; } VA...
STRING_1 equals ( VAR_1 METHOD_2 ( ) ) ? check s3 risk uri scheme s3a s3
protected String METHOD_1 ( ) { <START> if ( VAR_1 . METHOD_2 ( ) != null && VAR_1 . METHOD_2 ( ) . equals ( STRING_1 ) ) { <END> return Constants . VAR_2 + VAR_3 ; } else { return Constants . VAR_4 + VAR_3 ; } }
protected String METHOD_1 ( ) { if ( STRING_1 . equals ( VAR_1 . METHOD_2 ( ) ) ) { return Constants . VAR_2 + VAR_3 ; } else { return Constants . VAR_4 + VAR_3 ; } }
getValue ( ) instead accessing private member
public boolean remove ( T element ) { <START> return VAR_1 . METHOD_1 ( x - > x . VAR_2 == element ) ; <END> }
public boolean remove ( T element ) { return VAR_1 . METHOD_1 ( x - > x . getValue ( ) == element ) ; }
instance TYPE_3 a bool ? other types channels ( TYPE_3 ) ? checking abstracted
public TYPE_8 ( TYPE_6 . TYPE_7 VAR_2 , TYPE_2 channel , long VAR_3 ) { VAR_4 = VAR_2 ; VAR_5 = channel instanceof TYPE_3 ? ( ) - > ( ( ( TYPE_3 ) channel ) . METHOD_1 ( ) && VAR_6 ) : ( ) - > VAR_6 ; <START> if ( channel instanceof TYPE_3 ) { <END> VAR_7 = ( ( TYPE_3 ) channel ) : : close ; } VAR_8 = TYPE_4 . METHOD_2...
public TYPE_8 ( TYPE_6 . TYPE_7 VAR_2 , TYPE_2 channel , long VAR_3 ) { VAR_4 = VAR_2 ; VAR_5 = ( ) - > VAR_6 ; VAR_8 = TYPE_4 . METHOD_2 ( channel , new TYPE_5 ( ( this ) ) ) ; VAR_9 = false ; VAR_10 = VAR_3 ; }
byte [ ] attribute values ? want store encoded values byte [ ] more compact platform agnostic
<START> public Map < String , String > METHOD_1 ( ) { <END> return VAR_1 ; }
public Map < String , byte [ ] > METHOD_1 ( ) { return VAR_1 ; }
expensive ( CPU mem ) create repeatedly especially xattrs example maps a default size ( 16 ) add consider creating map unused
private TYPE_3 ( String VAR_2 ) { VAR_3 = null ; VAR_4 = false ; VAR_5 = false ; VAR_6 = null ; VAR_7 = null ; VAR_8 = TYPE_1 . METHOD_1 ( TYPE_2 . METHOD_2 ( ) , VAR_2 ) ; <START> VAR_9 = new HashMap < > ( ) ; <END> }
private TYPE_3 ( String VAR_2 ) { VAR_3 = null ; VAR_4 = false ; VAR_5 = false ; VAR_6 = null ; VAR_7 = null ; VAR_8 = TYPE_1 . METHOD_1 ( TYPE_2 . METHOD_2 ( ) , VAR_2 ) ; }
inline booleans
public synchronized void METHOD_1 ( TYPE_1 VAR_1 ) throws TYPE_2 { boolean VAR_2 = VAR_3 . METHOD_2 ( ) ; boolean VAR_4 = VAR_5 ; <START> METHOD_3 ( VAR_1 , ! VAR_2 , ! VAR_4 ) ; <END> }
public synchronized void METHOD_1 ( TYPE_1 VAR_1 ) throws TYPE_2 { METHOD_3 ( VAR_1 , ! VAR_3 . METHOD_2 ( ) , ! VAR_5 ) ; }
empty string instead
<START> default String VAR_1 ( ) { <END> return null ; }
default String VAR_1 ( ) { return "" ; }
set
public TYPE_6 ( TYPE_1 < TYPE_2 < byte [ ] > > properties ) { try { VAR_2 = TYPE_3 . getInstance ( STRING_1 ) ; } catch ( TYPE_4 e ) { throw new RuntimeException ( e ) ; } VAR_3 = properties ; VAR_4 = new TYPE_5 ( true ) ; <START> VAR_5 = "" ; <END> }
public TYPE_6 ( TYPE_1 < TYPE_2 < byte [ ] > > properties ) { try { VAR_2 = TYPE_3 . getInstance ( STRING_1 ) ; } catch ( TYPE_4 e ) { throw new RuntimeException ( e ) ; } VAR_3 = properties ; VAR_4 = new TYPE_5 ( true ) ; }
alphabetical order ? : )
public int METHOD_1 ( ) { return TYPE_1 . METHOD_1 ( <START> VAR_1 , <END> VAR_2 , VAR_3 , VAR_4 , VAR_5 , VAR_6 , VAR_7 , VAR_8 , VAR_9 , VAR_10 , VAR_11 , VAR_12 , VAR_13 , VAR_14 ) ; }
public int METHOD_1 ( ) { return TYPE_1 . METHOD_1 ( VAR_2 , VAR_3 , VAR_1 , VAR_4 , VAR_5 , VAR_6 , VAR_7 , VAR_8 , VAR_9 , VAR_10 , VAR_11 , VAR_12 , VAR_13 , VAR_14 ) ; }
remove parentheses VAR_4 METHOD_2 ( VAR_3 0 ) - longer _CODE_ put ( VAR_3 VAR_4 METHOD_2 ( VAR_3 0 ) + VAR_2 ) ;
public void record ( long VAR_1 , int VAR_2 ) { long VAR_3 = METHOD_1 ( VAR_1 ) ; <START> VAR_4 . put ( VAR_3 , ( VAR_4 . METHOD_2 ( VAR_3 , 0 ) ) + VAR_2 ) ; <END> }
public void record ( long VAR_1 , int VAR_2 ) { long VAR_3 = METHOD_1 ( VAR_1 ) ; VAR_4 . put ( VAR_3 , VAR_4 . METHOD_2 ( VAR_3 , 0 ) + VAR_2 ) ; }
safer create a copy a _CODE_ RPC read returned map map updated another RPC
public Map < String , List < String > > METHOD_1 ( ) { <START> return Collections . VAR_1 ( VAR_2 ) ; <END> }
public Map < String , List < String > > METHOD_1 ( ) { return new HashMap < > ( VAR_2 ) ; }
susceptible concurrent modification exceptions return a copy instead
public List < String > METHOD_1 ( ) { <START> return Collections . VAR_1 ( VAR_2 ) ; <END> }
public List < String > METHOD_1 ( ) { return new ArrayList < > ( VAR_2 ) ; }
xxx METHOD_3 ( xxx ) add ( xxx ) reason ( VAR_4 ) line
public Map < String , List < String > > METHOD_1 ( ) { Map < String , List < String > > VAR_1 = new HashMap < > ( ) ; for ( Pair < String , String > VAR_2 : VAR_3 . keySet ( ) ) { String VAR_4 = VAR_2 . METHOD_2 ( ) ; <START> VAR_1 . METHOD_3 ( VAR_4 , VAR_5 - > new ArrayList < > ( ) ) ; <END> VAR_1 . get ( VAR_4 ) . a...
public Map < String , List < String > > METHOD_1 ( ) { Map < String , List < String > > VAR_1 = new HashMap < > ( ) ; for ( Pair < String , String > VAR_2 : VAR_3 . keySet ( ) ) { String VAR_4 = VAR_2 . METHOD_2 ( ) ; VAR_1 . METHOD_3 ( VAR_4 , VAR_5 - > new ArrayList < > ( ) ) . add ( VAR_2 . METHOD_4 ( ) ) ; } return...
necessary previous hashmap put override
private void METHOD_1 ( TYPE_1 entry ) { final String path = entry . getPath ( ) ; final Map < String , String > properties = entry . VAR_1 ( ) ; if ( VAR_2 . containsKey ( path ) ) { VAR_2 . get ( path ) . clear ( ) ; <START> VAR_2 . get ( path ) . METHOD_2 ( properties ) ; <END> } else { VAR_2 . put ( path , new Hash...
private void METHOD_1 ( TYPE_1 entry ) { String path = entry . getPath ( ) ; Map < String , String > properties = entry . VAR_1 ( ) ; if ( VAR_2 . containsKey ( path ) ) { VAR_2 . get ( path ) . clear ( ) ; VAR_2 . get ( path ) . METHOD_2 ( properties ) ; } else { VAR_2 . put ( path , new HashMap < > ( properties ) ) ;...
unnecessary final
private void METHOD_1 ( TYPE_1 entry ) { <START> final String path = entry . getPath ( ) ; <END> VAR_1 . remove ( path ) ; }
private void METHOD_1 ( TYPE_1 entry ) { String path = entry . getPath ( ) ; VAR_1 . remove ( path ) ; }
instead construct TYPE_3 doesn t removed keys
public static Collection < ? extends TYPE_1 > METHOD_1 ( ) { <START> return TYPE_2 . METHOD_2 ( TYPE_3 . values ( ) <END> . METHOD_3 ( ) . filter ( key - > ! TYPE_1 . METHOD_4 ( key ) ) . collect ( Collectors . VAR_1 ( ) ) ) ; }
public static Collection < ? extends TYPE_1 > METHOD_1 ( ) { return TYPE_2 . METHOD_2 ( TYPE_3 . values ( ) ) ; }
call TYPE_1 don t empty constructor TYPE_1 call command executing I simplifies code VAR_2 isn t else
public TYPE_2 ( ) { <START> VAR_2 = TYPE_1 . get ( TYPE_3 . VAR_4 ) ; <END> }
public TYPE_2 ( ) { }
inline operations similar _CODE_ call
private TYPE_1 METHOD_1 ( TYPE_2 request ) throws IOException { <START> TYPE_3 < TYPE_1 > VAR_1 = ( ) - > { <END> TYPE_1 result = VAR_2 . METHOD_2 ( request ) ; request . VAR_3 ( result . VAR_4 ( ) ) ; return result ; } ; try { return METHOD_3 ( VAR_1 , STRING_1 ) ; } catch ( TYPE_4 e ) { throw new IOException ( e ) ; ...
private TYPE_1 METHOD_1 ( TYPE_2 request ) throws IOException { try { return METHOD_3 ( ( ) - > { TYPE_1 result = VAR_2 . METHOD_2 ( request ) ; request . VAR_3 ( result . VAR_4 ( ) ) ; return result ; } , STRING_1 ) ; } catch ( TYPE_4 e ) { throw new IOException ( e ) ; } }
_CODE_ need supply defaults
public Response METHOD_1 ( ANNOTATION_1 ( STRING_1 ) final String path , final TYPE_1 options ) { return TYPE_2 . call ( ( TYPE_2 . TYPE_8 < TYPE_4 > ) ( ) - > { if ( options == null ) { VAR_1 . METHOD_1 ( new TYPE_5 ( path ) , <START> TYPE_6 . METHOD_2 ( TYPE_7 . METHOD_3 ( ) ) ) ; <END> } else { VAR_1 . METHOD_1 ( ne...
public Response METHOD_1 ( ANNOTATION_1 ( STRING_1 ) final String path , final TYPE_1 options ) { return TYPE_2 . call ( ( TYPE_2 . TYPE_8 < TYPE_4 > ) ( ) - > { if ( options == null ) { VAR_1 . METHOD_1 ( new TYPE_5 ( path ) ) ; } else { VAR_1 . METHOD_1 ( new TYPE_5 ( path ) , options ) ; } return null ; } , TYPE_7 ....
prefer _CODE_ Assert _CODE_
public void METHOD_1 ( ) throws Exception { <START> Assert . assertTrue ( METHOD_2 ( VAR_1 ) . METHOD_1 ( ) > 0 ) ; <END> }
public void METHOD_1 ( ) throws Exception { assertTrue ( METHOD_2 ( VAR_1 ) . METHOD_1 ( ) > 0 ) ; }
need check VAR_2 ! = null
public synchronized void close ( ) throws IOException { if ( VAR_1 != null ) { VAR_1 . close ( ) ; VAR_1 = null ; <START> VAR_2 . close ( ) ; <END> VAR_2 = null ; } if ( VAR_3 != null ) { VAR_3 . METHOD_1 ( false ) ; VAR_3 = null ; } VAR_4 = TYPE_1 . VAR_6 ; }
public synchronized void close ( ) throws IOException { if ( VAR_1 != null ) { VAR_1 . close ( ) ; VAR_1 = null ; } if ( VAR_2 != null ) { VAR_2 . close ( ) ; VAR_2 = null ; } if ( VAR_3 != null ) { VAR_3 . METHOD_1 ( false ) ; VAR_3 = null ; } VAR_4 = TYPE_1 . VAR_6 ; }
doesn t throw ? METHOD_2 a file close channel
public void METHOD_1 ( int VAR_1 ) { TYPE_1 r = VAR_2 . remove ( VAR_1 ) ; if ( r != null ) { <START> r . VAR_3 . METHOD_2 ( ) ; <END> try { r . VAR_4 . METHOD_1 ( ) ; r . VAR_5 . close ( ) ; } catch ( IOException e ) { throw new RuntimeException ( e ) ; } } }
public void METHOD_1 ( int VAR_1 ) { TYPE_1 r = VAR_2 . remove ( VAR_1 ) ; if ( r != null ) { r . VAR_3 . METHOD_2 ( ) ; try { r . VAR_4 . METHOD_1 ( ) ; r . VAR_4 . channel ( ) . close ( ) ; } catch ( IOException e ) { throw new RuntimeException ( e ) ; } } }
private s meant class protected s meant subclasses
<START> void METHOD_1 ( ) { <END> METHOD_1 ( "" , "" ) ; }
protected void METHOD_1 ( ) { METHOD_1 ( "" , "" ) ; }
VAR_4 - > _CODE_
public static TYPE_6 . TYPE_7 METHOD_1 ( ) { TYPE_2 type = TYPE_3 . METHOD_2 ( TYPE_8 . VAR_2 , TYPE_2 . class ) ; switch ( type ) { case VAR_3 : <START> return VAR_4 - > new TYPE_4 ( ) ; <END> case VAR_5 : return args - > new TYPE_5 ( TYPE_3 . METHOD_3 ( ) ) ; default : throw new IllegalStateException ( STRING_1 + typ...
public static TYPE_6 . TYPE_7 METHOD_1 ( ) { TYPE_2 type = TYPE_3 . METHOD_2 ( TYPE_8 . VAR_2 , TYPE_2 . class ) ; switch ( type ) { case VAR_3 : return args - > new TYPE_4 ( args ) ; case VAR_5 : return args - > new TYPE_5 ( args ) ; default : throw new IllegalStateException ( STRING_1 + type ) ; } }
debugging output
public void remove ( Long VAR_1 ) { <START> System . out . METHOD_1 ( STRING_1 , VAR_1 ) ; <END> try { byte [ ] id = TYPE_1 . METHOD_2 ( VAR_1 ) ; VAR_2 . METHOD_3 ( VAR_3 , VAR_4 , id ) ; } catch ( TYPE_2 e ) { throw new RuntimeException ( e ) ; } }
public void remove ( Long VAR_1 ) { try { byte [ ] id = TYPE_1 . METHOD_2 ( VAR_1 ) ; VAR_2 . METHOD_3 ( VAR_3 , VAR_4 , id ) ; } catch ( TYPE_2 e ) { throw new RuntimeException ( e ) ; } }
VAR_1 null
public void METHOD_1 ( String name ) { <START> if ( VAR_1 . remove ( name ) != null ) { <END> VAR_2 . METHOD_2 ( ) ; } }
public void METHOD_1 ( String name ) { if ( VAR_1 != null && VAR_1 . remove ( name ) != null ) { VAR_2 . METHOD_2 ( ) ; } }
client shutdown need release
public void close ( ) throws IOException { <START> if ( VAR_1 . METHOD_1 ( ) ) { <END> return ; } VAR_2 . close ( ) ; try { VAR_2 . METHOD_2 ( VAR_3 ) ; } finally { VAR_4 . METHOD_3 ( VAR_5 , VAR_1 ) ; } }
public void close ( ) throws IOException { try { if ( VAR_1 . METHOD_1 ( ) ) { return ; } VAR_2 . close ( ) ; VAR_2 . METHOD_2 ( VAR_3 ) ; } finally { VAR_4 . METHOD_3 ( VAR_5 , VAR_1 ) ; } }
method throw IOException
private TYPE_3 ( TYPE_1 reader , long offset , long VAR_2 , long VAR_3 ) <START> throws IOException { <END> VAR_4 = reader ; TYPE_2 . METHOD_1 ( VAR_3 > 0 ) ; VAR_5 = offset ; VAR_6 = Math . VAR_7 ( VAR_4 . METHOD_2 ( ) , offset + VAR_2 ) ; VAR_8 = VAR_3 ; }
private TYPE_3 ( TYPE_1 reader , long offset , long VAR_2 , long VAR_3 ) { VAR_4 = reader ; TYPE_2 . METHOD_1 ( VAR_3 > 0 ) ; VAR_5 = offset ; VAR_6 = Math . VAR_7 ( VAR_4 . METHOD_2 ( ) , offset + VAR_2 ) ; VAR_8 = VAR_3 ; }
sense include TYPE_3 _CODE_ inquire client ( find alluxio master ) pretty central client I feel TYPE_1 needs 1 constructor takes a _CODE_
<START> public static TYPE_1 create ( TYPE_2 VAR_1 , TYPE_3 VAR_2 , <END> TYPE_4 VAR_3 ) { TYPE_5 props = null ; if ( VAR_3 != null ) { props = VAR_3 . METHOD_1 ( ) ; } TYPE_1 context = new TYPE_1 ( VAR_1 , props ) ; context . VAR_4 ( VAR_2 ) ; return context ; }
public static TYPE_1 create ( TYPE_2 VAR_1 , TYPE_3 VAR_2 , TYPE_4 VAR_3 ) { TYPE_1 context = new TYPE_1 ( VAR_1 , VAR_3 ) ; context . VAR_4 ( VAR_2 ) ; return context ; }
modify input conf
<START> public static TYPE_1 METHOD_1 ( TYPE_1 conf , Map < ? , ? > properties , <END> TYPE_2 source ) { TYPE_3 props = conf . VAR_1 ( ) ; props . VAR_2 ( properties , source ) ; return new TYPE_4 ( props ) ; }
public static void METHOD_1 ( TYPE_1 conf , Map < ? , ? > properties , TYPE_2 source ) { TYPE_3 props = conf . VAR_1 ( ) ; props . VAR_2 ( properties , source ) ; }
add worker host log message
public void close ( ) throws IOException { VAR_1 . METHOD_1 ( ) ; try { long VAR_2 = TYPE_1 . METHOD_2 ( TYPE_2 . VAR_4 ) ; if ( ! VAR_1 . METHOD_3 ( VAR_2 , TimeUnit . VAR_5 ) ) { <START> LOGGER . warn ( STRING_1 , VAR_2 ) ; <END> } } catch ( InterruptedException e ) { Thread . VAR_6 ( ) . METHOD_4 ( ) ; throw new Run...
public void close ( ) throws IOException { VAR_1 . METHOD_1 ( ) ; }
stopped super METHOD_1 ( )
public void METHOD_1 ( ) throws IOException { if ( VAR_1 != null ) { VAR_1 . METHOD_1 ( ) ; VAR_1 = null ; } super . METHOD_1 ( ) ; <START> VAR_2 . METHOD_1 ( ) ; <END> }
public void METHOD_1 ( ) throws IOException { if ( VAR_1 != null ) { VAR_1 . METHOD_1 ( ) ; VAR_1 = null ; } VAR_2 . METHOD_1 ( ) ; super . METHOD_1 ( ) ; }
import
<START> public List < TYPE_7 . TYPE_8 . TYPE_2 > METHOD_1 ( ) throws IOException , TYPE_3 { <END> TYPE_4 VAR_1 = VAR_2 . METHOD_2 ( ) ; try { return VAR_1 . METHOD_1 ( ) ; } catch ( TYPE_5 e ) { throw e ; } catch ( TYPE_6 e ) { throw e . VAR_3 ( ) ; } finally { VAR_2 . METHOD_3 ( VAR_1 ) ; } }
public List < TYPE_2 > METHOD_1 ( ) throws IOException , TYPE_3 { TYPE_4 VAR_1 = VAR_2 . METHOD_2 ( ) ; try { return VAR_1 . METHOD_1 ( ) ; } catch ( TYPE_5 e ) { throw e ; } catch ( TYPE_6 e ) { throw e . VAR_3 ( ) ; } finally { VAR_2 . METHOD_3 ( VAR_1 ) ; } }
currentTimeMillis ( ) some ordering sense dir names
private static String METHOD_1 ( String VAR_1 ) { return TYPE_1 . METHOD_2 ( VAR_1 , <START> STRING_1 + System . VAR_2 ( ) + STRING_2 + TYPE_2 . METHOD_3 ( 3 ) ) ; <END> }
private static String METHOD_1 ( String VAR_1 ) { return TYPE_1 . METHOD_2 ( VAR_1 , STRING_1 + System . currentTimeMillis ( ) + STRING_2 + TYPE_2 . METHOD_3 ( 3 ) ) ; }
private
<START> public void METHOD_1 ( TYPE_1 uri ) throws Exception { <END> try ( TYPE_2 VAR_1 = VAR_2 . METHOD_2 ( uri , TYPE_3 . METHOD_3 ( ) . METHOD_4 ( TYPE_5 . VAR_4 ) . METHOD_5 ( VAR_5 ) ) ) { VAR_1 . write ( TYPE_4 . METHOD_6 ( VAR_5 + 1 ) ) ; } }
private void METHOD_1 ( TYPE_1 uri ) throws Exception { try ( TYPE_2 VAR_1 = VAR_2 . METHOD_2 ( uri , TYPE_3 . METHOD_3 ( ) . METHOD_4 ( TYPE_5 . VAR_4 ) . METHOD_5 ( VAR_5 ) ) ) { VAR_1 . write ( TYPE_4 . METHOD_6 ( VAR_5 + 1 ) ) ; } }
zk@a : 0 b : 0 c : 1 change VAR_1
private void METHOD_1 ( String VAR_1 , String VAR_2 ) throws Exception { try { <START> METHOD_2 ( STRING_1 ) ; <END> METHOD_3 ( VAR_2 ) ; } catch ( IllegalArgumentException e ) { assertThat ( e . getMessage ( ) , METHOD_4 ( STRING_2 ) ) ; } }
private void METHOD_1 ( String VAR_1 , String VAR_2 ) throws Exception { try { METHOD_2 ( VAR_1 ) ; METHOD_3 ( VAR_2 ) ; } catch ( IllegalArgumentException e ) { assertThat ( e . getMessage ( ) , METHOD_4 ( STRING_2 ) ) ; } }
I METHOD_1 calls _CODE_ series methods unnecessary ( key ) call METHOD_1 METHOD_1
public int getInt ( TYPE_1 key ) { String VAR_1 = get ( key ) ; try { <START> return Integer . parseInt ( METHOD_1 ( VAR_1 ) ) ; <END> } catch ( TYPE_2 e ) { throw new RuntimeException ( TYPE_5 . TYPE_6 . getMessage ( key ) ) ; } catch ( TYPE_4 e ) { throw new RuntimeException ( e ) ; } }
public int getInt ( TYPE_1 key ) { String VAR_1 = get ( key ) ; try { return Integer . parseInt ( VAR_1 ) ; } catch ( TYPE_2 e ) { throw new RuntimeException ( TYPE_5 . TYPE_6 . getMessage ( key ) ) ; } }
case I s log a warning recommended write alluxio uri picks authority configuration
<START> public void METHOD_1 ( ) throws IOException { <END> TYPE_1 VAR_1 = TYPE_1 . create ( STRING_1 ) ; TYPE_2 . get ( VAR_1 , new org . VAR_2 . VAR_3 . conf . TYPE_3 ( ) ) ; METHOD_2 ( VAR_5 . VAR_6 . METHOD_3 ( STRING_2 ) ) ; }
public void METHOD_1 ( ) throws IOException { TYPE_1 VAR_1 = TYPE_1 . create ( STRING_1 ) ; TYPE_2 . get ( VAR_1 , new org . VAR_2 . VAR_3 . conf . TYPE_3 ( ) ) ; METHOD_2 ( VAR_5 . METHOD_3 ( STRING_2 ) ) ; }
put a finally
public void run ( ) { VAR_1 . start ( ) ; try { VAR_1 . METHOD_1 ( INT_1 ) ; if ( VAR_1 . METHOD_2 ( ) ) { <START> LOG . warn ( STRING_1 ) ; <END> } } catch ( InterruptedException e ) { return ; } }
public void run ( ) { VAR_1 . start ( ) ; try { VAR_1 . METHOD_1 ( INT_1 ) ; } catch ( InterruptedException e ) { return ; } finally { if ( VAR_1 . METHOD_2 ( ) ) { LOG . warn ( STRING_1 ) ; } } }
push reference counting close implementation TYPE_1 ? reads METHOD_4 ( ) / METHOD_2 ( )
public void close ( ) throws IOException { super . close ( ) ; synchronized ( VAR_1 ) { Pair < TYPE_1 , TYPE_2 > VAR_2 = TYPE_3 . get ( VAR_3 . METHOD_1 ( ) ) ; if ( VAR_2 == null ) { LOG . warn ( STRING_1 ) ; return ; } <START> if ( VAR_2 . METHOD_2 ( ) . METHOD_3 ( ) == 0 ) { <END> VAR_2 . METHOD_4 ( ) . close ( ) ; ...
public void close ( ) throws IOException { super . close ( ) ; if ( VAR_3 != null ) { VAR_3 . close ( ) ; } }
throw
<START> public void METHOD_1 ( ) throws TYPE_1 { <END> org . VAR_1 . VAR_2 . conf . TYPE_2 VAR_3 = new org . VAR_1 . VAR_2 . conf . TYPE_2 ( ) ; long VAR_4 = TYPE_2 . METHOD_2 ( ) . size ( ) ; TYPE_3 . METHOD_3 ( VAR_3 , TYPE_2 . METHOD_4 ( ) ) ; long VAR_5 = TYPE_2 . METHOD_2 ( ) . size ( ) ; Assert . assertEquals ( V...
public void METHOD_1 ( ) { org . VAR_1 . VAR_2 . conf . TYPE_2 VAR_3 = new org . VAR_1 . VAR_2 . conf . TYPE_2 ( ) ; long VAR_4 = TYPE_2 . METHOD_2 ( ) . size ( ) ; TYPE_3 . METHOD_3 ( VAR_3 , TYPE_2 . METHOD_4 ( ) ) ; long VAR_5 = TYPE_2 . METHOD_2 ( ) . size ( ) ; Assert . assertEquals ( VAR_4 , VAR_5 ) ; Assert . VA...
need METHOD_2 ( ) method ? instanceof a similar clearer safe cast VAR_3 subclass
public String METHOD_1 ( ) { <START> if ( METHOD_2 ( ) == TYPE_2 . VAR_2 ) { <END> TYPE_1 VAR_3 = ( TYPE_1 ) VAR_4 . METHOD_3 ( ) ; return VAR_3 . METHOD_1 ( ) ; } return null ; }
public String METHOD_1 ( ) { if ( VAR_4 . METHOD_3 ( ) instanceof TYPE_1 ) { TYPE_1 VAR_3 = ( TYPE_1 ) VAR_4 . METHOD_3 ( ) ; return VAR_3 . METHOD_1 ( ) ; } return null ; }
prefer original VAR_1 METHOD_2 ( ) < 0
private TYPE_1 METHOD_1 ( TYPE_2 < ? > VAR_1 ) { <START> if ( VAR_1 . METHOD_2 ( ) <= Constants . VAR_2 ) { <END> return null ; } long VAR_3 = VAR_1 . METHOD_3 ( ) + VAR_1 . METHOD_2 ( ) ; TYPE_1 VAR_4 = VAR_5 . METHOD_4 ( new TYPE_1 ( VAR_3 ) ) ; if ( VAR_4 == null || VAR_4 . METHOD_5 ( ) < VAR_3 || ( VAR_4 . METHOD_5...
private TYPE_1 METHOD_1 ( TYPE_2 < ? > VAR_1 ) { if ( VAR_1 . METHOD_2 ( ) == Constants . VAR_2 ) { return null ; } long VAR_3 = VAR_1 . METHOD_3 ( ) + VAR_1 . METHOD_2 ( ) ; TYPE_1 VAR_4 = VAR_5 . METHOD_4 ( new TYPE_1 ( VAR_3 ) ) ; if ( VAR_4 == null || VAR_4 . METHOD_5 ( ) < VAR_3 || ( VAR_4 . METHOD_5 ( ) == VAR_3 ...
good perform expensive / blocking operations constructor - call run ( ) instead
public TYPE_4 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 ) throws IOException { VAR_4 = VAR_2 ; VAR_5 = VAR_3 ; <START> VAR_6 = new TYPE_3 < > ( VAR_4 . METHOD_1 ( ) ) ; <END> }
public TYPE_4 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 ) throws IOException { VAR_4 = VAR_2 ; VAR_5 = VAR_3 ; }
need throws IOException signature
<START> public void METHOD_1 ( String path , TYPE_1 VAR_1 ) { <END> }
public void METHOD_1 ( String path , TYPE_1 VAR_1 ) throws IOException { }
( VAR_1 )
public synchronized TYPE_1 METHOD_1 ( ) { <START> if ( VAR_1 == true ) { <END> VAR_1 = false ; METHOD_2 ( ) ; } return VAR_2 ; }
public synchronized TYPE_1 METHOD_1 ( ) { if ( VAR_1 ) { VAR_1 = false ; METHOD_2 ( ) ; } return VAR_2 ; }
VAR_3 null
public T METHOD_1 ( List < TYPE_1 > VAR_1 ) throws IOException { for ( TYPE_1 entry : VAR_1 ) { if ( entry . VAR_2 ( ) ) { TYPE_2 VAR_3 = METHOD_2 ( ) ; <START> if ( VAR_3 != null ) { <END> VAR_3 . METHOD_3 ( entry ) ; } } else { VAR_4 . METHOD_3 ( entry ) ; } } return METHOD_4 ( ) ; }
public T METHOD_1 ( List < TYPE_1 > VAR_1 ) throws IOException { for ( TYPE_1 entry : VAR_1 ) { if ( entry . VAR_2 ( ) ) { TYPE_2 VAR_3 = METHOD_2 ( ) ; VAR_3 . METHOD_3 ( entry ) ; } else { VAR_4 . METHOD_3 ( entry ) ; } } return METHOD_4 ( ) ; }
limit scope
<START> public String METHOD_1 ( String path ) { <END> String VAR_1 = TYPE_1 . METHOD_1 ( path , TYPE_2 . METHOD_2 ( METHOD_3 ( ) , VAR_2 ) ) ; if ( ! VAR_1 . equals ( path ) ) { return VAR_1 ; } return TYPE_1 . METHOD_1 ( path , VAR_2 ) ; }
protected String METHOD_1 ( String path ) { String VAR_1 = TYPE_1 . METHOD_1 ( path , TYPE_2 . METHOD_2 ( METHOD_3 ( ) , VAR_2 ) ) ; if ( ! VAR_1 . equals ( path ) ) { return VAR_1 ; } return TYPE_1 . METHOD_1 ( path , VAR_2 ) ; }
METHOD_2 expensive ? ( new array copying entries )
TYPE_9 ( TYPE_1 uri , TYPE_2 VAR_2 , TYPE_7 . TYPE_8 VAR_3 ) throws TYPE_4 { <START> TYPE_5 . METHOD_1 ( ! VAR_2 . METHOD_2 ( ) . isEmpty ( ) ) ; <END> VAR_4 = uri ; VAR_5 = TYPE_6 . METHOD_3 ( VAR_4 . getPath ( ) ) ; VAR_6 = VAR_2 ; VAR_7 = VAR_3 ; }
TYPE_9 ( TYPE_1 uri , TYPE_2 VAR_2 , TYPE_7 . TYPE_8 VAR_3 ) throws TYPE_4 { TYPE_5 . METHOD_1 ( ! VAR_2 . isEmpty ( ) ) ; VAR_4 = uri ; VAR_5 = TYPE_6 . METHOD_3 ( VAR_4 . getPath ( ) ) ; VAR_6 = VAR_2 ; VAR_7 = VAR_3 ; }
add a precondition constructor VAR_1 - null s final don t need check more point worth inlining METHOD_1 calls
public boolean METHOD_1 ( ) { <START> return VAR_1 != null && VAR_1 . METHOD_1 ( ) ; <END> }
public boolean METHOD_1 ( ) { return VAR_1 . METHOD_1 ( ) ; }
initialize - 1 haven t logged a report
public TYPE_3 ( TYPE_1 VAR_2 , TYPE_1 VAR_3 ) { VAR_4 = VAR_2 ; VAR_5 = VAR_3 ; VAR_6 = new TYPE_2 ( ) ; <START> VAR_7 = System . currentTimeMillis ( ) ; <END> VAR_4 . METHOD_1 ( this : : METHOD_2 ) ; }
public TYPE_3 ( TYPE_1 VAR_2 , TYPE_1 VAR_3 ) { VAR_4 = VAR_2 ; VAR_5 = VAR_3 ; VAR_6 = new TYPE_2 ( ) ; VAR_4 . METHOD_1 ( this : : METHOD_2 ) ; }
METHOD_2 designed chained VAR_1 = TYPE_2 METHOD_2 ( host STRING_1 )
public TYPE_1 METHOD_1 ( String host ) { TYPE_2 . METHOD_2 ( host , STRING_1 ) ; <START> VAR_1 = host ; <END> return this ; }
public TYPE_1 METHOD_1 ( String host ) { VAR_1 = TYPE_2 . METHOD_2 ( host , STRING_1 ) ; return this ; }
static _CODE_
public void METHOD_1 ( ) throws Exception { <START> TYPE_1 . put ( VAR_1 , VAR_2 + STRING_1 + VAR_3 ) ; <END> TYPE_1 . put ( VAR_4 , VAR_5 + STRING_1 + VAR_6 ) ; TYPE_6 . TYPE_7 . get ( ) . METHOD_2 ( new TYPE_3 ( STRING_2 ) , TYPE_4 . METHOD_3 ( ) . METHOD_4 ( new TYPE_5 ( ( short ) INT_1 ) ) ) ; }
public void METHOD_1 ( ) throws Exception { TYPE_6 . TYPE_7 . get ( ) . METHOD_2 ( new TYPE_3 ( STRING_2 ) , TYPE_4 . METHOD_3 ( ) . METHOD_4 ( new TYPE_5 ( ( short ) INT_1 ) ) ) ; }
determine ID a process users able map ID a process metrics abnormal
public String getId ( ) { <START> return VAR_1 ; <END> }
public long getId ( ) { return VAR_1 ; }
nested retries ( METHOD_2 _CODE_ ) unneeded complexity
public synchronized void METHOD_1 ( final List < TYPE_1 > VAR_1 ) throws IOException { <START> METHOD_2 ( new TYPE_2 < TYPE_3 > ( ) { <END> @Override public TYPE_3 call ( ) throws TYPE_4 { VAR_2 . METHOD_3 ( TYPE_8 . TYPE_9 . getId ( ) , TYPE_6 . METHOD_4 ( ) , new TYPE_7 ( VAR_1 ) ) ; return null ; } } ) ; }
public synchronized void METHOD_1 ( final List < TYPE_1 > VAR_1 ) throws IOException { METHOD_2 ( new TYPE_2 < TYPE_3 > ( ) { @Override public TYPE_3 call ( ) throws TYPE_4 { VAR_2 . METHOD_3 ( Long . toString ( TYPE_8 . get ( ) . getId ( ) ) , TYPE_6 . METHOD_4 ( ) , new TYPE_7 ( VAR_1 ) ) ; return null ; } } ) ; }
logic METHOD_2 able handle empty set
public void METHOD_1 ( String VAR_1 , String VAR_2 , List < TYPE_1 > VAR_3 ) { if ( VAR_3 . isEmpty ( ) ) { return ; <START> } <END> VAR_4 . METHOD_2 ( VAR_2 , VAR_1 , VAR_3 ) ; }
public void METHOD_1 ( String VAR_1 , String VAR_2 , List < TYPE_1 > VAR_3 ) { VAR_4 . METHOD_2 ( VAR_2 , VAR_1 , VAR_3 ) ; }
safe VAR_1 set multiple times
public static TYPE_1 get ( ) { if ( VAR_1 == null ) { synchronized ( TYPE_1 . class ) { VAR_1 = create ( ) ; } } <START> return VAR_1 ; <END> }
public static TYPE_1 get ( ) { if ( VAR_1 == null ) { synchronized ( TYPE_1 . class ) { if ( VAR_1 == null ) { VAR_1 = create ( ) ; } } } return VAR_1 ; }
VAR_3 ? based current implementation context object metrics heartbeat gauge based context
private static void METHOD_1 ( ) { TYPE_1 . METHOD_2 ( TYPE_1 . METHOD_3 ( STRING_1 ) , new TYPE_2 < Long > ( ) { @Override public Long getValue ( ) { long VAR_1 = 0 ; <START> for ( TYPE_3 VAR_2 : VAR_3 . VAR_4 . values ( ) ) { <END> VAR_1 += VAR_2 . size ( ) ; } return VAR_1 ; } } ) ; }
private static void METHOD_1 ( ) { TYPE_1 . METHOD_2 ( TYPE_1 . METHOD_3 ( STRING_1 ) , new TYPE_2 < Long > ( ) { @Override public Long getValue ( ) { long VAR_1 = 0 ; for ( TYPE_3 VAR_2 : get ( ) . VAR_4 . values ( ) ) { VAR_1 += VAR_2 . size ( ) ; } return VAR_1 ; } } ) ; }
synchronized required
public TYPE_1 METHOD_1 ( long VAR_1 ) { TYPE_2 VAR_2 = VAR_3 . METHOD_2 ( VAR_4 , VAR_1 ) ; if ( VAR_2 == null ) { LOG . warn ( STRING_1 , VAR_1 ) ; return TYPE_1 . TYPE_3 ; } <START> synchronized ( VAR_2 ) { <END> VAR_2 . METHOD_3 ( ) ; } return TYPE_1 . TYPE_4 ; }
public TYPE_1 METHOD_1 ( long VAR_1 ) { TYPE_2 VAR_2 = VAR_3 . METHOD_2 ( VAR_4 , VAR_1 ) ; if ( VAR_2 == null ) { LOG . warn ( STRING_1 , VAR_1 ) ; return TYPE_1 . TYPE_3 ; } VAR_2 . METHOD_3 ( ) ; return TYPE_1 . TYPE_4 ; }
moved _CODE_
protected void METHOD_1 ( ) { try { <START> VAR_1 . METHOD_2 ( ) ; <END> VAR_2 . METHOD_3 ( ) ; } catch ( IOException e ) { throw TYPE_1 . METHOD_4 ( e ) ; } }
protected void METHOD_1 ( ) { try { VAR_2 . METHOD_3 ( ) ; } catch ( IOException e ) { throw TYPE_1 . METHOD_4 ( e ) ; } }
VAR_6 type Long
public TYPE_3 . TYPE_4 . TYPE_5 METHOD_1 ( ) { TYPE_3 . TYPE_4 . TYPE_5 VAR_2 = new TYPE_3 . TYPE_4 . TYPE_5 ( ) ; VAR_2 . METHOD_2 ( VAR_3 ) ; VAR_2 . METHOD_3 ( VAR_4 ) ; VAR_2 . METHOD_4 ( VAR_5 ) ; <START> if ( ! ( VAR_6 instanceof Integer ) && ! ( VAR_6 instanceof Long ) ) { <END> LOG . error ( STRING_1 , this ) ;...
public TYPE_3 . TYPE_4 . TYPE_5 METHOD_1 ( ) { TYPE_3 . TYPE_4 . TYPE_5 VAR_2 = new TYPE_3 . TYPE_4 . TYPE_5 ( ) ; VAR_2 . METHOD_2 ( VAR_3 . toString ( ) ) ; VAR_2 . METHOD_3 ( VAR_4 ) ; VAR_2 . METHOD_4 ( VAR_5 ) ; VAR_2 . METHOD_5 ( VAR_6 ) ; return VAR_2 ; }
protected
<START> protected TYPE_4 ( TYPE_1 VAR_2 ) { <END> this ( VAR_2 , new TYPE_2 ( ) , TYPE_3 . METHOD_1 ( Constants . VAR_3 , 2 ) ) ; }
TYPE_4 ( TYPE_1 VAR_2 ) { this ( VAR_2 , new TYPE_2 ( ) , TYPE_3 . METHOD_1 ( Constants . VAR_3 , 2 ) ) ; }
cast necessary ? I thought metrics longs
public long getValue ( Map < TYPE_1 , Set < TYPE_2 > > map ) { long value = 0 ; for ( TYPE_2 VAR_1 : map . get ( VAR_2 ) ) { <START> value += ( long ) VAR_1 . getValue ( ) ; <END> } return value ; }
public long getValue ( Map < TYPE_1 , Set < TYPE_2 > > map ) { long value = 0 ; for ( TYPE_2 VAR_1 : map . get ( VAR_2 ) ) { value += VAR_1 . getValue ( ) ; } return value ; }
a simpler approach code reuse ? javafor ( _CODE_ key : _CODE_ _CODE_ ( ) ) { map add ( key getName ( key ) ) ; } return map ;
public static Map < String , String > METHOD_1 ( ) { <START> Map < String , String > map = METHOD_2 ( ) ; <END> String VAR_1 = STRING_1 ; for ( Map . Entry < String , String > entry : map . entrySet ( ) ) { String value = entry . getValue ( ) ; if ( value != null && value . contains ( VAR_1 ) ) { map . put ( entry . ge...
public static Map < String , String > METHOD_1 ( ) { Map < String , String > map = METHOD_2 ( ) ; for ( Map . Entry < String , String > entry : map . entrySet ( ) ) { String value = entry . getValue ( ) ; if ( value != null ) { map . put ( entry . getKey ( ) , METHOD_3 ( value ) ) ; } } return map ; }
instead exception return some default
public TYPE_1 METHOD_1 ( String path ) throws TYPE_2 , IOException { <START> throw new TYPE_2 ( STRING_1 ) ; <END> }
public TYPE_1 METHOD_1 ( String path ) throws IOException { return null ; }
assertEquals similar instead mockito
public void METHOD_1 ( ) { when ( VAR_1 . METHOD_2 ( ) ) . METHOD_3 ( INT_1 ) ; <START> Assert . assertEquals ( INT_1 , METHOD_4 ( TYPE_1 . VAR_3 ) ) ; <END> when ( VAR_1 . METHOD_5 ( ) ) . METHOD_3 ( INT_2 ) ; Assert . assertEquals ( INT_2 , METHOD_4 ( TYPE_1 . VAR_4 ) ) ; Assert . assertEquals ( INT_3 , METHOD_4 ( TY...
public void METHOD_1 ( ) { when ( VAR_1 . METHOD_2 ( ) ) . METHOD_3 ( INT_1 ) ; assertEquals ( INT_1 , METHOD_4 ( TYPE_1 . VAR_3 ) ) ; when ( VAR_1 . METHOD_5 ( ) ) . METHOD_3 ( INT_2 ) ; assertEquals ( INT_2 , METHOD_4 ( TYPE_1 . VAR_4 ) ) ; assertEquals ( INT_3 , METHOD_4 ( TYPE_1 . VAR_5 ) ) ; }