ReviewComments stringlengths 1 2.35k | OriginalCode stringlengths 28 487 | ReviewedCode stringlengths 14 463 |
|---|---|---|
t need METHOD_3 interface sufficient : javaif ( ! VAR_2 METHOD_2 ( VAR_3 ) ( ) ) table VAR_4 ( ) add builder _CODE_ ( false ) ; _CODE_ constructor | public void METHOD_1 ( ) { if ( VAR_1 != null ) { VAR_1 . METHOD_1 ( ) ; } <START> if ( VAR_2 . METHOD_2 ( VAR_3 ) . get ( ) && ( VAR_1 == null || VAR_1 . METHOD_3 ( ) ) ) { <END> table . VAR_4 ( ) ; } super . METHOD_1 ( ) ; } | public void METHOD_1 ( ) { table . VAR_4 ( ) ; super . METHOD_1 ( ) ; } |
need a Collections VAR_7 ( cmd ) | public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { if ( VAR_2 ) { VAR_1 . println ( VAR_1 . METHOD_2 ( ) ) ; } TYPE_3 cmd = new TYPE_3 ( TYPE_4 . VAR_4 ) . METHOD_3 ( VAR_5 , TYPE_4 . TYPE_5 . VAR_4 ) ; <START> return VAR_1 . execute ( Collections . VAR_7 ( cmd ) ) ; <END> } | public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { if ( VAR_2 ) { VAR_1 . println ( VAR_1 . METHOD_2 ( ) ) ; } TYPE_3 cmd = new TYPE_3 ( TYPE_4 . VAR_4 ) . METHOD_3 ( VAR_5 , TYPE_4 . TYPE_5 . VAR_4 ) ; return VAR_1 . execute ( cmd ) ; } |
remove VAR_1 | public Collection < String > METHOD_1 ( String container ) throws IOException { <START> List < String > VAR_1 = ( List < String > ) METHOD_2 ( METHOD_3 ( ( ) - > client . VAR_2 ( container ) . info ( ) ) , Map . VAR_3 ) . get ( STRING_1 ) ; <END> return VAR_1 ; } | public Collection < String > METHOD_1 ( String container ) throws IOException { return ( List < String > ) METHOD_2 ( METHOD_3 ( ( ) - > client . VAR_2 ( container ) . info ( ) ) , Map . VAR_3 ) . get ( STRING_1 ) ; } |
return Set : ) | <START> public HashSet < TYPE_1 > METHOD_1 ( ) { <END> return new HashSet < > ( values ) ; } | public Set < TYPE_1 > METHOD_1 ( ) { return new HashSet < > ( values ) ; } |
I personally preferred else block I fine | private void update ( TYPE_1 type , TYPE_2 < TYPE_3 > VAR_1 ) { if ( type == VAR_2 ) { synchronized ( VAR_3 ) { VAR_1 . METHOD_1 ( VAR_3 ) ; } <START> return ; <END> } synchronized ( VAR_4 ) { VAR_1 . METHOD_1 ( VAR_4 ) ; } } | private void update ( TYPE_1 type , TYPE_2 < TYPE_3 > VAR_1 ) { if ( type == VAR_2 ) { synchronized ( VAR_3 ) { VAR_1 . METHOD_1 ( VAR_3 ) ; } } else { synchronized ( VAR_4 ) { VAR_1 . METHOD_1 ( VAR_4 ) ; } } } |
guessing wanted argument int ? valueOf unneeded | public TYPE_1 METHOD_1 ( String name , Integer value ) { if ( value != null ) { <START> this . options . put ( name , Integer . valueOf ( value ) ) ; <END> } return this ; } | public TYPE_1 METHOD_1 ( String name , Integer value ) { if ( value != null ) { this . options . put ( name , value ) ; } return this ; } |
shouldn t necessary point I wrong | public TYPE_1 METHOD_1 ( ) { TYPE_1 VAR_1 = new TYPE_1 ( ) ; VAR_1 . METHOD_2 ( Arrays . asList ( new TYPE_2 ( STRING_1 , VAR_2 ) ) ) ; <START> VAR_1 . METHOD_3 ( TYPE_3 . class . getName ( ) ) ; <END> VAR_1 . METHOD_4 ( TYPE_4 . VAR_4 + STRING_2 ) ; return VAR_1 ; } | public TYPE_1 METHOD_1 ( ) { TYPE_1 VAR_1 = new TYPE_1 ( ) ; VAR_1 . METHOD_2 ( Arrays . asList ( new TYPE_2 ( STRING_1 , VAR_2 ) ) ) ; VAR_1 . METHOD_4 ( TYPE_4 . VAR_4 + STRING_2 ) ; return VAR_1 ; } |
set global jmx VAR_2 cache s VAR_2 JMX disabled globally | protected String METHOD_1 ( ) { if ( ! VAR_1 . METHOD_2 ( ) ) { if ( VAR_1 . VAR_2 == null ) { VAR_1 . VAR_2 = VAR_2 ; } VAR_1 . METHOD_3 ( ) ; } return VAR_1 . VAR_3 ; <START> } <END> | protected String METHOD_1 ( ) { return VAR_1 . VAR_3 ; } |
unneeded change | <START> protected void METHOD_1 ( ) { <END> METHOD_2 ( ( ) - > METHOD_3 ( ) . METHOD_4 ( ) . isEmpty ( ) , INT_1 , TimeUnit . VAR_1 ) ; } | void METHOD_1 ( ) { METHOD_2 ( ( ) - > METHOD_3 ( ) . METHOD_4 ( ) . isEmpty ( ) , INT_1 , TimeUnit . VAR_1 ) ; } |
TYPE_3 TYPE_1 shouldn t updated | public TYPE_4 ( TYPE_1 ctx , TYPE_2 VAR_2 ) { super ( VAR_3 , VAR_4 , VAR_5 , VAR_6 , VAR_7 , VAR_8 ) ; this . ctx = ctx ; this . VAR_9 = new TYPE_3 ( ctx ) ; this . VAR_2 = VAR_2 ; <START> } <END> | public TYPE_4 ( TYPE_1 ctx , TYPE_2 VAR_2 ) { super ( VAR_3 , VAR_4 , VAR_5 , VAR_6 , VAR_7 , VAR_8 ) ; this . ctx = ctx ; this . VAR_2 = VAR_2 ; } |
getClass ( ) METHOD_1 ( ) leaving null default TCCL | public TYPE_5 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 ) { super ( ) ; <START> this . VAR_2 = VAR_2 == null ? getClass ( ) . METHOD_1 ( ) : VAR_2 ; <END> VAR_4 . METHOD_2 ( VAR_3 == null ? new TYPE_3 ( VAR_2 ) : new TYPE_4 ( VAR_3 , VAR_2 ) ) ; } | public TYPE_5 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 ) { super ( ) ; if ( VAR_2 == null ) { VAR_2 = getClass ( ) . METHOD_1 ( ) ; } VAR_4 . METHOD_2 ( VAR_3 == null ? new TYPE_3 ( VAR_2 ) : new TYPE_4 ( VAR_3 , VAR_2 ) ) ; } |
suggestionif ( VAR_2 < = 0 || ( VAR_2 & VAR_3 ) ! = 0 ) { | public TYPE_1 ( int VAR_2 ) { int VAR_3 = VAR_2 - 1 ; <START> if ( VAR_2 <= 0 && ( VAR_2 & VAR_3 ) == 0 ) { <END> throw new IllegalArgumentException ( STRING_1 + VAR_2 + STRING_2 ) ; } this . VAR_3 = VAR_3 ; } | public TYPE_1 ( int VAR_2 ) { int VAR_3 = VAR_2 - 1 ; if ( VAR_2 <= 0 || ( VAR_2 & VAR_3 ) != 0 ) { throw new IllegalArgumentException ( STRING_1 + VAR_2 + STRING_2 ) ; } this . VAR_3 = VAR_3 ; } |
oops good catch | void METHOD_1 ( long VAR_1 ) { if ( trace ) { <START> Long VAR_2 = VAR_3 . remove ( VAR_1 ) ; <END> if ( VAR_2 == null ) { throw new IllegalArgumentException ( ) ; } } TYPE_1 . METHOD_2 ( VAR_1 ) ; } | void METHOD_1 ( long VAR_1 ) { Long VAR_2 = VAR_3 . remove ( VAR_1 ) ; if ( trace ) { if ( VAR_2 == null ) { throw new IllegalArgumentException ( ) ; } } TYPE_1 . METHOD_2 ( VAR_1 ) ; } |
needed | public synchronized void METHOD_1 ( long VAR_1 ) { if ( ! VAR_2 ) { if ( trace ) { <START> log . trace ( STRING_1 ) ; <END> } VAR_2 = true ; VAR_3 = VAR_1 ; } VAR_4 ++ ; if ( trace ) { log . VAR_5 ( STRING_2 , VAR_4 ) ; } } | public synchronized void METHOD_1 ( long VAR_1 ) { if ( ! VAR_2 ) { VAR_2 = true ; VAR_3 = VAR_1 ; } VAR_4 ++ ; } |
return previous line | public TYPE_1 < ? > METHOD_1 ( TYPE_2 VAR_1 , int VAR_2 , boolean VAR_3 , Collection < TYPE_3 > VAR_4 ) { VAR_5 . METHOD_2 ( ) ; try { assertTrue ( VAR_6 . METHOD_3 ( 10 , TimeUnit . VAR_7 ) ) ; } catch ( InterruptedException e ) { throw new RuntimeException ( e ) ; } super . METHOD_1 ( VAR_1 , VAR_2 , VAR_3 , VAR_4 ) ... | public TYPE_1 < ? > METHOD_1 ( TYPE_2 VAR_1 , int VAR_2 , boolean VAR_3 , Collection < TYPE_3 > VAR_4 ) { VAR_5 . METHOD_2 ( ) ; try { assertTrue ( VAR_6 . METHOD_3 ( 10 , TimeUnit . VAR_7 ) ) ; } catch ( InterruptedException e ) { throw new RuntimeException ( e ) ; } return super . METHOD_1 ( VAR_1 , VAR_2 , VAR_3 , V... |
return previous line | public TYPE_1 < ? > METHOD_1 ( TYPE_2 VAR_1 , int VAR_2 , boolean VAR_3 , Collection < TYPE_3 > VAR_4 ) { VAR_5 . METHOD_1 ( VAR_1 , VAR_2 , VAR_3 , VAR_4 ) ; <START> return null ; <END> } | public TYPE_1 < ? > METHOD_1 ( TYPE_2 VAR_1 , int VAR_2 , boolean VAR_3 , Collection < TYPE_3 > VAR_4 ) { return VAR_5 . METHOD_1 ( VAR_1 , VAR_2 , VAR_3 , VAR_4 ) ; } |
allow removing TYPE_7 list Object VAR_2 isn t serializable | static void METHOD_1 ( TYPE_1 list ) { list . VAR_1 ( TYPE_10 . TYPE_11 . class , TYPE_10 . TYPE_12 . class , TYPE_4 . class , TYPE_6 . TYPE_13 . class , TYPE_6 . Status . class ) ; <START> list . VAR_1 ( TYPE_7 . class , TYPE_8 . class , Object . VAR_2 , Object [ ] . class , TYPE_9 . VAR_2 ) ; <END> } | static void METHOD_1 ( TYPE_1 list ) { list . VAR_1 ( TYPE_8 . VAR_2 , Object . VAR_2 , Object [ ] . class , TYPE_9 . VAR_2 ) ; } |
meh means a new allocation operation : - / I mess storing channel _CODE_ | public void METHOD_1 ( TYPE_1 channel ) { assert VAR_1 == null ; <START> this . VAR_1 = channel . VAR_2 ( ) . METHOD_2 ( new TYPE_2 ( channel ) , VAR_3 . METHOD_3 ( ) , TimeUnit . VAR_4 ) ; <END> } | public void METHOD_1 ( TYPE_1 channel ) { assert VAR_1 == null ; this . channel = channel ; this . VAR_1 = channel . VAR_2 ( ) . METHOD_2 ( this , VAR_3 . METHOD_3 ( ) , TimeUnit . VAR_4 ) ; } |
d logging | public void METHOD_1 ( TYPE_1 e ) { <START> VAR_1 . add ( e ) ; <END> System . out . println ( STRING_1 + e ) ; } | public void METHOD_1 ( TYPE_1 e ) { VAR_1 . add ( e ) ; } |
private | <START> TYPE_2 ( long VAR_2 , long VAR_3 , TYPE_1 version ) { <END> super ( VAR_3 , version ) ; this . VAR_2 = VAR_2 ; } | private TYPE_2 ( long VAR_2 , long VAR_3 , TYPE_1 version ) { super ( VAR_3 , version ) ; this . VAR_2 = VAR_2 ; } |
version protected I don t need access accessor | public String toString ( ) { return STRING_1 + <START> STRING_2 + version ( ) + <END> STRING_3 + VAR_1 + CHAR_1 ; } | public String toString ( ) { return STRING_1 + STRING_2 + version + STRING_3 + VAR_1 + CHAR_1 ; } |
< > missing | public < TYPE_1 , TYPE_2 > TYPE_3 < TYPE_4 < TYPE_1 , TYPE_2 > > METHOD_1 ( String name , TYPE_5 config ) { return TYPE_6 . METHOD_2 ( ( ) - > { METHOD_3 ( config ) ; TYPE_7 < TYPE_1 , TYPE_2 > cache = VAR_1 . METHOD_4 ( name , false ) ; TYPE_7 < TYPE_1 , TYPE_2 > VAR_2 = VAR_1 . METHOD_4 ( name , true ) ; <START> retu... | public < TYPE_1 , TYPE_2 > TYPE_3 < TYPE_4 < TYPE_1 , TYPE_2 > > METHOD_1 ( String name , TYPE_5 config ) { return TYPE_6 . METHOD_2 ( ( ) - > { METHOD_3 ( config ) ; TYPE_7 < TYPE_1 , TYPE_2 > cache = VAR_1 . METHOD_4 ( name , false ) ; TYPE_7 < TYPE_1 , TYPE_2 > VAR_2 = VAR_1 . METHOD_4 ( name , true ) ; return new T... |
VAR_3 ( ) enough _CODE_ | public TYPE_2 ( TYPE_1 [ ] VAR_2 ) { List < TYPE_1 > VAR_3 = Arrays . asList ( VAR_2 ) ; <START> VAR_4 = VAR_3 . contains ( TYPE_1 . VAR_5 ) ? true : false ; <END> VAR_6 = VAR_3 . contains ( TYPE_1 . VAR_7 ) ? true : false ; VAR_8 = VAR_3 . contains ( TYPE_1 . VAR_9 ) ? true : false ; } | private TYPE_2 ( TYPE_1 [ ] VAR_2 ) { List < TYPE_1 > VAR_3 = Arrays . asList ( VAR_2 ) ; VAR_4 = VAR_3 . contains ( TYPE_1 . VAR_5 ) ; VAR_6 = VAR_3 . contains ( TYPE_1 . VAR_7 ) ; VAR_8 = VAR_3 . contains ( TYPE_1 . VAR_9 ) ; } |
need add error cancel handles time ? done create VAR_3 | public void METHOD_1 ( TYPE_1 < ? super TYPE_2 < TYPE_3 , TYPE_4 > > VAR_1 ) { VAR_2 . add ( VAR_1 ) ; METHOD_2 ( ) ; VAR_3 . METHOD_1 ( VAR_1 ) ; <START> VAR_3 . METHOD_3 ( e - > { <END> log . error ( e ) ; VAR_4 . METHOD_4 ( VAR_5 ) ; } ) . METHOD_5 ( ( ) - > VAR_4 . METHOD_4 ( VAR_5 ) ) ; } | public void METHOD_1 ( TYPE_1 < ? super TYPE_2 < TYPE_3 , TYPE_4 > > VAR_1 ) { METHOD_2 ( ) ; VAR_3 . METHOD_1 ( VAR_1 ) ; } |
I d _CODE_ objects immutable a lot places | <START> public void METHOD_1 ( byte [ ] VAR_1 ) { <END> this . VAR_1 = VAR_1 ; this . VAR_2 = Arrays . VAR_3 ( VAR_1 ) ; } | void METHOD_1 ( byte [ ] VAR_1 ) { this . VAR_1 = VAR_1 ; this . VAR_2 = Arrays . VAR_3 ( VAR_1 ) ; } |
caller collection METHOD_2 field final METHOD_2 doesn t I needs a custom _CODE_ | Set < String > METHOD_1 ( ) { VAR_1 . METHOD_2 ( ) ; try { return VAR_2 ; } finally { <START> VAR_1 . METHOD_3 ( ) ; <END> } } | Set < String > METHOD_1 ( ) { VAR_1 . METHOD_2 ( ) ; try { return new HashSet < > ( VAR_2 ) ; } finally { VAR_1 . METHOD_3 ( ) ; } } |
I m surprised server doesn t | public void METHOD_1 ( ) { VAR_1 = TYPE_1 . METHOD_2 ( METHOD_3 ( ) ) ; assertEquals ( VAR_1 . METHOD_4 ( ) . size ( ) , 0 ) ; <START> TYPE_2 . METHOD_5 ( VAR_1 , new TYPE_3 ( ) ) ; <END> VAR_2 = TYPE_4 . METHOD_6 ( VAR_1 , INT_1 ) ; } | public void METHOD_1 ( ) { VAR_1 = TYPE_1 . METHOD_2 ( METHOD_3 ( ) ) ; assertEquals ( VAR_1 . METHOD_4 ( ) . size ( ) , 0 ) ; VAR_2 = TYPE_4 . METHOD_6 ( VAR_1 , INT_1 ) ; } |
thinking verify 10 active iterations stopping client reaper timeout | public void METHOD_1 ( ) throws InterruptedException { TYPE_1 VAR_1 = server ( ) . METHOD_2 ( ) ; for ( int i = 0 ; i < 10 ; i ++ ) { VAR_2 . METHOD_3 ( null , null , null , 10 , false ) ; <START> } <END> VAR_2 . METHOD_4 ( ) . METHOD_5 ( ) ; assertEquals ( 0 , VAR_1 . METHOD_6 ( ) ) ; } | public void METHOD_1 ( ) throws InterruptedException { TYPE_1 VAR_1 = server ( ) . METHOD_2 ( ) ; for ( int i = 0 ; i < 10 ; i ++ ) { VAR_2 . METHOD_3 ( null , null , null , 10 , false ) ; } assertEquals ( 10 , VAR_1 . METHOD_6 ( ) ) ; VAR_2 . METHOD_4 ( ) . METHOD_5 ( ) ; assertEquals ( 0 , VAR_1 . METHOD_6 ( ) ) ; } |
doesn t | default TYPE_3 < TYPE_2 < VAR_3 , VAR_4 > > VAR_5 ( TYPE_1 VAR_7 , TYPE_4 < ? super VAR_3 > filter , boolean VAR_9 , boolean VAR_10 ) { <START> return null ; <END> } | default TYPE_3 < TYPE_2 < VAR_3 , VAR_4 > > VAR_5 ( TYPE_1 VAR_7 , TYPE_4 < ? super VAR_3 > filter , boolean VAR_9 , boolean VAR_10 ) { return VAR_5 ( filter , VAR_9 , VAR_10 ) ; } |
field read | public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 , Response response ) { if ( response . VAR_2 ( ) ) { return ( TYPE_1 ) response ; } if ( response instanceof TYPE_3 ) { throw TYPE_4 . METHOD_2 ( VAR_1 , ( ( TYPE_3 ) response ) . METHOD_3 ( ) ) ; } if ( response instanceof TYPE_5 ) { <START> VAR_3 = true ; <END> return null ; } e... | public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 , Response response ) { if ( response . VAR_2 ( ) ) { return ( TYPE_1 ) response ; } if ( response instanceof TYPE_3 ) { throw TYPE_4 . METHOD_2 ( VAR_1 , ( ( TYPE_3 ) response ) . METHOD_3 ( ) ) ; } if ( response instanceof TYPE_5 ) { return null ; } else if ( response instanceof ... |
reduced tojavaif ( ! new File ( path ) METHOD_2 ( ) && VAR_1 ! = null ) { return new File ( new File ( VAR_1 ) path ) METHOD_3 ( ) ; } return path ; | public static String METHOD_1 ( String path , String VAR_1 ) { if ( new File ( path ) . METHOD_2 ( ) ) { return path ; } else if ( VAR_1 != null ) { return new File ( new File ( VAR_1 ) , path ) . METHOD_3 ( ) ; } else { return path ; } <START> } <END> | public static String METHOD_1 ( String path , String VAR_1 ) { if ( path == null ) { return null ; } else if ( new File ( path ) . METHOD_2 ( ) ) { return path ; } else if ( VAR_1 != null ) { return new File ( new File ( VAR_1 ) , path ) . METHOD_3 ( ) ; } else { return path ; } } |
technically another lambda scope PR imo | public TYPE_1 METHOD_1 ( ) { <START> return VAR_1 . METHOD_2 ( ) . map ( TYPE_2 : : get ) . METHOD_3 ( null ) ; <END> } | public TYPE_1 METHOD_1 ( ) { if ( VAR_1 . METHOD_2 ( ) . isPresent ( ) ) { return TYPE_2 . get ( VAR_1 . METHOD_2 ( ) . get ( ) ) ; } else { return null ; } } |
isn t performance - sensitive | public TYPE_1 < TYPE_2 > METHOD_1 ( TYPE_3 VAR_1 ) { if ( VAR_1 != this . VAR_1 ) { <START> if ( VAR_2 . METHOD_2 ( TYPE_4 . class ) ) { <END> return VAR_2 . METHOD_3 ( VAR_1 , true ) . METHOD_4 ( VAR_3 - > { METHOD_5 ( VAR_1 ) ; return VAR_2 . METHOD_3 ( VAR_1 , false ) ; } ) ; } else { return METHOD_5 ( VAR_1 ) ; } }... | public TYPE_1 < TYPE_2 > METHOD_1 ( TYPE_3 VAR_1 ) { if ( VAR_1 != this . VAR_1 ) { return VAR_2 . METHOD_3 ( VAR_1 , true ) . METHOD_4 ( VAR_3 - > { METHOD_5 ( VAR_1 ) ; return VAR_2 . METHOD_3 ( VAR_1 , false ) ; } ) ; } else { return TYPE_5 . METHOD_6 ( ) ; } } |
IMO caller check fact callers | public static void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) throws Exception { <START> if ( VAR_1 != null && VAR_2 . METHOD_2 ( VAR_1 ) ) { <END> TYPE_3 . METHOD_1 ( VAR_1 , VAR_2 ) ; log . VAR_3 ( STRING_1 , VAR_1 ) ; } } | public static void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) throws Exception { if ( VAR_2 . METHOD_2 ( VAR_1 ) ) { TYPE_3 . METHOD_1 ( VAR_1 , VAR_2 ) ; log . VAR_3 ( STRING_1 , VAR_1 ) ; } } |
response status ( ) METHOD_1 ( ) | public int getStatus ( ) { <START> return response . getStatus ( ) . METHOD_1 ( ) ; <END> } | public int getStatus ( ) { return response . status ( ) . METHOD_1 ( ) ; } |
return values = = null ? null : values iterator ( ) ( ) ; | private String METHOD_1 ( TYPE_1 VAR_1 , String name ) { List < String > values = VAR_1 . parameters ( ) . get ( name ) ; if ( values == null ) return null ; <START> return values . iterator ( ) . next ( ) ; <END> } | private String METHOD_1 ( TYPE_1 VAR_1 , String name ) { List < String > values = VAR_1 . parameters ( ) . get ( name ) ; return values == null ? null : values . iterator ( ) . next ( ) ; } |
METHOD_1 ( ) declare exact class need wildcards | <START> public Class < ? extends TYPE_1 > METHOD_1 ( ) { <END> return TYPE_1 . class ; } | public Class < TYPE_1 > METHOD_1 ( ) { return TYPE_1 . class ; } |
shouldn t index initialized MAX_INT order trigger 1st call | public void METHOD_1 ( Collection < TYPE_1 > VAR_1 ) { this . VAR_1 = VAR_1 . METHOD_2 ( new TYPE_1 [ VAR_1 . size ( ) ] ) ; if ( index >= this . VAR_1 . length ) { <START> index = TYPE_2 . METHOD_3 ( ) . METHOD_4 ( this . VAR_1 . length ) ; <END> } if ( trace ) { log . VAR_2 ( STRING_1 + Arrays . toString ( this . VAR... | public void METHOD_1 ( Collection < TYPE_1 > VAR_1 ) { this . VAR_1 = VAR_1 . METHOD_2 ( new TYPE_1 [ VAR_1 . size ( ) ] ) ; index = TYPE_2 . METHOD_3 ( ) . METHOD_4 ( this . VAR_1 . length ) ; if ( trace ) { log . VAR_2 ( STRING_1 + Arrays . toString ( this . VAR_1 ) ) ; } } |
don t eager cache anymore | public TYPE_1 < TYPE_2 , TYPE_3 > METHOD_1 ( TYPE_2 key , TYPE_1 < TYPE_2 , TYPE_3 > ... VAR_1 ) { <START> if ( VAR_2 . METHOD_2 ( ) ) { <END> TYPE_4 VAR_3 = METHOD_3 ( VAR_4 ) ; assertEquals ( key , VAR_3 . key ) ; } METHOD_4 ( ) ; return this ; } | public TYPE_1 < TYPE_2 , TYPE_3 > METHOD_1 ( TYPE_2 key , TYPE_1 < TYPE_2 , TYPE_3 > ... VAR_1 ) { TYPE_4 VAR_3 = METHOD_3 ( VAR_4 ) ; assertEquals ( key , VAR_3 . key ) ; METHOD_4 ( ) ; return this ; } |
I m I checks staying moved codec28 checks done HR protocol 2 8 ( HR protocol version ) leave carry checking protocol 2 9 wasteful server send | public boolean METHOD_1 ( ) { <START> boolean VAR_1 = status == VAR_2 <END> || status == VAR_3 || status == VAR_4 ; boolean VAR_5 = VAR_6 != null && VAR_6 . METHOD_2 ( TYPE_1 . VAR_8 ) ; return VAR_1 || VAR_5 ; } | public boolean METHOD_1 ( ) { return VAR_6 != null && VAR_6 . METHOD_2 ( TYPE_1 . VAR_8 ) ; } |
change order ? METHOD_2 order creation create embedded cache manager server METHOD_2 server cache manager | public void METHOD_1 ( ) { <START> VAR_1 . METHOD_2 ( ) ; <END> VAR_2 . METHOD_2 ( ) ; VAR_3 . METHOD_2 ( ) ; } | public void METHOD_1 ( ) { VAR_2 . METHOD_2 ( ) ; VAR_3 . METHOD_2 ( ) ; VAR_1 . METHOD_2 ( ) ; } |
METHOD_3 doesn t I d : private static void METHOD_1 ( TYPE_1 VAR_1 int VAR_2 ) throws Exception { { VAR_1 run ( ) ; METHOD_2 ( ) ; } catch ( TYPE_3 e ) { assertEquals ( VAR_2 e VAR_2 ) ; } } I d move helper methods tests | private static void METHOD_1 ( TYPE_1 VAR_1 , int VAR_2 ) { try { VAR_1 . run ( ) ; METHOD_2 ( ) ; } catch ( Exception e ) { TYPE_2 . METHOD_3 ( TYPE_3 . class , e ) ; <START> assertEquals ( VAR_2 , ( ( TYPE_3 ) e ) . VAR_2 ) ; <END> } } | private static void METHOD_1 ( TYPE_1 VAR_1 , int VAR_2 ) throws Exception { try { VAR_1 . run ( ) ; METHOD_2 ( ) ; } catch ( TYPE_3 e ) { assertEquals ( VAR_2 , e . VAR_2 ) ; } } |
VAR_5 = VAR_1 VAR_5 ( ) ; | public Builder < ? > read ( TYPE_1 VAR_1 ) { VAR_2 = VAR_1 . METHOD_1 ( ) ; VAR_3 = VAR_1 . METHOD_2 ( ) ; TYPE_2 VAR_4 = VAR_1 . METHOD_3 ( ) ; <START> VAR_5 = VAR_4 ; <END> return this ; } | public Builder < ? > read ( TYPE_1 VAR_1 ) { VAR_2 = VAR_1 . METHOD_1 ( ) ; VAR_3 = VAR_1 . METHOD_2 ( ) ; VAR_5 = VAR_1 . METHOD_3 ( ) ; return this ; } |
unnecessary cast avoid unchecked warning declaring entry VAR_3 generic parameters < String String > | public TYPE_2 ( ) { this . VAR_2 = 2 ; this . VAR_3 = ( VAR_4 , VAR_5 ) - > { <START> TYPE_1 entry = VAR_4 != null ? VAR_4 : ( TYPE_1 ) VAR_5 . get ( 0 ) ; <END> entry . VAR_6 ( VAR_7 ) ; return entry ; } ; } | public TYPE_2 ( ) { this . VAR_2 = 2 ; this . VAR_3 = ( VAR_4 , VAR_5 ) - > { TYPE_1 < String , String > entry = VAR_4 != null ? VAR_4 : VAR_5 . get ( 0 ) ; entry . VAR_6 ( VAR_7 ) ; return entry ; } ; } |
VAR_1 + 1 ? other ( ) methods constructor parameter range | public static TYPE_1 of ( int VAR_1 ) { <START> TYPE_1 set = new TYPE_1 ( 1 ) ; <END> set . set ( VAR_1 ) ; return set ; } | public static TYPE_1 of ( int VAR_1 ) { TYPE_1 set = new TYPE_1 ( ) ; set . set ( VAR_1 ) ; return set ; } |
unnecessary null check | private static void METHOD_1 ( Iterator < ? > VAR_1 ) { <START> if ( VAR_1 != null && VAR_1 instanceof TYPE_1 ) { <END> ( ( TYPE_1 ) VAR_1 ) . close ( ) ; } } | private static void METHOD_1 ( Iterator < ? > VAR_1 ) { if ( VAR_1 instanceof TYPE_1 ) { ( ( TYPE_1 ) VAR_1 ) . close ( ) ; } } |
change _CODE_ return a - > 0 partitioner local invalidation caches instead | private int METHOD_1 ( Object key ) { if ( VAR_1 . METHOD_2 ( ) ) { return VAR_2 . METHOD_1 ( key ) ; } <START> return 0 ; <END> } | private int METHOD_1 ( Object key ) { return VAR_2 . METHOD_1 ( key ) ; } |
VAR_1 removed ( cache getName ( ) ) | public TYPE_1 get ( Object key ) { METHOD_1 ( key ) ; <START> METHOD_2 ( cache , VAR_1 ) ; <END> TYPE_2 < TYPE_3 , TYPE_1 > VAR_2 = METHOD_3 ( ) . get ( key ) ; if ( VAR_2 != null ) { return VAR_2 . getValue ( ) ; } return null ; } | public TYPE_1 get ( Object key ) { METHOD_1 ( key ) ; METHOD_2 ( cache , cache . getName ( ) ) ; TYPE_2 < TYPE_3 , TYPE_1 > VAR_2 = METHOD_3 ( ) . get ( key ) ; if ( VAR_2 != null ) { return VAR_2 . getValue ( ) ; } return null ; } |
1 IMO commands write / read segment | protected void METHOD_1 ( TYPE_1 output , TYPE_2 command ) throws IOException { command . VAR_1 ( output ) ; if ( command instanceof TYPE_3 ) { output . VAR_2 ( ( ( TYPE_3 ) command ) . METHOD_2 ( ) ) ; } if ( command instanceof TYPE_4 ) { <START> TYPE_5 . METHOD_3 ( output , ( ( TYPE_4 ) command ) . METHOD_4 ( ) ) ; <... | protected void METHOD_1 ( TYPE_1 output , TYPE_2 command ) throws IOException { command . VAR_1 ( output ) ; if ( command instanceof TYPE_3 ) { output . VAR_2 ( ( ( TYPE_3 ) command ) . METHOD_2 ( ) ) ; } } |
symmetry qualify field remove others : smile : | public TYPE_7 ( ) { this . VAR_2 = new TYPE_1 < > ( Thread . VAR_3 ( ) . METHOD_1 ( ) ) ; this . VAR_4 = new TYPE_2 ( this ) ; this . VAR_5 = new TYPE_3 ( this ) ; this . VAR_6 = new TYPE_4 ( this ) ; this . VAR_7 = new TYPE_5 ( this ) ; <START> VAR_8 = new TYPE_6 ( this ) ; <END> } | public TYPE_7 ( ) { this . VAR_2 = new TYPE_1 < > ( Thread . VAR_3 ( ) . METHOD_1 ( ) ) ; this . VAR_4 = new TYPE_2 ( this ) ; this . VAR_5 = new TYPE_3 ( this ) ; this . VAR_6 = new TYPE_4 ( this ) ; this . VAR_7 = new TYPE_5 ( this ) ; this . VAR_8 = new TYPE_6 ( this ) ; } |
proper dependency graphs avoid conjured numbers | <START> public void METHOD_1 ( ) { <END> if ( trace ) { log . VAR_1 ( STRING_1 , VAR_2 . METHOD_2 ( ) ) ; } VAR_3 = false ; for ( TYPE_1 cache : VAR_4 . values ( ) ) { cache . VAR_5 ( ) . METHOD_3 ( ) ; } VAR_6 . METHOD_4 ( ) ; VAR_7 . METHOD_5 ( VAR_8 ) ; } | public void METHOD_1 ( ) { if ( trace ) { log . VAR_1 ( STRING_1 , VAR_2 . METHOD_2 ( ) ) ; } VAR_3 = false ; for ( TYPE_1 cache : VAR_4 . values ( ) ) { cache . VAR_5 ( ) . METHOD_3 ( ) ; } VAR_6 . METHOD_4 ( ) ; } |
method | void METHOD_1 ( TYPE_1 target , TYPE_2 command , long VAR_1 , TYPE_3 VAR_2 , boolean VAR_3 , boolean VAR_4 , boolean VAR_5 ) { TYPE_4 message = new TYPE_4 ( METHOD_2 ( target ) ) ; METHOD_3 ( message , command , VAR_1 ) ; METHOD_4 ( message , VAR_2 , VAR_3 , VAR_4 ) ; <START> if ( VAR_5 && ! VAR_6 . contains ( target )... | void METHOD_1 ( TYPE_1 target , TYPE_2 command , long VAR_1 , TYPE_3 VAR_2 , boolean VAR_3 , boolean VAR_4 , boolean VAR_5 ) { if ( VAR_5 && ! VAR_6 . contains ( target ) ) return ; TYPE_4 message = new TYPE_4 ( METHOD_2 ( target ) ) ; METHOD_3 ( message , command , VAR_1 ) ; METHOD_4 ( message , VAR_2 , VAR_3 , VAR_4 ... |
removing union CH doesn t work I conflict CH reading set _CODE_ change TYPE_3 VAR_5 | public void METHOD_1 ( TYPE_1 VAR_1 , List < TYPE_2 > VAR_2 ) { VAR_3 = new TYPE_3 ( VAR_3 . METHOD_2 ( ) + 1 , VAR_3 . METHOD_3 ( ) + 1 , <START> VAR_1 , VAR_1 , VAR_1 , <END> TYPE_3 . TYPE_4 . VAR_5 , VAR_2 , METHOD_4 ( VAR_2 ) ) ; } | public void METHOD_1 ( TYPE_1 VAR_1 , List < TYPE_2 > VAR_2 ) { VAR_3 = new TYPE_3 ( VAR_3 . METHOD_2 ( ) + 1 , VAR_3 . METHOD_3 ( ) + 1 , VAR_1 , null , TYPE_3 . TYPE_4 . VAR_5 , VAR_2 , METHOD_4 ( VAR_2 ) ) ; } |
returning VAR_2 values ( ) | synchronized void METHOD_1 ( ) { List < Map < TYPE_1 , TYPE_2 < TYPE_3 , TYPE_4 > > > VAR_1 = VAR_2 . entrySet ( ) . stream ( ) . map ( Map . Entry : : getValue ) <START> . collect ( Collectors . VAR_3 ( ) ) ; <END> clear ( ) ; VAR_4 . METHOD_2 ( Collections . VAR_5 ( VAR_1 ) ) ; } | synchronized void METHOD_1 ( ) { List < Map < TYPE_1 , TYPE_2 < TYPE_3 , TYPE_4 > > > VAR_1 = new ArrayList < > ( VAR_2 . values ( ) ) ; clear ( ) ; VAR_4 . METHOD_2 ( Collections . VAR_5 ( VAR_1 ) ) ; } |
I prefer initialize inline field declaration constructor I nitpicking | public TYPE_1 ( String name ) { this . name = name ; <START> this . VAR_2 = this : : METHOD_1 ; <END> this . VAR_3 = this : : METHOD_2 ; } | public TYPE_1 ( String name ) { this . name = name ; } |
_CODE_ necessary | public void METHOD_1 ( TYPE_1 event ) { try { VAR_1 . put ( event ) ; <START> log . VAR_2 ( STRING_1 , name , event ) ; <END> } catch ( InterruptedException e ) { log . VAR_3 ( e , STRING_2 , name , event ) ; } } | public void METHOD_1 ( TYPE_1 event ) { try { VAR_1 . put ( event ) ; if ( trace ) { log . VAR_2 ( STRING_1 , name , event ) ; } } catch ( InterruptedException e ) { log . VAR_3 ( e , STRING_2 , name , event ) ; } } |
putting VAR_4 = = VAR_4 comparison fail faster : ) | public boolean equals ( Object o ) { if ( this == o ) return true ; if ( o == null || getClass ( ) != o . getClass ( ) ) return false ; TYPE_1 that = ( TYPE_1 ) o ; return TYPE_2 . equals ( VAR_1 , that . VAR_1 ) && TYPE_2 . equals ( VAR_2 , that . VAR_2 ) && TYPE_2 . equals ( VAR_3 , that . VAR_3 ) && <START> VAR_4 ==... | public boolean equals ( Object o ) { if ( this == o ) return true ; if ( o == null || getClass ( ) != o . getClass ( ) ) return false ; TYPE_1 that = ( TYPE_1 ) o ; return VAR_4 == that . VAR_4 && TYPE_2 . equals ( VAR_1 , that . VAR_1 ) && TYPE_2 . equals ( VAR_2 , that . VAR_2 ) && TYPE_2 . equals ( VAR_3 , that . VA... |
buffer VAR_1 ( size ) | public boolean METHOD_1 ( int size ) { <START> return buffer . VAR_1 ( ) ; <END> } | public boolean METHOD_1 ( int size ) { return buffer . VAR_1 ( size ) ; } |
unnecessary boxing | public Integer METHOD_1 ( ) { <START> return Integer . valueOf ( VAR_1 . size ( ) ) ; <END> } | public Integer METHOD_1 ( ) { return VAR_1 . size ( ) ; } |
minute code utilises _CODE_ ( null ) _CODE_ new TYPE_2 ( ) called builder a bit description I missing intend TYPE_2 constructor | <START> public TYPE_2 ( boolean VAR_2 , boolean VAR_3 , Map < String , TYPE_1 > VAR_4 ) { <END> this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; this . VAR_4 = VAR_4 ; } | TYPE_2 ( boolean VAR_2 , boolean VAR_3 , Map < String , TYPE_1 > VAR_4 ) { this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; this . VAR_4 = VAR_4 ; } |
METHOD_2 ( cache : : METHOD_1 ) | static TYPE_1 METHOD_1 ( final TYPE_2 < ? , ? > cache ) { TYPE_3 action = new TYPE_3 ( cache ) ; <START> return METHOD_2 ( action ) ; <END> } | static TYPE_1 METHOD_1 ( final TYPE_2 < ? , ? > cache ) { return METHOD_2 ( cache : : METHOD_1 ) ; } |
curly else branch ? : ) | void METHOD_1 ( String message , String VAR_1 ) { if ( VAR_2 ) { METHOD_1 ( VAR_1 + message + VAR_3 ) ; } else <START> METHOD_1 ( message ) ; <END> } | void METHOD_1 ( String message , String VAR_1 ) { if ( VAR_2 ) { METHOD_1 ( VAR_1 + message + VAR_3 ) ; } else { METHOD_1 ( message ) ; } } |
VAR_1 field ? I set don t | public TYPE_1 < TYPE_2 > METHOD_1 ( TYPE_3 VAR_1 ) { <START> this . VAR_1 = VAR_1 ; <END> this . VAR_2 . METHOD_2 ( VAR_1 ) ; return super . METHOD_1 ( VAR_1 ) ; } | public TYPE_1 < TYPE_2 > METHOD_1 ( TYPE_3 VAR_1 ) { this . VAR_2 . METHOD_2 ( VAR_1 ) ; return super . METHOD_1 ( VAR_1 ) ; } |
declaration initialization command done line | public TYPE_1 METHOD_1 ( TYPE_2 < ? , ? > cache , TYPE_3 VAR_1 , TYPE_4 VAR_2 , int VAR_3 ) { <START> TYPE_1 command = null ; <END> command = METHOD_2 ( ) ; command . VAR_4 ( cache , VAR_1 , VAR_2 , VAR_3 ) ; return command ; } | public TYPE_1 METHOD_1 ( TYPE_2 < ? , ? > cache , TYPE_3 VAR_1 , TYPE_4 VAR_2 , int VAR_3 ) { TYPE_1 command = METHOD_2 ( ) ; command . VAR_4 ( cache , VAR_1 , VAR_2 , VAR_3 ) ; return command ; } |
don t want create a factory ? injected : ) | public void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) { <START> this . VAR_1 = VAR_1 ; <END> this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_1 . METHOD_2 ( ) . METHOD_3 ( ) ; } | public void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) { this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_1 . METHOD_2 ( ) . METHOD_3 ( ) ; } |
enum implemented TYPE_2 find configured VAR_2 = = VAR_1 | public static TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { if ( VAR_1 == null ) return NONE ; for ( TYPE_1 VAR_2 : TYPE_1 . values ( ) ) <START> if ( VAR_2 . VAR_3 != null && TYPE_3 . equals ( VAR_2 . VAR_3 . getClass ( ) , VAR_1 . getClass ( ) ) ) <END> return VAR_2 ; return VAR_4 ; } | public static TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { if ( VAR_1 == null ) return NONE ; for ( TYPE_1 VAR_2 : TYPE_1 . values ( ) ) if ( VAR_2 == VAR_1 ) return VAR_2 ; return VAR_4 ; } |
checks work _CODE_ validate ( ) logging warnings merge policy I m METHOD_6 > 1 check needed | private boolean METHOD_1 ( TYPE_1 config , TYPE_2 VAR_1 ) { if ( config == null || VAR_1 . METHOD_2 ( ) || VAR_1 . METHOD_3 ( ) ) return false ; TYPE_3 VAR_2 = config . VAR_3 ( ) ; <START> return VAR_2 . METHOD_4 ( ) . METHOD_1 ( ) && VAR_2 . METHOD_5 ( ) . METHOD_6 ( ) > 1 ; <END> } | private boolean METHOD_1 ( TYPE_1 config , TYPE_2 VAR_1 ) { if ( config == null || VAR_1 . METHOD_2 ( ) || VAR_1 . METHOD_3 ( ) ) return false ; return config . VAR_3 ( ) . METHOD_4 ( ) . METHOD_1 ( ) ; } |
interpreting _CODE_ [ [ 0 1 2 ] [ 3 ] ] failed test results kind tough I d give partition scenarios a instead TBH I started thinking I some factory ( ) implementations I realized I idea new int [ ] { 0 1 2 } new int [ ] { 3 } changes test compared new int [ ] { 0 1 } new int [ ] { 2 } | protected Object [ ] METHOD_1 ( ) { <START> String VAR_1 = String . format ( STRING_1 , Arrays . toString ( VAR_2 . METHOD_2 ( ) ) , Arrays . toString ( VAR_3 . METHOD_2 ( ) ) ) ; <END> return METHOD_3 ( super . METHOD_1 ( ) , VAR_1 ) ; } | protected Object [ ] METHOD_1 ( ) { return METHOD_3 ( super . METHOD_1 ( ) , description ) ; } |
I m afraid equivalent VAR_1 ! = null doesn t return false VAR_1 = = I suggest ( VAR_1 = = ) return false ; else return VAR_1 ! = null | public boolean METHOD_1 ( ) { TYPE_1 VAR_1 = METHOD_2 ( ) ; <START> return ( VAR_1 instanceof TYPE_2 && VAR_1 != TYPE_2 . NONE ) || VAR_1 != null ; <END> } | public boolean METHOD_1 ( ) { TYPE_1 VAR_1 = METHOD_2 ( ) ; if ( VAR_1 == TYPE_2 . NONE ) return false ; return VAR_1 != null ; } |
I METHOD_1 ( ) called _CODE_ ( ) I d replace condition a null check VAR_3 | void METHOD_1 ( ) { if ( trace ) log . VAR_1 ( STRING_1 , VAR_2 ) ; <START> if ( METHOD_2 ( ) ) <END> VAR_3 . METHOD_3 ( true ) ; } | void METHOD_1 ( ) { if ( trace ) log . VAR_1 ( STRING_1 , VAR_2 ) ; if ( VAR_3 != null ) VAR_3 . METHOD_3 ( true ) ; } |
luck VAR_6 null wouldn t able read command | public void METHOD_1 ( TYPE_1 input ) throws IOException , TYPE_2 { VAR_1 = ( TYPE_3 ) input . VAR_2 ( ) ; if ( VAR_1 != null ) { id = input . VAR_3 ( ) ; } VAR_4 = input . VAR_5 ( ) ; VAR_6 = TYPE_4 . METHOD_2 ( input , ArrayList : : new ) ; <START> if ( VAR_6 == null ) { <END> VAR_7 = TYPE_4 . METHOD_3 ( input , TYPE... | public void METHOD_1 ( TYPE_1 input ) throws IOException , TYPE_2 { VAR_1 = ( TYPE_3 ) input . VAR_2 ( ) ; if ( VAR_1 != null ) { id = input . VAR_3 ( ) ; } VAR_4 = input . VAR_5 ( ) ; VAR_6 = TYPE_4 . METHOD_2 ( input , ArrayList : : new ) ; } |
VAR_3 null | protected TYPE_1 < ? > METHOD_1 ( TYPE_2 command , TYPE_3 VAR_1 , TYPE_1 < ? > VAR_2 ) { TYPE_1 < ? > VAR_3 = METHOD_2 ( command . getKey ( ) , VAR_1 , command . VAR_4 ( ) ) ; <START> return VAR_3 == null ? VAR_2 : TYPE_1 . METHOD_3 ( VAR_2 , VAR_3 ) ; <END> } | protected TYPE_1 < ? > METHOD_1 ( TYPE_2 command , TYPE_3 VAR_1 , TYPE_1 < ? > VAR_2 ) { TYPE_1 < ? > VAR_3 = METHOD_2 ( command . getKey ( ) , VAR_1 , command . VAR_4 ( ) ) ; return TYPE_1 . METHOD_3 ( VAR_2 , VAR_3 ) ; } |
TYPE_3 thrown removed | private static TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) <START> throws TYPE_3 { <END> final TYPE_4 VAR_2 = METHOD_2 ( VAR_1 . METHOD_3 ( VAR_3 ) ) ; final TYPE_1 VAR_4 = VAR_2 . METHOD_4 ( VAR_2 . size ( ) - 1 ) ; return VAR_4 ; } | private static TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { final TYPE_4 VAR_2 = METHOD_2 ( VAR_1 . METHOD_3 ( VAR_3 ) ) ; final TYPE_1 VAR_4 = VAR_2 . METHOD_4 ( VAR_2 . size ( ) - 1 ) ; return VAR_4 ; } |
persistent problem deleting counter persistent storage | public void METHOD_1 ( TYPE_1 context ) { TYPE_2 container = this . VAR_1 . METHOD_2 ( ) ; TYPE_3 VAR_2 = TYPE_4 . METHOD_3 ( container ) ; <START> VAR_2 . remove ( VAR_3 ) ; <END> } | public void METHOD_1 ( TYPE_1 context ) { } |
doesn t VAR_6 METHOD_1 ( ) include size LRU pointers | public TYPE_4 ( int VAR_2 , long VAR_3 , TYPE_1 type ) { super ( VAR_2 ) ; this . VAR_3 = VAR_3 ; if ( type == TYPE_1 . VAR_4 ) { VAR_5 = i - > 1 ; } else { <START> VAR_5 = i - > VAR_6 . METHOD_1 ( i ) + TYPE_2 . METHOD_1 ( ) ; <END> } this . VAR_7 = new TYPE_3 ( ) ; VAR_8 = 0 ; } | public TYPE_4 ( int VAR_2 , long VAR_3 , TYPE_1 type ) { super ( VAR_2 ) ; this . VAR_3 = VAR_3 ; if ( type == TYPE_1 . VAR_4 ) { VAR_5 = i - > 1 ; } else { VAR_5 = i - > VAR_6 . METHOD_1 ( i ) ; } this . VAR_7 = new TYPE_3 ( ) ; VAR_8 = 0 ; } |
want a message create | public void METHOD_1 ( TYPE_1 < TYPE_2 , TYPE_3 > event ) { String VAR_1 = event . getKey ( ) . getName ( ) ; <START> VAR_2 . log . METHOD_2 ( STRING_1 , VAR_1 ) ; <END> VAR_2 . METHOD_3 ( VAR_1 ) ; } | public void METHOD_1 ( TYPE_1 < TYPE_2 , TYPE_3 > event ) { String VAR_1 = event . getKey ( ) . getName ( ) ; VAR_2 . METHOD_3 ( VAR_1 ) ; } |
I don t VAR_5 null | public void METHOD_1 ( String VAR_1 ) { VAR_2 . METHOD_2 ( TYPE_2 . VAR_4 ) ; <START> if ( VAR_5 != null ) <END> VAR_5 . METHOD_1 ( VAR_1 ) ; else { TYPE_1 . METHOD_1 ( this , VAR_1 ) ; } } | public void METHOD_1 ( String VAR_1 ) { VAR_5 . METHOD_1 ( VAR_1 ) ; } |
METHOD_4 METHOD_5 log remove log essage | protected void METHOD_1 ( long VAR_1 , long VAR_2 ) { long VAR_3 = VAR_4 . METHOD_2 ( VAR_2 ) ; long VAR_5 = VAR_4 . METHOD_2 ( VAR_1 ) ; VAR_6 . METHOD_3 ( ) ; try { if ( trace ) { <START> log . VAR_7 ( STRING_1 , VAR_2 , <END> VAR_1 ) ; } METHOD_4 ( VAR_2 ) ; METHOD_5 ( VAR_1 ) ; VAR_8 += VAR_5 ; VAR_8 -= VAR_3 ; sup... | protected void METHOD_1 ( long VAR_1 , long VAR_2 ) { long VAR_3 = VAR_4 . METHOD_2 ( VAR_2 ) ; long VAR_5 = VAR_4 . METHOD_2 ( VAR_1 ) ; VAR_6 . METHOD_3 ( ) ; try { METHOD_4 ( VAR_2 ) ; METHOD_5 ( VAR_1 ) ; VAR_8 += VAR_5 ; VAR_8 -= VAR_3 ; super . METHOD_1 ( VAR_1 , VAR_2 ) ; } finally { VAR_6 . METHOD_6 ( ) ; } } |
prepare commands 0 VAR_4 common | public void METHOD_1 ( TYPE_1 input ) throws IOException , TYPE_2 { super . METHOD_1 ( input ) ; VAR_1 = input . VAR_2 ( ) ; VAR_3 = input . VAR_2 ( ) ; <START> VAR_4 = TYPE_3 . METHOD_2 ( input , TYPE_4 : : METHOD_3 ) ; <END> } | public void METHOD_1 ( TYPE_1 input ) throws IOException , TYPE_2 { super . METHOD_1 ( input ) ; VAR_1 = input . VAR_2 ( ) ; VAR_3 = input . VAR_2 ( ) ; VAR_4 = TYPE_3 . METHOD_2 ( input , TYPE_4 [ ] : : new ) ; } |
I 0 - length arrays rare ( tests data segment ) | public void METHOD_1 ( TYPE_1 input ) throws IOException , TYPE_2 { VAR_1 = input . VAR_2 ( ) ; <START> VAR_3 = TYPE_3 . METHOD_2 ( input , TYPE_4 : : METHOD_3 ) ; <END> } | public void METHOD_1 ( TYPE_1 input ) throws IOException , TYPE_2 { VAR_1 = input . VAR_2 ( ) ; VAR_3 = TYPE_3 . METHOD_2 ( input , TYPE_4 [ ] : : new ) ; } |
void | <START> protected < TYPE_1 > TYPE_2 < TYPE_1 > METHOD_1 ( final TYPE_3 < ? , ? > cache , final TYPE_4 VAR_1 ) { <END> return TYPE_5 . METHOD_2 ( VAR_1 , TYPE_2 . class , cache , ( VAR_2 , m ) - > VAR_2 . when ( m ) . METHOD_3 ( METHOD_4 ( ) , METHOD_4 ( ) , METHOD_4 ( ) , METHOD_4 ( ) , METHOD_4 ( ) , METHOD_5 ( ) , ME... | protected < TYPE_1 > void METHOD_1 ( final TYPE_3 < ? , ? > cache , final TYPE_4 VAR_1 ) { TYPE_5 . METHOD_2 ( VAR_1 , TYPE_2 . class , cache , ( VAR_2 , m ) - > VAR_2 . when ( m ) . METHOD_3 ( METHOD_4 ( ) , METHOD_4 ( ) , METHOD_4 ( ) , METHOD_4 ( ) , METHOD_4 ( ) , METHOD_5 ( ) , METHOD_4 ( ) , METHOD_6 ( ) ) ) ; } |
void | <START> private static < TYPE_1 , TYPE_2 > TYPE_3 < TYPE_1 , TYPE_2 > METHOD_1 ( final TYPE_4 VAR_1 , <END> TYPE_5 < TYPE_1 , TYPE_2 > cache ) { return TYPE_6 . METHOD_2 ( VAR_1 , TYPE_3 . class , cache , ( VAR_2 , m ) - > VAR_2 . when ( m ) . METHOD_3 ( METHOD_4 ( TYPE_7 . VAR_4 ) , METHOD_4 ( false ) ) ) ; } | private static < TYPE_1 , TYPE_2 > void METHOD_1 ( final TYPE_4 VAR_1 , TYPE_5 < TYPE_1 , TYPE_2 > cache ) { TYPE_6 . METHOD_2 ( VAR_1 , TYPE_3 . class , cache , ( VAR_2 , m ) - > VAR_2 . when ( m ) . METHOD_3 ( METHOD_4 ( TYPE_7 . VAR_4 ) , METHOD_4 ( false ) ) ) ; } |
leftover debugging | public final Object METHOD_1 ( TYPE_1 ctx , TYPE_2 command ) throws Throwable { METHOD_2 ( ctx , command ) ; <START> if ( ctx . VAR_1 ( command . getKey ( ) ) != null && ctx . VAR_1 ( command . getKey ( ) ) . METHOD_3 ( ) instanceof TYPE_3 ) { <END> log . VAR_2 ( STRING_1 ) ; } return METHOD_4 ( ctx , command ) ; } | public final Object METHOD_1 ( TYPE_1 ctx , TYPE_2 command ) throws Throwable { METHOD_2 ( ctx , command ) ; return METHOD_4 ( ctx , command ) ; } |
assertTrue ( METHOD_2 ( VAR_1 [ 0 ] ) || METHOD_2 ( VAR_1 [ 1 ] ) ) ; | protected void METHOD_1 ( TYPE_1 [ ] VAR_1 ) { <START> if ( ! METHOD_2 ( VAR_1 [ 0 ] ) && ! METHOD_2 ( VAR_1 [ 1 ] ) ) <END> throw new TYPE_2 ( String . format ( STRING_1 , Arrays . toString ( VAR_1 ) ) ) ; } | protected void METHOD_1 ( TYPE_1 [ ] VAR_1 ) { assertTrue ( String . format ( STRING_1 , Arrays . toString ( VAR_1 ) ) , METHOD_2 ( VAR_1 [ 0 ] ) || METHOD_2 ( VAR_1 [ 1 ] ) ) ; } |
I purpose PR test unnecessary depends _CODE_ instead _CODE_ | public void METHOD_1 ( ) { <START> for ( TYPE_1 < Object , String > c : VAR_1 ) assert c . isEmpty ( ) ; <END> Object VAR_2 = METHOD_2 ( STRING_1 ) . put ( STRING_1 , STRING_2 ) ; METHOD_3 ( STRING_1 , TYPE_2 . class ) ; if ( VAR_3 ) assert VAR_2 == null ; VAR_2 = METHOD_4 ( STRING_1 ) [ 0 ] . remove ( STRING_1 ) ; MET... | public void METHOD_1 ( ) { Object VAR_2 = METHOD_2 ( STRING_1 ) . put ( STRING_1 , STRING_2 ) ; METHOD_3 ( STRING_1 , TYPE_2 . class ) ; if ( VAR_3 ) assert VAR_2 == null ; VAR_2 = METHOD_4 ( STRING_1 ) [ 0 ] . remove ( STRING_1 ) ; METHOD_3 ( STRING_1 , TYPE_3 . class ) ; if ( VAR_3 ) assert STRING_2 . equals ( VAR_2 ... |
d decorate cache constructor | public Integer METHOD_1 ( TYPE_1 ctx ) throws Throwable { <START> long size = cache . VAR_1 ( ) . METHOD_2 ( TYPE_2 . class ) . keySet ( ) . stream ( ) . count ( ) ; <END> if ( size > Integer . VAR_2 ) { return Integer . VAR_2 ; } else { return ( int ) size ; } } | public Integer METHOD_1 ( TYPE_1 ctx ) throws Throwable { long size = cache . keySet ( ) . stream ( ) . count ( ) ; if ( size > Integer . VAR_2 ) { return Integer . VAR_2 ; } else { return ( int ) size ; } } |
FYI logic part avoid creating new instances requested encoding place | public TYPE_7 ( TYPE_1 < Object , ? > cache , long VAR_2 ) { METHOD_1 ( VAR_2 ) ; TYPE_2 < Object , ? > VAR_3 = cache . VAR_4 ( ) ; if ( VAR_2 != TYPE_3 . VAR_5 ) { VAR_3 = VAR_3 . METHOD_2 ( TYPE_3 . METHOD_3 ( VAR_2 , TYPE_4 . class ) ) ; } this . cache = VAR_3 . METHOD_4 ( ) . METHOD_5 ( ) . METHOD_6 ( ) == TYPE_6 .... | public TYPE_7 ( TYPE_1 < Object , ? > cache , long VAR_2 ) { METHOD_1 ( VAR_2 ) ; TYPE_2 < Object , ? > VAR_3 = cache . VAR_4 ( ) ; if ( VAR_2 != TYPE_3 . VAR_5 ) { VAR_3 = VAR_3 . METHOD_2 ( TYPE_3 . METHOD_3 ( VAR_2 , TYPE_4 . class ) ) ; } this . cache = VAR_3 . METHOD_7 ( TYPE_5 . class ) ; } |
need public ? I package private | public void METHOD_1 ( TYPE_1 VAR_1 ) { TYPE_2 < ? , ? > VAR_2 = VAR_1 . VAR_2 ; <START> TYPE_3 VAR_3 = new TYPE_3 ( <END> VAR_4 , VAR_2 . getName ( ) , VAR_1 . VAR_5 , VAR_6 , VAR_7 , VAR_8 , configuration ) ; VAR_2 . METHOD_2 ( VAR_9 , VAR_8 , VAR_3 , configuration . VAR_10 ( ) , configuration . VAR_11 ( ) , configur... | private void METHOD_1 ( TYPE_1 VAR_1 ) { TYPE_2 < ? , ? > VAR_2 = VAR_1 . VAR_2 ; TYPE_3 VAR_3 = new TYPE_3 ( VAR_4 , VAR_2 . getName ( ) , VAR_1 . VAR_5 , VAR_6 , VAR_7 , VAR_8 , configuration ) ; VAR_2 . METHOD_2 ( VAR_9 , VAR_8 , VAR_3 , configuration . VAR_10 ( ) , configuration . VAR_11 ( ) , configuration . VAR_1... |
wiring | public void METHOD_1 ( TYPE_1 VAR_1 ) { if ( VAR_2 != null ) { VAR_1 . METHOD_2 ( this ) ; } <START> if ( VAR_2 != null ) { <END> VAR_1 . METHOD_2 ( this ) ; } } | public void METHOD_1 ( TYPE_1 VAR_1 ) { if ( VAR_2 != null ) { VAR_1 . METHOD_2 ( this ) ; } } |
point async store necessary * function * serializable resulting entry check belong holds compute commands | public Object METHOD_1 ( TYPE_1 ctx , TYPE_2 command ) throws Throwable { if ( METHOD_2 ( ctx , command ) ) { METHOD_3 ( command . getKey ( ) ) ; <START> METHOD_3 ( command . VAR_1 ( ) ) ; <END> } return METHOD_4 ( ctx , command ) ; } | public Object METHOD_1 ( TYPE_1 ctx , TYPE_2 command ) throws Throwable { if ( METHOD_2 ( ctx , command ) ) { METHOD_3 ( command . getKey ( ) ) ; } return METHOD_4 ( ctx , command ) ; } |
works line : ) | private Throwable METHOD_1 ( Throwable VAR_1 ) { <START> if ( VAR_1 . METHOD_2 ( ) == null ) return VAR_1 ; <END> Throwable VAR_2 = VAR_1 . METHOD_2 ( ) ; if ( VAR_2 instanceof RuntimeException ) return METHOD_1 ( VAR_2 ) ; else return VAR_1 ; } | private Throwable METHOD_1 ( Throwable VAR_1 ) { Throwable VAR_2 = VAR_1 . METHOD_2 ( ) ; if ( VAR_2 instanceof RuntimeException ) return METHOD_1 ( VAR_2 ) ; else return VAR_1 ; } |
don t need cast | private Collection < TYPE_1 > METHOD_1 ( TYPE_2 ctx ) { TYPE_3 VAR_1 = ( TYPE_3 ) ctx . VAR_2 ( ) ; TYPE_4 VAR_3 = VAR_4 . METHOD_2 ( ) ; Collection < TYPE_1 > VAR_5 = <START> VAR_6 ? null : VAR_3 . METHOD_3 ( ( Collection < Object > ) ctx . VAR_7 ( ) ) ; <END> return VAR_1 . METHOD_1 ( VAR_5 , VAR_3 ) ; } | private Collection < TYPE_1 > METHOD_1 ( TYPE_2 ctx ) { TYPE_3 VAR_1 = ( TYPE_3 ) ctx . VAR_2 ( ) ; TYPE_4 VAR_3 = VAR_4 . METHOD_2 ( ) ; Collection < TYPE_1 > VAR_5 = VAR_6 ? null : VAR_3 . METHOD_3 ( ctx . VAR_7 ( ) ) ; return VAR_1 . METHOD_1 ( VAR_5 , VAR_3 ) ; } |
need | public < TYPE_1 > void METHOD_1 ( Object listener , TYPE_2 < ? super TYPE_3 , ? super TYPE_4 > filter , <START> TYPE_5 < ? super TYPE_3 , ? super TYPE_4 , TYPE_1 > VAR_1 , TYPE_6 VAR_2 ) { <END> METHOD_2 ( listener , null , null , filter , VAR_1 , VAR_2 ) ; } | public < TYPE_1 > void METHOD_1 ( Object listener , TYPE_2 < ? super TYPE_3 , ? super TYPE_4 > filter , TYPE_5 < ? super TYPE_3 , ? super TYPE_4 , TYPE_1 > VAR_1 , TYPE_6 VAR_2 ) { METHOD_2 ( listener , null , null , null , null , filter , VAR_1 , VAR_2 ) ; } |
hmm call ctor null VAR_4 ( besides reflection ) ? don t new TYPE_4 [ 0 ] set null param null flag | public TYPE_7 ( TYPE_1 < TYPE_2 , TYPE_3 > VAR_2 , Object VAR_3 , TYPE_4 ... VAR_4 ) { super ( VAR_2 ) ; if ( VAR_4 == null ) <START> throw new IllegalArgumentException ( STRING_1 ) ; <END> if ( VAR_4 . length == 0 ) this . VAR_4 = TYPE_5 . VAR_5 ; else { this . VAR_4 = TYPE_5 . METHOD_1 ( VAR_4 ) ; } this . VAR_3 = VA... | public TYPE_7 ( TYPE_1 < TYPE_2 , TYPE_3 > VAR_2 , Object VAR_3 , TYPE_4 ... VAR_4 ) { super ( VAR_2 ) ; if ( VAR_4 . length == 0 ) this . VAR_4 = TYPE_5 . VAR_5 ; else { this . VAR_4 = TYPE_5 . METHOD_1 ( VAR_4 ) ; } this . VAR_3 = VAR_3 ; VAR_6 = ( TYPE_6 < TYPE_2 , TYPE_3 > ) VAR_2 ; } |
offtopic : doesn t related PR compete radim longest PR ? : ) | public TYPE_1 < Object > METHOD_1 ( TYPE_2 ctx , TYPE_3 command ) { <START> TYPE_4 . METHOD_2 ( command , trace ) ; <END> try { Object result = VAR_1 . METHOD_3 ( ctx , command ) ; if ( result instanceof TYPE_5 ) { return ( ( TYPE_5 ) result ) . METHOD_4 ( ) ; } else { return TYPE_1 . METHOD_5 ( result ) ; } } catch ( ... | public TYPE_1 < Object > METHOD_1 ( TYPE_2 ctx , TYPE_3 command ) { try { Object result = VAR_1 . METHOD_3 ( ctx , command ) ; if ( result instanceof TYPE_5 ) { return ( ( TYPE_5 ) result ) . METHOD_4 ( ) ; } else { return TYPE_1 . METHOD_5 ( result ) ; } } catch ( Throwable t ) { return TYPE_6 . METHOD_6 ( t ) ; } } |
cast needed | public int METHOD_1 ( ) { if ( channel == null ) throw new TYPE_1 ( STRING_1 ) ; <START> return ( int ) VAR_1 . METHOD_1 ( ) ; <END> } | public int METHOD_1 ( ) { if ( channel == null ) throw new TYPE_1 ( STRING_1 ) ; return VAR_1 . METHOD_1 ( ) ; } |
IMO trace message METHOD_4 ( ) | public void METHOD_1 ( Object VAR_1 , Throwable VAR_2 ) { <START> if ( trace ) <END> log . VAR_3 ( STRING_1 , command , METHOD_2 ( ) ) ; TYPE_1 . METHOD_3 ( command , trace ) ; try { METHOD_4 ( VAR_1 , VAR_2 ) ; } finally { TYPE_1 . METHOD_5 ( command , trace ) ; } } | public void METHOD_1 ( Object VAR_1 , Throwable VAR_2 ) { METHOD_4 ( VAR_1 , VAR_2 ) ; } |
implementing correct pattern dealing VAR_1 commit / rollback [ code ] ( ) shows correct pattern | private TYPE_1 METHOD_1 ( ) { try { TYPE_1 VAR_1 = null ; if ( VAR_2 != null ) { VAR_1 = VAR_2 . METHOD_2 ( ) ; if ( VAR_1 == null && VAR_3 != null ) { VAR_1 = VAR_3 . METHOD_3 ( ) ; } } return VAR_1 ; } catch ( TYPE_2 e ) { throw new TYPE_3 ( STRING_1 , e ) ; } <START> } <END> | private TYPE_1 METHOD_1 ( ) { try { TYPE_1 VAR_1 = VAR_2 . METHOD_2 ( ) ; if ( VAR_1 == null && VAR_3 != null ) { VAR_1 = VAR_3 . METHOD_3 ( ) ; } return VAR_1 ; } catch ( TYPE_2 e ) { throw new TYPE_3 ( STRING_1 , e ) ; } } |
assign VAR_5 VAR_6 constructor null instead variable null | public < T > TYPE_1 < T > METHOD_1 ( String VAR_1 , Map < String , byte [ ] > VAR_2 ) { return new TYPE_1 < > ( VAR_3 , VAR_4 , VAR_5 == null ? VAR_6 : VAR_5 , <START> VAR_7 , METHOD_2 ( ) , VAR_8 , VAR_1 , VAR_2 ) ; <END> } | public < T > TYPE_1 < T > METHOD_1 ( String VAR_1 , Map < String , byte [ ] > VAR_2 ) { return new TYPE_1 < > ( VAR_3 , VAR_4 , VAR_5 , VAR_7 , METHOD_2 ( ) , VAR_8 , VAR_1 , VAR_2 ) ; } |
trace message sticks a bit thinking remove add logs rest some point | public Object METHOD_1 ( TYPE_1 ctx , TYPE_2 command ) throws Throwable { <START> log . VAR_1 ( STRING_1 , command ) ; <END> if ( command . VAR_2 ( ) ) { return VAR_3 . METHOD_2 ( command . getKey ( ) , command . VAR_4 ( ) , command . VAR_5 ( ) ) ; } return VAR_3 . METHOD_3 ( command . getKey ( ) , command . VAR_4 ( ) ... | public Object METHOD_1 ( TYPE_1 ctx , TYPE_2 command ) throws Throwable { if ( command . VAR_2 ( ) ) { return VAR_3 . METHOD_2 ( command . getKey ( ) , command . VAR_4 ( ) , command . VAR_5 ( ) ) ; } return VAR_3 . METHOD_3 ( command . getKey ( ) , command . VAR_4 ( ) , command . VAR_5 ( ) ) ; } |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.