ReviewComments stringlengths 1 2.35k | OriginalCode stringlengths 28 487 | ReviewedCode stringlengths 14 463 |
|---|---|---|
shouldn t happen shut VAR_2 bound | public void METHOD_1 ( ) { if ( METHOD_2 ( ) ) { VAR_1 . METHOD_3 ( ) ; VAR_2 . METHOD_4 ( ) ; <START> VAR_3 . METHOD_1 ( ) ; <END> } VAR_4 = false ; } | public void METHOD_1 ( ) { if ( METHOD_2 ( ) ) { VAR_3 . METHOD_1 ( ) ; VAR_1 . METHOD_3 ( ) ; VAR_2 . METHOD_4 ( ) ; } VAR_4 = false ; } |
remove instead doesn t need called 2 lines | public void METHOD_1 ( byte [ ] VAR_1 ) { <START> TYPE_1 VAR_2 = VAR_3 . get ( VAR_1 ) ; <END> VAR_2 . VAR_4 . METHOD_2 ( ) ; VAR_3 . remove ( VAR_1 ) ; if ( log . VAR_5 ( ) ) log . VAR_6 ( STRING_1 , TYPE_2 . METHOD_3 ( VAR_1 ) ) ; } | public void METHOD_1 ( byte [ ] VAR_1 ) { TYPE_1 VAR_2 = VAR_3 . remove ( VAR_1 ) ; VAR_2 . VAR_4 . METHOD_2 ( ) ; if ( log . VAR_5 ( ) ) log . VAR_6 ( STRING_1 , TYPE_2 . METHOD_3 ( VAR_1 ) ) ; } |
I familiar serialization process hotrod couldn t pass string ? error case null | private void METHOD_1 ( TYPE_1 VAR_1 , String VAR_2 , byte [ ] [ ] params ) { if ( VAR_2 . isEmpty ( ) ) { <START> VAR_1 . METHOD_2 ( ( short ) 0 ) ; <END> } else { VAR_1 . METHOD_3 ( VAR_2 ) ; if ( params != null ) { VAR_1 . METHOD_2 ( ( short ) params . length ) ; for ( byte [ ] VAR_3 : params ) VAR_1 . METHOD_4 ( VA... | private void METHOD_1 ( TYPE_1 VAR_1 , String VAR_2 , byte [ ] [ ] params ) { VAR_1 . METHOD_3 ( VAR_2 ) ; if ( ! VAR_2 . isEmpty ( ) ) { if ( params != null ) { VAR_1 . METHOD_2 ( ( short ) params . length ) ; for ( byte [ ] VAR_3 : params ) VAR_1 . METHOD_4 ( VAR_3 ) ; } else { VAR_1 . METHOD_2 ( ( short ) 0 ) ; } } ... |
I I nice constraints based command type : ) | <START> public TYPE_2 ( Class < ? extends TYPE_1 > VAR_2 ) { <END> this ( VAR_2 , null , null , null , VAR_3 ) ; } | public TYPE_2 ( Class < ? extends TYPE_1 > VAR_2 ) { this ( VAR_2 , null , null , null ) ; } |
a small nitpick equals ( 1 based conditional ) thinking give spread VAR_1 multiplied INT_1 VAR_2 multiplied | public int METHOD_1 ( ) { <START> int result = VAR_1 != null ? VAR_1 . METHOD_1 ( ) : 0 ; <END> result = INT_1 * result + ( VAR_2 != null ? VAR_2 . METHOD_1 ( ) : 0 ) ; return result ; } | public int METHOD_1 ( ) { return VAR_1 != null ? VAR_1 . METHOD_1 ( ) : VAR_2 . METHOD_1 ( ) ; } |
redundant parenthesis isn t calling Arrays toString | public String toString ( ) { <START> return STRING_1 + STRING_2 + ( Arrays . asList ( VAR_1 ) ) + CHAR_1 ; <END> } | public String toString ( ) { return STRING_1 + STRING_2 + Arrays . toString ( VAR_1 ) + CHAR_1 ; } |
String valueOf ( ) avoid checking null code : P | public static void METHOD_1 ( TYPE_1 VAR_1 , int VAR_2 , TYPE_2 VAR_3 ) { if ( ( VAR_2 & VAR_3 . METHOD_2 ( ) ) != VAR_3 . METHOD_2 ( ) ) { if ( System . VAR_4 ( ) == null ) { <START> throw log . VAR_5 ( VAR_1 == null ? STRING_1 : VAR_1 . toString ( ) , VAR_3 . toString ( ) ) ; <END> } else { System . VAR_4 ( ) . METHO... | public static void METHOD_1 ( TYPE_1 VAR_1 , int VAR_2 , TYPE_2 VAR_3 ) { if ( ( VAR_2 & VAR_3 . METHOD_2 ( ) ) != VAR_3 . METHOD_2 ( ) ) { if ( System . VAR_4 ( ) == null ) { throw log . VAR_5 ( String . valueOf ( VAR_1 ) , VAR_3 . toString ( ) ) ; } else { System . VAR_4 ( ) . METHOD_1 ( VAR_3 . METHOD_3 ( ) ) ; } } ... |
I bundles referenced d check OSGI expert a singleton instance class references bundle instances problematic | public static TYPE_1 [ ] METHOD_1 ( TYPE_1 VAR_1 ) { return new TYPE_1 [ ] { VAR_1 , <START> new TYPE_2 ( ) , <END> TYPE_3 . class . METHOD_2 ( ) , TYPE_1 . METHOD_3 ( ) } ; } | public static TYPE_1 [ ] METHOD_1 ( TYPE_1 VAR_1 ) { return new TYPE_1 [ ] { VAR_1 , TYPE_2 . getInstance ( ) , TYPE_3 . class . METHOD_2 ( ) , TYPE_1 . METHOD_3 ( ) } ; } |
I don t cache defined created default configuration | public void execute ( String VAR_1 ) throws TYPE_1 { if ( VAR_1 == null || VAR_1 . isEmpty ( ) ) { throw new IllegalArgumentException ( STRING_1 + VAR_1 ) ; } TYPE_2 < Object , Object > VAR_2 = cache . VAR_3 ( ) . METHOD_1 ( VAR_1 ) ; <START> if ( VAR_2 == null ) { <END> throw new IllegalArgumentException ( STRING_2 + ... | public void execute ( String VAR_1 ) throws TYPE_1 { if ( VAR_1 == null || VAR_1 . isEmpty ( ) ) { throw new IllegalArgumentException ( STRING_1 + VAR_1 ) ; } METHOD_2 ( VAR_1 ) ; } |
missing < TYPE_2 TYPE_3 > | public TYPE_1 < TYPE_2 , TYPE_3 > remove ( Object VAR_1 ) { <START> TYPE_1 e = VAR_2 . remove ( VAR_1 ) ; <END> return e == null || ( e . VAR_3 ( ) && e . VAR_4 ( VAR_5 . METHOD_1 ( ) ) ) ? null : e ; } | public TYPE_1 < TYPE_2 , TYPE_3 > remove ( Object VAR_1 ) { TYPE_1 < TYPE_2 , TYPE_3 > e = VAR_2 . remove ( VAR_1 ) ; return e == null || ( e . VAR_3 ( ) && e . VAR_4 ( VAR_5 . METHOD_1 ( ) ) ) ? null : e ; } |
I originally set 2 intermediate values split test happen INT_1 | protected void METHOD_1 ( ) throws Throwable { TYPE_1 builder = METHOD_2 ( METHOD_3 ( ) , true ) ; <START> builder . VAR_1 ( ) . METHOD_4 ( ) . METHOD_5 ( INT_1 ) ; <END> METHOD_6 ( 4 , METHOD_7 ( ) , builder ) ; } | protected void METHOD_1 ( ) throws Throwable { TYPE_1 builder = METHOD_2 ( METHOD_3 ( ) , true ) ; builder . VAR_1 ( ) . METHOD_4 ( ) . METHOD_5 ( 2 ) ; METHOD_6 ( 4 , METHOD_7 ( ) , builder ) ; } |
INT_1 128 | protected void METHOD_1 ( ) throws Throwable { TYPE_1 builder = METHOD_2 ( METHOD_3 ( ) , true ) ; <START> builder . VAR_1 ( ) . METHOD_4 ( ) . METHOD_5 ( INT_1 ) ; <END> METHOD_6 ( 2 , METHOD_7 ( ) , builder ) ; } | protected void METHOD_1 ( ) throws Throwable { TYPE_1 builder = METHOD_2 ( METHOD_3 ( ) , true ) ; builder . VAR_1 ( ) . METHOD_4 ( ) . METHOD_5 ( 2 ) ; METHOD_6 ( 2 , METHOD_7 ( ) , builder ) ; } |
return String valueOf ( properties ( key ) ) ? protect null | public String getProperty ( String key ) { <START> return this . properties . get ( key ) . toString ( ) ; <END> } | public String getProperty ( String key ) { return String . valueOf ( this . properties . get ( key ) ) ; } |
VAR_9 null | private Thread METHOD_1 ( final TYPE_1 target ) { final TYPE_2 VAR_1 = new TYPE_2 ( VAR_2 . METHOD_2 ( ) , VAR_3 . METHOD_2 ( ) , VAR_4 , node , VAR_5 ) ; Thread VAR_6 = new Thread ( VAR_7 , target ) ; VAR_6 . METHOD_3 ( VAR_1 . format ( VAR_6 , VAR_8 ) ) ; <START> if ( VAR_9 != null ) VAR_6 . METHOD_4 ( VAR_9 ) ; <END... | private Thread METHOD_1 ( final TYPE_1 target ) { final TYPE_2 VAR_1 = new TYPE_2 ( VAR_2 . METHOD_2 ( ) , VAR_3 . METHOD_2 ( ) , VAR_4 , node , VAR_5 ) ; Thread VAR_6 = new Thread ( VAR_7 , target ) ; VAR_6 . METHOD_3 ( VAR_1 . format ( VAR_6 , VAR_8 ) ) ; VAR_6 . METHOD_4 ( VAR_9 ) ; VAR_6 . METHOD_5 ( true ) ; retur... |
smaller : return = = ? VAR_8 : VAR_7 | public org . VAR_1 . VAR_2 . TYPE_1 METHOD_1 ( ) { <START> switch ( this ) { <END> case VAR_4 : case VAR_5 : case VAR_6 : return org . VAR_1 . VAR_2 . TYPE_1 . VAR_7 ; default : return org . VAR_1 . VAR_2 . TYPE_1 . VAR_8 ; } } | public org . VAR_1 . VAR_2 . TYPE_1 METHOD_1 ( ) { return this == NONE ? org . VAR_1 . VAR_2 . TYPE_1 . VAR_8 : org . VAR_1 . VAR_2 . TYPE_1 . VAR_7 ; } |
bad IMO offset > > > VAR_1 offset VAR_2 overflow int ( return a negative int instead a positive ) Long valueOf ( offset ) METHOD_1 ( VAR_1 offset ) another suggestion swap order check offset size offset size | public int METHOD_1 ( TYPE_1 VAR_1 ) { int VAR_2 = size - VAR_1 . size ; <START> return ( VAR_2 != 0 ) ? VAR_2 : ( int ) ( offset - VAR_1 . offset ) ; <END> } | public int METHOD_1 ( TYPE_1 VAR_1 ) { int VAR_2 = size - VAR_1 . size ; if ( VAR_2 != 0 ) return VAR_2 ; return ( offset < VAR_1 . offset ) ? - 1 : ( ( offset == VAR_1 . offset ) ? 0 : 1 ) ; } |
check VAR_1 ! = null | public void METHOD_1 ( ) { <START> VAR_1 . METHOD_2 ( ) . clear ( ) ; <END> TYPE_1 . METHOD_3 ( VAR_2 ) ; } | public void METHOD_1 ( ) { if ( VAR_1 != null ) { VAR_1 . METHOD_2 ( ) . clear ( ) ; } TYPE_1 . METHOD_3 ( VAR_2 ) ; } |
I don t problem prohibiting x - site backup / a VAR_5 cache I m familiar x - site configuration I don t s validation | public TYPE_4 ( TYPE_1 cache ) { this . cache = cache ; <START> this . VAR_2 = cache . VAR_3 ( ) . METHOD_1 ( ) . METHOD_2 ( ) == TYPE_3 . VAR_5 ; <END> VAR_6 = new TYPE_2 ( cache , VAR_7 ) ; } | public TYPE_4 ( TYPE_1 cache ) { this . cache = cache ; VAR_6 = new TYPE_2 ( cache , VAR_7 ) ; } |
I - optimizing a bit _CODE_ * * * * rare a simple return new Object [ ] { VAR_1 VAR_5 } fine | public Object [ ] getParameters ( ) { switch ( VAR_1 ) { case VAR_2 : case VAR_3 : case VAR_4 : return new Object [ ] { VAR_1 . METHOD_1 ( ) , VAR_5 } ; } <START> return new Object [ ] { VAR_1 . METHOD_1 ( ) } ; <END> } | public Object [ ] getParameters ( ) { return new Object [ ] { VAR_1 , VAR_5 } ; } |
guard null | private byte [ ] METHOD_1 ( String c ) throws IOException { TYPE_1 is = getClass ( ) . METHOD_2 ( c ) ; try { return TYPE_2 . METHOD_3 ( is ) ; } finally { <START> is . close ( ) ; <END> } } | private byte [ ] METHOD_1 ( String c ) throws IOException { TYPE_1 is = getClass ( ) . METHOD_2 ( c ) ; try { return TYPE_2 . METHOD_3 ( is ) ; } finally { if ( is != null ) { is . close ( ) ; } } } |
lines don t configure mock needed TYPE_6 a proper component | private TYPE_1 METHOD_1 ( TYPE_2 cache ) { TYPE_1 VAR_1 = new TYPE_1 ( METHOD_2 ( cache , TYPE_3 . class ) ) ; TYPE_4 t = ( TYPE_4 ) METHOD_2 ( cache , TYPE_5 . class ) ; TYPE_6 VAR_2 = t . VAR_3 ( ) ; METHOD_3 ( VAR_1 , STRING_1 , VAR_2 , TYPE_6 . class ) ; <START> METHOD_4 ( cache . VAR_4 ( ) , TYPE_3 . class , VAR_1... | private TYPE_1 METHOD_1 ( TYPE_2 cache ) { TYPE_1 VAR_1 = new TYPE_1 ( METHOD_2 ( cache , TYPE_3 . class ) ) ; METHOD_4 ( cache . VAR_4 ( ) , TYPE_3 . class , VAR_1 , true ) ; TYPE_4 t = ( TYPE_4 ) METHOD_2 ( cache , TYPE_5 . class ) ; TYPE_6 VAR_2 = t . VAR_3 ( ) ; METHOD_3 ( VAR_1 , STRING_1 , VAR_2 , TYPE_6 . class ... |
Set addAll method instead | public Builder < ? > read ( TYPE_1 VAR_1 ) { VAR_2 . clear ( ) ; <START> for ( TYPE_2 VAR_3 : VAR_1 . METHOD_1 ( ) ) { <END> VAR_2 . add ( VAR_3 ) ; } return this ; } | public Builder < ? > read ( TYPE_1 VAR_1 ) { VAR_2 . clear ( ) ; VAR_2 . addAll ( VAR_1 . METHOD_1 ( ) ) ; return this ; } |
interleaving events t happen entries put ( ) implicitly synchronizes entries _CODE_ I I problem : allocate ( ) moved processing entry loop METHOD_1 variable initialized entry METHOD_1 list locked METHOD_1 entry bigger | private void METHOD_1 ( TYPE_1 VAR_1 ) throws IOException { if ( VAR_1 != null ) { <START> VAR_1 . METHOD_2 ( ) ; <END> channel . write ( ByteBuffer . VAR_2 ( VAR_3 ) , VAR_1 . offset + VAR_4 ) ; if ( ! VAR_5 . add ( VAR_1 ) ) { throw new IllegalStateException ( String . format ( STRING_1 , VAR_1 ) ) ; } if ( trace ) l... | private void METHOD_1 ( TYPE_1 VAR_1 ) throws IOException { if ( VAR_1 != null ) { channel . write ( ByteBuffer . VAR_2 ( VAR_3 ) , VAR_1 . offset + VAR_4 ) ; if ( ! VAR_5 . add ( VAR_1 ) ) { throw new IllegalStateException ( String . format ( STRING_1 , VAR_1 ) ) ; } if ( trace ) log . VAR_6 ( STRING_2 , VAR_1 . offse... |
System caller btw isnt s logging preferred System tests | private TYPE_1 < String , TYPE_2 > METHOD_1 ( int VAR_1 ) { TYPE_1 < String , TYPE_2 > cache = cache ( VAR_1 ) ; TYPE_3 < String , TYPE_2 > VAR_2 = cache . VAR_3 ( ) ; TYPE_3 < String , TYPE_2 > VAR_4 = VAR_2 . METHOD_2 ( TYPE_4 . VAR_6 , TYPE_4 . VAR_7 ) ; <START> System . out . METHOD_3 ( STRING_1 + VAR_1 + STRING_2 ... | private TYPE_1 < String , TYPE_2 > METHOD_1 ( int VAR_1 ) { TYPE_1 < String , TYPE_2 > cache = cache ( VAR_1 ) ; TYPE_3 < String , TYPE_2 > VAR_2 = cache . VAR_3 ( ) ; TYPE_3 < String , TYPE_2 > VAR_4 = VAR_2 . METHOD_2 ( TYPE_4 . VAR_6 , TYPE_4 . VAR_7 ) ; return VAR_4 ; } |
returned ? put cluster registry IGNORE_RETURN_VALUES | <START> TYPE_1 put ( final TYPE_2 key , final TYPE_1 value ) { <END> final TYPE_1 VAR_1 = VAR_2 . put ( VAR_3 , key , value ) ; METHOD_1 ( key , value ) ; return VAR_1 ; } | void put ( final TYPE_2 key , final TYPE_1 value ) { VAR_2 . put ( VAR_3 , key , value ) ; METHOD_1 ( key , value ) ; } |
don t need variable inline | public TYPE_1 METHOD_1 ( ) { <START> TYPE_1 ctx = new TYPE_2 ( true , VAR_1 ) ; <END> return ctx ; } | public TYPE_1 METHOD_1 ( ) { return new TYPE_2 ( true , VAR_1 ) ; } |
a reason class lazy initialization instead a _CODE_ / _CODE_ other classes | private TYPE_1 METHOD_1 ( ) { <START> if ( VAR_1 == null ) { <END> VAR_1 = new TYPE_1 ( ) ; } return VAR_1 ; } | private TYPE_1 METHOD_1 ( ) { return VAR_1 ; } |
I don t wanna noisy full class methods class | <START> public org . VAR_1 . configuration . cache . TYPE_1 METHOD_1 ( ) { <END> return new TYPE_2 ( ) . METHOD_2 ( ) . METHOD_3 ( TYPE_3 . VAR_3 ) . METHOD_4 ( 4 ) . build ( ) ; } | public TYPE_1 METHOD_1 ( ) { return new TYPE_2 ( ) . METHOD_2 ( ) . METHOD_3 ( TYPE_3 . VAR_3 ) . METHOD_4 ( 4 ) . build ( ) ; } |
public ? else I d leave private | <START> public static TYPE_1 METHOD_1 ( TYPE_1 metadata ) { <END> TYPE_1 VAR_1 = metadata ; while ( VAR_1 != null ) { if ( VAR_1 instanceof TYPE_2 ) { VAR_1 = ( ( TYPE_2 ) VAR_1 ) . METHOD_2 ( ) ; } else { break ; } } return VAR_1 ; } | private static TYPE_1 METHOD_1 ( TYPE_1 metadata ) { TYPE_1 VAR_1 = metadata ; while ( VAR_1 != null ) { if ( VAR_1 instanceof TYPE_2 ) { VAR_1 = ( ( TYPE_2 ) VAR_1 ) . METHOD_2 ( ) ; } else { break ; } } return VAR_1 ; } |
I enough check _CODE_ empty originator owner invalidation done requestors a key happen owners sounds a bit expensive couldn t _CODE_ approach - tx caches invalidate primary owner instead | private boolean METHOD_1 ( TYPE_1 ctx ) { return METHOD_2 ( ctx ) || <START> ! ctx . VAR_1 ( ) && ! ctx . VAR_2 ( ) . isEmpty ( ) ; <END> } | private boolean METHOD_1 ( TYPE_1 ctx ) { return ! ctx . VAR_2 ( ) . isEmpty ( ) ; } |
I sense METHOD_3 ( ) VAR_3 METHOD_3 ( ) invoked state changes tasks unblocked ( case receive ( increase ) topology id ) total order commands change state | private void METHOD_1 ( TYPE_1 command , Response VAR_1 ) { if ( command instanceof TYPE_2 || command instanceof TYPE_3 || command instanceof TYPE_4 || ( command instanceof TYPE_5 && ( ( ( TYPE_6 ) command ) . METHOD_2 ( ) || VAR_1 instanceof TYPE_7 ) ) ) { VAR_2 . METHOD_3 ( ) ; <START> VAR_3 . METHOD_3 ( ) ; <END> } ... | private void METHOD_1 ( TYPE_1 command , Response VAR_1 ) { if ( command instanceof TYPE_2 || command instanceof TYPE_3 || command instanceof TYPE_4 || ( command instanceof TYPE_5 && ( ( ( TYPE_6 ) command ) . METHOD_2 ( ) || VAR_1 instanceof TYPE_7 ) ) ) { VAR_2 . METHOD_3 ( ) ; } } |
s normal methods package protected instead public ? METHOD_1 _CODE_ ( others ) | <START> Class METHOD_1 ( ) { <END> return VAR_1 ; } | protected Class METHOD_1 ( ) { return VAR_1 ; } |
I guard METHOD_6 invocation ( _CODE_ ( ) ) | public Object METHOD_1 ( TYPE_1 ctx , TYPE_2 command , boolean VAR_1 ) throws Throwable { Object VAR_2 = METHOD_2 ( ctx , command ) ; Object key ; if ( METHOD_3 ( command ) && command . VAR_3 ( ) && VAR_4 . METHOD_4 ( ( key = command . getKey ( ) ) ) ) { <START> METHOD_5 ( ) . METHOD_6 ( STRING_1 ) ; <END> VAR_5 . METH... | public Object METHOD_1 ( TYPE_1 ctx , TYPE_2 command , boolean VAR_1 ) throws Throwable { Object VAR_2 = METHOD_2 ( ctx , command ) ; Object key ; if ( METHOD_3 ( command ) && command . VAR_3 ( ) && VAR_4 . METHOD_4 ( ( key = command . getKey ( ) ) ) ) { if ( trace ) { log . trace ( STRING_1 ) ; } VAR_5 . METHOD_7 ( Co... |
cast result a bit faster : - ) TYPE_1 VAR_1 = ( TYPE_1 ) o ; | public int METHOD_1 ( Object o ) { <START> if ( ! ( o instanceof TYPE_1 ) ) <END> throw new TYPE_2 ( ) ; if ( this == o ) return 0 ; TYPE_1 VAR_1 = ( TYPE_1 ) o ; int VAR_2 = size - VAR_1 . size ; return ( VAR_2 != 0 ) ? VAR_2 : offset > VAR_1 . offset ? 1 : - 1 ; } | public int METHOD_1 ( Object o ) { TYPE_1 VAR_1 = ( TYPE_1 ) o ; if ( this == VAR_1 ) return 0 ; int VAR_2 = size - VAR_1 . size ; return ( VAR_2 != 0 ) ? VAR_2 : offset > VAR_1 . offset ? 1 : - 1 ; } |
needed | public void METHOD_1 ( ) throws TYPE_1 { <START> METHOD_2 ( ) ; <END> final TYPE_2 VAR_1 = new TYPE_2 ( STRING_1 , VAR_2 , VAR_3 ) ; final String VAR_4 = STRING_2 ; final String VAR_5 = STRING_3 ; TYPE_3 VAR_6 = TYPE_4 . METHOD_3 ( VAR_7 , TYPE_5 . class ) . METHOD_4 ( ) ; VAR_6 . METHOD_5 ( TYPE_6 . create ( VAR_1 , V... | public void METHOD_1 ( ) throws TYPE_1 { final TYPE_2 VAR_1 = new TYPE_2 ( STRING_1 , VAR_2 , VAR_3 ) ; final String VAR_4 = STRING_2 ; final String VAR_5 = STRING_3 ; TYPE_3 VAR_6 = TYPE_4 . METHOD_3 ( VAR_7 , TYPE_5 . class ) . METHOD_4 ( ) ; VAR_6 . METHOD_5 ( TYPE_6 . create ( VAR_1 , VAR_5 ) ) ; VAR_2 . put ( VAR_... |
nicer a method TYPE_1 _CODE_ ( ) : : TYPE_1 care drop - - nice instanceof | public TYPE_1 METHOD_1 ( TYPE_1 VAR_1 ) { <START> if ( VAR_1 == TYPE_3 . VAR_3 ) { <END> return METHOD_2 ( ) ; } else if ( VAR_1 instanceof TYPE_2 ) { TYPE_2 VAR_4 = ( TYPE_2 ) VAR_1 ; long VAR_5 = VAR_4 . METHOD_3 ( ) + 1 ; return METHOD_4 ( VAR_5 ) ; } throw log . VAR_6 ( VAR_1 . getClass ( ) . getName ( ) ) ; } | public TYPE_1 METHOD_1 ( TYPE_1 VAR_1 ) { if ( VAR_1 instanceof TYPE_2 ) { TYPE_2 VAR_4 = ( TYPE_2 ) VAR_1 ; long VAR_5 = VAR_4 . METHOD_3 ( ) + 1 ; return METHOD_4 ( VAR_5 ) ; } throw log . VAR_6 ( VAR_1 . getClass ( ) . getName ( ) ) ; } |
I true instead false | public Object METHOD_1 ( TYPE_1 ctx , TYPE_2 command ) throws Throwable { if ( this . VAR_1 ) VAR_2 . METHOD_2 ( ) ; Object result = METHOD_3 ( ctx , command ) ; if ( ! ctx . VAR_3 ( ) ) { if ( command . VAR_4 ( ) ) { <START> VAR_5 . METHOD_4 ( command . VAR_6 ( ) , false ) ; <END> } else { VAR_5 . METHOD_5 ( command .... | public Object METHOD_1 ( TYPE_1 ctx , TYPE_2 command ) throws Throwable { if ( this . VAR_1 ) VAR_2 . METHOD_2 ( ) ; Object result = METHOD_3 ( ctx , command ) ; if ( ! ctx . VAR_3 ( ) ) { if ( command . VAR_4 ( ) ) { VAR_5 . METHOD_4 ( command . VAR_6 ( ) , true ) ; } else { VAR_5 . METHOD_5 ( command . VAR_6 ( ) ) ; ... |
s / location / VAR_1 / | public void METHOD_1 ( int VAR_1 ) { METHOD_2 ( STRING_1 ) ; <START> METHOD_3 ( location , STRING_2 , properties ) ; <END> this . VAR_1 = VAR_1 ; } | public void METHOD_1 ( int VAR_1 ) { METHOD_2 ( STRING_1 ) ; METHOD_3 ( String . valueOf ( VAR_1 ) , STRING_1 , properties ) ; this . VAR_1 = VAR_1 ; } |
I don t handle correctly scenario passivation disabled case entries memory a subset entries disk I store instead memory operations | public Object METHOD_1 ( TYPE_1 ctx , TYPE_2 command ) throws Throwable { Object VAR_1 = super . METHOD_1 ( ctx , command ) ; <START> if ( VAR_2 && VAR_3 && ! METHOD_2 ( command ) ) { <END> Set < Object > set = VAR_4 . METHOD_3 ( Collections . VAR_5 ( ) ) ; Set < Object > VAR_6 = new HashSet < Object > ( set ) ; VAR_6 ... | public Object METHOD_1 ( TYPE_1 ctx , TYPE_2 command ) throws Throwable { Object VAR_1 = super . METHOD_1 ( ctx , command ) ; if ( VAR_2 && ! METHOD_2 ( command ) ) { Set < Object > VAR_6 = new HashSet < Object > ( ( Set < Object > ) VAR_1 ) ; VAR_6 . addAll ( VAR_4 . METHOD_3 ( VAR_6 ) ) ; return Collections . VAR_7 (... |
I don t helps | public void METHOD_1 ( ) { VAR_1 . clear ( ) ; <START> VAR_2 . remove ( ) ; <END> } | public void METHOD_1 ( ) { VAR_1 . clear ( ) ; } |
order expected actual values wrong | public void METHOD_1 ( ) throws Throwable { Object VAR_1 = getKey ( ) ; cache ( 0 ) . put ( VAR_1 , STRING_1 ) ; METHOD_2 ( 0 ) . METHOD_3 ( ) ; cache ( 0 ) . remove ( VAR_1 ) ; METHOD_4 ( cache ( 0 ) . get ( VAR_1 ) ) ; METHOD_2 ( 0 ) . METHOD_5 ( ) ; <START> assertEquals ( cache ( 0 ) . get ( VAR_1 ) , STRING_1 ) ; <... | public void METHOD_1 ( ) throws Throwable { Object VAR_1 = getKey ( ) ; cache ( 0 ) . put ( VAR_1 , STRING_1 ) ; METHOD_2 ( 0 ) . METHOD_3 ( ) ; cache ( 0 ) . remove ( VAR_1 ) ; METHOD_4 ( cache ( 0 ) . get ( VAR_1 ) ) ; METHOD_2 ( 0 ) . METHOD_5 ( ) ; assertEquals ( STRING_1 , cache ( 0 ) . get ( VAR_1 ) ) ; } |
data container check ? call cache ( ) | private void METHOD_1 ( int VAR_1 , Object key , Object VAR_2 ) { <START> TYPE_1 entry = cache ( VAR_1 ) . METHOD_2 ( ) . METHOD_3 ( ) . get ( key ) ; <END> assertEquals ( VAR_2 , entry != null ? entry . getValue ( ) : null ) ; } | private void METHOD_1 ( int VAR_1 , Object key , Object VAR_2 ) { assertEquals ( VAR_2 , cache ( VAR_1 ) . get ( key ) ) ; } |
AFAICT queue unlimited shouldn t need throw a TYPE_2 | public final void execute ( TYPE_1 VAR_1 ) { if ( VAR_2 ) { throw new TYPE_2 ( STRING_1 ) ; } if ( VAR_1 . METHOD_1 ( ) ) { METHOD_2 ( VAR_1 ) ; } else { if ( ! VAR_3 . METHOD_3 ( VAR_1 ) ) { <START> throw new TYPE_2 ( STRING_2 ) ; <END> } } METHOD_4 ( ) ; if ( log . VAR_4 ( ) ) { log . VAR_5 ( STRING_3 , VAR_3 . size ... | public final void execute ( TYPE_1 VAR_1 ) { if ( VAR_2 ) { throw new TYPE_2 ( STRING_1 ) ; } if ( VAR_1 . METHOD_1 ( ) ) { METHOD_2 ( VAR_1 ) ; } else { VAR_3 . METHOD_3 ( VAR_1 ) ; } if ( log . VAR_4 ( ) ) { log . VAR_5 ( STRING_3 , VAR_3 . size ( ) ) ; } } |
line removed | protected Set < byte [ ] > METHOD_1 ( TYPE_1 VAR_1 ) { TYPE_2 params = METHOD_2 ( VAR_1 , VAR_2 ) ; VAR_1 . METHOD_3 ( ) ; <START> System . out . println ( STRING_1 ) ; <END> METHOD_4 ( VAR_1 , params ) ; System . out . println ( STRING_2 ) ; Set < byte [ ] > result = new HashSet < byte [ ] > ( ) ; while ( VAR_1 . METH... | protected Set < byte [ ] > METHOD_1 ( TYPE_1 VAR_1 ) { TYPE_2 params = METHOD_2 ( VAR_1 , VAR_2 ) ; VAR_1 . METHOD_3 ( ) ; METHOD_4 ( VAR_1 , params ) ; Set < byte [ ] > result = new HashSet < byte [ ] > ( ) ; while ( VAR_1 . METHOD_5 ( ) == 1 ) { result . add ( VAR_1 . METHOD_6 ( ) ) ; } return result ; } |
I don t matters strictly speaking passing a explicitly I _CODE_ parameter false | protected < T > T METHOD_1 ( Class < T > VAR_1 , String name ) { <START> return METHOD_1 ( VAR_1 , name , true ) ; <END> } | protected < T > T METHOD_1 ( Class < T > VAR_1 , String name ) { return METHOD_1 ( VAR_1 , name , false ) ; } |
arguments passed - ( string concatenation ) nice consequence formatters don t need ( log VAR_3 ) s issue FYI code more readable | public TYPE_1 METHOD_1 ( ANNOTATION_1 TYPE_2 < TYPE_1 > VAR_1 , ANNOTATION_2 TYPE_3 VAR_2 ) { if ( ! VAR_1 . METHOD_2 ( ) ) { if ( log . VAR_3 ( ) ) { <START> log . VAR_4 ( STRING_1 , VAR_1 ) ; <END> } return VAR_1 . get ( ) ; } return new TYPE_4 ( VAR_2 ) ; } | public TYPE_1 METHOD_1 ( ANNOTATION_1 TYPE_2 < TYPE_1 > VAR_1 , ANNOTATION_2 TYPE_3 VAR_2 ) { if ( ! VAR_1 . METHOD_2 ( ) ) { log . VAR_4 ( STRING_1 , VAR_1 ) ; return VAR_1 . get ( ) ; } return new TYPE_4 ( VAR_2 ) ; } |
missing VAR_3 METHOD_2 ( ) | private void METHOD_1 ( ) { VAR_1 . METHOD_2 ( VAR_2 ) ; VAR_3 . METHOD_2 ( VAR_2 ) ; <START> VAR_2 . METHOD_1 ( ) ; <END> METHOD_3 ( ) ; } | private void METHOD_1 ( ) { VAR_1 . METHOD_2 ( VAR_2 ) ; VAR_3 . METHOD_2 ( VAR_2 ) ; VAR_3 . METHOD_2 ( this ) ; METHOD_3 ( ) ; } |
method return true throw exception return false A boolean return required | protected boolean METHOD_1 ( ) throws Exception { boolean VAR_1 ; if ( VAR_2 . METHOD_2 ( ) ) { throw new IllegalStateException ( STRING_1 + METHOD_3 ( ) + STRING_2 ) ; } VAR_3 = METHOD_4 ( ) ; VAR_1 = true ; if ( VAR_3 . METHOD_5 ( ) . contains ( VAR_4 ) ) VAR_5 = VAR_3 ; else VAR_5 = METHOD_6 ( configuration , VAR_3 ... | protected void METHOD_1 ( ) throws Exception { if ( VAR_2 . METHOD_2 ( ) ) { throw new IllegalStateException ( STRING_1 + METHOD_3 ( ) + STRING_2 ) ; } VAR_3 = METHOD_4 ( ) ; if ( VAR_3 . METHOD_5 ( ) . contains ( VAR_4 ) ) VAR_5 = VAR_3 ; else VAR_5 = METHOD_6 ( configuration , VAR_3 . METHOD_5 ( ) , VAR_2 . METHOD_7 ... |
usage collection ineffective plan modify flight Collections _CODE_ ( ) instead code | public TYPE_2 ( String id , String VAR_2 , String VAR_3 , String VAR_4 , String VAR_5 ) { super ( id ) ; this . VAR_2 = StringUtils . VAR_6 ( VAR_2 , STRING_1 ) + STRING_1 ; METHOD_1 ( VAR_3 ) ; METHOD_2 ( StringUtils . VAR_7 ( VAR_4 , TYPE_3 . VAR_9 ) ) ; METHOD_3 ( StringUtils . VAR_7 ( VAR_5 , TYPE_3 . VAR_10 ) ) ; ... | public TYPE_2 ( String id , String VAR_2 , String VAR_3 , String VAR_4 , String VAR_5 ) { super ( id ) ; this . VAR_2 = StringUtils . VAR_6 ( VAR_2 , STRING_1 ) + STRING_1 ; METHOD_1 ( VAR_3 ) ; METHOD_2 ( StringUtils . VAR_7 ( VAR_4 , TYPE_3 . VAR_9 ) ) ; METHOD_3 ( StringUtils . VAR_7 ( VAR_5 , TYPE_3 . VAR_10 ) ) ; ... |
( ) invocation constructor | public TYPE_4 ( TYPE_1 VAR_2 ) { this . VAR_3 = <START> new TYPE_2 ( VAR_2 , TYPE_3 < String , TYPE_1 > METHOD_1 ( ) , TYPE_5 . VAR_6 ) ; <END> } | public TYPE_4 ( TYPE_1 VAR_2 ) { this ( VAR_2 , null , TYPE_5 . VAR_6 ) ; } |
need catch - throw exception | private static TYPE_1 METHOD_1 ( TYPE_2 VAR_1 , TYPE_3 element , TYPE_4 VAR_2 ) throws TYPE_5 { try { if ( STRING_1 . equals ( element . VAR_3 ( ) ) ) { return new TYPE_6 ( VAR_1 , VAR_2 ) ; } return new TYPE_1 ( VAR_1 , 0 , VAR_2 , element ) ; } catch ( TYPE_5 e ) { <START> throw e ; <END> } } | private static TYPE_1 METHOD_1 ( TYPE_2 VAR_1 , TYPE_3 element , TYPE_4 VAR_2 ) throws TYPE_5 { if ( STRING_1 . equals ( element . VAR_3 ( ) ) ) { return new TYPE_6 ( VAR_1 , VAR_2 ) ; } return new TYPE_1 ( VAR_1 , 0 , VAR_2 , element ) ; } |
catch blocks body java 7 s user multi - catch syntax : } catch ( _CODE_ e { | private static TYPE_1 METHOD_1 ( TYPE_2 VAR_1 , TYPE_3 VAR_2 ) throws TYPE_4 { try { return VAR_2 . METHOD_1 ( METHOD_2 ( VAR_1 ) ) ; <START> } catch ( TYPE_5 e ) { <END> throw e ; } catch ( TYPE_6 e ) { throw e ; } } | private static TYPE_1 METHOD_1 ( TYPE_2 VAR_1 , TYPE_3 VAR_2 ) throws TYPE_4 { try { return VAR_2 . METHOD_1 ( METHOD_2 ( VAR_1 ) ) ; } catch ( TYPE_6 e ) { throw e ; } } |
s multi - catch | public static TYPE_1 < TYPE_2 > METHOD_1 ( final TYPE_3 VAR_1 ) { return new TYPE_1 < TYPE_2 > ( ) { @Override public TYPE_2 apply ( TYPE_4 VAR_2 ) { try { TYPE_5 element = METHOD_2 ( VAR_1 , VAR_2 ) ; return METHOD_3 ( VAR_1 , element , VAR_2 ) ; <START> } catch ( TYPE_6 e ) { <END> return null ; } catch ( TYPE_7 e ) ... | public static TYPE_1 < TYPE_2 > METHOD_1 ( final TYPE_3 VAR_1 ) { return new TYPE_1 < TYPE_2 > ( ) { @Override public TYPE_2 apply ( TYPE_4 VAR_2 ) { try { TYPE_5 element = METHOD_2 ( VAR_1 , VAR_2 ) ; return METHOD_3 ( VAR_1 , element , VAR_2 ) ; } catch ( TYPE_6 | TYPE_7 e ) { return null ; } } @Override public Strin... |
reason named CB d short statically referenced - - biggie | public static void METHOD_1 ( ) throws Exception { String VAR_1 = System . getProperty ( STRING_1 ) ; <START> if ( VAR_1 == null ) VAR_1 = TYPE_6 . TYPE_5 . METHOD_2 ( ) + File . VAR_2 + STRING_2 ; <END> System . out . println ( STRING_3 + VAR_1 ) ; TYPE_2 VAR_3 = new TYPE_2 ( new File ( Utils . VAR_4 ( VAR_1 ) ) ) ; V... | public static void METHOD_1 ( ) throws Exception { String VAR_1 = System . getProperty ( STRING_1 ) ; if ( VAR_1 == null ) VAR_1 = TYPE_3 . TYPE_5 . METHOD_2 ( ) + File . VAR_2 + STRING_2 ; System . out . println ( STRING_3 + VAR_1 ) ; TYPE_2 VAR_3 = new TYPE_2 ( new File ( Utils . VAR_4 ( VAR_1 ) ) ) ; VAR_5 = TYPE_3 ... |
I m sorting _CODE_ reason METHOD_1 ( ) returns a List a Set original call site notready command fed a utility method stringifies a List s laziness more : PI more sense sorting caller site else reduces blast radius pull request changes collected signs / rendering code | public List < TYPE_1 > METHOD_1 ( ) { List < TYPE_1 > result = new TYPE_2 < > ( ) ; result . addAll ( VAR_1 ) ; result . VAR_2 ( VAR_3 ) ; <START> result . VAR_4 ( TYPE_3 . METHOD_2 ( TYPE_1 : : getName ) ) ; <END> return result ; } | public List < TYPE_1 > METHOD_1 ( ) { List < TYPE_1 > result = new TYPE_2 < > ( ) ; result . addAll ( VAR_1 ) ; result . VAR_2 ( VAR_3 ) ; return result ; } |
I don t necessary | public TYPE_3 ( String VAR_2 , String VAR_3 ) { <START> super ( ) ; <END> VAR_4 = new TYPE_1 ( this , VAR_2 , VAR_3 , new TYPE_2 ( ) ) ; } | public TYPE_3 ( String VAR_2 , String VAR_3 ) { VAR_4 = new TYPE_1 ( this , VAR_2 , VAR_3 , new TYPE_2 ( ) ) ; } |
final | public TYPE_1 METHOD_1 ( int VAR_1 , int VAR_2 ) { <START> double VAR_3 = VAR_1 - VAR_4 . METHOD_2 ( ) / FLOAT_1 ; <END> double VAR_5 = VAR_4 . METHOD_3 ( ) / FLOAT_1 - VAR_2 ; return METHOD_4 ( ) . METHOD_5 ( ) . apply ( new TYPE_1 ( VAR_3 , VAR_5 , 0 ) ) ; } | public TYPE_1 METHOD_1 ( int VAR_1 , int VAR_2 ) { final double VAR_3 = VAR_1 - VAR_4 . METHOD_2 ( ) / FLOAT_1 ; final double VAR_5 = VAR_4 . METHOD_3 ( ) / FLOAT_1 - VAR_2 ; return METHOD_4 ( ) . METHOD_5 ( ) . apply ( new TYPE_1 ( VAR_3 , VAR_5 , 0 ) ) ; } |
final | public void METHOD_1 ( TYPE_1 VAR_1 ) { synchronized ( VAR_2 ) { this . VAR_1 = VAR_1 ; <START> double VAR_3 = VAR_4 . METHOD_2 ( ) ; <END> METHOD_3 ( ) ; VAR_4 = VAR_4 . METHOD_4 ( VAR_3 / VAR_4 . METHOD_2 ( ) ) ; } } | public void METHOD_1 ( TYPE_1 VAR_1 ) { synchronized ( VAR_2 ) { this . VAR_1 = VAR_1 ; final double VAR_3 = VAR_4 . METHOD_2 ( ) ; METHOD_3 ( ) ; VAR_4 = VAR_4 . METHOD_4 ( VAR_3 / VAR_4 . METHOD_2 ( ) ) ; } } |
catch exception ? pass ? I a thin chance happen case a default data VAR_2 ( ) UTF - 8 fails TYPE_3 | public static long METHOD_1 ( String data ) { if ( data == null ) { return - 1 ; } try { byte VAR_1 [ ] = data . VAR_2 ( STRING_1 ) ; TYPE_1 VAR_3 = new TYPE_2 ( ) ; VAR_3 . update ( VAR_1 , 0 , VAR_1 . length ) ; return VAR_3 . getValue ( ) ; } catch ( TYPE_3 e ) { <START> return - 1 ; <END> } } | public static long METHOD_1 ( String data ) { if ( data == null ) { return - 1 ; } try { byte VAR_1 [ ] = data . VAR_2 ( STRING_1 ) ; TYPE_1 VAR_3 = new TYPE_2 ( ) ; VAR_3 . update ( VAR_1 , 0 , VAR_1 . length ) ; return VAR_3 . getValue ( ) ; } catch ( TYPE_3 e ) { throw new RuntimeException ( e ) ; } } |
please add braces surrounding loop block confusing read | private void METHOD_1 ( TYPE_1 properties , Map < String , String > VAR_1 ) { if ( properties != null ) { <START> for ( final String name : properties . VAR_2 ( ) ) <END> if ( ! VAR_1 . containsKey ( name ) ) { VAR_1 . put ( name , properties . getProperty ( name ) ) ; } } } | private static void METHOD_1 ( TYPE_1 properties , Map < String , String > VAR_1 ) { if ( properties != null ) { for ( final String name : properties . VAR_2 ( ) ) { if ( ! VAR_1 . containsKey ( name ) ) { VAR_1 . put ( name , properties . getProperty ( name ) ) ; } } } } |
refactor else condition ? javaif ( ! VAR_1 || ( VAR_1 && METHOD_3 ( ) < = 0 ) ) { VAR_1 = METHOD_2 ( ) ; } | public String METHOD_1 ( ) throws TYPE_1 { <START> if ( VAR_1 == null ) { <END> VAR_1 = METHOD_2 ( ) ; } else if ( ( VAR_1 != null ) && ( METHOD_3 ( ) <= 0 ) ) { VAR_1 = METHOD_2 ( ) ; } return VAR_1 ; } | public String METHOD_1 ( ) throws TYPE_1 { if ( VAR_1 == null || METHOD_3 ( ) <= 0 ) { VAR_1 = METHOD_2 ( ) ; } return VAR_1 ; } |
histogram based natural breaks quantiles percentage calculation require counting portions VAR_2 a set ranges necessarily match VAR_2 limits methods compute results | private double [ ] METHOD_1 ( List < Double > VAR_1 , List < TYPE_1 > VAR_2 , int VAR_3 , int VAR_4 ) { Map < Double , Integer > values = new HashMap < > ( ) ; for ( TYPE_1 b : VAR_2 ) { values . put ( b . VAR_5 ( ) , b . VAR_6 ( ) ) ; } TYPE_2 VAR_7 = new TYPE_2 ( ) ; <START> return VAR_7 . METHOD_1 ( values , VAR_1 ,... | private double [ ] METHOD_1 ( List < Double > VAR_1 , List < TYPE_1 > VAR_2 , int VAR_3 , int VAR_4 ) { TYPE_2 VAR_7 = new TYPE_2 ( ) ; return VAR_7 . METHOD_1 ( VAR_2 , VAR_1 , VAR_4 ) ; } |
check explicitly zero ? opaque optimize a division | private Double METHOD_1 ( double VAR_1 , double VAR_2 , double VAR_3 , double VAR_4 ) { if ( VAR_1 > VAR_4 || VAR_2 < VAR_3 ) { return FLOAT_1 ; } double VAR_5 = Math . max ( VAR_1 , VAR_3 ) ; double VAR_6 = Math . VAR_7 ( VAR_2 , VAR_4 ) ; double VAR_8 = VAR_6 - VAR_5 ; double VAR_9 = VAR_4 - VAR_3 ; <START> if ( VAR_... | private Double METHOD_1 ( double VAR_1 , double VAR_2 , double VAR_3 , double VAR_4 ) { if ( VAR_1 > VAR_4 || VAR_2 < VAR_3 ) { return FLOAT_1 ; } double VAR_5 = Math . max ( VAR_1 , VAR_3 ) ; double VAR_6 = Math . VAR_7 ( VAR_2 , VAR_4 ) ; double VAR_8 = VAR_6 - VAR_5 ; double VAR_9 = VAR_4 - VAR_3 ; if ( VAR_9 == FLO... |
need a null check done default returned field isn t set ( i e null ) _CODE_ example default return : ) | public boolean METHOD_1 ( ) { <START> return this . VAR_1 ; <END> } | public boolean METHOD_1 ( ) { if ( this . VAR_1 == null ) { return false ; } else { return this . VAR_1 ; } } |
/ private ( remove ( _CODE_ class ) ) | <START> public final Object METHOD_1 ( TYPE_1 build , Class VAR_1 ) { <END> return build instanceof TYPE_2 ? ( TYPE_2 ) build : null ; } | private final Object METHOD_1 ( TYPE_1 build , Class VAR_1 ) { return build instanceof TYPE_2 ? ( TYPE_2 ) build : null ; } |
protected static ? doesn t sense t override static methods | <START> protected static TYPE_1 METHOD_1 ( ) { <END> return b . VAR_1 ( ) ; } | protected TYPE_1 METHOD_1 ( ) { return b . VAR_1 ( ) ; } |
error | public TYPE_1 METHOD_1 ( ) throws InterruptedException { synchronized ( VAR_1 ) { if ( VAR_1 . isEmpty ( ) ) { <START> VAR_1 . METHOD_2 ( ) ; <END> Integer VAR_2 = VAR_1 . METHOD_3 ( ) ; return VAR_3 [ VAR_2 ] ; } Integer VAR_2 = VAR_1 . METHOD_3 ( ) ; return VAR_3 [ VAR_2 ] ; } } | public TYPE_1 METHOD_1 ( ) throws InterruptedException { synchronized ( VAR_1 ) { while ( VAR_1 . isEmpty ( ) ) { VAR_1 . METHOD_2 ( ) ; } Integer VAR_2 = VAR_1 . METHOD_3 ( ) ; return VAR_3 [ VAR_2 ] ; } } |
a bit harsh I m guessing TIFF reader a single byte read call | public int read ( ) throws IOException { VAR_1 ++ ; <START> return 0 ; <END> } | public int read ( ) throws IOException { byte [ ] b = new byte [ 1 ] ; read ( b , 0 , 1 ) ; return b [ 0 ] ; } |
instead string concatenation a StringBuilder | public static String METHOD_1 ( List < TYPE_1 > VAR_1 ) { <START> String buffer = "" ; <END> for ( TYPE_1 c : VAR_1 ) { buffer += METHOD_1 ( c , 0 ) ; } return buffer ; } | public static String METHOD_1 ( List < TYPE_1 > VAR_1 ) { StringBuilder builder = new StringBuilder ( ) ; for ( TYPE_1 c : VAR_1 ) { builder . append ( METHOD_1 ( c , 0 ) ) ; } return builder . toString ( ) ; } |
add curly brackets statement ? good practice don t weird bugs future | public TYPE_1 METHOD_1 ( String VAR_1 ) throws TYPE_2 { <START> if ( VAR_1 == STRING_1 ) <END> throw new TYPE_2 ( STRING_2 ) ; TYPE_3 object = ( TYPE_3 ) VAR_2 . get ( String . format ( TYPE_4 . VAR_4 , VAR_1 ) , null ) . METHOD_2 ( ) ; TYPE_3 data = ( TYPE_3 ) object . get ( STRING_3 ) ; return data != null ? new TYPE... | public TYPE_1 METHOD_1 ( String VAR_1 ) throws TYPE_2 { if ( VAR_1 . equals ( STRING_1 ) ) { throw new TYPE_2 ( STRING_2 ) ; } TYPE_3 object = ( TYPE_3 ) VAR_2 . get ( String . format ( TYPE_4 . VAR_4 , VAR_1 ) , null ) . METHOD_2 ( ) ; TYPE_3 data = ( TYPE_3 ) object . get ( STRING_3 ) ; return data != null ? new TYPE... |
don t * * user = null * * null class instantianciated line redundant | public TYPE_2 ( TYPE_1 VAR_2 ) { this . VAR_2 = VAR_2 ; <START> this . user = null ; <END> } | public TYPE_2 ( TYPE_1 VAR_2 ) { this . VAR_2 = VAR_2 ; } |
_CODE_ iterating Map Entry < String TYPE_3 > | public void METHOD_1 ( TYPE_1 event ) { TYPE_2 VAR_1 = event . VAR_2 ( ) ; if ( ! VAR_1 . METHOD_2 ( ) ) { <START> for ( Object map : VAR_3 . METHOD_3 ( ) . keySet ( ) ) { <END> TYPE_3 VAR_4 = VAR_3 . METHOD_3 ( ) . get ( map ) ; if ( TYPE_4 . METHOD_4 ( ) . METHOD_5 ( VAR_1 , STRING_1 + map ) ) { VAR_4 . METHOD_6 ( VA... | public void METHOD_1 ( TYPE_1 event ) { TYPE_2 VAR_1 = event . VAR_2 ( ) ; if ( ! VAR_1 . METHOD_2 ( ) ) { for ( Entry < String , TYPE_3 > map : VAR_3 . METHOD_3 ( ) . entrySet ( ) ) { if ( TYPE_4 . METHOD_4 ( ) . METHOD_5 ( VAR_1 , STRING_1 + map ) ) { map . getValue ( ) . METHOD_6 ( VAR_1 ) ; } } } } |
class final private | <START> protected boolean METHOD_1 ( final TYPE_1 request ) { <END> return TYPE_2 . METHOD_2 ( TYPE_2 . METHOD_3 ( request , this . VAR_1 , this . VAR_2 ) ) ; } | private boolean METHOD_1 ( final TYPE_1 request ) { return TYPE_2 . METHOD_2 ( TYPE_2 . METHOD_3 ( request , this . VAR_1 , this . VAR_2 ) ) ; } |
private | <START> protected boolean METHOD_1 ( final TYPE_1 request ) { <END> return STRING_1 . equals ( request . VAR_1 ( ) ) && ! METHOD_2 ( request ) && TYPE_2 . METHOD_3 ( TYPE_2 . METHOD_4 ( request , this . VAR_2 , this . VAR_3 ) ) ; } | private boolean METHOD_1 ( final TYPE_1 request ) { return STRING_1 . equals ( request . VAR_1 ( ) ) && ! METHOD_2 ( request ) && TYPE_2 . METHOD_3 ( TYPE_2 . METHOD_4 ( request , this . VAR_2 , this . VAR_3 ) ) ; } |
instead VAR_3 | private String METHOD_1 ( final TYPE_1 VAR_1 , final String VAR_2 ) { <START> final String VAR_3 = VAR_1 . METHOD_2 ( ) . METHOD_3 ( VAR_2 ) ; <END> if ( TYPE_2 . METHOD_4 ( VAR_3 ) ) { logger . info ( STRING_1 , VAR_2 , VAR_3 ) ; return VAR_3 ; } return null ; } | private String METHOD_1 ( final TYPE_1 VAR_1 , final String VAR_2 ) { final String value = VAR_1 . METHOD_2 ( ) . METHOD_3 ( VAR_2 ) ; if ( TYPE_2 . METHOD_4 ( value ) ) { logger . info ( STRING_1 , VAR_2 , value ) ; return value ; } return null ; } |
static imports | public TYPE_4 ( String type , TYPE_1 options , TYPE_2 VAR_2 ) { super ( type , options , VAR_2 , true ) ; <START> TYPE_3 . METHOD_1 ( VAR_3 , VAR_4 , VAR_5 ) ; <END> TYPE_3 . METHOD_2 ( VAR_6 , VAR_4 , VAR_5 ) ; METHOD_3 ( ) ; } | public TYPE_4 ( String type , TYPE_1 options , TYPE_2 VAR_2 ) { super ( type , options , VAR_2 ) ; } |
static imports | public TYPE_4 ( String type , TYPE_1 options , TYPE_2 VAR_2 ) { super ( type , options , VAR_2 , true ) ; <START> TYPE_3 . METHOD_1 ( VAR_3 , VAR_4 , VAR_5 ) ; <END> TYPE_3 . METHOD_2 ( VAR_6 , VAR_4 , VAR_5 ) ; } | public TYPE_4 ( String type , TYPE_1 options , TYPE_2 VAR_2 ) { super ( type , options , VAR_2 ) ; } |
static imports | public TYPE_4 ( String type , TYPE_1 options , TYPE_2 VAR_2 ) { super ( type , options , VAR_2 , true ) ; <START> TYPE_3 . METHOD_1 ( VAR_3 , VAR_4 , VAR_5 ) ; <END> TYPE_3 . METHOD_2 ( VAR_2 , VAR_4 , VAR_5 ) ; TYPE_3 . METHOD_3 ( VAR_6 , VAR_4 , VAR_5 ) ; this . options = options ; } | public TYPE_4 ( String type , TYPE_1 options , TYPE_2 VAR_2 ) { super ( type , options , VAR_2 ) ; } |
METHOD_1 check disconnect | public void METHOD_1 ( ) { connection = new TYPE_1 ( options , VAR_1 , VAR_2 ) ; connection . VAR_3 ( options ) ; <START> if ( connection . VAR_4 ( ) . METHOD_2 ( ) != VAR_5 ) { <END> connection . VAR_6 ( ) ; throw new IllegalArgumentException ( format ( STRING_1 + VAR_7 + STRING_2 , VAR_8 . toString ( ) . METHOD_3 ( )... | public void METHOD_1 ( ) { super . METHOD_1 ( ) ; } |
s update METHOD_2 ( ) return TYPE_1 type need typecast | private synchronized void METHOD_1 ( ) { <START> final TYPE_1 VAR_1 = ( TYPE_1 ) METHOD_2 ( ) ; <END> if ( VAR_2 . METHOD_3 ( ) && METHOD_4 ( VAR_1 ) ) { VAR_3 . METHOD_5 ( VAR_1 . METHOD_6 ( ) ) ; VAR_1 . METHOD_7 ( ) ; VAR_4 = TYPE_2 . METHOD_8 ( ) ; } } | synchronized void METHOD_1 ( ) { final TYPE_1 VAR_1 = METHOD_2 ( ) ; if ( VAR_2 . METHOD_3 ( ) && METHOD_4 ( VAR_1 ) ) { VAR_3 . METHOD_5 ( VAR_1 . METHOD_6 ( ) ) ; VAR_1 . METHOD_7 ( ) ; VAR_4 = TYPE_2 . METHOD_8 ( ) ; } } |
public t removed class a public class a breaking change | <START> TYPE_3 ( TYPE_1 < T > VAR_2 , <END> String VAR_3 , long VAR_4 , long VAR_5 , int VAR_6 , int VAR_7 , int VAR_8 , TYPE_2 VAR_9 ) { this ( VAR_2 , METHOD_1 ( ) , VAR_3 , VAR_4 , VAR_5 , VAR_6 , VAR_7 , VAR_8 , VAR_9 ) ; } | public TYPE_3 ( TYPE_1 < T > VAR_2 , String VAR_3 , long VAR_4 , long VAR_5 , int VAR_6 , int VAR_7 , int VAR_8 , TYPE_2 VAR_9 ) { this ( VAR_2 , METHOD_1 ( ) , VAR_3 , VAR_4 , VAR_5 , VAR_6 , VAR_7 , VAR_8 , VAR_9 ) ; } |
@Override line method annotations PR line | <START> @Override public synchronized Boolean METHOD_1 ( String VAR_1 ) { <END> if ( METHOD_2 ( ( ) - > TYPE_1 . METHOD_3 ( VAR_2 ) ) ) { METHOD_4 ( ) ; VAR_3 . METHOD_5 ( this : : METHOD_4 , VAR_4 , VAR_5 , TimeUnit . VAR_6 ) ; } return METHOD_2 ( ( ) - > METHOD_6 ( VAR_1 ) ) ; } | public synchronized Boolean METHOD_1 ( String VAR_1 ) { if ( METHOD_2 ( ( ) - > TYPE_1 . METHOD_3 ( VAR_2 ) ) ) { METHOD_4 ( ) ; VAR_3 . METHOD_5 ( this : : METHOD_4 , VAR_4 , VAR_5 , TimeUnit . VAR_6 ) ; } return METHOD_2 ( ( ) - > METHOD_6 ( VAR_1 ) ) ; } |
statement statement doesn t | public final void METHOD_1 ( ) { TYPE_1 event = new TYPE_1 ( VAR_1 , VAR_2 ) ; event . VAR_3 ( VAR_4 ) ; assertTrue ( VAR_5 ) ; <START> VAR_5 = false ; <END> } | public void METHOD_1 ( ) { TYPE_1 event = new TYPE_1 ( VAR_1 , VAR_2 ) ; event . VAR_3 ( VAR_4 ) ; assertTrue ( VAR_5 ) ; } |
a reason changing order chained constructor ? add new parameter list | public TYPE_1 ( TYPE_2 VAR_1 , TYPE_3 VAR_2 , TYPE_4 VAR_3 , Optional < Long > VAR_4 , TYPE_5 VAR_5 , TYPE_6 VAR_6 ) { this ( VAR_1 , VAR_2 , VAR_3 , VAR_4 , VAR_5 , <START> VAR_6 , TYPE_7 . VAR_8 , <END> TYPE_1 . METHOD_1 ( VAR_5 . METHOD_2 ( ) ) , INT_1 ) ; } | public TYPE_1 ( TYPE_2 VAR_1 , TYPE_3 VAR_2 , TYPE_4 VAR_3 , Optional < Long > VAR_4 , TYPE_5 VAR_5 , TYPE_6 VAR_6 ) { this ( VAR_1 , VAR_2 , VAR_3 , VAR_4 , VAR_5 , TYPE_7 . VAR_8 , TYPE_1 . METHOD_1 ( VAR_5 . METHOD_2 ( ) ) , INT_1 , VAR_6 ) ; } |
changed true trigger METHOD_3 | private void METHOD_1 ( ) { if ( ! VAR_1 . METHOD_2 ( ) ) { VAR_1 . METHOD_3 ( ) ; } <START> VAR_2 = true ; <END> } | private void METHOD_1 ( ) { if ( ! VAR_1 . METHOD_2 ( ) ) { VAR_1 . METHOD_3 ( ) ; } } |
( TYPE_6 equals ( VAR_2 METHOD_5 ( ) VAR_7 ) ) { return VAR_6 ; } _CODE_ | public TYPE_1 METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) { final TYPE_3 VAR_3 = ( TYPE_3 ) ( VAR_1 . METHOD_2 ( VAR_4 ) ) ; TYPE_1 VAR_5 = null ; for ( TYPE_4 item : VAR_3 . METHOD_3 ( ) ) { final TYPE_1 VAR_6 = ( TYPE_1 ) item ; final String VAR_7 = TYPE_5 . METHOD_4 ( VAR_6 , TYPE_2 . VAR_8 ) ; <START> if ( ! TYPE_6 . ... | public TYPE_1 METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) { final TYPE_3 VAR_3 = ( TYPE_3 ) ( VAR_1 . METHOD_2 ( VAR_4 ) ) ; TYPE_1 VAR_5 = null ; for ( TYPE_4 item : VAR_3 . METHOD_3 ( ) ) { final TYPE_1 VAR_6 = ( TYPE_1 ) item ; final String VAR_7 = TYPE_5 . METHOD_4 ( VAR_6 , TYPE_2 . VAR_8 ) ; if ( TYPE_6 . equals ( V... |
throw IOException | <START> public TYPE_1 create ( ANNOTATION_1 TYPE_1 VAR_1 ) throws Exception { <END> TYPE_2 VAR_2 = TYPE_3 . to ( VAR_1 ) ; return get ( VAR_3 . create ( VAR_2 ) ) ; } | public TYPE_1 create ( ANNOTATION_1 TYPE_1 VAR_1 ) throws IOException { TYPE_2 VAR_2 = TYPE_3 . to ( VAR_1 ) ; return get ( VAR_3 . create ( VAR_2 ) ) ; } |
ll build versions match tag names v0 2 190 create a stable version release STRING_2 pointing current develop branch safest return STRING_2 won t a broken link release | public static String METHOD_1 ( ) { if ( TYPE_2 . TYPE_3 . METHOD_2 ( STRING_1 ) ) { <START> return TYPE_2 . TYPE_3 ; <END> } else { return STRING_2 ; } } | public static String METHOD_1 ( ) { return STRING_2 ; } |
I m s safe change fake - fake sequences I m trouble working mind | protected void METHOD_1 ( TYPE_1 to , TYPE_1 from ) throws IOException { to . VAR_1 ( from . getName ( ) ) ; <START> to . VAR_2 ( from . VAR_3 ( ) ) ; <END> to . VAR_4 ( from . VAR_5 ( ) ) ; to . VAR_6 ( from . VAR_7 ( ) ) ; } | protected void METHOD_1 ( TYPE_1 to , TYPE_1 from ) throws IOException { to . VAR_1 ( from . getName ( ) ) ; to . VAR_4 ( from . VAR_5 ( ) ) ; to . VAR_6 ( from . VAR_7 ( ) ) ; } |
parameter false ( _CODE_ isn t nullable ) | public static TYPE_1 to ( ANNOTATION_1 TYPE_2 from ) { TYPE_1 to = new TYPE_1 ( ) ; if ( from . getId ( ) != null ) to . VAR_1 ( from . getId ( ) ) ; METHOD_1 ( to : : METHOD_2 , from . getName ( ) ) ; METHOD_1 ( to : : METHOD_3 , from . VAR_2 ( ) ) ; <START> METHOD_4 ( to : : METHOD_5 , from . VAR_3 ( ) , true ) ; <EN... | public static TYPE_1 to ( ANNOTATION_1 TYPE_2 from ) { TYPE_1 to = new TYPE_1 ( ) ; if ( from . getId ( ) != null ) to . VAR_1 ( from . getId ( ) ) ; METHOD_1 ( to : : METHOD_2 , from . getName ( ) ) ; METHOD_1 ( to : : METHOD_3 , from . VAR_2 ( ) ) ; METHOD_4 ( to : : METHOD_5 , from . VAR_3 ( ) , false ) ; return to ... |
3 methods private useful controller a utilities class | <START> public static String METHOD_1 ( String index , int VAR_1 ) { <END> return index . substring ( 0 , VAR_1 ) ; } | private static String METHOD_1 ( String index , int VAR_1 ) { return index . substring ( 0 , VAR_1 ) ; } |
ve changes similar a places compiler complaining want update java version I previously a version a similar bug | public ANNOTATION_1 List < TYPE_1 > list ( ) throws IOException { Collection < TYPE_2 > VAR_1 = VAR_2 . list ( ) ; <START> return VAR_1 . stream ( ) . map ( VAR_3 - > TYPE_3 . METHOD_1 ( VAR_3 ) ) . collect ( Collectors . VAR_4 ( ) ) ; <END> } | public ANNOTATION_1 List < TYPE_1 > list ( ) throws IOException { Collection < TYPE_2 > VAR_1 = VAR_2 . list ( ) ; return VAR_1 . stream ( ) . map ( TYPE_3 : : METHOD_1 ) . collect ( Collectors . VAR_4 ( ) ) ; } |
add a check item position removing ? ( I selected a column a blank VAR_2 clicked discard selected returned internal server error : item VAR_3 position I closed dialog page didn t refresh looked happened I manually refreshed page turned selected items discarded ) | public ANNOTATION_1 TYPE_1 METHOD_1 ( ANNOTATION_2 long VAR_1 , ANNOTATION_3 List < String > VAR_2 ) throws IOException { TYPE_2 VAR_3 = METHOD_2 ( VAR_1 ) ; for ( String position : VAR_2 ) { <START> VAR_3 . METHOD_3 ( ) . remove ( position ) ; <END> } VAR_4 . METHOD_4 ( VAR_3 ) ; return METHOD_5 ( VAR_1 ) ; } | public ANNOTATION_1 TYPE_1 METHOD_1 ( ANNOTATION_2 long VAR_1 , ANNOTATION_3 List < String > VAR_2 ) throws IOException { TYPE_2 VAR_3 = METHOD_2 ( VAR_1 ) ; for ( String position : VAR_2 ) { if ( VAR_3 . METHOD_3 ( ) . containsKey ( position ) ) { VAR_3 . METHOD_3 ( ) . remove ( position ) ; } } VAR_4 . METHOD_4 ( VAR... |
add STRING_1 STRING_2 STANDARD_ALIASES list top class added criteria _CODE_ | public String METHOD_1 ( TYPE_1 item , boolean VAR_1 ) { item . VAR_2 ( STRING_1 , STRING_1 ) ; <START> item . VAR_2 ( STRING_2 , STRING_2 ) ; <END> return VAR_1 ? STRING_3 : STRING_4 ; } | public String METHOD_1 ( TYPE_1 item , boolean VAR_1 ) { return VAR_1 ? STRING_3 : STRING_4 ; } |
creator isn t modifiable doesn t need loaded database update ( ll fully loaded managed VAR_4 [ ] ( ) ) | public TYPE_1 METHOD_1 ( ANNOTATION_1 Long VAR_1 , ANNOTATION_2 TYPE_1 VAR_2 ) throws IOException { if ( VAR_2 == null ) { log . error ( STRING_1 ) ; throw new TYPE_2 ( STRING_2 , Status . VAR_3 ) ; } TYPE_3 VAR_4 = TYPE_4 . to ( VAR_2 ) ; <START> VAR_4 . METHOD_2 ( VAR_5 . METHOD_3 ( VAR_2 . METHOD_4 ( ) ) ) ; <END> V... | public TYPE_1 METHOD_1 ( ANNOTATION_1 Long VAR_1 , ANNOTATION_2 TYPE_1 VAR_2 ) throws IOException { if ( VAR_2 == null ) { log . error ( STRING_1 ) ; throw new TYPE_2 ( STRING_2 , Status . VAR_3 ) ; } TYPE_3 VAR_4 = TYPE_4 . to ( VAR_2 ) ; VAR_4 . METHOD_5 ( VAR_1 ) ; VAR_6 . update ( VAR_4 ) ; return METHOD_6 ( VAR_1 ... |
protected knowledge link text belongs page model classes A page class expose _CODE_ ( ) method METHOD_1 ( add ) | <START> public String METHOD_1 ( String VAR_1 ) { <END> TYPE_1 VAR_2 = METHOD_2 ( ) . METHOD_3 ( TYPE_2 . METHOD_4 ( VAR_1 ) ) ; TYPE_1 VAR_3 = METHOD_5 ( ) ; VAR_2 . METHOD_6 ( ) ; METHOD_7 ( VAR_3 ) ; return METHOD_8 ( ) ; } | protected String METHOD_1 ( String VAR_1 ) { TYPE_1 VAR_2 = METHOD_2 ( ) . METHOD_3 ( TYPE_2 . METHOD_4 ( VAR_1 ) ) ; TYPE_1 VAR_3 = METHOD_5 ( ) ; VAR_2 . METHOD_6 ( ) ; METHOD_7 ( VAR_3 ) ; return METHOD_8 ( ) ; } |
_CODE_ throw _CODE_ element doesn t exist null _CODE_ element null more sense remove null check allow _CODE_ _CODE_ _CODE_ | protected void METHOD_1 ( ) { TYPE_1 VAR_1 = METHOD_2 ( ) . METHOD_3 ( TYPE_2 . id ( STRING_1 ) ) ; <START> if ( VAR_1 != null ) { <END> VAR_1 . METHOD_4 ( ) ; } else { throw new IllegalArgumentException ( STRING_2 ) ; } } | protected void METHOD_1 ( ) { TYPE_1 VAR_1 = METHOD_2 ( ) . METHOD_3 ( TYPE_2 . id ( STRING_1 ) ) ; VAR_1 . METHOD_4 ( ) ; } |
sense support usual search TYPE_3 parse I m indifferent | public TYPE_1 METHOD_1 ( ANNOTATION_1 ( STRING_1 ) String VAR_1 , ANNOTATION_1 ( STRING_2 ) String query ) throws IOException { TYPE_2 VAR_2 = TYPE_2 . get ( VAR_1 ) ; return METHOD_2 ( 100 , <START> TYPE_3 . METHOD_3 ( VAR_2 ) , <END> TYPE_3 . query ( query ) ) ; } | public TYPE_1 METHOD_1 ( ANNOTATION_1 ( STRING_1 ) String VAR_1 , ANNOTATION_1 ( STRING_2 ) String query ) throws IOException { return METHOD_2 ( 100 , TYPE_3 . METHOD_3 ( TYPE_2 . valueOf ( VAR_1 ) ) , TYPE_3 . query ( query ) ) ; } |
I changing UNSAVED_ID constants primitive change getters Long object field a primitive ? necessitates a lot boxing / unboxing | <START> public Long getId ( ) { <END> return VAR_1 ; } | public long getId ( ) { return VAR_1 ; } |
methods protected public accessed subclasses | <START> public void setText ( String input , TYPE_1 element ) { <END> element . VAR_1 ( ) ; element . clear ( ) ; element . VAR_2 ( input ) ; element . VAR_2 ( TYPE_2 . VAR_4 ) ; } | protected void setText ( String input , TYPE_1 element ) { element . VAR_1 ( ) ; element . clear ( ) ; element . VAR_2 ( input ) ; element . VAR_2 ( TYPE_2 . VAR_4 ) ; } |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.