ReviewComments stringlengths 1 2.35k | OriginalCode stringlengths 28 487 | ReviewedCode stringlengths 14 463 |
|---|---|---|
necessary scheduler hard - coded scan 15 minutes ? greater instead | public boolean METHOD_1 ( ) { <START> return ! VAR_1 . METHOD_2 ( ) . METHOD_3 ( ) && TYPE_1 . METHOD_4 ( VAR_2 , TYPE_2 . METHOD_5 ( ) ) . METHOD_6 ( ) < 10 ; <END> } | public boolean METHOD_1 ( ) { return ! VAR_1 . METHOD_2 ( ) . METHOD_3 ( ) && TYPE_1 . METHOD_4 ( VAR_2 , TYPE_2 . METHOD_5 ( ) ) . METHOD_6 ( ) > 10 ; } |
please remove checks VAR_3 ! = null ? lack cruft favourite parts services | public void METHOD_1 ( TYPE_1 VAR_1 ) throws IOException { VAR_2 . METHOD_2 ( VAR_1 ) ; if ( VAR_3 != null ) { if ( ! VAR_3 . remove ( VAR_1 ) ) { throw new IOException ( STRING_1 ) ; } } else { <START> throw new IOException ( STRING_2 ) ; <END> } } | public void METHOD_1 ( TYPE_1 VAR_1 ) throws IOException { VAR_2 . METHOD_2 ( VAR_1 ) ; if ( ! VAR_3 . remove ( VAR_1 ) ) { throw new IOException ( STRING_1 ) ; } } |
sacre bleu thees ? earth mees a sweet succulent _CODE_ | public Map < String , Integer > METHOD_1 ( ) throws IOException { if ( VAR_1 != null ) { return VAR_1 . METHOD_2 ( ) ; } else { <START> throw new IOException ( STRING_1 ) ; <END> } } | public Map < String , Integer > METHOD_1 ( ) throws IOException { return VAR_1 . METHOD_2 ( ) ; } |
/ VAR_1 / { id } | public TYPE_1 METHOD_1 ( ANNOTATION_1 TYPE_1 VAR_1 , TYPE_2 VAR_2 , TYPE_3 response ) throws IOException { Long id = VAR_3 . METHOD_2 ( TYPE_4 . to ( VAR_1 ) ) ; <START> TYPE_5 VAR_4 = VAR_2 . path ( STRING_1 ) . METHOD_3 ( id ) ; <END> response . VAR_5 ( STRING_2 , VAR_4 . METHOD_4 ( ) . toString ( ) ) ; return METHOD... | public TYPE_1 METHOD_1 ( ANNOTATION_1 TYPE_1 VAR_1 , TYPE_2 VAR_2 , TYPE_3 response ) throws IOException { Long id = VAR_3 . METHOD_2 ( TYPE_4 . to ( VAR_1 ) ) ; return METHOD_5 ( id ) ; } |
ideal clear repopulate TYPE_1 table V9000 test data migration s easier test exact controlled number _CODE_ making tests more lenient _CODE_ | public void METHOD_1 ( ) throws Exception { List < TYPE_1 > VAR_1 = VAR_2 . METHOD_2 ( ) ; <START> assertTrue ( VAR_1 . size ( ) > 0 ) ; <END> } | public void METHOD_1 ( ) throws Exception { List < TYPE_1 > VAR_1 = VAR_2 . METHOD_2 ( ) ; assertEquals ( 10 , VAR_1 . size ( ) ) ; } |
missed | public void METHOD_1 ( ) throws Exception { List < TYPE_1 > VAR_1 = VAR_2 . METHOD_2 ( ) ; <START> assertTrue ( VAR_1 . size ( ) > 0 ) ; <END> } | public void METHOD_1 ( ) throws Exception { List < TYPE_1 > VAR_1 = VAR_2 . METHOD_2 ( ) ; assertEquals ( 2 , VAR_1 . size ( ) ) ; } |
METHOD_2 called path | public void METHOD_1 ( TYPE_1 VAR_1 ) { METHOD_2 ( TYPE_2 . METHOD_3 ( VAR_1 , STRING_1 , getId ( ) ) ) ; METHOD_4 ( TYPE_2 . METHOD_3 ( VAR_1 , STRING_2 , METHOD_5 ( ) ) ) ; if ( METHOD_6 ( ) != null ) { METHOD_7 ( TYPE_2 . METHOD_3 ( VAR_1 , STRING_3 , METHOD_6 ( ) ) ) ; } <START> METHOD_2 ( TYPE_2 . METHOD_3 ( VAR_1... | public void METHOD_1 ( TYPE_1 VAR_1 ) { METHOD_2 ( TYPE_2 . METHOD_3 ( VAR_1 , STRING_1 , getId ( ) ) ) ; METHOD_4 ( TYPE_2 . METHOD_3 ( VAR_1 , STRING_2 , METHOD_5 ( ) ) ) ; if ( METHOD_6 ( ) != null ) { METHOD_7 ( TYPE_2 . METHOD_3 ( VAR_1 , STRING_3 , METHOD_6 ( ) ) ) ; } } |
a reason targeted sequencing set id isn t ? exception thrown | private void METHOD_1 ( TYPE_1 VAR_1 ) throws IOException { if ( VAR_1 . METHOD_2 ( ) != null ) { VAR_1 . METHOD_3 ( VAR_2 . get ( VAR_1 . METHOD_2 ( ) . getId ( ) ) ) ; } <START> if ( VAR_1 . METHOD_4 ( ) != null && VAR_1 . METHOD_4 ( ) . getId ( ) != null ) { <END> VAR_1 . METHOD_5 ( VAR_3 . get ( VAR_1 . METHOD_4 ( ... | private void METHOD_1 ( TYPE_1 VAR_1 ) throws IOException { if ( VAR_1 . METHOD_2 ( ) != null ) { VAR_1 . METHOD_3 ( VAR_2 . get ( VAR_1 . METHOD_2 ( ) . getId ( ) ) ) ; } if ( VAR_1 . METHOD_4 ( ) != null ) { VAR_1 . METHOD_5 ( VAR_3 . get ( VAR_1 . METHOD_4 ( ) . getId ( ) ) ) ; } } |
a field _CODE_ table purpose = concentration hard - coding exist DB temporarily | public void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) throws IOException { TYPE_1 VAR_3 = VAR_4 . get ( VAR_1 . getId ( ) ) ; VAR_5 . METHOD_2 ( VAR_3 ) ; VAR_2 . METHOD_3 ( VAR_5 . METHOD_4 ( ) ) ; <START> if ( STRING_1 . equals ( VAR_2 . METHOD_5 ( ) . getName ( ) ) ) { <END> VAR_3 . METHOD_6 ( VAR_2 . METHOD_7 ( ) ) ... | public void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) throws IOException { TYPE_1 VAR_3 = VAR_4 . get ( VAR_1 . getId ( ) ) ; VAR_5 . METHOD_2 ( VAR_3 ) ; VAR_2 . METHOD_3 ( VAR_5 . METHOD_4 ( ) ) ; VAR_6 . METHOD_8 ( VAR_2 ) ; VAR_4 . METHOD_8 ( VAR_1 ) ; } |
remove cast | public void METHOD_1 ( TYPE_1 < TYPE_2 > VAR_1 ) { <START> this . VAR_2 = ( TYPE_3 ) VAR_1 ; <END> } | public void METHOD_1 ( TYPE_1 < TYPE_2 > VAR_1 ) { this . VAR_2 = VAR_1 ; } |
remove line | public TYPE_3 ( TYPE_1 user ) { if ( user != null ) { VAR_2 = new TYPE_2 ( user ) ; <START> METHOD_1 ( ) . METHOD_2 ( ) ; <END> } } | public TYPE_3 ( TYPE_1 user ) { if ( user != null ) { VAR_2 = new TYPE_2 ( user ) ; } } |
s shouldn t comparing VAR_1 s ID TYPE_2 s | public long METHOD_1 ( TYPE_1 VAR_1 ) throws IOException { long id ; <START> if ( VAR_1 . getId ( ) == TYPE_2 . VAR_3 ) { <END> id = ( long ) METHOD_2 ( ) . METHOD_1 ( VAR_1 ) ; } else { METHOD_2 ( ) . update ( VAR_1 ) ; id = VAR_1 . getId ( ) ; } return id ; } | public long METHOD_1 ( TYPE_1 VAR_1 ) throws IOException { long id ; if ( VAR_1 . getId ( ) == TYPE_1 . VAR_3 ) { id = ( long ) METHOD_2 ( ) . METHOD_1 ( VAR_1 ) ; } else { METHOD_2 ( ) . update ( VAR_1 ) ; id = VAR_1 . getId ( ) ; } return id ; } |
s deletable s saved | public boolean METHOD_1 ( ) { <START> return VAR_1 == VAR_2 ; <END> } | public boolean METHOD_1 ( ) { return VAR_1 != VAR_2 ; } |
compilation errors | public void METHOD_1 ( ) { TYPE_1 VAR_1 = new TYPE_1 ( ) ; VAR_1 . METHOD_2 ( VAR_2 ) ; VAR_1 . METHOD_3 ( VAR_3 ) ; <START> VAR_1 . METHOD_4 ( VAR_4 ) ; <END> VAR_1 . METHOD_5 ( METHOD_6 ( ) ) ; VAR_1 . METHOD_7 ( VAR_5 ) ; VAR_1 . METHOD_8 ( VAR_6 ) ; METHOD_9 ( VAR_1 ) ; } | public void METHOD_1 ( ) { TYPE_1 VAR_1 = new TYPE_1 ( ) ; VAR_1 . METHOD_2 ( VAR_2 ) ; METHOD_9 ( VAR_1 ) ; } |
consider making relationship unidirectional instead _CODE_ useful ( edit sequencer page I d ) | public TYPE_1 get ( long id ) throws IOException { TYPE_1 VAR_1 = ( TYPE_1 ) METHOD_1 ( ) . get ( TYPE_2 . class , id ) ; TYPE_1 VAR_2 = METHOD_2 ( id ) ; if ( VAR_2 != null ) { <START> VAR_1 . METHOD_3 ( VAR_2 ) ; <END> } return VAR_1 ; } | public TYPE_1 get ( long id ) throws IOException { return ( TYPE_1 ) METHOD_1 ( ) . get ( TYPE_2 . class , id ) ; } |
rethrow IllegalArgumentException | public void METHOD_1 ( String VAR_1 ) { if ( VAR_1 == null ) { this . VAR_1 = null ; } else { try { TYPE_1 VAR_2 = TYPE_1 . METHOD_2 ( VAR_1 ) ; this . VAR_1 = ( VAR_2 != null ? VAR_2 . METHOD_3 ( ) : null ) ; } catch ( IOException e ) { log . error ( STRING_1 + VAR_1 , e ) ; <START> this . VAR_1 = null ; <END> } } } | public void METHOD_1 ( String VAR_1 ) { if ( VAR_1 == null ) { this . VAR_1 = null ; } else { try { TYPE_1 VAR_2 = TYPE_1 . METHOD_2 ( VAR_1 ) ; this . VAR_1 = ( VAR_2 != null ? VAR_2 . METHOD_3 ( ) : null ) ; } catch ( IOException e ) { log . error ( STRING_1 + VAR_1 , e ) ; throw new IllegalArgumentException ( STRING... |
potential NPE won t useful ID set ( migration ) append _CODE_ object base _CODE_ s METHOD_1 VAR_1 ( a unique key ) | public int METHOD_1 ( ) { return new TYPE_1 ( 5 , INT_1 ) . append ( VAR_1 ) . append ( description ) . append ( VAR_2 ) <START> . append ( VAR_3 . getId ( ) ) <END> . append ( VAR_4 ) . METHOD_2 ( ) ; } | public int METHOD_1 ( ) { return new TYPE_1 ( 5 , INT_1 ) . append ( VAR_1 ) . append ( description ) . append ( VAR_2 ) . append ( VAR_3 ) . append ( VAR_4 ) . METHOD_2 ( ) ; } |
method updating other objects dependencies project DAO doesn t belong _CODE_ method sets VAR_5 VAR_2 VAR_4 | private void METHOD_1 ( ) { if ( VAR_1 != null ) VAR_1 . METHOD_2 ( VAR_2 ) ; if ( VAR_3 != null ) VAR_3 . METHOD_3 ( VAR_2 ) ; <START> if ( VAR_4 != null ) VAR_4 . METHOD_4 ( VAR_5 ) ; <END> } | private void METHOD_1 ( ) { if ( VAR_1 != null ) VAR_1 . METHOD_2 ( VAR_2 ) ; if ( VAR_3 != null ) VAR_3 . METHOD_3 ( VAR_2 ) ; } |
shouldn t need ID anymore | private TYPE_1 METHOD_1 ( ) { TYPE_1 VAR_1 = new TYPE_2 ( ) ; VAR_1 . METHOD_2 ( STRING_1 ) ; <START> VAR_1 . METHOD_3 ( INT_1 ) ; <END> return VAR_1 ; } | private TYPE_1 METHOD_1 ( ) { TYPE_1 VAR_1 = new TYPE_2 ( ) ; VAR_1 . METHOD_2 ( STRING_1 ) ; return VAR_1 ; } |
return TYPE_1 METHOD_3 ( VAR_1 ) ; instead lookup | public Collection < String > METHOD_1 ( ) throws IOException { Collection < TYPE_1 > VAR_1 = VAR_2 . METHOD_2 ( ) ; if ( VAR_1 . size ( ) > 0 ) { <START> return TYPE_1 . METHOD_3 ( VAR_2 . METHOD_2 ( ) ) ; <END> } else { return VAR_2 . METHOD_4 ( ) ; } } | public Collection < String > METHOD_1 ( ) throws IOException { Collection < TYPE_1 > VAR_1 = VAR_2 . METHOD_2 ( ) ; if ( VAR_1 . size ( ) > 0 ) { return TYPE_1 . METHOD_3 ( VAR_1 ) ; } else { return VAR_2 . METHOD_4 ( ) ; } } |
consider adding a wildcard front string searching KGMT match KGMT_0015 searching 0015 query string escaped s currently SQL wildcards queries ( a general user ) searching %0015 match KGMT_0015 | public Collection < TYPE_1 > METHOD_1 ( String VAR_1 ) throws IOException { TYPE_2 VAR_2 = METHOD_2 ( ) . METHOD_3 ( TYPE_1 . class ) ; VAR_2 . add ( TYPE_3 . METHOD_4 ( TYPE_3 . METHOD_5 ( STRING_1 , VAR_1 + STRING_2 ) , TYPE_3 . METHOD_5 ( STRING_3 , VAR_1 + STRING_2 ) , <START> TYPE_3 . METHOD_5 ( STRING_4 , VAR_1 +... | public Collection < TYPE_1 > METHOD_1 ( String VAR_1 ) throws IOException { TYPE_2 VAR_2 = METHOD_2 ( ) . METHOD_3 ( TYPE_1 . class ) ; VAR_2 . add ( TYPE_3 . METHOD_4 ( TYPE_3 . METHOD_5 ( STRING_1 , STRING_2 + VAR_1 + STRING_2 ) , TYPE_3 . METHOD_5 ( STRING_3 , STRING_2 + VAR_1 + STRING_2 ) , TYPE_3 . METHOD_5 ( STRI... |
wrong place done _CODE_ method originally | private void METHOD_1 ( ) { if ( VAR_1 != null ) VAR_1 . METHOD_2 ( VAR_2 ) ; <START> METHOD_3 ( ) ; <END> } | private void METHOD_1 ( ) { if ( VAR_1 != null ) VAR_1 . METHOD_2 ( VAR_2 ) ; } |
int | public Integer METHOD_1 ( ) { <START> Integer VAR_1 = 0 ; <END> for ( TYPE_1 child : METHOD_2 ( ) ) { if ( child instanceof TYPE_2 && ( ( TYPE_2 ) child ) . METHOD_3 ( ) != null ) { VAR_1 += ( ( TYPE_2 ) child ) . METHOD_3 ( ) ; } } return ( METHOD_4 ( ) - METHOD_5 ( ) - VAR_1 ) ; } | public Integer METHOD_1 ( ) { int VAR_1 = 0 ; for ( TYPE_1 child : METHOD_2 ( ) ) { if ( child != null && child instanceof TYPE_2 && ( ( TYPE_2 ) child ) . METHOD_3 ( ) != null ) { VAR_1 += ( ( TYPE_2 ) child ) . METHOD_3 ( ) ; } } return ( METHOD_4 ( ) - METHOD_5 ( ) - VAR_1 ) ; } |
easier read : ( int i = 0 ; i < VAR_2 size ( ) ; + + i ) { ( i > 0 ) { VAR_3 append ( STRING_2 ) ; } VAR_3 append ( VAR_2 METHOD_3 ( i ) ) ; } | public String METHOD_1 ( ANNOTATION_1 TYPE_1 VAR_1 ) throws IOException { TYPE_2 VAR_2 = TYPE_2 . METHOD_2 ( VAR_1 . get ( STRING_1 ) ) ; TYPE_3 VAR_3 = new TYPE_3 ( ) ; for ( int i = 0 ; i < VAR_2 . size ( ) ; ++ i ) { VAR_3 . append ( VAR_2 . METHOD_3 ( i ) ) ; <START> if ( i + 1 < VAR_2 . size ( ) ) { <END> VAR_3 . ... | public String METHOD_1 ( ANNOTATION_1 TYPE_1 VAR_1 ) throws IOException { TYPE_2 VAR_2 = TYPE_2 . METHOD_2 ( VAR_1 . get ( STRING_1 ) ) ; TYPE_3 VAR_3 = new TYPE_3 ( ) ; for ( int i = 0 ; i < VAR_2 . size ( ) ; ++ i ) { if ( i > 0 ) VAR_3 . append ( STRING_2 ) ; VAR_3 . append ( VAR_2 . METHOD_3 ( i ) ) ; } return STRI... |
set method lines | public static TYPE_1 to ( TYPE_2 from ) { TYPE_1 to = new TYPE_3 ( ) ; to . VAR_1 ( from . VAR_2 ( ) ) ; to . VAR_3 ( from . VAR_4 ( ) ) ; to . VAR_5 ( from . VAR_6 ( ) ) ; to . VAR_7 ( from . VAR_8 ( ) ) ; to . VAR_9 ( from . VAR_10 ( ) ) ; to . VAR_5 ( from . VAR_6 ( ) ) ; <START> return to ; <END> } | public static TYPE_1 to ( TYPE_2 from ) { TYPE_1 to = new TYPE_3 ( ) ; to . VAR_1 ( from . VAR_2 ( ) ) ; to . VAR_3 ( from . VAR_4 ( ) ) ; to . VAR_5 ( from . VAR_6 ( ) ) ; to . VAR_7 ( from . VAR_8 ( ) ) ; to . VAR_9 ( from . VAR_10 ( ) ) ; return to ; } |
VAR_6 needs added _CODE_ | public String toString ( ) { return STRING_1 + VAR_1 + STRING_2 + VAR_2 + STRING_3 + VAR_3 + STRING_4 + VAR_4 + STRING_5 + VAR_5 + STRING_6 + id + STRING_7 + VAR_6 + STRING_8 + VAR_7 + STRING_9 + VAR_8 + STRING_10 + VAR_9 + STRING_11 + VAR_10 + STRING_12 + url + STRING_13 ; <START> } <END> | public String toString ( ) { return STRING_1 + VAR_1 + STRING_2 + VAR_2 + STRING_3 + VAR_3 + STRING_4 + VAR_4 + STRING_5 + VAR_5 + STRING_6 + id + STRING_8 + VAR_7 + STRING_9 + VAR_8 + STRING_10 + VAR_9 + STRING_11 + VAR_10 + STRING_12 + url + STRING_13 ; } |
setting dates handled METHOD_9 method required | private TYPE_1 METHOD_1 ( TYPE_2 project , TYPE_3 user ) { TYPE_1 VAR_1 ; VAR_1 = new TYPE_4 ( ) ; VAR_1 . METHOD_2 ( project ) ; VAR_1 . METHOD_3 ( 0 ) ; VAR_1 . METHOD_4 ( VAR_2 ) ; VAR_1 . METHOD_5 ( user ) ; VAR_1 . METHOD_6 ( user ) ; VAR_1 . METHOD_7 ( new Date ( ) ) ; <START> VAR_1 . METHOD_8 ( new Date ( ) ) ; ... | private TYPE_1 METHOD_1 ( TYPE_2 project , TYPE_3 user ) { TYPE_1 VAR_1 ; VAR_1 = new TYPE_4 ( ) ; VAR_1 . METHOD_2 ( project ) ; VAR_1 . METHOD_3 ( 0 ) ; VAR_1 . METHOD_4 ( VAR_2 ) ; VAR_1 . METHOD_5 ( user ) ; VAR_1 . METHOD_6 ( user ) ; METHOD_9 ( VAR_1 ) ; return VAR_1 ; } |
/ finally | public static String METHOD_1 ( String path ) { String result = "" ; TYPE_1 VAR_1 = new TYPE_1 ( TYPE_2 . class . METHOD_2 ( ) . METHOD_3 ( path ) ) ; while ( VAR_1 . METHOD_4 ( ) ) { result += VAR_1 . METHOD_5 ( ) ; } <START> VAR_1 . close ( ) ; <END> return result ; } | public static String METHOD_1 ( String path ) { String result = "" ; TYPE_1 VAR_1 = null ; try { VAR_1 = new TYPE_1 ( TYPE_2 . class . METHOD_2 ( ) . METHOD_3 ( path ) ) ; while ( VAR_1 . METHOD_4 ( ) ) { result += VAR_1 . METHOD_5 ( ) ; } VAR_1 . close ( ) ; } finally { if ( VAR_1 != null ) { VAR_1 . close ( ) ; } } r... |
superfluous instanceof false null a null bypasses instanceof checks returns null method | private static TYPE_1 METHOD_1 ( final Context context ) { <START> if ( context == null ) { <END> return null ; } else if ( context instanceof TYPE_1 ) { return ( TYPE_1 ) context ; } else if ( context instanceof TYPE_2 ) { return METHOD_1 ( ( ( TYPE_2 ) context ) . METHOD_2 ( ) ) ; } return null ; } | private static TYPE_1 METHOD_1 ( final Context context ) { if ( context instanceof TYPE_1 ) { return ( TYPE_1 ) context ; } else if ( context instanceof TYPE_2 ) { return METHOD_1 ( ( ( TYPE_2 ) context ) . METHOD_2 ( ) ) ; } return null ; } |
return List < TYPE_1 > | <START> public static TYPE_1 [ ] METHOD_1 ( ) { <END> final List < TYPE_1 > VAR_1 = new ArrayList < > ( ) ; for ( final TYPE_1 VAR_2 : VAR_3 ) { if ( VAR_2 . METHOD_2 ( ) ) { VAR_1 . add ( VAR_2 ) ; } } return VAR_1 . METHOD_3 ( new TYPE_1 [ VAR_1 . size ( ) ] ) ; } | public static List < TYPE_1 > METHOD_1 ( ) { final List < TYPE_1 > VAR_1 = new ArrayList < > ( ) ; for ( final TYPE_1 VAR_2 : VAR_3 ) { if ( VAR_2 . METHOD_2 ( ) ) { VAR_1 . add ( VAR_2 ) ; } } return VAR_1 ; } |
transformed statement | public boolean METHOD_1 ( final TYPE_1 item ) { <START> switch ( item . VAR_1 ( ) ) { <END> case VAR_2 . R . id . VAR_3 : METHOD_2 ( ) ; return true ; } return false ; } | public boolean METHOD_1 ( final TYPE_1 item ) { if ( item . VAR_1 ( ) == VAR_2 . R . id . VAR_3 ) { METHOD_2 ( ) ; return true ; } return false ; } |
rid condition ( null - initialization VAR_3 ) a - loop | static List < TYPE_1 > METHOD_1 ( ) { final List < TYPE_1 > VAR_1 = new ArrayList < > ( ) ; int VAR_2 = 0 ; TYPE_1 [ ] VAR_3 = null ; <START> while ( VAR_3 == null || VAR_3 . length == VAR_4 ) { <END> VAR_3 = METHOD_2 ( STRING_1 + VAR_4 + STRING_2 + VAR_2 , TYPE_1 [ ] . class ) . METHOD_3 ( ) ; VAR_1 . addAll ( Arrays ... | static List < TYPE_1 > METHOD_1 ( ) { final List < TYPE_1 > VAR_1 = new ArrayList < > ( ) ; int VAR_2 = 0 ; TYPE_1 [ ] VAR_3 ; do { VAR_3 = METHOD_2 ( STRING_1 + VAR_4 + STRING_2 + VAR_2 , TYPE_1 [ ] . class ) . METHOD_3 ( ) ; VAR_1 . addAll ( Arrays . asList ( VAR_3 ) ) ; VAR_2 += VAR_4 ; } while ( VAR_3 . length == V... |
s VAR_1 + + ; I mind proposed reference field | public void METHOD_1 ( ) { if ( VAR_1 >= 0 ) { <START> METHOD_2 ( VAR_1 + 1 ) ; <END> } } | public void METHOD_1 ( ) { if ( VAR_1 >= 0 ) { VAR_1 ++ ; } } |
proposal early returns easier understand : return ( ) executed line please change tojavaif ( VAR_1 = = null ) { return null ; } return new TYPE_1 ( new TYPE_3 ( VAR_1 ) ) ; | public static TYPE_1 METHOD_1 ( final String VAR_1 ) throws TYPE_2 { TYPE_1 VAR_2 = null ; if ( VAR_1 != null ) { VAR_2 = new TYPE_1 ( new TYPE_3 ( VAR_1 ) ) ; } <START> return VAR_2 ; <END> } | public static TYPE_1 METHOD_1 ( final String VAR_1 ) throws TYPE_2 { if ( VAR_1 == null ) { return null ; } return new TYPE_1 ( new TYPE_3 ( VAR_1 ) ) ; } |
final TYPE_1 VAR_1 = … | public TYPE_1 METHOD_1 ( ) throws TYPE_2 { <START> TYPE_1 VAR_1 = new TYPE_1 ( ) ; <END> VAR_1 . put ( STRING_1 , type . VAR_2 ( ) ) ; VAR_1 . put ( STRING_2 , VAR_3 ) ; VAR_1 . put ( STRING_3 , VAR_4 ) ; VAR_1 . put ( STRING_4 , VAR_5 ) ; return VAR_1 ; } | public TYPE_1 METHOD_1 ( ) throws TYPE_2 { final TYPE_1 VAR_1 = new TYPE_1 ( ) ; VAR_1 . put ( STRING_1 , type . VAR_2 ( ) ) ; VAR_1 . put ( STRING_2 , VAR_3 ) ; VAR_1 . put ( STRING_3 , VAR_4 ) ; VAR_1 . put ( STRING_4 , VAR_5 ) ; return VAR_1 ; } |
please add empty line methods | <START> public void METHOD_1 ( ) throws Exception { <END> VAR_1 . add ( VAR_2 ) ; VAR_3 . add ( VAR_4 ) ; VAR_5 . add ( VAR_4 ) ; final Set < TYPE_1 > VAR_6 = TYPE_2 . METHOD_2 ( VAR_7 ) ; assertThat ( VAR_6 . size ( ) ) . METHOD_3 ( 0 ) ; assertThat ( VAR_6 . contains ( VAR_8 ) ) . METHOD_4 ( ) ; assertThat ( VAR_6 . ... | public void METHOD_1 ( ) { VAR_1 . add ( VAR_2 ) ; VAR_3 . add ( VAR_4 ) ; VAR_5 . add ( VAR_4 ) ; final Set < TYPE_1 > VAR_6 = TYPE_2 . METHOD_2 ( VAR_7 ) ; assertThat ( VAR_6 . size ( ) ) . METHOD_3 ( 0 ) ; assertThat ( VAR_6 . contains ( VAR_8 ) ) . METHOD_4 ( ) ; assertThat ( VAR_6 . contains ( VAR_9 ) ) . METHOD_4... |
- fix string %d instead %s - implicit toString ( ) jobrather calling String valueOf explicitly | private void METHOD_1 ( ) { if ( TYPE_1 . METHOD_2 ( cache ) . METHOD_3 ( cache , VAR_1 ) ) { if ( VAR_2 > 0 ) { VAR_3 . METHOD_4 ( View . VAR_4 ) ; <START> VAR_3 . setText ( getString ( R . string . VAR_5 , String . valueOf ( VAR_2 ) ) ) ; <END> } } else { VAR_3 . METHOD_4 ( View . VAR_6 ) ; } } | private void METHOD_1 ( ) { if ( TYPE_1 . METHOD_2 ( cache ) . METHOD_3 ( cache , VAR_1 ) ) { if ( VAR_2 > 0 ) { VAR_3 . METHOD_4 ( View . VAR_4 ) ; VAR_3 . setText ( getString ( R . string . VAR_5 , VAR_2 ) ) ; } } else { VAR_3 . METHOD_4 ( View . VAR_6 ) ; } } |
purpose method change | <START> private void METHOD_1 ( ) { <END> METHOD_2 ( TYPE_6 . VAR_2 ) ; TYPE_1 . METHOD_3 ( this ) ; res = this . METHOD_4 ( ) ; VAR_3 = ( TYPE_2 ) this . METHOD_5 ( ) ; TYPE_3 . METHOD_6 ( TYPE_4 . METHOD_7 ( ) ) ; TYPE_5 . METHOD_8 ( this , VAR_4 ) ; } | private void METHOD_1 ( ) { res = this . METHOD_4 ( ) ; VAR_3 = ( TYPE_2 ) this . METHOD_5 ( ) ; TYPE_3 . METHOD_6 ( TYPE_4 . METHOD_7 ( ) ) ; TYPE_5 . METHOD_8 ( this , VAR_4 ) ; } |
I Log e ( ) return null ; | protected TYPE_1 METHOD_1 ( ) throws IOException { try { return VAR_1 . METHOD_2 ( uri ) ; } catch ( final TYPE_2 e ) { if ( uri . toString ( ) . startsWith ( STRING_1 ) ) { return TYPE_3 . METHOD_3 ( TYPE_3 . METHOD_4 ( uri . toString ( ) ) ) ; } <START> Log . e ( STRING_2 + uri ) ; <END> } return null ; } | protected TYPE_1 METHOD_1 ( ) throws IOException { try { return VAR_1 . METHOD_2 ( uri ) ; } catch ( final TYPE_2 e ) { if ( uri . toString ( ) . startsWith ( STRING_1 ) ) { return TYPE_3 . METHOD_3 ( TYPE_3 . METHOD_4 ( uri . toString ( ) ) ) ; } } Log . e ( STRING_2 + uri ) ; return null ; } |
please avoid boxed primitives | public void METHOD_1 ( final TYPE_1 VAR_1 ) { if ( VAR_2 == null ) { VAR_2 = new ArrayList < TYPE_1 > ( ) ; } <START> Boolean VAR_3 = false ; <END> for ( final TYPE_1 VAR_4 : VAR_2 ) { if ( VAR_4 . METHOD_2 ( ) . equals ( VAR_1 . METHOD_2 ( ) ) ) { VAR_3 = true ; VAR_4 . METHOD_3 ( VAR_1 ) ; break ; } } if ( ! VAR_3 ) ... | public void METHOD_1 ( final TYPE_1 VAR_1 ) { if ( VAR_2 == null ) { VAR_2 = new ArrayList < > ( ) ; } Boolean VAR_3 = false ; for ( final TYPE_1 VAR_4 : VAR_2 ) { if ( VAR_4 . METHOD_2 ( ) . equals ( VAR_1 . METHOD_2 ( ) ) ) { VAR_3 = true ; VAR_4 . METHOD_3 ( VAR_1 ) ; break ; } } if ( ! VAR_3 ) { VAR_2 . add ( VAR_1... |
list set null ? soon _CODE_ ( ) called _CODE_ called a _CODE_ loop _CODE_ ( ) called singleton ? case null instead singleton ? I m I follow logic | public TYPE_1 ( ) { this . VAR_2 = null ; <START> this . list = null ; <END> } | public TYPE_1 ( ) { VAR_2 = null ; list = new ArrayList < > ( ) ; } |
final | public static List < TYPE_1 > parse ( final TYPE_2 page ) { try { <START> TYPE_3 VAR_1 = TYPE_3 . METHOD_1 ( ) ; <END> TYPE_4 VAR_2 = VAR_1 . METHOD_2 ( ) ; TYPE_5 VAR_3 = VAR_2 . METHOD_3 ( ) ; final TYPE_6 VAR_4 = new TYPE_6 ( ) ; VAR_3 . METHOD_4 ( VAR_4 ) ; VAR_3 . parse ( page ) ; return VAR_4 . METHOD_5 ( ) ; } c... | public static List < TYPE_1 > parse ( final TYPE_2 page ) { try { final TYPE_3 VAR_1 = TYPE_3 . METHOD_1 ( ) ; final TYPE_4 VAR_2 = VAR_1 . METHOD_2 ( ) ; final TYPE_5 VAR_3 = VAR_2 . METHOD_3 ( ) ; final TYPE_6 VAR_4 = new TYPE_6 ( ) ; VAR_3 . METHOD_4 ( VAR_4 ) ; VAR_3 . parse ( page ) ; return VAR_4 . METHOD_5 ( ) ;... |
public | <START> public static boolean METHOD_1 ( final List < TYPE_1 > VAR_1 , List < TYPE_1 > VAR_2 ) { <END> if ( VAR_2 != null && ! VAR_2 . isEmpty ( ) ) { for ( final TYPE_1 log : VAR_2 ) { if ( VAR_1 . contains ( log ) ) { VAR_1 . get ( VAR_1 . METHOD_2 ( log ) ) . VAR_3 = true ; } else { log . VAR_3 = true ; VAR_1 . add ... | private static boolean METHOD_1 ( final List < TYPE_1 > VAR_1 , List < TYPE_1 > VAR_2 ) { if ( VAR_2 != null && ! VAR_2 . isEmpty ( ) ) { for ( final TYPE_1 log : VAR_2 ) { if ( VAR_1 . contains ( log ) ) { VAR_1 . get ( VAR_1 . METHOD_2 ( log ) ) . VAR_3 = true ; } else { VAR_1 . add ( log ) ; } } return true ; } retu... |
line replaced single linejavareturn cache ! = null ? new TYPE_1 ( cache ) : null ; | public TYPE_1 METHOD_1 ( final String VAR_1 , final String VAR_2 , final TYPE_2 VAR_3 ) { TYPE_2 . METHOD_2 ( VAR_3 , R . string . VAR_4 ) ; final TYPE_3 cache = TYPE_4 . METHOD_3 ( VAR_1 ) ; <START> if ( cache == null ) { <END> return null ; } final TYPE_1 VAR_5 = new TYPE_1 ( cache ) ; return VAR_5 ; } | public TYPE_1 METHOD_1 ( final String VAR_1 , final String VAR_2 , final TYPE_2 VAR_3 ) { TYPE_2 . METHOD_2 ( VAR_3 , R . string . VAR_4 ) ; final TYPE_3 cache = TYPE_4 . METHOD_3 ( VAR_1 ) ; return cache != null ? new TYPE_1 ( cache ) : null ; } |
please create useless variables more readable : javareturn TYPE_6 METHOD_1 ( cache VAR_1 VAR_2 log ) ; | public final TYPE_1 METHOD_1 ( final TYPE_2 cache , final TYPE_3 VAR_1 , final TYPE_4 VAR_2 , final String log , final String VAR_3 , final List < TYPE_5 > VAR_4 ) { <START> final TYPE_1 result = TYPE_6 . METHOD_1 ( cache , VAR_1 , VAR_2 , log ) ; <END> return result ; } | public final TYPE_1 METHOD_1 ( final TYPE_2 cache , final TYPE_3 VAR_1 , final TYPE_4 VAR_2 , final String log , final String VAR_3 , final List < TYPE_5 > VAR_4 ) { return TYPE_6 . METHOD_1 ( cache , VAR_1 , VAR_2 , log ) ; } |
shorterjavareturn response ! = null ? METHOD_2 ( response false ) : null ; | public static String METHOD_1 ( ANNOTATION_1 final TYPE_1 response ) { if ( response == null ) { return null ; } <START> return METHOD_2 ( response , false ) ; <END> } | public static String METHOD_1 ( ANNOTATION_1 final TYPE_1 response ) { return response != null ? METHOD_2 ( response , false ) : null ; } |
else transformed a simple assignment | public void METHOD_1 ( TYPE_1 < String > VAR_1 , String page ) { if ( page == null ) { VAR_2 = true ; } else { VAR_3 = TYPE_2 . METHOD_2 ( page ) ; VAR_4 = TYPE_3 . METHOD_3 ( page ) ; VAR_5 = TYPE_3 . METHOD_4 ( page ) ; <START> if ( VAR_5 . isEmpty ( ) ) { <END> VAR_2 = true ; } else { VAR_2 = false ; } } VAR_6 . MET... | public void METHOD_1 ( TYPE_1 < String > VAR_1 , String page ) { if ( page == null ) { VAR_2 = true ; } else { VAR_3 = TYPE_2 . METHOD_2 ( page ) ; VAR_4 = TYPE_3 . METHOD_3 ( page ) ; VAR_5 = TYPE_3 . METHOD_4 ( page ) ; VAR_2 = VAR_5 . isEmpty ( ) ; } VAR_6 . METHOD_1 ( ) ; } |
method written asjavapublic static void METHOD_1 ( String [ ] VAR_1 ) { METHOD_2 ( Arrays asList ( VAR_1 ) 0 ) ; } | public static void METHOD_1 ( String [ ] VAR_1 ) { ArrayList < String > VAR_2 = new ArrayList < String > ( ) ; for ( int i = 0 ; i < VAR_1 . length ; i ++ ) { VAR_2 . add ( VAR_1 [ i ] ) ; } METHOD_2 ( VAR_2 , 0 ) ; <START> } <END> | public static void METHOD_1 ( String [ ] VAR_1 ) { METHOD_2 ( Arrays . asList ( VAR_1 ) , 0 ) ; } |
I m confused fields ( geocodes error _CODE_ ) copied new TYPE_1 ( VAR_2 ) constructor wouldn t | public TYPE_1 METHOD_1 ( ) { VAR_1 = true ; if ( VAR_2 == null ) { VAR_2 = METHOD_2 ( ) ; } else { TYPE_1 VAR_3 = new TYPE_1 ( VAR_2 ) ; VAR_3 . METHOD_3 ( VAR_2 . METHOD_4 ( ) ) ; <START> VAR_3 . METHOD_5 ( VAR_2 . METHOD_6 ( ) ) ; <END> VAR_2 = TYPE_2 . METHOD_7 ( VAR_3 , TYPE_3 . METHOD_8 ( ) , this ) ; } VAR_1 = fa... | public TYPE_1 METHOD_1 ( ) { VAR_1 = true ; if ( VAR_2 == null ) { VAR_2 = METHOD_2 ( ) ; } else { VAR_2 = TYPE_2 . METHOD_7 ( new TYPE_1 ( VAR_2 ) , TYPE_3 . METHOD_8 ( ) , this ) ; } VAR_1 = false ; return VAR_2 ; } |
read easier others splitting check guards style : ( METHOD_2 METHOD_3 ( ) ) { return false ; } ( TYPE_1 METHOD_4 ( ) = = null ) { return false ; } return true ; want ask : isn t original code more compact optimized ? compiler create basically binary code versions besides differences binary don t matter code optimized r... | public boolean METHOD_1 ( ) { <START> return ! METHOD_2 ( ) . METHOD_3 ( ) <END> && null != TYPE_1 . METHOD_4 ( ) ; } | public boolean METHOD_1 ( ) { if ( METHOD_2 ( ) . METHOD_3 ( ) ) { return false ; } if ( null == TYPE_1 . METHOD_4 ( ) ) { return false ; } return true ; } |
bejavareturn VAR_1 = = null ; I wrote semantics questionable… | public boolean METHOD_1 ( TYPE_1 VAR_1 ) { if ( VAR_1 == null ) { return true ; } <START> return false ; <END> } | public boolean METHOD_1 ( TYPE_1 VAR_1 ) { return VAR_1 == null ; } |
synchronized ? IMHO stopped times wish | <START> public synchronized void METHOD_1 ( ) { <END> VAR_1 = true ; } | public void METHOD_1 ( ) { VAR_1 = true ; } |
I removed empty constructor ( 0|0 ) doesn t sense possibilities : - set valid coordinates ( preferred ) - set VAR_8 null check | public VAR_1 ( final TYPE_1 VAR_2 , TYPE_2 VAR_3 , final TYPE_3 VAR_4 , final TYPE_4 VAR_5 ) { super ( VAR_2 ) ; context = VAR_2 ; VAR_6 = VAR_3 ; VAR_7 = VAR_5 ; if ( VAR_4 != null ) { VAR_8 = VAR_4 ; } else if ( VAR_7 != null && VAR_7 . VAR_9 != null && VAR_7 . VAR_10 != null ) { VAR_8 = new TYPE_3 ( VAR_7 . VAR_9 , ... | public VAR_1 ( final TYPE_1 VAR_2 , TYPE_2 VAR_3 , final TYPE_3 VAR_4 , final TYPE_4 VAR_5 ) { super ( VAR_2 ) ; context = VAR_2 ; VAR_6 = VAR_3 ; VAR_7 = VAR_5 ; if ( VAR_4 != null ) { VAR_8 = VAR_4 ; } else if ( VAR_7 != null && VAR_7 . VAR_9 != null && VAR_7 . VAR_10 != null ) { VAR_8 = new TYPE_3 ( VAR_7 . VAR_9 , ... |
unnecessary parenthesis | protected TYPE_1 METHOD_1 ( String query ) throws TYPE_2 { <START> return ( connection . VAR_1 ( query ) ) ; <END> } | protected TYPE_1 METHOD_1 ( String query ) throws TYPE_2 { return connection . VAR_1 ( query ) ; } |
a handle exception a more _CODE_ - y example : update I ll merge straightaway : code great thanks ; ) | <START> public void METHOD_1 ( ) { <END> TYPE_1 d = METHOD_2 ( ) ; d . get ( STRING_1 ) ; try { TYPE_2 VAR_1 = d . VAR_2 ( TYPE_3 . METHOD_3 ( STRING_2 ) ) ; METHOD_4 ( ) ; } catch ( TYPE_4 e ) { } } | public void METHOD_1 ( ) { TYPE_1 d = METHOD_2 ( ) ; d . get ( STRING_1 ) ; TYPE_2 VAR_1 = d . VAR_2 ( TYPE_3 . METHOD_3 ( STRING_2 ) ) ; } |
shouldn t normalized _CODE_ constructor | public void METHOD_1 ( final TYPE_1 VAR_1 ) { try { <START> VAR_1 . getMessage ( ) . toString ( ) ; <END> final TYPE_2 m = TYPE_2 . METHOD_2 ( ) ; m . VAR_2 = VAR_3 ; m . obj = VAR_1 ; VAR_4 . METHOD_3 ( m ) ; } catch ( TYPE_3 e ) { TYPE_4 . e ( VAR_5 , STRING_1 , e ) ; } } | public void METHOD_1 ( final TYPE_1 VAR_1 ) { final TYPE_2 m = TYPE_2 . METHOD_2 ( ) ; m . VAR_2 = VAR_3 ; m . obj = VAR_1 ; VAR_4 . METHOD_3 ( m ) ; } |
s unclear invalid 0 valid s a string I d recommend a bit more specific potentially tests invalid clear expectations | public void METHOD_1 ( ) { final TYPE_1 VAR_1 = new TYPE_1 ( ) ; VAR_1 . METHOD_2 ( STRING_1 , STRING_2 ) ; <START> VAR_1 . METHOD_2 ( STRING_3 , STRING_4 ) ; <END> VAR_2 . METHOD_3 ( VAR_1 ) ; METHOD_4 ( VAR_3 , METHOD_5 ( ) ) . METHOD_6 ( METHOD_7 ( Integer . VAR_4 ) ) ; } | public void METHOD_1 ( ) { final TYPE_1 VAR_1 = new TYPE_1 ( ) ; VAR_1 . METHOD_2 ( STRING_1 , STRING_2 ) ; VAR_1 . METHOD_2 ( STRING_3 , 0 ) ; VAR_2 . METHOD_3 ( VAR_1 ) ; METHOD_4 ( VAR_3 , METHOD_5 ( ) ) . METHOD_6 ( METHOD_7 ( Integer . VAR_4 ) ) ; } |
t more specific METHOD_4 METHOD_5 ( TYPE_3 TYPE_4 VAR_7 ) | public void METHOD_1 ( ) { final TYPE_1 VAR_1 = new TYPE_1 ( ) ; VAR_1 . METHOD_2 ( STRING_1 , STRING_2 ) ; TYPE_2 VAR_2 = VAR_3 . METHOD_3 ( VAR_1 ) ; <START> METHOD_4 ( VAR_4 ) . METHOD_5 ( METHOD_6 ( ) ) ; <END> assertEquals ( VAR_2 . METHOD_7 ( ) , TYPE_3 . TYPE_4 . VAR_7 ) ; } | public void METHOD_1 ( ) { final TYPE_1 VAR_1 = new TYPE_1 ( ) ; VAR_1 . METHOD_2 ( STRING_1 , STRING_2 ) ; TYPE_2 VAR_2 = VAR_3 . METHOD_3 ( VAR_1 ) ; METHOD_4 ( VAR_4 ) . METHOD_5 ( TYPE_3 . TYPE_4 . VAR_7 ) ; assertEquals ( VAR_2 . METHOD_7 ( ) , TYPE_3 . TYPE_4 . VAR_7 ) ; } |
return VAR_2 ( url ) need create a local var | protected TYPE_1 METHOD_1 ( String url ) { TYPE_2 is = new TYPE_2 ( context , STRING_1 ) ; try { TYPE_1 VAR_1 = is . VAR_2 ( url ) ; <START> return VAR_1 ; <END> } catch ( TYPE_2 . TYPE_4 e ) { return null ; } } | protected TYPE_1 METHOD_1 ( String url ) { TYPE_2 is = new TYPE_2 ( context , STRING_1 ) ; try { return is . VAR_2 ( url ) ; } catch ( TYPE_2 . TYPE_4 e ) { return null ; } } |
repeat question I test code set VAR_6 0 | protected void METHOD_1 ( TYPE_1 data ) { <START> if ( TYPE_2 . VAR_2 . VAR_3 >= TYPE_2 . VAR_4 . VAR_5 && data . VAR_6 > 0 ) { <END> builder . VAR_7 ( data . VAR_6 ) ; } } | protected void METHOD_1 ( TYPE_1 data ) { if ( data . VAR_6 > 0 ) { builder . VAR_7 ( data . VAR_6 ) ; } } |
suggestion / * package * / TYPE_1 METHOD_1 ( TYPE_2 uri ) { | <START> protected TYPE_1 METHOD_1 ( TYPE_2 uri ) { <END> return new TYPE_1 ( TYPE_1 . VAR_1 , uri ) ; } | TYPE_1 METHOD_1 ( TYPE_2 uri ) { return new TYPE_1 ( TYPE_1 . VAR_1 , uri ) ; } |
want check a timed event return 0 case 👍 | public double METHOD_1 ( final String VAR_1 ) { final long VAR_2 = System . currentTimeMillis ( ) ; long VAR_3 ; synchronized ( VAR_4 ) { <START> VAR_3 = VAR_4 . get ( VAR_1 ) ; <END> } return ( double ) ( ( VAR_2 - VAR_3 ) / INT_1 ) ; } | public double METHOD_1 ( final String VAR_1 ) { final long VAR_2 = System . currentTimeMillis ( ) ; Long VAR_3 ; synchronized ( VAR_4 ) { VAR_3 = VAR_4 . get ( VAR_1 ) ; } return VAR_3 == null ? 0 : ( double ) ( ( VAR_2 - VAR_3 ) / INT_1 ) ; } |
stackoverflow post 4 people suggesting TYPE_7 TYPE_13 equals ( STRING_2 ) library : worth include | private boolean METHOD_1 ( ) { return TYPE_7 . TYPE_9 . startsWith ( STRING_1 ) <START> || TYPE_7 . TYPE_9 . startsWith ( STRING_2 ) <END> || TYPE_7 . TYPE_12 . contains ( STRING_3 ) || TYPE_7 . TYPE_12 . contains ( STRING_4 ) || TYPE_7 . TYPE_12 . contains ( STRING_5 ) || TYPE_7 . TYPE_13 . contains ( STRING_6 ) || ( ... | private boolean METHOD_1 ( ) { return TYPE_7 . TYPE_9 . startsWith ( STRING_1 ) || TYPE_7 . TYPE_9 . startsWith ( STRING_2 ) || TYPE_7 . TYPE_12 . contains ( STRING_3 ) || TYPE_7 . TYPE_12 . contains ( STRING_4 ) || TYPE_7 . TYPE_12 . contains ( STRING_5 ) || TYPE_7 . TYPE_13 . contains ( STRING_6 ) || ( TYPE_7 . TYPE_... |
I a fan null a meaningful change behavior / flow product instance VAR_1 empty TYPE_1 VAR_1 VAR_4 device empty VAR_1 | private void METHOD_1 ( TYPE_1 VAR_1 ) { final TYPE_2 VAR_2 = METHOD_2 ( ) ; final TYPE_2 . TYPE_4 VAR_3 = VAR_2 . METHOD_3 ( ) ; <START> if ( VAR_1 != null ) { <END> VAR_3 . METHOD_4 ( VAR_4 , VAR_1 . toString ( ) ) ; } else { VAR_3 . remove ( VAR_4 ) ; } VAR_3 . apply ( ) ; METHOD_5 ( ) ; } | private void METHOD_1 ( TYPE_1 VAR_1 ) { final TYPE_2 VAR_2 = METHOD_2 ( ) ; final TYPE_2 . TYPE_4 VAR_3 = VAR_2 . METHOD_3 ( ) ; if ( VAR_1 . length ( ) > 0 ) { VAR_3 . METHOD_4 ( VAR_4 , VAR_1 . toString ( ) ) ; } else { VAR_3 . remove ( VAR_4 ) ; } VAR_3 . apply ( ) ; METHOD_5 ( ) ; } |
VAR_11 null | public TYPE_7 ( String token , TYPE_1 listener , TYPE_2 VAR_2 ) { VAR_3 = token ; VAR_4 = listener ; VAR_5 = VAR_2 ; VAR_6 = null ; VAR_7 = new TYPE_3 < TYPE_4 > ( ) ; VAR_8 = new TYPE_3 < TYPE_5 > ( ) ; VAR_9 = new HashSet < Integer > ( ) ; VAR_10 = new HashSet < Integer > ( ) ; <START> if ( VAR_11 == null ) { <END> V... | public TYPE_7 ( String token , TYPE_1 listener , TYPE_2 VAR_2 ) { VAR_3 = token ; VAR_4 = listener ; VAR_5 = VAR_2 ; VAR_6 = null ; VAR_7 = new TYPE_3 < TYPE_4 > ( ) ; VAR_8 = new TYPE_3 < TYPE_5 > ( ) ; VAR_9 = new HashSet < Integer > ( ) ; VAR_10 = new HashSet < Integer > ( ) ; VAR_11 = new TYPE_6 ( ) ; } |
TYPE_1 e | public String METHOD_1 ( ) { String VAR_1 = null ; try { VAR_1 = ( String ) VAR_2 ; <START> } catch ( TYPE_1 VAR_3 ) { <END> ; } try { VAR_1 = ( String ) value ; } catch ( TYPE_1 e ) { ; } return VAR_1 ; } | public String METHOD_1 ( ) { String VAR_1 = null ; try { VAR_1 = ( String ) VAR_2 ; } catch ( TYPE_1 e ) { ; } try { VAR_1 = ( String ) value ; } catch ( TYPE_1 e ) { ; } return VAR_1 ; } |
I m worried rethrow crash app TYPE_3 shouldn t a runtime error | public void run ( ) { if ( ! VAR_1 ) { return ; } final View VAR_2 = VAR_3 . get ( ) ; if ( null == VAR_2 || VAR_4 ) { METHOD_1 ( ) ; return ; } try { VAR_5 . METHOD_2 ( VAR_2 ) ; } catch ( TYPE_2 . TYPE_3 e ) { METHOD_1 ( ) ; <START> throw e ; <END> } VAR_6 . METHOD_3 ( this ) ; VAR_6 . METHOD_4 ( this , INT_1 ) ; } | public void run ( ) { if ( ! VAR_1 ) { return ; } final View VAR_2 = VAR_3 . get ( ) ; if ( null == VAR_2 || VAR_4 ) { METHOD_1 ( ) ; return ; } VAR_5 . METHOD_2 ( VAR_2 ) ; VAR_6 . METHOD_3 ( this ) ; VAR_6 . METHOD_4 ( this , INT_1 ) ; } |
great | public void METHOD_1 ( View VAR_1 ) { <START> if ( VAR_2 ) { <END> super . METHOD_2 ( ) . METHOD_3 ( VAR_1 , super . getPath ( ) , this ) ; } } | public void METHOD_1 ( View VAR_1 ) { if ( VAR_2 ) { METHOD_2 ( ) . METHOD_3 ( VAR_1 , getPath ( ) , this ) ; } } |
METHOD_2 ( ) _CODE_ ( ) ? I current logic call necessary register listeners | <START> public void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) { <END> METHOD_2 ( VAR_1 ) ; } | public void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) { } |
I _CODE_ shared tokens multiple tokens overwrite token ll writing device ids wrong project please check | public static TYPE_1 getInstance ( Context context , String token ) { TYPE_1 instance = VAR_1 . get ( token ) ; if ( instance == null ) { instance = new TYPE_1 ( context . VAR_2 ( ) , token ) ; VAR_1 . put ( token , instance ) ; } <START> instance . VAR_3 . METHOD_1 ( ) . METHOD_2 ( STRING_1 , token ) . commit ( ) ; <E... | public static TYPE_1 getInstance ( Context context , String token ) { TYPE_1 instance = VAR_1 . get ( token ) ; if ( instance == null ) { instance = new TYPE_1 ( context . VAR_2 ( ) , token ) ; VAR_1 . put ( token , instance ) ; } return instance ; } |
annotation public removed | <START> public void METHOD_1 ( List < String > properties ) { <END> this . properties = properties ; } | void METHOD_1 ( List < String > properties ) { this . properties = properties ; } |
configuration files small stream sufficiently large warrant bufferred reading approach simply reading stream ? eventually reading stream memory _CODE_ similar | private String METHOD_1 ( TYPE_1 in ) { try { TYPE_2 result = new TYPE_2 ( ) ; byte [ ] buffer = new byte [ INT_1 ] ; int length ; <START> while ( ( length = in . read ( buffer ) ) != - 1 ) { <END> result . write ( buffer , 0 , length ) ; } return result . toString ( TYPE_6 . TYPE_5 . name ( ) ) ; } catch ( IOException... | private String METHOD_1 ( TYPE_1 in ) { try { TYPE_2 result = new TYPE_2 ( ) ; byte [ ] buffer = new byte [ INT_1 ] ; int length ; while ( ( length = in . read ( buffer ) ) != - 1 ) { result . write ( buffer , 0 , length ) ; } return result . toString ( TYPE_5 . name ( ) ) ; } catch ( IOException e ) { throw new TYPE_4... |
I don t throws checked exceptions drop throws Exception | <START> private TYPE_1 < TYPE_2 > METHOD_1 ( TYPE_3 VAR_1 ) throws Exception { <END> TYPE_4 VAR_2 = new TYPE_5 ( ) ; VAR_2 . METHOD_2 ( new TYPE_6 ( ) ) ; return VAR_2 . METHOD_3 ( VAR_1 ) . METHOD_4 ( ( ) - > VAR_1 . VAR_3 . METHOD_5 ( VAR_1 . METHOD_6 ( ) ) ) ; } | private TYPE_1 < TYPE_2 > METHOD_1 ( TYPE_3 VAR_1 ) { TYPE_4 VAR_2 = new TYPE_5 ( ) ; VAR_2 . METHOD_2 ( new TYPE_6 ( ) ) ; return VAR_2 . METHOD_3 ( VAR_1 ) . METHOD_4 ( ( ) - > VAR_1 . VAR_3 . METHOD_5 ( VAR_1 . METHOD_6 ( ) ) ) ; } |
nice avoid creating key object class access private VAR_1 add stuff VAR_1 VAR_3 VAR_1 values alternatively create a private method private void add ( long timestamp ) { } call method I private method a cleaner | public void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) { VAR_1 . clear ( ) ; for ( int i = 0 ; i < VAR_3 . size ( ) ; i ++ ) { long time = VAR_3 . get ( i ) ; if ( VAR_2 . METHOD_2 ( time ) ) { <START> VAR_1 . add ( new TYPE_3 ( key . VAR_4 ( ) , time ) , values . get ( i ) ) ; <END> } } } | public void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) { VAR_1 . clear ( ) ; if ( key != null ) { VAR_1 . key = new TYPE_3 ( key ) ; } for ( int i = 0 ; i < VAR_3 . size ( ) ; i ++ ) { long time = VAR_3 . get ( i ) ; if ( VAR_2 . METHOD_2 ( time ) ) { VAR_1 . add ( time , values . get ( i ) ) ; } } } |
_CODE_ suggesting method reference : : METHOD_3 ( ) - > METHOD_3 ( ) | private synchronized void METHOD_1 ( ) { <START> VAR_1 . METHOD_2 ( ( ) - > METHOD_3 ( ) , VAR_2 , TimeUnit . VAR_3 ) ; <END> VAR_2 = Math . VAR_4 ( VAR_5 , ( long ) ( FLOAT_1 * VAR_2 ) + ( long ) ( VAR_2 * Math . VAR_6 ( ) ) ) ; } | private synchronized void METHOD_1 ( ) { VAR_1 . METHOD_2 ( this : : METHOD_3 , VAR_2 , TimeUnit . VAR_3 ) ; VAR_2 = Math . VAR_4 ( VAR_5 , ( long ) ( FLOAT_1 * VAR_2 ) + ( long ) ( VAR_2 * Math . VAR_6 ( ) ) ) ; } |
: _CODE_ | private synchronized void METHOD_1 ( ) { <START> VAR_1 . METHOD_2 ( ( ) - > METHOD_3 ( ) , 0 , TimeUnit . VAR_2 ) ; <END> } | private synchronized void METHOD_1 ( ) { VAR_1 . METHOD_2 ( this : : METHOD_3 , 0 , TimeUnit . VAR_2 ) ; } |
private | <START> public void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) throws Exception { <END> if ( VAR_3 < VAR_2 . METHOD_2 ( ) ) { METHOD_3 ( VAR_1 ) ; } else { METHOD_4 ( ) . METHOD_5 ( VAR_2 . METHOD_6 ( ) ) ; METHOD_7 ( VAR_1 , VAR_2 . METHOD_6 ( ) ) ; } } | private void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) throws Exception { if ( VAR_3 < VAR_2 . METHOD_2 ( ) ) { METHOD_3 ( VAR_1 ) ; } else { METHOD_4 ( ) . METHOD_5 ( VAR_2 . METHOD_6 ( ) ) ; METHOD_7 ( VAR_1 , VAR_2 . METHOD_6 ( ) ) ; } } |
methods class need public package local | <START> public TYPE_1 < TYPE_2 > METHOD_1 ( Collection < TYPE_3 > VAR_1 ) { <END> if ( VAR_1 . size ( ) == 0 ) { return TYPE_4 . METHOD_2 ( null ) ; } TYPE_5 < TYPE_2 > VAR_2 = TYPE_5 . create ( VAR_3 , null ) ; try { TYPE_6 VAR_4 = new TYPE_6 ( VAR_1 , VAR_2 ) ; VAR_5 . put ( VAR_4 ) ; return VAR_2 ; } catch ( Excepti... | TYPE_1 < TYPE_2 > METHOD_1 ( Collection < TYPE_3 > VAR_1 ) { if ( VAR_1 . size ( ) == 0 ) { return TYPE_4 . METHOD_2 ( null ) ; } TYPE_5 < TYPE_2 > VAR_2 = TYPE_5 . create ( VAR_3 , null ) ; try { TYPE_6 VAR_4 = new TYPE_6 ( VAR_1 , VAR_2 ) ; VAR_5 . put ( VAR_4 ) ; return VAR_2 ; } catch ( Exception e ) { throw new Ru... |
public part API ? I thinking methods implementation part API support | <START> public TYPE_1 METHOD_1 ( String VAR_1 , int value ) { <END> TYPE_2 . METHOD_2 ( value > 0 , VAR_1 + STRING_1 ) ; METHOD_3 ( VAR_1 , value ) ; return this ; } | private TYPE_1 METHOD_1 ( String VAR_1 , int value ) { TYPE_2 . METHOD_2 ( value > 0 , VAR_1 + STRING_1 ) ; METHOD_3 ( VAR_1 , value ) ; return this ; } |
return VAR_1 substring ( VAR_2 ) trim ( ) remove trailing whitespace | public static String METHOD_1 ( String VAR_1 ) { int VAR_2 = VAR_1 . METHOD_2 ( STRING_1 ) ; if ( VAR_2 != - 1 ) { <START> return VAR_1 . substring ( VAR_2 ) ; <END> } return STRING_1 ; } | public static String METHOD_1 ( String VAR_1 ) { int VAR_2 = VAR_1 . METHOD_2 ( STRING_1 ) ; if ( VAR_2 != - 1 ) { return VAR_1 . substring ( VAR_2 ) . trim ( ) ; } return STRING_1 ; } |
creating a separate put method environment parameter avoid null | public TYPE_1 put ( TYPE_2 VAR_1 , TYPE_3 value ) { <START> TYPE_4 . put ( null , VAR_2 , VAR_1 , TYPE_6 . VAR_4 | 0 , value . VAR_5 ( ) ) ; <END> TYPE_4 . put ( null , VAR_2 , VAR_1 , TYPE_6 . VAR_6 | 1 , TYPE_5 . METHOD_1 ( 0 , false , false ) ) ; return this ; } | public TYPE_1 put ( TYPE_2 VAR_1 , TYPE_3 value ) { TYPE_4 . put ( VAR_2 , VAR_1 , TYPE_6 . VAR_4 | 0 , value . VAR_5 ( ) ) ; TYPE_4 . put ( VAR_2 , VAR_1 , TYPE_6 . VAR_6 | 1 , TYPE_5 . METHOD_1 ( 0 , false , false ) ) ; return this ; } |
synchronizing object changes sync blocks good | public Long METHOD_1 ( ) { <START> synchronized ( status ) { <END> TYPE_1 . METHOD_2 ( status != TYPE_2 . VAR_2 , STRING_1 ) ; if ( ( status == TYPE_2 . VAR_3 ) && ( node == null ) ) { Long VAR_4 = METHOD_3 ( ) ; if ( node == null ) { METHOD_4 ( VAR_4 ) ; } } Long VAR_5 = METHOD_3 ( ) ; VAR_6 . add ( VAR_5 ) ; status =... | public synchronized long METHOD_1 ( ) { TYPE_1 . METHOD_2 ( status != TYPE_2 . VAR_2 , STRING_1 ) ; if ( ( status == TYPE_2 . VAR_3 ) && ( node == null ) ) { long VAR_4 = METHOD_3 ( ) ; if ( node == null ) { METHOD_4 ( VAR_4 ) ; } } long VAR_5 = METHOD_3 ( ) ; VAR_6 . add ( VAR_5 ) ; status = TYPE_2 . VAR_7 ; return VA... |
thinking some more zknode deleted ( state set VAR_3 ) lock held detected ? retry ? alternative retrying increment allocating counter block decrement sync block code deletes node allocating counter > 0 another alternative a read - write lock | public long METHOD_1 ( ) { synchronized ( this ) { TYPE_1 . METHOD_2 ( status != TYPE_2 . VAR_2 , STRING_1 ) ; if ( ( status == TYPE_2 . VAR_3 ) && ( node == null ) ) { Long VAR_4 = METHOD_3 ( ) ; if ( node == null ) { METHOD_4 ( VAR_4 ) ; } } } long VAR_5 = METHOD_3 ( ) ; synchronized ( this ) { <START> VAR_6 . add ( ... | public synchronized long METHOD_1 ( ) { TYPE_1 . METHOD_2 ( status != TYPE_2 . VAR_2 , STRING_1 ) ; if ( ( status == TYPE_2 . VAR_3 ) && ( node == null ) ) { long VAR_4 = METHOD_3 ( ) ; if ( node == null ) { METHOD_4 ( VAR_4 ) ; } } long VAR_5 = METHOD_3 ( ) ; VAR_6 . add ( VAR_5 ) ; status = TYPE_2 . VAR_7 ; return VA... |
nicemaybe finally | <START> public void METHOD_1 ( ) throws TYPE_1 { <END> commit ( ) ; close ( ) ; } | public void METHOD_1 ( ) throws TYPE_1 { try { commit ( ) ; } finally { close ( ) ; } } |
sense modify usage cache transactors timed exist transactions _CODE_ timeout newer transactions timeout needs occur timeout cache updated a newer time prevent rollbacks continuing occur transactors slow started function correctly | public boolean METHOD_1 ( Long VAR_1 ) { <START> if ( VAR_2 . METHOD_2 ( VAR_1 ) != null ) <END> return false ; return cache . VAR_3 ( TYPE_1 . METHOD_3 ( config , VAR_1 ) ) != null ; } | public boolean METHOD_1 ( Long VAR_1 ) { return cache . VAR_3 ( TYPE_1 . METHOD_3 ( config , VAR_1 ) ) != null ; } |
unrelated issue VAR_2 method synchronized | <START> public void METHOD_1 ( ) throws Exception { <END> if ( VAR_1 ) { server . VAR_2 ( ) ; VAR_3 . METHOD_2 ( ) ; VAR_1 = false ; VAR_4 = null ; if ( VAR_5 . METHOD_3 ( ) . equals ( TYPE_1 . VAR_7 ) ) { VAR_8 . METHOD_4 ( ) . METHOD_5 ( this ) ; VAR_8 . close ( ) ; VAR_9 . close ( ) ; VAR_5 . METHOD_6 ( ) . METHOD_5... | public synchronized void METHOD_1 ( ) throws Exception { if ( VAR_1 ) { server . VAR_2 ( ) ; VAR_3 . METHOD_2 ( ) ; VAR_1 = false ; VAR_4 = null ; if ( VAR_5 . METHOD_3 ( ) . equals ( TYPE_1 . VAR_7 ) ) { VAR_8 . METHOD_4 ( ) . METHOD_5 ( this ) ; VAR_8 . close ( ) ; VAR_9 . close ( ) ; VAR_5 . METHOD_6 ( ) . METHOD_5 ... |
want bucket doesn t start upper case character s naming restrictions mentioned [ ] ( ) | public static String METHOD_1 ( final TYPE_1 config , final TYPE_2 client , final String VAR_1 , final String VAR_2 ) { if ( STRING_1 . equals ( VAR_2 ) ) { if ( TYPE_3 . METHOD_2 ( METHOD_3 ( config , client ) ) ) { return METHOD_4 ( config , VAR_1 ) ; } else { throw new TYPE_4 ( STRING_2 ) ; } } <START> return TYPE_5... | public static String METHOD_1 ( final TYPE_1 config , final TYPE_2 client , final String VAR_1 , final String VAR_2 ) throws IOException { if ( STRING_1 . equals ( VAR_2 ) ) { if ( TYPE_3 . METHOD_2 ( METHOD_3 ( config , client ) ) ) { return METHOD_4 ( config , VAR_1 ) ; } else { throw new TYPE_4 ( STRING_2 ) ; } } re... |
I raw enum simpler | public void METHOD_1 ( ) { <START> final TYPE_1 VAR_1 = TYPE_1 . VAR_2 ; <END> final TYPE_1 VAR_3 = TYPE_1 . VAR_4 ; final TYPE_1 VAR_5 = TYPE_1 . VAR_6 ; final TYPE_1 VAR_7 = TYPE_1 . METHOD_2 ( STRING_1 ) ; final TYPE_1 VAR_8 = TYPE_1 . METHOD_2 ( STRING_2 ) ; final TYPE_1 VAR_9 = TYPE_1 . METHOD_2 ( STRING_3 ) ; Ass... | public void METHOD_1 ( ) { final TYPE_1 VAR_7 = TYPE_1 . METHOD_2 ( STRING_1 ) ; final TYPE_1 VAR_8 = TYPE_1 . METHOD_2 ( STRING_2 ) ; final TYPE_1 VAR_9 = TYPE_1 . METHOD_2 ( STRING_3 ) ; Assert . assertEquals ( VAR_7 , VAR_2 ) ; Assert . assertEquals ( VAR_8 , VAR_4 ) ; Assert . assertEquals ( VAR_9 , VAR_6 ) ; } |
iterator | public void METHOD_1 ( ) throws IOException , TYPE_1 { final Iterator < TYPE_2 > i = TYPE_3 . iterator ( ) ; <START> while ( i . hasNext ( ) ) { <END> final TYPE_2 VAR_1 = i . next ( ) ; METHOD_2 ( VAR_1 ) ; } } | public void METHOD_1 ( ) throws IOException , TYPE_1 { for ( final TYPE_2 VAR_1 : TYPE_3 ) { METHOD_2 ( VAR_1 ) ; } } |
s good handle 0 case TYPE_3 s easier maintainer check VAR_3 = = null || VAR_3 = = 0 ( fact isn t null means unboxing safe ) | void METHOD_1 ( final String VAR_1 , final TYPE_1 VAR_2 , final Integer VAR_3 ) throws IOException { TYPE_2 . METHOD_2 ( VAR_1 , STRING_1 ) ; String path = METHOD_3 ( VAR_1 ) ; <START> if ( VAR_3 == null ) { <END> LOG . debug ( STRING_2 , path ) ; VAR_4 . METHOD_4 ( path , VAR_2 ) ; } else { TYPE_3 . METHOD_5 ( this , ... | void METHOD_1 ( final String VAR_1 , final TYPE_1 VAR_2 , final Integer VAR_3 ) throws IOException { TYPE_2 . METHOD_2 ( VAR_1 , STRING_1 ) ; String path = METHOD_3 ( VAR_1 ) ; if ( VAR_3 == null || VAR_3 == 0 ) { LOG . debug ( STRING_2 , path ) ; VAR_4 . METHOD_4 ( path , VAR_2 ) ; } else { TYPE_3 . METHOD_5 ( this , ... |
( guava actual formal annotation ) | <START> private static long [ ] METHOD_1 ( final Long [ ] VAR_1 , <END> final TYPE_1 VAR_2 ) { final long VAR_3 = VAR_2 . METHOD_2 ( ) ; final long VAR_4 ; final long VAR_5 ; if ( VAR_1 [ 0 ] == null ) { VAR_4 = INT_1 ; } else { VAR_4 = VAR_1 [ 0 ] ; } if ( VAR_1 [ 1 ] == null ) { VAR_5 = VAR_3 ; } else { VAR_5 = VAR_1... | static long [ ] METHOD_1 ( final Long [ ] VAR_1 , final TYPE_1 VAR_2 ) { final long VAR_3 = VAR_2 . METHOD_2 ( ) ; final long VAR_4 ; final long VAR_5 ; if ( VAR_1 [ 0 ] == null ) { VAR_4 = INT_1 ; } else { VAR_4 = VAR_1 [ 0 ] ; } if ( VAR_1 [ 1 ] == null ) { VAR_5 = VAR_3 ; } else { VAR_5 = VAR_1 [ 1 ] ; } return new ... |
declared scope loop | private void METHOD_1 ( ) { TYPE_1 VAR_1 = new TYPE_1 ( ) ; int iterator , VAR_2 ; <START> Object VAR_3 ; <END> for ( iterator = VAR_4 . length - 1 ; iterator > 0 ; iterator -- ) { VAR_2 = VAR_1 . METHOD_2 ( iterator ) ; VAR_3 = VAR_4 [ iterator ] ; VAR_4 [ iterator ] = VAR_4 [ VAR_2 ] ; VAR_4 [ VAR_2 ] = VAR_3 ; } } | private void METHOD_1 ( ) { TYPE_1 VAR_1 = new TYPE_1 ( ) ; for ( int VAR_2 = 0 , iterator = VAR_4 . length - 1 ; iterator > 0 ; iterator -- ) { VAR_2 = VAR_1 . METHOD_2 ( iterator ) ; Object VAR_3 = VAR_4 [ iterator ] ; VAR_4 [ iterator ] = VAR_4 [ VAR_2 ] ; VAR_4 [ VAR_2 ] = VAR_3 ; } } |
check generated range instead checking s limit values : assertTrue ( new TYPE_2 ( STRING_3 ) METHOD_3 ( VAR_2 ) > = 1 ) ; assertTrue ( new TYPE_2 ( STRING_4 ) METHOD_3 ( VAR_2 ) < = INT_1 ) ; | public void METHOD_1 ( ) { TYPE_1 VAR_1 = new TYPE_1 ( TYPE_2 . class , new TYPE_3 ( 1 , INT_1 ) ) ; TYPE_2 VAR_2 = VAR_1 . METHOD_2 ( ) ; assertNotNull ( STRING_1 , VAR_2 ) ; assertTrue ( STRING_2 , VAR_2 instanceof TYPE_2 ) ; <START> assertTrue ( new TYPE_2 ( STRING_3 ) . METHOD_3 ( VAR_2 ) != 1 ) ; <END> assertTrue ... | public void METHOD_1 ( ) { TYPE_1 VAR_1 = new TYPE_1 ( TYPE_2 . class , new TYPE_3 ( 1 , INT_1 ) ) ; TYPE_2 VAR_2 = VAR_1 . METHOD_2 ( ) ; assertNotNull ( STRING_1 , VAR_2 ) ; assertTrue ( STRING_2 , VAR_2 instanceof TYPE_2 ) ; assertTrue ( VAR_2 . METHOD_3 ( new TYPE_2 ( STRING_3 ) ) >= 0 ) ; assertTrue ( VAR_2 . METH... |
put METHOD_2 line | public void METHOD_1 ( ) throws TYPE_1 { TYPE_2 VAR_1 = <START> new TYPE_2 . Builder ( ) . METHOD_2 ( METHOD_3 ( STRING_1 ) ) <END> . METHOD_2 ( METHOD_3 ( STRING_2 ) ) . METHOD_2 ( METHOD_3 ( STRING_3 ) ) . METHOD_2 ( METHOD_3 ( STRING_4 ) ) . METHOD_2 ( METHOD_3 ( STRING_5 ) ) . METHOD_2 ( METHOD_3 ( STRING_6 ) ) . M... | public void METHOD_1 ( ) { TYPE_2 VAR_1 = new TYPE_2 . Builder ( ) . METHOD_2 ( METHOD_3 ( STRING_1 ) ) . METHOD_2 ( METHOD_3 ( STRING_2 ) ) . METHOD_2 ( METHOD_3 ( STRING_3 ) ) . METHOD_2 ( METHOD_3 ( STRING_4 ) ) . METHOD_2 ( METHOD_3 ( STRING_5 ) ) . METHOD_2 ( METHOD_3 ( STRING_6 ) ) . METHOD_2 ( METHOD_3 ( STRING_... |
a syntax error | public boolean METHOD_1 ( TYPE_1 VAR_1 , int x , int y , int VAR_2 ) { for ( TYPE_2 element : VAR_3 ) { <START> if ( ! TYPE_4 . VAR_5 . METHOD_2 ( VAR_1 , new TYPE_3 ( + element . x , y + element . y , VAR_2 + element . VAR_2 ) ) ) <END> return false ; } return true ; } | public boolean METHOD_1 ( TYPE_1 VAR_1 , int x , int y , int VAR_2 ) { for ( TYPE_2 element : VAR_3 ) { if ( ! TYPE_4 . VAR_5 . METHOD_2 ( VAR_1 , new TYPE_3 ( x + element . x , y + element . y , VAR_2 + element . VAR_2 ) ) ) return false ; } return true ; } |
TYPE_1 METHOD_2 ( TYPE_3 VAR_3 TYPE_3 VAR_2 ) ; I pass parameters | private void METHOD_1 ( Path from , Path to ) throws IOException { try { <START> TYPE_1 . METHOD_2 ( from , to , TYPE_3 . VAR_2 ) ; <END> } catch ( TYPE_2 e ) { TYPE_1 . METHOD_2 ( from , to , TYPE_3 . VAR_3 ) ; } } | private void METHOD_1 ( Path from , Path to ) throws IOException { try { TYPE_1 . METHOD_2 ( from , to , TYPE_3 . VAR_2 , TYPE_3 . VAR_3 ) ; } catch ( TYPE_2 e ) { TYPE_1 . METHOD_2 ( from , to , TYPE_3 . VAR_3 ) ; } } |
inverted | public boolean METHOD_1 ( char VAR_1 , int VAR_2 ) { if ( METHOD_2 ( ) && this . METHOD_3 ( ) && VAR_1 == CHAR_1 ) { return true ; <START> METHOD_4 ( false ) ; <END> } return super . METHOD_1 ( VAR_1 , VAR_2 ) ; } | public boolean METHOD_1 ( char VAR_1 , int VAR_2 ) { if ( METHOD_2 ( ) && this . METHOD_3 ( ) && VAR_1 == CHAR_1 ) { METHOD_4 ( false ) ; return true ; } return super . METHOD_1 ( VAR_1 , VAR_2 ) ; } |
needs discussed clarified point case semantic missing happen removed check rules I remove ( test ) | public void METHOD_1 ( TYPE_1 VAR_1 ) { <START> if ( ! METHOD_2 ( ) ) { return ; } <END> String VAR_2 = ( ( TYPE_2 ) VAR_1 ) . METHOD_3 ( ) . METHOD_4 ( ) . METHOD_5 ( ) ; if ( TYPE_3 . containsKey ( VAR_2 ) ) { METHOD_6 ( VAR_1 , String . format ( STRING_1 , VAR_2 , TYPE_3 . get ( VAR_2 ) ) ) ; } } | public void METHOD_1 ( TYPE_1 VAR_1 ) { String VAR_2 = ( ( TYPE_2 ) VAR_1 ) . METHOD_3 ( ) . METHOD_4 ( ) . METHOD_5 ( ) ; if ( TYPE_3 . containsKey ( VAR_2 ) ) { METHOD_6 ( VAR_1 , String . format ( STRING_1 , VAR_2 , TYPE_3 . get ( VAR_2 ) ) ) ; } } |
test condition leads FP bad resolving VAR_2 symbol I prefer replace METHOD_2 _CODE_ : wink : | public void METHOD_1 ( TYPE_1 VAR_1 ) { <START> if ( METHOD_2 ( VAR_1 , VAR_2 ) && TYPE_2 . METHOD_3 ( VAR_1 ) && METHOD_4 ( VAR_1 . METHOD_5 ( ) . get ( 0 ) ) ) { <END> this . VAR_3 = true ; } super . METHOD_1 ( VAR_1 ) ; } | public void METHOD_1 ( TYPE_1 VAR_1 ) { if ( METHOD_2 ( VAR_1 , VAR_2 , true ) && TYPE_2 . METHOD_3 ( VAR_1 ) && METHOD_4 ( VAR_1 . METHOD_5 ( ) . get ( 0 ) ) ) { this . VAR_3 = true ; } super . METHOD_1 ( VAR_1 ) ; } |
string TYPE_2 ( ) | protected List < TYPE_1 > METHOD_1 ( ) { return Collections . VAR_1 ( TYPE_1 . create ( ) <START> . METHOD_2 ( TYPE_2 . is ( STRING_1 ) ) <END> . name ( STRING_2 ) . METHOD_3 ( ) ) ; } | protected List < TYPE_1 > METHOD_1 ( ) { return Collections . VAR_1 ( TYPE_1 . create ( ) . METHOD_2 ( STRING_1 ) . name ( STRING_2 ) . METHOD_3 ( ) ) ; } |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.