fix mask and position bug for batch generation

#35

by qingsonglv - opened Apr 10, 2023

←

Knowledge Engineering Group (KEG) & Data Mining at Tsinghua University org Apr 10, 2023

No description provided.

Apr 11, 2023

这里确实是有问题的，batch的时候，官方没有修复这个bug。你的修改了之后训练起来还有问题吗？

Knowledge Engineering Group (KEG) & Data Mining at Tsinghua University org Apr 11, 2023

•

训练是不受影响的，因为训练没有left pad，只是inference有影响。batch size=1的chat函数应该也没有影响，只有不定长batch generation的时候有影响。

Knowledge Engineering Group (KEG) & Data Mining at Tsinghua University org Apr 11, 2023

看起来是我这边测试的问题，其实是没有bug的……

qingsonglv changed pull request status to closed Apr 11, 2023

Upload images, audio, and videos by dragging in the text input, pasting, or clicking here.

Tap or paste here to upload images

· Sign up or log in to comment