Add `clip_sample=False` to scheduler to make model compatible with DDIM.

#1
by patrickvonplaten - opened

Hey imjunaidafzal πŸ‘‹,

Your model repository seems to contain a stable diffusion checkpoint. We have noticed that your scheduler config currently does not correctly work with the DDIMScheduler because clip_sample is not set to False and will therefore incorrectly default to True.
The official stable diffusion checkpoints have clip_sample=False so that the scheduler config works will all schedulers, see: https://huggingface.co/stabilityai/stable-diffusion-2-1-base/blob/main/scheduler/scheduler_config.json#L7.

We strongly recommend that you merge this PR to make sure your model works correctly with DDIM.

Diffusingly,
Patrick.

imjunaidafzal changed pull request status to merged

Hey imjunaidafzal πŸ‘‹,

Your model repository seems to contain a stable diffusion checkpoint. We have noticed that your scheduler config currently does not correctly work with the DDIMScheduler because clip_sample is not set to False and will therefore incorrectly default to True.
The official stable diffusion checkpoints have clip_sample=False so that the scheduler config works will all schedulers, see: https://huggingface.co/stabilityai/stable-diffusion-2-1-base/blob/main/scheduler/scheduler_config.json#L7.

We strongly recommend that you merge this PR to make sure your model works correctly with DDIM.

Diffusingly,
Patrick.

Hey thanks! for the advise. I merged the required changes.

Sign up or log in to comment