Hi,

The reason I changed the unless is because I am using cloudfront from aws
and it inputs the "accept_oracle_download_terms": "true", and this will
fail the check. This will work if I correct the unless statement.

This change is because I didn't find a way to interpret a string to
boolean.

Thanks for the help.
Simão


On Aug 24, 2013 12:06 AM, "dpetzel" <notifications@github.com> wrote:

> In recipes/server.rb:
>
> > @@ -22,8 +22,8 @@ class Chef::Recipe
> >   include ZenossHelper
> >  end
> >
> > -unless node['java']['oracle']['accept_oracle_download_terms'] == true
> > -  Chef::log.error("You have not accepted the Java License Agreement" +
> > +unless node['java']['oracle']['accept_oracle_download_terms'] == true || node['java']['oracle']['accept_oracle_download_terms'] == "true"
>
> Thanks for catching the typo! Is there a specific reason we should allow
> the string value of "true" instead of just the boolean? Looking through the
> Java cookbook documentation and source I don't see any references that says
> a string of "true" is an acceptable value so I wonder if we should be
> blazing a new trail here, or just stick to the boolean forms?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/ZCA/zenoss-chef-cookbook/pull/12/files#r5963316>
> .
>