params is already set