labofsahil/github-event-dataset-2012 huggingface dataset:
Fixes an incorrect libmemcached version check for OPT_PREFIX_KEY

The PREFIX_KEY functionality had a comment explaining that a bug
had to be worked around, in all version prior to 0.50.  However,
that assumption was invalid, as the memcached_set_prefix_key()
behavior was only rewritten in version 0.49.  Since the error was
fixed in libmemcached-0.50, that means it only exists in one version:
0.49.

I tested this fix against every release between 0.44 - 0.50, and
confirmed that the bug only has to be worked around in *exactly*
version 0.49.

The simple test:

    [terminalA] $ nc -l localhost 5555

    [terminalB] $ php -a
    php > $mc = new Memcached();
    php > $mc->addServer('localhost', 5555, 1);
    php > $mc->setOption(Memcached::OPT_PREFIX_KEY, 'foo');
    php > $mc->set('bar', 1, 15);

I saw "foo0bar" coming through in version 0.44 - 0.48. The problem
was fixed in 0.49 and 0.50.
Updated class to be compatible with ARC

Since AFNetworking went to ARC with 1.0, I tweaked this class to be work with ARC as well.
Modif Noms Fichiers
Posts method
Quick fix for jQuery 1.8 for outerHeight 

Just adds boolean parameter to outerHeight for jQuery 1.8+.   Returns an object otherwise.
removed all .DS_Store files

I removed all the .DS_Store files that were scattered throughout the project.
fixed glyphicons path for bootstrap plugin 2.1.1

sorry, forgot to add that to the last pull request
Bug#1705

Principaux chgt sur la page d'accueil du composant impactant sur les looks :
- les id categoryLeft et categoryRight ont été transformé en class
- Les id ViewAllClassifiedsByCategory et newClassified  ont été transformé en class
Added ca-cert location for debians
Added access to elements that observable is bound to and some events V1.0

I forgot to say in my first request, great work! I love this extension for knockout!

Here is one based on v1.0. I closed the other pull request.

I made this change to be able to access the element(s) that the observable is bound to so I can use qtip to display the messages on validation error instead of inserting it right next to it.

The events are needed so I can fire off a function when it is all done, onValidationStart and onValidationError.

If you have any questions or better ways of implementing let me know. Or if you don't feel comfortable pulling this in I understand. Just though it might be useful to some as it was to me.

Thanks!
Kaleb
Stop spamming the log if debug mode isn't on

This replaces all prints with xbmc.log calls with different severities. Also did some cosmetics like renaming paths and shares to sources and some consistency with string quotation and building.
Do NOT trim values returned from Ogone

Extra spaces in the $_GET values need to be included when calculating SHA hash to compare to the hash calculated on their end. With these trim() calls in, a handful of valid payments were marked as failed on our end because we calculated a different SHA. For example, some of these came from people who left a trailing space on the credit card name field, and Ogone doesn't trim it.
correct service_name behavior and add service_type option

this corrects the service_name to look at the name from the service catalog. Also adds an option to change the service_type. Finally, included some tests to validate the service catalog parsing.
Trivially allow the plugin to act as an AMD module under RequireJS etc.

Plugin authors are widely adapting their plugins to work as AMD modules,
particularly now that jQuery itself is AMD-compatible. This small change
makes this plugin work either as normal, or as an AMD module when used in
such an environment (e.g. RequireJS).

Info about AMD: https://github.com/amdjs/amdjs-api/wiki/AMD

Handy module templates: https://github.com/umdjs/umd
Adding "::" before to ensure correct top level namespace

I edited all instances of Rails::* to ::Rails::*.  I don't think this should cause any problems. I know that it fixed the problems I was encountering.

Hope this helps.
Починка обновления

Для бранча master
Style update

Fix various style updates. Fixes various style issues.
French Version of the article
Brazilian portuguese version initiated. 

Sending an initial translation from english to brazilian / portuguese.
siniestros
Added package.xml + localization de_CH & en_GB

Created package.xml with package information.
Modified JS + PHP for package.xml version information
Created localization for de_CH + en_GB

package.xml is good for showing version information of the plugin in the "About" section in roundcube
Fix submodel filtering.

Fix the issue pointed out by @oparadis in sonata-project/SonataAdminBundle#696 when filtering on ``association1.association2``.
Ss

vv
Switching out for direct Authorize usage since django-merchant doesn't handle subscriptions very well.
fuix bugs
changed sys to util

changed `require('sys')` to `require('util')` I left the sys variable as... it is for compatibility reasons with the code.
PLFM-1590

This is the PLFM side of PLFM-1590, the migration of OpenID from PLFM to SWC.
Add Translation support to the config's
Fix for ubuntu playback & import issues

The problem seemed to be that x86_64 versions were using 32 bit gstreamer libs. I don't think that anyone using a 32 bit version of Ubuntu would have encountered this because of the way build.sh was previously, but even on a 64 bit version, there were still 32 bit gstreamer libs located in /usr/lib/i386-linux-gnu. This was making nightingale load those instead of the ones in /usr/lib/x86_64-linux-gnu.

This was a quick fix but it works, so I figured I'd send in a pull request before anyone wasted any time trying to debug it.
Added a call to transaction.commit_unless_managed() to ensure rows actua...

This is a small change to address this issue: https://github.com/stefanfoulis/django-graceful-session-cleanup/issues/6

What do you think?

Cheers,
Dan
Pressflow updates
Added missing cmake dependencies for glut, libXmu and libXi

Fixed Redmine issue #68
Corregidos errores varios ortográficos.

Corregí varios tipos de errores ortográficos (como errores de tipeo, errores de tipo de voz, etcétera).
Added require line to initializer

See discussion here:

https://gist.github.com/1214011/7ffaa86636e5b5b1fe872f9273834373c58f7ab6
Bugfix/last child on delete

/cc @joshdrake @adamfast
Corrected For the Style Guide And Some Little Changes

So I made the amendments, and also have removed jb.url as it jquery already has a get feature. I have removed the contents of now playing as I am working on integrating jplayer into it.  

I moved all the JavaScript code into externals sheets as I believe this will help with ensuring that code quality and will make things more modular. The code is in the head tag and not in the html tag. From the testing I did there is little/no difference in performance.
Dev

Update files
とりあえず

一応ゲームルール画面という事で存在させておこうかと思います。
Support for SugarCRM 6.3

Hi, so here it is. It should work quite well now. I fixed few glitches and on my installation it works well. I tried it on SugarCRM 6.1.7 and it looks ok, so it probably should be backward compatible.

I am sure, that style modifications could be made better - i am really not big friend with web technologies ;-).

Someone should test it on latest SugarCRM, i am not working with latest wersion because of strange problems with Module Loader (but it can be problems with my setup).

I am sure, that it needs more testing, but I will work with Sugar templated, so if I discover any problems I will push it to my branch and make another pull request.

Leszek
Fluid 4628 - Modified menu item "Body/techniques/something?" to "Techniques"

This pull request should be merged into "mediawiki-1.18.1" branch which is an mediawiki upgrade branch that hasn't been merged into "master" yet. The IDLH production is currently built upon this branch.
SEGV at Menu#createItem()

This is code at Menu.java (of SWT):
```Java
TCHAR buffer = new TCHAR (0, " ", true);
int byteCount = buffer.length () * TCHAR.sizeof;
```
If TCHAR class constructed by `terminate = true`, it will make space of '\0'. 
Therefore, buffer.length() is 2. 


```D
StringT buffer = StrToTCHARs (0, " \0");
int byteCount = (buffer.length-1) * TCHAR.sizeof;
```
`buffer.length-1` of this code must be `buffer.length`. (buffer.length is 2)

An error occur occasionally in an environment of low on memory.
Genome reference

A new table 'genome_reference' that autopopulates on default the genomic data found in the metadactyl conf/genome_reference.json file into the DE postgres database.
Fix incorrect align attribute in garbage.dd example.
Client request objects

This is not 100% done yet. There may be more to be done on the OIDCSignedRequestFilter, as the exchange between this and the request object endpoint still fails.
warming up :D
Feature/usermessages

Hi,

You can find the templating for usermessages page, including composing page, message detail, and inbox page.

Some functionnalities are missing (search engine, etc...)

TODO for Alex : 
-messages search engine in the top greybar
-previous / next messages buttons
-modify the multiple recipients fonctionnality to follow mockups (point to discuss ?)

See herve's mockups for each functionnality
CIRCLE CIRCLE DOT DOT

Now you have your pokerus shot.
Pull Req: Fixes 30, 31, and 32 issues.

This fixes #30, #31 and #32 bugs.
Support deleting comments
Clear upload when form is not valid. 

[Bugfix] Clear upload when form is not valid. 

TODO: Reselect files when form is not valid.
Gennaro
2e fichier
Should keep people from pushing .pyc compiled python files to repo.
Firstly - "In-game messages", not "messages in-game"
Secondly, I disagree with Karl: Messages involve, not messages involves. Both can't be plural.
Ya like I said I had to send all of my commits.  If you can reject this one but except the others that would be better.
no const here?
@Nielsomat makes sense. I'm just obsessively allergic to feature bloat :).
@radar  I've tracked the Spree errors to this commit.  Going to see if I can fix this to work properly, but reverting it will fix the broken specs.

@joneslee85 maybe you can weigh in with a fix before I get to it?
Unless of course this works as written.
How silly!
have a problem with file names on windows, becouse `\ / : * ? " < > |` are not allowed symbols
*nods* This is a good code quality bug.
Understood, but doesn't Tork differ enough from the original [test-loop](https://github.com/sunaku/tork/commit/2fa807faeb6e0def967dfc301bd2711c235cfcd4) gem that it could have it's own 1.0.0 release?
Your current update action should be able to handle the ajax version as well. I think the issue is using the `respond_to` block in the `before_filter`. If your filter is redirecting there isn't really any need to have the `respond_to` block.

In your view where you are doing the ajax request you can either:
1. Not handle the redirect you get back if the user isn't the correct one. This should be an edge case anyways where someone is hacking the form or something similar, they don't need nice error messages :).
2. When you get the redirect you can show the not authorized message.
The reason I didn't reference a tag is because version '1.1' is actually over two years old. The branch from AgileBits that I'm pointing to here is the most recent version, updated very recently, but they haven't "officially" updated the version number or tags.

Since there are a few competing divergent branches, and there doesn't seem to be an active "owner," proper versioning is problematic. If that's grounds for exclusion for CocoaPods, then go ahead and close this pull request.
Merged.  Much appreciated, thanks.
fuck... autoredirect*
Seriously? I "should use classes"? Yeah, maybe I should, but there is absolutely no need for shouting at me; I wrote a huge amount of code compared to what you did here (and compared to what I usually do). You're certainly right about classes and stuff, but it's not a reason to decry my work this way.

Perhaps you feel cleverer since you take part in contests about algorithm or I don't know what other stuff (I hope not, that be annoying), but get back in real life, I'm coding the same board as you, we're both involved in this project so you're absolutely not allowed to shout at me like you did.

By the way, we have typography, you should use it.
This is wrong, it is NOT meant to exit here. Think about it.
I think the patch is ready for submission after the following two issues are addressed (and after I tested it thoroughly):

1. loongson-specific instructions in the delay slot - I tend to agree with Petar that we should probably just revert these parts to the unoptimized version - a delay slot gain is probably not worth the possible problems due to having to maintain two versions of the same code.

2. the Jump optimization we talked about above - I just realized that this will probably interfere with the li+jr -> j optimization in Assembler::set_target_address_at (the one that turns jr into immediate jumps if pc and the address are in the same 256m segment). I think we should weigh the benefits of both methods and decide which one is more important.
meh. I'll pass.
no I made this consistent with the other calls, see the existing code.
Please don't add (more) system-specific headers to libnet's public API.
yes I will asap
I'll change that to addHairStyleId(), and change the function description, and the member storing the info accordingly. For instance:

```c++
std::set<int> mHairStyles;
...
void HairDb::addHairStyle(int id)
```


would it be ok as proposed?
works + looks fine
Due to the rename, deleting PROGRAMS would be a bad idea.
I've got a bunch of patches for you :D
Возможно бред, а возможно и нет. Но все же, это не финальная версия
Perfect.. Seems to be ok
sometimes, I observed this to crash with the error that bool has no .all().  numpy sometimes returns scalars when indexing in ways that can be convenient / annoying.  Since I couldn't reliably reproduce the crash, i put on this bandaid and emailed you. hasn't crashed since....
may be some summons... but not Sindra spells :)
或者加个注释，简单说明一下吧
spyder read your facebook !
Ty, fixed
Okay I am doing it again, this implementation is more buggy than I saw earlier. For multiple plots on the same axes, I think we can generalise (a loop + a switch) inside the javascript code, but first lets get the bar thing right.
oui github est trop fort ^^

2012/2/8 Olivier Hoarau <
reply@reply.github.com
>

> Oh mais a a march !
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/Olwaro/Web-loto/commit/e4f7fd73858a8da822932954da3734281399e72b#commitcomment-946497
>



-- 
Ludovic LEFEBVRE.
Elve 1er anne ENSC.
这里请使用 tags.subscribers.include?(@user)
An extension of .C is used on unix systems for C++ files.

See http://www.openfoam.com/

This code guesses wrong on unix systems so there must be a way to fix or override this bad guess.
oh my.. semi-colon shy?
I have grid unloading disabled since i cant remeber...
Sorry, fotget apply it! Still crashing http://pastebin.com/8BETGwNL
I'll fix the VC project file (conflict markers were not removed)
@mosst I think that is not related to this commit, i have this workaround 1 year on my server and no problems
need change faction in BG script, not in creature (else his has some broken functions)
@Reamer  I believe it should go directly to master. Now. Do it.
leading , are against our style guide
As for the nature of the bug it was a bit subtle and deep in pyparsing
call stack .. I foound some reference to it in the internets but don't
remember the details precisely.   Ill look them up when Im in front of
a computer (tomorrow)

On 1/28/12, David Cox
<reply@reply.github.com>
wrote:
> Can you elaborate a bit on what the pyparsing bug is?  Do you mean it
> requires *at least* 1.5.1, or exactly that version?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/yamins81/genson/commit/46351605b68dd72953a4615ed325d2af15bae8e8#commitcomment-911327
>

-- 
Sent from my mobile device
In this situation, could always bring in both commits (Tony's original one and Kevin's f/u commit) since both commit comments are well documented and then both parties also get credited as authors.
In general, when adding non-standard browser techniques, I want to be sure somebody did the research
in terms of how this affects stability and performance across browsers. Its probably marked "experimental" for a reason :)
I've googled a bit for "svg gradients ie9 performance", doesn't seem to be a big problem at least.
@adrexia Do you have any more info? Can you test the CMS before/after the patch in IE9? (/cc @sminnee)
Vieux copié-collé : `${linker.login}` devrait mieux marcher
@masonaxcte yes, for class file use the class name as file name so that it will be more clear while import.
shouldn't you add `` .. versionadded: 2.2.5`` ?
A more likely scenario is I implement a "securable modules" style API to allow for cyclic dependencies.  I don't like this API, but it does make for quite elegant cyclic dependencies possible.

    local exports = {}
    local module = {exports=exports}
    package.loaded[path] = exports
    local env = getfenv(fn)
    env.module = module
    env.exports = exports
    fn()
I think 3.4.2 is the latest release.
This is not useful at all?
In LTR, the "Add to Collection" text comes in two lines with the icon on the left to "Add" in the first line. Now in RTL, this icon should come on the right of "Collection". When locale is an RTL language and with "Add to Collection" in two lines, it is not possible to place the icon on the left of "Collection".

`inline-block` ensures that the text comes in one line and then correct positioning of icon is possible.
you can simply pass keyword arguments. python will know what to do and update those key/value pairs. http://docs.python.org/library/stdtypes.html#dict.update
Sorry for the English fails in the log... I was tired when I have written this.
Si vous voulez j'ai pas mal de "Warnings" sur mon mac (où la compilation est plus "sévère"). Donc ça peut peut-etre vous aidez à trouver les erreurs ...
Please make this fall inline with the way the rest of the service modules run, also I don't think this should be merged until it properly detects if upstart is available on distributions like Fedora which have Upstart or SystemD.
may be
WorldSession::HandleMoveWorldportAckOpcode //line 175
WorldSession::HandleMoveTeleportAck //line223

This condition can be reduced: newZone == m_zoneUpdateId
no sense to update the zone data if it is the same
Nasty bug, was running init code twice
What's the reference to plugin_basename actually doing here?
All good except you should check that the optional parameters are present. For example, the program will crash when trying to print argv[6], if this argument were not supplied. You can ASSUME that ''at least'' 6 arguments are there. 

Also, in `fprintf (stderr, "\nPARAMETERS", argv[0]);`, argv[0] is not actually used for anything:)
In general, i'm fine with using inflector. However, it should only be used if the developer has not set session.name. The test is therefore incorrect as anytime the config is passed in it should not be changed. Of course, this makes it hard to test since the value comes from a define.
Hi Mike,

Sorry for the late response. I can cancel these changes in .gitignore.
I will send another pull request contains only the drain part.

Sincerely,
Vincent
This isn't even close to done, nor even working. Please build on this if you'd like and I'll pull your changes (complete or not) in and continue on that.
I'd like to yank the xen functionality altogether from autotest, as it's hardly been maintained. If people want it badly, we'll gladly accept patches.
It isn't essential, but yeah, I think it'd be more clear.
Why is comment now a Type assigned to User TypeGroup ?
you just need to revert TC utgarde update to our old one this would fix the compile
It should say "Not worth..."
Should be `import (SimpleEditor as QtSimpleEditor, ` etc.?
structures :-)
Might want to mention bug #20 here, since this is directly related to it.
когда есть несколько коллекторов, лучше выделить для них интерфейс
и сделать для его базовый метод (вроде collect/inport)
см коммент выше про дженерики
Yeah we've been back and forth between this.  It appears that both types eventually fail.  Trying to figure it out.
When does the data in apps get freed and when does the glist it;s self get freed?
There is no association for rt_communities. There is a
communities_builder in which both module and bean_name are empty
strings.

Is it that there is something amiss in the client's Sugar instance?
Perhaps they renamed the module? So your gem thinks there is an
RTCommunity and AbcBuilder module, but they are one in the same? I'm
just grasping at straws here.

Thanks a lot for the support. It's very kind of you!

--
Jason Rogers



On Mon, Jan 23, 2012 at 21:30, Carl Hicks
<reply@reply.github.com>
wrote:
> Excellent, I should have said '''AbcBuilder''', sorry :)
>
> If you look at the output of "associations", and you search for a proxy_method that includes "community".  You get something like this:
>
>    #<SugarCRM::Namespace0::Association @proxy_methods=[communities_builder], @link_field="communities_builder", @target=false, @owner=SugarCRM::Namespace0::AbcBuilder, @cardinality=:many_to_one>
>
> '''@target=false''', means that the gem doesn't know which module is associated with this class.  This is probably because it wasn't provided in the module metadata we received from a '''get_module_fields''' call (we look for the module name in the "module" or "bean_name" entry of the returned metadata).
>
> Can you run:
>
>    SugarCRM.connection.get_module_fields("AbcBuilders")
>
> And look for a line like:
>
>    "rt_communities"=>
>      {"name"=>"communities_builders",
>       "type"=>"link",
>       "relationship"=>"communities_builders",
>       "module"=>"",
>       "bean_name"=>""},
>
> Let me know if "module" and or "bean_name" are empty.  If so, try editing the vardefs and adding the appropriate module name.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/jacaetevha/sugarcrm/commit/0636284e801a3aa191a0427f64e7caf2f1530e0a#commitcomment-894694
Il n'y a pas des fonctions dans ffmpeg pour récupérer cette liste dynamiquement ?
Elle doit bien déjà etre en dur dans ffmpeg... c'est dommage de devoir la maintenir en doublon de notre coté. Mais bon je ne sais pas si il y a ce qu'il faut dans ffmpeg pour faire ça....
so its not just sabsuite causing the issue? just to confirm, with maraschino installed with out sab you get the issue?

cat .xbmc/temp/xbmc.log | paste

see if that shows anything
I need to make a note here. The TCC820x folder is a copy from TCC77x because both chips are nearly identical. TCC820x seems to be the natural progression of that chip. Everything is mapped the same except for the GPIO lines.

These files are NOT tested with a TCC8200 chip at all. They're likely horribly wrong! I need to keep fiddling with this stuff
Any steps to decrease the bootup time is welcome :) Thanks again.
Any particular reason for this function?
I think you'll want a space after "system" here, as in
<code>logger.info("Using the grid engine machine batch system " + str(batchSystem))</code>, 
yeah?
Reviewing the code, I'm taking that back: in src/master:

updatedJob = batchSystem.getUpdatedJob(10) 
#pauseForUpdatedJob(batchSystem.getUpdatedJob) #Asks the batch system 
what jobs have been completed.
if updatedJob != None: #Runs through a map of updated jobs and there 
status,
     jobID, result = updatedJob

So it should return either None, or a valid tuple. Unless I'm missing 
another piece of code...?

On 07/03/2012 14:20, Dent Earl wrote:
> Shouldn't this initialization be
> <code>i = (None, None, None)</code>
> Since you're now expecting this function to return a triple? See the call made by<code>getUpdatedJobs()</code>.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/benedictpaten/jobTree/commit/0580ca24d6c8915964edf711f60729f10dacfb9a#commitcomment-1055948
Тут много народу программит? Но в целом да, общий стиль и всё такое. Fell free to fix wiki pages.
Ok, but if you could patch that, that'd be great :)
Looks pretty good so far.
http://community.modx-cms.ru/blog/addons/1621.html
Here's more about cacheAccelerator
also send link to the author of the cacheAccelerator

and one more addon cacheExtender
http://community.modx-cms.ru/blog/dev/1625.html
Useless use of "if"? Why not simply
(menu-bar-mode (window-system)) 
?
As for adding a note, you can already do this in the comments section, so I don't see the practical utility of merging this with recommendations.
I have a quick question about `composer.json` usage. I don't know much about `composer.json`, so this might be a silly question, but how do people chose what branch (`master` or `2.0`) they want to use when using composer to install this bundle?
Shouldn't the '!' be deleted ?
I've slightly adjusted your changes because suddenly transformAttributeGetSetDeclFlags() was different from the rest of similar methods.
OK so let's blame them :P
Yup. I do. :) Thanks for the comment though.
First 'draft' of connecting to HBase, get a list of all HBase tables, their column families and columns.
.. and is quicker :)
Once you're done, we can put this in SCons too.  SCons knows about latex/pdf.  So then we would type `scons docs` (or whatever we want if you want to use a different target name) to create the pdf file.
Je sais mais ça rentre pas sinon... On comprend toujours le sens de la phrase. Si t'a une autre phrase qui rentre n'hésite pas à faire un commit :)
Ясно, учту.
在 config.py 里设置了 highlight_language 之后，可以免去显式地设置 highlight 了。
This all looks good, too.
I did not mean how you built it, I meant how did you connect to target? 

Since I can't use 7.3 and OpenOCD v0.5.0 together. Without fixing that what is causing the "packet reply is too long" problem.
Just wondering if you had the same?
<pre></pre>
Hm, why does this appear in the pull review?
Awesome bro, thanks.

https://github.com/josevalim/rails-footnotes/pull/67

I would have done the whitespace separate though.
Using 2 Scaler for X and y would prevent using a pipeline for grid search. We could just make `Scaler` have extra constructor argument to explicitly scale the target or not (set to `False` by default to avoid fishy heuristics based on the integer distribution of the target variable).
Converted to pull request #103
Hah, I'm happy to see you get that message.

Thanks for the tips... I'll try to pop into #cyanogenmod-dev later tonight after work when I start playing with this.  Stop by if you're around later (remember I'm GMT+3)?
MAC計算を整理してソースはさっぱりしたのだが、IDブロックを２回読みにいくようになったのが好かん。
We need this timeout to be configurable rather than removed, however we do have a Jira to track that.

Also there is a subsequent Jira to allow long running calls to check they are still in progress should the call timeout.
this breaks symfony 2.8: PHP Fatal error:  Class 'Doctrine\Bundle\DoctrineBundle\Command\DoctrineCommand' not found in

any idea?
trackRecordForExclusion/isTrackedForExclusion
+1
This is tagged with SAND-213. I don't think that is the correct issue number for this commit.
Yeah, But I implemented this function to use with the page function. So the starting row is needed.
The classname is not equal at filename:

> The autoloader expected class "BeSimple\SsoAuthBundle\Buzz\AdaptiveClient" to be defined in file "/Users/sergio/Sites/consigna/app/../vendor/bundles/BeSimple/SsoAuthBundle/Buzz/AdaptiveClient.php". The file was found but the class was not in it, the class name or namespace probably has a typo.
Hi Taylor,

Thanks for noticing those issues with our URL matching.  Out of curiosity, why did you add an entry for the Django logout view?  Is there a reason to prefer that over the one we match in esp/esp/users/urls.py?
agreed, though I had line width issues already editing the file and didn't want to make it even longer. :}
The CSS style classes should probably declared as constants so that they aren't duplicated in the comments and the code, and so it's clear that these strings are used outside of this file.
reuse the existing container-boms found in the showcase. If a set/type is missing, create it
I wonder whether we couldn't make _AggregateResourceBundleLocator_ an interface and rename the current implementation to _ListBasedAggregateResourceBundleLocator_ (or something like that). I think it would be nicer to have interfaces in the public api instead of concrete classes. Of course we would need a way then to specify the bundle names.
Ok, maybe better "Usage and container requirements" then?
undefined. Гм, надо заменить `getThread(post).Num` обратно на `getThread(post).id.match(/\d+/)[0]`. Недосмотрел.
I don't think you need a `maxVersion`.
See 1 comment above.
If you do your monkeypatching manually, this should use a `finally` clause instead of repeating the same code in `except` and `else`. But as @pnasrat says, better solution is to use `mock.patch` and let it handle cleanup automatically.
Sure, doesn't hurt. It just stood out to be that there's back-compat code for a new component.
We should extend List
What would be the use case of doing that?
Thinking about it, wouldn't it be easier to set `self._parameters` to the default parameters in the constructor and update with `parameters`? That way you wouldn't need to deal with the case of missing dictionary keys and the update would be much simpler.
It is a tad sad, though, that this cannot be made a compiler constant (I tried some variations but couldn’t get it to work).
OHNOES! Good that there’s `scripts/fix-protobuf.sh`, try it!
oh, you meant `roles`, I thought you meant `roles` ;)
This change basically means that it is okay to disconnect clients (without warning) while nobody is waiting for a barrier. Is that what you intended?
It will exceed the line length limit.
I vote for not keeping this then
There should be a warning like that which follows, right? Do you have a better suggestion for the title of that paragraph? or shall the title just go?
what is your concern?
How would it be detected if not checked for?
It could be moved into the next else branch, but I'm not a big fan of nested if:s
Still waiting on info/instruction so I can complete this request to get this push request closer to acceptance
mask_signal is not accurate as both data corresponding both to b0s and nonb0s are signal. I could rename those to non_b0s and b0s. Very happy to make them attributes too. Is there a rule for a method becoming an attribute? Perhaps when it takes no input and returns a single value?
Replaces groups with organizations
This is utterly nit-picky, but on messages like these we haven't been using periods.
This is the tallest stack of mock decorators I've ever seen. :)
You were right about from_*, with these, I don't even have to declare these in User as they the standard AR names.  Modularized you probably let them declare the linking field or fields in their model. (:account and :card for us)
@elupus: Did you also meant moving the function from the CURL class to URIUtils? This doesn't makes sense IMO since the Encode/Decode functions is what this going to be used with mainly, which live in CURL:: space
Would be nice to combine these 3 test cases by extracting a variable or two.
"The mocked version of `make_runner()`..."
Makes import of interface obsolete.
The argparse module provides excellent support for managing cli args.
I am to please. :cake:
It is relevant to the class extension of `TUITextFieldEditor` which allows `TUITextField` to do its job.
I don't think this will work; you'll probably need some C code that negotiates between C and C#.
This should be documented. Also, the name "generation ID" is confusing here because it is the same as the "generation" for map output locations (which workers use to tell when to invalidate their cache of map output locations because some nodes have failed). I would just call this object IdGenerator. Also, I would place an IdGenerator instance on object BlockManager instead of having one "util" class where all the possible sequences of IDs are generated.
So that a ByteBufAllocator implementor extends it?
still work in progress. I want to keep it to advertise. if not ready by the time of release I will remove.
A method named `construction` will not be executed. But since you're only calling the parent's `constructor` here, you can remove the whole method.
заменить комментарий описанием проблемы, либо убрать
Extra indentation here
These changes are not needed, please keep these unchanged.
Is it possible to make this change?

```ruby
variable = @options.fetch(:as) { path[%r'_?(\w+)(\.\w+)*$', 1] }
raise ArgumentError unless variable
```

All these `try`s seem strange.
This could simply be :

    if self.class.default_x_frame_options
this could fail; please create a variable with something like this:

```python
news = getattr(portal, 'noticias')
if news is not None:
    ...
```
Agreed with that - `clone` should have parens.
+1.  Also, does it need to be lazy?  Doesn't appear to suck up much space, and object are already lazily initialized.
should RETmode be sticky? (what if you have a block expression as the result of the return and somewhere in there is a CPS expr that needs to be rewritten?)  In any case, this could be addressed in a future pull request.
It is supposed to minimize to the local minimum.  The tolerance can be adjusted via arguments passed to the minimizer.
Add spaces around `+` and `-`.
On 13.04.2012 05:49, Christopher Smith wrote:
>> +
>> +    If `>` is a so-called global order, that is `1` is the smallest monomial,
>> +    then we just have `S = K` and `R = K[x_1, \dots, x_n]`.
>> +
>> +    A few examples may make this clearer.
>> +
>> +>>>  from sympy.abc import x, y
>> +>>>  from sympy import QQ
>> +
>> +    Our first ring uses global lexicographic order.
>> +>>>  R1 = QQ.poly_ring(x, y, order=(("lex", x, y),))
>> +
>> +    The second ring uses local lexicographic order. Note that when using a
>> +    single (non-product) order, you can just specify the name and omit the
>> +    variables:
>> +>>>  R2 = QQ.poly_ring(x, y, order="ilex")
>
> I generally like to see a space before the `>>>`, otherwise it looks too busy.
>

Done.
`n = len(rgs) - (i + 1)`

```
>>> r=range(10)
>>> len(r[3+1:]) == len(r)-(3+1)
True
```
I don't see how you could get None here.
So what exactly are the expected inputs to Partition? An iterable of Sets? An iterable of FiniteSets? An iterable of iterables?
All `if deep` logic is now handled by expand() itself.  So you shouldn't even be looking at the deep keyword.
> Depends if we want strong typing or not. 

My vote here is yes

> In any case, shouldn't such check be done by MatPow?

Sounds reasonable
This is now an order on a polynomial ring. The `x_1, x_2 ` and `y_1, y_2, y_3` would be called generators and typically abbreviated to `{x_i, y_i}` [that is the `i` is a "running index"].
It should be = options$out.width %n% (options$fig.width * options$dpi)
I see. Then it's fine. Thanks.
yes, sir! :-)

the test is fine by itself, to be enabled as soon as xmlns issue is resolved, which is a separate concern
@eric How do you want to handle this? `#add_or_get` uses `klass` to make sure the metric retrieved from the registry is of the same class. `klass` could become an optional parameter if a block is supplied and then bypass the class check. I think it's important to skip.

Another option could be.

```ruby
add_or_get(name, Metriks::Histogram) do |klass|
  klass.new_exponentially_decaying
end
```

I prefer the code that's pushed. I don't think it's worth the trouble to DRY up the metric class name and it's more explicit what it's doing. The above is only one step better than passing the name of the constructor as the original commit did.
If you wanted to add a closure, you could just use the regular `addListener` method?
It's mostly defensive coding against future changes. I want to document that these collections should always be the same size.
это зачем здесь?
Make it StringIO inline. remove those small files.
I think I almost understand what is going on here, but maybe you can clarify this - on first inspection, it looks like you are parsing empty content - is there some mocking going on here?
You should user `user.groups.filter(name='Mentor').exists()`
Ce bloc de code (lignes 6 à 10) se retrouve dans toutes les pages html. Il serait plus simple de le mettre dans *base.html*. Si un jour on veut changer ce bout de code, nous aurons qu'une seule place à le changer. Sinon, on doit répéter le changement dans tout les fichiers html.
Has been added. For some reason github doesn't hide this automatically.
phpbb_ prefix if this is in global scope, ideally however take it out of the global scope.
Should not be in this diff or should not exist at all.
It was a bug in old document.
Is there a cleaner way to check this? I know in ele someone would make you refactor this.
cred că se poate scrie mai frumos: `chl_grp_user[ch.user_to.user] = chl_grp_user.get(ch.user_to.user, [])`
Its better to include custom headers after standard ones because standard header can potentially redefine or undefine macro from your header.
`render` приема `activity_content.html`, което ще използва html версията. Това значи, че може или във `feed_body` да използваш директно `activity_content.html`, или може в `_activity_content.rss.haml` да сложиш само:

``` ruby
render 'activity_content.html', :activity => activity`
```
is this something you're moving into `BaseController` in a future commit?
right, thanks for the review!
Replace
```C++
(src.cols + 63) / 64 <= (src.step - offset.x)
```
with
```C++
((src.cols + 63) / 64) * 64 <= (src.step - offset.x)
```
there's a model already present with name encounter so i gave it raxacoreEncounter
Be careful of your tabs/spacing here
TODO: remove it.
I think you can remove ``(at exit)``. It proably was written ``atexit`` to refer to the python ``atexit`` module, but it seems irrelevant to me.
The code would be faster and smaller if you just passed these keySets directly as arguments to getKeyInfo (changing its argument type or overloading if you need different argument types).

BTW, when you DO need to add an entire collection like the keySets into another collection like the parentNodeList, you can do it faster in 1 line instead of 3 by calling addAll.
space after "function"
s/with the calling process/with the `Pid'/
oh no! another Yvonne Strahovski fan!
This is mostly a style issue and not a pull-stopper.
Syntax error! Extra `'` after `self.pk`. Also we should be showing valid pep8 code - no spaces inside a dict literal.
Ah OK. So an eventual refactoring should occur in another branch.

LGTM
I find the code above to be overly cryptic, how about the following variant?

    imts = set(hc.intensity_measure_types_and_levels.keys())
    all_imts = set(hc.intensity_measure_types)
    if not imts.issubset(all_imts):
        msg = 'Unknown IMTs (`%s`) in `%s`'
        msg %= (imts - all_imts, 'intensity_measure_types')
        ...

The snippet above is easier to read IMHO and has the additional benefit of a
more precise error message.
"type" is optional parameter (just like action attribute for form element), if omitted, "GET " will set by default – http://api.jquery.com/jQuery.ajax/
Won't this alter width/height animations because of css.js L372, where we want `extra` to be falsy? I recommend changing the condition on css.js L188 to `numeric || extra !== undefined` and changing this call to pass `false` (or `""` if smaller) instead of `"tween"`.
You could use it on your application for example
Postgres 8.4 does not support ordered aggregate. Therefore, we need a different solution for it. Since the solution without ordered aggregate is much slower, we will only use it for PG 8.4.

Anyway, we need a switch point. I can define another function named MADLIB_SCHEMA.__treemodel_display and embed the switching logic inside this new function. Does this meet your suggestions?
This is not correct if the nspname is capitalized.
find and replace error?  shouldn't it be doc.documentElement
Doesn't it make sense to  do the userExists check even before emitting the hook?
I think the reason this can't be run outside of Twisted is better stated as "as it assumes the result of batch_inbound_keys_matching is a Deferred object". Only the `wait=False` case actually requires this. You could rework the function to use `calls_manager` and not yield the result of batch_inbound_keys and add a callback to it when `wait` is False. You could also assert that the manager is an async manager in this case.
Issue #300 addresses this
I suggest using intermediate variables such as `var key = session._updatedKeys[i];` to improve readability.
So hatte ich Koala verstanden, ja.. denn bis dato war der default für den ersten click `desc` .. was i.d.R. tatsächlich nicht das is was man will.
Auf die grundsätzliche Sortierung beim ersten Öffnen der rex_list hat man ja nur query seitig Einfluß.. die rex_list weiß davon nichts.. weder welches Feld noch die Richtung..

Sprich: der patch ändert lediglich die Sortierrichtung für den _ersten_ klick auf eine column von `desc` nach `asc`.. zuzügl. der Option über `$direction` doch wieder `desc` zu wählen.. und das auf column basis, sprich für jede separat wenn man will/braucht.
Yeah, I was thinking the same thing
And don't use hard coded tmpdirs, use mktemp for that.
Why make this a function that takes a callback versus just returning the list of locations? Do you anticipate having this be a database driven lookup in the future?
if a data mapper
Added clarifying comments. Moved ``_pendingDocumentPromises`` to be a property of the ``getDocumentForPath`` ``Function`` object.
Yeah, since we don't have ellipses for "New File" or "New Folder", we should probably leave it off "Rename" too. Done.
Might be good to add a comment here noting that `addToWorkingSet()` is synchronous.  (On my copy of the fix I also added "Completes synchronously." to the docs on `addToWorkingSet()` itself since it differs from what feels like the norm for DocumentManager APIs).
Yes! It's supposed to say "though"
All my current cases have values on the same line, but that brings up the point that I should add multi-line cases. Will add some.
please make more changes
Or maybe when data.filters === undefined.  In either case, it would be more explicit to do:

if (data && data.filters) {
  $('#hq-report-filters').html(data.filters);
}
Why not?  If you want to use mu installed system-wide, you can just set `:build nil` in your el-get-sources.
should those magic Strings be refactored to be a class constant?
And `nfortin` should be `Nicolas Fortin`. I fixed that in most existing code, let's not reintroduce any.

Much more importantly, could you rename the class to remove the underscore?
Shouldn't this be a move?
I recommend that you use [HTML validator](https://addons.mozilla.org/en-US/firefox/addon/html-validator/) Firefox plugin. It allows simple validation directly from the browser.
Why overriding fulltitle? Why not setting only title to *Logout*?
Since you're manipulating these already, can we remove HTML from this file? The layout system is an obvious place to put these.

Also, these variables should be const-like, i.e. of the form `URL_INPUT_INNER_WRAPPER`, and most likely on line 7 (outside of this scope). There isn't a good reason for all of this to get instantiated each time the media-editor open -- especially if `cloneNode` is being used on them below. Since they're already supposed to be consts, let's go all the way with how they're styled.
I don't have a date, I have a number of ms, so unless I do work to parse it back into a date, then extract the bits I need...  What I have works well, does it matter--math is fast in js?  Seems like spending time rewriting this is wasting time.
nah, it's not necessary here -- only the icon is needed, not the outer styles of a button
Move this into it's own test block
Sure I could think of Add/Remove/Has AllRecordings(Url)Identifier or AllRecordings(Url)Extension. Just let me know what you prefer?

Yes, l257 compares just the stuff after the last slash. But for the top level 'All Recordings' path, there is no slash. That's covered in l254.
`clientGuarantee`, `clientExpect`
I don't see any other code that's similar, where we could reduce duplication by re-using this method, which is why it's been left as just a private instance method in this class.  But yes, it could be in its own class, and if we wanted to do this same thing again somewhere else I would definitely do that.

One other benefit would be that then we could test the excon error-handling code independently, and then in the specs for classes that that use it we could just set expectations that this utility method is called, rather than actually simulating the AWS exceptions.  So it would make the tests a little nicer. 

Right now we've already got the test coverage in the places where this code is used, so I don't think there's a strong incentive to change it.  But it's a good thought for the future.
of all the things to guard, this would be one valid use of guarding...
Some botched merge here
`module.exports = require(process.env.BORSCHIK_COVER? './lib-cov' : './lib');`
index можно не добавлять, потому что он будет использоваться по умолчанию для директории
Also, according to http://www.w3.org/TR/html401/struct/lists.html only `li` tags are allowed as children of `ul`.
there is a getLayer method for this
After reading 3.2.4.3 again (a number of times) and checking the pseude code. I agree.
typo here (archutecture)
same answer as clone_id :0
I "stole" this code from Spacewalk. And Spacewalk still support tomcat5 (which I removed), but I left there this if-condition as tomcat7 is approaching.
Hrm, this works, but i wonder if it would make more sense to just get the repos within the default content view for library instead of getting ones who's library_instance_id is nill (which is more of a side effect).
Does this mean that every page for everyone will have a link to the calendar belonging to the nurse with id 1?
$connection is returned by methods earlier and there is no need to search for it again
It gives minification gain. Since infinity are ment to be a library - production size matters I believe  
`that` is a common pattern for `this` alias
这个逻辑走不到吧？你上边已经强制加“/”了
After I apply <code>display: inline-block</code> it caused a spacing issue (In this scenario)
There are extra spaces between elements, I have to set the margin to negative value and eliminate the extra space.
Maybe there is a correct way to use <code>display: inline-block</code> or I think I can keep <code>float: left</code> first.
See 

https://github.com/andreasgal/gaia/blob/master/apps/sms/js/utils.js#L188

on how properly escape text in HTML if you ended up pattern like this.
this line is probably not required
I fixed this in numpy/numpy#483 but I don't think it will make the cut to 1.7.0. I agree we should add a reference to the issue.
'also also' -> 'is also'
But it looks like this exception won't be raised if the `unit` was a `Unit` instance but was not one of u.degree, etc..  This is never checked until below when a less helpful ValueError is raised.

Also, wouldn't calling `u.Unit(unit)` do the string conversion? Or does it not understand things like "degrees" and "hours"?
Hmm, I'm thinking maybe `pattern` or `wildcard` for this variable name instead. Equally ambiguous but perhaps more common and recognizable.
Is there a reason to use a std:;string instead of a const char*, seems like std::string needlessly copies the data to yet another buffer?