ReviewComments stringlengths 1 2.35k | OriginalCode stringlengths 28 487 | ReviewedCode stringlengths 14 463 |
|---|---|---|
space ( | <START> TYPE_1 ( String <END> m , String c , String VAR_2 ) { VAR_3 = c ; message = m ; VAR_4 = VAR_2 ; } | TYPE_1 ( String m , String c , String VAR_2 ) { message = m ; VAR_3 = c ; VAR_4 = VAR_2 ; } |
remove line TYPE_7 needed more deleted files _CODE_ java removed | protected void METHOD_1 ( ) { METHOD_2 ( new TYPE_1 ( ) { @Override protected void METHOD_3 ( ) { <START> factory ( TYPE_7 . TYPE_6 . class ) ; <END> factory ( TYPE_5 . TYPE_6 . class ) ; } } ) ; METHOD_4 ( TYPE_4 . class ) ; } | protected void METHOD_1 ( ) { METHOD_2 ( new TYPE_1 ( ) { @Override protected void METHOD_3 ( ) { factory ( TYPE_5 . TYPE_6 . class ) ; } } ) ; METHOD_4 ( TYPE_4 . class ) ; } |
I preferif ( o instanceof TYPE_1 ) { TYPE_1 VAR_1 = ( TYPE_1 ) o ; } return false ; | public boolean equals ( Object o ) { <START> if ( ! ( o instanceof TYPE_1 ) ) { return false ; } <END> TYPE_1 VAR_1 = ( TYPE_1 ) o ; return TYPE_2 . METHOD_1 ( name , VAR_1 . name ) && value == VAR_1 . value ; } | public boolean equals ( Object o ) { if ( o instanceof TYPE_1 ) { TYPE_1 VAR_1 = ( TYPE_1 ) o ; return TYPE_2 . METHOD_1 ( name , VAR_1 . name ) && value == VAR_1 . value ; } return false ; } |
needed ? subclassing a TYPE_1 method body lines 30 - 32 | protected void METHOD_1 ( ) { <START> METHOD_2 ( new TYPE_1 ( ) { <END> @Override protected void METHOD_1 ( ) { cache ( VAR_1 , TYPE_2 . class , TYPE_3 . class ) . METHOD_3 ( 2 < < INT_1 ) . METHOD_4 ( TYPE_4 . class ) ; } } ) ; } | protected void METHOD_1 ( ) { cache ( VAR_1 , TYPE_2 . class , TYPE_3 . class ) . METHOD_3 ( 2 < < INT_1 ) . METHOD_4 ( TYPE_4 . class ) ; } |
unnecessary rewalking a previously walked graph | private void METHOD_1 ( ) throws TYPE_1 , IOException { VAR_1 . METHOD_2 ( VAR_1 . METHOD_3 ( VAR_2 ) ) ; for ( TYPE_2 commit : VAR_1 ) { <START> VAR_1 . METHOD_4 ( commit ) ; <END> parse ( commit ) ; } METHOD_5 ( ) ; for ( Collection < TYPE_3 > v : VAR_3 . METHOD_6 ( ) . values ( ) ) { Collections . VAR_4 ( ( List < TYPE_3 > ) v , VAR_5 ) ; } } | private void METHOD_1 ( ) throws TYPE_1 , IOException { VAR_1 . METHOD_2 ( VAR_1 . METHOD_3 ( VAR_2 ) ) ; for ( TYPE_2 commit : VAR_1 ) { parse ( commit ) ; } METHOD_5 ( ) ; for ( Collection < TYPE_3 > v : VAR_3 . METHOD_6 ( ) . values ( ) ) { Collections . VAR_4 ( ( List < TYPE_3 > ) v , VAR_5 ) ; } } |
changing : VAR_1 METHOD_2 ( STRING_1 STRING_3 STRING_4 false ) ; tests fail | static TYPE_1 METHOD_1 ( ) { TYPE_2 VAR_1 = new TYPE_2 ( ) ; VAR_1 . METHOD_2 ( STRING_1 , null , STRING_2 , true ) ; <START> VAR_1 . METHOD_2 ( STRING_1 , STRING_3 , STRING_4 , true ) ; <END> return new TYPE_1 ( VAR_1 ) ; } | static TYPE_1 METHOD_1 ( ) { TYPE_2 VAR_1 = new TYPE_2 ( ) ; VAR_1 . METHOD_2 ( STRING_1 , null , STRING_2 , true ) ; return new TYPE_1 ( VAR_1 ) ; } |
remove lines don t ned METHOD_4 ( ) method standard | private void METHOD_1 ( TYPE_4 . TYPE_5 r ) throws Exception { METHOD_2 ( r , 2 ) ; <START> TYPE_2 input = new TYPE_2 ( ) ; input . VAR_1 = true ; <END> METHOD_3 ( r ) . METHOD_4 ( input ) ; TYPE_3 repo = VAR_2 . METHOD_5 ( project ) ; try { assertEquals ( r . VAR_3 ( ) , repo . VAR_4 ( STRING_1 ) . METHOD_6 ( ) ) ; } finally { repo . close ( ) ; } } | private void METHOD_1 ( TYPE_4 . TYPE_5 r ) throws Exception { METHOD_2 ( r , 2 ) ; METHOD_3 ( r ) . METHOD_4 ( ) ; TYPE_3 repo = VAR_2 . METHOD_5 ( project ) ; try { assertEquals ( r . VAR_3 ( ) , repo . VAR_4 ( STRING_1 ) . METHOD_6 ( ) ) ; } finally { repo . close ( ) ; } } |
? : foo METHOD_1 updated > foo | public boolean METHOD_1 ( TYPE_1 VAR_1 ) throws TYPE_2 { <START> return VAR_1 . METHOD_2 ( ) . METHOD_3 ( ) . METHOD_4 ( ) <= VAR_2 . METHOD_4 ( ) ; <END> } | public boolean METHOD_1 ( TYPE_1 VAR_1 ) throws TYPE_2 { return VAR_1 . METHOD_2 ( ) . METHOD_3 ( ) . METHOD_4 ( ) >= VAR_2 . METHOD_4 ( ) ; } |
needed missed previous review | protected void run ( ) <START> throws TYPE_1 , TYPE_2 , Exception { <END> VAR_1 . println ( STRING_1 ) ; } | protected void run ( ) { VAR_1 . println ( STRING_1 ) ; } |
catch part innter block need nest blocks | protected void METHOD_1 ( final String p ) { try { try ( TYPE_1 in = TYPE_2 . class . METHOD_2 ( ) . METHOD_3 ( p ) ) { if ( in != null ) { METHOD_4 ( in , STRING_1 + p ) ; } else { log . error ( STRING_2 + p ) ; } } <START> } catch ( IOException e ) { <END> log . error ( e . getMessage ( ) , e ) ; } } | protected void METHOD_1 ( final String p ) { try ( TYPE_1 in = TYPE_2 . class . METHOD_2 ( ) . METHOD_3 ( p ) ) { if ( in != null ) { METHOD_4 ( in , STRING_1 + p ) ; } else { log . error ( STRING_2 + p ) ; } } catch ( IOException e ) { log . error ( e . getMessage ( ) , e ) ; } } |
I method called line 244 return checked return method return void | <START> private boolean METHOD_1 ( ) { <END> if ( ! VAR_1 . contains ( VAR_2 ) ) { while ( VAR_3 > 0 ) { TYPE_1 c = VAR_4 . get ( VAR_3 ) . commit ( ) ; TYPE_2 b = VAR_4 . get ( VAR_3 ) . METHOD_2 ( ) ; if ( b . get ( 0 ) != null ) { VAR_1 . add ( c . commit ( ) ) ; } VAR_3 -- ; } return true ; } return false ; } | private void METHOD_1 ( ) { if ( ! VAR_1 . contains ( VAR_2 ) ) { while ( VAR_3 > 0 ) { TYPE_1 c = VAR_4 . get ( VAR_3 ) . commit ( ) ; TYPE_2 b = VAR_4 . get ( VAR_3 ) . METHOD_2 ( ) ; if ( b . get ( 0 ) != null ) { VAR_1 . add ( c . commit ( ) ) ; } VAR_3 -- ; } } } |
variable needed VAR_1 direct | private static boolean METHOD_1 ( String url ) { <START> String VAR_1 = <END> STRING_1 ; return url . VAR_2 ( VAR_1 ) ; } | private static boolean METHOD_1 ( String url ) { return url . VAR_2 ( STRING_1 ) ; } |
I stops admins installing example / code / review / server | static void METHOD_1 ( final String target , final TYPE_1 req , final TYPE_2 VAR_1 ) throws IOException { final StringBuilder url = new StringBuilder ( ) ; <START> url . append ( TYPE_3 . METHOD_2 ( req . VAR_2 ( ) , STRING_1 ) ) ; <END> url . append ( CHAR_1 ) ; url . append ( CHAR_2 ) ; url . append ( target ) ; VAR_1 . METHOD_3 ( url . toString ( ) ) ; } | static void METHOD_1 ( final String target , final TYPE_1 req , final TYPE_2 VAR_1 ) throws IOException { final StringBuilder url = new StringBuilder ( ) ; url . append ( req . VAR_2 ( ) ) ; url . append ( CHAR_1 ) ; url . append ( CHAR_2 ) ; url . append ( target ) ; VAR_1 . METHOD_3 ( url . toString ( ) ) ; } |
URL access web application unsafe hosed IIRC string gerrit config admin p0wn3d gerrit config other problems | protected void METHOD_1 ( final TYPE_1 req , final TYPE_2 VAR_1 ) throws IOException { final StringBuilder VAR_2 = new StringBuilder ( ) ; <START> VAR_2 . append ( TYPE_3 . METHOD_2 ( VAR_3 . get ( ) , STRING_1 ) ) ; <END> VAR_2 . append ( CHAR_1 ) ; VAR_2 . append ( METHOD_3 ( req ) ) ; TYPE_4 . METHOD_4 ( VAR_1 ) ; VAR_1 . METHOD_5 ( VAR_2 . toString ( ) ) ; } | protected void METHOD_1 ( final TYPE_1 req , final TYPE_2 VAR_1 ) throws IOException { final StringBuilder VAR_2 = new StringBuilder ( ) ; VAR_2 . append ( VAR_3 . get ( ) ) ; VAR_2 . append ( CHAR_1 ) ; VAR_2 . append ( METHOD_3 ( req ) ) ; TYPE_4 . METHOD_4 ( VAR_1 ) ; VAR_1 . METHOD_5 ( VAR_2 . toString ( ) ) ; } |
reason TYPE_2 METHOD_1 handle null cases parameters I VAR_1 canno null : VAR_1 equals ( o VAR_1 ) good enough | public boolean equals ( Object obj ) { if ( obj instanceof TYPE_1 ) { TYPE_1 o = ( TYPE_1 ) obj ; <START> return TYPE_2 . METHOD_1 ( VAR_1 , o . VAR_1 ) ; <END> } return equals ( obj ) ; } | public boolean equals ( Object obj ) { if ( obj instanceof TYPE_1 ) { TYPE_1 o = ( TYPE_1 ) obj ; return VAR_1 . equals ( o . VAR_1 ) ; } return super . equals ( obj ) ; } |
I don t want return null METHOD_5 ( ) shouldn t hard modify TYPE_3 _CODE_ handle a null revision | public List < TYPE_1 > METHOD_1 ( TYPE_2 db , TYPE_3 VAR_1 , TYPE_8 . TYPE_7 VAR_2 ) throws TYPE_5 { if ( ! VAR_3 . METHOD_2 ( ) ) { return METHOD_3 ( db . VAR_4 ( ) . METHOD_1 ( VAR_2 ) ) ; } TYPE_6 < TYPE_7 , TYPE_1 > VAR_5 = VAR_1 . METHOD_4 ( ) . METHOD_5 ( ) ; <START> if ( VAR_5 != null ) { <END> return VAR_5 . get ( VAR_2 ) ; } return Collections . VAR_6 ( ) ; } | public List < TYPE_1 > METHOD_1 ( TYPE_2 db , TYPE_3 VAR_1 , TYPE_8 . TYPE_7 VAR_2 ) throws TYPE_5 { if ( ! VAR_3 . METHOD_2 ( ) ) { return METHOD_3 ( db . VAR_4 ( ) . METHOD_1 ( VAR_2 ) ) ; } return VAR_1 . METHOD_4 ( ) . METHOD_5 ( ) . get ( VAR_2 ) ; } |
apparently method returns false wait time exceeded implementation buggy completed future lied caller indexing done new implementation avoids caller potentially wait 2x VAR_1 METHOD_2 returns false method throw TYPE_2 | public TYPE_1 get ( long VAR_1 , TimeUnit VAR_2 ) throws InterruptedException , TYPE_2 , TYPE_3 { if ( ! METHOD_1 ( ) ) { if <START> ( VAR_3 . METHOD_2 ( VAR_4 , <END> ( int ) TYPE_4 . METHOD_3 ( VAR_1 , VAR_2 ) ) ) { set ( null ) ; } } return super . get ( VAR_1 , VAR_2 ) ; } | public TYPE_1 get ( long VAR_1 , TimeUnit VAR_2 ) throws InterruptedException , TYPE_2 , TYPE_3 { if ( ! METHOD_1 ( ) ) { if ( VAR_3 . METHOD_2 ( VAR_4 , ( int ) TYPE_4 . METHOD_3 ( VAR_1 , VAR_2 ) ) ) { set ( null ) ; } else { throw new TYPE_2 ( ) ; } } return super . get ( VAR_1 , VAR_2 ) ; } |
METHOD_3 block method METHOD_1 called future concurrent set set gen future remove matter state future | public void METHOD_1 ( ) throws IOException { if ( METHOD_2 ( ) ) { if ( ! METHOD_3 ( ) ) { <START> VAR_1 . remove ( this ) ; <END> set ( null ) ; } } } | void METHOD_1 ( ) { if ( METHOD_2 ( ) ) { VAR_1 . remove ( this ) ; if ( ! METHOD_3 ( ) ) { set ( null ) ; } } } |
redundant auto - boxing work fine IIRC _CODE_ don t warn auto - boxing gerrit | public void METHOD_1 ( List < String > VAR_1 ) throws TYPE_1 { TYPE_2 VAR_2 = METHOD_2 ( ) ; if ( VAR_2 != null ) { <START> VAR_3 . put ( Integer . valueOf ( VAR_2 . METHOD_3 ( ) ) , <END> ImmutableList . VAR_4 ( VAR_1 ) ) ; } } | public void METHOD_1 ( List < String > VAR_1 ) throws TYPE_1 { TYPE_2 VAR_2 = METHOD_2 ( ) ; if ( VAR_2 != null ) { VAR_3 . put ( VAR_2 . METHOD_3 ( ) , ImmutableList . VAR_4 ( VAR_1 ) ) ; } } |
public ? gerrit conversion mark injected constructors package provided | <START> public <END> TYPE_3 ( TYPE_1 < TYPE_2 > VAR_2 ) { this . VAR_3 = VAR_2 ; } | TYPE_3 ( TYPE_1 < TYPE_2 > VAR_2 ) { this . VAR_3 = VAR_2 ; } |
useful error message fails | public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 , TYPE_3 commit ) throws IOException { <START> METHOD_2 ( commit . VAR_2 ( ) == 1 ) ; <END> TYPE_3 VAR_3 = commit . VAR_4 ( 0 ) ; TYPE_4 VAR_5 = new TYPE_4 ( TYPE_5 . toString ( VAR_3 . getId ( ) ) ) ; try { return TYPE_6 . METHOD_3 ( db . get ( ) . METHOD_4 ( ) . METHOD_5 ( VAR_5 ) . METHOD_6 ( ) ) ; } catch ( TYPE_7 e ) { throw new IOException ( e ) ; } } | public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 , TYPE_3 commit ) throws IOException { TYPE_3 VAR_3 = commit . VAR_4 ( 0 ) ; TYPE_4 VAR_5 = new TYPE_4 ( TYPE_5 . toString ( VAR_3 . getId ( ) ) ) ; try { return TYPE_6 . METHOD_3 ( db . get ( ) . METHOD_4 ( ) . METHOD_5 ( VAR_5 ) . METHOD_6 ( ) ) ; } catch ( TYPE_7 e ) { throw new IOException ( e ) ; } } |
obvious argument s copy identity ? pass a _CODE_ instead | private TYPE_1 METHOD_1 ( TYPE_2 VAR_1 , TYPE_3 VAR_2 , <START> TYPE_4 VAR_3 , TYPE_4 <END> VAR_4 , TYPE_1 VAR_5 ) throws IOException { TYPE_5 builder = new TYPE_5 ( ) ; builder . VAR_6 ( VAR_5 ) ; builder . VAR_7 ( VAR_4 ) ; builder . VAR_8 ( VAR_3 . METHOD_2 ( ) ) ; builder . VAR_9 ( METHOD_3 ( VAR_1 ) ) ; builder . VAR_10 ( VAR_3 . METHOD_4 ( ) ) ; TYPE_1 VAR_11 = VAR_2 . METHOD_5 ( builder ) ; VAR_2 . METHOD_6 ( ) ; return VAR_11 ; } | private TYPE_1 METHOD_1 ( TYPE_2 VAR_1 , TYPE_3 VAR_2 , TYPE_4 VAR_3 , TYPE_4 VAR_4 , TYPE_1 VAR_5 ) throws IOException { TYPE_5 builder = new TYPE_5 ( ) ; builder . VAR_6 ( VAR_5 ) ; builder . VAR_7 ( VAR_4 ) ; builder . VAR_8 ( VAR_3 . METHOD_2 ( ) ) ; builder . VAR_9 ( METHOD_3 ( VAR_1 ) ) ; builder . VAR_10 ( VAR_3 . METHOD_4 ( ) ) ; return VAR_2 . METHOD_5 ( builder ) ; } |
class TYPE_3 class : getClass ( ) METHOD_1 ( VAR_3 ) | public TYPE_3 ( ) throws IOException { TYPE_1 VAR_2 = <START> TYPE_2 . class . METHOD_1 ( VAR_3 ) ; <END> if ( VAR_2 != null ) { METHOD_2 ( VAR_2 ) ; } else { log . error ( STRING_1 , VAR_3 ) ; } } | public TYPE_3 ( ) throws IOException { TYPE_1 VAR_2 = getClass ( ) . METHOD_1 ( VAR_3 ) ; if ( VAR_2 != null ) { try { METHOD_2 ( VAR_2 ) ; } finally { VAR_2 . close ( ) ; } } else { log . error ( STRING_1 , VAR_3 ) ; } } |
need variable inline return statement | private TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { <START> TYPE_3 VAR_2 = <END> VAR_3 . METHOD_2 ( VAR_1 ) ; return VAR_2 . getInstance ( TYPE_1 . class ) ; } | private TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { return VAR_3 . METHOD_2 ( VAR_1 ) . getInstance ( TYPE_1 . class ) ; } |
s ll want event METHOD_2 pass e null | void METHOD_1 ( TYPE_1 e ) { <START> METHOD_2 ( null ) ; <END> } | void METHOD_1 ( TYPE_1 e ) { METHOD_2 ( e ) ; } |
private | <START> static boolean METHOD_1 ( TYPE_1 req ) { <END> return ! TYPE_2 . METHOD_2 ( req . VAR_1 ( ) ) && req . VAR_1 ( ) . startsWith ( VAR_2 ) ; } | private static boolean METHOD_1 ( TYPE_1 req ) { return ! TYPE_2 . METHOD_2 ( req . VAR_1 ( ) ) && req . VAR_1 ( ) . startsWith ( VAR_2 ) ; } |
I tests similar call grant ( ) ? switch convenience method | static public TYPE_1 <START> METHOD_1 ( TYPE_2 <END> project , String VAR_1 , TYPE_4 . TYPE_5 group ) { TYPE_1 VAR_2 = METHOD_2 ( project , group ) ; project . VAR_3 ( TYPE_6 . VAR_5 , true ) . METHOD_3 ( VAR_1 , true ) . add ( VAR_2 ) ; return VAR_2 ; } | public static TYPE_1 METHOD_1 ( TYPE_2 project , String VAR_1 , TYPE_4 . TYPE_5 group ) { TYPE_1 VAR_2 = METHOD_2 ( project , group ) ; project . VAR_3 ( TYPE_6 . VAR_5 , true ) . METHOD_3 ( VAR_1 , true ) . add ( VAR_2 ) ; return VAR_2 ; } |
wrap line | public boolean METHOD_1 ( TYPE_1 VAR_1 ) { return VAR_2 > VAR_1 . METHOD_2 ( ) <START> || ( VAR_3 && VAR_4 . VAR_5 . METHOD_3 ( ) > VAR_1 . METHOD_2 ( ) ) ; <END> } | public boolean METHOD_1 ( TYPE_1 VAR_1 ) { return VAR_3 && VAR_4 . VAR_5 . METHOD_3 ( ) > VAR_1 . METHOD_2 ( ) ; } |
exhaust entropy local server login stalls general denial service enough entropy builds start another RNG create TYPE_1 server startup retain long term a singleton helps avoid depleting local high quality entropy login request early early days gerrit issues SSH users couldn t login hours days SSH server depleting entropy connection | private static String METHOD_1 ( ) { byte [ ] VAR_1 = new byte [ INT_1 ] ; <START> new TYPE_1 ( ) . METHOD_2 ( VAR_1 ) ; <END> return TYPE_2 . METHOD_3 ( VAR_1 ) ; } | static String METHOD_1 ( ) { byte [ ] state = new byte [ INT_1 ] ; VAR_1 . METHOD_2 ( state ) ; return TYPE_2 . METHOD_3 ( state ) ; } |
METHOD_4 method | private String METHOD_1 ( String VAR_1 , String path ) throws TYPE_1 { if ( VAR_1 . METHOD_2 ( STRING_1 ) > 0 ) { return new TYPE_2 ( new TYPE_2 ( VAR_1 ) , path ) . METHOD_3 ( ) ; } else { return VAR_1 + METHOD_4 ( VAR_1 ) + STRING_2 + <START> TYPE_3 . is ( CHAR_1 ) . METHOD_5 ( path ) ; <END> } } | private String METHOD_1 ( String VAR_1 , String path ) { return METHOD_4 ( VAR_1 ) + path ; } |
static ( ) | <START> private long <END> METHOD_1 ( TYPE_1 VAR_1 , String VAR_2 ) { long VAR_3 = - 1 ; try { VAR_3 = TYPE_2 . METHOD_2 ( VAR_1 , VAR_2 , null , VAR_4 , - 1 , TimeUnit . VAR_5 ) ; if ( VAR_3 == - 1 ) { log . info ( TYPE_3 . format ( STRING_1 , VAR_2 , VAR_4 ) ) ; } } catch ( IllegalArgumentException e ) { log . error ( TYPE_3 . format ( STRING_2 , VAR_2 , VAR_4 ) , e ) ; } return VAR_3 ; } | private static long METHOD_1 ( TYPE_1 VAR_1 , String VAR_2 ) { long VAR_3 = - 1 ; try { VAR_3 = TYPE_2 . METHOD_2 ( VAR_1 , VAR_2 , null , VAR_4 , - 1 , TimeUnit . VAR_5 ) ; if ( VAR_3 == - 1 ) { log . info ( TYPE_3 . format ( STRING_1 , VAR_2 , VAR_4 ) ) ; } } catch ( IllegalArgumentException e ) { log . error ( TYPE_3 . format ( STRING_2 , VAR_2 , VAR_4 ) , e ) ; } return VAR_3 ; } |
I guess work queue listens METHOD_1 event cancels tasks verified | public void METHOD_1 ( ) { <START> if ( VAR_1 != null ) { VAR_1 . METHOD_2 ( true ) ; } <END> } | public void METHOD_1 ( ) { } |
+ 1 clarify docs | <START> public static List < TYPE_1 > METHOD_1 ( TYPE_2 < TYPE_1 > VAR_1 ) { return TYPE_4 . TYPE_5 . METHOD_2 ( VAR_1 ) ; } <END> | private static List < TYPE_1 > METHOD_1 ( TYPE_2 < TYPE_1 > VAR_1 ) { return TYPE_4 . TYPE_5 . METHOD_2 ( VAR_1 ) ; } |
eclipse warning argument r unused I guess changed r | public void METHOD_1 ( TYPE_1 r ) { VAR_1 = <START> VAR_1 == <END> null ? null : new TYPE_2 ( VAR_1 . VAR_2 , VAR_1 . VAR_3 , VAR_1 . VAR_4 , VAR_1 . VAR_5 ) ; } | public void METHOD_1 ( TYPE_1 r ) { VAR_1 = r == null ? null : new TYPE_2 ( VAR_1 . VAR_2 , VAR_1 . VAR_3 , VAR_1 . VAR_4 , VAR_1 . VAR_5 ) ; } |
temp var unneeded return direct | public TYPE_1 get ( ) { <START> TYPE_1 VAR_1 = <END> new TYPE_1 ( VAR_2 ) ; return VAR_1 ; } | public TYPE_1 get ( ) { return new TYPE_1 ( VAR_2 ) ; } |
static order public methods | <START> private Collection < TYPE_1 > METHOD_1 ( <END> Collection < TYPE_1 > VAR_1 , Collection < TYPE_1 > VAR_2 , String file ) { for ( TYPE_1 c : VAR_2 ) { String VAR_3 = c . getKey ( ) . METHOD_2 ( ) . METHOD_3 ( ) ; if ( VAR_3 . equals ( file ) ) { VAR_1 . add ( c ) ; } } return VAR_1 ; } | private static Collection < TYPE_1 > METHOD_1 ( Collection < TYPE_1 > VAR_1 , Collection < TYPE_1 > VAR_2 , String file ) { for ( TYPE_1 c : VAR_2 ) { String VAR_3 = c . getKey ( ) . METHOD_2 ( ) . METHOD_3 ( ) ; if ( VAR_3 . equals ( file ) ) { VAR_1 . add ( c ) ; } } return VAR_1 ; } |
done | private TYPE_1 METHOD_1 ( ) throws TYPE_2 { try { TYPE_3 r = new TYPE_3 ( in , TYPE_8 . VAR_2 ) ; return TYPE_6 . TYPE_7 . METHOD_2 ( ) . METHOD_3 ( TYPE_5 . toString ( r ) , TYPE_1 . class ) ; } catch <START> ( IOException e ) <END> { throw error ( STRING_1 ) ; } } | private TYPE_1 METHOD_1 ( ) throws TYPE_2 { try ( TYPE_3 r = new TYPE_3 ( in , TYPE_8 . VAR_2 ) ) { return TYPE_6 . TYPE_7 . METHOD_2 ( ) . METHOD_3 ( TYPE_5 . toString ( r ) , TYPE_1 . class ) ; } catch ( IOException e ) { throw error ( STRING_1 ) ; } } |
defensive copy instead | TYPE_3 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 ) { this . VAR_2 = VAR_2 ; <START> this . VAR_3 = VAR_3 ; <END> } | TYPE_3 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 ) { this . VAR_2 = VAR_2 ; this . VAR_3 = new TYPE_2 ( VAR_3 ) ; } |
leave private | <START> protected boolean isEmpty ( ) { <END> return VAR_1 . isEmpty ( ) && VAR_2 . isEmpty ( ) && VAR_3 . isEmpty ( ) && VAR_4 . isEmpty ( ) && status == null && VAR_5 == null && VAR_6 == null ; } | private boolean isEmpty ( ) { return VAR_1 . isEmpty ( ) && VAR_2 . isEmpty ( ) && VAR_3 . isEmpty ( ) && VAR_4 . isEmpty ( ) && status == null && VAR_5 == null && VAR_6 == null ; } |
left diagnostic output | public static synchronized void METHOD_1 ( ) throws IOException { <START> System . out . println ( STRING_1 ) ; <END> for ( File VAR_1 : VAR_2 ) { System . err . println ( STRING_2 + VAR_1 . METHOD_2 ( ) ) ; METHOD_3 ( VAR_1 ) ; } VAR_2 . clear ( ) ; } | public static synchronized void METHOD_1 ( ) throws IOException { for ( File VAR_1 : VAR_2 ) { METHOD_3 ( VAR_1 ) ; } VAR_2 . clear ( ) ; } |
new ArrayList < > ( ) | private List < TYPE_3 . TYPE_5 > METHOD_1 ( String VAR_1 , TYPE_2 < TYPE_3 > VAR_2 ) { List < TYPE_3 . TYPE_5 > VAR_3 = <START> TYPE_4 . METHOD_2 ( ) ; <END> for ( TYPE_3 VAR_4 : VAR_2 ) { if ( VAR_4 . METHOD_3 ( VAR_1 ) ) { VAR_3 . add ( VAR_4 . getKey ( ) ) ; } } return VAR_3 ; } | private List < TYPE_3 . TYPE_5 > METHOD_1 ( String VAR_1 , TYPE_2 < TYPE_3 > VAR_2 ) { List < TYPE_3 . TYPE_5 > VAR_3 = new ArrayList < > ( ) ; for ( TYPE_3 VAR_4 : VAR_2 ) { if ( VAR_4 . METHOD_3 ( VAR_1 ) ) { VAR_3 . add ( VAR_4 . getKey ( ) ) ; } } return VAR_3 ; } |
necessary | <START> public static TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { <END> TYPE_1 p = new TYPE_1 ( ) ; p . name = VAR_1 . getName ( ) ; p . VAR_2 = VAR_1 . METHOD_2 ( ) ; p . VAR_3 = VAR_1 . METHOD_3 ( ) ; p . VAR_4 = VAR_1 . METHOD_4 ( ) ; return p ; } | private static TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { TYPE_1 p = new TYPE_1 ( ) ; p . name = VAR_1 . getName ( ) ; p . VAR_2 = VAR_1 . METHOD_2 ( ) ; p . VAR_3 = VAR_1 . METHOD_3 ( ) ; p . VAR_4 = VAR_1 . METHOD_4 ( ) ; return p ; } |
private _CODE_ static qualifier method order class wrong private methods expected public dave clarified order methods change [ 1 ] i place helper method methods line 146 ps [ 1 ] | <START> private List < TYPE_1 > <END> METHOD_1 ( TYPE_2 < TYPE_1 > VAR_1 , final TYPE_1 . Status status ) throws TYPE_3 { return TYPE_4 . METHOD_2 ( TYPE_5 . filter ( VAR_1 , new TYPE_6 < TYPE_1 > ( ) { @Override public boolean apply ( TYPE_1 input ) { return ( input . getStatus ( ) == status ) ; } } ) ) ; } | private static List < TYPE_1 > METHOD_1 ( TYPE_2 < TYPE_1 > VAR_1 , final TYPE_1 . Status status ) { return TYPE_4 . METHOD_2 ( TYPE_5 . filter ( VAR_1 , new TYPE_6 < TYPE_1 > ( ) { @Override public boolean apply ( TYPE_1 input ) { return ( input . getStatus ( ) == status ) ; } } ) ) ; } |
METHOD_3 ( ) returns list : VAR_1 = VAR_2 METHOD_3 ( db METHOD_4 ( ) ) ; | public Collection < TYPE_1 > METHOD_1 ( ) throws TYPE_2 { if ( VAR_1 == null ) { <START> VAR_1 = TYPE_3 . METHOD_2 ( VAR_2 . METHOD_3 ( db , METHOD_4 ( ) ) ) ; <END> } return VAR_1 ; } | public Collection < TYPE_1 > METHOD_1 ( ) throws TYPE_2 { if ( VAR_1 == null ) { VAR_1 = VAR_2 . METHOD_3 ( db , METHOD_4 ( ) ) ; } return VAR_1 ; } |
removal slash effect dealt | public String METHOD_1 ( String VAR_1 , String path ) throws TYPE_1 { if ( VAR_1 . METHOD_2 ( STRING_1 ) > 0 ) { return new TYPE_2 ( new TYPE_2 ( VAR_1 ) , path ) . METHOD_3 ( ) ; } else { <START> return VAR_1 + ( VAR_1 . METHOD_4 ( STRING_2 ) ? "" : STRING_2 ) <END> + ( path . startsWith ( STRING_2 ) ? path . substring ( 1 ) : path ) ; } } | private static String METHOD_1 ( String VAR_1 , String path ) throws TYPE_1 { return new TYPE_2 ( new TYPE_2 ( VAR_1 ) , path ) . METHOD_3 ( ) ; } |
private static | <START> private List < TYPE_1 > <END> METHOD_1 ( List < TYPE_1 > VAR_1 ) { Collections . VAR_2 ( VAR_1 , TYPE_3 . TYPE_2 ) ; return VAR_1 ; } | private static List < TYPE_1 > METHOD_1 ( List < TYPE_1 > VAR_1 ) { Collections . VAR_2 ( VAR_1 , TYPE_3 . TYPE_2 ) ; return VAR_1 ; } |
Optional : extract a var don t retrieve : line 90 | private static void METHOD_1 ( ) throws TYPE_1 { for ( TYPE_2 < Logger > logger = TYPE_3 . METHOD_2 ( ) ; logger . VAR_1 ( ) ; ) { logger . VAR_2 ( ) . METHOD_3 ( null ) ; } if <START> ( TYPE_4 . METHOD_4 ( System . getProperty ( VAR_3 ) ) ) <END> { TYPE_5 . METHOD_5 ( TYPE_6 . METHOD_6 ( VAR_4 ) ) ; } else { TYPE_5 . METHOD_5 ( new TYPE_7 ( System . getProperty ( VAR_3 ) ) ) ; } } | private static void METHOD_1 ( ) throws TYPE_1 { for ( TYPE_2 < Logger > logger = TYPE_3 . METHOD_2 ( ) ; logger . VAR_1 ( ) ; ) { logger . VAR_2 ( ) . METHOD_3 ( null ) ; } String path = System . getProperty ( VAR_3 ) ; if ( TYPE_4 . METHOD_4 ( path ) ) { TYPE_5 . METHOD_5 ( TYPE_6 . METHOD_6 ( VAR_4 ) ) ; } else { TYPE_5 . METHOD_5 ( new TYPE_7 ( path ) ) ; } } |
need builder ( ) done | private static TYPE_1 METHOD_1 ( String name , int value ) { TYPE_2 VAR_1 = new TYPE_2 ( TYPE_3 . VAR_2 ) ; TYPE_4 builder = new TYPE_4 ( ) ; builder . append ( VAR_1 ) ; <START> TYPE_3 . METHOD_2 ( value , 0 , builder ) ; <END> return new TYPE_1 ( name , VAR_1 ) ; } | private static TYPE_1 METHOD_1 ( String name , int value ) { TYPE_4 builder = new TYPE_4 ( ) ; TYPE_3 . METHOD_2 ( value , 0 , builder ) ; return new TYPE_1 ( name , builder . get ( ) ) ; } |
optional : inlined line | public void METHOD_1 ( TYPE_1 event ) { TYPE_4 . TYPE_3 <START> p = <END> new TYPE_3 ( event . VAR_1 ( ) ) ; VAR_2 . METHOD_2 ( p ) ; } | public void METHOD_1 ( TYPE_1 event ) { VAR_2 . METHOD_2 ( new TYPE_4 . TYPE_3 ( event . VAR_1 ( ) ) ) ; } |
I don t final place anymore | private boolean METHOD_1 ( Collection < TYPE_1 > VAR_1 ) { for <START> ( final TYPE_1 <END> cmd : VAR_1 ) { if ( cmd . getType ( ) != TYPE_1 . Type . VAR_2 ) return true ; } return false ; } | private boolean METHOD_1 ( Collection < TYPE_1 > VAR_1 ) { for ( TYPE_1 cmd : VAR_1 ) { if ( cmd . getType ( ) != TYPE_1 . Type . VAR_2 ) return true ; } return false ; } |
happen ? care | private TYPE_4 ( String p , String f , String r ) { project = <START> p != null ? <END> new TYPE_2 . TYPE_3 ( p ) : null ; file = f ; VAR_2 = r ; } | private TYPE_4 ( String p , String f , String r ) { project = new TYPE_2 . TYPE_3 ( p ) ; file = f ; VAR_2 = r ; } |
needed | <START> public TYPE_5 ( TYPE_3 . TYPE_4 <END> project , String r , TYPE_2 VAR_2 ) { this . project = project ; this . resource = r ; this . VAR_2 = VAR_2 ; } | TYPE_5 ( TYPE_3 . TYPE_4 project , String r , TYPE_2 VAR_2 ) { this . project = project ; this . resource = r ; this . VAR_2 = VAR_2 ; } |
bug : format string %s needs argument 1 0 provided | private TYPE_1 METHOD_1 ( String VAR_1 , TYPE_2 VAR_2 ) { try { ANNOTATION_1 ( STRING_1 ) Class < ? extends TYPE_1 > VAR_3 = ( Class < ? extends TYPE_1 > ) Class . VAR_4 ( VAR_1 ) ; return VAR_2 . getInstance ( VAR_3 ) ; } catch ( TYPE_3 e ) { throw new RuntimeException ( <START> String . format ( STRING_2 ) , e ) ; <END> } } | private TYPE_1 METHOD_1 ( String VAR_1 , TYPE_2 VAR_2 ) { try { ANNOTATION_1 ( STRING_1 ) Class < ? extends TYPE_1 > VAR_3 = ( Class < ? extends TYPE_1 > ) Class . VAR_4 ( VAR_1 ) ; return VAR_2 . getInstance ( VAR_3 ) ; } catch ( TYPE_3 e ) { throw new RuntimeException ( String . format ( STRING_2 , VAR_1 ) , e ) ; } } |
VAR_3 + 1 depending side effect | private TYPE_1 METHOD_1 ( TYPE_2 VAR_1 , TYPE_3 VAR_2 ) throws IOException , TYPE_4 { try { int VAR_3 = VAR_2 . getName ( ) . METHOD_2 ( STRING_1 ) ; String VAR_4 = <START> VAR_2 . getName ( ) . substring ( ++ VAR_3 ) ; <END> return db . get ( ) . METHOD_3 ( ) . get ( new TYPE_1 . TYPE_7 ( VAR_1 . getId ( ) , Integer . valueOf ( VAR_4 ) ) ) ; } catch ( TYPE_6 e ) { throw new IOException ( e ) ; } } | private TYPE_1 METHOD_1 ( TYPE_2 VAR_1 , TYPE_3 VAR_2 ) throws IOException , TYPE_4 { try { int VAR_3 = VAR_2 . getName ( ) . METHOD_2 ( STRING_1 ) ; String VAR_4 = VAR_2 . getName ( ) . substring ( VAR_3 + 1 ) ; return db . get ( ) . METHOD_3 ( ) . get ( new TYPE_1 . TYPE_7 ( VAR_1 . getId ( ) , Integer . valueOf ( VAR_4 ) ) ) ; } catch ( TYPE_6 e ) { throw new IOException ( e ) ; } } |
_CODE_ < ? extends Set < String > > | public <START> Response < TYPE_1 < String > > apply ( TYPE_2 <END> req ) throws TYPE_3 , TYPE_4 , IOException , TYPE_5 { TYPE_6 VAR_1 = req . VAR_2 ( ) ; TYPE_7 VAR_3 = VAR_1 . METHOD_1 ( ) . METHOD_2 ( ) ; Set < String > VAR_4 = VAR_3 . METHOD_3 ( ) ; if ( VAR_4 == null ) { VAR_4 = TYPE_8 . of ( ) ; } return Response . VAR_5 ( new TYPE_1 < String > ( VAR_4 ) ) ; } | public Response < ? extends Set < String > > apply ( TYPE_2 req ) throws TYPE_3 , TYPE_4 , IOException , TYPE_5 { TYPE_6 VAR_1 = req . VAR_2 ( ) ; TYPE_7 VAR_3 = VAR_1 . METHOD_1 ( ) . METHOD_2 ( ) ; Set < String > VAR_4 = VAR_3 . METHOD_3 ( ) ; if ( VAR_4 == null ) { VAR_4 = TYPE_8 . of ( ) ; } return Response . VAR_5 ( new TYPE_1 < String > ( VAR_4 ) ) ; } |
event java7 : new HashSet < > ( ) ; | public Set < TYPE_3 . TYPE_4 > METHOD_1 ( ) { Set < TYPE_3 . TYPE_4 > result = new <START> HashSet < TYPE_3 . TYPE_4 > ( ) ; <END> for ( TYPE_2 p : METHOD_2 ( ) ) { result . addAll ( p . VAR_1 ) ; } return result ; } | public Set < TYPE_3 . TYPE_4 > METHOD_1 ( ) { Set < TYPE_3 . TYPE_4 > result = new HashSet < > ( ) ; for ( TYPE_2 p : METHOD_2 ( ) ) { result . addAll ( p . VAR_1 ) ; } return result ; } |
string retrieved VAR_2 #test1 #test2 remove VAR_1 VAR_1 check _CODE_ instead | void METHOD_1 ( TYPE_1 e ) { String VAR_1 = VAR_2 . METHOD_2 ( ) ; <START> while ( VAR_1 . startsWith ( STRING_1 ) ) { <END> VAR_1 = VAR_1 . substring ( 1 ) ; } if ( ! VAR_1 . isEmpty ( ) ) { METHOD_3 ( VAR_1 ) ; } } | void METHOD_1 ( TYPE_1 e ) { String VAR_1 = VAR_2 . METHOD_2 ( ) ; if ( ! VAR_1 . isEmpty ( ) ) { METHOD_3 ( VAR_1 ) ; } } |
public static _CODE_ public irrelevant visible class package access skip public keyword | <START> static public void METHOD_1 ( int <END> value ) { VAR_1 . set ( value ) ; } | static void METHOD_1 ( int value ) { VAR_1 . set ( value ) ; } |
done | <START> static public void METHOD_1 ( ) <END> { VAR_1 . remove ( ) ; } | static void METHOD_1 ( ) { VAR_1 . remove ( ) ; } |
aren t static strings held reused ? shouldn t charge weight merge strategy string actual memory entry pointer sized string length | public int METHOD_1 ( TYPE_1 VAR_1 , Boolean v ) { return INT_1 + 2 * ( INT_1 + INT_2 ) + INT_3 + INT_3 + <START> 2 * VAR_1 . VAR_2 . length ( ) <END> + 1 ; } | public int METHOD_1 ( TYPE_1 VAR_1 , Boolean v ) { return INT_1 + 2 * ( INT_1 + INT_2 ) + 4 * INT_3 + 1 ; } |
unneeded change _CODE_ package | <START> public static <END> TYPE_1 METHOD_1 ( TYPE_5 . TYPE_6 id , int VAR_1 ) { TYPE_1 VAR_2 = new TYPE_1 ( null , null , null , null , null , null , null , null , null , null , null , null , null , id ) ; VAR_2 . VAR_3 = new TYPE_3 ( new TYPE_3 . TYPE_6 ( id , VAR_1 ) ) ; return VAR_2 ; } | static TYPE_1 METHOD_1 ( TYPE_5 . TYPE_6 id , int VAR_1 ) { TYPE_1 VAR_2 = new TYPE_1 ( null , null , null , null , null , null , null , null , null , null , null , null , null , id ) ; VAR_2 . VAR_3 = new TYPE_3 ( new TYPE_3 . TYPE_6 ( id , VAR_1 ) ) ; return VAR_2 ; } |
e = = null | private List < TYPE_1 > METHOD_1 ( String err , Exception e ) { if ( VAR_1 ) { if <START> ( err == null ) { <END> log . error ( err ) ; } else { log . error ( err , e ) ; } return METHOD_2 ( ) ; } else { return METHOD_3 ( err ) ; } } | private List < TYPE_1 > METHOD_1 ( String err , Exception e ) { if ( VAR_1 ) { if ( e == null ) { log . error ( err ) ; } else { log . error ( err , e ) ; } return METHOD_2 ( ) ; } else { return METHOD_3 ( err ) ; } } |
inline method private | <START> public void METHOD_1 ( ) throws IOException { VAR_1 = TYPE_1 . parse ( METHOD_2 ( TYPE_1 . VAR_2 ) , this ) ; } <END> | private void METHOD_1 ( ) throws IOException { VAR_1 = TYPE_1 . parse ( METHOD_2 ( TYPE_1 . VAR_2 ) , this ) ; } |
done | public boolean METHOD_1 ( TYPE_1 name ) { boolean VAR_1 ; if ( VAR_2 . isEmpty ( ) ) { VAR_1 = true ; } else { VAR_1 = false ; String VAR_3 = name . get ( ) ; for ( String VAR_4 : VAR_2 ) { VAR_1 = METHOD_2 ( VAR_3 , VAR_4 ) ; if ( VAR_1 ) { break ; } } } <START> return VAR_1 ; <END> } | public boolean METHOD_1 ( TYPE_1 name ) { if ( VAR_2 . isEmpty ( ) ) { return true ; } else { String VAR_3 = name . get ( ) ; for ( String VAR_4 : VAR_2 ) { if ( METHOD_2 ( VAR_3 , VAR_4 ) ) { return true ; } } } return false ; } |
thrown | public TYPE_1 apply ( TYPE_2 VAR_1 ) throws TYPE_3 , IOException , <START> TYPE_4 , TYPE_5 , <END> TYPE_6 { Optional < TYPE_7 > VAR_2 = VAR_3 . METHOD_1 ( VAR_1 . METHOD_2 ( ) ) ; String m = VAR_2 . isPresent ( ) ? VAR_2 . get ( ) . METHOD_3 ( ) . METHOD_4 ( ) : VAR_4 . getMessage ( VAR_1 . METHOD_2 ( ) ) ; return TYPE_1 . create ( m ) . METHOD_5 ( ) ; } | public TYPE_1 apply ( TYPE_2 VAR_1 ) throws TYPE_3 , IOException , TYPE_5 , TYPE_6 { Optional < TYPE_7 > VAR_2 = VAR_3 . METHOD_1 ( VAR_1 . METHOD_2 ( ) ) ; String m = VAR_2 . isPresent ( ) ? VAR_2 . get ( ) . METHOD_3 ( ) . METHOD_4 ( ) : VAR_4 . getMessage ( VAR_1 . METHOD_2 ( ) ) ; return TYPE_1 . create ( m ) . METHOD_5 ( ) ; } |
METHOD_1 ( VAR_2 ) | public TYPE_2 ( TYPE_1 VAR_2 , String VAR_3 ) { <START> this . VAR_2 = VAR_2 ; <END> this . VAR_3 = METHOD_1 ( VAR_3 ) ; } | public TYPE_2 ( TYPE_1 VAR_2 , String VAR_3 ) { this . VAR_2 = METHOD_1 ( VAR_2 ) ; this . VAR_3 = METHOD_1 ( VAR_3 ) ; } |
optional s default java doesn t dumb treat leading 0s octal | public static TYPE_2 . TYPE_3 METHOD_1 ( String VAR_1 ) { int d = VAR_1 . METHOD_2 ( CHAR_1 ) ; return new TYPE_2 . TYPE_3 ( Integer . parseInt ( VAR_1 . substring ( d + <START> 1 ) , 10 ) ) ; <END> } | public static TYPE_2 . TYPE_3 METHOD_1 ( String VAR_1 ) { int d = VAR_1 . METHOD_2 ( CHAR_1 ) ; return new TYPE_2 . TYPE_3 ( Integer . parseInt ( VAR_1 . substring ( d + 1 ) ) ) ; } |
return unexpected method doesn t render _CODE_ reason instantiate TYPE_1 return VAR_2 | public <START> TYPE_1 METHOD_1 ( TYPE_2 <END> c ) { METHOD_2 ( ) ; VAR_1 = c ; try { METHOD_3 ( ) ; TYPE_1 result = new TYPE_1 ( ) ; result . VAR_2 = VAR_2 ; return result ; } finally { if ( VAR_3 != null ) { VAR_3 . METHOD_4 ( ) ; } if ( repo != null ) { repo . close ( ) ; } } } | public List < String > METHOD_1 ( TYPE_2 c ) { METHOD_2 ( ) ; VAR_1 = c ; try { METHOD_3 ( ) ; return VAR_2 ; } finally { if ( VAR_3 != null ) { VAR_3 . METHOD_4 ( ) ; } if ( repo != null ) { repo . close ( ) ; } } } |
I prefer written : CHAR_8 < = VAR_1 && VAR_1 < = char_9as closer mathematical notation : CHAR_8 < = VAR_1 < = char_9looking codebase places pattern 2 lines | static boolean METHOD_1 ( final int VAR_1 ) { switch ( VAR_1 ) { case CHAR_1 : case CHAR_2 : case CHAR_3 : case CHAR_4 : case CHAR_5 : case CHAR_6 : case CHAR_7 : return false ; default : if <START> ( ( VAR_1 >= CHAR_8 && VAR_1 <= CHAR_9 ) <END> || ( VAR_1 >= CHAR_10 && VAR_1 <= CHAR_11 ) || ( VAR_1 >= CHAR_12 && VAR_1 <= CHAR_13 ) ) { return false ; } else { return true ; } } } | static boolean METHOD_1 ( final int VAR_1 ) { switch ( VAR_1 ) { case CHAR_1 : case CHAR_2 : case CHAR_3 : case CHAR_4 : case CHAR_5 : case CHAR_6 : case CHAR_7 : return false ; default : if ( ( CHAR_8 <= VAR_1 && VAR_1 <= CHAR_9 ) || ( CHAR_10 <= VAR_1 && VAR_1 <= CHAR_11 ) || ( CHAR_12 <= VAR_1 && VAR_1 <= CHAR_13 ) ) { return false ; } else { return true ; } } } |
( ! ( req VAR_1 ( ) equals ( STRING_1 ) || req VAR_1 ( ) equals ( STRING_2 ) ) ) | private static void METHOD_1 ( TYPE_1 req ) throws TYPE_2 { <START> if ( ! STRING_1 . equals ( req . VAR_1 ( ) ) && ! STRING_2 . equals ( req . VAR_1 ( ) ) ) { <END> throw new TYPE_2 ( ) ; } } | private static void METHOD_1 ( TYPE_1 req ) throws TYPE_2 { if ( ! ( STRING_1 . equals ( req . VAR_1 ( ) ) || STRING_2 . equals ( req . VAR_1 ( ) ) ) ) { throw new TYPE_2 ( ) ; } } |
rename path consistent parameter METHOD_6 | public void METHOD_1 ( TYPE_1 VAR_1 ) { String VAR_2 = TYPE_2 . METHOD_2 ( VAR_1 . METHOD_3 ( 1 ) ) ; String <START> VAR_3 = <END> TYPE_2 . METHOD_2 ( VAR_1 . METHOD_3 ( 2 ) ) ; VAR_1 . METHOD_4 ( new TYPE_3 ( VAR_2 , STRING_1 , VAR_3 ) ) ; VAR_1 . METHOD_5 ( METHOD_6 ( VAR_3 ) ) ; } | public void METHOD_1 ( TYPE_1 VAR_1 ) { String VAR_2 = TYPE_2 . METHOD_2 ( VAR_1 . METHOD_3 ( 1 ) ) ; String path = TYPE_2 . METHOD_2 ( VAR_1 . METHOD_3 ( 2 ) ) ; VAR_1 . METHOD_4 ( new TYPE_3 ( VAR_2 , STRING_1 , path ) ) ; VAR_1 . METHOD_5 ( METHOD_6 ( path ) ) ; } |
I wrap user code : ( VAR_1 ) { return VAR_3 ( ) } return Integer VAR_2 ; | private int METHOD_1 ( ) { <START> if ( ! VAR_1 ) { return Integer . VAR_2 ; } return VAR_3 . get ( ) . METHOD_2 ( ) . METHOD_3 ( TYPE_1 . VAR_5 ) . METHOD_4 ( ) ; <END> } | private int METHOD_1 ( ) { if ( VAR_1 ) { return VAR_3 . get ( ) . METHOD_2 ( ) . METHOD_3 ( TYPE_1 . VAR_5 ) . METHOD_4 ( ) ; } return Integer . VAR_2 ; } |
toggling edit mode file table doesn t imply a change edit : post reviews | void METHOD_1 ( ANNOTATION_1 ( STRING_1 ) TYPE_1 e ) { VAR_1 = TYPE_3 . TYPE_2 . VAR_4 ; METHOD_2 ( ) ; VAR_5 . METHOD_3 ( false ) ; <START> VAR_6 . METHOD_3 ( false ) ; <END> VAR_7 . METHOD_3 ( true ) ; VAR_8 . METHOD_3 ( true ) ; } | void METHOD_1 ( ANNOTATION_1 ( STRING_1 ) TYPE_1 e ) { VAR_1 = TYPE_3 . TYPE_2 . VAR_4 ; METHOD_2 ( ) ; VAR_5 . METHOD_3 ( false ) ; VAR_7 . METHOD_3 ( true ) ; VAR_8 . METHOD_3 ( true ) ; } |
exceptions unsed Exception real code unit tests | public Object apply ( TYPE_1 VAR_1 ) throws <START> TYPE_2 , TYPE_3 , TYPE_4 , Exception { <END> return Response . VAR_2 ( VAR_3 . get ( ) . format ( VAR_1 ) ) ; } | public Object apply ( TYPE_1 VAR_1 ) { return Response . VAR_2 ( VAR_3 . format ( VAR_1 ) ) ; } |
_CODE_ returning a _CODE_ ? actions revision sounds a Map < String _CODE_ > | public Object apply ( TYPE_1 VAR_1 ) throws TYPE_2 , TYPE_3 , TYPE_4 , Exception { <START> return Response . VAR_2 ( VAR_3 . format ( VAR_1 ) ) ; <END> } | public Object apply ( TYPE_1 VAR_1 ) throws TYPE_2 , TYPE_3 , TYPE_4 , Exception { return Response . VAR_2 ( VAR_3 . get ( ) . format ( VAR_1 ) ) ; } |
local variable necessary instead : return true ; | private boolean METHOD_1 ( TYPE_1 db , TYPE_6 . TYPE_7 VAR_1 , TYPE_5 . TYPE_8 key ) throws TYPE_4 { boolean VAR_2 = false ; for ( TYPE_5 id : db . VAR_3 ( ) . METHOD_2 ( VAR_1 ) ) { if ( id . getKey ( ) . equals ( key ) ) { <START> VAR_2 = true ; break ; <END> } } return VAR_2 ; } | private boolean METHOD_1 ( TYPE_1 db , TYPE_6 . TYPE_7 VAR_1 , TYPE_5 . TYPE_8 key ) throws TYPE_4 { boolean VAR_2 = false ; for ( TYPE_5 id : db . VAR_3 ( ) . METHOD_2 ( VAR_1 ) ) { if ( id . getKey ( ) . equals ( key ) ) { return true ; } } return false ; } |
alphabetize | public TYPE_1 [ ] METHOD_1 ( ) { return new TYPE_1 [ ] { METHOD_2 ( ) , METHOD_3 ( ) , <START> METHOD_4 ( ) , <END> } ; } | public TYPE_1 [ ] METHOD_1 ( ) { return new TYPE_1 [ ] { METHOD_4 ( ) , METHOD_3 ( ) , METHOD_2 ( ) , } ; } |
VAR_2 null NPE METHOD_4 method | public void execute ( ) throws TYPE_1 , TYPE_2 { try { METHOD_1 ( ) ; METHOD_2 ( ) ; METHOD_3 ( ) ; VAR_1 . METHOD_4 ( project , <START> VAR_2 ) ; <END> METHOD_5 ( ) ; } catch ( TYPE_1 | TYPE_2 e ) { throw e ; } catch ( Exception e ) { TYPE_3 . METHOD_6 ( e ) ; throw new TYPE_1 ( e ) ; } } | public void execute ( ) throws TYPE_1 , TYPE_2 { try { METHOD_1 ( ) ; METHOD_2 ( ) ; METHOD_3 ( ) ; if ( VAR_2 != null ) { VAR_1 . METHOD_4 ( project , VAR_2 ) ; } METHOD_5 ( ) ; } catch ( TYPE_1 | TYPE_2 e ) { throw e ; } catch ( Exception e ) { TYPE_3 . METHOD_6 ( e ) ; throw new TYPE_1 ( e ) ; } } |
method static | <START> private int METHOD_1 ( final TYPE_1 VAR_1 ) { <END> long VAR_2 = TYPE_2 . METHOD_2 ( VAR_1 , STRING_1 , null , STRING_2 , VAR_3 , TimeUnit . VAR_4 ) ; if ( VAR_2 < 0 ) { return 0 ; } return ( int ) VAR_2 ; } | private static int METHOD_1 ( final TYPE_1 VAR_1 ) { long VAR_2 = TYPE_2 . METHOD_2 ( VAR_1 , STRING_1 , null , STRING_2 , VAR_3 , TimeUnit . VAR_4 ) ; if ( VAR_2 < 0 ) { return 0 ; } return ( int ) VAR_2 ; } |
unnecessary lines perform a test null result | public synchronized void METHOD_1 ( TYPE_1 key ) { <START> if ( VAR_1 . containsKey ( key ) ) { <END> TYPE_2 VAR_2 = VAR_1 . get ( key ) ; if ( VAR_2 != null ) { VAR_2 . METHOD_2 ( ) ; if ( VAR_2 . METHOD_3 ( ) < 1 ) { VAR_1 . remove ( key ) ; } } } } | public synchronized void METHOD_1 ( TYPE_1 key ) { TYPE_2 VAR_2 = VAR_1 . get ( key ) ; if ( VAR_2 != null ) { VAR_2 . METHOD_2 ( ) ; if ( VAR_2 . METHOD_3 ( ) < 1 ) { VAR_1 . remove ( key ) ; } } } |
equals ( ) | private TYPE_1 METHOD_1 ( ) { for ( final TYPE_1 VAR_1 : VAR_2 ) <START> if ( METHOD_2 ( VAR_1 ) == Constants . VAR_3 ) <END> return VAR_1 ; return VAR_2 . get ( 0 ) ; } | private TYPE_1 METHOD_1 ( ) { for ( final TYPE_1 VAR_1 : VAR_2 ) if ( Constants . VAR_3 . equals ( METHOD_2 ( VAR_1 ) ) ) return VAR_1 ; return VAR_2 . get ( 0 ) ; } |
style - : don t call super arguments | protected TYPE_2 ( int VAR_2 , int VAR_3 , int VAR_4 , TYPE_1 VAR_5 ) { <START> super ( ) ; <END> this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; this . VAR_4 = VAR_4 ; this . VAR_5 = VAR_5 ; } | protected TYPE_2 ( int VAR_2 , int VAR_3 , int VAR_4 , TYPE_1 VAR_5 ) { this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; this . VAR_4 = VAR_4 ; this . VAR_5 = VAR_5 ; } |
VAR_4 redundant local variablesl necessary | public TYPE_3 ( TYPE_1 repo , TYPE_2 VAR_2 , boolean VAR_3 ) { this . VAR_2 = VAR_2 ; this . repo = repo ; <START> VAR_4 = VAR_2 . METHOD_1 ( ) ; <END> this . VAR_3 = VAR_3 ; VAR_5 = Constants . VAR_6 + VAR_4 ; } | public TYPE_3 ( TYPE_1 repo , TYPE_2 VAR_2 , boolean VAR_3 ) { this . VAR_2 = VAR_2 ; this . repo = repo ; this . VAR_3 = VAR_3 ; } |
more straightforward VAR_1 = = null ? ( isn t C ) | public void METHOD_1 ( TYPE_1 VAR_1 ) { <START> if ( null == VAR_1 ) { <END> return ; } for ( int i = 0 ; i < VAR_2 . size ( ) ; i ++ ) if ( VAR_1 . equals ( VAR_2 . get ( i ) . VAR_1 ) ) { VAR_3 . METHOD_2 ( i ) ; break ; } } | public void METHOD_1 ( TYPE_1 VAR_1 ) { if ( VAR_1 == null ) { return ; } for ( int i = 0 ; i < VAR_2 . size ( ) ; i ++ ) if ( VAR_1 . equals ( VAR_2 . get ( i ) . VAR_1 ) ) { VAR_3 . METHOD_2 ( i ) ; break ; } } |
style - : I I prefer defined : public TYPE_1 METHOD_1 ( String String VAR_1 ) { return METHOD_1 ( new TYPE_2 ( VAR_1 ) ) ; } | public TYPE_1 METHOD_1 ( String name , String VAR_1 ) { <START> this . VAR_2 = new TYPE_2 ( name , VAR_1 ) ; <END> return this ; } | public TYPE_1 METHOD_1 ( String name , String VAR_1 ) { return METHOD_1 ( new TYPE_2 ( name , VAR_1 ) ) ; } |
style - : don t put parens return : return new TYPE_1 ( ) ; | public TYPE_1 commit ( ) { <START> return ( new TYPE_1 ( this ) ) ; <END> } | public TYPE_1 commit ( ) { return new TYPE_1 ( this ) ; } |
style : extra parentheses | public TYPE_1 log ( ) { <START> return ( new TYPE_1 ( this ) ) ; <END> } | public TYPE_1 log ( ) { return new TYPE_1 ( this ) ; } |
style : extra parentheses | public TYPE_1 METHOD_1 ( ) { <START> return ( repo ) ; <END> } | public TYPE_1 METHOD_1 ( ) { return repo ; } |
API null returned check | public void execute ( TYPE_1 action ) { <START> TYPE_2 view = TYPE_3 . METHOD_1 ( TYPE_4 . METHOD_2 ( ) , METHOD_3 ( ) [ 0 ] , null ) ; <END> TYPE_5 page = view . VAR_1 ( ) ; if ( page instanceof TYPE_6 ) { TYPE_6 VAR_2 = ( TYPE_6 ) page ; VAR_2 . METHOD_4 ( true ) ; } } | public void execute ( TYPE_1 action ) { TYPE_2 view = TYPE_3 . METHOD_1 ( TYPE_4 . METHOD_2 ( ) , METHOD_3 ( ) [ 0 ] , null ) ; if ( view == null ) return ; TYPE_5 page = view . VAR_1 ( ) ; if ( page instanceof TYPE_6 ) { TYPE_6 VAR_2 = ( TYPE_6 ) page ; VAR_2 . METHOD_4 ( true ) ; } } |
I willing bet a beer time meet person : ( ! VAR_1 METHOD_2 ( ) ) break ; faster a system call read directory contents operating system forbidden letting remove a directory long file / directory accomplish tasks system call METHOD_2 aborting soon doesn t work | private void METHOD_1 ( File f ) { File VAR_1 = f . VAR_2 ( ) ; while ( ! VAR_1 . equals ( repo . VAR_3 ( ) ) ) { <START> if ( VAR_1 . list ( ) . length == 0 ) <END> VAR_1 . METHOD_2 ( ) ; else break ; VAR_1 = VAR_1 . METHOD_3 ( ) ; } } | private void METHOD_1 ( File f ) { File VAR_1 = f . VAR_2 ( ) ; while ( ! VAR_1 . equals ( repo . VAR_3 ( ) ) ) { if ( ! VAR_1 . METHOD_2 ( ) ) break ; VAR_1 = VAR_1 . METHOD_3 ( ) ; } } |
throw IOException IllegalStateException _CODE_ ( ) ? throw type consistently | public TYPE_1 METHOD_1 ( ) throws IOException { if ( METHOD_2 ( ) ) <START> throw new IOException ( <END> TYPE_2 . get ( ) . VAR_1 ) ; if ( index == null ) { index = new TYPE_1 ( this ) ; index . read ( ) ; } else { index . VAR_2 ( ) ; } return index ; } | public TYPE_1 METHOD_1 ( ) throws IOException , IllegalStateException { if ( METHOD_2 ( ) ) throw new IOException ( TYPE_2 . get ( ) . VAR_1 ) ; if ( index == null ) { index = new TYPE_1 ( this ) ; index . read ( ) ; } else { index . VAR_2 ( ) ; } return index ; } |
logic constructor I simplify method : public boolean METHOD_1 ( ) { return VAR_6 = = null ; } | public boolean METHOD_1 ( ) { boolean VAR_1 = METHOD_2 ( ) . getString ( TYPE_1 . VAR_3 , null , TYPE_1 . VAR_4 ) != null ; if ( VAR_1 ) return METHOD_2 ( ) . METHOD_3 ( TYPE_1 . VAR_3 , TYPE_1 . VAR_4 , false ) ; if ( VAR_5 && VAR_6 == null ) return true ; if ( METHOD_4 ( ) . getName ( ) . equals ( Constants . VAR_7 ) ) return false ; <START> return true ; <END> } | public boolean METHOD_1 ( ) { return VAR_6 == null ; } |
style : braces single line | public void METHOD_1 ( TYPE_1 event ) { <START> if ( event . getType ( ) == TYPE_1 . VAR_1 ) { <END> state = true ; } } | public void METHOD_1 ( TYPE_1 event ) { if ( event . getType ( ) == TYPE_1 . VAR_1 ) state = true ; } |
style : braces single line | public boolean METHOD_1 ( String VAR_1 ) { TYPE_1 table = VAR_2 . table ( 0 ) ; int VAR_3 = METHOD_2 ( ) ; for ( int i = 0 ; i < VAR_3 ; i ++ ) { String VAR_4 = table . VAR_5 ( i ) . METHOD_3 ( ) ; <START> if ( VAR_4 . contains ( VAR_1 ) ) { <END> return true ; } } return false ; } | public boolean METHOD_1 ( String VAR_1 ) { TYPE_1 table = VAR_2 . table ( 0 ) ; int VAR_3 = METHOD_2 ( ) ; for ( int i = 0 ; i < VAR_3 ; i ++ ) { String VAR_4 = table . VAR_5 ( i ) . METHOD_3 ( ) ; if ( VAR_4 . contains ( VAR_1 ) ) return true ; } return false ; } |
style : braces single line | private String METHOD_1 ( TYPE_1 repo , TYPE_2 VAR_1 ) { String VAR_2 = repo . VAR_3 ( ) . toString ( ) ; if ( ! STRING_1 . equals ( File . VAR_4 ) ) { VAR_2 = VAR_2 . METHOD_2 ( File . VAR_5 , CHAR_1 ) ; } String VAR_6 = VAR_1 . METHOD_3 ( ) . toString ( ) ; VAR_6 = VAR_6 . METHOD_2 ( VAR_2 , "" ) ; <START> if ( VAR_6 . startsWith ( STRING_1 ) ) { <END> VAR_6 = VAR_6 . substring ( 1 ) ; } return VAR_6 ; } | private String METHOD_1 ( TYPE_1 repo , TYPE_2 VAR_1 ) { String VAR_2 = repo . VAR_3 ( ) . toString ( ) ; if ( ! STRING_1 . equals ( File . VAR_4 ) ) { VAR_2 = VAR_2 . METHOD_2 ( File . VAR_5 , CHAR_1 ) ; } String VAR_6 = VAR_1 . METHOD_3 ( ) . toString ( ) ; VAR_6 = VAR_6 . METHOD_2 ( VAR_2 , "" ) ; if ( VAR_6 . startsWith ( STRING_1 ) ) VAR_6 = VAR_6 . substring ( 1 ) ; return VAR_6 ; } |
style : braces single line | public void METHOD_1 ( TYPE_1 resource , int VAR_1 ) throws TYPE_2 { <START> if ( ! VAR_2 . METHOD_2 ( resource . VAR_3 ( ) ) . METHOD_3 ( ) ) { <END> VAR_4 . METHOD_4 ( resource , VAR_1 ) ; } } | public void METHOD_1 ( TYPE_1 resource , int VAR_1 ) throws TYPE_2 { if ( ! VAR_2 . METHOD_2 ( resource . VAR_3 ( ) ) . METHOD_3 ( ) ) VAR_4 . METHOD_4 ( resource , VAR_1 ) ; } |
performance - : pull VAR_1 [ VAR_2 ] a local variable evaluated | protected int METHOD_1 ( final byte [ ] VAR_1 , int VAR_2 , final int VAR_3 ) { int VAR_4 = INT_1 ; for ( ; VAR_2 < VAR_3 ; VAR_2 ++ ) { <START> if ( ! TYPE_1 . METHOD_2 ( VAR_1 [ VAR_2 ] ) ) { <END> VAR_4 = ( VAR_4 < < 5 ) ^ ( VAR_1 [ VAR_2 ] & INT_2 ) ; } } return VAR_4 ; } | protected int METHOD_1 ( final byte [ ] VAR_1 , int VAR_2 , final int VAR_3 ) { int VAR_4 = INT_1 ; for ( ; VAR_2 < VAR_3 ; VAR_2 ++ ) { byte c = VAR_1 [ VAR_2 ] ; if ( ! METHOD_2 ( c ) ) VAR_4 = ( VAR_4 < < 5 ) ^ ( c & INT_2 ) ; } return VAR_4 ; } |
please don t move line constructor essential patch | TYPE_3 ( final byte [ ] b , final int offset ) { <START> VAR_2 = TYPE_1 . VAR_4 ; <END> buf = b ; VAR_5 = offset ; VAR_6 = TYPE_2 . VAR_8 ; } | TYPE_3 ( final byte [ ] b , final int offset ) { buf = b ; VAR_5 = offset ; VAR_2 = TYPE_1 . VAR_4 ; VAR_6 = TYPE_2 . VAR_8 ; } |
I error statement : java lang IllegalStateException : repository _CODE_ new TYPE_3 ( repository repository ) instead ? created instance TYPE_1 | public void METHOD_1 ( ) throws Exception { super . METHOD_1 ( ) ; VAR_1 = project . project ; if ( ! VAR_2 . exists ( ) ) new TYPE_1 ( VAR_2 ) . create ( ) ; <START> new TYPE_2 ( VAR_1 , VAR_2 ) . execute ( null ) ; <END> VAR_3 = new TYPE_3 ( VAR_2 ) ; VAR_3 . METHOD_2 ( VAR_1 ) ; repo = TYPE_4 . METHOD_3 ( VAR_1 ) . METHOD_4 ( ) ; } | public void METHOD_1 ( ) throws Exception { super . METHOD_1 ( ) ; VAR_1 = project . project ; VAR_3 = new TYPE_3 ( VAR_2 ) ; VAR_3 . METHOD_2 ( VAR_1 ) ; repo = TYPE_4 . METHOD_3 ( VAR_1 ) . METHOD_4 ( ) ; } |
style - : a static method | <START> private TYPE_1 METHOD_1 ( TYPE_1 VAR_1 , List < TYPE_1 > list ) { <END> TYPE_1 VAR_2 = null ; int VAR_3 = - 1 ; for ( TYPE_1 d : list ) { if ( METHOD_2 ( METHOD_3 ( d ) , METHOD_3 ( VAR_1 ) ) ) { int VAR_4 = TYPE_2 . METHOD_4 ( path ( d ) , path ( VAR_1 ) ) ; if ( VAR_4 > VAR_3 ) { VAR_2 = d ; VAR_3 = VAR_4 ; } } } return VAR_2 ; } | private static TYPE_1 METHOD_1 ( TYPE_1 VAR_1 , List < TYPE_1 > list ) { TYPE_1 VAR_2 = null ; int VAR_3 = - 1 ; for ( TYPE_1 d : list ) { if ( METHOD_2 ( METHOD_3 ( d ) , METHOD_3 ( VAR_1 ) ) ) { int VAR_4 = TYPE_2 . METHOD_4 ( path ( d ) , path ( VAR_1 ) ) ; if ( VAR_4 > VAR_3 ) { VAR_2 = d ; VAR_3 = VAR_4 ; } } } return VAR_2 ; } |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.