Datasets:
YabTad
/
CodeRev

Dataset card Data Studio Files
xet
 Community
ReviewComments
stringlengths
1
2.35k
OriginalCode
stringlengths
28
487
ReviewedCode
stringlengths
14
463
null : List < TYPE_1 > result = VAR_1 METHOD_2 ( null ) ;
public void METHOD_1 ( ) { <START> List < TYPE_1 > result = VAR_1 . METHOD_2 ( TYPE_2 . METHOD_3 ( - 1 ) ) ; <END> METHOD_4 ( result ) ; }
public void METHOD_1 ( ) { List < TYPE_1 > result = VAR_1 . METHOD_2 ( null ) ; METHOD_4 ( result ) ; }
I more easy read common code structure : switch ( METHOD_2 ( ) ) { case TYPE_2 : return METHOD_3 ( )
public TYPE_1 METHOD_1 ( ) { <START> if ( TYPE_2 . equals ( METHOD_2 ( ) ) && <END> METHOD_3 ( ) ) { return METHOD_4 ( ) ? VAR_1 : VAR_2 ; } else if ( TYPE_2 . equals ( METHOD_2 ( ) ) && ! METHOD_3 ( ) ) { return VAR_3 ; } else if ( TYPE_3 . equals ( METHOD_2 ( ) ) ) { return VAR_4 ; } return VAR_5 ; }
public TYPE_1 METHOD_1 ( ) { switch ( METHOD_2 ( ) ) { case TYPE_2 : if ( ! METHOD_3 ( ) ) { return VAR_3 ; } else if ( ! METHOD_4 ( ) ) { return VAR_2 ; } else { return VAR_1 ; } case TYPE_3 : return VAR_4 ; } return VAR_5 ; }
safe a reference comparison instead i e equals _CODE_
private void METHOD_1 ( TYPE_1 e , TYPE_3 . TYPE_4 VAR_1 ) { if ( e != null && <START> e != METHOD_2 ( ) . METHOD_3 ( ) ) { <END> e . VAR_2 ( ) . METHOD_4 ( ) . METHOD_5 ( VAR_1 ) ; METHOD_1 ( e . VAR_2 ( ) , VAR_1 ) ; } }
private void METHOD_1 ( TYPE_1 e , TYPE_3 . TYPE_4 VAR_1 ) { if ( e != null && ! e . equals ( METHOD_2 ( ) . METHOD_3 ( ) ) ) { e . VAR_2 ( ) . METHOD_4 ( ) . METHOD_5 ( VAR_1 ) ; METHOD_1 ( e . VAR_2 ( ) , VAR_1 ) ; } }
previously condition : METHOD_2 ( ) METHOD_3 ( ) = = TYPE_1 VAR_2 _CODE_ ( ) METHOD_3 ( ) = = METHOD_4 ( ) METHOD_3 ( )
private boolean METHOD_1 ( ) { return <START> METHOD_2 ( ) . METHOD_3 ( ) != TYPE_1 . VAR_2 && METHOD_2 ( ) . METHOD_3 ( ) == METHOD_4 ( ) . METHOD_3 ( ) ; <END> }
private boolean METHOD_1 ( ) { return METHOD_2 ( ) . METHOD_3 ( ) == TYPE_1 . VAR_2 || METHOD_2 ( ) . METHOD_3 ( ) == METHOD_4 ( ) . METHOD_3 ( ) ; }
needed
public <START> synchronized Map < Guid , <END> TYPE_1 > METHOD_1 ( Set < Guid > VAR_1 ) { if ( VAR_1 == null ) { return Collections . VAR_2 ( ) ; } return VAR_1 . stream ( ) . collect ( Collectors . VAR_3 ( TYPE_2 . METHOD_2 ( ) , this : : METHOD_3 ) ) ; }
public Map < Guid , TYPE_1 > METHOD_1 ( Set < Guid > VAR_1 ) { if ( VAR_1 == null ) { return Collections . VAR_2 ( ) ; } return VAR_1 . stream ( ) . collect ( Collectors . VAR_3 ( TYPE_2 . METHOD_2 ( ) , this : : METHOD_3 ) ) ; }
called init method needed
public TYPE_1 METHOD_1 ( ) { if ( VAR_1 == null ) { <START> METHOD_2 ( ) ; <END> } return VAR_1 ; }
public TYPE_1 METHOD_1 ( ) { return VAR_1 ; }
private
<START> public boolean <END> METHOD_1 ( ) { TYPE_1 VAR_1 ; try { VAR_1 = METHOD_2 ( TYPE_5 . TYPE_4 , new TYPE_2 ( parent . VAR_4 , VAR_5 ) ) ; } catch ( TYPE_3 e ) { if ( e . VAR_6 ( ) . getStatus ( ) == Response . Status . VAR_7 . METHOD_3 ( ) ) { return false ; } throw e ; } return VAR_1 != null ; }
private boolean METHOD_1 ( ) { TYPE_1 VAR_1 ; try { VAR_1 = METHOD_2 ( TYPE_5 . TYPE_4 , new TYPE_2 ( parent . VAR_4 , VAR_5 ) ) ; } catch ( TYPE_3 e ) { if ( e . VAR_6 ( ) . getStatus ( ) == Response . Status . VAR_7 . METHOD_3 ( ) ) { return false ; } throw e ; } return VAR_1 != null ; }
I else totally removing else more readable 1 indent
private Guid METHOD_1 ( TYPE_1 VAR_1 ) { if ( Guid . TYPE_2 . equals ( VAR_1 . METHOD_2 ( ) ) ) { return Guid . TYPE_2 ; } <START> else { if ( ! getParameters ( ) . METHOD_3 ( ) . isEmpty ( ) ) <END> { return getParameters ( ) . METHOD_4 ( ) ; } } return VAR_1 . METHOD_5 ( ) . equals ( VAR_1 . METHOD_2 ( ) ) ? VAR_3 . get ( VAR_1 . METHOD_5 ( ) ) . METHOD_6 ( ) : getParameters ( ) . METHOD_7 ( ) ; }
private Guid METHOD_1 ( TYPE_1 VAR_1 ) { if ( Guid . TYPE_2 . equals ( VAR_1 . METHOD_2 ( ) ) ) { return Guid . TYPE_2 ; } else if ( ! getParameters ( ) . METHOD_3 ( ) . isEmpty ( ) ) { return getParameters ( ) . METHOD_4 ( ) ; } return VAR_1 . METHOD_5 ( ) . equals ( VAR_1 . METHOD_2 ( ) ) ? VAR_3 . get ( VAR_1 . METHOD_5 ( ) ) . METHOD_6 ( ) : getParameters ( ) . METHOD_7 ( ) ; }
1 ) move - arg C tor C tor 2 ) nice call 3 - arg C tor : ( Guid TYPE_1 Guid TYPE_1 Guid TYPE_1 ) ;
public <START> TYPE_2 ( ) <END> { this . METHOD_1 ( Guid . TYPE_1 ) ; this . METHOD_2 ( Guid . TYPE_1 ) ; this . METHOD_3 ( Guid . TYPE_1 ) ; }
public TYPE_2 ( ) { this ( Guid . TYPE_1 , Guid . TYPE_1 , Guid . TYPE_1 ) ; }
I consider changing private
<START> protected void <END> METHOD_1 ( ) { METHOD_2 ( false ) ; METHOD_3 ( true ) ; }
private void METHOD_1 ( ) { METHOD_2 ( false ) ; METHOD_3 ( true ) ; }
convert early return log a bit clearer
private void METHOD_1 ( Guid VAR_1 , Guid VAR_2 ) { <START> if ( ! METHOD_2 ( ) ) { <END> List < TYPE_1 > VAR_3 = VAR_4 . METHOD_3 ( VAR_1 , VAR_2 ) ; if ( ! VAR_3 . isEmpty ( ) ) { VAR_5 = VAR_3 . get ( 0 ) ; try { METHOD_4 ( ) ; } catch ( TYPE_2 e ) { log . error ( STRING_1 , e . getMessage ( ) , VAR_5 . METHOD_5 ( ) ) ; log . debug ( STRING_2 , e ) ; } } } }
private void METHOD_1 ( Guid VAR_1 , Guid VAR_2 ) { List < TYPE_1 > VAR_3 = VAR_4 . METHOD_3 ( VAR_1 , VAR_2 ) ; if ( ! VAR_3 . isEmpty ( ) ) { VAR_5 = VAR_3 . get ( 0 ) ; try { METHOD_4 ( ) ; } catch ( TYPE_2 e ) { log . error ( STRING_1 , e . getMessage ( ) , VAR_5 . METHOD_5 ( ) ) ; log . debug ( STRING_2 , e ) ; } } }
private
<START> protected void <END> METHOD_1 ( Guid VAR_1 , Guid VAR_2 ) { if ( ! METHOD_2 ( ) ) { List < TYPE_1 > VAR_3 = VAR_4 . METHOD_3 ( VAR_1 , VAR_2 ) ; if ( ! VAR_3 . isEmpty ( ) ) { VAR_5 = VAR_3 . get ( 0 ) ; try { METHOD_4 ( ) ; } catch ( TYPE_2 e ) { log . error ( STRING_1 , e . getMessage ( ) , VAR_5 . METHOD_5 ( ) ) ; log . debug ( STRING_2 , e ) ; } } } }
private void METHOD_1 ( Guid VAR_1 , Guid VAR_2 ) { if ( ! METHOD_2 ( ) ) { List < TYPE_1 > VAR_3 = VAR_4 . METHOD_3 ( VAR_1 , VAR_2 ) ; if ( ! VAR_3 . isEmpty ( ) ) { VAR_5 = VAR_3 . get ( 0 ) ; try { METHOD_4 ( ) ; } catch ( TYPE_2 e ) { log . error ( STRING_1 , e . getMessage ( ) , VAR_5 . METHOD_5 ( ) ) ; log . debug ( STRING_2 , e ) ; } } } }
private
<START> public void <END> METHOD_1 ( ) { when ( VAR_1 . METHOD_2 ( VAR_2 , VAR_3 ) ) . METHOD_3 ( new ArrayList < > ( ) ) ; }
private void METHOD_1 ( ) { when ( VAR_1 . METHOD_2 ( VAR_2 , VAR_3 ) ) . METHOD_3 ( new ArrayList < > ( ) ) ; }
consider changing command getName ( ) equals ( STRING_1 ) fit else
public void METHOD_1 ( TYPE_1 command ) { super . METHOD_1 ( command ) ; if ( command == METHOD_2 ( ) ) { METHOD_3 ( ) ; } else if ( command == METHOD_4 ( ) ) { remove ( ) ; } else if <START> ( STRING_1 . equals ( command . getName ( ) ) ) <END> { METHOD_5 ( ) ; } else if ( command . getName ( ) . equals ( STRING_2 ) ) { METHOD_6 ( ) ; } }
public void METHOD_1 ( TYPE_1 command ) { super . METHOD_1 ( command ) ; if ( command == METHOD_2 ( ) ) { METHOD_3 ( ) ; } else if ( command == METHOD_4 ( ) ) { remove ( ) ; } else if ( command . getName ( ) . equals ( STRING_1 ) ) { METHOD_5 ( ) ; } else if ( command . getName ( ) . equals ( STRING_2 ) ) { METHOD_6 ( ) ; } }
I section : ! METHOD_6 ( VAR_1 )
protected void METHOD_1 ( ) { if ( METHOD_2 ( ) != null ) { TYPE_1 VAR_1 = METHOD_2 ( ) ; <START> VAR_2 . METHOD_3 ( VAR_1 . METHOD_4 ( ) == null || ! VAR_1 . METHOD_4 ( ) . METHOD_5 ( ) ) ; <END> VAR_3 . METHOD_3 ( METHOD_6 ( VAR_1 ) ) ; VAR_4 . METHOD_3 ( VAR_1 . METHOD_7 ( ) == TYPE_2 . VAR_6 || VAR_1 . METHOD_7 ( ) == TYPE_2 . VAR_7 ) ; } }
protected void METHOD_1 ( ) { if ( METHOD_2 ( ) != null ) { TYPE_1 VAR_1 = METHOD_2 ( ) ; VAR_2 . METHOD_3 ( ! METHOD_6 ( VAR_1 ) ) ; VAR_3 . METHOD_3 ( METHOD_6 ( VAR_1 ) ) ; VAR_4 . METHOD_3 ( VAR_1 . METHOD_7 ( ) == TYPE_2 . VAR_6 || VAR_1 . METHOD_7 ( ) == TYPE_2 . VAR_7 ) ; } }
remove ( API longer accesses configuration need mock ) instead please change _CODE_ ( ) similar tests expect new parameters - class added
public static TYPE_1 < TYPE_2 < ? > > METHOD_1 ( ) { <START> return TYPE_1 . of ( TYPE_2 . of ( TYPE_4 . TYPE_3 , STRING_1 ) , TYPE_2 . of ( TYPE_4 . TYPE_5 , INT_1 ) ) ; <END> }
public static TYPE_1 < TYPE_2 < ? > > METHOD_1 ( ) { return TYPE_1 . of ( TYPE_2 . of ( TYPE_4 . TYPE_3 , STRING_1 ) ) ; }
move call calling method _CODE_ : : _CODE_ ? strange a method called calls callback floppy supported
public static void METHOD_1 ( TYPE_1 < List < String > > VAR_1 , Guid VAR_2 , int VAR_3 , TYPE_2 VAR_4 ) { <START> TYPE_3 . METHOD_2 ( new TYPE_1 < > ( VAR_5 - > { <END> if ( VAR_5 ) { METHOD_3 ( VAR_1 , VAR_2 , false , TYPE_5 . TYPE_6 , new TYPE_4 ( ) ) ; } } ) , VAR_3 , VAR_4 ) ; }
public static void METHOD_1 ( TYPE_1 < List < String > > VAR_1 , Guid VAR_2 , int VAR_3 , TYPE_2 VAR_4 ) { METHOD_3 ( VAR_1 , VAR_2 , false , TYPE_5 . TYPE_6 , new TYPE_4 ( ) ) ; }
default need set
public TYPE_2 ( ) { super ( ) ; METHOD_1 ( new TYPE_1 < > ( ) ) ; METHOD_2 ( ) . METHOD_3 ( false ) ; <START> METHOD_2 ( ) . METHOD_4 ( true ) ; <END> }
public TYPE_2 ( ) { super ( ) ; METHOD_1 ( new TYPE_1 < > ( ) ) ; METHOD_2 ( ) . METHOD_3 ( false ) ; }
done line 816 need
private void METHOD_1 ( TYPE_1 model ) { <START> VAR_1 . METHOD_2 ( model . getName ( ) . METHOD_3 ( ) ) ; <END> METHOD_4 ( model , VAR_1 ) ; }
private void METHOD_1 ( TYPE_1 model ) { METHOD_4 ( model , VAR_1 ) ; }
updating QCOW other parameters call
public TYPE_1 update ( TYPE_1 VAR_1 ) { if ( VAR_1 . METHOD_1 ( ) ) { <START> return METHOD_2 ( <END> VAR_1 , new TYPE_2 < > ( TYPE_12 . TYPE_10 , TYPE_3 . class ) , TYPE_9 . TYPE_8 , new TYPE_4 ( ) ) ; } return METHOD_2 ( VAR_1 , new TYPE_5 ( ) , TYPE_9 . TYPE_11 , new TYPE_7 . TYPE_4 ( ) ) ; }
public TYPE_1 update ( TYPE_1 VAR_1 ) { if ( VAR_1 . METHOD_1 ( ) ) { return METHOD_2 ( VAR_1 , new TYPE_2 < > ( TYPE_12 . TYPE_10 , TYPE_3 . class ) , TYPE_9 . TYPE_8 , new TYPE_4 ( ) ) ; } return METHOD_2 ( VAR_1 , new TYPE_2 < > ( TYPE_12 . TYPE_10 , TYPE_3 . class ) , TYPE_9 . TYPE_11 , new TYPE_7 . TYPE_4 ( ) ) ; }
fail empty collection
public void METHOD_1 ( Collection < T > value , T VAR_1 ) { List < T > VAR_2 = new ArrayList < > ( value ) ; <START> if ( VAR_2 . get ( 0 ) != null ) <END> { VAR_2 . add ( 0 , null ) ; } super . METHOD_1 ( VAR_2 , VAR_1 ) ; }
public void METHOD_1 ( Collection < T > value , T VAR_1 ) { List < T > VAR_2 = value == null ? new ArrayList < > ( ) : new ArrayList < > ( value ) ; if ( VAR_2 . isEmpty ( ) || VAR_2 . get ( 0 ) != null ) { VAR_2 . add ( 0 , null ) ; } super . METHOD_1 ( VAR_2 , VAR_1 ) ; }
doesn t condition arbiter volume version 4 1 ? case removing version check changes logic other versions arbiter volume removed completely
<START> private void METHOD_1 ( ) { <END> METHOD_2 ( ) . METHOD_3 ( METHOD_4 ( ) . METHOD_5 ( ) . METHOD_6 ( ) && METHOD_7 ( ) . METHOD_5 ( ) != null ) ; }
private void METHOD_1 ( ) { METHOD_2 ( ) . METHOD_3 ( METHOD_4 ( ) . METHOD_5 ( ) . METHOD_6 ( ) ) ; }
consider ? : syntax - return ? x : y
public TYPE_1 METHOD_1 ( ) { if ( TYPE_6 . VAR_2 != VAR_3 . getType ( ) ) { return TYPE_1 . VAR_4 ; } List < TYPE_2 < ? > > VAR_5 = TYPE_3 . get ( TYPE_4 . class ) . METHOD_2 ( TYPE_6 . VAR_2 ) ; <START> if ( TYPE_5 . METHOD_3 ( VAR_3 ) ) { return METHOD_4 ( VAR_5 ) ; } else { return METHOD_5 ( VAR_5 ) ; } <END> }
public TYPE_1 METHOD_1 ( ) { if ( TYPE_6 . VAR_2 != VAR_3 . getType ( ) ) { return TYPE_1 . VAR_4 ; } List < TYPE_2 < ? > > VAR_5 = TYPE_3 . get ( TYPE_4 . class ) . METHOD_2 ( TYPE_6 . VAR_2 ) ; return TYPE_5 . METHOD_3 ( VAR_3 ) ? METHOD_4 ( VAR_5 ) : METHOD_5 ( VAR_5 ) ; }
consider new java 11 List ( )
private boolean METHOD_1 ( ) { TYPE_1 VAR_1 = ( TYPE_1 ) METHOD_2 ( ) ; METHOD_3 ( VAR_1 . METHOD_4 ( ) ) ; if ( ! METHOD_5 ( new TYPE_2 ( METHOD_6 ( ) ) . METHOD_7 ( ) ) ) { return false ; } TYPE_3 VAR_2 = new <START> TYPE_3 ( Collections . VAR_3 ( VAR_1 ) ) ; <END> return METHOD_5 ( VAR_2 . METHOD_8 ( ) ) ; }
private boolean METHOD_1 ( ) { TYPE_1 VAR_1 = ( TYPE_1 ) METHOD_2 ( ) ; METHOD_3 ( VAR_1 . METHOD_4 ( ) ) ; if ( ! METHOD_5 ( new TYPE_2 ( METHOD_6 ( ) ) . METHOD_7 ( ) ) ) { return false ; } TYPE_3 VAR_2 = new TYPE_3 ( List . of ( VAR_1 ) ) ; return METHOD_5 ( VAR_2 . METHOD_8 ( ) ) ; }
I safe java > 9 Map ( key1 value1 key2 value2 ) ;
private TYPE_1 METHOD_1 ( TYPE_2 command , String VAR_1 ) { return TYPE_3 . METHOD_2 ( command . VAR_2 ( ) . get ( 0 ) , command . VAR_3 ( ) , <START> new HashMap < > ( ) { { put ( STRING_1 , VAR_1 ) ; put ( STRING_2 , command . VAR_4 ( ) ) ; } } <END> ) ; }
private TYPE_1 METHOD_1 ( TYPE_2 command , String VAR_1 ) { return TYPE_3 . METHOD_2 ( command . VAR_2 ( ) . get ( 0 ) , command . VAR_3 ( ) , Map . of ( STRING_1 , VAR_1 , STRING_2 , command . VAR_4 ( ) ) ) ; }
line needed _CODE_ automatically replaced calling METHOD_3 ( )
public TYPE_1 METHOD_1 ( ) { <START> METHOD_2 ( STRING_1 , String . format ( STRING_2 , METHOD_3 ( ) ) ) ; <END> return METHOD_4 ( ) ? TYPE_1 . VAR_1 : TYPE_1 . VAR_2 ; }
public TYPE_1 METHOD_1 ( ) { return METHOD_4 ( ) ? TYPE_1 . VAR_1 : TYPE_1 . VAR_2 ; }
please move call METHOD_12 ( ) method method multiple similar statements check VM state add audit log line
protected void METHOD_1 ( ) { if ( METHOD_2 ( ) ) { METHOD_3 ( ) ; return ; } if ( METHOD_4 ( ) ) { METHOD_5 ( ) ; return ; } if ( METHOD_6 ( ) ) { METHOD_7 ( ) ; return ; } <START> if ( METHOD_8 ( ) ) { <END> METHOD_9 ( ) ; } if ( ! METHOD_10 ( ) ) { METHOD_11 ( ) ; return ; } METHOD_12 ( ) ; }
protected void METHOD_1 ( ) { if ( METHOD_2 ( ) ) { METHOD_3 ( ) ; return ; } if ( METHOD_4 ( ) ) { METHOD_5 ( ) ; return ; } if ( METHOD_6 ( ) ) { METHOD_7 ( ) ; return ; } if ( ! METHOD_10 ( ) ) { METHOD_11 ( ) ; return ; } METHOD_12 ( ) ; }
public required vdsbroker
<START> public TYPE_1 <END> METHOD_1 ( TYPE_2 VAR_1 , TYPE_1 VAR_2 ) { return VAR_1 != null && VAR_1 . METHOD_2 ( ) ? TYPE_1 . METHOD_3 ( VAR_1 . METHOD_4 ( ) ) : VAR_2 ; }
TYPE_1 METHOD_1 ( TYPE_2 VAR_1 , TYPE_1 VAR_2 ) { return VAR_1 != null && VAR_1 . METHOD_2 ( ) ? TYPE_1 . METHOD_3 ( VAR_1 . METHOD_4 ( ) ) : VAR_2 ; }
public required
<START> public TYPE_1 <END> METHOD_1 ( TYPE_2 VAR_1 ) { return VAR_1 != null ? VAR_2 . get ( VAR_1 . METHOD_2 ( ) ) : null ; }
TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { return VAR_1 != null ? VAR_2 . get ( VAR_1 . METHOD_2 ( ) ) : null ; }
public required
<START> public List < TYPE_1 > <END> METHOD_1 ( ) { return VAR_1 . METHOD_1 ( ) ; }
List < TYPE_1 > METHOD_1 ( ) { return VAR_1 . METHOD_1 ( ) ; }
s shorter : VAR_3 METHOD_2 ( VAR_2 getType = = || ) ;
private void METHOD_1 ( Map < Guid , TYPE_1 > VAR_1 , TYPE_2 VAR_2 ) { TYPE_1 VAR_3 = VAR_1 . get ( VAR_2 . getId ( ) ) ; if ( VAR_3 == null ) { return ; } <START> if ( VAR_2 . getType ( ) == TYPE_3 . VAR_5 || VAR_2 . getType ( ) == TYPE_3 . VAR_6 ) { <END> VAR_3 . METHOD_2 ( true ) ; } else { VAR_3 . METHOD_2 ( false ) ; } }
private void METHOD_1 ( Map < Guid , TYPE_1 > VAR_1 , TYPE_2 VAR_2 ) { TYPE_1 VAR_3 = VAR_1 . get ( VAR_2 . getId ( ) ) ; if ( VAR_3 == null ) { return ; } VAR_3 . METHOD_2 ( VAR_2 . getType ( ) == TYPE_3 . VAR_5 || VAR_2 . getType ( ) == TYPE_3 . VAR_6 ) ; }
please move validate method method handle size updating
private void METHOD_1 ( TYPE_1 VAR_1 ) { <START> METHOD_2 ( ) . METHOD_3 ( new TYPE_2 [ ] { <END> new TYPE_3 ( ) , new TYPE_4 ( ) , } ) ; if ( METHOD_2 ( ) . METHOD_4 ( ) ) { long VAR_2 = Long . VAR_3 ( METHOD_2 ( ) . METHOD_5 ( ) ) ; if ( VAR_2 > 0 ) { VAR_1 . METHOD_6 ( VAR_1 . METHOD_7 ( ) + VAR_2 ) ; } } }
private void METHOD_1 ( TYPE_1 VAR_1 ) { long VAR_2 = Long . VAR_3 ( METHOD_2 ( ) . METHOD_5 ( ) ) ; if ( VAR_2 > 0 ) { VAR_1 . METHOD_6 ( VAR_1 . METHOD_7 ( ) + VAR_2 ) ; } }
suggest surround parsing - catch line a potential throw
private void METHOD_1 ( TYPE_1 VAR_1 ) { try { <START> long VAR_2 = Long . VAR_3 ( METHOD_2 ( ) . METHOD_3 ( ) ) ; <END> if ( VAR_2 > 0 ) { VAR_1 . METHOD_4 ( VAR_1 . METHOD_5 ( ) + VAR_2 ) ; } } catch ( TYPE_2 VAR_4 ) { } }
private void METHOD_1 ( TYPE_1 VAR_1 ) { long VAR_2 ; try { VAR_2 = Long . VAR_3 ( METHOD_2 ( ) . METHOD_3 ( ) ) ; } catch ( TYPE_2 VAR_4 ) { return ; } if ( VAR_2 > 0 ) { VAR_1 . METHOD_4 ( VAR_1 . METHOD_5 ( ) + VAR_2 ) ; } }
please change incrementing index ( VAR_1 + + ) instead ( + + VAR_1 ) 3 lines ll need click tab field
public int METHOD_1 ( int VAR_1 ) { <START> VAR_2 . METHOD_2 ( ++ VAR_1 ) ; VAR_3 . METHOD_2 ( ++ VAR_1 ) ; VAR_4 . METHOD_2 ( ++ VAR_1 ) ; <END> return VAR_1 ; }
public int METHOD_1 ( int VAR_1 ) { VAR_2 . METHOD_2 ( VAR_1 ++ ) ; VAR_3 . METHOD_2 ( VAR_1 ++ ) ; VAR_4 . METHOD_2 ( VAR_1 ++ ) ; return VAR_1 ; }
METHOD_4 ( false ) raise error
protected void METHOD_1 ( ) { TYPE_1 cluster = VAR_1 . get ( getParameters ( ) . METHOD_2 ( ) ) ; if ( cluster . VAR_2 ( ) ) { try { VAR_3 . METHOD_3 ( cluster ) ; } catch ( Exception e ) { <START> log . error ( STRING_1 , <END> cluster . getName ( ) , e . getMessage ( ) ) ; log . debug ( STRING_2 , e ) ; } METHOD_4 ( true ) ; } }
protected void METHOD_1 ( ) { try { VAR_3 . METHOD_3 ( cluster ) ; } catch ( Exception e ) { log . error ( STRING_1 , cluster . getName ( ) , e . getMessage ( ) ) ; log . debug ( STRING_2 , e ) ; METHOD_4 ( false ) ; } METHOD_4 ( true ) ; }
I m wrong method return void other _CODE_ methods return
private TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { vm . VAR_2 ( VAR_1 ) ; vm . VAR_3 ( VAR_4 ) ; vm . VAR_5 ( Guid . VAR_6 ( ) ) ; when ( VAR_7 . get ( command . getParameters ( ) . METHOD_2 ( ) ) ) . METHOD_3 ( vm ) ; <START> return vm ; <END> }
private void METHOD_1 ( TYPE_2 VAR_1 ) { vm . VAR_2 ( VAR_1 ) ; vm . VAR_3 ( VAR_4 ) ; vm . VAR_5 ( Guid . VAR_6 ( ) ) ; when ( VAR_7 . get ( command . getParameters ( ) . METHOD_2 ( ) ) ) . METHOD_3 ( vm ) ; }
smells a bug equals
public static int METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 < ? > column ) { if ( VAR_1 == null || column == null ) { return - 1 ; } for ( int i = 0 ; i < VAR_1 . size ( ) ; i ++ ) { TYPE_1 . TYPE_4 VAR_2 = VAR_1 . get ( i ) ; if <START> ( column == VAR_2 . METHOD_2 ( ) ) { <END> return i ; } } return - 1 ; }
public static int METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 < ? > column ) { if ( VAR_1 == null || column == null ) { return - 1 ; } for ( int i = 0 ; i < VAR_1 . size ( ) ; i ++ ) { TYPE_1 . TYPE_4 VAR_2 = VAR_1 . get ( i ) ; if ( column . equals ( VAR_2 . METHOD_2 ( ) ) ) { return i ; } } return - 1 ; }
check VDS collection guidsprobably vds getId ( )
public Guid METHOD_1 ( Guid VAR_1 , Collection < Guid > VAR_2 ) { return METHOD_1 ( VAR_1 , vds - > <START> ! VAR_2 . contains ( vds ) ) ; <END> }
public Guid METHOD_1 ( Guid VAR_1 , Collection < Guid > VAR_2 ) { return METHOD_1 ( VAR_1 , vds - > ! VAR_2 . contains ( vds . getId ( ) ) ) ; }
simplified : return ! VAR_5 getId ( ) equals ( VAR_6 getId ( ) ) || TYPE_2 VAR_8 = = VAR_6 METHOD_4 ( ) ;
public boolean METHOD_1 ( Guid VAR_1 , Guid VAR_2 , Guid VAR_3 , Guid VAR_4 ) { TYPE_1 VAR_5 = METHOD_2 ( VAR_3 ) ; TYPE_1 VAR_6 = METHOD_3 ( VAR_1 , VAR_2 , VAR_3 , VAR_4 ) ; <START> return VAR_5 . getId ( ) . equals ( VAR_6 . getId ( ) ) ? TYPE_2 . VAR_8 == VAR_6 . METHOD_4 ( ) : true ; <END> }
public boolean METHOD_1 ( Guid VAR_1 , Guid VAR_2 , Guid VAR_3 , Guid VAR_4 ) { TYPE_1 VAR_5 = METHOD_2 ( VAR_3 ) ; TYPE_1 VAR_6 = METHOD_3 ( VAR_1 , VAR_2 , VAR_3 , VAR_4 ) ; return ! VAR_5 . getId ( ) . equals ( VAR_6 . getId ( ) ) || TYPE_2 . VAR_8 == VAR_6 . METHOD_4 ( ) ; }
replaced : return VAR_5 getId ( ) equals ( VAR_6 getId ( ) ) ? TYPE_2 VAR_8 = = VAR_6 METHOD_4 ( ) : true ; a a matter style
public boolean METHOD_1 ( Guid VAR_1 , Guid VAR_2 , Guid VAR_3 , Guid VAR_4 ) { TYPE_1 VAR_5 = METHOD_2 ( VAR_3 ) ; TYPE_1 VAR_6 = METHOD_3 ( VAR_1 , VAR_2 , VAR_3 , VAR_4 ) ; if ( VAR_5 . getId ( ) . equals ( VAR_6 . getId ( ) ) ) { return TYPE_2 . VAR_8 == VAR_6 . METHOD_4 ( ) ; } return <START> true ; <END> }
public boolean METHOD_1 ( Guid VAR_1 , Guid VAR_2 , Guid VAR_3 , Guid VAR_4 ) { TYPE_1 VAR_5 = METHOD_2 ( VAR_3 ) ; TYPE_1 VAR_6 = METHOD_3 ( VAR_1 , VAR_2 , VAR_3 , VAR_4 ) ; return VAR_5 . getId ( ) . equals ( VAR_6 . getId ( ) ) ? TYPE_2 . VAR_8 == VAR_6 . METHOD_4 ( ) : true ; }
fail null pointer exception hide errors reading response log 2 errorsfor issue ( e g print stack trace reading fails return empty string failwhen parsing json ) lets code raise IOException handle caller - wrap callsin / catch block
private String METHOD_1 ( TYPE_1 response ) { TYPE_2 reader = null ; try { reader = new TYPE_2 ( new TYPE_3 ( response . VAR_1 ( ) . METHOD_2 ( ) ) ) ; } catch ( IOException e ) { e . VAR_2 ( ) ; } <START> return reader . VAR_3 ( ) . collect ( Collectors . VAR_4 ( ) ) ; <END> }
private String METHOD_1 ( TYPE_1 response ) throws IOException { TYPE_2 reader = new TYPE_2 ( new TYPE_3 ( response . VAR_1 ( ) . METHOD_2 ( ) ) ) ; return reader . VAR_3 ( ) . collect ( Collectors . VAR_4 ( ) ) ; }
client provide reliable persistent connection I instancein command create a new client request instead adding more state thecommand avoid need create client lazily
private TYPE_1 METHOD_1 ( ) { if ( VAR_1 == null ) { VAR_1 = new TYPE_1 ( METHOD_2 ( ) . toString ( ) ) ; } <START> return VAR_1 ; <END> }
private TYPE_1 METHOD_1 ( ) { if ( VAR_1 == null ) { VAR_1 = new TYPE_1 ( METHOD_2 ( ) . toString ( ) ) ; } return new TYPE_1 ( METHOD_2 ( ) . toString ( ) ) ; }
isn t implementing METHOD_1 _CODE_ interface ? s return type changed
<START> public void METHOD_1 ( Object instance , <END> String VAR_1 , Class < ? > [ ] VAR_2 , Object [ ] VAR_3 , long VAR_4 , long VAR_5 , TimeUnit VAR_6 ) { VAR_7 . METHOD_1 ( METHOD_2 ( instance , VAR_1 ) , VAR_4 , VAR_5 , TimeUnit . VAR_8 ) ; }
public void METHOD_1 ( Object instance , String VAR_1 , Class < ? > [ ] VAR_2 , Object [ ] VAR_3 , long VAR_4 , long VAR_5 , TimeUnit VAR_6 ) { VAR_7 . METHOD_1 ( METHOD_2 ( instance , VAR_1 , VAR_2 , VAR_3 ) , VAR_4 , VAR_5 , TimeUnit . VAR_8 ) ; }
case null
public void close ( ) throws IOException { <START> VAR_1 . close ( ) ; <END> }
public void close ( ) throws IOException { if ( VAR_1 != null ) { VAR_1 . close ( ) ; } }
pls verify VAR_1 null
public void METHOD_1 ( ) { try { <START> VAR_1 . close ( ) ; <END> } catch ( IOException e ) { } }
public void METHOD_1 ( ) { try { if ( VAR_1 != null ) { VAR_1 . close ( ) ; } } catch ( IOException e ) { } }
pls check VAR_1 isn t null
public void METHOD_1 ( ) { super . METHOD_1 ( ) ; try { <START> VAR_1 . close ( ) ; <END> } catch ( IOException e ) { } }
public void METHOD_1 ( ) { super . METHOD_1 ( ) ; try { if ( VAR_1 != null ) { VAR_1 . close ( ) ; } } catch ( IOException e ) { } }
IMHO inserted METHOD_5 ( ) METHOD_7 ( TYPE_2 VAR_6 ) ; instead return false ; METHOD_6 ( TYPE_1 VAR_4 ) ; instead return true ;
public boolean METHOD_1 ( int VAR_1 ) { METHOD_2 ( ) ; switch ( getParameters ( ) . METHOD_3 ( ) . METHOD_4 ( ) ) { case VAR_2 : <START> if ( METHOD_5 ( ) ) { METHOD_6 ( TYPE_1 . VAR_4 ) ; } else { METHOD_7 ( TYPE_2 . VAR_6 ) ; } <END> log . info ( STRING_1 ) ; break ; case VAR_4 : return true ; case VAR_7 : METHOD_8 ( ) ; METHOD_7 ( TYPE_2 . VAR_8 ) ; break ; } METHOD_9 ( ) ; return true ; }
public boolean METHOD_1 ( int VAR_1 ) { METHOD_2 ( ) ; switch ( getParameters ( ) . METHOD_3 ( ) . METHOD_4 ( ) ) { case VAR_2 : if ( METHOD_5 ( ) ) { METHOD_6 ( TYPE_1 . VAR_4 ) ; log . info ( STRING_1 ) ; } else { METHOD_7 ( TYPE_2 . VAR_6 ) ; } break ; case VAR_4 : return true ; case VAR_7 : METHOD_8 ( ) ; METHOD_7 ( TYPE_2 . VAR_8 ) ; break ; } METHOD_9 ( ) ; return true ; }
s invalid isn t ? s meaning VAR_17 cluster set autodetect = = null concrete values allowed
private static TYPE_1 METHOD_1 ( ) { TYPE_1 group = new TYPE_1 ( ) ; group . VAR_1 ( STRING_1 ) ; group . VAR_2 ( "" ) ; group . VAR_3 ( VAR_4 ) ; group . VAR_5 ( VAR_6 ) ; group . VAR_7 ( VAR_8 ) ; group . VAR_9 ( TYPE_2 . VAR_11 ) ; group . VAR_12 ( Guid . VAR_13 ( ) ) ; group . VAR_14 ( 100 ) ; <START> group . VAR_15 ( TYPE_3 . VAR_17 ) ; <END> return group ; }
private static TYPE_1 METHOD_1 ( ) { TYPE_1 group = new TYPE_1 ( ) ; group . VAR_1 ( STRING_1 ) ; group . VAR_2 ( "" ) ; group . VAR_3 ( VAR_4 ) ; group . VAR_5 ( VAR_6 ) ; group . VAR_7 ( VAR_8 ) ; group . VAR_9 ( TYPE_2 . VAR_11 ) ; group . VAR_12 ( Guid . VAR_13 ( ) ) ; group . VAR_14 ( 100 ) ; return group ; }
? case VAR_6
public TYPE_1 ( Map < String , Object > VAR_2 ) { super ( VAR_2 ) ; VAR_3 = ( Map < String , Object > ) VAR_2 . get ( TYPE_2 . VAR_5 ) ; Object VAR_6 = VAR_2 . get ( TYPE_2 . VAR_7 ) ; if ( VAR_6 != null ) { VAR_8 = ( String ) <START> VAR_2 . get ( TYPE_2 . VAR_7 ) ; <END> } }
public TYPE_1 ( Map < String , Object > VAR_2 ) { super ( VAR_2 ) ; VAR_3 = ( Map < String , Object > ) VAR_2 . get ( TYPE_2 . VAR_5 ) ; Object VAR_6 = VAR_2 . get ( TYPE_2 . VAR_7 ) ; if ( VAR_6 != null ) { VAR_8 = ( String ) VAR_6 ; } }
removed
private String METHOD_1 ( int from , int to , int VAR_1 ) { if ( VAR_1 > 0 ) { return VAR_2 . METHOD_2 ( from , to , VAR_1 ) ; <START> } else { <END> return VAR_2 . METHOD_3 ( from , to ) ; } }
private String METHOD_1 ( int from , int to , int VAR_1 ) { if ( VAR_1 > 0 ) { return VAR_2 . METHOD_2 ( from , to , VAR_1 ) ; } return VAR_2 . METHOD_3 ( from , to ) ; }
good other places set null I fix comparison
private void METHOD_1 ( TYPE_1 vm ) { vm . VAR_1 ( null ) ; vm . VAR_2 ( ) . clear ( ) ; vm . VAR_3 ( null ) ; vm . VAR_4 ( null ) ; vm . VAR_5 ( null ) ; <START> vm . VAR_6 ( "" ) ; <END> vm . VAR_7 ( null ) ; vm . VAR_8 ( null ) ; vm . VAR_9 ( null ) ; vm . VAR_10 ( null ) ; vm . VAR_11 ( false ) ; vm . VAR_12 ( 0 ) ; }
private void METHOD_1 ( TYPE_1 vm ) { vm . VAR_1 ( null ) ; vm . VAR_2 ( ) . clear ( ) ; vm . VAR_3 ( null ) ; vm . VAR_4 ( null ) ; vm . VAR_5 ( null ) ; vm . VAR_6 ( null ) ; vm . VAR_7 ( null ) ; vm . VAR_8 ( null ) ; vm . VAR_9 ( null ) ; vm . VAR_10 ( null ) ; vm . VAR_11 ( false ) ; vm . VAR_12 ( 0 ) ; }
a URL ( e g file : / / / path / / image nbd : unix : / path / / socket : exportname = vda ) String url =
private boolean METHOD_1 ( Guid VAR_1 , String VAR_2 ) { String <START> VAR_3 = <END> String . format ( STRING_1 , VAR_2 , VAR_4 , VAR_1 ) ; TYPE_1 VAR_5 = METHOD_2 ( VAR_1 , VAR_3 ) ; log . info ( STRING_2 , VAR_1 ) ; try { METHOD_3 ( ) . METHOD_4 ( VAR_5 ) ; } catch ( RuntimeException e ) { log . error ( STRING_3 , e . getMessage ( ) , e ) ; return false ; } return true ; }
private boolean METHOD_1 ( Guid VAR_1 , String VAR_2 ) { String url = String . format ( STRING_1 , VAR_2 , VAR_4 , VAR_1 ) ; TYPE_1 VAR_5 = METHOD_2 ( VAR_1 , url ) ; log . info ( STRING_2 , VAR_1 ) ; try { METHOD_3 ( ) . METHOD_4 ( VAR_5 ) ; } catch ( RuntimeException e ) { log . error ( STRING_3 , e . getMessage ( ) , e ) ; return false ; } return true ; }
worth usage _CODE_ ( package ) remove public
<START> public static <END> TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { TYPE_1 parameters = new TYPE_1 ( ) ; parameters . VAR_2 ( TYPE_4 . TYPE_5 ) ; parameters . VAR_5 ( VAR_1 . getId ( ) ) ; String VAR_6 = VAR_1 . METHOD_2 ( ) == TYPE_3 . VAR_8 ? STRING_1 : STRING_2 ; parameters . VAR_9 ( VAR_1 . METHOD_3 ( ) + VAR_6 ) ; parameters . VAR_10 ( VAR_1 . METHOD_4 ( ) ) ; parameters . VAR_11 ( true ) ; return parameters ; }
static TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { TYPE_1 parameters = new TYPE_1 ( ) ; parameters . VAR_2 ( TYPE_4 . TYPE_5 ) ; parameters . VAR_5 ( VAR_1 . getId ( ) ) ; String VAR_6 = VAR_1 . METHOD_2 ( ) == TYPE_3 . VAR_8 ? STRING_1 : STRING_2 ; parameters . VAR_9 ( VAR_1 . METHOD_3 ( ) + VAR_6 ) ; parameters . VAR_10 ( VAR_1 . METHOD_4 ( ) ) ; parameters . VAR_11 ( true ) ; return parameters ; }
static avoid avoid redundant object creation _CODE_
<START> public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { <END> TYPE_1 parameters = new TYPE_1 ( ) ; parameters . VAR_2 ( TYPE_4 . TYPE_5 ) ; parameters . VAR_5 ( VAR_1 . getId ( ) ) ; String VAR_6 = VAR_1 . METHOD_2 ( ) == TYPE_3 . VAR_8 ? STRING_1 : STRING_2 ; parameters . VAR_9 ( VAR_1 . METHOD_3 ( ) + VAR_6 ) ; parameters . VAR_10 ( VAR_1 . METHOD_4 ( ) ) ; parameters . VAR_11 ( true ) ; return parameters ; }
public static TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { TYPE_1 parameters = new TYPE_1 ( ) ; parameters . VAR_2 ( TYPE_4 . TYPE_5 ) ; parameters . VAR_5 ( VAR_1 . getId ( ) ) ; String VAR_6 = VAR_1 . METHOD_2 ( ) == TYPE_3 . VAR_8 ? STRING_1 : STRING_2 ; parameters . VAR_9 ( VAR_1 . METHOD_3 ( ) + VAR_6 ) ; parameters . VAR_10 ( VAR_1 . METHOD_4 ( ) ) ; parameters . VAR_11 ( true ) ; return parameters ; }
! VAR_1 isEmpty ( )
private boolean METHOD_1 ( ) { List < TYPE_1 > VAR_1 = METHOD_2 ( ) ; return VAR_1 != null && <START> VAR_1 . size ( ) != 0 ; <END> }
private boolean METHOD_1 ( ) { List < TYPE_1 > VAR_1 = METHOD_2 ( ) ; return VAR_1 != null && ! VAR_1 . isEmpty ( ) ; }
a List specific objects List
private <START> List METHOD_1 ( TYPE_1 <END> VAR_1 , TYPE_2 params ) { TYPE_3 VAR_2 ; try { VAR_2 = METHOD_2 ( VAR_1 , params ) ; if ( ! VAR_2 . METHOD_3 ( ) ) { TYPE_4 VAR_3 = new TYPE_4 ( ) ; VAR_3 . METHOD_4 ( VAR_2 . METHOD_5 ( ) ) ; throw VAR_3 ; } } catch ( TYPE_4 e ) { log . error ( STRING_1 , VAR_1 , e ) ; throw e ; } return ( List ) VAR_2 . METHOD_6 ( ) ; }
private List < Guid > METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 params ) { TYPE_3 VAR_2 ; try { VAR_2 = METHOD_2 ( VAR_1 , params ) ; if ( ! VAR_2 . METHOD_3 ( ) ) { TYPE_4 VAR_3 = new TYPE_4 ( ) ; VAR_3 . METHOD_4 ( VAR_2 . METHOD_5 ( ) ) ; throw VAR_3 ; } } catch ( TYPE_4 e ) { log . error ( STRING_1 , VAR_1 , e ) ; throw e ; } return ( List < Guid > ) VAR_2 . METHOD_6 ( ) ; }
condition inverted wasn t
private boolean METHOD_1 ( ) { return METHOD_2 ( ) || METHOD_3 ( ) || METHOD_4 ( ) <START> || VAR_1 . METHOD_5 ( ) == METHOD_5 ( ) ; <END> }
private boolean METHOD_1 ( ) { return METHOD_2 ( ) || METHOD_3 ( ) || METHOD_4 ( ) || VAR_1 . METHOD_5 ( ) != METHOD_5 ( ) ; }
need ( ! METHOD_1 ( VAR_5 METHOD_5 ( ) ) { }
protected boolean METHOD_1 ( ) { if ( ! ( METHOD_2 ( ) . getStatus ( ) == TYPE_3 . TYPE_2 || METHOD_2 ( ) . METHOD_3 ( ) ) ) { return METHOD_4 ( TYPE_4 . VAR_4 ) ; } TYPE_1 VAR_5 = new TYPE_1 ( VAR_6 ) ; <START> METHOD_1 ( VAR_5 . METHOD_5 ( ) ) ; <END> return super . METHOD_1 ( ) ; }
protected boolean METHOD_1 ( ) { if ( ! ( METHOD_2 ( ) . getStatus ( ) == TYPE_3 . TYPE_2 || METHOD_2 ( ) . METHOD_3 ( ) ) ) { return METHOD_4 ( TYPE_4 . VAR_4 ) ; } TYPE_1 VAR_5 = new TYPE_1 ( VAR_6 ) ; if ( ! METHOD_1 ( VAR_5 . METHOD_5 ( ) ) ) { return false ; } return super . METHOD_1 ( ) ; }
please handle VAR_3 null
public boolean METHOD_1 ( String VAR_1 , String VAR_2 , String <START> VAR_3 ) { <END> String VAR_4 = TYPE_1 . getInstance ( ) . METHOD_2 ( VAR_2 ) ; TYPE_2 VAR_5 = VAR_6 . METHOD_3 ( VAR_1 , VAR_4 ) ; TYPE_3 VAR_7 = VAR_6 . METHOD_4 ( VAR_3 ) ; return VAR_5 . METHOD_5 ( VAR_7 ) ; }
public boolean METHOD_1 ( String VAR_1 , String VAR_2 , String VAR_3 ) { if ( VAR_3 == null ) { return true ; } String VAR_4 = TYPE_1 . getInstance ( ) . METHOD_2 ( VAR_2 ) ; TYPE_2 VAR_5 = VAR_6 . METHOD_3 ( VAR_1 , VAR_4 ) ; TYPE_3 VAR_7 = VAR_6 . METHOD_4 ( VAR_3 ) ; return VAR_5 . METHOD_5 ( VAR_7 ) ; }
existing rows null _CODE_
protected void METHOD_1 ( final int VAR_1 , final int column , final int line , final short file ) { <START> METHOD_1 ( VAR_1 , column , line , file , "" ) ; <END> }
protected void METHOD_1 ( final int VAR_1 , final int column , final int line , final short file ) { METHOD_1 ( VAR_1 , column , line , file , null ) ; }
IIRC VAR_1 returns String [ 0 ] elements null
private static List < String > METHOD_1 ( final TYPE_1 config , final String name ) { String s [ ] = config . VAR_1 ( STRING_1 , null , name ) ; <START> if ( s == null || s . length == 0 ) { <END> return null ; } final List < String > VAR_2 = new ArrayList < String > ( ) ; for ( int i = 0 ; i < s . length ; i ++ ) { VAR_2 . add ( s [ i ] ) ; } return VAR_2 ; }
private static List < String > METHOD_1 ( final TYPE_1 config , final String name ) { String s [ ] = config . VAR_1 ( STRING_1 , null , name ) ; return Arrays . asList ( s ) ; }
hmm caller invoking a full TYPE_3 object hand pass time database column initialize field assume null
TYPE_5 ( final TYPE_3 . TYPE_4 i , final TYPE_2 VAR_2 ) { id = i ; VAR_3 = VAR_2 ; <START> VAR_4 = null ; <END> }
TYPE_5 ( final TYPE_3 . TYPE_4 i , final TYPE_2 VAR_2 ) { id = i ; VAR_3 = VAR_2 ; }
style - : code shorter remove VAR_1 variable : VAR_2 put ( listener new TYPE_3 ( listener user ) ) ;
public void METHOD_1 ( TYPE_1 listener , TYPE_2 user ) { <START> TYPE_3 VAR_1 = new TYPE_3 ( listener , user ) ; <END> VAR_2 . put ( listener , VAR_1 ) ; }
public void METHOD_1 ( TYPE_1 listener , TYPE_2 user ) { VAR_2 . put ( listener , new TYPE_3 ( listener , user ) ) ; }
return null project suddenly disappear I guard testing null skipping rest method : ( VAR_2 = = null ) { return false ; }
private boolean METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 user ) { <START> final TYPE_3 VAR_2 = VAR_3 . get ( VAR_1 . METHOD_2 ( ) ) ; <END> final TYPE_4 VAR_4 = VAR_2 . METHOD_3 ( user ) ; final TYPE_5 VAR_5 = VAR_4 . METHOD_4 ( VAR_1 . METHOD_5 ( ) . get ( ) ) ; return VAR_5 . METHOD_6 ( ) ; }
private boolean METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 user ) { final TYPE_3 VAR_2 = VAR_3 . get ( VAR_1 . METHOD_2 ( ) ) ; if ( VAR_2 == null ) { return false ; } final TYPE_4 VAR_4 = VAR_2 . METHOD_3 ( user ) ; return VAR_4 . METHOD_3 ( VAR_1 ) . METHOD_6 ( ) ; }
protected exists JSON serialization library
<START> public TYPE_1 ( ) { <END> }
protected TYPE_1 ( ) { }
constructor exists JSON encoding recursively process populate fields s need call ( ) accept default initialization false / null fields JSON decoder finish building object
protected TYPE_2 ( ) { <START> this ( new ArrayList < TYPE_1 > ( ) , false ) ; <END> }
protected TYPE_2 ( ) { }
drop - else block VAR_3 simplified val = Math max ( ) expression
public int METHOD_1 ( Set < TYPE_3 . TYPE_4 > VAR_1 ) { int val = Integer . VAR_2 ; for ( TYPE_2 VAR_3 : VAR_4 ) { if ( VAR_1 . contains ( VAR_3 . METHOD_2 ( ) ) ) { <START> if ( ( val < 0 && VAR_3 . METHOD_3 ( ) > 0 ) ) { <END> val = Math . max ( VAR_3 . METHOD_3 ( ) , val ) ; } } } return val ; }
public int METHOD_1 ( Set < TYPE_3 . TYPE_4 > VAR_1 ) { int val = Integer . VAR_2 ; for ( TYPE_2 VAR_3 : VAR_4 ) { if ( VAR_1 . contains ( VAR_3 . METHOD_2 ( ) ) ) { val = Math . max ( VAR_3 . METHOD_3 ( ) , val ) ; } } return val ; }
need selection dynamically based current user batch jobs coming interface fetch degraded service ssh : / /
TYPE_6 ( final TYPE_1 < TYPE_2 > VAR_2 , TYPE_3 VAR_3 , final TYPE_4 context , ANNOTATION_1 final TYPE_5 VAR_4 ) { this . VAR_2 = VAR_2 ; <START> this . VAR_5 = VAR_3 . METHOD_1 ( ) ; <END> this . context = context ; this . VAR_6 = METHOD_2 ( VAR_4 , STRING_1 , null , STRING_2 , 5 , VAR_7 ) ; }
TYPE_6 ( final TYPE_1 < TYPE_2 > VAR_2 , TYPE_3 VAR_3 , final TYPE_4 context , ANNOTATION_1 final TYPE_5 VAR_4 ) { this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; this . context = context ; this . VAR_6 = METHOD_2 ( VAR_4 , STRING_1 , null , STRING_2 , 5 , VAR_7 ) ; }
completeness invert / z
public static String METHOD_1 ( String VAR_1 ) { if ( VAR_1 . equalsIgnoreCase ( STRING_1 ) ) { return STRING_2 ; <START> } <END> StringBuilder VAR_2 = new StringBuilder ( INT_1 ) ; VAR_2 . METHOD_2 ( INT_1 ) ; METHOD_3 ( VAR_2 , - INT_2 - METHOD_4 ( VAR_1 ) ) ; return VAR_2 . toString ( ) ; }
public static String METHOD_1 ( String VAR_1 ) { if ( VAR_1 . equalsIgnoreCase ( STRING_1 ) ) { return STRING_2 ; } else if ( VAR_1 . equalsIgnoreCase ( STRING_2 ) ) { return STRING_1 ; } StringBuilder VAR_2 = new StringBuilder ( INT_1 ) ; VAR_2 . METHOD_2 ( INT_1 ) ; METHOD_3 ( VAR_2 , - INT_2 - METHOD_4 ( VAR_1 ) ) ; return VAR_2 . toString ( ) ; }
style - : spaces operators +
public void METHOD_1 ( ) throws TYPE_1 { db . create ( ) ; final TYPE_2 config = db . VAR_1 ( ) ; <START> METHOD_2 ( TYPE_3 . VAR_3 + STRING_1 , config . VAR_4 , <END> TYPE_4 . VAR_6 , 1 , 1 ) ; }
public void METHOD_1 ( ) throws TYPE_1 { db . create ( ) ; final TYPE_2 config = db . VAR_1 ( ) ; METHOD_2 ( STRING_1 , config . VAR_4 , TYPE_4 . VAR_6 , 1 , 1 ) ; }
please don t hold database connection 12 hours METHOD_1 close run method time execute borrowed a small pool keeping tied hours isn t friendly other threads JVM
public TYPE_9 ( TYPE_1 < TYPE_2 > VAR_2 , ANNOTATION_1 ( TYPE_8 . VAR_4 ) final TYPE_3 < TYPE_5 . TYPE_7 , TYPE_5 > cache ) throws TYPE_6 { <START> this . VAR_5 = VAR_2 . METHOD_1 ( ) . METHOD_2 ( ) ; <END> this . cache = cache ; }
public TYPE_9 ( TYPE_1 < TYPE_2 > VAR_2 , ANNOTATION_1 ( TYPE_8 . VAR_4 ) final TYPE_3 < TYPE_5 . TYPE_7 , TYPE_5 > cache ) { this . VAR_2 = VAR_2 ; this . cache = cache ; }
please don t initialize a local variable null instead leave uninitialized compiler prove correctly populated hiding a bug VAR_1 null database threw exception crash JSON encoder _CODE_ database fails return a default preference logging warning
public TYPE_1 METHOD_1 ( ) { <START> TYPE_1 VAR_1 = null ; <END> try { VAR_1 = VAR_2 . get ( ) . METHOD_2 ( ) . get ( METHOD_3 ( ) ) ; if ( VAR_1 == null ) { return TYPE_1 . METHOD_4 ( METHOD_3 ( ) ) ; } } catch ( TYPE_2 e ) { log . warn ( STRING_1 , e ) ; } return VAR_1 ; }
public TYPE_1 METHOD_1 ( ) { TYPE_1 VAR_1 ; try { VAR_1 = VAR_2 . get ( ) . METHOD_2 ( ) . get ( METHOD_3 ( ) ) ; if ( VAR_1 == null ) { VAR_1 = TYPE_1 . METHOD_4 ( METHOD_3 ( ) ) ; } } catch ( TYPE_2 e ) { log . warn ( STRING_1 , e ) ; VAR_1 = TYPE_1 . METHOD_4 ( METHOD_3 ( ) ) ; } return VAR_1 ; }
update ( ) method ensuring save preferences invoked key binding enter setup constructor
void METHOD_1 ( TYPE_1 event ) { update ( ) ; if ( TYPE_2 . METHOD_2 ( ) ) { <START> METHOD_3 ( ) ; <END> } }
void METHOD_1 ( TYPE_1 event ) { update ( ) ; }
I t reproduce failure update commit message explain condition don t a panel
private void METHOD_1 ( ) { if ( VAR_1 != - 1 ) { TYPE_1 VAR_2 = VAR_3 . get ( VAR_1 ) ; <START> if ( VAR_2 != null ) { <END> VAR_2 . METHOD_2 ( false ) ; } VAR_1 = - 1 ; } }
private void METHOD_1 ( ) { if ( VAR_1 != - 1 ) { TYPE_1 VAR_2 = VAR_3 . get ( VAR_1 ) ; VAR_2 . METHOD_2 ( false ) ; VAR_1 = - 1 ; } }
doesn t public default package access thee cache impl package
<START> public TYPE_3 ( TYPE_1 < TYPE_2 > VAR_2 ) { <END> this . VAR_2 = VAR_2 ; }
TYPE_3 ( TYPE_1 < TYPE_2 > VAR_2 ) { this . VAR_2 = VAR_2 ; }
doesn t public default package access thee cache impl package
<START> public TYPE_1 < TYPE_2 > METHOD_1 ( ) { <END> return VAR_1 ; }
TYPE_1 < TYPE_2 > METHOD_1 ( ) { return VAR_1 ; }
remove TYPE_3 private hacked class
public static TYPE_1 METHOD_1 ( TYPE_2 e ) { TYPE_1 VAR_1 = new TYPE_1 ( e . VAR_2 ( ) , e . VAR_3 ( ) , e . VAR_4 ( ) , e . VAR_5 ( ) ) ; <START> if ( e instanceof TYPE_3 ) { <END> TYPE_3 VAR_6 = ( TYPE_3 ) e ; List < TYPE_1 > VAR_7 = TYPE_1 . METHOD_2 ( VAR_6 . METHOD_3 ( ) ) ; VAR_1 = new TYPE_5 . TYPE_6 . VAR_8 . VAR_9 . VAR_10 . TYPE_3 ( VAR_1 , VAR_7 ) ; } return VAR_1 ; }
public static TYPE_1 METHOD_1 ( TYPE_2 e ) { TYPE_1 VAR_1 = new TYPE_1 ( e . VAR_2 ( ) , e . VAR_3 ( ) , e . VAR_4 ( ) , e . VAR_5 ( ) ) ; return VAR_1 ; }
VAR_2 doesn t res result r
public static List < TYPE_1 > METHOD_1 ( List < TYPE_2 > VAR_1 ) { ArrayList < TYPE_1 > VAR_2 = new ArrayList < TYPE_1 > ( VAR_1 . size ( ) ) ; for ( TYPE_2 e : VAR_1 ) { <START> VAR_2 . add ( METHOD_2 ( e ) ) ; <END> } return Collections . VAR_3 ( VAR_2 ) ; }
public static List < TYPE_1 > METHOD_1 ( List < TYPE_2 > VAR_1 ) { ArrayList < TYPE_1 > out = new ArrayList < TYPE_1 > ( VAR_1 . size ( ) ) ; for ( TYPE_2 e : VAR_1 ) { out . add ( METHOD_2 ( e ) ) ; } return Collections . VAR_3 ( out ) ; }
doesn t need public
<START> public TYPE_2 ( T object , TYPE_1 < T > VAR_2 ) { <END> buf = new byte [ VAR_2 . METHOD_1 ( object ) ] ; VAR_2 . METHOD_2 ( object , buf ) ; this . object = object ; this . VAR_2 = VAR_2 ; VAR_3 = object . VAR_4 ( ) ; }
TYPE_2 ( T object , TYPE_1 < T > VAR_2 ) { this . object = object ; this . VAR_2 = VAR_2 ; this . VAR_3 = object . VAR_4 ( ) ; }
doesn t need public
<START> public T METHOD_1 ( TYPE_1 < T > VAR_1 , TYPE_2 < T > VAR_2 ) { <END> if ( object == null ) { this . VAR_1 = VAR_1 ; if ( VAR_2 == null ) { object = VAR_1 . METHOD_2 ( buf ) ; } else { object = VAR_2 . get ( ) ; try { VAR_1 . METHOD_3 ( TYPE_3 . METHOD_4 ( buf ) , object ) ; } catch ( IOException e ) { throw new RuntimeException ( STRING_1 , e ) ; } } buf = null ; } return object ; }
T METHOD_1 ( TYPE_1 < T > VAR_1 , TYPE_2 < T > VAR_2 ) { if ( object == null ) { this . VAR_1 = VAR_1 ; if ( VAR_2 == null ) { object = VAR_1 . METHOD_2 ( buf ) ; } else { object = VAR_2 . get ( ) ; VAR_1 . METHOD_3 ( buf , object ) ; } buf = null ; } return object ; }
style - : put curly braces statement
private void METHOD_1 ( final List < TYPE_1 > VAR_1 , final TYPE_2 VAR_2 ) throws IOException { final String VAR_3 = VAR_2 . METHOD_2 ( ) ; String VAR_4 = VAR_2 . METHOD_3 ( ) ; <START> if ( VAR_4 == null ) VAR_4 = VAR_3 ; <END> final boolean VAR_5 = VAR_2 . METHOD_4 ( ) ; VAR_1 . add ( new TYPE_1 ( db , VAR_3 , VAR_4 , VAR_5 , null , null ) ) ; }
private void METHOD_1 ( final List < TYPE_1 > VAR_1 , final TYPE_2 VAR_2 ) throws IOException { final String VAR_3 = VAR_2 . METHOD_2 ( ) ; String VAR_4 = VAR_2 . METHOD_3 ( ) ; if ( VAR_4 == null ) { VAR_4 = VAR_3 ; } final boolean VAR_5 = VAR_2 . METHOD_4 ( ) ; VAR_1 . add ( new TYPE_1 ( db , VAR_3 , VAR_4 , VAR_5 , null , null ) ) ; }
doesn t need public
<START> public TYPE_3 ( <END> Collection < ? extends TYPE_1 < TYPE_2 > > that ) { super ( that ) ; }
TYPE_3 ( Collection < ? extends TYPE_1 < TYPE_2 > > that ) { super ( that ) ; }
doesn t need public
<START> public TYPE_3 ( TYPE_1 < TYPE_2 > ... that ) { <END> super ( that ) ; }
TYPE_3 ( TYPE_1 < TYPE_2 > ... that ) { super ( that ) ; }
style - : space I write code more cleanly : ( VAR_2 = = null || VAR_2 = = VAR_1 METHOD_3 ( ) ) { map put ( VAR_1 getId ( ) info ) ; }
private void METHOD_1 ( Map map , TYPE_1 VAR_1 , TYPE_2 info , Boolean VAR_2 ) { <START> if ( VAR_2 != null ) { <END> if ( VAR_2 . METHOD_2 ( ) != VAR_1 . METHOD_3 ( ) ) { return ; } } map . put ( VAR_1 . getId ( ) , info ) ; }
private void METHOD_1 ( Map map , TYPE_1 VAR_1 , TYPE_2 info , Boolean VAR_2 ) { if ( VAR_2 == null || VAR_2 == VAR_1 . METHOD_3 ( ) ) { map . put ( VAR_1 . getId ( ) , info ) ; } }
compare TYPE_2 ids
public void run ( ) { try { final TYPE_1 db = VAR_1 . METHOD_1 ( ) ; try { for ( final TYPE_2 project : db . VAR_2 ( ) . METHOD_2 ( ) ) { <START> if ( ! project . VAR_3 ( ) . equals ( VAR_4 . METHOD_3 ( ) ) ) { <END> VAR_5 . METHOD_4 ( project . VAR_3 ( ) , VAR_6 ) ; } } } finally { db . close ( ) ; } } catch ( TYPE_3 e ) { log . error ( STRING_1 , e ) ; } }
public void run ( ) { try { final TYPE_1 db = VAR_1 . METHOD_1 ( ) ; try { for ( final TYPE_2 project : db . VAR_2 ( ) . METHOD_2 ( ) ) { if ( ! project . getId ( ) . equals ( VAR_4 . getId ( ) ) ) { VAR_5 . METHOD_4 ( project . VAR_3 ( ) , VAR_6 ) ; } } } finally { db . close ( ) ; } } catch ( TYPE_3 e ) { log . error ( STRING_1 , e ) ; } }
getId ( ) instead
private Collection < TYPE_1 > METHOD_1 ( ) { <START> final TYPE_2 s = VAR_1 . get ( VAR_2 . METHOD_2 ( ) ) ; <END> return s != null ? s . VAR_3 ( ) : TYPE_3 < TYPE_1 > METHOD_3 ( ) ; }
private Collection < TYPE_1 > METHOD_1 ( ) { final TYPE_2 s = VAR_1 . get ( VAR_2 . getId ( ) ) ; return s != null ? s . VAR_3 ( ) : TYPE_3 < TYPE_1 > METHOD_3 ( ) ; }
I confusing put instead METHOD_7 ( RPC call ) ends another trigger create ( keyboard ) missed duplicated
private void METHOD_1 ( ) { VAR_1 = new TYPE_1 ( TYPE_5 . TYPE_6 . METHOD_2 ( ) ) ; VAR_1 . METHOD_3 ( false ) ; VAR_1 . METHOD_4 ( new TYPE_3 ( ) { @Override public void METHOD_5 ( final TYPE_4 event ) { <START> METHOD_6 ( false ) ; <END> METHOD_7 ( ) ; } } ) ; }
private void METHOD_1 ( ) { VAR_1 = new TYPE_1 ( TYPE_5 . TYPE_6 . METHOD_2 ( ) ) ; VAR_1 . METHOD_3 ( false ) ; VAR_1 . METHOD_4 ( new TYPE_3 ( ) { @Override public void METHOD_5 ( final TYPE_4 event ) { METHOD_7 ( ) ; } } ) ; }
[ optional ] return project _CODE_
<START> public String METHOD_1 ( ) { <END> return VAR_1 ; }
public String METHOD_1 ( ) { return VAR_1 != null ? VAR_1 . get ( ) : null ; }
easier read : ( VAR_2 = = null ) VAR_2 = ;
private void METHOD_1 ( final TYPE_1 VAR_1 ) { TYPE_2 . add ( new TYPE_3 ( ) { public void execute ( ) { String VAR_2 = VAR_3 . get ( VAR_1 ) ; <START> VAR_2 = VAR_2 == null ? "" : VAR_2 ; <END> if ( ! VAR_2 . equals ( VAR_1 . METHOD_2 ( ) ) ) { VAR_4 . METHOD_3 ( true ) ; } } } ) ; }
private void METHOD_1 ( final TYPE_1 VAR_1 ) { TYPE_2 . add ( new TYPE_3 ( ) { @Override public void execute ( ) { String VAR_2 = VAR_3 . get ( VAR_1 ) ; if ( VAR_2 == null ) { VAR_2 = "" ; } if ( ! VAR_2 . equals ( VAR_1 . METHOD_2 ( ) ) ) { VAR_4 . METHOD_3 ( true ) ; } } } ) ; }
need METHOD_4 ( ) ;
private void METHOD_1 ( final TYPE_2 . TYPE_3 VAR_1 ) { if ( VAR_2 != null ) { for ( int i = 0 ; i < VAR_2 . METHOD_2 ( ) ; i ++ ) { if ( VAR_1 . name ( ) . equals ( VAR_2 . getValue ( i ) ) ) { <START> VAR_2 . METHOD_3 ( i ) ; <END> return ; } } VAR_2 . METHOD_3 ( - 1 ) ; METHOD_4 ( ) ; } }
private void METHOD_1 ( final TYPE_2 . TYPE_3 VAR_1 ) { int index = - 1 ; if ( VAR_2 != null ) { for ( int i = 0 ; i < VAR_2 . METHOD_2 ( ) ; i ++ ) { if ( VAR_1 . name ( ) . equals ( VAR_2 . getValue ( i ) ) ) { index = i ; break ; } } VAR_2 . METHOD_3 ( index ) ; METHOD_4 ( ) ; } }
passing a null allowed a clear box
<START> public void METHOD_1 ( final TYPE_2 . TYPE_3 VAR_1 ) { <END> VAR_2 . setText ( VAR_1 . get ( ) ) ; }
public void METHOD_1 ( final TYPE_2 . TYPE_3 VAR_1 ) { VAR_2 . setText ( VAR_1 != null ? VAR_1 . get ( ) : "" ) ; }
done line 247 avoiding need else
private void METHOD_1 ( final TYPE_1 config ) throws TYPE_2 , TYPE_3 { final TYPE_4 VAR_1 ; if ( VAR_2 != null ) { final TYPE_5 VAR_3 = VAR_4 . get ( VAR_2 ) ; if ( VAR_3 == null ) { throw new TYPE_3 ( VAR_2 ) ; } VAR_1 = VAR_3 . METHOD_2 ( ) ; } else { <START> VAR_1 = null ; <END> } VAR_5 . create ( Collections . VAR_6 ( config . VAR_7 ( ) ) , VAR_1 ) . METHOD_3 ( ) ; config . VAR_7 ( ) . METHOD_4 ( VAR_2 ) ; }
private void METHOD_1 ( final TYPE_1 config ) throws TYPE_2 , TYPE_3 { TYPE_4 VAR_1 = null ; if ( VAR_2 != null ) { final TYPE_5 VAR_3 = VAR_4 . get ( VAR_2 ) ; if ( VAR_3 == null ) { throw new TYPE_3 ( VAR_2 ) ; } VAR_1 = VAR_3 . METHOD_2 ( ) ; } VAR_5 . create ( Collections . VAR_6 ( config . VAR_7 ( ) ) , VAR_1 ) . METHOD_3 ( ) ; config . VAR_7 ( ) . METHOD_4 ( VAR_2 ) ; }
statement inlined
private void METHOD_1 ( ) throws IOException , TYPE_1 { project = VAR_1 . METHOD_2 ( ) . METHOD_3 ( ) ; try { repo = VAR_2 . METHOD_4 ( project . VAR_3 ( ) ) ; } catch ( TYPE_2 e ) { <START> final String name = project . getName ( ) ; <END> throw new TYPE_1 ( 1 , STRING_1 + name + STRING_2 , e ) ; } try { METHOD_5 ( ) ; } finally { repo . close ( ) ; } }
private void METHOD_1 ( ) throws IOException , TYPE_1 { project = VAR_1 . METHOD_2 ( ) . METHOD_3 ( ) ; try { repo = VAR_2 . METHOD_4 ( project . VAR_3 ( ) ) ; } catch ( TYPE_2 e ) { throw new TYPE_1 ( 1 , STRING_1 + project . getName ( ) + STRING_2 , e ) ; } try { METHOD_5 ( ) ; } finally { repo . close ( ) ; } }
need initialize variable branch directions assign variable discard HashSet
public Set < TYPE_2 . TYPE_3 > METHOD_1 ( ) { if ( VAR_1 == null ) { <START> Set < TYPE_2 . TYPE_3 > VAR_2 = new HashSet < TYPE_2 . TYPE_3 > ( ) ; <END> if ( VAR_3 . METHOD_2 ( state ( ) . METHOD_3 ( ) ) ) { VAR_2 = VAR_4 . METHOD_4 ( state ( ) ) ; } else { VAR_2 = VAR_3 . METHOD_5 ( ) ; } VAR_1 = METHOD_6 ( VAR_2 ) ; } return VAR_1 ; }
public Set < TYPE_2 . TYPE_3 > METHOD_1 ( ) { if ( VAR_1 == null ) { Set < TYPE_2 . TYPE_3 > VAR_2 ; if ( VAR_3 . METHOD_2 ( state ( ) . METHOD_3 ( ) ) ) { VAR_2 = VAR_4 . METHOD_4 ( state ( ) ) ; } else { VAR_2 = VAR_3 . METHOD_5 ( ) ; } VAR_1 = METHOD_6 ( VAR_2 ) ; } return VAR_1 ; }
VAR_2 clear ( )
public void METHOD_1 ( TYPE_1 VAR_1 ) { <START> VAR_2 . remove ( 0 ) ; <END> switch ( VAR_1 ) { case VAR_3 : VAR_2 . add ( new TYPE_2 ( ) ) ; break ; case VAR_4 : VAR_2 . add ( VAR_5 ) ; break ; case VAR_6 : VAR_2 . add ( VAR_7 ) ; break ; case VAR_8 : VAR_2 . add ( VAR_9 ) ; break ; case VAR_10 : VAR_2 . add ( VAR_11 ) ; break ; } }
public void METHOD_1 ( TYPE_1 VAR_1 ) { VAR_2 . clear ( ) ; switch ( VAR_1 ) { case VAR_4 : VAR_2 . add ( VAR_5 ) ; break ; case VAR_6 : VAR_2 . add ( VAR_7 ) ; break ; case VAR_8 : VAR_2 . add ( VAR_9 ) ; break ; case VAR_10 : VAR_2 . add ( VAR_11 ) ; break ; } }
pref : unneeded else
private String METHOD_1 ( ) { if ( VAR_1 != null ) { if ( VAR_1 . METHOD_2 ( ) != null ) { return VAR_1 . METHOD_2 ( ) ; <START> } else { <END> return VAR_1 . METHOD_3 ( ) . toString ( ) ; } } else { return VAR_2 . getName ( ) ; } }
private String METHOD_1 ( ) { if ( VAR_1 != null ) { if ( VAR_1 . METHOD_2 ( ) != null ) { return VAR_1 . METHOD_2 ( ) ; } return VAR_1 . METHOD_3 ( ) . toString ( ) ; } return VAR_2 . getName ( ) ; }
pref : eliminate return boolean evaluation
<START> public static boolean METHOD_1 ( final TYPE_4 . TYPE_7 VAR_1 ) { <END> if ( TYPE_4 . TYPE_6 . equals ( VAR_1 ) || TYPE_4 . TYPE_5 . equals ( VAR_1 ) ) { return false ; } return true ; }
public static boolean METHOD_1 ( final TYPE_4 . TYPE_7 VAR_1 ) { return ! ( TYPE_4 . TYPE_6 . equals ( VAR_1 ) || TYPE_4 . TYPE_5 . equals ( VAR_1 ) ) ; }
declare package access
<START> public TYPE_1 ( ) { <END> super ( TYPE_2 . this . VAR_3 , TYPE_2 . VAR_4 . VAR_5 ) ; }
TYPE_1 ( ) { super ( TYPE_2 . VAR_4 . VAR_3 , TYPE_2 . VAR_4 . VAR_5 ) ; }
I m accuracy necessary web UI side need user owner a local VAR_1 order edit
public boolean METHOD_1 ( TYPE_1 VAR_1 ) { <START> return TYPE_2 . METHOD_2 ( METHOD_3 ( ) , VAR_1 . METHOD_4 ( ) ) ; <END> }
public boolean METHOD_1 ( TYPE_1 VAR_1 ) { return METHOD_3 ( ) . contains ( VAR_1 . METHOD_4 ( ) ) ; }
subclasses allowed override method
<START> protected TYPE_1 commit ( final TYPE_2 m , final TYPE_3 VAR_1 ) <END> throws IOException , TYPE_4 { TYPE_5 VAR_2 = m . VAR_3 ( ) ; try { TYPE_1 id = VAR_2 . METHOD_1 ( VAR_1 ) ; VAR_2 . METHOD_2 ( ) ; return id ; } finally { VAR_2 . METHOD_3 ( ) ; } }
protected final TYPE_1 commit ( final TYPE_2 m , final TYPE_3 VAR_1 ) throws IOException , TYPE_4 { TYPE_5 VAR_2 = m . VAR_3 ( ) ; try { TYPE_1 id = VAR_2 . METHOD_1 ( VAR_1 ) ; VAR_2 . METHOD_2 ( ) ; return id ; } finally { VAR_2 . METHOD_3 ( ) ; } }